10 lines
591 B
Plaintext
10 lines
591 B
Plaintext
Please add unit tests for the new count-only functionality.
|
|
|
|
line 43 def matchmake:
|
|
This was making redundant calls to regex matching functions and so could be slower than necessary. I suggest changes that use the walrus operator to keep the same logical structure without the redundant calls.
|
|
|
|
|
|
line 212 def __init__:
|
|
|
|
Minor note: This constructor is taking a lot of arguments. This is fine, but from a style + maintainability perspective it might make sense to create a new class for the regex matching configuration and pass a configuration object to this contructor instead.
|