code review.

This commit is contained in:
2023-05-03 10:23:30 -07:00
parent 54fa6221a8
commit 933ca753ed
3 changed files with 22 additions and 16 deletions

9
code_review_notes.txt Normal file
View File

@@ -0,0 +1,9 @@
Please add unit tests for the new count-only functionality.
line 43 def matchmake:
This was making redundant calls to regex matching functions and so could be slower than necessary. I suggest changes that use the walrus operator to keep the same logical structure without the redundant calls.
line 212 def __init__:
Minor note: This constructor is taking a lot of arguments. This is fine, but from a style + maintainability perspective it might make sense to create a new class for the regex matching configuration and pass a configuration object to this contructor instead.