Yes, but you need to populate that table from /somewhere/.  :-)
API is per wiki. toolserver.wiki is a meta table.
(In reply to comment #4)
> In addition, I think we should only rely on MediaWiki's API for this
> information (with user authentication, as necessary).

This is particularly important in that some extensions may have hard-to-evaluate effect on some configuration values (namespaces and usergroups being the more obvious cases).

I should say that any necessary configuration value that cannot be fetched through the API should be /added/ to the API rather than fetched through an alternative scheme.

-- Marc
I think we should have a discussion about what the current "toolserver" database is, what we want in the future, and whether we care about breaking backward compatibility.

Some of the design decisions in some of the database tables could probably be re-thought, but only if we're willing to break the current interfaces.

In addition, I think we should only rely on MediaWiki's API for this information (with user authentication, as necessary). This is the cleanest and sanest way to accurately get this information, as far as I know.
Do we want a database table consisting of three columns: wiki, config_variable_name, and config_variable_value (as a serialized blob)?
(In reply to comment #1)
> Played around with:
> 
> | include ($MediaWikiRepoPath . "/includes/Defines.php");
> | include ($WmfConfigRepoPath . "/wmf-config/InitialiseSettings.php");
> | var_dump ($wgConf->settings);
> 
> but it doesn't yield for example information about de.wikipedia.org.

Some experiments:

$ php maintenance/eval.php 
> $wgDBname='zhwiki';

> $wmfRealm='production';

> $mwConfigDir="$IP/../operations/mediawiki-config";

> $wmfConfigDir="$mwConfigDir/wmf-config";

> function getRealmSpecificFilename($p){global $IP,$wmfConfigDir;return str_replace($p,$IP,$wmfConfigDir);}

> function wmfLoadInitialiseSettings($c){global $wmfConfigDir;require("$wmfConfigDir/InitialiseSettings.php");}

> require("$wmfConfigDir/wgConf.php");

> list($site,$lang)=$wgConf->siteFromDB($wgDBname);

> $wikiTags=array();

> $mwConfigDirHandle=opendir($mwConfigDir);

> while(($f=readdir($mwConfigDirHandle))!==false){if(pathinfo($f,PATHINFO_EXTENSION)==='dblist'&&in_array($wgDBname,array_map('trim',file("$mwConfigDir/$f")))){$wikiTags[]=pathinfo($f,PATHINFO_FILENAME);}}

> $dbSuffix = ( $site === 'wikipedia' ) ? 'wiki' : $site;

> $wgConf->loadFullData();

> $globals = $wgConf->getAll( $wgDBname, $dbSuffix,array('lang'    => $lang,'site'    => $site,'stdlogo' => "//upload.wikimedia.org/$site/$lang/b/bc/Wiki.png"), $wikiTags );

> print_r($globals);
Array
(
    [wgLegacyEncoding] => 
    [wgCapitalLinks] => 1
    ...
)

>
Played around with:

| include ($MediaWikiRepoPath . "/includes/Defines.php");
| include ($WmfConfigRepoPath . "/wmf-config/InitialiseSettings.php");
| var_dump ($wgConf->settings);

but it doesn't yield for example information about de.wikipedia.org.
There are now at least three ways to edit a page via index.php (not including other crazy things like Wikidata). I couldn't find a bug tracking this user experience issue, so I'm filing this one.

The three ways I'm initially focused on are:

* directly editing the wikitext (which can appear as an "edit source" page tab when VisualEditor is enabled);
* VisualEditor [https://www.mediawiki.org/wiki/VisualEditor]; and
* CodeEditor [https://www.mediawiki.org/wiki/Extension:CodeEditor] (automatic for pages in the Module namespace and soon the CSS/JS pages as well; has a toggle in the edit toolbar).

In particular to switch to editing the source, I'm worried about divergent approaches in the user interface. For example, a page tab v. a toggle in the edit toolbar.

--------------------------
**Version**: wmf-deployment
**Severity**: normal
Slightly unclear what the bug to fix is here (and hence when it can be considered fixed). Could you elaborate?
oh, and we can also add wikEd to that list :D
VE drops things like <i></i>, which Parsoid sometimes uses to preserve strange things.

I think a solution might be to store this as an inline node or as a meta item.

--------------------------
**Version**: unspecified
**Severity**: normal
This works for single annotations, but not for nested ones. See https://gerrit.wikimedia.org/r/#/c/69343/ for a failing test case.
Split new items out to bug 49497; closing this one.
Above change fixes issue with annotations being dropped, but we still need to fix empty annotations not rendering (e.g. <span style="display: block; background: red; width: 100px; height: 100px;"></span>), either here or in a new bug.
Related URL: https://gerrit.wikimedia.org/r/68213 (Gerrit Change I0f3a194f629b054f193a61af105733a555775d79)
That would be nice, yes, but I don't think it's critically important.
(Actually it's a yes/no question, both cases relate to the same behaviour.)
(In reply to comment #1)
> Should the inline node disappear if saved next to similarly annotated text,
> 
> e.g.
> '<i><emptyAnnotation /></i><i>Foo</i>' => '<i>Foo</i>'
> 
> or more complex:
> 
> '<i><emptyAnnotation /></i><b><i>Foo</i></b>' => '<i><emptyAnnotation
> /><b>Foo</b></i>'
> ?

I believe the latter, but Roan was going to answer this.
Should the inline node disappear if saved next to similarly annotated text,

e.g.
'<i><emptyAnnotation /></i><i>Foo</i>' => '<i>Foo</i>'

or more complex:

'<i><emptyAnnotation /></i><b><i>Foo</i></b>' => '<i><emptyAnnotation /><b>Foo</b></i>'
?
--------------------------
**Version**: unspecified
**Severity**: minor
Merged and will go out with wmf5.
Related URL: https://gerrit.wikimedia.org/r/64484 (Gerrit Change Ia2a2120cb75aa86374b594ae3f484c5161028919)
Throws an exception on line 564 of ve.ce.Surface, ve.getWindow is undefined.

--------------------------
**Version**: unspecified
**Severity**: normal
Merged in master; will go out as part of wmf5.
Related URL: https://gerrit.wikimedia.org/r/64483 (Gerrit Change I31dc071328123b57b778aa1b21f0e1daf6405e5c)
'Review and save' is enabled on loading an old version of a page (as it should) but becomes disabled briefly after the first transaction is committed, and again if you undo to the top of the stack.

--------------------------
**Version**: unspecified
**Severity**: normal
Merged; will go out with wmf5.
Related URL: https://gerrit.wikimedia.org/r/64372 (Gerrit Change I67c011ac655d4e553f9467cab10a875aaac61d03)
When "deselecting" the text field of the visual editor (e.g. by clicking into the summary field) it seems to somehow loose focus.

It's then not possible to directly select text (with the mouse) anymore. One needs to first click one time into the text field to be able to normally select text again.

--------------------------
**Version**: unspecified
**Severity**: minor
I d'not know why I ever wrote VisualEditor but this definitely is about CodeEditor. And it definitely is fixed now!

Thanks for bringing it up again (I remember you adding the PATCH_TO_REVIEW) but it wasn't merged back then so I couldn't test if the bug was really fixed) so we can close it for good.
Wait, this is in the CodeEditor extension group, but people are talking about the 'visual editor'. Did the reporter originally file it under the wrong Extension ?

Eduard, can you clarify please ?
This seems fixed with: https://gerrit.wikimedia.org/r/104510
Is this the same issue as bug 50722?
I think I can replicate this bug, but I'm not sure I entirely understand the whole problem.

If I select some text in the CodeEditor box, then click into another input element on the page to move focus there, then click back into to the CodeEditor, the cursor position within the text area does not change to the place I just clicked at and the selected text remains selected. I would expect it to deselect all text and move the cursor position to where the mouse cursor is. Major -> Minor
I'm using Firefox 21 on Windows 7.
Could you please provide browser information?
It should only appear when you're matching to a single, extant category - it doesn't appear for a new category, but appears (with no content) where you match more than one, which is confusing.

--------------------------
**Version**: unspecified
**Severity**: minor
This is fixed.
It's a no-op, and is confusing. (But is it more confusing to list it?)

--------------------------
**Version**: unspecified
**Severity**: enhancement
https://gerrit.wikimedia.org/r/68130 (Gerrit Change If48e001b92c217bee0a35b6da41d1c1ff0e3271c) | change APPROVED and MERGED [by jenkins-bot]
Related URL: https://gerrit.wikimedia.org/r/68130 (Gerrit Change If48e001b92c217bee0a35b6da41d1c1ff0e3271c)
Related URL: https://gerrit.wikimedia.org/r/68130 (Gerrit Change If48e001b92c217bee0a35b6da41d1c1ff0e3271c)
Now merged.
Related URL: https://gerrit.wikimedia.org/r/67922 (Gerrit Change I93ce05f7cbb28313a3f0827539f0528c366aeb7e)
Investigate how mw.hook could be useful for GuidedTour.  One idea is subscribing to state changes for shouldSkip.  For instance, UploadWizard has an AJAX-type interface where you go from step to step without changing pages.

If we could listen to those steps, we could trigger the shouldSkip check (by calling guiders.resume or maybe another method that only checks this).

--------------------------
**Version**: master
**Severity**: enhancement
Change 116228 merged by jenkins-bot:
Refactor and add non-linear tours, with tests

https://gerrit.wikimedia.org/r/116228
Change 116228 had a related patch set uploaded by Mattflaschen:
WIP: Refactor and add non-linear tours, with tests

https://gerrit.wikimedia.org/r/116228
This is done for VisualEditor.  I made this a tracking bug, and opened a separate one (bug 51985) for UploadWizard.
I'm working on a change set right now that uses mw.hook for VE like this.
We now have nginx SSL proxies in front of the beta caches (Bug T38648). We still have to fix the certificate (that is *.wmflabs.org for now).

We need certificates generated by 'Labs CA' for the entries listed in role::protoproxy::ssl::beta and some more.  I guess the easiest would be to create *.beta.wmflabs.org cert that will also contains the following DNS entries:

*.wikimedia.beta.wmflabs.org
*.wikibooks.beta.wmflabs.org
*.wikinews.beta.wmflabs.org
*.wikipedia.beta.wmflabs.org
*.wikiquote.beta.wmflabs.org
*.wikisource.beta.wmflabs.org
*.wikiversity.beta.wmflabs.org
*.wikivoyage.beta.wmflabs.org
*.wiktionary.beta.wmflabs.org

And the mobile ones:

*.m.wikimedia.beta.wmflabs.org
*.m.wikibooks.beta.wmflabs.org
*.m.wikinews.beta.wmflabs.org
*.m.wikipedia.beta.wmflabs.org
*.m.wikiquote.beta.wmflabs.org
*.m.wikisource.beta.wmflabs.org
*.m.wikiversity.beta.wmflabs.org
*.m.wikivoyage.beta.wmflabs.org
*.m.wiktionary.beta.wmflabs.org

*.zero.wikipedia.beta.wmflabs.org

**See Also**:
{T56065}
{T70387}
{T71269}
Can this ticket be made public nowadays?  There is now T182927 and it seemed like a duplicate.

Edit: ignore this, this comment was meant to be on T97593)
Can this ticket be made public nowadays?  There is now T182927 and it seemed like a duplicate.
Thanks to @Krenair (with reviews from @BBlack ) we got SSL on beta cluster.  That is quite an achievement.

The last remaining patch has been merged in. I believe there is nothing left to do there.
Change 247587 merged by BBlack:
beta: Use Let's Encrypt cert

[[https://gerrit.wikimedia.org/r/247587]]
So that is now pending review / merge of https://gerrit.wikimedia.org/r/247587 //beta: Use Let's Encrypt cert// which is already on beta cluster.
Convince someone with ops rights to merge the patch
That is really neat @AlexMonk-WMF !  Is there anything left to do?
Change 302409 merged by jenkins-bot:
deployment-prep: Swap config to HTTPS

[[https://gerrit.wikimedia.org/r/302409]]
Change 302409 had a related patch set uploaded (by Alex Monk):
deployment-prep: Swap config to HTTPS

[[https://gerrit.wikimedia.org/r/302409]]
Change 247587 had a related patch set uploaded (by Alex Monk):
beta: Use Let's Encrypt for upload, and new self-signed SSL certificate for most of text

[[https://gerrit.wikimedia.org/r/247587]]
This is now working for meta.wikimedia.beta.wmflabs.org and deployment.wikimedia.beta.wmflabs.org (and their mobile variants) as well as upload.beta.wmflabs.org. I'll try to handle all other domains tomorrow.
This is now working for meta.wikimedia.beta.wmflabs.org and deployment.wikimedia.beta.wmflabs.org (and their variants) as well as upload.beta.wmflabs.org. I'll try to handle all other domains tomorrow.
Its puppetized now, should not be hard anymore. We already use it in prod.
It may or may not be a strict blocker but we should probably wait for {T132812}
>>! In T50501#2210861, @csteipp wrote:
> Ftr, I'd love to see us move in the direction of the let's encrypt model, where it's a straightforward, automated process for servers to get a valid cert for their identity. Whether it's LE specifically, or one of the projects that makes an LE-like api that organizations can run to automatically get certificates from their preferred CA.
> 
> I think we're going to need more of these (mysql and kafka servers / clients in the near term), and I'd like to get to the point where we're dealing with short lived certs wherever possible.

That might be hard as we're not exposing those servers directly to the internet. I suppose we could use an internal CA and run our own Let's Encrypt-like setup, but this is all far outside the scope of this task :)
>>! In T50501#2210736, @Krenair wrote:
>>>! In T97593#2115226, @Krenair wrote:
>> I am also wondering what the best way is to put the Let's Encrypt client onto the beta servers. Could we install it on the deployment-cache-text04 and deployment-cache-upload04 instances and have them get their own certificates? They're all running jessie and there is a letsencrypt package available.

Ftr, I'd love to see us move in the direction of the let's encrypt model, where it's a straightforward, automated process for servers to get a valid cert for their identity. Whether it's LE specifically, or one of the projects that makes an LE-like api that organizations can run to automatically get certificates from their preferred CA.

I think we're going to need more of these (mysql and kafka servers / clients in the near term), and I'd like to get to the point where we're dealing with short lived certs wherever possible.
>>! In T97593#2115226, @Krenair wrote:
> I am also wondering what the best way is to put the Let's Encrypt client onto the beta servers. Could we install it on the deployment-cache-text04 and deployment-cache-upload04 instances and have them get their own certificates? They're all running jessie and there is a letsencrypt package available.

>>! In T97593#2116454, @Krenair wrote:
> I checked this in deployment-cache-upload04 today. It's from jessie-backports and depends on lots of things from there, so you end up with something like:
> `sudo apt-get install letsencrypt python-cryptography=1.1.1-1~bpo8+1 python-pyasn1=0.1.9-1~bpo8+1 python-openssl=0.15.1-2~bpo8+1`
> (I did not actually allow this to continue, would like someone else to review since I'm not used to messing with package versions like this)

>>! In T97593#2210712, @Krenair wrote:
> ops have started using it in production for (ubuntu|apt|mirrors).wikimedia.org and it might be puppetised soon. (see T132450)
>>! In T97593#2115226, @Krenair wrote:
> I am also wondering what the best way is to put the Let's Encrypt client onto the beta servers. Could we install it on the deployment-cache-text04 and deployment-cache-upload04 instances and have them get their own certificates? They're all running jessie and there is a letsencrypt package available.

>>! In T97593#2116454, @Krenair wrote:
> I checked this in deployment-cache-upload04 today. It's from jessie-backports and depends on lots of things from there, so you end up with something like:
> `sudo apt-get install letsencrypt python-cryptography=1.1.1-1~bpo8+1 python-pyasn1=0.1.9-1~bpo8+1 python-openssl=0.15.1-2~bpo8+1`
> (I did not actually allow this to continue, would like someone else to review since I'm not used to messing with package versions like this)
I'm going around a few tasks on this subject trying to merge/close everything together (this one, T70387, T75919, T97593). I'm going to see if I can get Let's Encrypt working for this.
I'm going around a few tasks on this subject trying to merge everything together (this one, T70387, T75919, T97593). I'm going to see if I can get Let's Encrypt working for this.
>>! In T50501#1951388, @faidon wrote:
> Can someone repeat why we can't just flatten the beta hostnames and just procure a *.beta.wmflabs.org certificate?

Presumably because that would make beta less similar to production and less useful for testing things where the domain structure is relevant (e.g. CentralAuth shared cookies).
>>! In T50501#527689, @Krinkle wrote:
> Would it be an option to flatten our subdomains?
> 
> We'd only need beta.wmflabs.org and *.beta.wmflabs.org to be in the certificate
> 
> (at e.g. DigiCert, those wildcards are $1425 for 3 years includes root and *)
> 
> For example:
> 
> * beta.wmflabs.org
> * bits.beta.wmflabs.org
> * wikimedia.beta.wmflabs.org
> * commons-wikimedia.beta.wmflabs.org
> * wikipedia.beta.wmflabs.org
> * en-wikipedia.beta.wmflabs.org
> * nl-wikibooks.beta.wmflabs.org
> * en-m-wikibooks.beta.wmflabs.org
> * en-m-wikinews.beta.wmflabs.org

I've asked the same a few times and I don't remember the response. Can someone repeat why we can't just flatten the beta hostnames and just procure a *.beta.wmflabs.org certificate?
Yeah, beta.wmflabs.org was in the private beta. Don't know if it can actually work with our setup though.
Let's Encrypt is in Public Beta now. Everyone can get free certificates from them now.

[1] https://letsencrypt.org/2015/12/03/entering-public-beta.html
[2] User Guide for getting certs using Let's Encrypt client: https://letsencrypt.readthedocs.org/en/latest/
>>! In T50501#1669896, @Chmarkine wrote:
> [[ https://letsencrypt.org/ | Let's Encrypt ]] provides free trusted(*) DV non-wildcard certs. We have 31 domains lists [[ http://meta.wikimedia.beta.wmflabs.org/wiki/Special:SiteMatrix | here ]]. If you think it's plausible, we can obtain 31 certs (one for each domain) from Let's Encrypt at zero cost. 
> 
> (*) They will have their CA certificate cross-signed by IdenTrust next month, so the certs they issued won't be trusted until then.

Let's Encrypt has received the cross-signature, so its certificates are now trusted by all major browsers.

[1] https://letsencrypt.org/2015/10/19/lets-encrypt-is-trusted.html
>>! In T50501#1670596, @Lixxx235 wrote:
> Chmarkine, there's always StartCom/StartSSL which has free certs, and they're already trusted by default in all major browsers. 

Yes. But StartCom charges $24.9 for each certificate revocation.

https://www.startssl.com/?app=43
>>! In T50501#1670596, @Lixxx235 wrote:
> Chmarkine, there's always StartCom/StartSSL which has free certs, and they're already trusted by default in all major browsers. 

Yes. But StartCom charges $25 for each certificate revocation.
Chmarkine, there's always StartCom/StartSSL which has free certs, and they're already trusted by default in all major browsers.
I think we'd also want upload.beta.wmflabs.org, maybe stream.wmflabs.org, all of the m./zero. variants? What about mx.beta.wmflabs.org?
[[ https://letsencrypt.org/ | Let's Encrypt ]] provides free trusted(*) DV non-wildcard certs. We have 31 domains lists [[ http://meta.wikimedia.beta.wmflabs.org/wiki/Special:SiteMatrix | here ]]. If you think it's plausible, we can obtain 31 certs (one for each domain) from Let's Encrypt at zero cost. 

(*) They will have their CA certificate cross-signed by IdenTrust next month, so the certs they issued won't be trusted until then.
one more reason we should have this is to avoid needing https://gerrit.wikimedia.org/r/237523  (T105794, T112195)
@ArielGlenn: there's an NDA'd task at T97593 which Brandon is driving.
@ArielGlenn: there's an NDA's task at T97593 which Brandon is driving.
@greg  so what's the decision; there's also https://phabricator.wikimedia.org/T75919 and https://phabricator.wikimedia.org/T70387   Self-signed certs in beta or not?
Is T70387 a duplicate of this?
(In reply to Matthew Flaschen from comment #93)
> If cost is the issue, did we consider setting up our own certificate
> authority (chained to an existing root)?  It's an upfront cost, but as I
> understand it that means no per-cert cost.
> 
> Google and Microsoft both have them, just to name a couple.

Getting a delegated signing certificate is a huge deal actually. Once you have one, any certificate you sign is trusted by all who trust your upstream signer. The x509 protocol does not make it possible to construct a trusted signing certificate that is restricted to a particular domain. As such, any trusted signer who issues delegate signing certificates must impose strict practices and regular audits of those practices on any delegate organization.
I can think of three significant problems with self-signed certificates:

1. It trains people to ignore SSL warnings, which means they ignore them when it's a legit problem.
2. It causes problems with automated tests (not clear if all of these have been worked around).
3. It's a real pain when testing manually because you have to visit https://bits.beta.wmflabs.org/ (and maybe also upload.beta.wmflabs.org) manually in Firefox.

FWIW, https://en.wikipedia.beta.wmflabs.org isn't working at all (not even invalid) right now (can't connect), but I assume that's temporary

If cost is the issue, did we consider setting up our own certificate authority (chained to an existing root)?  It's an upfront cost, but as I understand it that means no per-cert cost.

Google and Microsoft both have them, just to name a couple.
This bug seems to be drifted away from the initial comment.
(In reply to Antoine "hashar" Musso from comment #0)
> We need certificates generated by 'Labs CA' for the entries listed in
> role::protoproxy::ssl::beta and some more.  I guess the easiest would be to
> create *.beta.wmflabs.org cert that will also contains the following DNS
> entries:

So

(In reply to Greg Grossmeier from comment #91)
> Won't Fix'ing this for now.
> A) We have self-signed certs in place on Beta

We still don't have valid self-signed certs for beta since eqiad migration as far as I know. At least nginx refuses to starts because of cert mismatch. As I was told in bug 63538 that this (certs) is handled here, I REOPEN. Please generate new (self-signed) certs.
Won't Fix'ing this for now.

A) We have self-signed certs in place on Beta
B) Real certs are expensive
C) There hasn't been any team come with a specific use case where buying the real certs would make sense.

Feel free to reopen if any of the above changes.
> I'm afraid it can't and *.wmflabs.org is not *.beta.wmflabs.org (only one
> level of wildcard possible). But ask RobH to make sure.

Ah indeed my bad. Sorry :-]
(In reply to Antoine "hashar" Musso from comment #86)
star.wmflabs.org would cover the entries:

 bits.beta.wmflabs.org
 upload.beta.wmflabs.org
 wikidata.beta.wmflabs.org

I'm afraid it can't and *.wmflabs.org is not *.beta.wmflabs.org (only one level of wildcard possible). But ask RobH to make sure.
for *.wmflabs.org, the self-signed cert has recently been replaced with one from RapidSSL , at first the chained file, which is created by puppet was wrong, the above changes should have fixed that.
https://gerrit.wikimedia.org/r/#/c/111386/
https://gerrit.wikimedia.org/r/#/c/126008/1
The beta cluster has for Varnish instances with a Nginx HTTPS proxy installed.  Nginx refuses to start because the star.wmflabs.org certificate is invalid:

root@deployment-cache-bits01:~# /etc/init.d/nginx start
Starting nginx: nginx: [emerg]
  SSL_CTX_use_PrivateKey_file("/etc/ssl/private/star.wmflabs.org.key")
  failed (SSL: error:0B080074:x509 certificate routines:X509_check_private_key:key values mismatch)
 nginx: configuration file /etc/nginx/nginx.conf test failed


To fix it we would need a few certificates to be installed on the instances via the role::protoproxy::ssl::beta puppet class in manifests/role/protoproxy.pp

star.wmflabs.org would cover the entries:

 bits.beta.wmflabs.org
 upload.beta.wmflabs.org
 wikidata.beta.wmflabs.org

We would need *.wikimedia.beta.wmflabs.org and *.wikipedia.beta.wmflabs.org certs as well.
(In reply to Greg Grossmeier from comment #84)
> * Setup was(is?) annoying because of the lack of easy way to secure these
> private certs from other non-WMF root labs users.

I thought comment 65 and comment 67 said the "access to private keys without an NDA" part was solved.

Antoine said he did the sudo configuration (see comment 67); I'm not sure if it's checked yet.
(Lowering priority and unassigning from self)

Status, afaict:
* Price was annoying, but we've identified the 7 we want (comment 77, comment 79, and comment 83).
* Setup was(is?) annoying because of the lack of easy way to secure these private certs from other non-WMF root labs users.

Marc/RobH: Let me know if I have that wrong and if there's anything else we can do right now.
wikidata.beta.wmflabs.org might be nice, since I know a few gadgets go cross domain to it.

I think the dewiki community also wanted to have de.wikipedia.beta.wmflabs.org, but unless we get a discount for buying them at one time, it would probably be good to wait until we have browser tests running against that wiki.
(In reply to Greg Grossmeier from comment #80)

> 
> For the avoidance of doubt: we're not doing them all, just a subset. SSL
> certs are a racket and expensive.

Oh, missed that above. Makes sense :)
Yeah, we can't do all; we can't even reasonably all the necessary wildcards to cover the whole matrix.

I have six now; any more?
(In reply to Kunal Mehta (Legoktm) from comment #78)
> http://meta.wikimedia.beta.wmflabs.org/wiki/Special:SiteMatrix is the full
> list.

For the avoidance of doubt: we're not doing them all, just a subset. SSL certs are a racket and expensive.
http://commons.wikimedia.beta.wmflabs.org/ is important
http://meta.wikimedia.beta.wmflabs.org/wiki/Special:SiteMatrix is the full list.

There are some weird ones like 'ee-prototype'.
login.wikipedia.beta.wmflabs.org
meta.wikipedia.beta.wmflabs.org
en.wikipedia.beta.wmflabs.org
bits.beta.wmflabs.org
upload.beta.wmflabs.org (for some icons on meta/login)

That's all I can see from the network calls.

Antoine/Chris/Chris: confirm?
Because of the necessity to have a default CA sign this, we need to buy individual certificates.  Please provide a definite list of domain names, and I'll get that ball rolling.
I think we do want it, on a limited set of subdomains to keep the cost down.

Beta's:
- loginwiki (so we can check SUL interactions)
- metawiki (so OAuth works correctly and securely)
- another wiki, maybe enwiki? (to catch other SUL login/wgSecureLogin issues)
- Oh, and to make enwiki work, the bits domain would also need a cert
We have stopped running browser tests over https. 

I think we still want SSL for labs, but I don't know of anyone actively working on that right now.
(In reply to comment #72)
> Still highest priority.  We want to get that done while I am in SF, hopefully
> this afternoon (PST time).

Sorry, was referring to another bug :-/


Regarding SSL certificates on beta, I am not sure what the status is.  Maybe Greg/Chris would know.  We might have a workaround now or simply stopped running browser tests over HTTPS.
Still highest priority.  We want to get that done while I am in SF, hopefully this afternoon (PST time).
Greg and RobLa: RT ticket states you wanted to discuss how to proceed here.
Any updates (or should this not be highest priority)?
Would it be an option to flatten our subdomains?

We'd only need beta.wmflabs.org and *.beta.wmflabs.org to be in the certificate

(at e.g. DigiCert, those wildcards are $1425 for 3 years includes root and *)

For example:

* beta.wmflabs.org
* bits.beta.wmflabs.org
* wikimedia.beta.wmflabs.org
* commons-wikimedia.beta.wmflabs.org
* wikipedia.beta.wmflabs.org
* en-wikipedia.beta.wmflabs.org
* nl-wikibooks.beta.wmflabs.org
* en-m-wikibooks.beta.wmflabs.org
* en-m-wikinews.beta.wmflabs.org
Reason in comment 16 is past (testing of new default HTTPS access), but warning message in Selenium probably still justifies highest prio? (for four months now)

(In reply to comment #68)
> The related ticket is https://rt.wikimedia.org/Ticket/Display.html?id=6116

To summarize the RT ticket: Prices offered by SSL vendors felt out of scope.

Greg and RobLa: RT ticket states you wanted to discuss how to proceed here.
Any updates?
Buying certs is pending approval according to RobH a few days ago.  The related ticket is https://rt.wikimedia.org/Ticket/Display.html?id=6116
I have cleaned up permissions on the deployment-prep labs project (ie: beta cluster).

The project admins are now limited to people from the Wikimedia ops and mw-core teams.

Root access has been limited to people having signed a non disclosure agreement with Wikimedia.


The reason for this change is to let us put real SSL certificates on the Varnish caches which would let us support HTTPS on the beta cluster.  We want to keep access to the certificates restricted, hence the change.


Please review the list of admins and sudo policy for the deployment-prep project on:

https://wikitech.wikimedia.org/wiki/Special:NovaProject
https://wikitech.wikimedia.org/wiki/Special:NovaSudoer
> 1. Remove projectadmin permissions from volunteers

I also just removed TheDJ since he didn't have an NDA on file and he didn't respond to my email asking if he wanted to sign one.

> 2. Clean up sudo policies to disallow root on varnish systems (that will have
> real certs)

Apparently the sudo policies are set up at https://wikitech.wikimedia.org/wiki/Special:NovaSudoer. It looks like most of them have sudo enabled for "ALL" hosts. I imagine disabling their root privileges on varnish systems just entails unchecking some of these hosts. Unfortunately, I'm not sure which of these hosts are varnish systems. Is it all 4 of the deployment-cache hosts? Any others?

> 3. Buy * certs

Good to hear that's in progress.
(In reply to comment #46)
> Summary of IRC conversation:
> 
> 1. Remove projectadmin permissions from volunteers

{{DONE}}, see list of members at: https://wikitech.wikimedia.org/wiki/Nova_Resource:Deployment-prep

> 2. Clean up sudo policies to disallow root on varnish systems (that will have
> real certs)

Not sure what needs to happen here. Tips/Pointers? I think Antoine had some ideas?

> 3. Buy * certs

In progress: https://rt.wikimedia.org/Ticket/Display.html?id=6116
So I took the bug thinking the cert was blocking everything, however that is not the case.

I will handle the purchase of the certificate, but I am not claiming any ownership over any other part of this process =]

We get purchase approvals within our closed ticketing system, RT#6116.  (I've set Hashar as requestor for that ticket.)  Once its purchased I'll post in here as well.
unassigning from Ryan to reflect reality.
(In reply to comment #46)
> 2. Clean up sudo policies to disallow root on varnish systems (that will have
> real certs)

I assume this means that non-admins should not have sudo on these machines?
(In reply to comment #58)
> Anyway, this isn't blocked on ops. In comment 46 I listed the steps that need
> to be taken, and they can be taken by anyone that has projectadmin in
> deployment-prep. Someone needs to take ownership of this situation and run
> with it.

I think the problem is that no one is quite sure how to do those things. I'm not sure otherwise I would JFDI.
Secure login is disabled
Well, disabling secure login is easy - much better to have a couple of tests failing than not be able to run them at all.
If MobileFrontend doesn't work without HTTPS it's broken. That's a different bug, though.

Anyway, this isn't blocked on ops. In comment 46 I listed the steps that need to be taken, and they can be taken by anyone that has projectadmin in deployment-prep. Someone needs to take ownership of this situation and run with it. It will take us a matter of days to get SSL certs and we can start that process now, but until the other steps are taken there's no major point in doing so.
This actually makes beta labs unusable for me and the rest of the mobile team. Mobile is dependent on https - it's been like this since login was first introduced. It is not easy to disentangle.
No I don't. It currently redirect to HTTPS for me in Safari and fails to load completely in Firefox.
(In reply to comment #54)
> Although I have no idea why the HTTP version doesn't load.

It does for me, both in browsers and using curl.  Is it possible you have HTTPS Everywhere or something enabled?
Any progress on this? It's been 2 weeks and we still can't do acceptance testing on beta labs.

And no we can't not use https:
http://en.m.wikipedia.beta.wmflabs.org/wiki/Main_Page
Although I have no idea why the HTTP version doesn't load.
Should be Real Soon Now: https://bugzilla.wikimedia.org/show_bug.cgi?id=55804
(In reply to comment #51)
> I guess the first part of my comment is redundant with what you already know.
> Mostly, I wanted to convey that our automation testing is broken, in case
> that
> affects prioritizing.

Is it possible for now to not use https? That's what other projects have done for now to workaround the issue.
I guess the first part of my comment is redundant with what you already know. Mostly, I wanted to convey that our automation testing is broken, in case that affects prioritizing.
(In reply to comment #49)
> Currently getting a cert warning when trying to go to:
> https://deployment.wikimedia.beta.wmflabs.org/
> This is breaking our automation tests for mobile.

Heh. Did you read the ticket any before posting this? :)
Currently getting a cert warning when trying to go to:
https://deployment.wikimedia.beta.wmflabs.org/
This is breaking our automation tests for mobile.
It's going to be an all-inclusive * cert for beta.
please don't forget about wikidata.beta.wmflabs.org
Summary of IRC conversation:

1. Remove projectadmin permissions from volunteers
2. Clean up sudo policies to disallow root on varnish systems (that will have real certs)
3. Buy * certs

Any volunteer that would like to have projectadmin in the project or root on the varnish systems will need an NDA.
Change 87045 merged by jenkins-bot:
Labs: Turn off secure login on loginwiki due to untrusted SSL

https://gerrit.wikimedia.org/r/87045
(In reply to comment #42)
> (In reply to comment #40)
> 
> > I'm still not opposed to getting a proper cert, but that requires some
> > infrastructure and permissions changes in deployment-prep...
> 
> Since we've been going around on this since May, what would be the next step
> to
> make that happen?

Maybe create another project with limited access and move the ssl terminators there. You should realize that other than advising I'm not really doing anything in beta...
(In reply to comment #41)
> (In reply to comment #29)
> > There's also the option which had been discussed before: make a new labs
> > project whose sole purpose would be to do SSL termination and would then
> > relay
> > to varnish.
> > 
> > Then *that* project would have the NDA req instead of the core beta project.
> 
> That's the dynamichttp proxy, which has been running silently for a while now
> :)

They want to have the same https infrastructure as production, which makes sense ;)
(In reply to comment #40)

> I'm still not opposed to getting a proper cert, but that requires some
> infrastructure and permissions changes in deployment-prep...

Since we've been going around on this since May, what would be the next step to make that happen?
(In reply to comment #29)
> There's also the option which had been discussed before: make a new labs
> project whose sole purpose would be to do SSL termination and would then
> relay
> to varnish.
> 
> Then *that* project would have the NDA req instead of the core beta project.

That's the dynamichttp proxy, which has been running silently for a while now :)
Has anyone considered creating a CA (http://pages.cs.wisc.edu/~zmiller/ca-howto/), generating a * cert, and adding that certificate to the browser's trust? Is that a possibility using the selenium service we're using?

I'm still not opposed to getting a proper cert, but that requires some infrastructure and permissions changes in deployment-prep...
(In reply to comment #33)
> But I can't find prefershttps in Preferences to turn that off.

So it turns out it only displays if wgSecureLogin is on, but it defaults true either way.  The gotcha is that it wasn't not on for Labs, *except* loginwiki.  However, loginwiki is not taken into account by the Preferences logic.  

I believe the above should workaround that by disabling wgSecureLogin on loginwiki as well.  However, I haven't tested it, since I don't have a realistic CentralAuth environment.

This is just intended to be temporary until there's an SSL setup on Beta that is trusted out-of-the-box by browsers.
Change 87045 had a related patch set uploaded by Mattflaschen:
Labs: Turn off secure login on loginwiki due to untrusted SSL

https://gerrit.wikimedia.org/r/87045
Calm down, what we need is to use the 'Labs CA' certificate authority to generate all the certificates we need, then add that authority as a trusted one in the browsers.

I would do it myself if I had access to the 'Labs CA'.
(In reply to comment #35)
> (In reply to comment #33)
> > (In reply to comment #32)
> > > (In reply to comment #19)
> > > > For those playing along at home: The Beta Cluster currently does not have
> > > > https by default turned on for this very reason (it broke browser tests).
> > > 
> > > This is no longer the case.
> > 
> > Correction: it's enabled by default, but only for logged in users.
> > 
> > But I can't find prefershttps in Preferences to turn that off.
> 
> This means, for instance, that VisualEditor is entirely untestable on Beta
> Labs. Yay fun. :-(

That is not true, VisualEditor works just fine on beta labs, we found Bug 54791 on beta labs with an automated browser test just this week.  Beta labs is as healthy as it has ever been, and it is running the master branch with database updates all maintained automatically.  Varnish on beta is configured properly, and is working well. 

What does not work on beta labs without a real SSL cert are: 

* tests for IE10 are busted : https://saucelabs.com/jobs/a29bcd975ac6483195b3bd56a64fec6a

* having to visit https://bits.beta.wmflabs.org manually over and over again to get styling to work in every browser is a drag
(In reply to comment #33)
> (In reply to comment #32)
> > (In reply to comment #19)
> > > For those playing along at home: The Beta Cluster currently does not have
> > > https by default turned on for this very reason (it broke browser tests).
> > 
> > This is no longer the case.
> 
> Correction: it's enabled by default, but only for logged in users.
> 
> But I can't find prefershttps in Preferences to turn that off.

This means, for instance, that VisualEditor is entirely untestable on Beta Labs. Yay fun. :-(
Yes. Using beta continues to be a hassle, and in the near future the SSL issue is going to be a big problem.
(In reply to comment #32)
> (In reply to comment #19)
> > For those playing along at home: The Beta Cluster currently does not have
> > https by default turned on for this very reason (it broke browser tests).
> 
> This is no longer the case.

Correction: it's enabled by default, but only for logged in users.

But I can't find prefershttps in Preferences to turn that off.
(In reply to comment #19)
> For those playing along at home: The Beta Cluster currently does not have
> https by default turned on for this very reason (it broke browser tests).

This is no longer the case.

(In reply to comment #24)
> Let's deploy SSL either correctly or not-at-all to beta.

Agreed.  I think turning SSL completely off on beta would be better than the current situation.  It's not good for people to get in the habit of ignoring certificate warnings.

Of course, fixing it properly with a valid cert is best.
Bumping this with a note that this affects our ability to run automated tests with IE10 only.  (Demo on request) Other versions of IE seem to be OK with the current situation on labs, but I haven't found a way around IE10's paranoia. 

It would be good to have some sort of solution for this in advance of support for IE10 in VisualEditor.
Hm. That isn't a bad idea. If we were to do that, I'd want to move the ssl terminators and the caching layer there, and strip private IP info at that layer. Then we can change beta's privacy policy to that of the projects.
There's also the option which had been discussed before: make a new labs project whose sole purpose would be to do SSL termination and would then relay to varnish.

Then *that* project would have the NDA req instead of the core beta project.
(In reply to comment #25)
> As I've mentioned in the past, I'm totally fine with getting an SSL cert for
> beta, assuming we ensure every project member in deployment-prep has a signed
> NDA.
> 
> In the future Yuvi's proxy will handle load balancing, HTTPS and such. We'll
> be
> able to drop the NDA requirement (and the SSL cert) once we have that.

Not every deployment-prep member is capable of signing an NDA anyway.
Ah. Indeed. Well, let's treat deployment-prep like tools and require NDAs for all roots...
(In reply to comment #25)
> In the future Yuvi's proxy will handle load balancing, HTTPS and such.
> We'll able to drop the NDA requirement (and the SSL cert) once we have that.

I dont think we should use  Yuvi proxy for beta since the point of the project is to closely reproduce production. Currently the SSL connections are handled by nginx proxies, whenever varnish supports it, they will land on the varnish frontends.
Understandable for manual testing. I just wanted to make sure the automated tests weren't actually blocked, since there's ways to relatively easily workaround the issue.

As I've mentioned in the past, I'm totally fine with getting an SSL cert for beta, assuming we ensure every project member in deployment-prep has a signed NDA.

In the future Yuvi's proxy will handle load balancing, HTTPS and such. We'll be able to drop the NDA requirement (and the SSL cert) once we have that.
Ryan, it's possible to work around the problem, but the issue is that, for manual testing, it's too easy to blame the SSL problem for things that might be totally unrelated.  Let's deploy SSL either correctly or not-at-all to beta.
My original requests was to generate certificates for the beta wildcards domains using the 'Labs CA' certificate authority.  By adding that authority certificate in the browser (or accepting it), that should make the browser trust all the generated certs.
The automated tests were OK I think with maybe some small exceptions.  The hassle was having to visit all the hosts (e.g. bits) in your browser in order to use any beta wikis.
Is it not possible to disable certificate checking on the automated browser tests until we get a proper certificate? I remember this being possible years ago when I built a selenium cluster...
Mostly it makes using beta labs manually a real hassle.
For those playing along at home: The Beta Cluster currently does not have https by default turned on for this very reason (it broke browser tests).
We should probably disable default https on beta until we have the opportunity to fix this up properly.  The proper fix, from what I understand, is pretty complicated, and isn't something we can do with just a day or two of elbow grease.
There's no interface with firefox, either. The workaround is to manually go to https://bits.beta.wmflabs.org/ and accept the certificate there.
It seems to me that being able to test the new [[m:HTTPS]] stuff on beta is a rather high priority; otherwise beta should be fixed for its other uses by reverting the HTTPS redirect on it.
Apparently the beta labs now forcefully redirect to https, which means all beta sides are unusable for me (Chrome) because there is no obvious way to accept the certificate for bits, so no resources are being loaded.
*** Bug 46621 has been marked as a duplicate of this bug. ***
*** Bug 49533 has been marked as a duplicate of this bug. ***
*** Bug 53113 has been marked as a duplicate of this bug. ***
Alex: turning ssl certificate verification off when doing automated testing is reasonably common because lots of folks don't run with valid certs and don't have a good infrastructure for distributing their self signed certs.  That isn't to say it is a good practice, just a common one.
Upping priority (a tiny bit) as we really need the beta cluster (hosted on labs) to be as similar to production as possible for automated testing. This is needed for that (specifically for SUL2, kinnnnnda important ;) ).
All browsers should force you to navigate that warning, unless you've somehow changed their configuration to somehow completely break that security feature.
in the configurations we're using, other browsers don't require an automated test to negotiate a warning screen, see the screen shot on Bug 52121
The other browsers don't like it either. Why is IE so special to you?
We need beta labs to work for IE in default configurations for test purposes. See Bug 52121
*** Bug 52121 has been marked as a duplicate of this bug. ***
Did not block the creation of a login wiki bug 51622

But it does prevents us from using SUL2 on beta which is bug 51580
Moving out from RT to "Labs" > "Infrastructure", per Ryan :)
RT #5184
Mailled labs-l to find out who can generate the cert. http://lists.wikimedia.org/pipermail/labs-l/2013-May/001212.html
We need a public API end point integrating with the general MediaWiki API that provides at least the following functionality:

* HTML DOM retrieval per page and revision. Basically the /en/Foo?oldid=<n> end point.
* HTML DOM expansion: POST a DOM (or fragment), return re-expanded DOM
* HTML DOM saving: POST a modified DOM and a summary, and save it as a new revision.

As long as we are using Wikitext as our storage format, saving requires a conversion to HTML and a separate save step. The individual steps should *internally* be exposed to other users including the VisualEditor extension. There is probably no need to expose the HTML2WT conversion. We should instead aim to provide an HTML-only public interface.

The integration should use an URL schema that makes it easy to map some or all of the functionality to a stand-alone (non-PHP) backend to avoid PHP startup costs in the future.

--------------------------
**Version**: unspecified
**Severity**: normal
@anomie Seems like it was mis-tagged, sorry about that. Will remove the project.
So this was in #MediaWiki-API but didn't actually have anything to do with that project?
Now resolved with https://rest.wikimedia.org/ entering beta production.
Lowering the priority as this is now live:

http://parsoid-lb.eqiad.wikimedia.org/
https://parsoid-prod.wmflabs.org/  (also supports spdy)
Once https://gerrit.wikimedia.org/r/#/c/93527/ is merged we'll provide interim access to our internal Parsoid cluster through front-end caches at http://parsoidcache.svc.eqiad.wikimedia.org/. This implements our internal https://www.mediawiki.org/wiki/Parsoid#The_Parsoid_web_API. In the longer term it will be replaced with a more general MediaWiki content API that we are still working on.
The PHP parser output is exposed through action=parse:

http://en.wikipedia.org/w/api.php?action=parse&redirects&prop=text%7Cdisplaytitle&format=xml&page=FOOBAR
Marco and I are taking this on.
Bumped the prority. We should get to this after Wikimania.
Building prod. tools based on Parsoid output (for example to produce offline snasphots) needs this MW API. http://parsoid.wmflabs.org/ can only be a temporary solution...
(In reply to comment #0)
> * HTML DOM saving: POST a modified DOM and a summary, and save it as a new
> revision.

Just to clarify, we don't need this for June/July (we're doing it in VisualEditor currently) - though it's a nice-to-have. :-)

The real focus for us is the HTML DOM expansion, which we will want ASAP for templates and other generated content blocks.
Currently the VisualEditor linkes like this: [[Glas|Glases]]
The German-language Wikipedia prefers this though: [[Glas]]es

--------------------------
**Version**: unspecified
**Severity**: normal
**See Also**:
https://bugzilla.wikimedia.org/show_bug.cgi?id=51438
https://bugzilla.wikimedia.org/show_bug.cgi?id=49940
https://bugzilla.wikimedia.org/show_bug.cgi?id=52240
There are several similar reports.

One thing is shortening the overall link to make it easier to spot and read in wikitext, it is less cluttered, and that is a good reason to enforce use of linktrail.

Use of linktrail can also be troublesome. Assume a link using one inflected word, where the inflection goes in the linktrail. Then the links are changed to another page title, but that page title has another inflection. To detect this and change it accordingly with the current bot frameworks are pretty difficult.

In English plural of `book` is `books`, but in Norwegian this is `bok`and `bøker`. 

Note that use of linktrail is an indication of a deeper problem. It should be possible for the writer to inflect the links themselves. That is instead of [[book]]s they should be able to write [[books]].

The page titles are usually of a normalized form, and rewriting a link into this normalized form is pretty strightforward. In some cases there are alternate normalized forms, but as long as all of them identify the same page there should be no real problem. Only if different inflections targets different pages would there be a problem.
There are several similar reports.

One thing is shortening the overall link to make it easier to spot and read in wikitext, it is less cluttered, and that is a good reason to enforce use of linktrail.

Use of linktrail can also be troublesome. Assume a link using one inflected word, where the inflection goes in the linktrail. Then the links are changed to another page title, but that page title has another inflection. To detect this and change it accordingly with the current bot frameworks are pretty difficult.

Note that use of linktrail is an indication of a deeper problem. It should be possible for the writer to inflect the links themselves. The page titles are usually of a normalized form, and rewriting a link into this normalized form is pretty strightforward. In some cases there are alternate normalized forms, but as long as all of them identify the same page tere should be no real problem. Only if different inflections targets different pages would there be a problem.
There are several similar reports.

One thing is shortening the overall link to make it easier to spot and read in wikitext, it is less cluttered, and that is a good reason to enforce use of linktrail.

Note that use of linktrail is an indication of a deeper problem. It should be possible for the writer to inflect the links themselves. The page titles are usually of a normalized form, and rewriting a link into this normalized form is pretty strightforward. In some cases there are alternate normalized forms, but as long as all of them identify the same page tere should be no real problem. Only if different inflections targets different pages would there be a problem.
There are several similar reports,.

One thing is shortening the overall link to make it easier to spot and read in wikitext, it is less cluttered, and that is a good reason to enforce use of linktrail.

Note that use of linktrail is an indication of a deeper problem. It should be possible for the writer to inflect the links themselves. The page titles are usually of a normalized form, and rewriting a link into this normalized form is pretty strightforward. In some cases there are alternate normalized forms, but as long as all of them identify the same page tere should be no real problem. Only if different inflections targets different pages would there be a problem.
Since there was another [[ https://de.wikipedia.org/w/index.php?diff=173370165&oldid=173263938&title=Wikipedia:Technik/Text/Edit/VisualEditor/R%C3%BCckmeldungen | complaint]] on the de-wp VE feedback page, I'm reviving this bug report. [[ https://de.wikipedia.org/w/index.php?diff=173369735&oldid=159649392 | Here ]] the previously correctly formatted link 
```
[[Baudenkmal]]e
```
was converted to
```
[[Baudenkmal|Baudenkmale]]
```

Is there any hope that this problem will be fixed soon? If that's not possible, a brief explanation of why it is difficult (which we can relay to our community when this question comes up) would be helpful.
Since there was another [[ https://de.wikipedia.org/w/index.php?diff=173370165&oldid=173263938&title=Wikipedia:Technik/Text/Edit/VisualEditor/R%C3%BCckmeldungen | complaint]] on the de-wp VE feedback page, I'm reviving this bug report. [[ https://de.wikipedia.org/w/index.php?diff=173369735&oldid=159649392 | Here ]] the previously correctly formatted link 
```
[[Baudenkmal]]e
```
was converted to
```
[[Baudenkmal|Baudenkmale]]
```

Is there any hope that this problem will be fixed soon?
>>! In T50463#2874249, @Cirdan wrote:
> Thanks for the clarification. This specific case of this bug understandably decreases acceptance of the VisualEditor on de-wp, whereas the general problem regarding trailing characters is generally seen as acceptable. I asked several complaining users to provide more diffs of this specific case which I will add here.

Let us unmerge T153107, retitle it, and add diffs there. [[Foo|Foo]] shouldn't be happening and is either a regression or a corner case in the HTML or something else going on that we have some missed all this while.
Thanks for the clarification. This specific case of this bug understandably decreases acceptance of the VisualEditor on de-wp, whereas the general problem regarding trailing characters is generally seen as acceptable. I asked several complaining users to provide more diffs of this specific case which I will add here.
>>! In T50463#2870576, @Cirdan wrote:
>> VE is an HTML editor. What kind of clean-up of HTML do you expect VE to do that would affect this?
> 
> Not HTML, but apparently editing pages with the VE creates links like 
> ```
> [[Target|Target]]
> ```
> in the Wikitext. I would assume that before Wikitext is saved (or delivered to the user), this is automatically cleaned to
> ```
> [[Target]]
> ```

Parsoid currently has code to generate simple links where necessary, but, clearly there was a bug that affected the diff you highlighted in T153107. But, in general, Parsoid does generate [[Foo]] instead of [[Foo|Foo]].
> VE is an HTML editor. What kind of clean-up of HTML do you expect VE to do that would affect this?

Not HTML, but apparently editing pages with the VE creates links like 
```
[[Target|Target]]
```
in the Wikitext. I would assume that before Wikitext is saved (or delivered to the user), this is automatically cleaned to
```
[[Target]]
```
>>! In T50463#2870216, @Cirdan wrote:
>>> How is it possible that the parser does not detect two identical strings as identical?
>> Your question assumes that it is looking for that. I don't know whether it is.
> 
> I just looked through what I believe to be the relevant parts of the source code, and it indeed seems that this is not how Parsoid handles this. I haven't looked at the VE implementation though. Is there no general cleanup at the end of a VE editing session?

VE is an HTML editor. What kind of clean-up of HTML do you expect VE to do that would affect this?
>> How is it possible that the parser does not detect two identical strings as identical?
> Your question assumes that it is looking for that. I don't know whether it is.

I just looked through what I believe to be the relevant parts of the source code, and it indeed seems that this is not how Parsoid handles this. I haven't looked at the VE implementation though. Is there no general cleanup at the end of a VE editing session?
>>! In T50463#2870045, @Cirdan wrote:
> Jdforrester-WMF, thanks for merging T153107. Could you elaborate how these two are related?

They are both issues where Parsoid is apparently creating wikitext sub-optimally.

> How is it possible that the parser does not detect two identical strings as identical?

Your question assumes that it is looking for that. I don't know whether it is.
Jdforrester-WMF, thanks for merging T153107. Could you elaborate how these two are related? How is it possible that the parser does not detect two identical strings as identical?
See also Change-Id: I78c8fc87be1777f63c84f8945ead1cc54161fb76
[Parsoid component reorg by merging JS/General and General. See bug 50685 for more information. Filter bugmail on this comment. parsoidreorg20130704]
(In reply to comment #1)
> Parsoid issue, moving to Parsoid.
> 
> Would like some input from James as to what he believes the behavior should
> be (piped links always? linktrails where possible? configurable either way?).

Canonically, linktrails should be preferred where possible (so, whenever a case-sensitive substring; except when on a $wgCapitalLinks=true, where it's a tad more complicated). I believe that linkheads should also be preferred where possible for the languages for which that applies.
Parsoid issue, moving to Parsoid.

Would like some input from James as to what he believes the behavior should be (piped links always? linktrails where possible? configurable either way?).
When VisualEditor comes across a part of a page it can't edit, it adds a green striped area. However, VisualEditor seems to have very bad aim in Monobook. Screenshots forthcoming.

--------------------------
**Version**: unspecified
**Severity**: minor
We did a bit of a re-write of how the phantoms appear in the last push; glad this fixed it. :-)
This appears to be fixed.
Created attachment 12310
VisualEditor using the Monobook skin on mediawiki.org; incorrect behavior

https://www.mediawiki.org/wiki/MobileFrontend/Photo_upload/Analysis?useskin=monobook&veaction=edit

**Attached**: {F10761}
Created attachment 12309
VisualEditor using the Vector skin on mediawiki.org; correct behavior

https://www.mediawiki.org/wiki/MobileFrontend/Photo_upload/Analysis?useskin=vector&veaction=edit

**Attached**: {F10760}
Currently VisualEditor is only enabled on the user/main namespaces on mediawiki.org. It'd be nice if it were enabled on all namespaces on mediawiki.org.

Perhaps test.wikipedia.org and test2.wikipedia.org as well.

--------------------------
**Version**: wmf-deployment
**Severity**: enhancement
Now complete.
Related URL: https://gerrit.wikimedia.org/r/63621 (Gerrit Change I1c18ff72265ed4a33c5114141d5d97301e85c2e3)
Bad diff from VisualEditor on mediawiki.org, 2013-05-13

Go to <https://www.mediawiki.org/wiki/Wikimedia_Engineering/2012-13_Goals>. Click "edit". VisualEditor form loads. Add a space after the sentence "that drive editor engagement;". Remove the space. Click "Review and save".

Expected behavior: a diff showing no changes at all (space was added to the end of the line and then removed).

Current behavior: see attached screenshot.

--------------------------
**Version**: unspecified
**Severity**: normal

**Attached**: {F10742}
We did a bunch of changes to avoid dirty-diffs with Parsoid; though there may be a few outstanding, I think we've got most of them licked, so closing.
Seems to have been fixed since the filing of this bug. Can you still reproduce this?
(In reply to comment #2)
> Are Parsoid/VisualEditor versions exposed somewhere?

[[mw:Special:Version]] :-) In general, VisualEditor is branched for production at the same time as MediaWiki core right now (so, fortnightly for the rest of this month, thereafter weekly); Parsoid is updated in production more frequently but less regularly, as it's a manual process.

> Or alternately, is there a public wiki running the most up-to-date version
> of VisualEditor?

No, I don't think so (but isn't beta meant to run master of everything?). Perhaps I should make a bug to build one in Labs.

> I really don't like wasting my time filing bugs that no longer exist. :-/

The perils of testing software that gets a dozen or so bugs fixed each week, sadly. In this particular case, I'm assuming that it's a Parsoid bug that was fixed (as I can't see anything in our git log that would suggest a VE fix changing this behaviour). Sorry!
(In reply to comment #1)
> I played around a bit locally while on the plane and tried to reproduce on
> master from the screenshot.

Blergh. I can still definitely reproduce this issue on mediawiki.org following the steps in comment 1.

Are Parsoid/VisualEditor versions exposed somewhere? Or alternately, is there a public wiki running the most up-to-date version of VisualEditor? I really don't like wasting my time filing bugs that no longer exist. :-/
I played around a bit locally while on the plane and tried to reproduce on master from the screenshot. I didn't reproduce your bug, but I found bug 48605 instead. Now that I have an internet connection again, I'll take a proper look at this bug once I've caught up on sleep.
VisualEditor added "../" inside [[Category:QA]], breaking the link. I swear I didn't touch the category itself. I was just editing an unrelated paragraph.

See https://www.mediawiki.org/w/index.php?title=Groups%2FProposals%2FFeatures_testing&diff=689563&oldid=689504

--------------------------
**Version**: unspecified
**Severity**: normal
(In reply to comment #2)
> We're going to put this into wmf4 with a Lightning Deploy this afternoon
> rather
> than wait for wmf5; thanks for the catch, Quim!
This is now done.
We're going to put this into wmf4 with a Lightning Deploy this afternoon rather than wait for wmf5; thanks for the catch, Quim!
Related URL: https://gerrit.wikimedia.org/r/63496 (Gerrit Change I84d2b23a05585890b2d5023c7c7f38a43889fd7f)
Any plans of having JSCover (JavaScript code coverage analysis) being integrated and run by Jenkins (in away that is usable for core and extensions as well)?

[1] http://tntim96.github.io/JSCover/

[2] http://tntim96.github.io/JSCover/example-qunit/out/jscoverage.html?test/index.html

[3] http://tntim96.github.io/JSCover/manual/manual.xml#automatingPhantomJS

[4] http://tntim96.github.io/JSCover/manual/manual.xml#automatingAnt

--------------------------
**Version**: wmf-deployment
**Severity**: enhancement
JSCover didn't work out very well.

I've standardised on istanbul[1] for the moment. There are qunit[2] and karma[3] integrations. Both of which we've been using for OOjs and VisualEditor these past few months.

They have command-line and HTML reporters.

[1]
http://gotwarlost.github.io/istanbul/
https://github.com/gotwarlost/istanbul

[2]
https://github.com/asciidisco/grunt-qunit-istanbul

[3]
https://github.com/karma-runner/karma-qunit
https://github.com/karma-runner/karma-coverage
Javascript coverage is still something we need. Nobody looked at integrating it in Jenkins yet though.
I'm not sure this will get any attention in a foreseeable future therefore closing this one.
**tntim96** wrote:

The JSCover JAR (JSCover-all.jar) is all custom code and only includes the Rhino library (i.e. no Jetty, Log4J, Apache-commons or other library dependencies).

Also, there is no HTML parser. When a JavaScript file is requested via JSCover's web or proxy server, JSCover instruments the specified JavaScript only. 

Whether the HTML is generated dynamically or not doesn't affect JSCover in proxy-mode. 

For proxy documentation, take a look at:
http://tntim96.github.io/JSCover/manual/manual.xml#gettingStartedProxy

...and a working proxy example at:
https://github.com/tntim96/JSCover-samples/blob/master/src/test/java/jscover/webdriver/jasmine/WebDriverUnderscoreProxyTest.java

Let me know if there are any changes required to JSCover that would assist you.
Both jscoverage and the new fork JSCover seem to have quite a nasty (though from a quick look, hard to avoid) implementation that involves instrumenting files. 

Though that in and of itself isn't a problem, it does this by running a static file server and proxying javascript files through its instrumentor and using some kind of HTML parser (another Java class dependency) to catch inline scripts even (not sure).

This isn't going to work straight up with MediaWiki since we generate HTML dynamically (e.g mediawiki-core/index.php) and load things through ResourceLoader.
I think we want QUnit tests on a few more extensions before adding code coverage. Thus lowering priority.
Single newlines have no effect on the way a wiki page is displayed.
So they should be ignored in a WYSIWYG editor.

Example: Third line at http://en.wikipedia.org/wiki/Content_Management_Interoperability_Services#Specification_progress_.26_TC_members
That sounds very project-specific.  In my experience, line breaks (shown as '↵' in VisualEditor) on enwiki often mean that someone has copied and pasted the text from another document (e.g., written the text offline in a word processor).  It only rarely seems to be done intentionally.

(Also, what if a line break someday stopped being interpreted as a space?)
Additional [[ https://de.wikipedia.org/wiki/Wikipedia:Technik/Text/Edit/VisualEditor/R%C3%BCckmeldungen#Zeichen_.27.E2.86.B5.27_taucht_in_Abs.C3.A4tzen_im_VisualEditor_auf.2C_wird_aber_nicht_erkl.C3.A4rt | feedback from a German editor]] regarding this issue:
"Wikipedians delete the '↵' in VisualEditor and replace it with a space. But this character '↵' only indicates that a break was added to the source for better readability, which is automatically translated into a space. It's often used in long citation blocks, for example. This' ↵'-character makes the Wikitext / source text more readable. The good readability of the source text in the source editor (Edit window) is still one of the quality indicators explicitly mentioned in our guidelines for good articles. The meaning in the VisualEditor is only that the user should insert a new text not to the left but to the right of the '↵' character. Just simply so that the line break in the source text remains directly behind the left character. But, when looking at the instructions, this subtlety is not mentioned. Also, no warning is displayed when you delete the '↵' character in the VisualEditer. Apparently the character can not be inserted in the VirtualEditor any more, if it was deleted. [...] I would hope that there is a warning when deleting the character or a tooltip when the mouse is hovering above the character. Thank you."
@Jdforrester-WMF let me try to rephrase to see if I understand, the
carriage return symbol is shown in VE because a wikitext editor has
included a line break in the editing environment to increase readability of
the wikitext, however this does not affect the presentation of the content
in read mode, and is meaningless and confusing to VE editors.

However there is a worry (by whom?) that not showing the character at all
would make it much easier for a VE editor to accidentally remove the
character because it has no visual representation. On the other hand
visualizing it as an actual line-break causes inconsistency between edit
and read modes (which currently exists in wikitext/read more)

Is that summary clear and factual?



*Jared Zimmerman * \\  Director of User Experience \\ Wikimedia Foundation

M +1 415 609 4043 \\ @jaredzimmerman <http://loo.ms/g0>
>>! In T50290#1074137, @Jaredzimmerman-WMF wrote:
> Unless I'm misunderstanding Whatamidoing, I think they mean that we copy
> line breaks in as actual linebreaks, so that reading and editing look the
> same and no one actually sees that carriage return symbol ever.

Yes, you're entirely missing the point here.

* Actual reader-visible new paragraphs (from two new lines after each other in wikitext) are shown as new paragraphs.
* Actual reader-visible line breaks (from a <br /> tag) are shown as line breaks.

This is about how to represent the reader-invisible nonsense wikitext single new line. See T50290#499295 for details; nothing's changed here since May 2013.
Unless I'm misunderstanding Whatamidoing, I think they mean that we copy
line breaks in as actual linebreaks, so that reading and editing look the
same and no one actually sees that carriage return symbol ever.



*Jared Zimmerman * \\  Director of User Experience \\ Wikimedia Foundation

M +1 415 609 4043 \\ @jaredzimmerman <http://loo.ms/g0>
>>! In T50290#1074123, @Whatamidoing-WMF wrote:
> I like the idea of showing it as a line break.  This might make more sense to less-technical people that have just copy-pasted text out of another document (one of the apparent causes) than the insertion of an unexpected symbol.

I'm not a fan of making VE less like the reading experience, though.
I like the idea of showing it as a line break.  This might make more sense to less-technical people that have just copy-pasted text out of another document (one of the apparent causes) than the insertion of an unexpected symbol.
*** Bug 57454 has been marked as a duplicate of this bug. ***
*** Bug 68811 has been marked as a duplicate of this bug. ***
*** Bug 65324 has been marked as a duplicate of this bug. ***
Indeed not WYSIWYG, but I happen to love this feature. I practically always remove these links when I see them. I'd say WONTFIX.
*** Bug 50641 has been marked as a duplicate of this bug. ***
*** Bug 61569 has been marked as a duplicate of this bug. ***
(In reply to comment #2)
> Newline characters are more debatable, because some people use them to make
> wikicode more readable.

...and I remmember some people use them to make diffs more readable[citation needed].
Example of TAB characters:
http://en.wikipedia.org/wiki/Refrigerator#Production_by_country
Same for TAB characters, which are shown as ➞

TAB characters have no meaning in wikicode, and I can't imagine anyone entering them for any purpose (plus they are difficult to enter in an HTML form).
I have never seen a case where they are intended (please point me to any example if I am mistaken).

I personally think TABs are a case where silent stripping would be acceptable.

---

Newline characters are more debatable, because some people use them to make wikicode more readable.
(In reply to comment #0)
> Single newlines have no effect on the way a wiki page is displayed.
> So they should be ignored in a WYSIWYG editor.
> 
> Example: Third line at
> http://en.wikipedia.org/wiki/
> Content_Management_Interoperability_Services#Specification_progress_.
> 26_TC_members

Yeah, this is a bit of a mess. In wikitext (except in some circumstances like <pre>s), \n is a whitespace character, rendered as either a space or as nothing depending on the things around it, but \n\n is "</p><p>".

We could:

* Silently strip non-conformant wikitext syntax like this on ingest, but this would mean that VisualEditor would not play well with other, wikitext-based users.

* Show the newline as a line break in VisualEditor - in a way that (a) doesn't look like a new paragraph/context has started, and (b) doesn't look like <br />s will look, either, and in some way conveys the fact that it's different.

* (Current behaviour) Show the newline as a special kind of character in VisualEditor - in a way that (a) doesn't look like a 'real' new line, because it isn't.

* Silently not show the new line as such (but instead as… a space?), which is prone to having users accidentally alter them without intention, again causing problems for intermixed VisualEditor and wikitext editor sessions.

What are your thoughts?
Go to http://en.wikipedia.org/wiki/Content_Management_Interoperability_Services
Put the cursor somewhere in the text.
Type "Enter" 2 times.
Type "Backspace" 2 times.

Expected: as original
Actually: The newlines remain

--------------------------
**Version**: unspecified
**Severity**: normal
This is now fixed in live.
Just reproduced on Firefox 21.0 / fresh install of Ubuntu Linux 2013.04
Nothing special appears in the web console.
Browser information highly welcome. Reopening for the time being.
When will the master fixes be deployed?
The situation is now horrible in production, with so many bugs that I am wondering whether it is even worth reporting them...
I just tried, it is a worse problem now, text is lost.
**orbit** wrote:

I'm not able to reproduce this one either. I experience other problems relating to Enter and Backspace on Firefox (fixed in Master) but not what you've described. I'm going to close this ticket, but please reopen if you have additional information.
As discussed with Steven W. just now, we should move this into MW core (so, amongst other things, VisualEditor can depend on it and not have to re-invent the wheel).

--------------------------
**Version**: master
**Severity**: normal
**See Also**:
https://bugzilla.wikimedia.org/show_bug.cgi?id=16066
That's a cherry-pick back to wmf5, so no wikis that currently have PostEdit will lose it when we disable the extension.
Related URL: https://gerrit.wikimedia.org/r/66316 (Gerrit Change I01cfc0630c3a505af82922844b5e70c1d61f3c1d)
(In reply to comment #1)
> Related URL: https://gerrit.wikimedia.org/r/66137 (Gerrit Change
> I01cfc0630c3a505af82922844b5e70c1d61f3c1d)

Merged.
Just for posterity, I'm noting bug 16066 here.
(In reply to comment #2)
> I should note that one extension depending on another is *not* a legitimate
> reason for moving the dependency into the core. That said, I still agree with
> the merging of this extension since it's a trivial feature.

Yes, I agree completely. There had already been wide agreement that this should be moved into core; the VisualEditor requirement is just a spur.
(In reply to comment #0)
> As discussed with Steven W. just now, we should move this into MW core (so,
> amongst other things, VisualEditor can depend on it and not have to re-invent
> the wheel).

I should note that one extension depending on another is *not* a legitimate reason for moving the dependency into the core. That said, I still agree with the merging of this extension since it's a trivial feature.
Related URL: https://gerrit.wikimedia.org/r/66137 (Gerrit Change I01cfc0630c3a505af82922844b5e70c1d61f3c1d)
We use textarea which means that browsers don't suggest text from previous uses.

**See Also**:
{T53903}
{T54859}
{T54085}
Proposed to #community-wishlist-survey-2017
>>! In T50274#3234411, @Schnark wrote:
> But neither will give results for users not logged in. Even if they have a static IP, `mw.user.getName()` will only return `null`.

There are a bunch of features that don't work for logged-out users; I'd not worry too much about that.
>>! In T50274#2137790, @Esanders wrote:
> Fetch and filter recent commit messages:
> 
> https://gist.github.com/edg2s/f7db01d240ad3c83d183

I don't think that `list: 'recentchanges'` is the best approach, as it will only give you summaries from the last month. When you are not very active, these are very few, so won't help much. In my script https://de.wikipedia.org/wiki/Benutzer:Schnark/js/veSummary.js, I instead decided to use `list: 'usercontribs'` instead.
But neither will give results for users not logged in. Even if they have a static IP, `mw.user.getName()` will only return `null`.
A solution could also be HTML5 `contenteditable`, at least its support in browsers is acceptable. (see [[ http://stackoverflow.com/questions/13324822/autocomplete-with-contenteditable-div-instead-of-textarea-doesnt-seem-to-work | StackOverflow question about this topic ]])
A solution could also be HTML5 `contenteditable`, at least its support in browsers is acceptable. (see [[ http://stackoverflow.com/questions/13324822/autocomplete-with-contenteditable-div-instead-of-textarea-doesnt-seem-to-work | StackOverflow question to this topic ]])
A solution could also be HTML5 `contenteditable`, at least its support in browsers is acceptable. (see [[ http://stackoverflow.com/questions/13324822/autocomplete-with-contenteditable-div-instead-of-textarea-doesnt-seem-to-work | StackOverflow question to the topic ]])
(Actually, Chrome does support autocomplete="street-address", huh. But that doesn't really help us here, it doesn't remember and autocomplete values in textareas on its own and there doesn't seem to be a way to make it do that.)
It's not possible to make <input> wrap. If anything, it could be possible to make <textarea> have autocomplete (nothing in the spec prohibits it, the attribute [[ https://html.spec.whatwg.org/multipage/forms.html#the-textarea-element| is valid on textarea]] and the new 'autocomplete' values include [[https://html.spec.whatwg.org/multipage/forms.html#attr-fe-autocomplete-street-address| one that is only valid on multiline content]]). But no browser seems to actually support this.
(That was https://gerrit.wikimedia.org/r/#/c/212795/, it tried to dynamically swap between <input type=text> and <textarea>.)
Bartosz had a go at this a few years ago, but then I pointed out some IME issues and he gave up. I think my API approach is probably the simplest.
How plausible would it be to use `input` but magically make it word wrap, even though the HTML spec says it mustn't?
Raising priority now that we have the same problem in VE source mode (NWE).
I have a (very hackish) user script for providing access to previous edit summaries: https://de.wikipedia.org/wiki/Benutzer:Schnark/js/veSummary.js If anybody wants to use code from there to fix this in VE itself, feel free to do so.
Fetch and filter recent commit messages:

https://gist.github.com/edg2s/f7db01d240ad3c83d183
I think this should be low priority. Only power users need quick access to commonly used edit summaries, and these power users will by definition know OS-wide tools like autohotkey or ditto which can do the job much more comfortably.
The main threads in VE/F:
https://en.wikipedia.org/wiki/Wikipedia:VisualEditor/Feedback/Archive_2013_05#Edit_summaries_have_no_.27memory.27
and
https://en.wikipedia.org/wiki/Wikipedia:VisualEditor/Feedback/Archive_2013_06#Predictive_texting_in_edit_summaries
and
https://en.wikipedia.org/wiki/Wikipedia:VisualEditor/Feedback/Archive_2013_06#Edit_summaries_-_menu_of_recently-used.3F
and
https://en.wikipedia.org/wiki/Wikipedia:VisualEditor/Feedback/Archive_2013_07#Speed.2C_Edit_Summary.2C_and_Limitations



Closely related are:

Bug 42139 ("There is no preview of edit summaries") - Wanted, so that we can test WP:shortcut links etc are correctly-targeted.

Bug 50961 ("Provide simultaneous access to editor and edit summary") - So that we don't have to remember everything we did, after a multitask edit.
(In reply to comment #8)
> A suggested list populated with recent edit summaries will be really useful
> when VE is extended to talk namespace.

We're not planning to make VisualEditor work with talk pages, but instead this will be done by Flow (which will use VisualEditor for editing content).

That said, we still think this would be valuable, and it's definitely in our plans.
A suggested list populated with recent edit summaries will be really useful when VE is extended to talk namespace. Almost every time I close an RfD as something other than delete, I make an edit to the redirect's talk page with the summary "Noting old RFD" or "Note old RFD and tag for relevant WikiProjects" (depending whether they are already tagged or not).
(In reply to comment #6)
> (In reply to comment #1)
> > ...or implement our own autocomplete?
> 
> However, just brainstorming, to address Raimond's use-case in comment 3, it
> may
> be possible to query the most recent X edit summaries a user has used and
> implement a suggestion feature based on those. That might cover the repeated
> edits use-case.

That's pretty much what I meant. The autocomplete would populate from recent commit messages, or they would just be shown in a dropdown.
(In reply to comment #1)
> ...or implement our own autocomplete?

It depends what the use-case is. Personally, I like the current multi-line input and my browser stopped remembering my inputs for <input>s long ago (perhaps when I switched from Firefox to Chrome).

However, just brainstorming, to address Raimond's use-case in comment 3, it may be possible to query the most recent X edit summaries a user has used and implement a suggestion feature based on those. That might cover the repeated edits use-case.
Rephrased bug summary. "textbox" doesn't exist. There is "input" and "textarea" both are "form fields".
(In reply to comment #3)
> Browser's autosuggestion/complete is the most used function during editing
> Wikipedia, especially when I do similar edits. Every time I test the VE is
> miss this function because the field is a textarea instead of an input field.
> It's really annoying to type every time the summary instead of selecting out of
> previous summaries.

Sure, but this functionality isn't possible for proper editable surfaces with rich text, links and other HTML items that these fields will allow.
Browser's autosuggestion/complete is the most used function during editing Wikipedia, especially when I do similar edits. Every time I test the VE is miss this function because the field is a textarea instead of an input field. It's really annoying to type every time the summary instead of selecting out of previous summaries.
(In reply to comment #1)
> ...or implement our own autocomplete?

Possibly. Given that we are intending to replace this wikitext field with a full VE micro-surface (with the limited scope that log entries allow), that might be a bit fiddly, though. There's also not currently a useful API to query "useful edit summaries" from. Marking as a longer-term consideration.
...or implement our own autocomplete?
Images in a table are incompleted alienated and still clickable.

--------------------------
**Version**: unspecified
**Severity**: normal
**URL**: https://de.wikipedia.org/wiki/Liste_der_Hochh%C3%A4user_in_Deutschland
(In reply to comment #0)
> Images in a table are incompleted alienated and still clickable.

This is fixed by the new image code which will be coming very soon (but is delayed to finish editing image properties). Marking as a dupe of that bug.

*** This bug has been marked as a duplicate of bug 37870 ***
Not sure whether this is ContentEditable, DataModel or LinearModel.

When pasting italicised text (from elsewhere on the same page) into an already italicised sentence we currently close, re-open, close, re-open that annotation.

Steps to reproduce problem:
* start with:
  <p><i>Original text here.</i></p><p><i>Something else there.</i></p>
* select "else"
* copy
* select "text"
* paste to replace
* end state:
  <p class="ve-ce-branchNode"><i class="ve-ce-TextStyleAnnotation ve-ce-TextStyleItalicAnnotation">Original </i><i class="ve-ce-TextStyleAnnotation ve-ce-TextStyleItalicAnnotation">else</i><i class="ve-ce-TextStyleAnnotation ve-ce-TextStyleItalicAnnotation"> here.</i></p>

Now this wouldn't be a major issue (merely inefficient) if it weren't for bug 48194 in Parsoid.

Real example:
* Intended edit: https://www.mediawiki.org/w/index.php?title=Watchlist_wishlist&diff=686477&oldid=686247
* Actual edit as seen in the Review and save dialog of VisualEditor (and saved as-is): https://www.mediawiki.org/w/index.php?title=Watchlist_wishlist&diff=686475&oldid=686247

--------------------------
**Version**: unspecified
**Severity**: critical
*** Bug 48489 has been marked as a duplicate of this bug. ***
Confirmed on mediawiki.org
Timo, can you confirm this in master? I think it's been fixed by Ed's change to how annotations are compared…
* Create an English article with a <ref> tag at the end of a paragraph
* Set $wgLanguageCode = 'en-rtl';
* View the article. You'll see something like ]My text[1 (this rendering seems wrong)
* Edit the article in VE. The non-contiguous reference causes problems:
** The phantom is rendered wrongly so it's not visible
** When you select the reference, the selection looks really strange

Should we wrap things in a <bidi> tag or whatever to ensure better rendering?

--------------------------
**Version**: unspecified
**Severity**: normal
Merged; closing.
Assigning to Moriel then. :-)
And it was Roan who suggested, and Krinkle who participating in the attempt of helping me understand.. THANKS for that!
Related URL: https://gerrit.wikimedia.org/r/62540 (Gerrit Change I319285d23a4f0a0522cc793f1a6661cda31a1ebf)
This is a CSS fix in the Cite extension. https://gerrit.wikimedia.org/r/#/c/61634/

As Krinkle suggested, I'm fixing a small detail again (position 'top') but updating the Cite extension should fix this problem. I'll link the new correction to this bug and submit the fix shortly.
Make a null edit (space and backspace), then trigger a diff. JS error thrown in Firefox but not Chrome:

Error: toDomElements() failed to return an array when converting element of type alienBlock @ http://bits.wikimedia.org/en.wikipedia.org/load.php?debug=false&lang=en&modules=ext.visualEditor.core%2Cicons-raster%7Cext.visualEditor.viewPageTarget.icons-raster%7Crangy%7Cunicodejs.wordbreak&skin=vector&version=20130506T190432Z&*:130

However, for debug=true, no such error occurs. Is this just going to be a transient RL issue?

--------------------------
**Version**: unspecified
**Severity**: minor
*** Bug 48193 has been marked as a duplicate of this bug. ***
This has been fixed for me in FF since yesterday evening. From chatting with Roan last night I think it was a deployment / ResourceLoader issue.

Resolving as fixed.
Happens in Chromium 26.0.1410.43 too.
I watched a user using Chrome paste a 32400-character buffer of special characters into VE.  Chrome became unresponsive. 

This user then did that in multiple tabs and the entire computer became unresponsive.

--------------------------
**Version**: unspecified
**Severity**: enhancement
Marking as an enhancement with normal priority (nice-to-have).
(Provided we are happy with the rendering quality)

Currently we only serve SVGs when window.devicePixelRatio > 1.

On suggested test for SVG support is:

document.createElementNS && document.createElementNS( 'http://www.w3.org/2000/svg', 'svg' ).createSVGRect

--------------------------
**Version**: unspecified
**Severity**: enhancement
Merged for wmf4.
Related URL: https://gerrit.wikimedia.org/r/62959 (Gerrit Change Iafe8cd290fb195369776f51a96b6de4a51577b89)
Let's do this. Trevor says we're happy with the rendering quality and the device load for desktop; I suggest keeping the PNGs around for mobile clients.
As the title says: when the VisualEditor is active, the drop down menu (p-caction) under Vector skin is dropped down behind the VE toolbar, making it impossible to click on. May be a simple z-index issue.
Merged; thanks Kaldari! Will go out in wmf4.
Assigning given that Kaldari's fixing it in core for us. :-)
Related URL: https://gerrit.wikimedia.org/r/63099 (Gerrit Change I61daea50209d040f7e0f71207a4e90998c15083f)
Unfortunately, this was caused by the fix to bug 37158.
https://gerrit.wikimedia.org/r/#/c/31288
Also brought up here: https://en.wikipedia.org/w/index.php?title=Wikipedia:Village_pump_%28technical%29&oldid=553770320#Notifications_gadget.27s_z-index
This also holds true for Echo, which also has z-index -100.
Expected layout

I included two screenshots, illustrating the problem.

Apple Safari 6, Mountain Lion

--------------------------
**Version**: unspecified
**Severity**: normal
**URL**: https://en.wikipedia.org/wiki/Meurchin

**Attached**: {F10895}
This is fixed in master (see gerrit 60940) and will be deployed to the English Wikipedia on Monday as part of the wmf3 roll-out. You can see how it should work in a test page on MediaWiki.org: https://www.mediawiki.org/wiki/VisualEditor:TableCaptionTest
Created attachment 12258
Content edit result

**Attached**: {F10896}
In Firefox 20.0.1:

1. Edit a page that has a bulleted list.
2. Place the cursor on the first bullet item.
3. Click the "Bullet List" button. The first bullet item loses its bullet. (Correct.)
4. Click the "Bullet List" button a second time. The first bullet comes back (correct), but there is now a blank line displayed below it.

Similarly, if you remove & add a bullet in the middle of the list, you get blank lines above AND below the item.

Similarly, if you do this with a numbered list, the blank line breaks the numbering: the list items below the blank line start over from "1".

--------------------------
**Version**: unspecified
**Severity**: enhancement
FWIW, I also just checked OpenOffice.org, and they also simply remove and restore the bullet, keeping a single bulleted list.
(In reply to comment #2)
> Interesting point. I think nontechnical end-users will have a different
> perspective, however. Both Microsoft Word and Google Docs will produce a
> single bulleted list as the result. Your users are going to be accustomed to
> that behavior.

Possibly.

> When an end-user clicks the button the first time, and the bullet disappears,
> they won't be thinking that "a bulleted list has become two lists." They'll
> simply think "a bullet symbol has been removed."

Not two lists - they'll have a paragraph and a list.

I'll make sure we do some real-world tests with non-technical people to come to a decision on this.
Interesting point. I think nontechnical end-users will have a different perspective, however. Both Microsoft Word and Google Docs will produce a single bulleted list as the result. Your users are going to be accustomed to that behavior.

When an end-user clicks the button the first time, and the bullet disappears, they won't be thinking that "a bulleted list has become two lists." They'll simply think "a bullet symbol has been removed."
(In reply to comment #0)
> In Firefox 20.0.1:
> 
> 1. Edit a page that has a bulleted list.
> 2. Place the cursor on the first bullet item.
> 3. Click the "Bullet List" button. The first bullet item loses its bullet.
> (Correct.)
> 4. Click the "Bullet List" button a second time. The first bullet comes back
> (correct), but there is now a blank line displayed below it.
> 
> Similarly, if you remove & add a bullet in the middle of the list, you get
> blank lines above AND below the item.
> 
> Similarly, if you do this with a numbered list, the blank line breaks the
> numbering: the list items below the blank line start over from "1".

Yes, because otherwise we'd be unexpectedly merging a <p> with a following <ul> (or whatever). You can always actively choose to merge the lists from this position by deleting the blank line between the lists (technically, this is a slug).

This is the deliberately-chosen behaviour for this. I take it you'd expect lists to instead automatically merge, and you'd have to split them rather than the other way around? X followed by X is not generally a direct reverse step (that's what undo is for), but you expected it to work that way around?
The indent and outdent buttons are always grayed out.

(reported at http://de.wikipedia.org/wiki/Wikipedia:Technik/Text/Edit/VisualEditor/Alpha2013-04#Link_einbinden_.2F_Einzug)

--------------------------
**Version**: unspecified
**Severity**: enhancement
(In reply to Spinningspark from comment #6)

Sorry, posted this in wrong place.  It was intended for bug 59849
I don't know if this is related, or whether it should be a new bug.  In this edit:

https://en.wikipedia.org/w/index.php?title=User:Spinningspark/Work_in_progress/Mobility_analogy&diff=626824709&oldid=626823704

VE adds a number of spurious indents.  The intended edit was to swap over the order of two blocks of text containing math markup.  Very frustrating that the problem could not even be fixed from within VE since indenting does not function in general.
*** Bug 51530 has been marked as a duplicate of this bug. ***
(In reply to comment #3)
> Would this also allow the tab key to be used for paragraph indenting (like
> for lists), or should that be filed as a separate bug report?

That'd be the same (the tab and shift-tab keys are bonded to these buttons), so no need for a separate bug report.
**mcdevitd** wrote:

Would this also allow the tab key to be used for paragraph indenting (like for lists), or should that be filed as a separate bug report?
This would be lovely (as a nice-to-have) to get done for the beta.

In practical terms, it means that <p>Foo</p> gets wrapped into <dl><dd><p>Foo</p></dd></dl> and vice versa; all the DM/Parsoid plumbing is there, just needs the indent/outdent commands to be aware of how to operate in the paragraph/preformatted context.
These are for list indenting currently, and do not (yet) do text block indenting. Setting as an enhancement, likely to be after the 'beta' is released.
Conversion labels shown

The conversion labels (i.e. { } ) for wikis like zhwiki is shown when editing using the VisualEditor.

Those labels should be hidden, or otherwise newbies using the editor will break them easily.

--------------------------
**Version**: unspecified
**Severity**: enhancement

**Attached**: {F10580}
This is a mess; Parsoid currently has no support for the language variant conversion syntax in wikitext, but when it does (bug 41716) we should work on this to make it easy to set the different variants.

Sorry that we are not really ready yet for zh; I feel that this is a blocker to deployment in zh, so until it's fixed I think VisualEditor will remain in alpha opt-in deployment there for now.
(In reply to comment #10)
...
> I'd recommend we add some code to mediawiki.action.edit to periodically check
> mwCustomEditButtons. Then immediately deprecate it (not removing it, just
> marking it as deprecated) and phasing it out over the following weeks (I'd
> like
> to add it to the js-deprecations train roll-out in May which will introduce
> mw.log.deprecate and console.warn messages that users can use to easily see
> if
> they are using something that is deprecated).

I requested this on bug 50310 so we don't forget.
Closing this as wontfix.

The classic edit toolbar has long been deprecated. The default was replaced with WikiEditor on Wikimedia in a 2010 deployment. And since a few releases it is now bundled with new MediaWiki releases as well.

Since then development has started on [[mw:VisualEditor]] which will be launched soon.

Despite all that, I've spend a fair amount of effort over the last months to come up with a brand new API for the classic edit toolbar: mw.toolbar because mwCustomEditButtons is fundamentally flawed and cannot be repaired and kept up with the latest technologies.

Any and all issues you may have with mwCustomEditButtons are from hereon invalid. Please use mw.toolbar instead. Note that mw.toolbar has nothing to do with WikiEditor or VisualEditor, it is a new API for the classic editor you are so familiar with.

I can't make any promises for how long the classic toolbar and this new mw.toolbar will be supported, but at least it has been renewed to work with all the latest technologies so it should be a relatively cheap burdon for us to maintain.

So, long story short: Change:

> if ( wgAction === 'edit' ) {
>     mwCustomEditButtons[mwCustomEditButtons.length] = {...};
> }

to:

> if ( mw.toolbar ) {
>     mw.toolbar.addButton( { ... } );
> }

If there are any bugs with that, please file a new bug report and be sure to mention "mw.toolbar" in its subject. I'll do my best to address if/when there are any issues.
We fixed it with Nemo on IRC. For the record, this was because the script ran on all pages (not just edit ones). The simplest way to fix that was to wrap the button definitions in "if ( mw.toolbar ) { ... }".
(In reply to comment #9)
> billinghurst, this has nothing to do with switching to the new toolbar;
> mw.toolbar.addButton works with and is intended for the old one, and the
> change
> is just a simple find and replace:
> 
>   Find:         mwCustomEditButtons[mwCustomEditButtons.length] = { ... }
>   Replace with: mw.toolbar.addButton({ ... })
> 
> Just be careful about braces and parentheses.
> 
> Here's an example diff:
> https://nl.wikipedia.org/w/index.php?title=Gebruiker:Romaine/vector.js&diff=37497149&oldid=37497060

This solution didn't work for long, it just broke all JavaScript for me on Meta (most prominently, [[m:WM:LS]]) with:

Timestamp: 09/06/2013 20:03:03
Error: TypeError: mw.toolbar is undefined
Source File: https://bits.wikimedia.org/meta.wikimedia.org/load.php?debug=false&lang=it&modules=user&only=scripts&skin=monobook&user=Nemo+bis&version=20130601T024617Z&*
Line: 1

[MediaWiki 	1.22wmf5 (bad4d50)]
(In reply to comment #11)
> (In reply to comment #9)
> > billinghurst, this has nothing to do with switching to the new toolbar;
> > mw.toolbar.addButton works with and is intended for the old one, and the
> > change
> > is just a simple find and replace:
> > 
> >   Find:         mwCustomEditButtons[mwCustomEditButtons.length] = { ... }
> >   Replace with: mw.toolbar.addButton({ ... })
> > 
> > Just be careful about braces and parentheses.
> > 
> > Here's an example diff:
> > https://nl.wikipedia.org/w/index.php?title=Gebruiker:Romaine/vector.
> > js&diff=37497149&oldid=37497060
> 
> Thanks. This innovation had escaped me, and clearly a whole community that
> was
> using mwCustomEditButtons. I will relay this to the enWS community, and fix
> our
> help pages.
> 
> Can you recommend that right page to watch for these changes.  I thought
> that I
> had watched all the relevant pages where Krinkle does these components,
> however, it is clear that this change wasn't evident for active changes.

Clearly it was a long time ago as I have since found reference that it was broken in 1.18, but somehow it didn't break for all. Weird.
(In reply to comment #9)
> billinghurst, this has nothing to do with switching to the new toolbar;
> mw.toolbar.addButton works with and is intended for the old one, and the
> change
> is just a simple find and replace:
> 
>   Find:         mwCustomEditButtons[mwCustomEditButtons.length] = { ... }
>   Replace with: mw.toolbar.addButton({ ... })
> 
> Just be careful about braces and parentheses.
> 
> Here's an example diff:
> https://nl.wikipedia.org/w/index.php?title=Gebruiker:Romaine/vector.
> js&diff=37497149&oldid=37497060

Thanks. This innovation had escaped me, and clearly a whole community that was using mwCustomEditButtons. I will relay this to the enWS community, and fix our help pages.

Can you recommend that right page to watch for these changes.  I thought that I had watched all the relevant pages where Krinkle does these components, however, it is clear that this change wasn't evident for active changes.
(In reply to comment #7)
> So how hard would it be to get the site&user scripts to run first, then
> $.ready, then the rest of the bottom queue? Then we could kill off
> mwCustomEditButtons after announcing it properly and revert the change
> (unless
> there is a considerable number of other scripts this would break).
> 
> [Disclaimer: I know next to nothing about ResourceLoader internals.]

site&user script run after the bottom queue by design. Just like the cascading stylesheets, they are intended and designed to allow overriding/customising things after everything else.

Though presence of code will not make a difference (since bottom queue is async), the loading is affected.

Code in site and/or user scripts that are wrapped in mw.loader.using would trigger additional http requests instead of tagging along on the already pending request for the bottom queue (this is ResourceLoader internals).

I'd recommend we add some code to mediawiki.action.edit to periodically check mwCustomEditButtons. Then immediately deprecate it (not removing it, just marking it as deprecated) and phasing it out over the following weeks (I'd like to add it to the js-deprecations train roll-out in May which will introduce mw.log.deprecate and console.warn messages that users can use to easily see if they are using something that is deprecated).

Then we can safely remove mwCustomEditButtons in the 1.22 release.

(In reply to comment #6)
> (In reply to comment #5)
> > Rephrasing bug to be about mwCustomEditButtons to avoid mixed subjects.
> 
> See my comment above. There may be other similar structures existing there.

Possible indeed, though unlikely as most legacy things have been phased out. Examples are welcome :)
billinghurst, this has nothing to do with switching to the new toolbar; mw.toolbar.addButton works with and is intended for the old one, and the change is just a simple find and replace:

  Find:         mwCustomEditButtons[mwCustomEditButtons.length] = { ... }
  Replace with: mw.toolbar.addButton({ ... })

Just be careful about braces and parentheses.

Here's an example diff: https://nl.wikipedia.org/w/index.php?title=Gebruiker:Romaine/vector.js&diff=37497149&oldid=37497060
As a comment mwCustomEditButtons functionality is used at English Wikisource. And for numbskulls like myself it is far easier to code snippets to implant code than the alternate means. I repeatedly failed to master mw.toolbar.addButton, gave up walked away, too much to do, too much to customise.

The old toolbar allows for easy nulling out of buttons not required, or not prioritised, and the easy addition of little bits of personal functionality, and the new toolbar makes these things hard (IMO).  Don't blame us that we find the older tool to work better; has the requisite functionality, and meets our simple needs. We are not WP, our requirements are different, our tasks are different, our namespaces are different.

I am happy to try again to be less stupid to see if I can create a core set of tools that could be used, and allow users to plug them in as they see fit, however, it isn't my core skill set. Definitely an area where better guidance would be of use.

PLUS as the 'new' toolbar is still considered a BETA FEATURE (see preferences), why would we be expected to move. Stridency against us simple editors seems a little harsh. Some of us just want to get on with our tasks, and chasing and understanding the backend changes isn't easy.
So how hard would it be to get the site&user scripts to run first, then $.ready, then the rest of the bottom queue? Then we could kill off mwCustomEditButtons after announcing it properly and revert the change (unless there is a considerable number of other scripts this would break).

[Disclaimer: I know next to nothing about ResourceLoader internals.]
(In reply to comment #5)
> Rephrasing bug to be about mwCustomEditButtons to avoid mixed subjects.

See my comment above. There may be other similar structures existing there.
Rephrasing bug to be about mwCustomEditButtons to avoid mixed subjects.

So in summary: mwCustomEditButtons is very ugly and undocumented. But it used to be the only way to add buttons to the toolbar. Though (as pointed out by various comments) it is a coincidence that most existing usages have survived without causing errors, but it is the case.

How mwCustomEditButtons works now:
* Initialise to empty array from top queue
* Hook in document ready
* Iterate through array (e.g. items added before the page load) and call mw.toolbar.addButton for each one.

The state is that most existing usages of mwCustomEditButtons happen from a site or user script at run-time in the global scope. And this works fine because they are blocking script tags.

Now that $.ready() (the jquery callback list, not the event itself) is triggered before site/user script load (the site/user script still load from the bottom) it means the code that iterates through the legacy array will not get any of the items because they're not in the array yet at that time.
(In reply to comment #0)
> @Liangent: Can you given an example where it matters for a user script
> whether
> the document becomes ready before or after they are loaded? The user scripts
> are loaded from the bottom of the <body> before </body>. Practically the
> document is already ready at this point, just $(document).ready() hasn't
> fired
> yet. Any user script code that isn't wrapped in $(document).ready() will
> still
> execute at exactly the same time. Any user script code that *is* wrapped in
> $(document).ready() will now execute immediately after loading instead of...
> immediately after loading. Exactly the same, not?

Let me give a (almost) real world example (difference explained below):

We have some gadgets (technically some gadgets, but socially one gadget; not using [ResourceLoader]). The first is the gadget itself, which registers some global states as data/options, then $(document).ready() its execution code. All gadgets below are modifiers for the gadget which change those global states so when the main body of the gadget is executed, the modified global states are visible to it. But now...

Difference from real world: addOnloadHook() is used there instead of $(document).ready() so it finally escaped :)
Created attachment 12209
Test case for the browser issue with setTimeout and document.write

I've attached my test case for the browser issue with setTimeout and document.write. Note that it should be served from a webserver that is not behind a proxy server, so the flush calls result in it slowly counting 0-9.

**Attached**: {F10516}
Screenshot in edit mode

Images on pages are normally included using the "thumb" syntax:

[[File:Foo.jpg|thumb|description]]

In the edit mode no thumb frame is shown, see screenhots.

--------------------------
**Version**: unspecified
**Severity**: normal
**URL**: https://de.wikipedia.org/wiki/Benutzer:Raymond/thumb

**Attached**: {F10382}
This was fixed by gerrit 64367 which is now merged, but is 'experimental' and so will not go out for a short while. Marking as fixed within wmf5, though.
For now we are going to fix it in VE directly. Parsoid will deliver us figure tags for block images and span tags for inline images, but VE is going to render div soup for block and image wrapped in an anchor for inline (maybe with few exceptions).
Hijacking this bug slightly. :-)

(This will probably be solved with an upstream bug with Parsoid for a post-parser to transform, but could be done in VE instead. Either way are messy; long term answer is for Parsoid-output to be the "read" HTML too, and have skins and scripts target that structure.)
Simple test case, see URL:

* foo
: bar

adds a newline in edit mode. When removing this newline in edit mode the : is killed by the parser.

--------------------------
**Version**: unspecified
**Severity**: normal
**URL**: https://de.wikipedia.org/wiki/Benutzer:Raymond/Finissage
**See Also**:
https://bugzilla.wikimedia.org/show_bug.cgi?id=60535
On nl.wp a discussion has started to turn on VE. In the process feedback has been collected on VE. Some users commented on "white lines" as a blocking issue for turning VE on as default. 
On top of pages like:
* https://nl.wikipedia.org/wiki/Bali_%28eiland%29?veaction=edit
* https://nl.wikipedia.org/wiki/Justine_Henin?veaction=edit
* https://nl.wikipedia.org/wiki/Rijn?veaction=edit
* https://nl.wikipedia.org/wiki/Brussels_Hoofdstedelijk_Gewest?veaction=edit
* https://nl.wikipedia.org/wiki/Antwerpen_%28stad%29?veaction=edit
as well as on other places on the page "white lines" or carriage returns appear in VE edit mode which do not appear in read mode. On mouse over the white line turns blue. 

Some users fear that newcomers others will delete those white lines and carriage returns. However, after deletion of those lines images are accidently deleted from the page.

This discussion started on bug 49806. James Forrester pointed me to this bug to continue the discussion.

(Deleting white space at the bottom of a page might also delete accidently categories and other metadata.)

How can I help to resolve this 'bug'? I will also copy to bug 55336.
Initial version of this now merged and being deployed tomorrow. I think we'll want to revisit the styling and behaviour, but this will do for now.
Change 116742 abandoned by Esanders:
Vector style tweaks for collapsible slugs

https://gerrit.wikimedia.org/r/116742
Change 109307 merged by jenkins-bot:
Collapse block slugs and expand on hover/focus

https://gerrit.wikimedia.org/r/109307
Change 116742 had a related patch set uploaded by Esanders:
Vector style tweaks for collapsible slugs

https://gerrit.wikimedia.org/r/116742
Change 109307 had a related patch set uploaded by Esanders:
Collapse block slugs, and expand on hover/focus

https://gerrit.wikimedia.org/r/109307
Thanks, Ed, for splitting the issue and working on a patch for bug 55336. 

Accordingly, I've set that bug to High/Major and this one to Normal, as the overall UX for slugs is important, but not as significant as the accidental deletion of content with the current implementation. I also suspect that we would want to alter the delete behavior even if we end up altering the slug appearance overall.

I do agree that the accidental whitespace is confusing (it's often the most immediate and obvious difference from read mode) and it would be good to find an alternative. In addition to offering an affordance on hover, we might also expand the slugs as the user moves her cursor through the page.
**jonathan_haas** wrote:

(In reply to comment #15)
> Why don't we just suppress the delete key when pressing it would delete the
> object the slug is associated with?

This would still leave the user with a superfluous empty line, which might be confusing and/or destroying the page layout.

I like the idea in attachment 12988, but I think it would be better, if slugs would have had an effective default height of 0 (for example height: 4px, margin-top: -2px, margin-bottom:-2px), so the article layout would match the real one.
I think we should split this bug in two: Slugs, and accidental deletion of FocusableNodes. Here is the latter: bug 55336
I agree with previous commenters that this is likely to be at the cause of a lot of the accidental infobox deletions and such. I understand it's a tricky issue, but the current behavior is extremely confusing from the user's point of view, so we need to look at some viable solutions. 

Recapping the simple case: User is on what they perceive to be an unnecessary newline, presses delete to make the visual layout match the expected layout. A separate object (in the case of the infobox, right-aligned on the other side of the screen) suddenly disappears. This is very surprising and counter-intuitive behavior.

Why don't we just suppress the delete key when pressing it would delete the object the slug is associated with? In some alternative editors like Google Docs, it is actually not possible to nuke the entire document by just pressing down the delete key at the top of the page -- it will stop before certain objects. I've never had any problems as a result.

That seems like the simplest solution to me and does not require a redesign of the slugs.
Today JohnCD asked again about this and I got another report from fr.wp, https://fr.wikipedia.org/w/index.php?title=Osmium&diff=96605232&oldid=93301425 .
Hoping this gets some love soon :)
*** Bug 52172 has been marked as a duplicate of this bug. ***
Created attachment 12988
Copy of http://i.imgur.com/39QQi8U.png

Please upload attachments to Bugzilla. imgur periodically prunes images; Bugzilla does not. :-)

**Attached**: {F10355}
Suggestion:
http://i.imgur.com/39QQi8U.png
**JohnCD67** wrote:

This causes trouble in the fairly common operation of removing a template (e.g. a PROD) from the top of a page which has an infobox. Click the template to select it, press "Delete" and it goes, leaving apparently a spare blank line at the top. The natural reaction is press "Delete" again to remove the blank line, and that takes out the info box. (Win7, FF22.0)
**joedecker** wrote:

I suspect this is behind a few of the reports (on the ENWIKI feedback page, some of them mine) in which unexpected deletions are caused.  

As a separate question, can you undo deletion of slugs?  If not, I think that would explain another set of problems others and I have observed.
Gotcha. A user was confused as to why they couldn't add a template to the top of an article without it appearing on the same line :).
(In reply to comment #4)
> Does this include the line of whitespace right at the start of articles?

Yes.
(In reply to comment #5)
> It looks like this bug was fixed somehow. I cannot longer reproduce it on
> dewiki.

Yes, we removed the slugs between lists because we felt they were no longer needed given the new editing tools, but they remain more widely.
It looks like this bug was fixed somehow. I cannot longer reproduce it on dewiki.
Does this include the line of whitespace right at the start of articles?
*** Bug 50295 has been marked as a duplicate of this bug. ***
*** Bug 50797 has been marked as a duplicate of this bug. ***
This is deliberate - the line is a "slug", allowing the user to insert text between the UL and the DL without creating a bullet and then down-converting it into a paragraph. We've been thinking about putting a little icon in slugs and making them a different height/etc. so it's obvious that they're not really "there" and are just places items can go.

Re-purposing this bug to talk about that. :-)
Coordinate template on dewiki not alienated. Shown as active hyperlink to the toolserver.

--------------------------
**Version**: unspecified
**Severity**: normal
**URL**: https://de.wikipedia.org/wiki/Breslauer_Platz_%28K%C3%B6ln%29
It looks like this is handled properly now. Reopen if you still experience this problem.
Interesting! The content (which is not labelled as an alien) is floated out from within a div (which is ve-ce-alienInlineNode). Inez/Christian, ideas?
Per community request; will throw in a change on Monday.

--------------------------
**Version**: wmf-deployment
**Severity**: enhancement
This is now deployed. Marking as fixed.
Change in gerrit 61382.
Request was via e-mail but http://vi.wikipedia.org/wiki/WP:TL#Tr.C3.ACnh_so.E1.BA.A1n_th.E1.BB.8B_gi.C3.A1c is an announcement on the wiki that this is coming for testing.
Any link to the community request, for the records?
If you scroll down from the top of the page with the edit notice open and then scroll back up, the text content of the notice 'throbs' a little. I think it has to do with the dynamic addition / removal of the 've-ui-toolbar-wrapper-floating' class on ve-ui-toolbar-wrapper.

--------------------------
**Version**: unspecified
**Severity**: trivial
Hi Ori. Can you please respond to James' comment?
Ori, I can't reproduce this locally (on Chrome, Safari or Firefox) - what browser were you using?
I tested it on the [[Bayes' theorem]] which has <Math></Math> inside the article with chrome 28 and it couldn't load the page!.

--------------------------
**Version**: unspecified
**Severity**: normal
Resolving as WORKSFORME as I cannot reproduce and there's been no further information about how to get this effect. Feel free to re-open if you have additional data to help us find out what went wrong for you.
I'm afraid I can't reproduce this - is this using MathJax? When I load the page https://en.wikipedia.org/wiki/Bayes'_theorem?veaction=edit (in Chrome or Firefox) I always get the <math> blocks rendered as PNGs instantly. Can you give some more information? A screenshot of the failed (partial?) rendering would be particularly useful.
No warning is shown when saving a page without an edit summary even when the "Prompt me when entering a blank edit summary" preference is enabled.

--------------------------
**Version**: unspecified
**Severity**: normal
Merged and will go out with wmf5.
Related URL: https://gerrit.wikimedia.org/r/64313 (Gerrit Change Idba707abaea8b08a94f7fa4d5bc5b1e35261a572)
When I edit an article in the English Wikipedia and hover over a template or an image, green diagonal stripes appear over it, meaning that it can't be edited.

These green stripes don't appear in the Hebrew Wikipedia.

See the URL for a demo.

--------------------------
**Version**: unspecified
**Severity**: normal
**URL**: https://he.wikipedia.org/wiki/ASCII
**orbit** wrote:

Yep, CSSJanus indeed. I've added /*@noflip*/ to the phantoms container to ensure proper positioning.
https://gerrit.wikimedia.org/r/61516 (Gerrit Change Id7662362d117d6c5719b9b98d7a0dbf62e9ba3ff) | change APPROVED and MERGED [by jenkins-bot]
Related URL: https://gerrit.wikimedia.org/r/61516 (Gerrit Change Id7662362d117d6c5719b9b98d7a0dbf62e9ba3ff)
Indeed, works in debug mode.

It's just a wild guess for now, but it may have something to do with CSSJanus.
It might be a cache issue - works just fine in debug mode - https://he.wikipedia.org/w/index.php?title=ASCII&debug=true
I'm able to reproduce at least in Chrome.
Steps:

1. Go to the URL.
2. Start editing the page using the VisualEditor.
3. Move the cursor using the keyboard arrow keys forward (right).

Observed:

When you get to the "Done" template and go on moving the cursor, the whole template disappears.

The same happens when you get to the reference number on the second line ("[1]").

The cursor must probably skip over them and definitely not make them disappear.

--------------------------
**Version**: unspecified
**Severity**: normal
**URL**: https://www.mediawiki.org/wiki/VisualEditor:Disappearing_template
And actually the desired behavior is not skipping over - it is selecting it (so you can delete if you want) - give it a try in Chrome.
I have a good reason to believe that this occurs only in Firefox and I just fixed it here: https://gerrit.wikimedia.org/r/#/c/61055/. If you get it in other browser then pelase reopen this bug.
Having users using different languages to post feedback on different pages on the same site makes it difficult to manage.

--------------------------
**Version**: unspecified
**Severity**: minor
Change 74064 merged by jenkins-bot:
Remove 'visualeditor-feedback-link' from RL module

https://gerrit.wikimedia.org/r/74064
Fixed. Sorry about this. Will be deployed this afternoon.
Change 74064 had a related patch set uploaded by Krinkle:
Remove 'visualeditor-feedback-link' from RL module

https://gerrit.wikimedia.org/r/74064
(In reply to comment #11)
> (In reply to comment #10)
> > pl.wiki is on 1.22wmf8 but my feedback was posted to a non-existing page with
> > Italian title (I have Italian UI), [[pl:Wikipedia:VisualEditor/Commenti]]:
> > https://pl.wikipedia.org/w/index.php?title=Wikipedia:VisualEditor/
> > Commenti&oldid=36959657
> 
> Confirmed, this is also happening to me. Did the code get broken somehow?

Somewhere between https://gerrit.wikimedia.org/r/#/c/68216/ and its parent (I can't seem to find the commit that added it) the message was added in VisualEditor.php's resource module definition. Which caused the message from VisualEditorMessagesModule (in content-language) to be overridden at run time by the one from ResourceLoader for user language.
(In reply to comment #10)
> pl.wiki is on 1.22wmf8 but my feedback was posted to a non-existing page with
> Italian title (I have Italian UI), [[pl:Wikipedia:VisualEditor/Commenti]]:
> https://pl.wikipedia.org/w/index.php?title=Wikipedia:VisualEditor/
> Commenti&oldid=36959657

Confirmed, this is also happening to me. Did the code get broken somehow?
pl.wiki is on 1.22wmf8 but my feedback was posted to a non-existing page with Italian title (I have Italian UI), [[pl:Wikipedia:VisualEditor/Commenti]]: https://pl.wikipedia.org/w/index.php?title=Wikipedia:VisualEditor/Commenti&oldid=36959657
Merged and will go out in wmf5.
*** Bug 48645 has been marked as a duplicate of this bug. ***
Related URL: https://gerrit.wikimedia.org/r/64498 (Gerrit Change I3804e6f91015ef9b8ae5196efb37475d714cd7d5)
(In reply to comment #5)
> Yes, that would fix this particular problem; my question is more as to
> whether
> the core tool should default for target link to be in the content language.

Based on what I see in the usage given above, you're giving a Title to core feedback tool, which points to a certain page, instead of a message name to core with feedback page name in that message.
Yes, that would fix this particular problem; my question is more as to whether the core tool should default for target link to be in the content language.
But there is:

modules/ve/init/mw/targets/ve.init.mw.ViewPageTarget.js:
		'title': new mw.Title( ve.msg( 'visualeditor-feedback-link' ) ),

shouldn't something like:

new mw.Title( ve.msg( 'visualeditor-feedback-link' ).inContentLanguage() )

be used?
(In reply to comment #2)
> I'm not sure what "core MW feedback tool" means, but I was talking about the
> feedback feature for [[Wikipedia:VisualEditor/Feedback]].

Yes, this is a core MediaWiki feature, it just happens to be used by VisualEditor:

  resources/mediawiki/mediawiki.feedback.js
I'm not sure what "core MW feedback tool" means, but I was talking about the feedback feature for [[Wikipedia:VisualEditor/Feedback]].
(Is this a bug in the core MW feedback tool?)
I tried to edit MediaWiki:Visualeditor-feedback-link on zhwp but it doesn't affect the feedback target page at all. Is that even the correct message to change?

I then turn the target page into a redirect, but feedback are still sent to that page without following the redirect.

--------------------------
**Version**: unspecified
**Severity**: enhancement
Fixed in 96c4e453ecfaba9cc5dca904301981e9d6e3492b (https://gerrit.wikimedia.org/r/#/c/143171/).
(In reply to comment #0)
> I tried to edit MediaWiki:Visualeditor-feedback-link on zhwp but it doesn't
> affect the feedback target page at all. Is that even the correct message to
> change?

Yes, that is the correct message; you can set it for all zh-hans or zh-hant projects at [0] and [1] and it will respect it (once the software is updated).

[0] - https://translatewiki.net/w/i.php?title=Special:Translate&language=zh-hans&group=ext-visualeditor
[1] - https://translatewiki.net/w/i.php?title=Special:Translate&language=zh-hant&group=ext-visualeditor

> I then turn the target page into a redirect, but feedback are still sent to
> that page without following the redirect.

You're right; this is a bug in the feedback tool, which is part of MediaWiki core. Moving the bug there.
Try typing non-ASCII characters in the VisualEditor edit summary field. For example, just type the Russian letter ж continuously. Towards the end it won't stop at 0, but at -1. Example screenshot from the Hebrew Wikipedia: http://j.mp/ZoQKX6 .

This should be handled in a cleaner way. Either disallow typing anything that would go beyond zero, or allow all text to go beyond zero, as in Twitter or MoodBar.

--------------------------
**Version**: unspecified
**Severity**: minor
Merged; will go out with wmf5.
Fixed in https://gerrit.wikimedia.org/r/#/c/64342/

To clarify, we aren't letting people go over the limit, we just aren't updating the counter after keyup. (If you get to -1 then press an arrow key, you'll see you're actually under the limit).
Steps:

1. Write some text in VisualEditor in the Hebrew Wikipedia.

2. Select a word.

3. Press the link button in the toolbar. A small link insertion panel appears.

Observed: The direction of the <input> element for the link is ltr.

Expected: The direction of the <input> element for the link is supposed to be rtl.

Comment: It does make sense to set ltr direction by default for external links (http://www.example.com). For internal links the default direction should be the same as that of that Wikipedia's content language.

--------------------------
**Version**: unspecified
**Severity**: normal
Merged in Moriel's fix (thanks!).
Related URL: https://gerrit.wikimedia.org/r/61960 (Gerrit Change Ic13b9c3b155ce2979298cac9518c7419b9d45bac)
Moriel wants to take a stab at this one; assigning.
(In reply to comment #1)
> Eurgh. That's a real mess of a user interaction - in an RTL locale, it starts
> as RTL, but then you type enough of a string that looks a bit like
> "http?://www" it magically switches to LTR?

This is not such a mess as a matter of fact. This works very well in GMail chat, for example. If you start typing Hebrew characters, it switches the input box to RTL and vice versa. It also goes further: if you type a few Hebrew characters, and then a lot of Latin characters, it switches to LTR.

BUT -and this is very important- it is not forced: the user can switch the direction later manually. In most Windows browsers it's done using Ctrl-Shift, in Firefox on Windows and GNU/Linux it's done using Ctrl-Shift-X. I don't know about Mac browsers, but it's probably something similar. (I do know that it's impossible on Chrome in Linux, which is why I almost never use it.)

> What about when your wiki page that
> you're internally linking to is [[http://www.amazon.com]] - do you show as
> LTR
> even though it's actually an internal link? How does this get handled in
> other
> software?

Same as above, essentially. One thing that could help here would be a possibility to specify the language of the page and of the title, as in bug 34514. But that's extra icing. For a link insertion dialog it is enough to do automatic detection with a possibility to override manually.
(In reply to comment #0)
> Comment: It does make sense to set ltr direction by default for external
> links (http://www.example.com). For internal links the default direction should
> be the same as that of that Wikipedia's content language.

Eurgh. That's a real mess of a user interaction - in an RTL locale, it starts as RTL, but then you type enough of a string that looks a bit like "http?://www" it magically switches to LTR? What about when your wiki page that you're internally linking to is [[http://www.amazon.com]] - do you show as LTR even though it's actually an internal link? How does this get handled in other software?
--------------------------
**Version**: unspecified
**Severity**: trivial
*** This bug has been marked as a duplicate of bug 48017 ***
If users can't edit in nowiki blocks, they will make accidental wikitext-like items and be forever unable to edit them in future.

--------------------------
**Version**: unspecified
**Severity**: enhancement
*** Bug 51950 has been marked as a duplicate of this bug. ***
Done and merged.
Change 74107 merged by jenkins-bot:
Add a node class for mw:Nowiki

https://gerrit.wikimedia.org/r/74107
Change 74107 had a related patch set uploaded by Catrope:
Add a node class for mw:Nowiki

https://gerrit.wikimedia.org/r/74107
Theoretically users should never know something's been <nowiki>'ed - possibly we could just silently drop them and Parsoid re-applies them automatically on save?

(This assumes we can rely on Parsoid to do this with no or very few false negatives - false positives, which we already have a little of, wouldn't be a huge problems for VE users.)
*** Bug 47677 has been marked as a duplicate of this bug. ***
The 'cancel' message is used confusingly.

I only noticed it recently. I know of two places where it is used, though there may be more:

1. As a link near the "Show changes" button when editing a page.

2. As a button near the "Review and save" button in the VisualEditor.

In both cases it's better to say something like "Exit without saving". The "Cancel" button is usually used in dialog boxes and not in editors' user interfaces.

The message may be used in other places and in extensions, so it's probably better not to change it. For these actions a new message should be created, or maybe even two messages.

--------------------------
**Version**: unspecified
**Severity**: trivial
Indeed. :-)
Hehe, it was removed eventually :)
Deciding to WONTFIX this, per discussion above. Hopefully it will be more understandable anyway, given the forthcoming changes to the save dialog.
I read your concern, Amir, and my opinion is similar to that of James. In computer interaction, clicking a button that says Cancel will end the current action (in this case editing a page) without actually committing the changes that the actor made. I see no deviation from that paradigm in the two use cases you describe.

I think we shoild close this issue without implementing the suggestion made.
Worry that this is a bit long for users, and "cancel" is used in the dialog sense (they entered an editor, this cancels that edit) but I can see your point.

(BTW, your two descriptions are for the same button, unless I'm missing something?)
Take a look at the URL.

When you see the output page, the list has three items. If you edit it in the source editor, you'll see that there's an extra empty item in the end of the list. If you edit it in the VisualEditor, you'll see it rendered.

The VisualEditor behavior actually makes more sense to me. Gabriel Wicke suggested on IRC to open this issue at the PHP parser.

--------------------------
**Version**: 1.22.0
**Severity**: normal
**URL**: https://www.mediawiki.org/wiki/VisualEditor:Empty_list_item
The goal of fixing templates to not emit empty list items in the first place ( T49673#1827449 ) is not in sight. For now, the core part of this ticket has been addressed. Empty elements no longer go missing with Tidy which means we can replace Tidy without worry about breaking rendering because of this.

Longer term, we should migrate to a CSS3 fix of li:empty { display:none; } and remove the mw-empty-elt class.
It would be easier to fix such templates if we finally got around to allowing blank lines between list items without breaking the list. This has been requested very often, although unfortunately the narrower, more sensible proposals on the subject (e.g. T11342, T35918, T15223) have been closed as duplicates in favour of the more aggressive proposal T3115.
It would be easier to fix such templates if we finally got around to allowing blank lines between list items without breaking the list. This has been requested very often, although unfortunately the narrower, more sensible proposals on the subject (e.g. T11342, T35918) have been closed as duplicates in favour of the more aggressive proposal T3115.
>>! In T49673#1776557, @Jonesey95 wrote:
> I don't have the gerrit skills to parse the code to understand whether this change will allow a page to emit a tracking category specific to monitor articles and templates that need to be updated. If it will, some instruction would be helpful. If it currently will not, please make whatever code modification is necessary to allow a page to emit such a tracking category. Thank you. 

There's no tracking category at the moment. I wanted to assess it myself, to determine the size of the problem, before creating task lists for others to work through.

[[https://www.mediawiki.org/wiki/User:Tim_Starling/Empty-li-log|Here is a log sample]] from parsoid listing some supposedly empty <li> elements. I have analysed some of them.

[[https://en.wikipedia.org/w/index.php?title=Template:Europe_topic&oldid=675002623&action=edit |Here is a notable example]] of a template which depends on empty li removal. This navbox template allows the removal of countries from Europe depending on parameters. For example if you consider Germany to not be part of Europe, you can use {{Europe topic|DE=}} to make a navbox which omits the relevant list item. Note that you can't just take the asterisk inside the #if, because that would create paragraph breaks between adjacent list items. It could be done by taking the line break inside the #if, or by removing all the line breaks and using HTML-style <li> input.
Change 253514 merged by jenkins-bot:
Add 'mobile' target to 'mediawiki.raggett' module

[[https://gerrit.wikimedia.org/r/253514]]
Change 253514 had a related patch set uploaded (by Legoktm):
Add 'mobile' target to 'mediawiki.raggett' module

[[https://gerrit.wikimedia.org/r/253514]]
The CSS trick for do not display element with //mw-empty-li// class works only for Desktop, not in mobile version.

It's possible in this transitory period hide the empty list elements also in mobile site? Thanks

See [[https://it.wikipedia.org/w/index.php?title=Discussioni_progetto:Coordinamento/Template&oldid=76516793#Errore di visualizzazione da mobile | discussion ]] (in italian) and [[https://it.m.wikipedia.org/wiki/Kriszti%C3%A1n_Adorj%C3%A1n|example]].
This tasks seems to be related to a lot of odd looking [[Template:Authority control]] templates that use //hlists// which suddenly started showing rows of dots between entries

# Commons issues and the fix was discussed at https://www.mediawiki.org/wiki/Talk:Snippets/Horizontal_lists
# Czech Wiki opted for rewriting the template https://cs.wikipedia.org/wiki/%C5%A0ablona:Autoritn%C3%AD_data?diff=13027629&oldid=12931367
# Other wikis were spared because they already rewrote the template in Lua
I don't have the gerrit skills to parse the code to understand whether this change will allow a page to emit a tracking category specific to monitor articles and templates that need to be updated. If it will, some instruction would be helpful. If it currently will not, please make whatever code modification is necessary to allow a page to emit such a tracking category. Thank you.
Change 246148 merged by jenkins-bot:
Client-side migration for empty li preservation

[[https://gerrit.wikimedia.org/r/246148]]
Change 246148 had a related patch set uploaded (by Tim Starling):
Client-side migration for empty li preservaton

[[https://gerrit.wikimedia.org/r/246148]]
I'm going to introduce a migration tool to fix this bug, roughly following @cscott's suggestion, which is to preserve empty <li> tags through Tidy, but to add a class to those preserved elements which will be styled with display:none. It is believed that there are some templates which are producing empty list items because it is convenient for them as a way of omitting the list item for empty input. After the display:none hack is introduced, a user script would allow the expected changes to be visible to template maintainers. There is also a proposed change to log affected templates: https://gerrit.wikimedia.org/r/#/c/246106

After a suitable migration period, the display:none rule would be removed, and list items would be visible as is desired by the multiple reporters of this bug.

The empty <li> tags would be preserved through tidy by adding a datafld attribute, exploiting special case behaviour in Tidy's CanPrune() which was intended to fix http://sourceforge.net/p/tidy/bugs/337/
*** Bug 52374 has been marked as a duplicate of this bug. ***
**Author:** `owen`

**Description:**
Looking at [[Principality of Stavelot-Malmedy]] in the Visual Editor, immediately after the heading "Development and the High Middle Ages" there are two images floated right.

In Read mode, these images are given `float: right; clear: right;`. In VE mode, however, the `clear: right;` appears to be missing, so the images are stacking up.

In case it makes a difference, I'm running Chrome 26.0.1410.64 m, on 64-bit Windows 7 Home Premium (Build 7601, Service Pack 1).

--------------------------
**Version**: unspecified
**Severity**: normal
**URL**: http://en.wikipedia.org/wiki/Principality_of_Stavelot-Malmedy
This was fixed by gerrit 64367 which is now merged, but is 'experimental' and
so will not go out for a short while. Marking as fixed within wmf5, though.
This is because Parsoid outputs completely different HTML for images (using <figure> and what not) that doesn't match the MediaWiki CSS.

This will be fixed once we change the ce.MWThumbImageNode rendering to match the MW rendering rather than the Parsoid rendering, and move image support out of the experimental list.
Confirmed - the DM layer for alien items (like images) apparently respects the CSS and is meant to pass it through, but CE isn't?
A long title all mixed

Long titles get compressed until they become unreadable, see URL and screenshot.

--------------------------
**Version**: master
**Severity**: minor
**URL**: https://meta.wikimedia.org/w/index.php?title=Special:Translate&language=de&group=page-Wikimedia+Blog%2FDrafts%2FTry+out+the+alpha+version+of+the+VisualEditor%2C+now+in+15+languages&filter=&action=page
**See Also**:
https://bugzilla.wikimedia.org/show_bug.cgi?id=45924

**Attached**: {F10857}
Created attachment 12173
Same long title just partly overlapping in another browser

**Attached**: {F10858}
1. Parsoid not running, VisualEditor enabled on to-be-created page X
2. Enter a few words 
3. "Review and Save"
4. Loader keeps spinning indefinitely

Request:

action=visualeditor&paction=serialize&html=%3Cp+data-ve-changed%3D%22%7B%26quot%3Bcontent%26quot%3B%3A7%7D%22%3Edfgdg%3C%2Fp%3E&page=Sandbox%2F1&oldid=0&token=%2B%5C&format=json

Response:

{"visualeditor":{"result":"success","content":false}}

No errors.

Note this bug could also be reported as "Loader keeps spinning forever when creating a new page and trying to review/save it"

--------------------------
**Version**: unspecified
**Severity**: normal
Merged into master; will go out with wmf5.
Related URL: https://gerrit.wikimedia.org/r/63861 (Gerrit Change I6bdd177bc9b5a0af9107cf08d8e46470c6778e12)
(In reply to comment #1)
> Related URL: https://gerrit.wikimedia.org/r/60613 (Gerrit Change
> Icdf64a792c13a326f494e051be47f2946928d142)

This fixed the visible problem described below:

(In reply to comment #0)
> as "Loader keeps spinning forever when creating a new page and
> trying to review/save it"

The error is now handled by stopping the spinner (as we always do after an aborted load) and display the error.

The error message in my case was "No Wikitext content in response from server" triggered from ve.init.mw.Target.onSerialize's patch where there are no errors and eventually finds this by type-checking the content property.

Lowering priority. Todo tasks:

* Don't return status "success" if content is missing, but use status "error".

* Make it not just status "error" but actually trigger a proper API response.error property with a more direct error, namely that the Parsoid server is unavailable.
Related URL: https://gerrit.wikimedia.org/r/60613 (Gerrit Change Icdf64a792c13a326f494e051be47f2946928d142)
As a VisualEditor plugin inside the extension, provide a visual way for users to create and edit musical scores.

This would be a (very) major undertaking, even if there is an existing JavaScript-based visual Lilypond score editor, or failing that, a visual score editor with a different output format which would need to be converted to Lilypond. A brief search found a few promising leads for ABC editors, but mostly based in Flash.

Still, hopefully not just a pipedream. :-)

--------------------------
**Version**: unspecified
**Severity**: enhancement
Note that as of November 2015 there is a nice previewing editor for Scores, but it's still based on the Lilypond or ABC source format rather than a visual one.
>>! In T49528#1003822, @Tgr wrote:
> Just adding a text editor with a preview button, like e.g. [[ http://lilybin.com/ | lilybin.com ]] does it, does not sound that hard.

Indeed, but this task is asking for a visual drag-and-drop sheet music editor.

> I wonder if that could even be a generic fallback option for tag-based parser extensions without a dedicated editor plugin.

That's already provided in VisualEditor.
Just adding a text editor with a preview button, like e.g. [[ http://lilybin.com/ | lilybin.com ]] does it, does not sound that hard. I wonder if that could even be a generic fallback option for tag-based parser extensions without a dedicated editor plugin.
See also
http://lists.wikimedia.org/pipermail/wikitech-l/2013-June/069973.html
On VE load, do an "originalHtml == serialise(linmod(originalHtml)" or whatever and fail out of the VE if false; ideally, also allow the user to submit a failure report for debugging purposes (this will need to get checked through with legal).

--------------------------
**Version**: unspecified
**Severity**: major
Written and about to be deployed.
Change 70106 merged by jenkins-bot:
mw.ViewPageTarget: Add sanity check for DOM roundtrip

https://gerrit.wikimedia.org/r/70106
Change 70106 had a related patch set uploaded by Krinkle:
mw.ViewPageTarget: Add sanity check for DOM roundtrip

https://gerrit.wikimedia.org/r/70106
Any news on this? 

Having some automated general sanity checks on the returned wikitext (for example size, check if it starts with a doctype) would also be good, especially now that users don't see a diff by default any more. If any of the automated sanity checks fail, you should probably ask the user to review changes before saving. This should catch most major article corruption issues before they happen.
Pulling.
Roan's offered to do this one on his flight. Marking as such.
We are diffing on the DOM on the way in, but while debugging a text diff is useful too.

Order preservation is not guaranteed in the DOM4 spec afaik, but is implemented and supported nevertheless using the attributes collection and numerical indexing: https://developer.mozilla.org/en-US/docs/DOM/Node.attributes
We wouldn't be doing string-based comparisons, we'd be doing DOM-based comparisons. That's what Parsoid should be doing too, IMO.

If comparisons are DOM-based, quoting style and attribute order don't matter. In general, I don't believe there's a way to read or write attribute order in the DOM.
A common issue currently is changes in attribute order and a change of quoting style for JSON attributes. It would be great if VE could preserve the order of attributes. 

For the quoting, we have some smart quoting code that you could reuse. Alternatively, you can compare the innerHTML of the original DOM with the exported DOM as that implicitly changes JSON attribute quoting to the verbose style.
The "language conversion blocks" are a wikitext feature that allow users to define text content in parallel scripts. The most high profile is in Chinese, which has two major writing systems and automated conversion between them, but there are 28 others, some of which are not automated conversion (so VE will need to not just mark the text with an appropriate <span>, but allow the user to understand when they have edited text that needs editing twice or thrice (possibly in scripts they cannot/do not want to use?) - see https://meta.wikimedia.org/wiki/Wikipedias_in_multiple_writing_systems

Documentation of the feature (focussed on the syntax) is here: https://www.mediawiki.org/wiki/Writing_systems/Syntax

Parsoid will need to add support for this first, which is {T43716}.
>>! In T49411#3691289, @Deskana wrote:
> I believe there's still more outstanding here, right?

Yes, see  {T43716} - phase 1 support is complete, which brings VE to parity with the PHP parser -- in both cases, as soon as you start to edit the page you're confronted with the raw un-converted text (not the text in your preferred variant).

VE can do better (in theory) -- that's "phase 3" of T43716.  But that's probably another bug.  Since VE is now at parity with PHP source editing, I think this task can be resolved, and we'll open specific bugs for deficiencies in the current UX (ie, T182910).  I'll open a new task for the VE side of Parsoid's phase 3, once we get there, but that's a new feature.
I believe there's still more outstanding here, right?
Change 361921 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Inspectors for editing LanguageConverter markup

[[https://gerrit.wikimedia.org/r/361921]]
Change 358396 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Context item for LanguageConverter markup

[[https://gerrit.wikimedia.org/r/358396]]
Change 356739 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Display LanguageConverter markup in VisualEditor

[[https://gerrit.wikimedia.org/r/356739]]
See https://www.mediawiki.org/wiki/Parsoid/Language_conversion#Testing_LanguageConverter_with_Parsoid_and_VisualEditor for setup & test hints.
Change 361921 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/extensions/VisualEditor@master] WIP: Dialog for editing LanguageConverter markup

[[https://gerrit.wikimedia.org/r/361921]]
Change 358396 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/extensions/VisualEditor@master] Node inspector for LanguageConverter markup

[[https://gerrit.wikimedia.org/r/358396]]
Change 356739 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/extensions/VisualEditor@master] WIP: Specialized inspector for LanguageConverter markup

[[https://gerrit.wikimedia.org/r/356739]]
@cscott Any updates for us on this since it's reopened? :-)
If we get an MWTemplateNode and the user doesn't change it, then in the data->DOM conversion we should serialize it back out the way it came in, including all the other nodes (the template contents) that we normally discard.

Discarding these nodes when the user did change the template (i.e. the attributes changed) is fine and encouraged, but if we also do it when nothing changed, Parsoid's DOM diff algorithm will notice that we changed something in the DOM, causing selective serialization not to skip the template while it should.

--------------------------
**Version**: unspecified
**Severity**: normal
Related URL: https://gerrit.wikimedia.org/r/60110 (Gerrit Change I2bbb5d2d6a90c4eb87fa129671112c92a9b931e7)
1. Go to: http://ve-change-marking.instance-proxy.wmflabs.org/wiki/Test2
2. Open page in VisualEditor
3. Open browser console.
4. Run ve.dm.converter.getDomFromData( ve.instances[0].documentModel.store, ve.instances[0].documentModel.data.data ).body.outerHTML
5. You get the following output:
--------------
<body><table data-parsoid="{&quot;tsr&quot;:[0,3],&quot;dsr&quot;:[0,49,3,2]}">
This is a caption
<tbody data-parsoid="{&quot;dsr&quot;:[24,47,0,0]}"><tr data-parsoid="{&quot;tsr&quot;:[24,26],&quot;startTagSrc&quot;:&quot;|-&quot;,&quot;autoInsertedEnd&quot;:true,&quot;dsr&quot;:[24,46,2,0]}">
<td data-parsoid="{&quot;tsr&quot;:[27,28],&quot;autoInsertedEnd&quot;:true,&quot;dsr&quot;:[27,46,1,0]}">Table cell content</td></tr>
</tbody></table></body>
----------------

Notice the missing <caption> .. </caption> tags.
So, when Parsoid gets this, the caption is fostered out and shows up as a diff.

--------------------------
**Version**: unspecified
**Severity**: major
...which has already been merged.
https://gerrit.wikimedia.org/r/59780
See bug 45808 for the corresponding Parsoid bug.

Currently editing a redirected page (say "OLPC") causes the following Bad Things to happen.

a) the edited page content is saved back to "OLPC", overwriting the original #REDIRECT

b) the page content is from "One Laptop Per Child", but with an added {{Redirect:OLPC}} template at the top; this extra template gets saved back with the rest of the edits.

In bug 45808, Parsoid will return a special <meta> or <link> tag in the body for redirected pages.  This bug is for the corresponding VE support to recognize that tag and provide a user-friendly interface for editing redirects.

--------------------------
**Version**: unspecified
**Severity**: enhancement
**See Also**:
https://bugzilla.wikimedia.org/show_bug.cgi?id=47329
(In reply to Gerrit Notification Bot from comment #10)

Neat! Is there documentation about this panel and/or a place to test it?
Change 95213 merged by jenkins-bot:
Let users set #REDIRECT and __STATICREDIRECT__ status

https://gerrit.wikimedia.org/r/95213
Change 95213 had a related patch set uploaded by Jforrester:
[WIP] Let users set #REDIRECT

https://gerrit.wikimedia.org/r/95213
Change 95103 had a related patch set uploaded by Jforrester:
[WIP] Let users set #REDIRECT, __NOTOC__, & __FORCETOC__

https://gerrit.wikimedia.org/r/95103
It is also possible to fail to convert a non-redirect page into a redirect (e.g following a merge).
This is likely obvious to everyone, but:  We need a way to create redirects in VisualEditor from redlinks.

VE is currently (02 July 2013) turned off for editing redirect pages at en.wikipedia.org.  However, it's still possible to create these pages using VE, which end up nowiki-ed and broken.
Assigning to Jiabao Wu as discussed on bug 48489 comment 4.
Redirect editing disabled by https://gerrit.wikimedia.org/r/64275, will need to be re-enabled when this bug is addressed.
Some quick advice on this one:

* There'll need to be code in DM and UI; the code in Parsoid which it will interact with has just been merged into their master.
* I'd suggest looking at how {{DEFAULTSORT}} works as a starting point - see https://gerrit.wikimedia.org/r/#/c/61374/ for the DM side.
* On the UI side, you'd want to create a new panel in the meta-data dialog ("Page settings" is probably the best name, though that's also the display name of the dialog, but we can fiddle with that later) into which you'd put a checkbox with an associated text box for a page name, with auto-suggest (like the link inspector has).
There's now a spec for redirects in the DOM: http://www.mediawiki.org/wiki/Parsoid/MediaWiki_DOM_spec#Redirects
This is probably a post-July task; have split off a "don't fail horribly" bug as bug 47329, linked.
Since at 2013-04-05 04:29:46 UTC, Zuul no more receives events from Gerrit. It uses a CLI command such as:

    ssh -p 29418  jenkins-bot@manganese.wikimedia.org gerrit stream-events

I did stream-events using both the jenkins-bot user and my own account 'hashar'. While submitting a new patchset or posting a comment: nothing is reported.

The end effect is that no jobs are triggered in Jenkins.

--------------------------

Summary (13/12/2017)

The sshd daemon (Mina) would lost connection on one way connections and hitting some kind of timeout.  That affected Zuul which idles with a `gerrit stream-events`.

Gerrit sshd.idleTimeout got set to 10 days as a workaround https://gerrit.wikimedia.org/r/#/c/58126/

Gerrit patch:

https://gerrit-review.googlesource.com/c/gerrit/+/44472 ([[ https://gerrit.googlesource.com/gerrit/+/79b91bfe746121a81a785bdd3b24df2096410c55 | 79b91bfe ]]) is the Gerrit patch.
(In reply to comment #24)
> We previously rolled back to a gerrit that exposed the problem again :-(
> 

To expand on this, last week when we tried upgrading to 2.7-rc1-424-gef469ac we hit a bunch of problems so we rolled back. However, I rolled too far back to 2.6-rc0-144-gb1dadd2.war instead of 2.6-rc0-154-gfcdb34b which lacked the SSH timeout fix mentioned above.
We previously rolled back to a gerrit that exposed the problem again :-(

In case we ever do this again: To keep the zuul<->gerrit connection
alive, it suffices to have at least one event fed to zuul each 10
minutes.

So for example clone our gerrit-ping repo.
Restore
  https://gerrit.wikimedia.org/r/#/c/58060/
Fetch patch set 1.
And run

  while true ; do date ; ssh gerrit.wikimedia.org gerrit review -m "'recheck'" --verified 0 75be73703978e75a25d5e3bb5685c51580af3060 ; sleep 240 ; done

in a shell (I had ssh configured to automatically supply username and gerrit port).

Gerrit 2.6-rc0-154-gfcdb34b is the first version that we deployed and
contained the fix.
*** Bug 49330 has been marked as a duplicate of this bug. ***
(In reply to comment #21)
> Lowering priority and severity since we have a workaround now.

Now actually doing so for priority too.
Lowering priority and severity since we have a workaround now.
*** Bug 47004 has been marked as a duplicate of this bug. ***
Deployed the upstream patch just now.
(In reply to comment #12)
> (In reply to comment #10)
> > https://gerrit-review.googlesource.com/#/c/44351/
> > got submitted to upstream gerrit.
> > 
> 
> It hasn't been reviewed / merged yet however. How long are we willing to
> wait?
> Can we apply it to our fork for now?
> 
> Jenkins being down is causing lots of workflow problems throughout the
> different projects.

We don't have a fork, we use vanilla Gerrit :)
But yes, I'm looking into deploying this now rather than waiting on upstream to merge.
Until we can deploy a new gerrit build, we prevent timeouts by forcing a
recheck on
https://gerrit.wikimedia.org/r/#/c/58060/
every 4 minutes.
Related URL: https://gerrit.wikimedia.org/r/58063 (Gerrit Change I431ff970596aae03b3ab5276303ed18574892b13)
Related URL: https://gerrit.wikimedia.org/r/58060 (Gerrit Change Ie0b3b0a5d77a2192abd09a934e780b8e622a1edd)
Related URL: https://gerrit.wikimedia.org/r/58059 (Gerrit Change Ie0b3b0a5d77a2192abd09a934e780b8e622a1edd)
(In reply to comment #10)
> https://gerrit-review.googlesource.com/#/c/44351/
> got submitted to upstream gerrit.
> 

It hasn't been reviewed / merged yet however. How long are we willing to wait? Can we apply it to our fork for now?

Jenkins being down is causing lots of workflow problems throughout the different projects.
Raising importance, this needs fixing ASAP. We need testing. Not just to save work, but because we (and by design and intention) rely on it automatically happen and performing the merge action on approval.

Also the lack of postmerge events is blocking (auto-deploy for certain projects).
Although I cannot reliably reproduce the problem, the culprit seems to
be gerrit's version bump of Apache SSHD to 0.6.0, which comes with
closing of idle ssh connections.

Upon 10 minutes of inactivity, gerrit disconnects Zuul, and Zuul has
to reconnect. Gerrit accepts the connection, but sometimes refuses to
stream events over the new connection. There seems to be some race
condition in gerrit when Zuul reconnects.

We can mitigate the problem by having at least 1 commit every 10
minutes... Go, programmers go :-))

To also have a solution until we get that commit density 24/7,
https://gerrit-review.googlesource.com/#/c/44351/
got submitted to upstream gerrit.

(We cannot simply downgrade gerrit to the last known good version, as
that would require database schema downgrading, which currently is not
supported by gerrit)
Stuck again but this time show-queue gives me:

Task     State                 Command
------------------------------------------------------------------------------
5229a073                       git-upload-pack '/mediawiki/extensions/VisualEditor' (shirayuki)
aad42f27 07:18:57.201          inside-wmf/mediawiki/extensions/FundraisingEmailUnsubscribe
------------------------------------------------------------------------------

Logged a message on IRC about it and pinged ops list.
Changing back to git/gerrit. Zuul has no issue, it is Gerrit holding the events and not emitting them.
The Zuul log is full of the following:

2013-04-06 17:02:55,441 ERROR gerrit.GerritWatcher: Exception on ssh event stream:
Traceback (most recent call last):
  File "/usr/local/lib/python2.7/dist-packages/zuul-0.0.151.e9d929a-py2.7.egg/zuul/lib/gerrit.py", line 68, in _run
    self._listen(stdout, stderr)
  File "/usr/local/lib/python2.7/dist-packages/zuul-0.0.151.e9d929a-py2.7.egg/zuul/lib/gerrit.py", line 52, in _listen
    self._read(stdout)
  File "/usr/local/lib/python2.7/dist-packages/zuul-0.0.151.e9d929a-py2.7.egg/zuul/lib/gerrit.py", line 39, in _read
    data = json.loads(l)
  File "/usr/lib/python2.7/json/__init__.py", line 326, in loads
    return _default_decoder.decode(s)
  File "/usr/lib/python2.7/json/decoder.py", line 366, in decode
    obj, end = self.raw_decode(s, idx=_w(s, 0).end())
  File "/usr/lib/python2.7/json/decoder.py", line 384, in raw_decode
    raise ValueError("No JSON object could be decoded")
ValueError: No JSON object could be decoded
(In reply to comment #4)
> Ariel restarted Gerrit on manganese. That unbroken the stream-events thus
> cleaning the issue.

Thanks. Lowering priority.
Ariel restarted Gerrit on manganese. That unbroken the stream-events thus cleaning the issue.

I am leaving this bug open for monitoring / investigation.  There must be some regression in Gerrit since we upgraded it yesterday.
Restarted Zuul just in case: nothing. Definitely on Gerrit side.
Gerrit has been upgraded with https://gerrit.wikimedia.org/r/#/c/57508/
Which got merged on Apr 4, 2013 20:29 (UTC).

Apparently Gerrit got restarted at 20:44 (UTC), the Zuul log shows errors 500 at that time.

The last event received by Zuul was on 2013-04-05 04:26:56 (UTC) then the JSON events cant be decoded / are not received:

2013-04-05 04:29:46,092 ERROR gerrit.GerritWatcher: Exception on ssh event stream:
Traceback (most recent call last):
  File "/usr/local/lib/python2.7/dist-packages/zuul-0.0.151.e9d929a-py2.7.egg/zuul/lib/gerrit.py", line 68, in _run
    self._listen(stdout, stderr)
  File "/usr/local/lib/python2.7/dist-packages/zuul-0.0.151.e9d929a-py2.7.egg/zuul/lib/gerrit.py", line 52, in _listen
    self._read(stdout)
  File "/usr/local/lib/python2.7/dist-packages/zuul-0.0.151.e9d929a-py2.7.egg/zuul/lib/gerrit.py", line 39, in _read
    data = json.loads(l)
  File "/usr/lib/python2.7/json/__init__.py", line 326, in loads
    return _default_decoder.decode(s)
  File "/usr/lib/python2.7/json/decoder.py", line 366, in decode
    obj, end = self.raw_decode(s, idx=_w(s, 0).end())
  File "/usr/lib/python2.7/json/decoder.py", line 384, in raw_decode
    raise ValueError("No JSON object could be decoded")
ValueError: No JSON object could be decoded
This is a major regression in our development workflow.
All HTML preservation should be changed to store the full HTML of the node/annotation and use the HTML store. This means removing the html/* attributes from nodes, and the strange things (original tag name and attributes) we put in annotations.

--------------------------
**Version**: unspecified
**Severity**: normal
Roan tells me we went in a different direction with this.
This also needs corresponding changes in the CE code for whitelisted rendering.
Though T41598 will mean that VisualEditor will be able to edit infoboxes as they are now (alongside other templates), in the near-future Wikidata will replace a great many of the entries in these infoboxes with Wikidata queries (syntax still to be locked down).

For the VisualEditor to be truly useful for users in this context, users should be able to:
* add, review, modify and remove references to existing Wikidata queries;
* add or amend arbitrary Wikidata queries for the above; and
* do so in both VisualEditor-mode contexts (paragraphs of text etc.) and wikitext-mode contexts (like the template dialog as it will initially be).

--------------------------
**See Also**:
{T41598}
Is this task related to {T131661} or vice versa?
[[ https://de.wikipedia.org/wiki/Wikipedia_Diskussion:Wikidata#Listenerstellung | Here ]] I made a detailed proposal for a mechanism to edit Wikidata claims in every mode you can view a page. (wikitext, visual editor, preview, view).

If you are interested, I can transakte it form German to English.
[[ https://de.wikipedia.org/wiki/Wikipedia_Diskussion:Wikidata#Listenerstellung | Here ]] I made a detailed proposal for a mechanism to edit Wikidata claims in every mode you can view a page. (wikitext, visual editor, preview, view)
I consider this very important. We'll unfortunately not be able to dedicate resources to this in the near future. Does your team have them? We should discuss in this case how exactly this should all look like in the end.
[replacing wikidata keyword by adding CC - see bug 56417]
* Make toHTML() return real DOM nodes, we don't need the weird construction for CE any more
* Pass in the content so it's possible to have rules like "if the annotation only covers whitespace, strip it"

--------------------------
**Version**: unspecified
**Severity**: normal
It's a T39835 issue.
I didn't know whether to reopen this or add a note to T39835, but looks like it's still possible to [[ https://fr.wikipedia.org/w/index.php?title=Asselin_(entreprise)&curid=8746091&diff=113502024&oldid=112208671 | create an empty wikilink ]]?
Now done.
Steps to reproduce issue:
* MediaWiki + VisualEditor (no Parsoid)
* Edit page (dims the page while loading)
* Error pops up (parsoidserver-http-curl-error)
* Cancel

Expected:
 Page undims.

Actual:
 Page still dimmed.

--------------------------
**Version**: unspecified
**Severity**: normal
Change-Id: I91ad2b110c2c523a4bb367407e3f33a953328ab4

That should fix it for now (quick fix). I'm now going to look into how much of this can be refactored to avoid this in the first place. It's all a bit too fragile.
Caused by I7769bd5a5b79f1ab36f258ef9f2be583ca503ce6.

In the refactoring Trevor moved the initialisation of the DOM element for the save/cancel buttons from the ve.init.mw.ViewPageTarget constructor to ve.init.mw.ViewPageTarget#setupToolbarButtons, which isn't called until after a successful load.

So, when #load() is called from #activate() and fails a loadError is emitted. onLoadError then calls #deacativate() which calls #tearDownToolbarButtons()

But tearDownToolbarButtons is unable to call this.toolbarCancelButton.removeAllListeners because the button doesn't exist yet because setupToolbarButtons was never called.
1. Load the 'aliens' example document.
2. Place the cursor in front of the first 'Lorem' and hit the link button.
3. Observe the exception

--------------------------
**Version**: unspecified
**Severity**: normal
Marking as fixed for -04-01 as it wasn't for -03-18.
Looks to be fixed in master now. Not sure which commit did it....
Ed, I can't reproduce it the way you described it. Please note that around first 'Lorem' (first paragraph) there is no alien (inline nor block).
**Author:** `lukebenes`

**Description:**
I see from [http://en.wikivoyage.org/wiki/Wikivoyage:Accommodation_listings The Accomodations Listing suggested style you want people to continue to use the wikitravel tags. But I do not see any tools to automate the process. 

If you look at the Add and Edit Listing Feature listing like those that can be found [http://wikitravel.org/en/Wikitravel:Small_city_article_template#Sleep here] and [http://wikitravel.org/en/Trat#Sleep here]? You'll see there is a tool to edit these tag. 

This tags is extremely useful to organize data and make quick edits. For example, I have fixed many incorrect phone numbers and addresses using this helpful tool. Please consider adding this feature the MediaWiki.

--------------------------
**Version**: unspecified
**Severity**: enhancement
>>! In T48225#2501154, @T.seppelt wrote:
> Since listings are highly structured and can be shared across several Wikivoyage language versions, Wikidata editing should be implemented before rolling this out.

Certainly, I think storing this data in Wikidata would be a good move. I'm not absolutely sure it should happen first, but I suppose it depends on who wants to work on what. :-)
Since listings are highly structured and can be shared across several Wikivoyage language versions, Wikidata editing should be implemented before rolling this out. I added T141345 for this. 

Note also that there is https://en.wikivoyage.org/wiki/Wikivoyage:Listing_editor, a tool especially designed for editing listings.
Note that, in my view, this is not a blocker for enabling the visual editor on Wikivoyages for all users. This is because almost no uses of `<listing>`s are done directly in wikitext, but instead through a template, which could do with some TemplateData love, but is supported fine already.

If you think I'm wrong please shout. :-)
**lukebenes** wrote:

Have you taken a look at WP:HOTCAT?

http://en.wikipedia.org/wiki/Wikipedia:HC

HotCat is a JavaScript program that helps registered users easily remove, change and add categories to Wikipedia pages. This is very similar to the functionality that we need for the Listing Editor.
This is about the Listings extension which is unique (in Wikimedia land) to Wikivoyage - https://www.mediawiki.org/wiki/Extension:Listings

It creates the following tags:

<buy>
<do>
<drink>
<eat>
<listing>
<see>
<sleep>

They are used to provide structured mark-up and hinting of recommendations for WV listings of places to go.

Sorry for the confusion. :-)
We weren't talking about any extension. This report was filed against MediaWiki core. Happy to move it to the right place, as long as we know what is the right place.

Luke, are you saying those tags were created in the Wikitravel times? If so, it would be useful to know how did they handle them.
Actually, on reflection this should live in the Extension we're talking about, and block against a tracker for such creations in VE itself. Sorry to mess this around.
Looking at our roadmap, the implementation of this feature looks more like a candidate for a VisualEditor plugin. 

MediaWiki core features must be generic enough for different wikis and must be reviewed and integrated by core maintainers. Visual Editor plugins can be developed by anybody and it is perfecty ok to have them for very specific purposes e.g. a Wikivoyage plugin.
**lukebenes** wrote:

There is a discussion about this feature on the wikivoyage site here:
http://en.wikivoyage.org/wiki/Wikivoyage:Roadmap/Improved_editing_interface
Some events are undocumented (like ve.dm.Surface.prototype.change, which emits multiple events but documents none), most have the event name without quotes, but some have single quotes (ve.dm.Surface.addInsertionAnnotation) or double quotes (ve.ui.Toolbar.prototype.onContextChange). Parameters sometimes are documented and sometimes aren't, there's no clear distinction between "parameters aren't documented" and "there aren't any", and in no case do we document the types and descriptions of event parameters, we only ever document their names.

We probably also don't document events with @event nearly as often as we should. It's a huge mess.

--------------------------
**Version**: unspecified
**Severity**: normal
Change-Id: Id879aa769b2c72d86a0322e75dddeb868211ce28
Working on it.
Right now VE is either 'default' for some given namespaces, or enabled but only exposed by user preference for some namespaces; it should be possible to have a mixed-installation for testing/etc.

--------------------------
**Version**: unspecified
**Severity**: normal
(In reply to comment #1)
> If enabled by default, can be disabled by preference?

Currently, yes, though we'll remove this preference when we go from "opt-in" to "opt-out" in July.

However, this bug isn't really necessary any more as we've just last week switched VE to default-on for Main, User and also the VisualEditor namespaces on mediawikiwiki. Closing as we no longer need this.
If enabled by default, can be disabled by preference?
Start a list item and type 'a', now hit shift-enter and type b.

Expected diff:
*a<p>b</p>

Actual diff:
*ab

The paragraph created when you create the list has internal.generated = 'wrapper'. This property gets copied when you split the list. Two wrapper paragraphs next to each other apparently get merged into one.

The only way wikitext can have two paragraphs in a list is with HTML so extra paragraphs must be full HTML paragraphs.

--------------------------
**Version**: unspecified
**Severity**: normal
Fixed by https://gerrit.wikimedia.org/r/#/c/52046/
Create a list of supported browsers and document it.

Also make sure that TUX actually works with those browsers.

--------------------------
**Version**: master
**Severity**: enhancement
**URL**: http://www.mediawiki.org/wiki/VisualEditor/Target_browser_matrix
On (c), https://wikimedia.mingle.thoughtworks.com/projects/language_engineering/cards/4381 mentions IE, Firefox, Safari and Chrome, but no versions.
https://www.mediawiki.org/wiki/Compatibility was recently updated and may serve as starting point; there is no need to restate the obvious, but it's useful to highlight any deviation from common expectations.

As far as I can see, Special:Translate and others have some browser tests, but:
a) I have no idea how comprehensive they are; it would be useful to file bugs for any missing one which should be added;
b) I don't know for sure whether they're used or how and where the outcomes are reported, though I think there is some degree of usage as part of the monthly [[mw:MLEB]] release;
c) I have absolutely no idea about the browsers used for such tests.

Is anyone able to shed some light on these questions, or point to someone who knows?
Any updates on this?
Harsh: 
Do you plan to work on this any time soon?
Do you need any input from the QA/browsertesting team (that would mean adding chrismcmahon@ and zfilipin@ to the CC list of this bug report)?
We had triaged this bug last month and Harsh Kothari had wanted to work on this. I'm adding him on cc for this bug.

Harsh, would you be working on this any time soon? Thanks.
Runa: this has been assigned you a month ago. Could you provide a status updated and whether you are currently working on this?
This is very much related to getting automated integration testing. Currently the scenarios are at http://etherpad.wikimedia.org/i18n-qa (ULS only so far). We should get at least 20 or so tests for TUX.
unwrapNodes & rewrapNodes are not implemented, and wrapNodes doesn't calculate selections correctly.

--------------------------
**Version**: unspecified
**Severity**: normal
Answer: yes. Marking as fixed.
Isn't this now (long) done?
e.g. https://integration.mediawiki.org/ci/job/mwext-Scribunto-jslint/233/checkstyleResult/file.984307183/type.1174449419/

It does that almost everywhere (including VisualEditor and MediaWiki core). Sometimes it does work though, weird.

--------------------------
**Version**: wmf-deployment
**Severity**: normal
Timo said it had a very confusing output due to :
- our builds not chaining because of different patchsets being run
- disabled checks being listed anyway

Checkstyle plugin is no more used. Closing the bug.
Unassigning self, I suspect that is either:

- JSHint does not add a description of the error in its XML output
- Jenkins Checkstyle plugin is missing description for JSHint errors

Most probably an upstream issue.
MW-specific code should be split from the VisualEditor itself; mediawiki/extensions/VisualEditor.git should only be the MW-specific items (integration; MW-specific plugins; MW-specific plugin overloading).

Target repository for VE itself already exists: VisualEditor/core.git

(Future plugins should be under VisualEditor/plugin/….git.)

--------------------------
**Version**: unspecified
**Severity**: enhancement
Now complete.
Change 102842 merged by jenkins-bot:
Use submodule for VisualEditor core

https://gerrit.wikimedia.org/r/102842
Change 102842 had a related patch set uploaded by Jforrester:
Use submodule for VisualEditor core

https://gerrit.wikimedia.org/r/102842
Change 102825 merged by jenkins-bot:
Update .gitreview and remove MW-specific things

https://gerrit.wikimedia.org/r/102825
Change 102825 had a related patch set uploaded by Jforrester:
Update .gitreview and remove MW-specific things

https://gerrit.wikimedia.org/r/102825
Change 101845 merged by jenkins-bot:
Split ext.visualEditor.mwcore out of ext.visualEditor.core

https://gerrit.wikimedia.org/r/101845
Change 101845 had a related patch set uploaded by Jforrester:
Split ext.visualEditor.mwcore out of ext.visualEditor.core

https://gerrit.wikimedia.org/r/101845
https://gerrit.wikimedia.org/r/71755 addresses part of this by splitting files between modules/ve/ and modules/ve-mw/
* Rules for "heading should not be in list" in CE rather than DM
* Function that isolates and unwraps things until they conform to the CE rules
** FormatAction does these things, but is hardcoded for lists

--------------------------
**Version**: unspecified
**Severity**: normal
Reassigning to Ed because he's already doing this anyway.
--------------------------
**Version**: unspecified
**Severity**: normal
Merged.
https://gerrit.wikimedia.org/r/#/c/50834/
--------------------------
**Version**: unspecified
**Severity**: normal
Merged.
Finished off in https://gerrit.wikimedia.org/r/#/c/50824/
Partially fixed in https://gerrit.wikimedia.org/r/#/c/50429/
**Author:** `visionary.incident`

**Description:**
I cannot input japanese consecutive characters in the beginning of the line.

Firefox version is 18.0.2 .

For example

inputed
あああああ

outputed
ああ

--------------------------
**Version**: unspecified
**Severity**: normal
I suspect this is no longer broken. Please re-test.
Just as a note, we are refactoring the Surface code in ContentEditable to make this fixable, hence the delay.
*** Bug 53064 has been marked as a duplicate of this bug. ***
Inez, is there an update on this bug?
Only works if the line has no text.
Confirmed on bullet-type lines too.
I was able to confirm it (using Katakana) in Chrome on MacOS. Apparently it depends on the speed of typing (Selenium test for it is going to be interesting).
We currently have 0 tests for ve.FormatAction.*

--------------------------
**Version**: unspecified
**Severity**: normal
Merged.
https://gerrit.wikimedia.org/r/#/c/50137/
In ve.js, function ve.msg:
// TODO: Fix dependency issues between ve.js and ve.init.platform

I don't know how this should be fixed exactly, Timo put this comment in in 407de829dd8f2e51c22a8378dc70c79fc6645d1e . I did notice that running the VE tests from Special:JavaScriptTest doesn't work because ve.msg() errors out with 've.init.platform' undefined.

--------------------------
**Version**: unspecified
**Severity**: normal
Change-Id: I47d7d92495974572194700c98a219d22ecbfaf4b
This is currently blocking us from enabling QUnit for extension VisualEditor as the race-condition is happening consistently in Chrome, Safari and PhantomJS.

I tracked it down to the calls to ve.msg from the global scope, such as:


@@ ve.ce.Surface.static.$phantomTemplate = $ (.. ) .attr( {
		'title': ve.msg( 'visualeditor-aliennode-tooltip' ),
(In reply to comment #0)
> In ve.js, function ve.msg:
> // TODO: Fix dependency issues between ve.js and ve.init.platform
> 
> I don't know how this should be fixed exactly, Timo put this comment in in
> 407de829dd8f2e51c22a8378dc70c79fc6645d1e . I did notice that running the VE
> tests from Special:JavaScriptTest doesn't work because ve.msg() errors out
> with
> 've.init.platform' undefined.

Indeed, that's the reason why. They sometimes fail, and sometimes work.

It appears to be a race-condition and/or absent dependency that should be fixed or lazy-loaded or something else to make sure one has the other.
**Author:** `kevinrose`

**Description:**
I am running under IIS with the files stored on network storage.
I get an error from line 1142 in includes\AutoLoader.php when the $filename being passed is already a network share. Specifically in my case it then adds $IP a second time.

Here are the variables from my situation:

From debugging we know that:
$IP is set to "\\server\share\mediawiki"

The offending class being loaded in LocalSettings.php:

require_once("$IP/extensions/WikiEditor/WikiEditor.php" );

After line 1142 $filename = "\\server\share\mediawiki\\server\share\mediawiki\extensions\WikiEditor\WikiEditor.php"

Line 1140 checks if the first character is a / (root), or the second character is a : (windows local drive).

To work around the problem I added a third check, that the second character is a slash (windows network share):

		if ( substr( $filename, 0, 1 ) != '/' && substr( $filename, 1, 1 ) != ':' && substr( $filename, 1, 1 ) != '\\') {

--------------------------
**Version**: 1.20.x
**Severity**: normal
**kevinrose** wrote:

I forgot about this bug - upgraded my mediawiki to latest snapshot of 1.22 and the issue came back.

The issue isn't related to a particular extension, but to the use of the AutoLoader.  Above the samples were with WikiEditor. This time I came across it with VisualEditor which uses AutoLoader.


In 1.22 latest snapshot 7/16/2013 line 1148-1152 of file includes\AutoLoader.php:

		# Make an absolute path, this improves performance by avoiding some stat calls
		if ( substr( $filename, 0, 1 ) != '/' && substr( $filename, 1, 1 ) != ':' ) {
			global $IP;
			$filename = "$IP/$filename";
		}



This handles the case where $filename is a linux full path (starting at /) or a windows full path (with the drive letter i.e. c:) but does not handle the case of a network share on windows (\\server\path)

Again fix in first message does address this:

if ( substr( $filename, 0, 1 ) != '/' && substr( $filename, 1, 1 ) !=
':' && substr( $filename, 0, 2 ) != '\\\\')

Adjusted to look specifically for two forward slashes in case there's some other case where one forward slash is ok?
**michael** wrote:

I experienced the same issue after upgrading to the latest version of GearHost.com's cloudsites platform, which too changed from local drive storage to a network share. Like the original poster, I found the same behavior. Additionally, though, I found that commenting the require_once("$IP/extensions/WikiEditor/WikiEditor.php" ); line would temporarily resolve the issue and allow MediaWiki to load, which suggests some dependency between require_once and the autoloader. I applied a similar change to the autoloader file which allowed to uncomment the require_once line successfully. I am running MediaWiki 1.19.1.
Please confirm that this is a MediaWiki related problem. Otherwise this issue should be closed.
I think you're confusing "require" with "autoloading".

The require_once() call you mention:
> require_once("$IP/extensions/WikiEditor/WikiEditor.php" );

that isn't a class but an extension file. This is your own code and placed in your LocalSettings.php, correct?

AutoLoader isn't involved there.


> After line 1142 $filename =
> "\\server\share\mediawiki\\server\share\mediawiki\extensions\WikiEditor\WikiEditor.php"

Line 1142/1145 of which file? Assuming AutoLoader.php, why is WikiEditor listed in your autoloader configuration?
**kevinrose** wrote:

Sorry to avoid confusion - the actual error is at line 1145 when the incorrect $filename tries to get required.
[Very much a longer-term enhancement.]

Parsoid doesn't currently have support for passing on an authenticated user's read right when fetching the wikitext (because the API doesn't support that yet).

--------------------------
**Version**: unspecified
**Severity**: enhancement
Change 91111 merged by jenkins-bot:
Support private wikis by forwarding Cookie: headers to Parsoid

https://gerrit.wikimedia.org/r/91111
Closing again.
Change 91111 had a related patch set uploaded by Jforrester:
Support private wikis by forwarding Cookie: headers to Parsoid

https://gerrit.wikimedia.org/r/91111
Cookies are now forwarded, and caching is disabled if a cookie is set. Closing this bug as fixed. A content API will have to do its own auth.
Change 85414 merged by jenkins-bot:
Bug 44483: Forward Cookie header to API

https://gerrit.wikimedia.org/r/85414
(In reply to comment #4)
> Random idea:
> 
> Could Parsoid be made private (already is, though last I checked it still
> has a
> public IP) and use an internal API instead of the public API. Then the
> responsibility for user rights lays in MediaWiki land, and when the request
> is
> in Parsoid we can assume it is authenticated and thus Parsoid can have
> unrestricted access.

That is what we'll have to do in the longer term once we store HTML. Parsoid might not even be involved in that case, only the content API / storage is. See https://www.mediawiki.org/wiki/User:GWicke/Notes/Storage for the current WIP on that.
Random idea:

Could Parsoid be made private (already is, though last I checked it still has a public IP) and use an internal API instead of the public API. Then the responsibility for user rights lays in MediaWiki land, and when the request is in Parsoid we can assume it is authenticated and thus Parsoid can have unrestricted access.
Change 85414 had a related patch set uploaded by GWicke:
WIP Bug 44483: Forward Cookie header to API

https://gerrit.wikimedia.org/r/85414
*** Bug 44313 has been marked as a duplicate of this bug. ***
Passing on the cookie header from the VisualEditor extension to Parsoid and then from Parsoid back to the API might be enough to enable this. Definitely worth a try.
Deleting multiple lines of selected text

When trying to delete a line of added text, the editor failed. See screenshot.

When reviewing the changes I get an empty "Latest revision" and empty "Your text". Tried with Chrome and Firefox. When saving, the changes are not committed either.

When trying to delete two lines (see screenshot on the right side), only one line is marked for deletion:

    - Mostly active on [[:bs:Korisnik:Edinwiki|bs-wiki]].

When selecting multiple lines in the same way, it seems that each time only the first line is selected.

--------------------------
**Version**: unspecified
**Severity**: major
**URL**: https://en.wikipedia.org/wiki/User:Edinwiki

**Attached**: {F10938}
This is now fixed given the Parsoid update. Sorry for the delay!
This appears to be a Parsoid issue - to recheck when Parsoid service is updated in live.
1. Type 2 spaces
2. Move the cursor between the two spaces
3. Press link button or (command|control)+k
4. Type text for target (if in mw integration you can also choose a suggested target)
5. Press enter (or click outside the inspector, or press esc)
6. See that the target text was inserted, but not annotated

--------------------------
**Version**: unspecified
**Severity**: normal
Gerrit patch merged.
Patched in: https://gerrit.wikimedia.org/r/#/c/47822/
Steps to reproduce:
1. Find a paragraph that has an inline node (alien or entity) in it, but not at the end
2. Move the cursor to the end of the paragraph
3. Repeatedly press backspace
4. When there is only one remaining character after the inline node, pressing backspace will remove that character (correct) and move the cursor to the beginning of the line (bad)

--------------------------
**Version**: unspecified
**Severity**: normal
I believe that this is now fixed with the new deletion model.
Some extensions, such as Extension:GuidedTour, require git submodules.

It would be a very useful enhancement if ExtensionDistributor included these in the download, by default or optionally.

--------------------------
**Version**: master
**Severity**: enhancement
**URL**: https://www.mediawiki.org/wiki/Extension_talk:ExtensionDistributor#Doesn.27t_do_submodules
New tarball generator has been deployed, which now includes submodules.
(In reply to Kunal Mehta (Legoktm) from comment #3)
> I've set up an API endpoint for VisualEditor on labs:
> http://tools.wmflabs.org/extdist/?version=REL1_23&ext=VisualEditor
> 
> I don't see any submodules in GuidedTour?

Correct, we forked Guiders so there's no longer a submodule.
Once we switch to the new labs tarball generator, this will be fixed.
Change 146430 abandoned by Legoktm:
Support having multiple API endpoints

Reason:
We're going to just point everything to labs instead.

https://gerrit.wikimedia.org/r/146430
I've set up an API endpoint for VisualEditor on labs: http://tools.wmflabs.org/extdist/?version=REL1_23&ext=VisualEditor

I don't see any submodules in GuidedTour?
Change 146430 had a related patch set uploaded by Legoktm:
Support having multiple API endpoints

https://gerrit.wikimedia.org/r/146430
Yeah, we need this for VE too.

Github doesn't support submodules, but it's easy to do this on labs (I already wrote a script to do it). Just requires a few changes to the extension...
Steps to reproduce:
1. Open VE on a page
2. Make changes
3. Stop Parsoid
4. Click "Review and save"
5. Get an error dialog about Parsoid being down. Click "Cancel".

The box that's supposed to show the diff is left empty, but the "Something's wrong" and "Looks good to me" buttons are still there. I can dismiss the box with the up arrow to go back to editing, but we should be doing this (or at least *something*) automatically on failure.

--------------------------
**Version**: unspecified
**Severity**: minor
Yeah, we completely switched around the fetching logic here so that this is now INVALID; sorry.
Everything about this seems different now... "Review and save" I guess has become "Save page", and you only get an error about Parsoid being down when you then click "Review your changes". This dialog offers only an "OK" button which simply stops the loading of the review dialog. I don't see an empty diff or "Something's wrong"/"Looks good to me" buttons.

Is this bug still valid?
Editnotices for pages are not currently exposed in the API, but are expected to be used by any interface of a Wikipedia  editor. This implies that the information should be easily retrievable.

It should be noted that the VisualEditor api has it's own private implementation of listing all edit notices that should be presented to users: https://en.wikipedia.org/w/api.php?action=visualeditor&format=json&paction=metadata&page=List_of_emoticons&uselang=en&oldid=846338965

This should probably be moved to core as well as be exposed via restbase or something similar.

--------------------------
**Version**: 1.21.x
**Severity**: enhancement
Change 74963 abandoned by Umherirrender:
Api: Add editnotices to prop=info

https://gerrit.wikimedia.org/r/74963
Change 74963 had a related patch set uploaded by Umherirrender:
Api: Add editnotices to prop=info

https://gerrit.wikimedia.org/r/74963
I wonder whether it would be better for prop=info to return the names of the messages containing the notice instead of parsing them itself. The client could parse these using action=parse if it wants HTML.

The main drawback to parsing them in prop=info is that parsing is expensive; prop=revisions, for example, will error out if asked to parse more than one revision, and if we'd add editnotices with parsed output to prop=info we'd have to do something similar there.


On a side note, I still don't understand what happened with r48276. Per-page edit noticed were half removed, but the removal wasn't finished even after this was pointed out, and then they were added back 2.5 years later.
The Translate extension has very nice info icons which bring users from the interface/feature they're seeing to the relevant (translatable) help page on mediawiki.org (all components are documented). See for instance [[ https://meta.wikimedia.org/wiki/Special:PageTranslation | m:Special:PageTranslation ]].

This is a huge task, but it should be done for core as well.

The problem is of course that there's no real(istic) plan to get such help pages done in the next few decades, as they continue to live either on Meta for copyright reasons or even on local wikis for the same + [[ https://meta.wikimedia.org/wiki/Not_my_wiki | m:Not my wiki]] syndrome. This part of the problem should be discussed on wiki, probably the talk of the project.

--------------------------
**URL**: https://www.mediawiki.org/wiki/Project:PD_help
**See Also**:
{T19557}
{T14306}
{T46286}
I am afraid the lack of a doc in ##mw:## is the major problem here.

Code fragments are distributed over many PHP units, and not really accessible to Wiki maintainers.
You can still use MediaWiki:Whatlinkshere-helppage to override the default help link on Special:WhatLinksHere (and similar for all other special pages). You can also use such messages for override/add help links for namespaces (e.g. MediaWiki:Namespace-0-helppage) and page actions (e.g. MediaWiki:History-helppage).

I don't know if this is properly documented anywhere, I just looked up how it works in source code.

The default value is unfortunately not shown on these pages, due to the way we use these messages. Perhaps this could be changed to make these messages behave more normally, but as a consequence, users with non-default interface language would not see the local override (currently they do).

Almost all of the built-in help links go to MediaWiki.org. There are only three exceptions: the help links for history action, Special:Import and Special:RecentChanges all go to MetaWiki. Presumably the documentation pages for these on MediaWiki.org are inferior.
Tried to figure out why some special page has a link to a local help page, and some has help pages at Meta and some at Mediawiki, but the previous -helppage system messages does not make sense anymore? Where is the doc for this?

A local help page for WhatLinksHere has no -helppage link, so tried to move the help page to check if there was some checks on page existence, but no change, the local page is still in use somehow.
Imho it is understandable, when there is a link to a help page for an action or feature that a specific wiki does not offer, or at least not to the general viewer, that they want the help link not shown. Thus we should possibly make help pages very modular and independent of one another and avoid cross-linking them for the things that are based on different user rights that can be assigned individually to users or groups. Also, help links should only appear on pages where the individual feature is available.

I do not know whether that is good and sufficient. At least, it contradicts the idea of offering the user a good and comprehensive Overview.

Last not least, we can have wikis copy the common help pages wholesale or individually as need be, and use their local copies which they can edit to their needs.
>>! In T45591#1411185, @Nikerabbit wrote:
> It seems a bit blanket statement to say all of those help link are unhelpful. I would argue they are more helpful than harmful and thus there is no need to be able do disable them altogether.

Maybe, maybe not. That's a third party wiki view. I can see it both ways; especially for a wiki that's not open to the public for editing, but is for public viewing. YMMV. Literally just passing on what I was told.
It seems a bit blanket statement to say all of those help link are unhelpful. I would argue they are more helpful than harmful and thus there is no need to be able do disable them altogether.
I've just had a third-party wiki wondering what the point of this is, and as such, how to disable it

```
[15:31:40] <AA-Andrew> I can't really see how it's helpful for it to Link to a media wiki help page though 
```

Of course, hiding it with CSS isn't really disabling it, you're still loading the various assets.

Should there be some sort of config flag for it? I'm not sure...
Ok, we can call this done for now. We should now go look for extension help pages on mediawiki.org and start adding links from their special pages.
* https://gerrit.wikimedia.org/r/194418 (branch master): #mw1.26, #mw1.26wmf9
Change 194418 merged by jenkins-bot:
Add help link for 8 more special pages

[[https://gerrit.wikimedia.org/r/194418]]
Change 211100 merged by jenkins-bot:
Allow to customise addHelpLink() target via system message

[[https://gerrit.wikimedia.org/r/211100]]
Once 8082c5f4f0a6c44bca1797470723089bc1d1ff03 is merged, this can be closed. Adding new help pages and links will then be an ongoing process as part of [[Project:PD Help]], as well as an easy matter of customisation by local wikis where needed.
Change 211100 had a related patch set uploaded (by Nemo bis):
Allow to customise addHelpLink() target via system message

[[https://gerrit.wikimedia.org/r/211100]]
Change 208378 merged by jenkins-bot:
Allow to customise addHelpLink() target via system message

[[https://gerrit.wikimedia.org/r/208378]]
Change 208378 had a related patch set uploaded (by Nemo bis):
Allow to customise addHelpLink() target via system message

[[https://gerrit.wikimedia.org/r/208378]]
>>! In T45591#1231734, @Multichill wrote:
> Already disabled on dewp (https://de.wikipedia.org/w/index.php?title=MediaWiki%3ACommon.css&diff=140838650&oldid=140486784). 

And i am inclined to switch this of on commons... It is not helpful. It is not linking to the commons policy's, but to some MW page.
Just had a look at http://git.wikimedia.org/blob/mediawiki%2Fcore.git/0a33db75cb2afd0879512b7a3cc2ec5b63d9ae5e/includes%2FOutputPage.php#L1408 . Hardcoded url? No message? Are you serious?

Already disabled on dewp (https://de.wikipedia.org/w/index.php?title=MediaWiki%3ACommon.css&diff=140838650&oldid=140486784). 

Including some help is a good idea, but the implementation should be improved so that the url is not hardcoded.
>>! In T45591#1139342, @Nemo_bis wrote:
>>>! In T45591#1139318, @matmarex wrote:
>> Outstanding patches:
>> * https://gerrit.wikimedia.org/r/#/c/194418/ "[WIP] Add link to Meta-Wiki help pages from several special pages"
> 
> This is the one which needs most discussion/help.

The pages in question are:
* https://meta.wikimedia.org/wiki/Help:User_contributions
* https://meta.wikimedia.org/wiki/Help:Export
* https://meta.wikimedia.org/wiki/Help:Import
* https://meta.wikimedia.org/wiki/Help:Linksearch
* https://meta.wikimedia.org/wiki/Special:MyLanguage/Help:Recent_changes
* https://meta.wikimedia.org/wiki/Help:Related_changes
* https://meta.wikimedia.org/wiki/Help:Watching_pages
* https://meta.wikimedia.org/wiki/Help:What_links_here
https://commons.wikimedia.org/wiki/Commons:Village_pump#Help_topicons_linking_to_external_help_pages_soon_displayed_everywhere.3F
Thanks Legoktm! If there is interest in a backport I can work on https://gerrit.wikimedia.org/r/#/c/194418/ this week.
Change 202968 merged by jenkins-bot:
Add help link to three rather important pages

[[https://gerrit.wikimedia.org/r/202968]]
Change 202968 had a related patch set uploaded (by Legoktm):
Add help link to three rather important pages

[[https://gerrit.wikimedia.org/r/202968]]
Change 194414 merged by jenkins-bot:
Add help link to three rather important pages

[[https://gerrit.wikimedia.org/r/194414]]
>>! In T45591#1159175, @PerfektesChaos wrote:
> Local confguration needs more emphasis.
> * At least a system message should be taken into account by the implementation.

This is valid point which can have it's own task.

> * Icons might be cultural dependant (CJK, arabic, hebrew) and should be configurable per system message – a greek question mark is a semicolon.

This can also be a separate task. We already do localised images in couple of places. I do disagree though that it needs to be configurable per system message.

> Rather than maintaining system messages for each page by each project, a wikifarm with a wikibase could make use of that knowledge. (Okay, WMF might be the only one, but is among the top ten websites)

This can already be achieved with the approach WikimediaMessages is using if we implement overrides with system messages.

> I would like to see in CommonSettings.php something like

Your proposal sounds very complicated, we already have standard way to handle these as explained above.

> I wonder whether the entire helppage link business should stay in core or should be turned into an extension.

It was just moved to core so that each extension does not implement a different way to do it. Definitely not to be moved to an extension.
>>! In T45591#1139318, @matmarex wrote:
> Outstanding patches:
> * https://gerrit.wikimedia.org/r/#/c/194418/ "[WIP] Add link to Meta-Wiki help pages from several special pages"

This is the one which needs most discussion/help. MediaWiki help pages can't lack coverage of RecentChanges and Watchlist... either they are rewritten on MediaWiki.org or we should change the rules to adopt/incorporate Meta-Wiki docs.
Outstanding patches:
* https://gerrit.wikimedia.org/r/#/c/194418/ "[WIP] Add link to Meta-Wiki help pages from several special pages"
* https://gerrit.wikimedia.org/r/#/c/194414/ "Add help link to three rather important pages"
Change 197667 merged by jenkins-bot:
mediawiki.helplink: Use a SVG PNG icon

[[https://gerrit.wikimedia.org/r/197667]]
One small question on https://gerrit.wikimedia.org/r/#/c/197667/2

FWIW, aside trivia:
* There's also a SVG version of the current help.png, but it's not a native one (014b5632fcc6a4200d519cf7f86e94c09639af8f).
* Personally I prefer a more "standard" (i.e. common) blue, but it doesn't matter.
* VE is not "standard", both are icons taken from extensions and [[https://wikimedia.mingle.thoughtworks.com/projects/language_engineering/cards/410|made by WMF]].
One small question on https://gerrit.wikimedia.org/r/#/c/197667/2

FWIW, aside trivia:
* There's also a SVG version of the current help.png, but it's not a native one.
* Personally I prefer a more "standard" (i.e. common) blue, but it doesn't matter.
* VE is not "standard", both are icons taken from extensions and [[https://wikimedia.mingle.thoughtworks.com/projects/language_engineering/cards/410|made by WMF]].
>>! In T45591#1104151, @matmarex wrote:
> Indeed, it seems that a "Help" icon was not considered for the new icon set.
That's {T90414}

> VisualEditor / OOjs UI has a icon for this, though: {F72837,size=full,layout=inline}. If you need it now, the file will have to be just copied into mediawiki/core,

FWIW the icon is reachable, https://bits.wikimedia.org/static-1.25wmf21/resources/lib/oojs-ui/themes/mediawiki/images/icons/help.svg, so `url(../../lib/oojs-ui/themes/mediawiki/images/icons/help.svg)` works. I guess there's no cleaner path to library resources.

> as the work on making the icons available has stalled a bit.
?  They're all available if you use OOjs UI ([[ https://tools.wmflabs.org/oojs-ui/oojs-ui/demos/#icons-mediawiki-vector-ltr | cool demo ]]). If we're making them available to non-OOjs UI code I look forward to documenting how-to.
Change 197667 had a related patch set uploaded (by Bartosz Dziewoński):
mediawiki.helplink: Use standard SVG PNG icon

[[https://gerrit.wikimedia.org/r/197667]]
Change 194411 merged by jenkins-bot:
Add help link to three other "minor" special pages

[[https://gerrit.wikimedia.org/r/194411]]
>>! In T45591#1103929, @matmarex wrote:
>>>! In T45591#1102455, @Krinkle wrote:
>> I imagine if this is not changed it will need to be reverted and further worked upon for the next deployment window.
> 
> That strikes me as somewhat of an overreaction.

It needs improvement before deployment. It wasn't my feature to implement and would not have been merged as-is in that case. As such, a revert is just returning status quo and enforcing quality criteria.
Indeed, it seems that a "Help" icon was not considered for the new icon set.

VisualEditor / OOjs UI has a icon for this, though: {F72837,size=full,layout=inline}

https://tools.wmflabs.org/oojs-ui/oojs-ui/dist/themes/mediawiki/images/icons/help.svg
https://tools.wmflabs.org/oojs-ui/oojs-ui/dist/themes/mediawiki/images/icons/help.png

Presumably that could be used. If you need it now, the file will have to be just copied into mediawiki/core, as the work on making the icons available has stalled a bit. (It is MIT-licensed, like the rest of OOjs UI.)
Are you talking about the blue "?" for 'help'?

For what is worth, WikiFont has an icon from @violetto called [[ https://commons.wikimedia.org/wiki/File:Sun_help.svg | Sun help ]]. I couldn't find any incon with "?" in the collection.

Needless to say, in Commons there are many SVGs of question mark signs in a blue circle, but... See https://commons.wikimedia.org/wiki/File:Blue_question_mark_icon.svg & friends.
I agree the icon needs to be improved. Do you have suggestions for a SVG-ready icon to use?

That's the icon closest to a "standard" that we currently have in the codebase for this purpose: it's used in a MediaWiki extension already, for several special pages. We must improve it before we extend its usage to more visible places, of course.
>>! In T45591#1102455, @Krinkle wrote:
> I imagine if this is not changed it will need to be reverted and further worked upon for the next deployment window.

That strikes me as somewhat of an overreaction. If the icon irks you, then it's a one-line change to remove it. It would be almost as easy to replace it with a different one, too.
>>! In T45591#1088866, @gerritbot wrote:
> Change 157497 merged by jenkins-bot:
> Add top help link to MediaWiki.org in several pages via indicator
> 
> [[https://gerrit.wikimedia.org/r/157497]]

This uses a non-standard icon that doesn't match the any skin and did not go through Design. It also does not have an SVG or High-resolution version available. Thus regressing from our state of having HiDPI-friendly pages by default.

The icon would be okay for a local gadget, but not MediaWiki core.

I don't know further context, but I imagine if this is not changed it will need to be reverted and further worked upon for the next deployment window.
Change 195045 merged by jenkins-bot:
Don't require JavaScript for addHelpLink styles

[[https://gerrit.wikimedia.org/r/195045]]
Change 195045 had a related patch set uploaded (by Nemo bis):
Don't require JavaScript for addHelpLink styles

[[https://gerrit.wikimedia.org/r/195045]]
Switching order needs to be checked for each call in core.

Hiding with css would work, but not tested yet.
Or we can switch the order. Did you try CSS, though?
on de.wikipedia.beta.wmflabs.org we have changed the id, but it does not override it, see http://de.wikipedia.beta.wmflabs.org/wiki/Spezial:Verschieben/MediaWiki:Movepage-summary for the place where the wrong help link is shown and http://de.wikipedia.beta.wmflabs.org/wiki/MediaWiki:Movepage-summary for the message where the indicator is used.

This seems to be happen because OutputPage::setHelpLink is called later than SpecialPage::outputHeader and than override the indicator ("In case of duplicate keys, existing values are overwritten."). OutputPage::setIndicators needs a explicit not-overwrite-option which than can be used from OutputPage::addHelpLink.
> What about wikis already have such a help link in the UI like dewiki (see https://de.wikipedia.org/w/index.php?title=Spezial:Linkliste/MediaWiki:Specialpage-helplink&limit=500&hidelinks=1 for all usages)

They should switch to the usage of indicators, using the same ID. This *should* suppress the default link.

> What about the local help pages like linked from https://www.wikidata.org/wiki/Q395887?
> Why hard linking to mw.org? There should be a way to allow the local community to override the target of the help page.

Local help pages are available on very few languages, but sure, customisation should be possible for wikis which care about it. Are the provided CSS class+id and the indicator system insufficient for customisation?
> What about wikis already have such a help link in the UI like dewiki (see https://de.wikipedia.org/w/index.php?title=Spezial:Linkliste/MediaWiki:Specialpage-helplink&limit=500&hidelinks=1 for all usages)

They should switch to the usage of indicators, using the same ID. This *should* suppress the default link.

> What about the local help pages like linked from https://www.wikidata.org/wiki/Q395887?
> Why hard linking to mw.org? There should be a way to allow the local community to override the target of the help page.

Local help pages are available on very few languages, but sure, customisation should be possible for wikis which care about it. Are the provided CSS classes and the indicator system insufficient for customisation?
> What about wikis already have such a help link in the UI like dewiki (see https://de.wikipedia.org/w/index.php?title=Spezial:Linkliste/MediaWiki:Specialpage-helplink&limit=500&hidelinks=1 for all usages)

They should switch to the usage of indicators, using the same ID. This *should* suppress the default link.

> What about the local help pages like linked from https://www.wikidata.org/wiki/Q395887?
> Why hard linking to mw.org? There should be a way to allow the local community to override the target of the help page.

Local help pages are available on very few languages, but sure, customisation should be possible for wikis which cared about it. Are the provided CSS classes and the indicator system insufficient for customisation?
I told you there were many. ;-) Even more ambitious, various actions or special cases thereof:
* https://meta.wikimedia.org/wiki/Help:Diff
* https://meta.wikimedia.org/wiki/Help:Edit_conflict
* https://meta.wikimedia.org/wiki/Help:Image_page
* https://meta.wikimedia.org/wiki/Help:Preview
* https://meta.wikimedia.org/wiki/Help:Redirect
* https://meta.wikimedia.org/wiki/Help:View_source

Not sure how to split this conversation/epic. As long as it's just me talking with myself, one report and 3-4 patches probably suffice. ;-) But fixing or rewriting 15 help pages on something like half of a wiki's daily operation is unlikely to be one man's work, while being something we must to at some point.
Change 194418 had a related patch set uploaded (by Nemo bis):
Add link to Meta-Wiki help pages from several special pages

[[https://gerrit.wikimedia.org/r/194418]]
Change 194414 had a related patch set uploaded (by Nemo bis):
Add help link to three rather important pages

[[https://gerrit.wikimedia.org/r/194414]]
Change 194411 had a related patch set uploaded (by Nemo bis):
Add help link to three other "minor" special pages

[[https://gerrit.wikimedia.org/r/194411]]
I'm very happy. :) As for closure let's see: I'm considering many more possible targets for core, I'll send more patches.
Fixed by Nemo for a number of core special pages, which will now have a "Help" link in the page indicator area (https://www.mediawiki.org/wiki/Help:Page_status_indicators). The newly added `OutputPage::addHelpLink()` method can be used by extensions to provide identical functionality for their own special pages.
Change 157497 merged by jenkins-bot:
Add top help link to MediaWiki.org in several pages via indicator

[[https://gerrit.wikimedia.org/r/157497]]
Change 157497 had a related patch set uploaded (by Nemo bis):
Add top help link to MediaWiki.org in several pages via indicator

[[https://gerrit.wikimedia.org/r/157497]]

#patch-for-review
Change 157496 abandoned by Nemo bis:
Function to add a top (right) icon link to help page

Reason:
Superseded by indicators

[[https://gerrit.wikimedia.org/r/157496]]
(In reply to Bartosz Dziewoński from comment #10)
> I did that as a note-to-self to implement this later. But okay.

That's appreciated, and it would be useful if bug 23796 had preserved its original bug summary (with its current summary split to some other bug), but as is it was very confusing.
I did that as a note-to-self to implement this later. But okay.
(In reply to Bartosz Dziewoński from comment #8)
> The implementation proposed by Nemo looks like it would benefit from having
> bug 23796 solved first, so I'm marking this as such.

With its current summary I see no relation whatsoever.
The implementation proposed by Nemo looks like it would benefit from having bug 23796 solved first, so I'm marking this as such.
Change 157497 had a related patch set uploaded by Nemo bis:
Add top help link to MediaWiki.org in several pages

https://gerrit.wikimedia.org/r/157497
Change 157496 had a related patch set uploaded by Nemo bis:
Function to add a top (right) icon link to help page

https://gerrit.wikimedia.org/r/157496
[[mw:Category:Help]] was made almost completely translatable (and usually revamped a bit in the process).

I count the following places which have a documentation page and don't link it: Special:Block, Special:MergeHistory, Special:MovePage, Special:NewPages, Special:NewImages, Special:Preferences, Special:Search, action=protect, Special:RecentChanges, action=delete, Special:AllMessages, Special:Undelete, Special:Watchlist; and in extensions, Special:MassMessage, Special:TemplateSandbox, Special:AbuseFilter.

Where to start?
(In reply to comment #3)
> Speaking of implementation method, the interwiki prefix mediawikiwiki can be
> used when necessary: "new" wikis have it by default, where "new" means after 
> 2007-03-29 (bug 9440 / r20825 / 98333f458046102ee140f4be86fe4d2c6facae2f ).

To clarify the "when necessary": personally, for now I'm following the path of last resistance, i.e. I use wikilink where there is already a wikilink and external where there is already an external link.
The separate bug 54835 addresses/proposes the standardisation.
Speaking of implementation method, the interwiki prefix mediawikiwiki can be used when necessary: "new" wikis have it by default, where "new" means after  2007-03-29 (bug 9440 / r20825 / 98333f458046102ee140f4be86fe4d2c6facae2f ).
(In reply to comment #1)
> I for one would prefer an "if the local page does not exist, then
> transparently
> deliver the central page from www.mediawiki.org" approach for help pages

Sure, that's a possibility too. It's a choice of implementation method, let's leave it to code review. :)
(Target pages would probably be customisable in system messages anyway, so the result would be the same: wikis could have their own pages if they really wanted.)
I for one would prefer an "if the local page does not exist, then transparently deliver the central page from www.mediawiki.org" approach for help pages, mainly resembling the way, pictures are handled and included from Commons if needed.

Also, when user on a wiki are about to create a new help page following a red link to the help: namespace, they should most preferrably be stirred towards the central www.mediawiki.org help page creation in their language.
Screenshot of bug and edit screens

Native parser rendering:
the Netherlands

Parsoid/VisualEditor rendering:
style="font-size: larger; font-weight: bold" | the Netherlands

[[Flag of the Kingdom of the Netherlands]]:
{{Infobox flag
| Name = the Netherlands
...

[[Template:Infobox flag]]:
> {| class="infobox" style="width: 22em; font-size:88%; text-align:left; line-height: 1.5em"
|+ style="font-size: larger; font-weight: bold" | <br>{{{Name|{{PAGENAME}}}}}
|-
...


See attachment for rendering.

--------------------------
**Version**: unspecified
**Severity**: normal

**Attached**: {F10351}
Fixed by https://gerrit.wikimedia.org/r/#/c/44170/.
**orbit** wrote:

Fixed here: https://gerrit.wikimedia.org/r/#/c/50309/
I can't reproduce this issue... If anyone still sees this, please reopen.
Created attachment 14685
HotCat showing up in the content editable surface

(from bug 55759 attachment 13500 by Chris McMahon)

**Attached**: {F9984}
(In reply to comment #4)
> Created attachment 13512 [details]
> VE iframe has gadget code before VE is invoked
I don't think that's related at all. Gadget CSS is expected in the iframe. It should be in the <head> instead of the <body> but that's a separate issue (bug 56630).

//attachment invisible_iframe_contents.png ignored as obsolete//
Created attachment 13512
VE iframe has gadget code before VE is invoked

//attachment invisible_iframe_contents.png ignored as obsolete//
*** Bug 55759 has been marked as a duplicate of this bug. ***
(In reply to comment #1)
> Is this related?
> 
> "We seem to have lost the plus and minus options of Hotcat that were one of
> the closest to WYSIWYG features of this site. Please can they be
> incorporated into visual editor. ϢereSpielChequers 13:46, 4 July 2013 (UTC)"

That's unrelated to VisualEditor; enwiki's community switched off HotCat as a default gadget, so people who want to keep using it will need to manually switch it back on.
Is this related?

"We seem to have lost the plus and minus options of Hotcat that were one of the closest to WYSIWYG features of this site. Please can they be incorporated into visual editor. ϢereSpielChequers 13:46, 4 July 2013 (UTC)"
After discussion with the team, we feel that this doesn't make sense because this is mostly a feature that makes sense in line-based editors (generally, for code), and VE is not one of these.
For the first part, some IDEs do this (e.g. Sublime), but LO, Google Docs & gedit don't. The downside is it reduces the target zone for placing the cursor at the start of a line.

For the second part, we already have left padding into which you can click to position the cursor at the start of the line.
A few more selser fixes later this should now be fixed. Repeating the test case above certainly suggests it works, so please reopen if there still are issues.
(Needs verification with VE)
Likely fixed by the DOM diffing functionality that landed in https://gerrit.wikimedia.org/r/#/c/41816/. Barring bugs, we now no longer depend on change markers for selective serialization to work.
> <imagemap>....</imagemap> is unparsed but shown as plain wikitext

Apparently at this point it is shown as an uneditable image.

An imagemap editor seems almost the same use case as an [[ https://commons.wikimedia.org/wiki/Help:Gadget-ImageAnnotator | ImageAnnotator ]] annotation editor.
Change 214078 merged by jenkins-bot:
Add VisualEditor support

[[https://gerrit.wikimedia.org/r/214078]]
Change 214078 had a related patch set uploaded (by Jforrester):
Add VE support for syntax highlighting

[[https://gerrit.wikimedia.org/r/214078]]
Change 114529 had a related patch set uploaded by Jforrester:
[WIP] Add VisualEditor support

https://gerrit.wikimedia.org/r/114529
Re-opening as this is now unmerged.
This is now complete and merged, as gerrit 68615, and will go out (as an experimental option) to MediaWiki.org tomorrow. Congratulations, Tongbo!
[Parsoid component reorg by merging JS/General and General. See bug 50685 for more information. Filter bugmail on this comment. parsoidreorg20130704]
Patch committed for review in https://gerrit.wikimedia.org/r/46465.
Appears to be a failed template expansion, so probably a Parsoid bug - Gabriel, thoughts?
I added a screenshot so that the task becomes easier to understand
I was already wondering... yes when you wonder...there might be a good reason for that;-)
Thanks for the clarification. So you mean something like
http://saskatoon.cs.rit.edu/min_instructions/
No. By "plain wikitext" the filer means "in LaTeX rather than visually", hence the title of this task.
I tested

```
Math is unparsed but shown as plain wikitext: https://en.wikipedia.org/wiki/User:Raymond/Math
```
and i could edit without issues. I could see a renderd formula when visiting this page
https://en.wikipedia.org/wiki/User:Raymond/Math?veaction=edit
Ok it had the png rendering and not the MathML rendering, but I think this is a seperate bug.
>>! In T45058#932936, @matmarex wrote:
> This has been fixed a looong time ago, or needs a better summary to explain what's missing.

Happy?
This has been fixed a looong time ago, or needs a better summary to explain what's missing.
**physik** wrote:

I'm happy to see the interest in the Math extension.
It would be really great to get some code reviews. There are a lot of unmerged improvements that are already implemented that wait for a code review.
https://gerrit.wikimedia.org/r/#/q/status:open+project:mediawiki/extensions/Math,n,z
The fromula editor for math is one example. The code for Math 2.0 that was finished in beginning of October 2013 is still waiting for review and not moving forward at all. That's really a very sad situation. (Sorry for the spamming)
(In reply to PiRSquared17 from comment #28)
> I'm not sure we need to reinvent the wheel.  Aren't there already libre JS
> formula editors that can export to LaTeX?  I just found one from Google:
> http://mathdox.org/formulaeditor/

Who is talking about re-inventing the wheel?
I'm not sure we need to reinvent the wheel.  Aren't there already libre JS formula editors that can export to LaTeX?  I just found one from Google: http://mathdox.org/formulaeditor/
(In reply to Richard Morris from comment #26)
> I hope the LaTeX editor is not going to be short term. This is the preferred
> input method for the mathematical community. By all means develop a GUI but
> please make sure you can still use a LaTeX input method.

+1
I hope the LaTeX editor is not going to be short term. This is the preferred input method for the mathematical community. By all means develop a GUI but please make sure you can still use a LaTeX input method.
*** Bug 61498 has been marked as a duplicate of this bug. ***
(In reply to Andre Klapper from comment #21)
> It's a bit unclear to me which further steps are required to get this ticket
> closed (probably creating dependency tickets for the items in comment 19?).

No, the issues in comment 19 only refer to the short-term LaTeX editor. This bug is asking for a fully-featured visual interactive editor for formulae – will merge bug 61498 back into this.
Bug 57437 is to "Allow the VE dialog for math elements to be movable and resizable", which is already a blocker for this ticket. This assigned to a google code-in student, Theopolisme, who I suspect is no longer working on that bug.

I've create bug 61497 to cover up the jumbled up formula in comment 16.

I think Jiabao original plan was to create a GUI I've added a bug for this as bug 61498.

Dialog overlapping the equation might be resolved by bug 57437 or it could possibly resolved by changing the way it is initially displayed.
**physik** wrote:

From what I see
https://gerrit.wikimedia.org/r/#/c/105647/ and
https://gerrit.wikimedia.org/r/#/c/105648/
need to be resolved before we can make progress on that.
Seems that Jiabao is not currently working on this ticket, hence resetting ASSIGNED status. 
It's a bit unclear to me which further steps are required to get this ticket closed (probably creating dependency tickets for the items in comment 19?).
OK I've created bug 57437 for the tweaks to the dialog and assigned it to Theopolisme. Hope that OK.
There are different problems reported here, and we should have separate reports for each. Then we will tie each bug report to a Google Code-in task:

* The dialog overlaps the equation: the solution might be a combination of setting a default position with less chances of overlapping and/or allowing the dialog to be moved to a different position?

* The dialog is sometimes too small: the solution might be to make the dialog resizable?

* #Comment 16 deserves an own bug report but, haven't tested this plugin myself, I can't describe the problem or propose solutions.

Richard, would you like to create these reports?

I'm going to pull http://www.google-melange.com/gci/task/view/google/gci2013/5861921152565248 in order to create 2 GCI tasks or more. Theopolisme, you can try to work on these issues now, or you can wait until the plan is more defined (and Jiabao is back, or we have found a co-mentor able to help you).
Just a bit of background: Theopolisme is a Google Code-in student working on a task related to #comment 15 that was created by Jiabao:

http://www.google-melange.com/gci/task/view/google/gci2013/5861921152565248

Jiabao has been silent in the past days. Your help is welcome while she comes back. Thank you!
@Richard/others: Thinking about making the dialog draggable and resizable...

The solution I initially think of is installing jquery.ui and then adding some parameters to OO.ui.Window that allow it to be made resizable and/or draggable. However, if I recall correctly one of the principles of OOJS was to be self-contained... so would this be wrong? Could someone else with a bit more firsthand experience chime in here?
Also editing the last equation at https://www.mediawiki.org/wiki/VisualEditor:TestMath?veaction=edit

if you actually make a change to the text of the equation the displayed equation becomes very jumbled. Any vertical positioning is lost, and text from different lines are overlaid on top of each other.

This happens with Chrome on a Mac, I can't seem to edit equations at all with firefox or safari.
Created attachment 13550
Screenshot of editing a math block

Some small tweaks are needed to the dialog box. Editing the last equation at https://www.mediawiki.org/wiki/VisualEditor:TestMath?veaction=edit
there are a a few problems

1) The dialog obscures the actual equation
2) The dlalog is too small to see the whole source text of the equation

This could be solved the making the dialog, moveable and resizeable.

**Attached**: {F10189}
If you have open tasks or bugs left, one possibility is to list them at https://www.mediawiki.org/wiki/Google_Code-In and volunteer yourself as mentor.

We have heard from Google and free software projects participating in Code-in that students participating in this programs have done a great work finishing and polishing GSoC projects, many times mentores by the former GSoC student. The key is to be able to split the pending work in little tasks.

More information in the wiki page. If you have questions you can ask there or you can contact me directly.
GSoC "soft pencils down" date was yesterday and all coding must stop on 23 September. Has this project been completed?
Its important that it will be possible to enter the raw latex and that the text input area is large enough to enter a large formula. Editing the formula for atan2 at https://www.mediawiki.org/wiki/VisualEditor:TestMath now give a multi line box, but its still a bit small and wraps the formula. 

It may be an idea to use a different size box for inline formula which tend to be short and display formula which tend to be larger. $ vrs $$ in latex syntax, I don't know how you would distinguish this in VE.

The need for latex input was discussed at https://www.mediawiki.org/wiki/User_talk:Jiabao_wu and came up again at http://en.wikipedia.org/w/index.php?title=Wikipedia:VisualEditor/Feedback&curid=37904286&diff=570517247&oldid=570514963
Possibly related: https://en.wikipedia.org/wiki/Wikipedia_talk:Flow#Mathematics_under_Flow
(In reply to comment #7)
> @Richard this plugin won't be dependent on bug 36496 (MathJax as default).
> Texvc-compatible syntax remains the internal/wikitext format. MathJax
> provides
> a live-preview within VE to enable visual editing. (Of course, a future
> iteration might use MathJax to save MathML and SVG alongside the TeX.)

Have removed the dependency.

(In reply to comment #8)
> Is this connect with http://www.mediawiki.org/wiki/VisualEditor:TestMath?

Yes; that's the work being done by Jiabao Wu as part of Google Summer of Code. See https://www.mediawiki.org/wiki/User:Jiabao_wu/GSoC_2013_Project_Work for updates.
@Richard I don't know which VE version is running there. I think I should point out that this is a GSoC project in the middle of development, not anywhere near production ready, frequently breaking etc.
Is this connect with http://www.mediawiki.org/wiki/VisualEditor:TestMath? If so its a nice start but I'm having trouble editing a large formula for arctan2 at the bottom?
@Richard this plugin won't be dependent on bug 36496 (MathJax as default). Texvc-compatible syntax remains the internal/wikitext format. MathJax provides a live-preview within VE to enable visual editing. (Of course, a future iteration might use MathJax to save MathML and SVG alongside the TeX.)
**physik** wrote:

I think a combination of MathML and MathJax would be optimal.
See https://gerrit.wikimedia.org/r/#/c/69298/
Wondering how the rendering is going to happen? Is it going to use MathJax which is the only game in town at the moment? The default texvc render won't be up to the job as it need to recreate an image for every keystroke. MathML based renders have basically failed with poor browser support. 

If you use MathJax deployment will be a problem unless bug 36496 is fixed.
(In reply to comment #3)
> Are there any news on this?

Jiabao was accepted as a GSoC student and will be working on this with us. Updates are going to be added at [[mw:User:Jiabao wu/GSoC 2013 Project Work]].
Are there any news on this?
**jiabao.foss** wrote:

(In reply to comment #1)
> This will require Parsoid to be finished and expose ParserHooks to get
> alienated, and then a VE node handler to be written. The first bit is
> relatively easy, but the second is a very significant undertaking, so
> prioritising as "lowest".

Hello James, I have designed and written my proposal for a plugin that will fix this bug. http://www.mediawiki.org/wiki/User:Jiabao_wu/GSoC_2013_Application

I am not yet familiar with the VE architecture so I need some help understanding it and your comments. Is my design close to what it needed for a "node handler" for the maths elements in a wiki page. Also currently I have two modules named doc reader and doc writer. It would be helpful to know more about how these can interact with the document in visual editor.

The design that I proposed of the User Interface for my plugin be similar to that of google docs. I am wondering if this is closer to what the community wants and needs for VisualEditor. Or if it would be better to stay closer to the existing way special characters are inserted in the traditional wikitext editor.

Thanks,
Jiabao
sorry for the criticism, and WORKSFORME is better, of course!
Sorry for the lack of response; I reviewed this bug quite a few times in the months since it was reported, and each time was unable to reproduce (but quite clearly this was a repeatable bug, given the screenshot and two independent reports).

This was not a 'blocker' in the sense that we use it, though obviously for a (seemingly very small) number of installations/situations it was a serious bug.

Glad to hear that it works for you now; unfortunately, as we don't know what the root cause was, we can't proove that it's not going to re-occur. Thus I feel it would be inappropriate to assign it as "FIXED", so I will instead mark as "WORKSFORME".
It is possible that the bug has been resolved, I had reported it, but cannot reproduce it. Closing as "probably fixed".

A minor criticism on bug management: at the time when Jeffery and I reported this, it was a totally debilitating bug, a blocker. Simply not investigating the bug 4 months, seemingly never testing it, but then reducing the severity to "minor" seems odd.
Add to deployment milestone.
I just fixed it with https://en.wikipedia.org/w/index.php?title=MediaWiki:Common.css&diff=624714120&oldid=624708988
This is still occuring.  Pages with no edit notices pop up with "1 notice" when VE is launched.  It is not even useful in providing a link to where I *can* add an edit notice.
Fixed on-wiki.
Change 118369 merged by jenkins-bot:
mw.Target: Add class "mw-ve-editNotice" to edit notices

https://gerrit.wikimedia.org/r/118369
Change 118369 had a related patch set uploaded by Krinkle:
mw.Target: Add class "mw-ve-editNotice" to edit notices

https://gerrit.wikimedia.org/r/118369
Looks like we do have a replacement class that isn't too generic:

 .ve-ui-mwNoticesPopupTool-item ...

Though it is an internal class, not one I'd recommend we promote as an API for wikis to use. Let's use that as a temporary replacement, and add another one soon for the long term.
(In reply to Erik Moeller from comment #10)
> Regression; this is happening again on en.wp.

The system is an en.wikipedia hack, and can't be fixed from within VisualEditor without it knowing more than it should about English Wikipedia.

It comes down to their Editnotice system explicitly creating an edit notice to tell sysops "there are no edit notices on this page, click here to create one", which they present as... an edit notice.

Thus MediaWiki, and by extend VisualEditor, show it as an edit notice.

Last year I put a system in place that allows them to hide these using a css class.

(In reply to Minh Nguyễn from comment #12)
> I've proposed a client-side workaround at [[MediaWiki talk:Common.css#Edit
> notices and VisualEditor]].

That css was adopted by en.wikipedia as of https://en.wikipedia.org/w/index.php?title=MediaWiki%3ACommon.css&diff=562641575&oldid=560030040 and that fixed it for them, last year with this:

/**
 * Hide the redlink generated by {{Editnotice}},
 * this overrides the ".sysop-show { display: none; }" above that applies
 * to the same link as well.
 */
.ve-init-mw-viewPageTarget-toolbar-editNotices-notice .editnotice-redlink {
    display: none !important;
}


Commit https://gerrit.wikimedia.org/r/#/c/90378/ accidentally removed this class, thus the above CSS rule no longer applies.

The CSS proposed by Minh on [[MediaWiki talk:Common.css#Edit
> notices and VisualEditor]] is a bit too generic in my opinion, I would recommend against that.
*** Bug 55951 has been marked as a duplicate of this bug. ***
*** Bug 61335 has been marked as a duplicate of this bug. ***
I've proposed a client-side workaround at [[MediaWiki talk:Common.css#Edit notices and VisualEditor]].
Bug 55951 is possibly a duplicate?
Regression; this is happening again on en.wp.
Tagging with deploy-train cycle.
*** Bug 57019 has been marked as a duplicate of this bug. ***
(In reply to Liangent from comment #11)
> (In reply to James Forrester from comment #10)
> > No, all edits - this is the same as [http://fr.wikipedia.org/wiki/Foo Bar]
> > being automatically converted by Parsoid to [[:fr:Foo|Bar]] which it already
> > does.
> 
> I feel there're still some deliberate use cases of external local links, for
> example, to prevent Echo notifications (see [[Template:Noping]]).

Users making hacks around bugs in Echo sounds like something we should fix in Echo so users don't have to do it, though. :-)
(In reply to James Forrester from comment #10)
> No, all edits - this is the same as [http://fr.wikipedia.org/wiki/Foo Bar]
> being automatically converted by Parsoid to [[:fr:Foo|Bar]] which it already
> does.

I feel there're still some deliberate use cases of external local links, for example, to prevent Echo notifications (see [[Template:Noping]]).
(In reply to Liangent from comment #9)
> (In reply to James Forrester from comment #8)
> > Feels like this has consensus that we should convert newly-added
> > [http://en.wikipedia.org/wiki/foo] links to [[foo]] automatically; I think
> > that this should be done inside Parsoid, so moving there.
> 
> But only for VisualEditor edits? if Parsoid is going to be used in other
> stuff eg. bots.

No, all edits - this is the same as [http://fr.wikipedia.org/wiki/Foo Bar] being automatically converted by Parsoid to [[:fr:Foo|Bar]] which it already does.
(In reply to James Forrester from comment #8)
> Feels like this has consensus that we should convert newly-added
> [http://en.wikipedia.org/wiki/foo] links to [[foo]] automatically; I think
> that this should be done inside Parsoid, so moving there.

But only for VisualEditor edits? if Parsoid is going to be used in other stuff eg. bots.
Feels like this has consensus that we should convert newly-added [http://en.wikipedia.org/wiki/foo] links to [[foo]] automatically; I think that this should be done inside Parsoid, so moving there.
Also, when users create a new article and want to link back to it immediately, they end up attaching "?venotify=created" to the external link they're copy/pasting, and this is something VE will need to strip before converting the URL to a wikilink.
I think maybe it should just recognize when a url points to an existing Wikipedia article, and offer that as an internal link option, similarly to the way that you get an internal link option for the article titled [[http://en.wikipedia.org/wiki/foo]]. That latter behavior represents a tiny edge case, though, as there are very few articles that start with http://. If there is ever going to be some sort of 'advanced' mode for links, then options to use external links to existing articles and internal links to articles starting http* should be hidden away there. In the vast majority of cases, users intend to create internal links if the article exists, and do not intend to create internal links to pages starting http*.

Incidentally, we want to add the same functionality to the EducationProgram extension for when users paste in a url to the article form: bug 44397.
I'd go for "prevent". (Also, it would be really nice to have it soon).
Seeing a few of these in the feed. Warn, perhaps? (In the link inspector dialog.)
(In reply to comment #2)
> Sometimes it is done deliberately, e.g. at
> https://en.wikipedia.org/w/index.php?title=English_Wikipedia&oldid=558847653
> . 
> In that case, they do use olids (permalinks), which is a way you could
> distinguish if you wanted to do the auto-replacement.

We could do an always-replace for [http://foo/wiki/* $1], but that feels like a fragile regexp. :-(
Sometimes it is done deliberately, e.g. at https://en.wikipedia.org/w/index.php?title=English_Wikipedia&oldid=558847653 .  In that case, they do use olids (permalinks), which is a way you could distinguish if you wanted to do the auto-replacement.
Merged and will go out with wmf5.
Related URL: https://gerrit.wikimedia.org/r/64492 (Gerrit Change Ib43d1938ffa24bc8d1dc76a300e16e486dabd928)
I'd suggest that once that change has been merged this bug can be closed.
Fixed the zero-history case, and the onbeforeunload issue: https://gerrit.wikimedia.org/r/#/c/53988/
After some more investigation is appears that comparing html might not do the trick. Doing something trivial like typing and deleting may not leave the html in it's original state. We currently have change markers (although these are queued up for deletion), but also hidden things like pawn characters and maybe other things in the future.

We can still implement the transaction stack check which we don't have at the moment, but telling you if there is a non-zero diff may have to be a job for Parsoid.
Agree on the window.onbeforeunload.

Not totally enamoured with the idea of a modal alert telling users off for behaviour that is currently silently failing (in core wikitext editor, if you make a null save it'll look like it saved, but no new entry in the history log).

Possibly we could over-ride the edit-success box to say "You made no changes so nothing was saved" or something similar? We should probably talk to E3 to see if this is something they'd want to see happen in core anyway...
Right now the Save button becomes enabled after the first transaction is applied and never goes back to disabled, even if the first transaction is undone. While this isn't ideal, doing a full HTML comparison on pretty much every keystroke may be a bit of an unnecessary overhead. Even doing an transaction stack comparison is a little unnecessary.

The real problem here is the creation of null edits and that only needs to be addressed when the save button is pressed. This could trigger an alert ("You haven't made any changes") and reset the button to disabled. We should also run this check in the window.onbeforeunload handler so people can leave the page nag-free if they undo their edits.
This works now, "&nbsp;" isn't spelled out any more, and the nbsp is rendered as a <span class="ve-ce-MWEntity"> in the editor as it's supposed to be. There are probably some selection issues with the nbsp's and with the ampersands encoded as &amp; but that's due to a different bug.
Change 112490 merged by jenkins-bot:
Show preview of edit summary in review screen

https://gerrit.wikimedia.org/r/112490
Change 112490 had a related patch set uploaded by Alex Monk:
Show preview of edit summary in review screen

https://gerrit.wikimedia.org/r/112490
To clarify, when the diff is shown ('Review your changes' dialog pane) we want to parse the entered summary and display it, probably above the diff.
(In reply to comment #1)
> As Max says, to be resolved by the dialog being a mini-VE surface.

So this has been assigned to me but I think I need a few pointers. Firstly, where can I find the code for mini-surfaces?
From Bug 53729:
A De.WP user suggested to include a preview for the edit summary. Report:

https://de.wikipedia.org/w/index.php?title=Wikipedia:Technik/Text/Edit/VisualEditor/Beta2013-07&oldid=122207411#Vorschau_f.C3.BCr_Zusammenfassung_und_Quellen
*** Bug 53729 has been marked as a duplicate of this bug. ***
User:Elizium23 at en.wp comments that the current save dialog "permits entry of an edit summary with newlines, however, no newlines are preserved in the edit summary when it is saved to the Wiki. This is confusing, because I just used a WYSIWYG editor, but what I see in the edit summary is not what I get."

While, AIUI, the current dialog is only temporary the issue of newlines (and presumably bold, italic, etc) will be applicable to the new "surface" unless that doesn't permit these features or edit summaries are upgraded to support them.
Per bug 51125 (which has been merged into this one), we should show the edit summary if provided in the "Review your changes" tab
*** Bug 51125 has been marked as a duplicate of this bug. ***
Need to discuss desired behaviour. Not sure we should implement as described above.
Assigning to Ed; this is to be done after the list code cleanup that he's doing already.
(In reply to comment #4)
> Can someone elaborate on some of the most common use cases for creating
> redirects to give a bit more background to this for new users not as
> familiar.
> 
> Also, is this a band aid? do we need to step back and think about the reason
> redirects are created in the first place? Does mediawiki support the concept
> of
> page aliases? Does the redirected page need to continue to exist as a regular
> wikipage after the redirect has happened?

[[m:Help:Redirect]] contains the necessary educational material for the topic.
**swalling** wrote:

(In reply to comment #4)
> 
> Also, is this a band aid? do we need to step back and think about the reason
> redirects are created in the first place? Does mediawiki support the concept
> of
> page aliases? Does the redirected page need to continue to exist as a regular
> wikipage after the redirect has happened?

Yes, I think the redirected page should exist as a regular wikipage after the redirect has happened. This allows any editor to un-redirect something without needing a special form or other interface, edit the redirect easily, etc. 

Consider this real case from English Wikipedia:

* Someone originally made "Deforestation in Brazil" a redirect to the Deforestation section in Amazon Rainforest. This isn't bad, but they're not actually aliases of each other precisely. This happens more than you'd think.
* Later, someone un-redirected Deforestation in Brazil, and expanded it to be a large independent article. This was made easy by the fact that redirects are still wiki pages. Otherwise, there'd have to be new background processes to re-make a redirect as a wiki page. 

Part of the challenges with the current implementation, which involves using somewhat arcane markup, will be solved by VisualEditor.
Can someone elaborate on some of the most common use cases for creating redirects to give a bit more background to this for new users not as familiar.

Also, is this a band aid? do we need to step back and think about the reason redirects are created in the first place? Does mediawiki support the concept of page aliases? Does the redirected page need to continue to exist as a regular wikipage after the redirect has happened?
(In reply to comment #2)
> Thanks to Daniel Friesen for pointing out that
> https://www.mediawiki.org/wiki/Extension:CreateRedirect exists.

Right. This bug is about MediaWiki core, though.
Thanks to Daniel Friesen for pointing out that https://www.mediawiki.org/wiki/Extension:CreateRedirect exists.
I can see plenty of Wikimedia and other MediaWiki users happy with this feature.

It would be good to know whether there is a buy in from the Core maintainers or whether they think this should be handled by an extension. A rough idea of the estimated work would be useful too. It sounds like a potential candidate for http://www.mediawiki.org/wiki/Mentorship_programs/Possible_projects

PS: found thanks to https://www.mediawiki.org/wiki/Bug_management/Triage/20130307
Change 192749 merged by jenkins-bot:
Refactoring mw.Feedback to work with OOUI elements

[[https://gerrit.wikimedia.org/r/192749]]
Change 32700 abandoned by Jforrester:
Feedback includes browser info, given user permission

Reason:
Being done as part of Id1967a83a.

[[https://gerrit.wikimedia.org/r/32700]]
Change 192749 had a related patch set uploaded (by Mooeypoo):
[wip] Refactoring mw.Feedback to work with OOUI elements

[[https://gerrit.wikimedia.org/r/192749]]
(In reply to James Forrester from comment #9)
> When you post on a talk page you write every byte that gets inserted (except
> for ==s for new sections and PST substitutions).

Now that you mention that, I'd say that if you're not logged in, your IP address is also included on the page history.
(In reply to James Forrester from comment #9)
> When you post on a talk page you write every byte that gets inserted 

Definitely not,

> (except
> for ==s for new sections and PST substitutions). 

as you say yourself,

> That's very different from
> auto-inserting

and how about the preload parameter?
If pre-save transform is consider radically different from preload, we could use a new magic word OMGREALLYSCARYPRIVATEDATABUTPLEASESHAREIFYOUWANTTOHELPTHESOFTWARE.
(In reply to Nemo from comment #8)
> (In reply to James Forrester from comment #7)
> > Though that sounds attractive, I'm told that that would not be appropriate,
> > informed consent.
> 
> How is it different from posting on a talk page? Surely such a difference
> can be eliminated.

When you post on a talk page you write every byte that gets inserted (except for ==s for new sections and PST substitutions). That's very different from auto-inserting private data (their user agent string) and hoping that they recognise it as such and remove it if they're not comfortable with that level of privacy intrusion.
(In reply to James Forrester from comment #7)
> Though that sounds attractive, I'm told that that would not be appropriate,
> informed consent.

How is it different from posting on a talk page? Surely such a difference can be eliminated.
(In reply to Nemo from comment #6)
> However I think there ought to be a much simpler solution: why can't the
> dialog just add the requested user-agent information in the text area?
> Instead of being blank, the "message" could be prefilled with "~~~~ (using
> Firefox 30)" or similar (when configured to do so). The user would have a
> very obvious way to remove the information by deleting it from the message;
> if they don't, it will be covered by
> https://meta.wikimedia.org/wiki/Privacy_policy#Because_You_Made_It_Public

Though that sounds attractive, I'm told that that would not be appropriate, informed consent.
I very much agree this is needed, especially for https://commons.wikimedia.org/wiki/Commons:Upload_Wizard_feedback where many sections are made of little use for lack of any browser information.

However I think there ought to be a much simpler solution: why can't the dialog just add the requested user-agent information in the text area? Instead of being blank, the "message" could be prefilled with "~~~~ (using Firefox 30)" or similar (when configured to do so). The user would have a very obvious way to remove the information by deleting it from the message; if they don't, it will be covered by https://meta.wikimedia.org/wiki/Privacy_policy#Because_You_Made_It_Public
Patch in Gerrit (link in comment 2) still needs review.
Fixed given the alienation re-write.
Fixed (https://gerrit.wikimedia.org/r/#/c/48964/).
@James: at this moment we don't have a way to select node yet, so I'm not sure what you are seeing.
@Nicolas: we might not be able to find solution to this problem soon. However - you should be able to get in front of nowiki block by using your arrow keys.
mw.org is not running current master- it is still on the December code version. So this is to be expected. http://parsoid.wmflabs.org/ runs the latest code.

We need to work out some issues with selective serialization before we can deploy a new version to the mw.org / enwiki backend. You'll see the fix for this bug in production after that deploy.
(In reply to comment #6)
> (In reply to comment #5)
> > It was fixed by a rework of the link serializer I did earlier this month.
> > That
> > code is not yet deployed on mw.org. You can verify that it is fixed in
> > Parsoid
> > by following Roan's instructions in comment 2. You can also do
> > 
> > echo '<p><a href="Foo" rel="mw:WikiLink">foo</a></p>' | nodejs parse
> > --html2wt
> 
> OK I'll retest it on Feb 4.

Bug persists.

https://www.mediawiki.org/w/index.php?title=VisualEditor:LinkTrailReEditBug&diff=641685&oldid=641684
(In reply to comment #5)
> It was fixed by a rework of the link serializer I did earlier this month.
> That
> code is not yet deployed on mw.org. You can verify that it is fixed in
> Parsoid
> by following Roan's instructions in comment 2. You can also do
> 
> echo '<p><a href="Foo" rel="mw:WikiLink">foo</a></p>' | nodejs parse
> --html2wt

OK I'll retest it on Feb 4.
It was fixed by a rework of the link serializer I did earlier this month. That code is not yet deployed on mw.org. You can verify that it is fixed in Parsoid by following Roan's instructions in comment 2. You can also do

echo '<p><a href="Foo" rel="mw:WikiLink">foo</a></p>' | nodejs parse --html2wt
(In reply to comment #3)
> Current output is [[foo]].

I assume this was fixed a while ago because you didn't specify a commit.

But this bug still exists on mw.org. See https://www.mediawiki.org/w/index.php?title=VisualEditor:LinkTrailReEditBug&diff=637012&oldid=637011

I noticed that it's impossible to select a part of a word, click "Edit link", then trash the link (the whole word is unlinked instead), but it's still possible to select some characters, then click "Clear formatting" to unlink those characters.
Current output is [[foo]].
Images drag-and-drop positioning is now merged (in gerrit 69279) and will go live shortly; for non-media items, I've split that off as bug 49981, and am closing this.
Gerrit 69279 is drag-and-drop moving for images.
What's the movement on this? Not trying to rush you guys - we have some users wondering :).
*** Bug 49486 has been marked as a duplicate of this bug. ***
I can see that work has started on this, with the mouse cursor changing to a "move that item" cursor, and the text caret trying to follow it (despite having some trouble at it sometimes).
The text does not get moved yet, but I guess the issue is progressing :-)
Probably possible (at least in Chrome and Firefox).
<span> is done. Reopening for <div>.
*** This bug has been marked as a duplicate of bug 47759 ***
This is now invalid, as we actually provide the SVGs by default to every browser that doesn't fail on them (yay).
(In reply to comment #2)
> A pointer implies that clicking will follow the link, when in fact it places
> a text cursor, hence cursor:text (as it is) is more appropriate. Both LO/OO
> and Google Docs use cursor:text for links.
> 
> WONTFIX unless I have misunderstood the point.

Agreed.
A pointer implies that clicking will follow the link, when in fact it places a text cursor, hence cursor:text (as it is) is more appropriate. Both LO/OO and Google Docs use cursor:text for links.

WONTFIX unless I have misunderstood the point.
Obsolete somewhat. I'm not sure whether it's specifically "fixed", but I've got a way of doing it so I only need to run it once
This has now (finally!) OK to merge, and has been.
Change 69856 merged by jenkins-bot:
Use postEdit mw.hook for save notifications

https://gerrit.wikimedia.org/r/69856
Change 69855 merged by jenkins-bot:
Allow postEdit hook to be triggered asynchronously

https://gerrit.wikimedia.org/r/69855
**swalling** wrote:

%%%*** Bug 50642 has been marked as a duplicate of this bug. ***%%%
Related URL: https://gerrit.wikimedia.org/r/69856 (Gerrit Change Id4a8bc22c09a552ef79670b0d4fc4a70df07ec33)
Related URL: https://gerrit.wikimedia.org/r/69855 (Gerrit Change I778b18bc051c51de355e122d8d4517b5a651ed4c)
(In reply to comment #8)
> In VE, saving an edit does not cause you to reload the page, so we
> can't use the mechanism.

It would only require a very modest refactoring to make the 'postEdit' hook triggerable by VE.
Looking at the code

https://git.wikimedia.org/blob/mediawiki%2Fcore.git/HEAD/resources%2Fmediawiki.action%2Fmediawiki.action.view.postEdit.js

it appears this extension is not designed to work asynchronously. It expects a cookie to have been set, then fires immediately on page load. In VE, saving an edit does not cause you to reload the page, so we can't use the mechanism.
*** Bug 43091 has been marked as a duplicate of this bug. ***
OK, after talking with Steven, [[mw:Extension:PostEdit]] is going to be moved in MW core at which point we can depend on it, and not re-implement the wheel. This means that users will get the same styling and text of messages whether they save via the wikitext editor or VisualEditor; yay.
Change 254041 merged by jenkins-bot:
VisualEditor: Move code for Cite into this repo

[[https://gerrit.wikimedia.org/r/254041]]
Change 254041 had a related patch set uploaded (by Jforrester):
[WIP] Move VisualEditor code for Cite into this repo

[[https://gerrit.wikimedia.org/r/254041]]
Change 248014 merged by jenkins-bot:
References: Don't load ext.visualEditor.mwreference if Cite is not installed

[[https://gerrit.wikimedia.org/r/248014]]
Change 248014 had a related patch set uploaded (by Esanders):
References: Don't load ext.visualEditor.mwreference if Cite is not installed

[[https://gerrit.wikimedia.org/r/248014]]
Re-prioritising.
(In reply to Andre Klapper from comment #3)
> In Bug 13127 comment 34 anomie wrote
> "Since Parsoid has reimplemented the Cite extension in their own code, any
> fixes to Cite are going to be very difficult to get merged unless someone
> wants to do all the work twice, once in PHP and once in nodejs."

That's a totally different issue about Parsoid's Cite vs Cite.php; this bug is about the location of code currently in the VisualEditor-MediaWiki repo that should be moved to the Cite extension's repository, like we did for <math> etc. Not sure if there's a bug about that?


> James: Quim wondered if this means that all Cite bugs.docs can be eventually
> and officially deprecated.

That's a question for the mythical other bug (but I'd say no).


> Any vague timeframe for this ticket, assuming that Trevor still works on
> this?

I'd want it to settle down a little more before the code was transitioned, but probably in a few months' time.
In Bug 13127 comment 34 anomie wrote
"Since Parsoid has reimplemented the Cite extension in their own code, any fixes to Cite are going to be very difficult to get merged unless someone wants to do all the work twice, once in PHP and once in nodejs."

James: Quim wondered if this means that all Cite bugs.docs can be eventually and officially deprecated.

Any vague timeframe for this ticket, assuming that Trevor still works on this?
Adding 'javascript' keyword, because I think this is JavaScript related...
After discussion with Timo, clarifying what this is.
I agree that "Something went wrong" isn't very helpful.  What would be helpful is an explanation of what to do.  For example, if it's hopeless and you've just lost all of your work, then acknowledging that it's hopeless would save people the time and stress of trying to save it.
For what is worth, Catalan Viquipedia users confused about an error message from Parsoid:

  Alguna cosa no ha funcionat

  parsoidserver-http: HTTP 500

  Descarta

"Something didn't work"  :)

https://ca.wikipedia.org/wiki/Topic:Shssmsofmcgkqhmv
I just hit this message (was about to reported a semi-dupe) on enwiki. I got the below variant:

```
Error loading data from server: parsoidserver-http-bad-status:
404: No pages were returned from the API request for $article.
Would you like to retry?" (yes/no)
```

I hit yes and it worked. So... why not just retry without asking me first?

If it fails again (or for X times, whatever) then give a more generalized "ooops, sorry 'bout that" message with a "click here for more info" dropdown (with the message I just pasted, minus the "would you like to retry?" bit, of course).
With the above patch, the former message:

    Error loading data from server: parsoidserver-http-bad-status:
    500. Would you like to retry?

… turns into:

    Error loading data from server: parsoidserver-http-bad-status:
    500: Page Fetch failure for "BADURL": Error: getaddrinfo
    ENOTFOUND. Would you like to retry?

Which is not ideal, but at least describes things a bit.
Change 157775 merged by jenkins-bot:
Add debugging help to VisualEditor

https://gerrit.wikimedia.org/r/157775
Change 157775 had a related patch set uploaded by Jforrester:
Add debugging help to VisualEditor

https://gerrit.wikimedia.org/r/157775
(In reply to Technical 13 from comment #4)
> Technically, I think to implement this, each protection level would have to
> be given it's own column in the table with an expiration date

That's not actually how the existing page_restrictions table is structured.

What would probably have to happen is that they unique index would have to change from (pr_page,pr_type) to (pr_page,pr_type,pr_level). And then various bits of code would need to be adjusted to deal with this.

> and the highest level of non-expired protection would be applied.

It's not necessarily possible to decide that one protection level is "higher" than another. For example, you probably know that enwiki created a new "templateeditor" protection level. What if enwiki decided they also wanted a special protection level for policy pages, and created a "policyeditor" protection level.[1] Which would be higher, "templateeditor" or "policyeditor"?

So what would have to happen is that a page with multiple protection levels active at once could be edited only by editors who could edit through each protection level individually.

There does seem to already be some support along these lines in the code, for example Title::getRestrictions() is defined to return an array of restrictions and Title::checkPageRestrictions() checks whether the user is allowed to edit through all of them. But I don't know for sure whether everything everywhere will correctly handle it.

And despite Title handling multiple restriction levels for an action, there's doesn't seem to be support for the different restriction levels expiring at different times (e.g. Title::getRestrictionExpiry() assumes there's only one relevant time). And then there are the UI issues too, with making a sensible protection form dealing with different restriction levels expiring at different times.


 [1]: Yes, this example is *incredibly* unlikely. But it illustrates the point.
Technically, I think to implement this, each protection level would have to be given it's own column in the table with an expiration date and the highest level of non-expired protection would be applied.  I'm not sure how hard it would be to implement, but think it is a good idea.
Wikimedia has migrated from Bugzilla to Phabricator. Learn more about it here: https://www.mediawiki.org/wiki/Phabricator/versus_Bugzilla - This task does not make sense anymore in the concept of Phabricator, hence closing as declined.
s/malicious/pernicious/ (a comment on #mediawiki confirmed my suspicion that the inaccurate translation of the Italian word I had in mind is... pernicious).
I'm adding bug 55807 as blocker, because that bug adds a malicious incentive to this organisational antipattern.
(In reply to comment #15)
> Low hanging fruit? What about moving all the Wikimedia mobile apps under a
> same
> umbrella called "Wikimedia mobile apps":
> 
> * Commons App
> * Wiki Loves Monuments
> * Wikipedia App

+1. We already did this once! See bug 41922.
Low hanging fruit? What about moving all the Wikimedia mobile apps under a same umbrella called "Wikimedia mobile apps":

* Commons App
* Wiki Loves Monuments
* Wikipedia App
(In reply to comment #8)
> I'm gonna go ahead and mark this bug as easy. It really just needs someone to
> sit down and figure out/write down a sensible hierarchy at
> <https://www.mediawiki.org/wiki/Requests_for_comment/Bugzilla_taxonomy> and
> then get it implemented (or implement it themselves, if a current Bugzilla
> admin takes this on). That shouldn't be very difficult to do.

You misunderstood the meaning of the "easy" keyword. This keyword is for new developers, to find bugs to start their first commits. While "writting a list" is easy, the problem is "figuring out" what to put on that list, and a new developer is definitively not the right person to do that. Removing keyword.
@greg: agreed, I prefer the project/tag over a tracking bug.
>>! In T40865#1159225, @mmodell wrote:
> @greg: By "next train release" do you mean the new branch that gets created on wednesday or any train deployment in general? 

The perpetual next release. This bug was used by Reedy to have a place to look for bugs to be pushed out with the train.

We now also have #WMF-Server-Backports, which we should probably use in lieu of this tracking bug, which is what https://www.mediawiki.org/wiki/Backporting_fixes says anyway...

If that sounds ok with you (@mmodell) then let's just close this bug, bid it farewell and thank it for its use over the years...
@greg: By "next train release" do you mean the new branch that gets created on wednesday or any train deployment in general?
>>! In T40865#1076036, @Nemo_bis wrote:
>> What are we going to do with this task now?
> 
> Maybe Mukunda has opinions. :)

@mmodell: how would you like to deal with "things (like config patches) people want to be included in the next train release".

There's already #wmf-server-backports which we aren't using much at all yet.
> What are we going to do with this task now?

Maybe Mukunda has opinions. :)
What are we going to do with this task now?
Cleared backlog of next-deployment changes that have since been processed.
(In reply to comment #16)
> Greg, are we still using this tracking bug?  If not, let's just close this.

Reedy is, and intends to, keep an eye on it. Andre and others are using it actively. I less so, but Andre usually beats me to the punch.

There's also the request for backport flag, which is being used (9 confirmed requests, last one sept 25th). Slight overlap, but not much, really (this one being for "things that should be done at next train start" and backport flags being for "this needs to happen now, now.").
(For reference, Greg and Reedy say that we do.)
Greg, are we still using this tracking bug?  If not, let's just close this.
Marking this back as FIXED (as it has been fixed in Vector for a while).
Change 151395 merged by jenkins-bot:
Use .mw-body in skins

https://gerrit.wikimedia.org/r/151395
Change 151395 had a related patch set uploaded by Jforrester:
Use .mw-body in skins

https://gerrit.wikimedia.org/r/151395
Change 153740 abandoned by Catrope:
Scope external link styling rules to #content rather than #bodyContent

Reason:
Yeah, that looks much better, thanks guys.

https://gerrit.wikimedia.org/r/153740
Change 153740 had a related patch set uploaded by Catrope:
Scope external link styling rules to #content rather than #bodyContent

https://gerrit.wikimedia.org/r/153740
(In reply to Spinningspark from comment #6)
> I'm not seeing this as entirely fixed.  The redlink issue has been fixed but
> there are still other colour issues:
> 
> * Visited redlinks are not shown in the visited redlink colour, they are
> shown in the redlink colour.
> * External links are not shown in the external links colour, they are shown
> in the internal links colour.
> * Link icons are omitted: external, secure, pdf etc.
> 
This caught my attention because external link icons have been working for me for a while. Turns out they work in Vector but not in Monobook. This appears to be a bug in Monobook, it's scoping link icon CSS to the wrong div (#bodyContent instead of #content).
I'm not seeing this as entirely fixed.  The redlink issue has been fixed but there are still other colour issues:

* Visited redlinks are not shown in the visited redlink colour, they are shown in the redlink colour.
* External links are not shown in the external links colour, they are shown in the internal links colour.
* Link icons are omitted: external, secure, pdf etc.

The raison d'etre of VE is that it is WYSIWYG while editing.  Not having links in the right colour defeats this and can lead to mistakes.
Verified the fix in production
Verified the fix in Betalabs and test2
Change 130769 merged by jenkins-bot:
Style external links and their suggestions with the right color

https://gerrit.wikimedia.org/r/130769
Change 130769 had a related patch set uploaded by Jforrester:
Style external links and their suggestions with the right color

https://gerrit.wikimedia.org/r/130769
Applying the same CSS may be difficult, but internal vs external links should be rendered differently somehow.
Merged and will go out with wmf5.
Related URL: https://gerrit.wikimedia.org/r/65332 (Gerrit Change I9b5e3b3e62b52c86743ee345b1cc31beec0a061e)
I think users wouldn't try to partially-select for linking if [[apple]]s worked with VE.
And one half of fixing that would be to search for "Apple" for links suggestions if "Apples" isn't found.
If the user then selects "Apple" in the suggestions, the correct

```
<a href=Apple>apples</a> -> "[[apple]]s"
```
link would be created.

And if "Apple" is found (because a redirect from "Apples" to "Apple"), since it can be detected as a part of "Apples", the correct link can be created too.
I think users wouldn't try to partially-select for linking if [[apple]]s worked with VE.
And one half of fixing that would be to search for "Apple" for links suggestions if "Apples" isn't found.
If the user then selects "Apple" in the suggestion, the correct

```
<a href=Apple>apples</a> -> "[[apple]]s"
```
link would be created.

And if "Apple" is found (because a redirect from "Apples" to "Apple"), since it can be detected as a part of "Apples", the correct link can be created too.
I think users wouldn't try to partially-select for linking if [[apple]]s worked with VE.
And one half of fixing that would be to search for "Apple" for links suggestions if "Apples" isn't found.
If the user then selects "apple" in the suggestion, the correct

```
<a href=Apple>apples</a> -> "[[apple]]s"
```
link would be created.

And if "Apple" is found (because a redirect from "Apples" to "Apple"), since it can be detected as a part of "Apples", the correct link can be created too.
(In reply to Krinkle)
> VisualEditor: Make it hard for users to partially-select some text for linking
> →
> VisualEditor: Make it easier to select a link in its entirety (instead of part it)

This isn't actually the bug as filed (or the problem). It's already trivially easy to select an existing link in its entirety (you don't even need to select it); this bug is about when you've made a selection of text which doesn't have a link and are making it into one.

Reverting and making a little clearer.
Sorry, that second link should be bug 48789
(In reply to comment #10 and comment #8)
These issues should be solved by making it easy to explicitly set the link and the display text independently and unambiguously in the link dialog as is asked for in bug 50945 and bug 47879
(In reply to comment #9)
> (In reply to comment #7)
> > What is the status of this bug? Currently it is not possible to link or
> > unlink part of a word, nor to unlink part of a multi-word link.
> 
> That's a very worrying problem - what browser are you using that makes this
> impossible? Does it happen on every page? When you say "impossible", do you
> mean that:
> 
> * the link inspector doesn't open when fired on a partial selection,
> * setting the link on a partial selection doesn't cause a link to be added,
> * on saving the link on the partial selection, it doesn't turn into the
> expected wikitext, or
> * something else that I've not covered?
> 
> I can very much add and remove links to parts of words using the link
> inspector, and remove parts of existing links using the "clear formatting"
> button. Hence the issue.

The behaviour has changed since the last depot it seems. Currently when using Firefox 22 on Xubuntu Linux:
*Selecting part of a word and pressing ctrl+k means I can link only the selected part (previously ctrl+k was selecting the whole word and then opening the link dialog). This currently works as it should.
*Unlinking part of a word or multi-word link is not possible with the link tool: 
**If there is the link [[Background]] and I select "ground" and press ctrl+k the selection is changed to "Background" and then the link dialog opens
**If there is the link [[Woolwich Arsenal station]] and I select "station" and press ctrl+k the selection is changed to "Woolwich Arsenal station" and then the link dialog opens. (This has not changed since my previous comment)
*Selecting part of a linked word or phrase and removing the formatting does remove the link only on the selection, but also removes any and all other formatting on that selection. Per Bug 51757 this is not desirable.
(In reply to comment #8)
> I fail to see the purpose of nowikiing the remainder of a partially linked
> word.  If I link "LC circuit" in the string "LC circuits" then I expect the
> UI
> to create "[[LC circuit]]s", not "[[LC circuit]]</nowiki>s".  That latter
> behaviour is entirely useless in any normal editing scenario I can think of.
> 
> The selection should not be expanded automatically.  The UI should assume the
> editor knows what they are doing unless there is evidence to the contrary. 
> When I make a partial selection like this it means I want the UI to offer "LC
> circuit" as the link target and display "LC circuits" as the link text.

That may be what you expect, with your deep understanding of wikitext, but it's very far from how normal visual editors work and so would be very confusing to users who are not immersed in the fine points of link trails.

More fundamentally, making a change in one place that magically affects another is a bad user experience. Why would this magic happen with links but not, say, adding bold? Why would this happen down-word but not up (except on wikis with linkhead instead of/as well as linktrail)? Etc.
(In reply to comment #7)
> What is the status of this bug? Currently it is not possible to link or
> unlink part of a word, nor to unlink part of a multi-word link.

That's a very worrying problem - what browser are you using that makes this impossible? Does it happen on every page? When you say "impossible", do you mean that:

* the link inspector doesn't open when fired on a partial selection,
* setting the link on a partial selection doesn't cause a link to be added,
* on saving the link on the partial selection, it doesn't turn into the expected wikitext, or
* something else that I've not covered?

I can very much add and remove links to parts of words using the link inspector, and remove parts of existing links using the "clear formatting" button. Hence the issue.
I fail to see the purpose of nowikiing the remainder of a partially linked word.  If I link "LC circuit" in the string "LC circuits" then I expect the UI to create "[[LC circuit]]s", not "[[LC circuit]]</nowiki>s".  That latter behaviour is entirely useless in any normal editing scenario I can think of.

The selection should not be expanded automatically.  The UI should assume the editor knows what they are doing unless there is evidence to the contrary.  When I make a partial selection like this it means I want the UI to offer "LC circuit" as the link target and display "LC circuits" as the link text.
What is the status of this bug? Currently it is not possible to link or unlink part of a word, nor to unlink part of a multi-word link.
>>! In T39870#997795, @Jdforrester-WMF wrote:
> Replaced with projects.

Which ones? I definitely can't watch the entire VisualEditor-MediaWiki-plugins component.
Replaced with projects.
Related URL: https://gerrit.wikimedia.org/r/68223 (Gerrit Change I547e06dcdb92e19f0159660314187c4f1a62f3ed)
*** Bug 48254 has been marked as a duplicate of this bug. ***
Verified that this bug no longer exists in CirrusSearch, as the third search result for that query for me is RenameRequest.js. As we're migrating from Lucene to CirrusSearch, I'm closing this bug as RESOLVED WONTFIX.
This results in VisualEditor returning empty searches even when the exact, complete file name is given as the search term.

At Commons' own Special:Search, searching for the exact, complete file name produces self-contradictory results:

  There were no results matching the query.
  There is a page named "File:GreatNurse.jpeg" on this wiki
(In reply to comment #0)
> A search for Dateiverschieber
> https://commons.wikimedia.org/w/index.
> php?title=Special%3ASearch&profile=advanced&search=Dateiverschieber&fulltext=
> Search&ns8=1&redirs=1&profile=advanced
> should find [[commons:MediaWiki:RenameRequest.js]]
> 
> But it does not. 

Confirming for this example.
I see... Pity.
As we cannot retest, closing as per comment 1.
**questpc** wrote:

Andre, MediaWiki is unpopular framework here in Russia. Our education system receives much smaller financing comparing to first world countries. Grants and charities are also very small, infrequent and hard to get. Non-commercial work is self-prohibitive because the life is expensive and wages are small (not in Moscow, at least). So I was not getting enough of freelancer MediaWiki job. Thus I was forced to move to Drupal then to my own framework. Sometimes I do small MediaWiki work but not so often and I lost deep knowledge of MediaWiki internals I had back in 1.15-1.17 times (API, FileRepo, early versions of ResourceLoader).

But of course previous lack of good scripting and lack of VisualEditor also contributed to low popularity of MediaWiki here in Russia. Hope it will get more popular again.

The site is now running 1.22wmf1. It was not my personal site but a freelancer job.
(In reply to comment #1)
> Modules can be dynamically registered. This should be checked in mediawiki.js
> instead. I believe this has been fixed in 1.19 or 1.20, could you confirm?

Dmitriy: Still running 1.18, or have you upgraded in the meantime?
If the latter, cxould you answer above question?
Please comment on that bug
https://phabricator.wikimedia.org/T78046
The only report currently marked as blocker is T37186 and is being discussed there. Going through the #Math component may find some more blockers.
What's the status of this now? It's been a while since it was last discussed. Are the reasons to not use MathJax just as valid now?
**physik** wrote:

In the meantime the situation has changed. So it might be better to create a new bug instead of updating this.
A first good step might be to resolve bug 48036 (opt-in for unregistered visitors). That way, people can vote with their feet.
**physik** wrote:

(In reply to comment #9)
> I think physikerwelt idea of semantic processing of mathematics is a nice
> idea
> and fit with the foundations wider goals. However it a bit off topic for this
> bug. I've created a new bug 51381 which the details where it can be explored
> in
> more details.

Thanks... sorry for the off topic... if I just said use
 $wgDefaultUserOptions['math'] = 7
that would be somehow pointless.
By the way 2 is html (deprecated) and mathjax is 6.

7 includes 6 since you it can be combined with MathJax (as you can see in the demo) but it must not. The advantage to use MathJax based on MathML is that it is reasonably fast. (To my mind that's not the case if you use MathJax without MathML). Furthermore you can display MathML without a need of JavaScript support.

A visual editor that is based on MathML would be easier to implement and handle than one that is based on TeX. But I would double think about doing so, since than the Tex source is gone. (OK the same holds for the visual editor in general.)

To stick to the topic, which is not visual editor:

I fully support the initiative to switch the rendering mode.
However, I think we should find a well defined process for doing so.
One opportunity could be:
1. Collect the alternatives
2. Compare and benchmark them
3. Discuss the results
4. Make a decision (Maybe even vote oOo)

This sounds a bit lengthy... but due to the fact that this bug is open for more than a year now... that might be really quick.
I think physikerwelt idea of semantic processing of mathematics is a nice idea and fit with the foundations wider goals. However it a bit off topic for this bug. I've created a new bug 51381 which the details where it can be explored in more details.
@Richard, the GSoC project for a math-editor component is coming along nicely. The approach is along the lines of the wyiswhat editor http://oerpub.github.io/Aloha-Editor/. The OERpub folks have done some testing (with regular school teachers) see http://kefletcher.blogspot.com/2013/05/testing-editor-designs.html. 

@Martin I think texvc's restricted TeX fits very well within the concept of Wikitext and texvc has (unfortunatly) proven to be "stable, secure and long term supported". Of course I'm biased, but I think MathJax solves the issues you describe (well except the ominous "along with all the JS issues" -- not sure what you're referring to). If all you're after is MathML and SVG output, then the MathJax-driven VE plugin could easily produce those as well. 

This is getting off topic, but I would add: we need more rather than less client-side rendering of scientific content. Server side rendering is inherently static, in fact, MathML (which is really just the math equivalent of text) feels a lot like HTML 1 at this point -- barely acceptable, static rendering in the browser. E.g., mathapedia and mathbox show what the future of math on the web might be.
**physik** wrote:

PS: There is a demo at 
http://demo.formulasearchengine.com

you can click on 
http://demo.formulasearchengine.com/index.php/Special:Random

to get a random page of the english wikipedia... the pages are not cached so it might take about 20 seconds, especially if images has to be loaded from commons
**physik** wrote:

I think it is really important to have a stable, secure, and long term supported way of math rendering.
As I'm working on integrating LaTeXML a rendering engine that converts tex to MathML I was running into a couple of issues.
First, Wikipedia uses texvc and not tex, therefore I had to create a list of special user defined commands. MathJax has this list as well.
To my mind it's a suboptiomal solution especially with regard to long term support. I propose to come up with a grammar that can be used by a wide audience (e.g. antlr) and convert that into native php code. This grammar converts texvc to tex and eliminates all commands that are not allowed.
Second, there are some security aspects, i.e. that someone could put code that is a potential security risk for the visitors. Texvc eliminates this security risk by       returning pictures only. On the other side as texvc is a potential security risk for the server, since the rendering must take place on the same machine as the core server works.
LaTeXML can use a separate server, but if there is an attack to the network the traffic could be redirected to another server. Therefore the output of LaTeXML must be checked again before returning it to the users browser.
If the users browser supports mathml only bugs in the browsers mathml implementation can be a security risk. If not MathJaX is needed to convert MathML to whatever, which comes along with all the Javascript issues.
As a result I think that it would be good to seperate the tasks somehow.
The Wikimedia Math extension php code should convert texvc to tex and ensure that only valid tex is passed to the rendering engine.
Than a standard rendering engine can be used and the final result can be validated according to standard methods. e.g. validate MathML out against the W3C MathML scheme.
In summer 2012 I proposed the LaTeXML render at CICM 2012, now it's avalible as opt-in[1].

[1] http://arxiv.org/abs/1304.5475
So we have a problem. We need to discuss maths on our talk page. Its a central part of building the encyclopedia. Now Flow is going to be introduced for our talk pages which will not allow standard wikicode as only the VisualEditor is allowed. Hence the VE must have math support, that is Bug 43058 must be fixed. 

Now a maths visual editor is a herculanean task but central to that is a render. MathJax could potentially do it, texvc cannot as you would have generate a new image on the fly with each key stroke. Any other system is just going to be an ugly kludge. 

In reply to Erik's comment. You have a tradeoff between the time it take javascript to render, with the time it takes to download all the images for the equations. It can take a considerable time to download a maths heavy page like Help:Formula. I would say they just about balance each other.
(In reply to comment #3)
> I don't think that this is likely to happen in the near future. MathJax is
> significantly slower to render even on high end computers and would likely
> cause unacceptable slowness on math-intense pages for users of low-end
> machines.

Just to mention one of the blocker bugs, it also has no localisation (bug 35038).

> I'm inclined to close this as WONTFIX for the time being. I'd suggest looking
> into ways to expose the MathJax user preference a bit more so that
> math-interested users can discover it more easily. For example, we could
> integrate the right-click menu that MathJax exposes with the PNG rendering
> mode.

Closing this per Erik (blocker bugs are easily overlooked, status is clearer to readers). Reopening is cheap when issues are solved.
I see i forgot to close this one. This is basically working now, though there apparently is a bug, reported in T90808.
For LivePreview, it depends on bug 24134 which isn't fixed yet, because I still need to finish https://gerrit.wikimedia.org/r/#/c/131346/. The patch that was merged was just one of the prerequisites. 

VE is a separate issue.
I just tested and it still doesn't seem to work (PNG images are shown).
Patch was merged a while ago - is there more work left to do here (if yes: please reset the bug report status to NEW or ASSIGNED), or can you close this ticket as RESOLVED FIXED?
Change 124064 merged by jenkins-bot:
MathJax: Listen for wikipage.content hook

https://gerrit.wikimedia.org/r/124064
Change 124064 had a related patch set uploaded by TheDJ:
MathJax: Listen for wikipage.content hook

https://gerrit.wikimedia.org/r/124064
A specific problem is that after a session in VisualEditor a full refresh is not done and MathJax is not rerun, so the raw latex code is displayed. Apparently according to bug 51565 gadgets should listen to "wikipage.content". I have heard rumours that the fix to bug 48560 will fix this problem.

This ha come up at https://en.wikipedia.org/w/index.php?title=Wikipedia:VisualEditor/Feedback&oldid=593049936
Both Ajaxpreview and wikEd now use the renderTex() command to render MathJax in their ajax based preview modes:

Example: https://en.wikipedia.org/w/index.php?title=User%3AJs%2Fpreview2.js&diff=558032369&oldid=520879456

Soon to be improved by making use of https://gerrit.wikimedia.org/r/56762
(For the record, there is now a fix in progress for bug 30713 which is a dependency here.)
MathJax module now has a $().renderTex command that can be run to render domelements that contain tex commands. A preview hook can use this to postprocess the preview output.
{nav icon=file, name=Mentioned in SAL (#wikimedia-operations), href=https://tools.wmflabs.org/sal/log/AVwNxIhIQMK9DA-FLPfy} [2017-05-15T20:20:02Z] <subbu> Updated Parsoid to a182c227 (T141226, T164792, T37247, T153107, T163091, T164006, T161151, T162920, T163549)
Change 352711 merged by jenkins-bot:
[mediawiki/services/parsoid@master] Add mw-parser-output class to Parsoid's output

[[https://gerrit.wikimedia.org/r/352711]]
Change 352835 had a related patch set uploaded (by Anomie; owner: Anomie):
[mediawiki/core@master] Add mw-parser-output to indicators container

[[https://gerrit.wikimedia.org/r/352835]]
At svwiki we have
  - https://sv.wikipedia.org/wiki/MediaWiki:Gadget-ProtectionIndicators.js 
  - https://sv.wikipedia.org/wiki/MediaWiki:Gadget-GroupIndicators.js 
  - https://sv.wikipedia.org/wiki/MediaWiki:Gadget-BlockIndicator.js
to convey information about protected pages, groups and blocked users in a reliable way, unlike templates that anyone can add or remove. This is not user-generated content, so if you're going to do this, I would prefer if you can just wrap the individual indicators that come from the wikitext, not the container for all indicators.
Change 352711 had a related patch set uploaded (by Subramanya Sastry; owner: Subramanya Sastry):
[mediawiki/services/parsoid@master] Add mw-parser-output class to Parsoid's output

[[https://gerrit.wikimedia.org/r/352711]]
Good question. I'd say yes, since indicators are user-generated content. It'd probably be a good idea to add the class to the indicators' wrapper element.
Here's a late annoying question – should contents of page status indicators (`<indicator name="…"></indicator>` in wikitext; https://www.mediawiki.org/wiki/Help:Page_status_indicators) be wrapped in this new wrapper?
>>! In T37247#3181097, @Anomie wrote:
> I don't know whether #VisualEditor and #Flow will get fixed up by that, though, or if they'll need some other work. I tried to set them up in mediawiki-vagrant, but neither actually functioned.

Now that the patch is merged and on Beta Labs, I was able to confirm that neither VE's editing area nor Flow's comments are getting wrapped in the new class. Filed T164790 and T164791 for those extensions.
Note this won't be included in 1.30.0-wmf.1, but should be in 1.30.0-wmf.2.
Change 350634 merged by jenkins-bot:
[mediawiki/core@master] Wrap parser output in <div class="mw-parser-output">

[[https://gerrit.wikimedia.org/r/350634]]
Change 350635 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Update tests for core change If4eb5bf7

[[https://gerrit.wikimedia.org/r/350635]]
>>! In T37247#3219054, @dr0ptp4kt wrote:
> you most likely want to double check that CSS selector expressions keep working in reading and, to the extent they're employed in the experiences you engineer, editing contexts. There may be no problem, but I would be remiss to not note it.

As far as selectors, you're probably good unless you're using the direct-decendent `>` selector. Potentially more interesting would be things like MobileFrontend that try to chop up the parser output (although for MobileFrontend specifically I already submitted [[https://gerrit.wikimedia.org/r/#/c/350635/|this patch]]).
Yeah, ok, thanks.
Flow or anything else that might want to put two "pages" of content in one HTML document. For example, a side-by-side comparison of the rendered text might make sense somewhere, maybe for translation or something.
Does it have to be a class (instead of an id) because of Flow?
Change 350636 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Update tests for core change If4eb5bf7

[[https://gerrit.wikimedia.org/r/350636]]
Adding @bearND, @Mholloway, @JoeWalsh, @Jdlrobson, @MarkTraceur for visibility - you most likely want to double check that CSS selector expressions keep working in reading and, to the extent they're employed in the experiences you engineer, editing contexts. There may be no problem, but I would be remiss to not note it.

CC @Fjalapeno
Change 350636 had a related patch set uploaded (by Anomie; owner: Anomie):
[mediawiki/extensions/Wikibase@master] Update tests for core change If4eb5bf7

[[https://gerrit.wikimedia.org/r/350636]]
Change 350635 had a related patch set uploaded (by Anomie; owner: Anomie):
[mediawiki/extensions/MobileFrontend@master] Update tests for core change If4eb5bf7

[[https://gerrit.wikimedia.org/r/350635]]
Change 350634 had a related patch set uploaded (by Anomie; owner: Anomie):
[mediawiki/core@master] Wrap parser output in <div class="mw-parser-output">

[[https://gerrit.wikimedia.org/r/350634]]
Maybe you could have a ParserOption for it, so that the parser tests can still pass without too much trouble? Have the wrapper be on by default, but turn it off for parser tests. Other than that, I think it should be fine to add it to Parser::parse(). Write the patch and we'll see what happens.
(In reply to comment #0)
> Also, it for example broke my script which tried to
>  document.getElementById("bodyContent").insertBefore(newElement,document.getElementById("editform"));

Please elaborate what you mean here.
For searchers: this bug often comes with "Saving the translation failed: The modification you tried to make was aborted by an extension hook" warnings.
https://www.mediawiki.org/wiki/Thread:Extension_talk:Translate/_%27Saving_the_translation_failed:_The_modification_you_tried_to_make_was_aborted_by_an_extension_hook%27_and_Documentation_problems/reply
https://www.mediawiki.org/w/index.php?title=Help%3AExtension%3ATranslate%2FConfiguration&diff=1236716&oldid=1229427
ContentTranslation implemented a (after the fact) solution: https://gerrit.wikimedia.org/r/#/c/146426/
If this works only with FancyCaptcha, this is already a good start.
(In reply to comment #9)
> So, it seems it's possible to deal with with the extension:ConfirmEdit
> through
> the API:
> https://bugzilla.wikimedia.org/show_bug.cgi?id=50356#c3

Note, that comment mentions only FancyCaptcha [which is the least used component of ConfirmEdit: few wikis other than WMF use it].
So, it seems it's possible to deal with with the extension:ConfirmEdit through the API:
https://bugzilla.wikimedia.org/show_bug.cgi?id=50356#c3

Would that be possible for extension:Translate to deal with it?
(In reply to comment #7)
> I'm also impacted by this issue and I agree, if the API does not provide the
> necessary tools then it seems to me complicated to deal with this. How does
> the
> VisualEditor? He is impacted?

It was: bug 50356 / https://gerrit.wikimedia.org/r/#/c/71160/ .
I'm also impacted by this issue and I agree, if the API does not provide the necessary tools then it seems to me complicated to deal with this. How does the VisualEditor? He is impacted?
Change 72265 merged by Demon:
Various edit conflict handling fixes

https://gerrit.wikimedia.org/r/72265
Change 72265 had a related patch set uploaded by Aaron Schulz:
Various edit conflict handling fixes

https://gerrit.wikimedia.org/r/72265
Neither edit is tagged as such, so no.
Does this require VisualEditor to reproduce?
Reopening: This happened again in https://de.wikipedia.org/w/index.php?title=Allgemeines_b%C3%BCrgerliches_Gesetzbuch&action=history

There are three relevant edits (all times in CEST):

(1) IP at 20:42:00
(2) IP at 20:42:31
(3) Botulph at 20:42:49

Edit (3) was started after (1), but before (2), and is just a revert of edit (1) via the "undo" function. The edit conflict with edit (2) was automatically resolved, but (3) was automatically checked, though of course it shouldn't.
- it is documented at [[ https://www.mediawiki.org/wiki/Repositories_with_Ruby_code | Repositories with Ruby code ]] page?
- is ruby syntax check running after every commit?
- is rubocop  running after every commit?
- is browser test jenkins job created? (optional)

Repositories:

gerrit

|name|ruby|rubocop|
|mediawiki/core|1.9.3|0.32.1|
|mediawiki/extensions/ArticleFeedbackv5|1.9.3|0.26.1|
|mediawiki/extensions/CentralAuth|1.9.3|0.29.1|
|mediawiki/extensions/CentralNotice|1.9.3|0.29.1|
|mediawiki/extensions/CirrusSearch|1.9.3|0.26.1|
|mediawiki/extensions/ContentTranslation|1.9.3|0.29.1|
|mediawiki/extensions/Echo|1.9.3|0.29.0|
|mediawiki/extensions/Flow|1.9.3|0.32.1|
|mediawiki/extensions/Gather|1.9.3|0.34.1|
|mediawiki/extensions/GettingStarted|1.9.3|0.29.1|
|mediawiki/extensions/Math|1.9.3|0.27.0|
|mediawiki/extensions/MobileFrontend|1.9.3|0.29.1|
|mediawiki/extensions/MultimediaViewer|1.9.3|0.29.1|
|mediawiki/extensions/PageTriage|1.9.3|0.26.1|
|mediawiki/extensions/PdfHandler|1.9.3|0.26.1|
|mediawiki/extensions/PoolCounter|1.9.3|0.27.1|
|mediawiki/extensions/QuickSurveys|1.9.3|0.29.1|
|mediawiki/extensions/Translate|1.9.3|0.26.1|
|mediawiki/extensions/TwnMainPage|1.9.3|0.26.1|
|mediawiki/extensions/UniversalLanguageSelector|1.9.3|0.29.1|
|mediawiki/extensions/UploadWizard|1.9.3|0.29.1|
|mediawiki/extensions/VisualEditor|1.9.3|0.32.1|
|mediawiki/extensions/WikiLove|1.9.3|0.26.1|
|mediawiki/extensions/ZeroBanner|1.9.3|0.26.1|
|mediawiki/extensions/ZeroPortal|1.9.3|0.26.1|
|mediawiki/ruby/api|1.9.3|0.29.1|
|mediawiki/selenium|1.9.3|0.29.1|
|mediawiki/vagrant|1.9.3|0.33.0|
|oojs/ui|2.0|0.27.1|
|operations/puppet|1.9.3|0.33.0|
|VisualEditor/VisualEditor|1.9.3|0.29.1|

github

|name|ruby|rubocop|
|amire80/commons_upload|2.2.0|0.33|
|amire80/screenshot.git|2.2.0|?|
|wmde/WikidataApiGem|1.9.3|-|
|wmde/WikidataBrowserTests|1.9.3|0.32.1|
Change 237373 merged by jenkins-bot:
Run Ruby syntax check for mediawiki/vagrant in experimental pipeline

[[https://gerrit.wikimedia.org/r/237373]]
Change 237375 merged by jenkins-bot:
Run Ruby syntax check for operations/puppet in experimental pipeline

[[https://gerrit.wikimedia.org/r/237375]]
Change 237638 merged by jenkins-bot:
Ruby Ruby syntax check and RuboCop for PoolCounter

[[https://gerrit.wikimedia.org/r/237638]]
Change 237638 had a related patch set uploaded (by Zfilipin):
Ruby Ruby syntax check and RuboCop for PoolCounter

[[https://gerrit.wikimedia.org/r/237638]]
Change 237375 had a related patch set uploaded (by Zfilipin):
Run Ruby syntax check for operations/puppet in experimental pipeline

[[https://gerrit.wikimedia.org/r/237375]]
Change 237373 had a related patch set uploaded (by Zfilipin):
Run Ruby syntax check for mediawiki/vagrant in experimental pipeline

[[https://gerrit.wikimedia.org/r/237373]]
Change 200863 abandoned by Zfilipin:
WIP Run Ruby syntax check and/or RuboCop for repositories with Ruby code

[[https://gerrit.wikimedia.org/r/200863]]
Change 200863 had a related patch set uploaded (by Zfilipin):
WIP Ruby Ruby syntax check and/or RuboCop for repositories with Ruby code

[[https://gerrit.wikimedia.org/r/200863]]
Feel free to add a step by step tutorial for ruby repositories, we have a few already: https://www.mediawiki.org/wiki/Continuous_integration/Tutorials .
At the moment, we have a couple of jenkins jobs:

  - [[ https://integration.wikimedia.org/ci/view/BrowserTests/view/-All/job/browsertests-VisualEditor-language-screenshot-linux-firefox/ | browsertests-VisualEditor-language-screenshot-linux-firefox ]]
  - [[ https://integration.wikimedia.org/ci/view/BrowserTests/view/-All/job/browsertests-VisualEditor-language-screenshot-linux-firefox-sauce/ | browsertests-VisualEditor-language-screenshot-linux-firefox-sauce ]]

The first job runs local firefox and fails randomly.

Options:

- check if any of the headless environment variables helps
- check if any of the reuse browser environment variables helps
- check if switching to local chromium helps

The second job run a remote browser on sauce labs, but it does not support Chinese and Japanese fonts (at least), but only on linux host.

- check if running the job on windows (or mac) helps.
It was moved to run on Mac, and now runs successfully.
Some more context:

Already reported as [bug 71602 - mediawiki_selenium always use the same default xvfb display 99](https://bugzilla.wikimedia.org/show_bug.cgi?id=71602), which explains how our jobs ends up killing each other XVFB (typical race condition).

Dan fixed it with https://gerrit.wikimedia.org/r/#/c/164704/ ( b6af34a40e ) which is included in mediawiki_selenium 0.4.1.

The jobs need to be bumped to that library version and use the appropriate env variables as described above.
The job has `BROWSER=firefox` and `HEADLESS=false`, I am not sure what happens exactly in some case.  We probably want to set `HEADLESS=true` and set HEADLESS* env variables to avoid killing the XVFB.

The relevant code for 0.4.1 is:

http://git.wikimedia.org/blob/mediawiki%2Fselenium/0.4.1/lib%2Fmediawiki_selenium%2Fsupport%2Fhooks.rb#L27

See also the `README.md` doc under "Headless mode" section: http://git.wikimedia.org/blob/mediawiki%2Fselenium/0.4.1/README.md

I think we want:

```
lang=sh
HEADLESS=true
HEADLESS_DESTROY_AT_EXIT=false
```

That will default to use display 99, we have an XVFB listening on 99 already.

If we want the headless gem to spawn a new xvfb on a different display port, we can use `HEADLESS_REUSE=false` which will make it spawn a new xvfb on a different display port.  But that is probably not needed.
>>! In T1321#23186, @hashar wrote:
> Can you confirm you have mediawiki_selenium 0.4.1 +

Yes.

```
00:03:37.335 Installing mediawiki_selenium 0.4.1
00:03:37.335 0:  mediawiki_selenium (0.4.1) from /mnt/jenkins-workspace/workspace/browsertests-VisualEditor-language-screenshot-windows_8.1-firefox/LANGUAGE_SCREENSHOT_CODE/ar/label/gems/2.0.0/specifications/mediawiki_selenium-0.4.1.gemspec
```

From:

https://integration.wikimedia.org/ci/view/BrowserTests/view/VisualEditor/job/browsertests-VisualEditor-language-screenshot-windows_8.1-firefox/LANGUAGE_SCREENSHOT_CODE=ar,label=contintLabsSlave%20&&%20UbuntuTrusty/1/console
Related commit: https://gerrit.wikimedia.org/r/#/c/174660/
Can you confirm you have mediawiki_selenium 0.4.1 +

And:

    export HEADLESS_DESTROY_AT_EXIT=false

See https://bugzilla.wikimedia.org/show_bug.cgi?id=71602#c6
It's not immediately clear which projects should be in the actual message. As things are looking now, just team and project is OK, but maybe tags should also be added.

See https://github.com/legoktm/wikibugs2/commit/f2d91f6e6a1d8ccba54041d3376ed7719585c8d3 -- all tags should be reported to the IRC bot, not just projects.


See also:
 -  T1209 - Add 'team' (purple) to output
 - T1122 - Don't include closed projects in wikibugs2 output
{icon umbrella}
Change 184864 merged by jenkins-bot:
Disentangle tag lists for filtering vs display

[[https://gerrit.wikimedia.org/r/184864]]
Change 184864 had a related patch set uploaded (by Yuvipanda):
Disentangle tag lists for filtering vs display

[[https://gerrit.wikimedia.org/r/184864]]

#patch-for-review
VE now works, thanks.
Change 179088 merged by jenkins-bot:
T1316: Also report {icon umbrella} projects

[[https://gerrit.wikimedia.org/r/179088]]
Change 179088 had a related patch set uploaded (by Merlijn van Deen):
T1316: Also report {icon umbrella} projects

[[https://gerrit.wikimedia.org/r/179088]]

#patch-for-review
Argh. Should we remove the umbrella for now?
I have been told that this is what causes tasks in #VisualEditor not to be reported on #mediawiki-visualeditor since the project has gained the umbrella icon. What do we do to fix that?
> ...but should not be reported in-channel in the channel list.

As said in my comment above, if you filter out tasks belonging to Team projects, it is likely that you will miss many tasks.
As discussed on IRC, I see no reason why "team" type of projects cannot be used to handle tasks themselves, and I see no reason to treat them differently than "suitcase" projects. If we don't use team projects for managing the team backlog, then the only reason to create a team project would be to handle some special permissions.
We don't have any real need for 1.23wmf* and 1.24wmf* deployment branches anymore. They should probably be changed to tags.

Chad, do you have a script for doing this? Timo seemed to think you had from before...

-----
**EDIT**: Krinkle used the following script for individual repositories at [https://github.com/Krinkle/dotfiles/tree/master/hosts/KrinkleMac/bin](https://github.com/Krinkle/dotfiles/tree/db0e65f/hosts/KrinkleMac/bin):
{P3455}
{P531}
This is done.
So I think the last thing to do here is to automate this a bit. I'm going to add it to `scap clean`
Done for all extensions, skins and vendor. No more extraneous tags. No more branches other than the currently active series, `1.28.0-wmf.N`
I agree, all those old tags and branches aren't very useful after a while.
One liner for all extensions and skins meta repos:
```
lang=bash
# Delete all remote branches matching wmf/ that aren't 1.28-based
git submodule foreach "git branch -r | grep -Eo 'wmf/.*' | grep -v '1.28' | xargs -I {} git push origin :{}"
# Delete all (remote) tags named wmf/* 
git submodule foreach "git tag | grep -Eo 'wmf/.*' | xargs -I {} git push origin :{} ||:"
# Delete the tags locally too, so we don't re-push them.
git submodule foreach "git tag | grep -Eo 'wmf/.*' | xargs -I {} git tag -d {}"
```

Just gotta swap `1.28` for whatever branch you're wanting to retain (the current one, obviously).

Just ran this for all skins and the vendor directory. Finishing up extensions now.

Let's please not reintroduce these tags. And get better (via the child task) at cleaning up the branches automatically.
One liner for all extensions and skins meta repos:
```
lang=bash
  # Delete all remote branches matching wmf/ that aren't 1.28-based
  git submodule foreach "git branch -r | grep -Eo 'wmf/.*' | grep -v '1.28' | xargs -I {} git push origin :{}"
  # Delete all (remote) tags named wmf/* 
  git submodule foreach "git tag | grep -Eo 'wmf/.*' | xargs -I {} git push origin :{} ||:"
  # Delete the tags locally too, so we don't re-push them.
  git submodule foreach "git tag | grep -Eo 'wmf/.*' | xargs -I {} git tag -d {}"
Just gotta swap `1.28` for whatever branch you're wanting to retain (the current one, obviously).
```

Just ran this for all skins and the vendor directory. Finishing up extensions now.

Let's please not reintroduce these tags. And get better (via the child task) at cleaning up the branches automatically.
One liner for all extensions and skins meta repos:
  git submodule foreach "git branch -r | grep -Eo 'wmf/.*' | grep -v '1.28' | xargs -I {} git push origin :{}"
  git submodule foreach "git tag | grep -Eo 'wmf/.*' | xargs -I {} git push origin :{} ||:"
  git submodule foreach "git tag | grep -Eo 'wmf/.*' | xargs -I {} git tag -d {}"
Just gotta swap `1.28` for whatever branch you're wanting to retain (the current one, obviously).

Just ran this for all skins and the vendor directory. Finishing up extensions now.

Let's please not reintroduce these tags. And get better (via the child task) at cleaning up the branches automatically.
One liner for all extensions and skins meta repos:
  git submodule foreach "git branch -r | grep -Eo 'wmf/.*' | grep -v '1.28' | xargs -I {} git push origin :{}"
  git submodule foreach "git tag | grep -Eo 'wmf/.*' | xargs -I {} git push origin :{}"
Just gotta swap `1.28` for whatever branch you're wanting to retain (the current one, obviously).

Just ran this for all skins and the vendor directory. Finishing up extensions now.

Let's please not reintroduce these tags. And get better (via the child task) at cleaning up the branches automatically.
Also we should prune old branches for extensions/skins/vendor too, I only do it for core right now.
Actually, I'd like to repurpose this as "Just kill old branches." The tags are useless and clutter shit up which is why I nuked all of them a few weeks ago.
Ran `convert-wmf-branches 1.26` on repos `mediawiki/core` and `mediawiki/extensions/{VisualEditor,NavigationTiming}`.
(Re-opening, since there are still plenty of extensions with them, and it will happen again every release cycle)
Maybe the make-wmf-branch could be taught how to convert obsolete branches to tags? This way the conversion will be part of the process and we could close this task.
I've ran the script for 1.25 on mediawiki/core and the following mediawiki extension repositories I have checked out:
```
CategoryTree
CentralNotice
CirrusSearch
Cite
Citoid
CodeReview
Collection
ContentTranslation
CvnDB
Echo
EventLogging
Flow
Gadgets
GlobalCssJs
GlobalUserPage
GuidedTour
ImageMetrics
Interwiki
Math
MobileFrontend
MultimediaViewer
ParserFunctions
Scribunto
Sentry
SyntaxHighlight_GeSHi
TemplateData
Thanks
Translate
UniversalLanguageSelector
VisualEditor
WikiEditor
WikimediaEvents
ZeroBanner
```
if there's no harm in keeping the tags around it sounds like a good idea to have them
Updated the script and published to P531. It now works for both MediaWiki core and extensions. And it also removes the branches afterward (instead of requiring manual action via Gerrit dashboard). Note that this requires Gerrit administrator permissions to run.

{P531}
Tried the following on `mediawiki/extensions/TemplateData` as test. Seems to work fine.

```
#!/usr/bin/env bash
remote='origin'
versions=('1.23' '1.24')
git remote update $remote
git remote prune $remote
for version in "${versions[@]}"; do
	refs=`git for-each-ref --format='%(refname)' refs/remotes/${remote}/wmf/${version}wmf*`
	for ref in $refs; do
		branch=$(echo $ref | cut -d '/' -f 4-6)
		git push origin ":$branch"
	done
done
git remote update $remote
git remote prune $remote
```
Tried the following on `mediawiki/extensions/TemplateData` as test. Seems to work fine.

```
#!/usr/bin/env bash
remote='origin'
version='1.23'
git remote update $remote
git remote prune $remote
refs=`git for-each-ref --format='%(refname)' refs/remotes/${remote}/wmf/${version}wmf*`
for ref in $refs; do
	branch=$(echo $ref | cut -d '/' -f 4-6)
	git push origin ":$branch"
	if [[ $? == 0 ]]; then
		echo "... deleted $branch"
	else
		echo "Could not delete $branch"
	fi
done
git remote update $remote
git remote prune $remote
```
I have no real strong opinions about keeping them around.
@hashar At this point this is only happening to wmf branches. After a MediaWiki core wmf-branch is abandoned, we definitely wouldn't be backporting patches for an individual extension's wmf-branch as the relevant wmf-branch wouldn't be deployed anymore (and couldn't as you'd have to update the submodule pointer in the MediaWiki core branch that no longer exists).

For release branches this is different. Extension authors may maintain their extensions' release branch beyond MediaWiki core's end-of-life data for a release. But so far we haven't purged any release branches.

@Reedy @Chad As for wmf-branches in extensions, I'd like to remove them instead of converting to tags. Do we need them for anything? The submodule pointers from the wmf-branches in mediawiki-core refer to commits, not branches. Having said that, should we keep them even in MediaWiki core? It's not like we'd revert back an entire major release in production.
That might break zuul-cloner which expects to checkout branches which is used for {T1350} among others. (link: https://www.mediawiki.org/wiki/RFC/Extensions_continuous_integration ).

I have filled {T76088} to investigate whether zuul-cloner will be able to consider tags instead of branches.
I don't see any reason we couldn't. It would be running the same script essentially for all of our submodules
Can this also be done for extensions as well?
I created tags for `wmf/1.23wmf*` and `wmf/1.24wmf*` and deleted the branches.

Script:

```
#!/usr/bin/env bash
remote='origin'
version='1.24'
git remote update $remote
git remote prune $remote
refs=`git for-each-ref --format='%(refname)' refs/remotes/${remote}/wmf/${version}wmf*`
for ref in $refs; do
	branch=$(echo $ref | cut -d '/' -f 4-6)
	git tag $branch $ref > /dev/null 2>&1
	if [[ $? == 0 ]]; then
		echo "... tagged $branch"
	else
		echo "Could not (re)create $branch"
	fi
done
echo
echo "Ask a Gerrit admin to delete wmf/$version branches via https://gerrit.wikimedia.org/r/#/admin/projects/mediawiki/core,branches"
echo
echo "... publishing tags"
git push $remote --tags
git remote update $remote
git remote prune $remote
```
Nope, no script for that.
Something like PACE minimal or barbershop http://github.hubspot.com/pace/docs/welcome/
Related to {T99274}
Thanks.
I didn't tag it easy, but I've removed it.
Is this really "easy"?
The goal is to have good descriptions in the most relevant videos at https://www.youtube.com/user/watchmediawiki
Links to all past tech talk videos: https://www.mediawiki.org/wiki/Tech_talks#Past_tech_talks

Step 1: Add one-line bio of the speaker(s) of the video
Step2: Go through the video and extract relevant links
Step3: Add the new description to commons

Template for the description:
-Speaker Name (Their one-line bio)
-Summary
-Relevant links


| Youtube video | Description in Youtube | Description in Commons | Embedded in Wikimedia pages
| [[ https://www.youtube.com/watch?v=Qo4XIzCJZVs | Tech Talk: New readership data]] | Done | [[ https://commons.wikimedia.org/wiki/File:Tech_Talk_-_New_readership_data_-_Some_things_we%27ve_been_learning_recently_about_how_Wikipedia_is_read.webm#.7B.7Bint:filedesc.7D.7D | Done]] | 
|[[https://www.youtube.com/watch?v=_yr5z9Ix2f8 | Phabricator for Wikimedia projects]] | Done | [[https://commons.wikimedia.org/wiki/File:Phabricator_for_Wikimedia_projects.webm | Done]] | |
| [[https://www.youtube.com/watch?v=ltEL-kPURKs |Automated citations in Wikipedia]] |Done | [[https://commons.wikimedia.org/wiki/File:Tech_Talk_-_Automated_citations_in_Wikipedia_-_Citoid_and_the_technology_behind_it.webm#.7B.7Bint:filedesc.7D.7D | Done]] | 
| [[https://www.youtube.com/watch?v=sWiDimlK4bE |  Introduction to Free and Open Source Licensing at Wikimedia]] | Done | [[https://commons.wikimedia.org/wiki/File:Tech_Talk_-_Introduction_to_Free_and_Open_Source_Licensing_at_Wikimedia.webm | Done]] | |
Similarly to {T142728}, I think this task has run its course. Thank very much for your help @husn_shujaat!

@Rfarrand @srishakatux from now any any new Tech Talk should have beforehand a proper plan for

* being published in YouTube with a proper title, description, and whatever information will make them easier to be found
* being published in Commons short after the event with the same
* being embedded in the right wiki pages so they can be found by the people checking that documentation.

I hope you will agree with this sensible plan not to increase our "communication debt" with Tech Talks.
Imported as https://codein.withgoogle.com/tasks/5210795455545344/
@srishakatux this is perfect! Thank you :)
@Aklapper @husn_shujaat I created a playlist for 'Tech talks' on our Youtube channel. All tech talks now lie here https://www.youtube.com/playlist?list=PLeoTcBlDanyMPuVYBZYbEORNezmemiAhv. I've created a GCI task about adding documentation for tech talk videos: https://codein.withgoogle.com/dashboard/tasks/5210795455545344/preview/. I haven't published it yet, but I have tried to frame the description as such that we could have several instances of it, where each student could choose to work on two videos at one time. If this sounds good, I will create a similar task with some additions for the one on CREDIT showcase and update the instance count to 5ish.
@Aklapper @husn_shujaat I created a playlist for 'Tech talks' on our Youtube channel. All tech talks now lie here on Youtube https://www.youtube.com/playlist?list=PLeoTcBlDanyMPuVYBZYbEORNezmemiAhv. I've created a GCI task about adding documentation for tech talk videos: https://codein.withgoogle.com/dashboard/tasks/5210795455545344/preview/. I haven't published it yet, but I have tried to frame the description as such that we could have several instances of it, where each student could choose to work on two videos at one time. If this sounds good, I will create a similar task with some additions for the one on CREDIT showcase and update the instance count to 5ish.
Ah, right. I'll put the page with links in the description.
Yeah, they can add the description in the commons, I'll put it to youtube :)
Ah, right. I'll put the page with links in the description.
Alright, so this would refer to Commons only...  :)
So as a student, how exactly would I find a video that still needs some documentation links added?
If I was a student, what will I have to do after extracting relevant links? Where I am expected to add a one-line bio of the speaker?
The thing is: We need to clearly communicate expectations to students, to avoid misunderstandings or wrong expectations on both sides :)
@Aklapper Take my place for the time being. Go through the video and extract the relevant links. Add a one-line bio of the speaker. :)
The summary is usually already there.
This all goes into the description of the video in commons
@Aklapper Take my place for the time being. Go through the video and extract the relevant links. Add a one-line bio of the speaker. :)
@husn_shujaat: If this was a GCI task, what exactly would be expected from a GCI student here? :)
I wonder if I could put this as a Google Code-In task.
Like, 1 task would include 1 video and so this could be a recurring task.
I wonder if I could put this as a Google Code-In task.
@husn_shujaat do you want to keep working on this task during this quarter?
@Aklapper that worked! thanks :)
>>! In T1119#2554781, @husn_shujaat wrote:
> When I add link of a speaker's profile, there is usually a ')' at its end, and youtube's code refuses to include that in the URL, so we end up with an invalid page. What to do?

@husn_shujaat: Instead of entering `https://wikimediafoundation.org/wiki/User:Slaporte_(WMF)` could you try encoding the brackets by using `https://wikimediafoundation.org/wiki/User:Slaporte_%28WMF%29` maybe? Just an idea how to work around...
You are right! I have tried to edit the description using Markdown syntax or HTML but it won't work either.

Well... then I think it is better not to specify those wrong links and point to their team pages instead. Team pages are going to be more informative than most user pages anyway.
There is tiiiiny bit problem at youtube. When I add link of a speaker's profile, there is usually a ')' at its end, and youtube's code refuses to include that in the URL, so we end up with an invalid page :/ 
See https://www.youtube.com/watch?v=sWiDimlK4bE
What to do?
Good idea. You can [[ https://www.mediawiki.org/wiki/Phabricator/Help#Creating_a_task | create the task ]] yourself. Let me know if you have any questions.
Good idea. I'll get the two at commons done. 
But I think we should create a seperate task for CREDITs . 
Let this one be for tech talks only.
A related comment:

>>! In T85593#2514784, @Qgil wrote:
> Here is another approach to this task: let's focus on assuring that current and future presentations are properly published in their related mediawiki.org pages. At least we will avoid making this problem bigger.

We could apply the same idea to new videos produced. For instance, there was a [[ https://www.mediawiki.org/wiki/CREDIT_showcase | CREDIT showcase ]] last week:

Stream: https://www.youtube.com/watch?v=BOj6nDbdPMA
Stas: small WDQS GUI updates - https://www.mediawiki.org/wiki/Wikidata_query_service
A related comment:

>>! In T85593#2514784, @Qgil wrote:
> Here is another approach to this task: let's focus on assuring that current and future presentations are properly published in their related mediawiki.org pages. At least we will avoid making this problem bigger.

We could apply the same idea to new videos produced. For instance, there was a CREDIT showcase last week:

Stream: https://www.youtube.com/watch?v=BOj6nDbdPMA
Stas: small WDQS GUI updates - https://www.mediawiki.org/wiki/Wikidata_query_service
@Aklapper Sorry for missing your pings here, yes! I can give permissions to the YouTube channel. So can Byron, Quim, Chris, James A, & Tilman. 
Happy to add anyone you want me to.
@Rfarrand: Do you know? ^^^
In T1119#2194307, @Qgil wrote:
> while we figure out (this week, I expect) your permissions on MediaWiki's YouTube account.

I'm wondering who knows about these permissions and how to go ahead when it comes to allowing more people to update description of existing Youtube videos.
@Rfarrand maybe?
@Rfarrand: Do you know? ^^^
>>! In T1119#2194307, @Qgil wrote:
> while we figure out (this week, I expect) your permissions on MediaWiki's YouTube account.

I'm wondering who knows about these permissions and how to go ahead when it comes to allowing more people to update description of existing Youtube videos. 
@Rfarrand maybe?
So, finally my exams are over. 
I just got done with https://commons.wikimedia.org/wiki/File:Phabricator_for_Wikimedia_projects.webm
@Qgil Thank you so much! :)
Of course @husn_shujaat ! First thing first. I wish you best luck with the exams.
I have my exams starting next week, I'm just too busy.
I was wondering if I can resume working on this task from June 10 (that's when my exams end)
Is that OK?
Yes, I'm totally ok with it. 
I'll now start with https://www.youtube.com/watch?v=_yr5z9Ix2f8
You can edit the list by clicking the "Edit Task" link above.

A couple of wiki pages mentioned in the video itself is a good guidance. Let's go for more?

I think it is good to do more videos available in Commons while we figure out (this week, I expect) your permissions on MediaWiki's YouTube account. Are you OK with this?
That list is very helpful, thanks!

I need help in deciding which tech talk video should be on which wiki page?
For the start, let's just consider 'The readership data' one.
So far, @Qgil embedded it in [[https://meta.wikimedia.org/wiki/Research:Characterizing_Wikipedia_Reader_Behaviour| here]] and I embedded it [[https://www.mediawiki.org/wiki/Reading/Mexico_Readers_Research|here]]. Is there any where else where the video should go?
Thanks so much for this work! Its great. Just a few links for you in case this helps. 
1) I try to keep this updated with all tech talks, however I have missed a few recently. I will go back and update soon: https://www.mediawiki.org/wiki/Tech_talks
2) Here is a collection of all of the tech talks we have done in case any are missing:
https://www.youtube.com/user/watchmediawiki

Let me know if I can help you!
Thank you! :)
I'll see to adding the speaker's description.

I will embed the videos, but I can't get how to put the links to [[ https://commons.wikimedia.org/wiki/Special:WhatLinksHere/File:Tech_Talk_-_New_readership_data_-_Some_things_we%27ve_been_learning_recently_about_how_Wikipedia_is_read.webm | this page]]?
Do you think I should just embed the videos in the links mentioned in the description (except for [[ https://phabricator.wikimedia.org/T113066
 | T113066 ]] of course)? Will those be enough?

The idea of the table is a great way of keeping track of our progress.
This is very good! I made [[ https://commons.wikimedia.org/w/index.php?title=File%3ATech_Talk_-_New_readership_data_-_Some_things_we%27ve_been_learning_recently_about_how_Wikipedia_is_read.webm&type=revision&diff=192443093&oldid=192413368 | some edits ]] to link to the speaker user profile in mediawiki.org, to add some relevant links to the description, and to simplify the format of the list of links (we try to avoid HTML in wikitext when possible).

It would be useful to add a one line description of the speaker, which you can usually borrow from their user profiles.

Finally, clicking at [[ https://commons.wikimedia.org/wiki/Special:WhatLinksHere/File:Tech_Talk_-_New_readership_data_-_Some_things_we%27ve_been_learning_recently_about_how_Wikipedia_is_read.webm | What links here ]] one can see that there is no relevant page linking to this video in the entire collection of Wikimedia wikis. This is not useful! You can improve this situation by finding the relevant pages, and embedding the video there.

Let me do this once to provide an example: https://meta.wikimedia.org/w/index.php?title=Research%3ACharacterizing_Wikipedia_Reader_Behaviour&type=revision&diff=15506568&oldid=15428580 (I did it with the regular "Edit" / VisualEditor link and the Tech Talk video was already the second result suggested as media, maybe your good description is starting to work semantically?).  :)

I was thinking that we could maintain a table in the description of this task to track progress, along these lines:

| YouTube video | Description in YouTube | Description in Commons | Embedded in Wikimedia pages |
|  [[ https://www.youtube.com/watch?v=Qo4XIzCJZVs | Tech Talk: New readership data ]] |  | [[ https://commons.wikimedia.org/wiki/File:Tech_Talk_-_New_readership_data_-_Some_things_we%27ve_been_learning_recently_about_how_Wikipedia_is_read.webm#.7B.7Bint:filedesc.7D.7D | DONE ]] |
Is this okay?
https://commons.wikimedia.org/wiki/File:Tech_Talk_-_New_readership_data_-_Some_things_we%27ve_been_learning_recently_about_how_Wikipedia_is_read.webm#.7B.7Bint:filedesc.7D.7D
OK!
I'll start with the description at commons.
The youtube video is linked at commons but not the other way round.
I think it's a good idea to have the youtube link at the source in commons as it is in this video.

P.S: It was me who liked it :D
Great! Let's move onto the videos. It makes sense to start with the Tech Talks. We can work on a specific one, and then when we are happy about it, we can apply the same formula to the rest.

I propose to start with this one:

* https://commons.wikimedia.org/wiki/File:Tech_Talk_-_New_readership_data_-_Some_things_we%27ve_been_learning_recently_about_how_Wikipedia_is_read.webm
* https://www.youtube.com/watch?v=Qo4XIzCJZVs

After almost three weeks, it has 77 views and 1 like in YouTube, 28 views in Commons. Let's see whether we can drive more YouTube attention there. :)

Since it is available in Commons, we can edit the description there at will, and when we are happy about it we can copy it to YouTube. OK?
Great! Let's move onto the videos. It makes sense to start with the Tech Talks. We can work on a specific one, and then when we are happy about it, we can apply the same formula to the rest.

I propose to start with this one:

* https://commons.wikimedia.org/wiki/File:Tech_Talk_-_New_readership_data_-_Some_things_we%27ve_been_learning_recently_about_how_Wikipedia_is_read.webm
* https://www.youtube.com/watch?v=Qo4XIzCJZVs

After almost three weeks, it has 77 views and 1 like. Let's see whether we can drive more YouTube attention there. :)

Since it is available in Commons, we can edit the description there at will, and when we are happy about it we can copy it to YouTube. OK?
Great! Let's move onto the videos. It makes sense to start with the Tech Talks. We can work on a specific one, and then when we are happy about it, we can apply the same formula to the rest.

I propose to start with this one:

* https://commons.wikimedia.org/wiki/File:Tech_Talk_-_New_readership_data_-_Some_things_we%27ve_been_learning_recently_about_how_Wikipedia_is_read.webm
* https://www.youtube.com/watch?v=Qo4XIzCJZVs

Since it is available in Commons, we can edit the description there at will, and when we are happy about it we can copy it to YouTube. OK?
Pleasure is all mine!
>  in an ideal world these videos should be in https://commons.wikimedia.org, and that information would be very interesting to have in the their description pages. You have the choice of detailing this information both in YouTube (since it might attract more viewers) and Commons (the canonical location of these videos), or you can have it only in Commons, and link to there from the YouTube page. Up to you, whatever you think is more feasible.

Yes, I can do that, it'll only take copy/paste to put description in both places.

It's a yes from me on this template (speaker, summary, links). 
Do you think we can move on to the videos?
Thank you @husn_shujaat !

> * Speaker/Credits

Yes, the main speakers are enough. All the better if we could link to their user page in mediawiki.org.

> Summary

Yes, paying attention to keywords that might bring more on-topic viewers to these videos.

> IRC (channel)

Hm. I would not get too obsessed about this. Usually the simultaneous chat is interesting only during the tech talk, but not after that.

> Relevant links (All the webpages mentioned in the video, for example, link of T113066 should be in the description of Tech Talk: New readership data...) We could also mention the time of when these links/webpages were shown.

If you are ready to do this work, then this will be excellent indeed. One thought though: in an ideal world these videos should be in https://commons.wikimedia.org, and that information would be very interesting to have in the their description pages. You have the choice of detailing this information both in YouTube (since it might attract more viewers) and Commons (the canonical location of these videos), or you can have it only in Commons, and link to there from the YouTube page. Up to you, whatever you think is more feasible.

As soon as we agree on the description, the next step will be to agree on which videos should get priority. Not all of them are equally relevant, and you should be able to focus your time on the videos that matter most.
Thanks for assigning this to me, I was looking for such tasks. 
The plan looks good to me.

I saw some techtalks videos and their descriptions give some good ideas for templates.
 
  -   Speaker/Credits
  -   Summary
  - IRC (channel)
  - Relevant links (All the webpages mentioned in the video, for example, link of [[ https://phabricator.wikimedia.org/T113066 | T113066]] should be in the description of [[ https://www.youtube.com/watch?v=Qo4XIzCJZVs | Tech Talk: New readership data...]]) We could also mention the time of when these links/webpages were shown.
@husn_shujaat based on T85593#2170408 I think this is a good task for you. I'm taking the liberty to steal it from @Rfarrand and assign it to you. I'm scheduling it for our currently quarterly milestone. 

The goal is to have good descriptions in the most relevant videos at https://www.youtube.com/user/watchmediawiki

As a first objective, I propose that you define a template for these descriptions. What information should it have, and any special format? It doesn't need to be anything complex. In fact, the simpler the better, as long as the basic information is provided. 

Once we agree on the template, let's discuss on which videos would need to get it first (we have many videos, and not all of them are equally interesting nowadays).

Please confirm this plan works for you, and feel free to suggest improvements.  :) Thank you!
>>! In T1119#1761755, @Aklapper wrote:
> @Rfarrand: [[ https://www.mediawiki.org/wiki/Google_Code-in_2015#Mentors.27_corner | Want to give this a shot ?]]

@Rfarrand: Ping. (Though I'm not sure how S' last comment is related, or if that would be separate here.)
>>! In T1119#1648391, @Qgil wrote:
> I wonder whether Google Code-in could be of any help here.

I think it could if @rfarrand defines a good "generic" (cloneable) [[ https://www.mediawiki.org/wiki/Google_Code-in_2015#Requirements_of_a_task | beginner task ]], like 
"Wikimedia occassionally hosts [[ https://www.mediawiki.org/wiki/Tech_talks | Tech talks]] (FIXME: That page does not even explain what a Tech Talk is). Go to this link which is a list of Wikimedia TechTalk videos on Youtube. Pick one video, thoroughly understand which topic the Tech Talk video is about, identify a number of key terms you would associate with the Tech Talk topic, [[ https://www.mediawiki.org/wiki/Help:Searching | search ]] for documentation wiki pages on Wikimedia sites (meta.wikimedia.org, mediawiki.org, potentially commons.wikimedia.org and en.wikipedia.org, wikimediafoundation.org, FIXME: any others?) which are strongly related to the Tech Talk's topic, and provide a list of links to these wiki pages plus information which video you chose". 
(The action of updating the Youtube description requires special permissions so that's out of scope for GCI I'd say.)

@Rfarrand: [[ https://www.mediawiki.org/wiki/Google_Code-in_2015#Mentors.27_corner | Want to give this a shot ?]]

**Edit:** I hadn't seen Spage's last comment when I wrote my comment.
>>! In T1119#1648391, @Qgil wrote:
> I wonder whether Google Code-in could be of any help here.

I think it could if @rfarrand defines a good "generic" (cloneable) [[ https://www.mediawiki.org/wiki/Google_Code-in_2015#Requirements_of_a_task | beginner task ]], like 
"Wikimedia occassionally hosts [[ https://www.mediawiki.org/wiki/Tech_talks | Tech talks]] (FIXME: That page does not even explain what a Tech Talk is). Go to this link which is a list of Wikimedia TechTalk videos on Youtube. Pick one video, thoroughly understand which topic the Tech Talk video is about, identify a number of key terms you would associate with the Tech Talk topic, [[ https://www.mediawiki.org/wiki/Help:Searching | search ]] for documentation wiki pages on Wikimedia sites (meta.wikimedia.org, mediawiki.org, potentially commons.wikimedia.org and en.wikipedia.org, wikimediafoundation.org, FIXME: any others?) which are strongly related to the Tech Talk's topic, and provide a list of links to these wiki pages plus information which video you chose". 
(The action of updating the Youtube description requires special permissions so that's out of scope for GCI I'd say.)

@Rfarrand: [[ https://www.mediawiki.org/wiki/Google_Code-in_2015#Mentors.27_corner | Want to give this a shot ?]]
I created [[ https://www.mediawiki.org/wiki/Template:Tech_talk_video |  Template:Tech talk video]] `{{Tech talk video| link=` //youtube link// `| date=` //date//  `| title=` //talk title// `}}` that outputs
* "[[ https://www.youtube.com/watch?v=sWiDimlK4bE | Watch ]] 2015-10-19 [[https://www.mediawiki.org/wiki/Tech_talks | Tech talk ]] on "Free and open source licensing at Wikimedia".

then just add this to the relevant pages that had tech talks. Maybe also use this template on the Tech talks page itself, though that has extra links.
Done on MediaWiki-Vagrant, Performance team, Phabricator -- check https://www.mediawiki.org/wiki/Special:WhatLinksHere/Template:Tech_talk_video
I created [[ https://www.mediawiki.org/wiki/Template:Tech_talk_video |  Template:Tech talk video]] `{{Tech talk video| link=` //youtube link// `| date=` //date//  `| title=` //talk title// `}}` that outputs
* "[[ https://www.youtube.com/watch?v=sWiDimlK4bE | Watch ]] 2015-10-19 [[https://www.mediawiki.org/wiki/Tech_talks | Tech talk ]] on "Free and open source licensing at Wikimedia".

then just add this to the relevant pages that had tech talks. Maybe also use this template on the Tech talks page itself.
How about:

Create a template `{{Tech talk |` //youtube link// `|` talk title `|` //date// `}}` that outputs
* "[[ https://www.youtube.com/watch?v=sWiDimlK4bE | Watch ]] 2015-10-19 [[https://www.mediawiki.org/wiki/Tech_talks | Tech talk ]] on "Free and open source licensing at Wikimedia"

then add this to the relevant pages that had tech talks. Maybe also use this template on the Tech talks page itself.
I wonder whether Google Code-in could be of any help here.
I mean, linking to the videos from the project pages. For instance, a link from https://www.mediawiki.org/wiki/MediaWiki-Vagrant to the last Tech Talk about MediaWiki Vagrant.
I have the youtube videos linked from the tech talk pages - I just have not linked to documentation on each talk from YouTube. It might actually take a little while to dig around and find all of the documentation/project pages. 

Past tech talks listed with YouTube links: https://www.mediawiki.org/wiki/Project:Calendar/How_to_schedule_an_event/TechTalks
This task is missing a description. The other way round ould be done as well: link to Tech Talk videos from the corresponding wiki pages.
https://www.mediawiki.org/wiki/2015_MediaWiki_User_Survey

https://docs.google.com/forms/d/1j2ThONROvc0bGY5d3yx4tJln4Aa2Fs130j5OlHbjW14/viewform

Presentation reporting preliminary results.

https://commons.wikimedia.org/wiki/File:2015_MediaWiki_User_Report.pdf
Exciting news and great job!
Exciting news and great job!

----- Original Message -----
From: "Ckoerner" <no-reply@phabricator.wikimedia.org>
To: alexis@everybody.org
Sent: Thursday, July 30, 2015 10:33:27 AM
Subject: [Maniphest] [Commented On] T1114: Create a survey that MediaWiki users can use to provide us with information

Ckoerner added a comment.

Phew!
It's been a few weeks since Wikimania and I'm just now getting my bearings.

As of this morning we have 127 responses to our survey. That's a great accomplishment. Does anyone want to send out another reminder to the various mailing lists? One last hurrah?

I'll close the survey tomorrow (Friday) at the end of the day (20:00 CST).

Then we should put together a final report (maybe just an update of our presentation from Wikimania) with stats.

I can work on making the data available publicly - anonymized of course.

Then what?

Might I suggest we take the feedback from the survey, add it to our wishlist, and start to prioritize?


TASK DETAIL
  https://phabricator.wikimedia.org/T1114

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ckoerner
Cc: Krenair, RichardHeigl, RHeigl, Ckoerner, cicalese, Spage, Aklapper, Mglaser, Palexis, MarkAHershberger, Qgil, Legoktm, Malyacko, P.Copp
Phew!
It's been a few weeks since Wikimania and I'm just now getting my bearings. 

As of this morning we have 127 responses to our survey. That's a great accomplishment. Does anyone want to send out another reminder to the various mailing lists? One last hurrah? 

I'll close the survey tomorrow (Friday) at the end of the day (20:00 CST).

Then we should put together a final report (maybe just an update of our presentation from Wikimania) with stats.

I can work on making the data available publicly - anonymized of course.

Then what?

Might I suggest we take the feedback from the survey, add it to our wishlist, and start to prioritize?
The survey has been sent to mediawiki-l

http://hexm.de/MWSurvey

Alternate link: https://docs.google.com/forms/d/1j2ThONROvc0bGY5d3yx4tJln4Aa2Fs130j5OlHbjW14/viewform

Please share and provide suggestions on where else to promote. We will leave it open for a little more than 2 weeks, closing on Friday, July 31st.

Woo!
Great! Will you be posting information for remote participation in the Stakeholders' meetup?
We (Mark, Marcus, and myself) are at the hackathon in Mexico City. We've created a page to host a brief introduction to the survey (and eventually the results) on Mediawiki.org.

https://www.mediawiki.org/wiki/2015_MediaWiki_User_Survey
Ok, we're at the Hackathon at Wikimania and talked about the question about how frequently you update. 

We've reworded it to ask, "Which MediaWiki update cycle is closest to what you use?"
Sorry, I didn't mean for this to be a blocker. Despite the fact that the major/point release schedule is not currently accurate in terms of time, it is a driver for updating. I update when a new security-related point release or major release is available, regardless of whether that is every month or every six months. So, the time-based answers were not a good fit for my situation. But, some folks might use a more time based approach to updating. I think adding answers based upon release availability to the time based answers to the question would be a good solution, helping us to determine what the drivers are for updating. I don't recall if there was an "other" answer, but that could also help. But, I whatever you choose, this should not stop the survey from moving forward.
I'm stuck on the 'How frequently do you update" question. Since the major/point release schedule isn't the most accurate, will responses tell us anything useful? Can we combine the two in a graceful way?
Yes, that was why I was mentioning it. It was difficult to answer the question with a strict timeframe. We update whenever there is a release available to update to, but that does not appear to happen on schedule at this point.
Ckoerner writes:

> Which is more important to know. That folks update to major/point
> releases or that they're updating with any sort of frequency? Do you
> think we should combine the two answer types?

No comment on either of those points, but I would point out that there
have been questions on mediawiki-l about the lack of point releases.
@RHeigl Thanks for the OK and the correction.

@Cicalese I can move the links to the thank you page. Good idea.

As for the upgrade question, you have an interesting point. The release schedule for MediaWiki is major releases every 6 months and point releases monthly. 

https://www.mediawiki.org/wiki/Version_lifecycle#Release_policy

Which is more important to know? That folks update to major/point releases or that they're updating with any sort of frequency? Do you think we should combine the two answer types?
@RHeigl Thanks for the OK and the correction.

@Cicalese I can move the links to the thank you page. Good idea.

As for the upgrade question, you have an interesting point. The release schedule for MediaWiki is major releases every 6 months and point releases monthly. 

https://www.mediawiki.org/wiki/Version_lifecycle#Release_policy

Which is more important to know. That folks update to major/point releases or that they're updating with any sort of frequency? Do you think we should combine the two answer types?
@RHeigl Thanks for the OK and the correction.

@Cicalese I can move the links to the thank you page. God idea.

As for the upgrade question, you have an interesting point. The release schedule for MediaWiki is major releases every 6 months and point releases monthly. 

https://www.mediawiki.org/wiki/Version_lifecycle#Release_policy

Which is more important to know. That folks update to major/point releases or that they're updating with any sort of frequency? Do you think we should combine the two answer types?
It looks great! Thank you so much for your work on this, @ckoerner!

I have two very minor suggestions, but I think it is good to go regardless, even without any changes. For the "how often do you upgrade" question, I wanted to answer in a less time constrained manner: "every time there is a point release", "every time there is a security-related point release" or "every time there is a major release". And, would it be possible to move the links from the page with the Submit button (where it is tempting to click them and lose the survey results) to the Thank You page?
Checked it. Great!
You have my OK :-))

Thank you very much!

Just found a typo: Are you(r) sites public or private?
@krenair Fixed! Thank you.

@mglaser Hmm. Good point. I've changed it to a multi-select.
On the third page, I am asked how many MediaWiki sites I run. I selected more than one. In the follwing question about my MW version, I have to pick one. However, I run a range of versions. This might probably be better if I could select multiple options here.  

Otherwise it's ok for me
On the third page, I am asked how many MediaWiki sites I run. I selected more than one. In the follwing question about my MW version, I have to pick one. However, I run a range of versions. This might probably be better if I could select multiple options here.
And " I contribute patches and pug fixes"
Typo on "What would yo like to see most improved in the community around MediaWiki?"
Tyop on "What would yo like to see most improved in the community around MediaWiki?"
Might be worth separating people who are actually running this week's WMF branches from those who are running really old WMF branches.
The survey has been created!

Please review. If you **are OK** with sending, please let me know. If you are **not OK** with sending, please let me know.

I will not publish or send this until I have **at least 4 responses **in the affirmative. I don't want to send it out with the //assumption //everyone is OK with it! :)

http://goo.gl/forms/XCYIdNT2gI
Thanks, Chris, for this list, this is good stuff. 

A few comments that come to my mind:

> 5. What MediaWiki version are you currently using?
I think it is more interesting how frequently they update. So the question could be rephrased to 
> 5. When did you last update your MediaWiki? To which version (LTS version, newest release, newest patch version, or other?)

And the questions about extensions:
> 6. How many extensions do you use?
I am not so sure why we would be interested in that. Maybe rephrase it: 
> 6. Did you modify your MediaWiki? How (add existing extensions, change skin, write new extensions)?

In addition to @cicalese's comment,
> 5. What barriers, if any, do you think exist to participation in the MediaWiki community?
maybe we could ask how to help:
> 5. What barriers, if any, do you think exist to participation in the MediaWiki community? What can we do to help?
This is a good short list. Perhaps the following two questions are similar enough to be combined into one:

3.What would you like to see improved in MediaWiki?
4.What is the most important thing the Mediawiki community should be focused on?

And, the following two questions are thematically related and could benefit from being beside each other:

2.Do you make contributions to the MediaWiki community?
5.We're striving to increase the participation of MediaWiki users outside of Wikimedia Foundation-led initiatives. What do you think is the biggest barrier to participation?

Perhaps 5 could be simplified to:

5. What barriers, if any, do you think exist to participation in the MediaWiki community?

Thanks for pulling this together!
Ok, how about this as a proposal. I've removed a few questions to shorten things down to 12 questions. These are what I feel (which is neither right or wrong) on what are the important questions to ask this go round. This would assume that we keep the 4 demographic questions.

 # How long have you been using MediaWiki?
 # How many MediaWiki sites do you manage?
 # Are your sites public or private?
 # How many end users are there of your MediaWiki sites?
 # What MediaWiki version are you currently using?
 # How many extensions do you use?
 # Of those extensions which are your Top Five?


 # Why do you use MediaWiki?
 # Do you make contributions to the MediaWiki community?
 # What would you like to see improved in MediaWiki?
 # What is the most important thing the Mediawiki community should be focused on? 
 # We're striving to increase the participation of MediaWiki users outside of Wikimedia Foundation-led initiatives. What do you think is the biggest barrier to participation?
Ok, how about this as a proposal. I've removed a few questions to shorten things. This would assume that we keep the 4 demographic questions.

 # How long have you been using MediaWiki?
 # How many MediaWiki sites do you manage?
 # Are your sites public or private?
 # How many end users are there of your MediaWiki sites?
 # What MediaWiki version are you currently using?
 # How many extensions do you use?
 # Of those extensions which are your Top Five?


 # Why do you use MediaWiki?
 # Do you make contributions to the MediaWiki community?
 # What would you like to see improved in MediaWiki?
 # What is the most important thing the Mediawiki community should be focused on? 
 # We're striving to increase the participation of MediaWiki users outside of Wikimedia Foundation-led initiatives. What do you think is the biggest barrier to participation?
Regarding community surveys, this one from the Drupal community was insightful. 

https://www.drupal.org/node/1399056

Of note, their survey was at around 13 questions, in addition to 4 'demographic' questions.
Dang. You are absolutely correct. We're at 20 + questions. What if we paired that down to say 10? I'll ask you and anyone else reading - what are the big 10 questions we want to ask? Think more about the answers. What top 10 things about MediaWiki users do we want to know? How do we ask questions that provide those answers?
Left my comments on the talk page.  One more, though: I feel like we don't want to bog dow the respondents just yet with too many questions.  I think @rheigl has worked on these beofe and it''d be good to know how we can make this as effective as possible.
Given that Wikimania is a scant two weeks away I spoke to @cicalese and offed to help finish the survey work. I have a draft of the questions here and need your feedback!

http://mwstake.org/mwstake/wiki/MediaWiki_Usage_Questions

Once I have a few people (I'm looking at you!) review these questions and the language around them I will create a working survey.

As I mentioned earlier (T1114#1341595) I have some suggestions on the distribution of the survey. 

  - What other opportunities exist that we can leverage to distribute? 
  - What do we need to do to get approval/permission to use the channels mentioned?
  - Does something like this need to be reviewed by the WMF in some capacity?

If we want to have a window for folks to respond we must act quickly. As of today we have two weeks until Wikimania begins. I would think getting this in front of Mediawiki users ASAP would provide us with more insightful and complete information than if we wait any longer.

Please review (and share) this draft. I propose a goal of sending this out by **the end of this week** - July 4th.
We are using Google Forms for our hackathon surveys, so nothing against this option. Still, you might want to check alternatives at {T94807}.
Given that our budget is 0, I propose we use a Google Doc to capture the information. Any alternative suggestions?
T951 is related as the survey will further our understanding of who (and how) is using MediaWiki.
Once we have a survey put together how do we get it in front of MediaWiki using people? A few ideas, but I'd love some more.
* Email to mediawiki, mediawiki-enterprise, semantic-mediawiki (dev and user), mailing lists
* Sharing on social media
* See if the folks at WikiApiary will help. Maybe a site banner or something for a week or two
* See if the folks behind MediaWiki.org can help. Maybe a banner as well
@cicalese , I put a page up on mwstake to start gathering these questions. I wanted to dump what was in my brain somewhere. Since this is your thing, feel free to delete it all. :)

http://mwstake.org/mwstake/wiki/MediaWiki_Usage_Questions
@Spage, you are right. Tag removed.
@Qgil, how is this part of the Documentation project? The survey is of users of the MediaWiki software. Are you thinking the survey could pose questions like "Are you an [] admin [] MediaWiki hacker?" "How could MediaWiki documentation for admins / users / developers be improved?"
Broad outline of the survey:

* How long have you been using MW?
* What do you use it for?
** Documentation?
** Coordination?
* How could MediaWiki distribution be improved?
> Need to develop the questions and find a place to host this survey.

@MarkAHershberger: Where was the scope of the survey discussed and where can that discussion be found (link)?
Currently it feels like no-one finding this task here could help because the scope feels a bit vague. Please clarify...
Thanks for the pointer!  That is helpful.
Phabricator does have a polling and questionnaire application..

I don't know if there is a standard place to do this otherwise, but it's a pretty straight forward app that is in phab-01 to look at https://phab-01.wmflabs.org/vote/
New report as of 2017/06/21. eventstreams is tracked at {T160644} already

```
root@graphite1001:/var/lib/carbon/whisper# du -hcs /var/lib/carbon/whisper/* | grep G | sort -rn
433G	/var/lib/carbon/whisper/eventstreams
199G	/var/lib/carbon/whisper/servers
199G	/var/lib/carbon/whisper/instances
137G	/var/lib/carbon/whisper/ores
71G	/var/lib/carbon/whisper/MediaWiki
50G	/var/lib/carbon/whisper/zuul
46G	/var/lib/carbon/whisper/varnishkafka
35G	/var/lib/carbon/whisper/frontend
```
Resolving this old task, individual big users are tracked separately
Change 358910 merged by Filippo Giunchedi:
[operations/puppet@production] role: cleanup CI data in graphite

[[https://gerrit.wikimedia.org/r/358910]]
@ArielGlenn thanks! yeah the eventstreams/rdkafka task is T160644, `instances` is also supposed to move to labmon in T143405
Seen today: icinga-wm: PROBLEM - carbon-cache too many creates on graphite1001 is CRITICAL: CRITICAL: 1.67% of data above the critical threshold [1000.0]

Mostly rdkafka plus some 'instances' metrics, I spot checked a couple log files: /var/log/carbon/carbon-cache\@{a,b,c}/creates.log
{nav icon=file, name=Mentioned in SAL (#wikimedia-operations), href=https://tools.wmflabs.org/sal/log/AVzee3oNZYjxCLpCzLVP} [2017-06-25T09:00:53Z] <elukey> Executing 'sudo -u _graphite find /var/lib/carbon/whisper/eventstreams/rdkafka -type f -mtime +15 -delete' on graphite1001 to free some space (/var/lib/carbon filling up) - T1075
Change 358910 had a related patch set uploaded (by Filippo Giunchedi; owner: Filippo Giunchedi):
[operations/puppet@production] role: cleanup zuul data in graphite

[[https://gerrit.wikimedia.org/r/358910]]
Change 358903 merged by Filippo Giunchedi:
[operations/puppet@production] graphite: introduce graphite::whisper_cleanup

[[https://gerrit.wikimedia.org/r/358903]]
Change 358903 had a related patch set uploaded (by Filippo Giunchedi; owner: Filippo Giunchedi):
[operations/puppet@production] graphite: introduce graphite::whisper_cleanup

[[https://gerrit.wikimedia.org/r/358903]]
Change 197509 merged by Filippo Giunchedi:
diamond: stop collecting disk IO stats for partitions

[[https://gerrit.wikimedia.org/r/197509]]
Change 197509 had a related patch set uploaded (by Filippo Giunchedi):
diamond: stop collecting disk partitions stats

[[https://gerrit.wikimedia.org/r/197509]]
downgrading to normal since we've mitigated the biggest growth.
still pending zuul patching which now has over 93k disting metrics and totalling 100+ GB
Jenkins no more emits to statsd under `jenkins.ci` which can now be deleted entirely.
>>! In T1075#22258, @fgiunchedi wrote:
> I think there might be some value in having those, but not as many. Note that also zuul metrics are basically duplicating those in jenkins, not sure exactly what generates those, zuul itself?
> 
> ```
> /var/lib/carbon/whisper/jenkins/ci/mwext-CentralNotice-testextension/FAILURE/count.wsp
> /var/lib/carbon/whisper/zuul/pipeline/test/job/mwext-CentralNotice-testextension/FAILURE/count.wsp
> ```

I finally looked at the usage of Graphite jenkins.ci metrics. Turns out they are not used from anywhere. The bug report to add them was:  Jenkins: report metrics to statsdhttps://bugzilla.wikimedia.org/show_bug.cgi?id=55412 .

The reason was to generate graphs of the executors queues, but it turns out the Java plugin does not collect them ( https://bugzilla.wikimedia.org/show_bug.cgi?id=55988 ).  So instead I added a Ganglia monitor which runs a python script to collect data out of the Jenkins REST API.


I have uninstalled the plugin ( T1278 ), still have to restart Jenkins but it is not an ideal time to do (there is some long running jobs going on which I don't want to abort).  Whenever Jenkins is restarted, we can delete the whole 'jenkins.ci.' metrics hierarchy and reclaim the disk space.


For Zuul, the metrics are used to generate dashboards on the Zuul status page at https://integration.wikimedia.org/zuul/ , so we need to keep them. That being said, we probably do not need metrics for each jobs / results, unfortunately Zuul does not have support to finely select which metrics to send.  Can be patched and proposed upstream.
>>! In T1075#22258, @fgiunchedi wrote:
>>>! In T1075#22250, @hashar wrote:
>> We can most probably remove the Statsd plugin from Jenkins. I have created the sub task {T1278}
> 
> I think there might be some value in having those, but not as many. Note that also zuul metrics are basically duplicating those in jenkins, not sure exactly what generates those, zuul itself?

@hashar any ideas on this?
>>! In T1075#22250, @hashar wrote:
> We can most probably remove the Statsd plugin from Jenkins. I have created the sub task {T1278}

I think there might be some value in having those, but not as many. Note that also zuul metrics are basically duplicating those in jenkins, not sure exactly what generates those, zuul itself?

```
/var/lib/carbon/whisper/jenkins/ci/mwext-CentralNotice-testextension/FAILURE/count.wsp
/var/lib/carbon/whisper/zuul/pipeline/test/job/mwext-CentralNotice-testextension/FAILURE/count.wsp
```
We can most probably remove the Statsd plugin from Jenkins. I have created the sub task {T1278}
also note that the zuul/jenkins stats are pushed twice, e.g.

```
/var/lib/carbon/whisper/jenkins/ci/mwext-CentralNotice-testextension/FAILURE/count.wsp
/var/lib/carbon/whisper/zuul/pipeline/test/job/mwext-CentralNotice-testextension/FAILURE/count.wsp
```

and account for ~half of all metrics created daily.

I took a look at the jenkins statsd plugin and it seems fairly easy to change it not to differentiate timings based on the build status but only on the job name:

```
diff --git a/src/main/java/org/jenkinsci/plugins/statsd/StatsdListener.java b/src/main/java/org/jenkinsci/plugins/statsd/StatsdListener.java
index 2409d1b..ce00eb0 100644
--- a/src/main/java/org/jenkinsci/plugins/statsd/StatsdListener.java
+++ b/src/main/java/org/jenkinsci/plugins/statsd/StatsdListener.java
@@ -46,7 +46,8 @@ public class StatsdListener extends RunListener<Run> {
         jobName = jobName.replaceAll("\\/", "-");
         jobName = jobName.replaceAll("[^a-zA-Z_\\-0-9]", "");
 
-        String metricName = prefix + '.' + jobName + '.' + result;
+        String metricResultName = prefix + '.' + jobName + '.' + result;
+        String metricTimingName = prefix + '.' + jobName;
 
         LOGGER.log(Level.INFO, "StatsdListener: config: " + config);
         LOGGER.log(Level.INFO, "StatsdListener: job: " + jobName + ", result: " + result +
@@ -54,8 +55,8 @@ public class StatsdListener extends RunListener<Run> {
 
         try {
             StatsdClient statsd = new StatsdClient(host, port);
-            statsd.increment(metricName);
-            statsd.timing(metricName, (int)duration);
+            statsd.increment(metricResultName);
+            statsd.timing(metricTimingName, (int)duration);
         } catch (UnknownHostException e) {
             LOGGER.log(Level.WARNING, "StatsdListener Unknown Host: ", e);
         } catch (IOException e) {
```
>>! In T1075#18973, @fgiunchedi wrote:
> another potential avenue of investigation from hashar
> 
> 
> ```
>>    I have some examples related to continuous integration:
> 
>>   A) jenkins.ci , emitted by Jenkins, metrics namespaced as follow:
> 
>>     - job_name (roughly 4000 jobs)
>>     - build status (4: success, failure, aborted, unstable)
> 
>>    Each having percentiles, count, max, mean, rate etc (12 entries)
> 
> 
> good catch! looks like these shouldn't get additional metrics calculated by statsd, that would cut it by 12x. definitely worth investigating what's going on
> 
> ```

so the solution here would be to separate build status from build time, status is fine being a different metric but build-time shouldn't be tied to the status as a metric, that greatly reduces the number of metrics
another potential avenue of investigation from hashar


```
>    I have some examples related to continuous integration:

>   A) jenkins.ci , emitted by Jenkins, metrics namespaced as follow:

>     - job_name (roughly 4000 jobs)
>     - build status (4: success, failure, aborted, unstable)

>    Each having percentiles, count, max, mean, rate etc (12 entries)


good catch! looks like these shouldn't get additional metrics calculated by statsd, that would cut it by 12x. definitely worth investigating what's going on

```
This error message happens [[ https://integration.wikimedia.org/ci/job/browsertests-VisualEditor-language-screenshot-linux-firefox/LANGUAGE_SCREENSHOT_CODE=nl,label=contintLabsSlave%20&&%20UbuntuTrusty/29/consoleFull | intermittently ]]:

  unable to obtain stable firefox connection in 60 seconds (127.0.0.1:7055) (Selenium::WebDriver::Error::WebDriverError)

Looks like it is a known problem:

https://code.google.com/p/selenium/issues/detail?id=4967
https://github.com/leonid-shevtsov/headless/issues/33
That is a duplicate of {T1321}

See there for full explanations and details on how to fix it up.
Related commit: https://gerrit.wikimedia.org/r/#/c/170023/
@MelodyKramer: The file to edit is https://phabricator.wikimedia.org/source/operations-puppet/browse/production/modules/phabricator/templates/community_metrics.sh.erb
If you feel like writing and proposing a patch in Gerrit: See https://www.mediawiki.org/wiki/Gerrit/Getting_started . The repo in this case is `operations/puppet.git`, the file is `modules/phabricator/templates/community_metrics.sh.erb`, and you'd have to replace the command `git checkout master` by `git checkout production` in this very case. And if you don't feel like I can also give it a shot. :)
Ah, thanks @Aklapper - is it possible to get that link (or the information contained within) added to the monthly email update I receive? I'm not sure who mans the wheels on that.
@MelodyKramer: I nowadays dump //two// of these numbers at [[ https://meta.wikimedia.org/wiki/Technical_Collaboration/Metrics#Project_management_.28Phabricator.29 | meta:Technical_Collaboration/Metrics#Project_management_.28Phabricator.29 ]].
(Beforehand I dumped two of these numbers at [[ https://www.mediawiki.org/wiki/Community_metrics | mw:Community_metrics ]] but the [[ https://www.mediawiki.org/w/index.php?title=Community_metrics&action=history | page scope was too blurry ]] so I split wikimedia.biterg.io documentation, displaying of some graphs with data copied out of other systems, and a link hub to random metrics pages in Wikimedia into three separate pages.)

(And the usual disclaimer when it comes to interpreting numbers: "New Phab accounts" does not mean "active Phab accounts" for more than half of these accounts.)
Hello! I just received the monthly stats email ([Wikitech-l] Phabricator monthly statistics - 2017-10) and I'm wondering if there's a way to show a 3 or 6 month trend. I do not know from the email if new Phab users have slowed down to a trickle or doubled...and the same holds true for active users and other metrics. This is a very very low-priority ask, but I would love to see additional stats added that compare the current figures to the past 3 or 6 months, so we can learn more about the ongoing nature of the userbase. Thank you! Mel
Trying to get some comparable numbers pre and post-migration. It seems that the sum of MediaWiki (including VisualEditor and MobileFrontend) and Wikimedia products is what mapped best from Bugzilla to Phabricator. Some numbers (I hate IRC invisible characters with passion, btw):

```
# Number of active users in MediaWiki and Wikimedia products
# January 2015
$ curl -s 'http://bots.wmflabs.org/~wm-bot/logs/%23mediawiki-feed/%23mediawiki-feed.tar.gz' | tar xzf - -O --wildcards '201501*' | grep wikibugs | grep -E '(MediaWiki|MobileFrontend|VisualEditor|Wikimedia)' | grep -Eo ' [(][^)]{0,3}10[^)]+' | sort | uniq -c | wc -l
473
# October 2014
$ ... --wildcards '201410*' ...
462
```
I would like to propose some changes in the data ranges used in this report, but before let's agree on {T86630}. You opinions are welcome there.
Thank you very much! 

>>! In T1003#963841, @Dzahn wrote:
> Number of accounts created in (2014-11): 299
> Number of active users (any activity) in (2014-11): 443

These are the two numbers I really care about for November. Look credible...

> Number of task authors in (2014-11): 284
> Number of users who have closed tasks in (2014-11): 115

These are also interesting. Do you think that they can be trusted?

It is no problem if the stats on tasks are messed up in the month of the Bugzilla migration. Even for December (with the RT migration) I'm not expecting to read much there in task related stats.

Having a continuity of user related stats is great. Thank you again.


> Number of tasks created in (2014-11): 1916
> Number of tasks closed in (2014-11): 814
> Number of tasks in the shell project closed as resolved,fixed in (2014-11): 4
> 
> Number of open and stalled tasks in total: 18296
> 
> 
> Is that sufficient? It was easier to make than the lower part.
andre__ added the address as allowed sender to wikitech-l. That means the list should now receive stats starting on Feb 1st.
As requested in comments above i have added wikitech-l to the recipients of this mail. More specifically wikitech-l is now one of the recipients that receive communitrymetrics@ mail which is the sender of this as configured in the puppet phabricator role.

Now we need one of the admins of wikitech-l to allow that sender as a "non-member".  Admins of wikitech-l are demon, aklapper and platonides.
>>! In T1003#961937, @KartikMistry wrote:
> Is it possible to get teamwise statistics? (eg: Language Engineering) (Just wishlist) :)

Separate tickets with specific criteria can be created. Such tickets will be wishlist/needs volunteer though; I don't think that I should spend much more time fiddling with Phabricator database schemes and SQL queries.
I doubt the November numbers because "Number of open and stalled tasks in total" is 18296 while it was 18125 in December. This really goes into details how metadata was migrated so I would not use any November numbers. Number of tasks created in Dec is 3424 - Number of tasks closed in Dec is 2529 = +895, but 18125-18296 =  -171. And as written in that script, the numbers are not entirely correctly for December either (and I encourage anybody who wants to investigate the SQL and Phab'sDB structure to fix that).
>>! In T1003#963724, @Dzahn wrote:
> 
> Yes, let me try to make one for November manually. I will attach it here.

I can give you this part:

Number of accounts created in (2014-11): 299
Number of active users (any activity) in (2014-11): 443
Number of task authors in (2014-11): 284
Number of users who have closed tasks in (2014-11): 115
Number of tasks created in (2014-11): 1916
Number of tasks closed in (2014-11): 814
Number of tasks in the shell project closed as resolved,fixed in (2014-11): 4

Number of open and stalled tasks in total: 18296


Is that sufficient? It was easier to make than the lower part.
>>! In T1003#961920, @Qgil wrote:
> The report send on January 1 looks good! Thank you very much. I have [[ https://lists.wikimedia.org/pipermail/wikitech-l/2015-January/079999.html | forwarded it to wikitech-l ]], wondering whether there is a way to sending it there automatically.

Yes, i can send it to wikitech by just adding the list address as a recipient. But one of the list admins has to also list the sender address in list settins somewhere as a verified "non-member" or we have to subscribe a fake user, otherwise the list will reject mail from an address it doesn't recognize as a subscribed member.

> 
> Also, would it possible to generate one report for November 2014? It's the month of the Bugzilla migration and any data needs to be taken with a big grain of salt. Still, having Bugzilla data until October and Phabricator data from December, it would be good to cover November for posterity.

Yes, let me try to make one for November manually. I will attach it here.
>>! In T1003#961937, @KartikMistry wrote:
> Is it possible to get teamwise statistics? (eg: Language Engineering) (Just wishlist) :)

We are no thee yet (at all), but see T28.
Is it possible to get teamwise statistics? (eg: Language Engineering) (Just wishlist) :)
The report send on January 1 looks good! Thank you very much. I have [[ https://lists.wikimedia.org/pipermail/wikitech-l/2015-January/079999.html | forwarded it to wikitech-l ]], wondering whether there is a way to sending it there automatically.

Also, would it possible to generate one report for November 2014? It's the month of the Bugzilla migration and any data needs to be taken with a big grain of salt. Still, having Bugzilla data until October and Phabricator data from December, it would be good to cover November for posterity.
♥! Thanks Dzahn!
resolving per: "This task can be closed as soon as we can publish monthly metrics for total amount of users and active in the past month."
Quim said:  ( for some reason I can't hit "quote" on his comment)
>Is it possible to add these to the report?
>Number of accounts created

This has been added now with  https://gerrit.wikimedia.org/r/#/c/181564/

"Number of accounts created in (2014-11): 299"
Change 181564 merged by Dzahn:
phab metrics: add number of accounts created

[[https://gerrit.wikimedia.org/r/181564]]
Change 181564 had a related patch set uploaded (by Dzahn):
phab metrics: add number of accounts created

[[https://gerrit.wikimedia.org/r/181564]]

#patch-for-review
>>! In T1003#939636, @Aklapper wrote:
> @dzahn: Does that require a separate ticket, or how to proceed?

It does, but it already exists. I reopened T78311 with the additional requirement and it's linked here as a blocker.
>>! In T1003#852987, @Dzahn wrote:
> Access denied for user 'phstats'@...  [...] This requires a change in DB GRANTS.

@dzahn: Does that require a separate ticket, or how to proceed?
>>>! In T1003#851249, @Aklapper wrote:
>> Uh, //daily//? The idea was monthly (see topic), otherwise the queries using INTERVAL 1 MONTH would likely create some weird results. :)

The cron job is changed now to run on the 1st of every month:

Puppet Name: phabstatscron_communitymetrics
0 0 1 * * /srv/phab/tools/community_metrics.sh

The third field is "day of the month".
>>>! In T1003#851249, @Aklapper wrote:
>> Uh, //daily//? The idea was monthly (see topic), otherwise the queries using INTERVAL 1 MONTH would likely create some weird results. :)

The cron job is changed now to run on the 1st of every month:

# Puppet Name: phabstatscron_communitymetrics
0 0 1 * * /srv/phab/tools/community_metrics.sh

The third field is "day of the month".
>>! In T1003#852435, @Aklapper wrote:
> but using $sql_name in the script won't work here as that is on the "phabricator_user" DB instead.

Access denied for user 'phstats'@...  The phstats user (and also the phuser user) don't have access to the "phabricator_user" database, only to the "phabricator_maniphest" database. This requires a change in DB GRANTS.
>>! In T1003#852435, @Aklapper wrote:
>>>! In T1003#851771, @chasemp wrote:
>> can I get on this list?
> 
> You need to bribe mutante.

No, there's no need for bribes. It's an exim alias defined in the private puppet repo.

@palladium:~/private/modules/privateexim/files/wikimedia.org

commit 38f50add7650b9ab524a7a7202bf6a3226a9d695

done:  dzahn: add Chase to communitymetrics@ alias
```
Hi Community Metrics team,

this is your automatic monthly Phabricator statistics mail.

Number of active users (any activity) in (2014-11): 433
Number of task authors in (2014-11): 269
Number of users who have closed tasks in (2014-11): 115
Number of tasks created in (2014-11): 1841
Number of tasks closed in (2014-11): 814
Number of tasks in the shell project closed as resolved,fixed in (2014-11): 4

Number of open and stalled tasks in total: 17463

Median age in days of open tasks by priority:
Unbreak now: 130
Needs Triage: 143
High: 206
Normal: 444
Low: 683
Needs Volunteer: 545

TODO: Numbers which refer to closed tasks might not be correct, as described in T1003.

Yours sincerely,
Fab Rick Aytor

(via community_metrics.sh on iridium at Tue Dec 16 15:50:10 UTC 2014)
```

>>! In T1003#851249, @Aklapper wrote:
>>>! In T1003#850735, @Dzahn wrote:
>> let me know if you don't receive it daily from now on
> 
> Uh, //daily//? The idea was monthly (see topic), otherwise the queries using INTERVAL 1 MONTH would likely create some weird results. :)

-->   https://gerrit.wikimedia.org/r/#/c/180444/
>>! In T1003#851771, @chasemp wrote:
> can I get on this list?

You need to bribe mutante.

>>! In T1003#851812, @Qgil wrote:
> Is it possible to add these to the report?

Should be. A bit late so dropping that here instead of cooking up a Gerrit patch directly:

>> Number of accounts created

SELECT COUNT(id) FROM user WHERE FROM_UNIXTIME(dateCreated,'%Y%m')=date_format(NOW() - INTERVAL 1 MONTH,'%Y%m');
but using $sql_name in the script won't work here as that is on the "phabricator_user" DB instead.

>> Number of users logging

Already covered by "Volume of contributors (any activity) in last month" already, I think? If not, what's the 𝝙? 
There's a "dateMotified" column but not sure what that really refers to, probably not helpful.
Is it possible to add these to the report?

> Number of accounts created
> Number of users logging

And I agree with @Nemo_bis, sending this email to wikitech-l every month would be great.
can I get on this list?
This is just great. I'm so happy. Thank you!
>>! In T1003#850735, @Dzahn wrote:
> let me know if you don't receive it daily from now on

Uh, //daily//? The idea was monthly (see topic), otherwise the queries using INTERVAL 1 MONTH would likely create some weird results. :)
needed one more small fix:

https://gerrit.wikimedia.org/r/#/c/180193/

but now it works, puppet applied it and i tested it.

the communitymetrics@ mail alias should now receive this. (currently qgil and aklapper)

i ran it once manually for you to get it now without having to wait for the cronjob.

let me know if you don't receive it daily from now on
merged PS10 https://gerrit.wikimedia.org/r/#/c/177792/

puppet-compiler: http://puppet-compiler.wmflabs.org/558/change/177792/html/iridium.eqiad.wmnet.html

on iridium:

Notice: /Stage[main]/Role::Phabricator::Main/Phabricator::Logmail[communitymetrics]/Cron[phabstatscron_communitymetrics]/ensure: created
Notice: /Stage[main]/Role::Phabricator::Main/Phabricator::Logmail[communitymetrics]/File[/srv/phab/tools/community_metrics.sh]/ensure: created
Change 177792 merged by Dzahn:
phabricator: community metrics stats mail

[[https://gerrit.wikimedia.org/r/177792]]
>>! In T1003#850592, @Aklapper wrote:
> Works locally. Now waiting for Daniel to trigger another test email to me.

yep, works for me. i ran it on iridium and triggered the test email
I've added a few more patchsets / revisions to https://gerrit.wikimedia.org/r/#/c/177792/ :
* worked around (fixed?) the two empty SQL query results by setting an empty column name via AS ' '
* added the way more performant "median age of open tasks by priority" queries (see last comment)
* removed backticks surrounding one variable to not get an invalid SQL query error for the median-age queries when calling those SQL queries from a bash script, works also as expected without them
* as the new median-age queries' output is a float instead of an integer, cut the .0000 resp .5000 suffixes so there's no "invalid arithmetic operator" syntax error anymore

Works locally. Now waiting for Daniel to trigger another test email to me.
>>! In T1003#850332, @Aklapper wrote:
> * For unknown reasons (those SQL queries work locally, maybe the  //cut -d " " -f3// in the script itself but hard to imagine), the following two values in that email are just empty: 
> ** Number of tasks created in (2014-11): 
> ** Number of open and stalled tasks in total: 

when i run the query for "tasks created" directly on the database i get this:


```
MariaDB MISC m3 localhost phabricator_maniphest > SELECT COUNT(*) FROM maniphest_task WHERE 
    ->     FROM_UNIXTIME(dateCreated,'%Y%m')=date_format(NOW() - INTERVAL 1 MONTH,'%Y%m');
+----------+
| COUNT(*) |
+----------+
|     1841 |
+----------+

```

in the script the variable $result_taskscreated" becomes this though:

"created: COUNT(*)
1841" 

i added the " , but the variable contains COUNT(*) and the line break and then the actual value.
>>! In T1003#844983, @kevinator wrote:
> This might be a cheap way to get a visualization of the data.

Thanks. We might play with this once we have the actual queries in place and their text output working.
When I saw the wiki with [[ https://www.mediawiki.org/wiki/Talk:Community_metrics#Bugzilla_stats | number of active bugzilla users ]],  I wondered if you knew about the graph extension that lets you embed graphs into wiki pages.  This was also an excuse for me to play with the extension:

bugzilla users: https://www.mediawiki.org/wiki/Talk:KLeduc_(WMF)/test_graph_extension
the data: https://www.mediawiki.org/wiki/Talk:KLeduc_(WMF)/test_graph_extension_data
the extension: https://www.mediawiki.org/wiki/Extension:Graph

This might be a cheap way to get a visualization of the data.
Change 177792 had a related patch set uploaded (by Nemo bis):
phabricator: community metrics stats mail

[[https://gerrit.wikimedia.org/r/177792]]

#patch-for-review
> start humble with sql queries

Speaking of which. As the Bugzilla weekly report is no more :[, this update could be sent directly to wikitech-l and called "Phabricator monthly report", with an expectation that new content might be added to it later (or not).
>>! In T1003#821248, @chasemp wrote:
> There is a "Fact" app that is pretty young, but it may make more sense to put our time into that https://secure.phabricator.com/fact/

Upstream told us clearly that it's not worth for us to try to step in to improve Fact or surroundings, before they do some homework in the background. This is one of the reasons why I'm proposing to start humble with sql queries. See https://secure.phabricator.com/T1562#80158 and below.
https://gerrit.wikimedia.org/r/#/c/177792/
There is a "Fact" app that is pretty young, but it may make more sense to put our time into that https://secure.phabricator.com/fact/
Let's have a separate ticket for some stats app in Phab.
To avoid confusion:
This ticket was originally about the cronjob that once a month sent an email with a single number to Quim and me: The number of active users in Bugzilla in the last month.
We want that for Phab too as we like to have some basic metrics.

As Phab's reporting tools are a bit limited currently and as we have not ported the backend of korma.wmflabs.org to support Phab (see T28) we're now missing some more statistics that we had on korma.
Hence as a poor man's solution, I'd like to extend that cronjob script by some more sql queries, for the time being. Some of them provide data that we had on korma, though now in a non-visual way, but better than nothing for the time being.

Let's have a potential future "Stats" app in Phab either handled in T28, or in a separate ticket. :)
we could probably create a 'stats' app in phabricator that would provide a simple ui for executing these queries and displaying the data in a reasonably nice way. It would be a significant amount of work but not huge or difficult.
> Volume of tasks in the "shell" project resolved/fixed in last month, requested by Guillaume

Hmm, no, I can't https://phabricator.wikimedia.org/conduit/method/maniphest.query/ see supporting that query either. Meh.

This query seems to work locally for me, but it has the same problem as the other "closed" queries above:

SELECT COUNT(DISTINCT objectPHID) FROM maniphest_transaction JOIN maniphest_nameindex JOIN edge WHERE (maniphest_nameindex.indexedObjectName="shell" AND maniphest_nameindex.indexedObjectPHID=edge.dst AND edge.src=maniphest_transaction.objectPHID) AND (transactionType="status" AND (oldValue="\"open\"" OR oldValue="\"stalled\"") AND newValue="\"resolved\"") AND FROM_UNIXTIME(maniphest_transaction.dateCreated,'%Y%m')=date_format(NOW() - INTERVAL 1 MONTH,'%Y%m');
Note to myself: Add another query for "shell requests closed in last month" for Guillaume as the UI does not offer that and add Guillaume to recipients. (I've also had two other ideas how to get that data but for this one I know it'll work.)
>>! In T1003#793868, @Dzahn wrote:
> Once we are at the point where we have more specific SQL queries you want to be executed and results mailed to people, ping me and I can puppetize that similar to how the BZ mails worked in the past. 

@Dzahn: I hereby ping you. :) 
If you could put the above SQL queries (which at least worked locally here for me) into a monthly cronjob email like the previous "bugzilla stats - 2014-10" ones (we can test now by triggering the one for November), that would be lovely. 
The last query listed here needs to be included several times to also cover those other x.priority values available.
And I can probably finetune&review a patch in Gerrit...
I'm afraid I pasted some useful queries for this ticket in T28#793720 instead.
Once we are at the point where we have more specific SQL queries you want to be executed and results mailed to people, ping me and I can puppetize that similar to how the BZ mails worked in the past.
Looking at the metrics proposed in the description, what do you think we could obtain in relation to these dates?

* Opening of the production instance
* Right before closing for the Bugzilla migration
* Right after the migration
* End of November
* and then, end of every month

We have our #Engineering-Community quarterly review on mid January. I want to bring Phabricator metrics there, because it would be useful, and because it is assured that Lila & co will ask for them.
After having a very quick look at the database scheme: 
In the "phabricator_user" database, the "user" table has "id" and "phid" columns to identify users. There's also "dateModified" and "dateCreated" (new registrations) columns with values stored in Unix epoch format (to base timespan queries against). The "user_log" table also has a "dateModified" column for any user's actions, stored in Unix epoch format. 
Also wondering if the "maniphest_transaction" and "maniphest_transaction_comment" tables from the "phabricator_maniphest" databases could provide activity data. Need to play more if I find time.
Let's track progress on the migration of this team to Phabricator. Feel free editing this task description.

[ ] Team member assigned to this task
[ ] Link(s) to the current projects in Mingle, Trello, other
[ ] (optional) Have you scheduled a team meeting with @Qgil to discuss the migration? (yyyy-mm-dd)
[ ] Blockers of the migration identified: (list the task numbers between {curly brackets})
[ ] Planned date for the migration/creation of a first real project: yyyy-mm-dd
[ ] Do you plan to have all your projects moved by the end of 2014? Yes/No, and if not, why
(...)
[ ] More than half of our team members and ongoing sprints are working in Phabricator now (yyyy-mm-dd)
[ ] All our projects have been moved to Phabricator. Mission completion! (yyyy-mm-dd)
yup
Can we Close Resolved, then?
Research team is in Phab.  Per @DarTar the remaining Trello boards do not need to be migrated.
Thanks, @Spage!

I think that we are done with the Research and Data board from Trello.

We need to groom the Research and Data backlog board and migrate what survives....grooming is scheduled for Thurs 2015-05-21.

@DarTar - does that sound correct?
I migrated the Trello columns Completed - In Progress - Incoming requests (external) - Time sensitive - Blocked, and I think Grace has dragged the Phab tasks into shape. Are we done?

𝄞 //We are Phamily, I got all my sisters with me// ♬  – Sister Sledge
I migrated the Trello columns Completed - In Progress - Incoming requests (external) - Time sensitive - Blocked and I think Grace has dragged the Phab tasks into shape. Are we done?

𝄞 //We are Phabily, I got all my sisters with me// ♬  – Sister Sledge
@Spage  Please migrate Incoming requests (external) and In Progress sequentially and check with me after each import.

Then I can manually create cards fromTime Sensitive and Blocked in Trello in Phab myself.
Thanks, @Spage!

I have created column for Staged (ready to execute) in Phab Research and Data board:

1.  moved cards relevant cards from backlog to Staged (ready to execute) column
2.  reviewed each card and replicated Trello comments that didn't make it over to Phab Research and Data tasks 

Please migrate the next Trello swim lane.
I migrated "Staged (ready to execute)", e.g. Trello card [[ https://trello.com/c/BNf0xY6P/632-mid-article-recommendation-for-content-translation | mid Article recommendation for Content Translation ]] became T99040. Details on [[ https://www.mediawiki.org/wiki/Phabricator/Trello_to_Phabricator/Research_import | Trello to Phabricator/Research import ]] page.

@ggellerman, @DarTar, step 4 above. Try creating the equivalent column in phabricator and dragging cards, look for obvious errors beyond the missing features mentioned in {T821}, let me know if it's OK to migrate the rest.
@qgil Search-and-Discovery-Research-and-Data-Sprint is not related to my team, it's an internal board used by the S/D team.

@spage the following are done (copied you)

  # Need list of user name mappings Trello -> Phabricator
  # Heads up migration is starting
meet with @DarTar and @ggellerman:

The main Trello board to migrate is [[ https://trello.com/b/k5N0ivoM/research-and-data | Research and Data ]]. Dario moved the one column in the Trello  "Research and Data - backlog" board to migrate into this.

# ☑ Need list of user name mappings Trello -> Phabricator
# ☑Heads up migration is starting
# ☑ spage migrate one column, probably "Staged (ready to execute)"
# ☑ Grace and Dario look at it
# ☑ Heads up the entire migration is happening
# ☑ spage migrates the rest
# ☑ Grace renames the Trello boards to append MIGRATED TO PHAB, etc.

Their plan is to have all tasks on a big Research workboard, have tags for specific Research projects like VisualEditor //Xxx research//
, and then filter the workboard by these tags (workboard > Filter > Advanced Filter... > Projects ) to see the status of particular projects.
meet with @DarTar and @ggellerman:

The main Trello board to migrate is [[ https://trello.com/b/k5N0ivoM/research-and-data | Research and Data ]]. Dario moved the one column in the Trello  "Research and Data - backlog" board to migrate into this.

# ☑ Need list of user name mappings Trello -> Phabricator
# ☑Heads up migration is starting
# ☑ spage migrate one column, probably "Staged (ready to execute)"
# Grace and Dario look at it
# Heads up the entire migration is happening
# spage migrates the rest
# Grace renames the Trello boards to append MIGRATED TO PHAB, etc.

Their plan is to have all tasks on a big Research workboard, have tags for specific Research projects like VisualEditor //Xxx research//
, and then filter the workboard by these tags (workboard > Filter > Advanced Filter... > Projects ) to see the status of particular projects.
meet with @DarTar and @ggellerman:

The Main Trello board to migrate is [[ https://trello.com/b/k5N0ivoM/research-and-data | Research and Data ]]. Dario moved the one column in the Trello  "Research and Data - backlog" board to migrate into this.

# ☑ Need list of user name mappings Trello -> Phabricator
# ☑Heads up migration is starting
# spage migrate one column, probably "Staged (ready to execute)" maybe do it Thursday
# Grace and Dario look at it
# Heads up the entire migration is happening
# spage migrates the rest
# Grace renames the Trello boards to append MIGRATED TO PHAB, etc.

Their plan is to have all tasks on a big Research workboard, have tags for specific Research projects like VisualEditor //Xxx research//
, and then filter the workboard by these tags (workboard > Filter > Advanced Filter... > Projects ) to see the status of particular projects.
meet with @DarTar and @ggellerman:
In Phabricator will have:
master project list for quarterly priorities
Research project list
Projects for individual tasks

Main Trello board to migrate is "Research and Data", also a "Research and Data - backlog" board. Only migrate some of the latter - Dario moved the column to migrate to #Research-and-Data.

# ☑ Need list of user name mappings Trello -> Phabricator
# ☑Heads up migration is starting
# spage migrate one column, probably "Staged (ready to execute)" maybe do it Thursday
# Grace and Dario look at it
# Heads up the entire migration is happening
# spage migrates the rest
# Grace renames the Trello boards to append MIGRATED TO PHAB, etc.

Their plan is to have all tasks on a big Research board, have tags for specific Research projects, and then filter the workboard to show the tasks in particular projects.
meet with @DarTar and @GraceGellerman:
In Phabricator will have:
master project list for quarterly priorities
Research project list
Projects for individual tasks

Main Trello board to migrate is "Research and Data", also a "Research and Data - backlog" board. Only migrate some of the latter - Dario moved the column to migrate to #Research-and-Data.

# Need list of user name mappings Trello -> Phabricator
# Heads up migration is starting
# spage migrate one column, probably "Staged (ready to execute)" maybe do it Thursday
# Grace and Dario look at it
# Heads up the entire migration is happening
# spage migrates the rest
# Grace renames the Trello boards to append MIGRATED TO PHAB, etc.

Their plan is to have all tasks on a big Research board, have tags for specific Research projects, and then filter the workboard to show the tasks in particular projects.
meet with @DarTar and @GraceGellerman:
In Phabricator will have:
master project list for quarterly priorities
Research project list
Projects for individual tasks

Main Trello board to migrate is "Research and Data", also a "Research and Data - backlog" board. Only migrate some of the latter - Dario moved the column to migrate to #Research-and-Data.

# Need list of user name mappings Trello -> Phabricator
# Heads up migration is starting
# spage migrate one column, probably "Staged (ready to execute)" maybe do it Thursday
# Grace and Dario look at it
# Heads up the entire migration is happening
# spage migrates the rest
# Grace renames the Trello boards to append MIGRATED TO PHAB, etc.

Their plan is to have a big Research board, and then filter
meet with @DarTar and @GraceGellerman:
In Phabricator will have:
master project list for quarterly priorities
Research project list
Projects for individual tasks

Main Trello board to migrate is "Research and Data", also a "Research and Data - backlog" board. Only migrate some of the latter - Dario moved the column to migrate to #Research-and-Data.

# Need list of user name mappings Trello -> Phabricator
# Heads up migration is starting
# spage migrate one column, probably "Staged (ready to execute)" maybe do it Thursday
# Grace and Dario look at it
# Heads up the entire migration is happening
# spage migrates the rest
# 

Their plan is to have a big Research board, and then filter
meet with @DarTar and @GraceGellerman:
In Phabricator will have:
master project list for quarterly priorities
Research project list
Projects for individual tasks

Main Trello board to migrate is "Research and Data", also a "Research and Data - backlog" board. Only migrate some of the latter - Dario moved the column to migrate to #Research-and-Data.

# Need list of user name mappings Trello -> Phabricator
# Heads up migration is starting
# spage migrate one column
# Grace and Dario look at it
# Heads up the entire migration is happening
# spage migrates the rest
# 

Their plan is to have a big Research board, and then filter
I just learned about #Search-and-Discovery-Research-and-Data-Sprint

Progress!
Hi, I'm preparing the Phabricator migration statistics for the #Engineering-Community quarterly review. Currently {T434} reports that your situation with Phabricator is 

  0	  Not started

Is this accurate?
@Qgil yes we'll definitely need this, I think we're not yet ready though (we need to review the other blockers first and I want to make sure we don't start creating duplicate cards until we're completely ready for the migration).
If/when you decide to move to Phabricator entirely, will you need migration of Trello cards to Phabricator tasks, aka someone to run {T821}?
I removed Analytics-Engineering because their migration is complete.

Note that "Restricted Project" in the task description refers to Analytics Research & Data. Someone tweaked its permissions.

Who should be the owner of this task? It would be good to have a point of contact.
@Ironholds has started a discussion about [[ https://lists.wikimedia.org/pipermail/analytics/2014-December/002894.html | Analytics Research & Data migrating to Phabricator ]] in the Analytics mailing list. It's a very interesting post that could be extrapolated to most WMF tech teams.
Hi Quim -- we really need the sprint extension to confirm our migration. If this doesn't meet our needs, we'll need to revisit our use of Phabricator.

R&D does not have plans to move off of Trello at this time.

No more teams within Analytics.

-Toby
Here are Research & Data Trello boards:

https://trello.com/b/k5N0ivoM/research-and-data
https://trello.com/b/UcQSC5Au/research-and-data-backlog
https://trello.com/b/CSltHJXs/research-and-data-archive
In relation to T434,

#Analytics-Engineering looks pretty active. Can we consider this team fully migrated to Phabricator, or are there still tasks / sprints / projects active elsewhere?

#research-and-data seems to be still 100% in Trello. Can you provide a link to access their board(s), please?

Are there more teams within in Analytics?

PS: T1322 is planned for this Wednesday.
In relation to T434,

#Analytics-Engineering looks pretty active. Can we consider this team fully migrated to Phabricator, or are there still tasks / sprints / projects active elsewhere?

#research-and-data seems to be still 100% in Trello. Can you provide a link to access their board(s), please?

PS: T1322 is planned for this Wednesday.
As discussed, the scrumbugz style burndowns are blockers for our migration (T1322)

We're excited for this feature! Let us know if we can help.
As per T434 , in the following days I plan to scan the levels of use of Phabricator by all the WMF product & engineering teams. Please keep the description of this task up to date.
Checking in to see if this needs to be modified or closed?
We agreed that the Severity information would be printed in the task description, since we decided not to have such field in Phabricator. Currently this information is missing in bugzillapreview. See for instance https://bugzilla.wikimedia.org/show_bug.cgi?id=57540 (Severity: critical)
Available Severity values in Bugzilla are
* blocker
* critical
* major
* normal
* minor
* trivial
* enhancement
and there is no conversion; this will just be added to the task description in Phabricator. Severity cannot be unspecified.
I'm not sure I understand your request. So the only problem here is that you expect that the "Severity: " text string is documented in /versus_Bugzilla, reflecting all the possible values, including the case where it is unspecified, right? 

I expect the answer to be

* blocker
* critical
* major
* normal
* minor
* trivial
* enhancement
* unspecified

I will ask.

The way to retrieve this information is a search query.
Reopen because [[Phabricator/Help]] is silent on severity and [[Phabricator/versus Bugzilla]] only says «Also note that Severity, Version, URL, Whiteboard, and other fields will not be available in Phabricator, because we have decided to discontinue them. The related data available in Bugzilla reports will be added to the description of the task.» Users need documented workarounds to access the information in question, such as the translation between previous and future values that Aklapper implied in https://phabricator.wikimedia.org/T695#12650
I'm having issues trying to reconcile contradictory indications:
> Let's drop the string values of "severity" (and "whiteboard" seems also not to be in yet, looking at bugzilla_create.py) as plain text in the initial description.
(apparently done) vs.
> you could always query tasks in project X with the string "Severity: Critical"

What's the current status? Are we sure that users were actually able to understand how the imported tasks will look like as regards "Severity", even though the import was changed after the bugzilla preview? (Cf. T552 which declined the creation of a final preview.)

>>! In T695#13006, @Jdforrester-WMF wrote:
> Actually, those are indeed untriaged and should be marked as such. :-)

So, if the others are triaged, this leaves us with 568 triaged tickets which received a non-default severity. https://bugzilla.wikimedia.org/buglist.cgi?bug_severity=blocker&bug_severity=critical&bug_severity=major&bug_severity=minor&bug_severity=trivial&bug_severity=enhancement&list_id=359859&priority=Immediate&priority=Highest&priority=High&priority=Normal&priority=Low&priority=Lowest&product=OOjs&product=OOjs%20UI&product=VisualEditor&query_format=advanced&resolution=---
How is that triaging work being preserved?
>>! In T695#12650, @Aklapper wrote:
> [offtopic]
> 
> In T695#12014, @Jdforrester-WMF wrote:
>> I'm not particularly keen to re-triage 2,000 bugs in VE/OOUI/wikitext editor and others…
> 
> I would recommend at some point rather sooner than later to (mass-)prioritize those open VE tickets in Bugzilla with Priority=Unprioritized even if that would only be a rough categorization (e.g. set Priority=lowest for open tickets with Priority=unprioritized && Severity=enh|trivial|minor and Priority=low for Priority=unprioritized && Severity=normal|major or whatever works). Otherwise you will end up with a large list of "Needs triage" tickets after the Phab migration. Also note that Target Milestones will be migrated which offers another way to plan.

Actually, those are indeed untriaged and should be marked as such. :-)
Trust you and resolve it.  :)

>>! In T695#12822, @chasemp wrote:
> This is currently:
> 
> {F368}

Good!

> What to do w/ this ticket now?

Trust you and resolve it.  :)
This is currently:

{F368}


What to do w/ this ticket now?
[offtopic]

In T695#12014, @Jdforrester-WMF wrote:
> I'm not particularly keen to re-triage 2,000 bugs in VE/OOUI/wikitext editor and others…

I would recommend at some point rather sooner than later to (mass-)prioritize those open VE tickets in Bugzilla with Priority=Unprioritized even if that would only be a rough categorization (e.g. set Priority=lowest for open tickets with Priority=unprioritized && Severity=enh|trivial|minor and Priority=low for Priority=unprioritized && Severity=normal|major or whatever works). Otherwise you will end up with a large list of "Needs triage" tickets after the Phab migration. Also note that Target Milestones will be migrated which offers another way to plan.
Good catch, sorry for the inconsistency. Let's drop the string values of "severity" (and "whiteboard" seems also not to be in yet, looking at bugzilla_create.py) as plain text in the initial description.

http://www.bugzilla.org/docs/4.4/en/html/api/Bugzilla/WebService/Bug.html#get

Clueless cargo cult patch in https://gerrit.wikimedia.org/r/#/c/167548/
What do you want t do with this information? If you want to search candidates for next sprints, and you want to use the Severity information to help you, you could always query tasks in project X with the string "Severity: Critical", and that should provide you the sample you are looking for.

I don't think workboards are the right tool for this task. Are you planning to have a VisualEditor workboard where each column corresponds to a severity level? Besides, Workboards are good to handle dozens of tasks anyway, not hundreds.
>>! In T695#12009, @Qgil wrote:
> The Severity field is gone for good (and yes, we can document better this fact). This task is simply about adding to the description the Severity value of the Bugzilla reports imported.

I understood that it would be replaced with project board prioritisation. If that's not going to be automatically filled in it's going to be a serious pain. I'm not particularly keen to re-triage 2,000 bugs in VE/OOUI/wikitext editor and others…
The Severity field is gone for good (and yes, we can document better this fact). This task is simply about adding to the description the Severity value of the Bugzilla reports imported.
Indeed, must not be dropped. See also https://phabricator.wikimedia.org/T102#11218
Hm, actually...

T102#1539 says:
> I would not migrate Severity as a custom field, but as a searchable text string in the task description.

However, {T259} says
> Severity: To be dropped, T102

and consequently, https://www.mediawiki.org/wiki/Phabricator/versus_Bugzilla#Bugzilla_data_migrated says 
> Severity - Not migrated

Considering that we agreed that the latter is the canonical reference, the script works as specified. However, I believe something got lost in the requirements? If we add "Hardware/OS" to the description, we might as well add Severity.
Currently these fields are being always printed in the bugzillapreview:

> URL: none
> Version: unspecified
> See Also: none
> Hardware/OS: unknown/unknown

See for instance https://bugzillapreview.wmflabs.org/T6408

If these fields contain just the defaults, they don't offer any information and are pure noise. Can we migrate these fields only when they have specific information (not the default)?

**DECISION**

Fields to always keep in the initial description of a Phab task, no matter what the value is set to:
* Version
* Severity
Fields to drop from the initial description of a Phab task only if set to default value "All":
* Platform/Hardware
* OS
Fields to drop from the initial description of a Phab task only if value is entirely empty:
* URL
* Whiteboard
* See Also
>>! In T694#779001, @Nemo_bis wrote:
> I'm still seeing "unspecified" though. https://phabricator.wikimedia.org/T54136

Consistent with the decision in the description:

> DECISION
>
> Fields to always keep in the initial description of a Phab task, no matter what the value is set to:
> 
> Version
> Severity
I'm still seeing "unspecified" though. https://phabricator.wikimedia.org/T54136
> I compared data of tickets https://bugzillapreview.wmflabs.org/T204 https://bugzillapreview.wmflabs.org/T716 https://bugzillapreview.wmflabs.org/T828 https://bugzillapreview.wmflabs.org/T939 https://bugzillapreview.wmflabs.org/T924 https://bugzillapreview.wmflabs.org/T941 with Bugzilla and all looks perfect to me. Great great great!

All 404 now, but thanks for fixing this, will make things much prettier.
I compared data of tickets https://bugzillapreview.wmflabs.org/T204 https://bugzillapreview.wmflabs.org/T716 https://bugzillapreview.wmflabs.org/T828 https://bugzillapreview.wmflabs.org/T939 https://bugzillapreview.wmflabs.org/T924 https://bugzillapreview.wmflabs.org/T941 with Bugzilla and all looks perfect to me. Great great great!

Leaving it to Chase to close this ticket as resolved.
Whoops, my thumb must have slipped on the bus.
>>! In T694#19030, @chasemp wrote:
> Fields not shown:
> 
> https://bugzillapreview.wmflabs.org/T11

Looks great. Thank you!
Fields not shown:

https://bugzillapreview.wmflabs.org/T11
Ignore my last comment; Chase already fixed this in https://git.wikimedia.org/commit/phabricator%2Ftools.git/a0822790ea39f53020ddfdc782e2577ba9ed4289

I think this can be closed, leaving that to Chase.
@chasemp: https://gerrit.wikimedia.org/r/#/c/170679/
To summarize the proposal that I can live with: 
* For "OS" and "hardware" fields, drop if the value is set to "All"
* for "URL", "Whiteboard", "See Also": Drop if field is entirely empty
> I would go so far as to say that the default values (even "Severity"=="normal") should just be dropped, since chances are, no human ever cared enough about it to change it.

Some triagers do, especially correcting by setting the hard to discover "enhancement" value. Severity information was explicitly requested in T695 hence I'd always keep it.

> What about keeping Version and Severity in all cases, and the rest only when there is a value different than the default?

I think I've gotten tired of discussing so I can live with that and what Quim proposes here. 
Wondering if "the values can be inferred by their absence" should be "documented" on https://www.mediawiki.org/wiki/Phabricator/versus_Bugzilla though.

More numbers for completeness, talking about 72760 tickets in Bugzilla:
* "Platform" (Hardware) field ever changed (!) to current default "All": [[ https://bugzilla.wikimedia.org/buglist.cgi?f1=rep_platform&o1=changedto&query_format=advanced&v1=All | 2524 tickets ]]
* "OS" field ever changed to current default "All": [[ https://bugzilla.wikimedia.org/buglist.cgi?f1=op_sys&o1=changedto&query_format=advanced&v1=All | 2502 tickets ]]
* In both cases I can imagine that many reporters religiously filled out all fields just describing which OS and Browser s/he used though totally irrelevant for the actually reported bug (and hence set back to default "All" when somebody cared about metadata)
* "Severity" field ever changed to current default "Normal": [[ https://bugzilla.wikimedia.org/buglist.cgi?f1=bug_severity&o1=changedto&query_format=advanced&v1=Normal | 2109 tickets ]]
* (Default) Values for "Version" are per product and not global, hence no simple numbers.
Concur with @RobLa-WMF.
>>! In T694#16896, @Dzahn wrote:
> a key without a value is not the same as a key that doesn't exist

Technically, correct.  Practically, *shrug*.  Look at this:
> URL: none
> Version: unspecified
> Severity: normal
> Whiteboard: none
> Hardware/OS: unknown/unknown
> See Also: none

Sure, the keys might exist, but it's academic.  I would go so far as to say that the default values (even "Severity"=="normal") should just be dropped, since chances are, no human ever cared enough about it to change it.  It's complete clutter, and in the case that someone really cares, the values can be inferred by their absence.
a key without a value is not the same as a key that doesn't exist
We are discussing two different types of Bugzilla fields which will be dropped as "text only" in the initial description of a Phab ticket imported from Bugzilla (as listed [[ https://www.mediawiki.org/wiki/Phabricator/versus_Bugzilla#Bugzilla_data_migrated | here ]]):

1) We have 4 dropdown fields with pre-defined values. By nature these fields must have one selected pre-defined value set: 
 * Version
 * Platform/Hardware
 * OS
 * Severity
2) We have 3 free-form text fields which can be entirely empty:
 * URL
 * Whiteboard
 * See Also

As a compromise between "correct and complete conversion of Bugzilla data" vs. "readability of initial descriptions" (I know my wording is oversimplifying): 
Can we agree on 
1) keeping dropdown fields with pre-defined values (as "Version: unspecified" or "OS: All" in Bugzilla could be considered information to transfer/preserve)
2) dropping completely empty free-form text fields from being listed in the initial description of a Phab task (as an empty Whiteboard or See Also field  in Bugzilla could be considered no information to transfer/preserve)
?
I agree with James.  Let's just not print the unused fields.
>>! In T694#14606, @chasemp wrote:
> In regards to the principle of progressive disclosure, this not a phabricator or migration issue.  
> 
> https://bugzilla.wikimedia.org/show_bug.cgi?id=68559 looks like this:
> 
> {F420}
> 
> phabricator looks like
> 
> {F422}
> 
> 
> Bugzilla chooses to display fields that have no set value, I assume because an unset field is not the same thing as //no data//.  The current approach is the least surprise approach as it most closely preserves the set of data, set and unset, in the original bug report.  Not liking it is fine, not wanting it shown on issues people are actively working on where the value of this data can be examined is fine.  It can be removed from any description, but the default migrated description would be missing valuable context without it.

I agree that Bugzilla is also crap at this. :-) However, we can and should do better.
Just for the records I don't have a strong opinion here and don't see an issue with 'empty' values being exposed (or not) in Phab's initial comment...
In regards to the principle of progressive disclosure, this not a phabricator or migration issue.  

https://bugzilla.wikimedia.org/show_bug.cgi?id=68559 looks like this:

{F420}

phabricator looks like

{F422}


Bugzilla chooses to display fields that have no set value, I assume because an unset field is not the same thing as //no data//.  The current approach is the least surprise approach as it most closely preserves the set of data, set and unset, in the original bug report.  Not liking it is fine, not wanting it shown on issues people are actively working on where the value of this data can be examined is fine.  It can be removed from any description, but the default migrated description would be missing valuable context without it.
>>! In T694#14544, @Qgil wrote:
> One possibility could be: based on the proof of concept that bugzillapreview is, we trust the script, and we will instruct it not to print the unnecessary fields.

So far I've seen no issues at all in the import in terms of missing content, so this seems sensible.
One possibility could be: based on the proof of concept that bugzillapreview is, we trust the script, and we will instruct it not to print the unnecessary fields.
>>! In T694#12394, @chasemp wrote:
> We looked at this and decided it is more confusing to have different fields per ticket as it begs the question did this just fail in migration or is it truly not set?  Since descriptions can be cleaned up easily anywhere people do not like this in regards to an active task I am going to mark this as declined.

Although I can understand that decision in the context of the migration, I think it's a huge mistake. This violates the principle of progressive disclosure, and so increases the confusion for non-expert and new members when they're reading each task imported from a Bugzilla bug — tasks which will be around for years to come. Instead, they will all need to be manually updated to remove this cruft. This doesn't feel very respectful of people's time.
Reopening this task only to make sure that people see it before creating a duplicate.

By the way, even if I reported this task, I fully agree with the decision. Makes sense.
We looked at this and decided it is more confusing to have different fields per ticket as it begs the question did this just fail in migration or is it truly not set?  Since descriptions can be cleaned up easily anywhere people do not like this in regards to an active task I am going to mark this as declined.
//importing issue status//
**greg** wrote on `2014-09-07 21:15:42 (UTC)`

Copy/pasted to https://www.mediawiki.org/wiki/Wikimedia_Release_Engineering_Team/Second_Beta_Cluster for historical purposes.
**cmcmahon** wrote on `2014-09-05 21:38:54 (UTC)`

I think this essay answers the task
**Proposed statuses:**

| **Status name in Phab** | **Explanation** | **Resembling in Bugzilla** |
| open | Default state | {UNCONFIRMED, NEW, ASSIGNED, REOPENED, PATCH_TO_REVIEW*} {} |
| stalled | Stalled |  |
| resolved | A change that fixes the task has been merged. | {RESOLVED, VERIFIED, CLOSED} FIXED |
| invalid | This is not a task, or it is out of scope in Wikimedia Phabricator. | {RESOLVED, VERIFIED, CLOSED} INVALID |
| declined | Bad idea, can not be reproduced, missing information has not been provided, or an acceptable alternative exists. | {RESOLVED, VERIFIED, CLOSED} {WONTFIX, LATER, WORKSFORME} |
| //(marked as duplicate)// | | RESOLVED DUPLICATE |

*For PATCH_TO_REVIEW, create a project and add it to Phab tasks. See T169.

---
---
For historical reasons: Initial task description:

By default, Phabricator offers OPEN, RESOLVED, WONTFIX, INVALID as statuses (and we can resolve tasks as duplicates).
Custom statuses can be added via /config/edit/maniphest.statuses/

Subtasks I see here:
 * Bugzilla also offers WORKSFORME (CANNOT_REPRODUCE). DO we want this?
 * NEEDINFO/NEEDS_MORE_INFO: marking an item as not actionable is a recurring request for Bugzilla, see https://bugzilla.wikimedia.org/show_bug.cgi?id=36064
 * INVALID sounds harsh so we might want to bikeshed on a better wording.
Stalled, then. Moving on. Thanks!
FWIW I would just go w/ stalled.  We already use it in one of the originating import system cases, and if it is truly an issue we can revisit at a later date.
"Paused" is an alternative, sometimes appropriate, other times it's not: "Paused" feels more voluntarily put in waiting than "Stalled" does. But sometimes that's exactly what we want/mean.

I don't particularly care that much, and I don't want to get into bikeshedding over this. All of this is better than the more specific "Needs info" IMHO.
The (small) problem I see with "Stalled" is that it is a bit of an idiom that might confuse our international and/or non-tech userbase.

A synonym of Stalled that would rhyme with Resolved, and Declined is "Paused". The more I see it, the better I prefer it over "Waiting". What do you think?

Whatever it is, will be decided latest by our meeting on Monday.  :)
In my brain "Needs info" vaguely translates to "blocked on somebody or something" which is close enough to "Stalled" or "Waiting". Both works for me.

We need to document that well, otherwise people might come up with interpretations like "I'm waiting for a developer to take a look at this and fix this!!!" or such. ;)
I agree that "Needs Info" can be renamed to something more generic. Also, we put a lot of effort trying to reduce the number of options for Status and other selectors compared to Bugzilla, and this is why you can feel my resistance to add a new status. Nothing against RT practices personally.

So what about "Waiting". This would mark tasks as "Open, Waiting", showing clearly that even if the task is assigned and has "Unbreak Now!" priority (hypothetical extreme case", the owner explicitly cannot do anything but wait for another event. Then we can define the reason for the wait via tags or workboard columns, tbd and in the ways that works better for every team.

@aklapper, does this work for you?
Hmm, maybe, we can experiment with it.

I do think that "Needs Info" is a rather specific case of a status for a ticket which can't progress, wouldn't it be better to use something more generic (like stalled)?
Have you considered using column workboards for these specific conditions? Then the label of the column appears in the description of the task. Like here, above, you can see "(Need Discussion)" now, you would have al the flexibility to decide other conditions your tasks are stuck on i.e. "Stalled".

Also for what is worth, I have been thinking about proposing tags like "2015-03" to denote tasks that need to be acted upon at a certain point in the future, but not now.
In RT we actually use "Stalled" sometimes, with meaning which is quite different from "Needs Info". Needs Info implies we're waiting on someone to provide info to be able to make progress with a bug.

"Stalled" for us can mean things like:

- Waiting on a 3rd party to do/implement/deliver something (vendor or whatever)
It's not really "needs info", it's also not blocked on a task we can resolve ourselves, but we can't make progress on this task either

or
- We're going to do this, we keep track of it, but the right time (or some other precondition) for it hasn't come yet
For example, "decommission server X at date Y." Of course, in some such cases, being able to list the precondition (such as a defer date) in ticket metadata would be even better.

Since "Stalled" is more generic than "Info" and can be used for a wider variety of things, we'd still like to have this status available for our projects...
This one is implemented as well. Sorry for the noise.
//importing issue status//
**aklapper** wrote on `2014-08-18 21:20:42 (UTC)`

Re last comment: We renamed some statuses in this fab.wmflabs.org instance to "implement"/reflect the decisions made in T359, and we realized that when a status (in this case the previously existing WONTFIX) goes away, Phab resets a task's status to unknown. Next time we know better, and I fixed that manually now to not run into inconsistencies for T336.
**qgil** wrote on `2014-08-18 21:16:06 (UTC)`

Currently we can see messages talking about tasks moving `from "Unknown Status" to "Declined"`. See for instance at the end of T432. What is this "Unknown Status"? Looks like it's "Open", although maybe there is another factor in play.
**qgil** wrote on `2014-08-15 11:45:56 (UTC)`

Great! 

Task completed? I volunteer documenting this in https://www.mediawiki.org/wiki/Phabricator/Help
**Rush** wrote on `2014-08-14 19:57:33 (UTC)`

tinker...tinker...tinker...I got it to work I think.

I updated the values on this install to match what i have for prod.  this install is kinda of a pain since everthing is a one-off and I can't just use the same config.

anyhoo -- check it out.
**qgil** wrote on `2014-08-14 12:00:39 (UTC)`

Ooops, sorry for resolving accidentally.
**qgil** wrote on `2014-08-14 12:00:11 (UTC)`

Maybe this refers to the value, being different to the string shown in the UI? This instance is showing "Resolved", "Wontfix", "Invalid" in upper case.

If this is the case, we could have "needsinfo" as value and "Needs Info" as UI string.
**Rush** wrote on `2014-08-13 20:13:01 (UTC)`

trying just "stalled" as a needs info alternative
**Rush** wrote on `2014-08-13 20:12:41 (UTC)`

ran into a problem here:

needs_info is a not a valid possible status

%%%[Core Exception/Exception] Key "needs_info" is not a valid status constant. Status constants must be 1-12 characters long and contain only lowercase letters (a-z) and digits (0-9). For example, "open" or "closed" are reasonable choices.%%%
**Nemo_bis** wrote on `2014-07-25 19:01:48 (UTC)`

>>! In T359#73, @aklapper wrote:
> I'd STILL appreciate if no wrong data was entered. ;) Fixed.

After http://fab.wmflabs.org/transactions/detail/PHID-XACT-TASK-xukns75c3p24el7/ it's ok; I have merely copied the official descriptions from mediawiki.org, UNCONFIRMED and REOPENED are practically equivalent now so they should be in the same group.
**aklapper** wrote on `2014-07-24 12:31:01 (UTC)`

I assume good faith when editing the description, but I'd STILL appreciate if no wrong data was entered. ;) Fixed.
**qgil** wrote on `2014-07-24 11:32:59 (UTC)`

James, I think the statuses and their descriptions listed at the top of this task satisfy your concerns. I agree that we cannot just delete all what is marked Invalid. In fact, Phabricator doesn't bring any need to change the current policy for deleting reports in Bugzilla.

>>! In T359#63, @jdforrester wrote:
> * "truly invalid" – spam reports

These will indeed be unpublished/deleted as soon as they are detected. Maybe we can have a "Spam" project in order to allow users to report spam. Then the right team with the right permissions can unpublish them.

> * "misplaced" – things filed in Bugzilla which aren't dealt with in Bugzilla
> * "overtaken by changes" – things asking for changes that made sense at the time but don't now

"This is not a task, or it is out of scope in Wikimedia Phabricator." Clearly "Invalid". Will stay.

> * "mistaken" – things which are this way by design (more often labelled WONTFIX).

"Bad idea, cannot be reproduced, missing information has not been provided, or an acceptable alternative exists." Clearly Declined. Will stay.
**qgil** wrote on `2014-07-24 11:17:36 (UTC)`

True! I was looking at the general advanced search instead of Maniphests' advanced search. Problem solved, then.
**aklapper** wrote on `2014-07-24 11:14:45 (UTC)`

>>! In T359#67, @Nemo_bis wrote:
>> (marked as duplicate)
> 
> Can this status be searched?

See "Status" section on http://fab.wmflabs.org/maniphest/query/advanced/ - there is an explicit "Duplicate" checkbox.
**qgil** wrote on `2014-07-24 10:37:59 (UTC)`

The status that appears at the top of merged tasks is "Closed, Duplicate", so it should be as searchable (or not, see below) as the rest of statuses.

As far as I can see, users can only search tasks by status Open/Closed. At least I can't see a checkbox for the different Closed statuses at the Advanced Search. Querying "Merged into" will get you pretty close ([[ https://secure.phabricator.com/search/query/HY2OHkK_zrvW/ | I hope this URL works ]]).
**Nemo_bis** wrote on `2014-07-24 01:02:24 (UTC)`

> (marked as duplicate)

Can this status be searched?
**jdforrester** wrote on `2014-07-23 16:14:19 (UTC)`

>>! In T359#45, @qgil wrote:
> |invalid| no historical value will be purged eventually (spam, etc)

This is a pretty big change in semantics – right now, INVALID and WONTFIX are used to distinguish between different shades of declines. I'd roughly categorise them as:

* "truly invalid" – spam reports
* "misplaced" – things filed in Bugzilla which aren't dealt with in Bugzilla
* "overtaken by changes" – things asking for changes that made sense at the time but don't now
* "mistaken" – things which are this way by design (more often labelled WONTFIX).

We'll need to make sure people are careful not to use "invalid" the way they've been using INVALID. Maybe purging isn't the best idea
**greg** wrote on `2014-07-17 23:13:16 (UTC)`

>>! In T359#58, @scfc wrote:
> A recurring problem in Bugzilla with PATCH_TO_REVIEW as a status is that, as it is used as a flag, when a patch is merged/abandoned, one has to go through all the comments to see if this was the only patch to have triggered setting the flag in the first place (and if it previously was UNCONFIRMED, NEW or ASSIGNED).  A Phabricator replacement should take into account that there is a n:m relationship between bugs and patches and ensure that the UI provides a clear picture of the existence of open patches.

In phase 1 (ie: after we've only transitioned Bugzilla to Phab, not Gerrit), that's out of scope.

For phase 2 (ie: after we've also transitioned Gerrit), that will be implicit in that fact that we use Phabricator :)

You can see a good example of what that looks like on the upstream Phabricator instance where a Task has many Diffs associated with it, and you can quickly see how many are merged/open: https://secure.phabricator.com/T2772
**scfc** wrote on `2014-07-17 22:55:59 (UTC)`

A recurring problem in Bugzilla with PATCH_TO_REVIEW as a status is that, as it is used as a flag, when a patch is merged/abandoned, one has to go through all the comments to see if this was the only patch to have triggered setting the flag in the first place (and if it previously was UNCONFIRMED, NEW or ASSIGNED).  A Phabricator replacement should take into account that there is a n:m relationship between bugs and patches and ensure that the UI provides a clear picture of the existence of open patches.
**Rush** wrote on `2014-07-17 17:01:14 (UTC)`

@greg...I will forgo my speech on projects and organization :D

But really it's that all projects function as tags at the basic level.  So we make a patch_to_review project and add and remove as appropriate for filtering.
**greg** wrote on `2014-07-17 16:31:00 (UTC)`

>>! In T359#55, @Rush wrote:
> @greg, would it work for you if there was an automated tag for issues in this state for now instead?
> 
> so you could go do phab.wm.com/tag/patch_to_review and see all tasks in this status.
> 
> That way we don't end up with an unused ticket status in the future, and since it's automated we can ensure consistency.

For me, yeah, probably. How are tags added/removed? I can't seem to find it in "Edit task"
**Rush** wrote on `2014-07-17 14:48:37 (UTC)`

@greg, would it work for you if there was an automated tag for issues in this state for now instead?

so you could go do phab.wm.com/tag/patch_to_review and see all tasks in this status.

That way we don't end up with an unused ticket status in the future, and since it's automated we can ensure consistency.
**greg** wrote on `2014-07-16 23:33:21 (UTC)`

>>! In T359#52, @qgil wrote:
> Bugzilla has so many ASSIGNED reports where it is not true that "someone is actively working on this, check the assignee field for who".

fwiw: I actively use that as a means to track work my team is doing. Some other projects/components don't have people tending the garden actively.
**Rush** wrote on `2014-07-16 18:53:44 (UTC)`

so seems like we can mimic this gerrit bot that notifies bugzilla with phab, but without a PATCH_TO_REVIEW  status that step would be replaced by another comment linking to the merged patch?
**qgil** wrote on `2014-07-16 18:46:35 (UTC)`

Bugzilla has so many ASSIGNED reports where it is not true that "someone is actively working on this, check the assignee field for who".

I'd rather have us rely on Open + Assigned To + workboard OR the assignee commenting about their intentions (so nobody else steps on their toes).
**greg** wrote on `2014-07-16 17:24:13 (UTC)`

>>! In T359#50, @aklapper wrote:
>> "someone is actively working on this, check the assignee field for who"
> 
> That's what workboards are for, IMHO?

If the task is in one and only one project, and that project uses workboards (not all will), sure. But if there's any deviation from that, no, not really.
**aklapper** wrote on `2014-07-16 17:13:05 (UTC)`

> The PATCH_TO_REVIEW status in BZ is a hack, I believe,

Yes, it's done by https://gerrit-review.googlesource.com/#/admin/projects/plugins/its-bugzilla set up by qchris and setting up a status looked like the most visible way (in additional to the comment created by that plugin). See http://lists.wikimedia.org/pipermail/wikitech-l/2012-December/065046.html and https://gerrit.wikimedia.org/r/#/c/69843/ for historical data.

> "someone is actively working on this, check the assignee field for who"

That's what workboards are for, IMHO?
**greg** wrote on `2014-07-16 16:53:22 (UTC)`

>>! In T359#48, @Rush wrote:
> @aklapper can you help me understand more about what you mean by gerrit patch notifications?
> 
> I know there is some interaction between bugzilla and gerrit, but haven't used it myself.  

Basically, since there is no tight integration between Gerrit and BZ, all we have is a bot that comments on BZ bugs when there's a new related patch, eg https://bugzilla.wikimedia.org/show_bug.cgi?id=67270#c26 and when said patch is merged eg https://bugzilla.wikimedia.org/show_bug.cgi?id=67270#c27 (and similar message for abandoned). When it comments that there's a related patch, it also changes the STATUS to PATCH_TO_REVIEW.

You get the fancy behavior by including "Bug: 12345" at the bottom of the change commit message (right before the change-id gerrit needs at the very bottom).

I personally think there should be an "in-progress" or whatever status as well, that says "someone is actively working on this, check the assignee field for who". The Gerrit bot could set that status when it has a related patch. (We basically use "ASSIGNED" in BZ for that now.)

The PATCH_TO_REVIEW status in BZ is a hack, I believe, because BZ doesn't have a nice way of querying bugs that have linked Gerrit commits associated with a bug. ie: the issue that will be solved when we also transition code review to Phab from Gerrit.
**Rush** wrote on `2014-07-16 15:25:24 (UTC)`

@aklapper can you help me understand more about what you mean by gerrit patch notifications?

I know there is some interaction between bugzilla and gerrit, but haven't used it myself.
**qgil** wrote on `2014-07-16 15:01:29 (UTC)`

Since those Gerrit patch notifications are created by a bot, here we could apply the idea of Open + project "Patches For Review".

The same bot could remove that project if the patch is merged/abandoned.
**aklapper** wrote on `2014-07-16 13:28:23 (UTC)`

Assuming that "Declined" covers both "sorry but we really could not reproduce" and "we are against fixing it", this is probably the smallest set of statuses one could come up with. Thank you Quim. :)

One aspect left: **Gerrit patch notifications** in Phab in T277 (as long as we have not killed Gerrit in T42): I have no idea yet if or how we want to implement the behavior of the "Patch to review" status in Bugzilla. Another status, temporarily until we've fixed T42? (as I have a hard time to imagine notifications triggering changes to a column in a project's workboard, as the naming scheme of columns in per project)
**qgil** wrote on `2014-07-16 10:38:30 (UTC)`

Ok, we can forget about tag-projects for Day one (and therefore the migration). They can always be added to the process at a later stage if somebody misses them or has a better idea of what to do with them.

I agree that Unreproducible is a variant of Needs Info.

>>! In T359#43, @Rush wrote:
|open| default state
|needs_info| stalled
|resolved| closed
|invalid| no historical value will be purged eventually (spam, etc)
|declined|we have decided not too -- even though we could

I agree with these statuses; descriptions to be fine tuned.
**Rush** wrote on `2014-07-15 20:01:46 (UTC)`

andre as usual you come up with good stuff.

@qgil...I really liked your thoughts, over the evening yesterday tho I became less convinced people would actually do it :)  I think it's a really cool idea within domains for people to utilize, ops could do this for their own stuff, andre could do it too.  Anyone who can ensure their own consistency it would work out for, but I don't feel like the 
workflow of a task lends itself to the status+project combo being a good default mindset sort for the big 3 or 4 or even 5 cases.  

I think the real difference tho is I don't view invalid as a subset of declined.  I do look at declined tasks as having value in a historical sense, and invalid tasks are really waiting to be purged out when they become cumbersome enough.

I don't see a difference between unreproducible and declined.  Do we not decline as unreproducible?  But in general, if it's a broad enough brush to be it's own bucket.  Fine with me.

I also think, unreproducible could be a form of needs_info.  that probably makes the most sense to me.

Needs triage is a priority right?  Not a status.

needs_info seems kind of odd, why not the suggested [incomplete]

That means the status's would be something like:

|open| default state
|needs_info| stalled
|resolved| closed
|invalid| no historical value will be purged eventually (spam, etc)
|declined|we have decided not too -- even though we could

-> 

|unreproducible| needs more info to reproduce?  should be merged with needs_info?


invalid and declined here are also taking the place of reject which exists in rt.  we do get spam there as well.  

Also, really liking andre's 'resembling' identities for the categories.
**qgil** wrote on `2014-07-14 17:01:42 (UTC)`

>>! In T359#40, @Rush wrote:
> are you suggesting a literal "out of scope" project that tasks are added to for this? or that there is a ticket state for which the option would be "declined - out of project scope'.

The former, but using the project just as a tag. Those tasks will be declined. We can forget about them. No team, sprint, dashboard, etc, will be assigned to those. You can always make elaborate queries if you need them: which tasks were "Declined" (Status) as "Out Of Scope" (tag-project) in "Visual Editor" (project-project)?

> Work-for-me is a terrible state for a ticket to be in as it doesn't mean anything.

Following the proposal above, the migration script should convert Bugzilla's WORKSFORME reports in Declined + project "Non Reproducible" tasks. In Bugzilla WORKSFORME sometimes is used as "what you see as a bug is correct behavior in my eyes", which is different than "Non Reproducible". I would still apply the same rule and leave the old bugs Rest In Peace.

> resolved fixed is less good than resolved closed

For the sake of the migration skip, I would treat both as equal.

> The only thing I feel is a strong point is that invalid is a distinct state for a ticket to be in outside of normal resolution, and it is important to distinguish between this isn't possible and we are not doing this

Declined + project "Invalid" for the migration? No matter what, they are still declined tasks. I just want to avoid if possible to have an option in the Status that will not be used in the 92% of cases (if we have to trust Bugzilla stats). Besides, if we dig deeper in the current INVALID reports we will find different reasons to reach to that resolution, including out of scope, spam, poorly written, and more. 

Having one "Declined" resolution and specific tag projects allow us to be (optionally) more precise without cluttering the Status field.
**qgil** wrote on `2014-07-14 15:13:43 (UTC)`

@Rush was faster than me. I was also about to say that workboards offer all the degrees you need between Open and Resolved.
**Rush** wrote on `2014-07-14 15:03:38 (UTC)`

could verified be a workboard status rather than a full on issue status?  

some of the team specific workflow can be handled at the alternative abstraction layer I think
**aklapper** wrote on `2014-07-14 14:26:09 (UTC)`

Hmm, same VERIFIED question goes to the VE team, actually (@jdforrester).

<Lydia_WMDE> we do use it for basically acceptance confirmation. ie ideally dev sets it to resolved fixed and then i go and set it to verified. doesn't entirely work atm though
<andre> the question is probably "what would you lose if it wasn't available anymore". Plus VE and Wikidata seem to be the only teams using VERIFIED.
<Lydia_WMDE> we would lose a second stage of review/confirmation.
<Lydia_WMDE> so i can live without it but i think we should have it
<andre> does anybody ever query for VERIFIED specifically (or excluding that from RESOLVED tickets)? What if this was just added as a comment instead?
<Lydia_WMDE> i query for all resolved fixed ones to go through them and verify
<andre> so if you could query for resolved tickets and exclude those which have a "has been verified" comment, would that also work? :D
<Lydia_WMDE> doesn't feel very nice/clean
<andre__> I'm wondering if adding a "Wikidata verified" (or so) project instead might work. Need to think about it.
**aklapper** wrote on `2014-07-14 14:16:53 (UTC)`

VERIFIED status in Bugzilla is being used by the Wikidata team - wondering how important it is to them in their development workflow, and if they could live without it for the sake of keeping it simple and stupid. I've pinged Lydia on IRC as I couldn't find an account here.
**qgil** wrote on `2014-07-14 12:43:56 (UTC)`

@parent5446, if I'm not mistaken, in Bugzilla reports are by default UNCONFIRMED until some action makes them NEW. The equivalent default status in Phabricator is Open + Needs Triage. "Needs Info" is a status that must be set manually, therefore it cannot be the default for all new tasks.

@aklapper, adding projects to declined tasks should be optional, and done when such projects help the task and the reporter somehow. Also, adding one tag-project can save you the work of typing a manual comment.

If "should be fixed in upstream" means "we won't work on it", then it can be Declined + project Upstream, and additionally we could even add a project for the specific upstream e.g. "Elasticsearch" if that helps us tracking tasks. We can also have tasks that must be fixed upstream, but our maintainers are planning to work on them, as it is the case already now here with certain Phabricator tasks.
**aklapper** wrote on `2014-07-14 11:30:27 (UTC)`

@qgil: Thanks, this looks really really good indeed (though I wonder a little bit with regard to workflow how tedious it'll be to change task status to Declined plus also add a "Out Of Scope" / "Non reproducible" project to that task). I guess that "Out of scope" would also cover "should be fixed in upstream" as it's "not our bug".
**parent5446** wrote on `2014-07-11 14:19:18 (UTC)`

@qgil, that looks pretty good. There's just a small error in your mapping table. UNCONFIRMED should map to "Needs Info", since, like you mentioned earlier, triage has more to do with the maintainers deciding the priority rather than the bug needing more information.
**qgil** wrote on `2014-07-11 13:44:43 (UTC)`

Revisiting this topic, I think we can use better the possibilities of Phabricator that were limitations in Bugzilla, requiring all these different types of statuses.

What about this:

* Open 
* Needs Info
* Resolved 
* Declined + optional tag project

"Open" means that a task is actionable. The rest is defined by its current priority and details like having someone assigned to it, or visible activity in the form of mockups, patches...

"Needs Info" deserves an own status to raise attention. These tasks may be declined (automagically?) if no info is received after some period.

"Resolved" means that the task is considered completed.

"Declined" means that the maintainers are removing the task from the plate. Reasons will differ, but the end result is the same: reporters and other contributors must do some homework if they want to reactivate them. Project tags can be used optionally to catalog tasks that might interest someone. Think of projects like "Non Reproducible" or "Out Of Scope".

Bugzilla-Phabricator mapping:

| Bugzilla | Phabricator |
| ----- | ----- |
| UNCONFIRMED (default) | Open + Needs Triage (default) |
| NEW | Open |
| ASSIGNED | Open + Assigned To |
| PATCH_TO_REVIEW | Open + Code Revisions |
| NEED_INFO | Needs Info |
| RESOLVED FIXED | Resolved |
| RESOLVED INVALID | Declined |
| RESOLVED WONTFIX | Declined + project "Out Of Scope" |
| RESOLVED WORKSFORME | Declined + project "Non Reproducible" |
| RESOLVED DUPLICATE | (merged) |
**parent5446** wrote on `2014-07-10 17:35:20 (UTC)`

>>! In T359#21, @scfc wrote:
> This doesn't make sense to me.  In Bugzilla, INVALID is used when someone complains that "expr 2 + 2" doesn't output 5 (and it shouldn't), WORKSFORME when the complaint is that it doesn't output 4, but for the triager it does, and WONTFIX if someone wants "expr 2.1 + 1.9" to work, but the developers consider this outside the scope of expr.

Agreed with this. WONTFIX, WORKSFORME, and INVALID are all three different, distinct resolutions, each representing a different community consensus concerning the bug reported.

Also, keep in mind that in Bugzilla, all of those (as well as FIXED and DUPLICATE) are not separate statuses, but rather all kept under the umbrella of RESOLVED. In reality, Bugzilla only has five statuses: UNCONFIRMED, NEW, ASSIGNED, PATCH_TO_REVIEW, and RESOLVED (we don't really use VERIFIED, so I left it out). With that in mind, ASSIGNED is really unnecessary in both Bugzilla and Phabricator, and PATCH_TO_REVIEW also is not necessary in Phabricator.

That brings us down to just three statuses: UNCONFIRMED, NEW, and RESOLVED. If there was a way to sub-categorize statuses in Phabricator, that would make things a lot simpler. In the end, though, I think it is necessary to keep the various sub-categories of RESOLVED (there names could be changed; I don't care about the naming).
**greg** wrote on `2014-06-02 20:26:02 (UTC)`

>>! In T359#22, @avive wrote:
>>>! In T359#8, @greg wrote:
>> Boy do I wish we could have separate statuses per project per task (eg: Fixed in master but open in 1.23.0)
> 
> Workboards kinda-sorta-coulda support this:
> {F6450}

Interesting.... That's a hack, but yeah, that could do it.
**greg** wrote on `2014-06-02 20:25:20 (UTC)`

[removing not useful part of this comment]

Bugzilla is still officially canonical, for the record.
**aklapper** wrote on `2014-06-02 18:30:11 (UTC)`

CC'ing those top 10 bug closers listed on http://korma.wmflabs.org/browser/its.html who have an account here:

Are any specific thoughts on task/ticket statuses in Phabricator, based on your experience in Bugzilla?
**avive** wrote on `2014-05-31 20:40:59 (UTC)`

>>! In T359#8, @greg wrote:
> Boy do I wish we could have separate statuses per project per task (eg: Fixed in master but open in 1.23.0)

Workboards kinda-sorta-coulda support this:
{F6450}
**scfc** wrote on `2014-05-31 02:25:24 (UTC)`

>>! In T359#16, @qgil wrote:
> The problem with making "Needs Info" equivalent to "Needs triage" is that it is difficult to know who to blame. While "Needs triage" means that the ball is in the field of the triagers / maintainers, "Needs Info" shows that it is he reporter who need to do some homework.

"Need(s) info" (as a concept) isn't necessarily limited to the reporter.  It can also be used to indicate that input from ops, legal, design, etc. is needed.  In general, it should move a bug from the dashboard of the assignee to that of the designated person.

>>! In T359#12, @qgil wrote:
> What you are saying is that we can keep the current behavior, just changing the strings:

> * Open --> Open
> * Resolved --> Resolved
> * Wontfix --> Not a Bug
> * Invalid --> Needs Info
> [...]

This doesn't make sense to me.  In Bugzilla, INVALID is used when someone complains that "expr 2 + 2" doesn't output 5 (and it shouldn't), WORKSFORME when the complaint is that it doesn't output 4, but for the triager it does, and WONTFIX if someone wants "expr 2.1 + 1.9" to work, but the developers consider this outside the scope of expr.

Also, IMHO in general if Phabricator has a different (default) set of statuses, I would be very hesitant to change them without a very good reason as it will introduce another little unnecessary hurdle for contributors.
**swalling** wrote on `2014-05-30 21:18:28 (UTC)`

Think about the best, most beloved issue trackers currently in use (Trello, for instance). Then compare to Bugzilla, which everyone except random volunteers, Platform, and VisualEditor have pretty much abandoned as their canonical issue tracker. 

Trello and most other good trackers: only two states: archived/resolved or open.
Bugzilla: too many status, priority, target and other state options to bother counting. 

This should be indicative how you're overcomplicating things.
**jdforrester** wrote on `2014-05-30 21:02:13 (UTC)`

Steven – Please warn if you're forking the conversation so I don't have to respond in two places! :-)

I agree with Quim and disagree with Steven re. the appropriacy of not having a NEEDSINFO state in terms of user interaction.

I also disagree with Steven re. polluting the "RESOLVED" status space with bugs that are not resolved but instead weren't appropriate bugs for whatever reason (like problems with gadgets, configuration mistakes, or issues with a localisation string or whatever else is a problem not tracked in Phabricator).
**swalling** wrote on `2014-05-30 19:31:31 (UTC)`

>The problem with making "Needs Info" equivalent to "Needs triage" is that it is difficult to know who to blame. While >"Needs triage" means that the ball is in the field of the triagers / maintainers, "Needs Info" shows that it is he reporter >who need to do some homework

Someone needs to be responsible for shepherding a task forward. Adding complexity to the state of tasks doesn't really help. They need to just step up and manage the state of the task. This is why we have maintainers, product managers, bugmeister, and other people in these roles.
**qgil** wrote on `2014-05-30 19:25:02 (UTC)`

The problem with making "Needs Info" equivalent to "Needs triage" is that it is difficult to know who to blame. While "Needs triage" means that the ball is in the field of the triagers / maintainers, "Needs Info" shows that it is he reporter who need to do some homework.
**swalling** wrote on `2014-05-30 19:19:46 (UTC)`

We should strive for absolutely simplicity and as small a number of states as possible. The more choices we provide the more confusing things are for all users. My thoughts, also replicated on the Product list are thus...

> [Updated] proposed set from @jdforrester: 
>
>OPEN
>RESOLVED
>DECLINED (rather than WONTFIX)
>NOTABUG (rather than INVALID, also replacing WORKSFORME)
>NEEDSINFO (consistent with not using "_"s, INCOMPLETE sounds like it's about the task, not the request)

I don't think we need INVALID/NOTABUG or NEEDSINFO.

INVALID is required when Bugzilla has a "Resolved fixed" status. (If something is not a bug, you can't mark it as fixed.)  We just have a resolved state now, and an issue is resolved whether we fix it with a patch or if we investigate and it was never an issue to begin with. 

NEEDSINFO is just adding additional state complexity to Needs Triage. Either leave something in Needs Triage, or triage is as lowest possible priority, while requesting more info. If someone can't provide more info, then mark it as Resolved. 

Declined is definitely better than WONTFIX. I will keep thinking on options there, but would be comfortable using that language.
**qgil** wrote on `2014-05-30 19:04:51 (UTC)`

What you are saying is that we can keep the current behavior, just changing the strings:

* Open --> Open
* Resolved --> Resolved
* Wontfix --> Not a Bug
* Invalid --> Needs Info

> Boy do I wish we could have separate statuses per project per task (eg: Fixed in master but open in 1.23.0)

Remove the task from "MediaWiki" but keep it in "MediaWiki 1.23.0"?
**jdforrester** wrote on `2014-05-30 18:34:42 (UTC)`

[Updated] proposed set:

  - OPEN
  - RESOLVED
  - DECLINED (rather than WONTFIX)
  - NOTABUG (rather than INVALID, also replacing WORKSFORME)
  - NEEDSINFO (consistent with not using "_"s, INCOMPLETE sounds like it's about the task, not the request)

Will validate these with other Product people.

(Do we want to represent PATCH_FOR_REVIEW or DEPLOYED states somehow?)
**greg** wrote on `2014-05-30 15:58:06 (UTC)`

My suggestion for day 1:
* Open
* Not a bug (instead of "invalid")
* Incomplete (or Needs more info)
* Fixed

I don't find "works for me" useful. If anything, it should be called "works, period" aka "not a bug". The "for me" part bothers me.

I also find "won't fix" not useful. If it's not a bug, mark it as such. If it's way low priority, set the priority as such. Since we can have multiple projects in use by a team to track sprints and such, the product owner argument of "I want a clean backlog" doesn't apply.

Boy do I wish we could have separate statuses per project per task (eg: Fixed in master but open in 1.23.0)
I don't see a tracking of severity distinct from priority. Considering that priority has no universal meaning, but only a per-component meaning (at best), this seems very inappropriate for a disperse project like ours.
http://c2.com/cgi/wiki?DifferentiatePriorityAndSeverity

Moreover, the main use we make of "Priority" in bugzilla, i.e. how hard/expensive a bug is, is already covered by "Points".

----

**See also**: {T93499}
T109492 is rather unrelated to any "severity" (except for when you interpret new functionality or maintenance as always either less or more severe than the other one).
Giving up on the Severity field has caused all sorts of negative consequences, in my opinion. Perhaps this decision should be revised in light of new superstructure which is being added (partly) to compensate the lack of such information, like T109492.
As Priority was mentioned (though this is about Severity): Story points express estimated complexity and are not directly related to priority. I agree that priority is relative and that severity //in theory// has boundaries if well defined but I don't see a "change to this culture". I rather see an overcategorization via many many fields in Bugzilla that are only used by a small number of users hence I challenge the usefulness. One of the fields I consider pretty much useless is "Severity", explained above. In this ticket we discussed usecases for the severity field and didn't find many.
//importing issue status//
**aklapper** wrote on `2014-08-18 12:50:42 (UTC)`

No replies to last comment, hence assuming that searching for the terms "crash" or "NPE" (favorized by the mobile app developers) seems to be sufficient for the "critical severity" case.

Closing as DECLINED as we don't plan to copy the Severity field from Bugzilla to Maniphest.
**aklapper** wrote on `2014-08-10 19:50:00 (UTC)`

Remaining question: Is there interest in converting the "crasher" severity to a project/tag in Phabricator, similar to a keyword now in Bugzilla? Do people query explicitly for crashers in Bugzilla by querying for critival severity?
**mmodell** wrote on `2014-08-07 14:19:50 (UTC)`

Also, FWIW: Phabricator has task dependencies to express "blockers" in much more useful and informative way... "T1 blocks T2" is much more useful than "severity: blocker" - that just says it's blocking _something_ but what's blocked?
**jdforrester** wrote on `2014-07-29 22:14:35 (UTC)`

>>! In T168#60, @aklapper wrote:
>>>! In T168#57, @jdforrester wrote:
>> As a product manager, I need an orthogonal way to represent how major an issue/problem/improvement a task is for users, distinct from whatever priority I have currently given it ("priority") and how difficult it is for engineers to do ("points").
>> 
>> This is vital when considering which tasks should go in each sprint, and reconsidering longer-term prioritisation. It is particularly important for triaging tasks reported by users and others, to gauge which ones to triage first.
> 
> How often do tasks go into a sprint which have lower impact (minor or trivial, in current Bugzilla terms)?

All the time. Normally large-impact changes are intentionally rationed per release – both because there's often a strong correlation between size of impact and size of work, but also because we don't want to make too many large changes for users at once. Also, there's a need for balance for both scale and type of workload between individual team members, and within each engineer's workload.

> With regard to longer-term prioritisation: Would that mean it's more likely that you add tasks to a future sprint which had a lower priority but a higher impact/severity?

Yes, though I'd be likely (but not guaranteed) to raise the priority based on impact as well. In general, higher-priority items would be expected to be put into the sprint ahead of equivalent lower-priority ones.

> If so, I'd interpret that as using Severity/Impact to "subclassify" tasks sharing the same lower Priority, to bump Priority later based on Severity/Impact. It's a pattern that can also be observed in Eclipse Bugzilla (according to page 4 in http://herraiz.org/papers/english/msr84cp-herraiz.pdf ).

That's a possible analysis, though I think that it's used more as a signal rather than a raw sub-priority field.
**aklapper** wrote on `2014-07-29 22:02:35 (UTC)`

>>! In T168#57, @jdforrester wrote:
> As a product manager, I need an orthogonal way to represent how major an issue/problem/improvement a task is for users, distinct from whatever priority I have currently given it ("priority") and how difficult it is for engineers to do ("points").
> 
> This is vital when considering which tasks should go in each sprint, and reconsidering longer-term prioritisation. It is particularly important for triaging tasks reported by users and others, to gauge which ones to triage first.

How often do tasks go into a sprint which have lower impact (minor or trivial, in current Bugzilla terms)?

With regard to longer-term prioritisation: Would that mean it's more likely that you add tasks to a future sprint which had a lower priority but a higher impact/severity? If so, I'd interpret that as using Severity/Impact to "subclassify" tasks sharing the same lower Priority, to bump Priority later based on Severity/Impact. It's a pattern that can also be observed in Eclipse Bugzilla (according to page 4 in http://herraiz.org/papers/english/msr84cp-herraiz.pdf ).
**jdforrester** wrote on `2014-07-29 21:32:21 (UTC)`

I also completely disagree with @aklapper about getting rid of some measure of severity/impact, as already stated.

As a product manager, I need an orthogonal way to represent how major an issue/problem/improvement a task is for users, distinct from whatever priority I have currently given it ("priority") and how difficult it is for engineers to do ("points").

This is vital when considering which tasks should go in each sprint, and reconsidering longer-term prioritisation. It is particularly important for triaging tasks reported by users and others, to gauge which ones to triage first.
**aklapper** wrote on `2014-07-28 20:33:10 (UTC)`

I take the silence as people agreeing on my last comment. If not, please raise your voice before it's too late.
**mmodell** wrote on `2014-07-15 22:35:23 (UTC)`

Phabricator's tokens are a perfectly good way to represent "impact" - people can individually assign tokens to express the impact that a given bug is having on them and the tokens are prominently displayed on the task with representative icons. We just need to assign some meanings to the tokens, more explicitly than they currently have in the UI.
**Waldir** wrote on `2014-07-15 17:08:44 (UTC)`

>>! In T168#50, @qgil wrote:
> Do we really gain clarity by adding a parameter of "Severity"? A "Normal" problem annoying many people will get a "Medium" / "High" priority and will be schedule in a foreseeable sprint. A "Major" or even "Critical" problem around a corner case of the likes of "only in PostgreSQL" will in practice fall under "Needs Volunteer" no matter what.
> 
> In other words, maybe what happens is that "severity" is not as objective and informative as it sounds, and what really counts is how relevant it is for those who actually can complete a task.

After thinking about this some more, I'd say that "severity" is actually both objective and informative (it means essentially "how much this breaks things"). On the contrary, I'd argue that what's not objective is Bugzilla's "priority" (i.e. timing-priority, or "this needs to be done soon"). That should essentially be the final arbiter of what to do next, but it should be defined based on objective components, not as a subjective single-axis. Your comment goes to the core of this: the "how many people are annoyed by this" factor (i.e. "impact") is central to how we make decisions, yet it's nowhere represented in the systems we use.

So perhaps instead of a single, subjective "priority" measure, we should keep bugzilla's two-axis system, but replacing "priority" with "impact", with impact having a stronger weight in the priority calculation. That would solve the problems you point out: a low-severity, high-impact problem will have higher priority than a high-severity, low-impact one, which is what we already observe today. And an issue with a "blocker" severity could then be untackled for years without diluting the meaning of severity, because we're explicitly acknowledging it's a low-impact one.
**qgil** wrote on `2014-07-10 17:39:30 (UTC)`

Revisiting this discussion under the assumption that we would have these levels of Priority (see {T436}):

> * Needs Triage
> * Unbreak Now!
> * High
> * Medium
> * Needs Volunteer

Do we really gain clarity by adding a parameter of "Severity"? A "Normal" problem annoying many people will get a "Medium" / "High" priority and will be schedule in a foreseeable sprint. A "Major" or even "Critical" problem around a corner case of the likes of "only in PostgreSQL" will in practice fall under "Needs Volunteer" no matter what.

In other words, maybe what happens is that "severity" is not as objective and informative as it sounds, and what really counts is how relevant it is for those who actually can complete a task. I'd rather have a simple axis (Priority) driving what is scheduled in forthcoming sprints, and then community discussion and negotiation on whether e.g. a "Needs Volunteer" task will be taken by a team as "Medium", and from there to a sprint.

Otherwise we end up in situations where "critical" and "blocker" bugs [[ https://bugzilla.wikimedia.org/buglist.cgi?bug_severity=blocker&bug_severity=critical&chfield=%5BBug%20creation%5D&chfieldto=2y&list_id=328275&product=Cortado&product=Datasets&product=Huggle&product=Kate%27s%20Tools&product=Logwood&product=MediaWiki&product=MediaWiki%20extensions&product=MediaWiki%20skins&product=MediaWiki-Vagrant&product=MobileFrontend&product=mwEmbed&product=OOjs&product=OOjs%20UI&product=openZIM&product=Parsoid&product=Pywikibot&product=QRpedia&product=Spam&product=Tool%20Labs%20tools&product=Unofficial%20Apps&product=Utilities&product=VisualEditor&product=Wiki%20Loves%20Monuments&product=WikiLoves%20Monuments%20Mobile&product=Wikimedia&product=Wikimedia%20Labs&product=Wikimedia%20Mobile&product=Wikipedia%20App&product=Wiktionary%20tools&query_format=advanced&resolution=--- | sit around for years ]], diluting the meaning of those terms.
**swalling** wrote on `2014-07-02 20:16:52 (UTC)`

> Ok, then I rephrase my question: is there a document (or more) summarising what's the current expectation of their meaning for those who use them?

Points are used in the same way they're understood in other Agile contexts. If you're looking for documentation, all you need do is Google around. 

TL;DR summary: You assign points to a task to estimate the time and effort involved in a task. You can then track how many points you completed over a given sprint (i.e. a two week period), and adjust expectations about the team's capacity in the next sprint. In other words, it helps you more accurately guess how much you can reasonably get done.
**Nemo_bis** wrote on `2014-07-02 20:08:33 (UTC)`

> I think we should feel free to innovate.

For instance by removing this field: I agree with comment #44

> the two teams that use them have repeatedly said they are a critical day-0 blocker for them.

Ok, then I rephrase my question: is there a document (or more) summarising what's the current expectation of their meaning for those who use them?
**jdforrester** wrote on `2014-06-30 19:46:13 (UTC)`

>>! In T168#46, @Waldir wrote:
> Merging //target milestone// and //(timing) priority// sounds like a good idea in combination with the above, since it'd provide a concrete, straightforward way to define urgency.

I completely and absolutely disagree. "Milestone" is something like "Alpha release 244: 2014-06-30" or "1.23", and is used for short-term planning (what are we working on this week?) and retrospective listing (what did we work on in week x?). It's not a long-term planning thing at all, and trying to merge the priority concept with a short-term planning framework is doomed to failure.
**Waldir** wrote on `2014-06-25 19:49:40 (UTC)`

My two cents: I've been thinking a lot recently about how to define task priorities (in general) in an objective way. I looked at [bugzilla's model](https://www.mediawiki.org/wiki/Bugzilla/Fields#Importance) for inspiration, and found the terms used (importance, priority and severity) to be somewhat vague. Thinking of "priority" as "urgency", and of "severity" as "impact", allowed me to grasp their meaning (and how they relate to each other) more intuitively.

Granted, "severity" is good enough a term, but "impact" is more common and can stand for both positive and negative impact, while severity is mostly negative thing. "Priority" definitely feels more objective when defined as "urgency". "Priority" and "importance" (and "points") are terms that should be avoided, IMO, since their meaning is not universal.

Essentially, I agree with what @aklapper said in T168#14, except that I'd use the terms **urgency**, **impact** and **effort**, to mean "timing-priority", "importance-priority" and "difficulty-priority". Merging //target milestone// and //(timing) priority// sounds like a good idea in combination with the above, since it'd provide a concrete, straightforward way to define urgency. Impact can be defined in terms of how many people are affected, and how often (e.g. readers/editors/admins, vs. on every page view/only on a specific subset of pages/only when using parameters x and y). Effort can be just a rough estimate of hours needed to code up the required change (anything too big to be estimated should become a tracking issue anyway).
**jdforrester** wrote on `2014-06-16 18:59:59 (UTC)`

>>! In T168#44, @qgil wrote:
>>>! In T168#43, @jdforrester wrote:
>> "Most" people at WMF Engineering don't use points; I'd imagine that third party and volunteer developers have even less reason to  have particular expectations of their use in the MediaWiki world, so I think we should feel free to innovate.
> 
> Or we could just remove them until we find a good use for them. This is a custom field that someone added, not a Phabricator feature out of the box.

"Most" !== all; the two teams that use them have repeatedly said they are a critical day-0 blocker for them.
**qgil** wrote on `2014-06-16 18:39:23 (UTC)`

>>! In T168#43, @jdforrester wrote:
> "Most" people at WMF Engineering don't use points; I'd imagine that third party and volunteer developers have even less reason to  have particular expectations of their use in the MediaWiki world, so I think we should feel free to innovate.

Or we could just remove them until we find a good use for them. This is a custom field that someone added, not a Phabricator feature out of the box.
**jdforrester** wrote on `2014-06-16 18:24:58 (UTC)`

>>! In T168#42, @Nemo_bis wrote:
>> data on severity into the "points" field in some fashion (Blocker -> 13, Critical -> 8, Major -> 5, … or whatever).
> 
> This doesn't fit my (very limited) understanding of what agile points are. Is there a good concise document summarising what's the current expectation of their meaning for most people in Wikimedia/MediaWiki?

"Most" people at WMF Engineering don't use points; I'd imagine that third party and volunteer developers have even less reason to  have particular expectations of their use in the MediaWiki world, so I think we should feel free to innovate.
**Nemo_bis** wrote on `2014-06-15 09:29:26 (UTC)`

> Priority and severity fields are just too fine-grained to be useful in seriously prioritizing tasks.

I agree on this, but mostly because the recent addition of "Highest", "Immediate" and "Lowest" is disputable.

> data on severity into the "points" field in some fashion (Blocker -> 13, Critical -> 8, Major -> 5, … or whatever).

This doesn't fit my (very limited) understanding of what agile points are. Is there a good concise document summarising what's the current expectation of their meaning for most people in Wikimedia/MediaWiki?
**aklapper** wrote on `2014-06-02 13:02:14 (UTC)`

> I don't think a severity field per se is a useful addition,

+1.

> and instead we should probably import the data on severity into the "points" field in some fashion (Blocker -> 13, Critical -> 8, Major -> 5, … or whatever).

So in Phab we'd have priority, points, and columns to express 'things'.

For general understanding and refering to the Severity field values in Bugzilla: Currently a bug report in Bugzilla about a crasher is critical by definition, but would be low priority if circumstances to reproduce required special rights in some rather uncommon volunteer-supported database backend (or such; to come up with one vague example). 
Bugzilla's //critical// severity could also be expressed by a //crash// project or so; //enhancement// is already expressed via priority (instead of severity) in Phabricator. Bugzilla severities like //trivial// or //minor// don't make sense (a trivial typo could still trigger a critical crasher) and feel like sufficiently expressed by Bugzilla's //easy// keyword which would end up as another project in Phabricator.
**jdforrester** wrote on `2014-05-30 21:08:00 (UTC)`

>>! In T168#36, @swalling wrote:
> I'd //really really// like to try leaving the Phabricator defaults alone in terms of priority. When prioritizing Growth's last sprint in Phabricator, I found the list of current values to be very useful. Any tinkering we do is kind of bikeshedding here, IMO.

I agree. I don't think a severity field //per se// is a useful addition, and instead we should probably import the data on severity into the "points" field in some fashion (Blocker -> 13, Critical -> 8, Major -> 5, … or whatever).


> One of the great problems of Bugzilla is that there is just too much bullshit to deal with. Priority //and// severity fields are just too fine-grained to be useful in seriously prioritizing tasks. The same goes for Target Milestone etc... almost zero people seriously use these fields or rely on them now. 

Remember that the milestones will be replaced by (sub)projects, which will be used to recording sprint activity. I'm assuming you //do// want to continue having sprints in Growth? Certainly, other teams are going to. :-)
**jdforrester** wrote on `2014-05-30 21:05:04 (UTC)`

>>! In T168#34, @qgil wrote:
> a casual call for opinions at wikitech-l might be interesting as well, especially if we plan to change the current Bugzilla status quo.

I agree that we should definitely set out in detail what we plan to do in an e-mail to wikitech-l once we've got an idea. Maybe it's a bit premature now? Many people find it easier to find issues with a strawman/proposal than just to answer in a vacuum.
**qgil** wrote on `2014-05-30 19:33:55 (UTC)`

I also think we can keep the default values and then use projects for whatever else (Easy, Security, Regressions, Sprint Candidates, etc). Custom fields bring unnecessary clutter for all tasks, most of them not needing such level of detail.
**swalling** wrote on `2014-05-30 19:19:29 (UTC)`

I'd //really really// like to try leaving the Phabricator defaults alone in terms of priority. When prioritizing Growth's last sprint in Phabricator, I found the list of current values to be very useful. Any tinkering we do is kind of bikeshedding here, IMO. 

One of the great problems of Bugzilla is that there is just too much bullshit to deal with. Priority //and// severity fields are just too fine-grained to be useful in seriously prioritizing tasks. The same goes for Target Milestone etc... almost zero people seriously use these fields or rely on them now.
**qgil** wrote on `2014-05-30 00:29:56 (UTC)`

>>! In T168#28, @TheDJ wrote:
> Can we set the visibility of fields ? Then we can at least import it and initial hide it for everyone, then argue about how to follow up :)

I'd argue before importing the data. What is stopping us from having this discussion?

If we create the custom field, place there the severity data, and then hide it, such data will be "lost" from the users point of view. If we decide not to have it beforehand, or to have something else, the such data can appear in the task description as plain text.

@aklapper and @jdforrester, I think you two should weigh in with an official position from the Phabmaster & PM team, if possible at all.

Edited: a casual call for opinions at wikitech-l might be interesting as well, especially if we plan to change the current Bugzilla status quo.
**TheDJ** wrote on `2014-05-29 16:15:27 (UTC)`

I'm trying this on my own instance, and i'm thus not sure if we are looking at the exact same thing, but the options is intended to be as flexible as https://fab.wmflabs.org/config/edit/differential.fields/ I presume, so I think the maniphest.fields option is currently awaiting to get the same treatment.

https://secure.phabricator.com/T5011 indicates as much.
**jdforrester** wrote on `2014-05-29 15:33:57 (UTC)`

>>! In T168#30, @aklapper wrote:
>> Can we set the visibility of fields ?
> 
> Admins can add custom fields at http://fab.wmflabs.org/config/edit/maniphest.custom-field-definitions/
> 
> Docs in https://secure.phabricator.com/book/phabricator/article/custom_fields/ say "The fields will then appear in the other config option for the application (for example, in maniphest.fields) and you can enable, disable, or reorder them." so //disabling// should be possible. Haven't tried; if it does not fit our needs a hackish workaround would be using "display: none" CSS which I'd like to avoid.

This seems a little limited unless I'm missing something – http://fab.wmflabs.org/config/edit/maniphest.fields/ lets you adjust what fields tasks have, but the only field shown (presumably, the only optional field?) is story points – I don't immediately see a way to remove other default fields. Also, it's not clear if removing the field disables it or just fails to show it, and of course it might behave differently for the built-in field for story points compared to a new field we added…

BTW, editing what values the built-in fields have is trivial – see for example http://fab.wmflabs.org/config/edit/maniphest.statuses/ where (if you're an admin) you can edit the task status values available, or http://fab.wmflabs.org/config/edit/maniphest.priorities/ for the task priority values.
**aklapper** wrote on `2014-05-28 17:00:37 (UTC)`

> Can we set the visibility of fields ?

Admins can add custom fields at http://fab.wmflabs.org/config/edit/maniphest.custom-field-definitions/

Docs in https://secure.phabricator.com/book/phabricator/article/custom_fields/ say "The fields will then appear in the other config option for the application (for example, in maniphest.fields) and you can enable, disable, or reorder them." so //disabling// should be possible. Haven't tried; if it does not fit our needs a hackish workaround would be using "display: none" CSS which I'd like to avoid.
**TheDJ** wrote on `2014-05-23 18:15:22 (UTC)`

Can we set the visibility of fields ? Then we can at least import it and initial hide it for everyone, then argue about how to follow up :)
**qgil** wrote on `2014-05-11 09:25:00 (UTC)`

> It was, however, the sole proposal moved

Because I wasn't paying enough attention.  :) 

If we have a Severity field in Day 1, we will have it in Day 10.000. If there is a time to challenge our current classification of bug/task status, this time is now.

Then again, while I do have a strong opinion about the need to revisit this topic and find an agreement now, I don't have any strong opinion about the decision itself. Whatever works for Andre will work for me.
**jdforrester** wrote on `2014-05-11 07:39:32 (UTC)`

> To be precise, this was "a proposal" and not "the proposal".

It was, however, **the** sole proposal moved, and reached unanimous approval (if not agreement), especially that this shouldn't be a block for Day 1 and could instead be changed later.
**qgil** wrote on `2014-05-10 23:26:56 (UTC)`

To be precise, this was "a proposal" and not "the proposal". I the topic of priority/severity/importance deserves a good community discussion, in my opinion. We have a chance to improve the current system, if needed. After the migration will be too late. 

If we discuss and reach to the conclusion that changing the current approach is not needed, fine. However, deciding after a few minutes of discussion in an afternoon doesn't look sensible to me.
**jdforrester** wrote on `2014-05-10 15:06:41 (UTC)`

The proposal in a meeting at the Zürich Hackathon was to mirror Bugzilla's existing `severity` field in Phabricator when we set it up, alongside the `priority` one.
**qgil** wrote on `2014-04-23 21:03:14 (UTC)`

For what is worth, there is an interesting discussion about Important vs Urgent in the context of Phabricator at https://secure.phabricator.com/T4807
**aklapper** wrote on `2014-04-22 07:05:18 (UTC)`

.... so I don't consider "No severity field" a bug per se. Missing functionality to describe or categorize something would be a bug if it's considered important enough to categorize. :)
**aklapper** wrote on `2014-04-22 07:03:29 (UTC)`

I'd like to see a broader discussion first if anybody would like to have a "Severity" field (or maybe "Impact" which would be a better name). Priority, Severity and Target Milestone in Bugzilla often feel like unneeded complication.

Two examples refering to potential shortcomes of Bugzilla's concept:
JamesF once mentioned
  - ​Timing-priority == "this needs to be done soon"
  - Importance-priority == "this is affecting lots of people / lots of actions / has major impact"
  - Difficulty-priority == "this is really hard to do"​
RobLa once thought of merging Target Milestone and Priority - both should describe when / how urgent an issue should get fixed, so (simplified) high priority would be TM = next release, normal priority = release after, low priority = not planned.
**qgil** wrote on `2014-04-22 00:59:21 (UTC)`

Marked as resolved for the purpose of this RfC. If we want Severity field we can have it.
**qgil** wrote on `2014-04-19 16:14:25 (UTC)`

If we need a field for severity, we can create it through Phabricator's configuration options.
DECISION: We will use `phabricator.wikimedia.org` as the domain for the service.

cnames for any shortened version

----

We need to decide a domain (and therefore a name) for the Phabricator instance in Wikimedia.

Do we want to use something around the "Phabricator" brand or do we prefer to go for a descriptive alternative, or a totally invented name?

We have used bugzilla.wikimedia.org and gerrit.wikimedia.org, therefore phabricator.wikimedia.org cannot be too wrong. Still, it is long, and I'm personally not convinced of relying so much on product names.
>>! In T82#808118, @Quiddity wrote:
> searching for fl294 didn't work.

It does. Go to Maniphest's advanced search and enter "fl294" in the Reference field. :)
I admit it's not [[ https://www.mediawiki.org/wiki/Phabricator/Help#Searching_for_items | documented ]] though; Bugzilla felt like a more common usecase.

> Where is the setting up task? Thanks :)

It's T178
>>! In T82#1216, @flimport wrote:
> **aklapper** wrote on `2014-05-16 22:04:24 (UTC)`
> 
> This ticket is resolved when it comes to //deciding// what the URL should be. I wondered whether to keep this open for actually setting up that subdomain, but I guess that's sufficiently covered by T294.

That ticket seems to be from the older phablabs test instance, and searching for fl294 didn't work. Where is the setting up task? Thanks :)
//importing issue status//
**aklapper** wrote on `2014-06-13 15:51:17 (UTC)`

Makes sense. Thanks for setting this up. 

For the records, reference to current setup of Bugzilla cert and CNAMEs: https://rt.wikimedia.org/Ticket/Display.html?id=5011
**Rush** wrote on `2014-06-13 15:49:24 (UTC)`

just a note, this idea comes into contact with the real world as I need to request SSL certificates that have to reflect these names.  If anyone wants a shortened version in addition to phab.wm.org now is the time to suggest :)
**Rush** wrote on `2014-06-13 15:48:07 (UTC)`

I'm sorry I didn't see this ticket earlier.  So the external facing URL has a standard.  We typically use the full service url (graphite.wikimedia.org / bugzilla.wikimedia.org) and do not do shortened url's for the main A record.  That being said we do use cnames for shorter versions.  We have bugs.wikimedia.org for bugzilla for example.  

Since this is the operations standard I am going to change the title url to be: phabricator.wikimedia.org

...with the intention of mimicking the bugs.wm.org behavior for phab.wm.org

should satisfy both and still maintain the standard?
**aklapper** wrote on `2014-05-16 22:04:24 (UTC)`

This ticket is resolved when it comes to //deciding// what the URL should be. I wondered whether to keep this open for actually setting up that subdomain, but I guess that's sufficiently covered by T294.
**jdforrester** wrote on `2014-05-10 14:59:48 (UTC)`

`phab.wikimedia.org` appears to be the clear winner; let's proceed on this basis.
**aklapper** wrote on `2014-05-03 22:40:40 (UTC)`

"collabtools" doesn't convince me either and the generic tech term "forge" isn't common enough yet, so I guess we could stick to phab.wikimedia.org (because we can).
**qgil** wrote on `2014-04-17 19:56:15 (UTC)`

Alright, so maybe after all we are talking about 

fab.wikimedia.org

or

phab.wikimedia.org
**jdforrester** wrote on `2014-04-17 19:25:10 (UTC)`

This is and always will be a secondary location for task management for Wikimedia compared to the wikis – fundamentally, work by volunteers happens primarily on-wiki, and calling this something not specific to code and technical makes it look like we're normalising off-wiki work – an exception that is rare.

Calling this `tasks` would strongly suggest that this is where the vast majority of tasks by volume (editing pages, patrolling edits, uploading images, discussing improvements, blocking users,…) happens, and I think that this would be a mistake.

`ph` would intrude into the reserved https://en.wikipedia.org/wiki/ISO_3166-2 and https://en.wikipedia.org/wiki/ISO_3166-1_alpha-3 spaces for chapters.
**qgil** wrote on `2014-04-17 18:46:47 (UTC)`

Agreed on the .wikimedia.org part.

One "problem" with code. and other tech. references is that non-coding non-tech projects might be interested as well. This is not just an hypothesis; @MissGayle and @philippe have been playing around already, and I don't see why we couldn't recommend this environment just to any project needing to organize tasks that may or may not have a connection with code.

Being also very pragmatical: if more WMF teams, chapters, etc would find this tool interesting it would be easier to find resources to maintain it properly.

Anyway, more ideas:

tasks.wikimedia.org (like projects, without the double meaning)

ph.wikimedia.org  (just because we can)
**jdforrester** wrote on `2014-04-17 15:50:09 (UTC)`

[Commence bike-shedding]

I think "`projects.wikimedia.org`" is confusing with regard to which projects (Wikipedia and Wiktionary are projects of the Wikimedia movement; Military History is a [wiki]project of the English Wikipedia; //etc.//).

I approve of hosting off `.wikimedia.org` rather than `.mediawiki.org` because we do rather more than just MediaWiki development nowadays (most notably operations work, but also //e.g.// VisualEditor), and we should be consistent with `git.wikimedia.org`, `bugzilla.wikimedia.org`, `rt.wikimedia.org` and so on.

Personally I like `code.wikimedia.org` as it's simple and direct, and doesn't interfere with potential chapter domain names, but could be argued around.
**qgil** wrote on `2014-04-17 15:09:38 (UTC)`

  projects.wikimedia.org

?
**Document moved to https://www.mediawiki.org/wiki/Requests_for_comment/Phabricator/versus_Bugzilla -- you are welcome to edit and discuss there.**

As a bugzilla volunteer user, I want to know what I'm supposed to gain from the migration to phabricator, which is bound to add work I've not asked for.
//importing issue status//
**qgil** wrote on `2014-04-27 03:53:40 (UTC)`

Actually, I wanted to see what happens when you copy text in Phabricator and paste it in MediaWiki using VisualEditor...  :)

https://www.mediawiki.org/wiki/Requests_for_comment/Phabricator/versus_Bugzilla

Resolving the task here, if you want to improve the document let's do it there.
**qgil** wrote on `2014-04-27 03:10:15 (UTC)`

I have been solving the task in its own description. Please have a look and edit at will. On Monday I will public the content in mediawiki.org... where?
**Nemo_bis** wrote on `2014-04-19 18:59:59 (UTC)`

> Nemo, could you take the lead in this task, please?

I still found none. I'm editing the task description for now, space is plenty for what I found.
**qgil** wrote on `2014-04-19 16:17:50 (UTC)`

I agree that having such document would be useful, but it would be even more useful in a wiki page closer to the RfC. Nemo, could you take the lead in this task, please? I will help editing.
**Nemo_bis** wrote on `2014-04-17 08:36:11 (UTC)`

Ideas can be found in https://bugzilla.wikimedia.org/buglist.cgi?bug_severity=enhancement&component=Bugzilla&list_id=305582&product=Wikimedia&query_format=advanced&resolution=--- : list the enhancement requests that phabricator would satisfy
Currently, {{int:}} is (ab)used to localize content, either directly by showing a localised message or by using e.g. [[ https://commons.wikimedia.org/w/index.php?title=Special%3ASearch&search=MediaWiki%3ALang&fulltext=1 | MediaWiki:Lang ]] to achieve conditional transclusion à-la {{sometemplate/{{int:lang}}}}. However, Parsoid always assumes content language for this parser function. This is generally not a problem for VisualEditor where it even makes sense to display a "canonical" version of text, but page views on multilingual projects like meta and commons are different because these sites rely heavily on user language to display content in it. A few examples:


  - File description pages, compare https://commons.wikimedia.org/wiki/File:Sao_Paulo_Railway.jpg?uselang=en vs. https://commons.wikimedia.org/wiki/File:Sao_Paulo_Railway.jpg?uselang=fr
  - Talk page templates, compare https://commons.wikimedia.org/wiki/Commons:Bistro?uselang=fr vs. https://commons.wikimedia.org/wiki/Commons:Bistro?uselang=en
  - Esoteric templates, e.g. https://commons.wikimedia.org/w/index.php?title=Template:Localized_link&action=edit or even in Lua: https://commons.wikimedia.org/wiki/Module:Fallback

We need to develop a strategy to mitigate thiese problems for Parsoid-based pageviews.
>>! In T85581#951449, @GWicke wrote:
> I think it's worth thinking about moving more of the remaining work to the client. We could compile a list of such elements in each page after parse, and then deliver translations to be applied client-side to users who requested it. This should be a good performance win if translations are small relative to the overall page size. It would reduce the per-language storage needs on the server to fragments rather than entire pages. It might even be possible to share such fragments between pages if we can establish that the output does not depend on the actual page name.

However, this will not work when {{int}} is used in esoteric templates to control transclusion.
@ssastry We could pass a language in as a parameter (and then forward that to expandtemplates), but would also need to store that separately, effectively replicating the current parser cache fragmentation.

Some of the use cases for {{int:}} like commons metadata will probably go away soonish with the move to wikidata. The remaining ones seem to be typically individual transclusions, often really small ones (like the 'thanks' template). 

I think it's worth thinking about moving more of the remaining work to the client. We could compile a list of such elements in each page after parse, and then deliver translations to be applied client-side to users who requested it. This should be a good performance win if translations are small relative to the overall page size. It would reduce the per-language storage needs on the server to fragments rather than entire pages. It might even be possible to share such fragments between pages if we can establish that the output does not depend on the actual page name.

In any case, I think the current result of returning the content language is tolerable in the short term. There are bigger issues to tackle right now.
@ssastry We could pass a language in as a parameter, but would also need to store that separately, effectively replicating the current parser cache fragmentation.

Some of the use cases for {{int:}} like commons metadata will probably go away soonish with the move to wikidata. The remaining ones seem to be typically individual transclusions, often really small ones (like the 'thanks' template). 

I think it's worth thinking about moving more of the remaining work to the client. We could compile a list of such elements in each page after parse, and then deliver translations to be applied client-side to users who requested it. This should be a good performance win if translations are small relative to the overall page size. It would reduce the per-language storage needs on the server to fragments rather than entire pages. It might even be possible to share such fragments between pages if we can establish that the output does not depend on the actual page name.

In any case, I think the current result of returning the content language is tolerable in the short term. There are bigger issues to tackle right now.
Hmm .. interesting ... this could be tricky. How do we get user state into the parsing because without user state, it will return the default lang.

```
[subbu@earth lib] echo "{{int:lang}}" | node parse --normalize --dump tplsrc --prefix commonswiki
=================================
pf_int
---------------------------------
en
---------------------------------

<p>en</p>
```
Pasting from Excel into Chrome works.  Highlighting that content in Chrome and then pasting it into IE works.

Pasting the content straight from Excel into IE11 doesn't work.

How can I enable pasting straight from Excel?
Not getting any crazy font tags with Excel2016 + Edge12.
Appears to work with Excel2016 + Edge12.
No, I was right.  I just removed all <font> tags and their children.
hrm.... maybe I was wrong.  looks like it is already stripped by this point.
Tracked down to a call in ve.js: ve.createDocumentFromHtml.

Using my trusty console.log() -- who needs a debugger!?! -- I saw that before this call the text I want is there, but after it isn't:

			// If there were no problems, let CE do its sanitizing as it may
			// contain all sorts of horrible metadata (head tags etc.)
			// TODO: IE will always take this path, and so may have bugs with span unwapping
			// in edge cases (e.g. pasting a single MWReference)
			htmlDoc = ve.createDocumentFromHtml( this.$pasteTarget.html() );
From IRC:

  <edsanders> hexmode, paste sanitization happens in
            ve.ce.Surface.prototype.beforePaste
  <edsanders> ve.ce.Surface.prototype.afterPaste
  <edsanders> and ve.dm.ElementLinearData.prototype.sanitize
  <edsanders> we have sanitization rules
  <edsanders> which are strict for MediaWiki and loose for VisualEditor core
I'll have to take a look at how the converter is handling it at the moment to see how to fix it, but I'm on holiday at the moment.
So, how do I strip it?  Where would I put that in the VE code?
Wow that IE html is bad. Font tags as a child of table!
Sorry for being an idiot -- I was pasting into the wrong box.

On Chrome, I get:

  <table border="0" cellpadding="0" cellspacing="0" width="270" style="border-collapse:
   collapse;width:203pt"><tbody><tr height="80" style="height:60.0pt">
    <td height="80" align="right" width="58" style="height:60.0pt;width:44pt">226</td>
    <td width="212" style="width:159pt">LexWiki</td></tr></tbody></table>


In IE, I get:
  <table width="270" style="width: 203pt; border-collapse: collapse;" border="0" cellspacing="0" cellpadding="0"><font face="Times New Roman">
   </font><colgroup><col width="58" style="width: 44pt; mso-width-source: userset; mso-width-alt: 2121;"><font face="Times New Roman">
   </font><col width="212" style="width: 159pt; mso-width-source: userset; mso-width-alt: 7753;"><font face="Times New Roman">
   </font><tbody><tr height="80" style="height: 60pt;"><font face="Times New Roman">
  
    </font><td width="58" height="80" align="right" style="border: 0px black; width: 44pt; height: 60pt; background-color: transparent;"><font face="Calibri">226</font></td><font face="Times New Roman">
    </font><td width="212" style="border: 0px black; width: 159pt; background-color: transparent;"><font face="Calibri">LexWiki</font></td><font face="Times New Roman">
  
   </font></tr><font face="Times New Roman">
  </font></tbody></table>

In FF, I get:

  <table border="0" cellpadding="0" cellspacing="0" width="270"><colgroup><col width="58"><col width="212"></colgroup><tbody><tr height="80">
    <td style="height:60.0pt;width:44pt" align="right" height="80" width="58">226</td>
    <td style="width:159pt" width="212">LexWiki</td>
  </tr></tbody></table>
It doesn't seem to matter which browser I use.  Chrome, FF, and IE all give: "226 LexWiki "

Pasting the same thing into a VE page on chrome gives a table with two cells.
What HTML do you get if you past into a CE box? http://edg2s.github.io/content-editable-sandbox/
This is similar to T53472.

Some languages or writing systems require combining diacritics.
In theory most characters with diacritics can be input with combining diacritics, for example é (e + combining acute) is equivalent to é (eacute). **For some combinations in some languages only the use of combining diacritics is possible, for exemple ɔ́ (open o + combining acute).**

When typing or pasting text with combining diacritics the following occurs:
  - the first character after a combining diacritics is duplicated on a new line below the cursor.
  - pressing backspace pushes the characters after the first combining diacritics to that line below, the cursor jumps to the end of the newline and the first character that was duplicated jumps behind the cursor as well.
  - pressing backspace gets stuck a the combining diacritics, erasing the duplicated character last, after the characters that jumped and the line return but not erasing the combining diacritics and its base character.

For example, typing

```
té
```
is fine.
But typing other characters becomes:

```
tél
l
```
then

```
télévision
l
```

Pressing backspace with the cursor at the end of the first line:

```
té
élvisio
```
with the cursor before the o, but the next backspace will delete the o and the cursor jumps before the i.

The expected result should be the word "télévision" and pressing backspace should delete the character before the cursor or the character cluster before the cursor.
Also impacts Flow.
I could see the issue for diacritics characters that are entered with Shift key(both in production and betalabs):

For example, using 'US extended' keyboard, 
1) type t, after t type e
2) then use Option+Shift+e to apply an accent mark to e,
3)  type l (letter 'el')

tél
l

Then the letter l will be duplicated and placed on the next line. There will be some issues with deleting as described.

Note: Entering so called precomposed diactrics characters does not seem to present an issue. Additional info at:
http://superuser.com/questions/339359/insert-a-character-with-multiple-accents-on-an-extended-mac-keyboard-layout
Found when investigating T62451 - a page consists entirely of text entered via Templates fields: https://pt.wikibooks.org/w/index.php?title=C%C3%A1lculo_(Volume_1)/An%C3%A1lise_de_fun%C3%A7%C3%B5es_elementares_(2)&redirect=no&veaction=edit 

Text is not searchable via VE Find, but can be searched via browser Find.
The RTL blocking/tracking bug T2745 can be converted into a Phabricator tag.

It also has some "sub-tracker" bugs, for example T35126, which is for RTL bugs in VisualEditor. These can eliminated as well. They should have the RTL tag and the appropriate project tag.
Requested project #RTL has been created: https://phabricator.wikimedia.org/project/profile/1280/

T2745 has been updated accordingly and closed as declined.

Please encourage interested people to visit the project and to join the project as {icon users} members, and to [[ https://www.mediawiki.org/wiki/Phabricator/Help#Receiving_updates_and_notifications | subscribe themselves to the project ]] in order to receive updates!

[[ https://www.mediawiki.org/wiki/Phabricator/Project_management | Recommended practices for project and workboard management in Phabricator ]] are available.

And if for some reason you ever want to rename the project, please check [[ https://www.mediawiki.org/wiki/Phabricator/Creating_and_renaming_projects#Renaming_projects | the guidelines ]] first.

I also created H32 for automatically adding #i18n to #RTL tasks.

Enjoy!
>>! In T78670#1325274, @Aklapper wrote:
> My remaining question still stands:
>> We can make Herald automatically add the #i18n tag whenever a future #RTL tag is added to a task. Does that sound reasonable?
> 
> Someone please answer.

Yes.
My remaining question still stands:
> We can make Herald automatically add the #i18n tag whenever a future #RTL tag is added to a task. Does that sound reasonable?

Someone please answer.
We can make Herald set the #i18n tag whenever a future #RTL tag is added to a task. Does that sound reasonable?

BiDi could be an additional hashtag.

For converting tracking tasks to projects there is now [[ https://www.mediawiki.org/wiki/Phabricator/Project_management/Tracking_tasks | documentation ]] available.
>>! In T78670#936776, @Aklapper wrote:
> Any naming proposal? "RTL-bidirectional" or such? Tag project description text could link to https://www.mediawiki.org/wiki/Directionality_support ?

Just "RTL" or "bidi" should be enough, if it's possible to make something very short.

Linking to https://www.mediawiki.org/wiki/Directionality_support is OK.

> And I've always wondered (already in Bugzilla) how this collides or not with the existing i18n tag - is RTL always a subset of i18n?

Indeed, all RTL bugs are i18n bugs, but i18n includes many more topics. If there is a way to organize a hierarchy of bugs that will automatically infer that all RTL bugs are i18n bugs, it would be a nice thing to have.

RTL could be a Bugzilla tag like i18n is from the start, but somehow RTL issues ended up being tracked by a blocking bug. Now would be a good time to clean that up :)
>>! In T78670#936776, @Aklapper wrote:
> I like the idea but converting looks rather cumbersome, see my general comment in T75703#936775.

https://phabricator.wikimedia.org/maniphest/query/bKU3kGuAWKFB/#R  :)
>>! In T78670#936776, @Aklapper wrote:
> I like the idea but converting looks rather cumbersome, see my general comment in T75703#936775.

https://phabricator.wikimedia.org/maniphest/query/stlzyr5F2Ks3/#R  :)
I like the idea but converting looks rather cumbersome, see my general comment in T75703#936775.

Any naming proposal? "RTL-bidirectional" or such? Tag project description text could link to https://www.mediawiki.org/wiki/Directionality_support ?

And I've always wondered (already in Bugzilla) how this collides or not with the existing i18n tag - is RTL always a subset of i18n?
The screenshots that are uploaded by the latest builds of the VisualEditor language screenshot job have pixelated fonts.

Compare:
* Current, pixelated: https://upload.wikimedia.org/wikipedia/commons/f/fe/VisualEditor_Toolbar_Headings-en.png
* Older, non-pixelated: https://upload.wikimedia.org/wikipedia/commons/archive/f/fe/20141203163056!VisualEditor_Toolbar_Headings-en.png

This may be happening because on the clients where the test jobs run there is a problem with the screen driver or maybe fonts anti-aliasing is disabled. Either the configuration of this client machines must be fixed, or the tests must run on a different platform, maybe Mac. (But it must be tested that they have fonts for all the languages, in particular Arabic, Japanese and Hebrew.)
Change 184587 merged by jenkins-bot:
Deleted Jenkins job that was running VisualEditor screenshots using a local browser

[[https://gerrit.wikimedia.org/r/184587]]
Change 184587 had a related patch set uploaded (by Zfilipin):
Deleted Jenkins job that was running VisualEditor screenshots using a local browser

[[https://gerrit.wikimedia.org/r/184587]]

#patch-for-review
Change 183480 merged by jenkins-bot:
Run VisualEditor screenshot job on a Mac

[[https://gerrit.wikimedia.org/r/183480]]
This patch fixes the pixelation. Thank you. When it's merged and the new non-pixelated screenshots are uploaded to Commons, this bug can be marked as resolved.
Change 183480 had a related patch set uploaded (by Zfilipin):
Run VisualEditor screenshot job on a Mac

[[https://gerrit.wikimedia.org/r/183480]]

#patch-for-review
VisualEditor screenshots-taking tests (currently language_screenshots.feature) upload the files to Commons. It would be useful to have a link from the file description page to the Jenkins job that uploaded the file so it would be easier to debug the problems in it if there are any.
`make-extension-branches` skips when the branch already exists; we should probably duplicate that code.
I tried to set up the MediaWiki Vagrant environment according to the steps described here: http://www.mediawiki.org/wiki/MediaWiki-Vagrant 
I used the most current VirtualBox and Vagrant.
When I tried to do vagrant up: mount.nfs: access denied by server while mounting. 

Find the complete error here: {F20641}
>>! In T78153#841751, @Mvolz wrote:
> I have full disk encryption, but vagrant used to work for me (about 6 months ago?) and it's the same computer although I'm now on 14.04 instead of 13.* , since then- is this a new thing, that it's known not to work on fully encrypted disks but just on Trusty Tahr specifically?

I'm using Vagrant and NFS with full disk encryption (not home directory).  However, I'm on Debian.
>>! In T78153#846323, @Sn1per wrote:
> 'access denied' also happens on unencrypted Fedora 21 with vagrant 1.7.1 and virtualbox 4.3.20.  Turning off NFS allows it to work.

When using libvirt on Fedora 25, I managed to get NFS to work by setting the following firewall settings:
> Example for easily configuring firewalld using the "firewall-config" GUI:
> 
> choose "Configuration: Permanent" from the drop down menu
> select the zone you want to modify (i chose "internal").
> go to the "Interfaces" tab, assign vboxnet0 (or other host-only adapter) to the zone.
> go to the "Services" tab, check "mountd", "nfs" and "rpc-bind"
> go to the global "Services" tab (next to "Zones"), select NFS and add Port 2049 UDP (only TCP is predefined).
> Finally choose "Options/Reload Firewalld".
> NFS mounts now work correctly from within the VM and you can leave firewalld enabled.


from https://github.com/mitchellh/vagrant/issues/2447#issuecomment-27763003

**EDIT:** Spoke too soon again. If NFS is enabled the initial provisioning hangs on
    ==> default: Notice: /Stage[main]/Apt/File[/etc/apt/apt.conf.d/01no-recommended]/ensure: defined content as '{md5}53ce69211afabdf3f0123353515e80f4'

**EDIT2:** When NFS shares were off, I got LXC to work on Fedora 25. (they happened to be off when I set up LXC; I don't know what would happen if it was enabled on initial provisioning) NFS worked after reenabling NFS shares, but I felt LXC was faster without NFS, so I turned it back off.
>>! In T78153#846323, @Sn1per wrote:
> 'access denied' also happens on unencrypted Fedora 21 with vagrant 1.7.1 and virtualbox 4.3.20.  Turning off NFS allows it to work.

When using libvirt on Fedora 25, I managed to get NFS to work by setting the following firewall settings:
> Example for easily configuring firewalld using the "firewall-config" GUI:
> 
> choose "Configuration: Permanent" from the drop down menu
> select the zone you want to modify (i chose "internal").
> go to the "Interfaces" tab, assign vboxnet0 (or other host-only adapter) to the zone.
> go to the "Services" tab, check "mountd", "nfs" and "rpc-bind"
> go to the global "Services" tab (next to "Zones"), select NFS and add Port 2049 UDP (only TCP is predefined).
> Finally choose "Options/Reload Firewalld".
> NFS mounts now work correctly from within the VM and you can leave firewalld enabled.


from https://github.com/mitchellh/vagrant/issues/2447#issuecomment-27763003

**EDIT:** Spoke too soon again. If NFS is enabled the initial provisioning hangs on
    ==> default: Notice: /Stage[main]/Apt/File[/etc/apt/apt.conf.d/01no-recommended]/ensure: defined content as '{md5}53ce69211afabdf3f0123353515e80f4'

**EDIT2:** After turning off NFS shares, I got LXC to work on Fedora 25. NFS worked after reenabling NFS shares, but I felt LXC was faster without NFS, so I turned it back off.
>>! In T78153#846323, @Sn1per wrote:
> 'access denied' also happens on unencrypted Fedora 21 with vagrant 1.7.1 and virtualbox 4.3.20.  Turning off NFS allows it to work.

~~When using libvirt on Fedora 25, I managed to get NFS to work by setting the following firewall settings:~~
> Example for easily configuring firewalld using the "firewall-config" GUI:
> 
> choose "Configuration: Permanent" from the drop down menu
> select the zone you want to modify (i chose "internal").
> go to the "Interfaces" tab, assign vboxnet0 (or other host-only adapter) to the zone.
> go to the "Services" tab, check "mountd", "nfs" and "rpc-bind"
> go to the global "Services" tab (next to "Zones"), select NFS and add Port 2049 UDP (only TCP is predefined).
> Finally choose "Options/Reload Firewalld".
> NFS mounts now work correctly from within the VM and you can leave firewalld enabled.


from https://github.com/mitchellh/vagrant/issues/2447#issuecomment-27763003

**EDIT:** Spoke too soon again. If NFS is enabled the initial provisioning hangs on
    ==> default: Notice: /Stage[main]/Apt/File[/etc/apt/apt.conf.d/01no-recommended]/ensure: defined content as '{md5}53ce69211afabdf3f0123353515e80f4'
>>! In T78153#846323, @Sn1per wrote:
> 'access denied' also happens on unencrypted Fedora 21 with vagrant 1.7.1 and virtualbox 4.3.20.  Turning off NFS allows it to work.

~~When using libvirt on Fedora 25, I managed to get NFS to work by setting the following firewall settings:~~
> Example for easily configuring firewalld using the "firewall-config" GUI:
> 
> choose "Configuration: Permanent" from the drop down menu
> select the zone you want to modify (i chose "internal").
> go to the "Interfaces" tab, assign vboxnet0 (or other host-only adapter) to the zone.
> go to the "Services" tab, check "mountd", "nfs" and "rpc-bind"
> go to the global "Services" tab (next to "Zones"), select NFS and add Port 2049 UDP (only TCP is predefined).
> Finally choose "Options/Reload Firewalld".
> NFS mounts now work correctly from within the VM and you can leave firewalld enabled.


~~ from https://github.com/mitchellh/vagrant/issues/2447#issuecomment-27763003 ~~

Spoke too soon again. If NFS is enabled the initial provisioning hangs on
    ==> default: Notice: /Stage[main]/Apt/File[/etc/apt/apt.conf.d/01no-recommended]/ensure: defined content as '{md5}53ce69211afabdf3f0123353515e80f4'
>>! In T78153#846323, @Sn1per wrote:
> 'access denied' also happens on unencrypted Fedora 21 with vagrant 1.7.1 and virtualbox 4.3.20.  Turning off NFS allows it to work.

When using libvirt on Fedora 25, I managed to get NFS to work by setting the following firewall settings:
> Example for easily configuring firewalld using the "firewall-config" GUI:
> 
> choose "Configuration: Permanent" from the drop down menu
> select the zone you want to modify (i chose "internal").
> go to the "Interfaces" tab, assign vboxnet0 (or other host-only adapter) to the zone.
> go to the "Services" tab, check "mountd", "nfs" and "rpc-bind"
> go to the global "Services" tab (next to "Zones"), select NFS and add Port 2049 UDP (only TCP is predefined).
> Finally choose "Options/Reload Firewalld".
> NFS mounts now work correctly from within the VM and you can leave firewalld enabled.


from https://github.com/mitchellh/vagrant/issues/2447#issuecomment-27763003
I just encountered the same issue on Lubuntu 15.10 (Vagrant 1.8.1, VirtualBox 5.0.16 r105871).

Using `vagrant config nfs_shares off` solved it for me
I just encountered the same issue on Lubuntu 15.10 (Vagrant 1.8.1
I'm getting the same mount.nfs: access denied by server while mounting error.
I'm getting a similar NFS 'access denied' on Fedora 23 alpha, no disk or home-dir encryption:

{F1567690}
I wonder if there is a way we can detect the use of ecryptfs and either give a better error message/warning to the user or just automatically disable nfs like we do for Windows.
'access denied' also happens on unencrypted Fedora 21 with vagrant 1.7.1 and virtualbox 4.3.20.  Turning off NFS allows it to work.
'access denied' also happens on Fedora 21 with vagrant 1.7.1 and virtualbox 4.3.20.  Turning off NFS allows it to work.
>>! In T78153#841751, @Mvolz wrote:
> Additional info:
> 
> I have full disk encryption, but vagrant used to work for me (about 6 months ago?) and it's the same computer although I'm now on 14.04 instead of 13.* , since then- is this a new thing, that it's known not to work on fully encrypted disks but just on Trusty Tahr specifically?

NFS was made the default disk sharing option on 2014-05-23 (<https://gerrit.wikimedia.org/r/#/c/134995/>).  The ability to easily turn this off due to encryption was added on 2014-08-14 (<https://gerrit.wikimedia.org/r/#/c/154153/>).

> I was able to complete vagrant up with NFS shares off, but unfortunately still with errors. 
> 
> While there is a server running at http://127.0.0.1:8080/ I get File not found: /vagrant/mediawiki/index.php. Alas! 
> 
> Output of vagrant up:
> 
> Stderr from the command:
> 
> stdin: is not a tty
> Error: composer install --optimize-autoloader returned 1 instead of one of [0]

This composer failure looks to be the root cause of the rest of the failures. Running `PUPPET_DEBUG=1 vagrant provision | tee puppet.log` or manually running `composer install --optimize-autoloader` in /vagrant/mediawiki may lead to more information on the reason for this failure.
Sputniza, does doing

vagrant config nfs_shares off

then

vagrant reload

Work for you?
>>! In T78153#837045, @Mvolz wrote:
> exportfs: /home/marielle/Code/vagrant does not support NFS export

This last error message sounds like /home/marielle is an encrypted partition. The only fix for this is to disable the use of nfs for your Vagrant shares. We have a command in our plugin that makes that pretty easy: `vagrant config nfs_shares off`
I am getting the same error on Ubuntu 14.04 with the most recent version of vagrant and virtualbox 4.3.12r93733

nfsd running
exportfs: duplicated export entries:
exportfs: 	10.11.12.13:/home/marielle/Code/vagrant
exportfs: 	10.11.12.13:/home/marielle/Code/vagrant
exportfs: /home/marielle/Code/vagrant does not support NFS export

default: Mounting NFS shared folders...
The following SSH command responded with a non-zero exit status.
Vagrant assumes that this means the command failed!

mount -o 'noatime,rsize=32767,wsize=32767,async' 10.11.12.1:'/home/marielle/Code/vagrant' /vagrant

Stdout from the command:



Stderr from the command:

stdin: is not a tty
mount.nfs: access denied by server while mounting 10.11.12.1:/home/marielle/Code/vagrant
I am getting the same error on Ubuntu 14.04 with the most recent version of vagrant:

nfsd running
exportfs: duplicated export entries:
exportfs: 	10.11.12.13:/home/marielle/Code/vagrant
exportfs: 	10.11.12.13:/home/marielle/Code/vagrant
exportfs: /home/marielle/Code/vagrant does not support NFS export
==> default: Mounting NFS shared folders...
The following SSH command responded with a non-zero exit status.
Vagrant assumes that this means the command failed!

mount -o 'noatime,rsize=32767,wsize=32767,async' 10.11.12.1:'/home/marielle/Code/vagrant' /vagrant

Stdout from the command:



Stderr from the command:

stdin: is not a tty
mount.nfs: access denied by server while mounting 10.11.12.1:/home/marielle/Code/vagrant
Due to a combination of factors, we haven't been able to line up a good mentorship for @memeht in the #Performance-Metrics-Dashboard project yet. This has caused a delay in her start on this program. This needs to be solved urgently. @Qgil is working on this.
@Memeht is now more than busy with @ssastry and @jdforrester-wmf. I will continue acting as "generic mentor". This task is resolved now. Thank you Chrsity for your patience, and thank you Subbu and James for stepping in!
Yesterday @Memeht and I had our weekly meeting. She is busy with tasks, she has questions that can find answers in the Analytics mailing list and the Parsoid IRC channel. I'm supporting her as generic mentor for now, but this is a task that I'm doing reactively when she has questions. I think this is going as good as it could during the Winter holidays, considering the situation in which we were just ten days ago.  :)
@Jdforrester-wmf has volunteered to find a project for @memeht and mentor her, as soon as he is back from vacation in January. In the meantime, he proposed this task: {T84949}

For the period between now and James' return, @ssastry has created {T85232}, a task that he is happy to mentor.

While these tasks were defined, I started the routing of weekly meetings with Christy, and I also pointed her to look at [[ https://www.mediawiki.org/wiki/Annoying_little_bugs | annoying little bugs ]], in the case she finished with the interim work.

The situation is far from ideal, but I'm personally happy for having reached to this point during these pre-holidays dates, and I'm very thankful for Subbu's and James' help.
@Memeht, altough it is being extremely difficult to find a mentor available in these pre-vacation days, we are narrowing down the area where your work is welcome: improving the metrics for VisualEditor, a key feature in the modernization of Wikipedia and wiki editing in general. Here you have some pointers:

* https://www.mediawiki.org/wiki/Editing (note that two former interns work in this team, @mvolz and @MSchottlender-WMF)
* https://www.mediawiki.org/wiki/VisualEditor (check "Statistics" under "See also")
* https://www.mediawiki.org/wiki/Editing_performance

I will create some tasks under #Performance-Metrics-Dashboard
@Memeht, altough it is being extremely difficult to find a mentor available in these pre-vacation days, we are narrowing down the area where your work is welcome: improving the metrics for VisualEditor, a key feature in the modernization of Wikipedia and wiki editing in general. Here you have some pointers:

* https://www.mediawiki.org/wiki/Editing (note that two former interns work in this team, @mvolz and @MSchottlender-WMF)
* https://www.mediawiki.org/wiki/VisualEditor (check "Statistics" under "See also")
* https://www.mediawiki.org/wiki/Editing_performance

I will create some tasks under #Performance-Metrics-Dashboard

<James_F> edit-reportcard.wmflabs.org needs lots of work.
<James_F> But it will take 3–4 hours for me to specify what might be good there.
<James_F> Saying "make it better" isn't helpful for her, I imagine.
<James_F> https://phabricator.wikimedia.org/T84926 and https://phabricator.wikimedia.org/T84927 are very basic starts.
Steps to reproduce:

1. Set language to Indonesian (id).
2. Open page in VisualEditor.
3. Insert a table, or select an existing one.
4. Click on the "▾" (down arrow) indicator next to the first cell.
5. Notice that the words end with … rather than spelling out the entire text.

Proposed solution:  Make the menu wider, because some languages require more space than English.
Change 236871 merged by jenkins-bot:
Slightly increase width of table context

[[https://gerrit.wikimedia.org/r/236871]]
Change 236871 had a related patch set uploaded (by Esanders):
Slightly increase width of table context

[[https://gerrit.wikimedia.org/r/236871]]
Think this is now resolved. Tried fr/pl/de/id/etc. and they all seemed to work.
Could anybody provide a pointer to the corresponding LESS file(s) so someone could give this a shot? Cannot find the right place. Thanks.
Could anybody provide a pointer to the corresponding LESS file(s)? 
I'm kind of curious if I can fix this but cannot find the right place. Thanks :)
The three options are truncated in most languages I tried in Firefox 36:
{F55266}
Still wondering what exactly in oojs-ui makes it calculate
```<div style="height: auto; margin-left: -29.5px; width: 150px;" class="oo-ui-popupWidget-popup">```
(someone with more LESS skills could provide a pointer please?). 
Not defining/calculating a "width" value would solve the problem (but would it create others? Don't think so).
See screenshot:

{F20260}
Change 179551 merged by jenkins-bot:
Hide extra space at the top of the single transclusion dialogs

[[https://gerrit.wikimedia.org/r/179551]]
The transitions are currently broken, and I think a bit OTT given we are transitioning the width of the entire dialog. I suggest just display:none-ing them.
Change 179551 had a related patch set uploaded (by Alex Monk):
Hide extra space at the top of the single transclusion dialogs

[[https://gerrit.wikimedia.org/r/179551]]

#patch-for-review
It's because of how we try to hide the template page label on single transclusion dialogs (e.g. templates, citations): https://github.com/wikimedia/mediawiki-extensions-VisualEditor/blob/45518019eb8b668df42a5b3886be8031f578fdee/modules/ve-mw/ui/styles/dialogs/ve.ui.MWTransclusionDialog.css#L55-L61

We use all of that instead of display:none so we can fade it out (see transition lines above).

Just need to work out why it still takes up room.
Seems the same in Apex to me. It's a hidden oo-ui-labelElement-label containing the template name, above the template page description.
https://wikimediafoundation.org/w/index.php?title=Special:Search&search=please%20check%20back&fulltext=Search&profile=all

The search results here include files from Wikimedia Commons. This is kind of weird. It might be helpful if the Commons search results are of media that's actively used/referenced on the local wiki, but otherwise it's just kind of strange and unexpected to include a foreign wiki's search results alongside the local wiki's, especially without a clear opt-out mechanism.

See also: {T94856}
Thanks for the deploy, @Krenair and @ThCipriani. Closing as resolved.
>>! In T76957#1589458, @Jdforrester-WMF wrote:
> Oh, interesting. When? This probably explains the complete breakage of media inserting on officewiki we had to fix a few weeks ago… 

It was done in [[https://gerrit.wikimedia.org/r/#/c/204536/|this patch]], so April 2015.
>>! In T76957#1576570, @Deskana wrote:
>>>! In T76957#1576565, @Jdforrester-WMF wrote:
>> Won't this break VisualEditor for inserting images on Foundationwiki?
> 
> Inserting images from Commons using VisualEditor seems to work just fine on officewiki, and officewiki already had this config change applied to it.

Oh, interesting. When? This probably explains the complete breakage of media inserting on officewiki we had to fix a few weeks ago…
Change 234040 merged by jenkins-bot:
Remove files from Commons from search results on wikimediafoundation.org

[[https://gerrit.wikimedia.org/r/234040]]
>>! In T76957#1576565, @Jdforrester-WMF wrote:
> Won't this break VisualEditor for inserting images on Foundationwiki?

No, what VE does is look up the actual file repositories set up on the local wiki and searches each one separately, I don't think it relies on local search to include foreign file repository results.
>>! In T76957#1576565, @Jdforrester-WMF wrote:
> Won't this break VisualEditor for inserting images on Foundationwiki?

No, what VE does is look up the actual file backends set up on the local wiki and searches each one separately, I don't think it relies on the local search backend to include foreign repository results.
>>! In T76957#1576565, @Jdforrester-WMF wrote:
> Won't this break VisualEditor for inserting images on Foundationwiki?

Inserting images from Commons using VisualEditor seems to work just fine on officewiki, and officewiki already had this config change applied to it. Given that, I find it unlikely that this will affect VisualEditor on foundationwiki.
Won't this break VisualEditor for inserting images on Foundationwiki?
Change 234040 had a related patch set uploaded (by Deskana):
Remove files from Commons from search results on wikimediafoundation.org

[[https://gerrit.wikimedia.org/r/234040]]
>>! In T76957#1462538, @Krenair wrote:
> Getting community consensus on foundationwiki sounds interesting. Who needs to approve this?

Well, Discovery owns search across all of our sites, and I'm the PM for Discovery, so why don't we say me? :-)
Getting community consensus on foundationwiki sounds interesting. Who needs to approve this?
We can now use "file:local:cat" for searching local files. See https://gerrit.wikimedia.org/r/#/c/204536/
Upstream reports: https://secure.phabricator.com/T6102 and https://secure.phabricator.com/T8510

**Workaround by valhallasw: 
Execute `JX.TypeaheadSource.prototype.setMaximumResultCount(100)` in the javascript console (or a userscript)** to get more results displayed. Userscripts at P2444 (Chrome) and P2445 (Firefox)

When typing in the "projects" field in the "edit task" or "edit search" view, phabricator offers up to 5 suggestions/completions. But sometimes, the exact match for what I just typed is not included in this list. This makes it impossible for me to enter these projects anywhere (for me, this happens for "wikidata" - I see "wikidata.org" etc, but not "wikidata"). Interestingly, these suggestions look different for other users (with the same input, they do get "wikidata", though it's only in the 4th slot), so it seems the ranking in the suggester is user-specific (projects that I am a member of get boosted, or some such). 

In any case: exact matches should always win. If I enter a full name and hit enter, this should always work if a project by this name exists.

I'm setting this to "high" since it makes it pretty much impossible for me to work with phab.

PS: I suppose the same issue exists for all fields that use the suggester/tag logic, but I did not run into any problems with other fields yet.

{F39253}
Upstream task https://secure.phabricator.com/T8510#202060 is only still open because
* #Maps and #Discovery entered in the global search bar aren't in first position,
* The "In Any" and "Not In" options [[ https://secure.phabricator.com/T8510#200936 | are not always offered ]] for exact project name matches in the "Tags" field of Maniphest's Advanced Search form. **Workaround:** Explicitly write `not(wikidata)` to get `Not in: Wikidata`.

In general the situation has improved a lot since this task was created, hence lowering its priority.
I have tested with #visualeditor, which wouldn't show up before due to all the related subprojects. Now it appears in the first position. Good!
In the search bar in the toolbar at the top of the screen, searching for "Maps" brings up Maps as the third option. Searching for "Discovery" brings up Discovery as the second option. 

When editing a task and entering tags, autocomplete does bring up Maps and Discovery as the first items. 

This task was originally filed for the editing case, so although I personally think both cases should be fixed, it seems the remaining issues should be captured in a separate task.
https://secure.phabricator.com/T8510#199629 states this should be pretty much resolved. 
We're now running that version here, with an [[ https://secure.phabricator.com/rPb02f64f6eecd1d3b7b1c573f108d5a2c8f35497f | additional backported patch ]] on top. And so far it looks like a great improvement!

Testing in the `Tags` field on https://phabricator.wikimedia.org/maniphest/query/advanced/ , some stuff surprised me:
* Entering `Labs not` displays `Not In: Labs` as 4th item. 
* Entering `labs not in` only displays `Not In: Labs-Infrastructure` but not `Not In: Labs`
* Entering `Wikidata` now shows the `Wikidata` project as the first result. \o/
* I have not been successful yet in getting `Not in: Wikidata` offered somehow. Entering `wikidata in` I only get three options related to the `MediaWiki-extensions-WikibaseMediaInfo` project.

If anyone has examples of exact matches **not** getting offered first, please add them to this task.
The original request was "exact matches should always win", which I interpret as saying they should always be the top match. And I agree. I'm frustrated that for some reason it seems like that change isn't going to be made. 

If this task is closed (which I wouldn't object to at this point), I really think it should be "declined", not "resolved".  It's really not resolved/fixed. But at least in most cases the exact match seems to be shown in the list. Even if it's at the bottom rather than the top.
The original request was "exact matches should always win", which I interpret as saying they should always be the top match. And I agree. I'm frustrated that for some reason it seems like that change isn't going to be made. 

If this task is closed (which I wouldn't object to at this point), I really think it should be "declined", not "resolved".  It's really not resolved/fixed. But in most cases the exact match seems to be shown in the list. Even if it's at the bottom rather than the top.
The original request was "exact matches should always win", which I interpret as saying they should always be the top match. And I agree. I'm frustrated that for some reason it seems like that change isn't going to be made. 

If this task is closed (which I wouldn't object to at this point), I really think it should be "declined", not "resolved.  It's really not resolved/fixed. But in most cases the exact match seems to be shown in the list. Even if it's at the bottom rather than the top.
I think I see the issue- by searching wikidata on the general form, #wikidata is not on top. I think that is a different issues than entering "wikidata" in a project-specific form (like creating a new ticket)- and not necessarily something we want (needs discussion). I would suggest to close this one as resolved and not increase the scope of it. If I write `#wikidata` or `#wikidata-query` on this very same same test form, I get exact results as expected while I am writing.

Then create a new subtask, if needed, of T146843 as that is related to improve general search results, and not to auto-complete (which seems mostly fine).
@lydia_pintscher to me it looks like it's fixed now. At least for the cases I've tried, #Wikidata was always at the top or at least in the list.
{F4611530}
At least for "Wikidata" the situation is still bad unfortunately.
I see some issues, but is the original complain still valid?
{F4602448}
{F4602447}
Removing Phabricator (2016-06-29) project since https://secure.phabricator.com/T8510 is still open and no time frame for that to be fixed.
I think the last one might be because there are a ton of additional hashtags on some of the wikidata related projects, causing them to win out in the relevance scoring.

For example:

#mediawiki-extensions-wikibaseclient has the following 'additional hashtags':

`#MediaWiki-extensions-WikidataClient`, `#mediawiki-extensions-wikidataclient`, `#MediaWiki-extensions-Wikibase-Client`, `#MediaWiki-extensions-Wikibase+Client`, `#mediawiki-extensions-wikibase+client`
For the records, https://secure.phabricator.com/T6102 is fixed upstream; https://secure.phabricator.com/T8510 not yet. 

Status of three testcases, after latest deployment on 2016-06-15:

**Discovery** (which has numerous additional hashtags):
* ✔ Using "Change Project Tags" under "Actions" above the field to add a Comment and entering "Discovery", the 2nd item among the 5 proposals is "Discovery".
* ✔ Using the global search in the upper right corner, "Discovery" is the 2nd item among the 10 proposals.
* ✔ Using the "Tags" field on https://phabricator.wikimedia.org/maniphest/query/advanced/ and entering "Discovery", it is the 2nd item among the 5 proposals.

**Labs** (which has no additional hashtags):
* ✔ Using "Change Project Tags" under "Actions" above the field to add a Comment and entering "Labs", it is the 1st item among the 5 proposals.
* ✔ Using the global search in the upper right corner, "Labs" is the 7th item among the 10 proposals.
* ✔ Using the "Tags" field on https://phabricator.wikimedia.org/maniphest/query/advanced/ and entering "Labs", it is the 1st item among the 5 proposals.


**Wikidata** (which has no additional hashtags):
* ✔ Using "Change Project Tags" under "Actions" above the field to add a Comment and entering "Wikidata", it is the 1st item among the 5 proposals.
* ✔ Using the global search in the upper right corner, "Wikidata" is the 10th item among the 10 proposals.
* ✗ Using the "Tags" field on https://phabricator.wikimedia.org/maniphest/query/advanced/ and entering "Wikidata", it is **NOT** among the 5 proposals:
{F4171138}
(This is a test, clicking the search button, typing "Wikidata", and selecting it from the long list.)
>>! In T76732#2382047, @Sjoerddebruin wrote:
> … it's not possible to add the project Wikidata to tasks.

Click the search button then select it.
Nothing seems to be changed, it's still not possible to add the project Wikidata to tasks.
Problem seems to became more worse, it's not possible to add the project Wikidata to tasks.
More fixes coming this week, hopefully this one is fully fixed after the update.
https://secure.phabricator.com/T8510 is not fully fixed yet, and this can still be reproduced trying to add "Wikidata" for example.
>>! In T76732#1334152, @Nemo_bis wrote:
> I'd also expect exact match of secondary hashtags to win.
> 
> {F173832}

Was this supposed to happen, after T135068? It didn't.
@Qgil: Thanks for pointing to that. It looks like they're going to sort the projects by displayed name, which should at least fix the Discovery case.

I still think their fix is "wrong", in the sense that I believe that an exact match should always win, no matter what order the results appear in. But it should be "good enough", at least for the cases I'm aware of.
Allegedly fixed upstream: https://secure.phabricator.com/T8510#177463
@ksmith: I totally agree that this is a problem and also that the upstream task may not be exactly applicable. I only linked it because it seemed somewhat relevant.
@mmodell : It is not clear to me that the upstream task would actually fix this issue. I think we should either get this case explicitly called out in that task, or we should file a new upstream task.  

As a specific reproducible example, in case anyone needs one: Entering Discovery in the Tags field  still does not offer #Discovery, which has been frustrating us for over a year.
There is still one upstream task[1] that remains open, unlike most of the related tasks about this issue which have been closed as either resolved or invlaid, without totally resolving the underlying problems. 

[1]: https://secure.phabricator.com/T7858
I use a greasemonkey script to get around this problem.  This overrides the suggestion-limiter to 100. 
It's documented onwiki at https://www.mediawiki.org/wiki/Team_Practices_Group/Phabricator_tips/Maniphest#Autocomplete_limit
and quick install at https://openuserjs.org/scripts/quiddity-wp/wikimedia_phabricator_suggestion_expander

However, it's only partially successful in some instances, such as the new "Actions" dropdown menus, and I haven't had time to investigate/fix it. (I assume z-index... but that's all a little outside my familiarity.)
{F4036179}
Things got worse with the subprojects: {F3625114}
Still an issue. Example: Enter [[ https://phabricator.wikimedia.org/project/profile/1174/ | discovery ]] (the primary name of a project) in the Projects field on https://phabricator.wikimedia.org/maniphest/query/advanced/ , the five proposals do not include the "Discovery" project itself.

I've created https://secure.phabricator.com/T8510
I'd also expect exact match of secondary hashtags to win.

{F173832}
Yes, can confirm.
This is not working for me, as described as part of T99739. I don't feel bold enough to reopen it myself, but believe that it should be reopened.
This is not fixed for me by https://secure.phabricator.com/rP49ee09be3f453386c91820e990d6916887206eb6
At least not in a way that I would have expected:
{F166948}
Can someone confirm?
It works!!!
>>! In T76732#1024884, @JanZerebecki wrote:
> Why not deploy the fix

-> T86772
Why not deploy the fix, that was merged upstream a month ago?
At least you could type "#Wikidata_" and get the result. But yes, mentioning the project in comments/descriptions is simpler and cleaner.
how would renaming to "#Wikidata_" work around the issue? Alphabetical sorting isn't the problem, as far as I can tell.
>>! In T76732#1019339, @Qgil wrote:
> What about renaming Wikidata to #Wikidata_ , as an interim solution?

+1, if it's technically possible.

This is an intuitive solution. By "intuitive" I mean that I tried adding "#Wikidata" to a task before I gave up and asked @Lydia_Pintscher for help :)
What about renaming Wikidata to #Wikidata_ , as an interim solution?
Any idea when this will go live here? It is super annoying for Wikidata :(
Fixed upstream: https://secure.phabricator.com/T6102
No.

And my patch hasn't landed locally, so you won't see its effects yet.
> 1) Open https://phabricator.wikimedia.org/maniphest/task/create/
> 2) Type "MediaWiki" in "Projects" field
>
> I. Observed: first option offered is "DataTypes"
> II. Expected: first options offered start with "MediaWiki"

Chad, does your upstream patch reverse the "normal" behaviour and favour frequent words over non-frequent ones, or something like that. For instance, when I type "Pha" I'm most likely looking for #Phabricator or #Phabricator.org, not for § Phabricator Sprint Extension [2014-12-11]
@Jdlrobson, when this task is fixed (hopefully soon), you can expect the same results that you get typing "mobile" in the header search field. At least for me these are 

# Mobile
# Mobile-Apps
# Mobile-Web
# Blocked-on-Mobile-Apps
# ...

This sorting makes total sense.
As described in T75737 by valhallasw, as a workaround for the time being, please execute

```
JX.TypeaheadSource.prototype.setMaximumResultCount(100)
```

in the javascript console (or a userscript).
I'm reopening this for the time being.
@daniel, can you at least select "Wikidata" now?

I have commented in the related upstream task: https://secure.phabricator.com/T6102#87052
>>! In T76732#838951, @chasemp wrote:
> We may need to reindex search...

Not for a change like that. We will anyway after [[ https://secure.phabricator.com/D10955 | Upstream D10955 ]] or something like it lands anyway.
We may need to reindex search...
Not convinced this really got fixed - bypassing the browser cache, going to  "edit task" here and literally entering "wikidata" in the project field, that project is still shown as the fourth one to me. 

Not sure if there's some caching server-side?

How are the results for others?
Great! Resolving. According to T76522, the next upgrade should happen latest by next Wednesday.
Thanks for the pointer! Reading the relevant code was fun :)
That should indeed fix it, please update soon...
In theory this was fixed upstream on November 17: https://secure.phabricator.com/T6102

I don't recall when exactly we upgraded our instance, but it was around that time. Maybe @chasemp or @aklapper can tell whether the related diff made it to our instance or not? If not, we are planning to upgrade one of these days (to install the Sprint app, among other things).
Exceptionally hard, many issues, yada yada yada.

Still, this would be an excellent thing to provide our users.
This is about VisualEditor-core, not VisualEditor-MediaWiki for which there are a bunch of issues that would need to be solved first.
I dont know, how is it in English punctuation, but suprisinglly hyphen mark, which is naturally present on all keyboards is not so much used in the texts. Wikipedia is based especially on texts so it would be a nice feature to VE to have a choise to replace hyphen by En dash, which is much more need in the text at times when you hit hyphen bar.

Now we should insert that symbol, by inserting the symbol - that is in fact not known to not skilled newbies. On the other side, it slow down the skilled editors. If they want to write a clear text from the beggining, the have to stop, insert en dash and continue.
>>! In T76275#802670, @Jdforrester-WMF wrote:
>>>! In T76275#802653, @Juandev wrote:
>> Yes, I am suggesting that James. Em dash is also not so broadly used, so I would not take care of it.
> 
> OK. That's pretty easy to do, but it might be irritating (and we don't have a way to make sequence substitutions only work on some wikis or for some users), so I'd appreciate some other input on whether this is a good idea.

Not a good idea. Hyphen is quite often used legally (eg. in names) and semi-legally (instead of minus), so enforcing its converting to en/em dash is wrong. Also other pars of wikitext can contain hyphens (data-* attributes, classnames, id's, template names etc. etc...)

I barely remember there was a task about convertig -- to en dash and --- to em dash on page save (so the next user would see the proper Unicode character in editbox next time), but I can't find it ATM.

WONTFIXing this because of the reasons above and in favour of the mentioned task.
>>! In T76275#802653, @Juandev wrote:
> Yes, I am suggesting that James. Em dash is also not so broadly used, so I would not take care of it.

OK. That's pretty easy to do, but it might be irritating (and we don't have a way to make sequence substitutions only work on some wikis or for some users), so I'd appreciate some other input on whether this is a good idea.
Yes, I am suggesting that James. Em dash is also not so broadly used, so I would not take care of it.
Just to note - VE preserves hyphen, en-dash, and em-dash typed with regular keyboard shortcuts(on Mac - Option+- for en-dash and Shift+Option+- for em-dash).
hyphen -
en-dash –
em-dash —
What are you suggesting? That if I type "foo-bar" it changes it to "foo–bar"? What about em-dash? Should "foo - bar" be changed to "foo — bar"?
The message visualeditor-recreate says "Press continue", but it's unclear what does "continue" refer to. It should probably include the "continue" message as a parameter.
Thanks to David for merging.
Change 176298 merged by jenkins-bot:
Mention the "Continue" label as a parameter in visualeditor-recreate

[[https://gerrit.wikimedia.org/r/176298]]
Change 176298 had a related patch set uploaded (by Amire80):
Mention the "Continue" label as a parameter in visualeditor-recreate

[[https://gerrit.wikimedia.org/r/176298]]

#patch-for-review
Thanks, but I'd prefer to have it embedded. (A patch is ready.)
The message is <ooui-dialog-process-continue>. I've updated the qqq to reflect this.
We explicitly call buildNodeTree() in a few places. Ideally, we would not need to do this outside of ve.dm.Document.

Suspect calls (excluding dm.Document, excluding tests):

lib/ve/src/ce/ve.ce.Surface.js
1000:			doc.buildNodeTree();
1711:		doc.buildNodeTree();

--------------------------
**Version**: unspecified
**Severity**: normal
The node tree is lazily evaluated by buildNodeTree the first time you call getDocumentNode. In the examples your provide (paste and drag-drop) we call buildNodeTree after sanitisation has occurred, as sanitisation happens on the data model array.
After a prolonged session of editing in Safari, the following error was displayed: 

[Error] Error: QuotaExceededError: DOM Exception 22 DOMException
	log (load.php, line 150)
	flush (load.php, line 173)


No degradation in responsiveness/functionality was noticed. Should we handle this exception?

--------------------------
**Version**: unspecified
**Severity**: minor
We should find out what this is before WONTFIXing, at least.
Read mode - all text is highlighted

1. In VE type some text. Hit enter for the second line.

Some text in bulk to check scrolling. Some text in bulk to check scrolling. Some text in bulk to check scrolling. Some text in bulk to check scrolling.
 
2. Open Edit source(Keep changes) and add <mark> as in the sample below: 

<mark>
Some text in bulk to check scrolling. Some text in bulk to check scrolling. Some text in bulk to check scrolling. Some text in bulk to check scrolling. 

3. Save - in Read mode all text on the page will be highlighted with the yellow background. 

4. Switch to Edit mode again - only the first line will be displayed as highlighted. 

The screenshots are attached.

--------------------------
**Version**: unspecified
**Severity**: trivial

**Attached**: {F14967}
Created attachment 17155
Edit mode - only the first line is highlighted

**Attached**: {F14968}
dragging gallery to Media

1. VE: insert media(a picture) and a gallery.

2. Attempt to drag a gallery into Media and drop - a horizontal vertical line will be displayed. The screen recording is attached.  

e.g.
<div class="ve-ce-focusableNode-dropMarker" style="width: 1048px;">


Note: happens *only* with dragging  a gallery.

--------------------------
**Version**: unspecified
**Severity**: normal

**Attached**: {F14943}
Those thin lines are visible only in VE - they are not preserved upon saving, so the priority is Low.
User:Tacsipacsi at the Hungarian Wikipedia reports issues with "the new buttons" and provides the following log:

```
[2014.11.15. 14:41:15] CSS - https://tools.wmflabs.org/oojs-ui/oojs-ui/demos/index.html
HTML style attribute
Invalid value for property: zoom
Line 1:
  display:inline;margin:0;border:0;padding:1px;width:1px;zoom:1
  -------------------------------------------------------------^
[2014.11.15. 14:41:15] CSS - https://tools.wmflabs.org/oojs-ui/oojs-ui/dist/oojs-ui-mediawiki.svg.css
Linked-in stylesheet
Invalid value for property: -webkit-transform
Line 957:
    -webkit-transform: translateZ(0px);
  -------------------------------------^
[2014.11.15. 14:41:15] CSS - https://tools.wmflabs.org/oojs-ui/oojs-ui/dist/oojs-ui-mediawiki.svg.css
Linked-in stylesheet
Invalid value for property: -o-transform
Line 960:
    -o-transform: translateZ(0px);
  --------------------------------^
[2014.11.15. 14:41:15] CSS - https://tools.wmflabs.org/oojs-ui/oojs-ui/dist/oojs-ui-mediawiki.svg.css
Linked-in stylesheet
Invalid value for property: transform
Line 961:
    transform: translateZ(0px);
  -----------------------------^
[2014.11.15. 14:41:15] CSS - https://tools.wmflabs.org/oojs-ui/oojs-ui/demos/styles/demo.css
Linked-in stylesheet
Declaration syntax error
Line 197:
   width: calc(100% - 40px);
  --------------------------^
```
--------------------------
**Version**: unspecified
**Severity**: normal
OK, I can go with it.
Hmm. I can reproduce that now – when I double-click on the checkbox label (which results in text being selected), the checkbox appears in incorrect state, and fixes itself when I mouse away. This looks like a browser bug, and it doesn't seem to be easily resolvable – honestly, I'm not sure if it's worth worrying about.

(It also doesn't seem to affect OOjs UI checkboxes – the ones used mostly in VisualEditor – but only MediaWiki UI checkboxes – the ones used on the login page, for example.)

As for the CSS errors, they are harmless – MediaWiki uses certain technically invalid constructs to support both old browsers (mostly IE 6) and experimental features of new browsers . Error handling in CSS is well-defined and therefore these are not a problem.
@Tacsipacsi If that happens only the first time when you check a checkbox, then that's possible, since the image will now only be loaded when necessary (previously it was preloaded). Otherwise that should not happen, and I can't reproduce the problem myself (using Opera 12.17 on Windows 7).
@matmarex: I tried it and it works, but it has a bit (sometimes several seconds) delay. Is it normal? If not, can it be fixed?
The issue has now been fixed, and the fix will be included in MediaWiki version 1.25wmf19. According to https://www.mediawiki.org/wiki/MediaWiki_1.25/Roadmap, that version will be deployed to Wikipedias on 4 March. You can try out the fix at beta labs (http://en.wikipedia.beta.wmflabs.org/).
The issue is caused by the combination of the SVG background and the border-radius. One solution can be seen in 2b8f46c6. An other solution is to remove the CSS border completely and draw the border in the SVG instead. I once tested this and it works fine in all browsers including Opera 12.

Personally I'm oscillating between two extremes:

* Don't reinvent the wheel. A checkbox is a checkbox. All CSS hacks (opacity: 0, empty clip regions) to force individual styles on otherwise native form elements are horrible and should have never been invented.

* Opera 12 is dead. It's performance on sites like Twitter is horrible. People should just stop using it. I did.
(In reply to Bartosz Dziewoński from comment #2)
> The solution is to stop serving SVG to Opera 12, like Thiemo has figured out
> and did it for this new checkbox style back when it was part of BetaFeatures

Note that this doesn't even cause the rendering to worsen – while Opera 12 has excellent support for the SVG format itself, it has rather lousy support for SVGs as background-images – if you zoom in, you can see the pixels appear just as if it was a PNG image. (I never tested this on a high DPI screen, but I would expect the effect to be the same.)
Assuming this is about Opera 12, then this is a Opera bug where SVG background-image sometimes disappears in presence of border-radius and the right phase of the moon. If you restart your browser, you'll probably be able to see the checkmark (for a while).

The solution is to stop serving SVG to Opera 12, like Thiemo has figured out and did it for this new checkbox style back when it was part of BetaFeatures (2b8f46c6dfbbe9a66029820f2b524b3aaf8fcddd). That is, however, currently impossible with the current build and "shipping" process of OOUI.

It might also be possible to come up with a magic combination of styles that makes it all work correctly. I couldn't come up with any, but I didn't spend too much time poking at this.
The problem is that there's no visual difference between the checked and unchecked status of the buttons. I tested and I can use it, but I don't know whether it's in checked or unchecked state. It generated lots of "warnings" beside the "errors" in the previous comment what I didn't attach to the error report, say if you need it.
ApiVisualEditorEdit.php:142, $view->setPageContent() should be passing 2 parameters

	public function setPageContent( &$outputDone, &$useParserCache ) {

--------------------------
**Version**: unspecified
**Severity**: trivial
Change 173749 merged by jenkins-bot:
Stop warnings about calling FlaggablePageView::setPageContent with no parameters

https://gerrit.wikimedia.org/r/173749
Change 173749 had a related patch set uploaded by Alex Monk:
Stop warnings about calling FlaggablePageView::setPageContent with no parameters

https://gerrit.wikimedia.org/r/173749
Inserted table with caption

Steps to reproduce: 

1 VE - Insert a media
2. In Media Settings box insert a table and add a caption to a table. Click Insert.

The media will be inserted with a table and the table caption will be displayed below the table. The screenshot is attached.

--------------------------
**Version**: unspecified
**Severity**: minor

**Attached**: {F15354}
Change 264600 merged by jenkins-bot:
Fix caption-side for tables inside figcaptions

[[https://gerrit.wikimedia.org/r/264600]]
Change 264600 had a related patch set uploaded (by Esanders):
Fix caption-side for tables inside figcaptions

[[https://gerrit.wikimedia.org/r/264600]]
This is an upstream issue with how Parsoid styles <figcaption>s. This rule is inherited by the table's <caption>.
Found in test2 and beta.
I was inserting log lines into a preformatted area.  It looked fine on the page, but after saving, there were clearly extra spaces added.  Went into wikitext to remove them.

--------------------------
**Version**: unspecified
**Severity**: normal
There are several issue with copy/paste into pre-formatted area - e.g.https://phabricator.wikimedia.org/T74456.
Prioritizing for now as low.
Tables in References list

Should we allow inserting tables in Basic citation? 

1. VE - insert Cite->Basic 

When inserting Basic citation the dialog box shows all toolbar options in Reference dialog box including tables. 

2. Insert a table from the Reference dialog box for the Basic citation. Type some text in that table. 

The reference list accommodate the table but does not how any table structure - see the attached screenshot.

--------------------------
**Version**: unspecified
**Severity**: normal

**Attached**: {F15121}
dragging block images split tables

The bug is split from 72995

Dragging an image and placing the insert cursor outside a table will split the table.

See the at attached screen recording.

--------------------------
**Version**: unspecified
**Severity**: normal

**Attached**: {F15063}
I think this has been fixed since we introduced block drop targets
It seems that formulae(display:block;) cannot be dragged into a table but are perfectly draggable over the page, including a caption of a table. 

Should we make formulae draggable to tables?
Cut 'n paste from a MS Word document into FF inserts several HTML comments which appear in VE as circled exclamation marks.  Hovering reveals the lengthy MSIE-specific comments.

Note that pasting the same thing into Chrome does not end up with the lengthly comments.

--------------------------
**Version**: unspecified
**Severity**: normal
@MarkAHershberger, just for clarity, could you attach a Word doc which shows this behavior?
Not logged in warning

In test2 and in Betalabs a warnings gets displayed "You are not logged in...". The page displays a user status as being logged in in the upper right corner.(see the attached screenshot).

--------------------------
**Version**: unspecified
**Severity**: normal

**Attached**: {F14878}
Adding screenshots {F54279}{F54277}
Re-checked after my user rights were changed to authorized. The captcha  does not appear anymore and the edits are saved. 
However, the message "You are not logged..."  still appears - although the page still displays me as logged in.
Since I do not have a way to manipulate session timeouts, we need to wait for timeout to occur naturally...

1. Open VE and wait for an hour-and-half.
2. Try to edit the page.
3. In betalabs I receive a captcha in Save dialog box - entering the captcha(s) does not seem to be working.
4. Switch to Read and then back to Edit - the message "You are not logged..."  appears.

 
Console shows:
"[Edit] Missing property "user.id"" load.php:37
<anonymous> load.php:37
mw.trackSubscribe/<() load.php:154
jQuery.Callbacks/fire() load.php:45
jQuery.Callbacks/fire() load.php:45
jQuery.Callbacks/self.fireWith() load.php:46
jQuery.Callbacks/self.fire() load.php:46
mw.track() load.php:153
<anonymous> load.php:219
ve.trackSubscribe/<() load.php:41
jQuery.Callbacks/fire() load.php:45
jQuery.Callbacks/self.fireWith() load.php:46
jQuery.Callbacks/self.fire() load.php:46
ve.track() load.php:41
ve.init.mw.TargetEvents.prototype.trackSaveError() load.php:215
oo.EventEmitter.prototype.emit() load.php:58
ve.init.mw.Target.prototype.onSaveError/<() load.php:197
jQuery.Callbacks/fire() load.php:45
jQuery.Callbacks/self.fireWith() load.php:46
.Deferred/</deferred[tuple[0]]() load.php:47
mw.Api.prototype.ajax/xhr<() load.php:26
jQuery.Callbacks/fire() load.php:45
jQuery.Callbacks/self.fireWith() load.php:46
done() load.php:135
.send/callback()
Cannot reproduce issue.
Environment- test2, beta

Just like media files , the gallery also does not take link or any annotations. But the behavior is inconsistent in Chrome when compared to FF.

Tested in Chrome 38 and FF 33.1.

1> In a blank page, insert a Gallery with some caption
2> Click to highlight the gallery and while it is still highlighted, select to insert link.
3> In FF, the link inspector opens above the Gallery.
In Chrome, the link inspector opens and closes in a split second.

The same thing happens when trying to language annotations to a Gallery.
1> > insert a Gallery with a file name and caption
2> Click to highlight the gallery and while it is still highlighted, select to apply language.
3> In FF, the langauge inspector opens below  the Gallery.

In Chrome, the language inspector opens and closes instantly.

--------------------------
**Version**: unspecified
**Severity**: normal
**OS**: Windows XP
Confirmed  - and as in bug 73226 - an inserted Gallery should be the first element on a page to display the described issue.
Gallery with no images (invalid characters as gallery contents) creates an invisible node and can't be edited.

For example, create a page with the following wikitext:
```
<gallery>
>>
</gallery>
```
Example: https://en.wikipedia.org/w/index.php?title=User:Matma_Rex/sandbox&oldid=826934821

This renders as an empty gallery (`<ul class="gallery mw-gallery-traditional"></ul>`).

In VE, it displays a placeholder, but it seems that it can't be clicked to focus it:
{F13935446}
When focussed using arrow keys, it displays a completely mispositioned context menu:
{F13935448}
Trying to use the "Edit" button causes a JS error in the console:
```
TypeError: Cannot read property 'toggleHighlighted' of undefined
    at VeUiMWGalleryDialog.ve.ui.MWGalleryDialog.onHighlightItem (https://en.wikipedia.org/w/extensions/VisualEditor/modules/ve-mw/ui/dialogs/ve.ui.MWGalleryDialog.js?22058:591:7)
    at https://en.wikipedia.org/w/extensions/VisualEditor/modules/ve-mw/ui/dialogs/ve.ui.MWGalleryDialog.js?22058:342:13
    at fire (https://en.wikipedia.org/w/load.php?debug=true&lang=en&modules=jquery%2Cmediawiki%7Cmediawiki.legacy.wikibits&only=scripts&skin=vector&version=14kbqyi:3317:31)
    at Object.add [as done] (https://en.wikipedia.org/w/load.php?debug=true&lang=en&modules=jquery%2Cmediawiki%7Cmediawiki.legacy.wikibits&only=scripts&skin=vector&version=14kbqyi:3376:7)
    at VeUiMWGalleryDialog.<anonymous> (https://en.wikipedia.org/w/extensions/VisualEditor/modules/ve-mw/ui/dialogs/ve.ui.MWGalleryDialog.js?22058:341:9)
    at https://en.wikipedia.org/w/resources/lib/oojs-ui/oojs-ui-windows.js?f9a29:748:28
    at mightThrow (https://en.wikipedia.org/w/load.php?debug=true&lang=en&modules=jquery%2Cmediawiki%7Cmediawiki.legacy.wikibits&only=scripts&skin=vector&version=14kbqyi:3583:29)
    at process (https://en.wikipedia.org/w/load.php?debug=true&lang=en&modules=jquery%2Cmediawiki%7Cmediawiki.legacy.wikibits&only=scripts&skin=vector&version=14kbqyi:3651:12)
```
Confirmed. 

In addition to the scenario described abotve: 

If ">>" is entered  - the gallery will be saved as 

<gallery>
>>
</gallery>  


If, say, "caption", will be surrounded with << and >>, then the inserted Gallery becomes invisible, but in Edit source it will be: 

<gallery>
<<Caption>>
</gallery>
Also found in FF 33.1.
Environment- test2, beta

1> Select to insert a gallery.Type in  some caption in the resulting  dialog.
2> Click done. 
3> open the gallery inspector again and while it is open, select Insert -> Media.
4> After the Media Search dialog opens notice the cursor instead of being active in the dialog's input field , is active in the main editor. See screencast.

--------------------------
**Version**: unspecified
**Severity**: normal
**OS**: Windows XP
Checked in betalabs and production.
Confirmed  - an inserted Gallery should be the first element on a page to display tye described behavior with a cursor.
http://youtu.be/m6BeEEnrKtc . Also found in FF 33.1.
screenshot of JS error

Enviornment- test2, beta

1> Select to insert a gallery. When the inspector opens just type in some text.
2> Now highlight the gallery and click on the gallery context menu. The gallery inspector opens.
3> delete the content in the dialog and then press done.Generates JS error Uncaught TypeError: Cannot read property 'nodeType' of undefined in the console.See screenshot.

Same behavior found in FF 33.1. 
JS error - TypeError: currentNode.children[(nao.offset - 1)] is undefined.

--------------------------
**Version**: unspecified
**Severity**: normal
**OS**: Windows XP

**Attached**: {F14822}
Confirmed -  the error displayed in JS console is exactly as the attached screenshot presents.
We currently sort of support this is that row/col deletion skips over merged cells, but the user should probably be able to create such a selection themselves. The current canonical form of a table selection is [fromCol,fromRow,toCol,toRow] so this would need to be changed/extended. There are also a lot of places where we assume the selection to be rectangular.

--------------------------
**Version**: unspecified
**Severity**: enhancement
I dug deeper after filing bug 73201.

1. Type "abcdef".
2. Make "ab" italic.
3. Make "ef" italic.
4. Make "bcde" a link.

Result:   ''a[[bcde|b]]''[[bcde|cd''e'']]''f''
Expected: ''a''[[bcde|''b''cd''e'']]''f''

The result doesn't seem to depend on the order of operations here.

VisualEditor should avoid splitting link annotations.

--------------------------
**Version**: unspecified
**Severity**: normal
Do we need to file a task which requests that?
Note that this remains the case even post {T105239} as Parsoid's `scrubWikitext` model doesn't aggressively merge links ahead of other styles.
This is essentially also a duplicate of bug 50098; marking as a subsidiary though in case there are specific concerns.
(In reply to Bartosz Dziewoński from comment #0)
> 3. Make "ef" italic.

Actually, you can skip this step, and still get the "split link" effect.
1. Open a page in VE and insert a table with a caption. Make sure that you have some chunk of text above the inserted table or a block of some content, so the page needs to be scrolled down to the table.

2. Place a cursor in the table caption and press the right arrow on a keyboard to navigate to the end of the caption. Press one more time - the page scrolls up and the cursor is placed at the beginning of the page. 

Note: moving a cursor with the left arrow to the beginning of the caption and pressing it one more time will simply place it at the last character of a previous sentence.
This task is about [VisualEditor](https://www.mediawiki.org/wiki/VisualEditor). See its [user guide](https://www.mediawiki.org/w/index.php?title=Help:VisualEditor/User_guide) for general information.

In the VisualEditor, click the ≡ icon, click "Options", and choose "Page Settings".
If someone puts an invalid page name / page title in the "Target page for [redirection](https://www.mediawiki.org/wiki/Help:Redirects)" field (like the page name "Talk:" or a page name with a pipe character `|` in it), and tries to apply the changes, an exception is caused and the editor is locked up. 

The "Apply Changes" button should be disabled when the input is not valid (like in e.g. the "Insert ➙ Media" dialog when file dimensions are invalid). 

You are expected to provide a patch in Wikimedia Gerrit. See https://www.mediawiki.org/wiki/Gerrit/Tutorial for how to set up Git and Gerrit.
>>! In T74971#1486465, @Krenair wrote:
> Right now it shows the red outline around the textbox when you try to do this. Do we want to block it from saving somehow? Show a warning and automatically set it back to the previous value?

Sounds good.
Right now it shows the red outline around the textbox when you try to do this. Do we want to block it from saving somehow? Show a warning and automatically set it back to the previous value?
So I looked into the code - MWTitleInputWidget (used for redirects and templates) vs. MWLinkTargetInputWidget (links)
I think a lot of the request/response handling code in MWLinkTargetInputWidget should probably be shared, it shows a lot of things in the result like title validity ('legality'), existence of the exact query, external links, exact matches, etc.
I was testing with characters like <>, pipes, etc.

```#REDIRECT [[Talk:]]```

comes up for "Talk:", but gets rendered as a numbered list element with a broken link by the MW parser.
```#REDIRECT [[MediaWiki:Badtitletext]]```
Betalabs

The down arrow to bring up the context menu for Categories is not center aligned.

Compare the screenshots from Betalabs and test2

--------------------------
**Version**: unspecified
**Severity**: minor

**Attached**: {F14800}
Verified the fix in production
Verified the fix in test2
Verified the fix in Betalabs
Change 171165 merged by jenkins-bot:
Fix indicator alignment in MWCategoryItemWidget

https://gerrit.wikimedia.org/r/171165
Change 171165 had a related patch set uploaded by Catrope:
Fix indicator alignment in MWCategoryItemWidget

https://gerrit.wikimedia.org/r/171165
Created attachment 17015
test2

**Attached**: {F14802}
Environment- production, beta

1> Cite -> Basic. Type a name in the “Use this Group”. Type some text in the sub-editor to make the insert button active and click to insert.
2> Cite -> Re Use. Select the Reference from the list.
3> Notice a label shows up with General References and the Group name momentarily, before the reference gets inserted to the main editor. See the screencast(pause it at 0.07).

In beta, it appears on the top-left corner of the page.

--------------------------
**Version**: unspecified
**Severity**: minor
Created attachment 17173
screen recording

**Attached**: {F15375}
The bug exists in beta, test, and production. I've attached the screenrecording - it shows the issue somewhat slower than in the previous attachment.
It turned out that Chrome displays the issue even better than FF. So, better see it there.
Elena, so it does not appear in Betalabs?
Re-tested it  - the bug still exists in test2 and production. The best way to reproduce it 

- use FF
- when inserting a Basic citation do not use General references- type some other name there
Yes, I saw it again in test2 - it's still not 100% reproducible. 

Now for Re-use references in test2, I got
Uncaught TypeError: Cannot read property 'length' of undefined VM1516:174ve.ui.MWReferenceDialog.useReference VM1516:174ve.ui.MWReferenceDialog.onSearchSelect VM1516:172oo.EventEmitter.emit VM1507:6ve.ui.MWReferenceSearchWidget.onResultsSelect VM1516:158oo.EventEmitter.emit VM1507:6OO.ui.SelectWidget.selectItem VM1507:147OO.ui.SelectWidget.chooseItem VM1507:148OO.ui.SelectWidget.onMouseUp
Reopen this issue.Steps to reproduce are the same as above.

See screencast at http://youtu.be/bhaPQLNC4ZU(pause it at 0.05).
Verified in test2.
It looks as the issue is gone  - checked it in betalabs on Safari, FF, Chrome, and IE11.
Provisionally marking as such.
I think I might have fixed this in https://gerrit.wikimedia.org/r/170784 (which is the fix for bug 72783).
Difficult to reproduce - I caught it once in betalabs Chrome. Maybe it related to network connectivity?
Difficult to reproduce - I caught it once in betalabs Chrome. Maybe it related to network connectivity?
http://youtu.be/a8rgrcU7Bns
Open a page containing some refs, and then a gallery that contains <ref> tags but no <references /> block inside the gallery.  (The references block can be elsewhere on the page.)  For example:
```
==Section==
Hello world.<ref>First footnote</ref>

==Gallery==
<gallery>
File:Example.jpg|An image<ref>A footnote for the image</ref>
</gallery>

==References==
<references />
```

In read mode, everything looks right:

> Section
> Hello world.[1]
> 
> Gallery
> An image[2]
> 
> References
> 1. ^ First footnote
> 2. ^ A footnote for the image

In VisualEditor, you get this:

> Section
> Hello world.[1]
> 
> Gallery
> An image[1]
> 1. ^ A footnote for the image
> 
>References
> 1. ^ First footnote

{F15268}

VisualEditor seems to be inserting a ref block into the gallery, even though none exists at that point on the page.  Also, it restarts the numbers for the gallery.
Reproducible in Parsoid:
```
$ echo -e "<gallery>\nFile:foo.jpg|A <ref group="n">ref one</ref>\n</gallery>" | node parse
…
<ul class="gallery mw-gallery-traditional" typeof="mw:Extension/gallery" data-mw='{"name":"gallery","attrs":{},"body":{"extsrc":"\nFile:foo.jpg|A &lt;ref group=n>ref one&lt;/ref>\n"}}' data-parsoid='{"dsr":[0,62,2,2]}' about="#mwt3">
<li class="gallerybox" style="width: 155px">
<div style="width: 155px">
<div class="thumb" style="width: 150px;">
<div style="margin:35.5px auto;"><a href="/wiki/File:Foo.jpg" class="image"><img alt="" src="//upload.wikimedia.org/wikipedia/commons/thumb/0/06/Foo.jpg/120px-Foo.jpg" width="120" height="79" srcset="//upload.wikimedia.org/wikipedia/commons/thumb/0/06/Foo.jpg/180px-Foo.jpg 1.5x, //upload.wikimedia.org/wikipedia/commons/thumb/0/06/Foo.jpg/240px-Foo.jpg 2x" data-file-width="300" data-file-height="197"/></a></div>
</div>
<div class="gallerytext">
<p>A <sup id="cite_ref-1" class="reference"><a href="#cite_note-1"><span>[</span>n 1<span>]</span></a></sup></p>
</div>
</div>
</li>
</ul><span about="#mwt3">
</span><p about="#mwt3"><br/>
<strong class="error mw-ext-cite-error">Cite error: There are <code>&lt;ref group=n></code> tags on this page, but the references will not show without a <code>{{reflist|group=n}}</code> template (see the <a href="/wiki/Help:Cite_errors/Cite_error_group_refs_without_references" title="Help:Cite errors/Cite error group refs without references">help page</a>).</strong>
<link rel="mw:PageProp/Category" href="./Category:Pages_with_missing_references_list#Main%20Page"/></p>
```

Could this be caused by using the <gallery>'s contents as a whole page, thus confusing Cite.php?
Blocked by T49344?
Screenshot

Steps to reproduce

1.Insert a table
2.Insert a caption "text2"
3.Make the caption a bullet point to create a slug above it
4.Now add some other text in that slug "text1"
5.Save the page

Observed Result:
The order of "text1" and "text2" gets reversed.

--------------------------
**Version**: unspecified
**Severity**: normal

**Attached**: {F15176}
As mentioned in [[ https://phabricator.wikimedia.org/T76100 | T76100 ]], this was fixed in 2015, in tidy-html5.
Re-tested and confirmed that this still happens (unsurprisingly).
Apparently this is a bug with HTMLTidy.
Still works on my local machine.

The wikitext produced is:
{|
|+
Foo
* Bar
!-
|
|}

which looks problematic but locally renders fine as

<table><caption>Foo<ul><li>bar...

but on production and betalabs renders as

<ul><li>bar</li></ul><table><caption>Foo...
Created attachment 17004
video capture

Still reproducible, see the video capture

**Attached**: {F15177}
Works for me in Chrome & FF.
1. In VE highlight any portion of an inserted table and add <visualeditor-table-caption>.  

2. Without typing any text in the caption, select any format for headings format - Uncaught TypeError will be displayed.

Uncaught TypeError: Cannot read property 'nodeType' of undefined VM8471:495ve.ce.Document.getNodeAndOffset VM8471:495ve.ce.Surface.focus VM8471:538ve.ui.FormatAction.convert VM8471:661ve.ui.Surface.execute VM8471:629ve.ui.Command.execute VM8471:645ve.ui.Tool.onSelect VM8471:638OO.ui.ToolGroup.onPointerUp VM8471:66OO.ui.PopupToolGroup.onPointerUp VM8471:91jQuery.event.dispatch load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=20141030T0…:65elemData.handle 

3. Attempt to delete the added caption displays: 

Uncaught Error: Unbalanced set of replace operations found (program):321ve.dm.TransactionProcessor.processors.replace (program):321ve.dm.TransactionProcessor.executeOperation (program):314ve.dm.TransactionProcessor.process (program):314ve.dm.Document.commit (program):390ve.dm.Surface.changeInternal (program):366ve.dm.Surface.change (program):365ve.dm.SurfaceFragment.change (program):370ve.dm.SurfaceFragment.delete (program):380ve.ce.Surface.handleLinearDelete (program):578ve.ce.Surface.onDocumentKeyDown (program):546ve.EventSequencer.callListener (program):257ve.EventSequencer.onEvent (program):254(anonymous function) (program):252jQuery.event.dispatch load.php:65elemData.handle

--------------------------
**Version**: unspecified
**Severity**: normal
Verified the fix in production.
Verified the fix in test2.
Fixed in master.
Screenshot

Steps to reproduce:

1.Open a page woth VE
2.Add a basic reference
3.Re -use that reference
4.Open the reference dialog for the re-used reference
5.Open the dropdown for the Use this group comb box 

Observed Result:
Cannot see any groups names there as its getting cut off

See the screenshot attached

--------------------------
**Version**: unspecified
**Severity**: normal

**Attached**: {F15043}
Verified the fix in production
Verified the fix in Betalabs and test2
**gerritadmin** wrote:

Change 170176 merged by jenkins-bot:
Add forgotten $overlay pass-through in MWReferenceDialog

https://gerrit.wikimedia.org/r/170176
**gerritadmin** wrote:

Change 170176 had a related patch set uploaded by Catrope:
Add forgotten $overlay pass-through in MWReferenceDialog

https://gerrit.wikimedia.org/r/170176
screenshot

Screenshot show my cursor within a string of bold text. However the toolbar menu button doesn't change to indicate that text-formatting is currently active. 

This is particularly a problem if I place my cursor at the *end* of a string of bold/formatted text, as I cannot know at-a-glance, whether the text I'm about to type will come out formatted in some way.

In many other programs/sites (eg. gmail, gdoc), there is always an onscreen indicator (usually the button appears "pressed"), which helps me understand whether text-formatting is active or not.

--------------------------
**Version**: unspecified
**Severity**: minor

**Attached**: {F14998}
The button also appears pressed in VisualEditor, it's just that it's pushed down to a sub-menu so it's not obvious. This is the same as e.g. Google Mail's editing interface, but it can be a bit perplexing, yes.
Steps to reproduce:
* Went to my user page, mw:User:Adamw .
* Clicked "Edit" to use the VisualEditor.
* Clicked the thumbnail at the top, to edit.
* Clicked the image title to open the editor dialog.
* Clicked "Choose a different image".
* Pasted the name of an image into the search field, and selected my image.
* Apply changes.
* Save chages to page.

This all seemed to go swimmingly, until I looked at the diff:

https://www.mediawiki.org/w/index.php?title=User%3AAdamw&diff=1246151&oldid=1041988

The "link" parameter is missing.

Client system: Linux, FF 32.0.3

--------------------------
**Version**: unspecified
**Severity**: minor
(In reply to Adam Wight from comment #1)
> I gave it a second try, and went to add the missing parameter with VE.  It
> was not supported anywhere...

Indeed. This is an exceptionally rare piece of wikitext we don't support yet.
I gave it a second try, and went to add the missing parameter with VE.  It was not supported anywhere...
Environment- test2, beta, production

1> insert an external link to a blank page. Number generated for this link is “1”.
2> hit enter a couple of times, to move the cursor down
3> Click to insert media ,in the media settings dialog enter  the same external link in the caption sub-editor.Click to insert.
4> notice the auto-numbers generated beside the external links.Number generated for the link in media is “2”.
5> Save the page. And notice that the media file external link’s auto-number has now changed to #1 and the external link in the page is #2.

See screencast.

--------------------------
**Version**: unspecified
**Severity**: trivial
This feels like we should fix this in MediaWiki rather than in VisualEditor. Alternatively, we could just wait for Parsoid HTML for read mode to come along, which fixes this that way instead. Meh.
Confirmed in betalabs - the steps to reproduce the bug are exactly as described by Ritu.
Created attachment 16928
Numbers change after saving the document

**Attached**: {F15282}
Created attachment 16927
Auto numbers generated before saving the page.

**Attached**: {F15281}
See screenshots.
Timing response editing at enwiki

The save operation has become very slow lately, and it seems to have accelerated this month, possibly in the middle of this month (October).

I did a test edit and the first POST request with submit action took 20562 ms, aka the "save". The later GET request on the page took 12627 ms. Some users report edit delays in the order of a minute or more.

This is on a 75Mbps symmetric fiber line, using HTTPS, with Firefox browser on Ubuntu 14.10. Other users have experienced this problem on other platforms and browsers, and both when they are logged in and not logged in.

Preferences for my part is pretty standard, I can make an export if necessary, but as this is reported from several users editing at several sites I don't think this has anything to do with preferences.

--------------------------
**Version**: unspecified
**Severity**: normal
**Whiteboard**: aklapper-moreinfo

**Attached**: {F15172}
No reply from @jeblad. :(

Hence closing as declined.
@jeblad: Still an issue?
This is very worrisome and I should not have let it slip my attention. @jeblad, what is the current status?
Hmm. Would be good to know if that happened again.
This is about 1-2 weeks prior to the bug. It seems like the response time is back to normal now. A POST after an edit is 7.853 s and the following GET is 5.381 s. Slow but not awfully slow.

I tested this (both now and the previous report) with classic editing, I don't know how the other users were editing.

Last edit on [[w:no:Bagn]].[1] Previous edit on [[w:en:Norway]].[2]

I suspect some heavy background processing slowed the system to a crawl, and it is now done.

[1] https://no.wikipedia.org/w/index.php?title=Bagn&diff=13509266&oldid=13254424
[2] https://en.wikipedia.org/w/index.php?title=Norway&diff=631363149&oldid=631261705
Sorry for the late response.

(In reply to jeblad from comment #0)
> reported from several users editing at several sites

Any links? Which timeframe is this about?

Does this only refer to "classic" editing or VisualEditor or both?
For a discussion at nowiki, see https://no.wikipedia.org/w/index.php?title=Wikipedia:Tinget&oldid=13483198#Hva_er_det_som_skjer_her_.3F.3F.3F.3F
Environment- beta, test2,production

1>In a blank page in VE,type in some text in paragraph format.
2>Enter a space and select to insert a link. Type in some text in the link input box and keep the inspector open.
3>Now while the inspector is open, click on to add a bullet/numbered list.
4>Notice the list gets added and deleted quickly and the link target gets inserted in between the text(right before the last character of the previously typed text). See screencast.

--------------------------
**Version**: unspecified
**Severity**: normal
**OS**: Windows XP
This seems to have been fixed.
Confirmed in test2 - it happens for sure, but not quite noticeable. It's somewhat more noticeable in FF than in Chrome.
http://youtu.be/RwVvvlI9rcI
screenshot of the comment popup

Environment- test2,beta,production

1> In VE, select to insert a comment.
2> When the dialog opens just enter space in the text area and click Done.
3> Notice the comment popup’s appearance (appears to be smaller, than the regular size).See screenshot.
4> Click on the popup. Notice the Edit comment box's textarea is empty  with no space taken up for the whitespace characters.

--------------------------
**Version**: unspecified
**Severity**: normal

**Attached**: {F15118}
Change 205567 merged by jenkins-bot:
ve.ui.WhitespacePreservingTextInputWidget: Trim whitespace in input

[[https://gerrit.wikimedia.org/r/205567]]
Change 205567 had a related patch set uploaded (by Bartosz Dziewoński):
ve.ui.WhitespacePreservingTextInputWidget: Trim whitespace in input

[[https://gerrit.wikimedia.org/r/205567]]
Confirmed - a Comment with white spaces can be saved. Generally

- it is not possible to create an empty comment
- if all text is deleted from the comment - it cannot be saved
- leading and trailing white spaces are not preserved upon saving 

If you re-open the saved Comment with white spaces and click Done - the comment will be recognized as an empty comment and deleted.
It would be nice if the VisualEditor dialogs were able to escape (percent-encode) URLs as this one in a way that makes them work in wikitext.

Currently it fails to do so both when changing an existing URL https://it.wikipedia.org/w/index.php?title=PAGEPress_Publications&diff=68792069&oldid=68792024 and when adding it from scratch. I had to manually use urlencode: as usual in wikitext.

--------------------------
**Version**: unspecified
**Severity**: enhancement
**URL**: http://doaj.org/search?source={%22query%22:{%22filtered%22:{%22query%22:{%22query_string%22:{%22query%22:%22Italy%22,%22default_operator%22:%22AND%22}},%22filter%22:{%22bool%22:{%22must%22:[{%22term%22:{%22_type%22:%22journal%22}},{%22term%22:{%22index.publisher.exact%22:%22PAGEPress%20Publications%22}}]}}}}}
> I am not sure what Parsoid should do here.

Nor do I. :) The VisualEditor dialog should percent-encode URLs (feature request); whether such an operation involves Parsoid I don't know.
I am not sure what Parsoid should do here. When given a string that is a parameter to a transclusion, Parsoid doesn't know that the string happens to be a uri.

Parsoid does handle escapable characters in links correctly where it is clear that the entire string is a url (as below).

[subbu@earth lib] echo '<a rel="mw:ExtLink" href="http://foo.bar?q=[foo]&s=[bar]">baz</a>' | node parse --html2wt
[http://foo.bar?q=&#x5B;foo&#x5D;&s=&#x5B;bar&#x5D; baz]

Am I missing something?
Screenshot

Steps to reproduce:

1.Open a page with mobile VE
2.Type a text
3.Apply a link on the text
4.Reopen the link inspector for it

Observed Result:
The link suggestions are appearing in a broken way .See the screenshot attached

--------------------------
**Version**: unspecified
**Severity**: normal

**Attached**: {F15372}
I cannot reproduce this on my mobile device.
In an actual mobile device,it appears broken for a split second, then again gets back to normal after that.
Created attachment 17044
broken in FF

It is still appearing broken in Firefox

**Attached**: {F15373}
Appears to now be fixed having tested with an iPad against Beta Labs.
Cannot reproduce.
Fram says that the "Page settings" item should be the three items most commonly wanted by encyclopedia article editors:

* redirect
* disambiguate
* displaytitle

and that all the other options should be "Advanced settings" (or not displayed at all as described in {T74396}).
(In reply to WhatamIdoing from comment #0)
> Fram says that the "Page settings" item should be the three items most
> commonly wanted by encyclopedia article editors:
> 
> * redirect
> * disambiguate
> * displaytitle

Where's the data to prove this prioritisation is accurate? (That's not to say the current list is good, but it's based on the MediaWiki manuals for "simple" controls.)

(I've re-written the title to make it an actual ask.)
Under "Advanced settings" in the Page options menu, there are two items:

  "Let this page be indexed by search engines"

and

  "Show a tab on this page to add a new section" 

that should never be changed for Wikipedia articles.  (This will differ for other projects; both of these might be appropriate at Meta, for example.)

Could these options be hidden at projects where they should not be used?

--------------------------
**Version**: unspecified
**Severity**: enhancement
Do-able. Hard and messy, but do-able.
Environment- beta.

1> In VE, insert a comment. Click done.
2> click to undo while the comment is still highlighted. Notice the label on the Comment  first changes to read “Comment” from the actual comment text, before removing it. See screencast.

--------------------------
**Version**: unspecified
**Severity**: normal
Verified the fix in test2.
Verified the fix in beta.
**gerritadmin** wrote:

Change 173808 merged by jenkins-bot:
Make changes to comment node before apply staging stack

https://gerrit.wikimedia.org/r/173808
**gerritadmin** wrote:

Change 173808 had a related patch set uploaded by Esanders:
Make changes to comment node before apply staging stack

https://gerrit.wikimedia.org/r/173808
(In reply to Alex Monk from comment #3)
> This seems to be because the first undo you make only clears the comment
> -text- change. The second undo actually removes the comment node itself.
> This makes sense since you make the comment node and it goes in the document
> first, then later insert some text into it.
> ContextItemWidget#getDescription falls back to the tool's title if the text
> was falsey (so, an empty string), which is why you see 'Comment' rather than
> an empty box. This also seems reasonable.
> 
> We should probably be removing an empty comment node from the document if
> it's left there due to undo... Currently this only appears to be done if you
> have an open comment inspector with no text and then click outside it (see
> CommentInspector#getTeardownProcess).

This sounds like it was caused by Ed's "staging empty comment node" change. That code should ensure that the creation of the comment node and setting the value are one entry in the undo stack.
This seems to be because the first undo you make only clears the comment -text- change. The second undo actually removes the comment node itself. This makes sense since you make the comment node and it goes in the document first, then later insert some text into it.
ContextItemWidget#getDescription falls back to the tool's title if the text was falsey (so, an empty string), which is why you see 'Comment' rather than an empty box. This also seems reasonable.

We should probably be removing an empty comment node from the document if it's left there due to undo... Currently this only appears to be done if you have an open comment inspector with no text and then click outside it (see CommentInspector#getTeardownProcess).
Confirmed in Beta(test2 and production do not have that issue).
http://youtu.be/ws3ObsyZijc
Language context menu appearing outside the editor

Environment-test2, beta

1> Insert some Language in RTL direction.
2> insert a comment in the language text, right before the last word. Notice the word moves to the start of line.
3> Now place the cursor at the end of the last char in the langauge text, notice the language context menu appears outside the editor on the top left of page.See screenshot.

It happens only when the cursor is at the last character.

Refer bug 71320 screencast, in case the above steps sound confusing.

--------------------------
**Version**: unspecified
**Severity**: normal

**Attached**: {F15040}
Fixed by Ed.
Confirmed test2 and Betalabs on Chrome.
Not quite sure how this will work (and how it will know which ones are available), but this would probably be rather useful.

https://www.mediawiki.org/wiki/Help:Page_status_indicators is no longer blank. :-)
PSI's can contain arbitrary wikitext so ideally their contents would be editable in a SurfaceWidget, however I suspect in most situations they will be transcluded onto the page and therefore not editable at all.
Advanced media dialog is shown with horizontal scrollbars because button labels don't fit.

{F15974499}
This is still a problem with the new dialog and the new design, I updated the screenshot.
Well, given that we're replacing this dialog with a new design which will be wider (as we'll have now drawer), and it's only in the "advanced" section, it's maybe not worth worrying for now? Eh.
Not really.
Can we improve the translations?
Un-used function. Clean-up is good. Etc.

--------------------------
**Version**: unspecified
**Severity**: enhancement
**gerritadmin** wrote:

Change 171002 merged by jenkins-bot:
[BREAKING CHANGE] Remove the ve.bind function

https://gerrit.wikimedia.org/r/171002
**gerritadmin** wrote:

Change 171002 had a related patch set uploaded by Jforrester:
[BREAKING CHANGE] Remove the ve.bind function

https://gerrit.wikimedia.org/r/171002
**gerritadmin** wrote:

Change 169644 merged by jenkins-bot:
Remove more references to ve.bind

https://gerrit.wikimedia.org/r/169644
**gerritadmin** wrote:

Change 169644 had a related patch set uploaded by Alex Monk:
Remove more references to ve.bind

https://gerrit.wikimedia.org/r/169644
<James_F> Krinkle: Thoughts on actually removing ve.bind rather than just removing its use?
<Krinkle> James_F: Not just yet. Maybe in 1-2 weeks time?
<James_F> Krinkle: For whom do you think we should wait?
<Krinkle> James_F: documentation, community, etc.
<James_F> Krinkle: Eh.
<Krinkle> James_F: We may not have a public API yet, but that doesn't mean it's cool to break stuff without at least giving them the chance to fix is.
<Krinkle> random google search: https://www.mediawiki.org/wiki/VisualEditor/Adding_instrumentation_how-to

resolved later
Screenshot

Steps to reproduce:

1.Open any page with VE in Betalabs using Firefox
2.Go to Insert>Media
3.Search for any image and select it to add it in the page


Observed Result:
The image gets added to the page but in the console there is an error:

Image corrupt or truncated: http://upload.wikimedia.org/wikipedia/commons/1/1b/Ko_BuWe.jpg

--------------------------
**Version**: unspecified
**Severity**: normal

**Attached**: {F15306}
Deeming as resolved, then.
I haven't seen it recently.
Rummana/Elena: Have either of you seen this issue recently?
(In reply to James Forrester from comment #15)
> Did we decide to declare this a "ghost in the machine" and move on?

If Roan didn't notice the cause in the above debug, I'm not sure who ask to look deeper. It seems the wrong request is being made, right?
Did we decide to declare this a "ghost in the machine" and move on?
As far I could see, there were no errors in header request/response. However, 

there is one small thing(may be nothing): 

Image corrupt or truncated: https://upload.wikimedia.org/wikipedia/commons/3/37/African_Bush_Elephant.jpg African_Bush_Elephant.jpg


<img class="ve-ce-focusableNode-highlight-relocatable-marker" src="data:image/gif;base64,R0lGODlh…EKAAEALAAAAAABAAEAAAICTAEAOw=="></img>

And the issue still is not reproducible 100% of the time.
Can you look into the contents of the HTTP response (in the Firebug network tab, or a network analysis tool like Fiddler) and check if the content is damaged somehow?
(In reply to etonkovidova from comment #10)
> The issue was reproduced in test2.

Which confirms this is not a "Beta Cluster stability" issue.
The issue was reproduced in test2.
I was able to reproduce the bug in FF 33. Look at the attached screenshot:  Screen Shot 2014-10-20 at 11.06.46 AM
Created attachment 16823
error message for inserted picture

**Attached**: {F15309}
The two images mentioned in the FF console in the screenshots:
https://commons.wikimedia.org/wiki/File:Ko_BuWe.jpg
https://commons.wikimedia.org/wiki/File:Zwaardstootplaat-Rijksmuseum_AK-MAK-1056.jpeg

The first file was loaded directly from Commons, the other from beta Commons.

I don't see why this would be a MediaViewer issue. (Was its appearence somehow correlated with using MediaViewer? MV can cause some oddities on Beta because it sometimes tries to preload thumbnails before they exist, and the resulting 404 gets cached - but this error is not related to that in any way I can see.) Some ideas:

- some sort of local issue? Happens deterministically, but no one else could reproduce...
- could be an actual image loading error: Firefox seems to emit this error if it fetches the content for an image file and it turns out not to be a valid image. Maybe the file gets truncated somehow (there were a lot of HTTP errors on beta after the HHVM switch, see e.g. bug 72162 - based on Rummana's screenshot, the file is not necessarily served by beta though, so such an error seems unlikely)
- https://bugzilla.mozilla.org/show_bug.cgi?id=941823 mentions FF errors with large files - the ones mentioned in the bug are in the 100MP range though, while the two files in the screenshots are 10MP
- there are claims that FF throws this error if you change the src of an image before it is fully loaded (e.g. http://stackoverflow.com/questions/11928878/detect-image-corrupt-or-truncated-in-firefox )

All in all, I would close this as worksforme if no one can reproduce and there are no reports of this happening in the wild.
From Gergo: https://bugzilla.mozilla.org/show_bug.cgi?id=646090

So, some image is corrupt (or just has had it's file extension changed, which is considered "corrupt"). Neither Mark H nor Gergo can repro. Rummana is the only person who can right now, right?

Rummana: can you repro with a clean Firefox profile?
I also can't reproduce this problem (MediaViewer issue?) in Chrome, Safari or Firefox? The error as state would be from the MW media fetching/thumbnailing API it sounds like?
See also: http://stackoverflow.com/questions/11727219/image-corrupt-or-truncated-in-firefox

This probably isn't a Beta Cluster problem(?) so I'm moving to VE (feel free to move to where ever it really needs to be) on the assumption its a problem in the code (and I don't want it to not be addressed because it's 'hidden' in the Beta Cluster component).
Created attachment 16792
Screenshot

Hey Greg! I just added the following image in the same page you used, and got the error:

http://en.wikipedia.beta.wmflabs.org/wiki/0.7358261884200304#mediaviewer/File:Zwaardstootplaat-Rijksmuseum_AK-MAK-1056.jpeg

**Attached**: {F15308}
Created attachment 16790
Console log in Iceweasel 32.0.3

I can't repro in Iceweasel 32.0.3. I've attached my console log with other warnings though :)

Done on http://en.wikipedia.beta.wmflabs.org/wiki/0.7358261884200304

**Attached**: {F15307}
I don't see any such error in the Firefox 32 browser console when inserting the "Ko_BuWe" image in VisualEditor on http://en.wikipedia.beta.wmflabs.org.

Also, why is this under "MediaWiki General"?
Screenshot

Steps to reproduce:

1.Open a page with mobile VE
2.Open any citation dialog like Cite>Website/book

Observed Result:
The fields inside Citations dialog are appearing at a much smaller size

See the screenshot attached

--------------------------
**Version**: unspecified
**Severity**: normal

**Attached**: {F15293}
Verified the fix in production
Created attachment 16987
Screenshot

Is it okay if the width appears this way in tablet?

**Attached**: {F15295}
It's not meant to. This is wide enough for tablets and phones.
Created attachment 16986
Screenshot

Its still not taking full width .Reopening it.

**Attached**: {F15294}
confirmed in betalabs. 

Previously it was: 
oo-ui-textInputWidget {
	.	 width: 20em;
}


After the fix: 
.oo-ui-textInputWidget {

	.	 width: 100%;
	.	 max-width: 50em;

}
**gerritadmin** wrote:

Change 169968 merged by jenkins-bot:
Set input/menu widgets to have a max-width expanding to 100% rather than hard-coded

https://gerrit.wikimedia.org/r/169968
**gerritadmin** wrote:

Change 169968 had a related patch set uploaded by Jforrester:
Set input/menu widgets to have a max-width expanding to 100% rather than hard-coded

https://gerrit.wikimedia.org/r/169968
This is almost certainly because of the MediaWiki theme; maybe that now actually sets fields' default width, and the previous theme wasn't?
* Originally proposed at at https://www.mediawiki.org/wiki/FOSS_Outreach_Program_for_Women/Round_9#Collaborative_spelling_dictionary_building_tool
* Currently ongoing work: https://www.mediawiki.org/wiki/Collaborative_spelling_dictionary/Progress

There are extensive spelling dictionaries for the major languages of the world: English, Italian, French and some others; at various degrees of coverage, Mozilla has over a hundred, LibreOffice dozens. They help make Wikipedia articles in these languages more readable and professional and provide an opportunity for participation in improving spelling. Many other languages, however, don’t have spelling dictionaries. One possible way to build good spelling dictionaries would be to employ crowdsourcing, and Wikipedia editors can be a good source for this, but this approach will also require a robust system in which language experts will be able to manage the submissions: accept, reject, filter and build new versions of the spelling dictionary upon them. This can be done as a MediaWiki extension integrated with VisualEditor, and possibly use Wikidata as a backend.

--------------------------
**Version**: unspecified
**Severity**: enhancement
(In reply to Quim Gil from comment #4)
> There is a question that as far as I can see hasn't been answered:
> 
> > How would such a thing interact with the wiktionary community. Would it
> > harvest data from them or be a sub project somehow, or is it planned to be
> > entirely separate?
> 
> https://lists.wikimedia.org/pipermail/wikitech-l/2014-October/079022.html

In the initial phase of development, the project will aim at making a spelling dictionary for VE. Once this has been achieved, it can then be integrated into Wiktionary later on. 
This way, it won't remain totally independent of the Wiktionary community forever, rather, it shall aim at improving and increasing the span of the same.
There is a question that as far as I can see hasn't been answered:

> How would such a thing interact with the wiktionary community. Would it
> harvest data from them or be a sub project somehow, or is it planned to be
> entirely separate?

https://lists.wikimedia.org/pipermail/wikitech-l/2014-October/079022.html
(In reply to Daniel Naber from comment #2)
> I'm not sure, but http://www.dicollecte.org/home.php?prj=fr might do
> something similar. It should probably be evaluated before starting this
> project.

This is something very similar to what the project aims to accomplish, just that dicollecte is specific to French. The project takes this up as a challenge (that only the most popular languages have a solid base of spelling dictionaries) and aims to establish spelling dictionaries for lesser popular languages as well.
**misc2006** wrote:

I'm not sure, but http://www.dicollecte.org/home.php?prj=fr might do something similar. It should probably be evaluated before starting this project.
Hello everyone!

I read through this project idea and am interested in working on this. 
Presently what I understand is that the project requires an admin panel to be built such that the suggestions that come through crowdsourcing can be verified by the administrator. This panel will be ready with rights like approving, rejecting, filtering to be given to the administrator so as to ensure only valid words/spellings to be accepted.

Please correct me if I'm wrong.

Also, it would be great if I could be redirected to some bugs that might help me better understand this project.

Thanks!
Dear Sir or Madam,

0) Context

DEB packages of `mediawiki' and many of its extensions, are prepared as part of the WP-MIRROR project (see <https://www.mediawiki.org/wiki/Wp-mirror>). 

1) Lintian

During the build process, `lintian' performs a great number of sanity checks, including seeing if each file has file permissions appropriate to its file type.

When `lintian' sees a non-executable file with 755 permissions, rather than 644, `lintian' will throw a warning like:

W: wp-mirror-mediawiki-extensions: executable-not-elf-or-script usr/share/wp-mirror-mediawiki/extensions/VisualEditor/modules/ve-mw/ui/styles/images/broken-image.png

2) Files which should have permissions set to 644

VisualEditor/modules/ve-mw/tests/browser/Gemfile
VisualEditor/modules/ve-mw/ui/widgets/ve.ui.MWMediaResultWidget.js
VisualEditor/modules/ve-mw/ui/widgets/ve.ui.MWMediaSearchWidget.js

3) Technical details

DEB standards version: 3.9.6
GIT branch: wmf/1.24wmf22

Sincerely Yours,
Kent

--------------------------
**Version**: unspecified
**Severity**: minor
Change 166275 merged by jenkins-bot:
Sort out some odd file permissions

https://gerrit.wikimedia.org/r/166275
Change 166275 had a related patch set uploaded by Alex Monk:
Sort out some odd file permissions

https://gerrit.wikimedia.org/r/166275
https://bugzilla.wikimedia.org/show_bug.cgi?id=71928 
https://bugzilla.wikimedia.org/show_bug.cgi?id=71930 
https://bugzilla.wikimedia.org/show_bug.cgi?id=71931 
https://bugzilla.wikimedia.org/show_bug.cgi?id=71932 
https://bugzilla.wikimedia.org/show_bug.cgi?id=71933 
https://bugzilla.wikimedia.org/show_bug.cgi?id=71934 
https://bugzilla.wikimedia.org/show_bug.cgi?id=71935 
https://bugzilla.wikimedia.org/show_bug.cgi?id=71936 
https://bugzilla.wikimedia.org/show_bug.cgi?id=71937 
https://bugzilla.wikimedia.org/show_bug.cgi?id=71938 
https://bugzilla.wikimedia.org/show_bug.cgi?id=71939 
https://bugzilla.wikimedia.org/show_bug.cgi?id=71940 
https://bugzilla.wikimedia.org/show_bug.cgi?id=71941 
https://bugzilla.wikimedia.org/show_bug.cgi?id=71942 
https://bugzilla.wikimedia.org/show_bug.cgi?id=71943 
https://bugzilla.wikimedia.org/show_bug.cgi?id=71944
I'm editing, and I see a plain, unlabeled, auto-numbered link to an external website.  It says "[2]".  I can't open that link without exiting VisualEditor.  The link dialog has an option to "Add label" but not "Open link".

--------------------------
**Version**: unspecified
**Severity**: enhancement
**gerritadmin** wrote:

Change 168007 merged by jenkins-bot:
MWLinkNodeInspector: Provide an open button here too

https://gerrit.wikimedia.org/r/168007
**gerritadmin** wrote:

Change 168007 had a related patch set uploaded by Jforrester:
MWLinkNodeInspector: Provide an open button here too

https://gerrit.wikimedia.org/r/168007
mwlib is able to fetch credentials to access content on private wikis, though with some issues.

* http://web.archive.org/web/20110800000000/http://code.pediapress.com/wiki/ticket/747
** Credentials not used to fetch license page 
** new – ralf – normal – major – 23 months
** Needs someone with a private wiki able to set $wgCollectionLicenseURL for testing; not relevant for OCG?

--------------------------
**Version**: unspecified
**Severity**: enhancement
As already announced in [[ https://meta.wikimedia.org/wiki/Tech/News/2017/37 | Tech News ]], OfflineContentGenerator (OCG) will not be used anymore after October 1st, 2017 on Wikimedia sites. OCG will be replaced by Electron. [[ https://www.mediawiki.org/wiki/Special:MyLanguage/Reading/Web/PDF_Functionality | You can read more on mediawiki.org. ]]
(In reply to C. Scott Ananian from comment #3)
> Is the concrete feature request here that we support HTTP authentication
> (basic? digest?) when contacting the wiki's api.php endpoint?

It depends on what we're asking from the API: are we asking anything that requires read privileges?
Is the concrete feature request here that we support HTTP authentication (basic? digest?) when contacting the wiki's api.php endpoint?

Have you tried using the 'http://username:password@host/...' format when configuring the API endpoint URL?
(In reply to C. Scott Ananian from comment #1)
> This should work, using the instructions for setting up Parsoid to point at
> a private wiki: 

Nice. But doesn't OCG also contact the web API?
This should work, using the instructions for setting up Parsoid to point at a private wiki: 
https://www.mediawiki.org/wiki/Parsoid/Setup#Configuration
https://www.mediawiki.org/wiki/Extension:VisualEditor#Linking_with_Parsoid_in_private_wikis

This could stand to be tested and documented better.
translate syntax in VE

Translated text should probably not display with syntax in VE

--------------------------
**Version**: unspecified
**Severity**: minor

**Attached**: {F14987}
(In reply to James Forrester from comment #4)
> No, it means the ghastly mess that is {{TNTNTNTNTTNT}} :-)

The screnshot seems to be about this excerpt:

<translate>
<!--T:21-->
More details at {{ll|Social media|Social media}}.
</translate>

{{ll}} only creates a link to Special:MyLanguage (which is not even in Translate now). (In the Translate docs we recommend to use Special:MyLanguage directly, but what can you do.)
So the summary currently mentions the only thing which is not in the screenshot. :)
No, it means the ghastly mess that is {{TNTNTNTNTTNT}} :-)
I assume you mean translate tags as shown in the screenshot, because "translate templates" don't exist.
Yeah, the Translate extension fundamentally doesn't work with VisualEditor in its current form, as I understand it. Much sadness.
see https://www.mediawiki.org/wiki/Communication?veaction=edit
unclear fields in an infobox template

some labels are not clear, or have not been given "human readable" aliases, providing a way for end users to flag these, or even submit suggestions or edit them directly could help clean these up quickly.

--------------------------
**Version**: unspecified
**Severity**: enhancement

**Attached**: {F14733}
This could get very tricky, but could be useful.
VisualEditor Mobile does not load at all on IE 11 right now (unknown dependency "ext.visualEditor.iehacks", gets stuck displaying the loading spinner).

Either the module needs mobile target, or we need to stop trying to load it on mobile.

--------------------------
**Version**: unspecified
**Severity**: normal
**gerritadmin** wrote:

Change 164649 merged by jenkins-bot:
Add mobile target to 'ext.visualEditor.iehacks' module

https://gerrit.wikimedia.org/r/164649
**gerritadmin** wrote:

Change 164649 had a related patch set uploaded by Bartosz Dziewoński:
Add mobile target to 'ext.visualEditor.iehacks' module

https://gerrit.wikimedia.org/r/164649
CommentInspector doesn't update its size when the textarea gets resized, only if it's closed and reopened. Split off from bug 71310.

--------------------------
**Version**: unspecified
**Severity**: minor
**gerritadmin** wrote:

Change 163674 merged by jenkins-bot:
ve.ui.CommentInspector: Update size when the textarea gets resized

https://gerrit.wikimedia.org/r/163674
Spoke too soon.
**gerritadmin** wrote:

Change 163738 merged by jenkins-bot:
WindowManager: Emit 'resize' event when a window is resized

https://gerrit.wikimedia.org/r/163738
**gerritadmin** wrote:

Change 163738 had a related patch set uploaded by Bartosz Dziewoński:
WindowManager: Emit 'resize' event when a window is resized

https://gerrit.wikimedia.org/r/163738
**gerritadmin** wrote:

Change 163674 had a related patch set uploaded by Bartosz Dziewoński:
[WIP] ve.ui.CommentInspector: Update size when the textarea gets resized

https://gerrit.wikimedia.org/r/163674
When one creates a redirect without filling an edit summary, MediaWiki automatically uses an edit summary to identify that the edit created a redirect. That's very useful. But the autosummary doesn't work if the user fills the edit summary. It also doesn't work when the user edits a redirected page to make it a normal page, by removing the #REDIRECT syntax.

Redirections are very special edits that would be good to have them tagged for review on recent changes and watchlists.

With AbuseFilter one could write some tricky filters to tag those edits, but that's far from ideal.

My proposal is to have at least 2 new tags:
* One to tag when a redirect is created
* One when a redirect is removed (not by page deletion, but by removing the #REDIRECT)

It would be nice to also have a tag for when a redirect target is changed (pointing the redirect to another article) and also when a redirect is edited without changing the redirect (like for example adding a category, a comment, or simply content that won't be viewed anyway).

A slight limitation of tags (as I understand) is that they won't display the redirect target as the autosummary does, but that's not important, I think. The autosummary would do the job when present.
Change 390224 merged by jenkins-bot:
[mediawiki/core@master] Add new core tags

[[https://gerrit.wikimedia.org/r/390224]]
Change 390224 had a related patch set uploaded (by Catrope; owner: Petar.petkovic):
[mediawiki/core@master] Add new core tags

[[https://gerrit.wikimedia.org/r/390224]]
Change 311683 abandoned by Cenarium:
Implement redirect-related and other tags in mediawiki core

Reason:
I ended up removing the dependencies directly in I2e48bd458fc8d7c289f04dc276f9287516e0b987 so I have only one commit to maintain.

[[https://gerrit.wikimedia.org/r/311683]]
Change 211497 had a related patch set uploaded (by Cenarium):
Implement redirect-related and other tags in mediawiki core

[[https://gerrit.wikimedia.org/r/211497]]
Change 311683 had a related patch set uploaded (by Cenarium):
Implement redirect-related and other tags in mediawiki core

[[https://gerrit.wikimedia.org/r/311683]]
>>! In T73236#1640971, @daniel wrote:
> what's the status of this? Can we get the patches merged?
> Hm, seems to be a long chain...
Lots of dependencies indeed...
For automated tags, we need a user-friendly drop down menu instead of an input box (since internal tag names are in english and obtuse, e.g. core-move-crossnamespace). It's 211497.
For the dropdown menu, we need to overhaul the caching so that a list of tags can be efficiently fetched. It's 218265.
Before overhauling the caching, we need to make several related performance improvements. It's 201905.
218777 is not essential to this (I might put it in another branch).

>>! In T73236#1641141, @TTO wrote:
> @daniel, if you have time, Cenarium and I would really appreciate a second opinion on some of these patches, particularly 201905. Anomie is too busy, and I personally have some doubts about `ChangeTagsContext` and would like someone's else's point of view.
Yes, I would appreciate reviews.
I've created `ChangeTagsContext` so that the `ChangeTag` class can't be provided with arbitrary hitcounts or tag definitions, in a way that doesn't require unnecessary duplications when multiple `ChangeTag` instances are involved.
@daniel, if you have time, Cenarium and I would really appreciate a second opinion on some of these patches, particularly 201905. Anomie is too busy, and I personally have some doubts about `ChangeTagsContext` and would like someone's else's point of view.
*bump*
what's the status of this? Can we get the patches merged?

Hm, seems to be a long chain...
* https://gerrit.wikimedia.org/r/#/c/194458/
* https://gerrit.wikimedia.org/r/#/c/211497/7
* https://gerrit.wikimedia.org/r/#/c/218265/4
* https://gerrit.wikimedia.org/r/#/c/218777/3
* https://gerrit.wikimedia.org/r/#/c/201905/28
ArchCom approves: this seems pretty uncontroversial. We have added some reviewers to the patch. If the review doesn't go forward, let us know.
[[ https://gerrit.wikimedia.org/r/#/c/194458/ | Change 194458 ]] pretty well does what's requested on this bug, so I'd say it could be closed once it's merged
@Cenarium, @Ciencia_Al_Poder: do you think it would be useful to have a discussion on IRC about this soon? Or would you say the patch sets you mentioned would be sufficient to close this? Is there anything more to discuss?
Did anyone work on this task at #wikimedia-hackathon-2015? If do, please share an update. If not, remove the label.
@daniel
I dunno what you intend to discuss, but FYI the patch set in https://gerrit.wikimedia.org/r/194458 when combined with https://gerrit.wikimedia.org/r/#/c/190656/ allows to resolve T92621, and when also combined with https://gerrit.wikimedia.org/r/#/c/211656/, allows to resolve T14363 as well (from recent changes, not from new pages where performance issues make this impossible IMO).
See {T92621}
>>! In T73236#1283464, @daniel wrote:
> @Cenarium, @Ciencia_Al_Poder: We (the ArchCom) thinks it may be nice to discuss this RFC at the hackathon in Lyon. Will you be attending?

Me neither
>>! In T73236#1283464, @daniel wrote:
> @Cenarium, @Ciencia_Al_Poder: We (the ArchCom) thinks it may be nice to discuss this RFC at the hackathon in Lyon. Will you be attending?

No I won't be attending. What is it in particular that you want to discuss ?
@Cenarium, @Ciencia_Al_Poder: We (the ArchCom) thinks it may be nice to discuss this RFC at the hackathon in Lyon. Will you be attending?
@Cenarium: We (the ArchCom) thinks it may be nice to discuss this RFC at the hackathon in Lyon. Will you be attending?
> Should we deactivate the feature by default in mediawiki core ?

Yes.

> (And enable it on WMF wikis.)

That requires a separate discussion IMHO.
>>! In T73236#1272896, @Nemo_bis wrote:
> Do we have statistics on how many (non-Wikimedia) wikis consider cross-namespace redirects to be a problem?

I don't think so.

Should we deactivate the feature by default in mediawiki core ?
(And enable it on WMF wikis.)
Do we have statistics on how many (non-Wikimedia) wikis consider cross-namespace redirects to be a problem?
@daniel I haven't implemented any of the controversial aspects.

The first one being the ability to activate / deactivate these tags directly from Special:Tags, which would require a database change. So we don't need a RFC on this at the moment, but we might revisit this issue if it turns out after implementation that there are requests from the wiki communities for such a feature.

The second one is how to handle these tags for display in a drop down menu. I've given up the controversial idea of having a localizable tag name, instead having a separate message for it which can also be used to prevent the tag from appearing in the drop down menu. I haven't had feedback yet on this proposed solution so I can't say if a RFC might be needed, but I don't see which alternatives we have.
@Cenarium do you think this should be an RFC? See https://www.mediawiki.org/wiki/Requests_for_comment/Process for the process. If not, feel free to remove the @MediaWiki-RfCs tag.
Assigning to RFC queue, since I think the ArchCom should have a look at this.
Change 194458 had a related patch set uploaded (by Cenarium):
Core-defined automatically added tags

[[https://gerrit.wikimedia.org/r/194458]]
I've uploaded a patch set for T91535.

Concerning this request, while I still think we should always endeavor to allow as much onwiki customization as possible, I plan on uploading a patch set that simply uses a config variable as originally suggested by TTO.
I am in full agreement that localising tag names, which are purely meant as internal IDs, is wrong. The only place users should see these names in the UI is in the first column of Special:Tags. This is not currently the case - the tag filter input box and the AbuseFilter edit page being the most obvious places where the raw tag name is used - but the solution is to use the `tag-$tag` system message in those places, not to localise the internal ID. 

Not only that, but it leads to difficulty for external consumers of the recentchanges API, as well as problems when trying to provide default tag description messages. 

I like the idea of namespacing the tags. It's not currently done by most extensions, but it would be a good precedent to set. For example, `mw-redirected` or `mw-redirect-removed`. As I said, users should never have to interact with these names, except in the first column of Special:Tags and when using the API.

> In core, admins control the tags, not extensions, so they should also be able to rename them (in case of conflict, for example). 

Not really. What we're developing here is essentially another tag-applying extension (using automated logic to apply tags, just like OAuth, AbuseFilter, VisualEditor et al) but built into MW core. So this feature should behave like an extension, not like the newly-added manual tagging stuff in core. When extensions apply tags using automated logic, they have control over their tags' names etc. Likewise, when core uses automated logic to apply tags, core should control the tags. Extensions are free to provide a way to turn tags on and off; core can do the same (or, as Legoktm says, not).

What you are trying to create is a weird hybrid of extension-based tagging and manual tagging, which seems to be the main bone of contention here.
I haven't followed all of the discussion here, but the patch seems drastically overcomplicated from what we need, which is a way for core to define tags (and then apply them). I would recommend just having a static function which returns core provided tags, similar to the one for extensions.

I don't think there's a solid usecase for being able to disable core provided tags, so we can probably leave that out of the initial implementation.
Ok, here's why we need a config variable to define optional tags IMO, it allows to:
- have a neat and efficient 'isset' check instead of ugly 'in_array'
- easily define the wfmessage they should use
- easily unset the default autotags in case an extension wants to provide more specific ones (e.g. with more special casing, usergroups checks, etc, making many of the default ones redundant).
I can't think of any other reasonable way of defining these tags.

Now for activation, doing this with the valid_tag table allows to:
- avoid a second config variable
- make it possible for admins to make the activation, without a single line of code needed since everything already exists
- have more use for this vastly underused table
- allows to store tag-specific data such as whether they should be patrollable, and maybe other features like hidden and such.
Again, letting admins do the activation is much easier to implement, the current implementation of tags already allows it, on the other hand using a second config variable would be a hassle to implement and fuzzy to maintain.
I've updated [[https://gerrit.wikimedia.org/r/#/c/193040/|commit 193040]] with various redirect-related tags including those suggested here.

>>! In T73236#1076852, @Anomie wrote:
> Extensions already have hooks to use.
> 
> I see no good reason to support wikis wanting to not-even-define built-in tags.

If the ListDefineTags hook is used, we can't simply define the source as 'optional'. Yet extensions should also be able to define optional tags. In the implementation I made, I use the config variable to not only define the tags but also to provide the relevant message giving the name of the tag (for internationalization purposes). It also allows a simple 'isset' check. A config variable to define all optional tags actually makes implementation easier. Wikis with lots of extensions may have lots of default optional tags, some of them may be irrelevant to them, so they may want to unset some, although it's not essential, just a bonus. And activation by admins is very easy to implement. So I don't see the need to think of other solutions, unless there is a serious issue with this implementation.
Extensions already have hooks to use.

I see no good reason to support wikis wanting to not-even-define built-in tags.
>>! In T73236#1076767, @Anomie wrote:
>>> Why are you assuming that the tags couldn't show up as defined but not active when the config setting for applying them is turned off?
>> 
>> To do that we would need two distinct config variables
> 
> No we wouldn't. We'd need one config variable to activate the feature, and //non-config// logic somewhere to define the tags and conditionally activate them.

Maybe, but if we did that, wouldn't it be more complicated, especially for extensions ? And how about wikis not wanting some built-in tags defined at all (whether from core or extensions) ?
I don't see the issue since in this case, it's actually very easy to allow admins to activate or not - we've already got everything that we need.
>>! In T73236#1076763, @Cenarium wrote:
>>>! In T73236#1069817, @Anomie wrote:
>> Why are you assuming that the tags couldn't show up as defined but not active when the config setting for applying them is turned off?
> 
> To do that we would need two distinct config variables

No we wouldn't. We'd need one config variable to activate the feature, and //non-config// logic somewhere to define the tags and conditionally activate them.
>>! In T73236#1069817, @Anomie wrote:
> Why are you assuming that the tags couldn't show up as defined but not active when the config setting for applying them is turned off?

To do that we would need two distinct config variables : one to list defined tags, one to make them active. This is just as complicated as letting admins activate them or not : it requires checking the config variable for active tags instead of checking the valid_tag table.

>>! In T73236#1069290, @TTO wrote:
> The fact is, configuration settings that affect the entire wiki belong in `$wg` variables. As far as I know, nowhere in MediaWiki or the WMF-installed extensions is there a way to modify global configuration state from the wiki (perhaps with the exception of Global Groups).
I agree that //defining// the optional built-in tags is a config issue, but //activating// them is not. It should be just as easy for admins to activate or deactivate an optional tag as to make an abuse filter tag or not.

I'll implement the redirect-related tags in a new patch set.
>>! In T73236#1068996, @Cenarium wrote:
> Config only isn't satisfactory, since those tags should not be active by default, but if we don't define them in config, they don't appear at Special:Tags so how can users of the wiki be even aware of their existence ?

Why are you assuming that the tags couldn't show up as defined but not active when the config setting for applying them is turned off?
The fact is, configuration settings that affect the entire wiki belong in `$wg` variables. As far as I know, nowhere in MediaWiki or the WMF-installed extensions is there a way to modify global configuration state from the wiki (perhaps with the exception of Global Groups).

The long-term plan is to actually get rid of the `$wg` scheme altogether, which would allow for the creation of an on-wiki configuration interface. This way, configuration settings would be stored in the DB (or CDB/similar file) rather than a PHP file, and stewards would be able to alter global wiki configuration settings from within the MediaWiki interface. See https://www.mediawiki.org/wiki/Requests_for_comment/Configuration_database_2 and T28992.

>>! In T73236#1068996, @Cenarium wrote:
> but if we don't define them in config, they don't appear at Special:Tags so how can users of the wiki be even aware of their existence ? 

That's a broader issue with configuration variables in general. People seem to manage to find them in general, see T65388 for a request to change a non-obvious setting.
>>! In T73236#1065778, @Anomie wrote:
>>>! In T73236#1064690, @TTO wrote:
>> Your point about reserving a "mw-" namespace for core tags is a good idea. However I don't think we need the added complexity of "optional tags". "Built-in tags" (just a temporary name I made up for tags added by MW core) could be turned on and off in the wiki's configuration settings
> 
> I agree with this, now that we have regular SWAT windows getting a configuration setting changed isn't very difficult, so the added complexity of having an on-wiki page for admins to directly do this seems unwarranted.

Config only isn't satisfactory, since those tags should not be active by default, but if we don't define them in config, they don't appear at Special:Tags so how can users of the wiki be even aware of their existence ? I agree with the idea of using a config variable, rather than a hook, but it should only define the tag, not make it active. Users are thus informed of the availability of those tags, and admins can then make them active or not as needed.

I've made a proof of concept implementation in [[https://gerrit.wikimedia.org/r/#/c/193040/|commit 193040]], which uses cross namespaces moves as an example (easier to implement). Since the user interface for activation already exists, it isn't complex to implement, they can be activated the same way as user-defined tags.
>>! In T73236#1064690, @TTO wrote:
> Your point about reserving a "mw-" namespace for core tags is a good idea. However I don't think we need the added complexity of "optional tags". "Built-in tags" (just a temporary name I made up for tags added by MW core) could be turned on and off in the wiki's configuration settings

I agree with this, now that we have regular SWAT windows getting a configuration setting changed isn't very difficult, so the added complexity of having an on-wiki page for admins to directly do this seems unwarranted.
It wouldn't really be core/extension adding to valid_tag but the tag manager that activates it. Config variables may be slightly less complicated to implement but it also makes it much harder to activate / deactivate a built-in tag.
I'd like this to be doable on wiki, since there's likely to be some interplay between these tags and those added by filters or bots, the later two offering more specific options (only certain users, namespaces, page size constraints, etc) that could supersede the built-in tag but since their reliability is limited (bot failure, condition limits...), and not all wikis would have the resources to implement these, or only intermittently, the built-in tags would be a handy default/fallback that should be readily available.

Another reason for this is patrolling of tagged changes... As I'm planing it, extension-defined tags would use a hook to define patrollable tags. So the behavior would be configured by the extension (for example visual editor would only list 'visualeditor-needcheck' as patrollable). On the other hand, the 'patrollable' status of user-defined tags would be stored in a field vt_important of the valid_tag table that admins could modify from Special:Tags. So if active built-in tags are not stored in valid_tag, how do we store the patrollable status of these ? As you mentioned there, a config variable would be unsatisfactory... doing this from Special:Tags is much easier.

If we add support for this class of 'optional' tags that can be defined and applied by core or extensions, but whose activation is up to tag managers, the built-in mediawiki tags would only be one aspect of it. Extensions could provide various optional tags without having to create a user interface for their activation/deactivation. It's kind of hybrid, but it allows much more control for end users, and valid_tag allows to store extra info for customization.
Your point about reserving a "mw-" namespace for core tags is a good idea. However I don't think we need the added complexity of "optional tags". "Built-in tags" (just a temporary name I made up for tags added by MW core) could be turned on and off in the wiki's configuration settings using something like

```
$wgUseBuiltInTags = true; // have 'em all
$wgUseBuiltInTags = array( 'mw-redirected', 'mw-redirect-removed' ); // list the ones that are wanted
$wgUseBuiltInTags = false; // none
```

Extensions would be able to provide their own configuration variables, which could behave in a similar fashion, or differently, depending on the requirements of that extension.

I should point out that only manually defined tags are present in the `valid_tag` table. Extensions do not add to this table, and neither should core.
I'd suggest to implement those in core, but with a hook so that they can be disabled and more of the same type can be added by extensions. IMO, these tags should be optional so I would make it their defining characteristic. They should probably not be enabled by default, it would be up to admins to enable them or not at Special:Tags (and they could subsequently disable them if they want).

They would be listed at Special:Tags via a 'ListOptionalTags' hook (core tags included). It should be possible for tag managers to activate and deactivate those tags (implemented by adding or removing them from the valid_tag table), but not for users to apply them to edits. Before applying those tags, MediaWiki core or extensions would check that the tag is defined in the valid_tag table (i.e. activated).

So basically three categories of tags :
- User-defined tags : defined and activated by tag managers, directly applied by users
- Extension-defined tags : defined, activated and applied by extensions
- Optional tags : defined by core/extensions, activated by users, and applied by core/extensions
We may also reserve a namespace for those defined in core, such as "mw-".
>>! In T73236#1056437, @TTO wrote:
> I wonder if it would be best to do this as a core feature, an extension (perhaps something like `SimpleTags`), or a Wikimedia-specific hook?

Core feature or extension, not a hook IMO.
I wonder if it would be best to do this as a core feature, an extension (perhaps something like `SimpleTags`), or a Wikimedia-specific hook?
The un-redirect part would be helpful for [[https://en.wikipedia.org/wiki/Wikipedia:Village_pump_%28proposals%29/Archive_117#Proposed_technical_change:_show_pages_expanded_from_redirects_on_Special:NewPages_and_Special:NewPagesFeed|this request]], particularly when combined with patrolling of tagged changes from T89553. This is a frequently requested feature, along with pages moved into mainspace.
Screenshot

Steps to reproduce:

1.Open a blank page with VE
2.Insert an image as the first item of the document
3.Save the page
4.Reopen the page
5.The image gets highlighted, now try to delete the image


Observed Result:
The following error appears in the console:
Uncaught Error: offset was inside a handlesOwnChildren node

See the screenshot attached.

--------------------------
**Version**: unspecified
**Severity**: major

**Attached**: {F14961}
Verified the fix in production
Verified the fix in test2
Verified the fix in Betalabs
Change 162884 merged by jenkins-bot:
Be more cautious about placing the cursor

https://gerrit.wikimedia.org/r/162884
Change 162884 had a related patch set uploaded by Esanders:
Be more cautious about placing the cursor

https://gerrit.wikimedia.org/r/162884
It happens for reflist too.Though thats not something common to encounter to have reflist at the beginning of a page
The VisualEditor section of BetaFeatures appears before the introduction

In my experimental setup, the VisualEditor section in the beta features appears as first item, just before the introductory text about beta features.

It appears that in the LocalSettings.php I load the VisualEditor extension before the BetaFeatures extension, and exchange the order results in a good placement of the VE as BF (normal order).

--------------------------
**Version**: master
**Severity**: minor

**Attached**: {F14687}
Re-close. Thanks!
Change 161685 merged by jenkins-bot:
Check the existence of BetaFeatures before adding the 'visualeditor-enable' preference

https://gerrit.wikimedia.org/r/161685
Thanks for merging, Bartosz.

I propose a patch for the second solution also, I find it better to check the existence of BetaFeatures.
Change 161685 had a related patch set uploaded by Seb35:
Check the existence of BetaFeatures before adding the 'visualeditor-enable' preference

https://gerrit.wikimedia.org/r/161685
Change 161677 merged by jenkins-bot:
Unset the preference key before adding it

https://gerrit.wikimedia.org/r/161677
Oh, I misread your solution 1. That also makes sense. Thanks for the patch!
Change 161677 had a related patch set uploaded by Seb35:
Unset the preference key before adding it

https://gerrit.wikimedia.org/r/161677
Yeah. VE should just check for the presence of 'BetaFeatures' class, instead of relying on the order. You can just use class_exists() for that. Want to submit a patch?
Since the VisualEditor registers its preference 'visualeditor-enable' in the standard GetPreferences and in the BF’s GetBetaFeaturePreferences, one is be cancelled.

If BF is loaded before VE (and hence BF’s GetPreferences is before VE’s GetPreferences), VE takes care and don’t add again the 'visualeditor-enable'.

But if VE is loaded before BF, VE’s GetPreferences first adds its 'visualeditor-enable' then VE’s GetBetaFeaturePreferences erases the previous value and remplaces it by the 'visualeditor-emable' in the BF syntax, but by *keeping* the same place in the $prefs array, so the PreferencesForm loads it in a "wrong" order.

Two non-exclusive solutions:
1. in BF, unset the $prefs[$key] before adding it, to restart the order (tested, it works)
2. in VE in onGetPreferences function, add a second condition before adding the 'visualeditor-enable' preference "!AutoLoader::loadClass( 'BetaFeatures' )" (tested, it works)
See the 6 hidden comments I placed in https://en.wikipedia.org/w/index.php?title=User:Elitre_(WMF)/SandboxVE&action=edit .
Only 2 of them are visible when VEditing, https://en.wikipedia.org/wiki/User:Elitre_(WMF)/SandboxVE?veaction=edit .
Reported on fr.wp, see for example that they are missing from sections Personagges and Liens externes in https://fr.wikipedia.org/w/index.php?title=Détective_Conan&veaction=edit .

--------------------------
**Version**: unspecified
**Severity**: minor
@jdforrester-WMF, comments won't show up if placed among a list of external links (see https://de.wikipedia.org/w/index.php?title=Benutzerin:Elitre_(WMF)/sandbox&veaction=edit&vesection=1 ). Should this task be re-opened?
(Filed as T90517.)
Ooh, thank you, that was helpful. I can reproduce only if the reference is at the end of paragraph, and you add the comment after it. Adding a comment before a reference, or adding it after and typing some more text, works correctly. I can also reproduce in production, so that must be a separate issue too.
Hmm, I am able to reproduce it consistently.Nope thats a different case, I am not adding anything into a slug.Attaching the screen capture if it helps
{F45842}
@Ryasmeen, can you elaborate? I can't reproduce that, neither in labs nor prod – I can open an existing article in VE, place the cursor after a citation (like "[1]"), insert a comment there, and save the page with the comment appearing in the source code (I didn't actually save, but "Review your changes" shows it). There is currently a separate issue with inserting things into slugs (T89192) – are you sure you're not running into that?
Also , comment is not getting added after template,gallery,math node and table
Also , comment is not getting added after template,gallery and table
Also , comment is not getting added after template and table
Also , comment is not getting added after template
Also , comment is not gettiing added after template
Comment added after citation node is not getting added , nothing in review changes section after adding it.
Comment added after citation not is not getting added , nothing in review changes section after adding it.
Change 192051 merged by jenkins-bot:
Generate CommentNodes more leniently

[[https://gerrit.wikimedia.org/r/192051]]
The patch above correctly displays all six comments in the example from task description.

> (this could be blamed on Parsoid's funny output, though – the <!-- --> is outside the <p></p>) 

Filed as T90321.
Change 192051 had a related patch set uploaded (by Bartosz Dziewoński):
Generate CommentNodes more leniently

[[https://gerrit.wikimedia.org/r/192051]]

#patch-for-review
Am I missing something obvious, or is this actually pretty simple?

The logic for this behavior is in Converter and ve.dm.CommentNode.static.toDataElement, we only generate a content node if converter.isExpectingContent() (=we're inside one of BlockquoteNode, HeadingNode, ParagraphNode, PreformattedNode, and expecting text). Therefore no comment will appear in VE for comments placed between block-level elements – paragraphs, tables, floated images, box-like templates, headings – and more confusingly, for comments placed at the beginning of a line containing a paragraph, for example (this could be blamed on Parsoid's funny output, though – the <!-- --> is outside the <p></p>) or at the beginning of a table cells and list items (and this is all our fault).

But! we already have logic to control which elements can be nested inside which (for example, table rows may only contain table cells; ordered list may only contain list items). And we already have logic to wrap things that are not block-level in paragraphs. Looks like we could easily use that.

I implemented it, played with it, and encountered no problems. Patch incoming.
The reason for this is that we're currently very conservative about which comments we deem to be "safe" to display, because there are some "unsafe" ones, like comments placed between two table rows. We haven't yet refined the logic for this, so right now a lot of comments are erroneously identified as unsafe.
original Word source causing issues

Some spaces in Word documented are being converted into line breaks when pasting into VE.

Example: https://www.mediawiki.org/wiki/User:Rosencrantz/Paste

--------------------------
**Version**: unspecified
**Severity**: normal

**Attached**: {F15305}
1. View https://en.wikipedia.org/wiki/GNU_Lesser_General_Public_License
2. Observe whitespace between heading, subtitle and first paragraph
3. Click Edit beta

Expected:
* Table of contents slide up and content remains in the same position and dims.

Actual:
* The content shift upwards due to #contentSub being display-none'ed. This element is empty by default (also on English Wikipedia) but it does have a line height and thus affects flow.

--------------------------
**Version**: unspecified
**Severity**: trivial
(In reply to Krinkle from comment #0)
> 1. View https://en.wikipedia.org/wiki/GNU_Lesser_General_Public_License
> 2. Observe whitespace between heading, subtitle and first paragraph
> 3. Click Edit beta
> 
> 

For comparison, here's a redirect page where the element is non-empty:

https://en.wikipedia.org/wiki/GNU_Library_General_Public_License
//**content hidden as private in Bugzilla**//
Caused by I2d6157708bd7b4c3a7c647 which fixed bug 52243 and bug 54325.

Perhaps we should use "visibility: hidden;" instead of "opacity: 0;" ?
Environment- Production, Test2, beta

1> open the transclusion for any citation (book/news/journal).
2> add a content and a template  below the citation in the modal.
3> Now highlight the Citation and click to move the citation down.
4> Notice that although the citation moves down and the Content moves up, but now the highlight moves to the content instead of staying at the Citation.

--------------------------
**Version**: unspecified
**Severity**: minor
Possibly caused by our changes to focussing in dialogs recently?
Created attachment 16472
Highlight jumps to the next item following the Citation, that is content

**Attached**: {F14730}
Created attachment 16471
citation highlighted

**Attached**: {F14729}
1. Select image node at <https://www.mediawiki.org/wiki/VisualEditor/Basic_example_worksheet#Media_files>
2. Resize an image
3. While a new thumb is generated and fetched from Commons, highlight a different image.

## Unexpected behaviour

Observe, after the thumbnail fetch has completed the dimmed pixelated thumbnail preview will be replaced with a sharp opaque rendering. Unexpected is that this new rendering results in the appearance of a new resize handle at its bottom right corner.

This new highlight and resize handle aren't supposed to exist and aren't properly kept up to date either (when reflowing the document they mostly stay behind and only update during more general regenerations).

--------------------------
**Version**: unspecified
**Severity**: minor
Still reproducible on latest master. On fast networks it's harder to reproduce but there's no doubt we're missing some state integrity in our handling for that callback.
 
{F41807}
```
review/jdlrobson/mantleview x ~/Sites/w/extensions/MobileFrontend $ vagrant provision
==> default: Running provisioner: lsb_check...
==> default: Running provisioner: puppet...
Running Puppet with site.pp...
Warning: Could not retrieve fact ipaddress
Error: Cannot allocate memory - fork(2) on node mediawiki-vagrant
Error: Cannot allocate memory - fork(2) on node mediawiki-vagrant
The following SSH command responded with a non-zero exit status.
Vagrant assumes that this means the command failed!

FACTER_fqdn='mediawiki-vagrant.dev' FACTER_forwarded_port='8080' FACTER_shared_apt_cache='/vagrant/cache/apt/' FACTER_environment='vagrant' FACTER_port_fragment=':8080' FACTER_share_owner='502' FACTER_share_group='20' FACTER_provider_name='virtualbox' puppet apply --templatedir /vagrant/puppet/templates --verbose --config_version /vagrant/puppet/extra/config-version --fileserverconfig /vagrant/puppet/extra/fileserver.conf --logdest /vagrant/logs/puppet/puppet.20f0fbdd9.log --logdest console --write-catalog-summary --modulepath '/tmp/vagrant-puppet-1/modules-0:/etc/puppet/modules' --hiera_config=/tmp/vagrant-puppet-1/hiera.yaml --manifestdir /tmp/vagrant-puppet-1/manifests --detailed-exitcodes /tmp/vagrant-puppet-1/manifests/site.pp || [ $? -eq 2 ]

Stdout from the command:



Stderr from the command:

Warning: Could not retrieve fact ipaddress
Error: Cannot allocate memory - fork(2) on node mediawiki-vagrant
Error: Cannot allocate memory - fork(2) on node mediawiki-vagrant
```
We can safely decline this. The base VM memory has been bumped a couple of times since this was opened and roles can now define an increase to memory if necessary.
Has anyone seen this problem in the last two years?
Or should this task get declined?
I know that some of the OOM issues during provisioning were happening during Ruby gem compilation (usually ffi). It probably wasn't the root cause—more likely the compounding effect of less base VM RAM and more memory required by the base MW dependencies (HHVM)—but it's worth noting that there have been far fewer reported cases since we switched to using system packages. [1][2]

[1] https://gerrit.wikimedia.org/r/#/c/158564/
[2] https://gerrit.wikimedia.org/r/#/c/156207/
It hasn't happened to me in a while (maybe correlated to less Flow coding?)... soon as it does I'll be back here.
I'll also add the easiest way to trigger the error is to try and load the hhvm debugger, 

    hhvm -m debug --debug-host ::1

always fails for me with not enough memory if it booted with 1G due to reading the wrong settings.yml
I've had this happen several times, not because of applications eating ram but because of https://bugzilla.wikimedia.org/show_bug.cgi?id=70304

I have to reload vagrant from the appropriate directory and it starts up with my configured 4G instead of 1G
Jon, poke. Any progress in reproducing and determining which application is eating your instance RAM?
(In reply to Jon from comment #2)
> Nothing looked suspect. Is there any particular commands you would like me
> to run?

# Top 20 processes by resident memory size
$ ps -e -orss=,args= | sort -b -k1,1nr | head -20

# Free/used ram
$ free -m

# Job queue status
$ mwscript showJobs.php --wiki=wiki --group
I'm using Flow, MobileFrontend and VisualEditor. I notice this seems to correlate when I have a Flow page with over 20 posts and I continuously keep hitting.

Nothing looked suspect. Is there any particular commands you would like me to run?
(In reply to Jon from comment #0)
> Warning: Could not retrieve fact ipaddress
> Error: Cannot allocate memory - fork(2) on node mediawiki-vagrant
> Error: Cannot allocate memory - fork(2) on node mediawiki-vagrant

Any idea what's eating all the ram in your VM? Redis full of unprocessed jobs perhaps?
Screenshot

Steps to reproduce:

1.Open a page with VE
2.Insert a template Top, specify a bg color code so you can see the effect better on CE.I tried with #FFFFE0
3.Now click on Insert and Save the page
4.You will see the entire content after that template (until references list) gets added as a Content section for that template and inherits the styling specified in the template parameters.
5.Reopen the page
6.Reopen the transclusion dialog for that template
7.Click on the Delete icon to remove the template "Top" to just retain the usual format of the text.
8.Click on "Apply Changes"
9.Now when you are back to CE, try to place your cursor on the content which was part of that template

Observed Result:
It throws the following error on each click:


Uncaught TypeError: Cannot read property 'right' of null
Uncaught Error: ve.dm.Document.getNodeFromOffset(): offset 85 is out of bounds 

Page:https://en.wikipedia.org/wiki/User:RYasmeen_(WMF)/sandbox?veaction=edit

--------------------------
**Version**: unspecified
**Severity**: normal

**Attached**: {F14694}
The Sub-heading 4 font as shown in the Text Style drop-down does not match with the other Sub-headings in it.

Screenshot:
{F25185708}
(old screenshot: F15333)

Task: Update the styles for VisualEditor's "Format" dropdown when using the [MonoBook](https://www.mediawiki.org/wiki/Skin:MonoBook) [skin](https://www.mediawiki.org/wiki/Manual:Skins), so that the text size for headings inside the dropdown is the same as their size on the page.
Confirmed - Sub-headings(started with Sub-heading 1) are decreasing proportionally like this: 130, 115, 100(for Sub-heading 3). However, for Sub-heading 4 - it has font-size: 80% instead of 85%. 

Look at the attached screenshot where Sub-heading 4 has font-size: 85% - it looks much more proportional relative to other Sub-headings.
Created attachment 17076
monobook Sub-heading 4 with font-size 85%

**Attached**: {F15334}
It's not obvious to everyone that you can click the wikitext warning to make it go away.  Please add an 'X' or something that makes it look like you should click on it if you don't want it to be there.

--------------------------
**Version**: unspecified
**Severity**: enhancement
Adding close buttons / etc. to MediaWiki's notice system is bug 40307. Merging this into that rather than duplicating.

*** This bug has been marked as a duplicate of bug 40307 ***
A thing that happens to me frequently is that I paste the title of another article. When this happens, it's formatted as a heading. This is correct HTML-wise, but it's never what I mean - I usually mean to paste it as plain text or as a link.

It would be nice if the VE vould guess it.

A long shot, I know, but it happens to me a lot and I wanted to write it down :)

--------------------------
**Version**: unspecified
**Severity**: enhancement
One could debate whether copying within a heading should write plain text to the clipboard, but then there is a common edge case where you select the whole heading, i.e. <h1>|word|</h1>. It's probably 50/50 what the user intends to happen when they paste. CTRL+SHIFT+V does what you need here, but maybe there could be a way to surface this after the fact ("this text was just pasted with formatting - click here to remove").
In the public weekly triage on 2015-04-29, we discussed this task. We decided that this task is not the right approach as stated, so we rejected it for the quarter's blocking list.
>>! In T72519#768508, @Jdforrester-WMF wrote:
> So this is "if paste is an <h1> with id of firstHeading, instead paste a <p>"? OK.

Well, this is the most frequent DWIM-style thing I can think of. Happens to me almost every time I edit an article.

I can imagine other DWIMmy things, but resolving just the <h1> issue would be a huge improvement for me.

And it probably shouldn't be a <p>, but simply match the surrounding markup, whether it's <h2>, link, etc.
(In reply to Amir E. Aharoni from comment #0)
> A thing that happens to me frequently is that I paste the title of another
> article. When this happens, it's formatted as a heading. This is correct
> HTML-wise, but it's never what I mean - I usually mean to paste it as plain
> text or as a link.
> 
> It would be nice if the VE vould guess it.
> 
> A long shot, I know, but it happens to me a lot and I wanted to write it
> down :)

So this is "if paste is an <h1> with id of firstHeading, instead paste a <p>"? OK.
We'll need a way of editing these for the rare but useful block-level editing concepts that sometimes crop up.

--------------------------
**Version**: unspecified
**Severity**: enhancement
The terminology between WikiEditor (aka "Advanced toolbar") and VisualEditor MUST be consistent so people will not get confused.

For example in VisualEditor there is "Cite" menu, while in WikiEditor it is called "Reference" (Cite options in enwiki is only a gadget). It is super important, so we can guide new editors with same terminology. If you don't like the old terminology in some cases - use new one, but fix the WikiEditor to use it too.


[Longer story]
Today I participated in a workshop for new editors. We told the new editors they should use either VE or classic wikitext, and gave them printed instructions what to do, and they got confused of it...
[The first time ever for me to open terminology bug, yay :)]

Suggested terminology
| VE | classic edit (including WikiEditor) | Suggestion | Description
| Review your changes | Show changes | Show changes 
| Cite | Reference | Reference | Cite may have disambig with quote. Both buttons are actually for adding reference/source
| Media | Embedded file (title), Insert file (dialog title) | Media | Media is more specific than file (e.g it doesn't mean you can upload article as txt file)
| Heading, Sub-heading 1, Sub-heading 2... | Heading, Level 2, Level 3 | Heading, Sub-heading 1, Sub-heading 2... 
| Search pages (in link dialog) | Target page (in link dialog) | Target page 
| External link (link dialog) | URL (link dialog) | External link | Not sure what is better. URL seems to be more technical
Screen cast of the sequence

When editing a page with an infobox on the side, header lines that ended on the infobox does not expand to full width if content added above them pushes them down below the infobox. 

The opposite works thouhg, i.e. deleting content so a header lines move up shortens the header line so that they do not overlap the infobox.

--------------------------
**Version**: unspecified
**Severity**: trivial

**Attached**: {F14886}
screenshot

1> open a page in VE, insert a link. And after a space or two, insert some Language style text. 
2> Now place the cursor at the end of the line and move along the line, the cursor jumps to the start of the line when it reaches the first character of the language style text .See screenshot.

--------------------------
**Version**: unspecified
**Severity**: minor

**Attached**: {F14760}
Confirmed. The structure of a line is like the following:
*link* some text *lang text*

A cursor that moves from left to right(placed at the beginning of *link*) will go through the inserted link, then the text, and then through language style text. 

A cursor that is placed at the end of  *lang text* and then moved from right to left, will jump to the beginning of the line - which is a bug. 

There is a workaround for editing the text between a link and lang style text  - just place a cursor inside it.
Environment- test2
so if i want to edit some text present in between a link and the language style text, i cannot do it.
{F14756}
1> open a page in VE, insert a comment.
2> Click to edit the comment and insert a link. Notice the link icon is selected in the toolbar, although no link gets inserted in the comment . Try the above steps, with Formula and text styles like Underline, Strikethrough. See screenshots.
I disagree. Disabling the surface (greyed out, like we do for dialogs) suggests the surface isn't active. Disabling individual tools (greyed out, like we do when the selection is a table range) suggests the tool can't work where the user believes the cursor is currently.
Inspectors are non-modal so opening them keeps the selection in the surface, and so you can still use all the tools.

Disabling the tools would suggest that the surface selection is no longer active which is not true.
Confirmed - as the attached screenshots indicate - link, and some style formats - e.g. Bold, Italic, Underline - make an impression that they can be applied to  Comments or Formulas. 

IN fact, clicking Formatting options or insert link have no effect on inserted Comments or Formulas.
Environment-test2
Created attachment 16353
screenshot2

**Attached**: {F14757}
Screenshot of embeded video

I think it would be better to distinguish better videos and pictures:
a) in media selection
b) in the text itself

a) if Id like to add video, I am not able to determine, which previous in media selections are videos and which not. Thus I must go to Wikimedia Commons anyway and add it like a unique filename.

b) attached screenshot shows, I add somethink and it still looks like an image - even its a video file.

--------------------------
**Version**: unspecified
**Severity**: enhancement

**Attached**: {F14720}
This is really two bugs, and should be split, but leaving for now…
(In reply to Andre Klapper from comment #1)
> Created attachment 16341 [details]
> Screenshot from Firefox 31, no problems
> 
> Which browser and version is that (such information is always welcome)? No
> problems here to get the "Play" button overlay with Firefox 31 on Linux, see
> screenshot.

But there is a small difference. Your screenshot is from "read" verstion, mine is from "edit".

 
> Still, what's the usecase of knowing in VisualEditor if it's a video or
> image? That you don't want to add another video if there is already one?

Well, you want to know if you are adding video or image.

**Attached**: {F14721}
Sigh. VE! Confirming. I should get more coffee. 
Sorry for all the noise. Ignore my last two comments please.

Still, what's the usecase of knowing in VisualEditor if it's a video or image? That you don't want to add another video if there is already one?
[Rephrasing bug summary; please insert browser & version there]
Created attachment 16341
Screenshot from Firefox 31, no problems

Which browser and version is that (such information is always welcome)? No problems here to get the "Play" button overlay with Firefox 31 on Linux, see screenshot.

**Attached**: {F14721}
When a template doesn't have a description in TemplateData, a link is shown to the template's page in the Template namespace (using the visualeditor-dialog-transclusion-no-template-description message).

This link is very useful.

I don't see such a link when a template does have a description. Compare, for example, how adding {{Reflist}} is different from adding {{LGBT Welcome}}.

For advanced users the description in TemplateData is not a replacement for the whole page, so there should always be a link to the template page.

--------------------------
**Version**: unspecified
**Severity**: enhancement
1. Sign up with a new username to a Wikimedia site.
2. Edit an article and add an external link.
3. Try saving.

After entering an edit summary and pressing the button in the dialog, the dialog remains and the CAPTCHA is shown in its bottom. At least on my machine, I need to scroll down in the dialog to actually see the CAPTCHA. I saw new users puzzled over this - they thought that they already pressed the save button and couldn't understand why is the dialog still there.

--------------------------
**Version**: unspecified
**Severity**: normal
VisualEditor doesn't have any magic way to bypass it, are you sure it saved successfully and that nothing else changed?
>>! In T72266#1384881, @jayvdb wrote:
> So the steps as an anon (should be the same?) are:
> 1. Edit using VE as an anon http://enwp.org/User:Elitre/Sandbox?veaction=edit
> 2. Add an EL http://blah.com/foo
> 3. step through the save process
I received a captcha when using the source editor but not with the visual editor.
>>! In T72266#1384974, @Amire80 wrote:
> Try it on a smaller screen. A lot of people still use 1024×768 or even smaller screens.
> 

I get exactly the same result in an 800x600 window

{F181476}

> How about putting it above the edit summary or instead of it?

My suggestion, would be to highlight the text-input-box, which is currently hard to detect underneath the CAPTCHA. 
Not that the current wikitext version is much better...
{F181482}


Sidenote: There's also {T54133} which if implemented will help reduce the size of that entire save window (and also fix T50274 - the missing autocomplete dropdown of previously used editsummaries (if someone let's their browser remember form-history. madness!))
Try it on a smaller screen. A lot of people still use 1024×768 or even smaller screens.

How about putting it above the edit summary or instead of it?
>>! In T72266#1384881, @jayvdb wrote:

Hey, thanks a lot for testing!

> So the steps as an anon (should be the same?) are:

I assume so, since the captcha is triggered then as well.

> 1. Edit using VE as an anon http://enwp.org/User:Elitre/Sandbox?veaction=edit
> 2. Add an EL http://blah.com/foo
> 3. step through the save process
> 
> It should show
> "Warning:
> CAPTCHA: To edit this page, please enter the words that appear below in the box (more info):"
> 
> And image appears below it.
> 
> Ive tried in twice on Chrome and once on Firefox. Two times it worked; once when I tried it on Chrome (Fedora 20; 43.0.2357.81), the warning appeared and the image didnt.
> 
> The warning should not be shown until the image is shown, and if the image doesnt arrive, it should display an error message.

I think this is a different issue then? (and maybe one with javascript?) Amir says that he needs to scroll down to see the captcha. In all my tests, the captcha is always immediately visible (as in Nick's second screenshot).
Which OS do you have? Mine is Win 7 (I'll test in my Macbook Air later). 

> 
> Also, it never shows the 'refresh' link to get another CAPTCHA, which is often necessary when the CAPTCHA is unreadable.  I checked and the 'source editor' has that.  Probably a separate bug.
The CAPTCHA is appearing in the visible area, for me. Only the previously visible licensing info (which needs to have been read before clicking "Save" anyway!) gets scrolled out of view:

{F181350}
{F181349}

So possibly this particular task needs to be retitled or refined?

I've confirmed there's no refresh. Filed as {T103227}
So the steps as an anon (should be the same?) are:
1. Edit using VE as an anon http://enwp.org/User:Elitre/Sandbox?veaction=edit
2. Add an EL http://blah.com/foo
3. step through the save process

It should show
"Warning:
CAPTCHA: To edit this page, please enter the words that appear below in the box (more info):"

And image appears below it.

Ive tried in twice on Chrome and once on Firefox. Two times it worked; once when I tried it on Chrome (Fedora 20; 43.0.2357.81), the warning appeared and the image didnt.

The warning should not be shown until the image is shown, and if the image doesnt arrive, it should display an error message.

Also, it never shows the 'refresh' link to get another CAPTCHA, which is often necessary when the CAPTCHA is unreadable.  I checked and the 'source editor' has that.  Probably a separate bug.
I haven't been successful so far in finding a way to replicate (I tested several times in these months and couldn't replicate in IE, FF, Opera or Chrome. TBH, rather than creating a new account, I just use incognito window because I was testing a report from an IP user).
I'm inclined to think that this may have been fixed by some design changes, but if it's still occurring for any of you and you can please post details of how you manage to reproduce it, I'd be happy to mark it as a "blocker".
I see closed tasks T52356 and T64766, but no other tasks relating to CAPTCHA, either open or closed.  Is this well covered by test scenarios?
If VE is going to be rolled out to new editors, surely this must be a high priority?
https://en.wikipedia.org/wiki/Wikipedia:Village_pump_%28proposals%29#Gradually_enabling_VisualEditor_for_new_accounts
The design and accessibility keywords aren't sufficient to cover cases where usability is the main hurdle.

Be it an existing implementation that is hard to use and needs input to improve it, or a new feature/bug that is blocked on having an intuitive interface.

In cleaning up bugs I often see this word in the title but would be interested in giving it its own keyword for interested parties (especially the Wikimedia UX team) to look at.

--------------------------
**Version**: wmf-deployment
**Severity**: enhancement
My main question was how/why the design keyword is not sufficient and what's the differentiation that users would need to understand to set those two keywords correctly.
(In reply to Andre Klapper from comment #1)
> I'm against this.
> I have not seen a single bugtracker where users understood the narrow frame
> of "usability". Instead, everything was randomly tagged with that keyword.
> "The server was down so I couldn't use it, hence a usability issue" style.
> 
> In my understanding, an intuitive interface needs proper design. 
> If the "design" keyword is not sufficient, please elaborate why that is the
> case.

One could make the same argument about lots of components and keywords (accessibility, design, javascript, parser, i18n; VisualEditor; Page editing; Any of those will be affected by other factors). I don't see how it's relevant that users may use it incorrectly. That happens all the time. That's why we triage bugs.

Anyway, not my problem.
I'm against this.
I have not seen a single bugtracker where users understood the narrow frame of "usability". Instead, everything was randomly tagged with that keyword. "The server was down so I couldn't use it, hence a usability issue" style.

In my understanding, an intuitive interface needs proper design. 
If the "design" keyword is not sufficient, please elaborate why that is the case.
**Author:** `bsitu`

**Description:**
It throws invalid workflow exception

---
See {T88908}.

--------------------------
**Version**: master
**Severity**: normal
>>! In T72148#1205755, @Arcane21 wrote:
> Parsoid is extremely resource intensive, even on small setups, and while the WMF may be able to easily ignore this, many smaller non WMF setups would not be able to do so, and I have to confess I'm greatly interested in introducing Flow to the Orain wiki farm (which I serve at as a staff member), but I'd rather we not have to have to acquire much more resources than we use currently to support Flow.

To determine whether it's overly resource-intensive, you would have to compare it to other software that does the same thing: Bidirectional conversion of editable HTML to wikitext.

The reason node.js was used for Parsoid is that investigation showed it was //far// more performant than the same thing would be in PHP.  There's no identical implementation of the current Parsoid in PHP (since no one chose to write one).  However, this has almost certainly not changed.

>>! In T72148#1211295, @FastLizard4 wrote:
> With a tool like VisualEditor, it's obvious why Parsoid needs to be required, but I don't see why Flow by itself //needs// to have access to the powerful parsing tools Parsoid provides, especially given that Parsoid is still experimental and is rapidly changing.

Though VisualEditor is not required (either for wiki operators installing Flow or for individual Flow end users), VE is a key part of the vision for Flow (that's why we use Parsoid to begin with).  That means, for example, we now use VE for previewing (so no preview without Parsoid).
Changing my token to make clear my opinion is the same as @Arcane21's one.
This issue has been fixed for awhile now. AFAIK, everything currently works in wikitext storage.
I definitely see both sides of the argument here.  I agree that, in most cases, maintaining two versions of key parts of a single piece of software is quite costly.  However, as a small wiki operator myself, I feel that at this point, restricting Flow to Parsoid-only would only hurt wide adoption, because at this point, Parsoid is still rather experimental (definitely at least "Beta" software).

With a tool like VisualEditor, it's obvious why Parsoid needs to be required, but I don't see why Flow by itself //needs// to have access to the powerful parsing tools Parsoid provides, especially given that Parsoid is still experimental and is rapidly changing.  At least until Parsoid becomes stable and ready for mass release, I would say that giving sysadmins the opportunity to be able to use Flow without needing Parsoid is important, even if it does increase the cost of Flow development.
>>! In T72148#1179439, @Arcane21 wrote:
> I strongly disagree with dropping non Parsoid support. Parsoid is incredibly costly, and while I would love to switch my LQT enabled wiki to Flow, I have no desire to install costly backend software to do so, nor would many smaller non WMF wikis with more limited resources, and if it means it performs less optimally, I would consider that an acceptable compromise to retain non Parsoid functionality.

Costly in what way, exactly?

* Requires a lot of man-hours to install?
* Difficult to maintain?
* Requires high-end services or equipment to run?

Maybe there's a way Parsoid could be easier for you to use.

The main reason we want to remove support for non-Parsoid is that it is costly (mainly in software engineer time) to maintain two versions of key parts of the code.
I strongly disagree with dropping non Parsoid support. Parsoid is incredibly costly, and while I would love to switch my LQT enabled wiki to Flow, I have no desire to install costly backend software to do so, nor would many smaller non WMF wikis with more limited resources, and if it means it performs less optimally, I would consider that an acceptable compromise to retain non Parsoid functionality.

LQT was thrown under the bus, more or less, because the WMF found Flow to be a better long term solution, and I would rather the WMF take more time to ensure non Parsoid fallback compatibility (which is advantageous to the WMF if Parsoid fails for some reason) than to eliminate any failsafes and disadvantage any other wikis wishing to use Flow.
I strongly disagree with dropping non Parsoid support. Parsoid is incredibly costly, and while I would love to switch my LQT enabled wiki to Flow, I have no desire to install costly backend software to do so, nor would many smaller non WMF wikis with more limited resources, and if it means it performs less optimally, I would consider that an acceptable compromise to retain non Parsoid functionality.
>>! In T72148#1072830, @Ricordisamoa wrote:
>>>! In T72148#730402, @coren wrote:
>> In my specific usecase I was able to switch to html format at little cost or effort; but it would seem to me that a hard dependency on Parsoid is going to severely restict the number of non-WMF sites who can deploy that otherwise very valuable extension.
>> 
>> I don't get to set priorities on dev time, but I'm pretty sure that dropping wikitext markup would be a Bad Idea™
> 
> Sure. Medium and small-sized wikis may just want a better discussion system without being willing to install Parsoid or VisualEditor.

The problem is, no one is testing the non-Parsoid configuration much.  As far as I know, there is no automated browser testing for that configuration.  And I don't even know of anyone regularly using wikis with the non-Parsoid configuration and reporting back (informally or formally).

It's better to have one well-tested path, then two paths, one of which sorta works but has random breakage that doesn't immediately get caught.  This also requires maintaining extra code.

That's why we are leaning towards eliminating it ({T88908}).
>>! In T72148#1072844, @EBernhardson wrote:
> MediaWiki is moving to soa, parsoid will likely be one of several services wikis require for various features.  The best solution is going to be working with the SOA team to ensure making services available works with your use case.

The effort in librarization is valuable, but it seems that just running a simple MediaWiki is going to get harder and harder...
MediaWiki is moving to soa, parsoid will likely be one of several services wikis require for various features.  The best solution is going to be working with the SOA team to ensure making services available works with your use case.
>>! In T72148#730402, @coren wrote:
> In my specific usecase I was able to switch to html format at little cost or effort; but it would seem to me that a hard dependency on Parsoid is going to severely restict the number of non-WMF sites who can deploy that otherwise very valuable extension.
> 
> I don't get to set priorities on dev time, but I'm pretty sure that dropping wikitext markup would be a Bad Idea™

Sure. Medium and small-sized wikis may just want a better discussion system without being willing to install Parsoid or VisualEditor.
**gerritadmin** wrote:

Change 169711 had a related patch set uploaded by Matthias Mullie:
(bug 70148) Fix new topic creation with wikitext storage

https://gerrit.wikimedia.org/r/169711
In my specific usecase I was able to switch to html format at little cost or effort; but it would seem to me that a hard dependency on Parsoid is going to severely restict the number of non-WMF sites who can deploy that otherwise very valuable extension.

I don't get to set priorities on dev time, but I'm pretty sure that dropping wikitext markup would be a Bad Idea™
https://www.mediawiki.org/wiki/Extension:Flow#Dependencies mentions this bug, and emphasizes the html format with Parsoid is what WMF uses and tests.

We could drop wgFlowCoptentFormat = wikitext if it makes life easier...
The data currently returned by the imageinfo API assigns the author to "artist" and the source to "credit". Both of these are incorrectly labeled. In particular these labels make it difficult to figure out the proper attribution for the image, as it sounds like you should use "credit", but you should actually use "artist".

https://en.m.wikipedia.org/w/api.php?action=query&format=json&prop=imageinfo&titles=File%3ALiber_Eliensis%2EPNG&iiprop=url%7Cextmetadata

--------------------------
**Version**: master
**Severity**: normal
Tgr's patch has been sitting in Gerrit for four months without comments / review. 
How to proceed / who to review?
Change 231505 had a related patch set uploaded (by Gergő Tisza):
Rename extmetadata labels to be more intuitive

[[https://gerrit.wikimedia.org/r/231505]]
@Tgr: I would suggest changing:
* Artist to Author
* Credit to FileSource (https://gerrit.wikimedia.org/r/#/c/107368)
* ImageDescription to FileDescription
And possibly:
* UsageTerms to LicenseLongName
@Tgr: I would suggest changing:
* Artist to Author
* Credit to FileSource (https://gerrit.wikimedia.org/r/#/c/107368)
* ImageDescription to FileDescription
The rest look fine to me.
Still, the first step should be to come up with the names :)
MedaViewer, OCG, MobileFrontend/mobile apps, VisualEditor are the big ones AFAIK. There are a bunch of gadgets, bots and other tools - [[ https://github.com/search?utf8=%E2%9C%93&q=extmetadata+imageinfo&type=Code&ref=searchresults | this search ]] should find the ones on GitHub. We could also just log useragents for a while.
https://gerrit.wikimedia.org/r/#/c/107368/ mentions updaing "all known clients". Do we already have a list? A first step seems to make one.
Announce it on [[http://lists.wikimedia.org/pipermail/mediawiki-api-announce/|mediawiki-api-announce]], if you can't maintain BC for the old names.
Given how much the structured data project lags behind, I would be inclined to fix this now. @Anomie, is there any guidance on how such a breaking change to the API should be handled?
See T59189#605222 for the rationale behind the field names. In hindsight, I agree it was the wrong decision, but I am not sure it is worth changing all the field names now - the API has other serious limitations and will be eventually superseded by the structured data API when wikibase will be introduced to Commons.
See bug 57189 comment 1 for the rationale behind the field names. In hindsight, I agree it was the wrong decision, but I am not sure it is worth changing all the field names now - the API has other serious limitations and will be eventually superseded by the structured data API when wikibase will be introduced to Commons.
Not an API bug, it's just returning what deeper layers of MediaWiki give it. It sounds like you want the CommonsMetadata extension.
**Author:** `gryllida`

**Description:**
from bug 54730#c3
>The general design principle in MediaWiki is to only show functional user interface elements (for example, unprivileged users are not shown a delete tab or a protect tab)

I would like MediaWiki to not expose any features which require JavaScript when it is off.

This means, for instance, not showing visual editor's edit tab, bug 69779  (noting 'requires javascript' where necessary in the beta tab).

I hope to succeed in making this a tracking bug for enforcing the above-quoted design for the "no JS enabled" case.

--------------------------
**Version**: 1.24rc
**Severity**: enhancement
It certainly should not expose dead links (e.g. it would be bad if you saw a VE edit link, and clicking it did nothing).  We're fixing a similar issue in a non-deployed feature right now, in fact.

My understanding is that with bug 69779, you are requesting that "this feature requires js" is shown especially when JS is disabled.  This makes sense, and the current intended behavior (as far as I can tell from reading the code) is that it shows only when JS is disabled.  As far as I can tell, it *does* show when JS is disabled.  You have not replied there to my latest comment and screenshot.

There is a glitch where it *also* shows when JS is enabled (bug 69823) in some cases.

Note, I don't think this preference behavior is clearly described by "not expose any features".  We want to make them aware (could be described as "expose") of JS-only features, but make it clear such feature can not be used without JS.

Tweaking the title and adding a depends accordingly.
[There are probably quite some open tickets already that could be marked as blocking this one]
**gryllida** wrote:

Which is probably stupid (visualeditor already does not show the edit tab when js is off; I misread earlier)
Especially when there are only categories on the page, it does not appear to be possible to put text above the categories.  The result is things like this:

http://en.wikipedia.beta.wmflabs.org/w/index.php?diff=122314&oldid=51987

which is not normally wanted.

--------------------------
**Version**: unspecified
**Severity**: minor
The saved page will display the text above categories. Only "Difference between revisions" misleadingly places the typed text under the categoreis.
That will be deployed next week, per the usual schedule. This task is not entirely fixed -- the tabs will still expand and collapse once on page load if you're using an unfortunate screen resolution. But correcting that is more difficult :/
Change 331919 merged by jenkins-bot:
collapsibleTabs: Stop the tabs from collapsing back and forth forever

[[https://gerrit.wikimedia.org/r/331919]]
This doesn't fix the issue entirely, but it should reduce it to mildly annoying. The tabs might still collapse back-and-forth once, but after that happens the code will update some internal calculations, and it should prevent the tabs from flapping forever.
Change 331919 had a related patch set uploaded (by Bartosz Dziewoński):
collapsibleTabs: Stop the tabs from collapsing back and forth forever

[[https://gerrit.wikimedia.org/r/331919]]
This has also been reported to us in OTRS, and I can easily reproduce it (at least in incognito mode) on local file description pages like https://de.wikipedia.org/wiki/Datei:Otzenrathpano2.jpg?uselang=de. So I'd also like to echo that this issue is easy to run into at the moment, which makes me wonder if this should really be treated as a low-priority issue.
Grabbing some popcorn and selecting the `<li id="ca-edit">` element in Firefox' dev tools, things seem to happily jump around between three states: `display: list-item` with `right: 0px` not being applied, replaced by `display: block` with `left: 0px` not being applied and vice versa; plus only very occasionally also the 3rd screenshot with `div.vectorTabs` not being in the game at all:
{F5228098}
F5228098
I'm getting this on my non-existent user page (which is copied from Meta) at mediawiki.org in Firefox 50, with "Show me both editor tabs" enabled.  I can't trigger it without this setting.  With that setting, on a non-existent userpage, there are three long descriptions in tabs at the top of the page, and the last hides and un-hides repeatedly.  

My browser window right now is about 1428 pixels wide.  To trigger it in English, I need to zoom in twice.  The default zoom triggers it in Russian.  Zooming in once or twice triggers it with the UI set to German.  So (the point of this message) if you aren't seeing it in your browser, then you might try enabling two tabs, switching to a couple of different languages with `?uselang=xx`, and/or zooming in and out a couple of steps.
I'm getting this on my non-existent user page (which is copied from Meta) at mediawiki.org in Firefox 50, with "Show me both editor tabs" enabled.  I can't trigger it without this setting.  With that setting, on a non-existent userpage, there are three long descriptions in tabs at the top of the page, and the last hides and un-hides repeatedly.  

My browser window right now is about 1428 pixels wide.  To trigger it in English, I need to zoom in twice.  The default zoom triggers it in Russian.  Zooming in once or twice triggers it with the UI set to German.  So (the point of this message) if you aren't seeing it in your browser, then you might try enabling  switching to a couple of different languages with `?uselang=xx` or zooming in and out a couple of steps.
I noticed the problem today for the first time on my PC (Chromium), before I had experienced it only on the tablet. It happened with a user page on de.wiki that derived from meta, a similar case as the above mentioned.
I've tried to reproduce locally without success

`File:Opening Karte_Gemeinde_Gommiswald_2013.png?uselang=de` with private browsing, with latest master of MediaWiki and Vector, with InstantCommons enabled, and adding this to LocalSettings.php to mimick the addition of the third tab (to avoid installing VisualEditor):

```
function test_onSkinTemplateNavigation_Universal( &$sktemplate, &$links ) {
        $links['views']['whatever'] = [
                'class' => 'collapsible',
                'text' => 'Lokalen Beschreibungsquelltext hinzufügen',
                'href' => '#'
        ];

        if ( isset( $links['views']['edit'] ) ) {
                $links['views']['edit']['primary'] = true;
        }
}

$wgHooks['SkinTemplateNavigation::Universal'][] = 'test_onSkinTemplateNavigation_Universal';
```

In one tab, dewiki page, in other tab my local wiki. On dewiki the bug happens, on my local wiki it doesn't. Texts and dimensions of the tabs are the same. The generated HTML for both (before running JavaScript) is equivalent.

So the only variable that is left here that might cause the problem is Visual Editor. But why?
> Judging by the number of reports, this has started happening more frequently for some reason.
Indeed.

As I don't get the effect in the link of the initial description here is an other example: 
https://de.wikipedia.org/wiki/Datei:Karte_Gemeinde_Gommiswald_2013.png.
The animation-loop happens from the start (without changing window-width).

Firefox v.50: `1173px` to `1428px`
Chromium v.53: `1113px` to `1341px`  (witch are quite average widths)
Might have been caused by https://phabricator.wikimedia.org/rSVEC1f26153a5d77584508f8bbd10478e8d8021ccb42
Judging by the number of reports, this has started happening more frequently for some reason.
As far as I can tell (T108588#1640647) FlaggedRevs prevents VE from using the desired labels for editing tabs on server side, thus forcing VE to modify them on client side, triggering this bug.
No, FlaggedRevs doesn't do that, and is not affected. To my knowledge, VisualEditor is the only tool that's causing this.
>>! In T71729#2878053, @Jdforrester-WMF wrote:
> This is not VE-specific, right? Anything that adjusts the tabs after the PHP layer is done with it, like FlaggedRevs and some gadgets, has this problem?

True, the VE-specific bug (see T71729#1611561) is T108588
This is not VE-specific, right? Anything that adjusts the tabs after the PHP layer is done with it, like FlaggedRevs and some gadgets, has this problem?
I got this today when reviewing changes from article's history one by one and the FlaggedRevs' "Pending edits" tab probably interfered.
>>! In T71729#1611561, @Ciencia_Al_Poder wrote:
>If that's not supported, VisualEditor shouldn't be doing that, right?

Indeed. That JavaScript is there in case the server failed to do it correctly (or in case of cached html). Looks like the ru.wikipedia.org configuration is not supported correctly by the server-side equivalent of that code.

https://github.com/wikimedia/mediawiki-extensions-VisualEditor/blob/667d8d9935/VisualEditor.hooks.php#L136-L175

> ```lang=php
>	$tabMessages = $config->get( 'VisualEditorTabMessages' );
>	..
>	if ( .. ) {
>		$editTabMessage = $tabMessages[$action . 'localdescriptionsource'];
>	} else {
>		$editTabMessage = $tabMessages[$action . 'source'];
>	}
> ```
Well, that VE thing seems to be tracked on T108588 instead
>>! In T71729#1027038, @Krinkle wrote:
> Changing the value of existing tabs is not supported. Can you provide an example or use case where this happens?
> 
> Such customisations (if desired) should be done upstream as part of Vector, or at least done server-side (e.g. by changing the MediaWiki namespace message for it, or by creating a hook in your LocalSettings configuration).

Reported again in T111601, Cokersed shows a nice video of it http://elric.ga/files/out-1.ogv

I see that on initial page load, there are 2 "edit" tabs with the same text: `Править`. Then, once the page finishes loaded, the text of the "not-ve edit" is changed to `Править вики-текст`

I've inspected a bit of JS and I see that it seems to be changed by #VisualEditor

https://ru.wikipedia.org/static/1.26wmf21/extensions/VisualEditor/modules/ve-mw/init/targets/ve.init.mw.DesktopArticleTarget.init.js

```
			// Alter the edit tab (#ca-edit)
			if ( $( '#ca-view-foreign' ).length ) {
				if ( tabMessages[ action + 'localdescriptionsource' ] !== null ) {
					$caEditLink.text( mw.msg( tabMessages[ action + 'localdescriptionsource' ] ) );
				}
			} else {
				if ( tabMessages[ action + 'source' ] !== null ) {
					$caEditLink.text( mw.msg( tabMessages[ action + 'source' ] ) );
				}
			}
```

If that's not supported, Visual Editor shouldn't be doing that, right?
>>! In T71729#1027038, @Krinkle wrote:
> Changing the value of existing tabs is not supported. Can you provide an example or use case where this happens?
> 
> Such customisations (if desired) should be done upstream as part of Vector, or at least done server-side (e.g. by changing the MediaWiki namespace message for it, or by creating a hook in your LocalSettings configuration).

Given T108588, does VisualEditor change the tabs on client-side? If so, this definitely isn't "Lowest" priority.
Changing the value of existing tabs is not supported. Can you provide an example or use case where this happens?

Such customisations (if desired) should be done upstream as part of Vector, or at least done server-side (e.g. by changing the MediaWiki namespace message for it, or by creating a hook in your LocalSettings configuration).
Steps to reproduce:

1.  Open a page that contains an image that has a really long or complicated name.

2.  Think, "Hey, I could use that image over at ______ article, too."

3.  Click on the image.  What's its name?  Well, it starts off as File:Foo bar baz bat... but who knows what the rest of it is.


It would be nice to be able to see the entire name of the image and to copy that name as well.

--------------------------
**Version**: unspecified
**Severity**: enhancement
I added `[[File:Diederich Graminaeus (1550-1610). Beschreibung derer Fürstlicher Güligscher ec. Hochzeit (Johann Wilhelm von Jülich-Kleve-Berg ∞ Jakobe von Baden-Baden, Hochzeit in Düsseldorf im Jahre 1585), Köln 1587, Ringrennen am 18. Juni 1585 in Pempelfort.jpg]]` to my page, loaded it in VE and looked at the media dialog. I could see and copy the whole thing, so I assume this got resolved at some point.
Being able to copy it from the tooltip would work for me, for example.
When adding a template to a page, the window title is "New template". This is quite confusing. Some users complained that it sounds like creating a whole new template.

Please consider retitling it to something like "Add a template".

--------------------------
**Version**: unspecified
**Severity**: trivial
Change 155448 merged by jenkins-bot:
Re-label inserting mode of transclusion dialog from "New template" to "Add a template"

https://gerrit.wikimedia.org/r/155448
Change 155448 had a related patch set uploaded by Jforrester:
Re-label inserting mode of transclusion dialog from "New template" to "Add a template"

https://gerrit.wikimedia.org/r/155448
https://en.wikipedia.org/wiki/Dachshund#Coat_and_color has a complex gallery tag:

<gallery widths="200px" heights="200px" perrow="5" caption= "There are three types of dachshund, which can  be classified by their coats: short-haired, called "smooth"; long-haired; and wire-haired">
File:Wirehaired_Dachshund.jpg|A wire-haired dachshund
File:Kurzhaardackel.jpg|A short-haired dachshund
Std Dachshund 600.jpg|A long-haired standard dachshund
File:Piebald.jpg|A piebald dachshund
File:Red-merle smooth Dachshund.jpg|A dapple dachshund</gallery>


It's being displayed as raw wikitext in VisualEditor on desktop.

--------------------------
**Version**: unspecified
**Severity**: normal
**See Also**:
https://bugzilla.wikimedia.org/show_bug.cgi?id=66065
We now have a bunch of tasks that are all about how best to handle broken attribute strings. Parsoid will not always match the PHP parser on this, and this is no longer a high priority task for us. At this point, tt seems reasonable to have these be fixed up in wikitext.
*** Bug 66065 has been marked as a duplicate of this bug. ***
I imagine this is probably not that uncommon since template args and template content may use the same quotes and thus break the html tags. We've seen a few different instances of this bug now. So, maybe worth investigating what it takes to handle this form of broken wikitext a bit more leniently.
This is invalid wikitext – you can't use raw " characters inside the caption of a gallery. Parsoid works just fine if you replace them with ' characters instead:

<gallery widths="200px" heights="200px" perrow="5" caption= "There are three
types of dachshund, which can  be classified by their coats: short-haired,
called 'smooth'; long-haired; and wire-haired">
File:Wirehaired_Dachshund.jpg|A wire-haired dachshund
File:Kurzhaardackel.jpg|A short-haired dachshund
Std Dachshund 600.jpg|A long-haired standard dachshund
File:Piebald.jpg|A piebald dachshund
File:Red-merle smooth Dachshund.jpg|A dapple dachshund</gallery>

I've fixed this in the article, but am moving the bug to Parsoid in case they want to comment/merge into a wider bug about escaping bad wikitext?
The keyboard shortcut styling is substantially different between the standalone demo and the MW integration in terms of font size. In MW, the font size is so much bigger that some shortcuts awkwardly break across lines. For instance, "Ctrl+Shift+V" is split with the "V" being on a line by itself. In SA, the font size is smaller (for the headings and the shortcuts, but not the descriptions) so this problem doesn't happen, but there the font feels a bit *too* small.

--------------------------
**Version**: unspecified
**Severity**: minor
Change 155539 merged by jenkins-bot:
Define kbd font-family explicity in case environment overrides

https://gerrit.wikimedia.org/r/155539
Change 155539 had a related patch set uploaded by Esanders:
Define kbd font-family explicity in case environment overrides

https://gerrit.wikimedia.org/r/155539
Ed likes fiddling with this dialog, so… :-)
When I go to "Enable Hovercards" to change my settings, it always defaults to "Read Quickly", even when I explicitly change it to "Monitor or Edit", save, then re-open the dialog to check the setting.

Tested in Firefox/Iceweasel 30.0

--------------------------
**See Also**: {T71576}
Thanks @Mattflaschen-WMF. I've updated that page to indicate that Navigation Popups takes precedence when both are enabled.
No longer applicable.

It's now just Disable/Enable.

There is another issue now (but it may be by design so I'm not filing yet): If you have the Navigation popups enabled, it always takes precedence.  Before, I think there was a way to switch back to Hovercards without explicitly disabling NAVPOP.

This is still documented at https://www.mediawiki.org/wiki/Beta_Features/Hovercards : "The Hovercards settings panel enables logged-out users to disable it entirely, and enables logged-in users to choose between Hovercards, Navigation popups, or disabling both.", but that might just be a doc bug.
@Mattflaschen-WMF I believe the options have changed. Would you please update the task Description as appropriate?
(In reply to Prateek Saxena from comment #3)
> I had forgotten why we had added the settings in the first place while we 
> were having our conversation. After speaking with Nick I remembered that 
> we'll be making it a default feature (for all logged in and logged out users) 
> on a few wikis that have shown interest.

It can still be a normal preference on those wikis, defaulted to true.  E.g. VisualEditor has multiple modes, including one where a regular preference is shown, and another where a beta feature is shown.

> Which is why we'll have to keep it the way it is. This pattern is being used 
> by ReferencePopups too which is a gadget that is enabled by default for all 
> users.

Gadgets have very different UX considerations, since they can not use normal preferences.

Note, currently (in production) I see both popups (I think this is meant to be fixed by https://gerrit.wikimedia.org/r/#/c/141668/ , not yet deployed) and no "Disable HoverCards" link when in "Read quickly mode".  This is arguably inconsistent, although you still have another way of disabling it (the gear).
I apologize for the confusion. I've been causing too many of them lately.
(In reply to Matthew in comment #2)

> We also talked about possible parts of the solution, including dropping "Turn Previews off" and relying on the standard BetaFeatures UI for disabling beta features.

I had forgotten why we had added the settings in the first place while we were having our conversation. After speaking with Nick I remembered that we'll be making it a default feature (for all logged in and logged out users) on a few wikis that have shown interest. 

Which is why we'll have to keep it the way it is. This pattern is being used by ReferencePopups too which is a gadget that is enabled by default for all users.



(In reply to Matthew in comment #0)

> When I go to "Enable Hovercards" to change my settings, it always defaults to "Read Quickly"

I think this is justified. The link says "/Enable/ hovecards" and not "Open settings" so it is correct for it to select that option.
This may not make sense to fix in isolation.

Prateek and I talked about some broader areas where the current UI may be confusing.

We also talked about possible parts of the solution, including dropping "Turn Previews off" and relying on the standard BetaFeatures UI for disabling beta features.  That then simplifies the internal preferences needed, which opens up possibilities.
This is tested on English Wikipedia on 1.24wmf16.
I met User:Zoony at Wikimania and he said that something which he'd love to see in VE is a way to deal easily with dead (rotten) links.
He suggested that a right click could launch a menu which provides access to several options, from searching on a search engine in a different tab (to try to fix one) to pasting the {{dead link}} template.
(More info about ways to deal with dead links at https://en.wikipedia.org/wiki/Wikipedia:Link_rot#Repairing_a_dead_link ).

--------------------------
**Version**: unspecified
**Severity**: enhancement
We wouldn't use right click for touch compatibility, but links have a complex context area now which we can add too:
{F2667021,size=full}
Ideas of things to scan for:

* Any request resulting in an error response (404 Not Found, 500 Internal Error, etc.).
* Uncaught JavaScript exceptions.
* Network requests made to third-party domains (images, stylesheets, scripts, xhr, etc.)

From comment 13 at {T71445} :
> However it would be great to have automated tests running after changes in common.js and gadgets. Such general tests can at least validate no external resource is loaded, or no invalid syntax is added.
> The simplest option is to run it outside MW (such as a script in labs that runs X times a day), but an extension to do it while editing would be even better...
> 
> BTW
> I just runned a simple phantomjs script on all wikipedia languages to catch simple errors:
> 
> testing als
> ERROR: ReferenceError: Can't find variable: ta
> TRACE:
> -> https://als.wikipedia.org/w/index.php?title=MediaWiki:If-pt-login.js&action=raw&ctype=text/javascript&dontcountme=s: 9
> 
> testing kk
> ERROR: TypeError: 'null' is not an object (evaluating 'document.getElementById('mw-vector-current-variant').innerHTML=wgULS("Кирил","Latın","توتە")')
> TRACE:
> -> https://bits.wikimedia.org/kk.wikipedia.org/load.php?debug=false&lang=kk&modules=site&only=scripts&skin=vector&*: 9
> 
> 
> anyone wants to fix them? :)
> 

From comment 14 at T71445:
> Example for errors across wikis
> Maybe it is a bit off-topic but here are some cases of errors across wikis in simple read/edit transaction using phantomJS

See also:
* {T71519}
* {T106770}
...and mentioning {T106770} here.
Not sure if that is a hard requirement and should be a dependency (subtask) here though
Replaced "PhantomJS" by "automated browser tests" in the task summary.

Reading through the comments here and trying to summarize the perfect world:
* run tests on all Wikimedia sites (gather from sitematrix)
* run tests on mainpage, editing page etc (via predefined urls), with debug=true
* allow test to be logged in
* enable / cover all available gadgets on the site
* cover MediaWiki:common.js on the site
* cover skins on the site
* maybe cover stuff like MediaWiki:Mobile.js or MediaWiki:Minerva.js or MediaWiki:Vector.js ?) on the site
* cover detecting code that calls 3rd party domains
I assume there is consensus to run such a test as a Jenkins job?

Also wondering if this could potentially be a Hackathon project. If e.g. legoktm's script can be used as a base.

For the records, aforementioned https://integration.wikimedia.org/ci/view/BrowserTests/view/Core/ and https://integration.wikimedia.org/ci/view/BrowserTests/view/-Dashboard/ are 404s nowadays. No idea if similar things are available on https://integration.wikimedia.org/ci/view/Default/ ...
>>! In T71519#1567266, @hashar wrote:
> @krinkle mentioned that PhantomJS is based on a completely outdated Webkit version

Yeah, we're rewriting asset-check on top of Chromium for that reason. Similar to what I did with our QUnit infrastructure in Jenkins. The APIs are similar though, so it's not that much work. See T106770.
See also {T101497}
@krinkle mentioned that PhantomJS is based on a completely outdated Webkit version that no more reflect the current browsers hitting the sites.  So I guess we can rephrase this task as being a smoke test for the production sites using modern browsers (chromium/firefox).

We have a bunch of browser tests hitting production already ( https://integration.wikimedia.org/ci/view/BrowserTests/view/-Dashboard/ )  and even a test suite for MediaWiki core although it is only hitting beta https://integration.wikimedia.org/ci/view/BrowserTests/view/Core/


Potentially we could come up with a set of tests defined somewhere (maybe integration/config) that are a shared responsibility, run continuously and spam everyone whenever something fails.  Will need to describe what kind of smoke tests we are interested to exercise though.
Looks like this is more something for Jenkins to run than something that needs production server access...
The webperf project has an asset-check deamon (see ["Webperf" on Wikitech](https://wikitech.wikimedia.org/wiki/Webperf#asset-check)) that frequently (every 5 minutes) views a bunch of different endpoints in a PhantomJS browser and collects metrics. We can extend this to cover any metrics needed here.

It currently publishes the metrics to Ganglia only which isn't very accessible. See T105354 for moving this to Graphite so we can build a dashboard for it and just in general to allow people to query the data more easily.

See the [checkAssets() in webperf/asset-check.js](https://github.com/wikimedia/operations-puppet/blob/4ba5e62018ede8929025fb7a2a156c76527860e1/modules/webperf/files/asset-check.js#L61-L97) for an overview of the data currently collected.
The webperf project has an asset-check deamon (see ["Webperf" on Wikitech](https://wikitech.wikimedia.org/wiki/Webperf#asset-check)) that frequently (every 5 minutes) views a bunch of different endpoints in a PhantomJS browser and collects metrics. We can extend this to cover any metrics needed here.

It currently publishes the metrics to Graphite only which isn't very accessible. See T105354 for moving this to Graphite so we can build a dashboard for it and just in general to allow people to query the data more easily.

See the [checkAssets() in webperf/asset-check.js](https://github.com/wikimedia/operations-puppet/blob/4ba5e62018ede8929025fb7a2a156c76527860e1/modules/webperf/files/asset-check.js#L61-L97) for an overview of the data currently collected.
There's also the VE production browser test that ensures that all wikis with VisualEditor installed actually let you get to VE successfully:

https://integration.wikimedia.org/ci/view/BrowserTests/job/browsertests-VisualEditor-production-linux-firefox-sauce/

(The fy.wikipedia.org one is just a regular test suite failure; the kk.wikipedia.org one looks like a local sysop has broken JS there.)
Seems we have two versions :-]  If you guys could unify the effort and have the resulting code hosted in Gerrit, I would be more than happy to write a Jenkins job that runs the script  once per hour and spam some place (mail/IRC...).
here is my version used for error checking:
https://github.com/eranroz/wiki-js-error-log/blob/master/testwiki.js
(In reply to MZMcBride from comment #0)
> ...
> testing als
> ERROR: ReferenceError: Can't find variable: ta
> TRACE:
>  ->
> https://als.wikipedia.org/w/index.php?title=MediaWiki:If-pt-login.
> js&action=raw&ctype=text/javascript&dontcountme=s: 9
> ...
FIXED:
https://als.wikipedia.org/wiki/MediaWiki:If-pt-login.js?diff=584752
<http://tools.wmflabs.org/legobot/wmf_js_scanner.js> checks for any JS errors being thrown on the main page (as an anonymous user) as well as the inclusion of any external resources.

Ideally such a tool would be able to login, visit a few pages (including ?action=edit), enable and disable individual gadgets and change skins.
The idea here is to use a tool such as PhantomJS (a headless WebKit browser) to hit a bunch of pre-defined URLs and report JavaScript errors.

In addition to strictly checking errors, checking fetches of content on domains outside of Wikimedia's control (e.g., Google Analytics) would also be nice.
Scan down these to find lots of garbage, including lines like:

</xml><![endif]--><!--[if gte mso 9]><xml>

or 

<!--[if gte mso 9]><xml>

https://fr.wikipedia.org/w/index.php?title=Catherine_Lemorton&curid=1711917&diff=105874955&oldid=105753648


https://fr.wikipedia.org/w/index.php?title=Paul_C%C3%A8re&curid=8199909&diff=106116894&oldid=106116223

https://fr.wikipedia.org/w/index.php?title=Paul_C%C3%A8re&curid=8199909&diff=106116209&oldid=106116068 

https://fr.wikipedia.org/w/index.php?title=Andr%C3%A9_Grassi&curid=5857691&diff=106069630&oldid=105919440 

https://fr.wikipedia.org/w/index.php?title=Capitulaire_de_Coulaines&curid=1578466&diff=106053129&oldid=90262123 

https://fr.wikipedia.org/w/index.php?title=Charles_Ateba_Eyene&curid=7794227&diff=105959949&oldid=105470353


This may be helpful in finding others:

https://fr.wikipedia.org/w/index.php?title=Sp%C3%A9cial:Modifications_r%C3%A9centes&days=30&from=&tagfilter=balise+HTML+interdite

--------------------------
**Version**: unspecified
**Severity**: minor
**See Also**:
https://bugzilla.wikimedia.org/show_bug.cgi?id=69821
https://bugzilla.wikimedia.org/show_bug.cgi?id=61371
This now looks to be fixed; I pasted the contents of a couple of the diffs show above into the HTML clipboard, and then back out into VisualEditor (simulating a copy from Microsoft Office), and the unwanted cruft was all magically removed.
The comments were dealt with in T71821
Maybe Outlook is kind of part of Microsoft Office nowadays anyway. :)
Isn't mso Microsoft Office, rather than Outlook?
(In reply to Alex Monk from comment #1)
> People copying in things from MS Word, it seems:
> http://www.equalserving.com/what-the-heck-is-msonormaltable-and-how-did-it-
> get-in-my-post/

Yes, probably, but this problem is new in VE: the first occurrence I've been able to find in frwiki is in August 1st. Nothing previously.
People copying in things from MS Word, it seems: http://www.equalserving.com/what-the-heck-is-msonormaltable-and-how-did-it-get-in-my-post/
From John Broughton:

It would be easier to remember what this menu does, and to tell others about it (say, in the User Guide) if the icon for it were the text “Page” (with a down-arrow) rather than three horizontal lines. This menu icon approach is used for the “Insert” and “Cite” menus, which helps users immediately understand (and/or remember) what type of items are on the menu.

--------------------------
**Version**: unspecified
**Severity**: minor
Prateek, I don't remember seeing any complaints about this for a long while.  Maybe people are used to it now?
With {T177432} progressing this should get resolved as we're using an article icon with settings cog.
//Page options// is a vague thing and so gets a vague icon {icon frown-o}. We could use the typical {icon cog} or {icon cogs} but that might get confused as settings for the editor itself. The same might be true for {icon sliders} too, plus we're using both those icons for items within the menu.

Other options might be {icon wrench}, {icon tachometer} or {icon file-o}.

***

@Whatamidoing-WMF, the {icon bars} icon while confusing has become quite popular as a //more options// icon, do you still find it difficult while communicating to users?
**Author:** `physik`

**Description:**
I'm using the vagrant role visual-editor for my wiki.
After enabling the visual editor role I could not edit formulae... The message is available in source mode only.
I see that the visual editor for math is not super fancy now, but it should be somehow stable?
If not this can become a tracking bug to trace of the bugs that need to be resolved.

--------------------------
**Version**: master
**Severity**: minor
**physik** wrote:

I think my version is not very old...
/vagrant/mediawiki/extensions/VisualEditor$ git log -1
commit f5681d490016a8c3213bbdceae859d784dbb5359
Author: Translation updater bot <l10n-bot@translatewiki.net>
Date:   Tue Aug 12 21:40:40 2014 +0200

    Localisation updates from https://translatewiki.net.

    Change-Id: I8e86d5dcaa3204893733734acf1439414656fc0f
I'm not aware of any configuration option that disables VE-support in the Math extension.
Umm. This was done in gerrit I0dd1c85a four months ago… are you running very very old code, or have you got the Maths extension configured in a way that breaks the VisualEditor plugin?
**physik** wrote:

Visual editor for math disabled

**Attached**: {F14708}
**Author:** `ronnirubin`

**Description:**
Re bug 68101

> Load VE. Say "Foobar" is the first word on the page.
> If you click on the link tool, by mistake or not, without selecting anything before, Foobar will automatically become a link to the Foobar page (it doesn't help that pressing ESC doesn't abort the action, the link gets applied anyway, as we know).

ESC _should not_ exit and save; it should either exit without saving, or revert the change (in this case, the link) without exiting.  I was going to set the Severity to "blocker", as it would block installation on en.Wikipedia, but that would be wrong.

--------------------------
**Version**: unspecified
**Severity**: enhancement
Yeah, that's {T52868}.
Not sure if I'm adding further confusion :) 
(and I think this task didn't keep T101176 into account?)
but from what I'm reading at the German Wikipedia,
some would find it desirable that ESC allowed to leave the "blue" link area after a link is added and placed the cursor just at the right so that people can quickly start typing again.

Currently, hitting ESC right after choosing a link target doesn't close the link tool - it prompts the "Are you sure?" dialog to leave the page entirely.
Also, to get out of the blue area just via the keyboard, you need to hit the right arrow twice (which doesn't seem much intuitive).
Unfortunately I agree with BOTH of you. 
I am often confused by the behaviour of the link dialogue and am often looking for the "insert" or "confirm" button. "Done" doesn't seem right to me somehow. 
On the other hand, James is right too. The behaviour of all the formatting icons on the toolbar is that as soon you press them, the action takes place. So, highlighting a word and pressing "bold" will cause the text to go bold immediately, not after a second 'confirmation click'. 
Nevertheless, despite intellectually understanding the link dialogue design, I keep stumbling on it - it gets in the way and I have to consciously think about it - which is not good behaviour for a labor-saving device.
This is a mistaken understanding of what the button does, and what the window is for.

* The link button *creates* a link if there is none there already.
* Once the link is created, we then also pop up a link editing window 
* This is to let you change the link to point to a different place, or remove it.
* Pressing escape closes the editing window, leaving you with the link you created.

This is intentional design. Escape isn't "applying" anything, but it's probably not very clear. Maybe design would like to comment?
When editing in VisualEditor, you can click "save", add some text to the edit summary, click "resume editing", edit some more, and repeat. This kind of incremental summary is a fairly common request from editors who add to the summary field when they make each successive change in an edit. 

So we actually have the capability they're requesting, but it's not well designed for this use case
See also (merge one into other?) {T52961}
Actually, I didn't realise you could do that which makes this much less of a problem that I thought it was.  Still, it's a bit clunky. I can't, for instance, start writing the edit summary first (I have to edit something first to make the save button go live).  There are many situations where one has "dirty" data on the clipboard carried from somewhere else and intended for the edit summary.  Have to remember not to copy-paste anything else before dumping it in the edit summary field.
I believe that what SpinningSpark is actually requesting is to have the edit summary visible and editable on the main screen.  Right now, you can fill out the edit summary incrementally, but you have to click on the Save button and then cancel saving each time.
**Author:** `che`

**Description:**
Yesterday I tried VisualEditor for the first time, after nine years of editing wikitext. I took me several minutes to find out how to make a link. I have tried text styles drop-down (as it has an underlined letter, which I associated with hyperlinks), the the "insert" drop-down, which included several useful objects, but not the hyperlink option. I have tried typing "[[", which has shown me a warning that wiki syntax does not work, but did not tell how to create a link in VisualEditor. Then I went through citation and list-formatting menus, before finally stumbling onto the link button, which is sort of grey, and the only button in the line that has no drop-down arrow. In retrospect, I guess I though it is some kind of separator.

Some things that might have made my life easier:
- a bit more obvious link button
- having another link option in "insert" menu (with the same icon, so I could discover it on the toolbar afterwards)
- having mr. Clippy's "It looks like you're attempting to use wikitext" message point me to the VisualEditor equivalent of what I'm trying to do (by showing the icon or highlighting the button on toolbar)

Alternatively, interpreting wikitext in VisualEditor might make life easier for users experienced with it's syntax, but that might be a stupid idea.

In any way, thank you for your work on VisualEditor. You're pushing as all forward towards a better future :-)

--------------------------
**Version**: unspecified
**Severity**: enhancement
The current link button is very similar to what is used in Google Docs and Gmail. It also has the same keyboard shortcut - Ctrl-K.

Adding a button to the insert menu is not bad, but may increase clutter unnecessarily.

Interpreting wikitext such as identifying that the editor is typing [[ would be nice DWIM for a lot of people, but unnecessary for others. I wouldn't make it a priority.
For example, if you open the link tool on a blank page, there is nothing to "Remove" and nothing to "Open", so those buttons should be grayed out.

--------------------------
**Version**: unspecified
**Severity**: enhancement
(In reply to Alex Monk from comment #3)
> Maybe relabel it "Cancel" instead in this case?

Maybe.
Maybe relabel it "Cancel" instead in this case?
(In reply to WhatamIdoing from comment #0)
> For example, if you open the link tool on a blank page, there is nothing to
> "Remove" and nothing to "Open", so those buttons should be grayed out.

1. Click into a blank spot (e.g. the cursor is at '|' in "Foo | Bar")
2. Enter a search term and select a link target

At this point, the only way to not insert this link is to click "Remove"; disabling it would mean that to not insert the link, you would have to empty the search box and then click "Done" (confusing) or outside the inspector (not possible in mobile).

Maybe we could come up with a different label, or maybe we don't care about this edge case enough?
Open button was bug 70015
screenshot

environment- test2

1> open page in VE, insert a comment.
2> Click to edit the comment.
3> Now click on the Text Style Menu, notice the  text style drop-down opens with edit comment dialog overriding it . Please see screenshot.

Only on Monobook skin, same issue found in FF.

--------------------------
**Version**: unspecified
**Severity**: minor

**Attached**: {F14206}
Issue Resolved on test2.
Think that this may have been fixed by gerrit 156723.
screenshot

1> Open a page in VE, the skin is Monobook.
2> Insert a link.
3>While the link icon is visible, move the cursor to the beginning of the link. The link icon looks broken. See screenshot.

--------------------------
**Version**: unspecified
**Severity**: minor
**OS**: Windows XP

**Attached**: {F14152}
Issue not fixed on test2.
(In reply to Ritu Swain from comment #6)
> Issue not fixed on test2.

Yes, this code will be deployed to test2 on 2014-09-04 so for now it will still be broken, sorry.
Issue not fixed on test2.
Think that this may have been fixed by gerrit 156723.
[editing bug summary]
(In reply to Andre Klapper from comment #2)
> What does "is broken" or "look broken" mean exactly here?

As the cursor moves on the link,the tip ("^") of the link icon moves along.But when you move it to the first character of the link, the tip("^"), it appears not to be part of the link icon anymore . Please see attached screenshot.
What does "is broken" or "look broken" mean exactly here?
Similar behavior found with the other icons as well, like - Comment,Language.
VE's help icon popup includes this "visualeditor-beta-warning" text:

... To switch back to source editing at any time without losing your changes, open the dropdown next to "Cancel" and select "Switch to source editing?"."

The last message is 'visualeditor-mweditmodesource-title'.  But the item in the dropdown is actually visualeditor-mweditmodesource-tool, which is "Switch to source editing" without a question mark. Trivial to fix.

(Also "Cancel" is gone from the VE UI, I filed bug 69201.)

--------------------------
**Version**: unspecified
**Severity**: trivial
Change 152913 merged by jenkins-bot:
Fix use of visualeditor-mweditmodesource-title instead of …-tool

https://gerrit.wikimedia.org/r/152913
Change 152913 had a related patch set uploaded by Jforrester:
Fix use of visualeditor-mweditmodesource-title instead of …-tool

https://gerrit.wikimedia.org/r/152913
Currently the MobileFrontend provides two editors : one using wikitext and one based on the VisualEditor. It would be nice to have a proper editor loader in order to allow to the creation of customized editors by other extensions (an use case may be an editor for Wikisource Page: pages).

**See Also**:
* {T67165}
This already exists.

You can use the hook 'SkinMinervaDefaultModules'

Inside the hook you can replace the editing module with your own module.

e.g.

$modules['editor'] = array( 'mycustomeditor' )

Can you try this and see if it works for you?
**bingle-admin** wrote:

Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/1GD5dpRW
**bingle-admin** wrote:

Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/pWbLQ2ga
**bingle-admin** wrote:

Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/3iclM3PZ
With attachment 16112:

119) ResourcesTest::testUnsatisfiableDependencies
The module 'mobile.editor.ve' must not have target 'desktop' because its dependency 'ext.visualEditor.mobileViewTarget' does not have it
Failed asserting that an array contains 'desktop'.

/srv/vagrant/mediawiki/tests/phpunit/structure/ResourcesTest.php:98
/srv/vagrant/mediawiki/tests/phpunit/MediaWikiTestCase.php:133
/srv/vagrant/mediawiki/tests/phpunit/MediaWikiPHPUnitCommand.php:42
/srv/vagrant/mediawiki/tests/phpunit/phpunit.php:160

--------------------------
**Version**: unspecified
**Severity**: enhancement
Not re-encountered in over a year.
Hmm. mobile.editor.ve is defined in MobileFrontend but without a mobile target (!?)… How does mobile.editor.ve get used in mobile?
… so instead it falls back to the built-in defaults (en and ltr), but really it shouldn't ever get to this position.
Is this now fixed?
(Taken from bug 52127.)

Previously, before comments were node-ified, editing

  [[Foo|Bar<!--Foo!-->]]

… to point to "Baz" would create the wikitext:

  [[Baz|Bar]][[Foo|<!--Foo!-->]]

… whereas it should have done

  [[Baz|Bar<!--Foo!-->]]

… (i.e., meta items inside annotations should get changed when the annotation changes, not keep their existing ones).


As comments are (mostly) now nodes, this doesn't apply to them, but will apply to other meta items like {{DISPLAYTITLE:Foo}} or whatever broken items might exist.

--------------------------
**Version**: unspecified
**Severity**: normal
So, it turns out we fixed this at some point in the past ~3 years anyway – tested on 1.31.0-wmf.17:

https://www.mediawiki.org/w/index.php?title=User:Jdforrester_(WMF)/T70779&diff=2703642&oldid=2703641

However, it still works after the re-unification of data and meta-data, tested on 0c9fb65fbe:

https://en.wikipedia.beta.wmflabs.org/w/index.php?title=User:Jdforrester_(WMF)/T70779&diff=375632&oldid=375631

… hurrah?
This is possibly by design, but I found it unexpected:

Use the Cite tool with any example having multiple fields to fill in, e.g. Website or Book.

Enter a field. Hit TAB.

I would expect the cursor to go to the next editable field, but instead the cursor highlights first the Field description icon, then the Remove field icon, and only after that moves to the next editable field.  The user must tab three times to put the cursor into the next editable field.

--------------------------
**Version**: unspecified
**Severity**: enhancement
>>! In T70768#720791, @Jdforrester-WMF wrote:
> Yeah, this is intentional

Specifically, we did it in response to T67474.
*** Bug 69512 has been marked as a duplicate of this bug. ***
Yeah, this is intentional, but maybe we should look again in case there is a way to provide the accessibility we need without being unhelpful to keyboard users.
Steps to reproduce:

1.Open a page with VE
2.Insert an image
4.Add a numbered list or bullet list after that
5.Make the image left aligned 
6.When the list gets wrapped on the right side of the image,place the cursor on one item in the list
7.Try increasing the indentation

Observed Result:
Nothing happens.No indentation is added to the listed item.

--------------------------
**Version**: unspecified
**Severity**: normal
Use case:

1. On a page with a heading and some text. Put cursor at start of the paragraph after the heading.
2. Insert a template (ends up selecting it after finishing insertion)
3. "Insert" another template.

Expected:

A dialog should appear with the ability to decide which template to insert etc.

Actual:

A dialog appears to edit the selected transclusion that is already on the page.


After being genuinely confused for a minute I realised that the confusion came from the menu label being "Insert". A while back, the "Template" button was separate on the toolbar (or under "More" or "Tools" whatever it was). Back then, like still the case with Links and Text Style, it was more natural to assume it will edit and not create a template when a template is selected already because the button would be rendered in an "active" (pressed-down) state (like for links and text style). However, the menu was then relabelled to "Insert" and the items in the "Insert" menu do not have an "active" state to help correlate with the currently selected item on the page.

Perhaps we should bring back the "active" state for the Insert menu items, for consistency with other buttons on the toolbar.

Or make it actually insert a new one at/before the current cursor position, which would mean that to edit a transclusion users then need to use the context menu instead.
Might be related to bug 68492.

> Discontiguous selection is not supported. rangy-core-1.3.js:2842
>> (anonymous function) rangy-core-1.3.js:2842
>> (anonymous function) rangy-core-1.3.js:2852
>> (anonymous function) rangy-core-1.3.js:327
>> init rangy-core-1.3.js:249
>> loadHandler rangy-core-1.3.js:365

--------------------------
**Version**: unspecified
**Severity**: normal
*** Bug 69616 has been marked as a duplicate of this bug. ***
Fixed now because we don't use Rangy any more.
**timdown** wrote:

It's coming from a perfectly reasonable feature test in Rangy that is upsetting non-standard behaviour in Chrome. I've reluctantly put in a hideous browser sniff to work around it in the latest Rangy release.
*** Bug 68771 has been marked as a duplicate of this bug. ***
Chrome emits this notice when using VisualEditor anywhere.

> 'Range.detach' is now a no-op, as per DOM (http://dom.spec.whatwg.org/#dom-range-detach).


Looks like more than the typical deprecation, because it's been replaced with a no-op. No idea if we/Rangy are relying on it doing something. Could cause all kinds of weird state inconsistencies.

--------------------------
**Version**: unspecified
**Severity**: major
As we've now dumped Rangy, this is now FIXED.
(In reply to Tim Down from comment #1)
> Rangy has no reliance on Range.detach now. The latest release does not use
> it at all.
Unfortunately we still use the Rangy position plugin, which appears to have been unmaintained for a while. So we're stuck with our current version of rangy for now. Ideally I would like us to migrate away from the position plugin, then to a more recent version of Rangy. But I need to do a code audit to see is being used where.
**timdown** wrote:

Rangy has no reliance on Range.detach now. The latest release does not use it at all.
Environment- Betalabs

Steps to Reproduce-

For Chrome-
1> Logged in and trying to switch to VE interface by clicking on "Edit beta" tab shows the spinner for a while and remains in the read mode.
2> Now click on "Edit Source" tab opens the Wikieditor interface.
3> Click on "Edit beta" tab again, takes you to the Read only mode instead.

For FF-
1>Logged in and trying to switch to VE interface by clicking on "Edit beta" tab shows the pop-up with message "Error loading data from server: readonly: The wiki is currently in read-only mode. Would you like to retry?", with the spinner in the background forever.

For Safari-
1>Logged in and trying to switch to VE interface by clicking on "Edit beta" tab shows the pop-up with message "Error loading data from server: readonly: The wiki is currently in read-only mode. Would you like to retry?"

This issue is related to Bug 59010 and Bug 60765.

--------------------------
**Version**: unspecified
**Severity**: enhancement
When trying to save wikitext during a DB lock, you can just copy-paste your wikitext, save it to a text file, and paste it back when the wiki comes up again later on. I guess with VE you can still do that by using "switch to wikitext", but it's not nearly as obvious.
By the way, bug 68349 is tracking the issue which has turned on read-only mode. This bug can be used to look into how VE is handling it poorly and/or inconsistently.
I think they mean that they can't open VE on any *.beta.wmflabs.org wiki. Those are part of the deployment-prep project in labs. The database there are read-only at the moment: no edits can be made.
Where exactly is "in betalabs"? All instances there or which one(s)?
Screenshot

Steps to reproduce:

1.Open a page with VE
2.Without making any change , go to page options next to "Save Page" button
3.Select the option "Switch to source editing"

Observed Result:
The confirmation dialog to keep ot discard changes appears.

--------------------------
**Version**: unspecified
**Severity**: normal

**Attached**: {F14213}
Verified the fix in production
Verified the fix in test2
Verified the fix in Betalabs
Change 147646 merged by jenkins-bot:
Don't confirm if there's no changes when switching to edit source mode through the page options menu

https://gerrit.wikimedia.org/r/147646
Change 147646 had a related patch set uploaded by Alex Monk:
Don't confirm if there's no changes when switching to edit source mode through the page options menu

https://gerrit.wikimedia.org/r/147646
Steps to reproduce:

1.Open a page with Mobile VE
2.Open link inspector
3.Type something in the text field to bring up the suggestions
4.Select one suggestion from the drop down
5.Place the cursor at the end of the link target name in the field
6.Press backspace to delete it

Observed Result:
Instead of deleting the link target , it takes user to the CE closing the inspector.

--------------------------
**Version**: unspecified
**Severity**: normal
Seems to work for me now. Tested on Beta Cluster using iOS Safari 8.0 on an iPad.
Needs re-testing.
Can't reproduce this issue. Is it Safari-only?
(In reply to Alex Monk from comment #7)
> Can't reproduce...

Can reproduce here.
Can't reproduce...
Yeah, I sat down with Maryana and showed her how to reproduce it.
I am still getting it following the exact same steps on Betalabs ,test2 and en.wiki. Infact, Roan and I reproduced it several times last week on master.
I just tested this out, and I'm not seeing any issues with backspacing text in link inspector on test2 or mediawiki.org on an iPad 2 – did it get fixed somehow?
Double tapping on backspace takes to a blank page
This is still happening in Betalabs
Fixed.
This was mentioned on the "[QA] Failing MobileFrontend browser tests" thread in July. I have seen a few more  "getaddrinfo: Name or service not known (SocketError)" errors with Flow browser tests, and then today we got four of them. :-(

See https://integration.wikimedia.org/ci/view/BrowserTests/job/browsertests-Flow-en.wikipedia.beta.wmflabs.org-linux-chrome-sauce/65/

All three tests failures in https://integration.wikimedia.org/ci/view/BrowserTests/job/browsertests-Flow-en.wikipedia.beta.wmflabs.org-linux-chrome-sauce/65/ at Jul 16, 2014 6:26:46 PM (UTC?) were with this error.

15 minutes earlier, https://integration.wikimedia.org/ci/view/BrowserTests/job/browsertests-Flow-en.wikipedia.beta.wmflabs.org-linux-firefox-sauce/72/ also failed with "getaddrinfo: Name or service not known (SocketError)". The other test failure was an action that took longer than 5 seconds to complete.

--------------------------
**Version**: unspecified
**Severity**: major
As far as I can see, this is no longer a problem. The last Flow build has 17 failed scenarios, but all of them are `timed out after 5 seconds, waiting for ... to become present (Watir::Wait::TimeoutError)`

https://integration.wikimedia.org/ci/view/BrowserTests/view/-All/job/browsertests-Flow-en.wikipedia.beta.wmflabs.org-linux-chrome-sauce/590/consoleFull

Closing this as invalid. Please reopen if the problem is still reproducible.
(In reply to Chris McMahon from comment #3)
> This is very likely fixed with

"fixed with what" ? HHVM improvements?

Anyway, this remains a problem. From e-mail to qa mailing list:
>>>
Echo and Flow tests were all green Saturday Sept 6 for the first time \o/

But then 4 out of 6 Flow test runs today (
  Sep 7, 2014 8:33:11 PM
  Sep 7, 2014 6:51:45 PM    
  Sep 7, 2014 6:13:05 PM
  Sep 7, 2014 3:54:07 AM
UTC times I think)
<<<
Tthere was another getaddrinfo failure Sep 8, 2014 3:45:56 AM, see 
<https://integration.wikimedia.org/ci/view/BrowserTests/job/browsertests-Flow-en.wikipedia.beta.wmflabs.org-linux-chrome-sauce/185/>
This is very likely fixed with
Seems to be a 90 second timeout for a Flow job as well, but without the big red error message at the top of the Sauce page: https://integration.wikimedia.org/ci/view/BrowserTests/job/browsertests-Flow-en.wikipedia.beta.wmflabs.org-linux-firefox-sauce/72/testReport/junit/(root)/Topic%20collapsing/Topics_only_view/
In at least one case this was caused by SauceLabs not receiving any command for 90 seconds: https://integration.wikimedia.org/ci/view/BrowserTests/job/browsertests-VisualEditor-en.wikipedia.beta.wmflabs.org-linux-firefox-sauce/lastCompletedBuild/testReport/(root)/VisualEditor%20general%20text%20markup%20features/VisualEditor_general_markup__outline_example_____Superscript____sup_General_Markup_VisualEditor_Test__sup____/
There are templates that have a different name, but the same parameters. For example, the many lang-XX templates. If I see that the parameter text is correct, but an incorrect template was used, and the template should be {{lang-ru}} and not {{lang-be}}, I can simply change the template name. In VE I need to delete the whole template and re-add it. This is silly, but tolerable, for a template with one parameter, but there are such templates with more parameters.

--------------------------
**Version**: unspecified
**Severity**: enhancement
Somewhat similar to T97936? To be able to chnage template name easily.
Ideally if the templates are identical but for one piece of information ('be' vs. 'ru') then the template should be used directly ({lang|ru|…}} vs {{lang-ru|…}}, not via accessor methods, which would make this moot. But yes.
window with message

Calling message [[:en:Wikipedia:Edit filter]] 

For example message "redrect to itself" (this filtermessage in ru-wiki; in en-wiki is no such call filter, but may work with other message)
* Edit page in VE
* Copy page title
* [Ξ] → Page settings → check "Redirect this page to" → past page title (page name of this article)
* Press Save page (in interface) → Save page (in floating window)

* Start showing Edit filter message (1 image 1)
* Clik on link in this message - new page open in this floating window and this window i can't close or go back to message (image 2)

Link should open in a new window

--------------------------
**Version**: unspecified
**Severity**: minor
**OS**: Windows 8.1
**Platform**: PC

**Attached**: {F14349}
This is caused by an unsuitable use of a template to provide links without a target="_window". Maybe we should prevent clicking on the links instead?
Created attachment 15941
window after click on link

**Attached**: {F14350}
Invoke VE from iOS Safari on tablet,

Make changes to page in VE 

Open second tab, load another website, 

Switch back to tab with VE instance, page is reloaded, and changes are lost
#Performance-Team is for any task worked on by the performance team. (Known issues in software we maintain, and improvements anywhere else if we're involved.)

#Performance is a generic tag for other projects to track known problems causing bad performance. (Not usually improvements/enhancements.) In addition, projects with their own subproject or workboard column for performance, normally don't also tag with Performance (similar to Tech Debt). I've untagged this and others with #VisualEditor-Performance.
#Performance-Team is for any task worked on by the performance team. (Known issues in software we maintain, and improvements anywhere when we assiset on the matter.)

#Performance is a generic tag for all other projects to track known problems causing bad performance. (Not usually improvements/enhancements.) In addition, projects with their own subproject or workboard column for performance, normally don't also tag with Performance (similar to Tech Debt). I've untagged this and others with #VisualEditor-Performance.
I don't know, what is the difference between //VisualEditor-Performance// and //Performance//, but //Performance// is used in similar VE issues and here is missing
Auto-save issue is T57370
Also the beahviour is the same on both devices: the tab is only expunged when the device runs out of memory.
A long term solution would be to store editing state in localStorage. I think there's an existing bug for that.

The best we can do at the moment is warn the user. The most likely time they'll switch is if they're using Citoid, and they go to get a URL to copy.
>>! In T70017#782815, @Eloquence wrote:
> What is the behavior in Chrome/Android?

Similar, but not 100% reproducible, I think it depends on how much memory the tab is using, which probably corresponds to the size of the article you're editing. chrome might also just try to keep more than one tab alive concurrently
>>! In T70017#782815, @Eloquence wrote:
> What is the behavior in Chrome/Android?

From what I remember of our testing, it's the same, controlling for RAM size. Mostly this is a performance / resource use issue.
What is the behavior in Chrome/Android?
"don't close me bro"
(In reply to Jared Zimmerman (WMF) from comment #4)
> This might not be able to resolved as the bug is written (stop safari from
> reloading) but the current experience for the user in unacceptable. We need
> a solution. possibly server side drafts or using localstorage on the device.
> Feel free to rewrite the bug, but we can't ignore this issue.

Well, this is what Apple wants to happen. We already say to the browser "don't just close me". Apple has decided in its wisdom to ignore that. We can try to take steps to make it less-terrible, but the underlying issue can't be fixed except upstream…
This might not be able to resolved as the bug is written (stop safari from reloading) but the current experience for the user in unacceptable. We need a solution. possibly server side drafts or using localstorage on the device. Feel free to rewrite the bug, but we can't ignore this issue.
Unfortunately, on investigation, this is something that we can't avoid; it's the built-in behaviour of Safari that we have no control over, sadly. Marking as "WONTFIX" but it's more "CANTFIX".
Yep, I know this one might be difficult but it obviously makes doing references on mobile basically impossible. glad to see we're prioritizing this.
This is "normal" behaviour from Safari, but we need to investigate if we can prevent (or at least discourage) it somehow.
This was an interesting comment from WhatamIdoing on T69826, so I thought I'd split it out for its own discussion.

> Changing default user preferences means overriding the choices of 
> registered editors who actually want the feature (including thousands of 
> editors who voluntarily opted-in before MediaViewer was made avaialble 
> by default).  
> 
> It's too bad that MediaWiki doesn't have a good one-click system for 
> changing prefs, like a "Click here to enable X" button or pop-up.  It'd be 
> so much easier than telling hundreds of users "Go to Special:Preferences, 
> click to this tab, scroll halfway down, find this item, tick the box, scroll 
> all the way down, save the page."

--------------------------
**See Also**:
* {T34811}
* {T69883}
(In reply to WhatamIdoing from comment #5)
> I think I can:
> 
> Tell me the exact wikitext I need to type to tell an editor at the English
> Wikipedia's Help Desk these things:
> 
> "Click HERE to disable MediaViewer"

Don't write "click here".

http://www.w3.org/QA/Tips/noClickHere

[…]

> "Click HERE to set your gender to female"

whatever ajax appears should be clear on privacy implications (value is published) and what exactly it's used for. (software strings not stats, etc) also, remember a11y, aria, etc.
I think I can:

Tell me the exact wikitext I need to type to tell an editor at the English Wikipedia's Help Desk these things:

"Click HERE to disable MediaViewer"

"Click HERE to opt into the Beta Feature VisualEditor"

"Click HERE to set your default image size to 300 px"

"Click HERE to set your gender to female"

"Click HERE to turn on Twinkle"

"Click HERE to turn off Navpops"

"Click HERE to set your default image size to 300 px"

"Click HERE to set your gender to female"
(In reply to James Forrester from comment #3)
> I think you have mis-understood this request; it's asking for a consistent,
> MW-provided system to do this that works the same way for all preferences

The WebAPI works for all preferences. Can you clarify the requirements, as you're so sure about them?
(In reply to Nemo from comment #2)
> I don't understand this bug. We have plenty of one-click preference change
> systems, which alter the preferences via WebAPI. As one prominent example,
> see [[mw:ULS]].

I think you have mis-understood this request; it's asking for a consistent, MW-provided system to do this that works the same way for all preferences, and which each feature can trivially provide, not specific ad-hoc hacks like ULS etc. use which mean users have to learn them each time.
I don't understand this bug. We have plenty of one-click preference change systems, which alter the preferences via WebAPI. As one prominent example, see [[mw:ULS]].
I recommend filing a separate bug for each preference you want one such control for, specifying if it can also supplant the Special:Preferences checkbox (cf. bug 32811; keep bug 31882 in mind).

Unless requirements for this request to be considered fulfilled are clarified, I propose RESOLVED WORKSFORME.
Thanks for filing this.

I should note that what would be most functional is a system that lets me post a link (meaning a wikilink or a URL) that represents the command.  I want anyone to be able to do this, not just the devs.  Something like:

"Click [[Special:ChangePreferences/scary-code-name-for-pref |here]] to toggle the tickbox for that pref"

(or whatever format is necessary) would be great.
**Author:** `gabrasca2`

**Description:**
VisualEditor deprecated text

When a param is indicated as "deprecated": true and it has no description, in the TemplateData parameters table the text "no description" isn't in italic grey.

--------------------------
**Version**: unspecified
**Severity**: minor

**Attached**: {F14398}
Verified in beta with http://en.wikipedia.beta.wmflabs.org/wiki/Template:ET_test
Change 184440 merged by jenkins-bot:
Show "no description" in italic grey also for deprecated parameters

[[https://gerrit.wikimedia.org/r/184440]]
Change 184440 had a related patch set uploaded (by Ricordisamoa):
Show "no description" in italic grey also for deprecated parameters

[[https://gerrit.wikimedia.org/r/184440]]

#patch-for-review
Screenshot

Steps to reproduce:

1.Open a page with VE
2.Insert an image
3.Make it frame-left or frame-right.

Observed Result:

The highlight for the image goes beyond the page

See the screenshot attached

--------------------------
**Version**: unspecified
**Severity**: minor

**Attached**: {F14208}
We currently don't. We should.
Merged into #VisualEditor-MediaWiki-Media.
*** Bug 67689 has been marked as a duplicate of this bug. ***
Right now while inserting an image, the button that shows up in the Media Settings dialog is "Apply Changes", it should be "Insert" instead , since there is no change here rather insertion.

--------------------------
**Version**: unspecified
**Severity**: minor
Checked in test2/production - for inserting a new media, the button will be always 'Insert'.  Marking as Resolved/Verified.
Expanded, made dependent on bug 67690 for us to be able to tell media types apart.
Copied from my Russian Wikipedia talk page: https://ru.wikipedia.org/wiki/%D0%9E%D0%B1%D1%81%D1%83%D0%B6%D0%B4%D0%B5%D0%BD%D0%B8%D0%B5_%D1%83%D1%87%D0%B0%D1%81%D1%82%D0%BD%D0%B8%D0%BA%D0%B0:Keegan_(WMF)#Bug_report_11

I filled TemplateData for Шаблон:Малая планета

early, template with comments inserted in articles
{{Малая планета
<!-- Основной блок -->
 | param        = 
<!-- Орбитальные характеристики -->
 | param        = 
<!-- Физические характеристики -->
 | param        = 
}}
now if i deleted comments https://ru.wikipedia.org/w/index.php?title=(87)_Сильвия&diff=64040824&oldid=62184664 then i can see parameters in VE editor
but if comments still in text then VE editor for template staying on "Загрузка..." ("Load...") and don't show parameters. sample: (25143) Итокава
Sunpriat 08:40, 6 июля 2014 (UTC)

--------------------------
**Version**: unspecified
**Severity**: enhancement
Change 169732 merged by jenkins-bot:
Bug 67657: Add normalized parameter names to templates

https://gerrit.wikimedia.org/r/169732
Marc, thanks for the clarification. I think the name 'paramWT' contributed to my confusion. It sounds more like the value to me. How about 'key.wt'? That could be extended with key.html etc in the future.

We should definitely include the wikitext for the key, as there is no good way to properly handle editing otherwise. VE shouldn't just pretend that a parameter was not templated, when it was. Those comments also often contain information that the user might be interested in.
Gabriel, 'wt' still contains the original wikitext for the parameter value as it's always done, we're just adding a new paramWt attribute that only shows up if the original parameter name wikitext is different from the actual parameter name that would be used in expansion.

I think the example was a little confusing because the comment in the param name is the same as the param value, sorry for that. Another example, this time with html in it too:

> {{ec<!--tpl comment-->ho|unnamed param value|1<!--param name comment-->2=Param ''value''}}

> {
> 	'parts': [ {
> 			'template': {
> 				'target': {
> 					'wt': 'ec<!--tpl comment-->ho',
> 					'href': '../Template:Echo'
> 				},
> 			'params':
> 			{
> 				'1': {
> 					'wt': "unnamed param value",
>                                       'html': 'unnamed param value'
> 				}
> 			},
> 			{
> 				'12': {
> 					'paramWt': '1<!--param name comment-->2',
> 					'wt': "Param ''value''",
>                                       'html': 'Param <i>value</i>'
> 				}
> 			},
> 			'i': 0
> 		}
> 	} ]
> }

If paramWt isn't actually needed by VE, maybe we could even not output it at all in data-mw, as it's also kept in data-parsoid…
I'm not a fan of making 'wt' return something that's not the original wikitext. How will the need for a normalized name evolve with the 'html' parameter format? It's relatively straightforward to ask for .textContent.
This looks fine to me. We don't really need paramWt in VE anyway, we don't really care that there was a comment in there, as long as Parsoid can preserve it when the template is edited. So with your proposed change, we wouldn't even have to change anything, because we'd just ignore (and preserve) paramWt.
In the patch I've uploaded, the normalized parameter name is used as the entry for the parameter info and the original parameter wikitext only appears if different, in the 'paramWt' attribute. So James' example would output as

> {
> 	'parts': [ {
> 			'template': {
> 				'target': {
> 					'wt': 'ec<!--Ho-->ho<!--Ha!-->',
> 					'href': '../Template:Echo'
> 				},
> 			'params':
> 			{
> 				'12': {
> 					'paramWt': '1<!--Foo!-->2',
> 					'wt': 'Foo'
> 				}
> 			},
> 			'i': 0
> 		}
> 	} ]
> }

Will that be enough, or should the paramWt be included for each parameter? Most of them will be the same anyway and that would increase page size a lot…
Change 169732 had a related patch set uploaded by Marcoil:
Bug 67657: Add normalized param names to templates

https://gerrit.wikimedia.org/r/169732
So… this is asking if Parsoid would consider making the 'params' block of their API give a 'normalised' version of the parameter name, possibly with a 'target' version as well like they do with templates' names?

E.g.:

Wikitext

> {{ec<!--Ho-->ho<!--Ha!-->|1<!--Foo!-->2=Foo}}


Current Parsoid output:

> {
> 	'parts': [ {
> 			'template': {
> 				'target': {
> 					'wt': 'ec<!--Ho-->ho<!--Ha!-->',
> 					'href': '../Template:Echo'
> 				},
> 			'params':
> 			{
> 				'1<!--Foo!-->2': {
> 					'wt': 'Foo'
> 				}
> 			},
> 			'i': 0
> 		}
> 	} ]
> }> 

Requested Parsoid output:

> {
> 	'parts': [ {
> 			'template': {
> 				'target': {
> 					'wt': 'ec<!--Ho-->ho<!--Ha!-->',
> 					'href': '../Template:Echo'
> 				},
> 			'params':
> 			{
> 				'12': {
> 					'target': '1<!--Foo!-->2',
> 					'wt': 'Foo'
> 				}
> 			},
> 			'i': 0
> 		}
> 	} ]
> }

… or similar?
For comparison, Parsoid already strips out html comments from the template title. It should do so for parameter names as well (in addition to trimming whitespace).
Created attachment 15885
Screenshot of bug.

Screenshot for editing the following on on https://www.mediawiki.org/wiki/VisualEditor/Basic_example_worksheet?veaction=edit

{{Wikimedia engineering project information
| name        =VisualEditor<!-- This HTML comment should not get deleted or modified. -->
| description <!-- ignored comment describing the parameter -->= Creating a visual editor for MediaWiki, other platforms and the Web at large
| logo        =VisualEditor-logo.svg
| ..
}}

**Attached**: {F14096}
Hm.. it sounds like the bug report says that html comments inside TemplateData conflict with VisualEditor.

However I think this might've been a confusion in translation. I think the reported problem is that when the wikitext has html comments in the transclusion, that Parsoid/VE is including those as part of the template name.

E.g. that when invoking:

{{ Echo
| 1 <!-- One -->  = Foo
}}

That the transclusion dialog and/or Parsoid is saying there is a parameter called "! <!-- One -->", and renders that as actual text in the label for the UI.

Rephrasing bug accordingly. I think this is something that should be normalised by Parsoid as VisualEditor shouldn't need to know what html comments mean in wikitext.
The inspector for <syntaxhighlight /> node immediately closes after opening on Opera 12. I don't yet know why, but I am going to find out.

--------------------------
**Version**: unspecified
**Severity**: normal
Seems to have been fixed at some point, I can no longer reproduce.
Also affects the comment inspector in standalone.
Ooh. It only closes itself when opened by clicking the context tooltip. Opening it by double-clicking the node or by pressing Enter when it's selected keeps the inspector open.

After editing it, when the context tooltip is displayed again, clicking it also will always work correctly. Fascinating.
(In reply to Bartosz Dziewoński from comment #1)
> * On Opera 12 `rangy.getSelection( this.getElementDocument() ).anchorNode` is
>   null, but on other browsers it returns the .ve-ce-surface-paste element

Oh, and I forgot the best part: not always. Sometimes the selection is the same as on other browsers. I've somehow caused that several times when debugging, but I have absolutely no idea how.
When you try opening the inspector:

* The 'focusout' event is eventually fired on .ve-ce-surface-paste
* ve.ce.Surface.prototype.onFocusChange is called
* On Opera 12 `rangy.getSelection( this.getElementDocument() ).anchorNode` is
  null, but on other browsers it returns the .ve-ce-surface-paste element
* Therefore `hasFocus` is false instead of true
* The document gets blurred, which triggers the inspector to hide some ten
  levels of abstraction down.


No idea why the selection gets lost. Perhaps the inspector should reselect?
Changing language of a <syntaxhighlight /> node doesn't load styles for new language. 

SyntaxHighlight_GeSHi defines a module for each supported language (in the format "ext.geshi.language.$lang"), VE should ensure that the appropriate module is present. Not sure how the content is updated, but the information about required modules should be provided in the ParserOutput and by the action=parse API.

--------------------------
**Version**: unspecified
**Severity**: minor
**See Also**:
https://bugzilla.wikimedia.org/show_bug.cgi?id=58388
* https://gerrit.wikimedia.org/r/214078 (branch master): #mw1.26wmf12
Change 214078 merged by jenkins-bot:
Add VisualEditor support

[[https://gerrit.wikimedia.org/r/214078]]
Change 214078 had a related patch set uploaded (by Jforrester):
Add VE support for syntax highlighting

[[https://gerrit.wikimedia.org/r/214078]]
Screenshot

Steps to reproduce:

1.Open a page with VE
2.Insert an image
3.Make it centre aligned
4.Keep it selected

Observed Result:
The highlight for the centered image is taking 100% width


See the screenshot attached

--------------------------
**Version**: unspecified
**Severity**: minor

**Attached**: {F14351}
Ha. Yes, fixed by Ed as part of his FocusableNode fixes.
Can't reproduce. Must have been fixed in the meantime.
Screenshot

Steps to reproduce:

1.Open a page with mobile VE
2.Go to Insert>Media

Observed Result:
"No results found" message appearing even before entering a search term inside Media Settings dialog

See the screenshot attached

--------------------------
**Version**: unspecified
**Severity**: trivial

**Attached**: {F14200}
Verified the fix in production
Verified the fix in test2
Verified the fix in Betalabs
Change 158584 merged by jenkins-bot:
Abort promises before sending new ones in MediaSearchWidget

https://gerrit.wikimedia.org/r/158584
Change 158584 had a related patch set uploaded by Mooeypoo:
[wip] Abort promises before sending new ones in MediaSearchWidget

https://gerrit.wikimedia.org/r/158584
Okay, it seems the problem is half fixed with the above commit. Now the "No results" message no longer appears on top of found results. However, it does seem to pop up and then disappear between searches. 

I'm going to investigate the issue further.
Change 158530 merged by jenkins-bot:
Hide "no results" messaage in media search widget

https://gerrit.wikimedia.org/r/158530
Change 158530 had a related patch set uploaded by Mooeypoo:
Hide "no results" messaage in media search widget

https://gerrit.wikimedia.org/r/158530
*** Bug 70273 has been marked as a duplicate of this bug. ***
As I mentioned in the dup bug, it's seen in Firefox. In Chrome I see the 'no results' found flicker slightly, but the main issue is in Firefox.
And I still can't see the issue there. I load "Insert media" and I see the search image page empty / processing and then "No results found".

I don't see "No results found" before the search is done, I only see it after the page searched for a moment and found nothing (as intended)

Tested on Chrome Version 36.0.1985.143 and Firefox 31.0

What am I missing here?
As in the duplicate bug, page is http://en.wikipedia.beta.wmflabs.org/wiki/Media_Interface_VisualEditor_Test?veaction=edit 

https://bugzilla.wikimedia.org/show_bug.cgi?id=69877
I can't replicate this. If you're still seeing this, can you give me the page this is still happening on?
*** Bug 69877 has been marked as a duplicate of this bug. ***
I just noticed this is again appearing in Betalabs, when you first open Media Settings dialog and the page name is in the search field,the "No Result Found" appears.Also, it appears when you click on "Change Image" button
This is fixed in Betalabs but not on test2, moving it to the next sprint.
Change 150001 merged by jenkins-bot:
Use $.when() in MediaSearchWidget

https://gerrit.wikimedia.org/r/150001
Change 150001 had a related patch set uploaded by Mooeypoo:
Use to $.when() in MediaSearchWidget

https://gerrit.wikimedia.org/r/150001
Oops. 

Wrong fix to the wrong bug (ignore the above comment)
This is fixed by this change: https://gerrit.wikimedia.org/r/#/c/149392/
Report from Jay8g about a bug that may be very hard to reproduce:

"After adding a parameter in the (advanced) template dialog, the focus briefly shifts to the previously added (edited) parameter before going to the one just added. This has led to me occasionally (about one in ten parameter additions) typing (generally just one character) in the wrong box"

"I would type something *immediately* after clicking the parameter button and it would only happen occasionally"


Jay's running Firefox 30 on Windows 7.  I've been unable to reproduce this, but I probably haven't tried enough times or been fast enough.  I've been wondering whether this might be easier to reproduce on an old, slow computer.

--------------------------
**Version**: unspecified
**Severity**: normal
The issue is confirmed - it is most noticeable in FF35 on Windows. I've attached a screencast for FF35 on Mac - the problem is noticeable as "jumpiness" of parameters in Template dialog. 

Important - to reproduce the bug, add parameter that will be placed **after** previously entered parameter, e.g. after parameter AA add parameter ZZ. Then you can see more clearly that the cursor will be placed momentarily into the previous field.

{F56327}
When we try to add this template:

http://en.wikipedia.org/wiki/User:Jay8g/sandbox/Template:Airline fleet table/Start

the TemplateData does not appear in the dialog.

If we add the doc subpage directly:

http://en.wikipedia.org/wiki/User:Jay8g/sandbox/Template:Airline fleet table/Start/doc 

then TemplateData appears.

We have already made at least three null edits to the template.  I assume that the problem is due to the namespace, but it's not bug 52609, because the template itself adds correctly to the page:  

{{User:Jay8g/sandbox/Template:Airline fleet table/Start}}

--------------------------
**Version**: unspecified
**Severity**: normal
AFAWCT this should work… marking as such.
Possibly. I had to fiddle around with things like that to check that this was actually working on my machine.
(In reply to Alex Monk from comment #2)
> I don't think this is valid... I can't reproduce it on my machine (with
> different pages)

Could it be a caching issue?
I don't think this is valid... I can't reproduce it on my machine (with different pages)
(In reply to WhatamIdoing from comment #0)
> We have already made at least three null edits to the template.  I assume
> that the problem is due to the namespace, but it's not bug 52609, because
> the template itself adds correctly to the page:  
> 
> {{User:Jay8g/sandbox/Template:Airline fleet table/Start}}

I'm pretty sure it was still fine adding to the page in bug 52609.
This may be related to bug 42986:  VisualEditor and Parsoid autoconvert URLs in the external link format to local links, including for interlanguage and other interwiki links.

This means that if you paste https://outreach.wikimedia.org/wiki/Example in as your link on one of the Wikipedias, it gets saved as [[outreach:Example]].  

This is fabulous and should be kept. 

However, if the local wiki doesn't recognize the converted prefix for the link, then the result is a redlink.  At the moment, office.wiki doesn't know about the existence of outreach.wiki, but links are converted anyway.  

The result is that pasting https://outreach.wikimedia.org/wiki/Example as a link on office.wiki gets saved as [[outreach:Example]], and when you click on the resulting redlink, it takes you to the non-existent page https://office.wikimedia.org/wiki/Outreach:Example  

This is not so fabulous.  

The most flexible system is to find out which wikis are known locally, and only convert those.  The most immediate solution is probably to tell office.wiki where to find outreach.wiki.

--------------------------
**Version**: unspecified
**Severity**: normal
> It's because "Outreach" is a namespace name on officewiki. So this is not a MW bug, but a bug probably in Parsoid.

I'd call that a bug in officewiki configuration. They shouldn't use a name reserved for an interwiki in their local namespaces...
It's because "Outreach" is a namespace name on officewiki. So this is not a MW bug, but a bug probably in Parsoid. It shouldn't auto-convert external links to interwikis when the interwiki matches the name or alias of a local namespace.
This is done in Parsoid, and should normally use the wiki-local interwiki table.

It is listed in https://office.wikimedia.org/w/api.php?action=query&meta=siteinfo&siprop=interwikimap&format=json, so the Parsoid behavior looks correct. Interestingly it is listed twice though: once as 'outreach', and once at 'outreachwiki'. When I manually change the wikitext link to [[outreachwiki:Example]], it is rendered as expected.

So to me this looks either like a configuration issue in officewiki. It could also be a bug in the PHP parser, which only recognizes one of two configured interwiki prefixes.
Does this happen in VE or Parsoid? If the latter it should be moved.
If a user has the preference "Prompt me when entering a blank edit summary" selected, VisualEditor's save dialog has to be closed and reopened to work. The "Save" button is greyed out even when an edit summary is entered.

To reproduce:
1. Enable Preferences>Editing>tick Prompt me when entering a blank edit summary
2. Attempt to save a VE edit and the prompt for an edit summary comes up, with save not an option
3. Enter an edit summary
4. Save is still not an option
5. Exit out of the dialog by clicking X and click save again
6. You can now save your edit with an edit summary

Firefox 30 on Mac OS X Mavericks.

--------------------------
**Version**: unspecified
**Severity**: normal
Change 143326 merged by jenkins-bot:
After showing missing edit summary error, mark the dialog as not pending anymore

https://gerrit.wikimedia.org/r/143326
This was probably an oversight on my part in Gerrit change 135945
Change 143326 had a related patch set uploaded by Alex Monk:
After showing missing edit summary error, mark the dialog as not pending anymore

https://gerrit.wikimedia.org/r/143326
Sounds like we need to code in that the you-must-set-an-edit-summary message is a recoverable error.
On translatewiki.net I see a red link in messages and this page won't exist on most wikis, just link https://www.mediawiki.org/wiki/Special:MyLanguage/Help:Formatting by default. See blocked bug for example and remember, Brion veto'ed the simple solution i.e. interwiki link [[mediawikiwiki:Special:MyLanguage/Help:Formatting]].

--------------------------
**Version**: unspecified
**Severity**: normal
Heh, WP:BEANS applies. Thanks.
Change 175886 merged by jenkins-bot:
Point wikitext markup link in warning to MW.org

[[https://gerrit.wikimedia.org/r/175886]]
Change 175886 had a related patch set uploaded (by Jforrester):
Point wikitext markup link in warning to MW.org

[[https://gerrit.wikimedia.org/r/175886]]

#patch-for-review
Key events fire without key codes (understandable as you can 'swipe' whole words) and backspace fires no key[up|down|press] event at all.

--------------------------
**Version**: unspecified
**Severity**: major
Note that Android 4.4's WebView is based on the Chromium engine, and unlike the standalone Chrome app it only gets updated with the OS. Might want to check whether the  stock Android browser on non-Google-branded 4.4.x devices is also affected. (Nexus devices seem to leave out the AOSP default browser in favor of Chrome, but I see a customized version on Samsung Galaxy branded devices for instance.)
OS update is not an issue, just app.
(In reply to Ed Sanders from comment #6)
> It looks like the above commit to Chrome for Mobile has been merged, which
> solves the most serious case (no event fired at all).

It doesn't "solve" it perfectly, as OS update lag for Android devices is notoriously slow (or non existent), and app update take-up is apparently poor. Is there a sane work-around we could do?

> We are still left with the general problem of IME deletion.

Yeah. :-(
It looks like the above commit to Chrome for Mobile has been merged, which solves the most serious case (no event fired at all). We are still left with the general problem of IME deletion.
"No key event is generated when the BACKSPACE key is pressed outside of composition, in other words, when AdapterInputConnection.deleteSurroundingText is called. In the reported bug, since the text field is empty, thus IME is not in the composition mode, thus pressing the BACKSPACE key triggers deleteSurroundingText and thus no key event is generated.

A cl that generates key events in deleteSurroundingText with a dummy keycode is under review at https://codereview.chromium.org/348413003/."
Not quite true, see http://jsbin.com/alAKaNaZ/5

Backspace fires a keydown with keyCode 0 (same as every other key event) but not when whitespace is deleted.

See https://code.google.com/p/chromium/issues/detail?id=184812
See https://code.google.com/p/chromium/issues/detail?id=118639 for pitchfork waving, including a complaint from the Microsoft Office Web Apps team who are having the same problem.
There is an 'input' event which fires, but this doesn't solve the problem of prevent the default backspace behaviour.
Oy.
Setup- FF 30.0. 
Steps to Reproduce-
1>Launch the FF browser.  And go to your user page in Beta labs.
2>Click on “Edit Source” tab.  Click anywhere on the Wikitext Editor pane.
3>Now while the cursor is still blinking in the editor pane, press the keyboard shortcut for the VE editor tab which is “Alt+Shift+v”.  

Actual Result-When the keyboard shortcut for the VE editor tab i,e. “Alt+Shift+v” is pressed, it just scrolls the window down, while the Wikitext Editor pane is still open and instead the “Show Changes” button gets highlighted(which apparently has the same keyboard shortcut combination).  The same behavior was observed in test2 environment for FF browser. But in Safari and Chrome no such similar behavior was found.

Expected Result-When pressed the keyboard shortcut of “Alt+Shift+v” should access the Edit beta tab and open the VE pane.

--------------------------
**Version**: unspecified
**Severity**: minor
**See Also**: {T54701}
Just to on the safe side, this is not the same as T114793?
I'd like to see meta-V in read mode be VisualEditor, and meta-V in wikitext editor be the diff.
We could have a different accesskey from action=edit (or just a new one in general), but that seems like it would confuse people.
(In reply to Alex Monk from comment #2)
> The 'Show changes' button has accesskey=v, so there's a conflict. Chrome
> just goes for the first one on the page and breaks the 'Show changes'
> shortcut, Firefox moves between the two. Not sure what we should do about
> that.

Oh, yeah, that thing. *sighs* I guess this would get fixed with a switch to a single edit tab, but I'm not sure what we could do in advance of that.
The 'Show changes' button has accesskey=v, so there's a conflict. Chrome just goes for the first one on the page and breaks the 'Show changes' shortcut, Firefox moves between the two. Not sure what we should do about that.
Yeah, Ctrl+Alt+v (on a Mac) works fine for me in read mode, but not in wikitext edit mode, where it just selects the tab… Something odd here.
Screenshot

Steps to reproduce:

1.Open a page with VE which contains a block item like reflist or image
2.Delete the image

Observed Result:
A highlight appears from the end of the previous line covering up the rest of the line.

Instead of highlighting, upon deleting the block item the cursor should just appear at the end of the previous line.

See the screenshot attached

--------------------------
**Version**: unspecified
**Severity**: minor

**Attached**: {F14275}
Verified the fix in production
Verified the fix in betalabs and test2
Change 142806 merged by jenkins-bot:
Fix up selection after deletion if at non-content offset

https://gerrit.wikimedia.org/r/142806
Change 142806 had a related patch set uploaded by Esanders:
Fix up selection after deletion if at non-content offset

https://gerrit.wikimedia.org/r/142806
Steps to reproduce:

1.Open a page with VE
2.Insert an image
3.Make it Frameless-Left or Basic-Left
4.Now uncheck the wrapping option.


Observed Result:
The previous line gets highlighted for a split second then the highlight goes away.

--------------------------
**Version**: unspecified
**Severity**: minor
1. Create a page with {{echo|foo}} in the text somewhere
2. Observe that the word "foo" is highlighted and clickable and all those good things
3. Inspect "foo", and change the parameter to "bar"
4. Click the rerendering

Note that there is no highlight, you're able to select parts of the word (!), it's not inspectable, etc.

--------------------------
**Version**: unspecified
**Severity**: minor
Change 140439 merged by jenkins-bot:
[BREAKING CHANGE] Remove generated content node wrappers

https://gerrit.wikimedia.org/r/140439
Confirmed fix
Change 140439 had a related patch set uploaded by Esanders:
[BREAKING CHANGE] Remove generated content node wrappers

https://gerrit.wikimedia.org/r/140439
What about after https://gerrit.wikimedia.org/r/140439 ?
Steps to reproduce:

1.  Go to Page settings and tick the box to make a redirect.

2.  Type in not just a page title, but also a section:  Example#Foo

3.  Now what?  If I click "Example" in the list, it deletes the #Foo part.


It turns out that if you click outside the page settings dialog, that it actually will accept this, but it looks impossible.

Then when you "apply changes", the redirect isn't visible on the page (T63861) so you can't tell whether it worked or did anything at all.
This seems to work the right way these days. If you input a title+section, the same is shown as the first element of the suggestions (but only if a page by that title exists). {F7052264}
So, when you have a title+section link in the text box, and the suggestions show the page name that's currently in there, an extra suggestion should be added for the full title+current section? I think anything more than that would be T52881
This very likely would use some (magical) technology that would be needed to fix {T52881}.
https://en.wikipedia.org/w/index.php?title=Lobstick&curid=43120379&diff=614082884&oldid=614013920

The user edited the page twice, resulting in two copies of this:

<div id="kloutify"><div></div><div id="kloutify-score">10</div></div>

at the top of the page.  The "10" is visible on the page.

http://kloutify.com/ says that this can be installed on Firefox, Chrome, and Safari.

--------------------------
**Version**: unspecified
**Severity**: minor
Change 163968 merged by jenkins-bot:
Blacklist div[id = kloutify] as well

https://gerrit.wikimedia.org/r/163968
Change 163968 had a related patch set uploaded by Alex Monk:
Blacklist div[id = kloutify] as well

https://gerrit.wikimedia.org/r/163968
Opening VisualEditor can be slow for some pages/some users.  Please offer the option of saving without exiting.

(Original suggestion:  https://en.wikipedia.org/w/index.php?diff=613298543&oldid=613210959)

--------------------------
**Version**: unspecified
**Severity**: enhancement
Interesting idea.
Steps to reproduce:

1.Open a page with Mobile VE
2.Type a text 
3.Tap on the "Return" key from the keyboard

Observed Result:
Instead of adding a newline and moving the cursor to it, it deletes the preceding text.

Device:Nexus 7(Android 4.4.2)
Environment:Production (en.wiki) and Betalabs
Needs re-testing.
Steps to reproduce:

1.Open any page with Mobile VE in Nexus 7(Android 4.4.2)
2.Type a text
3.Save the page

Observed Result:
The edit does not get saved

Device:Nexus 7(Android 4.4.2)
Environment: Production (en.wiki) and Betalabs

--------------------------
**Version**: unspecified
**Severity**: major
Checked this issue , in en.wiki and test2 , not happening anymore. closing this one.
Was this specifically with that device, and not any others tested?
Seems to be a mis-tag.
Change 145222 had a related patch set uploaded by BryanDavis:
[WIP] Enable HHVM debugging REPL

https://gerrit.wikimedia.org/r/145222
Try to recheck in case this was a deployment issue?
Steps to reproduce:

1.Open a page with mobile VE
2.Tap at the end of a link

Observed Result:
The link gets copied at the position your cursor was on and it will keep continue doing that everytime you place your cursor at the end of extended link.

See the screenshot attached

Device: Nexus 7(Android 4.4.2)
Environment:Production (en.wiki) and Betalabs

--------------------------
**Version**: unspecified
**Severity**: normal
Needs re-testing.
Right now the HTML created for
- headings specified using Wikitext (e.g. "==")
- headings created using HTML tags (e.g. "<h2>")
look basically the same.

- Both have a wrapping heading element (without class or id)
- Both contain a <span> of class "mw-headline"

The only (but major) difference is that sections created by Wikitext are editable and therefore contain an additional <span> of class "mw-editsection".

It would be nice if there was an easy possibility to directly differentiate those types of headers on a CSS level (e.g. by an additional class applied to the parent <h*> element)


This would make it much easier to create custom CSS and JS since often one would only want to style "true" (that is editable) article headers created by Wikitext instead of custom created headers that are mostly used for design of e.g. project pages.
Right now such CSS and JS often erroneously styles all headers the same, regardless of how the headers were created, often resulting in unintentional appearance.

--------------------------
**Version**: 1.24rc
**Severity**: enhancement
It is possible (if inadvisable) to have whitespace at the start of a paragraph in HTML; to readers it is mostly invisible. In MediaWiki, because whitespace at the start of a paragraph has magic meaning, Parsoid `<nowiki />`s it. To avoid users doing this accidentally, it might be nice to design a way to flag to the user what they've done when they create these.
Thanks, Guillaume! I'll be watching.
>>! In T68628#1366507, @Elitre wrote:
> Even on Office wiki? If not, I have a diff from June 12th about that.

I had the same question earlier today, and @Jdforrester-WMF said it might be related to JavaScript that was cached in the user's browser. It may take a few weeks for the issue to completely disappear.
Even on Office wiki? If not, I have a diff from June 12th about that.
VisualEditor now strips leading whitespace by design, so this task has become obsolete. Closing.
It's still happening:  https://en.wikipedia.org/w/index.php?diff=660662487&oldid=657477479  The original had only one space between paragraphs, but I usually add two in wikitext ("English spacing"), so there may have been two spaces at the time that I hit return to split the paragraphs.
This issue came up 4 times out of 100 reviewed diffs, and accounted for ⅔ of problematic diffs on the English Wikipedia this week ( T94767#1225878 ). I see this being a possible point of contention during a wider roll-out.

Based on those numbers, I'm re-nominating this issue as a blocker for further discussion.
{T78137} sounds like an interesting approach.

I tested now and it seems like the leading spaces can still be created and displayed in the editor, but magically disappear when the MediaWiki page is saved.
@Jdforrester-WMF by the way, was this officially rejected as blocker, or was the blocker tag removed for another reason?
>>! In T68628#1150309, @Jdforrester-WMF wrote:
> 
> I have reverted the title change because it is **completely** wrong. "Remove nowikied spaces at the beginning of a paragraph unless the user manually inserted them" means "please corrupt pages on load", and is absolutely the wrong this to do. VisualEditor is not in the business of "fixing" pages. If you click edit, then click save without making changes, there should never ever be any difference, or we've failed.

That's not at all what I meant. I didn't suggest we fix unrelated spaces; I thought the accompanying description (which you moved to T93935) made that clear. Sorry for the misunderstanding.
I'm having second thoughts about my earlier all-clear.  It's possible that this problem only arises if the wikitext uses French spacing (two spaces after the full stop).  If that's the case—if it strips one space but leaves the second—then my test yesterday is inadequate, because I didn't check what the wikitext looks like.
I've restored this task back to what it's about, which is a **design** issue about discouraging odd user behaviour, and has essentially nothing to do with `<nowiki />`s, which are already dealt with in multiple other tasks.
>>! In T68628#1150358, @Whatamidoing-WMF wrote:
> This appears to be fixed now (same browser/same article test).
> 
> I think that a title of "Stop adding nowiki'd spaces at the start of newly
> split paragraphs" would capture the ask better.  I don't really want to see
> the spaces (although that would be better than having them present but
> invisible); I want the stray spaces to not be present in the first place.

That's a different task, which I have created: {T93935}.
This appears to be fixed now (same browser/same article test).

I think that a title of "Stop adding nowiki'd spaces at the start of newly
split paragraphs" would capture the ask better.  I don't really want to see
the spaces (although that would be better than having them present but
invisible); I want the stray spaces to not be present in the first place.
>>! In T68628#1146900, @gpaumier wrote:
> Are there any valid use cases for keeping those white spaces at the beginning of a paragraph? Otherwise I think we should just remove them. If we don't want to remove them automatically on save, then as @Whatamidoing-WMF suggested in T68628#967908 , we should at least remove the space when editing, so that the nowikied space is added //only if// the user explicitly inserts it.

I have reverted the title change because it is **completely** wrong. "Remove nowikied spaces at the beginning of a paragraph unless the user manually inserted them" means "please corrupt pages on load", and is absolutely the wrong this to do. VisualEditor is not in the business of "fixing" pages. If you click edit, then click save without making changes, there should never ever be any difference, or we've failed.
I have reverted the title change because it is **completely** wrong. "Remove nowikied spaces at the beginning of a paragraph unless the user manually inserted them" means "please corrupt pages on load", and is absolutely the wrong this to do. VisualEditor is not in the business of "fixing" pages. If you click edit, then click save without making changes, there should never ever be any difference, or we've failed.
Are there any valid use cases for keeping those white spaces at the beginning of a paragraph? Otherwise I think we should just remove them. If we don't want to remove them automatically on save, then as @Whatamidoing-WMF suggested in T68628#967908 , we should at least remove the space when editing, so that the nowikied space is added //only if// the user explicitly inserts it.
The nowikied space also persists if a user then removes the newline. See https://en.wikipedia.org/w/index.php?diff=653301980 for an example in which:
* an existing nowikied space at the beginning of a paragraph now lives in the middle of a paragraph;
* a new nowikied space was added at the beginning of a paragraph.
I'm adding Parsoid to this, because Subbu thought that it might be solvable there.
This is still happening.  I'm still not doing anything exceptional:  I put my cursor in between two sentences and press the Return key.  This still should not be happening. If I want to start a paragraph with a space, then I should have to actually press the space bar.

https://en.wikipedia.org/w/index.php?diff=prev&oldid=641792115
No, they actually are not shown.  

Download the screenshot and pull it into Preview on your Mac. Zoom in six times, scroll way over to the red ovals, and use "Tools:Annotate:Line" to draw a vertical line down the leading edge of those paragraphs.  Hold down your shift key to keep the line straight.  Set the line to the thinnest option in the toolbar.  

Now count the pixels between your line and the beginnings of each letter on those paragraphs.  The straight edge on the 'r' of 'raised', the 'E' of 'Experience', and the 'M' of 'Modern' are very convenient for this.  

There is no visible difference.  Where I drew my line, I found exactly one pixel between my line and the start of each character.  Something that does not display as even a single pixel on a reasonably typical laptop is properly described as "not shown".
They actually are shown – but it's very hard to see them. Re-wording.
Created attachment 15656
Nowiki tags enclose spaces, but no spaces are shown in VisualEditor

**Attached**: {F13610}
Highlighting entire paragraphs and applying or removing list formatting should consistently apply or remove formatting, currently some items are ignored.

--------------------------
**Version**: unspecified
**Severity**: enhancement
**See Also**:
https://bugzilla.wikimedia.org/show_bug.cgi?id=42115
(In reply to Jared Zimmerman (WMF) from comment #4)
> I'd love for us to do a set of user tests around this. Just because
> word/gdocs/openoffice does something doesn't mean it is the correct thing to
> do. Not saying we got it wrong, but I think hearing specific feedback on
> this from users might be useful. 

Absolutely. Just flagging that we've already spent many dozens of hours going back and forth about this with users and designers. It's not remotely a green field. :-)

> I agree that a table or a link isn't "formatting" in this sense, but lists
> don't fit as neatly into that category for me, I'd love to hear from users.

Definitely.
@abbey, can you create a card in the backlog to help the VE team validate some of the assumptions around formatting behavior best practices please.
I'd love for us to do a set of user tests around this. Just because word/gdocs/openoffice does something doesn't mean it is the correct thing to do. Not saying we got it wrong, but I think hearing specific feedback on this from users might be useful. 

I agree that a table or a link isn't "formatting" in this sense, but lists don't fit as neatly into that category for me, I'd love to hear from users.
(In reply to Jared Zimmerman (WMF) from comment #2)
> Nested list items…
> 
> Shouldn't clear formatting clear nested list items styles as well? That
> would be my expectation.

No. Lists, tables, blockquotes, headers, preformatted etc. are all considered "structural" changes rather than "styles".

Right now the selection-action behaviour for links is modelled after a number of different editors with some insanely complex edge-cases (e.g. applying "make numbered list" to a selection covering some numbered list items, some paragraphs, some nested bullet list sub-items, and some partials of the above).
Nested list items…

Shouldn't clear formatting clear nested list items styles as well? That would be my expectation.
(In reply to Jared Zimmerman (WMF) from comment #0)
> Highlighting entire paragraphs and applying or removing list formatting
> should consistently apply or remove formatting, currently some items are
> ignored.

Which items?
Because of {T139740} this is unlikely to ever get done.
A tool like these could automate the process:

http://xinminlabs.github.io/synvert/rules/
https://github.com/yujinakayama/transpec
Removed release-engineering, since it does not belong there.
Removed patch-for-review, since all related patches (as far as I can see) are merged or abandoned.
Removed
@jagori79 are you working on this? If not, please remove yourself from "assigned to". Thanks.
@Physikerwelt: no problem. I think it would be a lot of noise if we created 20 or so subtasks, but it is something to consider for the future tasks.
Sorry for closing this bug. I thought it was only about the Math extension, because the project Math was specified. I think in the future it might be better to add subtasks for each extension.
Change 186947 merged by jenkins-bot:
Use rspec-expectations "expect" syntax instead of "should" syntax

[[https://gerrit.wikimedia.org/r/186947]]
Change 186949 merged by jenkins-bot:
Change RSpec 2 should syntax to RSpec 3 expect syntax

[[https://gerrit.wikimedia.org/r/186949]]
Change 187269 merged by jenkins-bot:
RSpec 3 expect syntax incorporation

[[https://gerrit.wikimedia.org/r/187269]]
Change 179072 merged by jenkins-bot:
Refactor code for RSpec3 expect syntax incorporation

[[https://gerrit.wikimedia.org/r/179072]]
I was not able to test this for the Math Extension:
See my comment in gerrit:
"
I could not test the effects of this change. I tried to run the tests on labs-vagrant instance following the guide at https://www.mediawiki.org/w/index.php?title=Quality_Assurance/Browser_testing/Running_tests#Running_VisualEditor_browser_tests_via_labs-vagrant However, even on master I get the following output https://gist.github.com/physikerwelt/5761056c077c02a8c636
"
Change 187269 had a related patch set uploaded (by Jagori79):
RSpec3 expect syntax incorporation

[[https://gerrit.wikimedia.org/r/187269]]

#patch-for-review
Change 186949 had a related patch set uploaded (by Jagori79):
Changing should to expect syntax

[[https://gerrit.wikimedia.org/r/186949]]

#patch-for-review
Change 186947 had a related patch set uploaded (by Jagori79):
RSpec3 expect syntax incorporation

[[https://gerrit.wikimedia.org/r/186947]]

#patch-for-review
Change 186947 had a related patch set uploaded (by Jagori79):
RSpec3 expect syntax incorporation

[[https://gerrit.wikimedia.org/r/186947]]

#patch-for-review
@Cmcmahon can you do a code review for this change?
Change 179072 had a related patch set uploaded (by Physikerwelt):
Refactor code for RSpec3 expect syntax incorporation

[[https://gerrit.wikimedia.org/r/179072]]

#patch-for-review
Change 146712 abandoned by Jagori79:
WIP [BrowserTest] Use rspec-expectations expect syntax instead of should syntax

Reason:
I am abandoning this change as already been implemented for Visual Editor.I will make the expect syntax changes on other codebase as suggested by Chris on the QA mailing list.

[[https://gerrit.wikimedia.org/r/146712]]
Thanks,Yes,will work on the other repositories.
If the change you were working on is already implemented, it probably makes sense to abandon your commit. We have plenty of other repositories where the change should be implemented. :)

https://github.com/wikimedia/mediawiki-selenium#links
Zeljko:I see the changes already implemented for Visual editor code,should I abandon the part which I was working on :https://gerrit.wikimedia.org/r/#/c/146712/

I had restored it .
Change 146712 restored by Jagori79:
WIP [BrowserTest] Use rspec-expectations expect syntax instead of should syntax

Reason:
Restoring

[[https://gerrit.wikimedia.org/r/146712]]
Change 146712 abandoned by Zfilipin:
WIP [BrowserTest] Use rspec-expectations expect syntax instead of should syntax

Reason:
No activity on the commit in months. Please restore if you plan to work on this.

https://gerrit.wikimedia.org/r/146712
Change 147423 merged by jenkins-bot:
Use rspec-expectations expect syntax instead of should syntax

https://gerrit.wikimedia.org/r/147423
Change 147423 had a related patch set uploaded by Zfilipin:
Use rspec-expectations expect syntax instead of should syntax

https://gerrit.wikimedia.org/r/147423
Change 146712 had a related patch set uploaded by Jagori79:
WIP [BrowserTest] Use rspec-expectations expect syntax instead of should syntax

https://gerrit.wikimedia.org/r/146712
(In reply to Željko Filipin from comment #1)
> Pick a repository:
> 
> https://github.com/wikimedia/mediawiki-selenium#links
> 
> Replace all expect syntax with should syntax.

  Editing the above line to :
   > Replace all should syntax with expect syntax.
@Zeljko: I am not able to assign the bug to myself.Could you please look into it.
I cannot see the "Edit" link.
We should have a sane way of including screenshots with skins and displaying them in the UI. These would be useful on Special:Preferences, in the installer when it will ask you which skin to choose, on Special:Version…

I coded up something that works but is probably not a good idea at https://gerrit.wikimedia.org/r/#/c/138110/ – this would just add support for a new key to $wgExtensionCredits.

One interesting issue is, what resolution should we expect the screenshot to be?

Another one is, how do we display it? Unless we want to push the whole thing through ResourceLoader CSS handling (which would be extremely silly), we need to know the URL path where the screenshot is available (relative to $wgStylePath?). This is not obvious :(

**See Also**: {T70331}

----

**The new convention**:
* Every skin can include screenshots in the screenshots/ directory, which will be shown in the installer (and possibly elsewhere in the future).
* It should include at least one 1280x800px screenshot, plus any extra screenshots if your skin looks different at different screen resolutions or with different configuration options.
* You should disable any extensions or uncommon configuration options when taking the screenshots.
* Make sure not to include any copyrighted content in the screenshots – here's some public domain content you can use:
** Page content: P5878
** Site logo: the MediaWiki logo (`$wgLogo = "/w/resources/assets/mediawiki.png";`)
** Images: [[https://commons.wikimedia.org/wiki/File:Turner,_J._M._W._-_The_Fighting_Téméraire_tugged_to_her_last_Berth_to_be_broken_(edit).jpg|1]] [[https://commons.wikimedia.org/wiki/File:Bierstadt_Albert_Indian_Summer_Hudson_River.jpg|2]] [[https://commons.wikimedia.org/wiki/File:Meisje_met_de_parel.jpg|3]]
**Examples**:
{F9028486,float} {F9028461,float} {F9028439,float}

----
No. I almost did it, but to upload them there, you'd have to find out the right license for every single one separately, and that was more effort than I was willing to put into it. The skins can each have different licenses, they're not all on GPL like MediaWiki.
This task has been pointed from {T179709}, where we are trying to take screenshots of skins that doesn't have one yet in their mediawiki.org skin page. Have the pictures taken during the work done for this task been inserted on mw.org?
It would be good to write this up as a seleniumJS script (see VisualEditor/build/screenshots.js), because skins change.
Also documented at https://www.mediawiki.org/wiki/Manual:Skinning_Part_2#Screenshots
With these patches merged, 24 skins out of 42 in our version control have screenshots.

The others ones are read-only repos, immediately fatal when enabled, don't seen to have any styles at all, or have other big problems.

| Skin | Status |
| -- | -- |
| apex | {icon check, color=green}
| Athena | 
| Blueprint | 
| BlueSky | {icon check, color=green}
| BlueSpiceSkin | 
| Bouquet | {icon check, color=green}
| CologneBlue | {icon check, color=green}
| CustomPage | 
| Daddio | {icon check, color=green}
| DeskMessMirrored | {icon check, color=green}
| Dusk | {icon check, color=green}
| DuskToDawn | 
| Empty | 
| erudite | {icon check, color=green}
| Example | {icon check, color=green}
| Gamepress | 
| GreyStuff | {icon check, color=green}
| HasSomeColours | 
| Mask | {icon check, color=green}
| Material | 
| mediawiki-strapping | 
| Metrolook | {icon check, color=green}
| MinervaNeue | {icon check, color=green}
| Modern | {icon check, color=green}
| MonoBook | {icon check, color=green}
| Nimbus | {icon check, color=green}
| Nostalgia | {icon check, color=green}
| p2wiki | 
| Poncho | 
| Refreshed | 
| Schulenburg | 
| Splash | {icon check, color=green}
| Synagonism | 
| Tempo | {icon check, color=green}
| Timeless | {icon check, color=green}
| Tomas | 
| Truglass | {icon check, color=green}
| Vector | {icon check, color=green}
| VectorV2 | 
| webplatform | {icon check, color=green}
| WoOgLeShades | 
| WPtouch | {icon check, color=green}
Change 371548 merged by jenkins-bot:
[mediawiki/skins/Timeless@master] Add skin screenshots for the installer

[[https://gerrit.wikimedia.org/r/371548]]
Change 371537 merged by jenkins-bot:
[mediawiki/skins/MonoBook@master] Add skin screenshot for the installer

[[https://gerrit.wikimedia.org/r/371537]]
Change 371538 merged by jenkins-bot:
[mediawiki/skins/Nimbus@master] Add skin screenshot for the installer

[[https://gerrit.wikimedia.org/r/371538]]
Change 371539 merged by jenkins-bot:
[mediawiki/skins/Nostalgia@master] Add skin screenshot for the installer

[[https://gerrit.wikimedia.org/r/371539]]
Change 371540 merged by jenkins-bot:
[mediawiki/skins/Splash@master] Add skin screenshot for the installer

[[https://gerrit.wikimedia.org/r/371540]]
Change 371541 merged by jenkins-bot:
[mediawiki/skins/Tempo@master] Add skin screenshot for the installer

[[https://gerrit.wikimedia.org/r/371541]]
Change 371542 merged by jenkins-bot:
[mediawiki/skins/Truglass@master] Add skin screenshot for the installer

[[https://gerrit.wikimedia.org/r/371542]]
Change 371544 merged by jenkins-bot:
[mediawiki/skins/webplatform@master] Add skin screenshot for the installer

[[https://gerrit.wikimedia.org/r/371544]]
Change 371545 merged by jenkins-bot:
[mediawiki/skins/WPtouch@master] Add skin screenshot for the installer

[[https://gerrit.wikimedia.org/r/371545]]
Change 371546 merged by jenkins-bot:
[mediawiki/skins/GreyStuff@master] Add skin screenshot for the installer

[[https://gerrit.wikimedia.org/r/371546]]
Change 371536 merged by jenkins-bot:
[mediawiki/skins/Modern@master] Add skin screenshot for the installer

[[https://gerrit.wikimedia.org/r/371536]]
Change 371534 merged by jenkins-bot:
[mediawiki/skins/Metrolook@master] Add skin screenshot for the installer

[[https://gerrit.wikimedia.org/r/371534]]
Change 371530 merged by jenkins-bot:
[mediawiki/skins/Dusk@master] Add skin screenshot for the installer

[[https://gerrit.wikimedia.org/r/371530]]
Change 371529 merged by jenkins-bot:
[mediawiki/skins/DeskMessMirrored@master] Add skin screenshot for the installer

[[https://gerrit.wikimedia.org/r/371529]]
Change 371528 merged by jenkins-bot:
[mediawiki/skins/Daddio@master] Add skin screenshot for the installer

[[https://gerrit.wikimedia.org/r/371528]]
Change 371527 merged by jenkins-bot:
[mediawiki/skins/CologneBlue@master] Add skin screenshot for the installer

[[https://gerrit.wikimedia.org/r/371527]]
Change 371526 merged by jenkins-bot:
[mediawiki/skins/Bouquet@master] Add skin screenshot for the installer

[[https://gerrit.wikimedia.org/r/371526]]
Change 371548 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/skins/Timeless@master] Add skin screenshots for the installer

[[https://gerrit.wikimedia.org/r/371548]]
Change 371533 merged by jenkins-bot:
[mediawiki/skins/Mask@master] Add skin screenshot for the installer

[[https://gerrit.wikimedia.org/r/371533]]
Change 371532 merged by jenkins-bot:
[mediawiki/skins/Example@master] Add skin screenshot for the installer

[[https://gerrit.wikimedia.org/r/371532]]
Change 371531 merged by jenkins-bot:
[mediawiki/skins/erudite@master] Add skin screenshot for the installer

[[https://gerrit.wikimedia.org/r/371531]]
Change 371543 merged by jenkins-bot:
[mediawiki/skins/Vector@master] Add skin screenshot for the installer

[[https://gerrit.wikimedia.org/r/371543]]
Change 371535 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@master] Add skin screenshot for the installer

[[https://gerrit.wikimedia.org/r/371535]]
Change 371546 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/skins/GreyStuff@master] Add skin screenshot for the installer

[[https://gerrit.wikimedia.org/r/371546]]
Change 371545 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/skins/WPtouch@master] Add skin screenshot for the installer

[[https://gerrit.wikimedia.org/r/371545]]
Change 371544 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/skins/webplatform@master] Add skin screenshot for the installer

[[https://gerrit.wikimedia.org/r/371544]]
Change 371543 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/skins/Vector@master] Add skin screenshot for the installer

[[https://gerrit.wikimedia.org/r/371543]]
Change 371542 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/skins/Truglass@master] Add skin screenshot for the installer

[[https://gerrit.wikimedia.org/r/371542]]
Change 371541 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/skins/Tempo@master] Add skin screenshot for the installer

[[https://gerrit.wikimedia.org/r/371541]]
Change 371540 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/skins/Splash@master] Add skin screenshot for the installer

[[https://gerrit.wikimedia.org/r/371540]]
Change 371539 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/skins/Nostalgia@master] Add skin screenshot for the installer

[[https://gerrit.wikimedia.org/r/371539]]
Change 371538 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/skins/Nimbus@master] Add skin screenshot for the installer

[[https://gerrit.wikimedia.org/r/371538]]
Change 371537 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/skins/MonoBook@master] Add skin screenshot for the installer

[[https://gerrit.wikimedia.org/r/371537]]
Change 371536 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/skins/Modern@master] Add skin screenshot for the installer

[[https://gerrit.wikimedia.org/r/371536]]
Change 371535 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/skins/MinervaNeue@master] Add skin screenshot for the installer

[[https://gerrit.wikimedia.org/r/371535]]
Change 371534 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/skins/Metrolook@master] Add skin screenshot for the installer

[[https://gerrit.wikimedia.org/r/371534]]
Change 371533 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/skins/Mask@master] Add skin screenshot for the installer

[[https://gerrit.wikimedia.org/r/371533]]
Change 371522 merged by jenkins-bot:
[mediawiki/skins/BlueSky@master] Add skin screenshot for the installer

[[https://gerrit.wikimedia.org/r/371522]]
Change 371532 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/skins/Example@master] Add skin screenshot for the installer

[[https://gerrit.wikimedia.org/r/371532]]
Change 371531 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/skins/erudite@master] Add skin screenshot for the installer

[[https://gerrit.wikimedia.org/r/371531]]
Change 371530 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/skins/Dusk@master] Add skin screenshot for the installer

[[https://gerrit.wikimedia.org/r/371530]]
Change 371529 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/skins/DeskMessMirrored@master] Add skin screenshot for the installer

[[https://gerrit.wikimedia.org/r/371529]]
Change 371525 abandoned by Bartosz Dziewoński:
Add skin screenshot for the installer

Reason:
Whoops, duplicate.

[[https://gerrit.wikimedia.org/r/371525]]
Change 371528 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/skins/Daddio@master] Add skin screenshot for the installer

[[https://gerrit.wikimedia.org/r/371528]]
Change 371524 abandoned by Bartosz Dziewoński:
Add skin screenshot for the installer

Reason:
Whoops, duplicate.

[[https://gerrit.wikimedia.org/r/371524]]
Change 371527 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/skins/CologneBlue@master] Add skin screenshot for the installer

[[https://gerrit.wikimedia.org/r/371527]]
Change 371521 merged by jenkins-bot:
[mediawiki/skins/apex@master] Add skin screenshot for the installer

[[https://gerrit.wikimedia.org/r/371521]]
Change 371526 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/skins/Bouquet@master] Add skin screenshot for the installer

[[https://gerrit.wikimedia.org/r/371526]]
Change 371525 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/skins/BlueSky@master] Add skin screenshot for the installer

[[https://gerrit.wikimedia.org/r/371525]]
Change 371524 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/skins/apex@master] Add skin screenshot for the installer

[[https://gerrit.wikimedia.org/r/371524]]
Change 371522 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/skins/BlueSky@master] Add skin screenshot for the installer

[[https://gerrit.wikimedia.org/r/371522]]
Change 371521 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/skins/apex@master] Add skin screenshot for the installer

[[https://gerrit.wikimedia.org/r/371521]]
<3
| MinervaNeue | {F9036540} | {F9036540,layout=link}
@matmarex probably needs MobileFrontend to be installed. It's still a bit weird in that way. :(
I tried to include it, but it's shown me some error message so I skipped it. Maybe I'll look at it again later and try to actually read what the error says. I don't think it's a major problem if it's inconsistent; I won't be taking screenshots of all skins forever so they will soon enough become inconsistent anyway.
Can #MinervaNeue get in on the screenshot  action? I cam generate one but it's  likely to be inconsistent..
You're awesomeeeee <3
Change https://gerrit.wikimedia.org/r/371080 (fd8d75c1fd26e9ca0976111f1b3861935a53f84b) makes this possible. I guess we should take a bunch of screenshots and include them now? :o
A full preview sounds a bit sketchy on the site, but would it potentially be possible to do the full preview somewhere else? Have a screenshot available with the skin, also have an optional link to a testwiki preview (like maybe just set up an entire toollabs wiki or whatever you call it for that)... this wouldn't cover all skins, but for ones included with the tarball and even in gerrit and crap it would be pretty straight forward to set up.

Would be a bit harder to maintain, though.
We wouldn't want it to get too complicated, both on the admin and on the user end, but I dunno.

If nothing else, having a small thumbnail just so there's something visual at all would certainly be useful, but we can't expect the thumbnail/screenshot to do much beyond that. So... er... there should be both. We should have both things - a more immediate preview mechanism, and a small thumbnail for initial eye-catching and later locating in the list.
I actually agree with Isarra somewhat - a preview is better than a screenshot. That said the current experience is terrible. Previewing the preference page for one makes no sense - it would be far better to see something in the main namespace rendered via the chosen skin.

Tumblr does a great job in its theme interface. You can select and search for skins and they instantly get applied so it's easy to flick between them and see the skin in the context of an ipsum lorem article.

This could be a great opportunity to break skins out of Special:Preferences - maybe Special:Preferences/Skin and just provide a good simple interface for skin switching - maybe a drop down at the top and an Ipsum lorem article rendered below. When we have templating in core we could even do this rendering via JavaScript :-).
What's wrong with ?useskin? 

Except in the installer. That would need something fancier, or something. Unless there'd be some way to safely automatically include them temporarily for preview... er...

I don't know where I was going with that.
1. Click Cite -> Newspaper
2. A dialog opens; while it's opening, the title is "Newspaper"
3. Once it finishes opening, the title changes to "Cite news"

This is more visible on a slower system or with an artificially lengthened opening animation.

--------------------------
**Version**: unspecified
**Severity**: minor
Steps to reproduce:

1.Open a page with VE
2.Insert an image
3.Click somewhere outside the page where the VE toolbar will get disabled
4.Now click on the image.

Observed Result:
Clicking on the image tries to select the image first then cursor moves to the beginning of the document.

Environment :Betalabs

--------------------------
**Version**: unspecified
**Severity**: normal
Verified the fix in en.wiki running wmf 8
Verified the fix in Betalabs and test2
Change 136013 merged by jenkins-bot:
Don't fix selection on document focus if focusedNode is set

https://gerrit.wikimedia.org/r/136013
Change 136013 had a related patch set uploaded by Esanders:
Don't fix selection on document focus is focusedNode is set

https://gerrit.wikimedia.org/r/136013
Created attachment 15500
video capture of the bug

**Attached**: {F13645}
Steps to reproduce:

1.Open a page with VE
2.Insert an image
3.Go to the Media Settings dialog of the image
4.Type something in the caption field
5.Now place the cursor in the Alternative Test field
6.Observe that, the "Undo" button in the toolbar is still active
7.Click on the undo button

Observed Result:
It clears the text inside the caption field , this is a bit confusing , since the cursor was pointing to text inside Alternative Text and but it started clearing out the content inside caption field.

--------------------------
**Version**: unspecified
**Severity**: normal
This is because the undo and redo buttons remain active when the surface is blurred. I know this is intentional, but maybe it should be revisited.
**Author:** `wiki.nihiltres`

**Description:**
I noticed today that dialogs are delayed or fail to work some of the time in VE, using Safari 5.1.10 on Mac OS 10.6.8. The first click on a button that produces a dialog, or first few clicks, don't seem to do anything, but clicking on the button a while later has the normal effect, suggesting something's taking a while to load.

--------------------------
**Version**: unspecified
**Severity**: major
**OS**: Mac OS X 10.6
**Platform**: Macintosh
Change 135154 merged by jenkins-bot:
Move Safari 5.x to greylist because dialogs aren't working well

https://gerrit.wikimedia.org/r/135154
Change 135154 had a related patch set uploaded by Jforrester:
Move Safari 5.x to greylist because dialogs aren't working well

https://gerrit.wikimedia.org/r/135154
Yes, Confirmed on MAC OSX 10.6 and Safari 5.1. This is happening while opening any dialog for the first time , it does not open even if I try clicking on it multiple times, once I clicked on some other buttons from the toolbar both the dialogs open at the same time
Odd. Rummana, can you test this and confirm behaviour?
Steps to reproduce:

1.  Open any page that contains the {{coord}} template on en.wp  See, e.g., https://en.wikipedia.org/wiki/Harton,_North_Yorkshire 


Results:

The coordinates template, which should be in the top right corner, displays in the far left—so far to the left that only the last few characters are visible.

--------------------------
**Version**: unspecified
**Severity**: normal
Yes, this is because we give the document padding instead of margin to make the margins clickable.
Today in (try here: https://en.wikipedia.org/wiki/Burpengary_Creek?veaction=edit ) it is on the far right, so far right that there is no margin between the final character and the scrollbar, as Elitre described.  However, it's also one line too low, which means that it makes the last few words of the first paragraph very difficult to read.
I tried as well, and what happens for me in FF and Chrome is that the template moves completely to the right and there is no margin between the E and the scrollbar.
Cannot reproduce the problem anymore on https://en.wikipedia.org/wiki/Harton,_North_Yorkshire?veaction=edit even after hovering over the Coord template and clicking it. Same for Quiddity's other two links. Coord stays on the right where it belongs in Firefox 36 on Fedora 21.

Should this task be closed as resolved / declined?
The above example is still basically the same. Possibly different, is that the template only moves to the far-left *after* I mouseover the template. (Firefox and Chrome).

However, at other articles, it moves to different places. 
e.g. https://en.wikipedia.org/wiki/Happy_Valley,_Victoria after I mouseover the link, it moves downwards by ~1cm, so that it overlaps the infobox.
e.g.2. https://en.wikipedia.org/wiki/Happy_Valley,_South_Australia after I mouseover the template, it moves to the far-left, but also far-down the page (underneath the ==References== section).
This is related to T52855 about parser functions and magic words.

When I have a sentence on a page like this:

   Choose the "{{int:visualeditor-dialogbutton-reference-tooltip}}" item in the "{{int:visualeditor-toolbar-insert}}" menu. 

I want to be able to:

(1) copy and paste; 
(2) edit; and
(3) create

the {{int:foo}} parts.  

Right now, I can only copy them for re-use elsewhere on the page if I select a bigger block of text (so "{{int:visualeditor-toolbar-insert}}", but not just {{int:visualeditor-toolbar-insert}}).

I can't edit them at all; it's an uneditable alienated text block.  Given the long strings of similar names for some of these items, it would be really handy to be able to copy and paste something like {{int:visualeditor-toolbar-insert}} and only need to change the "insert" bit to "cite-label", or to fix a typo in the name.

It would also be nice to have a sensible system for creating these things.  At the moment, it can only be done through this sequence:  Insert > Template, "Other options", Content, type in the wikitext, and Insert transclusion. 

However, my main concern is just being able to edit existing ones.
@Whatamidoing-WMF, I'm sure it's //possible//, but generally we shouldn't introduce behavioral inconsistencies without a good reason. Whatever the decision on changing the name of a  transclusion is, it should probably apply to all types of transclusions.
I believe that has already been filed and declined for templates, although I can't find it.  Do you want to handle transcluded magic words and the like differently from transcluded templates?  (Is that even feasible?)
@Whatamidoing-WMF, fair point. Do you want to file a separate task for changing the name of an existing transclusion?
It is still not possible to edit them, e.g., to fix a typo.  You have to delete them and re-create them.  This is perhaps not surprising, since you can't fix a typo in a template name, either.
>Update: I can insert parser functions by adding a "template" named (for example) "int:vector-view-edit". It says there's no TemplateData, but it adds it.

Given that it's now possible to easily transclude and move interface messages, I'm closing this. I've opened T106755 for the low-priority challenge of making it more user-friendly.
Update:  I can insert parser functions by adding a "template" named (for example) "int:vector-view-edit".  It says there's no TemplateData, but it adds it.
I spent a lot of time wondering why my citations were not rendering properly.

VisualEditor shows a cite menu which behaves strangely if the Cite extension not enabled.

Should this throw an error or not show the citation tool when the Cite extension is not installed?

--------------------------
**Version**: unspecified
**Severity**: normal
Well technically we should move all the reference code to the Cite extension...
Yeah, this is a bit of a crummy situation. We should fix this.
It looks like we aren't percent-decoding & underscore-removing the resource properly in the serializer. This also seems to be the case for block images.
1. go to article on en.m.wiki
2. invoke WTE type characters
3. shake phone, [undo/cancel] dialog is displayed
4. choose undo

expected : typed characters should be removed
actual : typing is not undone

5. once undo works, shaking phone again should trigger [redo/cancel] which should restore undone action.

--------------------------
**Version**: unspecified
**Severity**: normal
Just testing on iphone, and ipad, in VE and WTE, issue is no longer present. closing.
@Jaredzimmerman-WMF Works for me. Tested in Mobile Safari on iPhone.
@Jdforrester-WMF this behaviour should be supported by both editors on mobile devices which support this gesture. Its isn't actually WTE specific.
What about #VisualEditor is there to do on this task?
@Jdlrobson why is this non-actionable, can you please comment as to what is needed to unblock this?
WikiTextEditor (e.g. not VE)
**jgonera** wrote:

What is WTE?
If you didn't mean to shake the OS already shows a dialog with [undo/cancel] this is a standard part of the OS that you can't turn off.
(Also what happens if I didn't mean to shake...? - happens to me all the time - had to disable it in Google Maps)
Please talk to Maryana about scheduling and prioritizing this feature request.
**bingle-admin** wrote:

Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/pNCKv65l
It's impossible to create a new page / new content without this. :-(
Just that - finding a place for it to go.
What else do we need to do here other than add the formatting menu to MobileViewTarget?
**bingle-admin** wrote:

Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/5i7pUTTK
Quora has a lovely feature in its visual editor: paste a URL and it's immediately and automatically converted in a smart way.

* If it's a link to another answer on Quora, it is given an appropriate title.
* If it's a link to YouTube, the video is embedded.
* If it's a link to some other website, the page's HTML <title> is inserted and automatically linked. (There may be other special cases, but you get the idea.)

After the link is thus inserted, the user can edit the text or click another button to make the actual URL appear or to make the URL just plain text.

I'd love such a feature in VE. It's especially relevant for newbies who link to other Wikipedia articles with full http links as if they were external. For external links, getting the title automatically is usually better than having a plain URL (in fact, there are some bots that automatically insert such titles). And pasting a Commons URL can embed the media as such.

--------------------------
**Version**: unspecified
**Severity**: enhancement
Pasting URLs now does sensible things, even converting to internal links when appropriate. Mostly thanks to work by @cscott.
(In reply to Amir E. Aharoni from comment #4)
> I meant not only external links, but pages in the same wiki, too. It's
> anecdotal, but I see newbies adding http urls to other Wikipedia article
> instead of using square brackets, and this should be DWIMmier.

Those already get converted to internal (well, interwiki) links, though…
I meant not only external links, but pages in the same wiki, too. It's anecdotal, but I see newbies adding http urls to other Wikipedia article instead of using square brackets, and this should be DWIMmier.
Hmm. Right now we're taking newly-created external links and displaying them as auto-numbered link nodes; having this as a secondary mode to fetching the <title> could work, but… I'm not sure.
This could potentially inform the VE UI for citoid;

I.e. we could have have one reference dialog, (i.e. the basic reference dialog) and then if a user pastes a link *into* the reference dialog, that inserts the citation guessed from the link. And then keep the drop down menu for individual templates in the ref dialog.

This does take some user discovery; however, I see this commonly being done with references already- i.e. a ref tag containing only an unformatted url. So it seems people are already just pasting links into the ref field and this is a natural enhancement of that work flow. 

This, by the way, is what both G+ and Facebook do for links as well, not just Quora. So there may be already some user comfort with a pasted link becoming formatted in some fashion.
Interesting idea. We've got some work planned to do this kind of thing for citations (you feed it a URL, it inserts a nice <ref>{{cite web|…}}</ref> block), and links to internal or interwiki targets get auto-converted on save (so [[:en:Foo|Bar]] not [https://en.wikipedia.org/wiki/Foo Bar]), but we don't do this for pasting into the surface. Maybe something we could do in the future?
Compare the keyboard shortcut help dialog (Ctrl+/) in the standalone demo vs the MW integration. The one in standalone has a smaller font size.

--------------------------
**Version**: unspecified
**Severity**: normal
Fixed in gerrit 141089.
Add anchor links to each feature so that a user could send someone directly to a feature. For example, https://en.wikipedia.org/wiki/Special:Preferences#mw-prefsection-betafeatures#VisualEditor
(In reply to Kaity Hammerstein from comment #0)
> Add anchor links to each feature so that a user could send someone directly
> to a feature. For example,
> https://en.wikipedia.org/wiki/Special:Preferences#mw-prefsection-
> betafeatures#VisualEditor

I don't think double anchors like that even work?

In my patch the links are created like https://en.wikipedia.org/wiki/Special:Preferences#mw-prefsection-betafeatures-betafeatures-vector-compact-personal-bar

Where "betafeatures-vector-compact-personal-bar" is the preference key used for the CPB BF in VectorBeta. So for VE it would be "visualeditor-enable".
Change 133419 had a related patch set uploaded by Legoktm:
Add an anchor for individual features

https://gerrit.wikimedia.org/r/133419
Screenshot

Steps to reproduce:

1.Open a blank page with mobile VE
2.Click on the link inspector icon
3.Without adding any text just close the inspector

Observed Result:
The link inspector icon in the toolbar remains highlighted where as there is no link added in the CE

--------------------------
**Version**: unspecified
**Severity**: minor

**Attached**: {F13539}
Screenshot

Steps to reproduce:

1.Open a page with VE
2.Edit something
3.Switch to edit source mode
4.Save the page from edit source mode

Observed Result:
The message  "The page has been restored" appearing on top of the page instead of 
"your edit was saved"

--------------------------
**Version**: unspecified
**Severity**: minor

**Attached**: {F14068}
Verified the fix in production
Verified the fix on test2
Verified the fix on Betalabs
Should be fixed now.
Change 133363 merged by jenkins-bot:
Only send useful oldid while switching to wikitext editor if it's specifically requested

https://gerrit.wikimedia.org/r/133363
Change 133363 had a related patch set uploaded by Alex Monk:
Only send useful oldid while switching to wikitext editor if it's specifically requested

https://gerrit.wikimedia.org/r/133363
A "Request desktop site" option exists in Chrome and Firefox on Android, and maybe in some other browsers too.

I believe what that option affects is just a user-agent string, and does not change other behaviors of the browser. However (for example in Firefox), with "Request desktop site" on, VisualEditor works happily, while with that option off, VisualEditor refuses to load.

We should check whether VE actually works in these browsers, and have it whitelisted or blacklisted, regardless of whether that option is on or off.

--------------------------
**Version**: 1.24rc
**Severity**: normal
If I understand correctly:
* When users of Firefox Mobile use "Request desktop site", it uses a user agent header jQuery Client recognises as desktop Firefox. And VE supports that. And that browser supports VE. All is good.
* When users of Firefox Mobile use the default mode, it uses a user agent header jQuery Client doesn't yet recognise properly (version=mobile). VE doesn't whitelist that. But it seems otherwise that browser would support VE.

I'm not sure that working around the intentionally faked user-agent header will be feasible. It would leave us in a hard to maintain state.

I'd recommend, instead:
* jQuery Client should detect the name and version of Firefox Mobile properly.
* VisualEditor whitelists Firefox Mobile (from that version and up).
If I understand correctly:
* When users of Firefox Mobile use "Request desktop site", it uses a user agent header jQuery Client recognises as desktop Firefox. And VE supports that. And that browser supports VE. All is good.
* When users of Firefox Mobile use the default mode, it uses a user agent header jQuery Client doesn't yet recognise properly (version=mobile). VE doesn't whitelist that. But it seems otherwise that browser would support VE.

I'm not sure that working around the intentionally faked user-agent header will be feasible and would leave us with a to maintain scenario.

I'd recommend, instead:
* jQuery Client should detect the version of Firefox Mobile properly.
* VisualEditor whitelists Firefox Mobile (from that version and up).
If I understand correctly:
* When users of Firefox Mobile use "Request desktop site", it uses a user agent header jQuery Client recognises as desktop Firefox. And VE supports that. And that browser supports VE. All is good.
* When users of Firefox Mobile use the default mode, it uses a user agent header jQuery Client doesn't yet recognise properly (version=mobile). VE does not support that. But it seems otherwise that browser would support VE.

I'm not sure that working around the intentionally faked user-agent header will be feasible and would leave us with a to maintain scenario.

I'd recommend, instead:
* jQuery Client should detect the version of Firefox Mobile properly.
* VisualEditor whitelists Firefox Mobile (from that version and up).
If I understand correctly:
* When users of Firefox Mobile use "Request desktop site", it uses a user agent header jQuery Client recognises as desktop Firefox. And VE supports that. And that browser supports VE. All is good.
* When users of Firefox Mobile use the default mode, it uses a user agent header jQuery Client doesn't yet recognise properly (version=mobile). VE does not support that. But it seems otherwise that browser would support VE.

In that case, I'd recommend:
* jQuery Client should detect the version of Firefox Mobile properly.
* VisualEditor whitelists Firefox Mobile (from that version and up).

I'm not sure that working around the intentionally faked user-agent header will be feasible and would leave us with a to maintain scenario.
So it's a jquery.client issue: for Chrome and Firefox on Android, profile().name should always be "firefox" or "chrome" respectively, with .version set correctly, no matter how user configures the browser.

Currently in Chrome, profile().platform is "linux". Maybe we can use "android" there to signify the browser is running on Android.
It seems there're two places where UA matters, summarized below:

Browser | Option | profile().name | profile().version | Tab shown | Warning shown
---------------------------------------------------------------------------------
Firefox |   On   |    android     |      mobile       |    No     |      N/A
Firefox |  Off   |    firefox     |       29.0        |    Yes    |      No
Chrome  |   On   |    android     |       4.4.2       |    Yes    |      Yes
Chrome  |  Off   |    chrome      |   34.0.1847.114   |    Yes    |      No

Firefox with the option on is being detected as browser "android" version "mobile" is the most problematic thing here, because it completely disables VE.
By having Firefox hit my own webserver, I caught UA below. Not sure whether it can be different from the one returned by navigator.userAgent.

"Request desktop site" off:

Mozilla/5.0 (Android; Mobile; rv:29.0) Gecko/29.0 Firefox/29.0

JSON.stringify($.client.profile({userAgent:'Mozilla/5.0 (Android; Mobile; rv:29.0) Gecko/29.0 Firefox/29.0',platform:''}))
"{"name":"android","layout":"gecko","layoutVersion":29,"platform":"unknown","version":"mobile","versionBase":"0","versionNumber":0}"

"Request desktop site" on:

Mozilla/5.0 (X11; Linux x86_64; rv:29.0) Gecko/20100101 Firefox/29.0

JSON.stringify($.client.profile({userAgent:'Mozilla/5.0 (X11; Linux x86_64; rv:29.0) Gecko/20100101 Firefox/29.0',platform:''}))
"{"name":"firefox","layout":"gecko","layoutVersion":20100101,"platform":"unknown","version":"29.0","versionBase":"29","versionNumber":29}"
(In reply to Liangent from comment #2)
> (In reply to James Forrester from comment #1)
> > Do you mean "make jquery.client detect for Firefox mobile"? If so, that's a
> > very different bug to how you've written this one. :-)
> 
> Hmm? so it's already special cased in jquery.client for Chrome mobile, so
> there's no such issue in Chrome, without any change in VE side (I haven't
> really tested)?

I don't know. Your bug report seems to suggest that Firefox Mobile is getting detected as a failing browser, and telling Firefox Mobile to pretend to be Firefox makes it work fine. That's a sign that it's failing jquery.client's test cases.

Do you have an example UA string? https://developer.mozilla.org/en-US/docs/Gecko_user_agent_string_reference suggests that it should be putting out "Mozilla/5.0 (Android; Mobile; rv:13.0) Gecko/13.0 Firefox/13.0".
(In reply to James Forrester from comment #1)
> Do you mean "make jquery.client detect for Firefox mobile"? If so, that's a
> very different bug to how you've written this one. :-)

Hmm? so it's already special cased in jquery.client for Chrome mobile, so there's no such issue in Chrome, without any change in VE side (I haven't really tested)?
Do you mean "make jquery.client detect for Firefox mobile"? If so, that's a very different bug to how you've written this one. :-)
In the linked article, the content is not cleared after floats of the tables when using the template {{-}} which transcludes as:
<br style="clear:both;">

This is caused by the inline-block behavior of .ve-ce-mwTransclusionInlineNode

--------------------------
**Version**: unspecified
**Severity**: minor
**URL**: https://en.wikipedia.org/w/index.php?title=List_of_top_100_Major_League_Baseball_strikeout_pitchers&oldid=608135239
**See Also**:
https://bugzilla.wikimedia.org/show_bug.cgi?id=57372
Confirmed, now seems fixed (tested in Safari 8.0.4).
This problem seems fixed, as far as I can assess...
The "notices" thing (exclamation mark in a triangle) disappears from VE toolbar if you open a page for editing, close VE, then open it again (on the same page).

To reproduce:
1. Click "Edit" (or "Edit beta") on any page to open VisualEditor
2. Click "Cancel" to close it
3. Click "Edit" again

The toolbar will no longer have the "notices" item.

--------------------------
**Version**: unspecified
**Severity**: minor
Gerritadmin seems to be missing, I uploaded Gerrit change 133537
Aha, yes, when the only warning is the browser warning I also get this. However, if e.g. you try to edit the Main Page of enwiki you get the other two notices (protected page and edit notice) each time.

Renaming.
I tested on Opera Next 22 and Opera 12 with the same effect. Maybe this is related to the "You're using an unsupported browser" popup?
What browser does this occur in? Opera? It works fine for me in Chrome and Firefox…
In https://en.wikipedia.org/w/index.php?title=Female_promiscuity&oldid=607751101 references [74], [75] and [76] show up as 1, 2 and 3 in VE in the references box, with the rest of the reference numbers "pushed down", but with their original numbering in the main VE editing interface.

--------------------------
**Version**: unspecified
**Severity**: minor
They now show as references [73], [74] and [75] (off-by-one error?)
They now show as references [73], [74] and [75] (off-by-one error?0
See link provided above.

--------------------------
**Version**: unspecified
**Severity**: normal
**URL**: https://en.wikipedia.org/w/index.php?title=Anaconda,_Montana&diff=prev&oldid=608235426
apparently worksforme is the correct resolution for this situation
So is this unconfirmed then?
(In reply to Richard Morris from comment #1)
> Not quite sure it was a plugin, it could have been user error, cut and
> pasting the wrong thing. The user did correct them self in the next edit.

If they'd pasted the HTML raw it would have refused (<iframe>s etc. are blocked on paste); maybe they tried to paste it as a link target?
Yeah, it could be. James had confirmed my theory and that's why I filed it anyway. But I noticed the revert and was really glad about it. Success, right? :)
Not quite sure it was a plugin, it could have been user error, cut and pasting the wrong thing. The user did correct them self in the next edit.
This is important since the extracts are currently generated with the old API which doesn't guarantee valid xhtml5. That prevents third-party developers using less forgiving markup environments from fetching the extracts to build tools on top of them, e.g. https://github.com/waldyrious/primerpedia/issues/20

I'd work on this myself but I really don't have the background to understand the code in ApiQueryExtracts.php on my own (even after taking a look at VisualEditor's ApiVisualEditor.php to check an example implementation of a request to Parsoid, as suggested by Mark Traceur).

--------------------------
**Version**: unspecified
**Severity**: enhancement
Thanks for the feedback! We'll hopefully be prioritising this soon as part of the [[ https://www.mediawiki.org/wiki/Beta_Features/Hovercards | page previews/Hovercards ]] roll out... so watch this space!
I need to be able to get the formatted extracts either via the old api.php or the new REST service. If a new endpoint is created providing such extracts with well-formed HTML, yes, that would work for me.
TextExtracts could provide xml well formedness via php (we have a library in #MobileFrontend doing exactly that). Is there any other reason you specifically want this in REST?

I suspect we will end up creating a rest endpoint to solve the epic. I've included well formed HTML as a requirement. Does this feel less broad now?
>>! In T67169#3221431, @Jdlrobson wrote:
> I think this task is exactly the same as what we are talking about in T113094 and its subtasks ?

Yes, it looks like it, although the title/description of that issue is a little too broad for me to be comfortable calling this a dupe (particularly the line "we either need to write a bunch of tests and fix up TextExtracts **//or//** build a new Parsoid based api specifically for the purpose of Hovercards" -- this bug is specifically about the latter, due to the need for xml well-formedness).
Thanks for clarifying @waldyrious .
We are considering switching to HTML extracts for Page previews so watch this space.
I think this task is exactly the same as what we are talking about in T113094 and its subtasks ?
IIUC, that is not exactly what this request is about: [[ https://github.com/waldyrious/primerpedia/blob/gh-pages/primerpedia.js | currently I'm using ]] a request like https://en.wikipedia.org/w/api.php?action=query&prop=extracts&exintro&indexpageids=true&format=json&generator=random&grnnamespace=0&format=json, which returns a html-formatted extract. The problem is that the html is not guaranteed to be valid, hence it fails if embedded in a xhtml page (or any other context where well-formed xml is required).

The REST API, in contrast, only returns plaintext extracts at the moment. I could use them, but that's a workaround (avoiding rich formatting altogether) rather than a fix.

Is there any way to use the REST API to get an extract including the (rendered, not wikicode) basic formatting used in the actual article? For example bold, italics, and perhaps links as well.
IIUC, that is not exactly what this request is about: [[ https://github.com/waldyrious/primerpedia/blob/gh-pages/primerpedia.js | currently I'm using ]] a request like https://en.wikipedia.org/w/api.php?action=query&prop=extracts&exintro&indexpageids=true&format=json&generator=random&grnnamespace=0&format=json, which returns a html-formatted extract. The problem is that the html is not guaranteed to be valid, hence it fails if embedded in a xhtml page (or any other context where well-formed xml is required).

The REST API, in contrast, only returns plaintext extracts at the moment. I could use them, but that's a workaround (avoiding rich formatting altogether) rather than a fix.

Is there any way to use the REST API to get an extract that preserves the basic formatting (bold, italics, and perhaps links as well) used in the actual article?
IIUC, that is not exactly what this request is about: [[ https://github.com/waldyrious/primerpedia/blob/gh-pages/primerpedia.js | currently I'm using ]] a request like https://en.wikipedia.org/w/api.php?action=query&prop=extracts&exintro&indexpageids=true&format=json&generator=random&grnnamespace=0&format=json, which returns a html-formatted extract. The problem is that the html is not guaranteed to be valid, hence it fails if embedded in a xhtml page (or any other context where well-formed xml is required).

The REST API, in contrast, only returns plaintext extracts at the moment. I could use them, but that's a workaround (avoiding rich formatting altogether) rather than a fix.

Is there any way to use the REST API to get an html-formatted extract?
I believe this is resolved?
Is this what you were asking for: https://en.wikipedia.org/api/rest_v1/page/summary/Bavaria ?
Would this task be a good topic for the #wikidev17 ? If so, the deadline to submit new proposals is next Monday, October 31: https://www.mediawiki.org/wiki/Wikimedia_Developer_Summit/Call_for_participation
I have detached this proposal from {T101441} and #web-APIs-Hub because the latter has defined its scope within web APIs only (which happens to be the scope of the Google, Facebook, Twitter examples given above).

Being Wikimedia also the umbrella of hundreds of open source projects, we have a more complex picture. What should be the one and only home to find about all of them? In short, my opinion is to make http://mediawiki.org that home, linking wherever it is needed.
#Engineering-Community with the help of @spage are committing to this goal for the next quarter: {T101441}.

I think it is time to conciliate that goal with this task, and to find the best relationship with both that we can achieve by the end of September.
Change 197272 merged by BBlack:
dev.wm.org - Increase HSTS max-age to 1 year

[[https://gerrit.wikimedia.org/r/197272]]
Change 197272 had a related patch set uploaded (by Chmarkine):
dev.wm.org - Increase HSTS max-age to 1 year

[[https://gerrit.wikimedia.org/r/197272]]
Change 195338 merged by BBlack:
Enable HSTS on dev.wm.org max-age=7 days

[[https://gerrit.wikimedia.org/r/195338]]
Change 195338 had a related patch set uploaded (by Chmarkine):
Enable HSTS on dev.wm.org max-age=7 days

[[https://gerrit.wikimedia.org/r/195338]]
>>! In T67074#1013909, @Qgil wrote:
> We have decided to [[ https://phabricator.wikimedia.org/maniphest/query/zZr63xHvTU8d/#R | prioritize the creation of some actual content ]] under the existing API: namespace in mediawiki.org.

Yes, content, then a portal page on mw.org featuring that content based on [[ https://www.mediawiki.org/wiki/dev.wikimedia.org#Structure |  wireframe ideas ]]. Once it's at "better than draft" status, dev.wikimedia.org can have a redirect to this, and doc.wikimedia.org can link to it.
We have decided to [[ https://phabricator.wikimedia.org/maniphest/query/zZr63xHvTU8d/#R | prioritize the creation of some actual content ]] under the existing API: namespace in mediawiki.org.
needs Apache config, then obviously some files to upload..
Change 181398 merged by Dzahn:
add dev.wikimedia.org

[[https://gerrit.wikimedia.org/r/181398]]
Change 181398 had a related patch set uploaded (by Qgil):
add dev.wikimedia.org

[[https://gerrit.wikimedia.org/r/181398]]

#patch-for-review
https://gerrit.wikimedia.org/r/#/c/181398/
**sumanah** wrote:

Removing myself from cc on this as I prepare to leave Wikimedia Foundation.
Let's merge this discussion with the work done at https://www.mediawiki.org/wiki/dev.wikimedia.org. Sorry for the duplicity of spaces, which will go away when we merge Bugzilla with Phabricator.

We have settled on http://dev.wikimedia.org -- see 

Name for the 'developer hub'
http://fab.wmflabs.org/T488 

and 

URL of the Developer Hub
http://fab.wmflabs.org/T490

(In reply to Bawolff (Brian Wolff) from comment #6)
> Why not just have dev.wikimedia.org redirect to a page on mediawiki.org.
> That way people can update it as appropriate easily.

Yes, this is the current plan that you can help fine tuning:

Technology selection for the Developer Hub
http://fab.wmflabs.org/T491

How to redirect from dev.wikimedia.org
http://fab.wmflabs.org/T558
(In reply to Krinkle from comment #0)
> 
> developer.wikimedia.org
> 
> The initial portal wouldn't be unlike some of these:
> * https://developers.google.com/
> * https://developers.facebook.com/
> * https://dev.twitter.com/

* https://developer.github.com/
* https://developer.yahoo.com/
* http://dev.windows.com/
* http://www.bing.com/dev


https://developers.google.com/
https://developers.google.com/maps/documentation/javascript/tutorial
https://developers.google.com/maps/documentation/javascript/examples/map-simple
Why not just have dev.wikimedia.org redirect to a page on mediawiki.org. That way people can update it as appropriate easily.


>- Where do I find out about the existence of:
[..]
>  * graphite.wikimedia.org

Not much point telling people about the existence of a service they are not allowed access to.
(In reply to Krinkle from comment #0)
> * Data and APIs
> 
>   Such as:
> 
>   * page view counts
>   * xml dumps
>   * OAuth?

Discovered today that there is such a thing as https://frdata.wikimedia.org
 as well. To be documented at  https://wikitech.wikimedia.org/wiki/frdata.wikimedia.org.
Topic related with a session scheduled for tomorrow at 10:30 in the Wikimedia Hackathon:

How does the data and developer hub fit into the current documentation
https://www.mediawiki.org/wiki/Z%C3%BCrich_Hackathon_2014/Schedule#Saturday_May_10
Initial implementation proposal:

 - static html wrapped in a lightweight php router for header/footer and nice url handling (e.g. no need to repeat too much for each subdirectory, it can be handled automatically using data and available directories (js,php,api,demo) and versions (master,REL1_23,etc.)), using twitter bootstrap (like doc.wikimedia.org)
 - all in git (wikimedia/dev-docroot.git?)
 - deployed via git-deploy

The server for it only needs to be behind misc-lb-eqiad and be a git-deploy target. The main changes would come in from people via gerrit/git and deployed periodically.

Changes to the auto-generated docs would be build by gallium, and somehow pushed to the web server (they wouldn't be in dev-docroot.git).
I'm in full support of this. 

As someone working on this https://www.mediawiki.org/wiki/API_Documentation_&_Developer_Hub, I would like this very much.
I think all of doc.wikimedia.org can migrate to appropriate paths on this domain.

Like:
- dev.wikimedia.org/mediawiki/doc/js
- dev.wikimedia.org/mediawiki/doc/php
- dev.wikimedia.org/mediawiki/doc/api
- dev.wikimedia.org/visualeditor/doc
- dev.wikimedia.org/visualeditor/demo
- dev.wikimedia.org/oojs-ui/doc
- dev.wikimedia.org/oojs-ui/demo
- dev.wikimedia.org/oojs/doc
Intention:
Add an image gallery at the top of a section.

Steps to Reproduce:
1. Open a page that has a list at the top of the section.  

2. Place your cursor at the top of the list, and Insert > Gallery.


Actual Results:  
The bullet remains visible.  The text of the list item is on the next line, but indented.

However, when you save, the list formatting (the asterisk at the start of the line) has been removed.

Expected Results:  
The gallery would be inserted before the list.  That is,

* List item

would turn into 
```
<gallery>File:Example.jpg
File:Example2.jpg</gallery>

* List item
```
instead of into

```
 <gallery>File:Example.jpg
File:Example2.jpg</gallery>List item
```
(Notice the stray space at the start of the line.)

Reproducible: Always

--------------------------
**Version**: unspecified
**Severity**: normal
**URL**: http://en.wikipedia.beta.wmflabs.org/w/index.php?diff=92775&oldid=92716
This sort of happens if you insert a references list, which gives you this:

* 
<references />List item


but not for images, math, templates, etc.
From MediaWiki.org:

> I would like to have an omnibar in VE. This is a single text field where
> a user can search for things they want to do, instead of clicking a
> button you can invoke omnibar with a keyboard shortcut and then search
> for the task you want to do. This would be helpful to easier access those
> buttons which don't have shortcuts now. Like managing category, inserting
> reference, changing to source editor etc.

Seems like it could be a lot of work to implement – for example, internationalisation of such controls might be hard – but it might be particularly useful for power users (or for controls that don't have a keyboard shortcut, as the proposer notes).

--------------------------
**Version**: unspecified
**Severity**: enhancement
I want to use the HTML code <mark> in the newsletter and still be able to edit the draft page in VisualEditor.  Right now, adding <mark> produces nowiki tags, and opening a page with <mark> already on it prevents editing the marked text (alienated content).

--------------------------
**Version**: unspecified
**Severity**: enhancement
I had seen that, but given that it didn't mention the word "text" and that elsewhere you were so strongly against the idea, I had to assume it was actually about the page color.
The ability to set a text background in whatever color we want (#FC0FC0, in my case) will IMHO make using <mark> unnecessary.
(In reply to Elitre from comment #7)
> No! Google Docs allows highlighting text in the color I want. Please make
> that happen somehow?

That's not highlighting with <mark>, that's setting text background colour which is bug 73041.
No! Google Docs allows highlighting text in the color I want. Please make that happen somehow?
(In reply to Elitre from comment #5)
> I'm unhappy. I demand the ability to pick my favorite color when
> highlighting.

Talk to W3C. ;-)
I'm unhappy. I demand the ability to pick my favorite color when highlighting.
(In reply to Elitre from comment #3)
> Will this only allow marking the text in yellow?

It will mark the text with <mark>. It's up to users' browsers to decide how to show it as marked, but yes, all major browsers ape the neon-lemon-yellow highlighter colour to show this currently.
Will this only allow marking the text in yellow?
Change 141605 merged by jenkins-bot:
Split out ve.{dm,ce}.TextStyleAnnotation into parts, add other annotations

https://gerrit.wikimedia.org/r/141605
Change 141605 had a related patch set uploaded by Jforrester:
Split out ve.{dm,ce}.TextStyleAnnotation into parts, add other annotations

https://gerrit.wikimedia.org/r/141605
Right now it's a horrible mess. :-(

--------------------------
**Version**: unspecified
**Severity**: enhancement
Said feature was killed off.
We should merge them together where appropriate.

--------------------------
**Version**: unspecified
**Severity**: enhancement
Read mode

Steps to reproduce:


1.Open a page with VE
2.Add a bullet list
3.Add an image as a bullet point 
4.Save the page
5.Reopen the page 


Observed Result:
The bullet point appears on the read mode but not inside VE, but when you type something in that position the bullet point appears again.

See the screenshot attached

Page:
http://en.wikipedia.beta.wmflabs.org/wiki/After_switch

--------------------------
**Version**: unspecified
**Severity**: minor

**Attached**: {F13837}
Verified the fix in production.
Verified the fix on test2
Change 127387 merged by jenkins-bot:
Remove unnecessary overflow:hidden from block slug style

https://gerrit.wikimedia.org/r/127387
Change 127387 had a related patch set uploaded by Esanders:
Remove unnecessary overflow:hidden from block slug style

https://gerrit.wikimedia.org/r/127387
Caused by a bug in Chrome, reported upstream: https://code.google.com/p/chromium/issues/detail?id=365024
Created attachment 15139
Inside VE

**Attached**: {F13838}
just ugh

See attached screenshot.  Green Highlight is the cursor bar -- showing the cursor and the top of the page is somehow ending up under the heading instead of just below it.  Red hightlight is the outline of the (not showing) warning about using an unsupported browser.

--------------------------
**Version**: unspecified
**Severity**: normal

**Attached**: {F13658}
This doesn't happen for me in IE10. The cursor does go under the toolbar, but that is a general issue (there's a lot of scrolling weirdness in IE still). I can't reproduce the invisible notice.
Fixed in IE11, at least.
This page should be using the html5 element <kbd> to represent the keyboard keys.

--------------------------
**Version**: unspecified
**Severity**: trivial
Change 125212 merged by jenkins-bot:
Put CommandHelpDialog keyboard shortcuts in kbd not div elements

https://gerrit.wikimedia.org/r/125212
Change 125212 had a related patch set uploaded by Jforrester:
Put CommandHelpDialog keyboard shortcuts in kbd not div elements

https://gerrit.wikimedia.org/r/125212
I've recently been working on an extension, and it would be nice for it to show a PostEdit success box when it successfully completes an operation. However, doing this at the moment would mean loading a Javascript file, the PHP setting a JS config var for whether to display the PostEdit box or not, JS checking this variable, JS getting a message for the text to display, etc.

What would really be useful would be a way, just in PHP, for extensions to specify that a PostEdit box should be shown, with the text to display. The code would then ensure that JS to show the box is loaded on the page (which would possibly also save resources over the above method).

I am not entirely sure how this would be best implemented, but possibly something like wfShowPostEdit( $text ), that could be easily called in an extension's code. Something like this would make it many more times easier for extensions to show PostEdit boxes.

--------------------------
**Version**: unspecified
**Severity**: enhancement
I think what you're looking for is `mw.notify()`.

See also <https://doc.wikimedia.org/mediawiki-core/master/js/#!/api/mw.plugin.notify>. Be sure to load the `mediawiki.notify` module (or add it as dependency to your script).

There are various examples in MediaWiki core that use this. Including the ajax modules for patrol and watch actions. E.g. click the watch star on a page when logged-in.
Yeah, it would be nice extensions to be able to show their own messages, depending on their function.

(Sorry about the categorisation stuff, still pretty unexperienced here :) )
MediaWiki 1.21 provides a wgPostEdit variable (bug 43270) depending on mediawiki.action.view.postEdit. 
Per bug 48276, the VisualEditor extension depends on it, but looks like you'd like to define your own strings to display here?
On every page there is an icon of a pencil.

It is linked to #editor/0.

I.e. there is no way to edit any other section than section 0.

Maybe it was assumed that /0 meant the whole page.

Anyway one must manually change the url to /1, /2 etc.
This is being handled as part of the Fixed Header / Winter Beta feature https://www.mediawiki.org/wiki/Winter
In the case of VE this does mean edit the entire page.
On tablets/desktops we may make this mean the entire page.

cc'ing Jared in case he can comment on the long term strategy.
This is currently by design to make editing easier on a mobile screen by optimising for section editing.

We are currently exploring full page edits in our work on VisualEditor. This may or may not get addressed as part of that.
Maybe if there is nowhere else to put it, have that row be:
Pencil (edit whole article), upload, watch, Pencil+0 (edit section 0)
The star watchlist icon applies to the entire article, so one assumes the same with the edit icon appearing in the same row. I didn't test the upload icon.
Ah... I get it!
To edit section | use pencil at
0 | top left
1 | side right
2 | side right
3 | side right
4 | side right

Who would have ever guessed!

One assumes instead:

To edit section | use pencil at
entire article | top left
0 | side right
1 | side right
2 | side right
3 | side right
4 | side right
**jgonera** wrote:

Are there no pencil icons in sections when you unfold them? If no, can you provide a URL?
**bingle-admin** wrote:

Prioritization and scheduling of this bug is tracked on Mingle card https://wikimedia.mingle.thoughtworks.com/projects/mobile/cards/1909
Gerrit af6d9ab introduced list=prefixsearch which can be used as a generator, which action=opensearch can't be. This would allows us to avoid taking the output of opensearch and turning around to make follow-up API requests for e.g. pageprops to see if they are redirects or whatever.

We shouldn't do this switch until MW1.23 is released, at least, however.

--------------------------
**Version**: unspecified
**Severity**: enhancement
Change 134632 merged by jenkins-bot:
Switch action=opensearch call to list=prefixsearch where appropriate

https://gerrit.wikimedia.org/r/134632
Change 134632 had a related patch set uploaded by Alex Monk:
Switch action=opensearch calls to list=prefixsearch where appropriate

https://gerrit.wikimedia.org/r/134632
(In reply to Minh Nguyễn from bug 5309 comment #45)
> many Vietnamese Wikipedia users rely on an IME script embedded via
> a gadget, but gadgets are disabled at [[Special:UserLogin/signup]]. We’d
> need to port the (rather complex) IME to ULS to keep the signup form
> accessible.

We definitely should! It shouldn't be hard, jquery.ime only needs a comma separated list of input keys -> result character pairs.
https://github.com/wikimedia/jquery.ime/wiki/Technical-Specification#input-method-definition
If you can't prepare such a table, can you ask other vietnamese users?

--------------------------
**Version**: master
**Severity**: enhancement
**See Also**:
https://github.com/wikimedia/jquery.ime/issues/342
(In reply to Nemo from comment #3)
> (In reply to Minh Nguyễn from comment #2)
> > I'd be happy to try and port AVIM to jquery.ime, but it may take awhile.
> 
> That would be wonderful! Please assign this bug to yourself when you start
> working on it.

Indeed, this would be wonderful. I'll gladly help with that. It shouldn't be very hard. jqeury.ime had pretty good docs for developers. Please contact me if you need any assistance.
(In reply to Minh Nguyễn from comment #2)
> I'd be happy to try and port AVIM to jquery.ime, but it may take awhile.

That would be wonderful! Please assign this bug to yourself when you start working on it.

> Fortunately, most of the complexity relates to text selection handling,
> which should be handled by jquery.ime already.

Nice. If other features are missing and block the port, please file them as soon as possible at https://github.com/wikimedia/jquery.ime/issues .
Forgot to link [[vi:MediaWiki:Gadget-AVIM.js]] and [[vi:MediaWiki:Gadget-AVIM portlet.js]].

I'd be happy to try and port AVIM to jquery.ime, but it may take awhile. Fortunately, most of the complexity relates to text selection handling, which should be handled by jquery.ime already.
Unfortunately, it isn't quite that simple. Vietnamese users expect IME-like functionality, not just a keyboard layout. For instance, with the [[Telex (IME)]] input method, "Vietje" should become "Việt", "truongwf" should become "trường", and if you're indecisive enough, "masfsfsfsfrxj" should become "mạ". "Wasshington" should become "Washington" rather than "Wáington" or "Wahíngton".

Much of this can be accomplished with regular expressions, but it might be easier to shoehorn an existing Vietnamese IME into jquery.ime. AVIM.js is very reliable and is available under an MIT license, but no one really understands the core code. bogo.js [1] is much cleaner but much more limited and only available under the MPL. Mudim [2] is a bit cleaner and is GPL2-licensed but has its own limitations, like an input buffer (not ideal for Vietnamese) and poor support for VIQR.

We'll definitely need support for a few input method-specific preferences, particularly tone mark placement (xóa vs. xoá) and spelling rule enforcement (Wahíngton vs. Washington).

AVIM works pretty well with VisualEditor and other features, so at the Wikimedia wikis, the only real benefit to ULS integration would be getting an IME on Special: pages. (The current workaround is to install a system IME or browser extension, or to use a bookmarklet.) I wouldn't recommend adopting a simplistic keyboard layout even as a stopgap measure, because then it'd be forced upon the Vietnamese wikis and literally no one would want to use it.

Full disclosure: I maintain a Firefox extension based on AVIM.js [3], but these comments are more from the perspective of a Vietnamese Wikipedian.

[1] https://github.com/lewtds/bogo.js
[2] https://code.google.com/p/mudim/
[3] http://avim.1ec5.org/en/
targetFn.super = originFn;

triggers a JS error in IE 8, and presumably in older versions of IE as well.

--------------------------
**Version**: unspecified
**Severity**: normal
Change 124360 merged by jenkins-bot:
core: Use bracket notation for 'super' for ES3 compatibility

https://gerrit.wikimedia.org/r/124360
(In reply to Tisza Gergő from comment #12)
> (In reply to Krinkle from comment #10)
> > I know for a fact that "throws" is perfectly safe (for I did extensive
> > research to verify it's safety going back to IE6 before adopting it un
> > QUnit).
> 

We don't use throws outside unit tests (it's a method name for QUnit) and as said,
it's perfectly safe back to IE6.
(In reply to Krinkle from comment #10)
> I know for a fact that "throws" is perfectly safe (for I did extensive
> research to verify it's safety going back to IE6 before adopting it un
> QUnit).

It would be easy to fix, though: it is only used by sinon.js which supplies aliases for all ES3-incompatible function names. For throws() it is throwsException(), I think.
(In reply to Gilles Dubuc from comment #9)
> That plan looks good to me. Since this bug is still marked as low priority,
> I imagine that you guys won't get around to it for at least a few months.
> 
> Since we're starting to work on UploadWizard and using OOJS for it will
> probably be on our todo list, would you be comfortable letting us implement
> ES3 support for OOJS the way you've just described? With you guys providing
> active review on it, so that we're not blocked waiting for too long?
> 
> That's assuming that we'll decide to keep UploadWizard ES3-compatible, but I
> want to see what our options will be.

Sorry for not seeing this comment earlier; this looks to now essentially be done. We'll need to merge the ES3-parsability (gerrit 124360), release a new version of OOjs, and pull it into MediaWiki, with the new ES5 shim (gerrit 139308).


(In reply to Krinkle from comment #10)
> Enabling 'es3: true' in jshintrc shows that we're supposed to avoid "throws"
> (qunit), "super" (oojs) and "static" (oojs).
> 
> I know for a fact that "throws" is perfectly safe (for I did extensive
> research to verify it's safety going back to IE6 before adopting it un
> QUnit).
> 
> Running a test shows that "static" is safe as well. It's only "super".

Is there a way we can get jshint to add an "es3-actual" flag so we can ensure that ES5-syntax-isms don't accidentally creep back into the codebase automatically?
Enabling 'es3: true' in jshintrc shows that we're supposed to avoid "throws" (qunit), "super" (oojs) and "static" (oojs).

I know for a fact that "throws" is perfectly safe (for I did extensive research to verify it's safety going back to IE6 before adopting it un QUnit).

Running a test shows that "static" is safe as well. It's only "super".

Test suite:  http://fiddle.jshell.net/bsz74/show/light/

(source: http://jsfiddle.net/bsz74/)

Test results via browserstack.com:
* Windows 7 / IE 9: all pass
* Windows 7 / IE 8: 1 failure (super)
* Windows XP / IE 8: 1 failure (super)
* Windows XP / IE 7: 1 failure (super)
* Windows XP / IE 6: 1 failure (super)
* Windows XP / Opera 12.10: all pass
* Windows XP / Firefox 3: all pass
* Windows XP / Safari 4: 1 failure (super)
* Windows XP / Safari 5.0: 1 failure (super)
* Windows XP / Safari 5.1: all pass
* OSX 10.6 Snow Leopard / Safari 4: 1 failure (super)
* OSX 10.6 Snow Leopard / Safari 5.0: 1 failure (super)
* OSX 10.6 Snow Leopard / Safari 5.1: all pass
* OSX 10.6 Snow Leopard / Firefox 4: all pass
* iPhone 3GS / iOS 3: 1 failure (super)
* iPhone 4 / iOS 4.0: 1 failure (super)
* iPhone 4S / iOS 5.0: all pass
That plan looks good to me. Since this bug is still marked as low priority, I imagine that you guys won't get around to it for at least a few months.

Since we're starting to work on UploadWizard and using OOJS for it will probably be on our todo list, would you be comfortable letting us implement ES3 support for OOJS the way you've just described? With you guys providing active review on it, so that we're not blocked waiting for too long?

That's assuming that we'll decide to keep UploadWizard ES3-compatible, but I want to see what our options will be.
Change 124360 had a related patch set uploaded by Jforrester:
core: Avoid an IE8 bug causing a fatal error when loaded on that platform

https://gerrit.wikimedia.org/r/124360
In case super still needs to be read/written for backwards compatibility, the syntax obj['super'] might work. Described here:
http://tiffanybbrown.com/2013/09/10/expected-identifier-bug-in-internet-explorer-8/
but a cursory search of the ES3 spec also suggests that this is valid.

(I note that UploadWizard is apparently being converted to OOjs UI. Doing this while declaring IE 6-8 is not supported seems like a pretty horrible idea to me.)
That fact could be made clearer in OOjs's README.md or a similar prominent place. I'm not sure that Mark knew this caveat at the time he embarked our project on the OOjs train. I think it would be very easy for another project to miss that fact as well. Resources.php is a really odd place if it's the sole warning.

Full support aside, the fix to this bug is simply renaming "super". Seems like a quick win for potentially making Media Viewer available to more than 1 in 20 visitors who currently can't use it. I would have submitted a patch, but since this is the name of an important feature in your framework, I'd rather let you pick the new name.

I understand that advanced WYSIWIG VE stuff is hard to do in ES3 and older, so ruling those browsers out for VE makes sense considering the effort/reward ratio. But what OOjs provides doesn't seem to me like it justifies ignoring 5%+ of our visitors, particularly if you're pushing for foundation-wide use of that framework (seems to be the reason why we ended up using it, anyway), since most features developed by the foundation don't do things as advanced as VE where older browsers are hard to support.

I'm pretty sure that this bug right here is the only thing preventing OOjs ES3 support, at least for the subset of OOjs features that Media Viewer is using. I recall using Media Viewer fine in IE 6, 7 and 8 in January/February, which seems consistent with the timeline, considering that the code triggering the bug seems to have been introduced in March.

If you fix this, you'll be getting continuous free help from us as a consumer of these frameworks when it comes to older IE support, because we'll be keeping an eye on it and submitting bug reports and patches when issues arise.
ES3 compatibility isn't yet supported for OOjs, as stated in Resources.php.
http://jsfiddle.net/PKdPz/1/embedded/result/

browserstack/IE9: Pass
browserstack/IE8: Fail
     > Expected identifier

Error details:
 User Agent: Mozilla/4.0 (compatible; MSIE 8.0; Windows NT 6.0; Trident/4.0; SLCC1; .NET CLR 2.0.50727; .NET CLR 3.5.30729; .NET CLR 3.0.30729)
Timestamp: Wed, 2 Apr 2014 01:04:33 UTC

 Message: Expected identifier
 URI: http://fiddle.jshell.net/PKdPz/1/show/light/
 Line: 33
 Char: 7
 Code: 0
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Reserved_Words
I think it could be as simple as renaming "super" to something else. It's most likely erroring because it's considered a reserved name.
The needcheck tag on it.wp recently detected half a dozen dirty diffs like this one: https://it.wikipedia.org/w/index.php?title=Respirazione_olotropica&curid=856162&diff=65014587&oldid=64980151 .

This seems to be due to a broken browser plugin, NortonInternetSecurityBF .

--------------------------
**Version**: unspecified
**Severity**: minor
We believe that this is now worked around.
https://no.wikipedia.org/w/index.php?title=Bruker:Bredekg%C3%A5rd&diff=13459686&oldid=13459676
Change 163961 merged by jenkins-bot:
Remove certain blacklisted elements when getting HTML from document

https://gerrit.wikimedia.org/r/163961
Change 163961 had a related patch set uploaded by Alex Monk:
Remove certain blacklisted elements when getting HTML from document

https://gerrit.wikimedia.org/r/163961
*** Bug 70537 has been marked as a duplicate of this bug. ***
Show the VisualEditor appendix conditionally for GettingStarted tours.  This is the same as {T63321}, but for GettingStarted tours.

--------------------------
**Version**: master
**Severity**: normal
On stack overflow there is a nice feature that guess edit summary for user based on what they changed. So that when you edit something edit summary isn't empty, but contains things like:

Replace "foo" with "bar"

OR

Inserted 20 words, removed 2 lines in paragraph "blah"

OR

Punctuation fixes

User is still able to modify it afterwards but this already save so much time. It would be nice if Visual Editor would do the same, so that users who do minor edits wouldn't need to bother with writing the summary.

--------------------------
**Version**: unspecified
**Severity**: enhancement
**See Also**:
https://bugzilla.wikimedia.org/show_bug.cgi?id=52859
*** Bug 70285 has been marked as a duplicate of this bug. ***
See https://en.wikipedia.org/w/index.php?title=User:MGMT90018_Turnover/sandbox&curid=42095125&diff=599418792&oldid=599219453
The "Web Thunder" plugin script from xunlei.com leaves the following litter at the top and bottom of pages:

<embed id="xunlei_com_thunder_helper_plugin_d462f475-c18e-46be-bd10-327458d045bd" type="application/thunder_download_plugin" height="0" width="0" />

<embed id="xunlei_com_thunder_helper_plugin_d462f475-c18e-46be-bd10-327458d045bd" type="application/thunder_download_plugin" height="0" width="0" />

--------------------------
**Version**: unspecified
**Severity**: minor
Change 163961 merged by jenkins-bot:
Remove certain blacklisted elements when getting HTML from document

https://gerrit.wikimedia.org/r/163961
Change 163961 had a related patch set uploaded by Alex Monk:
Remove certain blacklisted elements when getting HTML from document

https://gerrit.wikimedia.org/r/163961
Screenshot

Steps to reproduce:


1.Open a page with VE
2.Add a text then a Cite>Website/Book/Newspaper/Journal just after that 
3.Now select both the text and the cite
4.Apply link on it

Observed Result:
The link also gets applied on the Cite

See the screenshot attached


Test Environment: http://en.wikipedia.beta.wmflabs.org/
Browser: Chrome Version 26.0.1410.65 & FF 25
OS: MAC OS X 10. 8. 5 
Page:http://en.wikipedia.beta.wmflabs.org/wiki/Reference_numbering?veaction=edit

--------------------------
**Version**: unspecified
**Severity**: minor

**Attached**: {F13245}
For templates we may need to have some kind of function that dynamically determines whether the template is linkable :(
This is hard to fix. Blacklisted annotation types are done on a per-node-type basis. Normal references are of type 'mwReference', but citations are of type 'mwTransclusionInline', and I don't think it's a good idea to make all templates unlinkable.
To reproduce:

1. Load a page in IE in the visual editor.
2. Load the same page in another browser, make a change, and save it.
3. Load the page view in IE, confirm you can see the edit.
4. Click "Edit" to enable the visual editor.  Old content appears in the editor.
5. Quit IE and restart.  Load page to edit in VE.  See new content in the editor.

Initially I thought this was simply a server configuration issue (and maybe it still is), but I tested the same thing in FF and got the new page.

--------------------------
**Version**: unspecified
**Severity**: normal
Sounds like it may have been resolved in another task, so resolving invalid. Please reopen if this is still an issue
Krenair writes:

> Is this still a problem? Sounds like IE is caching wrongly?

I doubt this is a problem now since {{T74480}} is resolved.
Is this still a problem? Sounds like IE is caching wrongly?
With the following wikitext:

  __NOTOC__ 

  This is a test

  {|
  |-
  | valign="top" | 
  == Header  ==
  * point one
  * point two
  ...

VE starts up with the cursor on "This".  Pressing down once in FF ends up with the cursor on the "Header" line.  In IE, it ends up on the "point one" line.  Pressing up once in IE then puts the cursor on the "Header" line.

--------------------------
**Version**: unspecified
**Severity**: normal
IE9 support has been dropped: T162277
Cursoring into a table cell in IE9 now takes you inside the cell and lets you edit it. This is still wrong: it should create a table selection highlighting the first cell.
(In reply to Roan Kattouw from comment #1)
> This is working as expected now. Pressing down once puts the cursor at the
> beginning of "Header" on my Windows 7 machine in IE10.

...but of course this bug was filed against IE9. I'm blind.
This is working as expected now. Pressing down once puts the cursor at the beginning of "Header" on my Windows 7 machine in IE10.
From the console:

 SCRIPT70: Permission denied 
 Main_Page, line 1 character 1

Filing to track this.

--------------------------
**Version**: unspecified
**Severity**: major
Change 283427 merged by jenkins-bot:
Fix access of iframe-created document in IE9

[[https://gerrit.wikimedia.org/r/283427]]
Change 283427 had a related patch set uploaded (by Esanders):
Fix access of iframe-created document in IE9

[[https://gerrit.wikimedia.org/r/283427]]
The iframe which is used to create the document is discarded and IE9 garbage collects it and wipes the document, even though we keep a pointer to the document.
For the record, I haven't experienced this problem in weeks of messing around with VE in IE in either IE10 or IE11.
Updated to latest VE (which shares MW's JQuery?) and saw the problem again.  Clicked IE's "Start debugging" in IE9 and wasn't able to reproduce it.

Returned to page, clicked IE's "Stop debugging" and then clicked VE's "Edit".  Spinner went into infinite loop.

Now, what are the dev tools setting up to cause this behavior?
Created attachment 14910
diff of changes to update jquery

**Attached**: {F13122}
Got past part of the permission problem without messing with the registry (yay!) by looking at newer jQuery code and seeing how it avoided use of iframe.  It is now stopping in setUpSurface.
*** Bug 63043 has been marked as a duplicate of this bug. ***
So after poking around for a bit I was able to get past this error with the following registry key set to "1":

  HKEY_LOCAL_MACHINE\SOFTWARE\Wow6432Node\Microsoft\Internet Explorer\MAIN
  \FeatureControl\FEATURE_PROTOCOL_LOCKDOWN\iexplore.exe

Isn't IE support fun?

Now the save button (bug #63043) changes color but clicking it results in "SCRIPT70: Permission denied" that IE's debugger says comes from the following line in jquery.js:

    proxy=function(){
        return fn.apply(context,args.concat(core_slice.call(arguments)));
    };

Hints on registry keys from http://stackoverflow.com/questions/5352057/script70-permission-denied-ie9

Looks like there may be some help in the newer versions of jquery: http://bugs.jquery.com/ticket/13936
Typing return to generate a new paragraph in FF works.  Filing this to ask for a pointer to figure out how I might track it down and fix it.

--------------------------
**Version**: unspecified
**Severity**: major
WFM in 9. 8 is not supported.
I was testing against IE8 or 9.  I've since upgraded that machine to 11, so it isn't available now.
Works in IE10 too. Which version of IE did you observe this in?
Fixed in IE11, at least.
still needs some tracking down for a reproducible case.
Right now, Users can add image inside reference dialog box, similarly they should be able to add gallery inside it.

--------------------------
**Version**: unspecified
**Severity**: enhancement
I'm not sure that's something we want to encourage?
--------------------------
**Version**: unspecified
**Severity**: enhancement
Removal of this function is punted to bug 72156.
Change 167055 merged by jenkins-bot:
Replace calls to ve.bind( fn, ... ) with fn.bind( ... )

https://gerrit.wikimedia.org/r/167055
Change 167055 had a related patch set uploaded by Alex Monk:
Replace calls to ve.bind( fn, ... ) with fn.bind( ... )

https://gerrit.wikimedia.org/r/167055
Change 166155 merged by jenkins-bot:
Replace calls to OO.ui.bind( fn, ... ) with fn.bind( ... )

https://gerrit.wikimedia.org/r/166155
Change 166155 had a related patch set uploaded by Alex Monk:
Replace calls to OO.ui.bind( fn, ... ) with fn.bind( ... )

https://gerrit.wikimedia.org/r/166155
(In reply to Alex Monk from comment #15)
> (In reply to Krinkle from comment #14)
> > VisualEditor core, and OOjs UI.
> 
> Me and Krinkle spoke about this and think it would be a better idea to defer
> this for now. PhantomJS is not implementing Function#bind (like we would
> expect) and that's necessary for the tests to succeed. In other repos we get
> around this by loading es5-shim but in these ones we should be able to rely
> on ES5 properly.

With I64a0bd96b in VE-core and If2da01a25 in OOUI this is no longer a blocker.
(In reply to Krinkle from comment #14)
> VisualEditor core, and OOjs UI.

Me and Krinkle spoke about this and think it would be a better idea to defer this for now. PhantomJS is not implementing Function#bind (like we would expect) and that's necessary for the tests to succeed. In other repos we get around this by loading es5-shim but in these ones we should be able to rely on ES5 properly.
(In reply to Alex Monk from comment #13)
> (In reply to Krinkle from comment #7)
> > We now have the polyfill for Function.prototype.bind provided by MediaWiki
> > so this should be easier to do now.
> 
> Heh.
> 
> Anyway, is there anything else to do here?

VisualEditor core, and OOjs UI.
(In reply to Krinkle from comment #7)
> We now have the polyfill for Function.prototype.bind provided by MediaWiki
> so this should be easier to do now.

Heh.

Anyway, is there anything else to do here?
Change 144840 merged by jenkins-bot:
Replace ve.bind( fn, ... ) calls with fn.bind( ... )

https://gerrit.wikimedia.org/r/144840
(In reply to Krinkle from comment #10)
> Why? How is this different from the other ES5 methods we've been using
> already? VisualEditor nor OOjs UI support ES3 engines afaik.
> 
> MediaWiki itself does, and OOjs core does (for other consumers of OOjs). But
> we don't (we user .super which breaks IE's ES3 parser, Array.isArray,
> Object.keys etc.)
> 
> mw-ve, ve-core, oojs-ui, and oojs all share a requirement for ES5
> environments beyond just the polyfillable methods.

oojs-core supports ES3 engines but requires an ES5 shim. The same would apply to OOjs UI and/or VisualEditor core if and when we decide to support older browsers.
Why? How is this different from the other ES5 methods we've been using already? VisualEditor nor OOjs UI support ES3 engines afaik.

MediaWiki itself does, and OOjs core does (for other consumers of OOjs). But we don't (we user .super which breaks IE's ES3 parser, Array.isArray, Object.keys etc.)

mw-ve, ve-core, oojs-ui, and oojs all share a requirement for ES5 environments beyond just the polyfillable methods.
If we're going to replace ve.bind it should be done in ve core first so we'll need a polyfill there. In ve-mw we can omit that polyfill as mw loads it's own.
Change 144840 had a related patch set uploaded by Alex Monk:
Replace ve.bind( fn, ... ) calls with fn.bind( ... )

https://gerrit.wikimedia.org/r/144840
We now have the polyfill for Function.prototype.bind provided by MediaWiki so this should be easier to do now. Simply replace all uses of $.proxy(fn..) and ve.bind(fn) in the modules/ directory with calls to fn.bind(..).
Sorry, I got bit busy with my other project.
Ping on this bug again – do you need any support/advice/help?
> (In reply to James Forrester from comment #1)
> > Tony, are you planning to take on this bug?
> 
> I plan to. But is there anything like bind() is only present in modern
> browsers ?

Indeed, Function.prototype.bind is new in ECMAScript 5, which VisualEditor requires. Or rather, VE requires ECMAScript 3 syntax engine and an environment that somehow provides certain ES5 features, which can potentially be polyfilled. We don't yet (and that is by design), adopt any ES5 syntax or ES5 features that can't be polyfilled.

This is already guarded against using the feature test in our mw integration init[1], so you can rely on this without having to worry about old browsers.

(In reply to Roan Kattouw from comment #3)

I'd recommend #2 for consistency (we do the same with other ES5 features we've adopted) and minor performance micro optimisation (extra global and property, extra callstack because it has to be a proxy calling bind, unlike Array.isArray is can't be assigned to ve.bind by reference because bind needs to be bound itself) and because we're already using '.bind' in a few places.

But keeping ve.bind with a small wrapper to bind using bind seems fine for backwards compatibility with ve plugins in the wild. But I'd recommend we don't use this in core.

[1] https://github.com/wikimedia/mediawiki-extensions-VisualEditor/blob/7e52a1ab2ab514/modules/ve-mw/init/targets/ve.init.mw.ViewPageTarget.init.js#L74-L93
We don't use $.proxy() directly in the VE code base, instead we set ve.bind = $.proxy; and use ve.bind().

Yes, this.keyup.bind() exists in modern browsers. It doesn't exist in older browsers, but we don't really care because VE doesn't support browsers that old for lots of other reasons anyway.

There are two ways we could approach this. I'll ask Krinkle which one he thinks is best before we proceed.

#1 is to migrate uses of ve.bind( this.foo, this ); to this.foo.bind( this ); across the code base, then deprecate and later remove ve.bind(). This would be pretty laborious.

#2 is to change ve.bind() to a wrapper that uses native .bind(). This will change every single function binding in the entire codebase to use native bind instantaneously.

My guess it's probably best to do #2 first, then #1 later, but I'd like Krinkle to weigh in on this.
(In reply to James Forrester from comment #1)
> Tony, are you planning to take on this bug?

I plan to. But is there anything like bind() is only present in modern browsers ? 
will replacing, say 
this.$element.on( 'keypress', $.proxy( this.keyup, this ) )
with 
this.$element.on( 'keypress', this.keyup.bind(this)) will do the trick ?
Tony, are you planning to take on this bug?
ve.ce.Surface contains a bunch of calls to stopTimerLoop() and startTimerLoop() that are unnecessary and seem to have been added based on the false assumption that JavaScript can be multithreaded.

There are also duplicate calls to pollOnce that seem unneeded, or only exist to update state post-modification. We should audit these.

--------------------------
**Version**: unspecified
**Severity**: enhancement
Setting decimal value

Steps to reproduce:

1.Open a page with VE
2.Insert a new image
3.Set the image size to a long value which becomes a number with scientific notation 
4.Now start deleting the value from right to left
5.Once you have deleted the scientific notation (e) and the number becomes a value with decimal point , click on "Apply Changes"

Observed Issue 1: it accepts that decimal value

6.Click on Save Page and go to "Review your Changes"

Observed Issue 2: The size value showing in the review changes section are completely different that what was set in step 5

See the screenshots attached

Test Environment: http://en.wikipedia.beta.wmflabs.org/
Browser: Chrome Version 26.0.1410.65 
OS: MAC OS X 10. 8. 5 
Page:http://en.wikipedia.beta.wmflabs.org/w/index.php?title=17marchff&veaction=edit

--------------------------
**Version**: unspecified
**Severity**: minor

**Attached**: {F13038}
Verified the fix in production
This doesn't happen anymore with the new MediaSizeWidget and the DimensionsWidget; they don't allow for decimal values at all.
Created attachment 14843
The discrepancy in review changes section

**Attached**: {F13040}
Intention:
Edit a Babel box that I'd just created.

Steps to Reproduce:
1. Create a Babel box using the workaround described in bug 62740 {T64740}.

2. Apply changes.

3. Select the transclusion and click the puzzle icon to edit it again.

4. It looks confusingly different.


Expected Results:  
If it can't add the function, then how is it able to edit it?  And if it can edit it, then why can't it add it normally?

Reproducible: Always

--------------------------
**Version**: unspecified
**Severity**: trivial
Created attachment 14840
Screenshot showing editing of Babel box

**Attached**: {F13026}
Created attachment 14839
Screenshot showing creation of Babel box

**Attached**: {F13025}
Intention:
Add a Babel box

Steps to Reproduce:
1. Go to Insert > Template

2. Type in #babel:en

3. Click "Add template".

4. Nothing happens.


Expected Results:  
Either it ought to Just Work™, or it ought to produce an error message about VisualEditor not supporting parser functions yet (see bug 50855).

Reproducible: Always

Workaround:  Go to complex transclusion mode; add "Content"; paste in wikitext source code for the parser function.

--------------------------
**Version**: unspecified
**Severity**: enhancement
**See Also**:
https://bugzilla.wikimedia.org/show_bug.cgi?id=49996
Created attachment 14836
Screenshot showing exactly what was in the template name field when it didn't work

**Attached**: {F13013}
Moved out of T40129's wishlist into its own bug.
I'm not sure I agree with doing this, since media and galleries have such different functionalities. E.g. a media item is only chosen once, whereas galleries can be extended, pruned, rearranged, etc. The media display options are quite different from the gallery display options too, and a media item might not even be an image. I think a single dialog that incorporated all of this would lead to a confusing user experience, with too many alternative workflows and options being disabled according to whether whether media or gallery behaviour was required.

I suspect the real problem is that the media dialog is more mature, so a better solution in my opinion would be to work on improving the gallery dialog.
Moved out of bug 38129's wishlist into its own bug.

--------------------------
**Version**: unspecified
**Severity**: enhancement
screenshot attached

Steps to reproduce:

1.Open a page with VE
2.Insert an image 
3.Insert another image just after it which is smaller than the previous one
4.Now align the first one to the left
5.Now align the second one to Centre 

Observed Result:

The smaller image overlaps with the previous bigger one in VE.If you save it and reopen the editor, you wont be able to see the image to select it.


Test Environment: http://en.wikipedia.beta.wmflabs.org/
Browser: Chrome Version 26.0.1410.65 
OS: MAC OS X 10. 8. 5
Page:http://en.wikipedia.beta.wmflabs.org/w/index.php?title=Widthnullagainalways

--------------------------
**Version**: unspecified
**Severity**: normal
**See Also**:
https://bugzilla.wikimedia.org/show_bug.cgi?id=62850

**Attached**: {F13301}
See also {T104540}.
Steps to reproduce:

1.Open a page in VE
2.Edit the page
3.Switch to Edit Source mode

Observed Result:
In the console : an error is appearing :"Uncaught TypeError:Cannot read property cleardiff of null".
However, it does not hamper the functionality of switching/saving the page

Test Environment: http://en.wikipedia.beta.wmflabs.org/
Browser: Chrome Version 26.0.1410.65 
OS: MAC OS X 10. 8. 5

--------------------------
**Version**: unspecified
**Severity**: normal
Verified the fix in production:https://en.wikipedia.org/wiki/User:RYasmeen_%28WMF%29/sandbox?veaction=edit
Verified the fix in test2:https://test2.wikipedia.org/w/index.php?title=User:RYasmeen_(WMF)/sandbox&veaction=edit
Change 118331 merged by jenkins-bot:
Fix JS error trying to access this.saveDialog from switch to source mode code path

https://gerrit.wikimedia.org/r/118331
Change 118331 had a related patch set uploaded by Catrope:
Fix JS error trying to access this.saveDialog from switch to source mode code path

https://gerrit.wikimedia.org/r/118331
Isn't VisualEditor supposed to be able to edit only the content of the table cells but not change the table structure? If so, I believe this should not happen:
https://pt.wikipedia.org/w/index.php?diff=38365876&uselang=en

--------------------------
**Version**: unspecified
**Severity**: normal
Table editing has changed dramatically since this bug was filed (for example, the visual editor //can// now change the table structure), so I'm closing. Reopen if you can still reproduce.
I'm setting this task's status to stalled as long as clear steps to reproduce are not known (plus this issue is now a year old).
I'm not sure how the anonymous user managed to do that.

Since the edit was marked with "Tag: VisualEditor", I assume the user didn't change to the wikitext editor after he started his changes (in that case it would be marked as "VisualEditor: Switched", I think).
Any specific steps that resulted in a broken table? And the table was edited **only** in VE?
It seems to be possible to get the Parsoid HTML/RDF output through the standard Mediawiki API, but I can't figure out how.

For example, this fails:
https://en.wikipedia.org/w/api.php?action=visualeditor&paction=parse&page=Main_Page&oldid=598252063

An example would be really helpful.

--------------------------
**Version**: unspecified
**Severity**: enhancement
**See Also**:
https://bugzilla.wikimedia.org/show_bug.cgi?id=61017
Change 166519 merged by jenkins-bot:
Mark action=visualeditor as an internal API

https://gerrit.wikimedia.org/r/166519
Change 166519 had a related patch set uploaded by Jforrester:
Mark action=visualeditor as an internal API

https://gerrit.wikimedia.org/r/166519
I took the upstream bug in MW core, might as well take this as well.
Have filed bug 62905 in MW's API to make this possible.
I see some kind of contradiction in proposing an API on one side  action=visualeditor @https://en.wikipedia.org/w/api.php and on the other side telling "this is a private API".

I fully understand that this is a work in progress, and thank you very much for you explanation Gabriel. But, IMO the current VE related API status is really puzzling for someone which is not embeded in the Parsoid/VE project.

Why not simply remove this documentation (action=visualeditor) as long as this is not really working for everybody?

NB: Regarding the Parsoid/API integration work itself, I think there is an other bug open somewhere about that.
(In reply to James Forrester from comment #2)
> Should this be the Parsoid bug for that, then?

My understanding is that this bug is about the VE API. http://parsoid-lb.eqiad.wikimedia.org/ links to the documentation at https://www.mediawiki.org/wiki/Parsoid#The_Parsoid_web_API, which has at least one example. This bug can probably be closed, but good to wait for Emmanuel's input.
(In reply to Gabriel Wicke from comment #1)
> The VE interface is private and not intended as a public / stable Parsoid
> API. It just proxies to http://parsoid-lb.eqiad.wikimedia.org/ and adds some
> more VE-specific information that is not needed if all you are interested in
> is the content. As it spins up an extra PHP worker it is also slower than
> accessing the Parsoid API directly.
> 
> The Parsoid API will be integrated in a new REST content API in the longer
> term. The URL will change at some point later this year, but the principle
> will remain the same.

Should this be the Parsoid bug for that, then?
The VE interface is private and not intended as a public / stable Parsoid API. It just proxies to http://parsoid-lb.eqiad.wikimedia.org/ and adds some more VE-specific information that is not needed if all you are interested in is the content. As it spins up an extra PHP worker it is also slower than accessing the Parsoid API directly.

The Parsoid API will be integrated in a new REST content API in the longer term. The URL will change at some point later this year, but the principle will remain the same.
If you have a complex transclusion (e.g., a succession box), and you try to rearrange the order of the items, and if one or more of those items is a template that contains a parameter, then some or all of the parameter-containing templates will silently disappear.

See https://en.wikipedia.org/wiki/Wikipedia:VisualEditor/Feedback/Archive_2014_1#Add_content_and_other_transclusion_mysteries for complaints.


Diffs of resulting problems:

https://en.wikipedia.org/w/index.php?title=User%3AFram%2Fsandbox&diff=596891776&oldid=596891699

https://en.wikipedia.org/w/index.php?title=User%3AFram%2Fsandbox&diff=597044161&oldid=596891923

--------------------------
**Version**: unspecified
**Severity**: normal
Tested it in test2. 

- By rearranging templates via moving them in Transclusion box, I was not able to separate template parameters - e.g. to make {{s-bef|before = [[Leonardo Domenici]]}}  --> {{s-bef|before = }}.
 - Also tried the exact steps on https://en.wikipedia.org/wiki/Wikipedia:VisualEditor/Feedback/Archive_2014_1#Add_content_and_other_transclusion_mysteries:
"Example: here all I did was use the "up" button four times: "up" the lowest "content", "up" the lowest s-aft, "up" the lowest "content" again, try to "up" the lowest s-aft again. Result when you want to save it: the s-aft has simply vanished :-)"

It was non-reproducible  - either the issue is resolved or I am not inventive enough :(  I'd like someone else to take a look at the issue - hence I've assigned some priority to it.
Screenshot

Steps to reproduce:

1.Open a page with wikitext editor
2.Insert an empty reference for example: empty reference<ref />
3.Save the page
4.Now open the page with VE

Observed Result:
It does not let you edit the empty reference you just added and shows an error "This reference is defined in a template or other generated block and for now can only be edited in source mode"

See the screenshot attached

Test Environment: http://en.wikipedia.beta.wmflabs.org/
Browser: Chrome Version 26.0.1410.65 & FF 25
OS: MAC OS X 10. 8. 5 
Page:http://en.wikipedia.beta.wmflabs.org/wiki/Newpagereference?veaction=edit

--------------------------
**Version**: unspecified
**Severity**: normal

**Attached**: {F12863}
I just tried at http://en.wikipedia.beta.wmflabs.org/wiki/0.24595949980612886 and the reference can be edited now, but shows the "disallowed" cursor on hover.
Screenshot of bug.

Encountered in IE9 using BrowserStack "Windows 7/IE9" using latest MediaWiki and VisualEditor master via a tunnel. Could either be a browser bug we have to work around, or something on our end applicable to other browsers as well.

* Edit a simple document.
* Add two characters at the start.
* "Save page" enables itself.
* Click it.

Uncaught exception:

> “Unable to get value of property ‘getModel’: object is null or undefined”.

--------------------------
**Version**: unspecified
**Severity**: normal

**Attached**: {F13345}
Works now.
> I get bug 63039 first:
Which is T65039 and has a patch for review.
I'm unable to reproduce this bug because before it even gets anywhere, I get bug 63039 first:

> "SCRIPT70: Permission denied", /Main_Page, line 1 character 1
Screenshot of bug.

Encountered in IE9 using BrowserStack "Windows 7/IE9" using latest MediaWiki and VisualEditor master via a tunnel. Could either be a browser bug we have to work around, or something on our end applicable to other browsers as well.


* Load up the "Worksheet" page.
* Trying to put the cursor in the first paragraph and add text.

It repeats the first sentence many times and causes various weird scroll/focus events to occur all over the document.

--------------------------
**Version**: unspecified
**Severity**: normal

**Attached**: {F13343}
IE9 support has been dropped: T162277
Haven't yet narrowed down, vague subject for now.
Open VisualEditor.  Click 'Insert'.  First item in the main Insert menu:  Reference.  

Open (or insert) and image.  Under the Caption, click 'Insert'.  First item:  Language.

Reference is still the most important item, and should be listed first.  (Should "image" even be listed at all?  It works, if you only go one deep, but...)

--------------------------
**Version**: unspecified
**Severity**: trivial
Change 117101 merged by jenkins-bot:
Make the order of insert tools consistent in dialogs

https://gerrit.wikimedia.org/r/117101
Change 117101 had a related patch set uploaded by Catrope:
Make the order of insert tools consistent in dialogs

https://gerrit.wikimedia.org/r/117101
So in general, the menus are supposed to be different for exactly the reason you hinted at: there are things you can't do in an image caption or in a reference. That said, the order should probably be consistent. This is likely to just be an oversight (the lists are maintained completely separately, which is kind of horrible) rather than anything intentional, but I'll double-check with James to make sure.
Right now there is no way to express Ctrl+? in the trigger system. Attempting to type that on my keyboard registers as Ctrl+Shift+/ , but that's only because my keyboard layout is such that ? is above /. There should be a way to express Ctrl+? independent of the keyboard layout.

This may not be easy to do because Trevor tells me that charCode is less reliable than keyCode, so we may not be able to detect this correctly.

--------------------------
**Version**: unspecified
**Severity**: enhancement
Pages like:
* documentation - [[Template:Terminal/doc]]
* Wikipedia namespace = [[Wikipedia:Manual of Style]]

Note that on many wikis there are custom subpages (like /doc) or namespaces which visual editing should be configurable.
I suggest MediaWiki interface - [[MediaWiki:Visualeditor-editable-pages]].

--------------------------
**Version**: unspecified
**Severity**: enhancement
Screenshot

Steps to reproduce:

1.Open a page with VE
2.Open a reference dialog or Media Settings for an image
3.Insert two images inside that dialog.
4.Now drag one of them

Observed Result:

Observe that, the shadow of the image appears from the corner of CE instead of the dialog.Also an error appears after dragging the image shadow over itself:
TypeError: $domNode.closest(...).data(...) is undefined

See the screenshot attached

Test Environment: http://en.wikipedia.beta.wmflabs.org/
Browser:  FF 25
OS: MAC OS X 10. 8. 5 
Page:http://en.wikipedia.beta.wmflabs.org/w/index.php?title=New_pageon%24&gettingStartedReturn=true&veaction=edit

--------------------------
**Version**: unspecified
**Severity**: normal

**Attached**: {F13253}
**Author:** `vigna`

**Description:**
Some Wikipedia pages contain slashes in their title, e.g., "/b/" or "/dev/null". Such slashes should be escaped to %2F when they are not meant to separate paths components, as per RFC 1738/3986. Instead, for instance,

http://en.wikipedia.org/w/index.php?title=B/&redirect=no

contains an A element

<a href="/wiki//b/" title="/b/">/b/</a>

that should written

<a href="/wiki/%2Fb%2F" title="/b/">/b/</a>


This causes 2 problems:

1) The URL above does not conform to the RFCs. This is a minor issue but it might rise other problems in the future.

2) If the slash is initial, the URI is not normalized as per RFC. E.g., in Java

bsh % print(URI.create("wiki//b/").normalize());
wiki/b/

This might be a problem with crawlers, which usually normalize URLs to reduce the number of duplicates.



Note that %2F-escaped slashes work perfectly, and 

http://en.wikipedia.org/wiki/%2Fb%2F

brings you exactly to /b/'s page. Bug 8254 seems to say the opposite, but it's a few years old.

--------------------------
**Version**: 1.23.0
**Severity**: normal
**vigna** wrote:

What I mean is that the Wikipedia text contains links like [[/b/]]. That is, the user will input the title of a page. But then some code will turn this title into a link: it shouldn't be http://en.wikipedia.org/wiki//b/, but rather http://en.wikipedia.org/wiki/%2Fb%2F . 

Maybe the page above wasn't a good example. Consider

http://en.wikipedia.org/wiki/Cory_Doctorow

The reference entry for /usr/bin/god in the "Other" section is

* ''[[/usr/bin/god]]'' (novel; Tor Books)

The link generated by the Wikimedia software (or whoever is in charge :) is

<a href="/wiki//usr/bin/god" title="/usr/bin/god">/usr/bin/god</a>

This should be

<a href="/wiki/%2Fusr%2Fbin%2Fgod" title="/usr/bin/god">/usr/bin/god</a>
Thanks for taking the time to report this!

It's not entirely clear to me what "should be escaped when generating links" mean. The user (when using classic text wikipage editing) or VisualEditor (when using VE for wikipage editing) cannot knowwhich kind of slash is meant.

Or did you mean "when generating wiki page titles" instead?
The button for the "More settings" menu has no tooltip.  Should it?

--------------------------
**Version**: unspecified
**Severity**: enhancement
Verified the fix in production:https://en.wikipedia.org/w/index.php?title=User:RYasmeen_%28WMF%29/sandbox&veaction=edit
Verified the fix in production:https://en.wikipedia.org/w/index.php?title=User:RYasmeen_%28WMF%29/sandbox&veaction=edit
Verified the fix in test2
Verified the fix in betalabs
Change 116145 merged by jenkins-bot:
Add tooltip to page options menu widget in the toolbar

https://gerrit.wikimedia.org/r/116145
Change 116145 had a related patch set uploaded by Jforrester:
Add tooltip to page options menu widget in the toolbar

https://gerrit.wikimedia.org/r/116145
Yes:  the three-bars icon, which is currently called "More settings" at mw:Help:VisualEditor/User_guide.
Do you mean the page menu (Options, Page settings, Advanced settings, …)?
Intention:
Blank a page (prior to setting a redirect).

Steps to Reproduce:
1. Select all (Command-a).
2. Press the delete key.
3. Save > Review changes.

Actual Results:  
Categories, defaultsort keys, and page protection templates are not removed.


Reproducible: Always

--------------------------
**Version**: unspecified
**Severity**: normal
**URL**: https://www.mediawiki.org/w/index.php?title=User:Whatamidoing_(WMF)&diff=914307&oldid=904077
https://en.wikipedia.org/w/index.php?action=edit&oldid=665564885 is the most interesting version of this that I've seen for a while.  It kept parts of a subst'd template.
(In reply to James Forrester from comment #3)
> On this one I'm minded to WONTFIX, but I could be argued around. What are
> the reasons for letting people remove content they can't see with select-all?

As WhatamIdoing says, redirecting, for example for merging. This may be achieved using some special scenario. (And hey, blanking must point at something special in any case.)

Copying here the description from bug 67200 which was closed as dupe:

Deleting the text from the article and converting it to a redirect page still leaves all the categories in it, as well as Other Stuff such as magic words and invisible templates.

This is a regression in comparison to the source editor, where the editor could just delete everything and be sure that categories, magic words, invisible templates and everything else is gone.

Just redirecting an article shouldn't necessarily remove everything, because it's actually possible that the editor wants to leave the article in a category. Some projects, including enwiki, have categories, templates etc. in redirect pages. But probably some kind of a warning should be shown.
*** Bug 67200 has been marked as a duplicate of this bug. ***
I'm not sure that select-all is the right way to remove them, but there should be some way to remove them, and a way to find out that they are present.
(In reply to Bartosz Dziewoński from comment #1)
> All kinds of other things too, see also bug 52036 and bug 60830. I think we
> need a tracking bug for this or a large WONTFIX.

I've merged bug 52036 and bug 60830 into their respective causes (both of those are things we will fix with those corrections), and narrowed this to just be about meta-data – things that don't display because they never create any content.

On this one I'm minded to WONTFIX, but I could be argued around. What are the reasons for letting people remove content they can't see with select-all?
Perhaps we should have a special process for redirects that handles 100% blanking, or at least inquires or warns about it.  (You might want cats for redirects, but probably not a default sort key).
All kinds of other things too, see also bug 52036 and bug 60830. I think we need a tracking bug for this or a large WONTFIX.
Screenshot

Steps to reproduce:

1.Open a page with VE
2.Add a heading
3.Select the text of the heading and insert a gallery
4.The gallery gets added as part of the heading
5.Save the page and observe the page content in the readmode

Observed Result:

In readmode , the heading text and caption of the gallery gets repeated immediately following the heading section.Also gallery is not showing up as part of the heading where as in wikitext editor it is inside ==heading== and also in VE

See the screenshot attached

Test Environment: https://test2.wikipedia.org/
Browser:  FF 25
OS: MAC OS X 10. 8. 5 
https://test2.wikipedia.org/w/index.php?title=Totalnewheading

--------------------------
**Version**: unspecified
**Severity**: normal

**Attached**: {F13262}
Instapaper is "a simple tool for saving web pages to read later on your iPhone, iPad, Android, computer, or Kindle."  It adds div tags to the top and bottom of pages edited in VisualEditor.  

See https://en.wikipedia.org/w/index.php?title=Major_Arcana_%28album%29&diff=589184449&oldid=589116581 for an example.  It added this to the top and the bottom:

<div id="sendToInstapaperResults"></div>

--------------------------
**Version**: unspecified
**Severity**: minor
**URL**: https://en.wikipedia.org/w/index.php?title=Major_Arcana_%28album%29&diff=589184449&oldid=589116581
Change 163961 merged by jenkins-bot:
Remove certain blacklisted elements when getting HTML from document

https://gerrit.wikimedia.org/r/163961
Change 163961 had a related patch set uploaded by Alex Monk:
Remove certain blacklisted elements when getting HTML from document

https://gerrit.wikimedia.org/r/163961
Pages in View mode contain a convenient link to the related "Data item" (in the sidebar, under Tools). However, in the classic edit mode such links disappears. It is a convenient link for editors, and there is no reason why it should disappear.

PS: the link is kept in VisualEditor since the "page" actually doesn't change.

--------------------------
**Version**: master
**Severity**: normal
**See Also**:
https://bugzilla.wikimedia.org/show_bug.cgi?id=45687
Big Thank You!
Change 167233 merged by jenkins-bot:
Always show link to wikibase item in toolbox

https://gerrit.wikimedia.org/r/167233
Change 167233 had a related patch set uploaded by Hoo man:
Always show link to wikibase item in toolbox

https://gerrit.wikimedia.org/r/167233
(In reply to Lydia Pintscher from comment #1)
> Hoo: Should this get the easy keyword?

Don't think so... doesn't seem like the hook we currently use for this supports this :/
Hoo: Should this get the easy keyword?
http://korma.wmflabs.org/browser/bugzilla_response_time.html should answer these questions:

How long does it take to give a first response to reporters of Low-Immediate / trivial-blocker bugs? How long until acknowledged bugs are resolved? Are we using the importance parameters consistently? Are we improving?

* Average time for an accepted bug report between bug creation date and PATCH_TO_REVIEW status being set
* Average time for an accepted bug report between PATCH_TO_REVIEW status being set and RESOLVED FIXED status being set.
* Average time for an accepted bug report between bug creation date and first comment by not the reporter her/himself.

https://www.mediawiki.org/wiki/Community_metrics#Bugzilla_response_time

--------------------------
**Version**: unspecified
**Severity**: normal
I'm marking this task as Resolved because @acs and @sduenas worked hard on it, and the only piece left was better descriptions. Now there is no point in working on them...

People interested in Maniphest metrics can watch and contribute to {T1003}. It's a modest start.
>>! In T63561#807103, @Nemo_bis wrote:
>>>! In T63561#802548, @Jdforrester-WMF wrote:
>> Should this be changed into a Phabricator-focussed metric?
> 
> Yes, but AFAIK pretty much everything is impossible for korma given phabricator has no APIs, see T28. Perhaps mark all issue tracker-related tasks in this component as stalled?

Can you not use https://phabricator.wikimedia.org/conduit/ for API access, or am I missing something?
>>! In T63561#802548, @Jdforrester-WMF wrote:
> Should this be changed into a Phabricator-focussed metric?

Yes, but AFAIK pretty much everything is impossible for korma given phabricator has no APIs, see T28. Perhaps mark all issue tracker-related tasks in this component as stalled?
Should this be changed into a Phabricator-focussed metric?
(In reply to Quim Gil from comment #29)
> What if you try without me explaining you how, so we test how usable is this?

I like!

My first guess: Click on a canvas and use Ctrl key && mouse scroll wheel. But the standard zoom behavior of browser takes over. That idea probably came from using PDF viewers too much.

Second guess: I mark a timeframe by clicking the left mouse button, dragging it horizontally while keeping it clicked, like in an audio editor.

Bingo.

I also highly appreciate that the y axis zoom is adjusted automatically!
And clicking for a bit longer on the canvas seems to reset the zoom.

Big kudos!
(In reply to Andre Klapper from comment #9)
> Is there a way to zoom the x and/or y axis (also see bug 61810)?

Now you can zoom. What is you try without me explaining you how, so we test how usable is this?  :)
The graphs are now considered ready:

http://korma.wmflabs.org/browser/bugzilla_response_time.html

We are still missing better strings, but this is a task for me. I'm taking the bug. Help / patches welcome.

https://www.mediawiki.org/wiki/Community_metrics#Global_Pending_List still mentions "Zoom feature for graphs" a a nice-to-have improvement. If this item is still open when we close this bug, we will open a new bug report for it.
This is our first approach to the zoom feature. There are some bugs to fix, though. 

http://korma.wmflabs.org/browser/zoom_test.html
Santi, only fyi: on the topic of removing tracking bugs, there is bug 2007, where all of them are identified.
Santi, thank you! The "Total" line is already useful now. I hope the fact of scanning only key Wikimedia projects will reduce the very high peaks, making the rest more readable.

One option to make the Total line more visible could also be to make it thicker than the rest (just in case this is easier than changing the color).

Andre, we agreed to Bitergia that they would focus on the graphs and we will focus on the content. Most of it can be "edited" indirectly via pull requests at https://github.com/Bitergia/mediawiki-dashboard/blob/master/browser/bugzilla_response_time.html
Looks good to me; thanks!

(In reply to Santiago Dueñas from comment #21)
> I've also include some help messages to clarify what the charts mean. Please
> have a look to the message and let me know whether you understand them or
> not, or if you want to change some terms, for instance, tickets to
> bugs/reports, etc.

* Typo: "Unnatended Tickets"
* Typo: "had no actions by ohters than the reporter."
* Clicking on the explanation button (qm_15.png icon; "?" in a square) in the
  four last of the six graphs scrolls up to the top of the page in FF27.
* Unattended vs uncommented: I'd still love to see an explanation of the
  difference to make sure that everybody understands, maybe in the header in 
  brackets, like "Unattended tickets (no activity by anybody else than 
  reporter)" and "Uncommented tickets" (no comments by anybody else than
  reporter)" or so?

> I still have to add the number of bugs in the info boxes and filter those 
> components that are not key projects.

I think I'll reevaluate after we have this functionality in place (plus zooming, maybe).
(In reply to Quim Gil from comment #22)
> Remaining tasks:
> 
> (In reply to Quim Gil from comment #19)
> > * the number of bugs will be also displayed in the dialog with data.
> > 
> > Then the canonical list of products / reports that Andre just posted must be
> > implemented.
> 
> We also agreed to add a black line t each graph showing the absolute median,
> regardless of severity/priority, excluding "Lowest" as the graphs do now.

Added but I still have to check how to change the colors of the charts.

> 
> We left this for later:
> 
> > Also, Andre was asking about the possibility to zoom graphs to visualize
> > only a certain period. I *believe* I have seen this functionality in
> > VizGrimoire but I'm not sure. In any case, it is something that we would
> > consider only when we have the points above solve, if we still need it.
Remaining tasks:

(In reply to Quim Gil from comment #19)
> * the number of bugs will be also displayed in the dialog with data.
> 
> Then the canonical list of products / reports that Andre just posted must be
> implemented.

We also agreed to add a black line t each graph showing the absolute median, regardless of severity/priority, excluding "Lowest" as the graphs do now.

We left this for later:

> Also, Andre was asking about the possibility to zoom graphs to visualize
> only a certain period. I *believe* I have seen this functionality in
> VizGrimoire but I'm not sure. In any case, it is something that we would
> consider only when we have the points above solve, if we still need it.
(In reply to Quim Gil from comment #20)
> Santi, yesterday Andre and me agreed that the information provided by the
> "Time to close" graphs isn't very useful to us. Not only the very high peaks
> make the rest impossible to analyze. The main problem is that those reports
> don't tell us much about the trends, what should we do better, what is the
> call to action.
> 

The other day Jesus and I were discussing about it and we find that these charts are not useful if we do not include bugs that are still opened, unattended or uncommented. Tomorrow we can talk about it during the confcall.

> The graphs about the age of reports open without action do show trends and
> where should we improve. In fact Andre is missing already the ones based on
> priority. 
> 
> For all these reasons we propose to have these graphs, in this order:
> 
> Age of reports without any action by priority & severity
> 
> Age of reports without any comment by priority & severity
> 
> Age of reports unresolved by priority & severity
> 
> 

Added.

I've also include some help messages to clarify what the charts mean. Please have a look to the message and let me know whether you understand them or not, or if you want to change some terms, for instance, tickets to bugs/reports, etc.

I still have to add the number of bugs in the info boxes and filter those components that are not key projects.

> If you still think it makes sense to have graphs of the age of
> closed/actioned/commented reports let's discuss, but after we leave this KPI
> ready for this iteration. It's already March and there is still a lot to do.
> Thank you!

Ok!

BTW, sorry with the delay with this. To get the "age" data from actions and comments was tricker than I thought.
Santi, yesterday Andre and me agreed that the information provided by the "Time to close" graphs isn't very useful to us. Not only the very high peaks make the rest impossible to analyze. The main problem is that those reports don't tell us much about the trends, what should we do better, what is the call to action.

The graphs about the age of reports open without action do show trends and where should we improve. In fact Andre is missing already the ones based on priority. 

For all these reasons we propose to have these graphs, in this order:

Age of reports without any action by priority & severity

Age of reports without any comment by priority & severity

Age of reports unresolved by priority & severity


If you still think it makes sense to have graphs of the age of closed/actioned/commented reports let's discuss, but after we leave this KPI ready for this iteration. It's already March and there is still a lot to do. Thank you!
After a conversation with Santi, we agreed on these changes:

* focus on severity, removing all the graphs about priority and keeping the page sane; the former is more objective and stable, the latter is more subjective and changeable

* Santi will try to draw the graphs calculating the severity of the reports at a given time; it seems to be easy but we'll see

* the "median age of open reports" graphs will go at the beginning: reports without any action, reports without any comment, reports unresolved

* the "media age of reports acted upon" will follow with a clear explanation: median age of reports when they get a first action, when they get a first comment, when they get a resolution

* the number of bugs will be also displayed in the dialog with data.

Then the canonical list of products / reports that Andre just posted must be implemented.

Then we will see whether we still get those high peaks converting the rest in planes or not.

Also, Andre was asking about the possibility to zoom graphs to visualize only a certain period. I *believe* I have seen this functionality in VizGrimoire but I'm not sure. In any case, it is something that we would consider only when we have the points above solve, if we still need it.
(In reply to Santiago Dueñas from comment #14)
> > > Should I make [[wikitech:Key_Wikimedia_software_projects]] a table and add
> > > the corresponding Bugzilla product/component in the second column? 
> 
> A table sounds good. They're easy to parse and edit. But if I can suggest
> something, I prefer to have product/component in separated columns

Done: https://wikitech.wikimedia.org/w/index.php?title=Key_Wikimedia_software_projects&diff=101721&oldid=90993

I hope I'll remember to update when I change Bugzilla's taxonomy. :)

(And as a side-effect of (re-)investigating Bugzilla taxomony of Fundraising I found & filed bug 62002.)
(In reply to Santiago Dueñas from comment #16)
> I've added some new charts that try to show this.

Thanks! They feel more helpful than the "Time to close by..." charts.

> These charts have some problems:
> 
> - A peak that goes down doesn't implies you are closing the oldest bugs. It
> can means that there are more bugs that were open recently, decreasing the
> median. You can see this behaviour in Feb 2011. The median of Unprioritized
> bugs is 530 days because there's only one bug that were opened 530 days ago.
> The next month, the median goes down to 282 days because another bug was
> opened in Mar 2011 and at the end of that month none of them were closed.

Probably overhead and not a good idea, but could the overlay also display on how many items the calculated value is based on?

> - Take into account that we are using the current priority of a bug. I think
> that for these kind of charts, it makes more sense to take the priority of
> the bug at that time, but it raises another problem: changes in lines might
> be produced by changes in the priority. If you change the priority of a bug,
> the old priority line will decrease while the new one will increase.

Yeah, that's what I meant in comment 10 - but let's revisit the "when to query the priority/severity value of a report" aspect later.
(In reply to Andre Klapper from comment #13)
> (In reply to Andre Klapper from comment #11)
> > Should I make [[wikitech:Key_Wikimedia_software_projects]] a table and add
> > the corresponding Bugzilla product/component in the second column? 
> > Or what's the prefered format to parse it in a machine-readable way? :-/
> 
> Santi: Could you answer this please?

A table sounds good. They're easy to parse and edit. But if I can suggest something, I prefer to have product/component in separated columns, in order to pass them as parameters to our tool.
(In reply to Andre Klapper from comment #11)
> Should I make [[wikitech:Key_Wikimedia_software_projects]] a table and add
> the corresponding Bugzilla product/component in the second column? 
> Or what's the prefered format to parse it in a machine-readable way? :-/

Santi: Could you answer this please?
(In reply to Quim Gil from comment #8)
> > Last list I made was bug 54469 comment 6.
> 
> Interesting, but... you could have updated
> [[wikitech:Key_Wikimedia_software_projects]] instead, which is the canonical
> place to track changes to the key Wikimedia projects.

Uhm. I cannot remember exactly, but I guess I was worried about the format I should use but did not ask explicitly. :(
Should I make [[wikitech:Key_Wikimedia_software_projects]] a table and add the corresponding Bugzilla product/component in the second column? 
Or what's the prefered format to parse it in a machine-readable way? :-/
For my better understanding (and maybe others who might have the same problem):
"Time to first action by Priority" - How is an "action" defined? Is "Time to first comment" a subset, or disjunct? Would changing the status from REOPENED to NEW count as an action already?

Smaller issue in all graphs but only on this page:  After "Feb 2013", the month name header in the overlay popup becomes "undefined" (instead of "Mar 2013" etc).

> The main problem here is with those big peaks in median charts. The 
> useful data is lost at the bottom of the chart and you can only see
> flat lines. We have to think about how to manage these cases.

Does the rendering allow a cut-off parameter, e.g. "only render lowest 40% of y axis"? Could images have double the height? Is there a way to zoom the x and/or y axis (also see bug 61810)?
Not convinced by these ideas, but still some thoughts.
(In reply to Andre Klapper from comment #2)
> (In reply to Quim Gil from comment #1)
> > * We need to scan only the Bugzilla products and components corresponding to
> > https://wikitech.wikimedia.org/wiki/Key_Wikimedia_software_projects . Andre,
> > did you have a list somewhere mapping these?
> 
> Last list I made was bug 54469 comment 6.

Interesting, but... you could have updated [[wikitech:Key_Wikimedia_software_projects]] instead, which is the canonical place to track changes to the key Wikimedia projects.

Maybe we can simplify things a bit? (but still document them in the wiki page)

Entire products:

Analytics
Commons App
Cortado (???)
Datasets
MediaWiki
MediaWiki‑Vagrant
MobileFrontend
OOjs
OOjs UI
openZIM
Parsoid
Pywikibot
QRpedia
Security (can we extract anything from here anyway?)
Tools (???)
VisualEditor
Wiki Loves Monuments
Wikimedia
Wikimedia Labs
Wikipedia App 

Then someone should map the components under "MediaWiki extensions" with [[wikitech:Key_Wikimedia_software_projects]]. Maybe it is easier to have the full list of components under "MediaWiki extensions" in Bugzilla and then remove those extensions not deployed here. It's not a big deal if there is a bit of mismatch. We can always fine tune.

Andre, can you help Santi with this?
Let's focus first on these graphs:

(In reply to Santiago Dueñas from comment #5)
> now we show "Time opened" by median and average.

There is still something odd here. See for instance "Time opened by Priority (average)"

In August 2004, apparently one month after opening the Bugzilla instance, we have about Low and Lowest bugs with a median of 1000 days. How can this be? I expect a graph that says that after 30 days of Bugzilla a bug can be 30 days old at most.


> The main problem here is with those big peaks in median charts.

Before trying to address the visualization problems of those high peaks, I still must understand the algorithm that generates them. You say...  

(In reply to Santiago Dueñas from comment #4)
> In this case, the peak is from bug 27320.

> It was submitted on Feb 2011 (that's why it is shown at that point in the
> chart) but its first action was made two years later (April 2013). Its
> current priority is Immediate.

I think we have a problem of perspective. Your perspective seems to be data-centric: "how old were the bugs created at this point of time when they received their first action?" We actually care about our own perspective as bugtriagers (yes, we are so self-centered people)  :) : "how old are today the open bugs that haven't received any action yet"? And last month? And a year ago?

We want to see whether we are processing those bugs faster or slower than before, whether we succeed addressing more important bugs faster or not. In this sense, I wouldn't expect high peaks emerging, since the highest increase from month to month can only be 31 days (unless you reopen hundreds of very old bugs, an unlikely scenario that would reflect a legitimate higher peak).

Let's agree on these points before tying to solve anything else, please.
(In reply to Santiago Dueñas from comment #5)
> The main problem here is with those big peaks in median charts. The useful
> data is lost at the bottom of the chart and you can only see flat lines. We
> have to think about how to manage these cases.

Scale in log base 10?
(In reply to Quim Gil from comment #3)
> The main problem I have with these graphs is that they show plenty of lines
> going up and down, but no clear message. 
> 
> When answering "Time to closed by Priority", I think we should actually
> answer "Median time of open bugs". This would provide more stable lines
> without huge jumps between months, where we can see
> 
> * whether we are increasing or decreasing the median time for open bugs
> * the differences of time response for higher and lower priority bugs
> 
> I think this change will make all the graphs a lot more useful.
> 
> Then we can organize better those six graphs:
> 
> Time to closed by Priority
> Time to closed by Severity
> 
> Then time to first action, then time to first comment.
> 

I think you are right.

Please have a look at the new charts that I've just uploaded. Instead of "Time to close" now we show "Time opened" by median and average. I've also included the median for first action and first comment.

The main problem here is with those big peaks in median charts. The useful data is lost at the bottom of the chart and you can only see flat lines. We have to think about how to manage these cases.

Average charts are still there for comparing with the median ones. We can remove them whenever you want.

> It would be good to have also a line for the median of the total of bugs,
> regardless of priority/severity, to see how good are we doing overall.
> 

Good point. I'm going to add it.

> One more thing, since we are considering "Lowest" almost as an equivalent of
> WONTFIX-for-maintainers (we assign Lowest priority when nobody is planning
> to act on a report), we might need to consider them as resolved-wontfix if
> they distort too much the results. We will see.

I had it into account for top issues and "Time opened" so these data is already filtered.
(In reply to Andre Klapper from comment #2)
> (In reply to Quim Gil from comment #1)
> > * We need to scan only the Bugzilla products and components corresponding to
> > https://wikitech.wikimedia.org/wiki/Key_Wikimedia_software_projects . Andre,
> > did you have a list somewhere mapping these?
> 
> Last list I made was bug 54469 comment 6.
> 
> > Andre, you are the main stakeholder of this page.
> 
> Noted.
> 
> One data issue in the graphs:
> http://korma.wmflabs.org/browser/bugzilla_response_time.html shows
> "avg_fa_Immediate:788.7567" for Feb 2011. That is impossible as the
> "Immediate" priority was only introduced on Nov 30, 2012:
> http://lists.wikimedia.org/pipermail/wikitech-l/2012-November/064746.html
> I have not investigated other peaks yet (also because I don't have data
> handy when which priority and severity was introduced in this Bugzilla).

It is shown that way because we take the current/final priority of a bug to classify them into group due to the priority can change during the life of bug.

In this case, the peak is from bug 27320.

https://bugzilla.wikimedia.org/show_bug.cgi?id=27320.

It was submitted on Feb 2011 (that's why it is shown at that point in the chart) but its first action was made two years later (April 2013). Its current priority is Immediate.

Another possibility is to select the initial state but most of the bugs (aroung 90%) fall in Unprioritize or Normal priorities. Selecting intermediate states doesn't make any sense because we would need infinite charts to show the data.
The main problem I have with these graphs is that they show plenty of lines going up and down, but no clear message. 

When answering "Time to closed by Priority", I think we should actually answer "Median time of open bugs". This would provide more stable lines without huge jumps between months, where we can see

* whether we are increasing or decreasing the median time for open bugs
* the differences of time response for higher and lower priority bugs

I think this change will make all the graphs a lot more useful.

Then we can organize better those six graphs:

Time to closed by Priority
Time to closed by Severity

Then time to first action, then time to first comment.

It would be good to have also a line for the median of the total of bugs, regardless of priority/severity, to see how good are we doing overall.

One more thing, since we are considering "Lowest" almost as an equivalent of WONTFIX-for-maintainers (we assign Lowest priority when nobody is planning to act on a report), we might need to consider them as resolved-wontfix if they distort too much the results. We will see.
(In reply to Quim Gil from comment #1)
> * We need to scan only the Bugzilla products and components corresponding to
> https://wikitech.wikimedia.org/wiki/Key_Wikimedia_software_projects . Andre,
> did you have a list somewhere mapping these?

Last list I made was bug 54469 comment 6.

> Andre, you are the main stakeholder of this page.

Noted.

One data issue in the graphs:
http://korma.wmflabs.org/browser/bugzilla_response_time.html shows "avg_fa_Immediate:788.7567" for Feb 2011. That is impossible as the "Immediate" priority was only introduced on Nov 30, 2012: http://lists.wikimedia.org/pipermail/wikitech-l/2012-November/064746.html
I have not investigated other peaks yet (also because I don't have data handy when which priority and severity was introduced in this Bugzilla).
The main problems discussed so far:

* We need to scan only the Bugzilla products and components corresponding to https://wikitech.wikimedia.org/wiki/Key_Wikimedia_software_projects . Andre, did you have a list somewhere mapping these?

* The graphs miss a legend describing what is being calculated. Documentation in the wiki page linked above would be useful too.

* The data calculated is the average, but the median is preferred.

* The graphs start in Jan 2002 but there is no data until Jul 2004.

* Proper labels.

I still must put more time to dive into these graphs and see whether they provide the answers we are looking for, or they could be improved. Andre, you are the main stakeholder of this page.
Intention:
Change an ISBN.

Steps to Reproduce:
1. Open a page with a pre-existing ISBN number (using the magic word).

2. Click in the link and open the link inspector.

3. Correct the numbers in the ISBN.

4. Close the link inspector.



Actual Results:  
The link label does not change.  This is not surprising, given VisualEditor's approach to links, but it is sometimes unfortunate; see https://fr.wikipedia.org/w/index.php?title=Massimo_Introvigne&diff=100272017&oldid=94374615

However, the link itself does not change, and if you have done nothing else, it is not possible to save the page, because you have supposedly made no changes.

Expected Results:  
Ideal behavior:

Changing "ISBN 1234567890" to "ISBN 1234567891" simply updates the plain wikitext magic word.

Possibly acceptable behavior:

Changing "ISBN 1234567890" to "ISBN 1234567891" updates the link to [[Special:BookSources/1234567891|ISBN 1234567891]].


Reproducible: Always

--------------------------
**Version**: unspecified
**Severity**: normal
**See Also**:
https://bugzilla.wikimedia.org/show_bug.cgi?id=52204
Change 233669 merged by jenkins-bot:
Specialized inspector for ISBN magic links

[[https://gerrit.wikimedia.org/r/233669]]
Change 233669 had a related patch set uploaded (by Cscott):
Specialized inspector for ISBN magic links

[[https://gerrit.wikimedia.org/r/233669]]
Change 233669 had a related patch set uploaded (by Cscott):
WIP: Specialized inspector for ISBN magic links

[[https://gerrit.wikimedia.org/r/233669]]
@krenair it's mostly orthogonal to this bug, but we just changed the `rel` type of ISBN links to `mw:WikiLink`.  I agree that it is more consistent that way.

The VE UX issue still exists: VE should detect edits to ISBN/RFC/PMID links and somehow keep the text and the link in sync.  I don't know the best way to do that within the VE codebase.
>>! In T63558#1365108, @Elitre wrote:
> @ssastry, are the problems described in [[ https://phabricator.wikimedia.org/T63558#677094 | this comment]] also possibly due to Parsoid? Thank you!

Looking at [[Special:BookSources/9782981011206|ISBN 978-2-9810112-1-]]<nowiki/>3 .. that looks like VE issues to me. The "3" is not part of the link text so, Parsoid is forced to add a nowiki to preserve HTML semantics. As for editing link text not chaning the underlying link, that is also a VE UX issue.
@ssastry, are the problems described in [[ https://phabricator.wikimedia.org/T63558#677094 | this comment]] also possibly due to Parsoid? Thank you!
The Parsoid output does not look quite right to me:
```<a href="./Special:BookSources/0345318641" rel="mw:ExtLink" data-parsoid='{"stx":"magiclink","dsr":[16,34,0,0]}'>ISBN 0-345-31864-1</a>```
ExtLink? That href is for a WikiLink...
The Parsoid output does not look quite right here:
```<a href="./Special:BookSources/0345318641" rel="mw:ExtLink" data-parsoid='{"stx":"magiclink","dsr":[16,34,0,0]}'>ISBN 0-345-31864-1</a>```
ExtLink? That href is for a WikiLink...
Other recent examples of ISBN problems caused by VE (awful syntax, link incoherent with displayed ISBN, nowiki added) :
https://fr.wikipedia.org/w/index.php?title=Bassin_s%C3%A9dimentaire&diff=prev&oldid=104307942
https://fr.wikipedia.org/w/index.php?title=Louis-Jos%C3%A9_Houde&diff=104782988&oldid=104262388

This is a recurring problem on frwiki.
The original plan for the math plugin was to create a equation editor GUI, similar to that in Google Docs.
https://www.mediawiki.org/wiki/User:Jiabao_wu/GSoC_2013_Application

This would have ability to insert mathematical symbols and create structures like integrals, matrices etc.

--------------------------
**Version**: unspecified
**Severity**: enhancement
*** This bug has been marked as a duplicate of bug 43058 ***
Consider VisualEditor as the default editing method, and suppose you are a new user arriving at one of the articles currently listed under
[[Category:Pages with missing references list]]
(or its equivalents in other languages).

Somewhere in the page there will be messages such as these:
* There are <ref> tags on this page, but the references will not show without a {{reflist}} template (see the help page).

* There are <ref group=$1> tags on this page, but the references will not show without a {{reflist|group=$1}} template (see the help page).

But since your few edits were made using VisuaEditor, you have no idea what are "<ref>", "<ref group=$1>" and "{{reflist|group=$1}}".

There are many other messages like that which are exposed to (inexperienced) users (either by MediaWiki core or one of its extensions). They should try to describe the problem avoiding talking about the wiki syntax, which will not make sense if VisualEditor is the only way someone is able to edit.


This bug report was inspired by the following feedback:
https://pt.wikipedia.org/wiki/WP:Editor_Visual/Comentários?oldid=38180789#fonte.2C_pede_sempre.

--------------------------
**Version**: unspecified
**Severity**: enhancement
I'm not sure this is a VisualEditor-specific bug, but yes, MediaWiki and its extensions' messages make occasional assumptions of the use of wikitext. This is much more acute due to local communities' over-ridden messages, which much more frequently make this mistake.
Screenshot

Number of reflist vertically misaligned, see screenshot

--------------------------
**Version**: unspecified
**Severity**: minor
**URL**: https://de.wikipedia.org/w/index.php?title=Wolfgang-Hahn-Preis_K%C3%B6ln&veaction=edit

**Attached**: {F13043}
**santosh.cool.reddy** wrote:

Looks like german pages are not using current visual editor. In english which uses https://www.mediawiki.org/wiki/Help:VisualEditor/User_guide doesn't show such errors.
**santosh.cool.reddy** wrote:

I had a look into this bug. I suggest style of ve-ce-mwTransclusionInlineNode must be "inline" not "inline-block" to clear this bug.
This is with Translate 2014-02-04.

I've created a testcase which you can see by visiting https://www.mediawiki.org/w/index.php?title=User:SamB/tvar_bug&oldid=907218&action=edit&section=1 and clicking the "preview" button.

Notice how all of the Translate markup shows up in the Preview because the <translate> tag isn't in this section?  That's kind of annoying.

{F31698682}
I don't really see a bug here - unclosed tags are probably just displayed like that by the parser, plus this just applies to the preview. 
Not sure if that's something to fix in the Translate codebase.
screenshot

steps to reproduce:

1.Open a page with VE
2.Insert an image
3.Go to the Media Settings of the image
4.Set the image to frameless and none as position
5.Now select the image

Observed Result:
 Image highlight box is appearing at the top left corner of the page

See the screenshot attached

Test Environment: http://en.wikipedia.beta.wmflabs.org/
Browser: Chrome Version 26.0.1410.65 
OS: MAC OS X 10. 8. 5 
Page:http://en.wikipedia.beta.wmflabs.org/w/index.php?title=14thfebchrome&veaction=edit

--------------------------
**Version**: unspecified
**Severity**: major

**Attached**: {F12967}
Verified the fix on:https://en.wikipedia.org/wiki/User:RYasmeen_%28WMF%29/sandbox
Verified the fix in test2
Verified the fix in betalabs
Change 116116 merged by jenkins-bot:
Don't show phantoms for hidden protected items

https://gerrit.wikimedia.org/r/116116
Change 116116 had a related patch set uploaded by Esanders:
Don't show phantoms for hidden protected items

https://gerrit.wikimedia.org/r/116116
*** Bug 56608 has been marked as a duplicate of this bug. ***
See for instance
https://fr.wikipedia.org/w/index.php?title=Philippe_Juvin&diff=101226971&oldid=101177693 .
The edit added `<span style="font-size:12.0pt;font-family:"Times New Roman","serif"; mso-fareast-font-family:Calibri;mso-ansi-language:EN-GB;mso-fareast-language: EN-US;mso-bidi-language:AR-SA">` to a newly added reference.
It was reported by NicoV at fr.wp, I haven't had a chance to see if it can be reproduced or how yet.

**See Also**:
* {T60689}
* {T71821}
* {T71513}
* {T75292}
Yeah, probably...
My guess is that https://cs.wikipedia.org/w/index.php?title=%C4%8Cesk%C3%A1_akademie_v%C4%9Bd_a_um%C4%9Bn%C3%AD&diff=11859116&oldid=11475316 is copy/paste issue as well?
<span style="... mso-..."> It's a copy/paste from Microsoft Office => Word

mso + wysiwyg on google => general trouble
If you look at the history of the same article, you'll see several edits with the same kind of problems (references added with unwanted formatting: span
I saw the same kind of problem on other articles, but can't find them right now.

https://fr.wikipedia.org/w/index.php?title=Philippe_Juvin&action=history
https://fr.wikipedia.org/w/index.php?title=Philippe_Juvin&diff=prev&oldid=101128645
https://fr.wikipedia.org/w/index.php?title=Philippe_Juvin&diff=prev&oldid=100741981
Anyway, I tested and couldn't reproduce it.
(It reminds me of Bug 58689, but the tag is different.)
Intention:
Whenever a new VE feature is launched it seems as though existing translations are not included.

Steps to Reproduce:
1. Go to https://sv.wikipedia.org/wiki/Bonsai?uselang=de&veaction=edit
2. Click on media settings for the first image
3. Click advanced settings (Erweiterte Einstellungen)

Actual Results:  
2. Alt_text dialogue reads "Alternative text"
3. Position dialogues read "Position: Left, right, center, none "

Expected Results:  
2. Alt_text dialogue reads "Alternativtext" (per https://translatewiki.net/w/i.php?title=MediaWiki:Visualeditor-dialog-media-alttext-section/de)
3. Should also be all in german (per e.g. https://translatewiki.net/w/i.php?title=MediaWiki:Visualeditor-dialog-media-position-left/de)

Reproducible: Always

This is not just an issue with the above features (or with uselang=de) but rather happens at every launched VE feature. Since the translations have normally been done before there is no reason why they should not be included as part of the pushing of any new feature.

The VE translations also seem to take longer to go live then translations in other parts of the interface (seems to happen only when there are other VE updates).

--------------------------
**Version**: unspecified
**Severity**: normal
**See Also**:
https://bugzilla.wikimedia.org/show_bug.cgi?id=64230
We'd need to check if the fix for bug 67805 fixed this as well.
(In reply to Elitre from comment #7)
> I wonder if bug 64230 is related?

Seems possible; adding as a see-also.

(In reply to Andre Klapper from comment #6)
> James: As this is assigned to you, do you plan to investigate?

No; unassigning.
I wonder if bug 64230 is related?
James: As this is assigned to you, do you plan to investigate?
James: As this is assigned to you, do you plan to investigate?
I am not sure if this counts as an example or not.
A French Wikipedian reported he spotted a few untranslated messages in the interface. I checked, and the French equivalent for both of them did exist on TranslateWiki. While https://translatewiki.net/wiki/MediaWiki:Visualeditor-dialog-transclusion-multiple-mode/fr is quite recent, https://translatewiki.net/wiki/MediaWiki:Visualeditor-dialogbutton-template-tooltip/fr was created last year. The interface tells me these are the correct messages, but they still won't show up. So I just created the related MediaWiki message locally, but I don't think this should be the solution.
Time difference between VE and non-VE items I've got no source for rather than a general impression (thus "seems" in my statement). In general though we are talking about weeks before the translations appear.

The main issue for me would be why existing translations are not included with the launch of new features? For the above case both de and sv translations existed before the features went live, yet they were not included until 1+ week later. Surely the point of making the messages translatable before they go live is to avoid users having to encounter untranslated strings.
Anybody having an idea how to investigate this?
(In reply to Lokal_Profil from comment #0)
> Intention:
> Whenever a new VE feature is launched it seems as though existing
> translations are not included.
> 
> Steps to Reproduce:
> 1. Go to https://sv.wikipedia.org/wiki/Bonsai?uselang=de&veaction=edit
> 2. Click on media settings for the first image
> 3. Click advanced settings (Erweiterte Einstellungen)
> 
> Actual Results:  
> 2. Alt_text dialogue reads "Alternative text"
> 3. Position dialogues read "Position: Left, right, center, none "
> 
> Expected Results:  
> 2. Alt_text dialogue reads "Alternativtext" (per
> https://translatewiki.net/w/i.php?title=MediaWiki:Visualeditor-dialog-media-
> alttext-section/de)
> 3. Should also be all in german (per e.g.
> https://translatewiki.net/w/i.php?title=MediaWiki:Visualeditor-dialog-media-
> position-left/de)
> 
> Reproducible: Always
> 
> This is not just an issue with the above features (or with uselang=de) but
> rather happens at every launched VE feature. Since the translations have
> normally been done before there is no reason why they should not be included
> as part of the pushing of any new feature.
> 
> The VE translations also seem to take longer to go live then translations in
> other parts of the interface (seems to happen only when there are other VE
> updates).

Translations of VE items should go live at the same time as non-VE items (as they are done by the same process) – if not, this sounds like a localisation update bug. Moving there to see if anyone has any ideas.
Intention:
Remove extraneous items from a Babel box

Steps to Reproduce:
1. Click on the Babel box to edit it. 
2. Remove unwanted parameters (with trashcan icon).
3. Apply changes.

Actual Results:  
Three items were correctly removed, but two that were kept were not displayed in VisualEditor.  (See screenshot to compare diff to VisualEditor's display.)

Expected Results:  
The transcluded {{#babel:en}} function would display correctly. 

Reproducible: Yes
Created attachment 14584
Babel box bug:  "Review changes" does not match what's displayed in the lower right corner.

**Attached**: {F12886}
Highlighted clear formatting option

Steps to reproduce:

1.Open a page with VE
2.Select a text and apply some text styles from the toolbar like "Bold", "Italic"
3.Now select "Clear Formatting:
4.Again reapply these formats

Observed Result:
Observe that, the though the text formats are reapplied the "Clear formatting" option remains selected.


See the screenshot attached

Test Environment: http://en.wikipedia.beta.wmflabs.org/
Browser: Chrome Version 26.0.1410.65 
OS: MAC OS X 10. 8. 5 
Page:http://en.wikipedia.beta.wmflabs.org/wiki/11thfeb?veaction=edit

--------------------------
**Version**: unspecified
**Severity**: normal

**Attached**: {F13203}
Verified the fix on production:https://en.wikipedia.org/wiki/User:RYasmeen_(WMF)/sandbox?veaction=edit
This was fixed last month.
All thumbnails, eg [[File:example.jpg|thumb]], are displaying as 220px (which is the usual wikimedia/mediawiki default, per bug 21117). 

If I change my "Thumbnail size" preferences (to 300px for example) at https://www.mediawiki.org/wiki/Special:Preferences#mw-prefsection-rendering then the thumbnails in existing Flow posts do not change accordingly.

The same applies to new posts that I make, or posts that I edit: all thumbnails are 220px regardless.

--------------------------
**Version**: unspecified
**Severity**: normal
Original patch (in VE) is closed - shutting this one down as well
Possibly this is a WONTFIX, per bug 47804 ("VisualEditor: "Thumb" images should display in wiki default thumb size"). Which seems reasonable, but if so, it should be documented.
broken link inspector UI

Steps to reproduce:

1.Open a page with VE
2.Add an image
3.Go to some other tab/window
4.After an idle time (~5 mins) come back to VE
5.Open any inspector like galley/link/Math

Observed Result:

All the inspectors are appearing with broken UI

See the screenshots attached.

Test Environment: https://test2.wikipedia.org/
Browser: Chrome Version 26.0.1410.65 & FF 25
OS: MAC OS X 10. 8. 5 
Sample Page:https://test2.wikipedia.org/wiki/Test2chromefeb7th?veaction=edit

--------------------------
**Version**: unspecified
**Severity**: major
**See Also**:
https://bugzilla.wikimedia.org/show_bug.cgi?id=70580

**Attached**: {F12858}
Bah.
I'm imagining so, too.
Probably long fixed…
Has anyone run into this issue recently?
Seems to be fixed. Formula/Gallery inspectors have a slight problem with displaying their border in full-screen view(test2 only), otherwise - betalabs/production display all inspectors correctly after various idle time intervals - 5-20 min.
Created attachment 14530
Formula inspector UI

**Attached**: {F12859}
Given url:
http://en.wikipedia.org/w/api.php?action=visualeditor&page=Berlin&paction=parse

Return this:
<?xml version="1.0"?>
<api servedby="mw1193">
  <error code="internal_api_error_MWException" info="Exception Caught: Internal error in ApiFormatXml::recXmlPrint: (notices, ...) has integer keys without _element value. Use ApiResult::setIndexedTagName()." xml:space="preserve" />
</api>

I guess, I make something wrong, but the error message does not really help me to understand what goes wrong.

--------------------------
**Version**: unspecified
**Severity**: minor
**See Also**:
https://bugzilla.wikimedia.org/show_bug.cgi?id=62452
Change 119912 merged by jenkins-bot:
Block non-JSON API access to VisualEditor, as it won't work

https://gerrit.wikimedia.org/r/119912
Change 119912 had a related patch set uploaded by Jforrester:
Block non-JSON API access to VisualEditor, as it won't work

https://gerrit.wikimedia.org/r/119912
The action=visualeditor API is purely designed for JSON access; we should inform the user that XML / etc. won't work instead of dying horribly.
If nothing else, it should probably be in the /lib directory rather than /modules (which will save us a directory's depth of file paths).

--------------------------
**Version**: unspecified
**Severity**: enhancement
Done at Wikimania 2014.
This is a Parsoid/RESTBase issue. For caching purposes they don't serve different content based on user preferences.
At least this should be forward compatible and support the MathML rendering mode... maybe it's not optimal to classify this as "Low" priority.
Sure, but the non-MathJax rendering options are also ignored.
MathJax is no longer supported. See T99369
*** Bug 64572 has been marked as a duplicate of this bug. ***
The title change seems to have repurposed this bug. The original title 
VisualEditor: Math formulas don't display correctly after save (until page is reloaded)  was a dupe of bug 36060 a dependant of bug 51565.

The current title does not describe current behaviour:

With VisualEditor formulae editing beta feature OFF. Formula are displayed as PNG's and can't be edited.

With VisualEditor formulae editing beta feature ON. Formula are initially displayed as PNG's they can be edited. As soon as they are edited they switch to MathJax display but with very garbled output due to Bug 61497.
Right now, if I add an image for example:https://test2.wikipedia.org/wiki/File:Foo.jpg

Initially in VE from Insert>Media it renders as 229x150.
If a user attempts to resize it to 350x350 , it will show a message that "Size Values are invalid"  as it has exceeded the original dimension values.But unless user knows those original dimensions , he or she might keep trying with different values not knowing what should be the input limit.

I think it will be better if we can have more clearer indication in the message saying something like "the size values are invalid since it has exceeded original dimension"

--------------------------
**Version**: unspecified
**Severity**: enhancement
(In reply to comment #2)
> Should those block the 'apply' button, or just give an indication that the
> size itself won't be applied, giving the user the option to apply the rest
> of the properties?

The second – see bug 60602.
Should those block the 'apply' button, or just give an indication that the size itself won't be applied, giving the user the option to apply the rest of the properties?
We should probably have several errors:

* "Size can be up to <width>x<height> pixels." (if too big for media)
* "Size must be positive whole numbers." (if not valid, e.g. negative or "hello")
* "Size is limited to <maxsize> pixels." (if SVGMaxSize reached)
Reproducible: Always

http://mediawiki.org/wiki/MediaWiki:Visualeditor-specialcharinspector-characterlist-insert should have the logical order of degrees, minutes, seconds, not with seconds in the middle.

--------------------------
**Version**: unspecified
**Severity**: trivial
Change 138304 merged by jenkins-bot:
Re-order special character mathematical symbols to be degrees, minutes, seconds

https://gerrit.wikimedia.org/r/138304
Change 138304 had a related patch set uploaded by Jforrester:
Re-order special character mathematical symbols to be degress, minutes, seconds

https://gerrit.wikimedia.org/r/138304
I'm not sure, but I think this is a regression (it didn't use to be this way).

A button that is flagged as constructive and currently disabled has a green border around its otherwise grey button. When hovering the button the border becomes grey, so it doesn't seem intentional that the border is green (otherwise it should have a hover implementation as well).

This is most visible when opening VisualEditor, the save button has emits this behaviour.

--------------------------
**Version**: unspecified
**Severity**: normal
Change 122879 merged by jenkins-bot:
apex/button: Reset border-color of disabled button when not hovered

https://gerrit.wikimedia.org/r/122879
Change 122879 had a related patch set uploaded by Krinkle:
apex/button: Reset border-color of disabled button when not hovered

https://gerrit.wikimedia.org/r/122879
**Author:** `gryllida`

**Description:**
Script viewer software should support sections and section editing, using one-line comments (or special formatting therein) for heading syntax.

---------------------------------------------

/* Foo */

Foo.prototype.bar = function(){
...
};
Foo.prototype.baz = function(){
...
};

^^^^^ everything above is in the Foo section

/* Foo 2 */ <---------- this becomes a heading

Foo2.prototype.bar = function(){
...
};

Foo2.prototype.baz = function(){
...
};

^^^^^ everything above is in the foo 2 section


---------------------------------------------

--------------------------
**Version**: unspecified
**Severity**: enhancement
**See Also**:
https://bugzilla.wikimedia.org/show_bug.cgi?id=50962
We actually have a geshi module that does this in the CodeEditor codebase, but it's only the editor mockup, it's not actually able to make changes to the wikitext right now.

Because you seem to be interested in similar functionality, I have fixed up the module in this patch: https://gerrit.wikimedia.org/r/#/c/127451/

Making it fully work would be quite some additional work still, but it's not as far away as I initially figured. The biggest problem is that we need to make sure not to implement everything a dozen times (live preview, editpage, visual editor and inline code editor).
**gryllida** wrote:

There are two reasons behind this.

1) Usually people contain different objects in different files. On wiki, browsing (or simply creating) different files and subfiles of a JS file is far from intuitive. It could make sense to add support for sections.

2) Inline (POD-like) documentation would benefit readability. See i.e. http://juerd.nl/site.plp/perlpodtut .

In other words, CodeEditor should be capable of editing any <source> block on a page without entering edit mode for the entire page. I am renaming the bug title accordingly.
Can I ask why ?

I mean a section in Javascript is usually not a self-contained unit, it only has meaning icw all the other stuff. So I'm trying to understand why you would want to edit it in that way. Can you clarify how this helps you to edit code ?
**gryllida** wrote:

https://test.wikipedia.org/wiki/User:Gryllida/common.js
a stupid ugly workaround

https://test.wikipedia.org/wiki/User:Gryllida/afch2/v2
with sections

syntax highlight ok, code-editor does not pick it up
See also
https://bugzilla.wikimedia.org/show_bug.cgi?id=43008#c2
**gryllida** wrote:

(Or Lua script.)
**gryllida** wrote:

Whatever I see when reading or editing [[Special:MyPage/common.js]]. (There is one extension which highlights the code when reading it, and another extension which is responsible for the code editor; I don't know which one this bug falls under, since both of them would have to support editing a section of a JS or CSS script.)
Hi, what is "Script viewer"? Is this [[mw:Extension:CodeEditor]]?
Dragging and dropping text (as an alternative to keyboard or context menu copy and paste commands) inside CodeEditor does not work.

Since this is basic functionality in every other editor I know this should also be supported by CodeEditor.

--------------------------
**Version**: unspecified
**Severity**: enhancement
**See Also**:
https://github.com/ajaxorg/ace/issues/1879
I carnt set multiple assigned to by TheDj is also included.
I cArnt set multiple assigned to by TheDj is also included.
Change 144780 merged by Brion VIBBER:
Ace: Update to 2015-01-28

[[https://gerrit.wikimedia.org/r/144780]]
Change 144780 had a related patch set uploaded (by Paladox):
Ace: Update to 08-07-2014

[[https://gerrit.wikimedia.org/r/144780]]

#patch-for-review
Change 144780 had a related patch set uploaded by TheDJ:
Ace: Update to 08-07-2014

https://gerrit.wikimedia.org/r/144780
Fixed upstream. I'll schedule an update of the code sometime next week.
Change 121044 abandoned by TheDJ:
Remove CodeEditor delay in drag & drop of text

Reason:
Fix added upstream.

https://gerrit.wikimedia.org/r/121044
Has been fixed upstream (thanks Derk-Jan):
https://github.com/ajaxorg/ace/commit/63f43da96a1bd2b9894c371fb0feed7e38ef34d6

Let's wait until this fix makes it into MediaWiki's CodeEditor extension...
Very nice! Thank you for the submission.
https://github.com/ajaxorg/ace/pull/2012
i still need to wrap this in some platform dependent if constructs.
Change 121044 had a related patch set uploaded by TheDJ:
Remove CodeEditor delay in drag & drop of text

https://gerrit.wikimedia.org/r/121044
So as answered in the linked upstream bug it seems this delay is actually configurable.

Nighwing wrote:
You can disable dragDelay by setting editor.setOption("dragDelay", 0)

Can somebody familiar with CodeEditor implement this? I can't see a reason to keep the delay at this point.
Thank you for clarifying Eduard !
Upstream bug is https://github.com/ajaxorg/ace/issues/1879

Let's hope it is easy fixable and not some sort of technical limitation.
No this definitely is about CodeEditor!

And while I just wanted to write that this is definitely not fixed I just realized during some additional testing that it actually is working... but only somehow.

I don't know if I have a very special way of dragging/dropping but actually dragging only starts after a small delay (note that after clicking highlighted text the cursor only changes to the move cursor after approx. 100 ms). If you start moving the mouse before it will just create a new selection.
However when normally dragging/dropping I start moving the mouse right away. Moving the mouse over the highlighted text, clicking, then *waiting* and only after waiting beginning to move the mouse is just counterintuitive and different from every other program I know.

Since it therefore doesn't seem to be specific to MediaWiki's implementation (Ace's web demo "works" exactly the same) I'll report a bug for Ace directly however. I'll update this bug with the respective info then.
This works for me in the beta at least: http://en.wikipedia.beta.wmflabs.org/w/index.php?title=Module:HtmlBuilder&action=edit

It might be that the reporter is actually talking about VisualEditor, which indeed does not seem to support drag and drop of text.
This should especially useful as new images may not appear in the API search results due to caching.
Change 210831 abandoned by MarkAHershberger:
MWMediaSearchWidget: Show user uploads

[[https://gerrit.wikimedia.org/r/210831]]
@Jdforrester-WMF I see the #Design tag was added but just wanted to make it explicit, I assume correctly from T154234#3072200 that this task is currently blocked on a design for showing user uploads in the Media insertion dialog so that <https://gerrit.wikimedia.org/r/210831> can be reworked to implement that?
Change 210831 had a related patch set uploaded (by Esanders):
WIP Show recent uploads in MWMediaSearchWidget

[[https://gerrit.wikimedia.org/r/210831]]
Jdforrester-WMF writes:

> This is a functionality task. The search results caching task was
> resolved by the switch to ElasticSearch months ago.

Just to be clear, though, this is something I would see in any browser,
right?  I've seen it in multiple browsers and across reboots so it isn't
a local caching problem.
>>! In T62398#1067311, @MarkAHershberger wrote:
> This issue (can't see recent uploads in the selection) was pointed out to me by a client.  At first I thought this was an IE caching problem, but I'm glad  to see it has been spotted elsewhere.

This is a functionality task. The search results caching task was resolved by the switch to ElasticSearch months ago.
This issue (can't see recent uploads in the selection) was pointed out to me by a client.  At first I thought this was an IE caching problem, but I'm glad  to see it has been spotted elsewhere.
Change 109670 had a related patch set uploaded by Esanders:
WIP Show recent uploads in MWMediaSearchWidget

https://gerrit.wikimedia.org/r/109670
Re: search caching, 'File:Three_sided_football_pitch.svg' is still not showing up in search results, an hour after uploading.
Yes there will be edge cases where the username on commons is different, but that is an edge case.

We can fill in the first row with recent uploads if found (which solves the case of "most users don't upload") and then fill with page title.
Currently we show the name of the article. Lots of users have mentioned that this is helpful (albeit limited utility for non-English users until we implement Wikidata-based item searching instead of string searching).

Walking away from this benefit from the somewhat-dubious benefit of your own uploads (most users don't upload, and we'd have no way to check for your "own" uploads on foreign repos) feels like a regression.
We can just show recent uploads when no search term is entered.
(In reply to comment #0)
> This should be relatively simple compared to full UploadWizard integration,

… but turns a simple search interface into a (multi-tabbed?) optional series of interfaces. :-(

> new images may not appear in the API search results due to caching.

{{cn}}

The exceptional amount of work put into the new search system has this as its most significant user-facing improvement.
Intention:
Remove a line that appears in the last section of a page, underneath a section that has an unclosed/unpaired {{refbegin}} template.

Steps to Reproduce:
1. Open https://en.wikipedia.org/w/index.php?oldid=592187387 in VisualEditor.

2. Try to select anything after the ==Bibliography== section, e.g., anything in the ==External links== section.

Actual Results:  
The cursor knows only two positions:  before the refbegin template, and in the slug at the bottom of the page.  You can't select or edit anything in between.


Reproducible: Always

--------------------------
**Version**: unspecified
**Severity**: normal
I'm not sure what else you could expect VE to do here.
Steps to reproduce:

- create a simple page with just this text: <syntaxhighlight lang="xml">></syntaxhighlight>
- example page: https://test2.wikipedia.org/wiki/Codez
- when the page is saved, only this is displayed, as expected: >

- edit the page with visual editor
- edit the text using syntaxhighlight editor
- for example, add just this: <
- see attached screen shot #1

- use "back" icon to see how the text will look like
- I was expecting to see this as page text: ><
- instead, the preview says page text is: &gt;&lt;
- see attached screen shot #2

- when the page is saved, the text is displayed correctly: ><
- see attached screen shot #3

--------------------------
**Version**: unspecified
**Severity**: minor
This is actually the same issue as bug 57429, let's merge the bugs.

*** This bug has been marked as a duplicate of bug 57429 ***
*** Bug 66456 has been marked as a duplicate of this bug. ***
Created attachment 14357
screen shot #3

**Attached**: {F12969}
Created attachment 14356
screen shot #2

**Attached**: {F12968}
Created attachment 14355
screen shot #1

**Attached**: {F12966}
Steps to reproduce:

1.Open a page which has a gallery inside it with VE
2.Select the gallery and open the gallery inspector
3.Close the gallery inspector 

Observed Result:

The "Save page" button of the page gets enabled although no change has been made in the gallery inspector

Test Environment: https://test2.wikipedia.org/
Browser: Chrome Version 26.0.1410.65 & FF 25
OS: MAC OS X 10. 8. 5 
Page:https://test2.wikipedia.org/wiki/Thedomtest

--------------------------
**Version**: unspecified
**Severity**: minor
Change 342240 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor] Update gallery actions in response to changes

[[https://gerrit.wikimedia.org/r/342240]]
Change 342240 had a related patch set uploaded (by Tchanders):
[mediawiki/extensions/VisualEditor] Update gallery actions in response to changes

[[https://gerrit.wikimedia.org/r/342240]]
Change 315449 abandoned by Tchanders:
WIP Update gallery dialog actions to reflect presence of changes

Reason:
This was split into two patches

[[https://gerrit.wikimedia.org/r/315449]]
Change 315449 had a related patch set uploaded (by Tchanders):
WIP Update gallery dialog actions to reflect presence of changes

[[https://gerrit.wikimedia.org/r/315449]]
https://noc.wikimedia.org/conf/visualeditor.dblist

This should be fully alphabetized, in my opinion. While people with intimate knowledge of Wikimedia's structure can likely discern and explain the current order, it seems like a lot more overhead than any value provided. A simple alphabetical index is easier to maintain (including insertion), it's more consistent with the other lists of databases (as far as I know), etc.

--------------------------
**Version**: wmf-deployment
**Severity**: enhancement
Why? It's a list of 300 dbnames; no-one sane is going to read it, just grep through it.

The current structure is sorted {public/private,project,alphabetical}. This is to prevent accidental mis-configuration. Eventually VE will be on for all wikis, but then we'll just delete this dblist.

If dblists supported comments it'd probably be easier to see, I agree, but that is not this bug.
I'm not sure how well these would work, but at least here in China, it is slow to wait for previews of musical scores for each modification. If you could add client-side support to Score, perhaps via:

* http://code.google.com/p/abcjs/
* https://github.com/incompleteopus/vexabc

...I wonder whether client-side rendering support (ideally in SVG in case notes could be synchronized with the music play-back in the future) could be added, if not now, then maybe after the main Mediawiki WYSIWYG interface stabilizes?

And support for the emerging Web Audio standard would be awesome for client-side audio play-back as well...

Also, with ABC seeming (to my quick glance) more like an open standard than Lilypond, might it make sense to make ABC the default?

--------------------------
**Version**: unspecified
**Severity**: enhancement
#visualeditor implements similar support to your examples. Also, both ABC and Lilypond are open, but Lilypond is more flexible and has `abc2ly`. ABC doesn't have vice-versa :)
In the past few years we've worked really hard to bring UploadWizard to a usable state, and now that we have a Multimedia team framework to actually do some good work on it, and we have the impetus to start making the upload pipeline way better, let's do it the right way: Let's make this project the organized, well-engineered machine it should have been in the first place.

I would particularly emphasize code conventions being followed, jshint conformance, an eye towards an MVC-like structure (nothing strict, but as a general goal...), building toward libraries that can be used elsewhere, and a variety of different possible interfaces.

Ideally none of the upload steps will be entangled unnecessarily with other steps, and we will be able to untangle them when necessary and put them in different pages or tools.

Ideally we will use the brilliant work- and complexity-reducing technology (oojs, oojs-ui, jQuery promises, moment.js) that other projects have started using in recent times.

It is an absolute *must* that we build tests for this system as we are building it, if we want this to be a generally useful set of tools for other projects. Same for documentation.

The leaders in LOC for active frontend projects deployed on the cluster are* VisualEditor, UploadWizard, Flow, and MultimediaViewer (in no particular order). Let's start bringing the upload pipeline projects closer to the high standards that other projects are holding themselves to.

* According to an unscientific survey based on guesswork

See https://www.mediawiki.org/wiki/Requests_for_comment/More_general_frontend_uploading_tools for more.

--------------------------
**Version**: unspecified
**Severity**: normal
**See Also**:
https://bugzilla.wikimedia.org/show_bug.cgi?id=62513
`<prtksxna> James_F: I think mw.Upload and mw.ForeignStructuredUpload resolved this.`
This is a tracking bug for any problems in VisualEditor associated with the Draft: namespace at the English Wikipedia.

--------------------------
**Version**: unspecified
**Severity**: enhancement
Indeed. All known issues fixed. Marking as such.
It seems slightly silly to have a whole tracking bug lying around to track one single bug...
It's not clear how the "Tag the edit for further review" option for AbuseFilter rules would work for Flow. Maybe it would add something to the Special:RecentChanges entry for FLow.

This is mentioned in https://www.mediawiki.org/wiki/Flow/Administration_notes

--------------------------
**Version**: master
**Severity**: normal
**See Also**: {T64750}
See here for an example of where AF tags appear:
https://en.wikipedia.org/w/index.php?title=User:Quiddity_%28WMF%29/sandbox&action=history
https://en.wikipedia.org/w/index.php?title=Special:Contributions/Quiddity_%28WMF%29&dir=prev&offset=20140107194435&limit=2&target=Quiddity+%28WMF%29
"(Tag: VisualEditor)"

documentation at:
https://en.wikipedia.org/wiki/Wikipedia:Tags
(and more linked in the navbox at the top)
We may be able to get this tag indication into the presentation of Flow changes in RecentChanges, Watchlist, Special:Log and history.
FWIW, I took a very quick look at that code in AbuseFilter yesterday - this is pretty much what it does for article edits.

AFAICT, when running a filter is matched and it needs to tag, something is added to array AbuseFilter::$tagsToSet, which is then read from a hook triggered when saving recentchanges for an article edit (RecentChange_save)
**bingle-admin** wrote:

The WMF core features team tracks this bug on Mingle card https://wikimedia.mingle.thoughtworks.com/projects/flow/cards/701, but people from the community are welcome to contribute here and in Gerrit.
On wiki's with Scribunto installed, when viewed in the mobile site, the exception "Uncaught Error: Unknown dependency: ext.scribunto" is thrown which prevents any further JavaScript from running.

This is because the module is not registered on mobile.

It also depends on jquery.ui.dialog code which pulls in the entire jquery.ui library - we certainly do not want on mobile where JavaScript load should be as tiny as possible.

I doubt we'd want to run this code on mobile thus the use of addInlineScript needs to be avoided since the module doesn't exist in the mobile environment. At the very least it should be wrapped with a try catch so say it is acceptable to fail.

Seems to have been introduced by https://gerrit.wikimedia.org/r/#/c/5617/1,publish

--------------------------
**Version**: unspecified
**Severity**: normal
Change 109262 abandoned by TheDJ:
Conditionally load jquery.ui.dialog for Scribunto errors

Reason:
Fixed with: https://gerrit.wikimedia.org/r/#/c/118944/

https://gerrit.wikimedia.org/r/109262
I'd still advise you to move away from jquery.ui but this is not effecting mobile now so I am happy.
Change 118944 merged by jenkins-bot:
Don't try to inline load ext.scribunto on mobile

https://gerrit.wikimedia.org/r/118944
Change 118944 had a related patch set uploaded by Hoo man:
Don't try to (inline load) ext.scribunto if it isn't registered

https://gerrit.wikimedia.org/r/118944
Change 109262 had a related patch set uploaded by TheDJ:
Conditionally load jquery.ui.dialog for Scribuntu errors

https://gerrit.wikimedia.org/r/109262
Updated summary since of course it doesn't pull in the whole of jQuery UI, it pulls in jquery.ui.dialog and (implicitly) its 7 dependencies, so 8 out of the 17 JavaScript files in resources/jquery.ui/
let's just dynamically load it, it's simple and not too many 'normal' users are using it anyways. When OOjs is more mature, we can just switch it over.
One problem with alert() is that it's not HTML, so you couldn't click on the source file links which appear in the Scribunto backtraces.

(In reply to comment #1)
> Okay this doesn't look so bad now as it seems to only become a problem when a
> ScribuntoError occurs (I'm not sure how often this occurs on wiki's - I've
> only managed to replicate this locally). 

You can replicate it on the pages in this category:

https://en.wikipedia.org/wiki/Category:Pages_with_script_errors

It looks like there are currently no such pages in the main namespace, so the impact of this bug on readers of en.m.wikipedia.org is negligible.

There's a bug in Scribunto which causes jquery.ui.dialog and the hidden category to be added even if no errors are emitted into the final HTML, say due to the error being sent to the condition of a {{#iferror:}}. At one point, there were tens of thousands of pages in [[Category:Pages with script errors]] for no obvious reason, possibly due to that bug. So, it would have affected mobile readers at that time. That could be reported separately if it's not already.

> However it seems bizarre to me that the
> entire jQuery UI library would be loaded simply for error reporting...

I think error reporting is the most important feature in Scribunto, it's central to the usability of Lua scripting. So I don't think it's bizarre that it loads libraries. It's just somewhat inefficient. 

I would be fine with a lightweight DIY thing, or with dynamic loading of jquery.ui.dialog on click of the error message, with a spinner.
OOjs is in core, but if you want to make dialogs, you probably need OOjs UI as well, which is still only in VisualEditor.
(In reply to comment #4)
> * Remove the dialog code from Scribunto and just use a JS alert in the
> meantime. Alerts are pretty unfriendly (since they take over the browser,
> stop
> JS execution, etc.), but since it's such a limited use, it might be OK for a
> short-term fix.

I believe some browsers are starting to block alters entirely.

(In reply to comment #5)
> As stated the correct thing to do would be to start using OO.js which is in
> core.

Patches welcome. Or even links to examples.
In case I was clear please do not follow Ryan's suggestion of 
"Make jquery.ui and jquery.ui.dialog loadable on mobile by giving them the
'mobile' target in the module definition (and make sure they are only loaded
when there is an error)"

An alert would make more sense, using jQuery UI is overkill for this use case imo.
jQuery UI != jQuery
Use jQuery by all means of a jQuery plugin for this - you do not need a huge library the size of jQuery UI.

jQuery UI is totally unsuitable for mobile. Please do not load it to simply use I'd guess about 2% of the library..

As stated the correct thing to do would be to start using OO.js which is in core.
For desktop, jQuery UI is fine (at least until OO.js is more widely adopted). The only problem is that mobile doesn't want to load jQuery UI unless absolutely necessary, and Scribunto is used on both desktop and mobile.

There are two possible short-term solutions:
* Make jquery.ui and jquery.ui.dialog loadable on mobile by giving them the 'mobile' target in the module definition (and make sure they are only loaded when there is an error)
* Remove the dialog code from Scribunto and just use a JS alert in the meantime. Alerts are pretty unfriendly (since they take over the browser, stop JS execution, etc.), but since it's such a limited use, it might be OK for a short-term fix.
What's the point of having jQuery if we're not supposed to use it?
Realistically, Scribunto does not require the full jQuery UI. I feel that it should roll its own "script error" popup, since jQuery UI Dialogs were not really designed for this use.
Okay this doesn't look so bad now as it seems to only become a problem when a ScribuntoError occurs (I'm not sure how often this occurs on wiki's - I've only managed to replicate this locally). However it seems bizarre to me that the entire jQuery UI library would be loaded simply for error reporting...
It either snaps to the top left of the screen (instead of lining up with the surface), or it tries to render with 0 width (especially if you switch page)

--------------------------
**Version**: unspecified
**Severity**: normal
*** Bug 60183 has been marked as a duplicate of this bug. ***
Change 109489 merged by jenkins-bot:
Attach container to DOM before initialising target in demo

https://gerrit.wikimedia.org/r/109489
Change 109489 had a related patch set uploaded by Esanders:
Attach container to DOM before initialising target in demo

https://gerrit.wikimedia.org/r/109489
I can't find a cause using git-bisect.

VisualEditor.git goes back to 20 Dec 2013, which already exhibits the problem.

Bisecting in mediawiki/extensions/VisualEditor.git also led to nothing as the problem was never present there to begin with.

I suspect the problem may be caused by us having removed a stylesheet in the repo split that is now in the ve-mw only, but should be under ve/ve instead.
Intention:
Rearrange the sections on a page

Steps to Reproduce:
1. Select the entire last section
2. Cut (Command-X) the section
3. Paste it elsewhere

Actual Results:  
The formatting for the section heading (not the formatting for the last line) remains at the end of the page.


Expected Results:  
The last line should either disappear entirely (be replaced by a slug) or be set to default/Paragraph styling

Reproducible: Always

Removing the blank section heading produced its own problems; look for the next bug report.

--------------------------
**Version**: unspecified
**Severity**: minor
**URL**: https://en.wikipedia.org/w/index.php?title=Celebrity_branding&diff=589156664&oldid=583130311
**See Also**:
{T52100}
{T57769}
Verified in beta.
Change 162310 merged by jenkins-bot:
For empty / whitespace-only headings, output <p> instead of <h#>

[[https://gerrit.wikimedia.org/r/162310]]
Change 162310 had a related patch set uploaded (by Jforrester):
MWHeading: Don't put self in output if contents are blank or whitespace

[[https://gerrit.wikimedia.org/r/162310]]

#patch-for-review
Change 162310 had a related patch set uploaded by Jforrester:
MWHeading: Don't put self in output if contents are blank or whitespace

https://gerrit.wikimedia.org/r/162310
In edit mode

Steps to reproduce:

1.Open a page with VE
2.Now add a reference to the page
3,Add a bullet or numbered list
4.Add references list from Insert>References list
5.Save the page

Observed Result:
The references list appeared as a bulleted item or numbered item of the preceding list

Test Environment: http://en.wikipedia.beta.wmflabs.org/
Browser: Chrome Version 26.0.1410.65 
OS: MAC OS X 10. 8. 5 
Page:http://en.wikipedia.beta.wmflabs.org/wiki/30th_december?veaction=edit

See the screenshot attached

--------------------------
**Version**: unspecified
**Severity**: minor

**Attached**: {F12662}
I was able to reproduce this bug today and figured it was already reported earlier. My observation is pretty much the same as above.

{F4452302}
Eww, MW, why do we hate you so? This. This is why.
Created attachment 14193
In read mode

**Attached**: {F12663}
Steps to reproduce:

1.Open an article in read mode in two different tabs of same browser or in two different browsers.

2.Now edit the page using one browser or tab

3.Save the change

4.Now open the same article with VE using another browser or tab

5.Click on "cancel"

Observed Result:
After step 4 the change made in step 2 by another browser or tab are correctly reflected in the edit mode .

But after pressing cancel on step 5 , it has been observed that the readmode is still not showing the change done in step 2 unless user refreshes it.

It will be better if both Edit mode and Read mode shows consistent content even if the change is made by other user/browser session

Test Environment: http://en.wikipedia.beta.wmflabs.org/
Browser: Chrome Version 26.0.1410.65 & FF 25
OS: MAC OS X 10. 8. 5

--------------------------
**Version**: unspecified
**Severity**: minor
**Author:** `jhall`

**Description:**
After observing some strange results from an automated Ruby test for cursor movement in the Visual Editor CE surface, we did some digging, and it appears that while a user is typing away happily and making and edit, the document.activeElement flip-flop several times.  

I'm assuming this is unintentional behavior, thus the bug ticket.

Repro steps:

1)  Visit this page: https://test2.wikipedia.org/wiki/User:Selenium_user/cursor_test_page_chromedriver_bug
2)  Click into VE editing mode.
3)  With cursor placed immediately in front of the letter "a" in the word "after", press the right arrow key several times in succession. 
4)  When your right-arrow-clicking brings you to the reference, the document.activeElement switches from "ve-ce-documentNode ve-ce-branchNode noime" to "ve-ce-surface-paste"

I'm assuming that when the user is typing in the "editing box", the document.activeElement should not be changing.

--------------------------
**Version**: unspecified
**Severity**: major
**See Also**:
https://bugzilla.wikimedia.org/show_bug.cgi?id=57552
**jhall** wrote:

Java program used to generate the blow-by-blow in the previous attachment

**Attached**: {F12401}
**jhall** wrote:

Blow-by-blow of document.activeElement as right arrow key is pressed many times in succession

**Attached**: {F12400}
Steps to reproduce:

1.Open a page with VE in Chrome
2.Copy a hiero
3.Open another page in FF
4.Paste the hiero into it

Observed Result:
An empty template table appears.The resulting wikitext is:
{|

|
{|

|

|}

|}


Test Environment: http://en.wikipedia.beta.wmflabs.org/
Browser: Chrome Version 26.0.1410.65 & FF 25
OS: MAC OS X 10. 8. 5 
Page:http://en.wikipedia.beta.wmflabs.org/w/index.php?title=26th_paste_ff&veaction=edit

--------------------------
**Version**: unspecified
**Severity**: normal
WFM. Likely fixed at some point in the last two years.
Is this still occurring?
While doing hiero copy-paste from  a page opened in FF to another page in FF, the following wikitext appears:

{| class="mw-hiero-table mw-hiero-outer" dir="ltr"

|
{| class="mw-hiero-table"

|

|}

|}
Created attachment 14174
Screenshot in the edit mode

**Attached**: {F12372}
Gryllida suggests that VisualEditor have colorful icons.  Alternatively, the existing monochrome icons could be kept, but editors could be given the option of choosing a Microsoft-style "theme" to change the appearance of the icons.  

In addition to being fun, it is possible that other icon styles would improve accessibility for some users.

--------------------------
**Version**: unspecified
**Severity**: enhancement
I have enabled the experimental Media Viewer feature on Wikipedia, and when I click on an image, left and right scroll through the images on the page in full-window mode.

However, when editing a page in Visual Editor, this keeps happening (that is, images from the article keep appearing in full-window mode) when I am trying to move around with the cursor keys.

VisualEditor should disable this "feature", as it's obviously not wanted when editing a page!

I use the Chromium browser.

--------------------------
**Version**: unspecified
**Severity**: minor
**OS**: Linux
**Platform**: PC
**See Also**:
https://bugzilla.wikimedia.org/show_bug.cgi?id=58266
Yeah, I don't see why this would still have been an issue on December 22, there should be no way to get this issue to happen anymore.

If someone else sees this issue, speak up quick, but please be willing to discuss it with us relatively quickly, ideally on IRC, so we can nail it down.

Thanks!
This should have been fixed in Media Viewer with bug 58266 being closed (the code was deployed to all wikis on 12 December), but if you're still encountering it that's not good.

Does it still break in this manner? What happens if you refresh?
Intention:
Move a section of a page by cutting it out of one place and pasting it into the right place.

Steps to Reproduce:
1.  Close an unwanted browser tab.
2.  Select several paragraphs in VisualEditor.
3.  Press Command-x to cut (not just copy) the material.
4.  Notice that the just-closed browser window has reappeared.  (Command-z/Undo in Safari reopens a tab that you just closed.)



Reproducible: Always

I am unable to reproduce this in Firefox, presumably because selecting text within VisualEditor seems to clear (or otherwise make unavailable) the 'undo' buffer.  So even if VisualEditor is telling Firefox to undo something, Firefox believes that there there's nothing to undo.

--------------------------
**Version**: unspecified
**Severity**: normal
**See Also**:
https://bugzilla.wikimedia.org/show_bug.cgi?id=57217
Change 156776 merged by jenkins-bot:
Remove unnecessary execCommand('undo') from onCut

https://gerrit.wikimedia.org/r/156776
Change 156776 had a related patch set uploaded by Esanders:
Remove unnecessary execCommand('undo') from onCut

https://gerrit.wikimedia.org/r/156776
Change 156733 abandoned by Catrope:
Avoid undo when processing a cut event.

Reason:
Duplicate of https://gerrit.wikimedia.org/r/156593

https://gerrit.wikimedia.org/r/156733
Change 156593 restored by Catrope:
Avoid undo when processing a cut event.

Reason:
Whoops, obviously this isn't a duplicate of itself...

https://gerrit.wikimedia.org/r/156593
Change 156593 abandoned by Catrope:
Avoid undo when processing a cut event.

Reason:
Duplicate of https://gerrit.wikimedia.org/r/156593

https://gerrit.wikimedia.org/r/156593
Change 156733 had a related patch set uploaded by Catrope:
Avoid undo when processing a cut event.

https://gerrit.wikimedia.org/r/156733
Change 156593 had a related patch set uploaded by Catrope:
Avoid undo when processing a cut event.

https://gerrit.wikimedia.org/r/156593
**aditya** wrote:

Pushed a patch to gerrit. 

https://gerrit.wikimedia.org/r/#/c/156593/
**aditya** wrote:

Patch to prevent undo on cut

Here's a patch that avoids the 'undo' execCommand and fixes the issue for me in Chromium 36.0.1985.125 (Linux).

I'm assuming that the timeout was originally intended to let the code in that block be safely executed only after the browser manipulated (deleted) the selection. It appears that this no longer works and the code is processed before the text is actually deleted.

Therefore this change uses preventDefault() to not let the browser do it's thing, and directly handles the entire removal with a transaction.

This is my first patch to VE, sorry if I made any obvious mistakes. :)

**Attached**: {F12701}
Ick. This feels like a pretty poor browser bug here…
On opt-in wikis, users already have to explicitly choose to be able to use VisualEditor, and they get a warning the first time they do so. Adding beta suffixes all over the UI is a leftover from opt-out status and only appropriate in wikis that are opt-out, and where communities explicitly request such notices to be present.

--------------------------
**Version**: unspecified
**Severity**: normal
Change 112590 merged by jenkins-bot:
Disable 'beta' label in tab for the VE opt-in wiki (enwiki)

[[https://gerrit.wikimedia.org/r/112590]]
Change 112590 had a related patch set uploaded (by Jforrester):
Disable 'beta' label in tab for the VE opt-in wiki (enwiki)

[[https://gerrit.wikimedia.org/r/112590]]
Change 112590 had a related patch set uploaded by Jforrester:
Disable 'beta' label in tab for the VE opt-in wiki (enwiki)

https://gerrit.wikimedia.org/r/112590
These should probably only respond to click events although it seems they currently support the click and drag functionality of a drop down box. If you are editing a textarea in the right hand panel and you click and drag from right to left to select all the text you will often end up with your mouse over the outline widget. Releasing your mouse here will cause you to jump to a random page.

--------------------------
**Version**: unspecified
**Severity**: normal
Fixed by https://gerrit.wikimedia.org/r/#/c/133284/
When editing Wikipedia, I have repeatedly run into the following issue: 

The article contains a link and I want to change the beginning of the link text (not the link's target), usually because it is upper case and I want it lower case. So I use VisualEditor to delete the first letter of the link and replace it with its lower case version. The result is unexpected: the first letter is not marked up as part of the link, but this is very hard to see.

The source code is transformed from [[Link]] to l[[Link|ink]]. Links like the latter are almost never contained in human-created wikitext.

Suggestion: link text should be "magnetic", so that changes at either end will automatically inherit the link markup.

--------------------------
**Version**: unspecified
**Severity**: enhancement
With the new style of link editing, the problem I described above has gone away. So this can task can be closed.
@AxelBoldt, the style of link editing has been changed so that the whole link is highlighted.  This makes it easier to tell when you're addding something to the link.  Do you still think that this would be desirable?
VisualEditor is currently disabled as an editor in Flow:
  $wgFlowEditorList = array( 'none' );  // EXPERIMENTAL prepend 'visualeditor'

when we re-enable it, the VE bugs we discovered will probably still apply.

The WMF core features team plans the "VisualEditor integration" story in  Mingle card https://mingle.corp.wikimedia.org/projects/flow/cards/28

--------------------------
**Version**: master
**Severity**: minor
**bingle-admin** wrote:

The WMF core features team tracks this bug on Mingle card https://mingle.corp.wikimedia.org/projects/flow/cards/619, but people from the community are welcome to contribute here and in Gerrit.
After pasting a block of <syntaxhighlight> in to a target surface, I had to save and then reload the page before the syntax highlighting styling was applied. 

https://www.mediawiki.org/w/index.php?title=User:TheDJ/sandbox&oldid=841358

--------------------------
**Version**: unspecified
**Severity**: minor
**See Also**:
https://bugzilla.wikimedia.org/show_bug.cgi?id=67515
Change 311839 merged by jenkins-bot:
VE: Ensure ext.pygments module gets loaded when a user adds a syntax highlight node

[[https://gerrit.wikimedia.org/r/311839]]
Change 311839 had a related patch set uploaded (by Alex Monk):
VE: Ensure ext.pygments module gets loaded when a user adds a syntax highlight node

[[https://gerrit.wikimedia.org/r/311839]]
Still an issue.
Change 214078 merged by jenkins-bot:
Add VisualEditor support

[[https://gerrit.wikimedia.org/r/214078]]
Change 214078 had a related patch set uploaded (by Jforrester):
Add VE support for syntax highlighting

[[https://gerrit.wikimedia.org/r/214078]]
related: https://gerrit.wikimedia.org/r/#/c/162123/
With the dependency fixed, this just needs VisualEditor loading the appropriate modules defined by SyntaxHighlight (one for each language) at appropriate times.
Confirmed.
https://www.mediawiki.org/wiki/Manual:Code?veaction=edit

Copy one of the tables there. You get an error in fixupInsertion

[Error] TypeError: 'undefined' is not an object (evaluating 'source.clone')
	copy (load.php, line 94)
	getClonedElement (load.php, line 39)
	fixupInsertion (load.php, line 120)
	fixupInsertion (load.php, line 119)
	newFromDocumentInsertion (load.php, line 71)
	afterPaste (load.php, line 299)
	(anonymous function) (load.php, line 294)
	proxy (load.php, line 10)

This does not seem related to bug 58318. The table also doesn't render as it should in the original surface, with slugs above and below it inside the table. Possibly caused by the usage of templates for row construction.

--------------------------
**Version**: unspecified
**Severity**: normal
Fixed by gerrit 140439.
I'm not sure if this was done on purpose, but when selecting text containing some formatting in some or all of the selected text (e.g. part of a link and some text after it, or part of a bolded string) the toolbar shows the "Clear formatting" button highlighted (similarly to how the "Bold" icon is highlighted when selecting bolded text).

The toolbar is supposed to reflect current state of selected text. Showing the "Clear formatting" button already activated seems like an impossible state (it would theoretically mean some hypothetical "clear" annotation is applied to the selected text, which is incorrect. The only case in which that would technically be correct is if you apply text that is already cleared of formatting).

This highlighting for the "Clear formatting" button is confusing from a UX point of view. I would associate it with how "bold" is highlighted when bolding is applied.

When encountering this strange UX behaviour earlier today, it took me a while to figure out what it is supposed to mean (longer than it should for an intuitive editor). I don't think this is because I'm familiar with VisualEditor's previous state, but more in general.

I think the correct approach would be to never highlight the clear formatting button in the toolbar, and have it be an "apply" button, you select text, and then activate (not deactivate) "clear formatting".

This concept also exists in other popular editors.

Alternatively, though that would be a new concept for people to learn, perhaps change the icon to something that means the opposite of no formatting, so that it being turned on for selected text, and being able deactivate it, like it currently does, actually makes sense as an action take.

--------------------------
**Version**: unspecified
**Severity**: normal
That bit is now fixed too AFAICT.
This now happens again. If you:

1. Select an image
2. Click Bold. This bolds the caption (this is a separate bug)
3. Select something else, then select the image again (otherwise the clear formatting button doesn't get enabled)
3. Click Clear Formatting.
4. Observe that Clear Formatting is now depressed.

Obviously there are lots of other weird things going on, but it seems that the only way that Clear Formatting button manages to not be depressed is by assuming that it will always successfully clear all formatting and therefore be disabled next.
This was done in the changes to the toolbar.
Created attachment 14069
When using the link inspector, "Link" and "Clear formatting" are active

**Attached**: {F12008}
Created attachment 14068
Selecting text spanning across a link shows "Clear formatting" active

**Attached**: {F12007}
VisualEditor is currently not usable or well-tested in Flow. (Per feedback at http://ee-flow.wmflabs.org/w/index.php?title=Talk:Flow_bugs&workflow=050a7c69647ff00fc8b1fa163e68c4ac&action=view)

Please create a separate preference (opt-in/out) for the VisualEditor within Flow pages, so that editors who are happily using/testing VE, will still be able to use Flow.

--------------------------
**Version**: unspecified
**Severity**: normal
Experimental VE has been pulled from Flow for awhile - should be revisited once we properly reimplement VE
**bingle-admin** wrote:

The WMF core features team tracks this bug on Mingle card https://mingle.corp.wikimedia.org/projects/flow/cards/573, but people from the community are welcome to contribute here and in Gerrit.
Though bug 52105 covers Wikidata-bourne language link editing, there are cases where local language link editing is still needed:

* for Wikimedia wikis not (yet) hooked into Wikidata;
* for Wikimedia wikis which cannot (yet) be hooked into Wikidata (e.g. [[en:Maggie Simpson]] vs. [[de:Die Simpsons (Familie)#Maggie Simpson]]); and 
* for MediaWiki installs without a Wikibase server (almost all third party users).

--------------------------
**Version**: unspecified
**Severity**: enhancement
**See Also**:
https://bugzilla.wikimedia.org/show_bug.cgi?id=52105
**Author:** `vladjohn2013`

**Description:**
Global, better URL to citation conversion functionality

Suppose, in Wikipedia, all that needed to be done to generate a perfect citation was to provide a URL? That would be a tremendous step toward getting a much higher percentage of text in Wikipedia articles to be supported by inline citations.

There are already expanders (for the English Wikipedia, at least) that will convert an ISBN, DOI, or PMID, supplied by an editor, into a full, correct citation (footnote). These are in the process of being incorporated into the reference dialog of the VisualEditor extension, making it almost trivial (two clicks, paste, two clicks) to insert a reference.

For web pages, however, the existing functionality seems to be limited to a Firefox add-on. Its limits, besides the obvious requirement to use that browser (and to install the add-on), include an inability to extract the author and date from even the most standard pages (e.g., New York Times), and the lack of integration with MediaWiki.

For a similar approach, using a different plug-in/program, see this Wikipedia page about Zotero.

A full URL-to-citation engine would use the existing Cite4Wiki (Firefox add-on) code, perhaps, plus (unless these exist elsewhere) source-specific parameter specifications. For example, the NYT uses "<meta name="author" content="NICK BILTON" />" for its author information; that format would be known by the engine (via a specifications database). Each Wikipedia community would be responsible for coding these (except for a small starter set, as examples), in the way that communities are responsible for TemplateData for the new VisualEditor extension.

(Project idea suggested by John Broughton.)

URL:https://www.mediawiki.org/wiki/Mentorship_programs/Possible_projects#Global.2C_better_URL_to_citation_conversion_functionality

--------------------------
**Version**: unspecified
**Severity**: enhancement
Resolving, then. Check #Citoid for details.
This is being addressed by [[ https://www.mediawiki.org/wiki/Citoid | Citoid ]]
John- thank you for the links, they were very helpful!

The project for an engine to provide citations to VE was approved for the May 2014 round for OPW. Extension is tentatively called https://www.mediawiki.org/wiki/Extension:CiteURLEngine although I'm not set on the name. 

Since you mention NYTimes, they're proving to be quite problematic because they treat scrapers as logged out users (so scrapers get redirected to a log-in page), and they've also disallowed caching by Google so you can't use the cached page as a back-up solution. If anyone has any ideas let me know!
Marielle - I'd be happy to work with you on nailing down the specs, and I'd also be happy to assist with QA (testing). If you do decide to create a bot to clean up naked urls in references/citations, I can also assist you with getting permission to run the bot at en.wikipedia.org (per [[WP:BOTREQ]]). 

However, I can't offer technical assistance - it's been far too many years since I did programming, in languages that aren't particularly useful today.

Finally, I note that the list of existing tools, at https://www.mediawiki.org/wiki/Improving_URL_citations_on_WikiMedia_(OPW_Project) , omits a significant number of things.  

See https://en.wikipedia.org/wiki/Help:Citation_tools for a more comprehensive list, and also see https://en.wikipedia.org/wiki/Wikipedia:EIW#Citetools .
Hi,

This project was listed as a possible project for the FOSS Outreach Program for Women and I'd very much like to work on it.

I've written a very rough proposal here: https://www.mediawiki.org/wiki/Improving_URL_citations_on_WikiMedia_(OPW_Project)

However, I would need a mentor to help nail down the specs of the project and then oversee it. I don't to step on anyone's toes regarding the project Erik mentioned (a WMF web service to provide citations to both the visual editor and the wikitext editor)- it sounds like some of what I proposed might replicate that. I'd be happy to work on this from that angle as well but I'm not sure what other people have done already.

Is there anyone on this thread that could mentor such a project? Thanks!

-Marielle
We are, in fact, investigating this in the context of VisualEditor, specifically the possibility of setting up a WMF web service for this that can be used by VisualEditor and wikitext editors alike to quickly generate citations. It'd be ideal to be able to share code with Zotero which has a comprehensive suite of URL-to-citation translators already.
**vladjohn2013** wrote:

This proposal has been listed at https://www.mediawiki.org/wiki/Mentorship_programs/Possible_projects and we are filing a report to gather community feedback and share updates.
Intention:
Add a category to a page

Steps to Reproduce:
1. Open the page in VisualEditor and choose the categories tool.
2. Type the full name of the category, including the namespace:  Category:Example


Actual Results:  
VisualEditor adds a non-existent, malformed category named [[Category:Category:Example]].

Expected Results:  
That VisualEditor would recognize that "Category:Example" already contained the namespace, and thus omit the duplication.  Ideally, at non-English wikis, it would recognize and remove both the local name for the namespace and the English name, since both are typically valid (e.g., strip out both "Kategorie" and "Category" at the German Wikipedia).

Reproducible: Always

--------------------------
**Version**: unspecified
**Severity**: enhancement
Also there's the problem of either (a) only doing this hack for English, or (b) having to hold in VE a copy of all of the translations of Category:, and know which one to remove when (removing Catégorie: on French, but not on English, and so on).
(In reply to comment #4)
> Do any [[Category:Category:Foo]] pages exist?  I haven't seen one.

On all ten million MediaWiki wikis out there? Quite probably…

J.
Do any [[Category:Category:Foo]] pages exist?  I haven't seen one.
There is [[Category:Category theory]], it might be worth checking as a corner case.
What to do when there's a category called "Category:Foo" and another called "Foo". Do we strip or not?
[new feature or "nice-to-have" => severity=enhancement]
Intention:
The wikitext warning says:

"Click "Edit source" to edit the page in wikitext mode – unsaved changes will be lost."

This need to be changed to reference the new ability to switch to the source editor without losing unsaved changes, at least (currently) for non-Firefox users.




Reproducible: Always

--------------------------
**Version**: unspecified
**Severity**: trivial
**See Also**:
https://bugzilla.wikimedia.org/show_bug.cgi?id=57699
Change 133637 merged by jenkins-bot:
Update wikitext-warning to refer to 'Switch to source editing'

https://gerrit.wikimedia.org/r/133637
I uploaded Gerrit change 133637 for this
Intention:
When you open VisualEditor for the first time, you get a message that says you can switch to wikitext, but that unsaved changes will be lost:

"You can keep using the wikitext editor by clicking the "Edit source" tab instead – unsaved changes will be lost."

This is not always true, since (currently for non-Firefox users) it is possible to switch to wikitext using the new menu item without losing any changes.




Reproducible: Always

--------------------------
**Version**: unspecified
**Severity**: enhancement
**See Also**:
https://bugzilla.wikimedia.org/show_bug.cgi?id=57462
https://bugzilla.wikimedia.org/show_bug.cgi?id=57700
Change 133639 merged by jenkins-bot:
Update beta warning to refer to 'Switch to source editing'

https://gerrit.wikimedia.org/r/133639
I uploaded Gerrit change 133639 for this
The switch option appears to be currently working for IPs as well.
(Actually, it's still broken for IPs.)
(BTW the switch option is now working with any browser AFAIK, or at least it is with FF.)
Any message of the interface can be changed locally in the MediaWiki namespace, so anybody can fix that. But the message only refers to the Edit source main tab, so it is always true that if you click that your changes will be lost.
Pretty much what the title says.
James thinks this might eventually be done at some point, so this is a reminder.

--------------------------
**Version**: unspecified
**Severity**: enhancement
Currently:

* byteLimit() will internally do all kinds of event binding to get notice of changes.
* We have our own 'change' callback for InputWidget elements.
* in mw.ViewPageTarget we use our 'change' event, our own getValue, manually run it through byteLength (not byteLimit), in order to get the current length that we assume byteLimit got to as well.
* When the length is exceeded by user input, byteLImit internally will start chopping off characters (or rather, cancel user events after it hit the limit, and falls back to chopping off characters until it fits again).

Problems:
* Mimics the change event.
* Duplicates logic for byteLength outside byteLimit, this will fail if the logic changes, and already fails if the byteLimit has a filter callback.

Ideally: byteLimit (standalone)
* Its own on('change') - so we don't have to mimic it
* Ability to retrieve byte length as perceived by byteLimit - so we don't have to reverse engineer it
* Option to disable the chopping off (instead, more like Twitter where the underlying user interface element will allow new characters, but it will have an event like 'length-exceeded' and 'length-satisfied' or 'length-recovered' so we dan display a nicer user interface (e.g. make the number negative and red)


or:

Ideally: byteLimit (utility mixin)
* Option to feed it change events instead of having it listen on its own.
* Get back from each event – the current state (length exceeded or not, and what the length is, having taken the filter in account).

--------------------------
**Version**: unspecified
**Severity**: enhancement
Some Wikipedias have hooks for the source editor that process the wikitext before it is saved. The only thing to currently do this for the Visual Editor seems to be to hook in the 'wikipage.content' event and do an API edit that processes the text as intended.

Instead, the visual editor should offer a different event, such as visualeditor.beforesave, that would allow such processing to take place when saving the content.

--------------------------
**Version**: unspecified
**Severity**: enhancement
Re-evaluating – if you want a client-side hook, this is a WONTFIX (both for specific reasons to this bug to do with catastrophic performance hits, and also because events are not a sane way to go).

If you want a VE-specific server-side (PHP) hook on wikitext save, we could do that more reasonably (as MediaWiki's too far down that road to pull back).
Ideally, there would be an event for each of these stages :) 

Realistically, in order to reuse existing code, the best time would probably be when the Wikitext is ready to be saved (since that would be the equivalent for pressing the "Save" button). Of course, the callback needs to be able to give the modified wikitext back to VE.
What stage of the save do you want? 

* HTML is ready to be saved
* HTML is converted to wikitext
* Wikitext is back from Parsoid and is ready to be saved
* VE just sent the wikitext to MW API
* VE just got the confirmation token back from MW API
* …
When a user clicks on Switch to source editing option from the settings drop down it tells user that switching to source editing will keep the changes made in the document.But if a user attempts to switch from the tab it does not retain those changes.This seemed confusing to me because when user uses the "switch to source editing" , the "Edit Source" tab is selected ,indicating the same destination for both action.

If a user can switch to source editing in multiple ways, i think it is better both ways have similar mechanism of handling the changes to have uniform experience.
Specially when switching from tab is one click away compared to the "[]switch to source editing" option.

--------------------------
**Version**: unspecified
**Severity**: enhancement
**See Also**:
https://bugzilla.wikimedia.org/show_bug.cgi?id=57699
https://bugzilla.wikimedia.org/show_bug.cgi?id=42141
Verified the fix in production
Verified the fix in test2
Verified the fix in Betalabs
Change 143203 merged by jenkins-bot:
Don't offer to retain changes when switching to wikitext editor by tab if no changes have been made

https://gerrit.wikimedia.org/r/143203
Change 143203 had a related patch set uploaded by Alex Monk:
Don't offer to retain changes when switching to wikitext editor by tab if no changes have been made.

https://gerrit.wikimedia.org/r/143203
Change 142064 merged by jenkins-bot:
Offer to retain changes when switching to the wikitext editor

https://gerrit.wikimedia.org/r/142064
Change 142064 had a related patch set uploaded by Alex Monk:
Offer to retain changes when switching to the wikitext editor

https://gerrit.wikimedia.org/r/142064
I personally think that this bug report is a duplicate of bug 42141.
This is possible, but would be ugly, because we'd need to replace the existing two-choice option (switch or don't switch) with a custom three-choice one (switch and keep changes, switch without changes, don't switch)… Maybe.
[Removing "[Suggestion]" from summary; setting severity field to "enhancement" instead]
Created attachment 13890
Inside Edit Source tab

**Attached**: {F12699}
Repro:

1. Create a page with text below:

<math>
\begin{matrix}
x & y \\
z & v
\end{matrix}
</math>

2. Default rendering, in PHP parser and Parsoid (VE initial state):

x y
z v

3. VE edit this matrix, change v to uv.

4. Edited block becomes:

x amp; y
z amp; uv

(After saving it works fine)

--------------------------
**Version**: unspecified
**Severity**: minor
**See Also**:
https://bugzilla.wikimedia.org/show_bug.cgi?id=54577
Thanks Bartosz!
Should be fixed.

Like in wikitext, it will now be impossible to input '</tag>' in the inspector in VisualEditor: it will be converted to '&lt;/tag>' when the inspector is closed.
Change 144158 merged by jenkins-bot:
ve.ce.MWExtensionNode: Don't escape content of wikitext tags on preview

https://gerrit.wikimedia.org/r/144158
Change 144157 merged by jenkins-bot:
ve.ui.MWExtensionInspector: Prevent from setting impossible content

https://gerrit.wikimedia.org/r/144157
Change 144158 had a related patch set uploaded by Bartosz Dziewoński:
ve.ce.MWExtensionNode: Don't escape content of wikitext tags on preview

https://gerrit.wikimedia.org/r/144158
Change 144157 had a related patch set uploaded by Bartosz Dziewoński:
ve.ui.MWExtensionInspector: Prevent from setting impossible content

https://gerrit.wikimedia.org/r/144157
Just for "fun", some informative examples that show what happens when you try too hard with {{#tag:}}. Two of these actually cause UNIQ markers to appear in output, which is rather bad in general. The behavior may differ depending on the tag used.


<syntaxhighlight lang=php>$a;</syntaxhighlight>

<syntaxhighlight lang=php></syntaxhighlight></syntaxhighlight>

<syntaxhighlight lang=php>&lt;/syntaxhighlight></syntaxhighlight>

{{#tag:syntaxhighlight|</syntaxhighlight>|lang=php}}

<syntaxhighlight lang=php><syntaxhighlight lang=php>$a;</syntaxhighlight></syntaxhighlight>

{{#tag:syntaxhighlight|<syntaxhighlight lang=php>$a;</syntaxhighlight>|lang=php}}

{{#tag:syntaxhighlight|&lt;syntaxhighlight lang=php>$a;</syntaxhighlight>|lang=php}}

{{#tag:syntaxhighlight|<nowiki><syntaxhighlight lang=php>$a;</syntaxhighlight></nowiki>|lang=php}}
Basically, ve.ce.MWExtensionNode.prototype.generateContents builds an XML element object for given tag name (for example 'math'), given attributes (none in this case) and given contents (for example 'a < b'), and then serializes it to a string to ensure that everything is correctly escaped.

The problem is that MediaWiki XML-like tags don't expect their contents to be escaped. Serializing such a node generates "<math>a &lt; b</math>", while wikitext expects "<math>a < b</math>".

(An interesting corollary is that a MediaWiki XML-like tag 'foo' may not contain the string '</foo>' in any form nor encoded in any way, unless the code of the extension handling the tag specifically parses nested <nowiki/> tags or something. You can cheat – {{#tag:foo|</foo>}} – but then you still can't include the string '<foo></foo>' because it gets double-parsed.)

(Fun fact: the above behavior is the reason why <source/> was renamed to <syntaxhighlight/> some years ago.)

We should not escape the contents at all and instead do something clever if the input text contains '</foo>'. VE and wikitext are both designed to never disallow the user from doing stupid things, so I'm not sure what can be done if we don't just prevent the user from saving that. Maybe selectively HTML-escape /<\/\s*foo\s*>/ when closing the inspector?
*** Bug 60332 has been marked as a duplicate of this bug. ***
This problem is actually common for everything that uses MWExtensionNode. The problem is that ve.ce.MWExtensionNode.prototype.generateContents makes some bold assumptions about wikitext syntax that are not true.

The fix from bug 54577 didn't actually fix much, it just changed what the problem is.
*** Bug 60113 has been marked as a duplicate of this bug. ***
**Author:** `raincity471`

**Description:**
Reproducible: Didn't try

--------------------------
**Version**: unspecified
**Severity**: minor
I'm not sure it's worth trying to explain this minor and not-hugely-useful feature. I think it would just add to the confusion.

Remember that this is the first ever interface users will see when using VisualEditor – it's important that we don't over-load them with too much information, or that we drown out the important information for them to learn by hiding it amongst a sea of less-important and un-important information.

WONTFIXing.
**raincity471** wrote:

Screenshot of the intro screen with affected sentence highlighted

Outdated sentence circled in red.
Screenshot saved ‎22 ‎November ‎2013, ‏‎13:37:15 (UTC) after a bit of editing in the GIMP. VE beta 0.1.0 running MediaWiki 1.23wmf4 (c066033), Firefox 25.0 in private mode (so no copyright problems with addons).
Firefox 25 is licensed under the Mozilla Public License 2.0. VisualEditor is licensed under the Massachusetts Institute of Technology license. MediaWiki is licensed under the GNU GPL version 2 or later.

**Attached**: {F12597}
**raincity471** wrote:

A new feature has been added to VisualEditor which allows editors to switch from VE to wikitext editing without losing their changes (see Bug 50687). The VE intro dialogue (shown to users the first time they open VE) still says you may switch from VE to "edit source" using the tab at the top and that changes will be lost. The new feature should be mentioned, maybe something like:

"You can keep using the wikitext editor by clicking the options button (three horizontal lines next to the cancel button) in the top-right corner and then "switch to source editing". Unsaved changes will not be lost."
Reproducible: Always

Fram reports that when you try to VEdit pages like
https://en.wikipedia.org/wiki/List_of_top_100_Major_League_Baseball_strikeout_pitchers
https://en.wikipedia.org/wiki/List_of_Major_League_Baseball_players_with_2,500_games_played
or https://en.wikipedia.org/wiki/List_of_top_300_Major_League_Baseball_home_run_hitters ,
what you get is not exactly what you saw :) (see the tables and the following sections.)

Ssastry furtherly diagnosticated: "Looks like some VE-clientside rendering issues with empty spans between multiple floating tables."
Doesn't look specific to a browser or skin.

--------------------------
**Version**: unspecified
**Severity**: minor
**See Also**:
https://bugzilla.wikimedia.org/show_bug.cgi?id=65249
We would like to have VisualEditor enabled on some part of svwiktionary.

Suggested namespace: User namespace.

Rationale:

We're doing a proof-reading project[1] where we'll need to do lots of style edits (mainly update italics and bold).

The idea is to extract useful information from the dictionary/thesaurus "Ord för ord"[2] and create new entries and improve existing ones using the information.


[1] https://sv.wiktionary.org/wiki/Wiktionary:Projekt/Ord_f%C3%B6r_ord
[2] http://runeberg.org/ordforord/

--------------------------
**Version**: wmf-deployment
**Severity**: enhancement
This should now be fixed; sorry for the mis-configuration.
Change 98871 merged by jenkins-bot:
Disable VisualEditor in content namespaces on svwiktionary

https://gerrit.wikimedia.org/r/98871
Change 98871 had a related patch set uploaded by Jforrester:
Disable VisualEditor in content namespaces on svwiktionary

https://gerrit.wikimedia.org/r/98871
(In reply to comment #9)
> I noticed that it's enabled in the main namespace too, but that doesn't make
> sense. We use lots of templates and very well-defined lists that just don't
> work well with VisualEditor.
> 
> Can you please disable it for the main namespace?

Hmm, that's odd; it's configured for just the User namespace, per this bug – will investigate why it's working elsewhere too.

> If possible, you could enable it for the project namespace instead (but not
> on pages with __NEWSECTIONLINK__).

Not sanely possible - we don't enable VisualEditor on pages which are signed, as that's what Flow is for, and too much of the project namespace is randomly signed (even with an expensive check for __NEWSECTIONLINK__), sorry. :-(
I noticed that it's enabled in the main namespace too, but that doesn't make sense. We use lots of templates and very well-defined lists that just don't work well with VisualEditor.

Can you please disable it for the main namespace?

If possible, you could enable it for the project namespace instead (but not on pages with __NEWSECTIONLINK__).
This is now live - you can opt in to test VisualEditor using the Beta Features link in your personal tools at the top of the page, or through the Preferences link in the "Beta Features" tab.

If there are any issues, please shout!
Change 97711 merged by jenkins-bot:
Enable VisualEditor as opt-in on svwiktionary

https://gerrit.wikimedia.org/r/97711
Change 97711 had a related patch set uploaded by Jforrester:
Enable VisualEditor as opt-in on svwikitionary

https://gerrit.wikimedia.org/r/97711
Sorry for the slow reply – we can do this if wanted.

Just user namespace is entirely possible if that's what you want.

Will do a patch now.
I was just providing info about what's written in public; James and the VE development team has the final word and is free to change plans. :)
I was thinking that it might be possible to enable it on svwiktionary earlier, since I thought it would be low-risk to enable it for the user namespace only, not adding any new requirements.

Anyway, I take that as a "no" in the short-term (this year).
https://www.mediawiki.org/wiki/VisualEditor#Timeline says "VisualEditor may be offered to users at non-Wikipedia projects, such as Commons or Wiktionary, after deployment to the Wikipedias has completed. No timeline has been set for this."
Thank you for your interest in Visual Editor.

[ Adding James Forrester and Trevor Pascal as CC to get feedback on this matter. ]
When a long string (24 characters or more) gets added in the link tool (a typical long URL, or a just a long article title), the external and internal link options get shortened with "..." in the middle. This can make it hard to know whether you put in the right string or not, and there doesn't seem to be much downside to displaying the full link targets for at least moderately longer strings.

--------------------------
**Version**: unspecified
**Severity**: minor
**See Also**:
https://bugzilla.wikimedia.org/show_bug.cgi?id=69574
(In reply to comment #0)
> When a long string (24 characters or more) gets added in the link tool (a
> typical long URL, or a just a long article title), the external and internal
> link options get shortened with "..." in the middle. This can make it hard to
> know whether you put in the right string or not, and there doesn't seem to be
> much downside to displaying the full link targets for at least moderately
> longer strings.

The downside is that the link needs to fit on the screen for the user to read it. :-)

I'm not happy with the idea of a hugely-wide search results pane masking much of the screen unnecessarily, but I also think that expanding and contracting as needed could be a bit of an eyesore…
On this page [1], the "Open questions" section ends with a line that has starts with <s> but later has another <s> instead of </s>. The strikethrough ends with the second tag anyway, when the page is being viewed normally. With VisualEditor, however, the strikethrough formatting continues to the end of the page.

[1] = https://www.mediawiki.org/w/index.php?title=Wikipedia_Education_Program&oldid=821826

--------------------------
**Version**: unspecified
**Severity**: normal
Tidy is going away and RemexHTML will be used on all wikis sometime mid next year. In that context, all these pages will look broken in RemexHTML as well and the relevant broken markup on these pages has to be fixed. We have added [[https://www.mediawiki.org/wiki/Help:Extension:Linter/multiple-unclosed-formatting-tags|a special linter category to aid that effort. ]]
(Tracking bug for Tidy being a piece of junk is bug 2542, by the way.)
This comment is basically a +1/me too. The same issue exhibits on https://en.wikipedia.org/w/index.php?title=Actor_model&oldid=602988700 but with a <tt> rather than a <s>. After some discussion with thedj on IRC he suggested I'd file here anyway, if only to indicate it might be somewhat prevalent in the wild.

Personally, I think this is a bug in tidy rather than in VE, and the most reasonable behaviour would be for tidy to conform to prevalent browser behaviour/the HTML spec, and to emit a warning about the likely location of the breakage (where tidy now closes the element)
This is a difference between tidy used by MediaWiki in production and the HTML5 spec. Tidy closes unclosed formatting elements eagerly, while the HTML5 spec demands that formatting elements are restored in most cases.

We are considering to prevent formatting elements from bleeding out of transclusions (see bug 50536) for reasons of correctness and performance, but so far we don't have plans to generally move away from HTML5-compliant (and MediaWiki without tidy) behavior for this.

We can detect unclosed tags and provide information for fix-ups in the wikitext though. That is partly tracked in bug 50547. I thought that we had another bug for this, but don't currently find it. Will add a link to bug 50547 when I find it.
Also, when I removed the entire section that included the offending strikethrough tags, the VE still showed strikethrough on the remainder of the page.

When I open it again in VE after the edit [1], it appears as expected.

[1] = https://www.mediawiki.org/w/index.php?title=Wikipedia_Education_Program&diff=821838&oldid=821826
Checkbox flag, redirect pages only.

--------------------------
**Version**: unspecified
**Severity**: enhancement
Verified the fix in test2
Change 95213 merged by jenkins-bot:
Let users set #REDIRECT and __STATICREDIRECT__ status

https://gerrit.wikimedia.org/r/95213
Change 95213 had a related patch set uploaded by Jforrester:
Let users set #REDIRECT and __STATICREDIRECT__ status

https://gerrit.wikimedia.org/r/95213
Checkbox flag, pages on variant wikis only.

--------------------------
**Version**: unspecified
**Severity**: enhancement
Change 126015 merged by jenkins-bot:
Add checkboxes to set some metadata on page metadata panel

https://gerrit.wikimedia.org/r/126015
Change 126015 had a related patch set uploaded by Alex Monk:
Add checkboxes to set some metadata on page metadata panel

https://gerrit.wikimedia.org/r/126015
Change 95726 had a related patch set uploaded by Jforrester:
[WIP] Create remaining meta items in DM

https://gerrit.wikimedia.org/r/95726
Checkbox flag, pages on variant wikis only.

--------------------------
**Version**: unspecified
**Severity**: enhancement
Change 126015 merged by jenkins-bot:
Add checkboxes to set some metadata on page metadata panel

https://gerrit.wikimedia.org/r/126015
Change 126015 had a related patch set uploaded by Alex Monk:
Add checkboxes to set some metadata on page metadata panel

https://gerrit.wikimedia.org/r/126015
Change 95726 had a related patch set uploaded by Jforrester:
[WIP] Create remaining meta items in DM

https://gerrit.wikimedia.org/r/95726
Checkbox flag, category namespace only.

--------------------------
**Version**: unspecified
**Severity**: enhancement
Change 126015 merged by jenkins-bot:
Add checkboxes to set some metadata on page metadata panel

https://gerrit.wikimedia.org/r/126015
Change 126015 had a related patch set uploaded by Alex Monk:
Add checkboxes to set some metadata on page metadata panel

https://gerrit.wikimedia.org/r/126015
Change 95726 had a related patch set uploaded by Jforrester:
[WIP] Create remaining meta items in DM

https://gerrit.wikimedia.org/r/95726
Trinary state (default, NEWEDITSECTION, NONEWEDITSECTION), all pages.

--------------------------
**Version**: unspecified
**Severity**: enhancement
Verified the fix in test2
Change 95725 merged by jenkins-bot:
Let users set __NEWEDITSECTION__ & __NONEWEDITSECTION__ status

https://gerrit.wikimedia.org/r/95725
Change 95725 had a related patch set uploaded by Jforrester:
Let users set __NEWEDITSECTION__ & __NONEWEDITSECTION__ status

https://gerrit.wikimedia.org/r/95725
Change 95725 had a related patch set uploaded by Jforrester:
Let users set __NEWEDITSECTION__ & __NONEWEDITSECTION__ status

https://gerrit.wikimedia.org/r/95725
Trinary state (default, INDEX, NOINDEX), all pages.

--------------------------
**Version**: unspecified
**Severity**: enhancement
Change 95724 merged by jenkins-bot:
Let users set __NOINDEX__ & __INDEX__ status

https://gerrit.wikimedia.org/r/95724
Change 95724 had a related patch set uploaded by Jforrester:
Let users set __NOINDEX__ & __INDEX__ status

https://gerrit.wikimedia.org/r/95724
Change 95724 had a related patch set uploaded by Jforrester:
Let users set __NOINDEX__ & __INDEX__ status

https://gerrit.wikimedia.org/r/95724
Checkbox flag on/off, all pages.

--------------------------
**Version**: unspecified
**Severity**: enhancement
Change 95723 had a related patch set uploaded by Jforrester:
Let users set __NOEDITSECTION__ status

https://gerrit.wikimedia.org/r/95723
**Author:** `anjana1`

**Description:**
OS: Win 8
Browser: Fire Fox 24 and Chrome 31.0

Not able to insert an image in VE mode on Beta. The image (A nice pic.jpg) which is on commons is not seen in the list while trying to upload it using the "Media" in the toolbar (found in "More" pulldown menu)in "Edit Beta mode".

The same image is uploadable using wikitext syntax [[File:A Nice pic.jpg]].

--------------------------
**Version**: unspecified
**Severity**: normal
**Whiteboard**: cirrus-fixed
This is fixed in Cirrus as far as I know. Inclined to WONTFIX for lsearchd as a result.
Re-titling this and putting back into the Wikimedia / Search area, as that's where the issue lies; I believe that the new search system fixes this issue, but will leave it for the experts to opine.
**anjana1** wrote:

Steps to reproduce:

Pre-requisites: Create an account in http://en.wikipedia.beta.wmflabs.org

1. Login with username and password into http://en.wikipedia.beta.wmflabs.org/wiki/User:<username>
2. On the topmost right-hand side of the page, click on "preferences"
3. Click on the "Beta Features" tab and select "VisualEditor"
4. Click on "Save" at the end of the page. You must see a message saying "Your preferences have been changed".
5. Click on <your username>. Your username will be found on the topmost right-hand side of the page.
6. Click on "Edit beta" , found on the top right-hand side next to "Edit Source".
7. On the toolbar, click on "More" pull-down menu and click on "Media"
8. Search for "A nice picture.jpg". [Here, we are looking for an image of "cave 26,ajanta caves"]
9. The intended image is not found.


But, this can be found with wikitext i.e, without VisualEditor.
1. Click on "Edit Source"
2. Type [[File:A nice picture.jpg]] on the page.
3. Click on "Save Page" tab at the bottom of the page.
4. Result: You will be able to see the intended image.
Thanks for taking the time to report this!

Could you please provide exact steps, click by click, to reproduce the problem, so anybody else could follow these steps and get the same results?
Reported by Mattho69 on frwiki [1].

If I try to add a link to a Wikipedia article using its full form (http://fr.wikipedia/org/wiki/…), it is saved as an interwiki (see [2]) instead of a local wikilink. 

I notice that it only happens with HTTP links, not with HTTPS ones (see [3]), which are not converted (maybe separate bug ?).

[1] https://fr.wikipedia.org/wiki/Wikip%C3%A9dia:%C3%89diteurVisuel/Avis#:fr:
[2] https://fr.wikipedia.org/w/index.php?title=Utilisateur:Ltrlg/tests&diff=98243431&oldid=98197987
[3] https://fr.wikipedia.org/w/index.php?title=Utilisateur:Ltrlg/tests&diff=98243523&oldid=98243431

--------------------------
**Version**: unspecified
**Severity**: enhancement
**See Also**:
https://bugzilla.wikimedia.org/show_bug.cgi?id=45209
https://bugzilla.wikimedia.org/show_bug.cgi?id=61672
*** This bug has been marked as a duplicate of bug 42986 ***
When adding parameters of some templates like this:
https://cs.wikipedia.org/wiki/%C5%A0ablona:Citace_elektronick%C3%A9_monografie
 it sais "unknown parametr" even the parametr is valid and works afterwords. 

This information is confusing.

--------------------------
**Version**: unspecified
**Severity**: trivial
Right now, manually adding a parameter that's not described by TemplateData shows a message saying that the parameter is "unknown", which is a little odd if it then seems to work.
What would be the exact steps to follow in order to reproduce this problem?
Steps to reproduce:
1. Find a page that already has a category
2. Edit in VE, and add a category
3. Review changes

Expected results:
The diff is
```
+**[[Category:New cat]]**
```

Actual results:
The diff is
```
-[[Category:Old cat]]
+[[Category:Old cat**]][[Category:New cat**]]
```
With the chunk between the stars viewed as added.

This also happens in the source editor, but it is less common that people will append a category to an existing category as that is against all style guidelines.  However the Visual Editor is doing just that.

--------------------------
**Version**: 1.23.0
**Severity**: normal
Checkboxes (disabled for some/most namespaces), setting:

__NEWSECTIONLINK__
  <meta property="mw:PageProp/newsectionlink">

__NONEWSECTIONLINK__
  <meta property="mw:PageProp/nonewsectionlink">

__NOGALLERY__
  <meta property="mw:PageProp/nogallery">

__HIDDENCAT__
  <meta property="mw:PageProp/hiddencat">

__NOCONTENTCONVERT__
  <meta property="mw:PageProp/nocontentconvert">

__NOCC__
  <meta property="mw:PageProp/nocc">

__NOTITLECONVERT__
  <meta property="mw:PageProp/notitleconvert">

__NOTC__
  <meta property="mw:PageProp/notitleconvert">

__NOEDITSECTION__
  <meta property="mw:PageProp/noeditsection">

__NOINDEX__
  <meta property="mw:PageProp/noindex">

__INDEX__
  <meta property="mw:PageProp/index">

__STATICREDIRECT__
  <meta property="mw:PageProp/staticredirect">

… and possibly others.

--------------------------
**Version**: unspecified
**Severity**: enhancement
Split out as bug 57166 ++
Similar to bug 56867 comment 1 I think these would be better handled as pairs of radio buttons, e.g.

Show this category on member pages: * Yes * No
Show a gallery of images in this category: * Yes * No
Show a new section link in the tab par for this page: * Yes * No
Allow search engines to index this page: * Yes * No

Defaults would be set per namespace as at present.
A checkbox, greyed out when there are more than 2 headings(?), setting:

  <meta property="mw:PageProp/forcetoc">

--------------------------
**Version**: unspecified
**Severity**: enhancement
Change 95103 merged by jenkins-bot:
Let users set __NOTOC__ & __FORCETOC__ status

https://gerrit.wikimedia.org/r/95103
Change 95103 had a related patch set uploaded by Jforrester:
[WIP] Let users set #REDIRECT, __NOTOC__, & __FORCETOC__

https://gerrit.wikimedia.org/r/95103
Perhaps better than this and bug 56866 would be a radio button/dropdown with three options for TOC:
Include an automatic table of contents on this page:
* Never
* When there are three or more headings (default)
* Always

If different wikis (can) have different settings for the number of headings before a TOC then the middle option will need to read that setting.

I say "automatic" above as manual TOC templates such as [[template:Compact ToC]] should always override this setting.
PageTriage UI editing User page

seen on beta enwiki:

* log in as a user with PageTriage privileges e.g. Selenium_user
* visit http://en.wikipedia.beta.wmflabs.org/wiki/Special:NewPagesFeed
* visit your user page

PageTriage UI appears

PageTriage UI should not appear on User pages
PageTriage UI should not appear in the editor

see screen shot

--------------------------
**Version**: unspecified
**Severity**: minor

**Attached**: {F12047}
Change 133379 merged by jenkins-bot:
Hide PageTriage curation toolbar while VE is open

https://gerrit.wikimedia.org/r/133379
Change 133379 had a related patch set uploaded by Alex Monk:
Hide PageTriage curation toolbar while VE is open

https://gerrit.wikimedia.org/r/133379
I don't believe I logged a bug against PageTriage at the time.
(In reply to Chris McMahon from comment #0)
> PageTriage UI should not appear on User pages

Was a bug logged against PageTriage for that?
I visited a Flow page in IE8, which is 8% of WMF audience according to https://www.mediawiki.org/wiki/VisualEditor/Target_browser_matrix (and more elsewhere I think).

Screenshot https://saucelabs.com/jobs/2a2680aeb681420381a5652ddf5fdca2/0001screenshot.png?auth=fc4f7362b9615cfceee0744b0f4bc93a

There are issues with Flow's local Agora CSS override in IE8:
* Gray backgrounds on secondary buttons (they should appear without any button border).
* Buttons aren't rounded.
* Thank icon goes away on mouseover.
* "Start a new topic" text field and textarea both have no blue bar on focus.
* Textarea has no placeholder (see http://www.jacklmoore.com/notes/form-placeholder-text/ ,also there's a jquery.placeholder in core, and Matt Flaschen had a placeholder patch for Login forms).
* Green [Add topic] button text looks poor.

For now this is a Flow bug, but at some point a version of this CSS will migrate to core (bug 54360).  https://gerrit.wikimedia.org/r/#/c/93584 may already have relevant LESS workarounds.

--------------------------
**Version**: master
**Severity**: normal
**URL**: http://ee-flow.wmflabs.org/wiki/User_talk:Spage
status ?
Possibly relevant, a current discussion on WP:VPT, describing odd problems with IE8 that supposedly only started on Nov 2nd.
https://en.wikipedia.org/wiki/Wikipedia:Village_pump_%28technical%29#Unable_to_do_anything_through_IE8
The WMF core features team tracks this bug on Mingle card https://mingle.corp.wikimedia.org/projects/flow/cards/413, but people from the community are welcome to contribute here and in Gerrit.
VE on beta labs and on prod is opt-in, but VE on test2wiki/mw.o is enabled by default for everyone, including anons. Flow must appropriatly offer VE as configured by the wiki.

--------------------------
**Version**: unspecified
**Severity**: normal
We're not using VE anymore; if/when we do, we can reopen.
Less pressing now that editing in Flow with VisualEditor is disabled by default (gerrit 99721).
The WMF core features team tracks this bug on Mingle card https://mingle.corp.wikimedia.org/projects/flow/cards/411, but people from the community are welcome to contribute here and in Gerrit.
Noticed on mediawiki.org, currently at 1.23wmf2 (88c7b3f)

On hover, the Help icon in the VisualEditor toolbar gets both the light gray border with all corners rounded, and the darker gray border that, if I look at the Menu icon for reference, should probably only appear when the button is pressed, not just hovered.

Furthermore, the dark gray border only has the left corners rounded.

--------------------------
**Version**: unspecified
**Severity**: trivial
This doesn't appear to be a problem anymore (not even on MonoBook, which still uses the original toolbar design), or I'm misunderstanding your description. In the future, please file bugs with screenshots. :(
The behaviour is correct because the help icon is actually in a group with the notification icon, however the notification icon is hidden when there are no notifications. This is also the cause of the rounded corners problem, as the CSS renderer doesn't match the last-child rule if the next child is hidden.

Solutions:
* Group help and notifications with the hamburger menu. This avoids the rounded corners problem, and the issue of the colours looking wrong because it is a set of one, but is hacky.
* Destroy the notifications icon when not in use. This would involve a bit of a rewrite as in theory it's possible to push notifications after load and the button should appear when this happens.
* Ungroup help and notifications. This avoids all the problems here.
As the preferred way to access the `wg*` variables in JavaScript is to use mw.config.get()/.set(), accessing them as globals (i.e. as members of window) should show deprecation notices in debug mode, just like it is done for the functions from wikibits.js.
Change 133162 merged by jenkins-bot:
mw.config: Show deprecation notices when accessing globals

[[https://gerrit.wikimedia.org/r/133162]]
Change 133162 had a related patch set uploaded (by Krinkle):
mw.config: Show deprecation notices when accessing globals

[[https://gerrit.wikimedia.org/r/133162]]

#patch-for-review
Change 133162 had a related patch set uploaded by Gerrit Patch Uploader:
Show deprecation notices when accessing wg* JavaScript globals

https://gerrit.wikimedia.org/r/133162
mw.log.deprecate warnings are now visible when not in debug mode too.
I just tried, and found that mw.log.deprecate can be called multiple times for the same variable without any problems. So mw.config.set could just call it, and whenever a wg* variable is changed via mw.config.set the global value would be updated, too. Only the other way round wouldn't work (or require some extra code instead of mw.log.deprecate).
(In reply to comment #3)
> (In reply to comment #1)
> > mw.config.get('wg*') is currently basically a wrapper for window.wg*. To make
> > such deprecation notices possible we'd have to duplicate the values, which
> > could cause them to get out-of-sync if something modified them after page
> > load.
> 
> Is this an actual issue? Once they are set, they shouldn't be changed anyway.
> So using a new object for mw.config.values instead of window and copying the
> variables over when they are set the first time using mw.log.deprecate
> shouldn't break more than replacing some of the wikibits.js functions with
> $.noop will break.

Apparently VisualEditor sets one, see bug 56532.
(In reply to comment #1)
> mw.config.get('wg*') is currently basically a wrapper for window.wg*. To make
> such deprecation notices possible we'd have to duplicate the values, which
> could cause them to get out-of-sync if something modified them after page
> load.

Is this an actual issue? Once they are set, they shouldn't be changed anyway. So using a new object for mw.config.values instead of window and copying the variables over when they are set the first time using mw.log.deprecate shouldn't break more than replacing some of the wikibits.js functions with $.noop will break.

(In reply to comment #2)
> Hm, how would deprecation actually work? Can we add getters on the window
> object?

Yes, if you don't believe it, have a look at wikibits.js.
Hm, how would deprecation actually work? Can we add getters on the window object?
mw.config.get('wg*') is currently basically a wrapper for window.wg*. To make such deprecation notices possible we'd have to duplicate the values, which could cause them to get out-of-sync if something modified them after page load.
https://en.wikipedia.org/w/index.php?title=Guilt_(emotion)&diff=579908396&oldid=576819947

I only intended to edit the "See also" section. VisualEditor edited a <ref> without my knowledge or consent.

--------------------------
**Version**: unspecified
**Severity**: normal
I [[ https://en.wikipedia.org/w/index.php?title=User%3ANeil_P._Quinn-WMF%2Fsandbox&diff=656821548&oldid=656821441 | repeated ]] @MZMcBride's testcase, and I didn't see any dirt. Closing.
If you're not pressing a "\" key, OO's trigger doesn't see a "\" key being pressed. This includes if you magically simulate a "\" key with another key combination, like "AltGr + 8" on French keyboards. Should we support that?

Split from bug 53682.

--------------------------
**Version**: unspecified
**Severity**: enhancement
I want to be able to test and give feedback for VisualEditor, so I've opted in on the English Wikipedia.

VisualEditor has bugs, but identifying bugs caused in your own edits can be annoying.

When I make an edit using VisualEditor, I want to be able to verify the edit (double-check VisualEditor's behavior) by viewing a diff of the changes. (Unlike when I'm editing wikitext, where I'll only preview and not use "show changes" to view a diff.) Clicking "Review your edits" in VisualEditor's user interface is tedious and interrupts my workflow.

It might be nice to implement showing the diff post-save for advanced users who simply want to be able to report an issue with VisualEditor. Or perhaps we could restore the previous behavior where a diff was automatically shown. This is an advanced user option, so it could be JavaScript config or similar. It should not be a user preference or anything that's user-facing. This feature would hopefully make reporting issues easier: rather than needing to request a diff from VisualEditor or navigate to the page history to check a diff link there, you would simply be presented with a diff.

In addition, if we're implementing an advanced user auto-diff option, perhaps we can also add a "report an issue" link to more easily file a bug? (Or search for relevant bugs.)

Filing as a Sunday afternoon thought.

--------------------------
**Version**: unspecified
**Severity**: enhancement
Triaging (but doing this as a gadget might make more sense, given this need is going to be short-term and our aversion to preference bloat).
Hey guys. The "report an issue" link has been there for a while: click on the question mark, then "Leave feedback". You can even choose if you want to file a bug here or add your request to the feedback page. HTH.
(In reply to comment #0)
> Or perhaps we
> could restore the previous behavior where a diff was automatically shown.

I don't recall an core mediawiki option for post-save diffs; have I forgotten?
I would love an pref 'Show diff after page save' in core, which when combined with 'Do not show page content below diffs' would mean my browser doesn't automatically fetch a new version of the page, which could be quite large.

Or, do you mean a pre-launch VisualEditor behaviour where a diff was automatically shown?  Was it pre-save or post-save?
Wikitext added to image captions is nowikied in the same way that markup added to the page body is. e.g. https://en.wikipedia.org/w/index.php?title=User%3AThryduulf%2Fsandbox&diff=578947711&oldid=574091986 however the wikitext warning is not generated.

To reproduce:
1. Load any page with an image in VE
2. Edit the image caption
3. Add any wiki markup in the caption (tested with bold, italic and links)

Expected behaviour: The wikitext warning pops up.
Action behaviour: Nothing happens

If popping up the warning while in the image caption dialog is not possible, then it should do so immediately the dialog is closed. Displaying it at the same time would be preferable though.

--------------------------
**Version**: unspecified
**Severity**: minor
**See Also**:
https://bugzilla.wikimedia.org/show_bug.cgi?id=53839
Change 138761 merged by jenkins-bot:
Show wikitext warnings in the reference and media caption dialogs

https://gerrit.wikimedia.org/r/138761
Change 138761 had a related patch set uploaded by Alex Monk:
Show wikitext warnings in the reference dialog

https://gerrit.wikimedia.org/r/138761
I started looking at this. It's annoying because the code to do the wikitext detection is already there and working for the main surface. It would be trivial to do the absolutely wrong way (i.e. copy the existing code to the reference surface or image caption surface and just change the reference to the Surface object), but it's a pain to fix the proper way.

One of the problems lies in the differences between normal surfaces (i.e. the main one) and surface widgets. It was suggested that we could implement MWSurfaceWidget which does the wikitext warning, but the main surface is not a widget and would still need it's own version of the code.

Also, we can't just shove the wikitext detection code in the ve.ui.Surface class and guard it with some config, because the Surface code lives in VE core which does not deal with MediaWiki features (wikitext) - the VE MediaWiki extension deals with that.

Roan suggested we could make the main surface be a surface widget and then create an MWSurfaceWidget, but that apparently has issues involving toolbar floating (I'm not familiar with this, perhaps it could be fixed in some way).

I think that for now, we can probably change the wikitext detection function to accept a surface parameter, then make it static somewhere and have each wikitext-free surface to set up an event handler for it.
Please rephrase the message "Visualeditor-preference-enable". Currently it says: "Enable VisualEditor (only in the main and user namespaces)"

With https://gerrit.wikimedia.org/r/#/c/90923/ the VE was enabled in NS_FILE, NS_HELP, NS_CATEGORY namespaces too.

--------------------------
**Version**: unspecified
**Severity**: trivial
*** Bug 52188 has been marked as a duplicate of this bug. ***
Change 92340 merged by jenkins-bot:
Re-word visualeditor-preference-enable to not specify NSes

https://gerrit.wikimedia.org/r/92340
Change 92340 had a related patch set uploaded by Jforrester:
Re-word visualeditor-preference-enable to not specify NSes

https://gerrit.wikimedia.org/r/92340
Good catch!
For instance, there's a rule for .oo-ui-toolbar-bottom but no code adding that class to anything.

--------------------------
**Version**: unspecified
**Severity**: enhancement
see page 

https://test2.wikipedia.org/wiki/User:Selenium_user/cursor_test_page2?veaction=edit

In Chrome, hit down-arrow 3 times to get to the line that begins with text 'Invisible'

In Firefox, it takes 4 times hitting down-arrow to get to that line.  The first time hitting down-arrow does nothing

--------------------------
**Version**: unspecified
**Severity**: normal
There are no slugs after lists anymore either.
Well, this now doesn't happen because Firefox doesn't get the surface selected on open.
Change 92331 merged by jenkins-bot:
[browser test] don't run cursor test pending Bug 56068 and review

https://gerrit.wikimedia.org/r/92331
Change 92331 had a related patch set uploaded by Cmcmahon:
[browser test] don't run cursor test pending Bug 56068 and review

https://gerrit.wikimedia.org/r/92331
as of Oct 28, the first right-arrow keyed also does nothing, and the first down-arrow keyed continues to do nothing.   Keying right-arrow had worked before.
Not occurring in FF18, but is in FF24; divergent behaviour from Chrome, where this works as expected.
this is causing browser test failures
Per https://gerrit.wikimedia.org/r/#/c/90339/ we should remove the dual-type support once it's been long enough since Parsoid has renamed the types.

--------------------------
**Version**: unspecified
**Severity**: normal
Re-opened as this will need to be co-ordinated with Parsoid to do a cache purge.
Change 99310 merged by jenkins-bot:
Remove dual-type support for Languages and Categories

https://gerrit.wikimedia.org/r/99310
Change 99310 had a related patch set uploaded by Jforrester:
Remove dual-type support for Languages and Categories

https://gerrit.wikimedia.org/r/99310
screenshot

VE blanks syntax-highlight extension block after editing contents with "<>" popup. :(

If you open the popup back up the source is there, but the preview in the editor is empty.

--------------------------
**Version**: unspecified
**Severity**: normal
**URL**: https://www.mediawiki.org/wiki/Manual:CORS?veaction=edit

**Attached**: {F12120}
Ha, yeah, we fixed this ages ago, I believe.
Does this still happen? I cleaned up various issues with extension blocks some months ago, and I never ran into this.
On English Wikipedia, the VE is now not offered for anons & people who have not enabled a user pref.

However if the user loads a URL that invokes VE (i.e. includes ?veaction=edit), it would be nice if VE loaded irrespective of user preferences.  If ?veaction=edit in the URL isnt explicit enough to bypass some checks, ?veaction=edit&debug=true should just do it.

That would streamline testing in many browsers, as we wouldnt need to log in on each browser - which is a bugger because logging into a second browser causes the first browser to be logged out.(bug 49890)

--------------------------
**Version**: unspecified
**Severity**: enhancement
**See Also**:
https://bugzilla.wikimedia.org/show_bug.cgi?id=51765
https://bugzilla.wikimedia.org/show_bug.cgi?id=19415
Change 97701 merged by jenkins-bot:
Make veaction=edit work regardless of user preference

https://gerrit.wikimedia.org/r/97701
Change 97701 had a related patch set uploaded by Jforrester:
Make veaction=edit work regardless of user preference

https://gerrit.wikimedia.org/r/97701
(In reply to comment #2)
> It is not a regression. Fixing.
Removing the code-update-regression keyword; it sounds like you intended to do that.
(In reply to comment #0)
> On English Wikipedia, the VE is now not offered for anons & people who have
> not enabled a user pref.

Indeed.

> However if the user loads a URL that invokes VE (i.e. includes
> ?veaction=edit), it would be nice if VE loaded irrespective of user
> preferences. If ?veaction=edit in the URL isnt explicit enough to bypass some
> checks, ?veaction=edit&debug=true should just do it.

Possibly, but I feel that this conflicts with the expressed will of the community (to prevent anonymous users from being able to use VisualEditor).

> That would streamline testing in many browsers, as we wouldnt need to log in
> on each browser - which is a bugger because logging into a second browser
> causes the first browser to be logged out.(bug 49890)

Understood the use-case (I have the issue too).

(In reply to comment #1)
> p.s. anon VE testing via URL params used to work.

Because it was enabled for all anons; when the configuration was changed, this feature was disabled. It is not a regression. Fixing.
p.s. anon VE testing via URL params used to work.
example of a number list attempting to be indented

This may be similar to https://bugzilla.wikimedia.org/show_bug.cgi?id=48010

In the VisualEditor, entire lists cannot be indented. For example, to get an entire list to appear slightly indented, a user would type in wikitext:

:* First
:** First sub one
:** First sub two
:** First sub three
:* Second
:** Second sub one...

Whereas the VisualEditor is attempting to enter this wikitext:

** First
*** First sub one
*** First sub two
*** First sub three
** Second
*** Second sub one...

--------------------------
**Version**: unspecified
**Severity**: enhancement

**Attached**: {F12745}
=Steps to reproduce=
Start with a section whose contents are: 
```
 ==Heading==
 * Alice
 * Bob
 * Chris
```
Place the cursor just before the 'A' in 'Alice' and insert an image.

The image will be placed inside the first list item:
```
==Heading==
* [[File:Example.jpg]]Alice
* Bob
* Chris
```

Editors almost never place images inside list items so they are likely to expect this to produce the following wikitext instead:
```
==Heading==
[[File:Example.jpg]]
* Alice
* Bob
* Chris
```

See https://en.wikipedia.org/w/index.php?title=User:Whatamidoing_(WMF)/sandbox&diff=577354576&oldid=577352415 for an example (look for the image of the apple).
This isn't about the VisualEditor, it is about the PHP Parser?
Same thing happen at the bottom of the list.
Example at [[ https://no.wikipedia.org/w/index.php?title=%C3%98vre_Vang_kirke&oldid=17205263 | w:no:Øvre Vang kirke ]].

Note that preview in VisualEditor/WikitextEditor seems to do it right. Or at least different.

It is not enough to add a newline to break out of the list.
Same thing happen at the bottom of the list.
Example at [[ https://no.wikipedia.org/w/index.php?title=%C3%98vre_Vang_kirke&oldid=17205263 | w:no:Øvre Vang kirke ]].
Maybe I havent understood, but I think it is not necessary to push user to add group to Reference list. Most of the references are used as a references. Other groups may be insert as an option. If you force it, it blocks to add references.

--------------------------
**Version**: unspecified
**Severity**: enhancement
In the fix for bug 59180 we made the group have a placeholder (default text) that says "General references" (in English), which should discourage this enough – marking as FIXED, though happy to discuss better ways to improve this if you want to re-open (or create a new bug).
Well,

I think this may cause also the following problem:

At this page:
https://cs.wikipedia.org/wiki/Angus_MacLise
There is one reference in group "p", but the VE engine sais here:
https://cs.wikipedia.org/wiki/Angus_MacLise#Pozn.C3.A1mky

there is no group p!
The "group" parameter is necessary if you have multiple reference lists, which is uncommon but is used some times. Re-wording to make clearer.
In the software at Wikisource it not possible to have paragraphs (by inserting empty lines) in references similar to the normal text. See: https://en.wikisource.org/wiki/User:Aschroet/test. In the normal HTML view the empty lines are just ignored and only one text block is shown. Even more interesting is the behavior in case when the text is exported by "Download as PDF". There, the paragraphs are created but not in a correct way.

The usage of <nowiki><p></nowiki> helps for the HTML view but not for PDF. The usage if <nowiki><br /></nowiki> works but does not generate real paragraphs but only newline in HTML and PDF.

--------------------------
**Version**: 1.22.0
**Severity**: minor
Background:

This issue manifests itself most often when using "bundled references" - https://en.wikipedia.org/wiki/Wikipedia:Citing_sources#Bundling_citations - where a single citation calls up multiple sources. Semantically references are a list and what we really ought to be doing is for the bundled references to be a nested list within one item of the overall list. However, the visual presentation of references is often the dominant factor among editors and they try to make each reference in the bundle display on a new line. This is sometimes implemented by inserting a raw <p> tag into the wikitext to create a paragraph and that is (i) semantically incorrect; and (ii) an annoyance for users of screen readers. Using <br> is similarly problematical.

In any case, inserting a blank line does not cause bundled references to display on separate lines as would be expected, hence this bug.
This bug causes an accessibility issue for screen reader users like myself, allbeit a minor one, because it makes it difficult to create HTML paragraphs that are semantically correct, as discussed at:

https://en.wikipedia.org/w/index.php?title=Wikipedia_talk:Manual_of_Style/Accessibility&oldid=661776586#.7B.7Bparagraph_break.7D.7D
> In the software at Wikisource it not possible to have paragraphs (by inserting empty lines) in references similar to the normal text....

The same type of DIV-ish [[https://en.wikisource.org/w/index.php?title=User:Aschroet/test&diff=5172643&oldid=4604940 | hack]] folks used for BLOCKQUOTE works for one or more newlines wrapped within REF tags as well.

I'm under the impression the ''paragraphStack'' approach in the parser was always at fault when it came to this (or at least plays a role in one reported instance or another). Seems like it should lead off with a closing P tag instead of a BR to me (resulting in an empty P tag at worst).

... but I don't know enough about this stuff to be sure about much truth be told.
My mind doesn't always understand itself either.

Currently, newlines inside <ref> tags or Image/File brackets are ignored.  This was also the case for <blockquote> and various quote templates.  

Due to Visual Editor's logic, VE was *not* ignoring newlines in <blockquote> or the quote templates.  The solution to fix whether newlines should or shouldn't be ignored was bug 6200.  6200 fixed the parser code so newlines are *not* ignored by anyone.

The question is, does VE respects newline characters in <ref> and Image/File brackets?  I ask the question because:
1) Bug 6200 languished for eight years until the problem showed up in VE
2) If VE is not ignoring the newlines, this too becomes a VE vs parser issue.
3) To show a past precedent of newlines being ignored and the bug being fixed.
bgwhite: Not sure if the VisualEditor codebase itself thinks or will answer your questions here. Maybe you want to rephrase for humans.
This problem has been going on for awhile for ref tags.  

Until today, newlines did not work correctly in blockquotes and various blockquote type templates (bug 6200).  The bug was finally fixed today on enwiki after 8 1/2 years and 2 years after a patch was submitted.  The reason for finally fixing it was because Virtual Editor thought newlines should actually work like newlines.  Silly VE.

Does VE think newlines should actually work in ref tags?
https://en.wikipedia.org/wiki/Mormons, ref 110 uses a newline. 

Newlines also don't work in Image/File brackets.  Does VE think newlines should actually work there too?
https://en.wikipedia.org/wiki/Angular_momentum, second to last image is an example.
For the example, in Wikisource we convert orignial sources to digital texts. Footnotes as e.g. in https://de.wikisource.org/wiki/Seite:Die_Gartenlaube_%281865%29_703.jpg (sorry, i usually work in German wikisource) are mapped to <ref> blocks. Since they are from time to time a little bit longer there are paragraphs inside the footnodes. 

Yes, <br /> enforces a line break but not indent of the following sentence.

I am just wondering why there is a different treatment in references than in the normal text for "normal" paragraphs.
Thanks for taking the time to report this!

What is an example/real usecase to use paragraphs in references?

As you wrote, a workaround is to insert a <br> to enforce a linebreak.

[Resetting component, as "Export/Import" refers to "Special:Export and Special:Import" only.]
I'm not sure exactly how I cause this bug but I've seen it twice now.

Works somewhat like this:
Click anywhere in the textarea and ensure there is whitespace before the cursor and nothing highlighted.

Click the link button
enter text, save it.

The link doesn't get added anywhere and now clicking the link button to create a new link has no effect.

I get JavaScript exception:
Uncaught Error: Offset could not be translated to a DOM element and offset: 6306

--------------------------
**Version**: unspecified
**Severity**: normal
Can't replicate. Closing for now.
Yes, that exception only throws from one place, and the high number looks like it's trying to find a position beyond the end of the document, but I can't reproduce.
Yeh I know.. I was hoping the Javascript exception would help debug somewhat. I managed to make it happen twice but haven't done so recently. Any clues from that exception to when it might occur?
This is difficult to look into without steps to reproduce. Let us know if you see it again, and how.
On editing a page on mediawiki.org

Navigated to
https://www.mediawiki.org/wiki/Manual:Coding_conventions/CSS?veaction=edit#Less

Looking in the console I see:
Uncaught NotFoundError: An attempt was made to reference a Node in a context where it does not exist. 

The save button is disabled.
I only noticed this after doing a long edit :(

--------------------------
**Version**: unspecified
**Severity**: major
**URL**: https://www.mediawiki.org/wiki/Manual:Coding_conventions/CSS?veaction=edit
Patch to disable SyntaxHighlight is now merged, so this problem will be suppressed with the production push tomorrow morning; restoring to "ASSIGNED".
Change 88901 merged by jenkins-bot:
Remove SyntaxHighlight from the experimental set

https://gerrit.wikimedia.org/r/88901
Change 88901 had a related patch set uploaded by Catrope:
Remove SyntaxHighlight from the experimental set

https://gerrit.wikimedia.org/r/88901
This was because of breakage in MWSyntaxHighlightNode, and that page 1) contains such a node and 2) is on mw.org where MWSyntaxHighlightNode is actually enabled. This is experimental code that's only enabled on mw.org and nowhere else (although it will be available everywhere else as an opt-in once we get BetaFeatures going).
Oh, sorry, it's something about that page in particular - confirmed on Chromium 28, Ubuntu GNU/Linux 12.04
WFM, Chromium 28 on Ubuntu GNU/Linux 12.04
Uncaught NotFoundError: An attempt was made to reference a Node in a context where it does not exist. load.php?debug=false&lang=en&modules=ext.visualEditor.core%2Cdata%2Cexperimental%2Cicons-vector%2Cs…:155
ve.dm.Converter.getDomSubtreeFromData load.php?debug=false&lang=en&modules=ext.visualEditor.core%2Cdata%2Cexperimental%2Cicons-vector%2Cs…:155
ve.dm.Converter.getDomFromData load.php?debug=false&lang=en&modules=ext.visualEditor.core%2Cdata%2Cexperimental%2Cicons-vector%2Cs…:148
(anonymous function) load.php?debug=false&lang=en&modules=ext.visualEditor.base%2Cmediawiki%2CviewPageTarget%7Cjquery.by…:94
Google Chrome Version 30.0.1599.69 and https://www.mediawiki.org/w/index.php?title=Manual:Coding_conventions/CSS&oldid=797048
ve.dm.Converter.js:1401
Currently, the mouse event handling in phantoms is:
```lang=js
// mouseenter on the protectednode
ve.ce.ProtectedNode.prototype.onProtectedMouseEnter = function () {
	if ( !this.root.getSurface().dragging ) {
		this.createPhantoms();
	}
};

// mousemove on the surface, bound by createPhantoms and unbound by clearPhantoms
ve.ce.ProtectedNode.prototype.onSurfaceMouseMove = function ( e ) {
	var $target = $( e.target );
	if (
		!$target.hasClass( 've-ce-protectedNode-phantom' ) &&
		$target.closest( '.ve-ce-protectedNode' ).length === 0
	) {
		this.clearPhantoms();
	}
};

// mouseout on the surface, bound by createPhantoms and unbound by clearPhantoms
ve.ce.ProtectedNode.prototype.onSurfaceMouseOut = function ( e ) {
	if ( e.toElement === null ) {
		this.clearPhantoms();
	}
};
```
Issues:
* the mousemove handler seems to permit moving the mouse directly to a different ProtectedNode without causing the phantoms to be cleared
* the mouseout handler uses e.toElement, which is a poorly documented property that's allegedly IE-only
* it's generally very difficult to reason about what this code does or convince oneself that it does something reasonable

--------------------------
**Version**: unspecified
**Severity**: normal
What's even worse is that if somehow another ProtectedNode does manage to show other phantoms, they will replace the first node's phantoms (because of the way ce.Surface manages phantoms), but if for some reason clearPhantoms() isn't called, the first node will continue to track the now-detached phantoms and reposition them when a transaction occurs.
Right now the way that you add a template through the VisualEditor is by choosing the Transclusion option from the toolbar.

'Transclusion' is programmer jargon. Regular people have no idea what that means. 'Template' is a somewhat ambiguous term, but at least it matches all of our documentation and the name of the namespace. It is also less scary sounding.

--------------------------
**Version**: unspecified
**Severity**: enhancement
> 'Transclusion' is programmer jargon. Regular people have no idea what that means.

 =/
> 'Transclusion' is programmer jargon. Regular people have no idea what that means.

=/
(In reply to Helder from comment #5)
> Created attachment 15228 [details]
> Transclusion vs. Template
> 
> I'm still seeing a few "transclusion" in the dialogs, on English Wikipedia.

Transclusion dialog != template dialog; transclusion = multiple template dialog.

**Attached**: {F11988}
Created attachment 15228
Transclusion vs. Template

I'm still seeing a few "transclusion" in the dialogs, on English Wikipedia.

**Attached**: {F11988}
Change 117151 merged by jenkins-bot:
Re-label "Transclusion" button to "Template", as that's now the default

https://gerrit.wikimedia.org/r/117151
Change 117151 had a related patch set uploaded by Jforrester:
Re-label "Transclusion" button to "Template", as that's now the default

https://gerrit.wikimedia.org/r/117151
*** Bug 58163 has been marked as a duplicate of this bug. ***
Eh. Maybe. We've been talking about this for months and months (surprised that there's not an extant bug for this). The problem is that though "transclusion" is indeed confusing and a surprising word, it has the advantage of being correct, and  "template" is even more confusing (and just jargon from a different well).
+++ This bug was initially created as a clone of Bug #55392 +++

VE caches the diff, which means if no content is changed, the user is shown
a) a stale diff and is allowed to proceed with saving the page, which means they are then
b) the page with their saved changes only
The user is unaware that they have overwritten another persons changes.

Steps to reproduce:
1. Create a page with some two lines
   https://en.wikipedia.org/w/index.php?title=User:John_Vandenberg/test&oldid=573748285
2. Open the page in two VE windows
3. In the second window, alter the first line and save
   https://en.wikipedia.org/w/index.php?title=User:John_Vandenberg/test&oldid=576079696
5. In the first window, alter the first line and review changes
   (the diff only shows the first line being modified
    against the page contents from step 3)
6. In the second window, add some lines and save
   https://en.wikipedia.org/w/index.php?title=User:John_Vandenberg/test&oldid=576079807
7. In the first window, review changes, and cancel the save
   (the diff is the same as in step 5; the VE page content doesnt change)
8. In the first window, save

Expected results:
In step 7, the diff should be refreshed even though the page content has not been modified.

Actual results:
The diff from step 5 is displayed in step 7.

--------------------------
**Version**: unspecified
**Severity**: minor
**See Also**:
https://bugzilla.wikimedia.org/show_bug.cgi?id=55392
At bug 55392 comment 3 James says that in core mediawiki functionality "you can't edit conflict with yourself, and new edits silently over-write", which could mean this bug is also the correct behaviour.  Need to retest with two different users.
This might be a Parsoid issue?
If the user is editing a content namespace, the link dialog should search the current namespace first, then all other content namespaces, when looking for link targets.

Steps to reproduce
1. https://www.mediawiki.org/wiki/Manual:Page_table?veaction=edit
2. Write and select 'archive table'
3. Open link dialog

Expected results:
Link target 'manual:archive table' automatically found

Actual results:
Link target 'archive table' (new page) is automatically provided

The same is needed for Wikisource which has, e.g. an Author: content namespace.

Wikipedias with a content namespace listed in InitialiseSettings.php:
Arabic Wikipedia : T22623
  https://ar.wikipedia.org/wiki/%D8%AE%D8%A7%D8%B5:%D9%81%D9%87%D8%B1%D8%B3_%D8%A8%D8%A7%D8%AF%D8%A6%D8%A9/%D9%85%D9%84%D8%AD%D9%82:
Spanish Wikipedia : T41866
  https://es.wikipedia.org/wiki/Especial:P%C3%A1ginasPorPrefijo/Anexo:
North Frisian Wikipedia: T40023
  (Wikisource inside Wikipedia)
Croatian Wikipedia: T42732
  https://hr.wikipedia.org/wiki/Posebno:Prefiks_indeks/Dodatak:
Portuguese Wikipedia:
  https://pt.wikipedia.org/wiki/Especial:%C3%8Dndice_por_prefixo/Anexo:

(and more potential ones listed at T41866)

As an aside, in 'Help' namespace, which isnt set as a content namespace, it would be nice to search within that namespace when linking, but that is a more blurry line.

--------------------------
**Version**: unspecified
**Severity**: enhancement
**See Also**:
{T71780}
{T57390}
{T64917}
{T71716}
**Author:** `Wikifram`

**Description:**
When you add a reference, it is automatically selected (blue), instead of having the cursor positioned directly after it (or better still, with a space after the ref and the cursor after that). The effec is that if you enter a ref and then start typing (which is rather normal editing behaviour), your ref immediately gets removed (overwritten) again, which makes it rather pointless. 

I think that it is much more often the intention to continue typing after adding a ref, than to have it highlighted, so please change the default behaviour.

--------------------------
**Version**: unspecified
**Severity**: trivial
Change 100522 merged by jenkins-bot:
Don't select nodes inserted by a dialog, but drop cursor after

https://gerrit.wikimedia.org/r/100522
Change 100522 had a related patch set uploaded by Catrope:
Don't select nodes inserted by a dialog, but drop cursor after

https://gerrit.wikimedia.org/r/100522
When the text of a link is changed in VisualEditor, the link target does not change. This results in many, many edits which are entirely well-intentioned but for a patroller look like vandalism. E.g. a user tries to fix the wrong date `[[2000]]` and ends up with `[[2000|2001]]` - an erroneous link that is basically impossible to catch in visual view. (Some examples: [[https://de.wikipedia.org/w/index.php?title=Osmium(IV)-oxid&diff=prev&oldid=122526489|diff]], [[https://hu.wikipedia.org/w/index.php?title=Lengyelorsz%C3%A1g_f%C3%B6ldrajza&diff=19527995&oldid=18755093|diff]]) This is a major problem; even highly experienced users fall prey to this, and new editors all the more (and then they get treated as vandals by the patrollers who are not familiar with VE and have no idea what's going on).

Maybe there could be some sort of notice asking whether the editor also wants to correct the actual target in case they change the displayed part of a wikilink (T55973#2792012 has a nice mockup).

On-wiki reports:
[[https://de.wikipedia.org/w/index.php?title=Wikipedia:Technik/Text/Edit/VisualEditor/Beta2013-07&oldid=123123378#Wikilink-Korrektur|Wikipedia:Technik/Text/Edit/VisualEditor/Beta2013-07#Wikilink-Korrektur]]
[[https://hu.wikipedia.org/wiki/Wikipédia:Kocsmafal_(egyéb)/Archív250#VisualEditor-hiba%3A_megtévesztő_belső_hivatkozások_létrehozása|Wikipédia:Kocsmafal_(egyéb)#VisualEditor-hiba: megtévesztő belső hivatkozások létrehozása]]

See Also:
* {T59506}
* {T55973}
T55973#2792012 may interest some of the followers of that task.
@Elitre 
Yes.

For the 1st and 3rd, I know, but there are only a few articles in these cases (5 of them exactly in total). And they appear at the beginning of the list, because they are recognized as special and my bot didn't flag them with {{Lien à corriger}}... So none of them appear in the dedicated category "Article avec un lien à corriger", and are not counted in the "more than 6.000 articles"

For the 2nd, I never said that all errors were due to VE, but most of them are. We are still talking about thousands of VE mistakes
@Elitre 
Yes.

For the 1st and 3rd, I know, but there are only a dozen of articles in these cases. And they appear at the beginning of the list, because they are recognized as special and my bot didn't flag them with {{Lien à corriger}}... So none of them appear in the dedicated category "Article avec un lien à corriger", and are not counted in the "more than 6.000 articles"

For the 2nd, I never said that all errors were due to VE, but most of them are. We are still talking about thousands of VE mistakes
(Just a quick comment about the query linked above:
it includes links to pages [[ https://fr.wikipedia.org/w/index.php?title=Accident_ferroviaire_de_Zoufftgen&type=revision&diff=104207507&oldid=104207037 | which are not years and not added by mistake]];
it includes pages where [[ https://fr.wikipedia.org/w/index.php?title=1._FC_Neubrandenburg_04&action=edit&oldid=62013397 | the visual editor was never used, and the mistake is almost certainly a typo]];
it includes pages where [[ https://fr.wikipedia.org/w/index.php?title=Nombre_de_Markov&action=edit&oldid=12476390 | the visual editor was never used, and the editor seems to have made a deliberate choice about the link target]].
There may be more, I'm not going to dig deeper though.)
@Whatamidoing-WMF
In addition to the abuse filter that was put in place last year, I've also recently run a bot on a dump from frwiki to find the incorrect links to pages related to years like [[2000|2015]] or [[2000 en musique|2015]].
Result is at https://fr.wikipedia.org/wiki/Projet:Correction_syntaxique/Analyse_526

Analysis on February dump found more than 6.000 articles with this kind of problem (and it's only for years related links, we are probably missing the majority of incorrect links)

I've then run a bot to add a warning after each problematic link with a template
https://fr.wikipedia.org/wiki/Mod%C3%A8le:Lien_%C3%A0_corriger
It displays a warning message and puts the article in a tracking category
https://fr.wikipedia.org/wiki/Cat%C3%A9gorie:Article_avec_un_lien_%C3%A0_corriger

It helped reduce the number of articles with this problem to about 5.400 articles

This shows that this problem is far from being anedoctic (and I don't know how to evaluate how many articles have the same problem, but not for links related to years)
Maybe whenever someone changes the link text which initially was the same as the link target, and the new link text is the name of an existing article, show a small warning in some easy-to-notice color in the link widget saying "[click here] to update the link target as well"?
+1 to //that "better" method is live, and we still have this problem//.
@Whatamidoing-WMF
Only for links to years which are easy to detect by a filter and (almost ?) always an error
https://fr.wikipedia.org/wiki/Sp%C3%A9cial:Filtre_antiabus/241
@NicoV:  Isn't there an edit filter on the French Wikipedia that would show every time this happens?
>>! In T56947#1294934, @Neil_P._Quinn_WMF wrote:
>>>! In T56947#1294891, @Amire80 wrote:
>> I may be missing something, but to me it's pretty obvious that changing the blue text "2010", which happens to point to [[2010]], to "2015" must change the link target to [[2015]].
> 
> @Amire80, are you suggesting that when a link has the same text and target (e.g. [[2010]]), changing the text should automatically change the target? Consider that this would make it //impossible// to change, for example, [[Impressionism]] to [[Impressionism|Impressionist]].

It won't be impossible if the inspector is shown, as it already is. An editor who really wants to change the text, but leave the target, can use the inspector to change it.

What I'm saying is that common sense tells me that when when the text and the target are the same and the text is changed, the target should be changed by default automatically. It makes little sense to alert the user that the target should be changed, because it's likely that that's what the user wants anyway, and double work should be avoided. It there's any alert, then it should be about the opposite: that maybe the user wants to //keep// the target.
Another pretty common mistake I find is people modifying [[Wikipedia]] to [[Wikipedia|Wiki]]pedia (probably a drag and drop problem).
Sometimes I see also [[Wikipedia|wikipedia]] or [[wikipedia|Wikipedia]] (VE seems to ignore first letter is case insensitive).
Finally I seldom (let's say less than 20 occurrences per month) find [[Wikipedia|Wikipedia]], still wrong but easy to fix via bot.
>>! In T56947#1294891, @Amire80 wrote:
> I may be missing something, but to me it's pretty obvious that changing the blue text "2010", which happens to point to [[2010]], to "2015" must change the link target to [[2015]].

@Amire80, are you suggesting that when a link has the same text and target (e.g. [[2010]]), changing the text should automatically change the target? Consider that this would make it //impossible// to change, for example, [[Impressionism]] to [[Impressionism|Impressionist]].
I may be missing something, but to me it's pretty obvious that changing the blue text "2010", which happens to point to [[2010]], to "2015" must change the link target to [[2015]].
@Whatamidoing-WMF, to what //extent// do we still have this problem? Now, anytime your cursor is within a link range, you get a big popup showing the target, along with a helpful picture in many cases; I'm not sure how much more visible it's possible to make the target without making it severely distracting.

At any rate, if it still is a major problem and we decide it needs to be addressed, I feel strongly that a more fundamental design change, not a reminder popup, would be the right solution. When a user type `<ref>`, for example, we don't bring up a comment saying: "Did you mean to add a reference?". We just pop up the citation dialog.
@Whatamidoing-WMF, to what //extent// do we still have this problem? Now, anytime your cursor is within a link range, you get a big popup showing the target, along with a helpful picture in many cases; I'm not sure how much more visible it's possible to make the target without making it severely distracting.
@Whatamidoing-WMF, to what extent do we still have this problem? Now, anytime your cursor is within a link range, you get a big popup showing the target, along with a helpful picture in many cases; I'm not sure how much more visible it's possible to make the target without making it severely distracting.
>>! In T56947#1266454, @Whatamidoing-WMF wrote:
> Okay, that "better" method is live, and we still have this problem.  
> 
> We need people (especially experienced editors) to be warned that this is happening.  When they see [[2010]], and they change the visible "2010" part to say "2015", they expect the result to be [[2015]], not [[2010|2015]].
> 
> Solutions could be a soft warning, like asking "Do you want to change the destination link to match?", but sirens and flashing lights and a blinking banner that says something like "DANGER, WILL ROBINSON!  IT LOOKS ALL RIGHT ON YOUR SCREEN, BUT THE ACTUAL LINK IS STILL SECRETLY GOING TO THE ORIGINAL PAGE!!" would be good, too.

imo, solution should not be "soft warning". solution should be something like
"internal links are not directly editable on page. when editor tries to edit an internal link, popup the "link" tool instead".

peace.
Okay, that "better" method is live, and we still have this problem.  

We need people (especially experienced editors) to be warned that this is happening.  When they see [[2010]], and they change the visible "2010" part to say "2015", they expect the result to be [[2015]], not [[2010|2015]].

Solutions could be a soft warning, like asking "Do you want to change the destination link to match?", but sirens and flashing lights and a blinking banner that says something like "DANGER, WILL ROBINSON!  IT LOOKS ALL RIGHT ON YOUR SCREEN, BUT THE ACTUAL LINK IS STILL SECRETLY GOING TO THE ORIGINAL PAGE!!" would be good, too.
This will be done better via {T88337}.
Merged in a bunch of duplicates. T63558 might be another one (not sure).
Proposing for potential VE Q3 Blocker due to the numerous duplicates (but feel free to punt).
I am a bit of a VE ambassador in the Hebrew Wikipedia and an experienced user asked me about this today. I know there are over a thousand other bugs and I don't mean to nudge, but this keeps coming up and I am curious whether this is considered as a needed feature on a product design level.
*** Bug 57506 has been marked as a duplicate of this bug. ***
Changing links is unintuitive -- user changes link text, but that dosen't change link target --see also this diff https://et.wikipedia.org/w/index.php?title=Joel_Luhamets&diff=3899205&oldid=3861224
When a page is currently a redirect, but has none-redirect versions in its history those versions should be editable in VE but are not. e.g. https://en.wikipedia.org/w/index.php?title=Equality_Acts&oldid=570457856

To reproduce:
1. Load any page that is not a redirect in the source editor
2. Change the page into a redirect and save
3. View any revision prior to the redirect

Expected behaviour: Old version is editable in VE
Action behaviour: No option is given to edit in VE

--------------------------
**Version**: unspecified
**Severity**: minor
**See Also**:
https://bugzilla.wikimedia.org/show_bug.cgi?id=50878
We no longer stop editing of isRedirect pages, so marking as INVALID now.
I'm not sure how easy this would be to do... It appears to be based on MediaWiki core's wgIsRedirect, which would need fixing to work out whether the current revision is a redirect (instead of the latest revision of the current page). I'm not sure core even has a function to work that out at the moment. Even in the database, the field to determine if something is a redirect is in the page table instead of the revision table.
Will be superseded by bug 50878 once bug 47328 is implemented, but could be done sooner if someone is keen.