*** Bug 56722 has been marked as a duplicate of this bug. ***
Change 90687 merged by jenkins-bot:
Match all characters when testing comments for JSON

https://gerrit.wikimedia.org/r/90687
Change 90687 had a related patch set uploaded by Arlolra:
Match all characters when testing comments for JSON

https://gerrit.wikimedia.org/r/90687
On second thought, I think it's because `.` doesn't match newline chars.
The problem here is that the contents of that comment isn't matching this regex,

  /^\{.*\}$/.test( content )

https://github.com/wikimedia/mediawiki-extensions-Parsoid/blob/master/js/lib/mediawiki.DOMPostProcessor.js#L95

It's not recognizing the last character as }. Taking content.charCodeAt( content.length - 1 ) returns undefined. Probably because of the unicode characters. Switching to something like,

  /^\{\"@type\"/.test( content )

seems to work but I'm interested to see where exactly things are going wrong.
Repro:

1. Create a new page with wikitext "[[中文]]" on zhwiki
2. VisualEditor-edit this page and type "s" at the end
3. The whole document now looks as if it has a link to "中文" with text "中文s"
4. Save the page
5. Resulting wikitext is "[[中文]]s", and in rendered HTML (both PHP and Parsoid - bug 41151), "s" is not a part of the link text

--------------------------
**Version**: unspecified
**Severity**: normal
I do not get the reported problem in Firefox 18 (And Chromium 25).
I downloaded versions 21, 22 and 23 from: https://ftp.mozilla.org/pub/mozilla.org/firefox/releases/21.0/ (etc.)

I didn't get your reported behaviour in any of them. :-(
(In reply to comment #7)
> (In reply to comment #6)
> > (In reply to comment #4)
> > > I get:
> > > 
> > > <p class="ve-ce-branchNode">s<a title="中文" class="ve-ce-LinkAnnotation
> > > ve-ce-mwInternalLinkAnnotation" rel="mw:WikiLink" href="../中文">中文</a>s</p>
> > > 
> > > … when using Firefox 24, Chrome 29, and Opera 12.16 (on Mac).
> > > 
> > > Very odd. :-(
> > 
> > Hmm in Firefox 24 it's no longer reproducible here...
> 
> If you can reproduce in Firefox 22 again, once it's in the broken state in
> the
> ContentEditable surface please place the cursor to the left (up-page of) the
> link and insert a new line. This should trigger a re-render and cause the
> shown
> HTML to be corrected to what it should be?

Unfortunatly I don't know how to get it back now :(

I simply APT updated it. Does any have some hint about downgrading a package?
(In reply to comment #6)
> (In reply to comment #4)
> > I get:
> > 
> > <p class="ve-ce-branchNode">s<a title="中文" class="ve-ce-LinkAnnotation
> > ve-ce-mwInternalLinkAnnotation" rel="mw:WikiLink" href="../中文">中文</a>s</p>
> > 
> > … when using Firefox 24, Chrome 29, and Opera 12.16 (on Mac).
> > 
> > Very odd. :-(
> 
> Hmm in Firefox 24 it's no longer reproducible here...

If you can reproduce in Firefox 22 again, once it's in the broken state in the ContentEditable surface please place the cursor to the left (up-page of) the link and insert a new line. This should trigger a re-render and cause the shown HTML to be corrected to what it should be?
(In reply to comment #4)
> I get:
> 
> <p class="ve-ce-branchNode">s<a title="中文" class="ve-ce-LinkAnnotation
> ve-ce-mwInternalLinkAnnotation" rel="mw:WikiLink" href="../中文">中文</a>s</p>
> 
> … when using Firefox 24, Chrome 29, and Opera 12.16 (on Mac).
> 
> Very odd. :-(

Hmm in Firefox 24 it's no longer reproducible here...
(In reply to comment #4)
> I get:
> 
> <p class="ve-ce-branchNode">s<a title="中文" class="ve-ce-LinkAnnotation
> ve-ce-mwInternalLinkAnnotation" rel="mw:WikiLink" href="../中文">中文</a>s</p>
> 
> … when using Firefox 24, Chrome 29, and Opera 12.16 (on Mac).
> 
> Very odd. :-(

btw I can't reproduce it using Chrome either.
I get:

<p class="ve-ce-branchNode">s<a title="中文" class="ve-ce-LinkAnnotation ve-ce-mwInternalLinkAnnotation" rel="mw:WikiLink" href="../中文">中文</a>s</p>

… when using Firefox 24, Chrome 29, and Opera 12.16 (on Mac).

Very odd. :-(
(In reply to comment #2)
> Are you absolutely sure it showed as <a>中文s</a> (because it really
> shouldn't!)?

Yes - already checked with inspector.

> What browser were you using?

Firefox 22.
(In reply to comment #0)
> Repro:
> 
> 1. Create a new page with wikitext "[[中文]]" on zhwiki
> 2. VisualEditor-edit this page and type "s" at the end
> 3. The whole document now looks as if it has a link to "中文" with text "中文s"
> 4. Save the page
> 5. Resulting wikitext is "[[中文]]s", and in rendered HTML (both PHP and
> Parsoid
> - bug 41151), "s" is not a part of the link text

I can't reproduce that - I got <a>中文</a>s in the edit surface, and it saved as expected:

* https://zh.wikipedia.org/w/index.php?title=User:Jdforrester_(WMF)/Sandbox&diff=28804968&oldid=28804967 (for linktrail)

https://zh.wikipedia.org/w/index.php?title=User:Jdforrester_(WMF)/Sandbox&diff=28804969&oldid=28804968 (for linkhead)

Are you absolutely sure it showed as <a>中文s</a> (because it really shouldn't!)? What browser were you using?
Linkprefix is also affected - type "s" at the beginning instead of the end in the repro above.
See https://fr.wikipedia.org/wiki/Fichier:Bug_%C3%A9diteur_visuel_barre_de_menu_style_de_texte_sur_deux_lignes.png .
In languages like French and Italian some options in that menu are long (multiple words names like Titre de section) and the last word will appear under the toolbar itself.

--------------------------
**Version**: unspecified
**Severity**: normal
*** Bug 50639 has been marked as a duplicate of this bug. ***
Fixed and will go out next week.
Change 87450 merged by jenkins-bot:
Allow menu tool groups to be wider if needed

https://gerrit.wikimedia.org/r/87450
Change 87450 had a related patch set uploaded by Trevor Parscal:
Allow menu tool groups to be wider if needed

https://gerrit.wikimedia.org/r/87450
It happens with Firefox/Chrome, Monobook/Vector, and the zoom used in the page does not matter.
Best seen on a slow connection e.g at crossbrowsertesting.com; I used Chrome 29 on OSX 10.7

Seen on beta labs and test2wiki with a fresh browser instance: 

* Click Edit/beta, invoke VE

** View of page appears, then disappears, refreshes and appears again before "Welcome to..." iframe appears

* Click X to dismiss iframe

** iframe disappears for a moment, then reappears, then disappears again

Given a slow enough connection, this behavior could be bothersome for regular users of VE.  

It definitely causes constant failures in the browser tests for Chrome on both beta labs and test2wiki. 

This is not seen in Firefox

--------------------------
**Version**: unspecified
**Severity**: major
**See Also**:
https://bugzilla.wikimedia.org/show_bug.cgi?id=55756
This bug was reported and is reproducible against Chrome version 29 but does not appear in Chrome version 30.  Closing.
This may only happen in Chrome 29, I have yet to repro in Chrome 30
Because both the underlying page and the Welcome to... overlay appear and disappear and reappear and then finally disappear for good, there is a chance that the correct elements will be in place at the times that the test looks for them.  On rare occasions the  build will hit everything with perfect timing. 

The other interesting artifact of this issue is that the tests in each build fail for different reasons, because the page and the overlay are appearing and disappearing and reappearing.

Watching the behavior in crossbrowsertesting as noted above is instructive.  The appear/disappear/reappear/disappear-again behavior is easily seen, I just checked it again.

And while the appearance of the 'You are not logged in' notice despite being logged in is more difficult to reproduce, it seems to be a symptom of the same issue.
I'm confused as to how the browser tests for Chrome passed 9 days after this bug was filed - https://wmf.ci.cloudbees.com/view/r-ve/job/VisualEditor-en.wikipedia.beta.wmflabs.org-linux-chrome/72/ - only to fail again immediately thereafter, where the only intervening change in VisualEditor's code base was an alteration to the browser tests - https://wmf.ci.cloudbees.com/view/r-ve/job/VisualEditor-en.wikipedia.beta.wmflabs.org-linux-chrome/73/ - which feels like a different issue, and one where the problem is with the tests, not the code they are testing?
still seeing this in automated tests

also, I reproduced this again manually using the slow connection at crossbrowsertesting.com as noted, and in addition to seeing the double-load of the page and double-load of the welcome notice, after clearing the notice I am presented with a message "You are not logged in".  This is impossible of course, since I have to be logged in with the opt-in preference set in order to be able to invoke VE at all. 

The "You are not logged in" notice does not appear consistently.
When a template is selected in the VE editing surface pressing enter should open the transclusion dialog.

When an image is selected in the VE editing surface pressing enter should open the media settings dialog.

These will be of benefit to people making textual changes to the surrounding context who want to make textual changes to the template output / image caption.

--------------------------
**Version**: unspecified
**Severity**: enhancement
**See Also**:
https://bugzilla.wikimedia.org/show_bug.cgi?id=50996
Change 103062 merged by jenkins-bot:
Create mixin that tries to execute primary node command

https://gerrit.wikimedia.org/r/103062
Change 103062 had a related patch set uploaded by Robmoen:
Create mixin for ce nodes that responds to dblclick

https://gerrit.wikimedia.org/r/103062
**Author:** `romaine.wiki`

**Description:**
The VisualEditor substitutes templates that shouldn't been substituted. The largethumb template got substituted on several occasions, like:

https://nl.wikipedia.org/w/index.php?title=Managua_%28stad%29&diff=38749742&oldid=38743043

If this continues to happen too long, we are forced to disable the VisualEditor for everyone as it changes things that absolutely should not be changed.

--------------------------
**Version**: unspecified
**Severity**: major
**See Also**:
https://bugzilla.wikimedia.org/show_bug.cgi?id=54315
Scheduled for deployment next Wednesday.
Change 110095 merged by jenkins-bot:
Set up data-mw for all templated image attributes.

https://gerrit.wikimedia.org/r/110095
Change 110095 had a related patch set uploaded by Subramanya Sastry:
WIP: Set up data-mw for all templated image attributes.

https://gerrit.wikimedia.org/r/110095
If the Parsoid will be able to parse this, this would at least avoid bad rendering (thumbnail at the right size) and fix (selfishly) my concern :)
We can parse it (so that it renders as expected), but I don't see a sane way to represent multiple attributes generated by the same template for visual editing.
@Gabriel Do you mean Parsoid won't be able to parse this template in the same way like the PHP one does?

After discussing a little bit about that on the nlwiki IRC channel, they are (of course) not so happy about that. Not only because the thousands of pages but also because the template is old and a lot of people would have then to change their habits.
(In reply to comment #4)
> Wanted to create an offline copy of nlwiki; but this bug is, for this usage,
> a
> showstopper.
> 
> The rendering is awful (but this is nothing new), for example:
> http://parsoid-lb.eqiad.wikimedia.org/nlwiki/Abraham_Lincoln?oldid=39371115
> 
> ... and such type of templates are widely used: ~10.000 articles only for
> {{largethumb}} on nlwiki. This bumps the whole size of the dump by a factor
> 2.
> 
> @James, good news: I have had a look a little bit around and I don't have
> found
> other templates working on the same principle.

@Kelson, that is great news! Scott is looking into image rendering issues, so assigning to him. We should be able to add a special-case hack for this template and edit-protect affected images.

For proper editing the thumb parameter should be pulled out, as in |thumb|{{large}} with large returning just something like '400px'. That will require some convincing and bot activity.
Wanted to create an offline copy of nlwiki; but this bug is, for this usage, a showstopper.

The rendering is awful (but this is nothing new), for example:
http://parsoid-lb.eqiad.wikimedia.org/nlwiki/Abraham_Lincoln?oldid=39371115

... and such type of templates are widely used: ~10.000 articles only for {{largethumb}} on nlwiki. This bumps the whole size of the dump by a factor 2.

@James, good news: I have had a look a little bit around and I don't have found other templates working on the same principle.
This doesn't round trip in Parsoid.
**romaine.wiki** wrote:

I haven't seen it happen with other templates so far.
Is this just the {{largethumb}} template, or are there others? (Templates that define some but not all of the parameters of an image are particularly troublesome.)
Screenshot explaining issue with visualeditor

Hi
These are the steps:

*Create a preformatted multiline text, inserting a space before each line, in source mode.
*Open visualeditor, select the text inside the box (the preformatted text)
*Change text type to "paragraph"
*The text is badly converted, return characters appear on the line. If the text is saved the return characters are lost.
*This happens in other cases too, tab symbols are displayed sometimes.

Thank you.

--------------------------
**Version**: unspecified
**Severity**: normal

**Attached**: {F12384}
The ↵ characters indicate that the newline is preserved as if you edit the page subsequently and convert the paragraph to preformatteed the line breaks return.
I couldn't find a way to click the links while editing and go to the target page. It's not easily available in the source editor, so it's not really a regression, but I find myself needing this features every time I edit, because the links are blue and look like links.

GMail and Google have reasonably good ways of going to links' targets in editing mode, so hints can be taken from them.

--------------------------
**Version**: unspecified
**Severity**: enhancement
**See Also**:
https://bugzilla.wikimedia.org/show_bug.cgi?id=50321
Fixed in gerrit 139550.
Right-click and 'open in new tab' works for me (tested in Firefox 24), but it'd be better to have something findable in the edit toolbar (or at *least* the link edit dialog) with a 'regular' click.

Right-click or long-press for context menus aren't something everybody knows well or jumps straight to.
+++ This bug was initially created as a clone of Bug #50643 comment 6 +++

Steps to reproduce:
1. Edit a page in VE
2. Select a piece of textual content without any fancy stuff in it.
3. Drag it to another location in the page

Expected results:
The cursor should be a disabled-drop icon

Actual results:
The cursor is an 'image' icon

--------------------------
**Version**: unspecified
**Severity**: enhancement
Given we are about to support text drag and drop with bug 49981, marking as wontfix.
What the?  Drag and drop text appears to be not working in Chrome either; I am pretty sure I remember dragging and dropping text in Chrome in July, but maybe I am mistaken.
Dropdown clipping

Referring to the attached screenshots there are two issues:

1. The width is not adjusted to account for the OS scrollbacks. I assume this is because has one of those fancy Macintosh computers that doesn't know how to draw a big chunky old-fashioned scroll bar.

2. The assumption is made the the height of the VE container is the maximum height the scrollbar expand to. Here that is clearly not the case. It may be the case that because we don't know what lies beyond the borders of VE (e.g. z-index 9999 banner), we can't do anything about this. Maybe we can make the assumption the page content is sane, and if the dropdown ends up obscured, leave that as an integration problem for the user?

--------------------------
**Version**: unspecified
**Severity**: normal
**See Also**:
https://bugzilla.wikimedia.org/show_bug.cgi?id=69707

**Attached**: {F12176}
Fixed in OOjs UI with gerrit 157295.
Corrections:
scrollbacks -> scroll bars
is because has -> is because Trevor has
Screenshot of languages dialog tab with the new-category popup in front

Switching from categories to languages while suggestion popup is open doesn't close popup -- see screenshot.

--------------------------
**Version**: unspecified
**Severity**: normal

**Attached**: {F12105}
This was fixed a while ago.
Screenshot of category dialog, showing no apparent way to get at the listed categories

The category suggestion tool seems to provide a simple typeahead search, but provides no way to go and see if the categories you've found are relevant.

At a minimum, you should be able to open up the category page via a link from the search box and and the little tag display.

Better still might be a little preview that pulls the description text (if any) and some sample contents right within the dialog box.

--------------------------
**Version**: unspecified
**Severity**: enhancement

**Attached**: {F12103}
Seems like a nice idea. Provide a link in the category menu?
This is kind of a meta bug and not an actual issue in BZ. Couldn't think of a better place to file it...

Filing bugs/enhancements is difficult for some people to figure out. We can lower the barrier pretty easily by making a 1 or 2 minute video showing you how. Upload to commons, link to from BZ main page.

Key components:
- Sign up
- Choosing the right product
- Giving clear description of the problem/request
-- Screenshots are fantastic
-- Providing links is great too
- Make sure to emphasize to not worry about filling all the fields out properly, the important step is opening the bug!

Major props to User:Biosthmors on enwiki for coming up with the idea.

--------------------------
**Version**: wmf-deployment
**Severity**: enhancement
**Whiteboard**: gci2013 https://www.mediawiki.org/wiki/Google_Code-In#Candidate_tasks
**URL**: https://commons.wikimedia.org/wiki/File:How_to_file_a_report_in_Bugzilla.webm
**See Also**:
https://bugzilla.wikimedia.org/show_bug.cgi?id=52696
Excellent work Shujat! Thank you very much :-)
Shujat completed the tutorial, which is available at https://commons.wikimedia.org/wiki/File:How_to_file_a_report_in_Bugzilla.webm

Your help featuring it in mediawiki.org and other projects is welcome!

Thank you very much, Shujat.
*** Bug 58965 has been marked as a duplicate of this bug. ***
(In reply to comment #33)
> That's totally fine. Is the address bar (where the URL is shown) still
> visible?
> I'd say that's preferable to have.
> 
Well, I got that fixed by now, so its not a problem anymore, only the address bar is visible.
But the g-mail will would be appearing, can't fix that.
(In reply to comment #30)
> Hello, I'm a student from GCI, and I've been assigned this task.
> So, about the screencast, I have an idea: how about once the user account has
> been created successfully, I go to http://www.mediawiki.org/wiki/MediaWiki,
> then search for How to report a bug. From there I move to the new guided
> form.

OK

(In reply to comment #32)
> The script tells to go to your e-mail client, and I went to my gmail account
> to get the mail, is that okay?

Let's see how it looks like. The idea about not showing browser/email/OS chrome is to make the video as generic and as brand-free as possible. Don't worry, we can always cut.
(In reply to comment #31)
> Well, in the video, the windows taskbar or chrome logo is not there but tabs
> are visible, that okay?

That's totally fine. Is the address bar (where the URL is shown) still visible? I'd say that's preferable to have.

(In reply to comment #32)
> The script tells to go to your e-mail client, and I went to my gmail account
> to get the mail, is that okay?

Yes, but if you prefer to not show your real private email address and inbox at that time to the world, you might want to create another email account just for testing and making this video.
The script tells to go to your e-mail client, and I went to my gmail account to get the mail, is that okay?
Well, in the video, the windows taskbar or chrome logo is not there but tabs are visible, that okay?
Hello, I'm a student from GCI, and I've been assigned this task.
So, about the screencast, I have an idea: how about once the user account has been created successfully, I go to http://www.mediawiki.org/wiki/MediaWiki, then search for How to report a bug. From there I move to the new guided form.
Thank you Richard!

The task about writing a script has been completed. I just created the task to produce the screencast:

http://www.google-melange.com/gci/task/view/google/gci2013/5787018130882560
**lettrich42** wrote:

Ok, i think its just about there, Did i seem to mention anything
Link for convenience: https://www.mediawiki.org/wiki/User:Richardusername/BugzillaScriptProject
I have given Richard my last round of comments. The script already looks very good. If you have additional feedback don't comment: edit the script directly ("Be bold").

As soon as this task is completed I will create a new one about creating the screencast.
Ok Richard, you don't need to get stuck in this discussion about the origin of the link. Whenever someone (you?) creates the screencast we will use an existing entry point in a wiki page (VisualEditor would work, as specified in your script).
(In reply to comment #18)
> I'm not sure how to transition from logging in to using the new formatted bug
> submission form, as there seems to be no link from the site homepage.

Uhm. I don't have an easy answer to that either right now. :(

So far I've expected users to follow links on wikipages which point to the ?format=guided form in the URL. 
But as Elitre already wrote: Discussed in bug 57254.
It's a good first draft, but still needs more work. I have left my feedback. Andre and other readers of this report are encouraged to comment there as well.
**lettrich42** wrote:

The draft is finished if you're interested. Just going to clean it up and maybe add more details. Link again for CC:https://www.mediawiki.org/wiki/User:Richardusername/BugzillaScriptProject
**lettrich42** wrote:

Thanks for the video! It was exactly what I was thinking of, except doing this one more to the point. Also this is my main account, was accidentally logged in to wrong one when posting the last one. (I was going through the steps again)  As for the brief sign-up , we can easily remove it if needed, so ill just leave it until final revisions.
Hi Richiell!

Slides vs screencast, this video was well received here. Just in case it serves as source of inspiration: 

> http://blog.johnath.com/2010/02/04/bugzilla-for-humans/

There is another GCI task about title cards for videos, but they are not ready yet. Still, this task is about agreeing on the script, so never mind.

Same for the link to the guided form. You are right, currently there is no way to reach it from Bugzilla itself. However, for your script we can assume that it will be in the home.

About your script, feel free of reusing the very little I could do at https://www.mediawiki.org/wiki/Talk:How_to_report_a_bug#Screencast

I also started thinking of the registration process. Then again, Bugzilla's registration is quite standard, so perhaps it is better to save that time to the viewers of the video and yourself. Mention in the script that users must be registered in order to file bugs, feel free spending 3 seconds to point to the Register link in the home and get directly to the stuff.

This means that the beef of your script is "Examples".  :) 

Sorry for not reaching to this conclusion before! Your draft helped reaching to this conclusion. This is how iterations work...
**richiell** wrote:

Ive made a little bit of progress on the script, here's the link if anyone wants to follow it: https://www.mediawiki.org/wiki/User:Richardusername/BugzillaScriptProject
Hear, hear! Bug 57254.
**lettrich42** wrote:

I'm not sure how to transition from logging in to using the new formatted bug submission form, as there seems to be no link from the site homepage.
:) I wouldn't like to see slides in the video, but hey, that's just me. Let's see what Andre thinks, since he rules over Bugzilla here!
**lettrich42** wrote:

(In reply to comment #15)
*or girls
**lettrich42** wrote:

OK, Im thinking about doing the script with part Slideshow and mostly a Guided screen recording. What do you guys think about that?
Awww! Thanks a lot!
**lettrich42** wrote:

I am a student from Google Code in this task was assighned to, and I will start today, begining in a couple of hours. (Regular updates were required)
(In reply to comment #11)
> You should post that guided form to wikitech-l

http://lists.wikimedia.org/pipermail/wikitech-l/2013-October/072786.html
(In reply to comment #10)
> https://bugzilla.wikimedia.org/enter_bug.cgi?product=VisualEditor&format=guided

That is REALLY nice!!  You should post that guided form to wikitech-l, I am sure other components could make use of a similar form.
The guided form is now ready (i.e. https://bugzilla.wikimedia.org/enter_bug.cgi?product=VisualEditor&format=guided ), and I'd really love to have a screencast about it!
Note that there are also bugzilla.mozilla.org thoughts on having video tutorials for specific Bugzilla topics: https://bmo.etherpad.mozilla.org/bugzilla-tips-videos
I don't know how much upstream this would be though.
Currently I'd use the normal form with "Hide Advanced Fields" enabled, and either MediaWiki or Wikimedia product, plus component "General/Unknown".
Guided form (bug 36762) is still under development and not deployed - this week was too busy with reallife but will try to get it into shape next week.
Well, yes, a video screencast.

What I'm asking is whether we should do it using the plain Bugzilla interface or the guided form.
(In reply to comment #4)
> What interface should we use for this screencast? The traditional or this new
> one Andre is cooking up?

I'd assumed you'd create a video in .ogv format.

A paginated PDF is also an option.
What interface should we use for this screencast? The traditional or this new one Andre is cooking up?

I have started defining a rough script at https://www.mediawiki.org/wiki/Talk:How_to_report_a_bug#Screencast
For the records (and inspiration), the only pretty good (and partially Mozilla-centric) video I am aware of is http://blog.johnath.com/2010/02/04/bugzilla-for-humans/
A screencast showing the shortest path to file a bug report should do. I haven't done a screencast in ages but I will try tomorrow, with the hope that someone hates what I did and produces something better.  :)

In fact this could be start of something. We could have more short screencasts focusing on a specific action (advanced search, comment on a bug...) and extend the idea to other tools (get developer access, comment on Gerrit...). These short videos could be easily embedded in the right wiki pages and...

But let me try with this File Your First Bug screencast first.  :)
Maybe Victor / some designers / whoever, can produce nice video intro and outro :)
Occasionally, pages have stray opening table tags which may end up screwing up DSR computations (which in turns messes up selser). It is possible that our latest foster parenting code implicitly handles this by wrapping the entire table as templated and protected a large body of code (which could then serve as a flag to the user to look for bugs in the wikitext souce). So, it might be worth verifying this and adding tests to spec this behavior.

See the bug report: https://en.wikipedia.org/w/index.php?title=Wikipedia:VisualEditor/Feedback&oldid=574391235#Duplicated_content_when_deleting_apparently_blank_lines

See my response that fixed the problem in the wikitext source: https://en.wikipedia.org/w/index.php?title=Wikipedia:VisualEditor/Feedback&oldid=574483272#References_and_tables

If this is not already handled by our handleUnbalancedTables and markFosteredContent DOM passes, we may need to tackle this -- by maybe adding a fixup in TokenStreamPatcher that enforces limited table scope (section boundaries is the obvious scope limiter => close unclosed tables whenever section heading tokens are encountered).

To be investigated and fixed.

--------------------------
**Version**: unspecified
**Severity**: normal
(In reply to comment #0)
> Occasionally, pages have stray opening table tags which may end up screwing
> up
> DSR computations (which in turns messes up selser). It is possible that our
> latest foster parenting code implicitly handles this by wrapping the entire
> table as templated and protected a large body of code (which could then serve
> as a flag to the user to look for bugs in the wikitext souce). So, it might
> be
> worth verifying this and adding tests to spec this behavior.

That seems to happen if a template is present, as in:

  {|

  {{echo|hi}}

  ;Ho

However, that's not the case in the bug report. It's more like,

  {|

  ;Off to work we go


> 
> See the bug report:
> https://en.wikipedia.org/w/index.php?title=Wikipedia:VisualEditor/
> Feedback&oldid=574391235#Duplicated_content_when_deleting_apparently_blank_li
> nes
> 
> See my response that fixed the problem in the wikitext source:
> https://en.wikipedia.org/w/index.php?title=Wikipedia:VisualEditor/
> Feedback&oldid=574483272#References_and_tables
> 
> If this is not already handled by our handleUnbalancedTables and
> markFosteredContent DOM passes, we may need to tackle this -- by maybe
> adding a
> fixup in TokenStreamPatcher that enforces limited table scope (section
> boundaries is the obvious scope limiter => close unclosed tables whenever
> section heading tokens are encountered).

Seems reasonable.

> 
> To be investigated and fixed.
Assigning to Parser as I suspect this is what would need to be fixed up to support this.

This patch [1] demonstrates the large number of rules exist for external links:

The browser matches styles from right to left, so the rightmost selector is really important.

We shouldn't need to have to resort to CSS rules in the form div#content a.external[href ^="https://"] - a link with class external should also have a class describing what type of external link it is if it is necessary. These selectors are less efficient and are not supported by older browsers.

Ideally we should simply these rules to become something like:

.link-audio,
.link-video,
.link-document,
.link-irc,
.link-ftp,
.link-https,
.link-news,
.link-mailto {
padding-right: 13px;
background: transparent center right no-repeat;
}

with rules for each of them for their correct icon.

[1] https://gerrit.wikimedia.org/r/#/c/85920/2/skins/vector/externalLinks.less

--------------------------
**Version**: unspecified
**Severity**: normal
**See Also**:
https://bugzilla.wikimedia.org/show_bug.cgi?id=63725
https://bugzilla.wikimedia.org/show_bug.cgi?id=63521
Sigh.
I'm frustrated by the removal of icons that were useful.
Meh.
PDF: To clarify this, the icon was always a generic document. On the English Wikipedia it uses an Adobe icon through Common.css.

The Typography Refresh removed the other icons in Vector. HTTPS icons were removed per Bug 61178.

So currently on the English Wikipedia we have the external link icon and the Adobe icon. Both are meaningless to our visually impaired readers since none of the icons have alt text; see Bug 45891.

Since many documents are now produced by dynamic web pages, they do not have the file extension that the CSS rules trigger on, thus those documents will show the simple external link icon.

Bottom line: How useful are the icons? Is there any other project using icons in this manner?
1) As I said in comment #6 - the mailto, irc, audio/video, and pdf icons are frequently useful for:
* Readers to have "principle of least astonishment" when clicking on links which often have a non-typical-navigation result.
* Editors to see that an unusual link has been used/added, which might warrant further investigation.

2) Our internal Pronunciation links all have an icon added automatically: e.g. https://en.wikipedia.org/wiki/Template:Pronunciation and https://en.wikipedia.org/wiki/Template:IPA - e.g. at [[Götterdämmerung]]

Then, 2 similar "bits of information - a difference that makes a difference" that any of our users might appreciate.

3) we have a request from the Internet Archive to add icons to their links: #1 at https://www.mediawiki.org/wiki/Archived_Pages#Implementation_ideas (mentioned at https://lists.wikimedia.org/pipermail/design/2013-October/001065.html )

4) we have a request from the community, (and I believe connected to The Wikipedia Library), to add icons that denote Open-Access resources: https://en.wikipedia.org/wiki/Wikipedia:WikiProject_Open_Access/Signalling_OA-ness

For all of these reasons, I hope we can re-instate these icons in Vector. 
The patch to do so is currently -2'd based on lack of apparent consensus (https://gerrit.wikimedia.org/r/#/c/154350/). 
I've also left a comment (the first...) at [[Help talk:External link icons]]. 
Comments here or there, with additional rationales for supporting or opposing the re-instatement (for use-case or technical or other reasons) would be appreciated.
(In reply to Bartosz Dziewoński from comment #81)
> So the general agreement is that it was good in the beginning and the change
> above was a bad idea.

I don't know how you have determined this from the above. Please give me the precise quotes you are attributing to.

All I see is agreement that we shouldn't use classes and should use an approach such as [href^="https://"]

Whether they are a good idea is another question.
I wouldn't want them on my local wiki for example.
Change 154350 had a related patch set uploaded by Bartosz Dziewoński:
Restore external links icons

https://gerrit.wikimedia.org/r/154350
So the general agreement is that it was good in the beginning and the change above was a bad idea. In other words, we should revert https://gerrit.wikimedia.org/r/#/c/123817/ in the Vector skin.

(Also, moving this to the Vector component, since the only changes that were implemented and the entire discussion involved only that skin.)
Change 141973 abandoned by Bartosz Dziewoński:
Linker: Add CSS classes to external links to some protocols/filetypes

Reason:
Right.

https://gerrit.wikimedia.org/r/141973
(In reply to Jon from comment #77)
> Isarra. What was the motivation for putting them in in the first place?

Given that this was orginally added in 2004, I couldn't say. I can, however, point you to comment #3 and comment #6, which detail specific reasons for keeping them in now.

> Putting styles in both core and common.css that do the same thing is a
> terrible terrible terrible thing and we should at least resolve that problem
> at the same time. The fact those rules exist there show MediaWiki was not
> serving there purpose and they were /not/ useful.

As I said, the English Wikipedia is not the only project that uses this software. What they do doesn't necessarily apply to other projects, especially when we don't even know why they did what they did.

> Currently each project as complete free reign to add these icons in
> common.css if they want to. I truly don't see the value in them being here.

Each project is free to write their entire skin css in common.css if they want to. Doesn't mean they should have to do that either.
(In reply to Jon from comment #77)
> PS. How can I remove myself from this bug. Since I'm the creator, it doesn't
> seem possible.

Sorry, only available in next version: https://bugzilla.mozilla.org/show_bug.cgi?id=148564 - For the time being, custom filters / thread muting.
Isarra. What was the motivation for putting them in in the first place?

Putting styles in both core and common.css that do the same thing is a terrible terrible terrible thing and we should at least resolve that problem at the same time. The fact those rules exist there show MediaWiki was not serving there purpose and they were /not/ useful.

Currently each project as complete free reign to add these icons in common.css if they want to. I truly don't see the value in them being here.

Isarra making use of icons is not the same as those icons giving value.

PS. How can I remove myself from this bug. Since I'm the creator, it doesn't seem possible. @Andre.. ?
(In reply to Jon from comment #75)
> The icons for audio, video etc have been gone for some time without any
> complaints that I am aware of. Maybe because a lot of these styles are
> implemented in MediaWiki:Common.css

Yes, nobody noticing would make it more difficult for anyone to complain about it.

> Let's not re-instate these classes and CSS rules. The status quo is
> currently fine. Let's not add back css rules for the sake of adding back css
> rules. I feel like we are wasting far too much energy on this bug.

MediaWiki serves more than just the English Wikipedia. While the icons often do serve little purpose on individual projects, many other projects do indeed make use of these icons, especially third-party technical projects which will not have seen that change at all due to generally being on stable releases (1.19, 1.22, 1.23 etc). This is not adding back css rules for the sake of adding them back, this is adding them back with a reasoned technical discussion about how best to do so considering the current technology, with the understanding that projects do use them, that there are real-life use cases speaking to their usefulness, and that there was no consensus to remove them in the first place.
The icons for audio, video etc have been gone for some time without any complaints that I am aware of. Maybe because a lot of these styles are implemented in MediaWiki:Common.css

Let's not re-instate these classes and CSS rules. The status quo is currently fine. Let's not add back css rules for the sake of adding back css rules. I feel like we are wasting far too much energy on this bug.
Phew .. long discussion. I could have gone either way (selectors or css classes) till I hit Gabriel and Roan's comments and now Krinkle's about client burden and code duplication to support classes/attributes. If there were no alternatives and this were the spec, of course, all clients would have to implement it, but given that there are no serious drawbacks to picking selectors over classes, I too think that it is a better idea to use css for icon-styling of links.
Re performance, I have not been able to find anything on the web that indicates that CSS selector performance is a significant issue in practice.

This SO articles seems to provide a good overview:
http://stackoverflow.com/questions/12279544/which-css-selectors-or-rules-can-significantly-affect-front-end-layout-renderi
+1 to Roan and Gabriel.
(In reply to Gabriel Wicke from comment #69)
> One issue I didn't mention yet is editor complexity. Every editor for our
> HTML including VE will need to replicate the class logic from the parser.
> This includes future micro-contribution tools like 'fix this link'. It seems
> likely that this will lead to rendering inconsistencies when the logic
> replication is not perfect.

This is also a problem for VisualEditor. Even in the current system, not including any micro-contribution tools that Gabriel talks about, we would need three entirely separate copies of this logic, in:
* MediaWiki's wikitext->HTML parser
* Parsoid, to generate correct HTML
* VisualEditor, to display newly created links correctly

VE generally deals well with styling that comes from the parser side and displays it correctly, but in this case the user could create a link entirely from scratch, and that link might be a .pdf link. Then even though there may not be another .pdf link anywhere on the page, we still need to know that .pdf is magical and should trigger a certain CSS class in order to produce the correct rendering. That's why we need a full duplicate of the icon logic.

So in general, we try to move this kind of logic fully *into* CSS, rather than *out of* CSS and into *code*. Last year this was done for auto-numbered external link numbering: instead of implementing a bunch of numbering logic both in Parsoid and in VE, we were able to number them entirely in CSS using CSS3 counters.

With that in mind, I would much prefer that link icons be done in pure CSS, with attribute selectors in their full "glory". That way VisualEditor and any other clients that need to generate new HTML will not have to reimplement the logic from scratch, and instead will just be able to load the CSS. Unless attribute selectors are horrendously slow (which they're probably not, the original CSS rules for link icons date back to 2004), moving to classes just makes things worse, not better.
One issue I didn't mention yet is editor complexity. Every editor for our HTML including VE will need to replicate the class logic from the parser. This includes future micro-contribution tools like 'fix this link'. It seems likely that this will lead to rendering inconsistencies when the logic replication is not perfect.
Oh, MediaWiki uses more advanced things for styling (like… LESS?), that was never the problem. The only problem was unspecified performance issues.

But I really don't feel like introducing two new ways of doing such a little feature is the right thing to do from a maintainability standpoint (both the maintainability of core, and maintainability of any skins that might want to use different icons).
(In reply to Bartosz Dziewoński from comment #66)
> As I said before, I'm okay with doing this either way (we can revert the old
> patch that removed this feature in Vector), but let's please not do both
> ways at once.

We are using attribute matches for a bunch of things in any case, so it's not like somebody working on MediaWiki CSS would now be exposed to new CSS 2 selectors. The main change would be the introduction of classes to eliminate overly complex attribute matches on file extensions, which I think is fairly easy to understand.
(In reply to Gabriel Wicke from comment #64)
> Looking at the linked CSS [1], to me it seems that the most complex rules
> are those matching on file extensions to figure out video / audio / document
> links. As those links are not that common relative to the total number of
> links I'd expect classes to be a win overall for those.
> 
> Protocol matches on the other hand are a single selector only (no need for
> upper case variants), and a large chunk of external links is neither to
> videos, audio or document files. This seems to favor keeping those matches
> in CSS to keep the document size down.
> 
> Does this sound like a promising solution to you?

Eh, I'd prefer if we decided on only one way of doing this and stuck to it. This seems to be the worst of both worlds.

As I said before, I'm okay with doing this either way (we can revert the old patch that removed this feature in Vector), but let's please not do both ways at once.
(In reply to Gabriel Wicke from comment #62)
> The .plainlinks class was normally used to mark this up, and applied to all
> links inside a content block. How does this work with classes on each link?

.plainlinks .link-https has higher specificity than .link-https, so it's easy to disable the icon for plain links, if desired.

(In reply to Gabriel Wicke from comment #64)
> Looking at the linked CSS [1], to me it seems that the most complex rules
> are those matching on file extensions to figure out video / audio / document
> links. As those links are not that common relative to the total number of
> links I'd expect classes to be a win overall for those.
> 
> Protocol matches on the other hand are a single selector only (no need for
> upper case variants), and a large chunk of external links is neither to
> videos, audio or document files. This seems to favor keeping those matches
> in CSS to keep the document size down.

I don't really know the performance details, but that seems reasonable.  PDF links are probably more common than audio/video, but still a minority.
Looking at the linked CSS [1], to me it seems that the most complex rules are those matching on file extensions to figure out video / audio / document links. As those links are not that common relative to the total number of links I'd expect classes to be a win overall for those.

Protocol matches on the other hand are a single selector only (no need for upper case variants), and a large chunk of external links is neither to videos, audio or document files. This seems to favor keeping those matches in CSS to keep the document size down.

Does this sound like a promising solution to you?

[1]: https://gerrit.wikimedia.org/r/#/c/85920/2/skins/vector/externalLinks.less
(In reply to Jon from comment #59)
> Another reason is styles written in this way are not reusable.

I'll add one more reason.

What if we "don't" want an icon? This should be as simple as not including the class. Using selectors this means you have to override a skin specific css rule, with an unknown weight to it. The selectors aren't even standardized yet, Vector used to use #content, MonoBook uses #bodyContent, and commonElements of course uses .mw-body (though for non-icon styles).
(In reply to C. Scott Ananian from comment #57)
> @Daniel: long story, but basically gzip compression in HTTP only works in
> the download direction.  There is no equivalent content negotiation for
> uploads in HTTP.

Oh you're talking about save sizes.

Are the byte sizes of a few link classes really a big deal for actions as infrequent as a save?

If they are, isn't there any serverside sanitization of the DOM? These are internally generated classes, so if it were an issue couldn't you just strip them before transmission and let the sanitizer or parsoid generate the classes?

Also I thought delta based saves were being done which make small byte size differences moot.
Another reason is styles written in this way are not reusable.

What if we want to use the same audio icon elsewhere?

With an icon-audio selector class we can.
With a selector based on href we can't.

I'd like to see us moving away from descendant selectors and explore OOCSS [1] as a solution to our CSS mess we have created. We really should be making better uses of classes, and not be restricted by the implementation restrictions of Parsoid.

[1] http://www.smashingmagazine.com/2011/12/12/an-introduction-to-object-oriented-css-oocss/
(In reply to C. Scott Ananian from comment #57)
> @Daniel: long story, but basically gzip compression in HTTP only works in
> the download direction.  There is no equivalent content negotiation for
> uploads in HTTP.

JS implementations aren't universally a win on all browsers & hardware either. See https://bugzilla.wikimedia.org/show_bug.cgi?id=66914 for some related discussion.
@Daniel: long story, but basically gzip compression in HTTP only works in the download direction.  There is no equivalent content negotiation for uploads in HTTP.
(In reply to Gabriel Wicke from comment #52)
> We have use cases where uncompressed HTML is sent over the wire (HTML save
> from VE), so uncompressed DOM size does matter.

Why is it not compressed?
(In reply to Bartosz Dziewoński from comment #54)
> (In reply to Gabriel Wicke from comment #52)
> > Do we have actual measurements that verify that this benefits total page
> > view performance in practice?
> 
> We don't. Jon provided some funky tool in comment 11 but I've been unable to
> get it to work. 

Same here, it wouldn't even load for me.

> Krinkle provided a theoretical explanation on why this
> should make a difference in comment 10.

Both of these aren't really telling us whether it's an overall win, draw or loss to add extra classes in the DOM & use those rather than match on existing properties. They both focus on one part of the picture only, and lack quantitative data. Only measurements can really answer this question.

> (In reply to Gabriel Wicke from comment #53)
> > One more note on browser support: IIRC these selectors were already
> > supported by IE 6 in 2004.
> 
> Not by IE 6, but by every other browser, yes. IE 7+ supports them too.

Ah, okay. Misremembered that then ;)
(In reply to Gabriel Wicke from comment #52)
> Do we have actual measurements that verify that this benefits total page
> view performance in practice?

We don't. Jon provided some funky tool in comment 11 but I've been unable to get it to work. Krinkle provided a theoretical explanation on why this should make a difference in comment 10.


> If there is no measurable improvement on page
> view / rendering even on mobile, then I'd propose to keep this in CSS to
> avoid slowing down use cases like VE saves.

You are actually proposing restoring this to CSS :), because it's already been removed (in spite of working well since 2004). I wouldn't mind that, personally.


(In reply to Gabriel Wicke from comment #53)
> One more note on browser support: IIRC these selectors were already
> supported by IE 6 in 2004.

Not by IE 6, but by every other browser, yes. IE 7+ supports them too.
One more note on browser support: IIRC these selectors were already supported by IE 6 in 2004.
We have use cases where uncompressed HTML is sent over the wire (HTML save from VE), so uncompressed DOM size does matter.

Do we have actual measurements that verify that this benefits total page view performance in practice? If there is no measurable improvement on page view / rendering even on mobile, then I'd propose to keep this in CSS to avoid slowing down use cases like VE saves.
(In reply to C. Scott Ananian from comment #50)
> Hm, Parsoid does not tag links with classes.  The only CSS would work fine
> for parsoid-generated HTML; the new CSS will not.

That is a bug in parsoid. We've required the .external class at minimum for years, parsoid should be able to handle link classes.
Hm, Parsoid does not tag links with classes.  The only CSS would work fine for parsoid-generated HTML; the new CSS will not.
We'll have https (secure) and external link icons in wiki font soon (probably already) but wiki font isn't in core yet, these issues are related but could be separate too.
Change 141973 had a related patch set uploaded by Bartosz Dziewoński:
Linker: Add CSS classes to external links to some protocols/filetypes

https://gerrit.wikimedia.org/r/141973
I've looked at this again now that things have cooled down. I still do not like this solution, and I still like this alternative proposed a long time ago:

(In reply to Bartosz Dziewoński from comment #13)
> (In reply to Jon from comment #11)
> > That aside use of a single class .link-https rather than a
> > combination of class .link-https, div#content a.external[href
> > ^="https://"] would be preferable for a variety of reasons
> > readability, maintainability, reduced file size... are you really
> > telling me this is not a no-brainer?
> 
> Using the classes as you proposed does seem sane and mostly non-troublesome
> (apart from the classic caching issues). I am perfectly fine with doing that
> (as long as I'm not the one who will have to jerry-rig the Parser).

So I looked at the Parser, or in fact the Linker, and doing this is actually amusingly trivial. Pity no one did this the first time around.

A patch will follow momentarily.
Regardless of everyone's opinions the patch has been merged, so this is fixed.
Change 124618 merged by jenkins-bot:
Follow-up: If985b16c – Vector external link change release notes

https://gerrit.wikimedia.org/r/124618
Change 124618 had a related patch set uploaded by Jdlrobson:
Follow up to If985b16c4f682d737683597ed80951c6d6644c8f

https://gerrit.wikimedia.org/r/124618
I can tell you that it's customary on sites like Reddit to add a "PDF warning" to a description of a link that points directly to a PDF document. (Other file types don't really come up often enough for such a custom to develop.)
(In reply to Jon from comment #37)
> Commits and reverts are cheap.

No. There's almost no evidence to suggest that commits and reverts of this nature are cheap. There's a ton of evidence to suggest that commits and reverts of this nature are expensive (in terms of community time and developer time).

> We have a huge editor decline and here we are arguing about some icons next to
> links.

No fearmongering here, please. The stated editor decline is dubious, bordering on spurious. This bug is strictly about "some icons next to links." You (Jon) are sidetracking the technical conversation with FUD about an editor decline. Focus on the issue at hand, please.
(In reply to Jared Zimmerman (WMF) from comment #36)
> (In reply to Isarra from comment #34)
> We did a beta feature, it was called typography refresh, and little to no
> feedback (negative or positive) addressed the removal of these icons, that
> was the impetus for moving forward with this as a simple patch. 

Lumping multiple changes together and then testing the entire pile is problematic by its very nature: it can become very difficult to differentiate between the effects of different changes, and getting meaningful feedback on any specific one often becomes very difficult. Thus you can wind up with an overall positive response despite individual aspects which significantly detract from the experience, and then wind up thinking those, too, are positive when they really aren't (or visa versa).

Thus, to say anything specific about the external link icons and potential changes, I would suggest that you need to test or otherwise investigate those specifically, and distinctly, first. Jon's not wrong that this is a relatively minor thing, but while that means a full-on battery of tests probably isn't actually necessary here, like with any other change, discussion is definitely in order in order to establish some sort of consensus as to what best serves the users. So here we are. Discussing. Or we were, before the entire thing got a wee bit sidetracked.
(In reply to Jon from comment #37)
> The world is not breaking. The world of Vector is just going through
> turbulence.

I didn't mean to point fingers at any specific event, and wasn't actually thinking of typo refresh when making my comment (Or the actual subject of this bug. Oh well guess this bug is pretty hijacked). I wanted to address in the abstract the attitude in comment 23 of making changes willy nilly (which I flippantly phrased as "breaking the world") and then iterating on them until people like them (or cynically: until they become fait accompli), as being a good way to get feedback. I think its a good way to piss off people, and self-justify changes via confirmation bias.


> 
> The fact we have to actively discuss trivial changes like this concerns me
> greatly. We have a huge editor decline and here we are arguing about some
> icons next to links.

I'm not sure I follow. Not asking editors for feedback on changes is somehow going to increase editor retention?

> 
> Also I think you mean /editors/ when you say /readers/ here. I think most
> /readers/ care simply if a link will take them to an external site or not.

I was responding as if "readers" = Users without an account who only read. For the actual change I think both groups care. My comment was aimed solely at attitudes for getting feedback. I'm not actually that concerned about the actual change
I'm just going to leap in here in the middle of this heated discussion and change the title of the bug to be grammatically correct. It's been bugging me. Sorry.
The world is not breaking. The world of Vector is just going through turbulence.

As stated above external links were removed as part of the typography beta feature. Actually, not a single person wrote about this on the talk page (https://www.mediawiki.org/wiki/Talk:Typography_Update) during the 6 months it was live. This evidence leads me to believe that they are /not/ important and it is the basis for removing them.

If this proves to be wrong, then we react and restore/amend it, it's no big deal. Commits and reverts are cheap.

The fact we have to actively discuss trivial changes like this concerns me greatly. We have a huge editor decline and here we are arguing about some icons next to links.

Also I think you mean /editors/ when you say /readers/ here. I think most /readers/ care simply if a link will take them to an external site or not.
(In reply to Isarra from comment #34)
We did a beta feature, it was called typography refresh, and little to no feedback (negative or positive) addressed the removal of these icons, that was the impetus for moving forward with this as a simple patch. 

If you read on the Beta Features page, you'll see that Beta Features should not be only subtractive in nature, e.g. packaging up the removal of these icons as its own feature makes very little sense. — https://www.mediawiki.org/wiki/Beta_Features/Package
> 
> Its relevant because asking for feedback on "the usual channels" completely
> omits the target user, when the target users is a reader. Jon's point that
> we can do it and then iterate speaks to the fact that it is one of our only
> ways to get reader feedback. To roll the change out publicly then iterate.
> We can get better at this eventually, but at the current juncture, I think
> this is a sound plan based on our infrastructure for eliciting feedback from
> readers and others who aren't aware of, or participate in "the usual
> channels"
> 
> Hope that makes sense.

breaking the world, and then seeing who complains isn't really a good way to get feedback from readers. First off, most people who complain aren't going to be "readers" they are going to be active users who are familiar with the regular channels. If you actually get readers angry enough that they figure out how to complain, you've probably massively screwed up the site. Second, that's prone to a massive confirmation bias of "Well nobody or not that many people complained out of a group of people who don't know how to complain, therefore it must be a good idea"

I really think this is an extraordinarily dangerous line of reasoning to go down.
Users of a product are aware (although not always consciously) of the absence of something equally well as the awareness of and existence of something (cruft). A user does not need to be aware of something, an "absence," say to be aware that a product is better because of design choices to remove, and simplify. 


"Good design is as little design as possible — Less is more – because it concentrates on the essential aspects and the products are not burdened with non-essentials. Back to purity, back to simplicity" —Dieter Rams

"Perfection is achieved perfection not when there is nothing left to add, but when there is nothing left to take away" –Antoine de Saint-Exupery
Then again, can you expect a casual reader to ever appreciate that which is not there? A removal like this is hard to notice, because most links don't have these icons.

Your proposal is basically: Ah, people asked for this 10 years ago. but there is a bunch of annoying css rules, so let's remove them and wait how long it takes for people to ask if they can have the feature back. This feature contributes to the rule of least astonishment, and you are removing it without considering replacing it with an alternative.

I find that somewhat presumptuous if i'm honest. But then again, I thought messing with fonts was a dangerous plan and that turned out just splendid, so what do I know....
(In reply to Isarra from comment #28)
> And there is a right way to make change happen - by proposing changes and
> getting feedback. By implementing this, you have inherently proposed it, and
> now you are getting feedback. Whether or not they should be merged depends
> on what consensus is established either here or in other appropriate
> channels; we have these channels for a reason.

Its relevant because asking for feedback on "the usual channels" completely omits the target user, when the target users is a reader. Jon's point that we can do it and then iterate speaks to the fact that it is one of our only ways to get reader feedback. To roll the change out publicly then iterate. We can get better at this eventually, but at the current juncture, I think this is a sound plan based on our infrastructure for eliciting feedback from readers and others who aren't aware of, or participate in "the usual channels"

Hope that makes sense.
(In reply to Jared Zimmerman (WMF) from comment #29)
> Isarra, I've mentioned it before and I'll mention it here again, that
> process makes total sense for editor or logged-in user features. It doesn't
> make sense for reader facing features, as these users are not part of this
> conversation.  
> 
> You know how to do cross site links but many users do not, and the systems
> are not smart enough to automatically convert them in many cases.

I agree, new users often don't appreciate the significance of many features. But how is this relevant to the matter at hand?
Isarra, I've mentioned it before and I'll mention it here again, that process makes total sense for editor or logged-in user features. It doesn't make sense for reader facing features, as these users are not part of this conversation.  

You know how to do cross site links but many users do not, and the systems are not smart enough to automatically convert them in many cases.
(In reply to Jon from comment #26)
> To be clear, we still show an external link icon.
> Yes I suspect it may annoy people but this can be easily remedied. Change is
> also a trend that needs to start.

And there is a right way to make change happen - by proposing changes and getting feedback. By implementing this, you have inherently proposed it, and now you are getting feedback. Whether or not they should be merged depends on what consensus is established either here or in other appropriate channels; we have these channels for a reason.

(In reply to Jared Zimmerman (WMF) from comment #27)
> Isarra, from a technical perspective a PDF hosted on commons while I'm on
> wikipedia is "leaving the site" but this isn't how most readers or casual
> editors see it. That was my point. I appreciate your point about it from a
> literal perspective.

External links appear if the external link format is used, regardless of where the link points. They are only supposed to be for links that go off the site (in other words, ones that are 'external'); we normally use wikilinks (ones formatted [[like this]]) to link to local and sister project pages, which do not result in external link formatting.

For more information about how links work in MediaWiki, please see https://www.mediawiki.org/wiki/Links
Isarra, from a technical perspective a PDF hosted on commons while I'm on wikipedia is "leaving the site" but this isn't how most readers or casual editors see it. That was my point. I appreciate your point about it from a literal perspective.
To be clear, we still show an external link icon.
Yes I suspect it may annoy people but this can be easily remedied. Change is also a trend that needs to start.
(In reply to Jared Zimmerman (WMF) from comment #23)
> From my understand the external/file format link icons are only relevant
> when you are actually leaving the site, or when it would cause your browsers
> to download a file rather than loading it in some kind of built in player,
> either on site or in-browsers. The original code for this I assume was
> created prior to mediawiki being able to natively handle many of these file
> formats. 

Generally external links do leave the site. This is what 'external link' means.

(In reply to Jon from comment #24)
> That said, I am happy to deal with any after effects of this change. I'd
> hope such a drastic change would surface the icons that are important.
> 
> I think the removal of them although somewhat extreme, will make it clearer
> and easier to restore ones that are vital.

I would suggest that breaking everything and then seeing what people complain about the most may not be the best way to determine what is important. Yes, it may work, but more than anything it's probably just going to annoy people, and needlessly alienating users is a trend that needs to stop, not continue.
Apologies if I misunderstood and this had been the agreement.

That said, I am happy to deal with any after effects of this change. I'd hope such a drastic change would surface the icons that are important.

I think the removal of them although somewhat extreme, will make it clearer and easier to restore ones that are vital.

A lot of these icons may be better done in something like MediaWiki:Vector/Monobook/Common.css on a per project basis anyhow.
From my understand the external/file format link icons are only relevant when you are actually leaving the site, or when it would cause your browsers to download a file rather than loading it in some kind of built in player, either on site or in-browsers. The original code for this I assume was created prior to mediawiki being able to natively handle many of these file formats. 

That said I think most if not all of these are no longer needed and confuse many users. Overall I would urge us to move towards simplicity when it comes to links, designating only links that take you out of the WMF sites, and links that point to non-existent articles. 

If knowing target file types is relevant to a small subset of users I've argue that this code should be gadgetized by someone who cares to retain this feature.
(In reply to Jon from comment #14)
> Great. I'm agnostic about killing the icons or not. My main goal is to start
> cleaning up and improving all the desktop CSS.

I thought we'd agreed to clean up the expensive CSS, and not to delete the icons (which is what https://gerrit.wikimedia.org/r/123817 does).

:/
Change 123817 merged by jenkins-bot:
Vector: Simply style external links

https://gerrit.wikimedia.org/r/123817
If they're not affected, they're not representative. It doesn't sound rational to mention them in the commit message.
I don't understand the question/problem. All wikis got the beta features experiment.

If those wiki's have local icons, that is fine, they won't be effected by this change to Vector, and will get a performance boost by having a simpler set of css selectors for these icons.
> During the typography experiment, these were removed, no one raised this as an 
> issue during the 5 months it was live, suggesting that explicit pdf icons etc
> are not as useful as we like to believe.

How many of the (English) wikis in question did not have *local* icons? How do you know how many were actually affected by these changes?
Change 123817 had a related patch set uploaded by Jdlrobson:
Vector: Simply style external links

https://gerrit.wikimedia.org/r/123817
See http://lists.wikimedia.org/pipermail/wikitech-l/2013-October/072642.html

Main highlights:

* We shouldn't confuse English Wikipedia's overrides with code in core.  However, there is room to clean that up, even if they want to keep a different icon from core (e.g. moving the Modern-specific code to Modern.css).
* I like the idea of doing it in the parser, but it obviously requires more testing than a CSS change.  To expand on what I said in the email, we could do something generic like 'mw-link-extension-pdf'.  We would need to decide whether to do it for all extensions, or just the ones where core styles it.
* We could consider using the Commons PDF icon in core, if it's freely licensed (have not investigated).
(In reply to comment #14)
> Great. I'm agnostic about killing the icons or not. My main goal is to start
> cleaning up and improving all the desktop CSS.

Sensible thing to do, indeed. Just bear in mind caching issues. >.<
Great. I'm agnostic about killing the icons or not. My main goal is to start cleaning up and improving all the desktop CSS.
(In reply to comment #11)
> That aside use of a single class .link-https rather than a
> combination of class .link-https, div#content a.external[href
> ^="https://"] would be preferable for a variety of reasons
> readability, maintainability, reduced file size... are you really
> telling me this is not a no-brainer?

Using the classes as you proposed does seem sane and mostly non-troublesome (apart from the classic caching issues). I am perfectly fine with doing that (as long as I'm not the one who will have to jerry-rig the Parser).

Killing the icons as suggested in comment 1 is a completely different thing and, apart from what I mentioned in comment 7, I will vehemently oppose doing it.


(In reply to comment #11)
> If you really feel the need for a citation check out:
> http://stevesouders.com/efws/css-selectors/csscreate.php

Either I am unable to figure it out, or it doesn't work. Reflow time is 0 for me no matter what I do. "page load time" is measuring the speed of my connection if anything.

(In reply to comment #12)
> CSS rule efficiency table:
> http://csswizardry.com/2011/09/writing-efficient-css-selectors/

This looks interesting; sorry, I don't have time to dig into it right now, but hopefully I will later. (Hopefully it's still relevant - it was apparently written in 2011, and two years is like a few decades at least ;) )
CSS rule efficiency table: http://csswizardry.com/2011/09/writing-efficient-css-selectors/
(In reply to comment #9)
> (In reply to comment #8)
> > The CSS is pretty ridiculous. Let's not forget that CSS parses from the
> > rightmost rule so something like a.external[href ^="news:"] can be a pretty
> > expensive operation.
> 
> [citation needed]. I don't see why would it be particularly more expensive

If you really feel the need for a citation check out:
http://stevesouders.com/efws/css-selectors/csscreate.php

That aside use of a single class .link-https rather than a combination of class .link-https, div#content a.external[href ^="https://"] would be preferable for a variety of reasons readability, maintainability, reduced file size... are you really telling me this is not a no-brainer?
(In reply to comment #8)
> The CSS is pretty ridiculous. Let's not forget that CSS parses from the
> rightmost rule so something like a.external[href ^="news:"] can be a pretty
> expensive operation.

[citation needed]. I don't see why would it be particularly more expensive than any of the hundreds of other rules we have. Assuming that the hypothetical browser does indeed naively match from the right side always, [href^="news:"] will immediately not match (most elements don't even have a href attribute) and the ten or so of such rules should not be noticeable.
The CSS is pretty ridiculous. Let's not forget that CSS parses from the rightmost rule so something like a.external[href ^="news:"] can be a pretty expensive operation. These rules should be killed with fire in favour of specific classes like link-pdf if needed.

I don't care if we kill or keep rules I just want these rules to die and the CSS in general to be cleaned up.
Per Isarra and Quiddity, I think that the only ones that should be killed are the HTTPS and FTP ones. That CSS is not ridiculous, it's just a little uncool.
(In reply to comment #5)
> My gut says remove them all esp. the https links, as @Isarra mentioned the
> only
> one that seems to make any real sense is links that point to files, like
> PDFs,
> however  internal (Commons) links have their own viewer. External PDFs seem
> like the only file that marking their links seems relevant in any way. Most
> modern browsers have built-in PDF renders so even the days of PDFs being
> treated special is soon becoming irrelevant. 
> 

Isarra mentioned mailto and IRC links too, which I'd agree are instances where the icon is useful. 

The audio/video icons are also good to have, per principle of least astonishment (eg, someone adds a link to a loud .wav file into an article's external links, and someone else in a quiet office clicks on it).

They also help editors to notice that these uncommon link types are present, and hence to check whether they're really suitable/wanted or not. (If I see an audio-file icon, I often click it to check for spam/vandalism).


> My recommendation would be to remove all special formatting other than
> wikilinks vs external links. 
> 
> If we could determine and mark wikilinks that are to other sister projects,
> I'd recommend they be treated as regular wikilinks as well.

Interwiki links (everything in https://meta.wikimedia.org/wiki/Interwiki_map )
are already styled with a slightly-lighter blue, via class "extiw" (external interwiki) located in https://svn.wikimedia.org/viewvc/mediawiki/trunk/phase3/skins/common/commonElements.css?view=markup and skins/monobook/main.css
My gut says remove them all esp. the https links, as @Isarra mentioned the only one that seems to make any real sense is links that point to files, like PDFs, however  internal (Commons) links have their own viewer. External PDFs seem like the only file that marking their links seems relevant in any way. Most modern browsers have built-in PDF renders so even the days of PDFs being treated special is soon becoming irrelevant. 

My recommendation would be to remove all special formatting other than wikilinks vs external links. 

If we could determine and mark wikilinks that are to other sister projects, I'd recommend they be treated as regular wikilinks as well.
(In reply to comment #1)
> Honestly I'd recommend just killing these link icons outright...

One of the things to consider is when and where the links are actually used, and if special treatment is even sensible anymore. 

Generally we'd probably only want special icons for things that are both fairly commonly used and where the browser reaction would be significantly different from general browsing - for things like PDFs, which are often used for sources, that can open up in a new window or rearrange the tab depending on browser, or mailto and IRC which often send the request out of the browser entirely and open a new window. Users do like warning when it comes to that sort of thing, indeed.

Whereas we probably don't want anything special for things like https, ftp, etc where the browser just opens it like normal, especially since for instance https is becoming more and more common as the default...
(In reply to comment #1)
> Honestly I'd recommend just killing these link icons outright...

Some of the other icons could /possibly/ be removed without screaming. 

But the PDF icon is important. Users get frustrated when they click a PDF without warning.

(The only alternative is [[Template:PDFlink]] which makes article/citation code more complicated, so that's not good.)
(In reply to comment #1)
> Honestly I'd recommend just killing these link icons outright...

This is a design question, I think. Adding the Bugzilla keyword accordingly.
Honestly I'd recommend just killing these link icons outright...
In ve.ui.MWReferenceDialog, this.referenceSurface changed from being a Surface to a SurfaceWidget. I noticed this because I rebased some old code that used this.referenceSurface.getModel() and broke, but this seems to have happened a while ago with the introduction of SurfaceWidget.

When a variable name is 'fooSurface', it should be a Surface, not something else. In particular, you shouldn't have to do this.referenceSurface.getSurface() to get the surface.

The same applies to this.captionSurface in ve.ui.MWMediaEditDialog.

--------------------------
**Version**: unspecified
**Severity**: enhancement
When you insert a reference in the middle of a bolded word, the reference itself doesn't receive a bold annotation, and so the resulting text is something like '''He'''<ref name="hello" />'''llo''', with the bold breaking around the reference.

When we insert inline nodes like references from the UI, they should take annotations. This is probably a wider problem beyond just references.

--------------------------
**Version**: unspecified
**Severity**: normal
See bug 48720.
(In reply to comment #2)
> Also, I'm not sure this is desirable behaviour.

But we are. :-)
Also, I'm not sure this is desirable behaviour.
The dialogs generate insertion transactions directly with newFromInsertion, and have no insertion annotation logic.
ce.MWExtensionNode.onParseSuccess contains the following code:

	// Rerender after images load
	this.$.find( 'img' ).on( 'load', ve.bind( function () {
		this.emit( 'rerender' );
	}, this ) );

Problems:
* Why is this in MWExtensionNode? Shouldn't it just be in GCNode?
* This potentially emits multiple rerender events, one for each image
* The first rerender event has already been emitted because we've already resolved the promise and attached the nodes to the DOM

What we should really do is attach the nodes somewhere else (where?) so that the images load, then reattach them to a wrapper and resolve the promise with that. That way we only emit rerender once, and we correctly only resolve the promise once everything has actually loaded.

In practice, this means the math inspector moves around twice after typing LaTeX in certain cases: once because of the 'rerender' event caused by the <img> tag being put on the page (at which point it measures 0x0), and once because of the 'rerender' event caused by the image actually loading (at which point it measures correctly).

Open questions:
* How does this work for images with invalid/unavailable sources?
* Really what we care about here is the dimensions of the images. If those are known, we can render the node without its dimensions changing later

--------------------------
**Version**: unspecified
**Severity**: normal
https://gerrit.wikimedia.org/r/#/c/86167/ fixes this
Right now, GCNode caching uses both the model hash and the hash of the config object. However, when properties in the config override properties in the model, the preview of a change and the new model node after the actual change will be the same but have different hashes (because the model is different, and because in the second case the config object is empty/undefined).

We should make generatedContents() static, so it can't inspect the model or any object state, and have a function that provides the default config that is then used to extend the provided config. That way we don't end up duplicating things in cache and rendering things twice.

--------------------------
**Version**: unspecified
**Severity**: enhancement
Currently http://korma.wmflabs.org/browser/its-repos.html shows that the Bugzilla products scanned are MediaWiki, All extensions, VisualEditor and Parsoid. However, this list must be in sync with http://korma.wmflabs.org/browser/scm-repos.html - which in turn is synced with https://wikitech.wikimedia.org/wiki/Key_Wikimedia_software_projects

Let's update that wiki page with the relevant products / components. A 100% match is probably impossible, but a 90% (or so) should be feasible.

--------------------------
**Version**: unspecified
**Severity**: major
**See Also**:
https://bugzilla.wikimedia.org/show_bug.cgi?id=49744
(In reply to comment #6)
> ==Core Extensions==
> Don't want to spend too much time going through the list and syncing with
> https://bugzilla.wikimedia.org/editcomponents.
> cgi?product=MediaWiki%20extensions
> however noteworthy naming differences from the top of my head:

Currently korma lists all the extensions in a single project. This is good enough for now, but for the Bugzilla Response Time KPI [1] we will need to be more precise:

* Including only the key projects.
* Treating each component separately, just like we do with code repos.

[1] https://www.mediawiki.org/wiki/Community_metrics#Bugzilla_response_time
Ok guys, you have the viz in:

http://korma.wmflabs.org/browser/its-repos.html
Yes!
Ok guys, is this ready to start downloading all those bugzilla product and components and adding them to the korma browser?
Andre, if you could point to the Bugzilla product/component of each project at https://wikitech.wikimedia.org/wiki/Key_Wikimedia_software_projects that would be perfect!
(If there is something I can specifically help with as Bugzilla admin, please tell me what I need to do for you folks.)
Quim, for the Bugzilla components mapping, do you have some plan in mind for gathering the info from Wikimedia Community? Maybe we can start doing the mapping of the more clear components, but it there is a complete process to cover all of them, much better!
Yes Quim, we can scan only components.
Álvaro, can MetricsGrimoire scan only specific components of a Bugzilla product? The reason to ask is that, ideally, we wouldn't scan the whole MediaWiki Extension product but only the relevant components.
**Author:** `jmichrina`

**Description:**
Example:
Line from "International_Air_Transport_Association_airport_code"

DFW for Dallas–Fort Worth, DTW for Detroit–Wayne County, RDU for Raleigh–Durham, MSP for Minneapolis–St. Paul and LBA for Leeds Bradford (Airport).

Line appears correctly formatted in editor [caps represent bold]:
dfw for Dallas-Fort Worth, dtw for DetroiT-Wayne county, rdu for Raleigh-DUrham, msp for Minneapolis-St. Paul and lba for Leeds Bradford (Airport).

Line appears incorrect on page [caps represent bold]:
dfw for DALLAS-FORT WORTH, stw for dEtROIT-wAYNE COUNTY, rdu for RALEIGH-DURHAM, msp for mINNEAPOLIS-sT. pAUL and lba for LEEDS BRADFORD (AIRPORT).

Note that the correct version appears in the editor even after it's saved.

Possibly related to bug 53208, but I didn't have time to verify.

--------------------------
**Version**: unspecified
**Severity**: major
This has long been merged, so closing as fixed. Please reopen if there is still an issue.
Tidy should result in non-broken HTML (unless there is a bug in Tidy). I just checked and Tidy fixes PHP parser's broken HTML and generates: <p><b><a href="/wiki/Foo" title="Foo" class="mw-redirect">F<b>oo</b> B<b>ar</b></a></b></p> (Can be verifed at https://en.wikipedia.org/wiki/User:Ssastry/sandbox)

As for Parsoid, yes, this kind of broken wikitext was not being handled properly so far, but that is set to change with https://gerrit.wikimedia.org/r/#/c/83216/ which is awaiting review.

That patch generates the following HTML on the snippet which is similar to what Tidy generates

<p data-parsoid='{"dsr":[0,27,0,0]}'><b data-parsoid='{"autoInsertedEnd":1,"dsr":[0,27,3,0]}'><a rel="mw:WikiLink" href="./Foo" data-parsoid='{"stx":"piped","a":{"href":"./Foo"},"sa":{"href":"Foo"},"dsr":[3,27,6,2]}'>F<b data-parsoid='{"dsr":[10,19,3,3]}'>oo </b>B<b data-parsoid='{"autoInsertedEnd":1,"dsr":[20,25,3,0]}'>ar</b></a></b></p>
I have fixed the particular problem with this edit: https://en.wikipedia.org/w/index.php?title=International_Air_Transport_Association_airport_code&diff=574406042&oldid=574202912

This is caused by a bug in Parsoid, I believe, which is wrongly interpretting wikitext as valid when it should be invalid. Specifically:

  '''[[Foo|F'''oo '''B'''ar]]

… as …

  <b><a href=Foo>F</a></b><a href=Foo>oo </a><b><a href=Foo>B</a></b><a href=Foo>ar</a>

… whereas it should result in broken HTML, per the PHP parser (post-Tidy), as:

  <b><a href=Foo>F<b>oo </b>B<b>ar</b></a>

The broken wikitext was added in https://en.wikipedia.org/w/index.php?title=International_Air_Transport_Association_airport_code&diff=568156811&oldid=568156261 which isn't tagged as a VisualEditor edit but possibly could have been (and a secondary bug means it isn't tagged) - will investigate separately.
Screenshot

https://en.wikipedia.org/w/index.php?title=Daniel_Rowe_%28footballer%29&oldid=570278760&veaction=edit

--------------------------
**Version**: unspecified
**Severity**: normal

**Attached**: {F11872}
Change 85866 merged by jenkins-bot:
Detect collapsed range inside focusable node in ve.ce.Surface#onChange

https://gerrit.wikimedia.org/r/85866
Change 85866 had a related patch set uploaded by Esanders:
Detect collapsed range inside focusable node in ve.ce.Surface#onChange

https://gerrit.wikimedia.org/r/85866
This is cause by ve.ce.Surface#showSelection not being aware of the slug at the start of the document. Also, because the focusableNode logic takes places before showSelection is called, it tries to do a native selection.
Created attachment 13347
Screenshot of page after trying to Undo

Causes loss of data as it makes it really easy to accidentally delete that selection when you start typing.

When you then try to do Undo, the following exception is thrown:

Uncaught Error: Cannot roll back a transaction that has not been committed 

Also, for some reason the font has become noticably smaller (only in the affected paragraph; see screenshot)

**Attached**: {F11873}
This is a separate report for automatic caret movement from one place to another when using VE with ULS.

This problem has been seen with some other bugs, specifically, in the fourth[1], seventh[2] and tenth[3] comments of Bug 53708 and the original report of Bug 54421

I also suspect that the problem in Bug 53701 is a form of this bug only.

However, I am reporting this as a separate bug since I was able to reproduce it independent of these bugs.

System environment:
Win 7 X64 SP1
Google Chrome 29.0.1547.66 m

Test Url:
https://www.mediawiki.org/wiki/User:Siddhartha_Ghai/sandbox?veaction=edit

Steps:
1 Enable ULS IME hindi transliteration
2 Take the caret to the end of the first paragraph using the mouse (i.e click at the end of the first paragraph to take the caret there)
3 Input [RETURN KEY][RETURN KEY]a

Expected output:
[NEWLINE][NEWLINE]अ

Actual Output:
[NEWLINE]अ[NEWLINE]

As long as the return keys have been pressed, everything is fine and the caret is in the second newline. However, as soon as a is pressed, the input is in the first new line and not the second. The caret has hence moved up one line before the input is placed into the output text. The caret does not move back and is after the output अ

This text is selectable, but can't be copy-pasted into an external text editor.
The text is removable, so this is not entirely Bug 53708 . However, pressing a backspace when the caret is after अ removes अ along with the newline that precedes it.

[1]: https://bugzilla.wikimedia.org/show_bug.cgi?id=53708#c4
[2]: https://bugzilla.wikimedia.org/show_bug.cgi?id=53708#c7
[3]: https://bugzilla.wikimedia.org/show_bug.cgi?id=53708#c10

--------------------------
**Version**: unspecified
**Severity**: normal
As of https://gerrit.wikimedia.org/r/#/c/264577/ in #jquery.ime this should now be resolved and working for all users, and will be part of the wmf.12 release starting tomorrow.
Hi,

Confirming the above problem for VE+ULS (Typing input Marathi:अक्षरांतरण) Tested with Win 7 + Firefox 24.0 

*Plus additional issue observed after Automatic Incorrect caret movement when I kept typing It started eating up text on right side in continuous movement simmiller to the problem described in Bug 53757 .




Thanks and Regards
Screenshot showing text duplication

This bug was observed when continuing testing from https://bugzilla.wikimedia.org/show_bug.cgi?id=53706#c3

The entire test procedure is as follows:

System Environment:
Windows7 X64 SP1
Google Chrome 29.0.1547.66 m

Test Url:
https://www.mediawiki.org/wiki/User:Siddhartha_Ghai/sandbox?veaction=edit

Steps:
Enable ULS IME hindi transliteration
Take a caret to the end of the first paragraph using the mouse (i.e click at
the end of the first paragraph to take the caret there.)
Input ag
Output will be अग् as expected but with incorrect selection as reported in the comment linked above
Further input a
This causes the text अग to show up at the beginning of the page with the text अग् at the end of the first paragraph remaining as it is.

What should have happened:
The original output अग् should have been changed to अग at the end of the first paragraph.

So effectively the text is duplicated at the beginning of the page. This means that first the caret moves to the beginning of the page, then the text is duplicated.

Note: The text is navigable and removable, so this is different from Bug 53708 and Bug 53711

--------------------------
**Version**: unspecified
**Severity**: normal

**Attached**: {F11824}
As of https://gerrit.wikimedia.org/r/#/c/264577/ in #jquery.ime this should now be resolved and working for all users, and will be part of the wmf.12 release starting tomorrow.
Automatic Incorrect caret movement has been reported separately as Bug 54424
This is a sub project of bug 53697 https://www.mediawiki.org/wiki/Continuous_integration/Browser_tests

It covers setting up the Zuul configuration to trigger browser tests. From the wiki page:

The exact workflow would need to be figured out with the VisualEditor team. A first step would be to run the browser tests after a change has been merged and report back in Gerrit for their information.
At first we will only want to run browser tests after a change has been merged. This let us load the system progressively without disrupting the VisualEditor authors.

We can later on make Zuul report back in Gerrit a message stating the result of the tests, that will raise awareness among developers and they can work on fixing the unsuccessful tests. Additionally, we can have the browser tests to be triggered on every patchset, the labs instance load will have to be carefully monitored.

Once tests are properly passing and the setup has been proven useful, we can make Zuul to block patchsets not passing the browser tests. The developers would then be required to fix the code or the test to have their change merged in

--------------------------
**Version**: wmf-deployment
**Severity**: enhancement
Being added on an ongoing basis. Already added the ULS browser tests in the Zuul 'test' pipeline.
CCing Željko Filipin on any continuous bug related to browsertests. Main tracking bug is: bug 53697, see https://bugzilla.wikimedia.org/showdependencytree.cgi?id=53697&hide_resolved=0
For end users and VE folks the non-selser _rt end point is often confusing, as it shows diffs that are normally avoided by selser. It would be useful to add a _rtselser end-point that serializes to HTML, re-parses that HTML (to catch foster-parenting issues) and then serializes it back with selser enabled.

This will provide us with a quick sanity check for the selser code, and a better link for end users and VE to establish that something has indeed dirtied the DOM.

--------------------------
**Version**: unspecified
**Severity**: normal
Change 85990 merged by jenkins-bot:
Bug 54339: Add _rtselser endpoint in web API

https://gerrit.wikimedia.org/r/85990
Change 85990 had a related patch set uploaded by Marcoil:
Bug 54339: Add _rtselser endpoint in web API

https://gerrit.wikimedia.org/r/85990
(In reply to comment #2)
> (In reply to comment #1)
> > Just for clarity, this will catch any unhandled fostered parenting issues in
> > Parsoid.
> Depending on how it's written, it could catch these (or have a mode to detect
> these), by serializing the DOM out to a string and parsing it back in again.

Yes, that is the intention. 

> With or without this kind of DOM normalization though, mass-testing articles
> to find selser bugs would be very awesome.

We haven't yet figured out how to do this reliably. We still have same problem that I mentioned on the VE/F page about absence of an oracle to tell us authoritative wikitext to compare against. So, the best we can do is simulate null edits, or modify text, etc. But those are, for the most part, the uninteresting bits of selser testing -- the most interesting bugs show up with more complex edits, and that is the bit that needs to be solved for using it in an automated manner in rt-testing.
(In reply to comment #1)
> Just for clarity, this will catch any unhandled fostered parenting issues in
> Parsoid.
Depending on how it's written, it could catch these (or have a mode to detect these), by serializing the DOM out to a string and parsing it back in again.

With or without this kind of DOM normalization though, mass-testing articles to find selser bugs would be very awesome.

> VE-DOM-dirtying will not be caught by this.
Fortunately, VE does its own detection for this at run time: https://en.wikipedia.org/w/index.php?title=Special:RecentChanges&tagfilter=visualeditor-needcheck
Just for clarity, this will catch any unhandled fostered parenting issues in Parsoid. VE-DOM-dirtying will not be caught by this.
As of https://gerrit.wikimedia.org/r/#/c/264577/ in #jquery.ime this should now be resolved and working for all users, and will be part of the wmf.12 release starting tomorrow.
As of https://gerrit.wikimedia.org/r/#/c/264577/ in #jquery.ime this should now be resolved and working for all users, and will be part of the wmf.12 release starting tomorrow.
Editable content in Read mode

Further, after everything stated in Comment 1 has happened, if VE editing is canceled and the js prompt about losing unsaved changes is confirmed, the second error still continues. The tab is set to Read instead of Edit, however the content is still editable and the VE toolbar remains visible (although it doesn't seem to work).

**Attached**: {F11633}
Related/similar bug: Bug 51526
I am trying to VEdit https://en.wikipedia.org/w/index.php?title=User:Elitre_%28WMF%29/Sandbox&oldid=573480590&veaction=edit , which is a blank version of my sandbox. There's a lot of white space between the title of the page and the point where I can start adding text, and although the source editor says the page is really empty, looks like there's still something there.

If I hover with the mouse right below the comma in the tagline "Wikipedia, the free encyclopedia", the cursor changes as if there's an invisible link.
1) Right under the comma, the "link" points to my userpage (it's clickable, and the page will open in the same tab);
2) some pixels below, the link will point to [[Help:Page History]];
3) going further down, it points to a diff of the sandbox.
There are other points in the page which trigger the links, but the page history one is not easy to spot.

--------------------------
**Version**: unspecified
**Severity**: minor
**See Also**:
https://bugzilla.wikimedia.org/show_bug.cgi?id=52243
https://bugzilla.wikimedia.org/show_bug.cgi?id=58063
Change 107133 merged by jenkins-bot:
Hide #contentSub properly

https://gerrit.wikimedia.org/r/107133
Change 107133 had a related patch set uploaded by Jforrester:
Hide #contentSub properly

https://gerrit.wikimedia.org/r/107133
Only partly a dupe of bug 52243.
The hidden text that causes this, if selected and copy/pasted elsewhere, reads:
< User:Elitre (WMF)
This is an old revision of this page, as edited by Elitre (WMF)  (talk | contribs) at 10:57, 18 September 2013. It may differ  significantly from the current revision.
Revision as of 10:57, 18 September 2013 by Elitre (WMF)  (talk | contribs)

This is reported as being common also in articles.
Thanks.
VisualEditor is installed already. Would be nice to have TemplateData as well.

--------------------------
**Version**: unspecified
**Severity**: enhancement
This seems to have been done, I think by the wikitech config/deployment changes.
Because about half the code in the DM is solely there to keep this delicate data structure together, and now that we don't need ±1 cursoring it seems like a lot of effort for nothing.

The behaviour it provides (protecting metadata from deletion) can all be done in the transaction builders, and in fact we already do this for internal lists)

Going forward this will make multi user editing a lot easier to.

That said this is going to be a massive commit.

-----

Currently, MetaItems are stored outside the main linear data structure, in a separate meta linear data structure. This complicates the processing of linear data: transaction processing, rebasing, serialization/deserialization etc, and makes it harder to reason about document correctness. Instead:
* Store metadata as block nodes in the main data list
* On conversion from HTML, hoist metadata found in a content position to a legal structural position
* On conversion back to HTML, roundtrip metadata hoisted from unmodified content branch nodes back into the original content position
* When deleting across metadata (e.g. <p>foo[-</p><meta/><p>-]bar</p>), hoist metadata to a legal structural position as necessary
Gosh.
Change 405751 **merged** by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (c5fddd508)

[[https://gerrit.wikimedia.org/r/405751]]
Change 405751 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (67548dc57)

[[https://gerrit.wikimedia.org/r/405751]]
Change 385492 **merged** by jenkins-bot:
[VisualEditor/VisualEditor@master] [BREAKING CHANGE] Store metadata as block nodes in the main data list

[[https://gerrit.wikimedia.org/r/385492]]
Change 336929 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/VisualEditor@master] [WIP] [PULLTHROUGH] MW changes for the meta-data inlining commit

[[https://gerrit.wikimedia.org/r/336929]]
Change 336925 abandoned by Divec:
WIP: [BREAKING CHANGE] Store metadata as block nodes in the main data list

Reason:
Moved to Ib5174b0dcba1c24f44d889e08140bee31a064011

[[https://gerrit.wikimedia.org/r/336925]]
Change 385492 had a related patch set uploaded (by Divec; owner: Divec):
[VisualEditor/VisualEditor@master] WIP: [BREAKING CHANGE] Store metadata as block nodes in the main data list

[[https://gerrit.wikimedia.org/r/385492]]
Change 336925 had a related patch set uploaded (by Jforrester):
[BREAKING CHANGE] Store metadata as block nodes in the main data list

[[https://gerrit.wikimedia.org/r/336925]]
Change 336899 had a related patch set uploaded (by Jforrester):
Update VE core submodule to master (0dfc50a88)

[[https://gerrit.wikimedia.org/r/336899]]
Change 314568 merged by jenkins-bot:
Store metadata as block nodes in the main data list

[[https://gerrit.wikimedia.org/r/314568]]
Change 314568 had a related patch set uploaded (by Jforrester):
Store metadata as block nodes in the main data list

[[https://gerrit.wikimedia.org/r/314568]]
We now have ve.dm.Node.static.isDeletable.
This would also solve the problem of the resize marker having to snap into the right position at the end of a drag if you use the wrong handle (or any handle if the image is centred)

--------------------------
**Version**: unspecified
**Severity**: normal
Change 89814 merged by jenkins-bot:
Resizable node live preview

https://gerrit.wikimedia.org/r/89814
Change 89814 had a related patch set uploaded by Esanders:
Resizable node live preview

https://gerrit.wikimedia.org/r/89814
**Author:** `renukaalurkar`

**Description:**
1)Logged in to http://en.wikipedia.beta.wmflabs.org/wiki/Main_Page
2)Go to your user page.
3)Click on Languages/cog, select Input and click on Enable Input tools.
4)Click on Edit beta tab.
5)Click on More, and using Media, select a couple of pictures
6)Click on the tiny keyboard/typewriter and select language as Hindi or Telugu
7)Now start entering text in Hindi or Telugu.

Observations:
1)After typing a few letters, the cursor jumps back to the beginning of the sentence.
2)Sometimes, when Enter is hit, the cursor goes back to the beginning of the paragraph.
3)Sometimes, when Enter is hit one of the images disappears.Write some more and the other image also disappears.
4)Click on Save page button
5)Now both the images are visible again.

Observed on Firefox 24.0 and Chrome 29.0.1547.66

--------------------------
**Version**: unspecified
**Severity**: normal
As of https://gerrit.wikimedia.org/r/#/c/264577/ in #jquery.ime this should now be resolved and working for all users, and will be part of the wmf.12 release starting tomorrow.
I've set my Language settings on https://en.wikipedia.org to using native keyboard for Hindi input.

> 5)Click on More, and using Media, select a couple of pictures
> 6)Click on the tiny keyboard/typewriter and select language as Hindi or Telugu

Where exactly? In the "alternative caption" field of the "Insert Image" dialog? Some other field? The text of the page you edit?
At least for लिप्यंतरण and इनस्क्रिप्ट I cannot reproduce any jumping back of the cursor in the "alternative caption" field.

The steps to reproduce this problem are a bit unclear (but probably only because the user interface has changed since this problem was reported). 

Clarification highly welcome.
? should be ؟ icon

For  Notification Tool for  RTL languages Please change "?" icon in attached image to RTL icon

See @Amire80's comment.  Not the same for all languages.

--------------------------
**Version**: unspecified
**Severity**: normal
**See Also**:
https://bugzilla.wikimedia.org/show_bug.cgi?id=54252

**Attached**: {F11507}
I believe that this is now long-since fixed, since we moved to OOjs UI.
VisualEditor seems to deal with this issue with the help button (also presented as ?)

It might help checking what lists they have to when to flip the question mark and when not to, and use that same strategy in this case.
**nzmoihue** wrote:

Seems dvwiki is also using "؟" http://dv.wikipedia.org/wiki/%DE%88%DE%A8%DE%86%DE%A8%DE%95%DE%A9%DE%91%DE%A8:%DE%A2%DE%A7%DE%82%DE%B0%DE%89%DE%AA_%DE%80%DE%AE%DE%85%DE%AA%DE%87%DE%A6%DE%81%DE%A8 (find "؟" on that bug using Ctrl+F)

I guess something like https://github.com/wikimedia/mediawiki-core/blob/9ea365dcb2f1390e117767e0ead4a5655ad4631d/skins/common/shared.css#L240 is needed for reversed question mark
This is not needed for all languages.

It is definitely not needed for Hebrew and Yiddish.

It is *probably* needed for all languages written in the Arabic script.

I'm not sure about Divehi (dv) and Aramaic (arc).
**bsitu** wrote:

Oops, the patch referenced the wrong bug
Change 89249 had a related patch set uploaded by Bsitu:
Notification overlay is partially hidden in RTL language

https://gerrit.wikimedia.org/r/89249
**bsitu** wrote:



%%%*** This bug has been marked as a duplicate of bug 54252 ***%%%
Prioritization and scheduling of this bug is tracked on Mingle card https://mingle.corp.wikimedia.org/projects/flow/cards/252
To devs:
You just need to add element like "#mw-echo-overlay-moreinfo-link" but with a "transform:scaleX(-1);" [1] to the ext.echo.overlay.css
and call that element instead the ltr one in ext.echo.overlay.js when .sitedir-rtl is true [2]

[1]: http://nicolasgallagher.com/css-background-image-hacks/
[2]: https://www.mediawiki.org/wiki/Manual:Interface/IDs_and_classes

Best
See
https://en.wikipedia.org/w/index.php?title=Fizeau_experiment&diff=573001070&oldid=572299847 - the user corrected a typo and this resulted in the references groups getting duplicated.
Reproduced in 
https://en.wikipedia.org/w/index.php?title=User:Elitre_(WMF)/Sandbox&diff=prev&oldid=573341379 and https://en.wikipedia.org/w/index.php?title=User:Elitre_(WMF)/Sandbox&diff=next&oldid=573340833 while just testing wikilinks, as you can see. My first attempt to reproduce this actually resulted in more weird (although known, I think) behaviour: https://en.wikipedia.org/w/index.php?title=User:Elitre_(WMF)/Sandbox&diff=prev&oldid=573176079 .
Thanks.

--------------------------
**Version**: unspecified
**Severity**: normal
I've tried to reproduce this using @Elitre's testcases, but couldn't; I'm tentatively closing as fixed.
I wonder if this is still valid.
https://fr.wikipedia.org/w/index.php?title=Archives_sociales_suisses&diff=96769347&oldid=96768850

https://fr.wikipedia.org/w/index.php?title=Jeu_vid%C3%A9o_ind%C3%A9pendant&diff=95172709&oldid=95071765
Edit a page with One&nbsp;Two which displays as One Two.  Select the entire text, copy, past at end of the string.  Displays in VE fine at first.  Saving however produces One&nbsp;TwoOneTwo which displays as One TwoOneTwo. 

Originally from 
http://en.wikipedia.org/w/index.php?title=Wikipedia:VisualEditor/Feedback&curid=37904286&diff=573462315&oldid=573461696

--------------------------
**Version**: unspecified
**Severity**: normal
Change 89356 merged by jenkins-bot:
Bug 54262: Serialize new entity to its contents

https://gerrit.wikimedia.org/r/89356
(In reply to comment #2)
> Is data-parsoid copied as well?

Never mind, the title had that info.
Change 89356 had a related patch set uploaded by GWicke:
Bug 54262: Serialize new entity to its contents

https://gerrit.wikimedia.org/r/89356
Is data-parsoid copied as well?
<p>Foo<span typeof="mw:Entity">&nbsp;</span>Bar</p>

converts to

FooBar

which appears to be the problem
DKqwerty at en.wp reports: "Article Futurama took 58 seconds to load into VE, with the loading bar running the entire time. I think this is unacceptable as it is probably off-putting to inexperienced users. Further, the bar just fills, empties, fills, empties, etc. rapidly and continuously until the page is loaded... Would it be possible to make this bar actually indicate what percentage has been loaded so editors have at least a hint that something is being processed?"
Thanks.

--------------------------
**Version**: unspecified
**Severity**: enhancement
Implemented by Ed in https://gerrit.wikimedia.org/r/#/c/196583/
Not sure how we'd judge progress on this one, but it'd be useful for users…
Moving here the following proposals:
<https://strategy.wikimedia.org/wiki/Proposal:Text_or_Syntax_driven_Charts,_Diagrams,_Graphs_and_more>
<https://strategy.wikimedia.org/wiki/Proposal:Editable_Graphics>
<https://strategy.wikimedia.org/wiki/Proposal:Markup_for_charts_and_graphs>
(with some of the participants in cc).

* «By now Wikipedia has markup/code for everything—math (TeX), parser functions, location maps, and even SVG is supported. However, what is notably missing from many articles (other than high-quality portraits) are graphs and charts.»
* «There are many types of diagrams. The need for collaborative graphics is wide ranging, from map making to biochemical pathways to flow charts to genealogy to general charting. Each type of graphic has or could have a little language, XML or other representation to define graphics of that type succinctly. Whilst all can be presented as .pngs or .SVGs, the more succinct description is necessary for editability.»

This is distinct from bug 43616 (Provide a way to create interactive 2D/3D timelines and infographics e.g. Java applets, AJAX, Flash) in that it's not about *interactive* stuff and that there are some existing extensions which someone should assess and develop for Wikimedia purposes. I'd also leave maps out of it because that's being addressed (at last) elsewhere.
Part of it will be solved by bug 38271, but only to a degree.

Mentioned extensions: [[mw:Extension:Graph]], [[mw:Extension:GnuplotBasic]], [[mw:Extension:Plotters]], [[mw:Extension:WikiPlot]].

Keywords from the proposals: http://bloodgate.com/perl/graph/, Java .jar, Flash .swf, Silverlight .scr, ActiveX .ocx, Vector (.svg) .svg (XML), AnyWikiDraw, AnyWikiDraw, WikiPathways, WikiTex, Graph Plugin, DPL Bundle, TeX, gluplot, pgfplots.

--------------------------
**Version**: unspecified
**Severity**: enhancement
Actionable tasks are not the only use case for Phabricator; cf. for example the #Epic project.  Additionally, I think tasks with subtasks are very preferable to projects in some cases as they themselves have a status, a dependency tree, etc.

This task has two blocking subtasks that have not been resolved, so this task itself does not seem to be resolved.  AFAIUI, for example you don't want to work on T56222 (which is fine), but that also means that someone else needs to do the deed to convert those cladograms to Extension:Graph (or something else).
@nemo_bis, this is not what the bug description states. I think the better use of phabricator would be to create small, actionable, and well scoped tasks for specific feature, and mark those with some project tag for tracking. Otherwise this task grows infinitely large and not very useful. Having small tasks allows each feature to be discussed separately, and different devs can pick them up for implementation.  The only reason why we had the [tracking] tasks in Bugzilla was because there was no good support for tagging (projects).
This bug's purpose is precisely to collect requirements and map alternatives. Two of them are identified by the two blockers. :) If you think the usecase behind that extension is another, please add to blockers.
Closing because we now have <graph>, and because this task is too broad. Please add more specific tasks for anything that's missing :)
@yurik OK.  I'm happy now.  Yep, I did know d3.js was under Vega, just previously had doubts that enough of that flexibility was exposed.   We can't have end users writing arbitrary javascript, so how the functionality is exposed really matters.

I think I am already now OK with this task being closed.  There is obviously tons more to do and tons more that could be done, but the basics of the template driven transform of json to svg or canvas are there, which is what this task was asking for.
@jamescrook, you mean [this example](http://vega.github.io/vega-editor/?mode=vega&spec=force)?  Also here is an [interactive version](http://vega.github.io/vega-editor/?mode=vega&spec=force_drag).

As for d3 - vega is based on d3, so, in theory, most of the capabilities of d3 are exposed. But yes, we will have to dig through it.
@jamescrook, you mean [this example](http://vega.github.io/vega-editor/?mode=vega&spec=force)?  or an [interactive version](http://vega.github.io/vega-editor/?mode=vega&spec=force_drag)

As for d3 - vega is based on d3, so, in theory, most of the capabilities of d3 are exposed. But yes, we will have to dig through it.
@Yurik , looking at the source for that tree it looks to be d3.js rather than Vega.
@yurik Vega doesn't currently seem to support those, at least not from the examples I can find.  They are motivating examples, so should not be swept under the carpet.  Biochemical pathways, flow charts and genealogy are all similar in being based on graphs (i.e. networks).  The Vega examples I am seeing are plots and maps.

I am wondering why I am seeing no force directed layouts with Vega, although the visual encoding transform is described in the documentation.  If we can get even a basic demo of some biochemical pathway done using a force directed layout then I am cool with this task being closed.  Elaboration and prettiness can come later.
Just found this [expandable tree sample](http://bl.ocks.org/alcy/raw/7702db089164c493a705/) that seems to be based on Vega with some additional hacks. Might be interesting to build something similar.  And of course there are existing samples like [heatmap](http://vega.github.io/vega-editor/?mode=vega&spec=heatmap&renderer=svg) and many other that might be useful.
CC: @jamescrook
@jamescrook, we have to narrow down this task, otherwise it sounds like "create a platform that allows everything", which is not really actionable.  From my reading of the description, Vega 2.0 should be able to handle most of it. If not, please create separate task that we can discuss.
Yurik, how does this address "biochemical pathways to flow charts to genealogy" from the description?
Should this be closed?  We now have interactive graphs/charts/etc: https://www.mediawiki.org/wiki/Extension:Graph/Demo#Vega_2.0_Interactive_Examples
Actually, this was one of the rawest ideas in the project list and is absolutely not usable for GSoC, unless a student comes who has an extremely clear idea of a feature to add and a plan for it. I'll move the possible project tag to T56222. The other blocker, T40271, would also be suitable, but I doubt it would benefit from GSoC (iterative GSoC cycles over the same problem rarely helped anything).
This task is about wikitext. VisualEditor support for the markup is a separate issue.
@qgil, I can totally see this becoming a GSoC project, but most of the mentorship would have to come from the UI/Visual Editor team because they have the expertise in building custom editors.  The student would build an editor with a dynamically updated viewer for the VE.  I already have a simplified version of that [[ http://graph.wmflabs.org/w/index.php?title=Graph:Stocks&action=edit | here ]] -- click preview and try changing the graph definition.
Wikimedia will [[ https://phabricator.wikimedia.org/T921 | apply to Google Summer of Code and Outreachy ]] on Tuesday, February 17. If you want this task to become a featured project idea, please follow [[ https://phabricator.wikimedia.org/project/view/1042/ | these instructions ]].
@Milimetric, @Yurik, is there a possible project related to this task that students like @Sumit could plan for in the context of Google Summer of Code 2015 (and that you would like to mentor)? Something about #MediaWiki-extensions-Graph ?
> I'd like to take this up as a project. Is this still open for taking up and developing for this year?

It's open, but not ready. Please choose one of the extensions mentioned by this report and start filing patches against them. When you find one you're comfortable developing, you'll know the area you can work on.
I'd like to take this up as a project. Is this still open for taking up and developing for this year?
Sorry, meant to post last comment for bug 43616.  Yet, for this request, graph ext is still applicable, except that it is not wysiwyg unless some brave soul starts hacking a proper vega editor.
Graph extension might be applicable, even though it is not dynamic (yet), or even in production wikis, it does support various timelines, e.g. "Napoleon" at http://trifacta.github.io/vega/editor/ :)

See https://www.mediawiki.org/wiki/Extension:Graph and samples at https://www.mediawiki.org/wiki/Extension:Graph/Demo 

Discussion at https://meta.wikimedia.org/wiki/Wikimedia_Forum#Graphs.2C_Maps.2C_..._.28experimental.29
I think what you're saying makes sense Pavel.  And no worries, to participate in this community you have to be really good at dealing with distractions.  I'm still waiting for someone else to help with mentoring on this important project.  I think someone with mediawiki extension development experience would be great.  Part of the reason I can't comment more, Pavel, is that I don't know anything about mediawiki extensions :)
Dan, thank you for pushing this proposal. If you want to jump to the GSoC 2014 train you need to:

* Take https://www.mediawiki.org/wiki/Mentorship_programs/Possible_projects#Support_for_text.2Fsyntax.2Fmarkup_driven_or_WYSIWYG_editable_charts.2C_diagrams.2C_graphs.2C_flowcharts_etc. , shorten the title, expand the description (one paragraph is enough), and move it under https://www.mediawiki.org/wiki/Mentorship_programs/Possible_projects#Featured_project_ideas

* Find a second mentor.

The sooner the better, since Wikimedia will be evaluated by the GSoC organizers in the next 1-2 weeks. You will know you are ready when your project looks great at https://www.mediawiki.org/wiki/Google_Summer_of_Code_2014

More: http://lists.wikimedia.org/pipermail/wikitech-l/2014-February/074277.html
Thanks Pavel.  I like the syntax you mention.  The advantage to using Vega JS syntax would be that it's a healthy active project and we get the parser, etc. for free.  Check it out if you haven't had a chance, I linked to it above.
I'd suggest using a scripting language as markup for the editable charts, diagrams, graphs, flowcharts etc.

For end users this may be like the example:

== Extension:Graph ==

 G { "Bonn" --> "Berlin" [ style: bold; ] }    
As
Graph( [ "Bonn" => [ "Berlin", "style"=>"bold" ] ] );
or 
$bonn = node("Bonn");
$bonn->linkTo( node("Berlin", "bold") );
Graph( $bonn );

== Extension:WikiPlot ==

<wikiplot height="200" width="200" caption="Simple plot" xspan="-100;100" yspan="-100;100">
        <graph label="Graph 1." color="255,0,0">x+4</graph>
        <graph label="Graph 2.">3*x-3</graph>
</wikiplot>

as 

$plot = new Plot( ['height'=>200, 'width'=>200, 'caption'=>'Simple plot', 'xspan'=>[-100, 100], 'yspan'=>[-100, 100] ] );

or 

$plot = new Plot();
$plot->height = 200;
$plot->width = 200;
$plot->caption = "Simple plot";
$plot->xspan = [-100, 100];
$plot->yspan = [-100, 100];

and

$plot.addGraph( ['x+4', 'label'=> 'Graph 1.', 'color'=>[255,0,0] ]);

$graph = new Graph( "3*x-3" );
$graph->label = 'Graph 2.'
$plot.add( $graph );

echo $plot;

It looks like directly code execution, but it is not.
I did mw:Extension:Foxway for testing possibility of this. I ascertained that this may work and may work quickly.
Now I do new mw:Extension:PhpTags. There any extension can register a hook as a constant, function or object.
So far I have only worked on the functions and constants, and did not start work on objects.
I am sure that the PhpTags will cover all the needs and will be convenient and powerful tool.
I would like to find someone interested in discussing this.
tl;dr; I would be interested in being a mentor here, and probably collaborating until a solution is reached.

We've done some thinking about this while we developed Limn [1] last year.  I believe Limn was headed in the wrong direction, but we (team analytics) are interested in solving this problem and it would be nice to combine efforts with anyone that is also interested.  Currently, I believe that Vega JS [2] is a very promising library.  It has a great mixture of simplicity and power.

My personal opinion is that creating and editing infographics would work much like Visual Editor does.  There would be a simple JSON editor on the front end, which could evolve over time.  When saved, this would use a server to generate static infographics for consumption by the cache layer.  The dynamic infographic could be accessed through a link on the static image.  The cache could be repopulated with up-to-date infographics periodically if they depend on external data.  For this vision, Vega JS is quite suitable as it can generate PNGs server side for example.


[1] https://github.com/wikimedia/limn
[2] http://trifacta.github.io/vega/
(In reply to comment #4)
> Should this project be still listed in that page? 

Yes.

> If not, please remove it.
> If
> it still makes sense, then it could be moved to the "Featured projects"
> section
> if it has community support and mentors.

It lacks a mentor, plus (probably) someone to set a direction/the requirements (who may or not be the same person).
**vladjohn2013** wrote:

Hi, this project is still listed at  https://www.mediawiki.org/wiki/Mentorship_programs/Possible_projects#Support_for_text.2Fsyntax.2Fmarkup_driven_or_WYSIWYG_editable_charts.2C_diagrams.2C_graphs.2C_flowcharts_etc. 

Should this project be still listed in that page? If not, please remove it. If it still makes sense, then it could be moved to the "Featured projects" section if it has community support and mentors.
Is there an interest in proposing this project for Outreach Program for Women?
If so, and if there at least one mentor for it. please move it to the "Featured projects" section. This way it will be automatically transcluded in
https://www.mediawiki.org/wiki/Outreach_Program_for_Women/Round_7

Thank you!
Correction, the links are: [[mw:Extension:WikiTeX]] (and [[mw:Extension:WikiTex]]).
What about reviving [[Extension:WikiTeX]] (not to be confused with [[Extension:WikiTex]])? This would have done graphs, plots, and more. It would be handy for it to also support simple circuit diagrams.
See https://github.com/mdevils/node-jscs

This is the first tool I've seen in the category of asserting coding style for javascript that actually looks like it is worth looking into further.

I intend to experiment with it in the near future for 1 or 2 projects, first in non-voting mode and perhaps later to become a standard enabled job for many projects.

--------------------------
**Version**: wmf-deployment
**Severity**: enhancement
>>! In T56218#973118, @adrianheine wrote:
> Cool, thanks. I added `npm test`, although I didn't go through grunt since we are not running any other grunt jobs, yet:
> 
> * Wikibase: https://gerrit.wikimedia.org/r/#/c/184591/
> * integration/config: https://gerrit.wikimedia.org/r/#/c/184592/

That's quite alright. If you don't need do run bash commands like `mv`, `cp`, `rm`, `ln` etc. which might not work cross-platform if put inside `scripts.test` (so you'll want to use a nodejs script or Grunt task for that); Running programs like jscs and jshint directly is perfectly fine and actually quite common. I've recently started to use this more often as well. Only use Grunt when there's a need for it. This avoids added complexity, needless abstraction, and indirect dependencies on the underlying framework (e.g. jscs/jshint) which can be quite annoying since it doesn't like being pinned to a direct version that way.

http://blog.keithcirkel.co.uk/how-to-use-npm-as-a-build-tool/
http://ponyfoo.com/articles/choose-grunt-gulp-or-npm
Cool, thanks. I added `npm test`, although I didn't go through grunt since we are not running any other grunt jobs, yet:

* Wikibase: https://gerrit.wikimedia.org/r/#/c/184591/
* integration/config: https://gerrit.wikimedia.org/r/#/c/184592/
>>! In T56218#972923, @adrianheine wrote:
> Is there work being done to get this run on ci? I'd like to push this for Wikibase as well :)

You will need a package.json and a npm 'test' entry point with a devDependencies for grunt-jscs.  From there we can add a Jenkins job that invokes 'npm test' and that should run jscs.

Example:

https://gerrit.wikimedia.org/r/#/c/100732/

More details at https://www.mediawiki.org/wiki/Continuous_integration/Test_entry_points#JavaScript :-)
Is there work being done to get this run on ci? I'd like to push this for Wikibase as well :)
Sounds good to me Timo. That nicely scale up CI to developers :-)
The bug is to figure out how to properly do it. Which I define by hacking it together for one repo, and as you repeat it for more repos you refine it until it seems sensible/maintainable.

I think we've reached that point. Any further repos that want it, can enable it the same way other pipelines are introduced. By patching their Gruntfile or adding a new npm-test pipeline.
Is this intended to be a tracking bug for every repo, a bug for it to be done automatically for all repos and then repos that now break need to fix themselves, or can it be marked as FIXED?
Change 111963 merged by jenkins-bot:
Set up node-jscs via Grunt (and pass it)

https://gerrit.wikimedia.org/r/111963
Change 111963 had a related patch set uploaded by Krinkle:
[WIP] Set up node-jscs via Grunt (and pass it)

https://gerrit.wikimedia.org/r/111963
Change 100732 merged by jenkins-bot:
Set up node-jscs, pass it, and configure in local Gruntfile

https://gerrit.wikimedia.org/r/100732
Change 100732 had a related patch set uploaded by Krinkle:
Set up node-jscs, pass it, and configure in local Gruntfile

https://gerrit.wikimedia.org/r/100732
Now merged locally in the repo for VisualEditor, and appears to be adding value; moving back to NEW for consideration to be added to jenkins for automated running.
Change 99596 merged by jenkins-bot:
Set up node-jscs, pass it, and configure in local Gruntfile

https://gerrit.wikimedia.org/r/99596
Change 99596 had a related patch set uploaded by Krinkle:
Set up node-jscs, pass it, and configure in local Gruntfile

https://gerrit.wikimedia.org/r/99596
node-jscs would be purely for coding style, not code quality (which is what jshint is primarily for).

Although there are a few minor things that jshint does in the realm of coding style, those are arguably code quality as well (like using of braces in if/else blocks).

This would allow us to validate the complete coding style (especially with regards to whitespace), which right now is mostly enforced by leaving comments in code review and fixup commits pointing to [[mw:CC/JS]].
Unrelated.
Is that a replacement for JSHint or unrelated?
e.g. fr -> Français, cy -> Cymraeg

--------------------------
**Version**: unspecified
**Severity**: enhancement
Change 98284 merged by jenkins-bot:
Show full language names in the MW language dialog

https://gerrit.wikimedia.org/r/98284
Change 98284 had a related patch set uploaded by Esanders:
Show full language names in the MW language dialog

https://gerrit.wikimedia.org/r/98284
Around the time when VE started to support editing of pres we started to get dirty diffs like this:

http://www.mediawiki.org/w/index.php?title=Parsoid&diff=779292&oldid=777387

This might either be a selser issue, or VE dirtying the DOM.

--------------------------
**Version**: unspecified
**Severity**: normal
*** Bug 53775 has been marked as a duplicate of this bug. ***
Change 84896 merged by Catrope:
Fix check for preformatted when stripping whitespace

https://gerrit.wikimedia.org/r/84896
Change 84896 had a related patch set uploaded by Catrope:
Fix check for preformatted when stripping whitespace

https://gerrit.wikimedia.org/r/84896
Change 84332 merged by jenkins-bot:
Fix check for preformatted when stripping whitespace

https://gerrit.wikimedia.org/r/84332
Change 84332 had a related patch set uploaded by Esanders:
Fix check for preformatted when stripping whitespace

https://gerrit.wikimedia.org/r/84332
There's a check tag on the edit, so VE dirtied something somewhere. That may or may not explain the whole bug, but we should fix it.
For BLP's and disambiguation pages on the English Wikipedia, an extra edit notice is provided through the https://en.wikipedia.org/wiki/Wikipedia:EDITINTRO system using Extension:InputBox and some code in MediaWiki:Common.js. VisualEditor does not work with Extension:InputBox, so the edit notice is not displayed. 

This hack is being used in several Wikimedia wikis besides the English Wikipedia:

* https://ja.wikipedia.org/wiki/MediaWiki:Common.js
* https://zh.wikipedia.org/wiki/MediaWiki:Common.js
* https://vi.wikipedia.org/wiki/MediaWiki:Common.js

See also [[https://www.wikidata.org/wiki/Q10566946| Template:BLP editintro (Q10566946)]] and [[https://www.wikidata.org/wiki/Q14400704|  Template:Disambig editintro (Q14400704) ]] for more of the potentially affected wikis.

--------------------------
**Version**: unspecified
**Severity**: normal
Change 329796 merged by jenkins-bot:
Add editintro to notices

[[https://gerrit.wikimedia.org/r/329796]]
Change 329796 had a related patch set uploaded (by Esanders):
Add editintro to notices

[[https://gerrit.wikimedia.org/r/329796]]
I think it is better than editintro+JS yes.
One way to fix this, as @Cenarium has observed, would be to fix {T85372} and switch wiki(?s) over to use that instead; is this the best option?
>>! In T56029#945042, @Cenarium wrote:
>
> Adding support in VE for preload / editintro is still worthy on its own, but it looks like this task is a duplicate of T51622.

Now Merging.
>>! In T56029#1098976, @Cenarium wrote:
> I've uploaded a patch for this (per-category editnotices) : [[https://gerrit.wikimedia.org/r/#/c/189178/|commit 189178]].

I've updated the patch, it works properly now.
I've uploaded a patch for this (per-category editnotices) : [[https://gerrit.wikimedia.org/r/#/c/189178/|commit 189178]].
>>! In T56029#800523, @TheDJ wrote:
> alternatively, get away from this specific implementation and try to move it into core as "category based edit notices" and VE gets the notice for free.

I've created a specific task for per category editnotices, T85372, I had already suggested it for the more general T20596 but this didn't get implemented. 
FYI, the English Wikipedia isn't the only wiki to use this.
Adding support in VE for preload / editintro is still worthy on its own, but it looks like this task is a duplicate of T51622.
alternatively, get away from this specific implementation and try to move it into core as "category based edit notices" and VE gets the notice for free.
To work as desired VE would need to respect the editintro= url parameter. For example
http://en.wikipedia.org/wiki/Paul_Bahn?veaction=edit&editintro=Template:BLP_editintro
and use that to fill in the edit notice with Template:BLP_editintro.
A couple of lines in MediaWiki:Common.js would add the parameters to URL's for all BLPs.
Link for InputBox https://www.mediawiki.org/wiki/Extension:InputBox
For example, onBeforePaste/onAfterPaste in ve.ce.Surface

--------------------------
**Version**: unspecified
**Severity**: enhancement
Thanks, looks like I hadn't properly updated my copy of VE to master. :P
(In reply to comment #1)
> Got a reference doc for EventSequencer?

https://doc.wikimedia.org/VisualEditor/master/#!/api/ve.EventSequencer
Got a reference doc for EventSequencer?
<translate>…</translate> and the related <tvar>…</tvar> are currently un-parsed and shown as plain wikitext in VisualEditor because they're not recognised, per T50891; however, once that is fixed, the blocks won't be editable except as alien nodes (in wikitext), and won't be createable.

Making a proper VisualEditor plugin to translate these in-page as a rich editor shouldn't be particularly hard (he says…).
Also, I don't think I could do this in two weeks, which suggests this is too big for GSoC.
>>! In T55974#2084495, @Micru wrote:
> I see that the stalled bug has been marked as resolved, Could this task become a GsoC project?

Eventually, yes; however this was missing a few dependencies, T49344 chief amongst them. That work might not be done for another year or more.
>>! In T55974#1042621, @Qgil wrote:
> If there is no interest / critical mentoring mass to promote this project for GSoC / Outreachy, then maybe the current "Normal" priority should be lower?

It's not a matter of priority, see blockers: this is blocked on a stalled bug.
If there is no interest / critical mentoring mass to promote this project for GSoC / Outreachy, then maybe the current "Normal" priority should be lower?
Wikimedia will [[ https://phabricator.wikimedia.org/T921 | apply to Google Summer of Code and Outreachy ]] on Tuesday, February 17. If you want this task to become a featured project idea, please follow [[ https://phabricator.wikimedia.org/project/view/1042/ | these instructions ]].
Is it true that parsoid has limitations parsing tags other than "normal parser tags". If yes what are they & why ? I want to make a plugin for VE to embed translate extension as mentioned above. Cant i include my own grammar for parser to do stuffs way i want.?
Pankaj: This bug depends on fixing bug 48891 first (see the "Depends on" field). If something is unclear with comment 0, please explain what is unclear and why. Also see [[mw:Annoying little bugs]].
**pankaj10it45** wrote:

Hello,I want to work on this bug.Can you tell me what exactly it is?
Thank you.
Change 255931 merged by jenkins-bot:
Use white-space: pre-wrap instead of using &nbsp; for spaces

[[https://gerrit.wikimedia.org/r/255931]]
Change 255931 had a related patch set uploaded (by Bartosz Dziewoński):
Use white-space: pre-wrap instead of using &nbsp; for spaces

[[https://gerrit.wikimedia.org/r/255931]]
Still valid:
```
./src/ce/nodes/ve.ce.TextNode.js:		// Replace spaces with &nbsp; where needed
```
From an email conversation I had with Aryeh in January 2012:

(Since I'm thinking about canonicalization of whitespace, a tip: set
white-space: pre-wrap on any contenteditable regions you use, and
wherever you use them.  This will stop you from needing to use nbsp's
in ways they were never intended to be used, which causes a variety of
subtle bugs.  See
<http://dvcs.w3.org/hg/editing/raw-file/tip/editing.html#canonical-space-sequences>
for a basic explanation, and click the first "View Comments" at
<http://dvcs.w3.org/hg/editing/raw-file/tip/editing.html#the-inserttext-command>
for a more detailed explanation of how nbsp substitution works in
practice.)
== Steps ==
1) Go to
https://www.mediawiki.org/wiki/BUG?veaction=edit&uselang=en
2) Click on "BETA"

== Actual result ==
There is the text "Version false" generated by the HTML:

<div>
 <span class="ve-init-mw-ViewPageTarget-version-label">Version</span> 
 <a class="ve-init-mw-ViewPageTarget-version-link"
    target="_blank"
    href="false">false</a> 
 <span class="ve-init-mw-ViewPageTarget-version-date"></span>
</div>

== Expected result ==
There should be some version number instead of the "false" text

--------------------------
**Version**: unspecified
**Severity**: normal
Yes, this was exposed as part of bug 53050, but due to bug 53972 in how code is currently deployed to the WMF cluster, we can't actually make this available outside of Beta Labs (boo). Consequently this was fixed in gerrit 84334 two weeks ago before it hit "real" production wikis (non-MW.org).
I don't see false anymore, but currently there is no element whose class contains "ve-init-mw-ViewPageTarget-version" either. Was this removed on purpose?
I dont see 'false' on mw or en.wp.  I see 'beta'.

Is the originally reported problem fixed, or masked somehow.

I notice that version says '0.1.0', which is not useful as there have been many deploys of the code.  beta's should have build numbers or build dates for each release.

https://www.mediawiki.org/wiki/Special:Version

e.g. ULS is 'Version 2013-06-17'
Article tabs are wrong when page is protected via cascading from another page.

To reproduce: visit https://pl.wikipedia.org/wiki/Wikipedia:Strona_główna?uselang=en and behold the "Edit source" link, even if you're anonymus.

--------------------------
**Version**: unspecified
**Severity**: minor
**See Also**:
https://bugzilla.wikimedia.org/show_bug.cgi?id=11700
Change 128965 merged by jenkins-bot:
Check cascade protection and show notice if relevant

https://gerrit.wikimedia.org/r/128965
Change 128965 had a related patch set uploaded by Alex Monk:
Check cascade protection and show notice if relevant

https://gerrit.wikimedia.org/r/128965
Did something change here? MW shows an edit tab on these pages. If you turn on VE then it changes that "Edit" to "Edit source" and adds a new "Edit", which is what I would expect it to do.

What probably should be done is showing the cascade notice on VE though.
*** Bug 58452 has been marked as a duplicate of this bug. ***
I added role "browsertests", but every time I run `vagrant provision` it fails. It seems to be trying to install an "ffi" (foreign function interface) module.

Fri Sep 06 20:26:53 +0000 2013 /Stage[main]/Browsertests/Exec[install browsertests bundle]/returns (notice): Using rake (10.1.0)
Fri Sep 06 20:26:53 +0000 2013 /Stage[main]/Browsertests/Exec[install browsertests bundle]/returns (notice): Using builder (3.2.2)
Fri Sep 06 20:26:53 +0000 2013 /Stage[main]/Browsertests/Exec[install browsertests bundle]/returns (notice): Installing ffi (1.9.0) with native extensions /usr/lib/ruby/1.9.1/rubygems/installer.rb:552:in `rescue in block in build_extensions': ERROR: Failed to build gem native extension. (Gem::Installer::ExtensionBuildError)
Fri Sep 06 20:26:53 +0000 2013 /Stage[main]/Browsertests/Exec[install browsertests bundle]/returns (notice):
Fri Sep 06 20:26:53 +0000 2013 /Stage[main]/Browsertests/Exec[install browsertests bundle]/returns (notice):         /usr/bin/ruby1.9.1 extconf.rb
Fri Sep 06 20:26:53 +0000 2013 /Stage[main]/Browsertests/Exec[install browsertests bundle]/returns (notice):
Fri Sep 06 20:26:53 +0000 2013 /Stage[main]/Browsertests/Exec[install browsertests bundle]/returns (notice): Gem files will remain installed in /home/vagrant/.gem/ruby/1.9.1/gems/ffi-1.9.0 for inspection.
Fri Sep 06 20:26:53 +0000 2013 /Stage[main]/Browsertests/Exec[install browsertests bundle]/returns (notice): Results logged to /home/vagrant/.gem/ruby/1.9.1/gems/ffi-1.9.0/ext/ffi_c/gem_make.out

gem_make.out has only:
   /usr/bin/ruby1.9.1 extconf.rb

--------------------------
**Version**: unspecified
**Severity**: normal
**See Also**:
https://bugzilla.wikimedia.org/show_bug.cgi?id=69874
Forgot to tag the commit in https://gerrit.wikimedia.org/r/#/c/158564/ but the patch should have fixed this and other bugs related to botched ffi compilation. A good handful of the most problematic gems are now installed from packages.
After profiling the `bundle install` process, I'm seeing around 128M as the peark memory usage. That seems like a reasonable amount of free memory to expect on the VM considering some of the other memory intensive processes that need to run (xvfb/firefox in browser testing, for example, uses around 192M).
The ruby-ffi package is for Ruby 1.9. Perhaps we should try switching back to a shared directory for bundler gems. That would at least mitigate the failures by only performing ffi compilation (and other native gem compilation) once.
Can we do `apt-get install ruby-ffi` instead of compiling ffi with bunder?
Is this still an active problem? The browsertests role has been removed, but there are now several extension specific roles which install gems via bundler to provide testing support.
I managed to get tests running after increasing memory size to 1024. Is it possible to increase memory size just when gems are installing, and then decrease it back to 512?
Found it. Mediawiki-Vagrant[1] says to edit Vagrantfile-extra.rb. Now VM memory size is 1024.

$ vagrant halt
edit Vagrantfile-extra.rb
$ vagrant up
$ VBoxManage showvminfo ...
...
Memory size: 1024MB
...

1: https://www.mediawiki.org/wiki/Mediawiki-Vagrant
I have tried this.

#1 $ vagrant halt

#2 changed

vb.customize ['modifyvm', :id, '--memory', '768']

in Vagrantfile to

vb.customize ['modifyvm', :id, '--memory', '1024']

#3 $ vagrant up
   $ vagrant provision

but both "VBoxManage showvminfo" and "Oracle VM VirtualBox Manager" still say "Memory size: 768MB".
Created attachment 13384
VBoxManage showvminfo

**Attached**: {F11493}
Created attachment 13383
vagrant provision

**Attached**: {F11492}
I have the same problem. I will attach output of "vagrant enable-role browsertests" and "VBoxManage showvminfo".

How do I increase VM memory size? (Looks like it is 768MB now.)

In Vagrantfile[1] or "Oracle VM VirtualBox Manager > VM > right click > Settings > System > Base Memory"?

1: https://github.com/wikimedia/mediawiki-vagrant/blob/master/Vagrantfile#L65
(In reply to comment #5)
> I increased the VM to 1024, `vagrant halt` `vagrant up`!
... that should have continued "and the vagrant provision complete successfully, and I can run tests!"  Yay, thanks for the memory suggestion.

(In reply to comment #6)
> the way to resolve this is to document...
I added something, https://www.mediawiki.org/w/index.php?title=MediaWiki-Vagrant&diff=783886&oldid=781408

> ... one should try freeing some memory in the VM
You mean by temporarily disabling other roles until vagrant provisions browsertests successfully?  I didn't try stopping apache/mysql/parsoid/redis in the vagrant VM, because I assumed `vagrant provision` would have restarted them before running the ruby gem bundler.

I guess the opaque exception reporting is an upstream issue.
(In reply to comment #5)
> I increased the VM to 1024, `vagrant halt` `vagrant up`!

And -- did it work? I guess it did, because you later speak of "successful and unsuccessful runs".

I don't think it's viable to keep increasing the default RAM allocation just so that this one Gem can compile, so the way to resolve this is to document the fact that compiling the ffi Gem is a memory-hungry task and that if it fails one should try freeing some memory in the VM or increasing the RAM allocation.
Created attachment 13289
output of `vboxmanage showvminfo ...` before I increased VM memory

**Attached**: {F11491}
Thanks for the updates. I did not modify the VM's memory size.
Maybe the difference between me and Chris is my roles include eventlogging, gettingstarted (which loads redis) and visualeditor+parsoid.

I increased the VM to 1024, `vagrant halt` `vagrant up`!

In the vagrant VM, on both successful and unsuccessful runs, puppet spends many minutes running
/usr/bin/ruby /usr/bin/bundle install --path /home/vagrant/.gem
with no output.

/home/vagrant/.gem/ruby/1.9.1/gems contains a bunch of old gems from May14, and the new revisions of gems from this run.

drwxr-xr-x  4 vagrant vagrant 4096 May 14 04:28 builder-3.2.0
drwxr-xr-x  6 vagrant vagrant 4096 Sep  6 22:14 builder-3.2.2
drwxr-xr-x  4 vagrant vagrant 4096 May 14 04:35 childprocess-0.3.9
drwxr-xr-x  6 vagrant vagrant 4096 May 14 04:35 chunky_png-1.2.8
drwxr-xr-x 10 vagrant vagrant 4096 May 14 04:44 cucumber-1.3.1
drwxr-xr-x  6 vagrant vagrant 4096 May 14 04:45 data_magic-0.14
drwxr-xr-x  7 vagrant vagrant 4096 May 14 04:35 diff-lcs-1.2.4
drwxr-xr-x  4 vagrant vagrant 4096 May 14 04:44 faker-1.1.2
drwxr-xr-x  7 vagrant vagrant 4096 May 14 04:29 ffi-1.8.1
drwxr-xr-x  7 vagrant vagrant 4096 Sep 16 03:50 ffi-1.9.0    <--- the problem
drwxr-xr-x 10 vagrant vagrant 4096 May 14 04:35 gherkin-2.12.0
drwxr-xr-x  5 vagrant vagrant 4096 May 14 04:44 i18n-0.6.4
drwxr-xr-x  4 vagrant vagrant 4096 May 14 04:35 multi_json-1.7.3
drwxr-xr-x  4 vagrant vagrant 4096 May 14 04:45 net-http-persistent-2.8
drwxr-xr-x  4 vagrant vagrant 4096 May 14 04:45 page_navigation-0.9
drwxr-xr-x  5 vagrant vagrant 4096 May 14 04:45 page-object-0.8.10
drwxr-xr-x  4 vagrant vagrant 4096 May 14 04:45 parallel-0.6.4
drwxr-xr-x  5 vagrant vagrant 4096 May 14 04:45 parallel_tests-0.12.3
drwxr-xr-x  6 vagrant vagrant 4096 May 14 04:28 rake-10.0.4
drwxr-xr-x  6 vagrant vagrant 4096 Sep  6 22:14 rake-10.1.0
Apparently having two different people attempt to verify your report is not quite enough to warrant a follow-up. Closing as invalid.
[mass-moving from Tools>MediaWiki-Vagrant to separate product. See bug 54041. Filter bugmail on this comment.]
I ran into this problem before. If I recall correctly, it's an out-of-memory error that bundler is unhelpfully catching and re-throwing as an uninformative generic exception. The memory requirements of building the ffi gem were the original impetus for bumping the VM's memory allocation to 768 Mb, but since we've done that I have not run into this problem. Have you modified the VM's memory allocation setting at all?

If you have not modified the VM, can you reproduce the output of "vboxmanage showvminfo"? It should be invoked with the machine's UUID as the final command-line argument. The UUID can be found in .vagrant/machines/default/virtualbox/id, which should exist under your Vagrant repo root.
I was not able to reproduce this in a fresh VM
System environment:
Win7 X64
Google Chrome 29.0.1547.62 m

Steps to reproduce:
Open a page
Edit it in VE
Copy-paste the following text:
a
b
c
d
e

Expected output:
a
b
c
d
e

Actual output:
abcde

The problem has been tested with notepad++ as the external editor, with line endings in windows format (CRLF), UNIX format (LF) and MAC format (CR). Newline is not copied in any of the cases.

The problem has also been tested by trying to copy-paste html text from chrome itself. Newline is not copied.

--------------------------
**Version**: unspecified
**Severity**: normal
**See Also**:
https://bugzilla.wikimedia.org/show_bug.cgi?id=52096
Change 86664 merged by jenkins-bot:
Rich paste

https://gerrit.wikimedia.org/r/86664
Works with gedit & chrome with the rich paste patch.
Change 86664 had a related patch set uploaded by Esanders:
Rich paste

https://gerrit.wikimedia.org/r/86664
Confirmed in Firefox 23 / Xubuntu Linux / Monobook

Using kwrite:
Tested with \n  \r and \r\n end of lines and it makes no difference.
Tested also using UTF-8, UTF-16, ISO-8859-1, ISO-8859-2 and Windows-1258 encodings.

Also tested copying from this page viewed in Firefox, Konqueror and Linuks, from a PDF, a text file in a terminal, and again from kwrite using the following:

a

b

c

d

e

None of it makes the slightest bit of difference.

https://en.wikipedia.org/w/index.php?title=User%3AThryduulf%2Fsandbox3&diff=571705481&oldid=571089410 is the copy from comment 0
Extensions such as Math or SyntaxHighlight may require the inclusion of large(ish) JS libraries. It would be good if we didn't load these on every VE page load, but rather when these elements are present, or become present (e.g. I add a formula to a new document)

--------------------------
**Version**: unspecified
**Severity**: enhancement
For special pages, no information about page existence is exposed to mw.config, which means that VisualEditor is forced to assume it exists regardless.

--------------------------
**Version**: 1.22.0
**Severity**: minor
**See Also**:
https://bugzilla.wikimedia.org/show_bug.cgi?id=66885
Change 169639 merged by jenkins-bot:
Expose ID of relevant page in JS variables

https://gerrit.wikimedia.org/r/169639
Change 169639 had a related patch set uploaded by Alex Monk:
Expose ID of relevant page in JS variables

https://gerrit.wikimedia.org/r/169639
'wgRelevantArticleId' => WikiPage::factory( $relevantTitle )->getId() perhaps?

I'm not sure we want to introduce new variables here though...
Sounds like you need the js variable 'wgIsProbablyEditable' or 'wgIsArticle' according to page under 'wgRelevantPageName' or a new variable 'wgRelevantIsProbablyEditable'/'wgRelevantIsArticle' to cover this.
This bug is about giving existence information for the relevant article (i.e. the article that the special page is working on). See bug 66885
(In reply to comment #3)
> There is wgCanonicalSpecialPageName set, when you are on a special page.

-> WORKSFORME
There is wgCanonicalSpecialPageName set, when you are on a special page.
Change 82744 merged by jenkins-bot:
Reference core bug 53774 in bug 49000 comment

https://gerrit.wikimedia.org/r/82744
Change 82744 had a related patch set uploaded by Jforrester:
Reference core bug 53774 in bug 49000 comment

https://gerrit.wikimedia.org/r/82744
**Author:** `kwwilliams`

**Description:**
When articles contain items that lead VE to corrupt the article, we've been protecting them by wrapping the article with <div class="ve-ce-protectedNode"> and </div>. This used to keep VE from being able to select any material within the article, which allowed us to keep the article from being corrupted.

VE is now allowing edits to templates inside the article (see https://en.wikipedia.org/w/index.php?title=Teenage_Dream_%28Katy_Perry_album%29&veaction=edit for an example), so we now have no way to protect articles that we know VE cannot handle.

--------------------------
**Version**: unspecified
**Severity**: enhancement
**See Also**:
https://bugzilla.wikimedia.org/show_bug.cgi?id=52141
(In reply to This, that and the other from comment #13)
> As it stands, this is a dupe of bug 52141. I've put back the original bug
> summary; it seems to me that WONTFIX is the appropriate resolution for this
> bug.

Agreed.
As it stands, this is a dupe of bug 52141. I've put back the original bug summary; it seems to me that WONTFIX is the appropriate resolution for this bug.
James, that is bug 52141.  This bug was about a specific problem with the existing code.
Changing this to "Provide a way to block VisualEditor from being active on a page"; I worry that this will lead to yet another magic word, but oh well.
I was very easily able to reproduce this problem; I dont have exact steps to reproduce, but with a few clicks and keypresses in the content area, all content was removed and the text I typed appeared in the body of the article.  Undo appeared to work as expected, however 'Review your changes' did not return any results - it hung, but didnt lock up the browser.  The toolbar is another way to override the protectedNode.

This template is also being used to create a 'pre' text area on
https://en.wikipedia.org/w/index.php?title=Morse_code&veaction=edit
**kwwilliams** wrote:

Note https://en.wikipedia.org/w/index.php?title=Wikipedia:VisualEditor/Feedback&diff=572094345&oldid=572076135 , where another 26,000 articles that VE mutilates have been identified.

We really need to have a method to shield articles from VE. It's critical to do, and beyond reason to expect that we will always modify articles to conform to VE's expectations.
I tried again on my test page on a different computer running Firefox 17.0.2 (ESR) under XP.

At first, it seemed that the protected node was working, but at some point (after clicking, double-clicking, typing, ...) I managed to write in the protected node: the result was an even greater mess than before: still the duplication, quotes added all over the place (they seem correct but unnecessary), pipes removed, space added, ...

https://en.wikipedia.org/w/index.php?title=User%3ANicoV%2FTest&diff=571628361&oldid=571542702
**kwwilliams** wrote:

(In reply to comment #6)
> On the wider point, it's not clear if there's an actual long-term need for a
> proper VE-prevention system (or if it's all solvable with a few quick fixes
> of
> bad wikitext), but if there is, we should build a proper one, not rely on a
> hack that might break.

What's unclear about that?

I agree that it would be better to do this with a category, but the need for VE to recognise some flag that tells it not to edit a given article seems fairly obvious. As long as VE mutilates pages in response to inputs that behaved reasonably with the working software, we will require a mechanism to tell VE not to edit certain pages.
(In reply to comment #5)
> The div has been removed, so people need to look at
> https://en.wikipedia.org/w/index.
> php?title=Teenage_Dream_%28Katy_Perry_album%29&oldid=571540632

In this particular case, note that the reason everything was broken in editing this page was because the <ref> was defined outside of the table cell, in a the non-space between the end of the cell and the start of the row, and only happened to "work" in WT mode because of HTML Tidy moving it to somewhere sane - Ed's edit to the page fixed the duplication so the desired protection is no longer needed: https://en.wikipedia.org/w/index.php?title=Teenage_Dream_(Katy_Perry_album)&diff=571550633&oldid=571540632

On the wider point, it's not clear if there's an actual long-term need for a proper VE-prevention system (or if it's all solvable with a few quick fixes of bad wikitext), but if there is, we should build a proper one, not rely on a hack that might break.
**kwwilliams** wrote:

The div has been removed, so people need to look at https://en.wikipedia.org/w/index.php?title=Teenage_Dream_%28Katy_Perry_album%29&oldid=571540632
**kwwilliams** wrote:

(In reply to comment #3)
> According to the documentation, the div is only meant to block editing to a
> section of a page (although that section can be the whole text), so adding
> text
> before is correct, likewise you should be able to add text after the /div.
It's a change from the original behaviour. I agree that it's not technically wrong.
According to the documentation, the div is only meant to block editing to a section of a page (although that section can be the whole text), so adding text before is correct, likewise you should be able to add text after the /div.

The editing templates within the div does sound like a bug though.

If VE (or Parsoid possibly) is not treating the div as invariant then the div definitely isn't doing what it was intended to do.
**kwwilliams** wrote:

Firefox 23.0.1 on Windows 7.

To be clear, we are still prevented from editing the text. We are not prevented from editing templates, and we can insert text before div.
The original person to report this noted that they were using Chrome 29 on Windows 7.

I have been unable to reproduce this in Firefox 23 on Linux.

Neither kww or the ip who can reproduce this have noted their system.
1. Create '<p>Foo<cite>Bar</cite>Baz</p>'
2. Select Bar
3. Range is now [4,6] (correct as <cite/> becomes [<alien>,</alien>])
4. Bold the selection
5. Range is now [6,6] :(

--------------------------
**Version**: unspecified
**Severity**: normal
Change 82771 merged by jenkins-bot:
Fix getOffsetFrom(Element|Text)Node for annotated aliens

https://gerrit.wikimedia.org/r/82771
Change 82771 had a related patch set uploaded by Esanders:
Fix getOffsetFrom(Element|Text)Node for annotated aliens

https://gerrit.wikimedia.org/r/82771
[Please move this to a different component if applicable, I'm not sure where the editor comes from.]

It is impossible to insert the "ę" or "Ę" characters (latin letter "e"/"E" with ogonek) from keyboard when editing in Module: namespace with the code editor on the Polish Wikipedia.

"ę" is inserted on the Polish keyboard using AltGr+e (aka Ctrl+Alt+e). If the editor uses this as a hotkey, it shouldn't (nor should it use any other Ctrl+Alt combinations).

(Reported at https://pl.wikipedia.org/wiki/Wikipedia:Kawiarenka/Kwestie_techniczne#VisualEditor_a_polskie_diakrytyki)

--------------------------
**Version**: unspecified
**Severity**: normal
These are all the default defined key combinations:
https://github.com/ajaxorg/ace/blob/40ea516801332fb8e96f8ba2e5046eece2fd95d3/lib/ace/commands/default_commands.js
In that case, it looks like you could follow the example in modules/jquery.codeEditor.js near line 151 to disable this command too.
@Brad, depending on how exactly you remapped it, the Ctrl+Alt+E might be mapped to "ę" in some lower-level layer, not letting the browser even see it. (I used this a few times to wrestle with some stupid applications which take Ctrl+Alt shortcuts for themselves to take it away from them.)

Some grepping shows ACE Editor uses "Ctrl-Alt-E" / "Command-Option-E" for the "togglerecording" command. This is most likely the culprit.

This seems to be the only Ctrl-Alt shortcut involving regular letters (there are also a few with arrow keys and backspace).
You want CodeEditor.

I note that I can type ę and Ę fine in CodeEditor from here, where the key combinations are "<Compose> ; e" and "<Compose> ; E".

I also remapped Ctrl+Alt+E to "ę" temporarily, and I was able to enter that character using that key combination in CodeEditor on a module page on plwiki with no issues (using Firefox 24 on Linux).
* This is language/script specific diacritic specific bug split from {T53472}

* For language Marathi Script Devanagari anuswara diacritic is  ं 
* If one types the anuswara diacritic  ं  after any devanagari script alphabet it is usually place above the concerned alphabet. For example  क is a Marathi/Devanagari alphabet if I type क+ ं I get  कं  
* If I place cursor before the cluster कं and press delete then whole cluster gets deleted and that is right way to happen, and this behaviour needs to be retained (since if basic alphabet is not there then no need of anuswara diacritic  ं) .
* Problem: In Visual Editor if I place cursor after the cluster e.g. after कं and press backspace current behaviour is the whole cluster gets deleted. Example कं + Backspace key = results in whole cluster getting deleted.
* Expected behaviour is: Cluster with anuswara diacritic (कं) + Backspace key = retain rest of cluster(retain क ) and only anuswara diacritic  ं should get deleted.
* Reason: During spell correction many times we need to retain rest of the cluster and only change the diacritics. For anuswara   ं diacritic spell change is required frequently for various reasons like change in singular-plural tense. Every time retyping the whole cluster is cumbersome. Traditional Source editing behaviour is proper and expected and problem is coming only with VisualEditor behaviour.
* For example please see this https://mr.wikipedia.org/w/index.php?title=कृष्ण_श्रीनिवास_अर्जुनवाडकर&diff=1198833&oldid=1198826 edit difference a user had to change this diacritic at several places.

Since users would be reluctant to use VE without correct behaviour, I would prefer this being treated as a bug not just enhancement and to have  fair importance level.

--------------------------
**Version**: unspecified
**Severity**: normal
I'm provisionally deeming this fixed. We changed this behaviour significantly since this was filed. Please re-open if you find issues.
>>! In T55754#549797 in October 2013, @Jdforrester-WMF wrote:
> we're switching back to native cursoring and backspacing, which hopefully will fix this

@Mahitgar: Do you know if this is still a problem in Devanagari? (I'm afraid I'm missing input method skills to test this myself.)
Retitled for clarity; we're switching back to native cursoring and backspacing, which hopefully will fix this, but keeping this open and distinct in case not.
en.wp user Professor Hog reports:
"If you try and use beta to edit a page, but you've forgotten to log in, so you log in directly off the beta page, once you have successfully logged in it takes you back to the edit source page instead of the beta page. Minor, but thought you may want to correct it? "

--------------------------
**Version**: unspecified
**Severity**: minor
**See Also**:
https://bugzilla.wikimedia.org/show_bug.cgi?id=52281
I think that needs to wait until enwiki has SET.
@Jdforrester-WMF It looks like the [workaround](https://en.wikipedia.org/wiki/MediaWiki:Anoneditwarning) at enwiki (and maybe others, though not that I know of) needs to be removed/altered.

See my previous comment.
This now works.
Note, Steven added a [custom workaround](https://en.wikipedia.org/w/index.php?title=MediaWiki:Anoneditwarning&diff=572253350&oldid=572253272) at English Wikipedia (shortly after this was filed).  It removes the action=edit, so you don't go to //any// editor on return (otherwise, it can to the wrong one like this bug says).

That was never the desired behavior, though.  The desired behavior is that it knows which editor you're using anonymously, and keeps you on the right editor when you return logged in.  Both VE and wikitext have suitable URL parameters; the issue is knowing which to use.
Changing the depends on to bug 52471 (sorry, I typoed in comment 3)
(In reply to comment #3)
> To clarify the sequence I used to reproduce this was:
> 1. log out
> 2. load a page in VE. I tested with [[Symphony No. 8 (Mahler)]] and
> [[user:Thryduulf/sandbox]]
> 3. click to edit the page in VE
> 4. Click the "log in" link in the notice that pops up. 
> This loads
> https://en.wikipedia.org/w/index.php?title=Special:UserLogin&returnto=User:
> Thryduulf/sandbox&returntoquery=action%3Dedit
> in a new tab.
> 5. In that new tab, log in as normal
> Get returned to the source editor.
> 
> The edit notice shown is that in [[MediaWiki:Anoneditwarning]] where the link
> is hardcoded to the source editor (pre VE this would never have been an
> issue).
> 
> To me this suggests that either editor-relative urls are needed or we need
> different edit notices for the classic editor and VE (see bug 52741 for the
> latter)

Oh, I see, I was clicking on "login" in the personal links bar - sorry. Re-titling so I don't get confused again. :-)
To clarify the sequence I used to reproduce this was:
1. log out
2. load a page in VE. I tested with [[Symphony No. 8 (Mahler)]] and [[user:Thryduulf/sandbox]]
3. click to edit the page in VE
4. Click the "log in" link in the notice that pops up. 
This loads https://en.wikipedia.org/w/index.php?title=Special:UserLogin&returnto=User:Thryduulf/sandbox&returntoquery=action%3Dedit in a new tab.
5. In that new tab, log in as normal
Get returned to the source editor.

The edit notice shown is that in [[MediaWiki:Anoneditwarning]] where the link is hardcoded to the source editor (pre VE this would never have been an issue).

To me this suggests that either editor-relative urls are needed or we need different edit notices for the classic editor and VE (see bug 52741 for the latter)
I'll ask for further clarification, but I've tested this in Firefox 23 on linux.

Clicking the link in the VE popup that notes you're not logged in reproduces this bug. (Note that this loads the login window in a new tab, I logged in there and was returned to the source editor in that window).

Dismissing that popup and then using the log in link at the top right of the page returned me to viewing the page not editing it in either editor.

The results are the same using my Thryduulf account which has a couple of gadgets, and my Awkward42 account which has none.
I can't reproduce this - I get back to VisualEditor (as expected) - the login link is something like https://en.wikipedia.org/w/index.php?title=Special:UserLogin&returnto=Foobar&returntoquery=veaction%3Dedit

Can "Professor Hog" give any further details? What browser were they using? Can they reproduce? What about after a hard-refresh? Do they have any odd gadgets on the account into which they were logging-in?
**Author:** `rachelqa99`

**Description:**
shows error message

I got this message when running a test automation script, that puts in a line of code and tries to save it. It doesn't recognize the new line of code I put in, so it gives this error message upon save. Not sure if you are aware of this particular scenario, which is why I am submitting it.

--------------------------
**Version**: unspecified
**Severity**: normal

**Attached**: {F11191}
I'm going to provisionally mark this as fixed as it appears to now work.
Is this still a problem, or can the task be resolved?
A clarification about each case we tried in the automated test: 

* type a string and the string is shown correctly in CE and DM
* type a string and :return and both the string and the empty line are shown correctly in CE and DM

* but type a string and :enter and CE correctly shows *both* the string *and* the empty line but DM shows *neither* the string nor the empty line.  That is, the :enter command is recognized in CE but seems to have the effect of making all the changes in CE invisible to DM.
I think this might be a real bug, but I think it might take some particular piece of hardware to trigger it. 

WebDriver/Selenium has two ways of sending a newline to the browser

:enter
:return

":return" is intended to emulate the "Return" key on a normal keyboard; ":enter" is intended to emulate the "Enter" key on a numeric keypad.

In this test, when we type a string plus :return in VE, the diff view is correct, and the test would pass.  But when the test sends a string plus :enter in VE, VE does not recognize that the contents of the edit page has changed. 

I tried to reproduce this issue manually using a Macintosh USB keyboard on a Macbook Pro laptop but both the Return key and Enter key on that particular piece of hardware worked correctly with VE. 

I suggest trying out Return (on the keyboard) and Enter (on the numeric keypad) on a few keyboards to make sure we don't see this in the wild.
**rachelqa99** wrote:

I am adding the line of text  This is a test  at the beginning of the page into the Selenium user's homepage on test2.  There is a bunch of already existing text below it, I am just trying to add a new line at the begining of the page, "This is a test" and hit Return key for a new line.  I can't seem to reproduce it manually.
(In reply to comment #0)
> Created attachment 13227 [details]
> shows error message
> 
> I got this message when running a test automation script,

Yes, this is the normal (you tried to get the diff but as far as we're concerned, no changes were made to the page).

> that puts in a line of code and tries to save it. It doesn't recognize the new
> line of code I put in, so it gives this error message upon save.

What "line of code" does it insert? Where does it insert it? On what page? On what wiki? Can you reproduce manually or does this only happen with the script?

(In reply to comment #3)
> Possibly a situation caused by bug 53360 which is marked as resolved.

The fix for bug 53360 is running on test2 right now, so almost certainly not related to that bug.

**Attached**: {F11191}
**rachelqa99** wrote:

Possibly a situation caused by bug 53360 which is marked as resolved.
**rachelqa99** wrote:

this is running off of test2
**rachelqa99** wrote:

feature script

**Attached**: {F11192}
The ULS input methods (jquery.ime) currently do not work with the popup windows of VE. These include the template, reference, reflist, image, link and page settings popups.

The problem has been tested by me on Win7 X64 with Google Chrome 29.0.1547.62 m and possibly by others on other browsers. The problem was originally reported on [1] by mr-wp users.

[1]: https://en.wikipedia.org/wiki/Wikipedia:VisualEditor/Feedback#VE_.2B_ULS_unicode_Devnagari_Script_input_issues

--------------------------
**Version**: unspecified
**Severity**: normal
Don't need to make this work as we don't use `iframe`s any more.
*** Bug 55969 has been marked as a duplicate of this bug. ***
System environment:
Win 7 X64
Google Chrome 29.0.1547.62 m

Steps to reproduce:
Open a blank page
Edit it in VE
Either use google input tools for hindi or enable ULS hindi transliteration

Input:
Select bullet formatting from the VE toolbar
agar[SPACE]main[SPACE]

Expected output:
with ULS: अगर[SPACE]मैन[SPACE]
with Google input tools (depends on translation history, macros etc and may differ user-to-user): अगर[SPACE]मैं[SPACE]

Actual output:
Text output is same as expected. However, the text is partially non-navigable, ie pressing the left arrow key from the end of the text takes the caret to the beginning, and then left/right arrow key presses have no effect on the caret. Simultaneously, if the text is navigated by specifically placing the caret at a particular point using the mouse, the value shown for the formatting dropdown in the toolbar may go blank at one point in the text and become paragraph at the next.

The text is also irremovable ie bug 53708

--------------------------
**Version**: unspecified
**Severity**: normal
**See Also**:
https://bugzilla.wikimedia.org/show_bug.cgi?id=53708
(In reply to comment #1)
> There's code to address this bug in the following patch, which is due to go
> live by mediawiki.org on 13 September 2013:
> 
> https://gerrit.wikimedia.org/r/#/c/82858/
> 
> Please let us know whether it fixes the bug!

System environment:
Win 7 X64 SP1
Google Chrome 29.0.1547.66 m

Test Url:
https://www.mediawiki.org/wiki/User:Siddhartha_Ghai?veaction=edit

The patch seems to have partially fixed the bug.

Text input using google input tools is now navigable.

But text input using ULS IME hindi transliteration is still non-navigable. Pressing the left arrow key from the end of the text takes the caret to the beginning, and then left/right arrow key presses have no effect on the caret. (Same behaviour as before)

The text formatting at all points in the bullet text remains as paragraph though (no blanking of the formatting drop-down).

Text input with ULS is still irremovable ( bug 53708 )
There's code to address this bug in the following patch, which is due to go live by mediawiki.org on 13 September 2013:

https://gerrit.wikimedia.org/r/#/c/82858/

Please let us know whether it fixes the bug!
Screenshot of incorrect text placement

System environment:
Win 7 X64
Google Chrome 29.0.1547.62 m

Steps to reproduce:
Open a blank page
Edit it in VE
Enable ULS IME hindi transliteration

Input:
[ENTER/RETURN KEY]x2 (two newlines)
agar[SPACE]ma

Expected output:
[NEWLINE]x2 (two newlines)
अगर[SPACE]म

Actual output:
[NEWLINE]x2 (two newlines)
अग[NEWLINE]र[SPACE]म

Once [ENTER/RETURN KEY]x2 followed by agar[SPACE] has been pressed, Bug 53706 shows up. If one continues the input, this bug is what happens. The incorrect placement is accompanied by the following incorrect bahaviours:

The VE toolbar shows no format (while the editing had been begun with paragraph)

Cursor movement is incorrect. When the cursor is at the end, pressing up key takes it to the end of the first line, then pressing the down key takes it in the second line after the [SPACE] and before म It is here that the incorrect behaviour occurs. Pressing either the left or the right arrow keys takes it to the end of the line (ie after म) While this should happen on right arrow key press, the left arrow key press should take the cursor(caret) to before the space.

Also, when at the end of the second line, pressing backspace does nothing. Similarly pressing delete anywhere in the second line does nothing. The second line effectively becomes irremovable, while the first line can be removed.

Note: Page used for this test is [[:w:hi:सदस्य:Siddhartha Ghai/sandbox]]

--------------------------
**Version**: unspecified
**Severity**: normal
**See Also**:
https://bugzilla.wikimedia.org/show_bug.cgi?id=53711

**Attached**: {F11165}
Automatic Incorrect caret movement has been reported separately as Bug 54424
Tested out this bug for page with pre-existing devanagari text.

System Environment: Same as Comment 4

Test Url:
https://www.mediawiki.org/wiki/User:Siddhartha_Ghai/sandbox?veaction=edit

Steps:
1 Enable ULS IME hindi transliteration
2 Take the caret to the end of the first paragraph using the mouse (i.e click at the end of the first paragraph to take the caret there)
3Input k
3.1 This will give the output of क् with the newline selected ( Bug 53706 )
4 Now input g
4.1 This will give an output of ग् but this output will show up in the next line
4.1.1 This output cannot be copy-pasted into an external text editor though it can be selected in VE
4.1.2 This output is ignored in caret movement when using the arrow keys, so the caret goes straight from the beginning of the second paragraph to the end of the first paragraph just after क् jumping past ग् in between. When right arrow key is pressed the caret goes from here to the beginning of the second paragraph इस jumping past ग्
4.1.3 Pressing backspace from the beginning of the second paragraph joins the second paragraph with the first paragraph jumping past the ग् making it the last text in the page
4.1.4 Taking the caret to the end of text i.e after ग् makes the formatting dropdown go blank
4.1.5 Using the VE toolbar Undo button moves the second paragraph back to a new line but it still stays above the ग् which is still the last text on the page.
4.1.6 Undoing everything and adding a space to the end of the second paragraph and then submitting and reviewing the changes diff shows that the ग् at the end of the page is not being added
4.1.7 Typing something after the ग् shows the text added after both ग् and the second paragraph.

So effectively the bug is present even while editing existing pages with devanagari text using VE+ULS.
Reported console errors in Bug 54331 and Bug 54334 per Comment 7

There's possibly other console error instances which need to be reported.

(In reply to comment #8)
> If you were able to test the issues for non-blank pages that would be a great
> help too, because it looks like the problems happen in different ways in
> those
> two cases.

Will do.
Thank you very much for providing this level of detail; I can't emphasise enough how helpful it is!

If you were able to test the issues for non-blank pages that would be a great help too, because it looks like the problems happen in different ways in those two cases.
Thanks for specifying the exact keystrokes -- it really helps!

There's a specific input issue when the whole page is blank (whether or not an input method is used, i.e. even if you just type ASCII characters).

Could you please try typing some text on the following page, under the words "Testing Area":

  https://www.mediawiki.org/w/index.php?title=Project:Sandbox&veaction=edit

Then click "Save Page" and "Review your changes", and see whether the text appears correctly in the right-hand version. (After that, you can cancel the edit without saving).

I can type देवनागरी ("devnagrI" using my Ibus Hindi phonetic IME) there, and it appears correctly.
The behaviour has also changed for the input described in Comment 1

Test at hindi wikipedia:
Test url:
https://hi.wikipedia.org/wiki/%E0%A4%B8%E0%A4%A6%E0%A4%B8%E0%A5%8D%E0%A4%AF:Siddhartha_Ghai/sandbox?veaction=edit

Input:
agar[SPACE]main[SPACE]kahoon[SPACE][RETURN KEY]

Output:
Fine except the newline never appears, no matter how many times the return key is pressed. The newline does not appear even when google input tools are disabled and the keyboard switched back to English (United States). The formatting dropdown is blank. The text is non-navigable ( bug 53711 ). However, pressing the left and right arrow keys a bunch of times and then pressing the return key still causes the text to be replaced with a newline followed by ♙

Test at Mediawiki.org:
Test url:
https://www.mediawiki.org/wiki/User:Siddhartha_Ghai?veaction=edit

The behaviour with google input tools seems to be correct with the newline being placed correctly, and the text being navigable.
There's code to address this bug in the following patch, which is due to go live by mediawiki.org on 13 September 2013:

https://gerrit.wikimedia.org/r/#/c/82858/

Please let us know whether it fixes the bug!
This bug was also seen when VE testing revealed Bug 53711
This bug (or a variant of it) seems to happen when using Google input tools for hindi.

Steps to reproduce:
Open a blank page
Edit it in VE
Enable google input tools IME
Type something. example keystrokes: agar[SPACE]main[SPACE]kahoon[SPACE][RETURN KEY]

Expected output:
The text is typed(exact output text would depend on the IME's translation memory, macros used etc.) with a newline at the end and the cursor (caret) in the newline.

Actual output:
The text is typed correctly, the newline is also placed, but the cursor remains in the first line. The formatting dropdown of the VE toolbar is blank. It changes back to paragraph on pressing either the right or left arrow key (haven't tested with any other key).

Pressing the return key again causes the newline to disappear while the text remains (variant of Bug 53705 ?). The same behaviour (correctly) takes place on pressing the delete key.

Possibly different bug: When at the end of the first line, pressing the left/right arrow keys a bunch of times and then pressing the return key made me somehow end up with ♙ as the only text and all the input text gone.

Also note that this bug doesn't seem to appear when using the native windows input devanagari-INSCRIPT
System environment:
Win 7 X64
Google Chrome 29.0.1547.62 m

Steps to reproduce:
Open a blank page
Edit it in VE
Let the API call for the parsed json output fail
VE asks if you would like to retry, press Cancel

Expected behaviour:
VE should reset the opacity for the title and sitesub back to 1 from 0.6

Actual behaviour:
Opacity is not changed, leaving it 0.6 although the user is effectively reading the article, not editing it with VE

--------------------------
**Version**: unspecified
**Severity**: normal
I believe we fixed this a few months ago; sorry for the slow triage.
Screenshot of selection error

System environment:
Win 7 X64
Google Chrome 29.0.1547.62 m

Steps to reproduce:
Open a blank page
Edit it in VE
Enable ULS IME hindi transliteration

Input:
[RETURN/ENTER KEY]x4 (four newlines)
agar[SPACE]

Expected output:
[NEWLINE]x4 (four newlines)
अगर[SPACE]

no text selection should be there

Actual output:
[NEWLINE]x4 (four newlines)
अगर[SPACE]

the ending [SPACE] is selected with a newline. Also, the toolbar shows that VE has somehow jumped to changing the formatting to bulleted and numbered list from the original paragraph formatting.

Further, pressing a backspace deletes not only the selected space/newline, but also the typed text अगर. I think this is Bug 53705 though I may be wrong.

--------------------------
**Version**: unspecified
**Severity**: normal
**See Also**:
https://bugzilla.wikimedia.org/show_bug.cgi?id=53700

**Attached**: {F11150}
As of https://gerrit.wikimedia.org/r/#/c/264577/ in #jquery.ime this should now be resolved and working for all users, and will be part of the wmf.12 release starting tomorrow.
Further testing Comment 3 seems to indicate that the newline selection happens when the last input is a consonant followed by a halant which can be input with one keystroke.

The hindi transliteration IME inputs two characters whenever an ASCII consonant is input, the equivalent hindi consonant followed by the halant character ् (U+094D)

So inputting g gives ग् i.e ग + ् , j gives ज् i.e ज + ् etc. with the newline selected.

Some hindi consonants, however, need two keystrokes to be input. So gh gives घ् i.e घ + ् and jh gives झ् i.e झ + ् etc. Output for these depends on the input speed. If one is quick, the text is input correctly with no selection. However, if one is slow, Bug 54421 shows up with the grapheme containing the duplicated text at the beginning of the article being selected.

This selection (or non-selection) behaviour takes place regardless of whether the input is one consonant or a word. The behaviour depends on what the last consonant is, one that can be input with one keystroke or one that is input with two keystrokes.
Note: Comment 3 is ofcourse with ULS IME hindi transliteration enabled.
Screenshot for comment 3

**Attached**: {F11151}
Per https://bugzilla.wikimedia.org/show_bug.cgi?id=53708#c8 the following report is for the bug behaviour when tested on a page with pre-existing text:

System Environment:
Windows7 X64 SP1
Google Chrome 29.0.1547.66 m

Test Url:
https://www.mediawiki.org/wiki/User:Siddhartha_Ghai/sandbox?veaction=edit

Steps:
Take a caret to the end of the first paragraph using the mouse (i.e click at the end of the first paragraph to take the caret there.)
Input ag

Expected output:
अग्

Actual output:
अग् but with the newline after it selected, although the newline or space wasn't typed in this edit and existed previously.
(In reply to comment #1)
> There's code to address this bug in the following patch, which is due to go
> live by mediawiki.org on 13 September 2013:
> 
> https://gerrit.wikimedia.org/r/#/c/82858/
> 
> Please let us know whether it fixes the bug!

The patch doesn't fix the bug.

System environment:
Win 7 X64 SP1
Google Chrome 29.0.1547.66 m

Test URL:
https://www.mediawiki.org/wiki/User:Siddhartha_Ghai?veaction=edit

Steps:
Enable ULS IME hi transliteration
Blank the page and reset the formatting to simple paragraph
Follow the input steps described in Comment 0

Result:
The output is the same as described in Comment 0 as far as content selection is concerned. The formatting however, instead of changing to bulleted and numbered list, has gone blank. The formatting dropdown shows no value and no button in the VE toolbar is selected.

Pressing backspace still deletes the space and the word. It also resets the formatting to paragraph.
There's code to address this bug in the following patch, which is due to go live by mediawiki.org on 13 September 2013:

https://gerrit.wikimedia.org/r/#/c/82858/

Please let us know whether it fixes the bug!
System environment:
Win 7 X64
Google Chrome 29.0.1547.62 m

Steps to reproduce:
Open a blank page
Edit it in VE
Enable ULS IME hindi transliteration

Input 1:
agar[SPACE][ENTER/RETURN KEY]

Input 2:
kyaa[SPACE]

Expected output 1:
अगर[SPACE][NEWLINE]

Expected output 2:
क्या[SPACE]

Actual output 1:
[NEWLINE]

Actual output 2:
[SPACE]

For the first case, when the given characters are typed, everything is fine upto the pressing of the return key, ie agar[SPACE] gives अगर[SPACE] as expected. However, as soon as the return key is pressed the entire text disappears leaving only a newline.

For the second case, everything is fine till [SPACE] is pressed.

If the page is not blank, extreme weirdness occurs, which can only be explained with further bugs (which I'm about to file). In short though, the disappearances persist, along with other buggy effects.

Note: Page used for this test is [[:w:hi:सदस्य:Siddhartha Ghai/sandbox]]

--------------------------
**Version**: unspecified
**Severity**: normal
As of https://gerrit.wikimedia.org/r/#/c/264577/ in #jquery.ime this should now be resolved and working for all users, and will be part of the wmf.12 release starting tomorrow.
Hi,

Besides Marathi and Hindi I tested this bug for more indic languages like Bangla, Ahirani,Konkni, etc.

Even after defficulties I am trying to use VE+ULS combination on Marathi Wikipedia as much as possible to have real time feel and understand the issues better.

For an example on Marathi Wikipedia we do have a page https://mr.wikipedia.org/wiki/वॉर_अँड_पीस . Other than info box it is empty. In Hindi and Marathi Wikipedia we do have large(huge) number of pages which are almost empty.Not able to type first word itself is a major hindrance and challenge before VE+ULS combinations.

So wish and hope bug number 53700 and 53705 remain on priority list 


rgds
HTML after input kyaa[SPACE]

**Attached**: {F11140}
HTML after input kyaa

**Attached**: {F11139}
HTML after input agar[SPACE][ENTER/RETURN KEY]

**Attached**: {F11138}
HTML after input agar[SPACE]

**Attached**: {F11136}
(In reply to comment #3)
> Here's the HTML which is in the result:

The above HTML is not entirely correct. Copy-pasting messed up the text nodes. I'll be adding screenshots for the html as seen in the chrome console.
(In reply to comment #2)
> There's code to address this bug in the following patch, which is due to go
> live by mediawiki.org on 13 September 2013:
> 
> https://gerrit.wikimedia.org/r/#/c/82858/
> 
> Please let us know whether it fixes the bug!

The bug is not fixed. The behaviour for both the spaces specified in Comment 0 is still the same. Tested at https://www.mediawiki.org/wiki/User:Siddhartha_Ghai?veaction=edit

Here's the HTML which is in the result:

HTML for Input 1:

<div class="ve-ce-documentNode ve-ce-branchNode" contenteditable="true" spellcheck="true" lang="en" dir="ltr"><p class="ve-ce-branchNode"><span class="ve-ce-branchNode-slug ve-ce-branchNode-inlineSlug">﻿</span></p><p class="ve-ce-branchNode"><span class="ve-ce-branchNode-slug ve-ce-branchNode-inlineSlug">﻿</span></p></div>

HTML for Input 2:

<div class="ve-ce-documentNode ve-ce-branchNode" contenteditable="true" spellcheck="true" lang="en" dir="ltr"><p class="ve-ce-branchNode">&nbsp;</p></div>
There's code to address this bug in the following patch, which is due to go live by mediawiki.org on 13 September 2013:

https://gerrit.wikimedia.org/r/#/c/82858/

Please let us know whether it fixes the bug!
The further weirdness mentioned above is explained in Bug 53706 and Bug 53708
*VisualEditor+ULS Method of input = अक्षरांतरण language=Marathi 
Script=Devanagari  (Non-VE source edit environ,ULS Method of input = अक्षरांतरण
works normal     

*Tested Browser and OS =Firefox+Win7

*Problem description =In normal speed typing,after we type first alphaabate cursor moves from right to left direction.Word marathi need to apear मराठी with VE+ULS instead is coming राठीम 	

**additional details = Marathi language devanagari is written in left to right direction.But when we use ULS Method of input = अक्षरांतरण with VE cursor is moving in opposite direction after typing first charecter as if we are typing a right to left script after typing first charecter and then again moves left to right 

*Screenshot will be added

--------------------------
**Version**: unspecified
**Severity**: major
**See Also**:
https://bugzilla.wikimedia.org/show_bug.cgi?id=49569
As of https://gerrit.wikimedia.org/r/#/c/264577/ in #jquery.ime this should now be resolved and working for all users, and will be part of the wmf.12 release starting tomorrow.
Would it be possible to test against current master? You can use this at
http://en.wikipedia.beta.wmflabs.org/ - we believe that we may have fixed the
issues (or, at least, changed the behaviour) since you tested it.

Thank you!
Automatic Incorrect caret movement has been reported separately as Bug 54424

I suspect that this bug is a special case of that bug, but I may be wrong.
(In reply to comment #2)

Did primary testing seems some change of behaviour and different kind of weird  aspects . will need more tests and time before confirming. 

Rgds
There's code to address this bug in the following patch, which is due to go live by mediawiki.org on 13 September 2013:

https://gerrit.wikimedia.org/r/#/c/82858/

Please let us know whether it fixes the bug!
[Not a blocker, see http://www.mediawiki.org/wiki/Bugzilla/Fields#Severity ]

> *Tested Browser and OS =Firefox+Win7

Which Firefox version?


What I tried:
1. Go to http://mr.wikipedia.org/wiki/%E0%A4%85%E0%A4%AB%E0%A4%97%E0%A4%BE%E0%A4%A3%E0%A4%BF%E0%A4%B8%E0%A5%8D%E0%A4%A4%E0%A4%BE%E0%A4%A8
2. make sure to be logged in
3. Go to माझ्या पसंती (Preferences), संपादन and enable last option: यथादृश्यसंपादक कार्यान्वित करा (केवळ मुख्य(लेख) आणि सदस्य नामविश्वात) - this enables VisualEditor
4. Click cog next to इतर भाषांमध्ये
5. Under क्षेपन (टायपींग ईनपुट) make sure to choose अक्षरांतरण
6. Click संपादन (Edit)
7. Make sure that URL ends with &veaction=edit
8. Type

Results are weird under Firefox 23.0.1 and Fedora 19 (new lines inserted etc), but typing is not always backwards.
*VisualEditor+ULS Method of input = अक्षरांतरण language=Marathi  Script=Devanagari  (Non-VE source edit environ,ULS Method of input = अक्षरांतरण works normal 	

*Tested Browser and OS =Firefox+Win7

*Problem description = No other text on a page> Type a word + space bar = eliminates typed text imidiately

**additional details = If some text is already there on the page or we copy paste then we can give the space bar with less frequency of this problem.


*Screen shot or Difference of edit if available = Can not create the screen shot/or edit diff


Thanks and Regards

--------------------------
**Version**: unspecified
**Severity**: major
**See Also**:
https://bugzilla.wikimedia.org/show_bug.cgi?id=49569
https://bugzilla.wikimedia.org/show_bug.cgi?id=53706
As of https://gerrit.wikimedia.org/r/#/c/264577/ in #jquery.ime this should now be resolved and working for all users, and will be part of the wmf.12 release starting tomorrow.
Not just Marathi/Devanagari specific, apparently it's a general problem with jquery.IME in VE.
*** Bug 54960 has been marked as a duplicate of this bug. ***
(In reply to comment #6)
> (In reply to comment #4)
> > I tested on  mr wiki
> 
> As comment 3 said, it's available on ***mediawiki.org***, not mr wiki (yet).
> mediawiki.org is where to test it.

Confirming this is not fixed.

System environment:
Win 7 X64 SP1
Google Chrome 29.0.1547.66 m

Test URL:
https://www.mediawiki.org/wiki/User:Siddhartha_Ghai?veaction=edit

Steps to reproduce:
Enable ULS IME mr transliteration (labelled अक्षरांतरण)
Blank the page (and reset formatting to simple paragraph, i.e remove bulleted list formatting)

Input 1:
agar[SPACE]

Output 1:
[SPACE]

Expected Output (as seen in the old editor):
अगर्[SPACE]

Input 2:
kyaa[SPACE]

Output 2:
[SPACE]

Expected Output (as seen in the old editor):
क्या[SPACE]
(In reply to comment #4)
> I tested on  mr wiki

As comment 3 said, it's available on ***mediawiki.org***, not mr wiki (yet). mediawiki.org is where to test it.
Hello,

This is 14th Sept 18.52 pm Indian standard time. I tested on  mr wiki couple of pages and tested on en wiki my own user space . To me problem is as is and not resolved.


Thanks and best wished for your continued effort


Rgds
There's code to address this bug in the following patch, which is due to go live by mediawiki.org on 13 September 2013:

https://gerrit.wikimedia.org/r/#/c/82858/

Please let us know whether it fixes the bug!
Possible duplicate: Bug 53705
[Not a blocker, see http://www.mediawiki.org/wiki/Bugzilla/Fields#Severity ]

Confirming for Firefox 23.0.1 and Fedora 19.

Steps to reproduce:
1. Go to non existing page like https://mr.wikipedia.org/w/index.php?title=%E0%A4%85%E0%A4%AB%E0%A4%97%E0%A4%BE
2. make sure to be logged in
3. Go to माझ्या पसंती (Preferences), संपादन and enable last option: यथादृश्यसंपादक कार्यान्वित करा (केवळ मुख्य(लेख) आणि सदस्य नामविश्वात) - this enables VisualEditor
4. Click cog next to इतर भाषांमध्ये
5. Under क्षेपन (टायपींग ईनपुट) make sure to choose अक्षरांतरण
6. Click तयार करा (Create page)
7. Make sure that URL ends with &veaction=edit
8. Type a word and press spacebar.
A user reported a problem to use the "clear formatting" shortcut with a french AZERTY keyboard. The shortcut is "Ctrl + \", but "\" is only accessible as "AltGr + 8".

First, even with, "Ctrl + AltGr + 8", the shortcut doesn't work. I was unable to find a keyboard combination that triggers the "clear formatting" shortcut. When using a classic QWERTY keyboard, "Ctrl + \" works on the same computer/browser.
See https://bugzilla.wikimedia.org/show_bug.cgi?id=51507

But, when testing, I noticed an other problem, with a behaviour depending on OS/browser when using "Ctrl + AltGr + 8" with text selected:
* On W7 + Chrome 29, the selected text is replaced by "\", but VE doesn't see any modification: save is disabled, undo is disabled, ...
* On W7 + Firefox 23, the selected text is replaced by "\", and VE sees that text has been modified
* On Ubuntu 12.04 LTS + Firefox 20, a user report that all page is selected.

Same kind of problems happen with "Ctrl + Alt + 8", "Alt + 8", ... or other digits.

https://fr.wikipedia.org/w/index.php?title=Wikipédia:ÉditeurVisuel/Avis#Raccourci_clavier_pour_effacer_la_mise_en_forme

--------------------------
**Version**: unspecified
**Severity**: normal
**See Also**:
https://bugzilla.wikimedia.org/show_bug.cgi?id=51507
Actually I think this was already fixed before Change 247800: On Ubuntu 15.10 with French keyboard, Alt+8 into a non-collapsed selection seems to overwrite the selection with \ in both the DOM and the DM, in both Firefox 42 and Chromium 45.
Change 247800 had a related patch set uploaded (by Divec):
Diff richtext to build model changes

[[https://gerrit.wikimedia.org/r/247800]]
Trigger issue is split to bug 56452. Re-titled.
At https://en.wikipedia.org/w/index.php?title=Flight_endurance_record&oldid=571122193#Free_Balloon.2C_Manned the table begins with an empty row where there would normally be a header:
{|class="wikitable"
|-
|-
|content

In view mode this empty line is not shown, but it does appear in VE.

Testing at https://en.wikipedia.org/w/index.php?title=User:Thryduulf/sandbox&oldid=571124234#Tables_with_empty_rows shows that the same thing happens, wherever the blank line is in the table. Oddly though the line is shown at full height when its in last position but ~half height elsewhere.

In itself this isn't a problem, it's just different to what happens in view mode where the second |- is ignored.

--------------------------
**Version**: unspecified
**Severity**: minor
This was fixed a while ago by the Parsoid team.
--------------------------
**Version**: unspecified
**Severity**: enhancement
Change 129856 merged by jenkins-bot:
Restyle parameter pages

https://gerrit.wikimedia.org/r/129856
Change 129856 had a related patch set uploaded by Trevor Parscal:
Restyle parameter pages

https://gerrit.wikimedia.org/r/129856
--------------------------
**Version**: unspecified
**Severity**: enhancement
Verified the fix in test2
Done in I8f84a9ae277e5093356f591f7a56e8cebf4a1893.
--------------------------
**Version**: unspecified
**Severity**: minor
Change 74566 merged by jenkins-bot:
Scroll into view support

https://gerrit.wikimedia.org/r/74566
Change 74566 had a related patch set uploaded by Jforrester:
Scroll into view support

https://gerrit.wikimedia.org/r/74566
[Now tracked as #VisualEditor-MediaWiki-Templates instead.]


Fork from bug 49833, which wasn't meant to be used this way.

--------------------------
**Version**: unspecified
**Severity**: normal
[adding the #tracking project to tasks blocking (now deprecated) T4007 as part of T93366]
Gadget checkboxes should be able to be grayed out (inaccessible) dependent on if another gadget is on or off, if other extensions exist that gadgets are unable to use, or if they require a specific skin to work.  For example, on en.wikipedia the current "Editing" section of the gadget tab on the preferences page looks like:
 
[[ https://commons.wikimedia.org/wiki/File:Special_Preferences_mw-prefsection-gadgets_(current).png | commons:File:Special_Preferences_mw-prefsection-gadgets_(current).png ]]

There should be a way to gray out functions, like:
 
[[ https://commons.wikimedia.org/wiki/File:Special_Preferences_mw-prefsection-gadgets_(proposed).png | commons:File:Special_Preferences_mw-prefsection-gadgets_(proposed).png ]]
If (in this instance) VisualEditor is enabled.
>>! In T55584#581617, @matmarex wrote:
> The BetaFeatures extension implements something similar, maybe it could be extended to work with Gadgets. But I'm not sure if it's a good idea, you could just use the dependency system to load other gadgets regardless.

Except in cases where the user doesn't want to use that other gadget.  In those cases, the dependent gadget should be greyed out and indicate they require the other component.  This lets the editor/user decide.
The BetaFeatures extension implements something similar, maybe it could be extended to work with Gadgets. But I'm not sure if it's a good idea, you could just use the dependency system to load other gadgets regardless.
https://fr.wikipedia.org/w/index.php?title=Polisy&veaction=edit
or
https://fr.wikipedia.org/w/index.php?title=Aix-en-Othe&veaction=edit

The demographic histogram gets duplicated while VEditing, although everything will be fine again once you save, but I see this can confuse users.

Looks like it is generated, like other parts of the Démographie section, by https://fr.wikipedia.org/wiki/Mod%C3%A8le:Section_d%C3%A9mographie_d%27article_de_commune_de_France .

--------------------------
**Version**: unspecified
**Severity**: normal
I don't see anything weird either on https://fr.wikipedia.org/w/index.php?title=Aix-en-Othe&veaction=edit

Closing as FIXED.
I discovered the bug in August 2013 and it was said to be fine from November 2013 at fr.wp. It must have been fixed by chance.
Looks fine to me... Was this fixed at some point?
Have seen multiple instances of this one backing up on commonswiki slaves recently:

SELECT /* IndexPager::buildQueryInfo (LogPager) 148.160.132.46 */  log_id,log_type,log_action,log_timestamp,log_user,log_user_text,log_namespace,log_title,log_comment,log_params,log_deleted,user_id,user_name,user_editcount,ts_tags  FROM `logging` FORCE INDEX (times) LEFT JOIN `user` ON ((log_user=user_id)) LEFT JOIN `tag_summary` ON ((ts_log_id=log_id))  WHERE (log_action != 'revision') AND (log_type != 'suppress') AND log_type IN ('delete','move')  AND log_namespace = '0' AND log_title = '0' AND ((log_deleted & 1) = 0)  ORDER BY log_timestamp DESC LIMIT 11

It runs in excess of 10 minutes.

EXPLAIN says the FORCE INDEX sends MySQL onto a very slow index scan over `times` (log_timestamp) which is hardly better than a table scan in this case.

Removing the FORCE allows `page_time` index be used which reduces execution time to a few seconds.

Suggest either filtering by a range on log_timestamp or removing the FORCE.

--------------------------
**Version**: 1.23.0
**Severity**: normal
**See Also**:
https://bugzilla.wikimedia.org/show_bug.cgi?id=54122
With partitioned slaves LogPager queries are still not super fast, but they average <10s now and no longer dominate the slow query log.

Closing this.
16 looks reasonable, I just wouldn't want something crazy like 256 ;)
16 partitions, a number chosen after some rough back-of-napkin style calculations for the larger wikis.

The effect of accessing multiple partitions is closest to UNION. I don't anticipate excessive sorting or limiting penalties for our other queries though I do want to see how range access and index scans perform.

Monitoring for queries adversely affected is definitely necessary and one of the reasons for only partitioning one slave per shard.
How many partitions per table? So the Special:Log (no filter) case will have to UNION/resort/limit queries from each partition?
Much better than it was.

I'm now trialing partitioned logging tables on one slave per production shard and directing these queries to those boxes. Since most of the queries use log_user = N, partitioning on key(log_user) allows the optimizer to use partition pruning.

Still have to track down and sort out the ones without log_user = N. They're infrequent and low priority.
Resetting status as per comment 9. Sean: Is this still high prio?
You're right, most of the slow queries we've seen in spikes do filter by log_user. But there are others that don't that also run slow.

Ishmael, S3, db1003:

/* IndexPager::buildQueryInfo */ select log_id, log_type, log_action, log_timestamp, log_user, log_user_text, log_namespace, log_title, log_comment, log_params, log_deleted, user_id, user_name, user_editcount, ts_tags from `logging` left join `user` on ((log_user=user_id)) left join `tag_summary` on ((ts_log_id=log_id)) where (log_type not in(?+)) and (log_type != ?) order by log_timestamp desc limit ?

I went to S3 because that's where I saw the query form previously (zhwiktionary at the time). A quick check on S2 slaves doesn't show the same query running slow there, though there are other versions:

* IndexPager::buildQueryInfo */ select log_id, log_type, log_action, log_timestamp, log_user, log_user_text, log_namespace, log_title, log_comment, log_params, log_deleted, user_id, user_name, user_editcount, ts_tags from `logging` left join `user` on ((log_user=user_id)) left join `tag_summary` on ((ts_log_id=log_id)) where (log_type != ?) and log_type = ? and log_namespace = ? and log_title = ? and ((log_deleted & ?) != ?) order by log_timestamp desc limit ?

It's possible we'll trawl some of these up with the existing patch. Just something to keep in mind.
Which slow queries are *not* filtering on user ID? I thought that is where the slow queries still mostly happen.
Change 95584 merged by Springle:
Changed use of tag_summary to use change_tag with GROUP_CONCAT()

https://gerrit.wikimedia.org/r/95584
True, ct_log_id cardinality still isn't brilliant, but it's better than ts_log_id.  The index is one that fluctuates cardinality estimates quite a bit between slaves, requiring periodic ANALYZE.  Eg, today the enwiki slaves manage to report ct_log_id cardinality values between 21 and 290251 :-| 

Also, ct_log_id index covers (ct_log_id,ct_tag) which is useful.

I've been trying different values for innodb_stats_sample_pages (=16 and =32) on several slaves to see if cardinality for a number of flakky indexes can be stabilized without the need for regular analysis (because of http://bugs.mysql.com/bug.php?id=33278). 

After our chat on IRC on Friday I applied the change_tag/subquery version to other examples of slow LogPager logged on various wikis. It is generally better overall but can still be susceptible to hitting too much cold data.

I'd still really like to see consideration on:

- Making log_user=N clause enforced. The examples of the query that don't filter by user id hit the most rows.

- If log_user=N isn't to be used then limit exposure to the last N months of data or something or change the way it's viewed entirely.

- Consideration of your suggestion to break up tag_summary into three tables, which seems like a good plan given we already denormalize for tag_summary.
Though actually doesn't change_tag also have similar poor cardinality problems for the log_id index?
Change 95584 had a related patch set uploaded by Aaron Schulz:
Changed use of tag_summary to use change_tag with GROUP_CONCAT()

https://gerrit.wikimedia.org/r/95584
Comment 2 correct.
Was this removed together with other FORCE INDEX recently?
Similar:

SELECT /* IndexPager::buildQueryInfo (contributions page unfiltered) AstroChemist */  rev_id,rev_page,rev_text_id,rev_timestamp,rev_comment,rev_user_text,rev_user,rev_minor_edit,rev_deleted,rev_len,rev_parent_id,rev_sha1,user_name,page_namespace,page_title,page_is_new,page_latest,page_is_redirect,page_len,ts_tags  FROM `revision` INNER JOIN `page` ON ((page_id = rev_page)) LEFT JOIN `user` ON ((rev_user != 0) AND (user_id = rev_user)) LEFT JOIN `user_groups` ON ((ug_user = rev_user) AND ug_group = 'bot') LEFT JOIN `tag_summary` ON ((ts_rev_id=rev_id)) INNER JOIN `change_tag` FORCE INDEX (change_tag_tag_id) ON ((ct_rev_id=rev_id))  WHERE (rev_user >19555425) AND (ug_group IS NULL) AND (page_namespace != '0') AND ((rev_deleted & 4) = 0) AND ct_tag = 'visualeditor' AND (rev_timestamp<'20140101000000')  ORDER BY rev_timestamp DESC LIMIT 601;

With force: 10+ mins

Without force: 8s
Attachment 1

Visual Editor became quite unusable (possibly) after a recent update in Malayalam Wikipedia. There are several selection, editing and linking problems started to appear recently. Two such problems are described here.

See the example below

1. Copy the following text and paste it in a test page at Malayalam Wikipedia using conventional editor and save it. 
ഈ ദുരന്തം ഐറിഷ് രാജ്യാതിർത്തി

2. Edit the page using VE.

3. Change the third word "ഐറിഷ്" to "അയർലൻഡ്". To do that, select the word "ഐറിഷ്" by double clicking on it and type the word അയർലൻഡ്.

4. Now I want to create a wikilink for അയർലൻഡ്. For that, I used shift+ctrl+left arrow. Now, instead of selecting the entire word, A PORTION OF THE WORD WAS SELECTED. See the attachment 1. 

5. Select the entire word അയർലൻഡ് using double clicking on it

6. Press ctrl+k. Now instead of popping up a linking suggestion for the word അയർലൻഡ്, THE WORD DISAPPEARED AND LINKING SUGGESTION FOR A PART OF NEXT WORD POPS UP. See the attachment 2

--------------------------
**Version**: unspecified
**Severity**: major
**OS**: Linux
**Platform**: PC

**Attached**: {F11751}
(In reply to comment #9)
> When will this be deployed in ml.wikipedia?

Assuming that VE is deployed according to the roadmap for MediaWiki: [[mw:MediaWiki_1.22/Roadmap]], September 19. (Sorry, I should have mentioned that in my previous comment :) )
(In reply to comment #7)
> vssun, on which wiki? The patch is only deployed at [[mw:|MediaWiki.org]]
> right
> now.

Thank you. The bug is about Malayalam Wikipedia (already mentioned in description)

When will this be deployed in ml.wikipedia?
(In reply to comment #6)
> Still facing all the problems mentioned at comment 1

Please always provide clear and exact steps to reproduce (e.g. URL testcase).
Resetting status as I assume that this is fixed on mediawiki.org.
vssun, on which wiki? The patch is only deployed at [[mw:|MediaWiki.org]] right now.
Still facing all the problems mentioned at comment 1
Marking this as "FIXED" on the expectation that it's fixed - please re-open if you find that it is still occurring.
There's code to address this bug in the following patch, which is due to go live by mediawiki.org on 13 September 2013:

https://gerrit.wikimedia.org/r/#/c/82858/

Please let us know whether it fixes the bug!
(In reply to comment #2)
> Sorry for the incorrect attachment links on the above comments. Please
> correct it if somebody can.

Sorry, links in comments can't be edited in Bugzilla. :-(
Sorry for the incorrect attachment links on the above comments. Please correct it if somebody can.
Attachment 2

**Attached**: {F11752}
When editing a document that contains:

* Foo
* Bar
* Baz

Adding an attribute to one of the list items in VE doesn't roundtrip (they serialise back to * instead of forcing <ul><li>..</ul>, as it will have to).

Right now VisualEditor never does this, but earlier today I was experimenting with this (the language inspector might need to do this to properly flip the directionality of an individual list item, wrapping the inner content is not an option as then the number would be on the wrong side).

When trying to reproduce this I noticed that it also happens when creating a new document (e.g. there is no existing page, it has no reason to force "*" instead of "<li>" other than that being the preferred default for wikitext).


http://parsoid.wmflabs.org/_html/:

In:
<div dir="ltr">
<ul>
<li>a
<li lang="he" dir="rtl">b
<li>c
</ul>
</div>

Out:
<div dir="ltr">

* a
* b
* c

</div>

The only case where Parsoid kept the attributes is when not editing a document with wikitext, and not creating a new document, but when editing an existing document with "<li>" in wikitext already, it did roundtrip those.

--------------------------
**Version**: unspecified
**Severity**: normal
**See Also**:
https://bugzilla.wikimedia.org/show_bug.cgi?id=68800
@esanders, @Catrope, @Jdforrester-WMF, Is this an use case that Parsoid should support in Q3 / Q4?
Timo indicated on IRC that lists and list items will be first, but other elements will follow. We should try to use this first case to develop the general infrastructure.

We will need to convert an entire list to HTML syntax if an attribute is set on either the list or any list item.

Mixed templated / non-templated list items are discussed in bug 53368. We protect the entire list if any list item's bullets are template-generated. That means that we (thankfully!) won't have to consider that case here.
MyOnlyEye says, "When I write long articles in VisualEditor the whole screen scolls - and the VisualEditor toolbar is scrolling upward and out of the screen. If I want to make a headline or instert a picture I'll have to scroll up to the top to reach the toolbar. I've tried it in the lastest edition of Firefox and Chrome in Win8 - on my own mediawiki with visualeditor and Wikipedia and Mediawiki....On every page that is longer than the screen - e.g. http://en.wikipedia.org/wiki/Electron?veaction=edit
I've tested a bit (after I wrote the feedback) and it seems to be OK on my Win7 and Linux-box (chrome and firefox, both in 64-bit), but it's not working on Win8 (32-bit). Both the lastest 32-bit edition of Chrome and Firefox have the "scrolling error" on my Acer W510 Win8-laptop in desktop-mode (and in tile-mode :-)....I tried the electron-article and updated my own wiki (with git pull on mediawiki developer and visualeditor). I tried it in Firefox and Chrome (latest 32-bits editions)....I've installed a virtualbox with Win8 (32-bit, same as my Acer W510) and ran some wiki-pages with visualeditor in Chrome. No problem with the toolbar. So there seems to be two options left - 1) it's the intel screen driver (Intel HD 9.14.3.1102) or 2) it's how the browsers behave in a touch screen environment. My W510 has touch screen, the virtualbox Win8 hasn't....
I've tested it on another Win8-machine (ASUS VivoBook S400 14" HD touch) with different hardware than Acer W510 _but_ with a touch screen - and... the toolbox/-bar scrolled out of the screen. So my guess is that this is something that happens when the browser knows that the user can scroll the webpage with the fingers."

It is apparently not quite the same as https://bugzilla.wikimedia.org/show_bug.cgi?id=52504

--------------------------
**Version**: unspecified
**Severity**: normal
**odin** wrote:

Now working in the lastest Firefox v25.0 for Windows8. Still not working in latest Chrome.
**odin** wrote:

Also confirmed in Android 4.3 (with default Chrome browser) on Asus Nexus 7 (2012).
**odin** wrote:

I just testet the bug in Android 4.2.1 with Chrome (on a Samsung Galaxy S4) - and when I scroll, the toolbox moves out of the screen.
This sounds bad for our impending work for mobile. :-(
I am filing a related common problem we meet at it.wp.

We had troubles with nowikis being thrown right after some templates when the
user did not add an extra space there, but simply edited something in that
page. See
https://it.wikipedia.org/w/index.php?title=Wikipedia&diff=61171396&oldid=61171228
.

We actually found a workaround for this:
https://it.wikipedia.org/w/index.php?title=Template:Quote&curid=224372&diff=61173726&oldid=60749506
but since this addition is apparently a nonsense, users demand that VE prevents
that behaviour instead.

They also think this is related to templates featuring some kind of table.

I did some tests as well.
I was able to reproduce an unwanted situation where the first line and the
table (which is actually a template) were mingled in a non-editable block
https://it.wikipedia.org/w/index.php?title=Utente%3AElitre_%28WMF%29%2FSandbox_VE&diff=61181542&oldid=61181524
.

But I was also able to avoid nowikis, even if the extra span tags were not
added to the template: as you can see here
https://it.wikipedia.org/w/index.php?title=Utente:Elitre_(WMF)/Sandbox_VE&diff=prev&oldid=61181473,
if the first letter of the line is actually closer to the template's final
brace (with no space between), VEditing that page will result in the text
getting automatically placed in a better position, and no nowikis in sight,
even after multiple saves of the page.

Thanks.

--------------------------
**Version**: unspecified
**Severity**: normal
Related Parsoid behavior (this is serialization of new content):
-----------------------
[subbu@earth lib] echo "<table><tbody><tr><td>foo</td></tr></tbody></table> a" | node parse --html2wt
{|
|foo
|}
<nowiki> </nowiki>a
-----------------------

The following is for existing content in wikitext
-----------------------
[subbu@earth lib] echo "{|\n|a\n|} a" | node parse --wt2wt
{|
|a
|} a
-----------------------

So, Parsoid does not split the line after the table if it is old content, but does if it is new content and can introduce a <nowiki>  Since the report states that happens no matter what is edited on the page, my suspicion is that the HTML has a newline break after the <table> added by VE.  Requires further investigation that I cannot do right now, but hope this is good for starters. Adding others who might have time to investigate.
Templates that are inserted to a page in RTL appear first floating on the right side, then only after save and re-edit they appear correctly.

Replicate:
1. Go to hewiki (or any other rtl wiki)
2. Add a template - for instance {{עליות}} which is supposed to be floated left - yet it is inserted floating right.
3. Save the page. Edit it again -- the template floats in the correct direction.

--------------------------
**Version**: unspecified
**Severity**: normal
**Author:** `p.selitskas`

**Description:**
Entries in Page settings / Languages don't have dir attributes for the link text. It leads to bidi issues for RTL languages.

Reproducing:
1. Go to an article with a langlink to Hebrew, for instance. Here's my favourite: [[en:August 3]].
2. Open the VisualEditor.
3. Go to Page settings / Languages and scroll down to 'he'.
4. Link text reads as "3 באוגוסט", but it should read with "3" after Hebrew characters (reading left-to-right, of course; in the beginning of the string, if right-to-left).

--------------------------
**Version**: unspecified
**Severity**: normal
Merged and will go out with wmf16 (from Thursday 5 September).
Change 81589 merged by jenkins-bot:
VisualEditor: RTL entries don't receive dir="rtl" in Page settings / Languages

https://gerrit.wikimedia.org/r/81589
Change 81589 had a related patch set uploaded by Wizardist:
VisualEditor: RTL entries don't receive dir="rtl" in Page settings / Languages

https://gerrit.wikimedia.org/r/81589
See numbers 49 and 50 in https://pl.wikipedia.org/w/index.php?title=Biurokracja&oldid=37367869 and https://pl.wikipedia.org/w/index.php?title=Biurokracja&oldid=37367869&veaction=edit

--------------------------
**Version**: unspecified
**Severity**: normal
**See Also**:
https://bugzilla.wikimedia.org/show_bug.cgi?id=51289
https://bugzilla.wikimedia.org/show_bug.cgi?id=52300
Actually, on review I'm pretty sure that this is a duplicate of bug 50474.

*** This bug has been marked as a duplicate of bug 50474 ***
at en.wp user:KWW wonders if this is the same issue as bug 52300?
Looking again, it seems this is not the same as the earlier bug. In that case the references from the infobox didn't appear in the reflist at all. Now it seems that it is just the numbering that is wrong. At [[Ptyhon (programming language)]] for example, there are 10 references in the infobox, so the first reference in the lead is numbered 11. 

Looking at in VE though the first reference in the lead (TIOBE Software Index (2012)) is numbered 1. In the reference list though TIOBE Software Index (2012) is numbered as 11 and reference 1 is the first one from the infobox.
To clarify the first comment: if you look at the vedit view of the page I linked, you'll see that references 50 and 49 are both labelled "49". So, potentially we might be dealing with two distinct bugs here - renumbering because it's not factoring in different surfaces, and duplicate numbering.
References in infobox not populating the main references list and not being counted sounds a lot like bug 51289 which was marked fixed at the start of the month
<< Entering Visual Editor mode renumbered the references on page Python_(programming_language) https://en.wikipedia.org/wiki/Python_(programming_language)?veaction=edit , so they don't match the references listed at the end of the article. Davipo 08:36, 29 August 2013 (UTC) >>
It will ignore the numbers in the infobox, and start again from n.1 in the first line of the article - should be 11 instead. I find it just slightly confusing, since in the end you are still able to edit footnotes correctly. Thanks.
The transclusion editor should not allow (or at least should warn about) template parameters with unmet dependencies.

For example in [[template:For]] parameter 4 has no effect unless parameter 3 is also specified, so the transclusion editor should not allow/warn about template 4 without an accompanying parameter 3. (parameter 3 is otherwise optional and can be present without parameter 4).

In at least some cite templates, parameter author2 requires the existence of author1, etc. 

I'm fairly sure that this functionality depends on bug 50407, which requests that TemplateData allows dependency relationships like this to be defined.

--------------------------
**Version**: unspecified
**Severity**: enhancement
Redlinks right now always take you into wikitext editor, regardless of what editor is primary on your wiki.

--------------------------
**See Also**:
{T54162}
{T54281}
Makes sense. I'll do that.
>>! In T55441#2039758, @Johan wrote:
> Something like this:
> 
> "In the future, clicking a red link will open the page in your primary editor. Today it will open it the wikitext editor. This will only work for wikis with [[<tvar|set>mw:Special:MyLanguage/VisualEditor/Single edit tab</>|single edit tab]]."
> 
> (I know the change is happening now, but unless it actually affects editors because it only works for wikis with the single edit tab, it's still a future change for them.)

The wording looks good. I'd push this to next week, and talk about how it will (then) be live on huwiki and people can see it there.
Something like this:

"In the future, clicking a red link will open the page in your primary editor. Today it will open it the wikitext editor. This will only work for wikis with [[<tvar|set>mw:Special:MyLanguage/VisualEditor/Single edit tab</>|single edit tab]]."

(I know the change is happening now, but unless it actually affects editors because it only works for wikis with the single edit tab, it's still a future change for them.)
Something like this:

"In the future, clicking a red link will open the page in your primary editor. Today it will open it the wikitext editor. This will only work for wikis with [[<tvar|set>mw:Special:MyLanguage/VisualEditor/Single edit tab|single edit tab]]."

(I know the change is happening now, but unless it actually affects editors because it only works for wikis with the single edit tab, it's still a future change for them.)
So does this affect any other wikis than the test wiki at the moment? Hungarian Wikipedia is supposed to get the single edit tab, but doesn't have it yet, right?
(Only fixed for Single Edit Tab wikis.)
>>! In T55441#1446269, @matmarex wrote:
>>>! In T55441#1446171, @Ricordisamoa wrote:
>>>>! In T55441#1446154, @Krenair wrote:
>>> We'd like to have a single edit tab where the user can chose between VE and a wikitext source editor
>> 
>> https://meta.wikimedia.org/wiki/Wikiafication
> 
> This comment is at best unfair and at worst willful ignorance or trolling. Being able to switch between editors while editing has been requested repeatedly, and using the action=edit view for editors is the obvious choice, already made by others such as CodeEditor. It is the most obvious, most intuitive and best way to present two or more editors

It proves that the essay is biased and Wikiafication can be good sometimes.
>>! In T55441#1446955, @TTO wrote:
> Many of the MW installations that have requested this appear to be corporate/internal wikis. Would you be willing to provide the feature for them, even if you do not enable it on WMF wikis?

Yes, that's fine (though ideally we'd do so in a way that doesn't create technical debt in MediaWiki which we'd have to carry).
Many of the MW installations that have requested this appear to be corporate/internal wikis. Would you be willing to provide the feature for them, even if you do not enable it on WMF wikis?
>>! In T55441#1446206, @Solstag wrote:
> This bug is about making the default choice of editor consistent. For red links. It's that simple.

I understand. The current situation is poor for the majority of people who click 'edit' rather than 'edit source' and get VE rather than WT, except when it comes to red links.

However, just blindly changing these from WT to VE would be a bad move for a few reasons:

* It's a pretty core disruptive change to a core part of how MediaWiki works, which means it would probably break a number of scripts, gadgets, bots and other tools that have been built over the past 15 years relying on this being a certain way.
* It would take a long time to roll out in Wikimedia production, as this would be a breaking change to the read HTML with `href`s' targets being changed, meaning the benefit for IPs would take many weeks to be fully felt (and likely breaking other things).
* It would replace the bad system (use WT, no choice) with another bad system (use VE, no choice), rather than a 'proper' system of user choice
* It would be particularly disruptive for 'power editors', who would be forced to switch over to WT every time they clicked edit, likely leading them to opt-out of VE in huge numbers.
* It would be inconsistent – for namespaces which are WT-only, like `MediaWiki:` or `Template:`, would it take you to WT anyway?
* For users who can't use VE (//e.g.// no JS, something we can't fix server-side), it would strand them on the 'read' page, rather than take then to WT

Consequently, I am not willing to make this change before we have a single edit tab that solves (or obviates) each of these issues.
>>! In T55441#1446171, @Ricordisamoa wrote:
>>>! In T55441#1446154, @Krenair wrote:
>> We'd like to have a single edit tab where the user can chose between VE and a wikitext source editor
> 
> https://meta.wikimedia.org/wiki/Wikiafication

This comment is at best unfair and at worst willful ignorance or trolling. Being able to switch between editors while editing has been requested repeatedly, and using the action=edit view for editors is the obvious choice, already made by others such as CodeEditor. It is the most obvious, most intuitive and best way to present two or more editors, and not "additional and costly bloat to a site as an unsuccessful means of "engaging visitors" or "building community"", like that page states.
Please, this bug is not about having a single edit tab, or choice, or wikiafication or whatever.

This bug is about making the default choice of editor consistent. For red links. It's that simple.
>>! In T55441#1446154, @Krenair wrote:
> We'd like to have a single edit tab where the user can chose between VE and a wikitext source editor

https://meta.wikimedia.org/wiki/Wikiafication
I'm not sure we want to use this hook for VE. We'd like to have a single edit tab (pointing to action=edit) where the user can chose between VE and a wikitext source editor instead, so this would be obsolete.
>>! In T55441#1433506, @Juandev wrote:
> So, why it was told to me, we need a community consensus?! Dont tell me that it cannot be set differently to each project?!

At the moment, it cannot, because the feature you are asking for doesn't even exist yet. That is the problem we are trying to solve with the patch linked above.

Once that is dealt with, then we can potentially act upon the community consensus and enable the feature on that wiki, if the VE boffins agree that it is a good thing to do.
>>! In T55441#1327857, @Krenair wrote:
> When it happens, it'll happen on every wiki. Until then it can't be on any wiki...

So, why it was told to me, we need a community consensus?! Dont tell me that it cannot be set differently to each project?!
>>! In T55441#1429220, @Nemo_bis wrote:
> Red links are the single most important entry point for article editing after the edit tabs and section editing, so it makes sense to make them smarter/configurable.

I've been wondering how are articles created. Is it red links from other articles? The red links that appears when search for a page that doesn't exist? Something else?
Indeed, this bug is not about action=edit but about what gets linked most prominently. Red links are the single most important entry point for article editing after the edit tabs and section editing, so it makes sense to make them smarter/configurable.

Then of course there are many other links to handle later (think of inputbox and so on) but divide et impera applies.
@Krenair I'm a little puzzled by your comment:

>>! In T55441#1412564, @Krenair wrote:
> Sorry, but this is not a thing. MediaWiki does not let you set default=wikitext vs. default=visualeditor. You get given one editor by MediaWiki for wikitext, and it's what gets shown at action=edit (the target of all of MediaWiki's red links). 

Well, isn't that part of the point of this issue - to make redlinks configurable? Of course, T102398 would render that moot, but in the interim, I have uploaded new patch sets to https://gerrit.wikimedia.org/r/178817 that allow extensions to retarget redlinks.

I don't expect WMF wikis to use this, but some third-party installations are interested in it (judging by posts at Support Desk over the past few months).
>>! In T55441#1408724, @Solstag wrote:
> A project that has visual editor as default for

Sorry, but this is not a thing. MediaWiki does not let you set default=wikitext vs. default=visualeditor. You get given one editor by MediaWiki for wikitext, and it's what gets shown at action=edit (the target of all of MediaWiki's red links). VE hacks itself in via veaction=edit, but this cannot be considered a default by any means.
>>! In T55441#1408724, @Solstag wrote:
> A project that has visual editor as default for everybody, even unauthenticated users, should open red links with the visual editor.

A gadget (enabled by default) which replaces `action=edit` with `veaction=edit` might be the easiest short-term solution - it gives the ability to opt out, and does not cause cache fragmentation.
Hi folks! Just in case the duplicate doesn't speak by itself, I see no reason why we don't have right now:

A project that has visual editor as default for everybody, even unauthenticated users, should open red links with the visual editor.

All other projects should wait until you sort out the mess with picking the right editor for each user.

This is definitely not hard to implement, there's not even a new config involved.

Cheers and thanks for looking into this.
>>! In T55441#1327857, @Krenair wrote:
> When it happens, it'll happen on every wiki. Until then it can't be on any wiki...

A lot of Wikimedia wikis have been happily using VisualEditor for over a year, and the wikitext editor being the default even for new editors is problematic for them. (It is somewhat ridiculous, for example, that [[ https://www.mediawiki.org/wiki/Extension:SandboxLink | SandboxLink ]], which is mainly meant to make the life of new editors easier, drops them into a wikitext editor.) I don't see what's wrong with providing a per-wiki option.
Updated title to reflect actual desired end result. The url structure is secondary and may actually change (see T54281).
When it happens, it'll happen on every wiki. Until then it can't be on any wiki...
Could you enable this on cs.wv per community consensus: https://cs.wikiversity.org/wiki/Wikiverzita:Diskusn%C3%AD_prostor#Zalo.C5.BEen.C3.AD_a_editace_str.C3.A1nky_ve_VisualEditoru
Change 178817 restored by TTO:
Consistent edit links

Reason:
Seems like a valuable change.

[[https://gerrit.wikimedia.org/r/178817]]
This option should (must?) be available for those who wish to use VE on their own MediaWiki installations. Currently, redlinks are a "hole" through which unsuspecting users can "fall" into the "pipework" of the wikitext editor.

Most of the discussion here deals with the social aspects of the task, which doesn't seem hugely relevant here. The functionality would presumably live behind a $wg flag, and be switched off by default.
Change 178817 abandoned by Ricordisamoa:
Consistent edit links

Reason:
There ain't no such thing as a solution for this.

[[https://gerrit.wikimedia.org/r/178817]]
I do not plan to work on it before the discussion has an outcome (nor I have any personal interest in supporting VisualEditor at the moment), but the patch is up for anyone who wants to play with it.
Are you going to work on it more? I got the impression from the way you unassigned this that we shouldn't review the patch before discussing this further.
@Krenair: should I abandon my patch then?
This has to be discussed further.
>>! In T55441#849854, @matmarex wrote:
> What I meant is that a vocal group of English Wikipedia users hates VisualEditor's guts and would enjoy the new opportunity to spit on it. I hope this clarifies the issue. :)
> 
> VisualEditor is also still not quite compatible with some languages and some wikis' conventions, so this would regardless need to be behind a configuration option.

I thought, they asked to switch it off at all.
I support not making assumptions about the editor, but I think making action=edit point to VisualEditor would break lots of things.
I think the editor should initialise at a canonical url. Perhaps with a way to force a specific editor but the vast majority of urls should point to the edit page without making assumptions about what editor that is. This means when we switch the default, existing urls will work as expected.

We already have two different editors for wikitext (classic toolbar and WikiEditor). Though they don't have a way to switch without changing user preferences right now, WikiEditor loads on the old edit page. I think from a user perspective, VisualEditor should be introduced the same way.

action=edit:
* Would load editor based on user preference. Default user preference being the site default. As with any user preference, this preference can be made immutable or hidden from the preferences page if we don't want it to be per-user.
* Use `&editor=...` to force a specific editor. This is what can be used when applications need to interoperate. E.g. in gadgets needing wikitext. Or when VisualEditor submits data to the wikitext editor (though it may incorporate its own wikitext editor). And of course in links like "Edit" / "Edit source". And permalinks (VisualEditor may want to do a pushState to editor=ve once loaded via plain action=edit so that one can share permalinks).
What I meant is that a vocal group of English Wikipedia users hates VisualEditor's guts and would enjoy the new opportunity to spit on it. I hope this clarifies the issue. :)

VisualEditor is also still not quite compatible with some languages and some wikis' conventions, so this would regardless need to be behind a configuration option.
>>! In T55441#840960, @matmarex wrote:
> I am not sure of this change will be beneficial at this point, given that VE is currently still used by  minority of users. It might result in more people disabling VE entirely.

Why do you think so? I have a reason, why I set up VE and I am disappointed it doesn not work for creating new pages. Who might be disappointed from using it on VE?
I reported this as a nead to create new page with VE. In this ligt there is a not logic message "you follow the link to the page which does not exist" Basically yes, but I had to do the step out of the page displayed with normal wikitext editing to the different one in VE. Once this bug removed, this can stay.
One question is whether we want to just overwrite existing edit links, or to add a new one, for example in the [[ https://www.mediawiki.org/w/index.php?title=VisualEditor&action=info&uselang=en#Page_properties | page properties ]] section.
In the first case, we probably don't want that to happen on WMF sites at all.
Thanks for the patch. I think we should look for a solution that neither requires a user preference nor a forced standard for all users. Can we initialize the interface in a way that reflects the user's previous choice (for the first time, it is whatever the wiki's default is)? Can this be done intuitively without going all the way to reorganizing tabs? Partially a #design question.
I am not sure of this change will be beneficial at this point, given that VE is currently still used by  minority of users. It might result in more people disabling VE entirely.
I am not sure of this change will be beneficial at this point, given that VE is currently still used by  minority of users. It might result in more people disabling VE entirely. Especially since it still doesn't support real section editing (T50429).
Change 178817 had a related patch set uploaded (by Ricordisamoa):
Consistent edit links

[[https://gerrit.wikimedia.org/r/178817]]

#patch-for-review
Let's give it a try.
**Author:** `p.selitskas`

**Description:**
Reproducing:
1. Open the VisualEditor
2. Put the cursor in a place where "Paragraph" (or whatever else) disappears. (For example, into the ugly and unbearable empty line in pages with infobox at the very beginning.) The content editor must be kept active and cursor blinking.
3. Scroll it down a bit.
4. Press Ctrl, Alt, or Shift, or every possible combination of these
5. See the content editor scroll up step by step (or as many steps per time as many keys are in combination.

I can reproduce this in Chrome 29.0.1547.57 and Firefox 23.0.1 on Windows.

--------------------------
**Version**: unspecified
**Severity**: minor
Seems to be fixed now.
fwiw, this is still happening.
en.wp user Risker reports from an editathon that of the participants:
"not a one of them understood what the "puzzle piece" was supposed to represent, and when shown, all of them still thought it was a poorly chosen icon.  Most had no suggestion as to an alternative, although two thought "curly brackets" would be a good idea.  I suspect that's because they'd seen curly brackets for templates when using wikitext."

--------------------------
**Version**: unspecified
**Severity**: enhancement
**See Also**:
https://bugzilla.wikimedia.org/show_bug.cgi?id=51372
Can we close this given we now show text in the menu?
(In reply to comment #0)
> en.wp user Risker reports from an editathon that of the participants:
> "not a one of them understood what the "puzzle piece" was supposed to
> represent, and when shown, all of them still thought it was a poorly chosen
> icon.

Yeah; we all hate it, and are using it because it's the least-bad option suggested so far (it's historically been the icon used in attempts at visual editors for MW since 2003).

>  Most had no suggestion as to an alternative, although two thought
> "curly brackets" would be a good idea.  I suspect that's because they'd seen
> curly brackets for templates when using wikitext."

Indeed - we're trying to break the linkage with wikitext, and I don't think braces make for much of an increased level of obviousness.

The new toolbar which allows buttons to self-describe if they're in a drop-down may help this significantly, but for now will keep this open.
**ypnypn9** wrote:

How about just using the word "Template"? Words are more obvious than even the best icons. (A disadvantage of this is that it would require a lot of translations, but this is not a huge problem.)
This is probably an occurrence of an existing bug, but I couldn't find one that really fitted.

In these edits, the table header was duplicated several times:

https://fr.wikipedia.org/w/index.php?title=CM_Punk&diff=95906046&oldid=95898800
https://fr.wikipedia.org/w/index.php?title=CM_Punk&diff=95848040&oldid=95838194
https://fr.wikipedia.org/w/index.php?title=CM_Punk&diff=95778036&oldid=95766921

--------------------------
**Version**: unspecified
**Severity**: normal
The rts look pretty reasonable to me these days. I'll assume whatever was causing the issue has cleared up.

http://localhost:8000/_rt/frwiki/CM_Punk?oldid=95898800
http://localhost:8000/_rt/frwiki/CM_Punk?oldid=95838194
http://localhost:8000/_rt/frwiki/CM_Punk?oldid=95766921
http://localhost:8000/_rt/frwiki/Utilisateur%3AElitre_%28WMF%29%2FProve_VE?oldid=100438786
Yes, it is:
https://fr.wikipedia.org/w/index.php?title=Utilisateur%3AElitre_%28WMF%29%2FProve_VE&diff=100438830&oldid=100438786 .
Is thist still an issue in production?
Ya, I've responded to this here: https://en.wikipedia.org/wiki/Wikipedia:VisualEditor/Feedback#Multiplication_of_table_headers. 

This general use case of fosterable content has been handled in Parsoid. Not sure why it is failing in production when I cannot reproduce it locally. To be investigated.
Trying to work out what the cause of the bug is here; certainly, it's trying to operate on completely-broken wikitext, viz.:

{| bgcolor="#f7f0ff" border="1" cellpadding="2" cellspacing="0" style="font-size: 90%; border: gray solid 1px; border-collapse: collapse;"
** '''[[Pro Wrestling Illustrated#Top 50 Females|Top 50 Females]]

(!)

This looks to have DSR issues as well (see the creation broken syntax with a single close-] alongside the partial wikitext non-DOM-sensicle duplication), and as the broken edits don't get a VE-check tag I'm assuming the DOM is clean from the VE end - moving to Parsoid.
More of them, making a lot of damages.
Any idea when someone will look at this bug, prioritize it, assign it and fix it ?

https://fr.wikipedia.org/w/index.php?title=Kelly_Kelly&diff=96858939&oldid=96858743
https://fr.wikipedia.org/w/index.php?title=Kelly_Kelly&diff=next&oldid=96858939
https://fr.wikipedia.org/w/index.php?title=Kelly_Kelly&diff=96801326&oldid=96761115
https://fr.wikipedia.org/w/index.php?title=Kelly_Kelly&diff=prev&oldid=96761115
https://fr.wikipedia.org/w/index.php?title=Kelly_Kelly&diff=96119241&oldid=96014996
Right now the CommandRegistry only takes a single command that can be used as a keybinding for a tool on a given platform (i.e. Mac, PC, etc.); it's thus not possible to have two keyboard shortcuts for the same tool, such as Undo (where both Ctrl+Y and Ctrl+Shift+Z are commonly used).

--------------------------
**Version**: unspecified
**Severity**: enhancement
(In reply to comment #1)
> For "Undo" read "Redo" in James' comment

Err. Yes. :-)
For "Undo" read "Redo" in James' comment
VE allows to mark text as both superscripted and subscripted (<sup><sub>text</sub></sup> or the other way). That sounds like a bad idea; such text simply ends up being displayed in smaller font.

--------------------------
**Version**: unspecified
**Severity**: normal
Let's leave the bug as fixed in the original fix, not the recent minor breakage.
Verified the fix in production
Change 143756 merged by jenkins-bot:
Follow-up: If717ef98 – Re-add subscript and superscript removes to DM nodes

https://gerrit.wikimedia.org/r/143756
Change 143756 had a related patch set uploaded by Catrope:
Follow-up: If717ef98 – Re-add subscript and superscript removes to DM nodes

https://gerrit.wikimedia.org/r/143756
I can't reproduce. Steps?
This is happening again, the superscript and subscript both are getting applied at the same time.
Verified the fix in betalabs
Change 114488 merged by jenkins-bot:
Allow annotations to remove other annotations

https://gerrit.wikimedia.org/r/114488
Yeah, that's what I meant. Thanks.
(In reply to Bartosz Dziewoński from comment #9)
> (In reply to James Forrester from comment #8)
> > (a) what should happen in VE when the user attempts this
> 
> Text should be either super- or subscripted, not both.
> 
> Nesting superscripts in subscripts, subscripts in superscripts,
> subscripts in subscripts and superscripts in superscripts
> should be impossible, just like it's impossible to nest links in other
> links. Currently only the last two are impossible.

This works for me. Re-wording bug for clarity – is this acceptable to you?
Change 114488 had a related patch set uploaded by Esanders:
Allow annotations to remove other annotations

https://gerrit.wikimedia.org/r/114488
(In reply to Ed Sanders from comment #10)
> I don't think we need to alienate such nested content though, in the same
> way we don't alienate a double bold tag (if someone used one). As long as
> the user doesn't try to change the sub/superscripting, the annotations will
> remain untouched.

I'm willing to trust you on implementation details :)
I agree that the sub/superscript tool should clear any other sub/superscript annotations present. As pointed out you can't do a double superscript, so clearly our goal is not to let you create any complex hierarchy you want, that's for <math>.

I don't think we need to alienate such nested content though, in the same way we don't alienate a double bold tag (if someone used one). As long as the user doesn't try to change the sub/superscripting, the annotations will remain untouched.
(In reply to James Forrester from comment #8)
> (a) what should happen in VE when the user attempts this

Text should be either super- or subscripted, not both.

Nesting superscripts in subscripts, subscripts in superscripts,
subscripts in subscripts and superscripts in superscripts
should be impossible, just like it's impossible to nest links in other
links. Currently only the last two are impossible.

> (b) what should happen in VE when the page already has this

The same thing that happens with all other unsupported input: it
should be alienated and left alone.

> (c) what should be changed in MediaWiki's PST to stop this happening
> in future(?).

Nothing. I suppose there are very rare use cases where this could be
wanted, we should just keep supporting them for backwards-compatibility.

In fact, the only things that I see in existing articles are currently
impossible in VE – you can't nest superscripts to produce, say,
10<sup>10<sup>26</sup></sup> (10^{10^26}) used in [[pl:Oś czasu dalekiej
przyszłości]]. Arguably this should just use <math/> tags though.
Wikitext lets you do this too. Do you think we should just silently kill all examples of this in the database? :-)

Closing again unless you can suggest (a) what should happen in VE when the user attempts this, (b) what should happen in VE when the page already has this, and (c) what should be changed in MediaWiki's PST to stop this happening in future(?).
A dupe was just filed, this is not just me. Reopening.
*** Bug 56795 has been marked as a duplicate of this bug. ***
As input, sure. But as output, HTML lets you do lots of things that VE doesn't.
(In reply to comment #2)
> Do other text editors permit that? I don't know of any that would.
> 
> (Or in other words, this is not fitting users' expectations.)

Well, HTML lets you do this, which means VE needs to support it on the input side at the very least.
(Or in other words, this is not fitting users' expectations.)
Do other text editors permit that? I don't know of any that would.
I don't see how this is a bug? Yes, it's bad, in the same way that setting text's colour to be white, or putting an image inside another image's caption, but that doesn't mean we should stop people doing it…

Generally, appropriate use of the software is a social thing, not a software thing. Willing to be convinced otherwise, but for now I'll mark this as a WONTFIX.
We need ULS support in dialog boxes-

1) Template dialog boxes - adding existing template for setting paratmeters
2) Image dialog box
3) Adding or editing references

--------------------------
**Version**: unspecified
**Severity**: enhancement
Fixed with https://gerrit.wikimedia.org/r/#/c/264577/
Pavanaja: Can you elaborate on what you mean by "We need ULS support in dialog boxes". I think you mean "input method support", but I'd like to be sure.

Additionally, if you could please add the following:
1. Numbered steps to reproduce.
2. Observed behavior
3. Expected behavior

This would allow us to unambiguously understand what you expect, and work towards resolving the issue you experience.
(In reply to comment #0)
> We need ULS support in dialog boxes-
> 
> 1) Template dialog boxes - adding existing template for setting paratmeters
> 2) Image dialog box
> 3) Adding or editing references

Is this something that is done on the VisualEditor side, or inside ULS? I'm pretty sure that there was no change made in VE for the enabling of jquery.IME inside the main VisualEditor surface…

(Please move back if I'm wrong.)
[New feature => setting the "Severity" field to "enhancement". 
Feel free to do so yourself when filing a report.]

(In reply to comment #0)
> We need ULS support in dialog boxes-
> 
> 1) Template dialog boxes - adding existing template for setting paratmeters
> 2) Image dialog box
> 3) Adding or editing references

Please please elaborate what that means, for example steps to reproduce, current outcome, and expected outcome. Also see https://www.mediawiki.org/wiki/How_to_report_a_bug
reported on en.wp by Atethnekos:

"So I put a space and then a backspace. Go to save, review changes to check and make sure it is a null edit, then it goes to this "processing" dialogue but then it shows "Could not start the review because your revision matches the latest version of this page." So then I press the little back link on the dialogue, but it just goes back to the processing dialogue. If the page is small, the processing is really quick, so before I can even press back again, it goes back to the "Could not start" warning message. Even if I do manage to press the back a second time quickly, it will only stay at the save dialogue for a split second and then again bring me to the warning message, although then pressing back does take me to the save dialogue securely. FF 23.0.1 Win7"

I've confirmed this in Firefox 23.0 on Linux.
The issue is with the < link only. Clicking the ^ does return you to the editing screen as expected.

--------------------------
**Version**: unspecified
**Severity**: minor
The fix for this is now merged and will be deployed on Thursday 10 October to MediaWiki.org, and to Wikipedias on Thursday 17 October.
Change 81876 merged by jenkins-bot:
Make the save dialog an actual dialog

https://gerrit.wikimedia.org/r/81876
Change 81876 had a related patch set uploaded by Jforrester:
Make the save dialog an actual dialog

https://gerrit.wikimedia.org/r/81876
*** Bug 53314 has been marked as a duplicate of this bug. ***
Rather than passing around boolean parameters called 'reversed' all over the place, we should use each transaction only once, and implement a function that creates a new transaction that's the reverse of an existing transaction.

--------------------------
**Version**: unspecified
**Severity**: enhancement
This was done ages ago in I3050c5430be4a12510f22e20853560b92acebb67
But note that the code currently uses the fact that the commit and rollback transaction are the same in order to update the 'applied' field.  So the rollback transaction should still contain a pointer to the original transaction, and when it is committed both should be marked with 'applied=false' (which indicates that we can skip over these entries in the completeHistory).
dm.Surface.undo() and .redo() just call documentModel.rollback() / .commit() directly, without going through all the other stuff in .change() . Presumably this other stuff is useful, so we should figure out if bypassing it causes bugs.

--------------------------
**Version**: unspecified
**Severity**: normal
Change 88728 merged by jenkins-bot:
Implement ve.dm.Surface.prototype.undo() and redo() in terms of change()

https://gerrit.wikimedia.org/r/88728
Change 88728 had a related patch set uploaded by Catrope:
Implement ve.dm.Surface.prototype.undo() and redo() in terms of change()

https://gerrit.wikimedia.org/r/88728
In theory Surface.change() should also have a corresponding Surface.unchange() method (or a 'reversed' parameter).
When loading VisualEditor from a section edit link, the editor opens at that position on the page. However, as the TOC is not displayed in edit mode (bug 49224) the content is effectively rendered higher up so a later section in the article moves into the view (from a users point of view this is perceived as scrolling to a random point). 

The view point does move to the new location of the desired section as the final step of loading, but only if the user has not scrolled at any point while waiting. 

If they have attempted to find the section themselves while VE is loading then either (a) the view point subsequently doesn't move when loading completes, or (b) moves by the amount it would have done if the user had not scrolled (meaning it now points at a different point to desired). I have not worked out how to specifically induce one behaviour or indeed what causes either.

--------------------------
**Version**: unspecified
**Severity**: enhancement
**See Also**:
{T51224}
{T52206}
{T54577}
Should this be closed in favor of T52206?
Also see T87556.
I clicked to edit a section of a long article, and when I tried to file a bug, it looked like the screen just went dark - I couldn't immediately see a dialog box. It turned out to be because the feedback dialog was overlayed above the section I was editing, which was way, way down the page, and the browser didn't scroll to that part of the page when I pressed the button.

--------------------------
**Version**: unspecified
**Severity**: minor
Ahm, I'm sorry (obviously requires VE to be enabled to see those section heading links).
Tried on http://en.wikipedia.beta.wmflabs.org/w/index.php?title=Arrr0.5320366523148922&veaction=edit&vesection=2 but still the "Submit feedback" dialog is centered. 
Still cannot reproduce with Chrome 41 or Firefox 36.
@Greenrd: Sorry that this task has not received feedback earlier, and thank you for reporting this!

> I clicked to edit a section of a long article

Where did you click exactly? Link to that long article is also very welcome. :)

> and when I tried to file a bug, it looked like the screen just went dark - I couldn't immediately see a dialog box. It turned out to be because the feedback dialog was overlayed above the section I was editing

Does this refer to the "Leave Feedback / Submit Feedback" dialog available from the "Help" (question mark) button in VE's toolbar?

I cannot reproduce in Firefox 36 and Chrome 41 trying with https://en.wikipedia.org/wiki/Hamburg?veaction=edit - is this still a problem?
Setting task status to "Stalled" for the time being...
(In reply to comment #1)
> Which browser is this about?

Chromium Version 27.0.1453.93 Built from source for Fedora release 18
Thanks for taking the time to report this!

Which browser is this about?
1. Create a document with:
   Foo <cite>Alien</cite> Bar
2. Select all and bold

Results
3. 'Alien' is bolded, despite being protected (questionable)
4. The shield has disappeared.

--------------------------
**Version**: unspecified
**Severity**: normal
Both ve.dm.ModelRegistry.js and its test file have references to  /^mw:/ . Any code relating to mw should be in modules/ve-mw/

--------------------------
**Version**: unspecified
**Severity**: enhancement
Change 116487 merged by jenkins-bot:
Update VE core submodule to master (74be717)

https://gerrit.wikimedia.org/r/116487
Change 116485 merged by jenkins-bot:
Remove MW-specific config and genericise tests in ModelRegistry

https://gerrit.wikimedia.org/r/116485
Change 116487 had a related patch set uploaded by Esanders:
MW configuration for modelRegistry

https://gerrit.wikimedia.org/r/116487
Change 116485 had a related patch set uploaded by Esanders:
Remove MW-specific config and genericise tests in ModelRegistry

https://gerrit.wikimedia.org/r/116485
We currently use { target: {}, params: {} } for single-transclusion content, and {parts: [{template:{target: {}, params: {}, i: 0}}]} for multi-part transclusions and extensions. This creates special cases and makes it necessary to know all keys to convert the single-transclusion format into the parts bit.

The missing namespacing also makes it harder than necessary to add additional information to data-mw.

To clean this up, we should consider moving to always using an array format like this:

parts: [{"@type":"mw:Transclusion", target: {}, params: {}}]

The change to always use an array is already supported by VisualEditor. Flattening the nested object and using a JSON-LDish @type key makes the parts structure more regular and easier to extend. It also moves it closer to the RDFa names. Both us and VE can support both formats as an input for a while to avoid caching issues, but should start by only emitting the new format.

See also:
http://json-ld.org/playground/index.html -- some example JSON-LD

--------------------------
**Version**: unspecified
**Severity**: normal
The other changes in this ticket will require co-ordination with VE since it will break existing code.

This will also require the cached HTML versioning to be implemented to prevent weird editing errors between when parsoid is deployed and varnish caches or cleared.  Alternatively, VE and Parsoid serializer would have to handle old and new formats of data-mw temporarily.
Change 81143 merged by jenkins-bot:
(Bug 53135) Step 1: Always use parts array for transclusion data-mw

https://gerrit.wikimedia.org/r/81143
Change 81143 had a related patch set uploaded by Subramanya Sastry:
(Bug 53135) Step 1: Always use parts array for transclusion data-mw

https://gerrit.wikimedia.org/r/81143
**Author:** `p.selitskas`

**Description:**
Please create an icon with bold cyrillic "Т" for [be] and [be-tarask].

In Belarusian locales ([be] and [be-tarask]), the Bold icon is now read as "Тл" which may be interpreted as "Тлусты" (fat), but in fact it makes the selected text not fat, but bold ("Тоўсты"). :)

--------------------------
**Version**: unspecified
**Severity**: normal
This should now be fixed in production; sorry for the delay.
Change 84361 merged by jenkins-bot:
Fix merge conflict breaking localised bold/italic icons

https://gerrit.wikimedia.org/r/84361
Change 84361 had a related patch set uploaded by Reedy:
Fix merge conflict breaking localised bold/italic icons

https://gerrit.wikimedia.org/r/84361
Change 84095 merged by jenkins-bot:
Fix merge conflict breaking localised bold/italic icons

https://gerrit.wikimedia.org/r/84095
Change 84095 had a related patch set uploaded by Catrope:
Fix merge conflict breaking localised bold/italic icons

https://gerrit.wikimedia.org/r/84095
You're welcome. It does.
**p.selitskas** wrote:

(In reply to comment #17)
> Argh, sorry about this mess; we'll back-port the fix.

Thanks for swift resolving! Does it mean the 'fix fix' will be deployed soon out of general deployment schedule?
Argh, sorry about this mess; we'll back-port the fix.
Change 84027 merged by jenkins-bot:
Fix merge conflict breaking localised bold/italic icons

https://gerrit.wikimedia.org/r/84027
Change 84027 had a related patch set uploaded by Esanders:
Fix merge conflict breaking localised bold/italic icons

https://gerrit.wikimedia.org/r/84027
This is the offending commit: https://gerrit.wikimedia.org/r/#/c/81522/
**p.selitskas** wrote:

(In reply to comment #12)
> Looks like Trevor's toolbar rewrite didn't merge cleanly with my commits and
> they were partially undone.

Obviously. I was not aware of the rewrite and first thought that the patch was merged but hasn't appeared in the codebase (black magic).
Looks like Trevor's toolbar rewrite didn't merge cleanly with my commits and they were partially undone.
**p.selitskas** wrote:

(In reply to comment #10)
> (In reply to comment #9)
> > te-el shouldn't exist as it was replaced with just te, so maybe this is a
> > caching issue?
> 
> https://bits.wikimedia.org/static-1.22wmf16/extensions/VisualEditor/modules/
> ve/ui/styles/images/icons/bold-cyrl-te-el.svg
> 
> 404 (PNG as well). And I'm not counting the absent CSS class that should
> display this icon. Did the deployment come smoothly? :)

Oh, I'm sorry, I checked the wrong file. Anyway, JS adds the wrong class.
**p.selitskas** wrote:

(In reply to comment #9)
> te-el shouldn't exist as it was replaced with just te, so maybe this is a
> caching issue?

https://bits.wikimedia.org/static-1.22wmf16/extensions/VisualEditor/modules/ve/ui/styles/images/icons/bold-cyrl-te-el.svg

404 (PNG as well). And I'm not counting the absent CSS class that should display this icon. Did the deployment come smoothly? :)
te-el shouldn't exist as it was replaced with just te, so maybe this is a caching issue?
**p.selitskas** wrote:

Class .ve-ui-icon-bold-cyrl-te-el was not created/generated, and now there is empty space instead of a "Bold" icon. Reopening the bug.
Now merged and will go out in about an hour.
Also related: https://gerrit.wikimedia.org/r/80126
The be-tarask icons are now changed (and this version of the software will go out in a few hours' time); keeping the bug open for making it work with both be and be-tarask, as part of a general fall-back mode.
Change 80049 merged by jenkins-bot:
Change be-tarask to use Te instead of Te-El for bold

https://gerrit.wikimedia.org/r/80049
**p.selitskas** wrote:

(In reply to comment #1)
> We don't currently support [be], just [be-tarask]. Can you confirm that we
> should use the same icons for [be] (bold: T, italic: K)?

Yes, I confirm this suggestion.
Change 80049 had a related patch set uploaded by Esanders:
Change be-tarask to use Te instead of Te-El for bold

https://gerrit.wikimedia.org/r/80049
We don't currently support [be], just [be-tarask]. Can you confirm that we should use the same icons for [be] (bold: T, italic: K)?
>>! In T55093#572665, @GWicke wrote:
> The issue does not seem to be specific to any particular page. At https://en.wikipedia.org/wiki/OpenOffice.org?veaction=edit for example an initial
> load of 215k turns into a 3.6mb POST.
> 
> Possible remedies:
> * use gzip compression for the POST request body
> * use multipart/form-data POST encoding instead of application/x-ww-form-urlencoded to avoid percent encoding overhead
> * send HTML as a separate POST variable without JSON wrapper to avoid JSON escaping, in particular of quotes

Where are you seeing this? VE already does all of these things, which I just confirmed at https://en.wikipedia.org/wiki/OpenOffice.org?veaction=edit in Chrome. The POST that occurs when the (first) save button is pressed has a `multipart/form-data` POST body with gzipped content (the value of the `html` parameter starts with `rawdeflate,7H1rd9tGkuj3+RW9`). The POST that occurs when the second save button is pressed only sends a `cachekey` value, no large blob of HTML.

You should not have been able to trigger a multi-megabyte POST upload. Perhaps you observed a cachekey miss and there's a bug where the POST body is not compressed in that case?
>>! In T55093#572665, @GWicke wrote:
> Some additional info about the POST size issue on save:
> 
> To check the POST request size, I looked at the Content-Size header in the request headers once that completed (request to api.php started when opening the save dialog).
> 
> The issue does not seem to be specific to any particular page. At https://en.wikipedia.org/wiki/OpenOffice.org?veaction=edit for example an initial
> load of 215k turns into a 3.6mb POST.

You're saying that the page downloads gzipped at a weight of 215k and then when the browser goes to re-upload it has a weight of 3.6mb uncompressed? That sounds pretty bad to me.
Strike the last point about JSON- the HTML is already sent as a plain query parameter without JSON wrapper.
Some additional info about the POST size issue on save:

To check the POST request size, I looked at the Content-Size header in the request headers once that completed (request to api.php started when opening the save dialog).

The issue does not seem to be specific to any particular page. At https://en.wikipedia.org/wiki/OpenOffice.org?veaction=edit for example an initial
load of 215k turns into a 3.6mb POST.

Possible remedies:
* use gzip compression for the POST request body
* use multipart/form-data POST encoding instead of application/x-ww-form-urlencoded to avoid percent encoding overhead
* send HTML as a separate POST variable without JSON wrapper to avoid JSON escaping, in particular of quotes
At
https://en.wikipedia.org/wiki/List_of_Criterion_Collection_DVD_and_Blu-ray_releases?veaction=edit,
I am seeing a 5.6mb upload on preview. This takes 47 seconds to transfer
using my DSL connection. Connections with slower upload speeds would do
worse, and possibly time out. The POST processing and response then
takes 7.9 seconds according to the Chromium network console.

For comparison, the HTML downloaded on VE open is 238kb in size and
takes 3 seconds to load. Total load time until VE is ready is around 36
seconds, again using Chromium.

In my experience Firefox's client-side processing would be a bit slower.
A user is reporting this problem at
https://en.wikipedia.org/w/index.php?title=Wikipedia:VisualEditor/Feedback&oldid=588582743#Reliable_but_not_powerful
Ok, so comment #3 should read that in one occasion,
David got the message, the edit was not saved.
Editing the same article, I didn't get the message, and my edit was saved.
In other cases, it is possible to get the message and having the edit saved.
I got "Error: unknown error", but the error saved anyway, on this edit: https://en.wikipedia.org/w/index.php?title=OpenOffice.org&curid=68227&diff=574513723&oldid=574510970 - first time I've ever had the error and it did in fact save.

I'm now wondering if having the error and the edit not being saved is the same bug as having the error and the edit being saved.
A fr.wp user reports he was confused when he got this message, since the edit was saved anyway.
David Gerard and I had different experiences about this bug.
He tried to edit https://en.wikipedia.org/wiki/Neuro-linguistic_programming , while I basically copy/pasted that article in my sandbox https://en.wikipedia.org/w/index.php?title=User:Elitre_(WMF)/Sandbox&oldid=573778358 and then attempted to change it.
After 100 secs or so, VE managed to save our edits, but he got the error message, while I didn't. HTH.
Here http://en.wikipedia.org/w/index.php?title=Fairfield%2C_Iowa&diff=569923054&oldid=569069756 is another case of the error message being thrown after an actually successful edit.
The user wonders: " it would be useful to know the current confidence limits around page length and the ability to edit same. Is it dependent upon local environment (i.e. PC configuration and memory allocated to browser)? Or is there a server side known performance limit?".
Thanks.
(User specs, Vista - FF23 - Vector.)
Screenshot

Blocked IP addresses can see the VisualEditor, use it, and are presented with the error in the screenshot when saving.

Reporting distinctly from bug 52004 because the error message and use case are both somewhat different.

--------------------------
**Version**: unspecified
**Severity**: normal
**See Also**:
https://bugzilla.wikimedia.org/show_bug.cgi?id=52004

**Attached**: {F11450}
As with the normal local block bug, I'm going to mark this as fixed. We don't block the user from using VE, but there is now a notice warning them when they open VE.

It would be difficult to get all the useful info into some smaller alert() message or similar. Though after thinking about it a bit more we could perhaps use a small VE dialog or something, I am open to suggestions of course - but perhaps that would be better to put in a more general "not able to edit page due to protection/block/etc. dialog error" as this patch simply brings global blocks into line with normal blocks, protection etc.
Change 127840 merged by jenkins-bot:
Show notice if user is globally blocked

https://gerrit.wikimedia.org/r/127840
That error message that you do get on saving is also a bug of it's own, patched in Gerrit change 127835
Change 127840 had a related patch set uploaded by Alex Monk:
Show notice if user is globally blocked

https://gerrit.wikimedia.org/r/127840
The thermometer is important, as it explains why a radically modified document would give me an empty "review changes" box.

Separate bugs: the thermometer never stops spinning, and my changes for review never appear--maybe Parsoid is gagging.  And, is that UI javascript running without a setTimeout?

--------------------------
**Version**: unspecified
**Severity**: minor
We can't reproduce this now, so closing as WORKSFORME.
I don't see a thermometer. :|
Sorry.

* Edit a page, making changes
* Click "Save page".  Save dialog pops down, and thermometer is spinning.
* Click "Review changes" before the thermometer stops.
The save dialog collapses down to a single line, which contains only the "Review changes" button, a left arrow button, and an up button.  This is strange.  The thermometer is gone.  There is no explanation of why i am presented with this damaged dialog.

Apparently, with my broken VE, the loading/render/whatever the thermometer represents never finishes.  Which made it very easy to reproduce this other bug.
Trying to parse this. Is this:

1. 'VisualEditor: Clicking "Review changes" mid-save causes the save dialog to disappear, which takes the save progress animation thermometer'

… or

2. 'VisualEditor: Clicking "Review changes" mid-save causes the save dialog to collapse but stay present, and also the save progress animation thermometer stays but stops animating'

… or something else?
How does a thermometer spin?
**Author:** `jamesjoshualim`

**Description:**
Hi, everyone.  Yesterday, we had a meetup here in Manila, and I discussed with two Tagalog Wikipedia editors (including a fellow bureaucrat) about the creation of a new interface language for Tagalog in a bid to resolve long-standing differences over how the interface should be translated.  We agreed on a compromise solution, where we would accommodate Taglish (code-switched Tagalog and English) as a new interface language called "Tagalog (informal)" for the Tagalog-language projects, similar to how there is an interface language for formal German (de-formal).

We decided that this new interface language will become the default interface language for all anonymous and new users on the Tagalog Wikipedia, in order to attract new editors who may be confused by the formal language used for the current Tagalog interface.  The current interface will be opt-in for those who want to use the interface as it currently is, and users will have the ability to select their preferred language using the Universal Language Selector which will only have Tagalog, Tagalog (informal) and English as the options.  All other languages may still be selected through the preferences.

If this is possible to do, I'd love to see this come to fruition, and I hope to hear from all of you soon.  Thanks! :)

--------------------------
**Version**: 1.22.0
**Severity**: enhancement
Or even better: https://www.mediawiki.org/wiki/Internationalisation_wishlist_2017#Better_support_for_formal_and_informal_variants

This assumes that it is only wanted for interface, and that differences are not that big.
Because language converter would need to cater to exceptions, the better way to do this is probably just open up a language and then only translate those that are different and then let the other terms fallback to Tagalog just like how zh_HK<>zh-Hant have been handled.

That is provided that if a consensus are to be reached.
It might be possible to implement informal variants using LanguageConverter; see T33015#3183625
This likely should be discussed *within* the community in order to reach consensus and support, however http://tl.wikipedia.org/wiki/WP:KAPE seems pretty inactive. Is there a better place?
**jojit_fb** wrote:

One more thing, why is it the localization project of the Mozilla Tagalog interface has no problems with retaining the technical terms untranslatable?  We can follow their example.
**jamesjoshualim** wrote:

(In reply to Joseph Ballesteros from comment #3)
> As a veteran editor in the Tagalog Wikipedia, I disagree with this.  I think
> it's redundant and I am for only one interface language for Tagalog.  I
> suggest that this should be discussed first with more editors.

It is not redundant when language issues are as divisive as they are on the Tagalog Wikipedia.  Short of forcing everyone to abide by one standard (which will not happen, given persistent conflicts between purists, moderates and progressives/universalists) or creating two different Wikipedias for Tagalog and Filipino, this is the best solution that can be conceived.

(Also, I posted a discussion on this on both the Tagalog Wikipedia Facebook group and the Kapihan months ago.)
**jojit_fb** wrote:

As a veteran editor in the Tagalog Wikipedia, I disagree with this.  I think it's redundant and I am for only one interface language for Tagalog.  I suggest that this should be discussed first with more editors.
**jamesjoshualim** wrote:

(In reply to comment #1)
> Is this asking for:
> 
> 1) Creating a new interface language, tl-informal, in TranslateWiki.net
> 2) Creating a new interface language, tl-informal, in MW core
> 3) Creating a new interface language, tl-informal, in production

Just these first three.  For now, we're very undecided on pursuing the fourth option, as we have not yet agreed on having Taglish content on the Tagalog Wikipedia.  For now, we only agreed on having a new interface language, and we will get to the issue of content languages when we get there.
Is this asking for:

1) Creating a new interface language, tl-informal, in TranslateWiki.net
2) Creating a new interface language, tl-informal, in MW core
3) Creating a new interface language, tl-informal, in production
4) Creating a new content language in MW core, adding to tlwiki as a variant
5) Creating a new content language in MW core, adding to a new wiki (tl-inf-wiki)?

I think this is 1, 2, 3 and 4 but not 5.

Note that adding variants to a wiki is do-able but makes for a sucky experience in both editing and creating wikitext, and means that tlwiki wouldn't be possible as a release target for VisualEditor for at least some time whilst we wait for building out support in VisualEditor and Parsoid.
**Author:** `swalling`

**Description:**
Hidden VE postedit confirmation

If you edit successfully via wikitext, we delay loading the GettingStarted toolbar until after the post-edit confirmation disappears. We should do the same for the new style of postedit confirmation from VE.

--------------------------
**Version**: unspecified
**Severity**: normal

**Attached**: {F11351}
Change 112880 merged by jenkins-bot:
Delay showing the task toolbar after VisualEditor edit

https://gerrit.wikimedia.org/r/112880
Thanks, James.  The change on our side is https://gerrit.wikimedia.org/r/112880.
The VE patch here has been merged and will be deployed in the train tomorrow (in wmf14); not sure if this achieves the fix desired, so just setting to "NEW" instead.
Change 112880 had a related patch set uploaded by Phuedx:
Delay showing the task toolbar after Visual Editor edit

https://gerrit.wikimedia.org/r/112880
Change 112879 had a related patch set uploaded by Phuedx:
Include edit status in the ve.deactivationComplete event

https://gerrit.wikimedia.org/r/112879
Currently we always serialize to wikitext and re-parse that to HTML, which runs the sanitizer on the token stream to ensure that our final HTML does not cause bad things to happen.

Soon both us and the Flow team want to store HTML from the VisualEditor directly without first serializing to wikitext. This means that we need to perform the sanitization on the HTML instead of the token stream. For performance, sanitizing on the way in would be preferable. We should however support re-sanitization when new issues were discovered. This could potentially be coupled with the versioning discussed in bug 52937. A new sanitizer could bump the version number, and the upgrade path would then run the new sanitizer on old HTML (and probably update the storage with the newly sanitized version).

--------------------------
**Version**: unspecified
**Severity**: normal
Note that tokens are equivalent to SAX events. This suggests the following option for hooking up the current sanitizer to process a DOM:

- Traverse the input DOM, emit SAX events
- feed SAX events through the sanitizer
- feed the resulting tokens / SAX events back to a HTML / XML DOM tree builder
**Author:** `swalling`

**Description:**
Screenshot at 1024x768

Very happy to see that VE is now using the same post-edit styling as wikitext! This is a big win for usability, since it is fixed position and so on.

I did find one suboptimal fact though... Since the text of the message includes the page title, it is very variable width, depending on the page title length and the browser width. 

One of the UX goals for this notification is to have new users notice it, but for it to eventually fade out of your attention as you become used to it. Since the page title produces very different widths as you edit different pages, this calls a lot more attention to the notification even if you've edit thousands of times. 

My recommendation would be to match what's in the wikitext version, "Your edit was saved." since we A/B tested it and we know it meets the goals I mentioned above. Another good solution is simply removing the page title, so that the VE version says, "Your changes have been saved." That seems functionally the same, though I think using edit is good for consistency with the tab names etc.

--------------------------
**Version**: unspecified
**Severity**: minor

**Attached**: {F11185}
Change 130968 merged by jenkins-bot:
Switch to use MediaWiki's built-in messages for post-edit notifications

https://gerrit.wikimedia.org/r/130968
Change 130968 had a related patch set uploaded by Alex Monk:
Switch to use MediaWiki's built-in messages for post-edit notifications

https://gerrit.wikimedia.org/r/130968
Change 127480 merged by jenkins-bot:
Expand core post edit functionality to match VE

https://gerrit.wikimedia.org/r/127480
Now just needs VE to use the same function.
Change 127480 had a related patch set uploaded by Alex Monk:
Expand core post edit functionality to match VE

https://gerrit.wikimedia.org/r/127480
Current VE messages:

    "visualeditor-notification-created": "\"$1\" has been created.",
    "visualeditor-notification-restored": "\"$1\" has been restored.",
    "visualeditor-notification-saved": "Your changes to \"$1\" have been saved.",

Current MW core message:

    'postedit-confirmation'            => 'Your edit was saved.',

We should:

1. Expand MW core to cater to all three states (create, restore, save):

** Create: "The page has been created."
** Restore: "The page has been restored."
** Saved: "Your edit was saved."

2. Not use different messages in VE – instead, use the core ones.

Rather than create two bugs, let's just use this one?
The <references /> section is empty in edit mode, see URL.

Other examples:

https://de.wikipedia.org/wiki/Joachim_Wiesner

--------------------------
**Version**: unspecified
**Severity**: normal
**URL**: https://de.wikipedia.org/wiki/Bahnhof_K%C3%B6ln_Eifeltor
Yeah, was already fixed. Great!
Hi Raimond,
in both articles I can correctly see the contents of the Einzelnachweise sections.
(Maybe this is a duplicate and the bug was already fixed?)
https://www.mediawiki.org/wiki/Special:Preferences#mw-prefsection-searchoptions

The "Advanced options" section of the "Search" tab in MediaWiki currently looks like this:

---
Advanced options

[ ] Search in all namespaces

Search in these namespaces by default:
[ ] (Main)
[ ] Talk
[ ] User
[ ] User talk
[ ] Project
[ ] Project talk
[ ] File
[ ] File talk
[ ] MediaWiki
[ ] MediaWiki talk
[ ] Template
[ ] Template talk
[ ] Help
[ ] Help talk
[ ] Category
[ ] Category talk
[ ] Thread
[ ] Thread talk
[ ] Summary
[ ] Summary talk
[ ] Manual
[ ] Manual talk
[ ] Extension
[ ] Extension talk
[ ] API
[ ] API talk
[ ] Skin
[ ] Skin talk
[ ] Module
[ ] Module talk
[ ] Translations
[ ] Translations talk
[ ] VisualEditor
[ ] VisualEditor talk
---

This list looks silly and excessive. While {T39878} has requested a layout change, I think we need to reconsider how this list is implemented.

What about adding a checkbox to [[Special:Search]]'s advanced search section that looks something like this:

[ ] Use these namespaces as my default

This would de-duplicate the namespace listing (between Special:Preferences and Special:Search) and would allow the search user preference to be set more easily from the search interface itself.

Rather than using Special:Preferences and having heavy user interface exposure, any custom search namespace preferences could be "hidden" user preferences. That is, they'll still be stored if they don't match the site-wide default, but they'll not clutter up Special:Preferences.

--------------------------
**See Also**:
{T50615}
Change 250271 merged by jenkins-bot:
Remove search preferences from Special:Preferences JavaScript

[[https://gerrit.wikimedia.org/r/250271]]
Change 250271 had a related patch set uploaded (by saper):
Remove search preferences from Special:Preferences JavaScript

[[https://gerrit.wikimedia.org/r/250271]]
Not really. As far as I understand the current search options are handled perfectly by the  [[http://git.wikimedia.org/blob/mediawiki%2Fcore.git/0158312d4bc3de9c15064a12a73b4bf57580e45e/resources%2Fsrc%2Fmediawiki.special%2Fmediawiki.special.search.js|mediawiki.special.search.js]] ResourceLoader module, while I intend to remove this from [[http://git.wikimedia.org/blob/mediawiki%2Fcore.git/0158312d4bc3de9c15064a12a73b4bf57580e45e/resources%2Fsrc%2Fmediawiki.special%2Fmediawiki.special.preferences.js#L284|mediawiki.special.preferences.js]] in https://gerrit.wikimedia.org/r/#/c/247728/. Probably this is just a leftover from this change.
> I have found that we still have JavaScript code attaching to #mw-htmlform-advancedsearchoptions and #mw-input-wpsearcheverything. I understand this can be safely removed?

Do you mean the All | None buttons inserted via JavaScript?
One question:

In https://gerrit.wikimedia.org/r/#/c/247728 I have found that we still have JavaScript code attaching to 
`#mw-htmlform-advancedsearchoptions` and `#mw-input-wpsearcheverything`. I understand this can be safely removed?
(In reply to Isarra from comment #27)
> May also want a separate page of 'all settings' or 'advanced settings' for a
> lot of them (it could also appear collapsed or something by default - the
> point is while this is often not the stuff folks will necessarily be after,
> it should be there somewhere in case they are), sort of like the extra
> 'config' heap you see in firefox and whatnot, but hopefully somewhat easier
> to find and use.

Is there an open bug report about this? I wouldn't oppose a gated (behind a checkbox, perhaps) advanced user preferences tab. Safari does this as well, I believe, with a preferences checkbox that enables a "Developer" drop-down menu. Similar-ish idea.
Created attachment 15597
Advanced search tab in mediawiki.org as of  	1.24wmf8

**Attached**: {F11964}
(In reply to billinghurst from comment #52)
> My complaint has "never" been about any checkbox, but the removal of
> Preferences.

Are you able to offer another tab of Special:Preferences and other 35 checkboxes (in the case of en.wiki) to sacrifice instead?
Preferences have been in a process of cutting for some time now and there are some rather extreme proposals around where your time would perhaps be better spent: https://www.mediawiki.org/wiki/Requests_for_comment/Redesign_user_preferences

The path I'm following is the one of least resistance for the biggest result, you'll see that I'm reducing your future pain. :)
My complaint has "never" been about any checkbox, but the removal of Preferences.
So much drama about a single checkbox… get me out of here.
(In reply to billinghurst from comment #48)

This bug is technically fixed: Advanced options preferences are now handled on Special:Search itself, which is the topic of this bug, so please stop reopening it. Also, a "resolved" status doesn't prevent you from commenting. If you detect flaws on the implementation, feel free to open a *new* bug describing the problems of this implementation (see [1]).

I'd suggest you to raise your concerns in a mailing list (mediawiki-l seems to be the the best one for your concerns) [2]. Your message will be received by more people that can share their point of view about this, while your messages on this bug report are being received by the same developers that were involved in it. Feel free to put here a link to the discussion on the mailing list if you decide to start a discussion there.

----

[1] https://www.mediawiki.org/wiki/How_to_report_a_bug
[2] https://www.mediawiki.org/wiki/Mailing_lists
I am sorry, that is a typical dismissive response, and pretty unhelpful.  I don't see the issues raised addresses by the bugzilla.

BTW no one made you the decision maker, and as it is your code I would think a little less CoI, and some more communication would be preferable.
(In reply to Quiddity from comment #40)
> I think the problem with the new version, is the physical distance, or
> dis-connection, of the checkbox from the search button... 

Split to bug 66342.

(In reply to billinghurst from comment #46)
> I am wondering whether the proponents of the change have had the ability to
> review suggestions

Yes.
I am wondering whether the proponents of the change have had the ability to review suggestions made by people who are not in favour of the holistic change and may be able to suggest a compromise position.

I have reopened this bug as I do not think that it should be considered fixed in light of this extra opinion.
**wmf.amgine3691** wrote:

(In reply to MZMcBride from comment #43)

> My gut feeling is that the real, underlying issue here is that you, me, and
> others want global (wikifarm-wide) user preferences. 

Speaking only for myself, I usually modify my search based on my involvement with the specific wiki. My search on a project I'm involved with and editing regularly usually needs the project and often the user namespaces. Ones I'm only occasionally editing need help and project namespaces. The defaults work fine on projects where I'm only a reader. It is a workflow issue.
**wmf.amgine3691** wrote:

> It was 50/50 that you were going to say that. The other option was "if it ain't > broke don't fix it". Both are useless clichés. 

Mmm, actually the third option was "change for the sake of change". They are clichés because they are common, valid issues. And you have not addressed the substance of the comment.

I would suggest your response - highly defensive and dismissive - is itself a cliché of "Dev knows best", except I also know the reason it's a cliché is because it's often true. I'm with Quiddity, Isarra, and sDrewth: let's figure out a both-and solution, because it does not need to be either-or.
(In reply to Quiddity from bug 52817 comment #40)
> Searching for help documentation is HELL unless we add the Wikipedia: ,
> Help: , and Template: namespaces to our default search. For the first few
> years as a new editor, I was constantly searching those namespaces for tools
> and guides. (Note that the Template: and Category: namespaces aren't
> included in the "Help and Project pages" output)

I guess this is an answer to:

(In reply to MZMcBride from bug 52817 comment #35)
> If many users are customizing their search settings, we're doing something
> wrong.

Split to bug 66066.
(In reply to Quiddity from comment #40)
> I'm surprised that we don't already have a link to
> [[Special:Preferences#mw-prefsection-searchoptions]] anywhere at
> [[Special:Search]] (advanced tab or otherwise)! How did we miss that, for so
> long?!  Forest, trees.

That's a very good point, and I've just made it happen on en.wp.
(In reply to Amgine from comment #36)
> This sounds so much like a solution looking for a problem.

It was 50/50 that you were going to say that. The other option was "if it ain't broke don't fix it". Both are useless clichés. 

Your comments are dripping with "me, me, me" privilege-based assumptions. Luckily, MediaWiki development is not based around avoiding advanced users having to have the minor inconvenience of learning a small interface change.
(In reply to billinghurst from comment #37)
> my
> issue is that Preferences = Preferences

Too bad this assumption is incorrect. We have plenty of preferences which have never been controlled by Special:Preferences, look https://www.mediawiki.org/w/api.php?action=query&meta=userinfo&uiprop=options&format=jsonfm again.
Not to speak of all the preferences which are not even stored in the database, but instead on cookies or URL parameters (hence bookmarks at best).
(In reply to MZMcBride from comment #35)
> (In reply to Amgine from comment #21)
> > Sucks as UX. Do we really want every special page to be creating and
> > maintaining its own interface for user preferences?
> 
> We want sensible defaults and intuitive, easy-to-use interfaces. For most
> users, there shouldn't be a need to customize the default search settings.
> If many users are customizing their search settings, we're doing something
> wrong. For the few users who want to customize their search preferences,
> there's now a checkbox in the same place as search. This seems like a good
> thing to me.

Nobody has argued about sensible defaults, nor the ability for communities to be able to adjust and modify. I don't see how that introduction is relevant.
 
> Because there's now an additional checkbox that controls per-user search
> preferences, we can de-duplicate the listing at Special:Preferences, which
> makes for a cleaner user preferences interface (increased signal, decreased
> noise). This also seems like a good thing to me.

In fact if you follow that logic, we are now cluttering up a search page with an option that is going to be used rarely or not at all, and maybe by a small subset of people ...  Making visible an option that is probably used zero times by most user, and maybe once or two by a small number of users. That is perverse.

> Perhaps a pointer from Special:Preferences to Special:Search would be
> helpful, but I'm not sure it's needed and I'm not sure where it would
> appropriately go.

Or it could be '''at''' the search page that it says something the lines of "Save this criteria to be your default" and have a link to Special:Preferences.

I have no specific issue with an improvement or option at Special:Search, my issue is that Preferences = Preferences and I expect to be able to go there and to be able to set my preferences for search.
**wmf.amgine3691** wrote:

Would those 'few users' happen to be the experienced wikimedians (like those who have piped up here)? the ones who know (well, knew) where to modify their user preferences?

This sounds so much like a solution looking for a problem.
(In reply to Amgine from comment #21)
> Sucks as UX. Do we really want every special page to be creating and
> maintaining its own interface for user preferences?

We want sensible defaults and intuitive, easy-to-use interfaces. For most users, there shouldn't be a need to customize the default search settings. If many users are customizing their search settings, we're doing something wrong. For the few users who want to customize their search preferences, there's now a checkbox in the same place as search. This seems like a good thing to me.

Because there's now an additional checkbox that controls per-user search preferences, we can de-duplicate the listing at Special:Preferences, which makes for a cleaner user preferences interface (increased signal, decreased noise). This also seems like a good thing to me.

Perhaps a pointer from Special:Preferences to Special:Search would be helpful, but I'm not sure it's needed and I'm not sure where it would appropriately go.
**wmf.amgine3691** wrote:

Ah, but then how simple it is to alter the settings is also out of scope.

My opinion is the people most familiar with the software are those most likely to wish to modify their search preferences. For those users, their user preferences are the most-likely first place to look to alter their user preferences. That would meet most 'least surprise' requirements. Being able to alter the search prefs elsewhere, as Isarra says, would be very cool. Being unable to set the search prefs via the least surprising interface would, in my opinion, not be cool.
How well those features work is a valid question but it's out of scope for this discussion.
**wmf.amgine3691** wrote:

(In reply to Scott Martin from comment #31)
> (In reply to Scott Martin from comment #28)
> > To get to Special:Search you click the magnifying glass
> > icon in the search box.
> 
> Or search for nothing. Sorry for two posts in rapid succession, remembered
> that a moment too late. (And also had the thought that maybe the magnifying
> glass thing is a skin-specific feature.)

Cool! and of course you have evidence that people just do this, intuitively.
(In reply to Scott Martin from comment #28)
> To get to Special:Search you click the magnifying glass
> icon in the search box.

Or search for nothing. Sorry for two posts in rapid succession, remembered that a moment too late. (And also had the thought that maybe the magnifying glass thing is a skin-specific feature.)
(In reply to Nemo from comment #29)
> (In reply to Isarra from comment #27)
> > Ideally we'd have some way to automatically dump settings that appear in the
> > interface elsewhere into main preferences just by telling it 'OY LOOK A
> > SETTING'.
> 
> That's exactly what we did.
> 
> > 
> > May also want a separate page of 'all settings' or 'advanced settings'
> 
> We have it:
> https://www.mediawiki.org/w/api.
> php?action=query&meta=userinfo&uiprop=options&format=jsonfm

Oh, neat! Very nice.
(In reply to Isarra from comment #27)
> Ideally we'd have some way to automatically dump settings that appear in the
> interface elsewhere into main preferences just by telling it 'OY LOOK A
> SETTING'.

That's exactly what we did.

> 
> May also want a separate page of 'all settings' or 'advanced settings'

We have it: https://www.mediawiki.org/w/api.php?action=query&meta=userinfo&uiprop=options&format=jsonfm
(In reply to Amgine from comment #26)
> The suggested model is not as simple as Scott Martin describes it. 

Actually, it is. To get to Special:Search you click the magnifying glass icon in the search box.
Ideally we'd have some way to automatically dump settings that appear in the interface elsewhere into main preferences just by telling it 'OY LOOK A SETTING'.

May also want a separate page of 'all settings' or 'advanced settings' for a lot of them (it could also appear collapsed or something by default - the point is while this is often not the stuff folks will necessarily be after, it should be there somewhere in case they are), sort of like the extra 'config' heap you see in firefox and whatnot, but hopefully somewhat easier to find and use.
**wmf.amgine3691** wrote:

@Isarra

So you are saying "both-and", not "eliminate one"? This would probably result in duplication of code and maintenance (which is one of my arguments against moving the preferences in the first place.)

The suggested model is not as simple as Scott Martin describes it. Although setting the preference is top menu -> special: preferences -> tab, this is simpler than tools menu -> special:specialpages -> search -> settings because search is not readily found in the special:specialpages page. Yes, *if one has already done a search* you are already on the page, but if you have not, you aren't. I just attempted to land on search from the search box: foo, qux, and quux are redirs, foobar is an article, baz and asdf are disambigs, and foobaz gets me to search.
I guess there are two things here.

1: Users will primarily care about preferences affecting a specific page when on that specific page. They will be able to most effectively see the effects when on that page, too, so giving them the option to save what works when they're there, seeing that it works, is generally quite useful.

2: Users do tend to expect to find preferences in preferences. A common practice, especially for users who have used the software before but are on a new project, is to go through all of them and quickly configure things how they like them, or think they will. Alternately, if they want to go back and disable something after it behaves weirdly, or if another user tells them to change a setting, the preferences are a likely place to go for that.

Yes.
I don't understand how clicking into Special:Preferences and then a subpage to set options for Special:SomePage is substantially less complicated than going to Special:SomePage and setting them there the first time you use it. Given that most changes to search options will be made on the fly during search experiences, requiring users to leave the special page, go into preferences and then come back (or change preferences in a new tab then reload the search) is a degradation of the UX.

> Preferences are preferences, please keep them together not scattered around the wiki.

"The wiki" is a misunderstanding here. "Preferences" are operational modes for programs, and the special pages are a collection of small utility programs accompanying the core. There's no objective reason why their mode controls should be grouped together remotely with the core's. It's like having the windscreen wiper speed control as a switch on the engine instead of on the dashboard; old-school advanced users of that peculiarly-designed car may be fine with opening the hood to change it because "it's always been there", but that doesn't make doing it easy for everyone. A new car would seem particularly old-fashioned if it were still designed this way, and we should be trying to ensure that MediaWiki lives up to the interface design expectations of modern software.

> Please produce the evidence base for this change.

Pretty much every UX study ever that's shown that the further away you put a control from what it affects, the harder users find it to interact with, or even find in the first place - especially new users. It's the GUI-side version of [[Action at a distance (computer programming)]].

S (speaking only for myself, I'm not a MediaWiki developer)
Clutter is removing unnecessary items, redundant items, messy items; clutter is not (re)moving a useful and considered page. So since when is a preference page like Search preference considered clutter? It is clear and specific.  Preferences are preferences, please keep them together not scattered around the wiki.

My attitude is not about any other item, please don't presume.

When I am setting up my preferences for a wiki it is very easy to go into preferences and change the settings that I want. Now you are going to make someone go to the search page to do it, off via other links. That is not more helpful.

If the issue that we give (too) much choice to users, and they are confronted about tabs, then produce a simple and an advanced choice plan. Please produce the evidence base for this change.

To the "maybe I missed ...". Have you missed the meaning of the word "consultation" and maybe seeking a broader opinion? 

That it is considered that bugzilla is a suitable place for working out a social solution is less than ideal, and yet it happens repeatedly. That a few didn't think it is worthwhile consulting with the broader community about this is disappointing.
(In reply to billinghurst from comment #20)
> It is disappointing that a cabal effect has
> taken place to what is a significant change to how things are done around
> here.

I'm sorry you see it that way; I suspect your attitude about this bug is affected by an unrelated change which got merged and reverted in these days after a MediaWiki RfC with a very obscure title. This is nothing like that. 

Maybe you missed something: https://bugzilla.wikimedia.org/showdependencygraph.cgi?id=62559&display=tree&rankdir=LR
If you did it's not your fault, implementation details discussed in each bug (like this) are just that, details; but it's safe to state that since some time ago there is wide consensus, and a strong push, towards reducing the clutter in MediaWiki by reducing interface complexity in general and Special:Preferences options specifically.
**wmf.amgine3691** wrote:

Sucks as UX. Do we really want every special page to be creating and maintaining its own interface for user preferences?
Really? Preferences are preferences and have belonged in ... umm ... "Preferences". Shouldn't such a change have had a wider discussion than between eight and eleven people? Maybe it could have been trialled, and checked through the UI processes. Maybe have used the beta features for testing?

This seems a significant change that really could have had better rigour put to it for an implementation. It is disappointing that a cabal effect has taken place to what is a significant change to how things are done around here.
There's a very similar move of preferences to page proposed at Bug 48615, for Special:Watchlist. As this change has met approval, it would be great if that bug could see movement - not least because this change will now cause a preference location inconsistency, if you see what I mean.
(In reply to Bohdan from comment #16)
> Also why to do a small change on specific WMF wiki's config it's community
> must hold 1 weeks discussion but a change concerning to all MediaWiki wikis
> it being done with no discussion at all?

How is the long comment thread above, and the even longer review list on the change itself, "no discussion at all"? There was discussion, you just didn't participate.

Config changes are not handled by any of the people who were involved in this, except maybe occasionally. Ask the people who handle them about why they have their requirements.
(In reply to Bohdan from comment #15)
> Why on Earth I must run through lots of pages to set personal configuration

Lots? As far as I know Special:Preferences contains options for about 3 special pages. It's also less common for users to set preferences for Special:Search without ever having visited it: so the action of tweaking preferences will happen in a visit to Special:Search which would have happened anyway, and the total number of special pages visited should be lower (because it's not necessary to switch to Special:Preferences to save the search options you just selected).
Also why to do a small change on specific WMF wiki's config it's community must hold 1 weeks discussion but a change concerning to all MediaWiki wikis it being done with no discussion at all?
Why on Earth I must run through lots of pages to set personal configuration for myself on a wiki? I think the best is to keep both central place for changing config in preferences and page specific on appropriate pages.
Thanks for all the help, Chad and Bartosz.
Let's get bug 31881 fixed in 1.24. :)
Change 131727 merged by jenkins-bot:
Save advanced search namespace prefs on Special:Search itself

https://gerrit.wikimedia.org/r/131727
Well, exact colouring is debatable, however we still have to consider colour-blind and blind users. Thus I believe that colour-highlighting is not a good idea.
(In reply to Jesús Martínez Novo (Ciencia Al Poder) from comment #9)
and
(In reply to Nemo from comment #10)

Use Colored-highlights, and a Legend, for 
* These options are the site-defaults
* These options are your customized defaults
* These options are selected for just-this-search.

This will also solve the "what were the defaults? I (might) want to reset!" issue.

My ugly mockup/napkin-sketches, from an unrelated topic, just to inspire further thinking: 
https://i.imgur.com/IcEWCzF.png
https://i.imgur.com/tOJOsXG.png
The behaviour is similar to what happens with the login checkbox, I can't imagine it being so confusing. Only few users very used to the wiki will set their preferred namespaces before their first search.

We can grey out the checkbox when the selection wasn't changed, but that can be done on a separate patch IMHO; a visual confirmation is provided by the checkboxes themselves, which are preserved the next time.
The idea is good. Now that I see the implementation, it implies you have to perform the search *after* marking that checkbox for it to be saved in your preferences.

Don't get me wrong, I'd also think that you have to mark the checkbox before performing the search, but people not so familiar with web forms may find it not too obvious.

A possible solution to this that I'm thinking of: add a button that on click would change the preferences using an AJAX call, with a visual feedback of the settings being saved.

Also, a checkbox may look weird if you mark it, and after performing the search it remains unchecked (did I checked it when performing the search? or was it totally ignored?).
Created attachment 15314
Current appearance of the feature

Screenshot of the feature as currently coded. It's just one more checkbox next to a few dozens: the HTML needs to be improved a bit but it's really straightforward from an interface perspective.

//attachment Bug52817.png ignored as obsolete//
Change 131727 had a related patch set uploaded by Nemo bis:
[WIP] Save advanced search namespace prefs on Special:Search itself

https://gerrit.wikimedia.org/r/131727
You'll want to use 'type' => 'api' (which is, admittedly, somewhat misleadingly named). One core preference using this is 'watchlisttoken'.
[[mw:Manual:Preferences]] and [[mw:Manual:Hooks/GetPreferences]] are not particularly helpful. To hide preferences from Special:Preferences, should they be made of "hidden" type? Added to $saveBlacklist? Spinned off from Preferences.php completely?
Are we still collecting (re)thoughts or is this bug focused on a specific change? Seems the latter, changing subject.
*** Bug 37878 has been marked as a duplicate of this bug. ***
(In reply to comment #1)
> I really really like this idea.

Should we set this ticket as for something we'd like to have in the next release (1.22) then?
I really really like this idea.
The "Enable section editing via [edit] links" user preference should be removed from MediaWiki core.

Users interested in hiding section-edit links can use per-user (or site-wide) CSS.

This should be an easy bug to resolve; marking it with the Bugzilla keyword
accordingly.

--------------------------
**Version**: 1.22.0
**Severity**: enhancement
**troyengel** wrote:

Got it -- I had to add !important, so this works:

  .mw-editsection { display:none!important; }

I'll get the wiki page updated with the new method, thanks!
(In reply to TE from comment #16)
> Can one of y'all please post exactly what needs to go where to disable
> site-wide this feature for anonymous, new and previous (logged in) users so
> that this change removing the feature can be put back into CSS?

You can try adding the following code to the page "MediaWiki:Common.css" on your wiki (untested, but should work...):

.mw-editsection { display: none; }
**troyengel** wrote:

I'm not a MediaWiki guru to be able to figure this out, but with the 1.23 release I can't figure out how to disable this again. It's referenced above:

"Users interested in hiding section-edit links can use per-user (or site-wide) CSS."

Great, but can someone update documentation on exactly *how* to do this? In my LocalSettings.php I have the old setting which is apparently ignored now:

  $wgDefaultUserOptions ['editsection'] = false;

I've dumped the DB and grepped and find only one reference to 'noeditsection' in the data, and my user account still shows the [Edit] on sections. The wiki indicates nothing about this change yet:

  http://www.mediawiki.org/wiki/Manual:$wgDefaultUserOptions

Can one of y'all please post exactly what needs to go where to disable site-wide this feature for anonymous, new and previous (logged in) users so that this change removing the feature can be put back into CSS?

I'd be happy to update the above wiki page if someone just tells me *how* to go about it as a low-speed wiki operator who doesn't live & breathe this code. Thanks!
(In reply to Danny B. from comment #14)
> Described in the last line of comment #11.

The last line of comment 11 is:
> And gadgets are what? Saved in preferences. Hence we are where we were.

Sure, but most users and most wikis don't want or need an extra user preference for this. These links are automatically shown based on user permission and they're able to be hidden on a site-wide basis, on a per-page basis, and on a per-user basis. I don't see a need for a user preference here. What's the use-case, exactly? Why would a user want to hide these links for only their account?

Regarding gadgets specifically, a few wikis might create such a gadget, but I doubt it. The overall MediaWiki experience (including that of most Wikimedia wikis) will have less clutter. This seems like a win to me.

>> Out of curiosity, has this happened anywhere?
> 
> Yes.

Where? Links welcome. :-)
(In reply to MZMcBride from comment #13)
> (In reply to Danny B. from comment #11)
> > This is nonsense. It should not have been removed.
> 
> Why's that?

Described in the last line of comment #11.

> > So there will be gadget created on sites to enable hiding.
> 
> Out of curiosity, has this happened anywhere?

Yes.
(In reply to Danny B. from comment #11)
> This is nonsense. It should not have been removed.

Why's that?

> So there will be gadget created on sites to enable hiding.

Out of curiosity, has this happened anywhere?
See comment 0 and comment 5 for reasoning, plus this request ("Remove ... user preference") is obviously FIXED as the code commit has been merged. :)

I don't think this specific bug report is the place for a generic "I want less popular ancient options to be removed from the user preferences to reduce UI clutter" vs. "I want less people to have to edit their custom CSS or write Gadgets to do X" discussion - should maybe happen on mediawiki-l instead if there is interest.

However I agree that statistics on how many users have enabled such a setting might be helpful for future evaluation when killing some preferences.
This is nonsense. It should not have been removed.

comment #0 says: "Users interested in hiding section-edit links can use per-user (or site-wide) CSS."

Exactly.

So there will be gadget created on sites to enable hiding. (because Jorm is totally true with 'Can we just agree from this day forward that "put it in your user css" is not an acceptable solution for any problem, ever?'

And gadgets are what? Saved in preferences. Hence we are where we were.
Change 99171 merged by jenkins-bot:
Removed "Enable section editing via [edit] links" from preferences

https://gerrit.wikimedia.org/r/99171
Change 108673 abandoned by 01tonythomas:
Removed "Enable section editing via [edit] links" from preferences

Reason:
Abandoned: Original patchset at :
https://gerrit.wikimedia.org/r/#/c/99171/

https://gerrit.wikimedia.org/r/108673
Change 99171 restored by 01tonythomas:
Removed "Enable section editing via [edit] links" from preferences

Reason:
Errors in Rebasing. 
Restoring for further tests..

https://gerrit.wikimedia.org/r/99171
Change 108673 had a related patch set uploaded by 01tonythomas:
Removed "Enable section editing via [edit] links" from preferences

https://gerrit.wikimedia.org/r/108673
Change 99171 abandoned by 01tonythomas:
Removed "Enable section editing via [edit] links" from preferences

Reason:
Rebase errors persistant :(

https://gerrit.wikimedia.org/r/99171
Brian's caution (asking some up to date stats) makes sense, however it should be noted that AFAIK this preference is mainly a relic of the ancient past when section editing was the last new thing. :) Maybe we'll need this preference again if VisualEditor ever finds some magic to allow section editing again. :P
(In reply to comment #3)
> Maybe the relevant code form the parser itself can also be removed?

I'm not sure what you mean here.
Just for the record:

<jorm> Can we just agree from this day forward that "put it in your user css" is not an acceptable solution for any problem, ever?

From https://bugzilla.wikimedia.org/quips.cgi?action=show

Maybe the relevant code form the parser itself can also be removed?
Change 99171 had a related patch set uploaded by 01tonythomas:
Removed "Enable section editing via [edit] links" from Mediawiki Preference.

https://gerrit.wikimedia.org/r/99171
I would like to prepare a patch for this bug. Please assign it to me.
A user asks if VE shouldn't now get rid of apostrophes used for formatting and use common tags instead <b>, <i>...

--------------------------
**Version**: unspecified
**Severity**: enhancement
Closing this as a duplicate to avoid confusion.

*** This bug has been marked as a duplicate of bug 49143 ***
Supporting HTML storage is indeed one of our goals for this fiscal year, and an important part of our long-term strategy. We plan to store both HTML and wikitext (plus metadata) for a while, but are working on supporting HTML-only wikis. Those will still be editable using wikitext by using Parsoid for the conversion from HTML to wikitext and then back to HTML after the edit.

See our roadmap at https://www.mediawiki.org/w/index.php?title=Parsoid/Roadmap&oldid=738055 for more detail.
(Can't reply right now and for a few days, but in the meantime, someone else begs to differ: http://www.flickr.com/photos/fabola/7571369108/in/set-72157630578652390 )
Bug 49143 is the related bug.
To clarify, is this asking for VisualEditor to replace wikitext (WT) with HTML equivalents (but still inside a wikitext place)?

If so, that's not something we will do:

* it makes it hard for users to edit with WT;
* it would be bad to have VE replace other users' WT unexpectedly;
* it would be confusing to have mixtures of WT and HTML; and
* it doesn't save anything technically (it'd still need to go through Parsoid).

Because of these factors, that suggestion is a WONTFIX.

However, there is a different goal for Parsoid to be able to store their HTML+RDFa in the database directly, either alongside, or instead of, the WT that is currently stored. This has a number of advantages but is very far off.

I'm going to re-sort this to reflect the second of these, as I don't believe that there is an existing bug.
I believe this is a long-term goal.
<< When editing a reference, there is no indication at all if it is used multiple times throughout the article. This makes it very easy to screw up references, e.g. when you replace a ref for one sentence by changing it and it gets propagated throughout the article. WS (talk) 11:45, 13 August 2013 (UTC) >>

--------------------------
**Version**: unspecified
**Severity**: enhancement
The warning "This reference is used [n] times on this page." appears for Basic citations only  - verified the fix in beta, test2, and production. 

Bug 73566 was filed to apply the same warning to multiple instances of any kind of citations.
Change 169270 merged by jenkins-bot:
Show warning on reference dialog when editing a reference used in more than one place

https://gerrit.wikimedia.org/r/169270
Change 169270 had a related patch set uploaded by Alex Monk:
Show warning on reference dialog when editing a reference used in more than one place

https://gerrit.wikimedia.org/r/169270
--------------------------
**Version**: unspecified
**Severity**: normal
**See Also**:
https://bugzilla.wikimedia.org/show_bug.cgi?id=52771
This was first raised at 
http://en.wikipedia.org/wiki/Wikipedia:VisualEditor/Feedback#Removing_line_above_header_.22de-headers.22_it.3B_lack_of_.22undo.22_facility

If you have a document like
==Heading 2==
===Heading 3===
====Heading 4====
Paragraph.

i.e.

<h2>Heading 2</h2>
<h3>Heading 3</h3>
<h4>Heading 4</h4>
<p>Paragraph.</p>

and select the heading 3 block, so the selection goes all the way to the right hand side of the screen then delete, it will change the following heading to be an <h3> element. Likewise deleting the whole of the heading 4 line and deleting changes the paragraph to be a <h3> heading.

I've made a test file at http://en.wikipedia.org/wiki/User:Salix_alba/VE_test
**Author:** `l736ewiki`

**Description:**
The data model for TemplateData allows the tag "default" to assign the default value for parameters which foresee it.

However, when adding a template to an article via VisualEditor, the default value is not presented inside the corresponding input field, which appears empty, nor there are automatic hints about the default value (unless who generated the TemplateData object inserted it into the textual "description" item).

I would have expected that:
* either the user is presented with the input field already pre-filled with the default value as specified inside the TemplateData description - this would improve usability
* or, if this pre-population of the input field is too complex/costly to achieve, at least the information about the "default" value is taken and highlighted using the corresponding "default" attribute from the parameter description.

You can test this on it.wiki, by trying editing a new article using VE and adding the template named "Azienda", whose "logo_dimensioni" parameter has been defined in JSON with "default":"200".

--------------------------
**Version**: unspecified
**Severity**: enhancement
Reports such as https://en.wikipedia.org/w/index.php?title=Wikipedia:VisualEditor/Feedback&oldid=568123469#I_can.27t_edit_the_references suggest that the references list being present but not editable is causing confusion for editors.

It would therefore be helpful for VE to display a message (popup? tooltip?) whne the reference list is selected that explains how to edit references. The text of this message should be set on a MediaWiki namespace page.

I don't have a suggested default wording at present.

--------------------------
**Version**: unspecified
**Severity**: enhancement
**See Also**:
https://bugzilla.wikimedia.org/show_bug.cgi?id=52750
[[https://fr.wikipedia.org/wiki/Wikip%C3%A9dia:Questions_techniques/semaine_28_2016#Impossibilt.C3.A9_d.27apporter_des_corrections_dans_les_sections_Notes_et_r.C3.A9f.C3.A9rences|New feedback from a user]] (a beginner) who wants to change a reference rom the reflist while editing with VE.
This would be most helpful if the backlinks took you to the position of reference while remaining in edit mode.

Suggestion for the message from en.wp user Looie496:
 "This list of references is automatically generated and cannot be edited directly. If you would like to change the content of a reference, click on its number where it appears in the body of the article."
If implemented, bug 52750 would make this request either unnecessary or applicable only as an interim measure. In the latter case there wouldn't be any need for the message requested here to be editable on-wiki.
**Author:** `gitartha.bordoloi`

**Description:**
Hello,
Visual editor was deployed as an opt-in editing tool in Assamese wikipedia about 2 months ago. However it seems the tool doesn't support Assamese script well. While writing with some tools reproduces only vowels or consonants, the in-built keyboards do not work at all. Kindly look into this matter urgently before it is released as default editing tool. The discussions can be found here: http://as.wikipedia.org/wiki/%E0%A7%B1%E0%A6%BF%E0%A6%95%E0%A6%BF%E0%A6%AA%E0%A6%BF%E0%A6%A1%E0%A6%BF%E0%A6%AF%E0%A6%BC%E0%A6%BE_%E0%A6%AC%E0%A6%BE%E0%A7%B0%E0%A7%8D%E0%A6%A4%E0%A6%BE:%E0%A6%AD%E0%A6%BF%E0%A6%9C%E0%A7%81%E0%A7%B1%E0%A7%87%E0%A6%B2_%E0%A6%8F%E0%A6%A1%E0%A6%BF%E0%A6%9F%E0%A7%B0

Thank you.

--------------------------
**Version**: unspecified
**Severity**: major
Could somebody please answer if what's left to do in this ticket "just" a dup of {T51569}, or is there more to do (if so, what?)
Is what is left to do in this ticket "just" a duplicate of {T51569}? 
Or is there more to do (if so, what?)
Is what is left to do in this ticket "just" a duplicate of {T51569}? 
Or is there more to do (if so, what?)
(In reply to comment #11)
> NONE of the 6 in-built keyboards are working as of today.

I wonder if this is the same as T60662 comment 5 which is marked as a duplicate of T51569...
(In reply to comment #11)
> NONE of the 6 in-built keyboards are working as of today.

I wonder if this is the same as bug 58662 comment 5 which is marked as a duplicate of bug 49569...
**gitartha.bordoloi** wrote:

Hello developers,
I'm regularly checking the visual editor in Assamese wikipedia and now it supports the "external keyboards" nicely. There is no problem with rendering of Assamese characters as I reported earlier. However NONE of the 6 in-built keyboards are working as of today. Trying to write something with those keyboards render only Roman characters. I reported the same problem in last August also. Here is a link to my sandbox page in Assamese wikipedia where I've tested the visualeditor with different keyboards. 
https://as.wikipedia.org/wiki/user:Gitartha.bordoloi/visualeditor_test

I've tested it on Mozilla Firefox 26 and Google chrome 30 (windows 7 pc). I'll be glad to hear about any new developments. Thanks.
(In reply to comment #8)
> I tested it in Assamese wikipedia because on 5th September it was mentioned
> that "please re-open if you find that it is still happening after tomorrow
> (when the code will go live on the Assamese Wikipedia)". I tested it in
> mediawiki today and found some problems. I'll wait until Thursday and test it
> in aswiki again. Thank you.

Would it be possible to test against current master? You can use this at http://en.wikipedia.beta.wmflabs.org/ - we believe that we may have fixed the issues (or, at least, changed the behaviour) since you tested it.

Thank you!
Hello Gitartha, could you also please add some screenshots if you find any problems after your next test? Thanks.
**gitartha.bordoloi** wrote:

I tested it in Assamese wikipedia because on 5th September it was mentioned that "please re-open if you find that it is still happening after tomorrow (when the code will go live on the Assamese Wikipedia)". I tested it in mediawiki today and found some problems. I'll wait until Thursday and test it in aswiki again. Thank you.
(In reply to comment #6)
> Hello. I'm reopening the bug as the problems mentioned earlier are still
> there. Nothing has changed.

Which wiki did you test? The changes only went out to MediaWiki.org last Thursday, 12 September (so you can test these at https://mediawiki.org/wiki/VisualEditor:Test or similar) - they will not be released to the Assamese Wikipedia until this Thursday, 19 September.
**gitartha.bordoloi** wrote:

Hello. I'm reopening the bug as the problems mentioned earlier are still there. Nothing has changed.
Going to provisionally mark this as fixed - please re-open if you find that it is still happening after tomorrow (when the code will go live on the Assamese Wikipedia).
I think https://gerrit.wikimedia.org/r/#/c/80080/ may have solved this - let us know!
Hello, Thanks for reporting this. We are currently working to resolve the several issues around using Indic language scripts on the VisualEditor and we expect to resolve them soon. The problem reported in the current bug is also known and exists in other Indic scripts as well.  More discussion about this topic can also be found on bug #49569 . Thanks.
**gitartha.bordoloi** wrote:

(In reply to comment #1)
> Thanks for taking the time to report this!
> 
> (In reply to comment #0)
> > doesn't support Assamese script well
> > While writing with some tools
> > in-built keyboards do not work at all
> 
> Can you please provide more information / exact steps to reproduce the
> problems, plus information about browser and version? Also, what are "some
> tools" exactly?
> Also see https://www.mediawiki.org/wiki/How_to_report_a_bug . Thanks!

Thanks for pointing out the problems with the report.

* I have tested it in Mozilla Firefox 22 and Google chrome 23.
* There are currently 6 input layouts for Assamese under ULS. While trying to write Assamese in visualeditor with any one of them, NO Assamese character comes out.
* 'Some tools' refer various Assamese writing tools like to Rodali, Baraha, Azhagi+, Avro barnana etc.

With Rodali, there seems to be problems with vowels like  ী (ঈ), ূ (ঊ), ৌ (ঔ). So while trying to write 'অসমীয়া', it becomes 'অসীয়া'. 'মূহুৰ্ত' becomes ' ূহুৰ্ত', 'কৌটি' becomes ' ৌটি' etc.

with Azhagi+, the problem is more. Only the last vowel character of a word is shown in visualeditor. So 'অসমীয়া' becomes 'া'.

With Baraha, the problem is again with vowel characters like ঐ and ঔ. So 'সৈমান' becomes ' ৈমান'.

Similar problems exists with Avro.
Thanks for taking the time to report this!

(In reply to comment #0)
> doesn't support Assamese script well
> While writing with some tools
> in-built keyboards do not work at all

Can you please provide more information / exact steps to reproduce the problems, plus information about browser and version? Also, what are "some tools" exactly?
Also see https://www.mediawiki.org/wiki/How_to_report_a_bug . Thanks!
MassMessage is an extension that allows a user to send a message to a list of pages through a special page and the job queue. It is intended to replace [[m:Global message delivery]].

More details are available at [[mw:Extension:MassMessage]], and there is a test instance at http://legoktm.instance-proxy.wmflabs.org/wiki/Main_Page

--------------------------
**Version**: wmf-deployment
**Severity**: enhancement
**URL**: https://www.mediawiki.org/wiki/Extension:MassMessage
Change 91344 had a related patch set uploaded by MZMcBride:
Enable MassMessage on all wikis

https://gerrit.wikimedia.org/r/91344
(In reply to comment #59)
> Lego: can you please submit a changeset to enable MassMessage on all (public)
> Wikimedia wikis?

I submitted https://gerrit.wikimedia.org/r/#/c/91344/ a few days ago.
Lego: can you please submit a changeset to enable MassMessage on all (public) Wikimedia wikis?
I've been working with Aaron via email on the architecture review and I believe everything has been resolved (cc'd Aaron to get confirmation on that).

(In reply to comment #57)
> All of the blocking bugs have been resolved. What happens now? (Greg?)

Thanks for merging :). I just added bug 55822 which is a config change for how the jobs will get processed, it would be good to get that deployed and make sure there are no issues before the full deployment.
All of the blocking bugs have been resolved. What happens now? (Greg?)
(In reply to comment #54)
> One more thing - we'll need to add standard licensing/ToS language to the
> submit screen to ensure content is licensed consistent with Wikimedia
> requirements. The wikimedia-copyrightwarning message in the WikimediaMessages
> extension should do the trick.

(The relevant function is EditPage::getCopyrightWarning(), the messages shouldn't be used directly.)
(In reply to comment #53)
> I have a quick question about the extension itself. Maybe I'm reading this
> code
> wrong, but the extension appears to iterate through the recipients on the
> special page, and then make a new job for each recipient. If this is true,
> that
> means that this extension would be launching thousands of jobs from a single
> web request. It kind of defeats the purpose of the job queue in the first
> place.

Yes, that's correct. I'm not sure how it defeats the purpose of the job queue though. We could do it like refreshlinks works and submit a job that submits more jobs, but I don't see how that would be any better. I did a simple test on testwiki a week ago and submitted 2k jobs at once and it seemed to work fine.

> 
> Also, do people have some sort of irrational fear of the FormSpecialPage
> class?

I actually didn't know that existed until now. I basically forked the code of TranslationNotifications and used that...
One more thing - we'll need to add standard licensing/ToS language to the submit screen to ensure content is licensed consistent with Wikimedia requirements. The wikimedia-copyrightwarning message in the WikimediaMessages extension should do the trick.
I have a quick question about the extension itself. Maybe I'm reading this code wrong, but the extension appears to iterate through the recipients on the special page, and then make a new job for each recipient. If this is true, that means that this extension would be launching thousands of jobs from a single web request. It kind of defeats the purpose of the job queue in the first place.

Also, do people have some sort of irrational fear of the FormSpecialPage class?
(In reply to comment #48)
> (In reply to comment #39)
<snip>

I've filed bug 54954 as a blocker to this one. I've asked a few preliminary questions on how this should be implemented, so if people who have options could comment there please :)
(In reply to comment #48)
If there is any way to do global logs (alongside local ones) this would be a very good place to use that, as that would make all wikis much more easily accountable for any usage of this tool.

That said you're probably right in that just enabling the sending part on meta would be better, since, on top of logs and such all being in one place, usage guidelines and crap would also be better synced. And implicitly trusting all admins isn't necessarily a good idea when different projects can have completely different methods and standards when approaching problems, and on top of that pretty much anyone can become an admin at least somewhere (which isn't even necessarily a bad thing, since if they happen to be in the right place even the most unexpected of folks can prove quite useful, but also doesn't mean it should carry weight elsewhere).

So just have a request page for anyone new to use, and a right that can be added to anyone who ain't an admin if they've general use for the spammer and clearly understand what not to do, or whatever. I'm sure the meta folks can argue out some actual details there.
(In reply to comment #34)
> [...] Last year, there was a broken core change about timestamping slipped through
> Platform review and got deployed. Because of that, a better thought-out and
> previously-developed pending core change for the exact same feature from
> Werdna
> got bumped. [...]

The only thing I found is https://gerrit.wikimedia.org/r/#/c/15746 which was merged after ignoring code-review for months, causing a developer and translator revolt.

(In reply to comment #48)
> So I'm not comfortable with a deploy that amounts to giving admins in every
> wiki 'massmessage' permission to every other wiki. I'd be fine with 1)
> limiting
> the availability of the massmessage permission to Meta, or 2) adding back the
> global/local message delivery distinction and enabling local delivery on all
> wikis, and global delivery on Meta.
> 
> Better broadcasting tools should still continually be developed, and the
> imperfections of this approach will hopefully feed into whatever comes next,
> whether it's an iteration on MassMessage or an entirely new approach.

+1
I think this is totally reasonable and was indeed my only true worry about the extension.
I'd add the permission to a special group, possibly reusing centralnoticeadmin group, since the first deploy, to avoid needless requests for adminship.
More than that, we could even try to replicate the logging of the messages content to a wiki page, for enhanced accountability.
s/ReviewerBot/MessengerBot/
**tchay** wrote:

(In reply to comment #41)
> (In reply to comment #7)
> > == TODO/Check list ==
> > Extension page on mediawiki.org: yes
> > Bugzilla component: yes
> > Extension in Gerrit: yes
> > Design Review: no
> > Archeticecture/Performance Review: no
> > Security Review: no
> > Screencast (if applicable): no
> > Community support: no?
> 
> As a designer, I did a design review over IRC. I said something along the
> lines
> of 'looks shiny'.
> 
> I hope that helps, as I'm not sure what more you could want with this kind of
> extension. Other issues beyond the interface itself have generally already
> been
> established by precedent (EdwardsBot).

We'd have to ask Greg what he really meant by this when he added that to [[mw:Review queue]] instead of leaving the process pointing back to [[mw:Writing_an_extension_for_deployment]], but if I were to hazard a guess:

I think Greg tried to clear the review queue because it was suffering from neglect. He tried summarize the original linked document: [[mw:Writing_an_extension_for_deployment#Design_review]] by saying it has a proper "design review." It clearly implies design review as being a product design review with a design UI design component [[mw:WMF_Project_Design_Review_Process]] probably dating back to when they were in the same department.

If you look at an earlier revision [https://www.mediawiki.org/w/index.php?title=Review_queue&oldid=697844], you can see the tracking list that was its original purpose since Brion created it. Around that time, it was getting unmanageable four months ago with little movement. My guess is that there simply had been no recent Extensions (other than in-flight extensions like Math and SignupAPI) that had actually gone through this process and in an effort to systematize the process into a workable checklist, it got morphed over time from "send it to product design for review" to "send an e-mail to a designer and to the design mailing list." *shrug*
(In reply to comment #40)
> (In reply to comment #38)
> 
> > > The requirement for extensions to be deployed has ALWAYS been that Features
> > > Engineering sign off on a commitment to maintain the extension.
> > 
> > This isn't consistent with the documentation at [[mw:Writing an extension for
> > deployment]], [[mw:Review queue]] and Greg's checklist in comment 7.
> 
> Interesting links.
> 
> To the first document which has its origins in the SVN days, the first stop
> with Howie Fung and his product management team. To my knowledge the only
> person asked was a Dan Garry, and not as a first stop on anything. 

Dan was cc'd by Greg in comment 13. I wasn't aware that Platform and/or Features were supposed to be in the loop so I never bothered to do it.

> I mentioned
> in my original post why that people should know better. The second stop was
> wikitech-l. To my knowledge mine was the first post on the subject.

Correct. I had spoken with Greg a few days earlier about emailing wikitech-l / Aaron / Tim for the architecture review, and he recommended that I wait for your comments ;-)


> The second document is newly written by Platform not vetted by anyone in
> Features.

For someone outside of the WMF who is trying to get an extension deployed, the distinction between Platform and Features isn't very clear, nor really important. Was VipsScaler (also written by a volunteer) handled by Features? All we really want is our code deployed :P
 
> The third link refers to someone who has been at the WMF even less time than
> me. If we're to use MZMcBrides seniority rules, the fact that some
> newly-minted, improperly vetted document was used by a relatively new
> engineer
> doesn't carry weight.

The checklist is fine, it just seems like its missing one step according to you (notify Features and/or Platform teams).

> I hope that documentation is updated.

Be bold!
(In reply to comment #41)
> As a designer, I did a design review over IRC. I said something along the
> lines
> of 'looks shiny'.

For reference, Isarra created [[commons:File:Massmessage preview (uncyc).png]], and pointed out a few flaws in the initial design, like using tables for the form (now switched to proper <div>s), and the submit/preview buttons stacked on top of each other (now side-by-side).
(In reply to comment #40)
> Do you have a link to this doctrine regarding software deployments and
> sign-offs? [...] perhaps there's a guideline you've written on mediawiki.org,
> wikitech.wikimedia.org, or Meta-Wiki. Please share.

Go on. I'll wait.
(In reply to comment #7)
> == TODO/Check list ==
> Extension page on mediawiki.org: yes
> Bugzilla component: yes
> Extension in Gerrit: yes
> Design Review: no
> Archeticecture/Performance Review: no
> Security Review: no
> Screencast (if applicable): no
> Community support: no?

As a designer, I did a design review over IRC. I said something along the lines of 'looks shiny'.

I hope that helps, as I'm not sure what more you could want with this kind of extension. Other issues beyond the interface itself have generally already been established by precedent (EdwardsBot).
(In reply to comment #37)
> Is the current thinking to give users on any wiki the right to use
> Special:MassMessage to spam users on any other wiki?

Yes. The design idea here was that this is already possibly by any user. Anyone can open up a bunch of browser tabs and post to dozens of wikis quickly without even logging in. Or, for example, I've been posting to hundreds of wikis for years without a privileged account using only a very simple Python script. The difference here in functionality isn't very big. The primary difference is that we're adding a proper user interface for delivery submissions and reducing the need for an external dependency (a bot).

> It seems to me you'd want something like:
> 
> * Users on Meta can trigger cross-wiki notifications;
> * Users on any other wiki can only trigger local notifications.

This was considered and it's probably easy enough to implement these restrictions, but as I said above, I'm not sure they're necessary. My view was to take a "wait and see" approach. If local administrators begin to abuse or misuse the tool, we can always add in restrictions later.

> Otherwise you end up with an audit trail mess. Having a single log in one
> place and a single place to set policy around these things seems highly
> desirable.

Again, anyone can go around posting messages to any wiki right now without even logging in. Giving local administrators the ability to send cross-wiki messages with a simpler tool doesn't seem to warrant much concern from my perspective, but if you consider this a requirement for wider deployment, Lego can add in the restrictions.

The bot currently provides an audit trail by (optionally?) appending an HTML comment containing the originating wiki, message sender's name, etc., I believe. Lego can confirm this.
(In reply to comment #35)
> Ori has stepped up and is willing to commit his time to help Legoktm in
> supporting MassMessage on an ongoing basis. According to the current standard
> of the above, there is no longer any block on bug 52723.

Thank you Ori!

> The requirement for extensions to be deployed has ALWAYS been that Features
> Engineering sign off on a commitment to maintain the extension.

This isn't consistent with the documentation at [[mw:Writing an extension for deployment]], [[mw:Review queue]] and Greg's checklist in comment 7.
Is the current thinking to give users on any wiki the right to use Special:MassMessage to spam users on any other wiki?

It seems to me you'd want something like:

* Users on Meta can trigger cross-wiki notifications;
* Users on any other wiki can only trigger local notifications.

Otherwise you end up with an audit trail mess. Having a single log in one place and a single place to set policy around these things seems highly desirable. If we're on the same page on that, I'm significantly less concerned about the long term impact of the extension.
(In reply to comment #35)
> The requirement for extensions to be deployed has ALWAYS been that Features
> Engineering sign off on a commitment to maintain the extension.

You've been at the Wikimedia Foundation for, what, two years? You really feel it's appropriate to lecture me and others about how things have "always" been? You seem to have absolutely no sense of how software deployments have operated for the majority of Wikimedia's existence.

You're attempting to dictate to volunteers as though they're your subordinates. This is wildly inappropriate.

Do you have a link to this doctrine regarding software deployments and sign-offs? As far as I can tell, you've just made it up here on this bug. But perhaps there's a guideline you've written on mediawiki.org, wikitech.wikimedia.org, or Meta-Wiki. Please share.
*couldn't be less true
**tchay** wrote:

I am not modifying this bug, to leave open the avenue that Platform Engineering commits to supporting [[mw:Extension:MassMessage]], only bug 35306.
As someone that has discussed the topic of mass notifications / announcements / newsletters with many people I agree with the approach being proposed here:

* MassMessage solves a problem here and now by deprecating EdwardsBotwith a better solution.

* There is a possibility to integrate an Echo plugin to MM in the future, but this is no blocker for a deployment to Wikimedia wikis now.

* There are other future possibilities around announcements / newsletters in the future, in the lines proposed at https://www.mediawiki.org/wiki/Extension:Newsletter#Wishlist and MassMessages might or might not be a good project to handle this, but again this is no obstacle for a deployment now.
(In reply to comment #25)
> There is some overlap with Echo with this. 
In general, yes. Both extensions provide a 'notification' functionality, however there are some pretty big differences as well.

1) Echo notifications for the most part are private; only you can see your Echo notifications. MM is designed so that everything (target list, message content) is fully public.

2) Echo is centered around users, given that you can only send notifications to users. MM can send to basically any page, which is necessary for global message delivery (most messages are sent to village pumps, not users directly).

3) Echo notifications are quick short messages that usually are just a link to something else. In many cases, EdwardsBot delivers the whole message to your talk page (example: <https://en.wikipedia.org/?diff=prev&oldid=565236352>). In this regard MM has been designed so that the end user receiving the message would not see any difference.

(In reply to comment #25)
> if we enable this extension we could always disable it should
> Echo supersede it.

I don't think merging MM into Echo is a good idea. Rather, MM should use Echo notifications instead of talk page ones if $wgMMUseEcho is enabled. Or something like that...
There is some overlap with Echo with this. On the other hand, there are some things that this might be suited for, such as the delivery of the Wikipedia Signpost. It's my view that an in-built solution to replace EdwardsBot would be useful, and if we enable this extension we could always disable it should Echo supersede it.

I'm CCing Fabrice Florin, the product manager for notifications, to see if he has any input.
(In reply to comment #19)
> Mostly, I brought this (deploying MassMessage) up in a Deployment updates
> meeting, and there was some push back from a product view. In short:
> "shouldn't this functionality be built into something like Echo?" So, I won't
> go around them and deploy MassMessage everywhere until that conversation is
> settled (for some value of "settled").

I'm still awaiting feedback from Terry, Howie, or Fabrice on bug 35306 (I also e-mailed them yesterday with a pointer to the bug), however Lego pointed out to me that Echo doesn't currently support cross-wiki notifications, so Echo integration is probably completely off the table for now.

I think a month of testing is sufficient for this extension, so I've tentatively scheduled a deployment to all Wikimedia wikis for the end of October (cf. <https://wikitech.wikimedia.org/w/index.php?diff=84903&oldid=84888#Near_term>). You know the calendar much better than me, though, so let me know if that's a particularly bad time for whatever reason.
(In reply to comment #22)

Hah! I just came here to write pretty much the same comment. Brilliant. Thank you, Lego.

Testing is underway (cf. [[testwiki:Special:Log/massmessage]]) and feedback has started to come in (cf. [[m:Talk:MassMessage]]).
Some updates:

MassMessage was successfully deployed to test and test2 today (thanks Reedy!). I did a few simple tests making sure everything worked fine (https://test.wikipedia.org/w/index.php?title=Special%3ALog&type=massmessage&user=Legoktm&page=&year=&month=-1&tagfilter=&hide_patrol_log=1&hide_review_log=1&hide_thanks_log=1)

MZMcBride has sent out a message to people who currently use EdwardsBot on enwiki and meta asking them to test it on testwiki and provide feedback (https://meta.wikimedia.org/w/index.php?title=Global_message_delivery/Spam&oldid=5895864).

We're still waiting on comments from Fabrice/Howie/Terry (bug 35306 comment 20).

[[mw:Help:Extension:MassMessage]] has documentation on how an administrator would use the special page to send out a message. [[m:MassMessage]] has also been created.
After a couple of updates, it all looks ok from the security side.
Err, I mean, after Chris S gives the all clear, security-review-wise: https://bugzilla.wikimedia.org/show_bug.cgi?id=52723#c16
(In reply to comment #18)
> (In reply to comment #17)
> > There was a request to see if this extension would make sense as an
> > improvement to Notifications/Echo. This discussion would probably be good to
> > have with the WMF product team (maybe including Fabrice, Terry, and Howie).
> 
> This already took place at bug 35306.

Right, so, I'm deferring judgement on that (and related) conversations to Terry C and Howie F right now. More on why below...

> > I'll default to defer for now, until that conversation happens.
> 
> I don't know what this means. Can you clarify?

Mostly, I brought this (deploying MassMessage) up in a Deployment updates meeting, and there was some push back from a product view. In short: "shouldn't this functionality be built into something like Echo?" So, I won't go around them and deploy MassMessage everywhere until that conversation is settled (for some value of "settled").

Now, what we should do is deploy MassMessage somewhere so you/others can test its functionality on a WMF production-like site. Let's get this out to test2.wikipedia this Thursday. Filed bug 54518 for that.
(In reply to comment #17)
> There was a request to see if this extension would make sense as an
> improvement to Notifications/Echo. This discussion would probably be good to
> have with the WMF product team (maybe including Fabrice, Terry, and Howie).

This already took place at bug 35306.

> I'll default to defer for now, until that conversation happens.

I don't know what this means. Can you clarify?
There was a request to see if this extension would make sense as an improvement to Notifications/Echo. This discussion would probably be good to have with the WMF product team (maybe including Fabrice, Terry, and Howie).

I'll default to defer for now, until that conversation happens.
Just an update, I'm still working on the review. There were a few bits that looked odd as I was testing, so I'd like to dig into those before giving the all clear. Should be able to get that finished on Monday.
I just spent a few minutes talking with Chris who said he would be able to do a security review of the extension this week.

Currently waiting for a few patches to be reviewed and then I'll send an email to wikitech-l.
(In reply to comment #11)
> (In reply to comment #9)
> >> Not sure this is relevant as this extension isn't really user-facing, but if
> >> you want to find someone to review the design, go for it.
> > 
> > Well, for some definition of user, right? It has sysop user facing UI. For a
> > design review, the Design mailing list is a good place to start (and then
> > ping until success).
> 
> Lego: please go ahead and e-mail the design mailing list (include a working
> demo of the tool, of course). If they have constructive feedback, wonderful.
> Otherwise, I don't consider this a blocker to deployment.
> 

Email sent to design list: http://lists.wikimedia.org/pipermail/design/2013-September/000923.html
CC'ing Dan Garry (new Platform PM). No action needed Dan (yet ;) ). Just using this as a way to remind us to talk about this work and how you'll interface with it.
The goal is to get this extension deployed (to phase 0 wikis) by the end of September. I'm not sure if this will be possible, but I've tentatively added it to the deployments calendar for September 30: <https://wikitech.wikimedia.org/w/index.php?diff=83188&oldid=83134#Near_term>.

Lego: feel free to move the date into October if necessary.
(In reply to comment #9)
> > 
> > > Community support: no?
> > 
> > Yes, plenty of it.
> 
> Awesome. I believe you, but would appreciate links to where discussion has
> happened.

Long wanted feature to not have to have bots making tens/thousands of edits onwiki. Not sure a discussion par se would have happened.. (if one has, great)

To users, it really doesn't matter where it comes from.
(In reply to comment #8)
> Thanks for writing out a checklist.

:)

> (In reply to comment #7)
> > == TODO/Check list ==
> > Extension page on mediawiki.org: yes
> > Bugzilla component: yes
> > Extension in Gerrit: yes
> 
> Right.
> 
> > Design Review: no
> 
> Not sure this is relevant as this extension isn't really user-facing, but if
> you want to find someone to review the design, go for it.

Well, for some definition of user, right? It has sysop user facing UI. For a design review, the Design mailing list is a good place to start (and then ping until success).

> 
> > Architecture/Performance Review: no
> > Security Review: no
> 
> These are the two areas needed here.
> 
> Greg: how do we get this extension reviewed for architecture/performance and
> security?

First pass would be to send a note to wikitech-l asking for help. Unfortunately, this week is a combined Tech Days and All Hands so WMF tech staff will be slower to respond than normal, but I know you know who to ping as needed (Aaron/Tim for arch, Chris for security).

> 
> > Screencast (if applicable): no
> 
> Not sure what this is about. It seems irrelevant.

Well, if there are any userfacing bits (even for non-mortals), then it'd be good to have a walk-through of how the extension is supposed to work/what the process is. Think of it as a required bit of user documentation :)

> 
> > Community support: no?
> 
> Yes, plenty of it.

Awesome. I believe you, but would appreciate links to where discussion has happened.
Thanks for writing out a checklist.

(In reply to comment #7)
> == TODO/Check list ==
> Extension page on mediawiki.org: yes
> Bugzilla component: yes
> Extension in Gerrit: yes

Right.

> Design Review: no

Not sure this is relevant as this extension isn't really user-facing, but if you want to find someone to review the design, go for it.

> Architecture/Performance Review: no
> Security Review: no

These are the two areas needed here.

Greg: how do we get this extension reviewed for architecture/performance and security?

> Screencast (if applicable): no

Not sure what this is about. It seems irrelevant.

> Community support: no?

Yes, plenty of it.
Hello, this is a quasi-automated-but-not-really message:

I am reviewing all tracking bugs for extensions to review and deploy to WMF servers. See the list here:
https://bugzilla.wikimedia.org/showdependencytree.cgi?id=31235&hide_resolved=1

The [[mw:Review queue]] page lists the steps necessary to complete the review. I have copied them below and done some initial filling out based on what I can easily gleen from this bug and any linked to sources that are obvious. If I miss something/state something false, please do correct me.

Also, if you haven't yet done so, please review the information on and linked to from:
https://www.mediawiki.org/wiki/Writing_an_extension_for_deployment


== TODO/Check list ==
Extension page on mediawiki.org: yes
Bugzilla component: yes
Extension in Gerrit: yes
Design Review: no
Archeticecture/Performance Review: no
Security Review: no
Screencast (if applicable): no
Community support: no?
(In reply to comment #5)
> Hi Legoktm, I see that http://www.mediawiki.org/wiki/Extension:MassMessage
> exists but where is its bugtracker? See
> https://www.mediawiki.org/wiki/Bug_management/Project_Maintainers#To_add_a_project_or_component

Filed as bug 52730.
Hi Legoktm, I see that http://www.mediawiki.org/wiki/Extension:MassMessage exists but where is its bugtracker? See https://www.mediawiki.org/wiki/Bug_management/Project_Maintainers#To_add_a_project_or_component
(In reply to comment #1)
> (see [[meta:User talk:EdwardsBot/Archive 1#LQT compatibility]])
The correct link is [[User talk:EdwardsBot/Archive 1#LQT compatibility]].
For reference: <https://gerrit.wikimedia.org/r/#/q/project:mediawiki/extensions/MassMessage+status:open,n,z>.
(In reply to comment #1)
> Does it have the same problem as the global message delivery system on wikis
> which use LiquidThreads?
> (see [[meta:User talk:EdwardsBot/Archive 1#LQT compatibility]])

The real bug is that those wikis are still using LiquidThreads. :-)

But if you want to add a dependency bug about MassMessage supporting LiquidThreads, it shouldn't be too painful to code.
Does it have the same problem as the global message delivery system on wikis which use LiquidThreads?
(see [[meta:User talk:EdwardsBot/Archive 1#LQT compatibility]])
The Swedish chapter would like to get the VisualEditor enabled on their wiki at se.wikimedia.org. 

Poll here: http://se.wikimedia.org/wiki/Tråd:Wikimedia:Bybrunnen/VisualEditor_och_Notifications

/Jan
CEO

--------------------------
**Version**: wmf-deployment
**Severity**: enhancement
This is now live - you can opt in to test VisualEditor using the Beta Features link in your personal tools at the top of the page, or through the Preferences link in the "Beta Features" tab.

If there are any issues, please shout!
Change 97714 merged by jenkins-bot:
Enable VisualEditor as opt-in on Swedish Wikimedia

https://gerrit.wikimedia.org/r/97714
Change 97714 had a related patch set uploaded by Jforrester:
Enable VisualEditor as opt-in on Swedish Wikimedia

https://gerrit.wikimedia.org/r/97714
en.wp user Cryptic C62 reports that using Firefox with Windows Vista "high contrast" mode renders VE entirely unusable:

"Using Windows Vista, press Shift + Alt + Print Screen to activate "high contrast" mode. Open VE in Firefox. Weep uncontrollably (see screenshot)."

Screenshot: [[File:VE High Contrast.jpg]]


It is worth noting that, when using the high contrast extension for Chrome, the interface is fully visible in every setting. Hooray!

--------------------------
**Version**: unspecified
**Severity**: major
id call this an OS bug...
Visual Editor in Windows 7 High Contrast Mode in Firefox 44 {F3524565}

Google.com in Microsoft's very own Internet Explorer 11
{F3524580}

Microsoft.com in IE 11 at High Contrast Mode on Windows 7 
{F3524584}

Given those examples I highly question how many people **are actually able to use //any website with this functionality at all//** in its current implementation?! Seems poorly conceived. 
@Jdforrester-WMF  If nobody is opposing that in a reasonable time frame (30 days?) I'd recommend closing this task as "invalid".
When a user has a larger font size than defualt, or a non-default font then the welcome dialog (the one controlled by the ve-beta-welcome-dialog cookie) doesn't expand or scroll to accommodate the extended length of the message and the text is cropped.

Screenshot at [[File:WARNINGforVE.png]]

This might be another example of bug 52602 but I'm not certain.

--------------------------
**Version**: unspecified
**Severity**: major
**See Also**:
https://bugzilla.wikimedia.org/show_bug.cgi?id=52602
https://bugzilla.wikimedia.org/show_bug.cgi?id=51755
https://bugzilla.wikimedia.org/show_bug.cgi?id=50885
Change 82466 merged by jenkins-bot:
Improve welcome dialog support for large fonts

https://gerrit.wikimedia.org/r/82466
Change 82466 had a related patch set uploaded by Trevor Parscal:
Improve welcome dialog support for large fonts

https://gerrit.wikimedia.org/r/82466
en.wp user Redrose64 reports:
With this edit: https://en.wikipedia.org/w/index.php?title=Paisley_Gilmour_Street_railway_station&diff=prev&oldid=567709873 "the {{-}} was moved from the bottom of a section into a heading, effectively yielding the HTML <h3><span class="mw-headline" id="2013">2013<br style="clear:both;" /></span>[edit]</h3> "

I can reproduce that on that article by:
1. Deleting with backspace the header "Post-2008" (and nothing else)
2. Typing "2013"

I can't reproduce it in my sandbox with {{-}} (or {{clear}}) before a header and then changing the header.

--------------------------
**Version**: unspecified
**Severity**: normal
*** This bug has been marked as a duplicate of bug 49806 ***
Because Subbu and Gabriel asked: this is a VE bug, not a Parsoid bug. Unfortunately it's not very clear where the {{-}} template is exactly because it doesn't really produce visible output. So pressing backspace or delete can cause the {{-}} to move to a different paragraph, which may be styled as a heading or restyled by the user to be a heading. And you don't really notice that you're doing this because it's not visible.
Moving to VisualEditor:

[16:19] <RoanKattouw> That looks like a VE issue
[16:20] <RoanKattouw> It's probably because {{-}} doesn't produce any visible output (it outputs a <br> with clear: both;)
[16:20] <RoanKattouw> And so people don't notice when their backspace or delete presses cause the {{-}} to be moved into a different paragraph which they then mark up as a heading
I reproduced it - not precisely, but close enough.

I pretended I was a brand new editor, and rather than changing the heading I created a new one, above the old. Then I deleted the old and applied formatting to the new word I typed.

This rendered this: http://en.wikipedia.org/w/index.php?title=User%3AMdennis_%28WMF%29%2Fsandbox&diff=568643085&oldid=568642989

The template moved, but in front of rather than behind the word.

I'm using Chrome.

I tried it again on Firefox, and caught the template again:
https://en.wikipedia.org/w/index.php?title=User%3AMdennis_%28WMF%29%2Fsandbox&diff=568643930&oldid=568643677

I guess that the IP editor may have positioned his cursor slightly differently, but that seems to be the behavior that led to the issue. It seems like potentially an easy decision to make.
I agree with your recommendation, Chris.

I think this was a valid bug, but it might have been specific to a particular set of conditions at the time of the bug (cached HTML, what the user was doing, the state that VE was in and the HTML it generated, source wikitext) which we are having a hard time reproducing now.  So, I am going to close this bug for now and we can reopen this or a new one if a similar error shows up.
Having tried again, I still can't reproduce it. The original edit that caused this was by an anonymous user who hasn't edited since, so we're unlikely to get any more information from them.

Should this be closed (WORKSFORME?) and then just reopened if it happens again in future?
After about 5 minutes trying I can't reproduce this now on either the present or old revisions of that page. I haven't tried again in my sandbox but given the other findings I wouldn't expect it to.

The only change is I'm now running Firefox 23 rather than the 22 I was running when I reported this (and I don't know how to keep separate versions of the same program available at the same time, sorry)
Unfortunately, I am having a hard time reproducing the bug now.  And, as you noted, I am not able to copy it to my sandbox and reproduce it either.  This may have been some glitch in how VE might have modified the DOM on editing there.

Can you verify that you can reproduce the error on the latest version or that oldid?  I even added a newline space back in case that matters (since that is what was present in the oldid).
During the edit

This has been noted on the Thai wikipedia.  
See screenshots for how it looks.  

Basically, in edit mode, the sixth column of this table, containing Goehack coordinate links, displays as an HTML string in edit mode. Not only very messy, but it pushes the following columns off the page.

Appears to save normally.

Replicated on current FF, Chrome, on Mac OS and Ubuntu

Page on Thai.wiki: https://th.wikipedia.org/wiki/%E0%B8%A3%E0%B8%B2%E0%B8%A2%E0%B8%8A%E0%B8%B7%E0%B9%88%E0%B8%AD%E0%B9%82%E0%B8%9A%E0%B8%A3%E0%B8%B2%E0%B8%93%E0%B8%AA%E0%B8%96%E0%B8%B2%E0%B8%99%E0%B9%83%E0%B8%99%E0%B8%81%E0%B8%A3%E0%B8%B8%E0%B8%87%E0%B9%80%E0%B8%97%E0%B8%9E%E0%B8%A1%E0%B8%AB%E0%B8%B2%E0%B8%99%E0%B8%84%E0%B8%A3_(%E0%B9%80%E0%B8%82%E0%B8%95%E0%B8%9E%E0%B8%A3%E0%B8%B0%E0%B8%99%E0%B8%84%E0%B8%A3_%E0%B8%9B%E0%B9%89%E0%B8%AD%E0%B8%A1%E0%B8%9B%E0%B8%A3%E0%B8%B2%E0%B8%9A%E0%B8%A8%E0%B8%B1%E0%B8%95%E0%B8%A3%E0%B8%B9%E0%B8%9E%E0%B9%88%E0%B8%B2%E0%B8%A2_%E0%B9%81%E0%B8%A5%E0%B8%B0%E0%B8%AA%E0%B8%B1%E0%B8%A1%E0%B8%9E%E0%B8%B1%E0%B8%99%E0%B8%98%E0%B8%A7%E0%B8%87%E0%B8%A8%E0%B9%8C)

--------------------------
**Version**: unspecified
**Severity**: normal

**Attached**: {F11613}
Not sure when, but this is now fixed, probably because of Ed's work on template wrapping.
If a parameter has '"type": "number"', VisualEditor should not allow the user to insert other kind of values. Alternativelly, it could just warn the user but still allow a value of the wrong type to be inserted.

This should not be restricted just to the "number" type. Other types would also benefity from some validation (e.g., if at some point we have a type "string/image-name", VE should check if the user provided the name of an existing image).

--------------------------
**Version**: unspecified
**Severity**: enhancement
**See Also**:
https://bugzilla.wikimedia.org/show_bug.cgi?id=52652
I don't agree with restricting users from only entering content as the hinting suggests (the hinting may be wrong, or may restrict users too much) - this is the same reason why we allow users to add un-hinted parameters.

However, yes, we should definitely add this missing feature in soon.
If you want to add a "template" that is not in the template namespace, for example: "User:UBX"; VE will make an API request like: "GET https://en.wikipedia.org/w/api.php?format=json&action=templatedata&titles=Template%3AUser%3AUBX".

It should automatically detect that "User:" is a valid namespace, and not add the "Template:" prefix.

--------------------------
**Version**: unspecified
**Severity**: minor
Change 140875 merged by jenkins-bot:
Handle transcluding templates outside of the template namespace properly

https://gerrit.wikimedia.org/r/140875
What Matt pointed out is handled correctly except for main namespace titles (e.g. :Foo), where the input widget trips over itself and you always end up with Template:Foo.
The commit says the purpose of the colon is "to create a link to something that would normally be included as a File/Category".

That's true, but it also plays a role in transclusion.  It's used to transclude things in the main namespace.

E.g. on English Wikipedia {{Main Page}} transcludes https://en.wikipedia.org/wiki/Template:Main_Page , whereas {{:Main Page}} transcludes https://en.wikipedia.org/wiki/Main_Page

For other namespaces (e.g. {{Wikipedia:Community Portal}} / {{:Wikipedia:Community Portal}} ), it works either way.

Full demo: https://en.wikipedia.org/w/index.php?title=User:Superm401/Sandbox&oldid=614564227

This may be handled somewhere (e.g. Parsoid), but it needs to be tested.
This was also hiding another problem (templates outside of the Template namespace ended up prefixed with ':', breaking them). This patch should fix that too (and hopefully not break any other link suggesting things).
Change 140875 had a related patch set uploaded by Alex Monk:
Handle transcluding templates outside of the template namespace properly

https://gerrit.wikimedia.org/r/140875
(Okay, it's not as simple as I was hoping)
It looks like we can just pass the title to mw.Title.newFromText with mw.config.get( 'wgNamespaceIds' ).template as the (default) namespace.
Some toDomElements functions reach into the store, but they shouldn't and the check is redundant.
A keyboard shortcut for code would be helpful, particularly for MediaWiki.org.  We'll need to think of what to use.

--------------------------
**Version**: unspecified
**Severity**: enhancement
Verified the fix in production
Change 160174 merged by jenkins-bot:
Add keyboard shortcuts for strikethrough and code annotations

https://gerrit.wikimedia.org/r/160174
Change 160174 had a related patch set uploaded by Jforrester:
Add keyboard shortcuts for strikethrough and code annotations

https://gerrit.wikimedia.org/r/160174
**fred** wrote:

When is this planned? I was about to write that enhancement proposition as well when I saw this ticket.

My personal preference would be to have a shortcut near the ctrl tab on the left of the keyboard.
(In reply to comment #1)
> One possiblity is Ctrl-{.  It takes three key strokes on some keyboards, but
> it's memorable as long as it matches the toolbar icon, and not that hard to
> type.

We're almost certainly not going to keep '{}' for code (especially as there's <code> and <syntaxhighlight> that need to be distinguishable), but it's a possibility.
One possiblity is Ctrl-{.  It takes three key strokes on some keyboards, but it's memorable as long as it matches the toolbar icon, and not that hard to type.
Some templates use numbered arguments (see for example http://en.wikipedia.org/wiki/Module:Citation/CS1/Whitelist in the numbered_arguments list). For example, you can use author1, author2, ... (no limit).

Currently, there's no way to define such parameters in TemplateData, and the VE interface is not also optimal for them.

Would it be possible to handle numbered arguments in TemplateData: a parameter named author# would define a numbered parameter named author with a numerical suffix. It should be possible to define lower bound (1 by default) and upper bound (no limit by default).

Then VE should handle them accordingly: only propose the first parameter available in the list of parameters than can be added.

--------------------------
**Version**: unspecified
**Severity**: major
**See Also**:
{T53740}
For draft template I'm working on for the Wikitionary, I came with things like `|définition.1.4.exemple.2.description =`. That is description of 2nd example of the 4th subdefinition of the first main definition. That might be a somewhat extreme example, but that would be nice to take it into account while treating this ticket.
For draft template I'm working on for the Wikitionary, I came things like `|définition.1.4.exemple.2.description =`. That is description of 2nd example of the 4th subdefinition of the first main definition. That might be a somewaht extrem example, but that would be nice to take it into account while treating this ticket.
I am also thinking of templates with an unlimited number of unnamed parameters, which are not handled well in VE currently.
Regarding the UX and UI of this feature, one possibility is that when a user adds content to the Author1 field, the Author2 field becomes visible, and when s/he adds content to Author2, Author3 becomes visible, and so on.
Regarding the visual implementation of this feature, one possibility is that when a user adds content to the Author1 field, the Author2 field becomes visible, and when s/he adds content to Author2, Author3 becomes visible, and so on.
I think I may increase priority of this task. A lot of new templates, gadgets and scripts have autogenerated parameters.
This will affect ProveIt when implemented. ProveIt relies on TemplateData to perform its work, much in the same way the VisualEditor does.
Would be very useful also for, e.g., https://www.mediawiki.org/wiki/Template:Extension#TemplateData (up to hook48!)
Hmm, I've messed up the JSON in the first example. Should be:

{{cite web
| authors = [{ "last": "Smith", "first": "John" }, { "last": "Doe", "first": "Jane" }]
}}

Perhaps this proves my point about users not being able to input JSON manually? :)
(In reply to Krinkle from comment #4)
> Especially now that we have Lua, specifying a parameter as taking a list
> seems more sensible (e.g. comma separated, line-break separated, whatever).
> Even if a template isn't converted to Lua yet, it could make use of a
> generic Lua module to do the string split and iteration.

This solution would be awkward when several parameters are related one to each other. For example, on the cite templates, you usually have several fields for each author (first name, last name, page link, ...) and they are easier to manage for a user if they are grouped.
With lists, users would have to be careful and to be sure that several lists are coherent between each other.
The foo1, foo2, foo3 etc. model exists in many templates, however in most cases the limit is quite low (when converted to Lua a user might have dropped the limit, no sure that is a good pattern). Only in cases where the value is for e.g. a table row do they have a high limit (up to 500 seems common).

e.g. 

{{Something
|row1=..
|row2=..
|row3=..
|=..

such as {{TemplateBox@commons.wikimedia.org
|p1=..
|p2=..
|p3=..
|..

However both for VisualEditor, TemplateData and any other modern program or programming language it is very visible that such dynamically named parameters are an unwanted pattern that should not be encouraged. It is hard to work with and only has downsides over alternatives (e.g. hard to re-order, requires hacks to implement in wikitext and lua, hard to document, hard to use).

Especially now that we have Lua, specifying a parameter as taking a list seems more sensible (e.g. comma separated, line-break separated, whatever). Even if a template isn't converted to Lua yet, it could make use of a generic Lua module to do the string split and iteration.

Also, in the interest of not implementing too soon and get stuck in a corner, I'd like to wait for VisualEditor to catch up with the features we've already recently added to TemplateData and see how those work out.
This proposal is based mostly on the idea that if TemplateData exists for a template, then editors should not be permitted to add any parameters that are not already in TemplateData.  

Rather than coding a variety of flexible naming/numbering schemes, it might make more sense to have a way to specify that a given template accepts (or does not accept) whatever parameters the editor chooses to name, regardless of what's in TemplateData.  If the TemplateData is complete and no unlisted parameters are useable, then editors could not add others.  If the TemplateData is incomplete, or if the number of parameters is unbounded, then editors could add whatever they wanted.
In the module code they use # to represent a number placeholder.
numbered_arguments = {
    ['author#'] = true,
    ['Author#'] = true,
    ['author-first#'] = true,
    ['author#-first'] = true,
    ['author-last#'] = true,
    ['author#-last'] = true,
...
}
As you can see the number can be in various places.

http://en.wikipedia.org/wiki/Module:Citation/CS1/Whitelist
When implemented, this should also accept an empty string as the "base" ("author" in original example above) to apply to unnamed (positional) parameters. Would be useful for some templates like [[pl:Template:Dopracować]] which currently can't be properly described using TemplateData.
I don't know if this is possible, or if it's been requested elsewhese, but a few users on the French-language Wikipedia have suggested that, when the user has scrolled through the page and invoked VisualEditor via the keyboard shortcut, VE should automatically scroll to that same position on the page when it opens (similarly to what the section edit link does).

--------------------------
**Version**: unspecified
**Severity**: enhancement
**See Also**:
https://bugzilla.wikimedia.org/show_bug.cgi?id=53217
The complication here is that while the VE view is similar to the read mode, it is not identical, so scrolling to the same pixel offset will not necessarily leave you at the same place. We could do an approximation by finding the nearest section heading and it's pixel offset from the top.
**misc2006** wrote:

This should always be the case, no matter how the editor is invoked. "User's position" when the editor is opened should be *exactly* the same as before. Use case: I want to fix a simple spelling error, so I click on the edit link on the paragraph. Often, the content has now scrolled up/down a bit and I need to find the location of the spelling error again. This is surprisingly difficult/annoying (just give it a try).
<< Icons can be useful to help a user navigate an interface, however in the transclusion dialog, the same box-shaped icon with the thick left border is shown so many times (when editing a template with more than a few parameters) that it is obnoxious. Almost every occurrence should be removed, keeping it displayed at at most one or two places.--[[User:Wouterstomp|WS]] ([[User talk:Wouterstomp|talk]]) 11:22, 6 August 2013 (UTC) >>

--------------------------
**Version**: unspecified
**Severity**: minor
**See Also**:
https://bugzilla.wikimedia.org/show_bug.cgi?id=49833
I disagree with this - the icon is used to identify which elements are parameters. Particularly in future they may be contrasted with sub-items such as images or sub-templates that are included in parameters but separately editable within the transclusion editor.
[15:52] <T13> VE Question.  How is VE currently set up to handle users that have opted-in to gadgets that modify the editing window such as wikEd?
...
[15:54] <T13> Do those gadgets still load even though the hooks they use don't exist? Shouldn't having VE enabled disable those gadgets and grey out the optiobs for them in the gadgets tab of preferences?
[15:56] <T13> I'm guessing some of the "VE" bugs are caused by these gadgets trying to do what they no longer can.
...
[16:06] <mooeypoo> T13: I think most of the edit-related gadgets work on the action=edit condition, and ve goes with action=vedit
[16:07] <mooeypoo> but I am not sure :) you'll be safer getting the answer from the VE team
[16:09] <MatmaRex> T13: i'm not on the team, but i'm pretty sure that's the reason
[16:10] <MatmaRex> T13: basically there are two ways to detect if we're inedit mode - either look if 'action' is 'edit' or 'submit', or look for some elements that are parts of theedit form, like #wpTextbox1 (the main textbox)
[16:10] <MatmaRex> VE avoids them both
[16:11] <T13> I've seen questions on WP:THQ with a link to a screenshot of wikEd and the user thinking they were using VE.  So, I was curious how it was handled.
[16:11] <T13> I'll add the suggestion to gray out the unusable with VE gadgets 
[16:11] <mooeypoo> Ah, *that* kind of user errors. Hm. Not sure how you can handle those other than politely correct the user's false assumption
[16:11] <T13> On Bugzilla...

--------------------------
**Version**: unspecified
**Severity**: enhancement
Hmm. Not totally convinced by this - (a) because this is inherently transitional as gadgets are updated to work with VisualEditor, and (b) because disabling gadgets that work fine, just not in all places, seems a bit unfair. Re-titling and moving to the Gadgets pile, however.
Working links:

https://commons.wikimedia.org/wiki/File:Special_Preferences_mw-prefsection-gadgets_(current).png

https://commons.wikimedia.org/wiki/File:Special_Preferences_mw-prefsection-gadgets_(proposed).png
(In reply to comment #1)
> Not sure what the bug is, here?
> 
> Gadgets can be written to work with VisualEditor, but gadgets not written to
> do so won't work, and dated (and so now misleading) advertising on behalf of
> these gadgets that it works with "the editor" will confuse people.
> 
> As normal, gadget authors and maintainers should make sure that they re-label
> their gadgets to avoid this confusion.
> 
> Or am I missing something?

I'm sorry James, I missed your question.  I've uploaded a couple screenshots of what I'm thinking (although I'm thinking this may require a change in the gadgets extension first on second thought).

Currently, the "Editing" section of the gadgets tab on enwp looks like:
   [[commons:File:Special_Preferences_mw-prefsection-gadgets_%28current%29.png]]

What I'm proposing, is that when VisualEditor is active for the user, it should look like:
   [[commons:File:Special_Preferences_mw-prefsection-gadgets_%28proposed%29.png]]

With the options for things like dot's highlighter and wikiEd grayed out so they can't be clicked (and defaulted to off).
Closing as INVALID as no response after 3 weeks (but happy to reconsider if I've mis-understood).
Not sure what the bug is, here?

Gadgets can be written to work with VisualEditor, but gadgets not written to do so won't work, and dated (and so now misleading) advertising on behalf of these gadgets that it works with "the editor" will confuse people.

As normal, gadget authors and maintainers should make sure that they re-label their gadgets to avoid this confusion.

Or am I missing something?
**Author:** `mcdevitd`

**Description:**
Typically, the expected behavior from hitting backspace at the beginning of a list line is to remove the bullet/number at that indent level so it is no longer a list, and no more. VisualEditor will completely delete the line itself and move the text to the end of the previous line. This is not how OpenOffice or Word works.
Agreed. For

| <ol><li><p>|</p></li><li><p>Foo</p></li></ol>

… backspace at the cursor position indicated should convert the document into:

| <p>|</p><ol><li><p>Foo</p></li></ol>

… with the initial <p> being a slug.

For nested list items we should pop to the next level:

| <ol><li><p>Foo</p></li><li><ol><li><p>|</p></li><li><p>Foo</p></li></ol></li></ol>

->


| <ol><li><p>Foo</p></li><li><p>|</p></li><li><ol><li><p>Foo</p></li></ol></li></ol>

I think?
**Author:** `mcdevitd`

**Description:**
The expected behavior in most word processors (Word and OpenOffice) is that the user can unindent (shift-tab) only to get to the initial list indent level but it should not actually delete the bulleting/numbering itself when you to the end. In VisualEditor, unindenting once too many times can remove the initial bullet/number entirely.

This becomes particularly annoying when (because of the behavior described in bug 48051) you accidentally split a list into two lists which can't be fixed clicking the list button again to re-add the bullet/number.

--------------------------
**Version**: unspecified
**Severity**: enhancement
(Still valid in current VE; is this really normal priority?)
*** Bug 56344 has been marked as a duplicate of this bug. ***
**mcdevitd** wrote:

(In reply to comment #1)
> (In reply to comment #0)
> 
> > This becomes particularly annoying when (because of the behavior described in
> > bug 48051) you accidentally split a list into two lists which can't be fixed
> > clicking the list button again to re-add the bullet/number.
> 
> "Undo" fixes that instantly, of course.

I wasn't trying to say that it is unfixable. I was just pointing out that the current list behavior means that the way most(?) people might naturally try to correct losing their bulleting/numbering would only compound the error. ("Undo" fixes almost anything, of course, except frustration and time wasted.)
(In reply to comment #0)
> The expected behavior in most word processors (Word and OpenOffice) is that
> the user can unindent (shift-tab) only to get to the initial list indent
> level but it should not actually delete the bulleting/numbering itself when
> you to the end. In VisualEditor, unindenting once too many times can remove
> the initial bullet/number entirely.

This was a deliberate choice, though I can't remember why (it was over a year ago that this was implemented). We should reconsider.

> This becomes particularly annoying when (because of the behavior described in
> bug 48051) you accidentally split a list into two lists which can't be fixed
> clicking the list button again to re-add the bullet/number.

"Undo" fixes that instantly, of course.
Users are requesting VE August update (https://en.wikipedia.org/wiki/Wikipedia:VisualEditor/August_2013_update) to be deployed in on hewiki.

--------------------------
**Version**: wmf-deployment
**Severity**: normal
**URL**: https://he.wikipedia.org/wiki/%D7%A9%D7%99%D7%97%D7%AA_%D7%9E%D7%A9%D7%AA%D7%9E%D7%A9:%D7%A2%D7%A8%D7%9F#.D7.A9.D7.99.D7.A0.D7.95.D7.99_.D7.91.D7.9E.D7.99.D7.A7.D7.95.D7.9D_.D7.94.D7.A7.D7.99.D7.A9.D7.95.D7.A8_.22.D7.A2.D7.A8.D7.99.D7.9B.D7.94_.D7.91.D7.A7.D7.95.D7.93_.D7.9E.D7.A7.D7.95.D7.A8.22_-_.D7.9B.D7.9E.D7.95_.D7.91.D7.95.D7.95.D7.99.D7.A7.D7.99.D7.A4.D7.93.D7.99.D7.94_.D7.94.D7.90.D7.A0.D7.92.D7.9C.D7.99.D7.AA
Finally done; sorry for the delay.
Change 87645 merged by Reedy:
Switch VisualEditor to secondary status on hewiki

https://gerrit.wikimedia.org/r/87645
(In reply to comment #14)
> Change 87645 had a related patch set uploaded by Jforrester:
> Switch VisualEditor to secondary status on hewiki
> 
> https://gerrit.wikimedia.org/r/87645

Will try to schedule this soon.
Change 87645 had a related patch set uploaded by Jforrester:
Switch VisualEditor to secondary status on hewiki

https://gerrit.wikimedia.org/r/87645
Thanks for adding the welcome message. 

I know there are discussions regarding these changes[1], but the change of the tab order (Edit and Edit source) is important for he wikipedia and Erik isn't totally against it [only ambivalent] :)

Since VE is enabled only in the main NS and user NS, for editors who also edit in other namespaces, addition of the VE edit tab "in the middle" may cause confusion. For consistency the edit source option should be alway the first option [in order], while VE edit should be second.

----
[1] http://lists.wikimedia.org/pipermail/wikitech-ambassadors/2013-September/000419.html
Change 77269 merged by jenkins-bot:
Enable VisualEditor beta welcome notice for all wikis

https://gerrit.wikimedia.org/r/77269
[Sorry for the delay in responding.]

The beta welcome message is now queued up to go out on all wikis with the next release when available.

We're still not decided on the way forward for the edit source/edit labelling split, so this is delayed until we have a proper answer. Sorry.
We are now in September so enough time have passed since August change, and the community have voted for deploying the changes. Please let us know when this change is planned for deployment.
There is is large support for the change in the village pump. 

https://he.wikipedia.org/w/index.php?title=%D7%95%D7%99%D7%A7%D7%99%D7%A4%D7%93%D7%99%D7%94:%D7%9E%D7%96%D7%A0%D7%95%D7%9F&oldid=14551521#.D7.94.D7.97.D7.9C.D7.A4.D7.AA_.D7.9E.D7.99.D7.A7.D7.95.D7.9D_.D7.94.D7.A7.D7.99.D7.A9.D7.95.D7.A8_.22.D7.A2.D7.A8.D7.99.D7.9B.D7.94_.D7.91.D7.A7.D7.95.D7.93_.D7.9E.D7.A7.D7.95.D7.A8.22_.D7.A2.D7.9D_.D7.9E.D7.99.D7.A7.D7.95.D7.9D_.D7.A7.D7.99.D7.A9.D7.95.D7.A8_.22.D7.A2.D7.A8.D7.99.D7.9B.D7.94.22_-_.D7.9B.D7.9E.D7.95_.D7.91.D7.95.D7.95.D7.99.D7.A7.D7.99.D7.A4.D7.93.D7.99.D7.94_.D7.94.D7.90.D7.A0.D7.92.D7.9C.D7.99.D7.AA
All of these
Hey,

Which of the bits of the update do you mean?

1. The re-ordered tabs and section edit links, so that the VE tab is second?
2. Giving a welcome message when you open VisualEditor for the first time?
3. Adding "beta" as a suffix after the VisualEditor tab and section edit link?
4. Changing "edit" to "edit source" on non-VisualEditor pages for consistency?
5. Removing the animation on section edit links?

All of these? Items 4 and 5 are already done.
is there any progress with the request?
Gerrit change 77269 will handle part of this. They were just waiting on translations of the messages before enabling it.
added in the url field.
(In reply to comment #0)
> Users are requesting VE August update
> (https://en.wikipedia.org/wiki/Wikipedia:VisualEditor/August_2013_update) to
> be deployed in on hewiki.

Please provide a link to these requests, if possible.
Please mark the targeted milestone when it is known. Thanks
Slightly related to bug 51322 

Take the Link FA templates on https://en.wikipedia.org/wiki/The_Adventures_of_Tintin?veaction=edit for instance. 

These produce empty elements, and don't qualify under 'solely metadata' of bug 51322, even though they are somewhat similar to it.

The templates are represented with the char: ↵﻿
Using the arrow keys to cursor trough this sequence will sometimes produce the template editor indicator. However their is little identifying these templates to the user and due to the interspersed ↵﻿, users think they should be deleted.

--------------------------
**Version**: unspecified
**Severity**: normal
Merging with bug 49806 (though non-transclusion empty HTML blocks do happen too).

*** This bug has been marked as a duplicate of bug 49806 ***
(In reply to comment #0)
> The templates are represented with the char: ↵﻿

Actually, that's representing the meaningless wikitext of the newline after the template.
From http://en.wikipedia.org/wiki/Wikipedia:VisualEditor/Feedback#Quote_box

In the adventures of tintin 
http://en.wikipedia.org/wiki/The_Adventures_of_Tintin?veaction=edit

the first {{quote box}} has been pushed down by the info box. The transclusion icon for this appears appear where the quote box was initially (just below the History section header on the right hand side) not where it actually appears.

--------------------------
**Version**: unspecified
**Severity**: normal
**See Also**:
https://bugzilla.wikimedia.org/show_bug.cgi?id=51548
Hello, we at Russian Wikipedia had **months** of interwiki gadgets not working for some users, because at first `compact-language-links` user option was set to `""` when switched off, but after some change switching it on and off turns it to `"0"`. (Was finally fixed [[https://ru.wikipedia.org/w/index.php?title=MediaWiki:Interwiki-links.js&diff=81404746&oldid=79892976|here]].) Those who switched the option off after that change had gadget not working, but the project engineers weren't able to reproduce. Other wikis which had borrowed code from us had the issue too, and they most probably won't update the code.

I have no idea why this task's priority is set to "Low". I don't know the site policy regarding changing priorities, I will try change to "Normal" at least, maybe needs "High".
Hello, we at Russian Wikipedia had **months** of interwiki gadgets not working for some users, because at first `compact-language-links` user option was set to `""` when switched off, but after some change switching it on and off turns it to `"0"`. (Was finally fixed [[https://ru.wikipedia.org/w/index.php?title=MediaWiki:Interwiki-links.js&diff=81404746&oldid=79892976|here]].) Those who switched the option off after that change had gadget not working, but the project engineers weren't able to reproduce. Other wikis which borrowed code from us had the issue too, and they most probably won't update the code.

I have no idea why this task's priority is set to "Low". I don't know the site policy regarding changing priorities, I will try change to "Normal" at least, maybe needs "High".
Preferences has a filter for some values. The search preferences, for example, are normalised to booleans. A few other are casted to integers.

However the filters are only applied on the in to the database. On the way out they become strings regardless and nothing takes care of that.

So aside from the filters not being available to extension-provided preferences (it's a hardcoded privilege for core's own handling), even for the core ones, there's no normalisation on the way out:

```
rclimit: 50
rows: "30"
searchNs0: true
searchNs1: false
..
searchNs10: "1"
searchNs11: false
searchNs12: false
searchNs13: false
searchNs14: "1"
```

Quite the mix up.

Few thoughts: Applying it on the way out would be a good start. Though it's not a a great system to use for extensions. We could extend the preference descriptor array with a `kind` property (for int, bool or str). Or perhaps something we can derive from the `type` property (for HTMLForm field type). Though the latter is extendable so we'd need to put it in the HTMLFormField class instead of simply having Preferences map the shortcuts to native types.
I have had similar difficulties and personally prefer booleans wherever possible.  They're more reliable and less likely to be unpredictable.  They are either true or false or they're invalid.
(In reply to Bartosz Dziewoński from comment #1)
> ...
> normalizing values of boolean prefs to true/false just before building this
> list (in ResourceLoaderUserOptionsModule#getScript) seems like the best way.

+1 for normalizing boolean preferences so that either
> `mw.user.options.get( 'anyBooleanPreference' ) === true`
> `mw.user.options.get( 'anyBooleanPreference' ) === false`
and nothing else.

The current behavior is ***very*** inconvenient:
* If I do not set `$wgDefaultUserOptions['usebetatoolbar']`
(i.e., if I use WikiEditor's default):
  - If I don't change the preference
    `mw.user.options.get( 'usebetatoolbar' ) === null`
  - If I enable the preference
    `mw.user.options.get( 'usebetatoolbar' ) === "1"`
* If I set `$wgDefaultUserOptions['usebetatoolbar'] = 1` (as in WMF cluster[1]):
  - If I don't change the preference
    `mw.user.options.get( 'usebetatoolbar' ) === 1`
  - If I disable the preference
    `mw.user.options.get( 'usebetatoolbar' ) === "0"` (non-empty string == true!)
* On English Wikipedia
  - If I don't change the preference
    `mw.user.options.get( 'usebetatoolbar' ) === 1`
  - If I disable the preference
    `mw.user.options.get( 'usebetatoolbar' ) === ""` (empty string!)

[1] https://github.com/wikimedia/operations-mediawiki-config/blob/8178a4994c0137f5171798f3e831c0492c8cbc06/wmf-config/CommonSettings.php#L1641
(In reply to Bartosz Dziewoński from comment #1)
> ...
> normalizing values of boolean prefs to true/false just before building this
> list (in ResourceLoaderUserOptionsModule#getScript) seems like the best way.

+1 for normalizing boolean preferences so that either
> mw.user.options.get( 'anyBooleanPreference' ) === true
> mw.user.options.get( 'anyBooleanPreference' ) === false
and nothing else.

The current behavior is ***very*** inconvenient:
* If I do not set $wgDefaultUserOptions['usebetatoolbar']
(i.e., if I use WikiEditor's default):
  - If I don't change the preference
    mw.user.options.get( 'usebetatoolbar' ) === null
  - If I enable the preference
    mw.user.options.get( 'usebetatoolbar' ) === "1"
* If I set $wgDefaultUserOptions['usebetatoolbar'] = 1 (as in WMF cluster[1]):
  - If I don't change the preference
    mw.user.options.get( 'usebetatoolbar' ) === 1
  - If I disable the preference
    mw.user.options.get( 'usebetatoolbar' ) === "0" (non-empty string == true!)
* On English Wikipedia
  - If I don't change the preference
    mw.user.options.get( 'usebetatoolbar' ) === 1
  - If I disable the preference
    mw.user.options.get( 'usebetatoolbar' ) === "" (empty string!)

[1] https://github.com/wikimedia/operations-mediawiki-config/blob/8178a4994c0137f5171798f3e831c0492c8cbc06/wmf-config/CommonSettings.php#L1641
The integer came from $wgDefaultSettings. Set it to string there and it should work, except gadget and maybe the searchNs, because that are dynamically preferences, where the default is not stored in $wgDefaultSettings.
Values that are actually saved in the database (ie, non-default ones) are always strings, and apparently usually equal to "1" (but for boolean prefs any truthy value is technically possible, especially if one uses the API to set them).

Values that are default ones are equal to whatever the programmer decided, and as you can see they might be 1/0, true/false, "1"/"0" or null. You should just check for truthiness in this case.

I'm not sure how to solve this, or whether we actually want to solve this; normalizing values of boolean prefs to true/false just before building this list (in ResourceLoaderUserOptionsModule#getScript) seems like the best way.
when saving, there is possibility to check the result visually. allow to edit it.

--------------------------
**Version**: unspecified
**Severity**: enhancement
**See Also**:
{T52687}
(In reply to comment #2)
> agreed, james, that would be desireable. but is for sure a very different
> feature not at all helping out when the diff reveals visual editor did
> something unexpected.
It does actually help: you can close the save dialog and switch to source mode, but this is not very discoverable.

Maybe we should consider adding a button to the diff preview that sends you straight to source mode?
agreed, james, that would be desireable. but is for sure a very different feature not at all helping out when the diff reveals visual editor did something unexpected.
This is an interesting idea, but I think bug 50687 (with a button to switch to the wikitext editor) is probably more discoverable and more useful for some situations.
Greg also reproduced this.  He sees a superscript, but I have an additional issue, that the beta is roughly the same horizontal position.

--------------------------
**Version**: unspecified
**Severity**: normal
*** Bug 71651 has been marked as a duplicate of this bug. ***
Upstream bug has been marked as fixed since 2014-06-19 15:05:07 (for FF33 - currently in Aurora, which seems to be fixed to me), marking this as fixed as well.
Seems to be already reported as https://bugzilla.mozilla.org/show_bug.cgi?id=727125
Filed as https://bugzilla.mozilla.org/show_bug.cgi?id=1009874
Firefox-specific rendering bug.
Created attachment 13057
Screenshot of beta with overline

This is from a few hours ago on enwiki.  It is reproducible (try a fresh account on enwiki), almost 100% of the time (one load seemed not to do it).

**Attached**: {F11270}
en.wp user Andrew Gray notes that on creating a page in VE he is given several alternatives to writing a new article, one of which is to search for an existing page to redirect the title to. He asks whether this should be offered to VE users while it does not support redirects.

However, the message is provided by [[MediaWiki:Newarticletext]] and the text is served identically in the source and visual editors. There is no current mechanism to detect in which editor it is being displayed so different content cannot be provided.

There will be occasions where such messages and also edit notices are only relevant to either source or visual editor users or are differently relevant. In other cases the different display formats (e.g. generally horizontal in source, generally vertical in visual) may lead to different presentation choices for optimum impact.

As it is not inconceivable that there will in future be other editors (developed by WMF or others) there should be some way for the editor to uniquely declare itself to such messages and for them to be able to determine what they do if they don't recognise the response. Sort of a:
IF editor="VisualEditor" THEN do X ELSE do Y

--------------------------
**Version**: unspecified
**Severity**: enhancement
I don't think there should be a control for separate interface messages.

However either way, meanwhile a workaround is to use a CSS selector (.ve-available or .ve-not-available) to hide or display certain pieces.
Yes, that does sound far simpler to implement! More difficult to keep the two in synch, but I suppose you can't have everything.
One possible way to do this is using a different interface message for VE in such cases. MediaWiki:Newarticletext-VE for example.

This looks apparently more simple to do than creating yet another programming language to control such logic on the message itself ;)
What it says on the tin: The transclusion editor should have a "cancel" button next to "Apply changes". This would close the editor without saving any changes.
Possibly it should require a confirmation if one or more templates have been selected.

--------------------------
**Version**: unspecified
**Severity**: enhancement
**See Also**:
https://bugzilla.wikimedia.org/show_bug.cgi?id=52386
(In reply to John Broughton from comment #8)
> If in fact the link tool and the Formula window are outside the scope of this>
> bug, feel free to close the bug

They are. This bug is about dialogs.

Design questions about non-dialogs is a distinct question – raising another ticket is probably a good idea if you think they should be changed.
As noted previously, there no "Cancel" button on the link tool (dialog? insert window?). Also, there is no "Cancel" button on the Formula dialog (insert window?). 

I'm reopening this bug because otherwise - in "Resolved" status - this bug is much more likely to be ignored. If in fact the link tool and the Formula window are outside the scope of this bug, feel free to close the bug - then we'll know that we need to open a new, separate bug to address those two issues.
There is still no "Cancel" button on the link tool.
This was done as part of the window redesign work.
A user at en.wp has reported that they were unaware that the ^ button on the save page dialog would return them to the article. Consequently they were under the impression that the only options were to preview the changes, save the changes or abort the edit, i.e. there was no way to go back and make addition changes or fix ones they had already made.

A cancel button as discussed in this bug would solve this, although I think labelling it something like "return to editing" would be better than "cancel" here (which could imply discarding the edit).
I think a cancel button makes perfect sense from a UX point of view for dialogs.

Closing would be an alias of cancel, but that's not the primary flow for a user.

Closing windows is always a bit of awkward and uncertain action to take.
(In reply to comment #2)
> Yes, I've seen it mentioned a couple  of times that people aren't sure what
> state clicking the "X" will leave things in. Will it cancel everything
> they've done, cancel only unfinished/unapplied changes, or close with
> everything in its current state finished or not.

* A "rubbish bin" icon (on lightweight inspectors, but not dialogs) is Option 1.
* An "X" icon (on dialogs, but not inspectors) is Option 2.
* The "apply changes" button (on dialogs, but not inspectors) is Option 3.

Clearly this isn't "obvious" enough; we should consider what more we can do.
Yes, I've seen it mentioned a couple  of times that people aren't sure what state clicking the "X" will leave things in. Will it cancel everything they've done, cancel only unfinished/unapplied changes, or close with everything in its current state finished or not.
This functionality is currently provided by the "X" in the top-right corner (as for all dialogs). Is a duplicate button needed?
User:Wouterstomp at en.wp suggests that in the media selection dialog, the full name of an image should be shown in a tooltip when you hover over it. Either for all images or only those whose name is too long to be shown in full beneath the image.

--------------------------
**Version**: unspecified
**Severity**: enhancement
Checked in betalabs.
Change 183729 merged by jenkins-bot:
Add filename to the media dialog

[[https://gerrit.wikimedia.org/r/183729]]
Change 183729 had a related patch set uploaded (by Mooeypoo):
Add filename to the media dialog

[[https://gerrit.wikimedia.org/r/183729]]

#patch-for-review
Or not.
Since no one disagrees, I'm going to make that happen.
I think a better place to display the name would be in the "Media settings" dialog. Right now, when inserting an image, you don't even know what you're inserting (neither a file name nor a thumbnail is shown in the dialog).

That would also provide a better place for the "Choose a different image" button, which is now awkwardly placed in the bottom-left corner.
This would be nice for desktop users, but not so good for mobile (tablet/phone) users who are using touch to navigate. Maybe something else for them, like displaying the details of the file on a page before inserting?
en.wp editor GermanJoe suggests that if you try to add a template not in the transclusion editor's list of known templates that it should give a warning or "are you sure?" message.

Such a message would note that very new templates might not appear in he list.

--------------------------
**Version**: unspecified
**Severity**: enhancement
(In reply to Alex Monk from comment #2)
> Unknown template = template with no TemplateData?

(In reply to Alex Monk from comment #3)
> Non-existent?

It means "the API didn't claim to know about it existing". Given MediaWiki's… awkwardness about knowing whether or not a page actually exists I didn't want to assume something when I wrote it. :-)
See comment #1?
Non-existent?
Unknown template = template with no TemplateData?
This feels like it could be a bit irritating as a modal alert, but maybe we could come up with something as effective whilst less in-your-face.
Currently the the transclusion editor's list of templates includes /Doc and other subpages of templates that are not themselves actual templates.

At https://en.wikipedia.org/wiki/Wikipedia:VisualEditor/Feedback/Archive_2013_2#Removing_template_subpages_from_the_template_selection_list.3F there was a discussion about this which suggested possible ways forward:
* Exclude all subpages except those explicitly marked as templates, e.g by magic word or category
* Include all subpages except those explicitly marked as not being templates, e.g. by magic word or category

See also:
* {T52512}
* {T58516}
>>! In T54448#1991488, @maiden_taiwan wrote:
> Suggestion: allow the wiki administrator to designate a particular subpage string, such as `doc`, as the official place to keep TemplateData. Then VisualEditor can intelligently and unambiguously filter these pages out. See T125222.

This one could work! On pt-wiki we use "doc" as the documentation subpage and "dados" as the TemplateData. Maybe blacklisting both of them could help VisualEditor interpreting them as **not** templates to be transcluded. 
I don't think that //"excluding all subpages except those explicitly marked as templates"// would be a good idea, because there are plenty of templates (Info/Patologia, Info/Grupo étnico, Info/Facção de conflito etc.) located on subpages.
Suggestion: allow the wiki administrator to designate a particular subpage string, such as `doc`, as the official place to keep TemplateData. Then VisualEditor can intelligently and unambiguously filter these pages out. See T125222.
Another option: instead of filtering, use sorting by usage (group by on templatelinks) instead of alphabetic sorting.
I think we have simple way to filter out subpages of templates.
I was able to produce a reference labelled "0" in the VisualEditor using the following steps:

1. Create a simple page with some text and a reference. (I've made an example at [[User:Mr. Stradivarius/ref0]].)
2. Copy and paste the reference to somewhere else in the page.
3. Delete the reference from the text that has just been copied and pasted.
4. The first reference is automatically renumbered to "0".

The numbering of the first is fixed (back to "1") if you delete the line of text that you were on, but if you add new lines of text the first reference remains laballed "0" even if the pasted line is subsequently removed. The numbering still starts at 0 if you add another reference, so you get ref "0", ref "1", etc.

This is on Firefox 22.

--------------------------
**Version**: unspecified
**Severity**: normal
Confirming that this bug is now fixed, almost certainly in the re-write of copy-and-paste for nodes that happened for the 5 September release. Apologies for the slow triage at my end.
Also, this is just in the editing window. When the page is saved, the numbering returns to normal.
When the first line of an article is a hatnote template that generates exactly 1 line of text in the visual editor, pressing down twice takes you to the end of the article. When the hatnote template generates more than one line then pressing down takes you to the end of the first line but no further.

I have been unable to reproduce this with templates other than hatnotes. 

Steps to reproduce (short hatnote):
1. Load a page with a short hatnote in VE, e.g. [[Laurence of Canterbury]]
2. Press the down cursor twice

Expected behaviour: you end up on the third line of the page
Actual behaviour: you end up on the last line of the page

Steps to reproduce (long hatnote):
1. Load a page with a long hatnote in VE, e.g. [[An American in Paris]]
2. Press the down cursor three or more times.

Expected behaviour: you end up on the third or fourth etc. line of the page
Actual behaviour: you end up at the end of the first line of the hatnote.

Sandbox pages to test:
Long hatnote: https://en.wikipedia.org/w/index.php?title=User:Thryduulf/sandbox&oldid=566827194&veaction=edit
Short hatnote: https://en.wikipedia.org/w/index.php?title=User:Thryduulf/sandbox2&oldid=566827110&veaction=edit

This might be related to bug 51708

--------------------------
**Version**: unspecified
**Severity**: normal
**See Also**:
https://bugzilla.wikimedia.org/show_bug.cgi?id=51708
Have tested this again, and I believe we have fixed this bug as reported, as part of the re-writing of how ContentEditable reacts to cursor events. However, I think I've found another bug semi-related, so will open that.
My testing was in Monobook in Firefox 22 on Linux.
The original reporter was using Monobook in Firefox 22 on Windows 7.
Rybec comments that they can reproduce it in some pages (e.g. my sandbox) but not others (e.g. [[Laurence of Canterbury]]) using Firefox ESR on Linux.

It's starting to look like it might be a Firefox-only bug.
I have been unable to reproduce this at all on all of the linked pages, with both Monobook and Vector on Chrome, Win7.
Flagged Revisions provides a number of edit notices about the status of the page being edited, but this one (about the status of the transcluded components thereof) isn't. This feels wrong. It also means VisualEditor can't warn people about it.

--------------------------
**Version**: master
**Severity**: normal
**See Also**:
https://bugzilla.wikimedia.org/show_bug.cgi?id=52280
Screenshot of problem

When the link inspector is fairly tall and the space somewhat narrow (e.g. a red link, 10 suggestions in the inspector, and the link itself is towards the bottom of the screen), the box will expand further than the page goes (triggering a scrollbar if needed).

That's fine, except that it is hard to see for the user whether there is more or not. Especially with OSX hiding scroll bars by default.

There should be some bottom margin so that it can be clearly seen that the bottom of the list is the bottom, ans eparated from the bottom of the (now expanded) page.

See attached screenshot.

--------------------------
**Version**: unspecified
**Severity**: minor

**Attached**: {F11124}
We have similar logic in the dropdown menus and dialogs already. They never touch the bottom of the window.. No Touching!
Pressing enter at the end of a colon indented line and typing more text displays as an indented, but, on save, (and review changes) the colon has not been added to the new line.

Steps to reproduce:

0. Start with a simple colon indented section. (See here: http://en.wikipedia.org/w/index.php?title=User:Markhurd/Sandbox&oldid=566721115 )
1. Edit with VE.
2. Click at end of last indented line.
3. Press Enter. Note this displays as continuing the indentation.
4. Type some text.
5. Save. Note that the colon is not included. (You can see it missing with Show Changes.)

My diff: http://en.wikipedia.org/w/index.php?title=User:Markhurd/Sandbox&diff=566721183&oldid=566721115

--------------------------
**Version**: unspecified
**Severity**: normal
This does seem to be fixed: https://en.wikipedia.org/w/index.php?title=User:Markhurd/Sandbox&diff=662749142&oldid=646642979
Created attachment 13202
VE shows the new text as indented, but it isn't

I've just reproduced this in Firefox 23/Linux/Monobook. The screenshot shows how VE displayed it, the dif showing what was actually saved is: https://en.wikipedia.org/w/index.php?title=User%3AThryduulf%2Fsandbox&diff=570859913&oldid=570858997

The trailing blank lines are bug 50995, and this may be an artefact of the same bug as the displayed blank lines do not exist in the source.

**Attached**: {F11963}
It isn't obvious to all users that clicking on the warning about Wikitext will make it disappear.

For example, PamD at en.wp said:
"I edited an article and found I'd got the popup saying I'd been using wiki markup, I should go into Edit Source, my edits wouldn't be saved, etc. I knew I'd input a pair of ''s at one time but had then remembered the error of my ways, removed them, and marked the title as italic in VE style, so was pretty confident I hadn't used any wiki markup and went ahead and saved the edit (difficult because the popup was sitting on top of the savepage box)."

The main issue there is Bug 52155, but after being pointed to that bug she replied:

"so if I'd clicked on the box it would have gone away... ? Not obvious!"

It would be good to add an X in the upper right corner to indicate that it can be closed. This wouldn't change the behaviour that clicking anywhere on the box dismisses it, just give a visual indication that it can be done.

--------------------------
**Version**: unspecified
**Severity**: enhancement
**See Also**:
https://bugzilla.wikimedia.org/show_bug.cgi?id=51701
https://bugzilla.wikimedia.org/show_bug.cgi?id=52462
Change 87034 merged by jenkins-bot:
Toolbar action widgetization and UI refactoring

https://gerrit.wikimedia.org/r/87034
Change 87034 had a related patch set uploaded by Jforrester:
Toolbar action widgetization and UI refactoring

https://gerrit.wikimedia.org/r/87034
Rephrased bug to not mention "wikitext message". Instead focussing on notices that pop out of the toolbar, which are indeed created by VisualEditor.
These alerts are rendered by a MediaWiki core interface. VisualEditor just calls mw.notify. It does not and should not be modifying those alerts by other means.

Please file a bug in core for this (or move/depends-on this bug).
en.wp user Mark M comments re the wikitext warning:
"It wasn't obvious to me how to get rid of the notice. In fact, it popped up and partially cover the "save" button in such a way that when I tried to click save, nothing happened, and the notice was still there! For a few seconds I thought I wouldn't be able to save my changes at all, even though I'd removed the wikitext. Fortunately I kept clicking nearby (in frustration) and the notice disappeared. But I would have been helped if there had simply been a "dismiss" button, or something similar, that indicates you should click on it to dismiss it. This wasn't obvious to me."
There have been two independent requests for this today on en.wp (one reporting an issue on he.wp).

It was also noted that the close indication should be applied to edit notice popus too.
In some cases it seems that <references /> is not fully populating the references list while {{reflist}} does.
Example at: At https://en.wikipedia.org/w/index.php?title=Christian_Scott&oldid=566681769

--------------------------
**Version**: unspecified
**Severity**: normal
**See Also**:
https://bugzilla.wikimedia.org/show_bug.cgi?id=50094
Both lists have the same references for me. Please re-open if you think there is still a problem.
Hi Chris, what I see there is the entire section being duplicate, in both view and edit mode. I am probably missing something :)
Not a duplicate, AFAICT.
%%%*** This bug has been marked as a duplicate of bug 50094 ***%%%
Random idea that might improve load performance: initially alienate the entire document, then progressively convert and dealienate it. This should bring the editor into view quickly and allow the first paragraph to be edited quickly while the rest of the page is still processing.

Possible pitfall: reference numbering and other crazy stuff in MWReferenceNode

See {T76544} for the same idea, but for content blocks.
en.wp user Cryptic C62 comments:
"Take a look at the text this page. The first two sentences may appear to be identical. If one activates VE, one will find that the first sentence (which employs <tt>) cannot be edited, but the second one (which employs <code>) can. My question is this: If the editor is supposed to be visually intuitive, why are two (almost) visually identical elements handled differently? "

The page referred to is: https://en.wikipedia.org/w/index.php?title=User:Cryptic_C62/sandbox&oldid=566625027

--------------------------
**Version**: unspecified
**Severity**: enhancement
Change 77389 merged by jenkins-bot:
Handle <tt> as textStyle/code

https://gerrit.wikimedia.org/r/77389
Change 77389 had a related patch set uploaded by Esanders:
Handle <tt> as textStyle/code

https://gerrit.wikimedia.org/r/77389
It is possible to insert a substituted template (by just putting in "subst:whatever" as its name). This will be saved correctly (substituted), but the diff shown in the review dialog shows the non-substituted wikitext.

--------------------------
**Version**: unspecified
**Severity**: minor
**See Also**:
https://bugzilla.wikimedia.org/show_bug.cgi?id=53201
Change 129251 merged by jenkins-bot:
Apply PST when generating diff

https://gerrit.wikimedia.org/r/129251
Change 129251 had a related patch set uploaded by Alex Monk:
Apply PST when generating diff

https://gerrit.wikimedia.org/r/129251
VE's API "diff" option instantiates its own DifferenceEngine but fails to set the PST option.
Marking as "minor" as we don't provide a built-in way for subst: to be added (yet) to transclusion invocations.
Sorry, my bad. I forgot I was using custom JS to generate diffs.
No, it shows the substituted code.
Isn't this how normal diffs work? If I replace the sandbox with {{subst:test}}, it just shows the addition of the text "{{subst:test}}" when you hit show changes.
en.wp user User:Timwi reports

"On the page [[Earth]], we had the following markup code:

[[File:(filename)|thumb|700px|center| (caption here) |alt= (alt text here) ]]

The VisualEditor parsed this incorrectly and assumed that “alt= (alt text here)” was the ''caption''.

Changing the order of the items fixed this despite having no effect on the rendered page, which indicates that it’s a bug in VisualEditor and not incorrect MediaWiki markup." http://en.wikipedia.org/w/index.php?title=Earth&diff=566614668&oldid=566595613 

I've done some testing in my sandbox and it seems like the issue is somehow related to the presence of the {{val}} template. I wasn't able to replicate the bug with the {{small}} or {{convert}} templates for example, but I've not done extensive testing with the latter or with any other template.

https://en.wikipedia.org/w/index.php?title=User:Thryduulf/sandbox&oldid=566618437&veaction=edit

--------------------------
**Version**: unspecified
**Severity**: normal
**URL**: http://parsoid-lb.eqiad.wikimedia.org/enwiki/User:Thryduulf/sandbox?oldid=566618437
Done now. Will be deployed tomorrow after a round of RT-testing. Can be reopened, if necessary.
Change 197120 merged by jenkins-bot:
T54341: Recover content from non-string tokens for img option alt

[[https://gerrit.wikimedia.org/r/197120]]
Change 197120 had a related patch set uploaded (by Subramanya Sastry):
WIP: T54341: Recover content from non-string tokens for img option alt

[[https://gerrit.wikimedia.org/r/197120]]
This is a difference in how links are handled in alt-attributes, and nothing to do with templates.
```
[subbu@earth tests] echo '[[File:Foo.jpg|thumb|Caption here|alt=Foo ]]' | node parse --fetchConfig false --normalize=parsoid
<figure class="mw-default-size" typeof="mw:Image/Thumb"><a href="File:Foo.jpg"><img alt="Foo" resource="./File:Foo.jpg" src="//upload.wikimedia.org/wikipedia/commons/0/06/Foo.jpg" height="144" width="220"/></a><figcaption>Caption here</figcaption></figure>

[subbu@earth tests] echo '[[File:Foo.jpg|thumb|Caption here|alt=[[Foo]] ]]' | node parse --fetchConfig false --normalize=parsoid
<figure class="mw-default-size" typeof="mw:Image/Thumb"><a href="File:Foo.jpg"><img resource="./File:Foo.jpg" src="//upload.wikimedia.org/wikipedia/commons/0/06/Foo.jpg" height="144" width="220"/></a><figcaption>alt=<a rel="mw:WikiLink" href="Foo" title="Foo">Foo</a> </figcaption></figure>

[subbu@earth tests] echo '[[File:Foo.jpg|thumb|Caption here|alt={{echo|[[Foo]]}} ]]' | node parse --fetchConfig false --normalize=parsoid
<figure class="mw-default-size" typeof="mw:Image/Thumb"><a href="File:Foo.jpg"><img resource="./File:Foo.jpg" src="//upload.wikimedia.org/wikipedia/commons/0/06/Foo.jpg" height="144" width="220"/></a><figcaption>alt=<a rel="mw:WikiLink" href="Foo" title="Foo" typeof="mw:Transclusion" data-mw='{"parts":[{"template":{"target":{"wt":"echo","href":"./Template:Echo"},"params":{"1":{"wt":"[[Foo]]"}},"i":0}}]}'>Foo</a> </figcaption></figure>
```

However, the PHP parser generates identical HTML for the "alt=Foo" and "alt=[[Foo]]" cases above.
This is a difference in how links are handled in alt-attributes, and nothing to do with templates.
```
[subbu@earth tests] echo '[[File:Foo.jpg|thumb|Caption here|alt=Foo ]]' | node parse --fetchConfig false --normalize=parsoid
<figure class="mw-default-size" typeof="mw:Image/Thumb"><a href="File:Foo.jpg"><img alt="Foo" resource="./File:Foo.jpg" src="//upload.wikimedia.org/wikipedia/commons/0/06/Foo.jpg" height="144" width="220"/></a><figcaption>Caption here</figcaption></figure>

[subbu@earth tests] echo '[[File:Foo.jpg|thumb|Caption here|alt=[[Foo]] ]]' | node parse --fetchConfig false --normalize=parsoid
<figure class="mw-default-size" typeof="mw:Image/Thumb"><a href="File:Foo.jpg"><img resource="./File:Foo.jpg" src="//upload.wikimedia.org/wikipedia/commons/0/06/Foo.jpg" height="144" width="220"/></a><figcaption>alt=<a rel="mw:WikiLink" href="Foo" title="Foo">Foo</a> </figcaption></figure>

[subbu@earth tests] echo '[[File:Foo.jpg|thumb|Caption here|alt={{echo|[[Foo]]}} ]]' | node parse --fetchConfig false --normalize=parsoid
<figure class="mw-default-size" typeof="mw:Image/Thumb"><a href="File:Foo.jpg"><img resource="./File:Foo.jpg" src="//upload.wikimedia.org/wikipedia/commons/0/06/Foo.jpg" height="144" width="220"/></a><figcaption>alt=<a rel="mw:WikiLink" href="Foo" title="Foo" typeof="mw:Transclusion" data-mw='{"parts":[{"template":{"target":{"wt":"echo","href":"./Template:Echo"},"params":{"1":{"wt":"[[Foo]]"}},"i":0}}]}'>Foo</a> </figcaption></figure>
```

However, the PHP parser generates identical HTML for the "alt=Foo" and "alt=[[Foo]]".
This is a difference in how links are handled in alt-attributes, and nothing to do with templates.
```
[subbu@earth tests] echo '[[File:Foo.jpg|thumb|Caption here|alt=Foo ]]' | node parse --fetchConfig false --normalize=parsoid
<figure class="mw-default-size" typeof="mw:Image/Thumb"><a href="File:Foo.jpg"><img alt="Foo" resource="./File:Foo.jpg" src="//upload.wikimedia.org/wikipedia/commons/0/06/Foo.jpg" height="144" width="220"/></a><figcaption>Caption here</figcaption></figure>

[subbu@earth tests] echo '[[File:Foo.jpg|thumb|Caption here|alt=[[Foo]] ]]' | node parse --fetchConfig false --normalize=parsoid
<figure class="mw-default-size" typeof="mw:Image/Thumb"><a href="File:Foo.jpg"><img resource="./File:Foo.jpg" src="//upload.wikimedia.org/wikipedia/commons/0/06/Foo.jpg" height="144" width="220"/></a><figcaption>alt=<a rel="mw:WikiLink" href="Foo" title="Foo">Foo</a> </figcaption></figure>

[subbu@earth tests] echo '[[File:Foo.jpg|thumb|Caption here|alt={{echo|[[Foo]]}} ]]' | node parse --fetchConfig false --normalize=parsoid
<figure class="mw-default-size" typeof="mw:Image/Thumb"><a href="File:Foo.jpg"><img resource="./File:Foo.jpg" src="//upload.wikimedia.org/wikipedia/commons/0/06/Foo.jpg" height="144" width="220"/></a><figcaption>alt=<a rel="mw:WikiLink" href="Foo" title="Foo" typeof="mw:Transclusion" data-mw='{"parts":[{"template":{"target":{"wt":"echo","href":"./Template:Echo"},"params":{"1":{"wt":"[[Foo]]"}},"i":0}}]}'>Foo</a> </figcaption></figure>
```
The problem seems to be with the link that the val template emits and Parsoid is somehow barfing on it. Can be reproduced with the following reduced test case:
``` [[File:Foo.jpg|thumb|Caption here|alt=This {{echo|[[will]]}} break]]```
Compare with output of
``` [[File:Foo.jpg|thumb|Caption here|alt=This {{echo|will not}} break]]```
Never mind. My eyes deceived me. The following snippet still parses incorrectly.

[[File:Solar Life Cycle.svg|thumb|700px|center|The life cycle of the Sun|alt=14 billion year timeline showing Sun's present age at {{val|4.6|ul=byr}}; from {{val|6|u=byr}} Sun gradually warming, becoming a red dwarf at, "soon" followed by its transformation into a white dwarf star]]
Verified fixed in deployed Parsoid version.
--------------------------
**Version**: unspecified
**Severity**: minor
>>! In T54327#1948228, @Jdforrester-WMF wrote:
>>>! In T54327#1948146, @Nemo_bis wrote:
>> How to share the blacklist (or whatever cleanup method VisualEditor is currently using) with other consumers of Parsoid, such as T124152?
> 
> They should sub-class VisualEditor, which is tracked in {T105447} which I've now linked that to.

Makes sense. What if someone else, maybe outside MediaWiki, desired to use Parsoid for two-way conversion? Should everyone subclass VisualEditor or is this sort of HTML/wikitext cleanup of more general use?
>>! In T54327#1948146, @Nemo_bis wrote:
> How to share the blacklist (or whatever cleanup method VisualEditor is currently using) with other consumers of Parsoid, such as T124152?

They should sub-class VisualEditor, which is tracked in {T105447} which I've now linked that to.
How to share the blacklist (or whatever cleanup method VisualEditor is currently using) with other consumers of Parsoid, such as T124152?
What is this tracking, nowadays?
I wonder if https://ru.wikipedia.org/?diff=65612328 is another instance of this, or if it's a copy-paste bug instead.
Added #53315 for texts looking like telephone numbers changed in <a href="tel:...">...</a>
On en wikipedia most of these are detected by
http://en.wikipedia.org/wiki/Special:AbuseFilter/345
Other common cases include
myEventWatcherDiv
QuickiWiki Look Up
application/x-datavault
end_of_the_skype_highlighting
inlineAdmedialink
_clearly_component
ktg6us78hf8vdu7

Most are not visible the but ktg6us78hf8vdu7 makes a right mess trying to add javascript links everywhere
http://en.wikipedia.org/w/index.php?title=Shane_Watson&diff=prev&oldid=568280885
Screenshot

Adding an image with caption besides a list creates whitespace in edit mode, see screenshot.

--------------------------
**Version**: unspecified
**Severity**: normal
**URL**: https://de.wikipedia.org/wiki/116._Panzer-Division_(Wehrmacht)

**Attached**: {F11788}
This is caused by bug 51708 – all inline templates assume 100% width, which breaks all floated items.

*** This bug has been marked as a duplicate of bug 51708 ***
**Author:** `kwwilliams`

**Description:**
In http://en.wikipedia.org/w/index.php?title=List_of_record_charts&oldid=566209687, notice how Note 1 gets transformed in the string "1.0.1.1" and the actual contents of Note 1 becomes reference 19, which is completely unused in the article body.

--------------------------
**Version**: unspecified
**Severity**: normal
**See Also**:
https://bugzilla.wikimedia.org/show_bug.cgi?id=53486
Clarify the title to explain what I think is happening:

| VisualEditor: Reference defined inside a reference list but of a different group inside template appears as part of the template and also in the appropriate reference list, but blank this time
I can confirm this is still happening.
When we edit using the visual editor, we still get
mw.config.get( 'wgAction' ) === 'view'
instead of
mw.config.get( 'wgAction' ) === 'edit'

See also
http://lists.wikimedia.org/pipermail/wikitech-l/2013-July/070603.html
which quotes
http://lists.wikimedia.org/pipermail/wikitech-l/2013-July/070601.html

--------------------------
**Version**: unspecified
**Severity**: normal
**See Also**:
* {T53421}
* {T55746}
* {T55441}
This is now mostly done, for single edit tab wikis.
(per https://phabricator.wikimedia.org/T55441#962602)

I agree. I don't think it's realistic or desirable to change the url of the editor. Instead we should (eventually) change the default. We can support permalinks for when the url given is semantically related to VisualEditor, but in most cases that is not the case.

There are many cases where the link itself has no relation to an editor, but we do want to send traffic to VisualEditor for new users (when configured as default):
* red links generated by the parser.
* edit links generated by templates.
* edit links created by extensions and gadgets.
* third party sites.
* existing content and discussions.

The majority of those links cannot be feasibly changed, with the exception of those generated by the parser as red links. To change those, the parser would need access to user preferences (which fragments the cache) and the parser would need access the target page content model (which requires additional expensive queries, and is also variable; so it would require cascading cache invalidation).

Instead of changing the url of the "Edit" or "Create" tab in the interface (and providing secondary links for other editors), it probably makes more sense to hook into EditAction (action=edit) and change the default server-side (based on page content model, and current user preferences). Then, we can use an optional query parameter (e.g. action=edit&editor=visualeditor) in case a direct permanent is wanted. Such as when switching between the editors, or when otherwise relying on exact behaviour (e.g. browser tests and gadgets).
(In reply to Helder from comment #1)
> For the sake of solving bug 51421, maybe it could use "action=vedit"?

+1
See also bug 53746 comment 3.
Another reason why the current method is not ideal, taken from
https://www.mediawiki.org/wiki/Thread:VisualEditor/Feedback/Categories/reply_(8)

>Lots of template transclusions also offer a specific edit link.
>Their action uses only the wiki code editor. If both actions
> "edit" and "editVE" were merged into a single one (with a simple
> switch to show either the editable preview or the wiki code) it
> would be simpler. And the "Show preview" button could disappear
> below the wiki editor (it would just remain a "Save page" button),
> but the "Save" button could also show the actual rendering
> without the limitations of the editable preview.
For the sake of solving bug 51421, maybe it could use "action=vedit"?
When a page has pending edits and it is opened for editing using VisualEditor, there is a dropdown box with a notice about this.  When a page has a template or a file with pending changes is opened for editing, the dropdown box does not appear.

An example on the Russian Wikipedia:
https://ru.wikipedia.org/wiki/%D0%98%D1%80%D0%B3%D0%B8%D1%88

--------------------------
**Version**: unspecified
**Severity**: enhancement
**See Also**:
https://bugzilla.wikimedia.org/show_bug.cgi?id=52440
Change 123875 merged by jenkins-bot:
Show pending changes notice about unstable transclusions in VE

[[https://gerrit.wikimedia.org/r/123875]]
(In reply to Alex Monk from comment #6)
> (In reply to James Forrester from comment #5)
> > (In reply to Alex Monk from comment #3)
> > > Shouldn't this appear on the wikitext editor too then?
> > 
> > Maybe create a further bug for that in FlaggedRevisions?
> 
> I just noticed that it was already made - by you. And it's what this bug is
> marked as depending on.

Ha. Never mind me. :-)
(In reply to James Forrester from comment #5)
> (In reply to Alex Monk from comment #3)
> > Shouldn't this appear on the wikitext editor too then?
> 
> Maybe create a further bug for that in FlaggedRevisions?

I just noticed that it was already made - by you. And it's what this bug is marked as depending on.
(In reply to Alex Monk from comment #3)
> Shouldn't this appear on the wikitext editor too then?

Maybe create a further bug for that in FlaggedRevisions?
Change 123875 had a related patch set uploaded by Alex Monk:
Show pending changes notice about unstable transclusions in VE

https://gerrit.wikimedia.org/r/123875
Shouldn't this appear on the wikitext editor too then?
Yes, this is intentional (as the tool interferes with VisualEditor and will need re-writing/merging into VE to work properly).

The notice above the page having transcluded files or templates with outstanding changes feels like one of the things that should appear in the wikitext page's edit notices (and so on VisualEditor's panel too) - not sure why it doesn't. Is this a Pending Changes bug?
Specifically, not only does the dropdown box not appear, but the notice that was on the page before clicking "edit" disappears, leaving absolutely no notice.
When an unmatched literal square bracket is used in the title of a reference, Parsoid or VisualEditor encloses it in a nowiki tag.

Example on the live wiki: https://en.wikipedia.org/w/index.php?title=Wikipedia&diff=566045928&oldid=566042453#cite_ref-209 (line 360)
Examples in testing: https://en.wikipedia.org/w/index.php?title=User%3AThryduulf%2Fsandbox&diff=566402676&oldid=566401436

It is possible this is a reappearance of or related to T45067

--------------------------
**Version**: unspecified
**Severity**: normal
**See Also**:
{T45067}
{T52331}
Yes, this is a known problem.  There are two different forms of nowiki escaping that goes on in Parsoid.  One is applied to text strings (the common kind that appears around [[foo]] when typed literally).

The one in this bug report is applied to transclusion parameters to prevent literal characters messing up transclusion parse.

Ex: If {{tpl|foo|bar}} is editd to {{tpl|[[foo|bar]]}}, then the "[[foo" and "bar]]" have to be wrapped in nowikis to prevent "[[foo|bar]]" from being parsed as a wikilink.

The current limitation of this second form of nowiki escaping is that it only checks arguments one at a time.  So, it conservatively escapes "[foo" in one argument right now without looking at the global context of all arguments which is why you see the nowiki escapes there.

To be fixed.
**Author:** `sandrobt.wiki`

**Description:**
The (visual)edit button in a diff (such as http://it.wikipedia.org/w/index.php?title=Kawakami_Gensai&diff=20609681&oldid=18301858) makes you edit the last version (in the example above the edit button gives the link http://it.wikipedia.org/wiki/Kawakami_Gensai?veaction=edit), whereas clicking on edit source makes you edit the old version (the newest of the two compared versions).

--------------------------
**Version**: unspecified
**Severity**: normal
This was fixed some time ago, it appears.
As far as I can tell the edit source and edit links point to the same oldid. Is this bug still valid?
This looks to be possibly the same issue as bug 51364
Confirming this -  http://it.wikipedia.org/w/index.php?title=Salamandrina_terdigitata&diff=60451620&oldid=57566108 .
Steps to reproduce:

Go to any page that is a subpage, such as a user sandbox. Observe the link to the parent page, located just under "From Wikipedia...". Activate VE. Observe that the aforementioned link disappears.

Found in firefox 22, chrome 28, in both monobook and vector. Screenshot at https://en.wikipedia.org/wiki/File:VE_Phantom_Link.png

--------------------------
**Version**: unspecified
**Severity**: minor
**See Also**:
https://bugzilla.wikimedia.org/show_bug.cgi?id=54325
https://bugzilla.wikimedia.org/show_bug.cgi?id=58063
Change 107133 merged by jenkins-bot:
Hide #contentSub properly

https://gerrit.wikimedia.org/r/107133
Change 107133 had a related patch set uploaded by Jforrester:
Hide #contentSub properly

https://gerrit.wikimedia.org/r/107133
When you copy & paste a link into VisualEditor, it will not be recognized as a URL, but will appear as plaintext. The MediaWiki parser does render it as a clickable link, of course.

This is annoying especially for references, because you might be confused why your link you're adding as a citation doesn't appear to be clickable.

--------------------------
**Version**: unspecified
**Severity**: normal
**See Also**:
https://bugzilla.wikimedia.org/show_bug.cgi?id=52204
Merging this into 52204 as it's a sub-request.

*** This bug has been marked as a duplicate of bug 52204 ***
Adding "ISBN 0-471-17864-0" doesn't render the ISBN as a link.  This is more important in the reference tool, but should work on all rich text surfaces.

See also:
* {T54241}
* {T63558}
Filed T109498 for the remaining "pasted ISBN" bit of this bug.
Change 230146 merged by jenkins-bot:
Detect paste of wikitext and convert it

[[https://gerrit.wikimedia.org/r/230146]]
Change 230146 had a related patch set uploaded (by Jforrester):
Detect paste of wikitext and convert it

[[https://gerrit.wikimedia.org/r/230146]]
Typed and pasted URLs are now merged in core.

*Pasted* RFC/PMID/ISBN links is implemented  (https://gerrit.wikimedia.org/r/230146 is in review).

Currently missing: *typed* RFC/PMID/ISBN links are not autolinked.
Autolink when typing has been merged.  Autolink after pasting is in review, but the functionality is complete.
>>! In T54204#1522662, @Amire80 wrote:
>>>! In T54204#1507599, @ssastry wrote:
>> T107433 (merged as a dupe here) seems to be a major source of nowikis on frwiki as per https://fr.wikipedia.org/wiki/Wikip%C3%A9dia:%C3%89diteurVisuel/Avis/Nowiki
> 
> In Hebrew as well.

@cscott is working on patches for this ( https://gerrit.wikimedia.org/r/#/c/230146/ and https://gerrit.wikimedia.org/r/#/c/230145/ )
>>! In T54204#1507599, @ssastry wrote:
> T107433 (merged as a dupe here) seems to be a major source of nowikis on frwiki as per https://fr.wikipedia.org/wiki/Wikip%C3%A9dia:%C3%89diteurVisuel/Avis/Nowiki

In Hebrew as well.
T107433 (merged as a dupe here) seems to be a major source of nowikis on frwiki as per https://fr.wikipedia.org/wiki/Wikip%C3%A9dia:%C3%89diteurVisuel/Avis/Nowiki
*** Bug 52241 has been marked as a duplicate of this bug. ***
(In reply to comment #5)
> Magic links are pretty evil.

They are one of many unusual pieces of wiki syntax. And it is quite 'wikipedia' specific functionality which could be dropped from core.

> Explicitly marking links with a parser function
> is
> much more sensible.

If the goal is to replace them with a more standard syntax, a 'isbn' interwiki pointing to special:booksources/$1 would be syntax that is more similar and conceptually closer also. Ideally it would render as an internal link when the interwiki points to the local special page.

> I'm not sure supporting magic links in VisualEditor is a
> good idea.

What is the impact of not supporting these magic links on a) big wikipedias like enwp where these magic works will often be used from a cite template (which can be changed without editing millions of pages) and b) small wikis which are imo more likely to use these magic words in raw wikitext.
I.e. How many bot edits are needed, and how many tools need to be revised.
Magic links are pretty evil. Explicitly marking links with a parser function is much more sensible. I'm not sure supporting magic links in VisualEditor is a good idea.
(In reply to comment #3)

> 
> Clicking on the non-hyphenated ISBN, however, results in a failed attempt to
> go
> directly to the ISBN search page, with this resulting error:
> 
> Error
> 404 – File not found
> http://en.wikipedia.org/Special:BookSources/9781234567890
> We could not find the above page on our servers.
> Did you mean to type
> http://en.wikipedia.org/wiki/Special:BookSources/9781234567890? You will be
> automatically redirected there in five seconds.
> Alternatively, you can visit the Main Page or read more information about
> this
> type of error.

The incorrect URI is bug 48915 (it's even worse for non-English wikis as it always suggests a page on en.wp). Although I presume what is wanted is for the ISBN to be edited rather than taking you to the ISBN search page? If so then getting to that page from a right click/ctrl+click would potentially be useful.
This works for me, but perhaps not as expected.

You can add:

PMIDs:  http://en.wikipedia.org/w/index.php?title=User:Whatamidoing_(WMF)/sandbox&diff=563393942&oldid=563393897

ISBNs without hyphenation:  http://en.wikipedia.org/w/index.php?title=User:Whatamidoing_(WMF)/sandbox&diff=567704513&oldid=564410882

ISBNs with hyphens:  http://en.wikipedia.org/w/index.php?title=User:Whatamidoing_(WMF)/sandbox&diff=567704681&oldid=567704513

Exactly like the classic wikitext editor, these do not display as being links until after they are saved.  They do work correctly when saved.

After they have been saved, if you go back into VisualEditor to edit again, then the PMID and hyphenated ISBNs are not editable or clickable (except to select the whole element).  Changes to them must be made by deleting the whole thing and retyping from scratch.  

Clicking on the non-hyphenated ISBN, however, results in a failed attempt to go directly to the ISBN search page, with this resulting error:

Error
404 – File not found
http://en.wikipedia.org/Special:BookSources/9781234567890
We could not find the above page on our servers.
Did you mean to type http://en.wikipedia.org/wiki/Special:BookSources/9781234567890? You will be automatically redirected there in five seconds.
Alternatively, you can visit the Main Page or read more information about this type of error.
I guess the other Magic links http://www.mediawiki.org/wiki/Markup_spec/BNF/Magic_links
for RFC and PMID should be included here.
Discussed at http://en.wikipedia.org/wiki/Wikipedia_talk:VisualEditor#Should_inability_to_edit_ISBNs_be_listed_in_the_limitations_section.3F
**Author:** `wikipedia`

**Description:**
When a file is deleted and still is being used in an article, this file is shown in the article as a box with a red link in it. Starting VE to remove the link, the link is no more visible and thus cannot be removed.

--------------------------
**Version**: unspecified
**Severity**: normal
**OS**: Windows 7
*** This bug has been marked as a duplicate of bug 50788 ***
**Author:** `jonathan_haas`

**Description:**
Steps to reproduce:

1. Goto http://de.wikipedia.org/wiki/The_Binding_of_Isaac?veaction=edit
2. Position the cursor at the start of the page directly before the bold "T".
3. Hit Backspace (to delete infobox)
4. Hit Ctrl+Z (undo)
5. Hit Backspace again
6. Hit Ctrl+Z again
Repeat as long as you want

Actual result:

On each Ctrl+Z a paragraph more is selected

Expected result:

Selection stays the same, undo should undo the action and not change the selection

--------------------------
**Version**: unspecified
**Severity**: normal
This was fixed in gerrit 115759 as part of fixing bug 57552.
**jonathan_haas** wrote:

Deleting infoboxes with a simple backspace has been disabled, but this is still somewhat reproducible, if you select an area (for example the infobox _and_ the bold T) in step 2.

In short: The problem is more hidden, but the underlying issue has not been fixed.
Reproduced.
Removing the content from out of a <ref> .. </ref> should prompt the user that they need to delete the reference.  Perhaps a tooltip, or this might be an opportunity to use a hover trick to give the user something to click to acknowledge they intended to delete the ref.

It shouldnt be possible to save with an empty ref, as that is an error condition.

https://en.wikipedia.org/w/index.php?title=User:John_Vandenberg/test&diff=566133128&oldid=566132993

--------------------------
**Version**: unspecified
**Severity**: minor
**See Also**:
https://bugzilla.wikimedia.org/show_bug.cgi?id=50609
Yes, sorry, this was great. Thanks!
Ping. Anyone want to answer my question?
So Gerrit change 136496 fixed the existing intended behaviour, but didn't go as far as this bug suggests (it just disables the apply button rather than deleting the reference) - should it be changed to delete the reference still?
*** Bug 62399 has been marked as a duplicate of this bug. ***
See Gerrit change 81438 and Gerrit change 88618
length < 4 is a hack and we probably shouldn't be using it…
According to ve.ui.MWReferenceDialog.prototype.onDocumentTransact, this apply button is supposed to be disabled when the length is less than 4. But when I empty the box, the length is 10 so nothing is done.

Anyway, I think we should either:
* Fix that bug (if it is one) and mark this bug as invalid (or repurposed for fixing it), or
* Replace that with this idea
If VisualEditor is default, why after clicking on a red link there's 'action=edit' in url and the source editor runs instead of 'veaction' and VE? I've checked it out on the enwiki and plwiki, but it concerns the rest of phase 2 as well and creating a new page in general. Furthermore, it makes inputboxes ('type=create') incompatible with VE and it can be a bothering problem on some wikis.

**See Also**: {T55441}
>>! In T54162#2590097, @Elitre wrote:
> Did SET work affect this...?

Not yet; it will need further work.
Did SET work affect this...?
I don't want to make inputbox suddenly magically different. It's about ordinary users (especially the new sort 'born' after VE deployment) who want to type a new article's name, click on button and voila, start creating their article in VE. In 2 steps, after 1 click, without experience like 'why the markups? oh, I'm switching to VE'. They'd be more likely to give up in this case.

Technically, you may change the default 'action' with 'veaction' or create a new parameter or sth else, it's up to you.
You can easily point InputBox to VE with a simple hook so that VE can change 'action' to 'veaction'. But that won't make VE magically support all the additional parameters which InputBox uses (e.g. preload, editintro, summary, minor, etc.)
Ah, I see a process problem with type=fulltext too

inputbox goes to search results, and search results show a red link, which the user would click on to start a new page. e.g.

https://en.wikipedia.org/wiki/Special:Search/this_article_doesnt_exist

I believe that some enhancement will be needed in the InputBox extension to support creating VE or SE articles.
https://www.mediawiki.org/wiki/Extension:InputBox
In the plwiki, we have no important inputbox with 'type=create' in the main nor user namespace, but there are inputboxes in help or project pages which create a new article (for ex. [[pl:Pomoc:Tworzenie nowych haseł#Niniejsza strona]]), and after clicking the button there is 'action=edit&preload=' in url.

Second, whenever we click on a red link in an article (the main), 'action=edit&redlink=1' displays. The default tab is 'Create source', not 'Create'. It's quite surprising for me and for the newbies, I believe.
Could you provide a example of a 'type=create' problem affecting VE?  Is it used on main or user namespace in your wiki?
An editor on en.wp has requested that Ctrl+Y should initiate the redo action. Presently the shortcut is ctrl+shift+z.

In my experience both shortcuts are used in about 50% of applications (Xubuntu Linux) so it would be ideal if both shortcuts could be used.

--------------------------
**Version**: unspecified
**Severity**: enhancement
Change 116966 merged by jenkins-bot:
Add cmd/ctrl+y as alternative shortcut for redo

https://gerrit.wikimedia.org/r/116966
Change 116966 had a related patch set uploaded by Catrope:
Add cmd/ctrl+y as alternative shortcut for redo

https://gerrit.wikimedia.org/r/116966
Add cmd/ctrl+y as alternative shortcut for redo
https://gerrit.wikimedia.org/r/#/c/116966/
**jonathan_haas** wrote:

Ctrl+Y is the default undo shortcut in Firefox. It's very confusing that it doesn't work in VE using Firefox.
We overuse both "index" and "offset" in our vocabulary, and one of the more cringe-worthy results is the rename of .indexOf() to .offsetOf() in AnnotationSet. We should refactor our vocabulary and rename this to something saner.

--------------------------
**Version**: unspecified
**Severity**: enhancement
**Author:** `nzmoihue`

**Description:**
I think one nice/needed addition to Visual Editor would be supporting custom wiki defined scripts for fixing text [without interfering with wiki text]. For example on Persian Wikipedia we have an edit tool script [1] [2] that wiki users are very depends on it for fixing article texts and without it Visual Editor would be useless for them.


 1. http://fa.wikipedia.org/wiki/%D9%88%DB%8C%DA%A9%DB%8C%E2%80%8C%D9%BE%D8%AF%DB%8C%D8%A7:%D8%A7%D8%A8%D8%B2%D8%A7%D8%B1%D9%87%D8%A7%DB%8C_%D9%88%DB%8C%D8%B1%D8%A7%DB%8C%D8%B4%DB%8C
 2.http://fa.wikipedia.org/wiki/MediaWiki:Gadget-Extra-Editbuttons-Functions.js

--------------------------
**Version**: unspecified
**Severity**: enhancement
I love this idea.

Wikipedias in several languages have such tools, and everywhere it's implemented differently.

The Hebrew Wikipedia has a fully automatic bot making spelling correction on which there's a wide consensus (with over 700 rules), and it also a gadget that adds a button to make semi-automatic edits when fully automatic edits are not reliable enough. I believe that the tool about which Ebrahim is speaking is similar.

If I'm not mistaken, Russian, Belarusian, Portuguese, Catalan and English Wikipedias have such tools, too, though there are definitely differences in implementation. Almost certainly there are more languages that have such tools.

It may be challenging to make a tool that would work equally well for all languages. Different languages have very different requirements. However, acknowledging that at least some languages needs some kind a framework for this and that not being able to use it is a regression for many users, and providing some standard baseline to work with it will be a good start.

What standard baseline? At least, a standard location for a button that would open such a tool. Another thing that would be useful to everybody would be an agreed API for automated or semi-automated searching and replacing in contentedtiable.

A harder thing to do would be to have a standardized format for replacement rules, though this will require at least a bit of research of the current implementations.

(A general comment: The standardized way of marking the text's language, which Moriel is developing in her GSoC project, should be helpful for such tools. They shall only need to work on the parts that are written in the appropriate language.)
People would like to be able to edit the language links that are coming from Wikidata in the page settings dialog. A link from there to Wikidata would probably also be a good first step.

**See Also**:
{T59929}
{T64005}
{T74178}
(In reply to Elitre from comment #7)
> Thanks. So should I file a new one, or...?

Filing a new bug about the Wikidata tool destroying your current edit by navigating away sounds like a good plan, yes, sorry. :-)
Thanks. So should I file a new one, or...?
(In reply to Elitre from comment #4)
> Apparently this is how it currently works? You can add links to Wikidata
> while in VE, but then you'll miss them because the page will be reloaded?

(In reply to Elitre from comment #5)
> Sorry, rephrasing: You can add items to Wikidata while in VE, but then
> you'll miss the other edits you made in that VE session since the page will
> be reloaded.

Yes, the Wikidata team's sidebar JS tool to add to language links ignores the existence of VE (and so breaks things, as you say).

This bug is talking about being able to edit the language links inside VE, in the language panel of the "page options" dialog which is currently read-only. It's also meant to cover more cases and features than the sidebar JS tool currently does.
Sorry, rephrasing: You can add items to Wikidata while in VE, but then you'll miss the other edits you made in that VE session since the page will be reloaded.
Apparently this is how it currently works? You can add links to Wikidata while in VE, but then you'll miss them because the page will be reloaded?
(In reply to comment #1)
> This would be excellent, but potentially quite a lot of work. Would the
> Wikidata team be interested in exploring with us how this could be done?

Yes :) I don't yet know if/how we can dedicate development time to this but let's talk.
bug52383 suggests the opposite approach: please do not include such complex logic in VE which is already slow. be so kind to improve the current implementation within the VE project if you feel its hacky.
This would be excellent, but potentially quite a lot of work. Would the Wikidata team be interested in exploring with us how this could be done?
**Author:** `molly.white5`

**Description:**
Twice now I've uploaded .ogv files (made with RecordMyDesktop, if that helps) and gotten a popup that very helpfully informs me, "loadImages bad". This appears directly after I choose the file to upload, and I'm guessing it has something to do with the inability to find a thumbnail image? Anyway, at the very least a more descriptive error message might be nice.

--------------------------
**Version**: unspecified
**Severity**: normal
I can't find anything that says "loadimages" in either today's UploadWizard nor the UploadWizard of July 2013.
**molly.white5** wrote:

Yes, it happens at Special:UploadWizard on Commons. I do not seem to be getting the error on test2.

The files were https://commons.wikimedia.org/wiki/File:RefTools_rework.ogv and https://commons.wikimedia.org/wiki/File:VisualEditor_reference_tutorial.ogv, which are 84.02 and 86.73 MB, respectively.
Hi Molly,
where does this happen exactly? http://commons.wikimedia.org/wiki/Special:UploadWizard ? Does it also happen on http://test2.wikipedia.org/wiki/Special:UploadWizard ? Which approx. filesize do these files have?
The rendering of a page can be affected by user extension options (e.g. their choice of renderer for the Math extension) so we should be able to pass through these options to the API.

This is blocking proper support of the Math extension in VisualEditor.

--------------------------
**Version**: 1.23.0
**Severity**: normal
To do something about this, I think we'd need:
# Put these extension options in ParserOptions, somehow. The extension would also have to depend on the ParserOptions rather than user preferences or the like to determine behavior.
# Be able to query the options available in ParserOptions, along with their API data types. And be able to set an option generically by name.
# Then ApiParse and other modules can use this to add relevant parameters for the parser options.
[Setting normal prio as bug 51698 (blocked by this) is also normal prio.]
See bug 51698
Following the documentation[1] starting at ve.ui.Surface (from ve.instances[0]) one would go to #getContext and access .toolbar. But though that property is defined, it is set to null.

I'm not sure why, but apparently our MediaWiki's init is instantiating its own and is only accessible from ve.init.mw.ViewPageTarget#toolbar (ve.init.mw.targets[0].toolbar).

It probably shouldn't have to instantiate its own one, and certainly not make it inaccessible to the rest of VE.


[1] https://doc.wikimedia.org/VisualEditor/master/#!/api/ve.ui.Surface

--------------------------
**Version**: unspecified
**Severity**: enhancement
There used to be a .toolbar property because the context had its own (local) toolbar to show the contextual tools in. This has been replaced with ContextWidget (which isn't a toolbar) which groups ContextItemWidget (which aren't tools), and now there is no .toolbar property.
It seems that Chrome 28 does not display the "Minor Edit" and "Watch This Page" checkboxes on the save page form. This does work in Firefox 22. Does not seem skin related - Vector and Monobook have the same problem in either browser

Steps to reproduce:
- Open any page in edit mode.
- Make a small change, press Save page.
- (Firefox): There will be checkboxes stating "Watch this page" and "This is a minor edit"
- (Chrome): Those checkboxes are not present.

--------------------------
**Version**: unspecified
**Severity**: normal
Then this is not the bug I thought it was; fixing settings.
Do'h! Logging in does indeed appear to be the problem - I restarted Chrome right before testing a few things iand forgot to log back after i did. Sorry for that - seems to be a storm in a teacup.
(In reply to comment #0)
> It seems that Chrome 28 does not display the "Minor Edit" and "Watch This
> Page"
> checkboxes on the save page form. This does work in Firefox 22. Does not seem
> skin related - Vector and Monobook have the same problem in either browser
> 
> Steps to reproduce:
> - Open any page in edit mode.
> - Make a small change, press Save page.
> - (Firefox): There will be checkboxes stating "Watch this page" and "This is
> a
> minor edit"
> - (Chrome): Those checkboxes are not present.
Are you sure you're logged in in both browsers? If you're logged out in Chrome, then you'd be getting the expected behavior for anons (which changed recently, because we're not using smarter code that's more consistent with how the old editor does it).
This is actually due to an underlying bug in the new code just pushed out an hour ago; we've just fixed this (reload if it doesn't show).
English Wikipedia user Atethnekos reports: 
"If I make 2 changes, review changes, exit review/save dialog, undo last change, and then review changes again, the review shows both changes, though saving only saves the first."

Steps to reproduce:
1. Make two changes to a page in VE
2. Undo one change
3. Click save and review your changes. 
-Expected behaviour: Only the first change is shown
-Actual behaviour: Both changes are shown.
4. Save the page. Only the first change has been saved.

This means that the review your changes is incorrect.

--------------------------
**Version**: unspecified
**Severity**: normal
Yes, this is now fixed, almost certainly as part of the re-write Roan did last month.
Can't replicate.
Reported by Atethnekos on EnWiki, who also provided an image: https://en.wikipedia.org/wiki/File:Platovesample1.png

"When I edit a page with the pending changes revision dropdown, and I am scrolled to the very top, the dropdown and the VE page settings link become mangled.  See highlight in included image.  Firefox 22 on Win7 Pro SP1."

I can reproduce this in both Firefox 22 and Chrome 28. The issue seems specific to the Monobook skin - Vector renders the pending changes dropdown somewhat lower in both browsers.

--------------------------
**Version**: unspecified
**Severity**: normal
Sorry about this; the good news is that we just fixed this in gerrit 75545 which will go out in about eight hours or so - that drop-down menu will be hidden once you're inside VisualEditor mode (whatever your skin).
Wikitext appearing in transclusion dialog

The underlying cause of this might be covered in bug 48231 or bug 51217 or others ... I thought I saw a bug about this, but cant find it now.

[[template:multicol]] with wikisyntax inside it results in the attached screenshot, with wikitext visible in the transclusion dialog as 'Content' blocks.

https://nl.wikipedia.org/wiki/Gebruiker:John_Vandenberg/test?veaction=edit

Section headers & list items also cause this; see the last block here:
https://en.wikipedia.org/w/index.php?title=User:John_Vandenberg/test&oldid=565567699&veaction=edit

If it helps, this issue is present on one of the parsoid topfails:

https://nl.wikipedia.org/wiki/Eerste_divisie_1996/97?veaction=edit

BeginKolommen occurs on nlwp 3047 times.  11362 times in enwp.  8861 times in eswp. 40985 times on itwp!, which is roughly 4% of the content pages.

Confirmed this is happening on every itwp invocation that I edit
https://it.wikipedia.org/wiki/Speciale:PuntanoQui/Template:Colonne
e.g.
https://it.wikipedia.org/wiki/Aeroplano?veaction=edit

--------------------------
**Version**: unspecified
**Severity**: normal

**Attached**: {F11763}
(In reply to comment #5)
> (In reply to comment #4)
> > > 'nl:Eerste divisie 1996/97' is on the parsoid topfails list
> > > 
> > > http://parsoid.wmflabs.org:8001/topfails
> > > 
> > Oh, I see. It's not any more now :(
> 
> It is on page two of 16
> 
> http://parsoid.wmflabs.org:8001/topfails/2
> 
Aha! Found it.

> I have no idea if the {{BeginKolommen}} or tables within it have anything to
> do
> with the semantic failure; just thought I should mention it.
That doesn't appear to be the case: looking at the RT diff (which you get to by clicking on the page name), it's mostly related to the tables on the page: http://parsoid.wmflabs.org/_rt/nl/Eerste_divisie_1996/97
(In reply to comment #4)
> > 'nl:Eerste divisie 1996/97' is on the parsoid topfails list
> > 
> > http://parsoid.wmflabs.org:8001/topfails
> > 
> Oh, I see. It's not any more now :(

It is on page two of 16

http://parsoid.wmflabs.org:8001/topfails/2

I have no idea if the {{BeginKolommen}} or tables within it have anything to do with the semantic failure; just thought I should mention it.
(In reply to comment #3)
> I think it is impressive that VE handles it
> 
This is mostly thanks to Parsoid handling this case very well, and VE simply building a UI around it :)

> 'nl:Eerste divisie 1996/97' is on the parsoid topfails list
> 
> http://parsoid.wmflabs.org:8001/topfails
> 
Oh, I see. It's not any more now :(

> Here is an itwp example where multicol consumes most of the page, and should
> probably be removed.
> 
> https://it.wikipedia.org/wiki/Campagna_%28comune%29?veaction=edit
Yes. I just fixed that page.
I think it is impressive that VE handles it

'nl:Eerste divisie 1996/97' is on the parsoid topfails list

http://parsoid.wmflabs.org:8001/topfails

Here is an itwp example where multicol consumes most of the page, and should probably be removed.

https://it.wikipedia.org/wiki/Campagna_%28comune%29?veaction=edit
{{BeginKolommen}} generates the beginning of a table, and {{EindeKolommen}} generates the end of that table. All content between those two is treated as one template call. This is expected behavior in the current implementation, and is exactly the same as succession boxes and all other templates that generate openings and closings separately (multipart templates).

It would be nice if we could let users edit these in a nicer way, especially considering that some (but not all) of the wikitext blocks are actually innocuous wikitext that VE could reasonably edit, but right now we can't. This is part of the reason why multipart templates suck.

What is the Parsoid topfail thing you're talking about? There's no link to the failure and it seems unrelated to this issue.


Not closing this as INVALID or whatever because this is something we should actually handle better.
Editing the wikitext appears to function correctly, which is good news.
https://it.wikipedia.org/w/index.php?title=Matematica&diff=60342095&oldid=59678552
The bug 51905 made me realize of a potential problem. When a media, say an image, is inserted, sometimes it may be inserted outside the field of view of the user, and this may lead some users to think that it wasn't inserted at all, causing aborted edits, confusion, frustration, and even bad edits. For example if there is an infobox in the article, or a bunch of images aligned to the right, then if the user inserts an image, in many cases it will be inserted below all this, and the user will not see it without scrolling the screen.

The solution to this potential problem is, I think, fairly simple: make the VisualEditor detect if the image is in the field of view of the user, and if it's not, then scroll the screen so that it is!

--------------------------
**Version**: unspecified
**Severity**: enhancement
**See Also**:
https://bugzilla.wikimedia.org/show_bug.cgi?id=58091
Checked all Insert menu options in beta (Chrome, FF35, and Safari).

What was checked 

-  a cursor placed at the top/bottom of a page and Insert
-  a cursor placed at the bottom of a page - and scroll up and then 'Insert'
-  'Insert' options for Media Caption
-  'Undo/Redo' with different cursor positions
Change 200243 merged by jenkins-bot:
Scroll the selection into view when it is outside the window

[[https://gerrit.wikimedia.org/r/200243]]
Change 200243 had a related patch set uploaded (by Mooeypoo):
Scroll to newly inserted elements

[[https://gerrit.wikimedia.org/r/200243]]
A auto-disappearing popup notice "Your image has been inserted; scroll down to see it." would help.
I experienced the same problem in bug 51863.
When an image file is included directly in an article (i.e not as a thumbnail and not in a frame) with an unclosed <center> tag in the caption causes Visual Editor to not render any page content after the image.

See https://en.wikipedia.org/w/index.php?title=User:Thryduulf/sandbox2&oldid=565498603 for an example.

All the following conditions must be true to see this bug:
* Image must not be a thumbnail or in a frame
* The image caption must contain an unclosed html tag specifying text alignment in the caption. Tested with <center>, <p align="center"> and <div align="right">
* The image placement (left, right or center) must be specified

The bug does not occur with an unclosed italic html tag. I haven't tested with other tags.

--------------------------
**Version**: unspecified
**Severity**: normal
As we discussed and confirmed on IRC, this is not happening in production right now. So, I am going to mark this resolved-fixed. Please reopen if a similar error shows up.
Will provisionally mark this as in-review, then (you can see that it's still happening with production Parsoid, though that may be cache errors).
Unclosed tags in image caption is not that infrequent unfortunately -- the difference between <center> and <i>/<b> tags is that the former is a block tag and the latter is an inline tag. So, any other block tag that is unclosed will cause the same issue. 

That said, I am surprised that this problem showed up in the first place since Parsoid has had support to deal with unbalanced tags for a long time: https://gerrit.wikimedia.org/r/#/c/43384/

This was a bit of a hacky support. More robust and improved support for this is coming in https://gerrit.wikimedia.org/r/#/c/83216/

So, unsure what happened here with this bug.
Forgot to note that although this combination of conditions is presumably uncommon, it was first observed in the wild at https://en.wikipedia.org/w/index.php?title=Typographer_%28typewriter%29&oldid=565431177
first table at [[Comparison of container formats]] rendered in a 1024px wide window. Firefox 22 on Linux

In VisualEditor the editing window does not horizontally scroll to accommodate wide tables. Table cells and their contents render as if the window did scroll, but as it does not they are truncated.

--------------------------
**Version**: unspecified
**Severity**: normal
**See Also**:
https://bugzilla.wikimedia.org/show_bug.cgi?id=51755
https://bugzilla.wikimedia.org/show_bug.cgi?id=51820

**Attached**: {F11662}
it would be nice to have a fix for horizontal scrolling for wide tables
en.wp user Cryptic C62 comments:
"VE does not correctly render any table wider than the screen, nor does it allow horizontal scrolling. This effect seems to extend to any wide element, including math formulas, images, transclusions, and text with non-breaking spaces. Some other findings:

* A horizontal scroll bar does appear when hovering over some elements with a mouseover effect, specifically images and uneditables (Strangely, the scroll bar does not appear when hovering over the {{Details}} template in this example). Scrolling can then occur if you have a clickable mousewheel.

* By placing the text cursor near the visible end of wide text, and pressing the right arrow key, it is possible to sneak the text cursor off of the page."

Test cases: https://en.wikipedia.org/w/index.php?title=User:Cryptic_C62/sandbox&oldid=567261009
Comment on attachment 12931
first table at [[Comparison of container formats]] rendered in a 1024px wide window. Firefox 22 on Linux

Fix MIME type
When VisualEditor inserts an image, the thumbnail keywords are written in English: "File:", "thumb", "right" (but see Bug 51851).

This should not, theoretically, be a problem, because the VisualEditor is supposed to make these keywords unimportant and hidden from the end-user. However, while the source editor is still being widely used, this is a problem, especially for right to left languages: it is very hard to edit these English keywords when they are mixed with right-to-left text.

These keywords should be inserted in the language of the wiki.

--------------------------
**Version**: unspecified
**Severity**: normal
Change 280792 merged by jenkins-bot:
T53852: Serialize localized image options

[[https://gerrit.wikimedia.org/r/280792]]
Change 244254 abandoned by Eranroz:
Use local keyword for image

Reason:
See a better patch: https://gerrit.wikimedia.org/r/#/c/244254/

[[https://gerrit.wikimedia.org/r/244254]]
Change 280792 had a related patch set uploaded (by Arlolra):
T53852: Serialize localized image options for rtl languages

[[https://gerrit.wikimedia.org/r/280792]]
>>! In T53852#1735891, @Amire80 wrote:
> General Q: Can the same patch also resolve T104057, a similar issue in ContentTranslation?
> 
>>>! In T53852#1735780, @cscott wrote:
>> * Alternatively, you could do a grep over the most recent dump for that wiki to count frequency of use for each alias, and verify that the term which would be used by this patch matches the most frequent alias.
> 
> Sounds more practical and closer to reality.
> 
> Parsoid developers, don't you have some kind of a tool that queries lots of dumps quickly? I remember hearing something like this, but maybe I am just imagining.

This used to be part of the parsoid repository but is now its own repo @ https://github.com/wikimedia/dumpgrepper
General Q: Can the same patch also resolve T104057, a similar issue in ContentTranslation?

>>! In T53852#1735780, @cscott wrote:
> * Alternatively, you could do a grep over the most recent dump for that wiki to count frequency of use for each alias, and verify that the term which would be used by this patch matches the most frequent alias.

Sounds more practical and closer to reality.

Parsoid developers, don't you have some kind of a tool that queries lots of dumps quickly? I remember hearing something like this, but maybe I am just imagining.

>>! In T53852#1735858, @ssastry wrote:
> A good compromise to get this moving would be to do this analysis for the top N wikis (N = 10?)

I'd guess that it's more like 50 or so.
A good compromise to get this moving would be to do this analysis for the top N wikis (N = 10?) -- the expectation is that only a few wikis will need either their messages tweaked or special case exceptions added for them in the code and we can get this going from there.
@eranroz's code in wikieditor: https://git.wikimedia.org/blob/mediawiki%2Fextensions%2FWikiEditor/8fa9506e20ce5216240531686fa0bd70fdb2a6d8/WikiEditor.hooks.php#L374

I'm proposing a simple process:
* Make a table with the various options whose serialization will be changed with this patch, both before and after.
* Send this in an email to the language team for approval.
** Alternatively, you could do a grep over the most recent dump for that wiki to count frequency of use for each alias, and verify that the term which would be used by this patch matches the most frequent alias.
* For any languages where this patch does *not* match that wiki's preferred term, file an issue as a blocker for this bug, and resolve it.
** Either add special cases to this patch, or else export some general siteinfo property (a boolean to "prefer first alias" or "prefer last alias"), or else work with the community to swap the aliases in mediawiki (MessageEn in core, and then perhaps the actual wikipedias need to be checked for customizations that might override this)
* After this is done, everyone will have objectively agreed that the terms used by this patch are preferable, and this patch can be merged.
It's not just english, it's also dewiki IIRC.

To unblock this issue, you need to survey all the wikis (not just enwiki and hewiki) and describe how this change will affect them, then get confirmation from the language team that the change is actually "better" for all these languages.

We were burned before by changing this prematurely; before we're going to make another change we need to be sure we are actually doing the right thing.
A note specific for English: This fix will introduce "thumbnail" instead of "thumb"  in parsoid. This side effect is the correct behavior as aliases are defined by the preferred order, and this is the syntax added by the current WikiEditor image dialog. If you prefer "thumb" and not "thumbnail" (personally I do too) which is shorter - you should swap the aliases in English (MessageEn in core, and enwiki.json in baseconfig) - but this should be a different task.
Change 244254 had a related patch set uploaded (by Eranroz):
Use local keyword for image

[[https://gerrit.wikimedia.org/r/244254]]
(In reply to C. Scott Ananian from comment #8)
> Yes, that is correct.  The patch was merged and then the language-specific
> parts were reverted because the way it selected the aliases was fragile in
> LTR languages.  This is still on my to-do list for a proper fix; IIRC the
> blocking issue is we need to export a simple RTL/LTR flag in siteinfo.

Would it be easier if we just had Parsoid default to the (first?) localised string over the generic wikitext? This presumably doesn't need any MW API changes…
Yes, that is correct.  The patch was merged and then the language-specific parts were reverted because the way it selected the aliases was fragile in LTR languages.  This is still on my to-do list for a proper fix; IIRC the blocking issue is we need to export a simple RTL/LTR flag in siteinfo.
The above was merged in January, but this bug isn't fixed AFAICT. Also, we should probably use the local wikitext over the English version in all languages, not just RTL ones.
Change 103082 had a related patch set uploaded by Cscott:
Edited image attributes should override data-parsoid value.

https://gerrit.wikimedia.org/r/103082
I'm pretty sure our magic words support already has the appropriate localized keyword alias. We just aren't using it (yet).
I went over the RTL languages and samples practical Wikipedia articles, and it seems that the first alias is always is always the most frequently used.

Is there anything I can do to help move this forward? It's one of the most requested features.
For the site info, look for "rtl" in http://he.wikipedia.org/w/api.php?action=query&meta=siteinfo&siprop=general&format=json
We don't actually need to hard-code the list of rtl wikis, as that information is available in the site info returned by the API. It would still be good to check for each current rtl wiki if the first option alias is always a good one.
In most ltr wikis the English version is actually the most commonly used today, which is why we went with serializing new content with the English defaults.

This is not ideal for rtl languages though, as this leads to a mix of ltr and rtl text.

If you can provide us with a list of rtl language codes and check for each if a common offset in the option aliases is a good default, then we can add a list of rtl languages to the serializer and use the localized defaults for those.
Steps to reproduce
1. start an empty sandbox (https://en.wikipedia.org/wiki/User:John_Vandenberg/mtgg?veaction=edit)
2. insert reference
3. use an existing reference

Expected results:
'Use an existing reference' should be disabled, as there are none to select.

--------------------------
**Version**: unspecified
**Severity**: minor
**See Also**:
https://bugzilla.wikimedia.org/show_bug.cgi?id=50458
Change 81964 merged by jenkins-bot:
Re-build reference search index so they can be used mid-edit

https://gerrit.wikimedia.org/r/81964
Now fixed in master and will be deployed next week.
Change 81964 had a related patch set uploaded by Trevor Parscal:
[WIP] Bug 51689, bug 52000 & bug 51848 - Reusing new references

https://gerrit.wikimedia.org/r/81964
Steps to reproduce:
1. Download and install Google input tools for windows www.google.co.in/inputtools
2. Open any page in firefox
3. Open VE
4. Edit a reference
5. Type anything in the reference. The word is input by the tools when the word is complete and one presses space/enter

Expected Behaviour:
The word is input and if the spacebar has been pressed, a space is input too.

What happens instead:
The word is entered recursively over and over. The space isn't input at all.

System environment:
Win 7 X64 SP1
Firefox 15.0.1
Google input tools for languages hindi and punjabi(gurmukhi script)

The problem didn't seem to arise when using input tools for urdu, though its possible that's just coz the wiki is ltr and urdu is rtl.

--------------------------
**Version**: unspecified
**Severity**: normal
Confirming that this is fixed in Firefox 23.0.1 on Win7 X64 SP1 for both punjabi (gurmukhi script) and hindi.
Marking this as "FIXED" on the expectation that it's fixed - please re-open if you find that it is still occurring.
There's code to address this bug in the following patch, which is due to go live by mediawiki.org on 13 September 2013:

https://gerrit.wikimedia.org/r/#/c/82858/

Please let us know whether it fixes the bug!
Steps to reproduce:
1. Open any page
2. Open VE
3. Type (or copy-paste) ग्र
5. Press left arrow key

What should happen:
Cursor should move to the left of the glyph

What happens:
Cursor stays there

System environment:
Win 7 X64 SP1
Google Chrome 28.0.1500.72 m

The problem arises regardless of what follows ग्र . I've tried with space, tab, the letter a, devanagari characters that do not combine with the glyph, like क, and devanagari characters that do combine with the glyph, such as ि to produce ग्रि and ी to produce ग्री

The problem doesn't seem to affect firefox 15.0.1.

In chrome, the problem doesn't arise in the link editing window, or when editing parameter of a template. It does, however, arise when editing a reference.

--------------------------
**Version**: unspecified
**Severity**: normal
Have tested quite a lot and this seems fine.
Seems to be fixed now, though probably needs to be tested extensively before closing.
18:32 < Sid-G> Hi. Can someone confirm if the fix for https://bugzilla.wikimedia.org/show_bug.cgi?id=51846 has been deployed to the wmf cluster?

18:40 < mutante> Sid-G: hi
18:40 < mutante> i dont know much about ve but yes, it looks deployed

8:40 < mutante> checked one of those changed files on tin
18:41 < mutante> /php-1.23wmf6/extensions/VisualEditor/modules/ve/ce/ve.ce.Document.js
18:43 < mutante> Sid-G: and also confirmed on random app server, so not like somebody forgot to deploy
18:43 < mutante> if it doesnt work it should actually need an additional fix

18:45 < Sid-G> hmm, then i should reopen the bug
18:45 < mutante> yes
18:45 < mutante> please do

18:58 < Sid-G> mutante: reopened. Is there an irc chan for VE?

19:15 < legoktm> #mediawiki-visualeditor
We'll have to investigate. Sorry this isn't fixed yet!
Reopening

System Environment:
Windows 7 X64 SP1
Google Chrome 31.0.1650.63 m

Urls:
Same as in comment 6

Glyphs:
Same as in comment 0 , comment 1 and comment 6

What happens:
Crossing the glyphs now requires three keypresses going either left to right or right to left.
Has this been deployed? If it has, it hasn't fixed the problem. Please reopen if this has been deployed. Tried at both urls per comment 6.
Change 80689 merged by jenkins-bot:
Revert model to use simple UTF-16 code units

https://gerrit.wikimedia.org/r/80689
Change 80689 had a related patch set uploaded by Divec:
DONTMERGE:Revert model to use simple UTF-16 code units

https://gerrit.wikimedia.org/r/80689
There's code in progress to fix this in gerrit 80689 which is currently a work-in-progress.
Update:
System Environment:
Windows 7 X64 SP1
Google Chrome 29.0.1547.76 m

Tested at https://www.mediawiki.org/wiki/User:Siddhartha_Ghai?veaction=edit

न्स seems to now require three keystrokes. All the others listed in Comment 6 above along with ग्र भ्र श्र ष्र still require two keystrokes.
System environment:
Win 7 X64 SP1
Google Chrome 29.0.1547.66 m

It seems similar behaviour (both with and without the patch) occurs when a letter is followed by ् + स regardless of whether the glyph appears joined or not.

To be clear, the same problem occurs with this cluster, and the patch works the same.

Results with the patch for all consonants, tested at [1]:
Glyph(s) -- Number of keystrokes needed (going either left to right or right to left)
क्स ख्स ग्स घ्स ङ्स च्स छ्स ज्स झ्स ञ्स ट्स ठ्स ड्स ढ्स ण्स त्स थ्स द्स ध्स न्स प्स फ्स ब्स भ्स म्स य्स र्स ल्स व्स श्स ष्स स्स ह्स -- 2

I have not tested the selection per key-press for these, but I expect the results would be same as those in Comment 5

Results without the patch, tested at [2]:
All of the clusters can be passed with one right arrow key press going from left to right. None can be passed going right to left on any number of left arrow key-presses.

[1]: https://www.mediawiki.org/wiki/User:Siddhartha_Ghai?veaction=edit
[2]: https://hi.wikipedia.org/wiki/%E0%A4%B8%E0%A4%A6%E0%A4%B8%E0%A5%8D%E0%A4%AF:Siddhartha_Ghai/sandbox?veaction=edit
(In reply to comment #4)
> There's code to address this bug in the following patch, which is due to go
> live on mediawiki.org by 13 September 2013:
> 
> https://gerrit.wikimedia.org/r/#/c/82858/
> 
> It does not fix this completely, but it does make it possible to cursor left
> through the cluster with repeated consecutive keypresses.

System environment:
Win 7 X64 SP1
Google Chrome 29.0.1547.66 m

Tested this out at [1]. The cursor moves past the glyph on two left arrow keypresses.

I tried selecting the text with the left arrow keypresses. Then I copy-pasted the selected text into an external text editor. It seems the first keypress takes the cursor past र and the second past ग्
However, visually the caret seems to be unmoved after the first keypress (i.e it does not move past the glyph or into the glyph) and crosses the glyph after the second keypress.

The patch also introduces an unintended side-effect. Crossing the glyph from the left to the right on right arrow keypress also takes two keypresses now. Without the patch, this used to take only one right arrow keypress. This correct behaviour can be currently seen at hindi wikipedia, specifically tested at [2]

So the problem is partially fixed, but with side-effects.

[1]: https://www.mediawiki.org/wiki/User:Siddhartha_Ghai?veaction=edit
[2]: https://hi.wikipedia.org/wiki/%E0%A4%B8%E0%A4%A6%E0%A4%B8%E0%A5%8D%E0%A4%AF:Siddhartha_Ghai/sandbox?veaction=edit
There's code to address this bug in the following patch, which is due to go live on mediawiki.org by 13 September 2013:

https://gerrit.wikimedia.org/r/#/c/82858/

It does not fix this completely, but it does make it possible to cursor left through the cluster with repeated consecutive keypresses.
(In reply to comment #2)
> Hi,
> 
> You are referring problem to windows system based inscript input system , ULS
> or any hindi devnagari input or any devnagari input including  Marathi and
> Nepali ?
> 
> Regards

The problem is not with the input method. It is with moving around the cursor when using visual editor. So, for example, if any letter followed by ् + र already exists on the wiki and you try to edit the page with visual editor, you can move the cursor across it from left to right, but not from right to left.

As far as I understand the problem, it is specific to devanagari (not hindi), although I haven't specifically gone to mr or ne wikis to verify.
(In reply to comment #1)
> Update: Same problem seems to arise for any other letters followed by ् + र
> to
> form a combined glyph. Examples:भ्र श्र ष्र etc. It does not seem to arise
> when
> the glyph is not combined.

Hi,

You are referring problem to windows system based inscript input system , ULS or any hindi devnagari input or any devnagari input including  Marathi and Nepali ?

Regards
Update: Same problem seems to arise for any other letters followed by ् + र to form a combined glyph. Examples:भ्र श्र ष्र etc. It does not seem to arise when the glyph is not combined.
The re-use tab in the reference dialog allows searching for group names. This was always possible. However, it doesn't work when the group name is uppercase or contains an uppercase character. For example, it works when the group name is "note" but not when the group name is "A". It doesn't matter if I search for "a" or "A", it's not found.

Turns out the relevant code is incomplete ever since it was written in 2013, see https://gerrit.wikimedia.org/r/70364. The relevant ticket was {T51733}.
Split from bug 51436, Original comment was:
"Also typing a word only shows template names starting with that word, not
containing it, which is a weird search behaviour.

If I type "book", template "Cite book" is not shown, which limits the search
functionality to be useful only for people who already know template names
(i.e. those who don't need it)."

A further relevant comment was:
"This is asking for VisualEditor ... to use an entirely different (and slower) part of MediaWiki's search infrastructure so we can do in-string searching rather than left-string completion."

--------------------------
**Version**: unspecified
**Severity**: enhancement
**See Also**:
https://bugzilla.wikimedia.org/show_bug.cgi?id=51670
**crypticc62** wrote:

Even if in-string searching is used instead of left-string completion, there is still the problem of templates whose names are completely unsearchable, such as {{rp}} and pretty much everything in [[Category:Typing-aid templates]].

What would be very useful is a TemplateData field in which editors can list relevant keywords that users might search for. Perhaps it could be called "keywords" or "tags". Without something like this, it's not clear to me how new users would ever find the templates they're looking for.
The VisualEditor's user manual is translatable in Meta, which is a Good Thing. Currently the help link uses Special:MyLanguage. This uses the user's UI language as defined on Meta, which is likely not to be the same as the user's UI language on a non-English site.

As much as possible, the link should point directly to the user manual in the language that the user is using currently for the UI.

--------------------------
**Version**: unspecified
**Severity**: enhancement
That is intentional. Given the logged out users and many logged in users by default have English, it prefers the provided language code instead of interface language.
>>! In T53797#564658, @Nikerabbit wrote:
> You could point to Special:MyLanguage/Page/<current ui language>. If the user is logged on mediawiki.org (which is quite likely), their interface language there will still overrule the provided language code :(

That would probably be okay, but if I go to https://ta.wikipedia.org/wiki/Mw:Special:MyLanguage/Help:VisualEditor/User_guide/ta I get Tamil, even though I am logged in and my preference is en.
(In reply to comment #2)
> You could point to Special:MyLanguage/Page/<current ui language>. If the user
> is logged on mediawiki.org (which is quite likely), their interface language
> there will still overrule the provided language code :(

To do this we'd have to have code that explicitly mangles an i18n string. This feels… deeply wrong. :-(
You could point to Special:MyLanguage/Page/<current ui language>. If the user is logged on mediawiki.org (which is quite likely), their interface language there will still overrule the provided language code :(
(In reply to comment #0)
> The VisualEditor's user manual is translatable in Meta, which is a Good
> Thing.
> Currently the help link uses Special:MyLanguage. This uses the user's UI
> language as defined on Meta, which is likely not to be the same as the user's
> UI language on a non-English site.
> 
> As much as possible, the link should point directly to the user manual in the
> language that the user is using currently for the UI.

What is the recommended solution for this? Hard-code the link to be https://www.mediawiki.org/wiki/Help:VisualEditor/User_guide/<foo>? Wouldn't it be easier for the user's language to properly transfer to MW.org using ULS or whatever?
Tracking for VE issues of problems that are specific to a Wikipedia other than English Wikipedia, excluding RTL issues as they are tracked by bug 33126.

--------------------------
**Version**: unspecified
**Severity**: normal
**See Also**:
{T51998}
{T51999}
Which project/tag was this replaced with?
Replaced with projects.
Since you dont want to track them, I have put myself as the assignee.

I added issues that appear to be a much higher priority for non-English Wikipedia, or only reproducible on non-English Wikipedia.  If they affect all Wikipedia, remove them.

We have had very few issues raised from non-English Wikis, and many of them had not even been confirmed until I worked through the Unconfirmed list yesterday.
It is not-unreasonable to use a tracking bug for language-specific issues, but almost all of the bugs cited here are not language-specific. Will remove those that are general VisualEditor issues.
When you type "[[" in visual editor, there is a "wiki markup text" popu (nice touch - Thanks, devs).

However, this warning popup shows at top of page, so it's not visible when the page is scrolled even a few lines.

VE toolbar floats at the top of the browser's page even when we edit at the middle of the article. the warning popu should do the same. 

REPRODUCTION INSTRUCTIONS
0) open [[en:The Rolling Stones]]
1) select one of the sections from the TOC
2) Click "Edit"
3) wait, wait, wait, wait...
4) close the edit notice
5) type "[["

EXPECTED
1) during the wait (3 above) there is a nice image asking you to wait: this image is expected to be visible

2) when the "edit notice" shows up, you expect some clear way to close it.

3) when typing "[[", you expect the "wikitext warning" popup to show up

WHAT ACTUALLY HAPPEN

1) the "please wait" image appears, but unfortunately it's outside the screen, so you do not know why the page appears milky, and have no indication that this would eventually end.

2) depending on your luck, clicking on various parts of the page *will* close the edit notice (if you're lucky), or will take you to [[en:Template:Editnotices/Page/The Rolling Stones]] (i.e., another page from the one you are trying to edit) if you're unlucky.

3) the warning popup appears, but it's at the top of the page, so unless you are editing the very first part of the page, you do not see it.


COMMENTS:
1) VE is clever enough to have its toolbar visible even when scrolling down, using "position:fixed". same should be done for the "please wait" image and for the warning popup(s).

2) the "1 notice" and the warning triangle on the toolbar should indicate that they are the gate to hiding the notice: e.g., change the "1 Notice" text to "Hide notice" when the notice is visible.

3) it seems that the wikitext notice is not yet translated to all languages.


peace.

--------------------------
**Version**: unspecified
**Severity**: normal
Sounds like the same thing.

The other bug is older and the discussion on this one is mostly related to bug 50870, so I'll mark this one as a dupe of that one.

*** This bug has been marked as a duplicate of bug 50206 ***
(is https://bugzilla.wikimedia.org/show_bug.cgi?id=50206 a dupe?)
(In reply to comment #3)
> i know that opening a single ticket for 3 different issues is not a good
> idea, and i apologize for doing something i know is wrong.

As long as you don't do it again, no need to apologise. :-)
Original bug talked about 3 (somewhat unrelated) things.

The first one turned out to be duplicate of bug 50870, and not specific to VE (i think this is why i did not find it).

However, the 2nd one *is* specific to VE, and i do not think bug 50870 covers it.

so i changed the synopsis of this bug to indicate the 2nd problem, and i'm reopening it.

i know that opening a single ticket for 3 different issues is not a good idea, and i apologize for doing something i know is wrong.

(it's a bit confusing - "1st" and "2nd", appear as "2" and "1" in original ticket - i call "2" in comment #0 "first" because this was the synopsis of original ticket).

peace.
*** This bug has been marked as a duplicate of bug 50870 ***
(In reply to comment #0)
> 2) depending on your luck, clicking on various parts of the page *will* close
> the edit notice (if you're lucky), or will take you to
> [[en:Template:Editnotices/Page/The Rolling Stones]] (i.e., another page from
> the one you are trying to edit) if you're unlucky.
> 
> 
> peace.

so here is what i mean: if you click on the page outside the "edit notice", nothing happens.
if you click on the edit notice itself, then it depends: 
some parts of the edit notice are links (including the images), and will take you elsewhere. there is no indication, because the edit notice as a whole has "cursor: pointer;" css attribute, so the mouse pointer looks the same everywhere on the edit notice. clicking somewhere which is not a link will close the notice, and clicking somewhere which *is* a link will take you elsewhere. again, there is little indication - e.g., moving the mouse into and out of images does not give any visible sign.
clicking on the little "page notice" link *inside* the notice takes you elsewhere, while clicking on the "1 notice" on the toolbar closes the notice.
very confusing.

(btw: the notice itself seems to be anchored to the toolbar rather than to the page, which is exactly what's needed for the "please wait" image and for the wikitext popup).

peace.
In an (un)ordered list nested in a table I am unable to edit wikilinks. While hovering above a wikilink the wikilink is an active weblink, instead of showing the icon of the link inspector, see URL.

--------------------------
**Version**: unspecified
**Severity**: minor
**URL**: https://test.wikipedia.org/wiki/User:Raymond/nested
*** Bug 52285 has been marked as a duplicate of this bug. ***
Block nodes (like lists) in inline positions (like in <small>) get alienated as inline aliens. These inline aliens then don't get shields and phantoms with the right dimensions. One way to fix that could be to make alienInline display:inline-block instead of display:inline, which seems to fix the dimensions of the shield, but we'd have to carefully evaluate that as it would potentially impact a lot of things.
From the mailing list

> from:	 planetenxin <planetenxin@web.de> via gmail.com 
> reply-to:	 Wikimedia developers <wikitech-l@lists.wikimedia.org>
> to:	 wikitech-l <wikitech-l@lists.wikimedia.org>
> date:	 Sun, Jul 21, 2013 at 10:15 PM
> subject:	 [Wikitech-l] Git Proxy Error

> Hi folks,
> I'm constantly getting the following error on https://git.wikimedia.org/:
> Proxy Error
> The proxy server received an invalid response from an upstream server.
> The proxy server could not handle the request GET /.
> Reason: Error reading from remote server
>/Alexander

--------------------------
**Version**: unspecified
**Severity**: normal
**See Also**:
https://bugzilla.wikimedia.org/show_bug.cgi?id=51656
https://bugzilla.wikimedia.org/show_bug.cgi?id=49371
The gitblit software powering git.wikimedia.org is in the process of being replaced by Phabricator Diffusion. See:

{T111465}
Project: #gitblit-deprecate
Maybe http://git.zx2c4.com/cgit/about/ might be an alternative to gitblit as its main design criterion is speed and caching.
Just a heads-up: Upstream in https://code.google.com/p/gitblit/issues/detail?id=274 asks "for discussion with Wikimedia folks on how to improve caching since the current strategy is not ideal".
max semenik reported that gitblit should mark critical links with rel="nofollow"
mark configured the misc varnish cluster for gitblit: https://gerrit.wikimedia.org/r/#/c/78262/
browser cache problem reported upstream and fixed, see here:
https://code.google.com/p/gitblit/issues/detail?id=274
https://gerrit.wikimedia.org/r/#/c/78919/

As soon as the bot picks up th new copy of the robots.txt file that should take care of it for now.
faidon lambiotis restarted it a couple of hours ago withoutout tracing it seems? and now its dead again.
Stupid question: is crawl-delay in robots.txt worth trying?
before restarting the java process, could you trace it with:
* jps -l to find out the process id
* strace to see if it excessivly calls into the operating system
* jstack
* kill -QUIT <p> to print the stacktrace
* jmap -heap <p> to find memory usage
* jmap -histo:live <p> | head to find excessivly used classes
* if you have ui, you might try jconsole or http://visualvm.java.net as well

you might want to set the java -XX:+HeapDumpOnOutOfMemoryError parameter when starting, so it writes a heap dump early enough. it can be analyzed with jhat.
down again at the moment... i think gitblit might behave nicer in case bots overloading it.
Back up again at the moment...
(In reply to comment #34)
> created a bug at gitblit:
> https://code.google.com/p/gitblit/issues/detail?id=294.

No need for that, I've already been in contact with upstream. It's mainly being overloaded from Googlebot.
created a bug at gitblit: https://code.google.com/p/gitblit/issues/detail?id=294.
As reported by OsamaK last night in #wikimedia-tech and again today by rupert THURNER on wikitech-l (and I personally confirmed last evening), git.wikimedia.org is down yet again.

---
$ time curl https://git.wikimedia.org/
<!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML 2.0//EN">
<html><head>
<title>502 Proxy Error</title>
</head><body>
<h1>Proxy Error</h1>
<p>The proxy server received an invalid
response from an upstream server.<br />
The proxy server could not handle the request <em><a href="/">GET&nbsp;/</a></em>.<p>
Reason: <strong>Error reading from remote server</strong></p></p>
</body></html>

real	12m1.522s
user	0m0.010s
sys	0m0.026s
---
For the records: https://gerrit.wikimedia.org/r/#/c/78243/
(By the way: Ariel & Daniel, thanks for keeping this ticket updated.)
chad fixed up service of robots.txt and we've unblocked the google bot.  Waiting for verification that google has picked up the file and we'll see how performance looks after that.
(Resetting severity & priority as long as things are working again.)
merged this:

https://gerrit.wikimedia.org/r/#/c/77909/1/templates/apache/sites/git.wikimedia.org.erb

and:

08:42 mutante: on overloaded antimony: stopped gitblit, ran puppet, blocked Googlebot, restarted apache and gitblit
08:22 mutante: git.wikimedia.org back
08:21 mutante: attempted to restart gitblit on antimony 

01:44 < mutante> apergos: oh.. Googlebot-Image/1.0 != Googlebot ?
01:44 < apergos> no
01:44 < apergos> googlebot is the one that rate limited
01:44 < apergos> that should be enough, it's the /zip/ paths primarily that were the problem
01:44 < mutante> Googlebot-Image is the one still being very active
01:44 < mutante> ok
01:44 < apergos> it's minor compared to the rest
01:44 < mutante> alright
01:44 < apergos> I did a count from the logs yeasterday
01:45 < mutante> now YandexBot kicking in :)
01:45 < apergos> please note it on the bz report so we don't forget
01:46 < mutante> java CPU usage isn't > 500% anymore though :)
Turns out that we were serving an empty robots.txt even though there is content. Logs show lots of:
[Wed Aug 07 21:44:15 2013] [error] [client XXX.XXX.XXX.XXX] proxy: Error reading from remote server returned by /robots.txt

Chad says this is likely due to some fancy proxy rewriting sending everything to gitblit.  In the meantime the google folks have cut back both parallel open connections and req/sec until we have this sorted and can give them the heads up.
I'm talking to the folks at google about it, will update as soon as I have more info.
Google is the one misbehaving.
(In reply to comment #24)
> > Do the misbehaving bots respect robots.txt?
> 
> Nope.

Just to be clear, I hope that you block whatever wished and needed except Google (so that we have at least one search engine).
(In reply to comment #23)
> (In reply to comment #22)
> > So bots aren't going to be allowed to index gitblit anymore since they can't
> > seem to behave.
> 
> Do the misbehaving bots respect robots.txt?

Nope.
(In reply to comment #22)
> So bots aren't going to be allowed to index gitblit anymore since they can't
> seem to behave.

Do the misbehaving bots respect robots.txt?
So bots aren't going to be allowed to index gitblit anymore since they can't seem to behave.
(In reply to comment #20)
> Down again?

Indeed. :-(

---
$ time curl https://git.wikimedia.org/
<!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML 2.0//EN">
<html><head>
<title>502 Proxy Error</title>
</head><body>
<h1>Proxy Error</h1>
<p>The proxy server received an invalid
response from an upstream server.<br />
The proxy server could not handle the request <em><a href="/">GET&nbsp;/</a></em>.<p>
Reason: <strong>Error reading from remote server</strong></p></p>
</body></html>

real	12m2.101s
user	0m0.010s
sys	0m0.028s
---
Down again?
Restarted service.
(In reply to comment #17)
> It's again inaccessible (my browser doesn't receive any reply) with antimony
> at 100 % load.

Confirmed that git.wikimedia.org is inaccessible currently; no idea about antimony's load.

Re-opening this bug as it's no longer resolved. Thank you, Nemo, for commenting here.

---
$ time curl https://git.wikimedia.org/
<!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML 2.0//EN">
<html><head>
<title>502 Proxy Error</title>
</head><body>
<h1>Proxy Error</h1>
<p>The proxy server received an invalid
response from an upstream server.<br />
The proxy server could not handle the request <em><a href="/">GET&nbsp;/</a></em>.<p>
Reason: <strong>Error reading from remote server</strong></p></p>
</body></html>

real	12m43.815s
user	0m0.010s
sys	0m0.024s
---
It's again inaccessible (my browser doesn't receive any reply) with antimony at 100 % load.
Closing this as resolved/fixed for now.
So, it's a little sluggish still but it's at least staying up. Did some more puppetizing and blocked some misbehaving spiders that were causing it to fall over all the time.

Still want to up the heap and see if we can get some better performance out of it.
I've got some new caching stuff that landed in master just for us :) Looking at turning that on today as well.
(In reply to comment #5)
> For the record, it doesn't seem to be completely down, just really slow to
> respond.

To me it just serves "Internal error" messages. When CPU usage goes down a bit, you may happen to get some content, maybe curl is just being very patient and retrying a lot till that happens.
(In reply to comment #10)
> git.wikimedia.org continues to be broken. This is very frustrating.

You're telling me :(
We cant take stack trace right now since gitblit is running with Java 6 and we are missing the jstack utility.  That is bug 51859.
git.wikimedia.org continues to be broken. This is very frustrating.
(In reply to comment #8)
>  14:42 apergos: (btw docs would be nice, is that really the right way to kick
> it?)
> 14:42 apergos: shot and restarted gitblit: on antinomy, cd /var/lib/gitblit,
> java -jar gitblit.jar & (see bug 51769) 
> 
> Can we help Ariel out? :)

Peachey88 helpfully created <https://wikitech.wikimedia.org/wiki/Git.wikimedia.org> and <https://wikitech.wikimedia.org/wiki/Gitblit>. Thank you, Peachey88!
14:42 apergos: (btw docs would be nice, is that really the right way to kick it?)
14:42 apergos: shot and restarted gitblit: on antinomy, cd /var/lib/gitblit, java -jar gitblit.jar & (see bug 51769) 

Can we help Ariel out? :)
This seems to be an issue again.
Restarted the service again. Nothing was suspicious in the logs, but CPU was pegged at 100% :\
It's happening again. :-(

$ time curl https://git.wikimedia.org
<!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML 2.0//EN">
<html><head>
<title>502 Proxy Error</title>
</head><body>
<h1>Proxy Error</h1>
<p>The proxy server received an invalid
response from an upstream server.<br />
The proxy server could not handle the request <em><a href="/">GET&nbsp;/</a></em>.<p>
Reason: <strong>Error reading from remote server</strong></p></p>
</body></html>

real	12m1.110s
user	0m0.015s
sys	0m0.021s
Restarted the service. Two things:

A) I'm doing some logging this time so I can figure out why it's crashing
B) I'm going to finish puppetizing and packaging this starting tomorrow so it'll take care of this better

Hopefully we can find an easy fix for this, but (B) is necessary anyway.
git.wikimedia.org being down is highly disruptive to support work in #mediawiki.
This is probably a duplicate of bug 51656, but I'll just add that bug as a see also to this bug.

Confirming the current issue:

$ curl https://git.wikimedia.org/
<!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML 2.0//EN">
<html><head>
<title>502 Proxy Error</title>
</head><body>
<h1>Proxy Error</h1>
<p>The proxy server received an invalid
response from an upstream server.<br />
The proxy server could not handle the request <em><a href="/">GET&nbsp;/</a></em>.<p>
Reason: <strong>Error reading from remote server</strong></p></p>
</body></html>
Could we have a way to bypass the browser blacklist. e.g.
1. a user preference to ignore the blacklist during initialisation, or
2. ?debug=true bypasses blacklist,
3. a test-wiki where the blacklist is empty/ignored, or
4. a simple way to re-run VE init from JS console

This will allow mere mortals to help identify bugs with unsupported browsers.

For option four, we can modify the blacklist, like so:

JS> delete mw.libs.ve.blacklist.opera;

But im not sure what to do after that.

--------------------------
**Version**: unspecified
**Severity**: enhancement
**See Also**:
https://bugzilla.wikimedia.org/show_bug.cgi?id=55900
The code for this enhancement request had already been written before the bug rasied, but wasn't deployed at that time.
https://gerrit.wikimedia.org/r/#/c/74574/
Changing from INVALID to FIXED, but maybe it is a dup of another bug?
You can already bypass the blacklist by using ?vewhitelist=1 - sorry, we should document this somewhere!
For anyone wanting to bypass it on browser with a decent JS debugger, set a breakpoint on the line 'mw.libs.ve = init' in 

https://bits.wikimedia.org/static-1.22wmf10/extensions/VisualEditor/modules/ve-mw/init/targets/ve.init.mw.ViewPageTarget.init.js

Then execute
JS> delete init.blacklist.opera

And resume running the VE scripts.

Im guessing this isnt possible on most mobile browsers, so one of option 1-3 or similar would be useful.
When a page with blocks of pre-formatted text that use the leading space in wikitaxt is edited in Visual Editor there are various issues trying to remove the pre-formatted blocks. https://en.wikipedia.org/w/index.php?title=User:Thryduulf/sandbox&oldid=565085889 can be used for testing.

* It is not possible to delete a block on the first line of a page
* When the pre-formatted block follows a mutli-line template, that template is deleted and the contents of the pre-formatted block becomes normal text on the line above where the template as, appended to any text that was already there.
* When the pre-formatted block follows a normal line of text or a single line template the contents of the block are appended to the end of that line.
* When the block follows indented text, the contents are appended to the last line of the indented block, even if that is a line that doesn't exist in wikitext (see {T52995})
* When the block follows an ordered or unordered list, the text is appended to the last line of the last item in the list
*When the block follows an image, the contents are appended to the image caption. This is probably depends on {T53624} and so I would expect the same behaviour with tables, but I have not tested that.
*If the block follows another pre-formatted block, the contents gets appended to the end of that block.

In all cases this can be worked around by inserting and then backspacing a new line at the start of the block.

In cases when there is a line of normal text, a blank line or a single line template before the pre-formatted block then pressing delete at the end of that line appends the contents of the block at the cursor position as normal text.

The differing behaviour of single and multi-line templates may be related to {T53708}

--------------------------
**Version**: unspecified
**Severity**: normal
Most of these workflows now work correctly. A few of them don't, so I've filed them separately as T106905 and T106902.
I also see instances where [[https://it.wikipedia.org/w/index.php?title=Giorgio_Summaripa&diff=72637884&oldid=72353193|a space pre was *added* ]] while inserting an image around a paragraph. Or maybe that's T68628?
>>! In T53758#1088912, @Aklapper wrote:
>> * When the pre-formatted block follows a mutli-line template, that template is deleted and the contents of the pre-formatted block becomes normal text on the line above where the template as, appended to any text that was already there.
> 
> When exactly is "that template deleted"? Already by loading the page in VisualEditor? If so I fail to reproduce...

From memory, what I meant by that was that when you have a template that produces more than one line of text that is immediately followed by a block of pre-formatted text that uses the leading space method (i.e. not <pre> tags), removing the leading space also deletes the preceding template and the linebreak between the template and the paragraph above the template. i.e.

Paragraph one.
Template
[space]two

becomes

Paragraph one.two

when you try to delete [space]. I don't have time now to test whether this still happens.
> * It is not possible to delete a block on the first line of a page

I managed after removing the text and then putting the cursor in front of the "Section 1" heading and pressing Backspace.

> * When the pre-formatted block follows a mutli-line template, that template is deleted and the contents of the pre-formatted block becomes normal text on the line above where the template as, appended to any text that was already there.

When exactly is "that template deleted"? Already by loading the page in VisualEditor? If so I fail to reproduce...
In this edit https://en.wikipedia.org/w/index.php?title=Morse_code&diff=571916446&oldid=571809074 the multiple leading spaces of a pre-formatted block have been removed while a totally unrelated line was being edited.  The edit summary gives no indication that this was done deliberately so I am assuming this was the result of a bug in VisEd.
In my volunteer mode, I was removing content that was copied from an external site. I didn't add any content at all, but simply deleted text (and a template) and merged the resultant material into a single paragraph.

VisualEditor flagged this as my adding wikimarkup and gave me the nowiki warning. :)

See http://en.wikipedia.org/wiki/File:Wikimarkup_warning_without_case.png which is confusingly titled, because I missed the "u" in "cause."

--------------------------
**Version**: unspecified
**Severity**: normal
Verified in betalabs.
Change 175336 merged by jenkins-bot:
Replace hacky wikitext warning listener with sequences

[[https://gerrit.wikimedia.org/r/175336]]
Change 175336 had a related patch set uploaded (by Catrope):
Replace hacky wikitext warning listener with sequences

[[https://gerrit.wikimedia.org/r/175336]]

#patch-for-review
Fixing this would cause a serious performance penalty for minor improvement in the user experience. WONTFIXing.
I get this error by adding anything to the second paragraph (beginning "VisualEditor" at https://office.wikimedia.org/w/index.php?title=User:Mdennis/sandbox&oldid=105896  There are preëxistng (intentional) nowiki's in this paragraph, which may the cause.
From bug 53661:
The Wikitext warning is triggered in some circumstances without the user having
entered Wikitext. The one cause I can reliably reproduce is where there is
nowikied markup on the page from a previous edit.

To reproduce:
1. Load
https://en.wikipedia.org/w/index.php?title=User:Thryduulf/sandbox3&oldid=571089410&veaction=edit
2. Click anywhere on the last line of Section number two (the line that
contains "[[Manhatan]]" and an ISBN, both of which are enclosed in nowiki
tags). 

It seems that the warning is triggered by the existence of wikitext markup in
the VE editing surface, rather than by its addition.
*** Bug 53661 has been marked as a duplicate of this bug. ***
As a follow-up to bug 49428 and bug 50771, default whitespace for headings should includespaces before/after ==.

Or in other words: prefer "== Heading ==" to "==Heading==".

(While this might seem minor, the first style was enforced at pl.wp with automated tools since ever and editors gets annoyed when VE changes it. Reported at https://pl.wikipedia.org/wiki/Wikipedia:VisualEditor/Opinie#sprz.C4.85tanie_kodu )

--------------------------
**Version**: unspecified
**Severity**: enhancement
Change 101318 merged by GWicke:
(Bug 51744) Add space around = chars in new headings

https://gerrit.wikimedia.org/r/101318
Change 101275 merged by GWicke:
Merge "(Bug 51744) Add space around = chars in new headings"

https://gerrit.wikimedia.org/r/101275
Change 101318 had a related patch set uploaded by GWicke:
(Bug 51744) Add space around = chars in new headings

https://gerrit.wikimedia.org/r/101318
Change 101275 had a related patch set uploaded by GWicke:
Merge "(Bug 51744) Add space around = chars in new headings"

https://gerrit.wikimedia.org/r/101275
Yes. Will be deployed today. Closing this bug now.
I assume this is fixed now? Thank you!
Change 96790 merged by jenkins-bot:
(Bug 51744) Add space around = chars in new headings

https://gerrit.wikimedia.org/r/96790
Change 96790 had a related patch set uploaded by Subramanya Sastry:
(Bug 51744) Add space around = chars in new headings

https://gerrit.wikimedia.org/r/96790
(In reply to comment #5)
> I assume these
> extra spaces will not be an issue on enwp and doesn't violate any style
> guidelines there?

No, per [[MOS:HEAD]], "Spaces between the equal signs and the heading text are optional, and will not affect the way the heading is displayed". It doesn't mention anything about them being uncool, and most of the wikis I frequent use them for readability.
Okay, I started to tackle this. The basic fix is quite simple, but it introduces a ton of noisy diffs in our parser tests and it will likely introduce a lot of noisy diffs in roundtrip testing as well. We could fix our testing infrastructure to ignore them, but a better solution is to leave existing headings untouched.

I can instead add this rule on new headings and leave old headings untouched.

But, looking at pages on enwp, I see (by clicking around on a about 10 "random" pages) that most headings don't use spaces after/before "==". I assume these extra spaces will not be an issue on enwp and doesn't violate any style guidelines there?
The French Wikipedia would be interested in this change as well, since they use a lot of "extra" spaces, and the headers are no exception.
(In reply to comment #2)
> (In reply to comment #1)
> > It would be very helpful if you can provide a list of any other default
> > whitespace rules for other wikitext elements.  It is simpler to implement
> > this
> > in one shot rather than piecemeal.
> 
> Sorry, I post these when I notice Parsoid is doing things not in my way :)

Thats okay.  I was not complaining, just making a request. :).  

You can test existing Parsoid behavior @ http://parsoid.wmflabs.org/_html/ and report what needs fixing.
(In reply to comment #1)
> It would be very helpful if you can provide a list of any other default
> whitespace rules for other wikitext elements.  It is simpler to implement
> this
> in one shot rather than piecemeal.

Sorry, I post these when I notice Parsoid is doing things not in my way :)


> Right now, we cannot implement different rules for different wikipedias, but,
> if necessary, something that we could consider at a later point.  So, can you
> also include some information, if you have, about whether the style rules are
> universal or specific to pl.wp?

Yeah, of course. No idea if any other wikis use any similar cleanup tools as pl.wp, but in general more whitespace is more readable than less (wikitext is just like code in this regard :) ).

The tools pl.wp uses is [[pl:MediaWiki:Gadget-sk.js]], but be aware that it also includes some non-code cleanup and some pl.wp-specific rules for template replacements etc.
It would be very helpful if you can provide a list of any other default whitespace rules for other wikitext elements.  It is simpler to implement this in one shot rather than piecemeal.

Right now, we cannot implement different rules for different wikipedias, but, if necessary, something that we could consider at a later point.  So, can you also include some information, if you have, about whether the style rules are universal or specific to pl.wp?
**Author:** `lunarjam.mcgahan`

**Description:**
Wikipedia VE bug Reference with no parameter tags not editable in Chrome on Win7

See attached Word document Wikipedia VE bug Reference with no parameter tags not editable in Chrome on Win7

--------------------------
**Version**: unspecified
**Severity**: normal

**Attached**: {F11354}
Today it seems to work well. (Firefox 42)
Or I have not undestood.
*** Bug 65593 has been marked as a duplicate of this bug. ***
This is similar to bug 33105 and bug 41193, but this bug is more specific as it is within the same window.

Steps to reproduce:
1. Create a reference with '[http:example.com example], publisher, year'
2. Open dialog for reference created in step 1
3. Copy the richtext reference and close the dialog
4. Insert reference anywhere, and paste the clipboard

Results:
Plain text paste 'example, publisher, year'

Expected results:
Richtext paste '[http:example.com example], publisher, year'
**lunarjam.mcgahan** wrote:

Further information

See attachment Bug 51725 further explanation

**Attached**: {F11355}
That ref is only on one page, in English and Thai
https://www.google.com.au/search?q="History of the Vardo"+site:wikipedia.org

And I was able to do a basic edit to that ref on Chrome Version 28.0.1500.72 m/Windows 7 Enterprise SP1, in Vector and Monobook

https://en.wikipedia.org/w/index.php?title=Recreational_vehicle&diff=565400866&oldid=565097139

https://en.wikipedia.org/w/index.php?title=Recreational_vehicle&diff=565401640&oldid=565400866

https://th.wikipedia.org/w/index.php?diff=5049776&oldid=4731458

There must be something more specific needed to reproduce this.
The contents of the attached Word document, to the extent that LibreOffice will display them, seem to be:

The source code is as follows:
<ref>[http://gypsywaggons.co.uk/varhistory.htm "History of the Vardo (Gypsy Caravan)"], ValleyStream Media, 2009</ref>

Was there a screenshot that you meant to include? Could you give us a link to the article? Could you explain the problem in more detail?
When MathJax is enabled we should render a <span> containing TeX, instead of an image.

--------------------------
**Version**: unspecified
**Severity**: normal
MathJax support is discountinued T99369
Mathjax is interesting for ZIM files and Kiwix because this would allow to reduce bandwidth/storage usage. Hope this is still on the Parsoid roadmap.
MathJax only works with Presentation MathML: 
http://www.mathjax.org/resources/faqs/#problem-content

It also accepts only Presentation MathML as input. 

We might actually be better off using LaTeXML (https://www.mediawiki.org/wiki/Extension:Math#LaTeXML) to generate Content MathML. LaTeXML provides a web service that we could probably use directly. SVG can be generated with dvisvg from the TeX source. Afaik this is already used in the math extension.
Just had a meeting with Gerardo Capiel in which we also talked about math. He was involved in a node / MathJax prototype that renders to SVG plus a textual description of the formula suitable for screen readers. It might be possible to use that to avoid the need for client-side rendering altogether:

* Content MathML as primary rendering for indexing and good rendering in Firefox
* Server-generated SVG fallback for fast rendering on other browsers
* Textual description for screen readers
* tex in data-mw for editing

The fall-back selection needs to be worked out, and might depend on JS. Compared to client-side rendering from TeX with MathJax this should be pretty fast. Ideally the DOM will not be modified, so that copy&pasting from a read-only page into an editor preserves all information.
Very relevant: http://arxiv.org/abs/1304.5475

How does the MathML generated by MathJax compare to the 'content MathML' generated by LaTeXML? Is it purely presentational MathML?
We currently render as PNG with the tex available in an attribute. It would be nicer both for semantic information / indexing purposes and copy / pasting to render as MathML instead. MathJax could be used server-side to generate the MathML from tex, and client-side as a polyfill to provide HTML+CSS (or image?) rendering for browsers that don't support MathML well.

Copy / pasting native MathML seemed to work quite well the last time I tried it in Firefox and vanilla contenteditable. MathJax-inserted HTML+CSS will likely not do so well unless we preserve the MathML and especially the tex in the data-mw attribute. At least entire formulas could be copy/pastable that way though.
Thanks for pointing me to this thread, Gabriel. 

Let me add https://bugzilla.wikimedia.org/show_bug.cgi?id=48036. 

If there's PNG+TeX in the page, then MathJax can replace the image on the fly. That will produce a nice user experience as the math will always be visible and only improve once MathJax is done (cf this Chrome extension https://chrome.google.com/webstore/detail/wikipedia-with-mathjax/fhomhkjcommffnlajeemenejemmegcmi).

For the OP, I should point out that MathJax preprocessing will remove the spans and insert its script tags, so you might want to insere those directly see http://docs.mathjax.org/en/latest/model.html#how-mathematics-is-stored-in-the-page.
From IRC discussion with pkrautzberger it seems that we could actually use MathJax directly to convert tex to MathML without calling the API at all. Some work is still needed though:

[17:03] <gwicke> do you have a node package?
[17:03] <pkrautzberger> ah. no. The problem is that MathJax requires a dom  right now. But we plan to liberate parts.
[17:03] <gwicke> we have a dom
[17:03] <pkrautzberger> (a lot functionality doesn't make sense outside the DOM).
[17:04] <gwicke> domino currently
[17:04] <pkrautzberger> but TeX2MathML conversion could be isolated easily (MathML to SVG not as easily). BTW our internal format is MathML.
[17:04] <gwicke> it only implements DOM4 in case that makes a difference
[17:04] <pkrautzberger> I'm not sure if dom4 would be a problem.
[17:04] <pkrautzberger> but we've seen people use dom runners.
[17:04] <gwicke> we could also use JSDom for math if that helps
[17:05] <gwicke> supports the other levels
[17:05] <gwicke> and script tag execution
[17:05] <pkrautzberger> well, ideally we could just isolate that from the dom.
[17:05] <pkrautzberger> but yes, I know someone who got jsdom to work with MathJax.
[17:06] <gwicke> ah, that sounds promising
See bug 52031.
Have we filed a bug against the mw api to support this?
From IRC discussions:

It appears that supporting this on the Parsoid end would definitely require an update to the mw api so we can pass in options to the extension (something like action=callextensiontag&attributes=...&options=...)

In addition, if the math extension doesn't accept output rendering options (except via config settings), the extension itself will need an update to support this.

Once both are present, Parsoid can emit mathml.
With VE's JS requirements we can just force everyone to use the MathJax rendering when editing, makes things a lot simpler and both ends, and means we don't need to round-trip to re-render.
http://it.wikipedia.org/wiki/Utente:Elitre_%28WMF%29/Sandbox?veaction=edit

This was actually discussed on IRC by Inez, subbu, gwicke on July 3rd, I might provide that part of the log if useful.

--------------------------
**Version**: unspecified
**Severity**: normal
**URL**: http://parsoid.wmflabs.org/it/Utente:Elitre_(WMF)/Sandbox
Change 87272 merged by jenkins-bot:
Add 'MemoryAlpha' namespace for parser tests.

https://gerrit.wikimedia.org/r/87272
Change 87272 had a related patch set uploaded by Cscott:
Add 'MemoryAlpha' namespace for parser tests.

https://gerrit.wikimedia.org/r/87272
Change 87203 merged by jenkins-bot:
ParserTests: allow test of precedence between interwiki links and namespaces

https://gerrit.wikimedia.org/r/87203
Change 86872 merged by jenkins-bot:
Bug 51680: Give preference to namespaces over interwiki prefixes

https://gerrit.wikimedia.org/r/86872
Change 87203 had a related patch set uploaded by Cscott:
ParserTests: allow test of precedence between interwiki links and namespaces

https://gerrit.wikimedia.org/r/87203
Change 86872 had a related patch set uploaded by Marcoil:
Bug 51680: Give preference to namespaces over interwiki prefixes

https://gerrit.wikimedia.org/r/86872
I have a patch for this one, taking it.
Namespace prefixes need to take precedence over interwiki prefixes in Parsoid, as is the case in the PHP parser.
Can't reproduce on enwp for obvious reasons.
Created attachment 12996
screenshot of adding a wikipedia: link

**Attached**: {F11284}
This is because Parsoid sees [[Wikipedia:VisualEditor/Cosa_cambia]] as a link to [[VisualEditor/Cosa_cambia]] on interwiki "Wikipedia" (i.e., the English Wikipedia). Whoops.
An IP user on the English Wikipedia reports the following slightly alarming bug:

"After I edited text near a link, "♙♙♙♙♙♙♙" characters started appearing around once a second, and I couldn't stop them or delete them."

Based on another bug report left a few minutes later by the same user they were using MobileSafari on iPad 2 with iOS 6.1.3

I can't replicate this in Firefox on a Linux PC and don't have an iPad to test on.

--------------------------
**Version**: unspecified
**Severity**: normal
**OS**: other
**Platform**: Tablet PC
**See Also**:
https://bugzilla.wikimedia.org/show_bug.cgi?id=50465
Seems to work for me now. Tested on Beta Cluster using iOS Safari 8.0 on an iPad.
(In reply to comment #0)
> An IP user on the English Wikipedia reports the following slightly alarming
> bug:
> 
> "After I edited text near a link, "♙♙♙♙♙♙♙" characters started appearing
> around
> once a second, and I couldn't stop them or delete them."
> 
> Based on another bug report left a few minutes later by the same user they
> were
> using MobileSafari on iPad 2 with iOS 6.1.3
> 
> I can't replicate this in Firefox on a Linux PC and don't have an iPad to
> test
> on.

Since you asked,in VE test edit we had encountered it at mr wiki http://mr.wikipedia.org/w/index.php?title=तेकिर्दा_प्रांत&diff=prev&oldid=1189390 When I increased space.I suppose developers already may be taking care of this.

I suppose en wiki maya be needs to track nowikis with better targeted edit filters for space and other mark up aspects.Thats my guess.
The parameter search is case sensitive, requiring all lowercase input

When searching for parameters in the transclusion/template editor the search returns "Unknown parameter" unless the search term is entirely lowercase.

--------------------------
**Version**: unspecified
**Severity**: normal

**Attached**: {F11271}
Done by gerrit 117305.
*** Bug 52950 has been marked as a duplicate of this bug. ***
After a moments though I wonder if this might be the same issue as bug 51670, with the search requiring input that matches the parameter as defined in the source (which the VE user has no way of knowing) rather than the title as displayed in the parameter list.
Lack of "remove template" button in a 1366x480px Firefox 22 window on Xubuntu Linux

In the Visual Editor template/transclusion editor the list of parameters obscures the "remove template" button so that it can only be clicked if you enter the name of a non-existant parameter into the search box. See attachment to bug 51671

Even this does not help when the window is too small for it to be displayed (see attachment).

Both problems could be solved by either: 
*making the window scroll (separately from making the parameter list scroll); and/or
*moving the "Remove template" button next to the "save changes" button (which would probably be more logical than placing it under "options" - see also bug 51135).

--------------------------
**Version**: unspecified
**Severity**: enhancement
**See Also**:
https://bugzilla.wikimedia.org/show_bug.cgi?id=51739
https://bugzilla.wikimedia.org/show_bug.cgi?id=51135

**Attached**: {F11269}
The button has now been moved to the right of the template or parameter's name.
(In reply to comment #2)
> The problem is that button removes the single template that the pane is
> about,
> not the entire transclusion (which can cover from one template to thousands)
> -
> the dialog footer buttons are meant to apply to the entire dialog's subject,
> not just the bit you're currently looking at.

Ah rights, yes that does make sense

> However, maybe it could be up in the top-right, alongside the name of the
> template you've currently got selected?

Right aligned on the same line as the template name / parameter name (for remove parameter) does seem like the best. Need to make sure that it doesn't collide with a long template/parameter name though.
(In reply to comment #0)
> *moving the "Remove template" button next to the "save changes" button (which
> would probably be more logical than placing it under "options" - see also bug
> 51135).

The problem is that button removes the single template that the pane is about, not the entire transclusion (which can cover from one template to thousands) - the dialog footer buttons are meant to apply to the entire dialog's subject, not just the bit you're currently looking at.

However, maybe it could be up in the top-right, alongside the name of the template you've currently got selected?
The fix to bug 51739 has made this less of an issue, in that the remove template button can be accessed by scrolling to the very bottom of the list. I still think the button would be better placed next to the "save changes" button though.

Changing from a bug to an enhancement accordingly.
A user on the English Wikipedia reports two problems when attempting to drag and drop an image.
"Problem 1: Clicking on a media file and dragging the mouse causes the cursor to change to the "I'm moving an image" icon, but the image doesn't actually move. I can only move an image if I click it once to select it, then click and hold.

Problem 2: If I move an image a small enough distance across the screen that it doesn't actually move, I can't move it again unless I deselect it and then reselect it."

They are using Firefox 21, I can confirm both problems in Firefox 22.

--------------------------
**Version**: unspecified
**Severity**: enhancement
**See Also**:
https://bugzilla.wikimedia.org/show_bug.cgi?id=54472
Specifically, this was fixed by Ed's changes to clickable nodes last week.
This doesn't appear to be a problem in master.
fwiw about Problem 1 the same happens with text based templates. Tested with the template {{languages}} at the top of the page at https://www.mediawiki.org/wiki/Groups
Some suggestions about dragging from Adam C.:
"If I might suggest, if dragging isn't possible, why not just make it that when you select an image, you have a few buttons. A left arrow to move it left, a right arrow to move it right, a menu button between them that'll give you the chance to edit image properties (and to set the rarely-used centre), ideally a way to directly edit the caption without entering a menu, and perhaps a little drag bar at the top for moving it vertically? (Having a standardised place to grab and drag would be an excellent idea, by the way.I'd suggest adding a little bar at the top of an element when it's clicked on.)".
/**
 * Creates an ve.Element object.
 *
 * @class
 * @abstract
 *
 * @constructor
 */
ve.Element = function VeElement

These and everything like are useless (not really explaining anything) and annoying (gets you excited to see a line of text only to find out its nothing) and makes the jsduck --nodoc utility unusable since a lot of things without documentation aren't without documentation.

So, henceforth, it is "okay" for a doc block to be just tags with no description on top (or even just /** */ with nothing, which is all jsduck needs to include a property in its index).

I (or someone else) will be ridding these at some point, but lets try and not duplicate them more (I won't take "consistency" as an argument here when creating something that is like something else that has a useless description, fill it in or don't copy it, don't spread the virus).

Thanks

--------------------------
**Version**: unspecified
**Severity**: enhancement
Change 146523 merged by jenkins-bot:
Remove useless documentation, add more useful documentation

https://gerrit.wikimedia.org/r/146523
Change 146523 had a related patch set uploaded by Krinkle:
Remove useless documentation, add more useful documentation

https://gerrit.wikimedia.org/r/146523
Change 125036 merged by jenkins-bot:
Get rid of useless comments for classes

https://gerrit.wikimedia.org/r/125036
Change 125036 had a related patch set uploaded by Krinkle:
Get rid of useless comments for classes

https://gerrit.wikimedia.org/r/125036
Note that there is one (exactly one) piece of useful information in that comment: @abstract
mw.gettingStarted.logging.getPageSchemaAction returns the wrong values for VE.  For instance, it returns page-impression when the VE edit screen is open.

--------------------------
**Version**: unspecified
**Severity**: normal
>>! In T53634#991958, @Halfak wrote:
> @aklapper  Hmm..  This should not be assigned to me.  I'm not sure how that happen.  

See https://old-bugzilla.wikimedia.org/show_bug.cgi?id=51634 - it was assigned to you in 02/2014.

Unassigning (you can also do that) and lowering priority here.
@aklapper  Hmm..  This should not be assigned to me.  I'm not sure how that happen.
>>! In T53634#544033, @Mattflaschen wrote:
> getPageSchemaAction has been removed entirely, so I'm tempted to close this.  However, we will need to revisit if we want to track something like "edit impressions" again.

@Halfak: Still working on this? If yes what's the progress, if no should the assignee be reset and is "high priority" still correct here?
As part of the new VE tests we will need to have reliable instrumentation (adding Nuria and James to make sure they are aware of this change).
getPageSchemaAction has been removed entirely, so I'm tempted to close this.  However, we will need to revisit if we want to track something like "edit impressions" again.
When this is fixed, we should also try to put back page-save-attempt and page-save-success for both (we might do it just for wikitext again in the meantime).
Yes, good catch.  VE doesn't touch wgPostEdit, which we're using, at all.
**swalling** wrote:

Would this impact page-save-success logging for VE?
If a stub template includes an image size declaration that includes "px" then that image is shown at native resolution in the editor.

This was observed with [[Template:Cornwall-stub]] which originally had the code:
{{asbox
| image     = Flag of Cornwall.svg
| pix       = 30px
| subject   = [[Cornwall]]
| category  = Cornwall stubs
| name      = Template:Cornwall-stub
}}

When the "pix" parameter was changed to just "30" [https://en.wikipedia.org/w/index.php?title=Template:Cornwall-stub&diff=564819917&oldid=547286019] as was used by e.g. [[Template:Nigeria-stub]] the image size was displayed correctly. The icon has been rendering at correct size when rendered for reading, presumably since [https://en.wikipedia.org/w/index.php?title=Template:Cornwall-stub&diff=next&oldid=235904748 2009]. 

Interestingly it renders as intended in VE when the template is initially placed, but does on every subsequent time it's opened in VE.

Feel free to use [[User:Thryduulf/stubtemplate]] for testing (I'll leave it up at least until this bug is closed) as I have altered the actual Cornwall-stub template.

--------------------------
**Version**: unspecified
**Severity**: normal
**See Also**:
https://bugzilla.wikimedia.org/show_bug.cgi?id=51826
Change 114345 merged by jenkins-bot:
Support trailing 'pxpx' in image size options.

https://gerrit.wikimedia.org/r/114345
Change 114345 had a related patch set uploaded by Cscott:
Support trailing 'pxpx' in image size options.

https://gerrit.wikimedia.org/r/114345
(In reply to C. Scott Ananian from comment #8)
> Yes, 'pxpx' is actually a "feature".  See bug 13500.

groan!
Yes, 'pxpx' is actually a "feature".  See bug 13500.

Working on a fix...
Another concrete example:
http://parsoid.wmflabs.org/arwiki/%D9%85%D8%B7%D8%A7%D8%B1_%D8%B3%D9%8A%D8%B3%D9%8A%D9%85%D9%8A%D9%88%D8%AA?oldid=11661406

This bug increases a little bit the size of the offline dumps. I have estimated for example that on arwiki, ~200 pictures (calls) are impacted.

It seems that the PHP related code is the function parseWidthParam() in Parser.php (but this doesn't seems to support things lik "$1px".
*** Bug 54371 has been marked as a duplicate of this bug. ***
We are supporting localized option patterns. In this case we get something like $1px, which does not match 30pxpx. We need to investigate why this works in the PHP parser, but not in Parsoid.
*** Bug 51826 has been marked as a duplicate of this bug. ***
This happens on every infobox that uses
https://de.wikipedia.org/wiki/Datei:Kazakhstan_location_map.svg
e.g.
https://de.wikipedia.org/wiki/Balqasch?veaction=edit

Im seeing it on _some_ other SVG based location maps on German Wikipedia, but not many (1 in 15?)
https://de.wikipedia.org/wiki/Almaty?veaction=edit
https://de.wikipedia.org/wiki/Bosporus?veaction=edit

Other similar issues
https://de.wikipedia.org/wiki/Totes_Meer?veaction=edit
https://de.wikipedia.org/wiki/Zittauer_Gebirge?veaction=edit
*** Bug 51845 has been marked as a duplicate of this bug. ***
I've just been pointed to an older discussion about this issue at https://en.wikipedia.org/wiki/Wikipedia:VisualEditor/Feedback/Archive_2013_07#Problem_with_image_and_other_information_in_an_infobox
User:NicoV at the English Wikipedia reports:
*In [[The Drover's Boy]], if you put the cursor just before the table and hit Del, the first title (Song title) is put outside the table while Performes becomes the first title.
*I saw this because I tried to insert a template just before the table, then deleted it => an empty line was visible before the table. When trying to delete this empty line, the first title was put outside the table.

I did some more testing and can confirm that:
*Pressing delete after the last character before a table deletes the first cell and moves the contents out of the table, and moves the second cell (including formatting) to the former position of the first cell. The position of the second cell is replaced with a blank cell.
*The same happens when pressing backspace before the first character of the first cell
*After repeating this sufficient times the contents of the last cell on the first line is moved out of the table and the line deleted.
*Pressing delete after the last character in the last cell, or backspace before the first character after the last cell, moves the whole of the next line (or title) into the last cell of the table, preserving formatting and links, etc.

--------------------------
**Version**: unspecified
**Severity**: normal
**See Also**:
https://bugzilla.wikimedia.org/show_bug.cgi?id=50286
None of the reported issues happen any more. I think most of it was fixed a long time ago, I fixed the last stragglers with T92702.
A user on Polish Wikipedia reports this is happening there, too. Please see Bug:61272.
A user at en.wp has reported what appears to be the same bug also occurring with image captions:
"Suppose an image lives between paragraphs 1 and 2. If I click before the first word of paragraph 2 and press "backspace", the rest of paragraph 2 gets moved into the caption of the image.

Suppose an image lives between paragraphs 1 and 2. If I click after the last word of paragraph 1 and press "delete", the image disappears and the caption gets moved to the end paragraph 1."
User:Hhhippo notes that the language "VisualEditor is in 'beta' and so many not let you edit everything yet" is likely to be very confusing to those who are not techie or wiki insiders. New users may understand better if "VisualEditor" was explained or replaced with more general language such as "This editing software".

While we're talking about clarifying language, I wonder if those same new editors would benefit from a note that they can use "edit source" if a feature they need does not work.

--------------------------
**Version**: unspecified
**Severity**: enhancement
I think this is now better; closing.
(In reply to comment #0)
> User:Hhhippo notes that the language "VisualEditor is in 'beta' and so many
> not let you edit everything yet" is likely to be very confusing to those who
> are not techie or wiki insiders. New users may understand better if
> "VisualEditor" was explained or replaced with more general language such as
> "This editing software".
> 
> While we're talking about clarifying language, I wonder if those same new
> editors would benefit from a note that they can use "edit source" if a
> feature they need does not work.

This language has already been changed (but not deployed yet - that will be this afternoon) to:

| VisualEditor is in 'beta'. You may encounter software issues, and you may
| not be able to edit parts of the page. Click "Edit source" to switch to
| wikitext mode – unsaved changes will be lost.

I think this makes this a bit clearer, though not perfect.
Right now lots of users try VE with MW 1.21.x and are confused as to why they get nothing.

--------------------------
**Version**: unspecified
**Severity**: minor
This is now merged.
Change 76869 merged by jenkins-bot:
Add dependency check for MW1.22/wmf11

https://gerrit.wikimedia.org/r/76869
Change 76869 had a related patch set uploaded by Jforrester:
Add dependency check for MW1.22/wmf11

https://gerrit.wikimedia.org/r/76869
Change 76706 merged by jenkins-bot:
Check MW version before loading VE

https://gerrit.wikimedia.org/r/76706
Change 76706 had a related patch set uploaded by Esanders:
Check MW version before loading VE

https://gerrit.wikimedia.org/r/76706
Digging around I assume wfUseMW( '1.22alpha' )?
http://www.mediawiki.org/wiki/Extension:VisualEditor says yes.

I'm not familiar with how extensions usually check for MW version compatibility. Obviously we could do it in the client and throw a JS exception, but there may a preferred way in PHP?
Is MW >= 1.22 a requirement? If so we can check wgVersion and throw an exception
'label': 'foo' should mean that the label is 'foo', not ve.msg( 'foo' );

--------------------------
**Version**: unspecified
**Severity**: minor
This has been resolved in Ic97a636f9a193374728629931b6702bee1b3416a - now menu options are individual tools and they have static titleMessage properties.
VisualEditor should support adding and editing the code tag (<code></code>).

--------------------------
**Version**: unspecified
**Severity**: enhancement
This is now done, but marked as "experimental" (so it will show up on MediaWiki.org and the test wikis, but not on other production wikis like the Wikipedias). This is mostly because we don't yet have a proper design for how to have lots of different text annotations (currently we're tracking bugs to create an additional eight on top of the four that now exist including this one). Once we've got a design for that, we'll switch it out of experimental mode, but I'll mark this as fixed for now.
Change 76077 merged by jenkins-bot:
Code annotation button

https://gerrit.wikimedia.org/r/76077
Change 76074 merged by jenkins-bot:
'CodeScript' => 'Code'

https://gerrit.wikimedia.org/r/76074
Change 76077 had a related patch set uploaded by Esanders:
Code annotation

https://gerrit.wikimedia.org/r/76077
Change 76074 had a related patch set uploaded by Esanders:
'CodeScript' => 'Code'

https://gerrit.wikimedia.org/r/76074
With the latest master, <code> blocks are no longer alienated (so you can edit their contents and copy them), but we haven't added the user interaction tools to set or unset the styling.
Change 74563 merged by jenkins-bot:
De-alienate <code>foo</code> blocks (code element)

https://gerrit.wikimedia.org/r/74563
Change 74563 had a related patch set uploaded by Jforrester:
De-alienate <code>foo</code> blocks (code element)

https://gerrit.wikimedia.org/r/74563
T32713 added "wikipage.content" passing it #mw-content-text, and fired it on initial load and from live preview (and other code like VisualEditor and other extensions/gadgets should also fire it when they replace/update the content).

A few others we should add for things outside the content:

* [DONE in rMW125bfdfec63c3be1b7d94be2d03e21226fcf23f5] `wikipage.categories`
  arguments: `.catlinks`

  Fired initially and from live preview.
  e.g. for things like HotCat to listen to

* `wikipage.langlinks`
  arguments: `#p-lang`

  Fire initially if `#p-lang` exists/non-empty, and from live preview.

* [DONE in rMW9cfb9cb9fba4dcfd25a0924237681b7cc86a20df] wikipage.diff
  arguments: `#wikiDiff`

  Fire initially if page has a diff on it, and from live preview if user
  did "show changes".

  e.g. for patrolling tools to hook into the diff and the [mark as patrolled] link.

* [DONE in rMW8d0dcb863701e78cb4b066f176da89091bba67b3] `wikipage.editform`
  arguments: (common parent of `.mw-summary-preview`, `.templatesUsed`, `.hiddencats`)

  e.g. for vector.footerCleanup and other things that hook into this.

--------------------------
**Version**: 1.21.x
**Severity**: normal
>>! In T53583#1918917, @TheDJ wrote:
> @Krinkle you do not think there is enough value if hotcat only hooks into this after VE saved the page ?

That is valuable, but isn't compatible with using this hook. It would either need to hardcode VE, make exceptions for preview, or simply use the 'wikipage.content' or 'postEdit' hook instead. There doesn't seem to be an appropiate way for HotCat to use 'wikipage.categories' in that case.
@Krinkle you do not think there is enough value if hotcat only hooks into this after VE saved the page ?
>>! In T53583#1885706, @TheDJ wrote:
> @Krinkle, probably yes, but I think that is a concern for HotCat, and not for the hook I would assume.

True, but if HotCat shouldn't use it, then that leaves the use-case question empty for this hook. Which means I may want to revert it. (It got merged meanwhile by @Jdlrobson)
Change 219629 merged by jenkins-bot:
Add wikipage.categories hook

[[https://gerrit.wikimedia.org/r/219629]]
@Krinkle, probably yes, but I think that is a concern for HotCat, and not for the hook I would assume.
Triggering wikipage.categories post-save in VisualEditor will help HotCat. However triggering it in edit preview might be unexpected in the particular case of HotCat since it probably shouldn't be creating an edit interface for categories whilst on an edit page for wikitext already (since the two would conflict). Something to consider with regards to separation of concerns.
Rebased that patch to only cover the categories case (as it is analogous to diffs). langlinks first need templates per skin probably.
Apologies and thanks for clarifying.

Patch open is:
https://gerrit.wikimedia.org/r/#/c/219629/
Of the 4 items in the list of the description, one was marked as done. A second one is now also marked as done. There is also one patch still under review... and a 5 item was being discussed as possibly qualifying for addition to the list.
Not sure what is left to do. Someone should re-open and clarify in the description (preferably via checkboxes if that's not true)
>>! In T53583#1844576, @Krinkle wrote:
>>>! In T53583#1606076, @Schnark wrote:
>> Not mentioned yet, but IMHO makes sense, too: `#firstHeading`
> 
> Why?

There are tools that modify the first heading, for example append a link to edit the lead section only. or to change the heading via JS in cases where DISPLAYTITLE can't be used (e.g. [[https://fr.wikipedia.org/wiki/J_sharp|fr:J sharp]]), just to name two examples. These scripts should run again when the content was updated.
Is this resolved? If not what's left to do?
>>! In T53583#1606076, @Schnark wrote:
> Not mentioned yet, but IMHO makes sense, too: `#firstHeading`

Why?
Change 218275 merged by jenkins-bot:
Add a wikipage.diff hook

[[https://gerrit.wikimedia.org/r/218275]]
Not mentioned yet, but IMHO makes sense, too: `#firstHeading`
Change 219629 had a related patch set uploaded (by TheDJ):
Add wikipage.categories and wikipage.languages hooks

[[https://gerrit.wikimedia.org/r/219629]]
Change 218275 had a related patch set uploaded (by TheDJ):
Add a wikipage.diff hook

[[https://gerrit.wikimedia.org/r/218275]]
So, now that I'm so much further along with LivePreview, I'm pondering taking on some of these elements next. I was thinking starting with templatesUsed, hiddencats and limit report (I've selected them because they are EditPage only elements, should be a safe start).

Do we still agree that this is the right approach ? Or have ideas changed over the past 2 years ?
Removing target milestone that was in the past.

If you want this in a specific release, have a good reason AND you are willing to find resources to fix this bug, feel free to change it to something appropriate.
[Bumping TM as MediaWiki 1.22.0 tarball was released today.]
As the Target Milestone on this ticket has been set to 1.22.0:

According to http://lists.wikimedia.org/pipermail/wikitech-l/2013-September/072030.html "MediaWiki 1.22 is slated for release on November 30th, at the very latest."

If this is still intended to get fixed for 1.22.0, a patch is needed soon.
These are easy to add. Holding off until usage of "wikipage.content" is slightly more widespread and we have more use cases for these (e.g. will HotCat be able to use this? etc.)

If you need one of these hooks, please let it know here including a brief description of how/where you'd like to use it. That'll help to shape the details of exactly where these hooks would go.
At the moment, the VE's refresh after save isn't a full refresh - it refreshes "in place", using the parsoid DOM. This isn't something things like gadgets or site JS recognise, and so the reloaded page lacks power user functionality. Save should simply refresh the page cleanly to avoid this issue.

--------------------------
**Version**: unspecified
**Severity**: normal
That's because the Math extension doesn't support this yet; see bug 36060.
Hmm... Visual editor still doesn't call MathJax after saving the page (all I see is the source code of the formulas, e.g. $ \mathbb{N} $).
The code of the gadget is not using the 'wikipage.content' hook introduced to fix bug 30713 (and added to VE on Gerrit Change 76751):
https://en.wikipedia.org/wiki/MediaWiki:Gadget-popups.js

I've made a request for this on its talk page:
https://en.wikipedia.org/wiki/MediaWiki_talk:Gadget-popups.js#Use_the_.27wikipage.content.27_hook
Javascript (or at least navigation popups) are again not working after a page is saved but do work when the page is reloaded.

To test:
1. Enable the navigation popups gadget
2. View any page editable in VE
3. Hover over any link to see a popup
4. Load the page in VE and save an edit (it doesn't mater what)
5. Hover over any link and fail to see a popup.
6. Reload the page, hover over the link and see a popup
This is now merged and will be deployed later today.
Change 76751 merged by jenkins-bot:
mw.ViewPageTarget: Fire 'wikipage.content' hook after saving

https://gerrit.wikimedia.org/r/76751
Change 76751 had a related patch set uploaded by Krinkle:
mw.ViewPageTarget: Fire 'wikipage.content' hook after saving

https://gerrit.wikimedia.org/r/76751
This hook will not fire in VisualEditor's editing mode. Nodes are protected and don't allow interaction anyway.

These hooks are for enhancements. Anything that's required for display should be handled by VisualEditor's ContentEditable node implementation (e.g. including Timeline, Math, etc.).
Change 74313 merged by jenkins-bot:
mediawiki.page.ready: Use wikipage.content instead of domready

https://gerrit.wikimedia.org/r/74313
It also affects the MathJax renderer see http://en.wikipedia.org/wiki/Wikipedia:VisualEditor/Feedback#Minor_redisplay_glitch
Some cases (e.g. navigation popups) may not want to fire in editing mode.  I'm not sure if that's best done with a separate hook, or just by making the listener check the mode.
We may need this to fire when we re-render parts of the document in editing mode, e.g. you are using the Math extension with JS rendering (MathJax), or you re-render a template containing a makecollapsible.
Change 74313 had a related patch set uploaded by Krinkle:
mediawiki.page.ready: Use wikipage.content instead of domready

https://gerrit.wikimedia.org/r/74313
No, we should not refresh because of this. This is not a new bug, this is a known issue in mediawiki core for years with "live preview".

The difference being that in 2013 (unlike several years ago when live preview came along) we have solved this. Recently I developed mw.hook in core with an event "wikipage.content". Gadgets should listen to that instead of document-ready.

Refreshing for every rendering is not a solution but a work around to have the native browser document trigger "ready" again. The solution is to have these wikipage (not html document) related actions be bound to its ready event and be able to fire that on-demand if the wiki page has changed (e.g. due to ajax navigation, live preview or page rendering like VisualEditor).

This has been solved and it is up to gadgets to start using it.

I'm rephrasing this bug to instead be a task for VisualEditor to start using this event (like LivePreview does in core).
*** Bug 51568 has been marked as a duplicate of this bug. ***
screenshot of the template edit icon in the wrong place

I inserted an image into an article using the VE, then I selected the infobox on the article. Instead of appearing on the infobox like it usually would, the puzzle icon for editing the infobox template appeared on the newly-inserted image.

--------------------------
**Version**: unspecified
**Severity**: normal
**See Also**:
https://bugzilla.wikimedia.org/show_bug.cgi?id=52547

**Attached**: {F11877}
>>! In T53548#1034742, @Elitre wrote:
> I think this is still happening. See for example https://fr.wikipedia.org/w/index.php?title=Parox%C3%A9tine&veaction=edit&vesection=10 ; the list of "Effets secondaires détaillés" is actually a template. The blue area when you select it looks like a cross in Chrome and Opera, with the puzzle piece icon overlapping the picture at the right.

That looks like it's {T52036} alone?
I think this is still happening. See for example https://fr.wikipedia.org/w/index.php?title=Parox%C3%A9tine&veaction=edit&vesection=10 ; the list of "Effets secondaires détaillés" is actually a template. The blue area when you select it looks like a cross in Chrome and Opera, with the puzzle piece icon overlapping the picture at the right.
All test cases provided appear to be working now.
*** Bug 60652 has been marked as a duplicate of this bug. ***
The new attachment refers to VEditing of https://it.wikipedia.org/w/index.php?title=Utente%3AElitre_%28WMF%29%2FSandbox_VE&diff=61361267&oldid=61290806 .
Created attachment 13252
An icon far, far away...

**Attached**: {F11878}
1. Click 'Edit'
2. Click 'Edit source' quickly before VE has loaded
3. You are show an API error in a confirm box 'Error loading data from server: error. Would you like to retry?', both OK & cancel let you navigate to edit source.

--------------------------
**Version**: unspecified
**Severity**: normal
*** Bug 57267 has been marked as a duplicate of this bug. ***
\o/

Thanks, Alex and Roan!
Change 110108 merged by jenkins-bot:
Stop API error dialog popping up if you navigate away from the page while Parsoid loads

https://gerrit.wikimedia.org/r/110108
Change 110108 had a related patch set uploaded by Alex Monk:
Stop API error dialog popping up if you navigate away from the page while Parsoid loads

https://gerrit.wikimedia.org/r/110108
Currently it is impossible to use Visual Editor in the pages of Portuguese Wikipedia which are on namespace 102 ("Anexo"), because the default value of $wgVisualEditorNamespaces is set to array( NS_MAIN ) instead of the $wgContentNamespaces (which usually, but not always is just array( NS_MAIN )). These pages are also articles, and as such should be editable by VisualEditor as any other article.

--------------------------
**Version**: unspecified
**Severity**: normal
**See Also**:
https://bugzilla.wikimedia.org/show_bug.cgi?id=52188
Thanks! I've updated our docs :-)
https://pt.wikipedia.org/w/index.php?diff=37359406
(In reply to comment #6)
> (In reply to comment #4)
> > Why is this not working on Portuguese Wikipedia? Our "Anexo" namespace is a
> > content namespace but this doesn't work:
> > 
> > https://pt.wikipedia.org/wiki/Anexo:Lista_de_listas?veaction=edit
> 
> This was because of how VE was configured to be used in WMF production; have
> done a config patch (above) which fixes this - will get it pushed out on
> Tuesday.

Just to confirm, this is now done. Sorry!
Change 94420 merged by jenkins-bot:
Make VisualEditor namespaces extend, not replace, default

https://gerrit.wikimedia.org/r/94420
(In reply to comment #4)
> Why is this not working on Portuguese Wikipedia? Our "Anexo" namespace is a
> content namespace but this doesn't work:
> 
> https://pt.wikipedia.org/wiki/Anexo:Lista_de_listas?veaction=edit

This was because of how VE was configured to be used in WMF production; have done a config patch (above) which fixes this - will get it pushed out on Tuesday.
Change 94420 had a related patch set uploaded by Jforrester:
Make VisualEditor namespaces extend, not replace, default

https://gerrit.wikimedia.org/r/94420
Why is this not working on Portuguese Wikipedia? Our "Anexo" namespace is a content namespace but this doesn't work:

https://pt.wikipedia.org/wiki/Anexo:Lista_de_listas?veaction=edit
Change 74138 merged by jenkins-bot:
Default $wgVisualEditorNamespaces to $wgContentNamespaces

https://gerrit.wikimedia.org/r/74138
Merged.
Change 74138 had a related patch set uploaded by Helder.wiki:
Default $wgVisualEditorNamespaces to $wgContentNamespaces

https://gerrit.wikimedia.org/r/74138
A community member marks his edits as "minor edits" (via preferences) by default. VE ignores un-marking it both in FF 20.0 and Chrome 27.0; see:

FF:

http://de.wikipedia.org/w/index.php?title=Benutzer:Thoken/test1&diff=prev&oldid=120588869

Chrome:

http://de.wikipedia.org/w/index.php?title=Benutzer:Thoken/test1&diff=prev&oldid=120590664

discussion on De.WP:

http://de.wikipedia.org/w/index.php?title=Wikipedia:Technik/Text/Edit/VisualEditor/Beta2013-07&oldid=120620759#Enthaken_von_.22Nur_Kleinigkeiten_wurden_ver.C3.A4ndert.22_ohne_Wirkung

--------------------------
**Version**: unspecified
**Severity**: normal
Fixed and will get deployed in a few minutes.
Change 75598 merged by jenkins-bot:
Set 'notminor' if minor edit box not checked

https://gerrit.wikimedia.org/r/75598
Change 75598 had a related patch set uploaded by Esanders:
Set 'notminor' if minor edit box not checked

https://gerrit.wikimedia.org/r/75598
Confirmed in Firefox.  Note this preference is not available in English Wikipedia.
When hovering the notice (which users do by default as the cursor is there after clicking the "Beta" icon on the toolbar) we highlight the "Leave feedback" label.

If the entire container was clickable and bound to opening the Feedback dialog that would be appropriate, however that isn't the case. On click we close the notice.

.ve-init-mw-viewPageTarget-tool:hover .ve-init-mw-viewPageTarget-tool-label, .ve-init-mw-viewPageTarget-subtool-label:hover {
text-decoration: underline;
}

--------------------------
**Version**: unspecified
**Severity**: normal
This was fixed in the toolbar re-write.
This also happens when hovering over the beta label on the toolbar (both it and the leave feedback label are underlined).
In both named and unnamed parameters.

The unnamed one should be of course a bug.

Should we manage to protect named ones from being trimmed in PHP parser?

ie. generate ({{P1|1= hello <nowiki/>}}) to protect the trailing space?

--------------------------
**Version**: unspecified
**Severity**: normal
**See Also**:
https://bugzilla.wikimedia.org/show_bug.cgi?id=61049
This was fixed some time ago in the clean-up re-write of the transclusion dialog; sorry for the slow triage.
Make a "First Edit" tour to help someone make their first edit, in general.  This should not have any connection to GettingStarted.

--------------------------
**Version**: unspecified
**Severity**: normal
**swalling** wrote:

Tours for 'firstedit' and 'firsteditve' are out in the wild. :)
This should also have browser tests.
So far I've been using separate tours (one for VE, one for wikitext), so if we continue with that approach, we should make two tours.
**swalling** wrote:

(In reply to comment #0)
> Make a "First Edit" tour to help someone make their first edit, in general. 
> This should not have any connection to GettingStarted.

Also should work with VisualEditor or wikitext editor.
Change 64981 had a related patch set uploaded by Mattflaschen:
Add tour to be used for first edit (other than GettingStarted).

https://gerrit.wikimedia.org/r/64981
In progress at https://gerrit.wikimedia.org/r/#/c/64981/
When editing the user page of a blocked user, some messages appear at the top of the page, for example blocked-notice-logextract.

They don't appear when editing with the VisualEditor.

Compare:

Good: https://en.wikipedia.org/w/index.php?title=User:SEAROSE8&action=edit

Bad: https://en.wikipedia.org/wiki/User:SEAROSE8?veaction=edit

--------------------------
**Version**: unspecified
**Severity**: normal
**See Also**:
https://bugzilla.wikimedia.org/show_bug.cgi?id=52004
Change 121232 merged by jenkins-bot:
Possibly show blocked-notice-logextract or userpage-userdoesnotexist when editing a user page

https://gerrit.wikimedia.org/r/121232
Change 121232 had a related patch set uploaded by Alex Monk:
Possibly show blocked-notice-logextract or userpage-userdoesnotexist when editing a user page

https://gerrit.wikimedia.org/r/121232
At unpredictable points, bits of the text from the underlying article sometimes show up on top of the Media search box. See attached video for an example.

--------------------------
**Version**: unspecified
**Severity**: minor
**OS**: Linux
**Platform**: PC
I'm guessing this is fixed by now. Reopen if you can still reproduce.
Upload failed, so see the video here: https://commons.wikimedia.org/wiki/File:Screen_recording_of_text-over-Media_bug_in_VisualEditor.ogv
**Author:** `turingt`

**Description:**
See this feedback trhead: [ https://en.wikipedia.org/wiki/Wikipedia:VisualEditor/Feedback#Observation_-_Template_Editor_behavior_improved ]

The search results for parameters include each parameter's description, making it easy to select the right one. 

But the templates list result contains only the template name, even though the template description is available (it's shown right 'after' a template is selected, so it doesn't help in choosing the right template).

So, add the template description to the search results list.

--------------------------
**Version**: unspecified
**Severity**: enhancement
**See Also**:
https://bugzilla.wikimedia.org/show_bug.cgi?id=51774
Verified the fix in Betalabs
Change 203459 merged by jenkins-bot:
Show template description in the template search

[[https://gerrit.wikimedia.org/r/203459]]
Change 203459 had a related patch set uploaded (by Mooeypoo):
Show template description in the template search

[[https://gerrit.wikimedia.org/r/203459]]
Thanks for the explanation, I've now reported it as bug 51822.
(In reply to comment #4)
> (In reply to comment #3)
> > > If I type "book", template "Cite book" is not shown, which limits the search
> > > functionality to be useful only for people who already know template names
> > > (i.e. those who don't need it).
> > 
> > That is a distinct enhancement request; please open a new bug for it.
> 
> Is it distinct or is it part of bug 51670?

It's distinct. This is asking for VisualEditor when searching pages (for links), categories (for the category dialog) and templates (for the transclusion dialog) to use an entirely different (and slower) part of MediaWiki's search infrastructure so we can do in-string searching rather than left-string completion.
(In reply to comment #3)
> > If I type "book", template "Cite book" is not shown, which limits the search
> > functionality to be useful only for people who already know template names
> > (i.e. those who don't need it).
> 
> That is a distinct enhancement request; please open a new bug for it.

Is it distinct or is it part of bug 51670?
(In reply to comment #2)
> Also typing a word only shows template names starting with that word, not
> containing it, which is a weird search behavior.
> 
> If I type "book", template "Cite book" is not shown, which limits the search
> functionality to be useful only for people who already know template names
> (i.e. those who don't need it).

That is a distinct enhancement request; please open a new bug for it.
**turingt** wrote:

Also typing a word only shows template names starting with that word, not containing it, which is a weird search behavior.

If I type "book", template "Cite book" is not shown, which limits the search functionality to be useful only for people who already know template names (i.e. those who don't need it).
Also typing in 'new' into the New template box returns a list of 10 templates starting with 'new', with no way to scroll through the longer list of templates starting/containing with 'New'

https://en.wikipedia.org/wiki/Special:PrefixIndex/Template:New

More practical, 'New Zealand' or 'New York' only returns 10, and the user may not know the right keyword needed to return better results.
In addition to the existing "default" attribute for each template parameter, that would be useful to have an "autofill" attribute for each template parameter:
* "default" is the value that will be used by the template if the parameter is not specified
* "autofill" could be used for indicating that when inserting a template in a article with VE (or other editor), some parameters should be created automatically with a given value.

I think for example of some templates that have a date parameter to be filled with the date at which the template was inserted.

--------------------------
**Version**: unspecified
**Severity**: enhancement
Change 157820 merged by jenkins-bot:
Implement new 'autovalue' parameter property

https://gerrit.wikimedia.org/r/157820
Change 157820 had a related patch set uploaded by Jforrester:
Implement new 'autovalue' parameter property

https://gerrit.wikimedia.org/r/157820
This is generally worked around by wikis by providing another template that when substituted inserts the autofill parameters.

e.g.

{{subst:newdelete|reason=Foo}}
-> 
{{delete|reason=Foo|date=YYYY-MM-DD}}

These templates need a "must-subst" property of sorts in template data first (bug 65550), but that would make this easier already.

The subst-behaviour is a super set of the scope of this bug (autofill values), however it may be enough.

The problem with a declarative autofill (as opposed to substituting a wrapper template) is that you'd need a fair amount of logic to express what you want to be filled in. Obviously you don't just want a literal string to be inserted, because then you'd just have users omit it and use that value as the default value.

With autofill you most probably want a dynamic value (e.g. the result of invoking a template, or magic words like current date/times, current revision user, base page name etc. Some of these (like date) could be trivially done, but that still leaves a lot of questions (how to specify the date etc.) and compatibility.

So I'd say let's solve bug 65550 first and see how that unfolds. If we still feel a need for this we can revisit it later.

This should additionally be helpful since subst-ing is that wikis do now without VisualEditor so they likely have that in place already and will want to keep that for wikitext users.
I almost submitted a new bug, but saw this one in the "possible duplicates" at the last second... Pasting the text I wrote, in case it helps:


Most cleanup templates, banner and inline, have a "|date={{CURRENTMONTHNAME}} {{CURRENTYEAR}}" parameter.

If we don't add them, then (on En.Wiki) AnomieBot adds them a few minutes later*, which clutters the history, and more importantly Buries the initial edit in watchlists, making it harder for us humans to check.

*eg. https://en.wikipedia.org/w/index.php?title=Red_squirrel&curid=638291&diff=572563931&oldid=572553559


Could we have an "Add current month and year" button, for parameters like this?

Or, a tweak for TemplateData so that specific templates will add this parameter/value by default?
From Bug 52028:
TemplateData should allow some parameters to have default values which are
prefilled when using the VisualEditor transclusion manager. 

An example would be the current date for accessdate in citation templates.
*** Bug 52028 has been marked as a duplicate of this bug. ***
This seems like a nice improvement, though I worry that it sets up an expectation that a client may not honour.
I would like to request that some flag or other indicator be added such that abuse filter rules can tell whether the edit is coming from VE or from the source editor.

Because the abuse filter tends to encourage different sorts of editor errors, it would be useful to know which interface is being used when editing.  For example, a nowiki tag added by the source editor is almost certainly intentional, while a nowiki added by VE is probably an accident and should be tagged for inspection.

--------------------------
**Version**: unspecified
**Severity**: enhancement
**See Also**:
{T54281}
>>! In T53421#2905524, @jhsoby wrote:
> Now with the 2017 wikitext editor I think this should get a priority bump, seeing that it too uses ?veaction instead of ?action, which makes it impossible (AFAIK) to use edit filters to identify those edits.

The action URL path is a poor guide to the source of edits (see the Special:Edit or whatever it's called tool, the mobile Web wikitext and visual editors, and other mechanisms). Anyone trying to capture edits by use of the URL path is going to fail pretty terribly.

I also don't agree that this is a particular priority. People have been editing using different tools for years without the software allowing discriminatory edit validation.
Now with the 2017 wikitext editor I think this should get a priority bump, seeing that it too uses ?veaction instead of ?action, which makes it impossible (AFAIK) to use edit filters to identify those edits.
(In reply to comment #10)
> The original request was merely for the AbuseFilter to somehow be made aware
> whether or not an edit had come from VE as opposed to source editing.  
> 
> For example, the Abuse Filter is aware of "action=" but not "veaction=".  At
> present "action=edit" and "veaction=edit" look identical to the AbuseFilter.

Adjusting comment accordingly.

> I think the suggestion that AbuseFilter should somehow be allowed process
> tags generated by other entities is actually an unnecessary (and more
> complicated) diversion.

Sure.
The original request was merely for the AbuseFilter to somehow be made aware whether or not an edit had come from VE as opposed to source editing.  

For example, the Abuse Filter is aware of "action=" but not "veaction=".  At present "action=edit" and "veaction=edit" look identical to the AbuseFilter.

I think the suggestion that AbuseFilter should somehow be allowed process tags generated by other entities is actually an unnecessary (and more complicated) diversion.
s/invisible to VE/invisible to AF/. I swear, I did proofread that. :)
s/attempts/happens/, of course.
AF's hook attempts *during* save, in EditPage#runPostMergeFilters and ApiEditPage#execute (the second one is only used to present nicer information about saving failure in the API and is what VE is actually hitting, but that doesn't matter here).

VisualEditor's ApiVisualEditorEdit calls the edit API first (#saveWikitext) and only after it has succeeded calls ChangeTags::addTags to add the tags to the edit.

So to make this work, we'd have to adjust code in core, in AbuseFilter and in VE to allow passing change tags with the edit API call or in some magical way before it. It'd make the logic really awkward (since tags could now be added before/during and after making the edit, and the second kind would be invisible to VE) and likely introduce back-compat issues (for the same reason).

There are also requests to make the tags editable by users (bug 18670), which generally seems like a pretty good idea, but complicates the issue here even further.

So to summarize, I don't see this happening, but feel free to prove me wrong if you think you can tackle this :)
(In reply to comment #5)
> I'm pretty sure it's impossible to do this since any kind of tags can be only
> added after an edit is saved (ChangeTags::addTags() function requires the
> edit to have a know rev_id which implies that it already exists in the
> database).

Does AF's hook happen after VE's save (which applies tags), at least?
I'm pretty sure it's impossible to do this since any kind of tags can be only added after an edit is saved (ChangeTags::addTags() function requires the edit to have a know rev_id which implies that it already exists in the database).
**nykevin.norris** wrote:

Wait, if the AbuseFilter is going to understand tags, and already applies tags, what order will filters run in?  What if a later filter applies a tag that would have triggered an earlier filter?  Should MW just keep re-running the filters until everything's been triggered?
Can the abusefilter detect veaction=edit. Using that and we could block edits which insert nowikis from the VE when they are almost always in error and allow them from wikitext editor, when they are normally ment.
This would need AbuseFilter to be extended to understand tags (or, to understand VisualEditor, which seems a less satisfying and extensible way of achieving this).
Both AbuseFilter and VisualEditor use change tags.  It might be possible for AbuseFilter to use VisualEditor's tag if AbuseFilter runs after, though I don't see tags mentioned at https://www.mediawiki.org/wiki/Extension:AbuseFilter/Rules_format
The file VisualEditor/modules/ve-mw/init/styles/images/loading.gif is a "progress bar"-like loading indicator. It is moving only left to right. It would be more natural for RTL environments if it had an RTL version.

--------------------------
**Version**: unspecified
**Severity**: normal
Change 80490 merged by jenkins-bot:
Reverse the progress image for RTL

https://gerrit.wikimedia.org/r/80490
Merged. Will go out with wmf15.
Change 80490 had a related patch set uploaded by Amire80:
Reverse the progress image for RTL

https://gerrit.wikimedia.org/r/80490
I would want to propose to add a type to indicate the content is contained wikitext, instead of a arbitary string. This could help VE to display a visual editor for those fields instead of showing the wikicode directly. This can't be done on "string" types as it's not certain they contain real wikitext. If the parameter is only to contain a single template invocation of a specific type, then perhaps a type "template" and a pointer to which template.

--------------------------
**Version**: unspecified
**Severity**: enhancement
**See Also**:
https://bugzilla.wikimedia.org/show_bug.cgi?id=52652
Change 91624 merged by jenkins-bot:
Specify "content" and "unbalanced-wikitext" as a valid parameter types

https://gerrit.wikimedia.org/r/91624
Change 91624 had a related patch set uploaded by Krinkle:
Specify "wiki-markup" as a valid parameter type

https://gerrit.wikimedia.org/r/91624
I was going to request this, because I've seen a similar case where the parameter is to be filled with just an internal link. VisualEditor should be able to hide the wikicode markup from new users as much as possible, and this seems to be a very common place where it still appears. See e.g. the values of the parameters "imagem_legenda" and "cidade" of the [[pt:Template:Info/Bairro do Brasil]]:
http://toolserver.org/~kolossos/templatetiger/tt-table4.php?template=Info/Bairro%20do%20Brasil&lang=ptwiki&where=&is=

We see things like "A [[Praça Dom Sebastião]], com a [[Igreja da Conceição]] ao fundo (2007)."
Original icon, and 2 suggested alternatives

The "Insert reference" icon is not very intuitive. I've made a sketch of two alternatives.

See attachment, or on-wiki at http://commons.wikimedia.org/wiki/File:VisualEditor_-_Toolbar_-_Reference-edit1.png

That image includes the current icon, and two adaptations that consist of: a snippet of grey text, and a blue super-scripted number [1]. 

The grey text could be made into abstract letterforms - squiggles - (rather than the letters REF) in order to make it usable by all languages. 

Or we could use a grey "+" sign with the blue [number]. 

(The only problem is RightToLeft languages. Not sure how to solve that.)

The blue super-scripted [number] is universally recognizable and intuitively understandable as denoting references, both in Wikimedia projects and even beyond. I'd suggest this element, at the least, should form the basis for any replacement icon.

--------------------------
**Version**: unspecified
**Severity**: enhancement
**See Also**:
https://bugzilla.wikimedia.org/show_bug.cgi?id=53396

**Attached**: {F11513}
I'm going to provisionally deem this solved with the new icon.
**turingt** wrote:

You should include a label besides each button whenever possible. When you have a clear label, it doesn't matter that the icon is hard to recognize. And no, hover text doesn't solve the problem.
Notes: 

The current icon is stored at http://commons.wikimedia.org/wiki/File:VisualEditor_-_Icon_-_Reference.svg

Threads on en.wiki which discussed the confusing design of the current icon include these:
http://en.wikipedia.org/wiki/Wikipedia:VisualEditor/Feedback#Icons_are_incomprehensible
http://en.wikipedia.org/wiki/Wikipedia:VisualEditor/Feedback/Archive_2013_07#Reference_Issues:_Omnibus_Edition
http://en.wikipedia.org/wiki/Wikipedia:VisualEditor/Feedback/Archive_2013_07#Mystery_meat_navigation
http://en.wikipedia.org/wiki/Wikipedia:VisualEditor/Feedback/Archive_2013_07#References
http://en.wikipedia.org/wiki/Wikipedia:VisualEditor/Feedback/Archive_2013_07#Attempting_to_add_a_reference
http://en.wikipedia.org/wiki/Wikipedia:VisualEditor/Feedback/Archive_2013_07#User_experience
http://en.wikipedia.org/wiki/Wikipedia:VisualEditor/Feedback/Archive_2013_07#Refs_and_templates
(And one thread that reminds us that cellphones/tablets don't get hover text)
Currently it's a hack; it'd be nice to be a bit less of one.

--------------------------
**Version**: unspecified
**Severity**: enhancement
**See Also**:
https://bugzilla.wikimedia.org/show_bug.cgi?id=50423
Done and merged, now that wmf12 is deployed everywhere.
Change 73614 merged by jenkins-bot:
Use new class to detect Cite errors inside templates

https://gerrit.wikimedia.org/r/73614
Change 73096 merged by jenkins-bot:
Add more specific class to cite errors

https://gerrit.wikimedia.org/r/73096
https://gerrit.wikimedia.org/r/#/c/73614/
Change 73096 had a related patch set uploaded by Jforrester:
Add more specific class to cite errors

https://gerrit.wikimedia.org/r/73096
The Beta notice looks strange to me: 
http://i.imgur.com/H5n3XdD.png
ff23 linux

--------------------------
**Version**: unspecified
**Severity**: minor
**See Also**:
https://bugzilla.wikimedia.org/show_bug.cgi?id=52176
This flyout is now much wider.
*** Bug 51618 has been marked as a duplicate of this bug. ***
(In reply to comment #3)
> (In reply to comment #1)
> > Which page / URL does this happen on? And what exactly is "strange"? The line
> > break between "Leave" and "feedback", or anything else? Feel free to edit the
> > bug summary to be more specific. Thanks!
> 
> I suspect it is the font (DejaVu?) that is common on Linux systems. It has
> wider characters than Arial (used on Windows).
> 
> The Beta popup should be made a little bit wider to accommodate this font.

The width is defined in terms of the font used (ems). I'm not sure how this fails due to that font - unless its em width is wrong somehow?

Note that we've just changed the language in the beta notices and expanded the width to compensate (deployment will be tomorrow afternoon PDT). Interested to know if this has an impact on this issue.
(In reply to comment #1)
> Which page / URL does this happen on? And what exactly is "strange"? The line
> break between "Leave" and "feedback", or anything else? Feel free to edit the
> bug summary to be more specific. Thanks!

I suspect it is the font (DejaVu?) that is common on Linux systems. It has wider characters than Arial (used on Windows).

The Beta popup should be made a little bit wider to accommodate this font.
Screenshot

Adding a screenshot of how it looks for me (Firefox22, Windows 7).

**Attached**: {F11423}
Which page / URL does this happen on? And what exactly is "strange"? The line break between "Leave" and "feedback", or anything else? Feel free to edit the bug summary to be more specific. Thanks!
Since T40551 have been resolved, it is //possible// to have per-language bold/italic button variants. But the only two languages //using// this are currently English and German. Do we really need to ask language by language, when we've been through all this with the Vector edit toolbar (see e.g. {T25625}, {T25911}, {T26188} etc.).

We already have https://commons.wikimedia.org/wiki/WikiEditor_Toolbar_Icons#List_by_language -- cannot we use that?

----

See also: https://usability.wikimedia.org/wiki/Opinion_Icons
[adding the #tracking project to tasks blocking (now deprecated) T4007 as part of T93366]
No outstanding requests for these; closing for now as complete.
Change 74677 merged by jenkins-bot:
Set Malayam to use B/I rather than A/A for toolbar icons

https://gerrit.wikimedia.org/r/74677
Change 74677 had a related patch set uploaded by Jforrester:
Set Malayam to use B/I rather than A/A for toolbar icons

https://gerrit.wikimedia.org/r/74677
(In reply to comment #2)
> That was exactly my point is that we do not want to do that, because we have
> already went through this with Vector. But I guess I have not expressed
> myself clearly: I do not care about the exact image files linked there. The
> point is that _we already know_ that Czech, Hebrew, and Polish (in addition
> to English) want to use B/I, and we already have these images, the only
> problem is to modify the configuration. We already know that Danish,
> Norwegian, and Swedish (in addition to German) want to use F/K, and we
> already have these images, the only problem is to modify the configuration.

Thank you! No, "we" do not know, as we are not experts - but you clearly do. :-) Have created this as bug 51330. Will do this tomorrow when I'm in the office.

> We also already know what letters 13 other languages would want to use, even
> though we do not have those images ready (I guess), but the best person to
> create those missing images is the person who created the current A/A/B/I/F/K
> ones, I would say.

Our developer/designer time is limited; we did F/K as an example for others to follow, not as a commitment that we would do this for all scripts.
(In reply to comment #0)
> Since bug 38551 have been resolved, it is _possible_ to have per-language
> bold/italic button variants.

That's about Vector, which is entirely irrelevant here.

> But the only two languages _using_ this are currently English and German.

Yes (and the Latin-generic ones).

> Do we really need to ask language by language, when we've been through
> all this with the Vector edit toolbar (see e.g. bug 23625, bug 23911,
> bug 24188 etc.).

See above.

> We already have
> https://commons.wikimedia.org/wiki/WikiEditor_Toolbar_Icons#List_by_language
> --
> cannot we use that?

No. Those are low-quality PNG-only icons and not in keeping with the existing VisualEditor ones. VisualEditor's interface is in SVG. We look forward to the creation of such icons and would gladly include them. Turning this into a tracking bug so each language can be tracked against it.
Twice I have added a bare URL as a reference to [[Paul Robert Magocsi]], which results in the [4] and [5] being added to the right spot in the text, 

but ..

The references section at the bottom did not display the reference.

Steps to reproduce:
1. Click add reference button
2. Paste in URL
3. Click 'Create new source'
4. Click 'Insert reference'
(Reference dialog appears)
5. Click 'Apply changes'
6. View the references list at bottom of article

Expected results:
the new reference is listed

Actual results:
The added reference was not visible.

--------------------------
**Version**: unspecified
**Severity**: enhancement
Re-titling; the problem is that VisualEditor has no idea that the block of content it's been handed by Parsoid happens to contain a <references /> call, and neither does Parsoid unless it re-parses it.

Consequently, we are expanding the syntax for <references /> to make {{reflist}} unnecessary. WONTFIXing this bug.
An Arabic editor has reported that he/she is having difficulty with getting images to display left-justified (as they should be in RTL wikis).  How does VE handle justification of elements in RTL?  Can images be defaulted to left justify?
This issue might apply to other elements, such as infobox templates.

--------------------------
**Version**: unspecified
**Severity**: normal
Same thing as bug 51851, and that one has more discussion despite being reported later.

*** This bug has been marked as a duplicate of bug 51851 ***
(In reply to comment #1)
> Please provide an exact testcase and/or link to reproduce, and browser
> information. Might be a dup of bug 51293?

Andre, here's a test case:

*Go to ar.wikipedia, a RTL wiki

*Enable VE in pref.

*Go to your userpage or sandbox (Google Translate is calling these "Stadiums"!)

*Use media icon to bring up dialog, pick image.

*Image defaults to the right.  Attempts to click'n'drag it to the left do not work.  

*Curse the LTR imperialists.

Duplicated on both latest Chrome and Firefox, OS 10.6.8.
Please provide an exact testcase and/or link to reproduce, and browser information. Might be a dup of bug 51293?
When viewed in edit mode, references included in an infobox are not included in the references list at the bottom of the article, and the first reference in the body of an article is numbered stating from 1, ignoring any in the infobox.

Example articles: [[https://en.wikipedia.org/wiki/Popocatépetl|w:en:Popocatépetl]] and [[East Toowoomba, Queensland]].

Possibly related to T52474 and/or T52479

**See Also**:
T54398
T52474
T52749
T54427
T55486
T52896
This seems to be fixed, although T52474 (which is similar) remains open.
*** Bug 69066 has been marked as a duplicate of this bug. ***
Also, as seen by editing https://en.wikipedia.org/w/index.php?oldid=596381198 you cannot re-use any references that are within an infobox.
Gah.
This has started happening again. See [[OpenOffice.Org]] and [[Bristol]] for examples.
Ok thanks for the quick reply, now reported as bug 52427
(In reply to comment #3)
> Mike Christie at en.wp has reported this happening with notes defined in
> image captions. Will the fix for this bug solve that when it is deployed or
> should I file a separate bug?

This is now deployed; references in image captions sounds like a further bug, sadly.
Mike Christie at en.wp has reported this happening with notes defined in image captions. Will the fix for this bug solve that when it is deployed or should I file a separate bug?
This is now fixed due to the same fixes as bug 51741 (and in Parsoid) - they're still numbered wrongly (which is bug 50474).
Sorry, that second possibly related bug should be bug 50749
From English Wikipedia, John Broughton (♫♫) 22:40, 12 July 2013 (UTC):

When selecting an image to be inserted, the selected thumbnail has a black box around it. The lines of the box are so fine as to make them almost invisible. A much better feedback would be if, when a thumbnail is selected, it turns blue in exactly the same way as when an image in an article is selected. (A blue coloring behavior - not the same as within an article, though - does happen for some images, though not most. For example, if one searches for "Sandbox", four of the first twelve thumbnails do add some blue if selected, though in one case just a sliver.)

--------------------------
**Version**: unspecified
**Severity**: enhancement
This was done as part of the re-work of the media inserter in late July; marking as such.
VisualEditor is disabled on the built-in & default browser, which has the user agent:
>Mozilla/5.0 (Linux; U; Android 4.0.4; en-gb; GT-N7000 Build/IMM76D) AppleWebKit/534.30 (KHTML, like Gecko) Version/4.0 Mobile Safari/534.30
@jayvdb, ah, so it was a [[http://www.gsmarena.com/samsung_galaxy_note_n7000-4135.php|Galaxy Note N-7000]]. Thanks!
>>! In T53274#1481575, @Neil_P._Quinn_WMF wrote:
> @jayvdb, which device did you notice this on, ...

This is in the user-agent I posted with the bug.

> and what was the browser named? Just "internet"? (Sorry, I know this is two years old!)

The app icon was 'Internet' (upper case I)

My phone has since been bricked & replaced, so I cant retest this bug.
@jayvdb, which device did you notice this on, and what was the browser named? Just "internet"? (Sorry, I know this is two years old!)
@jayvdb, which device did you notice this on, and what is the browser named? Just "internet"? (Sorry, I know this is two years old!)
Iv given the user-agent. It is the 'Internet' browser that ships with the device. It passes the vast majority on the compliance tests for content editable.
Safari literally doesn't exist on Android phones; there is no such thing.

Some mobile browsers report themselves as compatible with Mobile Safari, which appears to be what you're seeing.
Mobile Safari isnt just iOS.  It is the *default* web browser on many Android phones.
For VisualEditor, we are continuously-bitten by <references /> tags that are embedded within generated content like the English Wikipedia's {{reflist}} (T52769). 

It would be much easier for everyone if we just moved the features provided by such templates into [[https://www.mediawiki.org/wiki/Extension:Cite|the Cite extension]] itself and allowed such templates to be replaced by the now more powerful <references /> tag.

Points of agreement include:
* The main requirements are for <references /> to support multiple columns and different list styles
** T33597 discusses defaulting to multiple columns for all reference lists
* Columns should be implemented using [[https://developer.mozilla.org/en-US/docs/Web/CSS/column-width|column widths]] rather than [[https://developer.mozilla.org/en-US/docs/Web/CSS/column-count|column counts]], to allow flexibility based on screen size.

This task is currently blocked, on the following issues:
* What the default settings/algorithms should be
* Whether column widths and list styles should be customizable per-page, or only per-wiki 
* If per-page customizations are allowed, whether they should be implemented by passing through CSS properties from the invocation of the <references /> tag or by applying CSS classes, which are then given CSS properties on a per-wiki or global level.

This would involve adding:

* columns (default to 1; a number between 1 and … another number? - not allowing width, obviously)
* list-style (default to decimal; just an escaped pass-through of the CSS list-style of the OL)

Then we could just bot-substitute uses of the template, and everyone would be happy.

**See Also**: T53145, T8019
Change 378935 merged by jenkins-bot:
[mediawiki/extensions/Cite@master] VE: Support 'responsive' attribute

[[https://gerrit.wikimedia.org/r/378935]]
Change 378935 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/Cite@master] VE: Support 'responsive' attribute

[[https://gerrit.wikimedia.org/r/378935]]
FYI, I've added some support to en.wp's {{reflist}} to explicitly enable and disable automatic columns.
Next step for en.wp will be to enables responsive by default for a plain <references> element

This leaves the following capabilities that are specific to Reflist, which currently cannot be fulfilled with a plain references element
# Different list item counters
# Differing column widths (this one is also not really compatible with automatic columns, which will create a bit of a disjunct in behaviour).

This doesn't negate the fact that:
* of course reflist is already universally used, and universally changing it will probably be seen as disruptive.
* there is also a rather large documentation gap, atm. regarding new and old information.
* ironically, it seems that the responsive attribute cannot be set/unset from VE

An idea that played in my mind, which would be terribly WMF specific, but might make it easier to work with this problem, is if we should maybe change the VE editor of <references/> and the Template:Reflist, to be aware of each other, and maybe offer the opportunity to switch between them ("more options", vs "convert to references element"). Just a thought.
>For VisualEditor, we are continuously-bitten by <references /> tags that are embedded within generated content like the English Wikipedia's {{reflist}} (T52769). It would be much easier for everyone if we just moved the features provided by such templates into the Cite extension itself and allowed such templates to be replaced by the now more powerful <references /> tag.

>Reference incidences (<ref>s) inside templates are an entirely distinct problem for VisualEditor to worry about, and this isn't about that. :-)

You're contradicting yourself, chuckle. I agree with the second statement, fixing VisualEditor's difficulties with templates is bug T52769. This proposal of a more powerful more powerful <references /> tag isn't going to help that bug because communities will still have various reasons for putting things inside various templates. If that's the purpose of this bug, it's a failure when it still gets templated.

This bug really only makes sense in light of something like //T33597: Render references list in multiple columns based on the number of items// which aims to add useful new functionality regardless of whether it's put inside a template.
This was discussed at the weekly meeting on 2015-06-30. We decided that it wasn't a priority for this quarter.
It should be noted that mobilefrontend already does some CSS overrides here (setting a default column width).
@thiemowmde mentions T33597
Just to make this clear (since I was told to say this here rather than in Gerrit): 100% agree to what Krinkle and Gabriel said. See bug 31597 (T33597) for a much more elaborate proposal.
Just to make this clear (since I was told to say this here rather than in Gerrit): 100% agree to what Krinkle and Gabriel said. See T31597 for a much more elaborate proposal.
Just to make this clear (since I was told to say this here rather than in Gerrit): 100% agree to what Krinkle and Gabriel said. See bug 31597 for a much more elaborate proposal.
See also:
Bug 31597 - generate class for references list according to the number of refs
Change 123105 abandoned by Alex Monk:
Support new column-width and list-style attributes to Cite's <references>

Reason:
ok done

https://gerrit.wikimedia.org/r/123105
I picked up the Cite & VE parts of this again.
Change 123105 restored by Alex Monk:
Support new column-width and list-style attributes to Cite's <references>

Reason:
Restoring so I can do a rebase to get the VE patch working

https://gerrit.wikimedia.org/r/123105
Change 123093 restored by Alex Monk:
WIP Support new column-width & list-style attributes to Cite's <references>

https://gerrit.wikimedia.org/r/123093
Change 120962 restored by Alex Monk:
Support setting column-width and list-style in <references /> tag

Reason:
Going to use classes.

https://gerrit.wikimedia.org/r/120962
Bug 22265 - Allow references to be listed with letters
No. We /are/ going to do this. Gabriel is on the hook for suggesting how to do it in a way that makes him happy, given he vetoed the agreed way. It certainly isn't "UNCONFIRMED".
Change 123093 abandoned by Alex Monk:
WIP Support new column-width & list-style attributes to Cite's <references>

Reason:
Abandoning all related patch sets

https://gerrit.wikimedia.org/r/123093
Change 120962 abandoned by Alex Monk:
Support setting column-width and list-style in <references /> tag

https://gerrit.wikimedia.org/r/120962
Change 123105 abandoned by Alex Monk:
Support new column-width and list-style attributes to Cite's <references>

https://gerrit.wikimedia.org/r/123105
See https://gerrit.wikimedia.org/r/#/c/120962/ for more discussion on this.
(In reply to Gabriel Wicke from comment #24)
> Is there a good reason to use magic attributes and inline styles here
> instead of CSS classes? The latter is easier to customize for different
> environments and creates less complexity in the parsers (PHP and Parsoid).
> 
> All VE needs is a list of classes to offer in a drop-down or the like.

Your assertion that a restricted set of classes invented by the development team will be sufficient for the community's existing wishes to be fulfilled is not met by reality…
Is there a good reason to use magic attributes and inline styles here instead of CSS classes? The latter is easier to customize for different environments and creates less complexity in the parsers (PHP and Parsoid).

All VE needs is a list of classes to offer in a drop-down or the like.
Change 123105 had a related patch set uploaded by Alex Monk:
Support new column-width and list-style attributes to Cite's <references>

https://gerrit.wikimedia.org/r/123105
Change 123093 had a related patch set uploaded by Alex Monk:
Support new column-width and list-style attributes to Cite's <references>

https://gerrit.wikimedia.org/r/123093
What? We don't do LATER, and haven't for over a year.
IMO this should be a WONTFIX or LATER, and instead bug 6019 should be fixed.
Change 120962 had a related patch set uploaded by Alex Monk:
Support setting column-width and list-style in <references /> tag

https://gerrit.wikimedia.org/r/120962
(In reply to Alex Monk from comment #17)
> Can someone sum up exactly what has been agreed to do here?

My understanding:

Do: 

* Add a "column-width" optional property to the <references /> element, in ems, defaulting to unspecified => one column of 100% width.

** Ensure the issues about RTL display being logical are fix (you need to make sure that the columns and their contents both flow RTL).

** Make it look nice. :-)

** Should this default be variable as a per-wiki option?


* Add a "list-style" optional property to the <references /> element, an escaped pass-through of the CSS list-style of the OL, defaulting to decimal.

** Should this default be variable as a per-wiki/per-content-language option? I can imagine there might be better alternatives for some languages than "Arabic" Roman decimal.


Do not:

* Add a "columns" property (this breaks the concept of the Web's content being fit for any sized screen and shouldn't be encouraged).

* Add a new class to the <references /> OL – the "references" class can be over-ridden locally by wikis if they want to change it further.


Is this what others think?
Can someone sum up exactly what has been agreed to do here?
(In reply to comment #8)
> The references tag should support html attributes, than you can write
> <references class="***" /> and the template can be replaced.

This is bug 6019.
 
> Needs a set up a class for list-styles.

Has anyone done an analysis of list-style usage on the large wikis?  I am wondering whether Cite adding a class for the group name will suffice. (i.e. emitting class="references references-$group $invocationClassesVal") 

I agree with others that Cite shouldn't add explicit support for columns, as this is very device-dependent; a class attribute indirectly provides this and more.
Multiple columns for references causes two major usability issues:

1. When there is only one reference and this reference is longer than the column width, it is split into several parts, causing gaps inside the reference. This gets even worse for bidi texts: If you have a reference in a right-to-left language inside a left-to-right context, and it is split into multiple columns, you have to start reading on the right end of the left column, read to the left, jump right to the next column, read to the left again, etc.

2. When the list of references is longer than the screen and a reference breaks into two columns, you have to scroll to read it. This means:
a) You click the superscript number, the browser sends you to the upper part of the reference.
b) You have to scroll down to the beginning of the reference and start reading.
c) You have to scroll up again to the second part and continue reading.
d) If you don't know that you can use your browser's "back" function, you have to scroll down again to get to the back link.

Both issues could be solved by using "break-inside: avoid-column;", but the browser support currently is very poor. So unless browser support for this improves in future or somebody writes a JS solution for it, multi-column reference lists are a bad idea for usability reasons.
For the record, both column-count and column-width are fully automated CSS properties in the browser. It's 1 line of code to tell the browser, and then browsers handle it natively for us. No development on our side to split the list or anything like that.
column-count is terrible indeed, especially for liquid layouts like in MediaWiki skins. When viewing it on a narrower window, it becomes unreadable.

column-width is a much more sensible approach, though I find it hard to believe either makes sense to be specified on the individual reflist. What I've seen in practice (at least on nl.wikipedia) that there is authors who know about it and explicitly use reflist with 2 columns in all their articles, and others who don't know about it, and others who prefer 3 for whatever reason.

The result is a chaos if different column counts per article.

When incorporating this back into the Cite extension, we can also provide a better default based on whatever really makes sense to derive it from. Whatever the rational is for needing multiple columns (mostly for readability I presume as the lines become too wide, and the list too long), we can automate that trivially based on rational UX arguments (yes, there shall be a global wiki bikeshed about why 2 is better than 3). Probably deriving it from the number of references in the list.

column-width will allow the list to fold back into 1 column on smaller devices and people who just like to narrow their window, and multiply out as the window gets wider. Of course this problem isn't entirely specific to references lists, it's also a long outstanding petpeeve of various designers about the article content itself, a fluid layout makes that content hard to read as well in some cases (though a fixed layout is probably better than multi-column in that case).

</brain-dump>
What about the {{reflist}} variants on en.wiki such as {{notelist}}?
The plwp infobox <references/> is here:
https://pl.wikipedia.org/wiki/Szablon:Infobox_uwagi_dodaj
(In reply to comment #7)
> I don't understand what you're saying? This is an enhancement about users
> frequently using a template to achieve a trivial software feature, and so 
> building that into reference lists (<references />s) rather than having them
> need to invent and use the template.
> 
> Reference incidences (<ref>s) inside templates are an entirely distinct
> problem
> for VisualEditor to worry about, and this isn't about that. :-)

This bug seems to be about enhancing <references /> so people won't (often?) have to embed <references /> in templates.  However, I think db's point is that there are other reasons (besides {{reflist}}) that <references /> may be in a template.  The example Bartosz gave (Carles Puyol) boils down (after a few template layers) to [[pl:Szablon:Infobox_uwagi_dodaj]], which has its own references tag with a custom infobox group.  As shown at [[pl:Carles Puyol]], the effect is a small notes list just for the infobox.
(In reply to comment #3)
> Also, some wikis include more stuff in their reflist-like templates; for
> example [[pl:Template:Przypisy]] unconditionally includes the heading.

Indeed. The equivalent template on Portuguese Wikipedia is also used to generate the header, and also has parameters to change the header text as well as its level (<h2>, <h3>, ...):
https://pt.wikipedia.org/wiki/Template:Referências
The references tag should support html attributes, than you can write <references class="***" /> and the template can be replaced.

Needs a set up a class for list-styles.

The extra class="reflist" is unneeded, because the references tag already adds class="references".

Thats why you can already add

.references { column-width: 35em; -moz-column-width: 35em; -webkit-column-width: 35em; }

to your common.css/user.css and all references will have column width, no need to tag each references tag with its own class.


But the template has the advanced, that syntax errors will not eat the rest of the page.
(In reply to comment #5)
> You will become also problems with <ref> in infobox templates or so on, that
> means you need another soluation than add a new tag or maintain a hardcoded
> template list in VisualEditor.

I don't understand what you're saying? This is an enhancement about users frequently using a template to achieve a trivial software feature, and so  building that into reference lists (<references />s) rather than having them need to invent and use the template.

Reference incidences (<ref>s) inside templates are an entirely distinct problem for VisualEditor to worry about, and this isn't about that. :-)
(In reply to comment #5)
> You will become also problems with <ref> in infobox templates or so on, that
> means you need another soluation than add a new tag or maintain a hardcoded
> template list in VisualEditor.

Hm, yeah, I didn't think about it, but some infoboxes include their own <ref>s *and* <references group=.../>, for example pl.wp infoboxes for football players and some other sportsmen; an example can be seen on [[pl:Carles Puyol]].
You will become also problems with <ref> in infobox templates or so on, that means you need another soluation than add a new tag or maintain a hardcoded template list in VisualEditor.
(In reply to comment #3)
> Also, some wikis include more stuff in their reflist-like templates; for
> example [[pl:Template:Przypisy]] unconditionally includes the heading.
> 
> (In reply to comment #2)
> > > "Obviously"? In my opinion setting maximalcolumn width and letting the
> > > browser figure out the layout makes more sense than hardcoded number
> > > (although sadly it's not how it's done right now).
> > 
> > We should be reducing, not increasing, the use of hard-coded widths. HTML is
> > not a graphical layout language, and should not be bastardised to serve as
> > such.
> 
> Hardcoding the number of columns is the same, except worse, since it can't be
> adjusted to the capabilities of the browser/device without violating CSS
> spec.
> 
> CSS only allows specifying column width "hints", anyway, and they can be
> measured in ems.
> https://developer.mozilla.org/en-US/docs/Web/CSS/column-width

OK, then I suppose we should maintain equivalence with {{reflist}} here.
Also, some wikis include more stuff in their reflist-like templates; for example [[pl:Template:Przypisy]] unconditionally includes the heading.

(In reply to comment #2)
> > "Obviously"? In my opinion setting maximalcolumn width and letting the
> > browser figure out the layout makes more sense than hardcoded number (although
> > sadly it's not how it's done right now).
> 
> We should be reducing, not increasing, the use of hard-coded widths. HTML is
> not a graphical layout language, and should not be bastardised to serve as
> such.

Hardcoding the number of columns is the same, except worse, since it can't be adjusted to the capabilities of the browser/device without violating CSS spec.

CSS only allows specifying column width "hints", anyway, and they can be measured in ems. https://developer.mozilla.org/en-US/docs/Web/CSS/column-width
(In reply to comment #1)
> (In reply to comment #0)
> > * columns (default to 1; a number between 1 and … another number? - not
> > allowing width, obviously)
> 
> "Obviously"? In my opinion setting maximalcolumn width and letting the
> browser figure out the layout makes more sense than hardcoded number (although
> sadly it's not how it's done right now).

We should be reducing, not increasing, the use of hard-coded widths. HTML is not a graphical layout language, and should not be bastardised to serve as such.

> > * list-style (default to decimal; just an escaped pass-through of the CSS
> > list-style of the OL)
> 
> That would be a bad way to do this; the list style should actually depends on
> the group name used (since Cite has a way to provide custom markers instead
> of [1] to reference citations, list-style is used to match them - see
> [[Special:PrefixIndex/MediaWiki:Cite_link_label_group]] for ones defined on
> en.wp).

Sorry, yes, I meant "default to what the group states; if no group, default to decimal; otherwise, let the user over-ride".
(In reply to comment #0)
> * columns (default to 1; a number between 1 and … another number? - not
> allowing width, obviously)

"Obviously"? In my opinion setting maximalcolumn width and letting the browser figure out the layout makes more sense than hardcoded number (although sadly it's not how it's done right now).


> * list-style (default to decimal; just an escaped pass-through of the CSS
> list-style of the OL)

That would be a bad way to do this; the list style should actually depends on the group name used (since Cite has a way to provide custom markers instead of [1] to reference citations, list-style is used to match them - see [[Special:PrefixIndex/MediaWiki:Cite_link_label_group]] for ones defined on en.wp).
--------------------------
**Version**: unspecified
**Severity**: normal
Change 76860 merged by jenkins-bot:
mw.Target: Removed unreachable badtoken recovery code

https://gerrit.wikimedia.org/r/76860
Change 76860 had a related patch set uploaded by Krinkle:
Removed unreachable badtoken recovery code

https://gerrit.wikimedia.org/r/76860
It also ignored the fact that the new token may be logged out or for a different user, though this was previous OK-ish because it was only to load the content which is a read action and not a write action (hence why we fixed that API recently to no longer require a token)
onLoad no longer requires or even considers a token, so this is now obsolete.
Please install Notifications (Echo) on the Polish Wikipedia. I think the community supports this in general.

Is it even possible? It seems some similar requests were rejected (bug 50064?).

I'll start a straw poll to confirm this after it's made clear that the request will be fulfilled (I don't want to bother them otherwise).

--------------------------
**Version**: wmf-deployment
**Severity**: enhancement
**See Also**:
https://bugzilla.wikimedia.org/show_bug.cgi?id=52510
I'm pretty sure this can be closed now :) Thanks, Fabrice!
Sorry, I meant to say 'translate to Polish' (not 'Swedish'). My apologies, I am juggling a number of parallel releases and am using more copy-and-paste than I should. ;o)
Hello Bartosz,

Thanks for bringing up the question about FlaggedRevs. At this point, we do not plan support these events, and will not be able to implement this request in the near-term, sadly.

In the meantime, I would like to make sure that all is ready on your end for our August 20 release.

If you haven't already, we recommend you do the following for this proposed release:

* Confirm on Meta that the Notifications interface has been properly translated to Swedish -- update the translations if needed.

* Translate and create a Polish version of this help page, which links from the tool's interface (question marks on flyout and archive):
http://www.mediawiki.org/wiki/Help:Notifications

* Go over the checklist in this Notifications release plan and determine if you need to make any special adjustments (e.g. default user settings):
http://www.mediawiki.org/wiki/Echo/Release_Plan_2013

Thanks so much for your interest in this tool. I look forward to working with you soon.
By the way, I just noticed that Echo doesn't provide notifications for events related to the FlaggedRevs extension pl.wp has installed, in particular the act of "sighting" a page (similar to how page patrolling in core works).

I filed bug 52510 about this. It's not a deployment blocker, but it would be *really* nice to have it.
Wonderful, thank you!

Let's reconnect after Wikimania, around Aug. 15, to see if there are any final questions before the scheduled Aug. 20 deployment, which should take place at about 21:00 CET.

Cheers!
I have copied relevant pages from the English Wikipedia to:
* https://pl.wikipedia.org/wiki/Wikipedia:Powiadomienia
* https://pl.wikipedia.org/wiki/Wikipedia:Powiadomienia/FAQ

They should get translated and adjusted before the deployment.
And thanks for responding :) I'll forward this information to the community.
(In reply to comment #3)
> It would be great if someone could start translating this FAQ page to Polish,
> and give us the URL, so we can link the help icons to that page when the tool
> is released in late August:
> http://en.wikipedia.org/wiki/Wikipedia:Notifications/FAQ

Then this page should be copied somewhere that is not English Wikipedia and that has the Translate extension installed.

VisualEditor's FAQ and help pages were being translated on mediawiki.org and copied to the wikis later, but Meta would do just as fine here.
Hi Bartosz,

Glad to hear that the Polish community has reached consensus for deployment of Notifications this summer. We are very happy to have you as one of our first pilot sites for this tool!

Our current target date for this deployment is now set to Tuesday, August 20th at about 12pm PT (~21:00 Central European Time, if I am correct).

It would be great if someone could start translating this FAQ page to Polish, and give us the URL, so we can link the help icons to that page when the tool is released in late August:
http://en.wikipedia.org/wiki/Wikipedia:Notifications/FAQ

We plan to deploy Notifications to MetaWiki tomorrow, which will give us a first preview of how the tool works in languages other than English. 

Please let us know if you gave any questions, comments or suggestions.

Look forward to working with you on this release!
Straw poll: https://pl.wikipedia.org/wiki/Wikipedia:KT#Nowy_system_powiadomie.C5.84

Overwhelming support, 21/2/2 right now :)

Can we get a more precise estimate on "later this summer"?
Hi Bartosz,

Yes, we are now looking for a few wikis who want Notifications right away, so we can deploy it on their sites later this summer.

Let us know what the Polish community thinks. If the straw poll is favorable, we can include you in our short list of summer deployments (which now includes Meta and the French Wikipedia).

Thanks for taking the time to suggest this!
So, for example, the template dialogue. Once you're in it, there's not really any guidance on what you should do: as intuitive as we can ultimately make it, there will always be some confusion. It would be good if the VisualEditor had space for some kind of help icon that would link, in a new tab/window, to a pertinent help page on the specific wiki: we could set up MediaWiki namespace pages that provide the wiki-specific link.

--------------------------
**Version**: unspecified
**Severity**: enhancement
**See Also**:
https://bugzilla.wikimedia.org/show_bug.cgi?id=51798
Instead of help /pages/ we've decided to go with help /popups/, per bug 51798.
Simple example:

{|
foo
|}

This doesn't RT correctly. 

Real world test case: [[All-Ireland_Senior_Camogie_Championship_1992]]
Related report: https://en.wikipedia.org/wiki/Wikipedia:VisualEditor/Feedback#A_simple_table_gets_doubled_after_an_unrelated_edit_of_plain_text

Interestingly enough, we have more robust handling for templated content.  The example below is handled properly and RTs correctly.

{|
{{echo|foo}}
|}

--------------------------
**Version**: unspecified
**Severity**: normal
**See Also**:
https://bugzilla.wikimedia.org/show_bug.cgi?id=53402
Fix deployed, but cache is not yet purged. The purge will happen tomorrow.
Change 78242 merged by jenkins-bot:
(Bug 52638) Fix selser regression introduced by fix for bug 51217

https://gerrit.wikimedia.org/r/78242
Change 78242 had a related patch set uploaded by Subramanya Sastry:
(Bug 52638) Fix selser regression introduced by fix for bug 51217

https://gerrit.wikimedia.org/r/78242
Now deployed in production.  I tested dummy test cases and it seems to work.  Would be good to keep an eye out for this in production.
Another related patch: https://gerrit.wikimedia.org/r/#/c/76324/
Currently undergoing rt-testing and will be deployed Monday/Tuesday.
Change 75253 merged by jenkins-bot:
(Bug 51217) Detect fostered content and ignore in selser

https://gerrit.wikimedia.org/r/75253
*** Bug 51993 has been marked as a duplicate of this bug. ***
*** Bug 51964 has been marked as a duplicate of this bug. ***
Change 75253 had a related patch set uploaded by Subramanya Sastry:
WIP: (Bug 51217) Detect fostered content and ignore in selser

https://gerrit.wikimedia.org/r/75253
*** Bug 50754 has been marked as a duplicate of this bug. ***
This looks very similar to bug 50754.
So, I investigated the bug with this page (https://en.wikipedia.org/w/index.php?title=List_of_Jessie_episodes&diff=564684769&oldid=564554799) (comment #3 above).  

This is quite nasty and nothing to do with foster parenting as I mistakenly/hastily believed.  The page has since been edited to remove the problematic wikitext (https://en.wikipedia.org/w/index.php?title=List_of_Jessie_episodes&diff=564803163&oldid=564788048) so the problem will no longer manifest there.

However, here is a snippet from 

{{Episode list
 |EpisodeNumber   = 1
...
...
 |ProdCode        = 101<ref name="futon" />
 |Viewers         = ...
...
...
|}

Note the input to the 'ProdCode' param.  Here is a snippet for the template source of Episode list (https://en.wikipedia.org/w/index.php?title=Template:Episode_list&action=edit)

... <td id="pc{{{ProdCode}}}">{{{ProdCode}}}</td> ...

See what that will do with the parameter passed in from the page.  Here is the expanded source that Parsoid sees:

... <td id="pc101<ref name="futon" />">101<ref name="futon" /></td> ...

So, that td-tag is totally broken and Parsoid renders that as literal text (rather than a html td tag) which then promptly gets fostered out (by Parsoid itself) which then adds noise to the HTML output which is what you see when you opened that page in VE (see video above added by AzaToth). 

The editor Geraldo Perez has already fixed the page as I indicated earlier, so this is not a problem anymore.

But, I dont think we should even bother trying to handle broken wikitext like this.  We do go to great lengths to fixup/handler broken wikitext while still preserving it as far as possible to not introduce dirty diffs, but dirty diffs are sometimes inevitable in situations like this.  So for now, I am going to classify this example as unfixable in Parsoid, unless someone has smart ideas.
(In reply to comment #7)
> The problem on the VE end is that foster-parenting happens already when the
> browser parses the received HTML. Doing a simple string comparison with the
> received HTML won't normally work because of quoting differences.
This is right. We have no reasonable way to tell whether the browser's HTML parser introduced changes, because inferring anything about the HTML string requires using the browser's HTML parser which... well you get the idea.

On the Parsoid end, this is easier to detect, because you have the original DOM. You could serialize that DOM to a string, then parse it into a DOM again, and compare that against the original DOM using .isEqualNode() (if that exists in your DOM library; alternatively, use your DOM differ).
The problem on the VE end is that foster-parenting happens already when the browser parses the received HTML. Doing a simple string comparison with the received HTML won't normally work because of quoting differences.
On the Parsoid end, detecting that the page cannot be handle is equivalent to fixing it.  Same analysis work has to be done.  On the VE end, perhaps they could use the 've-needscheck' verification to detect something like this -- that is something that VE developers can respond to best.  Adding Roan to this ticket who might be better able to answer that part.
Why not just disable VE on pages like these for now. Edit page, parsoid render, "VisualEditor encountered a structure that it currently cannot handle. You will be redirected to the source editor."

Breaking pages == bad.
See http://youtu.be/QYgkdnQ6Yng for realtime feeling about the issue
Looks like this corruption is because content gets fostered out of the table on
load in VE.  One more instance of fosterable content that needs to be handled.

https://en.wikipedia.org/w/index.php?title=List_of_Jessie_episodes&diff=564684769&oldid=564554799
(In reply to comment #1)
> Jotting down an idea:
> 
> https://gerrit.wikimedia.org/r/#/c/73369/ is going to add tag-ids to dom
> elements.  Since they are added linearly, it will always be the case that
> tag-id(node) < tag-id(node.nextSibling) and tag-id(node) < tag-id(node.child)
> except when a child is fostered out. 

http://www.mediawiki.org/w/index.php?title=Parsoid/Todo&oldid=554715#DOM_tree_builder is making a cameo appearance ;)

After detection we'll have to figure out a way to make this work with selser though. Simply enlarging the start tag width to include the fostered content won't work. Fostered content can also come from several places in the table. The best is probably to prevent selser from serializing any of the fostered content, but serialize all of it when a part of it is edited.

Generally we should not try to do more than avoiding dirty diffs. On edit to the fostered content (or even the table in general) we should take the liberty to fix the wikitext to more closely mirror the way that content actually renders.
Jotting down an idea:

https://gerrit.wikimedia.org/r/#/c/73369/ is going to add tag-ids to dom elements.  Since they are added linearly, it will always be the case that tag-id(node) < tag-id(node.nextSibling) and tag-id(node) < tag-id(node.child) except when a child is fostered out. 

So, we could actually use these tag ids to robustly detect fostered content and add some encapsulation typeof and about ids on the content and the table so that VE as well as Parsoid's serializer can deal with it.
Shields/phantoms are currently recursively applying to protected elements and positioning additional elements inside them. This causes 2 major problems:

1. Very slow, the CSS selectors use * and adding and controlling all these elements takes a lot of time as well.

2. We are limited to a single rectangle per protected node, which for inline elements is especially problematic since they are meant to wrap.

Using getClientRect and getClientRects (for inline stuff) can give us bounding box information that we can then cache, and render polygon click blocks for using an SVG layer. SVG's pointer-events: none works across browsers (unlike using this property in HTML) so we can control which elements in the SVG rendering block or pass through.

--------------------------
**Version**: unspecified
**Severity**: enhancement
**See Also**:
https://bugzilla.wikimedia.org/show_bug.cgi?id=64709
In order to prevent the SVG canvas (a bounding rectangle) from capturing click events we'd need to set pointer-events, which would mean this wouldn't work on IE<11
>>! In T53202#781046, @Esanders wrote:
> This is not high priority

Investigating performance options is generally always a priority. But you're probably right that it won't be hugely beneficial.
This is not high priority
We are now using getBoundingClientRect and getClientRects. The only part missing from this bug is to use SVG. We should investigate the performance benefits/losses of doing so.
@Trevor: Thanks for writing it down. I'm pretty excited about working on it. Btw. in the meantime, I'm working on shields/phantoms performance optimization here: https://gerrit.wikimedia.org/r/#/c/72113/
The user preference for disabling VisualEditor has gone missing. It should be restored.

--------------------------
**Version**: wmf-deployment
**Severity**: normal
*** This bug has been marked as a duplicate of bug 50929 ***
The user preference should appear under the "Editing" tab at [[Special:Preferences]], where editors naturally expect to find it.
**stephdechine** wrote:

(In reply to comment #2)
> I also see that you are using Node 0.10.8.  Note that currently Parsoid only
> supports node 0.8
> (http://www.mediawiki.org/wiki/Parsoid#Use_node.js_0.8.2C_not_0.10)

Thank you for pointing out that. After I downgrade node.js to 0.8.23 everything works correctly. My fault. That works for me.
I also see that you are using Node 0.10.8.  Note that currently Parsoid only supports node 0.8 (http://www.mediawiki.org/wiki/Parsoid#Use_node.js_0.8.2C_not_0.10)
Your wiki API is not reachable from the Parsoid machine. Configure it correctly in localsettings.js and verify that it is indeed reachable using wget, curl, w3m or any other tool of your choice.

Example commandline:

curl <yourApiURL>

We should probably print this information when the config request fails. Repurposing this bug for that.
As discovered in bug 50120, we need to find out what this is and fix it.

--------------------------
**Version**: unspecified
**Severity**: normal
@Jdforrester-WMF, can we close this? T52120 has been resolved.
@Jdforrester-WMF, can we close this? T52120 has been resolved.
From English Wikipedia:

I've not yet done a lot with refs and reflists (a lot of my work is stub-sorting where it rarely crops up) but.... 

Editing Howard Wilson Elementary School I changed the number of columns of {{reflist}} from 2 to 1 (there's only one ref and it looks daft over 2 cols). The whole reflist disappeared, while I stayed in VE - see edit summary. On saving the page, it was there all present and correct.

This is one of several instances where VE alarms the editor: if it's supposed to be a Visual Editor, it needs to reflect changes made and not give the impression that the template has been deleted. Worrying enough for an experienced editor - totally offputting for someone new.

Apologies if this exact problem, or a more generalised case, is already tracked. PamD 16:38, 9 July 2013 (UTC)

--------------------------
**Version**: unspecified
**Severity**: normal
>>! In T53146#1442033, @Esanders wrote:
> Where is the bug to move all the functionality over to the <references> tag making {{reflist}} redundant?

https://phabricator.wikimedia.org/maniphest/query/7.xI5WLmYTc1/#R pffers some tasks about //specific// (not: //all//) functionality...
Where is the bug to move all the functionality over to the <references> tag making {{reflist}} redundant?
(In reply to James Forrester from comment #2)
> This will be fixed when we switch over to Parsoid rendering the templates
> mid-edit rather than rely on PHP parser.

As follow-up, right now we don't have a way to give context to Parsoid, so when parsing a template that generates part of a wider structure – e.g. a cell, row or section of a table – we just give the template itself, contextless.

This means that Parsoid (correctly) returns a fostered-out block, which we (correctly) splice into the location, meaning the document looks very odd. However, it saves fine.

In the future we'd need a way to tell Parsoid that "this is an update to transclusion id=1234 in structure id=4321" or something so Parsoid has context; I assume this will need to wait until Parsoid puts GUIDs into the source for us.
*** Bug 67856 has been marked as a duplicate of this bug. ***
This will be fixed when we switch over to Parsoid rendering the templates mid-edit rather than rely on PHP parser.
Confirmed. This one's especially annoying given how common {{reflist}} is. See also bug 50075 (which I was no longer able to reproduce).
Currently this is really ugly; Trevor's better class will help, but in general we want to do this better.

--------------------------
**Version**: unspecified
**Severity**: enhancement
(In reply to James Forrester from comment #3)
> Sorry!
> 
> This refers to the hacky fix for bug 50423 which added (eventually):
> 
>   /* HACK: Hide Ref errors in templates */
>   .mw-ext-cite-error {
> 	display: none;
>   }
> 
> … to ve.ce.MWReferenceNode.css
> 
> This bug is asking for a way for these errors to not be shown that doesn't
> just suppress the conent (they're caused by the templates rendering out of
> context).

I guess we could send some 'nocontext' parameter in the HTTP request which would suppress errors based on missing information... Sounds like it would be even worse than the current solution though.
Sorry!

This refers to the hacky fix for bug 50423 which added (eventually):

  /* HACK: Hide Ref errors in templates */
  .mw-ext-cite-error {
	display: none;
  }

… to ve.ce.MWReferenceNode.css

This bug is asking for a way for these errors to not be shown that doesn't just suppress the conent (they're caused by the templates rendering out of context).
Hello?
So what is this about? There's a lot of missing context here.
An English Wikipedia user writes to note that since red is the color of a missing link, it may not be an ideal choice for "remove template"

I myself wonder if it might not show up as pale grey (hence suggesting it will not work) to the color blind.

--------------------------
**Version**: unspecified
**Severity**: enhancement
We now use a rubbish bin ("trash can") icon which is a lot softer.
Note that this is in-line with the Design department's upcoming changes to the skins - it's a wider question. However, we should indeed flag this issue, I agree.
A user suggests that, in addition to the "cancel" option next to the "save" button, there should be an option to "cancel" from within the save box.

--------------------------
**Version**: unspecified
**Severity**: enhancement
I have.
Hmm... Yes, after thinking about this some more, I agree. Who wants to mark this wontfix?
Agree with Trevor, also on basic grounds of minimizing clutter; we should only add this if there's user testing that shows users don't know how to cancel their edits.
It's really cool that Alex has added a patch, but I feel pretty confident this is a mistake. If you open a dialog and then hit cancel, you are going to believe it will close the dialog without taking action. This is a reasonable sounding request, but we really need to say no to this.

I'm not going to wontfix until other's chime in. Can anyone really make a case for why this is a good direction?
Change 127004 had a related patch set uploaded by Alex Monk:
Add cancel & discard changes button to save dialog

https://gerrit.wikimedia.org/r/127004
The user is asking to escape VE entirely.
Would this be to escape from VisualEditor entirely (i.e., go back to view mode) or just to get out of the save dialog and back to the editor?
Links in the form [[./Bla]] are invalid markup, but are rendered as correct links in VisualEditor. There may be other types of invalid formats that are similarly accepted.

--------------------------
**Version**: unspecified
**Severity**: minor
**See Also**:
https://bugzilla.wikimedia.org/show_bug.cgi?id=33094
Change 124009 merged by jenkins-bot:
(Bug 51090): Follow-up to 4dce7f620: handle transclusions + html2wt mode

https://gerrit.wikimedia.org/r/124009
Change 121658 merged by jenkins-bot:
Bug 51090: Render invalid wikilinks as plain text

https://gerrit.wikimedia.org/r/121658
Change 124009 had a related patch set uploaded by Subramanya Sastry:
(Bug 51090): Follow-up to 4dce7f620: handles more scenarios

https://gerrit.wikimedia.org/r/124009
This section details the invalid cases to handle:

http://en.wikipedia.org/wiki/Wikipedia:Page_name#Technical_restrictions_and_limitations

The best place to handle this is in onWikiLink in ext.core.LinkHandler.js.
This needs to be checked more carefully after template expansion. Test case this will need to handle as well:

[[{{echo|./Bla}}]]
Confirmed, see http://en.wikipedia.beta.wmflabs.org/w/index.php?title=User:Jdforrester_(WMF)/Bug_51090 vs. http://en.wikipedia.beta.wmflabs.org/w/index.php?title=User:Jdforrester_(WMF)/Bug_51090&veaction=edit
You can't now enter these links in VE (bug 33094) but when they appear in the page they are still rendered as valid links in VE. For example [[./Bla]] displays the same as [[Bla]] in the source would and when right clicked, it opens that page.
On any page, click Link icon

Enter text in text field

Click the "<" symbol

Check the diff or save the page.  

The link is created but the text entered is not preserved.  

Suggest either preserving the contents of the text field upon the user clicking "<" or (less nice) disabling clicking "<" until the user has hit ENTER

--------------------------
**Version**: unspecified
**Severity**: normal
*** Bug 51177 has been marked as a duplicate of this bug. ***
This is now merged and will be deployed later.
Change 76839 merged by jenkins-bot:
Link inspector bug fixes

https://gerrit.wikimedia.org/r/76839
Change 76839 had a related patch set uploaded by Trevor Parscal:
The greatest commit in the history of the world*

https://gerrit.wikimedia.org/r/76839
OK, my apologies.  I can reproduce with those steps.

Bug 48789 looks more like a UI design 'enhancement', whereas this bug is a simple bugfix for the current design.
Is this the same thing as bug 48789?
It is reproducible, let me show an example: 

Assume that the first word on a page to be edited is "ThisIsALinkToGoogle" (no quotes) 

Open the page to be edited and without doing anything else to the page, click the Link icon.  The Link dialog shows ThisIsALinkToGoogle highlighted and entered automatically in the text field input. 

In the input field, replace ThisIsALinkToGoogle by typing "http://www.google.com"

When you finish typing, just click the left-arrow icon to close the Link dialog and (ostensibly) save what you have typed into the text field. 

Do the Save page/Review your changes dance. 

In the diff and in the saved page you will see 	
[[ThisIsALinkToGoogle]] which is not helpful.  

What I would expect to see is your typing preserved in a link like [http://www.google.com ThisIsALinkToGoogle]
Is this still reproducible?  I tried it, and the diff was empty, but maybe I'm not following the instructions correctly.
Thread is at https://en.wikipedia.org/w/index.php?title=Wikipedia:VisualEditor/Feedback&oldid=563553593#Consecutive_spaces - I can't explain it any better than the user has :).

--------------------------
**Version**: unspecified
**Severity**: minor
This is going to be a pain to get the user interaction pattern right.
This was reported as an enhancement, but because it causes content (i.e. consecutive spaces) to display and behave differently in the edit window than in the view window, I think it is more appropriate to regard it as a bug.  Accordingly, I am upgrading this from "enhancement" to "minor".
From
https://www.mediawiki.org/wiki/Thread:VisualEditor/Feedback/About_TemplateData

'(...) would it be possible to add new parameter "example" (where is example text what should be added to the parameter) in addition "label", "description", "type" and "required"?'

--------------------------
**Version**: unspecified
**Severity**: enhancement
Change 207123 merged by jenkins-bot:
Add example property to HTML rendering

[[https://gerrit.wikimedia.org/r/207123]]
Change 207123 had a related patch set uploaded (by Krinkle):
Add example property to HTML rendering

[[https://gerrit.wikimedia.org/r/207123]]
Checked in betalabs - 'Example (en)' was added to Template documentation editor.
Change 194386 merged by jenkins-bot:
Add an example property to parameters

[[https://gerrit.wikimedia.org/r/194386]]
The feature support in MWParameterPage is a bit presumptuous as the exact definition and property name are still being reviewed upstream in TemplateData.

Anyway, this feature seems useful, but I'd like to be more explicit about at least one use case before we land it. The talk thread that requests it didn't seem to note anything about the existing properties `description`, `default`  and `autofill` which currently cover the use case of showing what a field is for and what kind of value it should have.

I take it it will be used as placeholder in a user interface. However in VisualEditor the `default` is currently also displayed in the `placeholder` attribute. And the (already merged) conditional implementation of that does indeed ignore the `example` value if there is a `default`. And it seems there is no difference communicated to the user visually to distinguish example from default.

If the user won't be able to tell the difference, can authors?

I feel like the feature would be useful, but it is imho not sufficiently clear in its specification, implementation and current use in VisualEditor to offset it from the other existing features. And I imagine this will lead to confusion or incorrect usage by authors and users.
Change 194416 merged by jenkins-bot:
MWParameterPage: Show the field's example if it exists

[[https://gerrit.wikimedia.org/r/194416]]
Change 194416 had a related patch set uploaded (by Mooeypoo):
Show the field's example if it exists

[[https://gerrit.wikimedia.org/r/194416]]
Change 194386 had a related patch set uploaded (by Mooeypoo):
Add an example property to parameters

[[https://gerrit.wikimedia.org/r/194386]]
Any progress?
Unpopular pages with short titles, e.g. [[Sop]], [[Topo]], do not appear in the top 10 opensearch suggestions, so VE thinks the pages don't exist. However, they definitely do exist.

This, along with bug 50898, suggests that the VE team might need to implement its own wrapper web API for link suggestions.

--------------------------
**Version**: unspecified
**Severity**: enhancement
**See Also**:
https://bugzilla.wikimedia.org/show_bug.cgi?id=54361
FIXED by dint of bug 70958 being fixed. Thanks, Timo!
*** Bug 54361 has been marked as a duplicate of this bug. ***
Action item: When using search in a way that the user input should be used as first hit if it exists[1], our code should always do an additional query for the literal input against the pageinfo API. At least until the upstream bug in MediaWiki search is fixed (do we have a report for that?).


[1] e.g. mediawiki link input widget, and transclusion dialog template name input, but not media dialog probably.
Right now MediaWiki search has a bug where one searches "Foo" and a page by that name exists, it might not be included in the search results (or at least not in the first 10). Or sometimes it's in there but on #3.

While fixing the order is harder, we can easily work around the case where it is absent by running an additional api query simply checking whether a page by the title of "Foo" exists.
*** Bug 65927 has been marked as a duplicate of this bug. ***
*** Bug 52596 has been marked as a duplicate of this bug. ***
This looks the same as bug 52596 which contains more details of which pages are believed to exist and which are not
To fit long page titles. 

There's plenty of empty space in the dialog box that could be put to use.

--------------------------
**Version**: unspecified
**Severity**: minor
Thanks!
Change 119092 merged by jenkins-bot:
Increases width of defaultsort and page redirect fields in options dialog

https://gerrit.wikimedia.org/r/119092
Change 119092 had a related patch set uploaded by Mvolz:
Increases width of defaultsort and page redirect fields in options dialog

https://gerrit.wikimedia.org/r/119092
Created attachment 14834
Other dialogs affected by change

**Attached**: {F11659}
Created attachment 14833
Screenshot of 100% width in default sort field

**Attached**: {F11658}
Created attachment 14832
Screenshot of 30em width in default sort field

So I've looked into this a bit and took some screenshots.

Currently this is set in the class .oo-ui-textInputWidget and is set to 20em. The text input widget appears in Options -> Categories, Options -> Page Settings, and Insert -> Reference. 

These 3 fields all look acceptable at a width of 30em. We could also go for 100% width of the div. I like the look of this in the two Options areas, although this looks a bit odd in the Reference dialog "group by" field. I think that even 20em was too wide for it to begin with- maybe we should add a special class here?

Any opinions? I like both 30 em and 100%, and since reference dialog is likely to undergo radical UI changes the size of the group by field in the reference dialog could be ignored for the time being.

**Attached**: {F11657}
When inserting a new template, the template dialog button label "Apply changes" doesn't make sense, since we're not changing an existing element. In that case, the button should be labeled "Insert template".

Similarly, when inserting the list of references, the button should be labeled "Insert references list", not "Apply changes".

In contrast, when inserting a footnote or media file, the button is correctly labeled "Insert reference" or "Insert media".

--------------------------
**Version**: unspecified
**Severity**: minor
Verified the fix production:https://en.wikipedia.org/wiki/User:RYasmeen_%28WMF%29/sandbox?veaction=edit
Verified the fix in test2:https://test2.wikipedia.org/w/index.php?title=User:RYasmeen_(WMF)/sandbox&veaction=edit
Change 117342 merged by jenkins-bot:
Keep label and disabled state of transclusion dialog apply button in sync

https://gerrit.wikimedia.org/r/117342
Change 117342 had a related patch set uploaded by Jforrester:
Keep label and disabled state of transclusion dialog apply button in sync

https://gerrit.wikimedia.org/r/117342
Splitting from bug 50475 comment 1.

--------------------------
**Version**: unspecified
**Severity**: enhancement
Especially for templates, having a faster way to open the inspector would be very helpful. Right now in the case of a large template, you have to first select the template, then mouse over to the puzzle piece location and click it. Just double-clicking/tapping the template seems like a straightforward and discoverable gesture.

For links and other nodes it may be less important, but what would be the disadvantages for just making open-on-double-click the default behavior for all nodes that have a primary inspector of some kind?

--------------------------
**Version**: unspecified
**Severity**: enhancement
**See Also**:
https://bugzilla.wikimedia.org/show_bug.cgi?id=54827
Change 103062 merged by jenkins-bot:
Create mixin that tries to execute primary node command

https://gerrit.wikimedia.org/r/103062
Change 84461 abandoned by Robmoen:
WIP: Create ve.ce.ClickableNode mixin

Reason:
old

https://gerrit.wikimedia.org/r/84461
Change 103062 had a related patch set uploaded by Robmoen:
Create mixin for node that responds to node click events

https://gerrit.wikimedia.org/r/103062
Change 84461 had a related patch set uploaded by Krinkle:
WIP: Create ve.ce.ClickableNode mixin.

https://gerrit.wikimedia.org/r/84461
WIP: https://gerrit.wikimedia.org/r/#/c/84461/
Sherry and I would really second Erik's suggestion.
We just had feedback from a user who was clueless about what to do with "a blue rectangle with a jigsaw icon".
*** Bug 51176 has been marked as a duplicate of this bug. ***
I think this would work best for nodes (i.e., things that have a dialog) and not for annotations (i.e., things that are either toggled like bold or superscript, or have only an inspector link links or language).

This would be a lot simpler from a UX perspective (consistency of action and explainability), and the change overall is a good quick affordance win.
If you backspace-delete the newline that appears immediately prior to the indented quote of this rev (the quote that begins with "This was a kind of blank .."), the entire quote is deleted. This may be related to the fact that the newline shouldn't be there in the first place; it does not exist in the wikitext version of the page, nor is the text indented by means of a template. 

https://en.wikipedia.org/w/index.php?title=Ernestine_Eckstein&oldid=563439288&veaction=edit

--------------------------
**Version**: unspecified
**Severity**: major
**See Also**:
https://bugzilla.wikimedia.org/show_bug.cgi?id=50418
This seems fixed now. I was able to backspace or delete anything around the indentations on the test pages without the editor exploding in my face.
Testing at https://en.wikipedia.org/w/index.php?title=User:Thryduulf/sandbox&oldid=570858997 shows that attempting to backspace on one of the trailing new lines no longer deletes anything, it just moves the cursor to the end of the line above.
I think this might be the same bug that I encountered last night. Details and a screenshot at https://en.wikipedia.org/w/index.php?title=Wikipedia:VisualEditor/Feedback&oldid=564667549#Indentation_with_colons_rendered_with_blank_lines._Attempting_to_delete_these_deletes_entire_section_and_cannot_be_undone

Summary: Indentation with colons is rendered in VisualEditor with one blank line per level of indent before and after the indented section. Attempting to delete one of the blank lines before the indentation unindents by one level and removing a blank line before the indented text but not removing any after it. 

Attempting to remove any of the blank lines after the indented text deletes the entire indentation section. This deletion cannot be undone.
Also note that undo doesn't seem to work on this deletion event.
Screenshot of odd rendering when using {{#tag:ref}}

https://www.mediawiki.org/wiki/VisualEditor/Basic_example_worksheet?veaction=edit

See attachment, [11] renders as span instead of as <sup> (like [10]) and as such isn'y styled correctly (text is too big).

--------------------------
**Version**: unspecified
**Severity**: normal

**Attached**: {F11600}
Fixed and will go out later today.
Change 73980 merged by jenkins-bot:
Fake superscript style for references generated as spans

https://gerrit.wikimedia.org/r/73980
Change 73980 had a related patch set uploaded by Esanders:
Fake superscript style for references generated as spans

https://gerrit.wikimedia.org/r/73980
(In reply to comment #2)
> Parsoid incorrectly renders references as <span>s. The ones directly in the
> main documented are rendered as <sup>s by VE, but we don't control the ones
> in
> templates and other generated content (and #tag is a ParserFunction).
Ugh, didn't see James's summary edit. Moving back to VE.

We could probably add CSS to make <span class="reference"> render as a superscript, or munge it in some other way. Though ideally I'd like us to convince Parsoid to render references as <sup>s the way the PHP parser does.
Parsoid incorrectly renders references as <span>s. The ones directly in the main documented are rendered as <sup>s by VE, but we don't control the ones in templates and other generated content (and #tag is a ParserFunction).
This is confusing because the lack of superscript makes these refs look like an external link.

This happens with all pages that use [[Template:Geographic reference]], which the English template page says is "a very large number of Wikipedia articles", and that template exists in 15 other Wikipedias including a few on the 'maybe' list for 22 July deployment.

Example in the wild:

https://en.wikipedia.org/wiki/Branford,_Florida?veaction=edit
From an editor on English Wikipedia:

On the whole, I really like it. It's basically intuitive and seems to have massively improved since I first tested it out. The main problem I'm having involves the amount of effort now required to open external links in references (especially those using {{cite web}} etc). As far as I can tell, I have to click on the footnote, then the icon, then the text of the reference, then another icon, then the url parameter, and once I'm done copy and pasting I have to close two pop-ups. Is there any way around this that I've missed? It's not an error or a bug, but it's the main barrier to efficient editing that I've encountered so far. – Arms & Hearts (talk) 16:03, 7 July 2013 (UTC)

--------------------------
**Version**: unspecified
**Severity**: enhancement
It's now possible to easily open links in citations and image captions using the link inspector. The same isn't true of gallery captions, but that's because we still need to make a visual editor for galleries (T45037).
*** Bug 66549 has been marked as a duplicate of this bug. ***
This affects more than just templates.  You can't click to open any internal or external link that is located inside any "node" (galleries, image captions, <references />).
An English Wikipedia user requests clarification of the "cancel" process, saying:

"If you open a page in the VisualEditor, make a few changes, and then decide to hit the "Cancel" button, you get a message that says "Are you sure you want to go back to view mode without saving first?". The options are "OK" and "Cancel", which aren't really proper answers to this yes/no question. As such, I'd like to request that instead the buttons be replaced with "Yes" and "No", which are clear responses to the question. -Thunderforge (talk) 21:36, 6 July 2013 (UTC)"

--------------------------
**Version**: unspecified
**Severity**: enhancement
Change 130394 merged by jenkins-bot:
Swap from using native confirm() to using an OOUI dialog when cancelling

https://gerrit.wikimedia.org/r/130394
Change 132316 merged by jenkins-bot:
Update OOjs UI to v0.1.0-pre (80f1797a5c)

https://gerrit.wikimedia.org/r/132316
Change 132318 merged by jenkins-bot:
Update OOjs UI to v0.1.0-pre (80f1797a5c)

https://gerrit.wikimedia.org/r/132318
Change 132113 merged by jenkins-bot:
Add confirmation dialog

https://gerrit.wikimedia.org/r/132113
Change 132318 had a related patch set uploaded by Alex Monk:
Register OOUI confirmation dialog with windowFactory

https://gerrit.wikimedia.org/r/132318
Change 132316 had a related patch set uploaded by Alex Monk:
Add confirmation dialog messages to MW core

https://gerrit.wikimedia.org/r/132316
Change 132113 had a related patch set uploaded by Alex Monk:
Add confirmation dialog

https://gerrit.wikimedia.org/r/132113
Change 130394 had a related patch set uploaded by Alex Monk:
Swap from using native confirm() to using an OOUI dialog when cancelling

https://gerrit.wikimedia.org/r/130394
**ignatzmice.wiki** wrote:

A user suggests [Return to editor] [Exit without saving]. https://en.wikipedia.org/w/index.php?title=Wikipedia:VisualEditor/Feedback&diff=567692036
From bug 51655 comment 1:

| The confirmation dialog should have more descriptive buttons, such as
|   [Discard edits] [Continue editing]
| , or
|   [Leave editing mode] [Return to editing]
| , etc.
| 
| For this to happen, it needs to become a jQuery dialog.
| 
| In fact, VE shouldn't use native confirm() dialogs; the implementation in
| most browsers is crappy.
*** Bug 51655 has been marked as a duplicate of this bug. ***
**ignatzmice.wiki** wrote:

See bug 51655, which should probably be closed as a duplicate. (On enwiki I'd say "merge".)
Unfortunately we can't actually replace the "OK" and "Cancel" buttons' text - that's supplied by the browser as is unchangeable.

What we can do is tweak the message so it's clear what this does, perhaps. Any ideas what might work better?
**Author:** `adaml`

**Description:**
When editing a table which includes a transclusion as seen on http://test.wikipedia.org/wiki/TableRowTest it seems to copy the row and paste it before the start of the table. 

In the example above, edit the page and select one of the rows for transclusion and change parameter 1 to a different value, all seems to be good until you save the page which screws it up

--------------------------
**Version**: unspecified
**Severity**: enhancement
**See Also**:
https://bugzilla.wikimedia.org/show_bug.cgi?id=50589
https://bugzilla.wikimedia.org/show_bug.cgi?id=50607
The table will still be broken after an edit as Parsoid doesn't run with context yet.
Fixed by gerrit 140439.
This might be related to VisualEditor bug 50607 and foster-parenting.
Confirmed.  This is probably the same problem as bug 50589, but this is a nice simple case and might be easier to solve.
An editor had an issue on English Wikipedia with the hyperlink tool when used within the reference editor.

Specifically, he formatted a reference manually and then used the hyperlink tool within the reference editor to provide an external link to the work. He found that many options were offered, to the point that the reference box was obscured by the list of possible links and he had to just guess where to paste the actual url. 

I reproduced this and took a screenshot. 

http://en.wikipedia.org/wiki/File:VisualEditor_Reference_issue.jpg

--------------------------
**Version**: unspecified
**Severity**: normal
**adam.jenkins** wrote:

Refreshing cache didn't help - I refreshed with VE open and again with the link dialog open. I noticed it didn't occur when adding a normal link in the body, only when adding a link in a reference.
**adam.jenkins** wrote:

Screenshot, Chrome, Mac running OSX 10.8.4

Pop-up list sits above textbox, text box for group appears in pop-up list.

**Attached**: {F11506}
(In reply to comment #3)
> When adding a new reference:
> 
> * I typed in "this is a lunk" (I mistyped link) 
> * Selected "lunk" and click on the link icon
> 
> This produces the pop-up list of suggested links, but it sits over the top of
> the text box, preventing the user from seeing what is typed.

OK, that's definitely broken behaviour - see the attachment I added just now for expected behaviour. Can you give a screenshot of what it looks like for you (is Maggie's link - http://en.wikipedia.org/wiki/File:VisualEditor_Reference_issue.jpg - accurate)? Does is still occur? In what skin? Do you have some gadgets installed, and does it occur if you disable them?

> As a secondary problem, (which is why I used "lunk" as an example above), if
> the pop-up list is long enough to extend over the "Use this group" textbox,
> the textbox appears as an item in the pop-up list. You can see it a bit in
> the attachment Maggie provided. If the pop-up list is longer, it is inserted
> between elements.

That won't happen if the link inspector's suggestion box appears in the correct mode.

> This does not occur in Chrome under Windows 7, as pop-up list appears below
> the text box, and doesn't have the issue with the "Use this group" textbox.

This looks horribly like a caching bug - what happens if you hard-refresh (in Chrome on Mac, Command-Shift-R on any page whilst in VisualEditor mode)?
Created attachment 12795
Expected behaviour if adding a link in a DOM dialog like a reference

**Attached**: {F11505}
**adam.jenkins** wrote:

I've been able to recreate the behaviour using Chrome on the iMac.
**adam.jenkins** wrote:

Hi! I'm currently running Chrome 26 on a MacBook Pro retina running 10.8.4, but I think I also had it on an iMac, but I'll confirm. When adding a new reference:

* I typed in "this is a lunk" (I mistyped link) 
* Selected "lunk" and click on the link icon

This produces the pop-up list of suggested links, but it sits over the top of the text box, preventing the user from seeing what is typed. A url can still be pasted in. If the user types a URL, the pop-up list will disappear, but reappear after any pause in typing, hiding the box again. (This reappearance would be desired behaviour normally).

As a secondary problem, (which is why I used "lunk" as an example above), if the pop-up list is long enough to extend over the "Use this group" textbox, the textbox appears as an item in the pop-up list. You can see it a bit in the attachment Maggie provided. If the pop-up list is longer, it is inserted between elements.

If a URL is entered the list reduces in size to two elements, the link in blue as an "External link", and the link in red as a "New page". However, the window still slightly overlaps the text box for entering the URL, and if accidently clicked when trying to select the textbox again, the link is changed to a wikilink and the options disappear. But there is no indication that this has occurred. This seems in part to be the "new pages appear as blue links" bug, so it might be fixed as part of that.

This does not occur in Chrome under Windows 7, as pop-up list appears below the text box, and doesn't have the issue with the "Use this group" textbox.
Maggie, I am not able to reproduce this behavior in Chrome or Firefox; the references dialog expands with a scrollbar if needed. Are you still getting this? If so could you provide more detailed steps to reproduce and browser info? Thanks!
I should add his words (User:Bilby):

"Short version - the pop-list of suggested wikilinks was malformed if it was long enough to cover the group name box, and prevents the user from seeing the text box when pasting a URL. When a URL is blindly pasted, it is easy to accidentally click on the wikilink option, but there is no indicator that this has occurred once the pop-up list disappears."

See http://en.wikipedia.org/w/index.php?title=Wikipedia:VisualEditor/Feedback&oldid=563382661#Adding_references_with_links
It's strange that I can't find a bug for this. Lots of user on en.wiki complained loudly about this [1], but nobody succeded to write a bug report for it? Well, here it is:

Please provide an option in user preferences to turn VE off. Some users just don't like it and don't want to have an extra tab which they don't use anyway. The gadget isn't perfect, as the tab might appear for short time before it is removed again, and has to updated when VE integration changes. The only reason I found for why there is no such option is this:

"It was planned, but the code turned out to be seriously buggy at the last minute. Getting it really, truly off (rather than just covered up) is more complicated than expected." Whatamidoing (WMF) (talk) 06:32, 2 July 2013 (UTC)

Now with the minimized amount of code that is loaded at startup, it is acceptable to load the code, but just not to execute it. Adding

if ( !mw.user.options.get( 'visualeditor-enable' ) ) {
 return;
}

near to the end of modules/ve-mw/init/targets/ve.init.mw.ViewPageTarget.init.js should be all that's really needed.

[1] https://en.wikipedia.org/wiki/Wikipedia:Vpt#.22Opt_out.22_of_VE_needed_under_preferences

--------------------------
**Version**: wmf-deployment
**Severity**: enhancement
**URL**: https://en.wikipedia.org/wiki/Wikipedia:Vpt#.22Opt_out.22_of_VE_needed_under_preferences
**See Also**:
https://bugzilla.wikimedia.org/show_bug.cgi?id=52086
[This comment is about the generalisation in the VE extension of the deployed patch, I open the bug 52086 for this specific generalisation inside the VE product.]

I can see the logic behind the introduction of the new preference (use a negative preference instead of a positive to use it on wikis where the VE is the default editor), but for the sake of generality of the VE extension it would be better to name it as "visualeditor-preference-disable: Disable VisualEditor" (see bug 52086).

And the temporary messages related to the deployment-test in the Wikimedia environment could be overriden in the WikimediaMessages extension. E.g. 
  "visualeditor-preference-enable: Enable VisualEditor (experimental, [[{{int:visualeditor-feedback-link}}|please help in reporting bugs]])"
  "visualeditor-preference-disable: Disable VisualEditor [during the beta phase] (but [[{{int:visualeditor-feedback-link}}|please help in reporting bugs]])"
(I guess in this case the WikimediaMessages section in InitialiseSettings.php should be move below the VisualEditor section)
I agree with hashar as well. And who knows, maybe hopefully by the time VE is out of beta this preference will not be really necessary (per comment 25). I'm pretty sure we're got at least a few months before we'll have to worry about that.
So you will reopen this bug as soon as VE gets stable? Promised?
For what it's worth, I agree with hashar. The bug as filed is resolved: there's now a user preference in the appropriate tab ("Editing") that fully disables VisualEditor.

I think we should deal with the future in the future. :-)
Sorry, your perception of this bug is pretty messed up.

Thhis bug is about "disabling VE", *not* about "disabling VE during beta period".

The patch clearly doesn't solve this problem.
This bug is about having a user preference to disable VisualEditor which is exactly what has been implemented by https://gerrit.wikimedia.org/r/#/c/75541/ . It is the proper way to handle this, not $wgHiddenPrefs :-D

The fact that the preference might be gone after VE is out of beta is a different problem.  For now the request has been fulfilled as far as I understand it.  Just check the "Temporarily disable VisualEditor while it is in beta" in the user preference and VE is gone.
Sorry, but this is clearly *not* fixed!

* The eye-wash preference in VE is nonsense and will be gone quickly when VE comes out of beta.
* The core of the problem - disabling VE when one surely will never use it - will not be solved by this hack.
* The failure by WMF (deploying a buggy beta software to everybody by default) is poorly concealed by this change but not solved either.

In fact you're even working against your own goals with this change: In the beta phase where feedback by editors is needed most you're now offering a preference to disable VE. When VE becomes stable and feedback is not that necessary anymore the preference will be gone, and the same discussion you're trying to mute with this change will start again.

Please reopen this bug, accept https://gerrit.wikimedia.org/r/73565, so we have a real fix in place!
Fixed in VisualEditor extension itself with https://gerrit.wikimedia.org/r/#/c/75541/
Change 73565 abandoned by Hashar:
(bug 50929) Remove 'visualeditor-enable' from $wgHiddenPrefs

Reason:
A preference to temporarily disable VisualEditor has been introduced in the VisualEditor extension itself : https://gerrit.wikimedia.org/r/#/c/75541/

This change is thus no more needed.

https://gerrit.wikimedia.org/r/73565
Noting that the main issues causing people to disable VE are 
1) bloat (this may be more perceived than real; the VE init.js isnt very large, and the scaffolding is used for other features besides VE) and 
2) the UI for edit section links (which is bug 50688 and bug 50540).
I am optimistic that both will be resolved before VisualEditor goes out of beta.
https://gerrit.wikimedia.org/r/#/c/75542/ was merged today, but it is only a dirty workaround that doesn't fix the actual problem. 

What happens when VisualEditor goes out of beta? Will editors that have turned it off be required to switch to it? What if they'd prefer to keep using source editing?
C. Scott Ananian: you're out of line.

Bugzilla is regularly used for discussion (among devs and non-devs alike) and calling it abuse (comment 18) to use Bugzilla's comments field for discussion isn't appropriate at all.

Richard Morris' comment (comment 20) correctly points to on-wiki discussion that's directly relevant to this bug. It's long-standing practice to cross-reference on-wiki consensus-gathering discussion with Bugzilla bugs.
Please do not discuss on this bug. The topic is on wikitech-l which has much more audience and is way easier to handle such long discussions :-]

Thread starts at:
http://lists.wikimedia.org/pipermail/wikitech-l/2013-July/070560.html
@Richard Morris: Please, bugzilla is a tool for developers, not a discussion forum.   Please discuss this on the wikitech-l mailing list (url above, or subscribe at https://lists.wikimedia.org/mailman/listinfo/wikitech-l) or at the RFC you linked to, or on a Talk page.  Anywhere, really, except for bugzilla.

Others: please do not respond here to Richard Morris or others.  Refrain from the temptation, whether you agree with him or not.  Make your point on one of the discussion sites (again: mailing list, talk page, RFC, IRC) not in bugzilla.

Thanks.
Have you guys not read http://en.wikipedia.org/wiki/Wikipedia:VisualEditor/RFC there is a clear consensus, 57 vrs 6, for "VisualEditor should have a way to be turned off fully, easily, and without continuing to leech resources". Many people don't want it the feedback page is constantly getting "how do I switch this off?" threads. Failure to implement this feature is causing more work for those on the wiki and a politically very bad decision.
(In reply to comment #18)
> Tyler, please follow the entire link in comment 16.

I did. It's only 3-4 people talking on a talk page. Kind of pales in comparison to the numerous people who supported this in the original link.

> This discussion is occuring on wikitech-l as well:
> http://lists.wikimedia.org/pipermail/wikitech-l/2013-July/070560.html
> 
> It's probably better to continue the discussion on the mailing list, rather
> than to abuse bugzilla.
> 
> (Just trying to synchronize the conversation.)

Agreed. I've continued the discussion there.
Tyler, please follow the entire link in comment 16.

This discussion is occuring on wikitech-l as well: http://lists.wikimedia.org/pipermail/wikitech-l/2013-July/070560.html

It's probably better to continue the discussion on the mailing list, rather than to abuse bugzilla.

(Just trying to synchronize the conversation.)
(In reply to comment #16)
> Per
> https://en.wikipedia.org/w/index.php?title=User_talk:
> Eloquence&diff=564621335&oldid=564492863
> and other lengthy discussion, this is and remains a WONTFIX.

This is one user's talk page. What discussion are you referring to? Is the link at the top of the page no longer the consensus? Also I'd like to know exactly what reasoning there is for having this preference hidden.
Per https://en.wikipedia.org/w/index.php?title=User_talk:Eloquence&diff=564621335&oldid=564492863 and other lengthy discussion, this is and remains a WONTFIX.

VisualEditor is switched on or off at the wiki-level, not on the per-user level. The fact that there is a temporary artefact of the alpha roll-out still around in the code that allows us to expose this option to users for the next few weeks (until it too goes away once the alpha roll-out is no longer needed) does not mean we should dishonestly mis-lead users into thinking that we are supporting this as a preference, which is what implementing this request would do.
That would reopen bug 48666 Make VisualEditor a hidden preference.
*** Bug 51389 has been marked as a duplicate of this bug. ***
Change 73565 had a related patch set uploaded by Odder:
(bug 50929) Remove 'visualeditor-enable' from $wgHiddenPrefs

https://gerrit.wikimedia.org/r/73565
(In reply to comment #7)
> This will not be a request only for English Wikipedia any longer, as soon as
> the VE is activated by default on Wikipedias in other languages. Keep that in
> mind!

just in case what Bartos wrote is not 100% clear:

The extension already implement a user-selectable enable/disable switch - nothing should be done there. 
LocalSettings.php for enwiki specifically removes the choice, by setting the line

"$wgHiddenPrefs[] = 'visualeditor-enable';"

this bug is basically a request to delete this line from enwiki's LocalSettings.php, and thus allowing users to opt-out of VE.

a derivative request would be such: once VE is enabled by default on other wikis, please do not to add such a line to their LocalSettings.php.
the second part is a "forward looking" request, i.e. it's a request not to do something in the future, without actually knowing if there's any intention to do it...

(as a side, it seems that the decision to remove user's switch was not a good one: the main result of this decision was that on enwiki, someone had to write a special gadget for disabling VE, instead of just using the built-in switch...)

peace.
Great, thank you.

I'm marking this bug with the "easy" keyword accordingly.
(In reply to comment #9)
> Can you explain what the code in this area looks like? There _was_ a user
> preference previously, it's just gone missing. Is this simply a matter of
> setting a configuration variable?

Yes, it's just a matter of removing "$wgHiddenPrefs[] = 'visualeditor-enable';" in CommonSettings.php.
(In reply to comment #6)
> This is actually a site request for the English Wikipedia right now, as this
> preference is enabled everywhere else right now. Changing Product/Component
> accordingly.

Can you explain what the code in this area looks like? There _was_ a user preference previously, it's just gone missing. Is this simply a matter of setting a configuration variable?
(In reply to comment #3)
> This should be in the obvious place, in the editing tab of user preferences,
> not a gadget.

Yep.
This will not be a request only for English Wikipedia any longer, as soon as the VE is activated by default on Wikipedias in other languages. Keep that in mind!
This is actually a site request for the English Wikipedia right now, as this preference is enabled everywhere else right now. Changing Product/Component accordingly.
*** Bug 51179 has been marked as a duplicate of this bug. ***
Created attachment 12827
en.wp temporary workaround

Since I doubt this will get fixed any time soon, I have implemented a change to a label, to redirect users with words from on preferences tab to another.

**Attached**: {F11458}
This should be in the obvious place, in the editing tab of user preferences, not a gadget.
(Quote from comment #0)
> The gadget isn't perfect, as the tab might appear for short time before it is
> removed again, and has to updated when VE integration changes.
To disable: Preferences > Gadgets > Editing (section) > checkmark for "Remove VisualEditor from the user interface" > Save

This is probably mentioned on http://en.wikipedia.org/wiki/Wikipedia:VisualEditor/Feedback
See: https://en.wikipedia.org/w/index.php?title=New%20Zealand%20English&diff=0&oldid=123

--------------------------
**Version**: unspecified
**Severity**: minor
**URL**: https://en.wikipedia.org/w/index.php?title=New%20Zealand%20English&diff=0&oldid=123
This is now deployed and appears to be working as expected in production, according to my testing. Marking as fixed. Please re-open if you find otherwise.
Change 72544 merged by jenkins-bot:
mw.ViewPageTarget.init: Only bind edit section links on view page

https://gerrit.wikimedia.org/r/72544
Change 72544 had a related patch set uploaded by Krinkle:
mw.ViewPageTarget: Don't bind edit section links on non-view page

https://gerrit.wikimedia.org/r/72544
(In reply to comment #0)
> See:
> https://en.wikipedia.org/w/index.
> php?title=New%20Zealand%20English&diff=0&oldid=123

I *think* this will get fixed by gerrit 72070 - Timo?
Taken from English Wikipedia

***

[[Template:Convert]] is actually a good example of where TemplateData falls over and hits the ground. The meaning of the numbered parameters changes depending on how many of them there are and whether the entry is text or a number. For example, each of the following are valid:
{{convert|3.21|kg|lb}}
3.21 kilograms (7.1 lb)
{{convert|3.21|mi|3}}
3.21 miles (5.166 km)
{{convert|60|to|170|kg|lb}}
60 to 170 kilograms (130 to 370 lb)
{{convert|60|+/-|10|kg|lb}}
60 ± 10 kilograms (130 ± 22 lb)
{{convert|6|ft|5|in|m}}
6 feet 5 inches (1.96 m)
In those examples, parameter 3 is variously 1) The output unit, 2) The number of significant figures, 3) The upper limit of a range, 4) The measurement uncertainty, 5) The number of inches in foot-inches measurement. Now write a TemplateData description for parameter 3 (or 2 or 4 or 5)? Convert is used on 500,000+ pages, so it is not like it can simply be redesigned at this point. That said, if someone can see the values of each parameter in the transclusion window then it would still be pretty easy to figure out which one they need to edit. I would suggest that the transclusion editor needs a way to preview the parameter contents (even if just a snippet) without having to click on each parameter. Dragons flight (talk) 17:57, 5 July 2013 (UTC)

--------------------------
**Version**: unspecified
**Severity**: enhancement
Reproduce:

1. Go to this page: https://he.wikipedia.org/wiki/%D7%A9%D7%9C%D7%9E%D7%94_%D7%A4%D7%99%D7%9C%D7%91%D7%A8 (Image is floating on the left)

2. Edit the page. The image is now stretched all across the content area, pushing the text down.

This is a 'no picture existing' template. In the Hebrew wiki: https://he.wikipedia.org/wiki/%D7%AA%D7%91%D7%A0%D7%99%D7%AA:%D7%90%D7%99%D7%9F_%D7%AA%D7%9E%D7%95%D7%A0%D7%94

It is probably an issue of the template code, but since it's used very often, it would be great if someone can help find the problem in this so we can fix the template itself.

--------------------------
**Version**: unspecified
**Severity**: normal
**See Also**:
https://bugzilla.wikimedia.org/show_bug.cgi?id=50395
Change 105639 merged by jenkins-bot:
CSSJanus: Account for attribute selectors in brace lookahead

https://gerrit.wikimedia.org/r/105639
Change 105640 merged by jenkins-bot:
Force CSSJanus to not flip image alignment classes

https://gerrit.wikimedia.org/r/105640
Change 105639 had a related patch set uploaded by Catrope:
Support attribute selectors in CSSJanus

https://gerrit.wikimedia.org/r/105639
Change 105640 had a related patch set uploaded by Mooeypoo:
Force CSSJanus to not flip image alignment classes

https://gerrit.wikimedia.org/r/105640
I found the remaining issue - since the page (and transclusion div) is set to dir='rtl' the "mw-halign-left" class float:left turned to float:right. 

This is quite odd, since these classes have /*@noflip*/ on them.
Ah! Partially. The image is no longer spread wide, but it floats the wrong way - it should float to the left, but it floats to the right inside VE.
Was this fixed by the fix for bug 53436?
A user points out that much of our communication both external and internal of the wiki instruct people to leave an edit summary, but the save dialog doesn't name this field as such, which might make it difficult for people to make a match between the instructions and the actual save dialog.

--------------------------
**Version**: unspecified
**Severity**: enhancement
This was done, ages ago.
If you have the [[Hands-on universe|Hands-On Universe]] link, it will report that Hands-On universe doesn't exist (which it does). This is probably because it matches on the different case: Hands-On Universe and then stops comparing.

--------------------------
**Version**: unspecified
**Severity**: normal
**See Also**:
https://bugzilla.wikimedia.org/show_bug.cgi?id=52596
This was fixed as part of the tweaks to the link inspector earlier this month.
Per discussion at Bug 52596 the presence of a redirect with a title of <=3 characters /may/ prevent an article with that title (but differently capitalised) appearing in the suggestions list.

For example the existence of the [[Fra]] redirect may be what is preventing the [[FRA]] article appearing in the list (something is, and the redirect is one theory).
Forgot to add that redirects that differ other than by capitalisation are shown - e.g. [[Elizabeth II of the United Kingdom]], a redirect to [[Elizabeth II]], appears in the suggestions list.
*** Bug 52251 has been marked as a duplicate of this bug. ***
This also happens with redirects. 
For example, [[Github]] is a redirect to [[GitHub]] but [[github]] is shown as not existing.

See attachment 13013 to bug 52251
(In reply to comment #1)
> Other examples: [[A]], [[B]], [[To]], [[Hi]]

I filed this as bug 51013.
Other examples: [[A]], [[B]], [[To]], [[Hi]]
In the old editor, you could hit ctrl-alt-s to save the page. In the new editor the save action is not reachable using the keyboard.

We could just add ctrl-s/cmd-s to the Save button ?

--------------------------
**Version**: unspecified
**Severity**: enhancement
**See Also**:
https://bugzilla.wikimedia.org/show_bug.cgi?id=38042
https://bugzilla.wikimedia.org/show_bug.cgi?id=50047
Change 110434 merged by jenkins-bot:
Use accesskey=s on the save buttons

https://gerrit.wikimedia.org/r/110434
Change 113319 abandoned by Esanders:
Add save shortcut to dialog

Reason:
ALT+S is MediaWiki only, abandoning in favour of Idf4fa31b98d1fa9e

https://gerrit.wikimedia.org/r/113319
Change 113319 had a related patch set uploaded by Alex Monk:
Add save shortcut to dialog

https://gerrit.wikimedia.org/r/113319
Change 110434 had a related patch set uploaded by Alex Monk:
Use accesskey=s on the save buttons

https://gerrit.wikimedia.org/r/110434
Trying to use accesskey=s like action=edit will make this conflict with FlaggedRevs, which doesn't appear on action=edit but does on veaction=edit (with display:none).
I don't have any particularly strong views about the right way to do this, but I really want to be able to open the page in VisualEditor, make a small change to the text, and save the page, without ever taking my hands off the keyboard.
*** Bug 53693 has been marked as a duplicate of this bug. ***
*** Bug 52745 has been marked as a duplicate of this bug. ***
Having shortcuts for Show preview/Review your changes, and for Save page (two different buttons, so if one shortcut is used for both, VE needs to check whether it is on the main page or in a dialog box), would certainly be helpful. To quote the WMF Deputy Director: "It's worth noting that VisualEditor has its own set of keyboard shortcuts, which can help with common tasks such as linking (which I actually already find faster in VE) ..."

And yes, there is also the accessibility issue - anything that can *only* be done by mouse is, by definition, an immovable problem to a physically disabled person who can only use a keyboard.
(In reply to comment #2)
> In the old editor, I would simply use TAB to reach the edit summary, type my
> edit summary and press ENTER to activate the "Save page" button and save. If
> I wanted to mark the edit minor, then I could type my edit summary, press TAB,
> SPACE, and then ENTER to "Save page".

Yeah... I split this out to bug 51918.
This seems similar to bug 38042. They're not identical but definitely related and they could possibly be usefully fixed at the same time.
**sk8er_97456** wrote:

In the old editor, I would simply use TAB to reach the edit summary, type my edit summary and press ENTER to activate the "Save page" button and save. If I wanted to mark the edit minor, then I could type my edit summary, press TAB, SPACE, and then ENTER to "Save page".

I can see that the new box for entering an edit summary allows newlines to be entered. I am not sure this is a good idea, because I just used a WSYIWYG editor and now "What I see" - well-formatted paragraphs describing my edit - is not going to be "what I get" - everything smashed on one line in the article history. But that is perhaps grist for another bug mill.

It seems that the "Save page" button never receives caret focus if I use TAB to try to get there. This would seem to have accessibility ramifications.
I think taking over ctrl-s/⌘-s which is already used by every browser for a different task (local save of rendered HTML) is a bit rude; I'd suggest just implementing the same keyboard shortcut.
For example, look at https://en.wikipedia.org/w/index.php?title=Peach_Springs_Trading_Post&oldid=563257259&veaction=edit.

Citation [1] is defined inside the infobox template. It is then reused at the end of the first paragraph, but when you click the [1] there, you get an inspector with the message: "This reference is defined in a template or generated block and for now can be only edited in source mode."

This also comes up when citations are defined within a template like `{{reflist}}`, as at https://en.wikipedia.org/w/index.php?title=Helminthopsis&oldid=592365854.

**See Also**:
T53289
Why isn't this given a higher priority, and/or assigned to someone? This issue affects every article that has an infobox with one or more citations, and that's a VERY large number, and continually increasing - and a high percentage of the most viewed articles DO have infoboxes.

More importantly, this isn't just an issue of problems with reuse: having a citation/footnote in a template such as an infobox also disrupts the numbering system for footnotes - the numbering that what appears in the body of an article, when in VE editing mode, //doesn't match //the list of footnotes shown in VE editing mode. That's obviously a source of confusion to those doing editing; again, this certainly affects thousands of articles, and quite probably tens of thousands. 

We //want// as much information as possible in Wikipedia articles to have inline supporting sources, and infoboxes are extremely popular (and helpful to readers). But the combination - citations inside templates such as infoboxes - is currently disruptive when editing using VE. That should be fixed.
This should NOT be a low priority. It's quite common for an article to have ALL references inside a template - see, for example, https://en.wikipedia.org/wiki/Helminthopsis . 

At the moment, VE is able to figure out that the citation information is elsewhere - a tooltip appears that says "This reference is defined in a template or other generated block, and for now can be only edited in source mode." If VE can figure that out, then it should be able to perform the following three additional steps:

* Check if the information is in the {{reflist}} template (match the "ref name=" parameter in the body of the text to a ref name parameter within the reflist template)

* If a match is found, pull the relevant citation information from the reflist template, allowing the user to edit it

* After the edit is finished, put the (modified) citation information back into the reflist template

(Side note: for edit conflict purposes, this is an edit of the section where the reflist template is located, not where the footnote label exists within the body of the text).

If VE is NOT modified to allow users to edit such references/citations, users are going to be (randomly) frustrated because they can't edit any footnotes in some articles using VE (see above) and because in some articles (https://en.wikipedia.org/wiki/Pope_Francis , for example), there are occasional footnotes that aren't editable in VE.
This happens with the Link annotation, but also happened to me with my Language annotation prototype when I play with it.

Steps to view the problem:
1. Go to some link in the text, put the cursor on it.
2. The 'link' button pops up, recognizing the annotation, and if you click it, the full annotation fragment is selected (expected behavior) and the input widget appears.
3. Without closing the input widget, click on another link in the text. The widget moves to the new location with the proper data, but the text of that fragment isn't selected, and it's a bit odd to edit. 

I think a better behavior may be to close the widget and have the icon pop up on the new location, as if I clicked an unrelated non-link text and then again selected a link.

(I hope this makes sense, I can post some screenshots if needed)

I use Firefox 22.0 under Ubuntu.

--------------------------
**Version**: unspecified
**Severity**: minor
Looks like the fix works. Can't reproduce this anymore on latest master.
Change 72865 merged by jenkins-bot:
Reset context menu on selection change while inspector is open

https://gerrit.wikimedia.org/r/72865
Change 72865 had a related patch set uploaded by Jforrester:
[WIP] Reset context menu on selection change while inspector is open

https://gerrit.wikimedia.org/r/72865
[[Jyllands-Posten Muhammad cartoons controversy]].

--------------------------
**Version**: unspecified
**Severity**: normal
**See Also**:
https://bugzilla.wikimedia.org/show_bug.cgi?id=51755
https://bugzilla.wikimedia.org/show_bug.cgi?id=52667
This was fixed last week.
*** Bug 62408 has been marked as a duplicate of this bug. ***
In terms of combinations, I think we need to plan to support the display of at least three edit notices.  It is not at all unusual for articles at the English Wikipedia to display both the standard BLP notice (https://en.wikipedia.org/wiki/Template:BLP_editintro) and a semi-protection notice, and being able to view three means that only one more item could be included.

https://en.wikipedia.org/w/index.php?title=Barack_Obama&action=edit&editintro=Template:BLP_editintro shows three items.  Some of them have much longer notices.  https://en.wikipedia.org/w/index.php?title=Cat&action=edit shows only two, but one has some fairly long collapsed text (which VisualEditor does not collapse).
It's not just single long edit notices, combinations of messages can also exceed screen height, e.g. at [[Caucasian Albania]]. The ArbCom sanctions notice is only about 5 lines in the source view, which has vastly greater horizontal space, likewise the semi-protection notice is designed for a horizontal layout.

Is there a reason why the VE notices must be vertical? Could they not horizontally expand to fit the messages? Doing so would reduce (but not remove) the need for bug 52471
In general, long edit notices misunderstand the concept of a brief message for users - but yes, we should fix this.
Comments from bug 52602

"Edit notices should scroll when they are larger than the height of the window.
Presently the bottom of the message is unreadable. The screenshot attached
shows en.wp's "Today's featured article" edit notice displayed in a 581px high
window (which is what I normally use for browsing)."

The screenshot is attachment 13067

"A couple of users have reported this also happening with "the notice
specifically for VE", which I presume is the beta welcome dialog. They are
unable to scroll through and read it all."
*** Bug 52602 has been marked as a duplicate of this bug. ***
If you click in the link
https://en.wikipedia.org/wiki/Math?veaction=edit
you will be redirected to [[Mathematics]] and the VisualEditor will load on that page instead of in the redirect page [[Math]].

--------------------------
**Version**: unspecified
**Severity**: enhancement
**URL**: https://en.wikipedia.org/wiki/Math?veaction=edit
**See Also**:
https://bugzilla.wikimedia.org/show_bug.cgi?id=54921
https://bugzilla.wikimedia.org/show_bug.cgi?id=25470
Change 95213 merged by jenkins-bot:
Let users set #REDIRECT and __STATICREDIRECT__ status

https://gerrit.wikimedia.org/r/95213
*** Bug 60425 has been marked as a duplicate of this bug. ***
Change 95213 had a related patch set uploaded by Jforrester:
[WIP] Let users set #REDIRECT

https://gerrit.wikimedia.org/r/95213
Change 95103 had a related patch set uploaded by Jforrester:
[WIP] Let users set #REDIRECT, __NOTOC__, & __FORCETOC__

https://gerrit.wikimedia.org/r/95103
(In reply to comment #3)
Indeed, I first noticed this bug in a user page which was a redirect.
I figured out that the redirect was the reason why I could not see VE tab on my userpage at vec.wiki, but I also suggest that this should probably be more visible. Redirects are also widely used on user pages, and I assume that there will be people who might consider writing a proper user page with VE at some point and will be puzzled that they can't find its tab there. Just my 2c :)
Not a duplicate of bug 50877; this is about being able to edit page redirects, which is an enhancement we want to do shortly, blocked by bug 47328.
I assume this bug is a duplicate. I believe an initial compromise was to remove the "edit" tab (leaving only "edit source") on redirects. But the behavior here still is pretty wonky and will likely remain wonky until someone writes a redirect VisualEditor module/plugin, I think?
If you click in the link
https://en.wikipedia.org/wiki/Special:MyPage?veaction=edit
you will be redirected to your user page in "view" mode instead of "vedit" mode

--------------------------
**Version**: unspecified
**Severity**: minor
**URL**: https://en.wikipedia.org/wiki/Special:MyPage?veaction=edit
Change 134788 merged by jenkins-bot:
Preserve veaction, vesection on special redirects to wiki pages

https://gerrit.wikimedia.org/r/134788
Change 134788 had a related patch set uploaded by Mattflaschen:
Preserve veaction, vesection on special redirects to wiki pages

https://gerrit.wikimedia.org/r/134788
From bug 51178 comment 0:

| The veaction parameter is not passed by Special:MyPage, so links like this do
| not work: http://en.wikipedia.org/wiki/Special:MyPage/sandbox?veaction=edit
|
| See the patch for bug 45219 for the way a similar issue was solved for the
| Guided Tours extension.
*** Bug 51178 has been marked as a duplicate of this bug. ***
Lots of testing involved here; currently assigning to myself.

--------------------------
**Version**: unspecified
**Severity**: normal
This is not the right task for "add something to the whitelist".
re-opening since I think it works pretty well.
INVALID-ing this given that the answer on testing is 'no'. Will need to take forward as real bugs, sadly.
(In reply to comment #1)
> Currently the answer appears to be "no we don't work very well". :) Selection
> is broken, and typing seems to eat the entire document.

Darn. :-(

> James, do you have a copy of Windows 8.1 Preview to test with? I can provide
> an installer ISO and a couple of product keys if you need them. Runs fine in
> Parallels.

Thanks for the offer, though Microsoft reached out to us and gave me the same; I've just not had a chance to do anything with it yet.
Currently the answer appears to be "no we don't work very well". :) Selection is broken, and typing seems to eat the entire document.

James, do you have a copy of Windows 8.1 Preview to test with? I can provide an installer ISO and a couple of product keys if you need them. Runs fine in Parallels.
Even though section editing in VE is a long way off, it would be really helpful if the title of the section you click edit on was automatically included in the edit summary in the same way that the source editor does. For example, when making [https://en.wikipedia.org/w/index.php?title=Viareggio_train_derailment&diff=next&oldid=563164136 this edit] I launched the VE by clicking on the edit link for the "See also" section, so I was expecting the edit summary to begin with the usual "-> See also". This provides context for the edit summary and so helps give context at recent changes and on watchlists.

--------------------------
**Version**: unspecified
**Severity**: enhancement
**See Also**:
https://bugzilla.wikimedia.org/show_bug.cgi?id=56891
https://bugzilla.wikimedia.org/show_bug.cgi?id=51903
Done and will be deployed tomorrow.
Change 74545 merged by jenkins-bot:
Prepend section title to edit summary

https://gerrit.wikimedia.org/r/74545
(In reply to comment #7)
> *** Bug 51903 has been marked as a duplicate of this bug. ***

not exactly: this bug is about "when launched from section edit link".

IMO, this will be wrong: VE does not support section edit, and a user can launch VE from a section edit link, and then do whatever anywhere on the page. 

bug 51903 asked VE to analyze the page when the user press "save", find out whether or not the changes are confined to a specific section, and if so (regardless of how VE was launched), add the section name to the summary.

so i do not think these two are truly "duplicates". 
if anything, this bug should be marked "invalid" and bug 51903 should be resurrected (51903 was opened as "enhancement request").

peace.
*** Bug 51903 has been marked as a duplicate of this bug. ***
Change 74545 had a related patch set uploaded by Esanders:
Prepend section title to edit summary

https://gerrit.wikimedia.org/r/74545
*** Bug 51343 has been marked as a duplicate of this bug. ***
Well, having a misleading "edit section" link isn't considered a problem.
Absolutely it can (and probably should) be removable.

As for editing other sections, hmm. My initial thought is to wonder whether it could be detectable from the diff generator which section(s) have been edited?
*** Bug 50535 has been marked as a duplicate of this bug. ***
(In reply to comment #0)
> Even though section editing in VE is a long way off, it would be really
> helpful if the title of the section you click edit on was automatically
> included in the edit summary in the same way that the source editor does.
> For example, when making https://en.wikipedia.org/w/?diff=next&oldid=563164136
> this edit I launched the VE by clicking on the edit link for the "See also"
> section, so I was expecting the edit summary to begin with the usual "-> See
> also". This provides context for the edit summary and so helps give context
> at recent changes and on watchlists.

Won't this be rather mis-leading? Normally reviewers will expect the changes to be limited to that section, whereas editors are unlikely to keep their changes restricted in that way. Potentially we could add it into the edit summary box before the user adds anything, so they can remove it if they want?
Original bug title:
mediawiki.notification should show the notification bubble relative to the screen, not to the document

Current behaviour:
Calling mw.notify("abc") in JavaScript creates a message-bubble somewhere below the first <h1> heading (the title) and the bubble disappears after about 5s.

Why this is an issue:
But if you have scrolled-down the page, the notification disappears without being read.

Where is this an issue:
For example, when marking large new pages as patrolled, the patrol link is at the bottom of the page and the message whether patrolling succeeded is not visible to the user. Or at custom gadgets/user scripts.

Expected behaviour:
Bubble shown, no matter of the current scroll position.

Possible implementation:
Fixed position.

--------------------------
**Version**: 1.22.0
**Severity**: enhancement
*** Bug 48689 has been marked as a duplicate of this bug. ***
Change 75662 had a related patch set uploaded by Matmarex:
mw.notification: Fix incorrect initial offset

https://gerrit.wikimedia.org/r/75662
@se4598, thanks for the report, I7444bf55 should fix this. Sorry!
above change deployed recently doesn't work for me; breaks UI:
* notification doesn't scroll with
* blocks user bar and other tabs in the top right corner
* css style changed

experienced in firefox 22 as well in chrome
Change 75614 merged by Catrope:
mediawiki.notification: Make notification area sticky to window

https://gerrit.wikimedia.org/r/75614
Change 75611 merged by Catrope:
mediawiki.notification: Make notification area sticky to window

https://gerrit.wikimedia.org/r/75611
Change 75614 had a related patch set uploaded by Catrope:
mediawiki.notification: Make notification area sticky to window

https://gerrit.wikimedia.org/r/75614
Change 75611 had a related patch set uploaded by Catrope:
mediawiki.notification: Make notification area sticky to window

https://gerrit.wikimedia.org/r/75611
Fixed in the above patch, which we will deploy tomorrow as a cherry-pick given the need to fix this urgently for VisualEditor.
Change 72322 merged by jenkins-bot:
mediawiki.notification: Make notification area sticky to window

https://gerrit.wikimedia.org/r/72322
*** Bug 51785 has been marked as a duplicate of this bug. ***
Change 73948 abandoned by Krinkle:
Use fixed position for notifications

Reason:
Dupe of Icb7cd68f484 (which has existed longer)

https://gerrit.wikimedia.org/r/73948
Change 73948 had a related patch set uploaded by Helder.wiki:
Use fixed position for notifications

https://gerrit.wikimedia.org/r/73948
*** Bug 51432 has been marked as a duplicate of this bug. ***
>Argh, I forgot that position:fixed is always relative to the entire document, >not to any positioned ancestor.
This is only true if you set top,left,right or bottom, AFAIK. Look at [[:commons:Special:Permalink/99667607]] (the grey DIV 2 inner is fixed)

See also http://stackoverflow.com/questions/8712047/positionfixed-when-left-top-right-bottom-arent-specified-desired-results-in

If one still wants to use something fancier (and one will have to for safari, unfortunately), one may use jQuery:
offset ( http://api.jquery.com/offset/ ) -- "Get the current coordinates of the first element in the set of matched elements, relative to the document."
This way one can get the position of mw.util.$content and add 1em. Here is an example implementation (one has to execute the positioning code every time the message is shown or one has to catch window.resize events).

var $content = mw.util.$content,
    $container = $('<div>').appendTo($content)
    $n = $('<div>').text('Message here').css({
     'float': 'right', // Set this in CSS so Janus can flip!
     'margin':  '1em'
    }).appendTo($container),
    o = $content.offset();
    
$container.css({
    position: 'fixed',
    width: $content.width()
}).offset(o);

Feel free to improve (padding of mw.util.$content is not respected) and note that styles are also touched in skin files like skins/vector/screen.css ( https://git.wikimedia.org/blob/mediawiki%2Fcore.git/9cbd77868a92022170348504fb5444e4e1f302fa/skins%2Fvector%2Fscreen.css#L807 )
Heh, I though they behave in this way. Seems like an obvious enhancement.
Change 72322 had a related patch set uploaded by Matmarex:
mediawiki.notification: Show the notifications relative to the screen

https://gerrit.wikimedia.org/r/72322
Allow launching a tour while limiting it to once per-user.  The idea is that GuidedTour handles this, so the calling code (GettingStarted, VisualEditor, etc.) doesn't need to think about hidden user preferences, etc.  I'll call it launchOnceForUser as illustration; better name suggestions welcome

Example use case: The VisualEditor edit screen calls launchOncePerUser, then GuidedTour decides internally whether to launch it based on whether the user has already seen it.

Ideally, it will allow launching immediately, and pre-launching by setting a cookie (we did this once with GettingStarted).

--------------------------
**Version**: master
**Severity**: enhancement
I need to think about whether this should go in the tour specification (defineTour), the launch site, or both.
We have lots of occurrences of 'cache': 'false' in $.ajax invocations in our code, and only one occurrence of 'cache': true. Based on the documentation, it seems to me that 'cache' should pretty much never be set to false. But then again, we set it to the string 'false', not the boolean false.

This seems bad and in need of cleanup. Assigning to Timo.

--------------------------
**Version**: unspecified
**Severity**: enhancement
Done in Roan's clean-up of API usage.
Take for example this: 
https://en.wikipedia.org/wiki/AMS-LaTeX?veaction=edit

The green alienation is only covering one line of the Math block after the sentence: "causes the equals signs in the two lines to be aligned with one another, like this:"

{F11183}

**See Also**: {T66625}
Quote: "I was editing this revision https://en.wikipedia.org/w/index.php?title=Chubby_bunny&oldid=562098358 of [[Chubby bunny]] to try to remove a thumbnail of a deleted image, the following wikitext:
[[Image:Sara_Jay_Chubby_Bunny_Challenge.png|thumbnail|Sara Jay playing Chubby Bunny]]

The red image link and/or its caption shown in the normal article view do not appear in the Visual Editor view and as far as I tell removing it in that view is impossible."

--------------------------
**Version**: unspecified
**Severity**: minor
Change 210625 merged by jenkins-bot:
Representation of red-linked images in VE

[[https://gerrit.wikimedia.org/r/210625]]
Change 210625 had a related patch set uploaded (by SuchetaG):
[WIP] Representation of red-linked images in VE

[[https://gerrit.wikimedia.org/r/210625]]
The current handling of red-linked images in wmf1.25/1.26

-  the non-existing images can be inserted only in 'Edit source'
-  in Read they are represented as {F113350}
-  switching to VE {F113352}

- hovering over the image gives: 'Sorry, this element can only be edited in source mode for now.'
- the image can be deleted in VE
>>! In T52788#1210051, @cscott wrote:
> We are emitting the mw:Error markup in Parsoid, I believe, and that hasn't changed.  What @mooeypoo reports is a regression in VE?

Probably.
We are emitting the mw:Error markup in Parsoid, I believe, and that hasn't changed.  What @mooeypoo reports is a regression in VE?
This is no longer the case. Red link images (or images that aren't loading, in the case of bad internet, etc) are disappearing from CE completely.
Marking as Resolved.
This task is open but has two "verified-in-phaseX" projects associated. Could someone clarify?
Visual editor displays a placeholder for non-existent images, so red-linked images can be deleted from VE.
Checked in production/betalabs/test2.
(In reply to C. Scott Ananian from comment #5)
> There's a draft spec at
> https://www.mediawiki.org/wiki/Parsoid/MediaWiki_DOM_spec#Error_handling --
> would that work for VE?
It would be reasonable-ish. Having a separate mw:Error type would be quite inconvenient though, we'd have to add it to (almost) all of our node definitions. Would it be OK to drop the mw:Error type and just have the data-mw thing there?
There's a draft spec at https://www.mediawiki.org/wiki/Parsoid/MediaWiki_DOM_spec#Error_handling -- would that work for VE?
*** Bug 52186 has been marked as a duplicate of this bug. ***
So currently redlink images are returned as <meta typeof="mw:Placeholder">. I see a couple of ways to solve this:

1. Parsoid gives us back normal image tags, and we make sure our handling of images can deal with 404 src's. This way when we support changing image src's these will be editable in a useful way.

2. We treat mw:Placeholder as real data, and come up with a rendering for it (maybe using parsewikitextfragment, like templates). We'd need to know what else converts to a mw:Placeholder as this may be undesirable in other situations.

Pinging gwicke as this requires some Parsoid input.
*** Bug 51968 has been marked as a duplicate of this bug. ***
Yes, this is a bit of a mess.
Tracking bug for:

- Browsers that shouldn't be blacklisted but are;

- Browsers that should be blacklisted but aren't.

--------------------------
**Version**: unspecified
**Severity**: normal
Replaced by #VisualEditor-Initialisation.
There's no real point adding Bugzilla aliases, as Phabricator doesn't support them so they're going to get dropped in a matter of weeks.
I'm going to add MSIE to the list, given that we really should get it working again.
Following up to T52534, at least currently, Firefox 11 and 12 are broken as well. The first version of Firefox that at least loads the editor is Firefox 13.

Reported by user for Firefox 12, and confirmed in crossbrowsertesting.com.

--------------------------
**Version**: unspecified
**Severity**: major
This is now merged.
Change 72119 abandoned by Jforrester:
Blacklist Firefox 11 and 12

https://gerrit.wikimedia.org/r/72119
Change 72119 had a related patch set uploaded by Jforrester:
Blacklist Firefox 11 and 12

https://gerrit.wikimedia.org/r/72119
Change 72118 abandoned by Jforrester:
Blacklist Firefox 11 and 12

https://gerrit.wikimedia.org/r/72118
Change 72118 had a related patch set uploaded by Jforrester:
Blacklist Firefox 11 and 12

https://gerrit.wikimedia.org/r/72118
Change 72107 had a related patch set uploaded by Jforrester:
Blacklist Firefox 11 and 12

https://gerrit.wikimedia.org/r/72107
May be dup of 50213? 

User:Joe Decker reports:

The revision of an article here (http://en.wikipedia.org/w/index.php?title=David_Busic&oldid=562867623) has an interesting thing, a completely empty bulleted list item, which does not normally display when the article is read. It is just below the reflist, you can both confirm this in the old-style editor, and see it visually in VisualEditor. However, I have found myself unable to delete that from within Visual Editor without also deleting the preceding reference list, which is a little wacky from a UI point of view. E.g., I attempt to backspace over the bullet and I lose a reference list. Reproduced on Chrome and Safari. --j⚛e deckertalk 18:48, 4 July 2013 (UTC)

Replicated by me.

--------------------------
**Version**: unspecified
**Severity**: normal
This now works, probably caused by Ed's re-working of GCNs.
Had the same experience in http://en.wikipedia.org/w/index.php?title=The_Mortal_Instruments%3A_City_of_Bones_%28soundtrack%29&diff=566255621&oldid=566255504 . The empty bulleted list here was something in a sort of template used by the initial creator of the article, to vertically separate two comments. The bulleted list is not visible in the article when read, but is visible in VE: so the careful editor goes to delete this rubbish, and deletes the item above (not the hidden comment, but the reflist, in this case). I'm in Firefox 22 on Vista.
Copied from English Wikipedia:

When I try to use VisualEditor on my Kindle Fire, the article goes into edit mode, but clicking in the article doesn't bring up the keyboard like it does on an iPad. I'm presuming that aading support for the Kindle Fire's Amazon Silk browser isn't on your to do list now. Could you please add this browser to the blacklist? I would like to keep VE on in my preferences so it works when I'm on my PC but not have VE get in the way while on the Kindle. Thanks! GoingBatty (talk) 02:59, 4 July 2013 (UTC)

--------------------------
**Version**: unspecified
**Severity**: minor
Change 72108 merged by jenkins-bot:
Blacklist Amazon Silk

https://gerrit.wikimedia.org/r/72108
Change 110989 merged by jenkins-bot:
jquery.client: Recognise Amazon Silk browser

https://gerrit.wikimedia.org/r/110989
Change 110989 had a related patch set uploaded by Alex Monk:
jquery.client: Recognise Amazon Silk

https://gerrit.wikimedia.org/r/110989
(In reply to comment #6)
> (In reply to comment #4)
> > Well, here's the sample UA strings, plop those in your tests. :)
> > 
> > https://developer.amazon.com/sdk/fire/specifications.html#UserAgentStrings
> 
> That redirects me to another page without a user agent section...

Now apparently moved to:

http://docs.aws.amazon.com/silk/latest/developerguide/user-agent.html
(In reply to comment #4)
> Well, here's the sample UA strings, plop those in your tests. :)
> 
> https://developer.amazon.com/sdk/fire/specifications.html#UserAgentStrings

That redirects me to another page without a user agent section...
Change 72108 had a related patch set uploaded by Jforrester:
[WIP] Blacklist Amazon Silk

https://gerrit.wikimedia.org/r/72108
Well, here's the sample UA strings, plop those in your tests. :)

https://developer.amazon.com/sdk/fire/specifications.html#UserAgentStrings
(In reply to comment #2)
> I found emulator images for the 2nd-gen Kindle Fires and HDs, but they don't
> include the browser.
> 
> *headdesk*

Mostly we just want to verify that any blacklisting we put in jquery.client based on UA string actually works. :-)
I found emulator images for the 2nd-gen Kindle Fires and HDs, but they don't include the browser.

*headdesk*
Note that I've got a first-gen Kindle Fire in my collection at the office, if it needs testing. I don't have the newer generations (Android 4-based) though.
Copied from English Wikipedia:

Hovering over a displayed math formula in <math> tags is supposed to get a tooltip that explains that the formula can't be edited in the VisualEditor. It sort of works; but it has trouble with tall formulas. The tooltip doesn't show up unless the cursor is moved to the middle of the formula. For some formulas this is OK, as users can be reasonably expected to put their cursor in the middle. For other formulas it's not. [See the link for] the opening of [[Companion matrix]], which has both a formula that works and one that doesn't:

http://en.wikipedia.org/w/index.php?title=Wikipedia:VisualEditor/Feedback&oldid=562893799#Math_tags


It would be more helpful if the tooltip appeared whenever the cursor was over any pixel of the formula, not just a middle pixel. Ozob (talk) 01:21, 4 July 2013 (UTC)

--------------------------
**Version**: unspecified
**Severity**: minor
This was actually a different issue (slightly), so separating it. Still FIXED, though. :-)
*** This bug has been marked as a duplicate of bug 64625 ***
Use Firefox 20 or 21.

Place the cursor in front of a [1] ref. Note how the cursor doesn't seem to jump to another line, but instead go to end of page or toolbar.

I don't see this on Safari 6.

--------------------------
**Version**: unspecified
**Severity**: normal
**See Also**:
https://bugzilla.wikimedia.org/show_bug.cgi?id=53750
(In reply to James Forrester from comment #3)
> I believe that it's now fixed, yes. The cursor getting stuck on down is odd
> and I'll make a new bug for that.

Now in bug 64983.
I believe that it's now fixed, yes. The cursor getting stuck on down is odd and I'll make a new bug for that.
I've tested a few times, and I am not seeing a 'page down' effect now.

However using the arrow keys anywhere near references in VE cause the arrow keys to start misbehaving.

Steps to reproduce:
1. Load https://en.wikipedia.org/wiki/Jos%C3%A9_Cl%C3%A1udio_Ribeiro_da_Silva?veaction=edit which will place cursor at the beginning of the first line of text.
2. Press the right arrow until it moves past the reference at the end of the first paragraph, into the second paragraph.
3. Press up arrow

Result: The cursor disappears

Steps to reproduce:
1. Load https://en.wikipedia.org/wiki/Jos%C3%A9_Cl%C3%A1udio_Ribeiro_da_Silva?veaction=edit which will place cursor at the beginning of the first line of text.
2. Press right arrow (or use mouse) to place cursor further right on the first paragraph relative to the position of the first reference in the first paragraph.
4. Press down. (the cursor should now be directly right of of the first reference)
5. Press down.

Result: The cursor is stuck on the first reference.

(The same result can be achieved by placing the cursor in the second paragraph and pressing up)
Also occurs on Firefox 22, Windows & Linux & OSX.

Cant reproduce on Chrome.
It seems that the visual editor can glitch a bit when it initially renders a template. Yet when the template is altered without changes this is corrected. (Firefox 22, Mono skin)

'''Steps to reproduce:'''
* Navigate to https://en.wikipedia.org/w/index.php?title=User:Excirial/Playground/Content&oldid=562754871 (Historical revision of my sandbox)
* Edit the page in the Visual Editor. You will immediately notice that the template isn't correctly displayed.
* Enter the template setting screen and just select "Apply Settings".

Once that is done, the template is rendered correctly. Note that the same template was initially added trough the visual editor itself and displayed just fine. Only when you open an already saved page it seems to glitch a bit (Until the settings are applied without change - somehow that corrects it). The page reports no changes after applying, so it seems this is just a rendering issue.

--------------------------
**Version**: unspecified
**Severity**: normal
This is an artefact of VisualEditor using Parsoid to render HTML originally, but the MediaWiki PHP parser for updates. The HTML outputted by the two are normally very similar, except for images - which, until we switch the PHP parser our for Parsoid for rendering read HTML, which will involve re-writing the entire skins system, amongst other minor issues. (See http://parsoid.wmflabs.org/en/User:Excirial/Playground/Content?oldid=562754871 for the HTML returned to VisualEditor - note the use of <figure> rather than <div class="thumb"> etc.)

This is an image that's created by a template, so we're not re-drawing it; clearly in this case we should. Is this a special case for items that are 'typeof="mw:Transclusion mw:Image/Frame"', or should we be traversing the template tree for all images inside generated blocks?
In the public weekly triage on 2015-04-29, we discussed this task. We decided that this task, though important, does not block further progress against current goals around better stability and performance for users, or an improved mobile editing experience, so we rejected it for the quarter's blocking list.
I think @Krinkle should rewrite it.
@Krinkle & @Krenair: This task was skipped during the last two #editing_department_2014_15_q4_blockers triage meetings because it's tagged "[REWRITE ME]". Who would be the best person to rewrite it? It would be ideal if it could be rewritten before the next triage meeting so it's not skipped again.
I apologize for the lousy name this is starting off with - I have no idea what toc all this.

Taken from English Wikipedia:

Time for another "Why did you even try this"? kind of bug. (Tested on Firefox 22, Mono)

'''Steps to Reproduct'''
* Edit the [[bugonia]] article using the visual editor.
* Click the "Aristeas and bugonia. Virgil's Georgics. Lyon. 1517" image, which is about halfway down the article.
* There is an uneditable section a bit higher. It starts with the text "If any further evidence is necessary". Click that one.
* Now click the hyperlink button. A slight white block will appear on the image.
* Select any other word in the image and click the hyperlink button.

For some reason the hyperlink dialog box will now show up on the image, no matter what word you select. After trying a few times it seems to tire of that and starts jumping over the screen at random when a word is selected. The added screenshot is an example of this - it tried to hide behind the search box. Excirial (Contact me,Contribs) 19:37, 3 July 2013 (UTC)

Link to screenshot:
http://en.wikipedia.org/wiki/File:VisualEditor_-_Hyperlink_Dialog_glitch.png

--------------------------
**Version**: unspecified
**Severity**: normal
I believe that this is now fixed, but I'm not quite sure. Please re-open if you can give a current example.
On every page I load on IE10, when switched into compatibility mode, I currently get the following error.

oo.js, line 97 character 2
Object doesn't support property or method 'create'

Also, if VE is not enabled on IE10, then why is this code being loaded ?

--------------------------
**Version**: unspecified
**Severity**: minor
**See Also**:
https://bugzilla.wikimedia.org/show_bug.cgi?id=50612
But now fixed in production anyway. :-)
Reclassifying as not serious after feedback confirming this only happens in developer mode.
This code shouldn't be running before the browser blacklists, you're right. We need to fix this urgently to avoid so many errors for users on every page load.

To avoid confusion, note that this code works fine in "real" IE10, just not in compatibility mode; this isn't a blocker for VE working in IE.
(In reply to comment #0)
> On every page I load on IE10, when switched into compatibility mode, I
> currently get the following error.
> 
> oo.js, line 97 character 2
> Object doesn't support property or method 'create'
> 
Object.create and other ES5 features are only supported in IE10 and up, so IE10 in compat mode does not support them.

> Also, if VE is not enabled on IE10, then why is this code being loaded ?
Unfortunately, the blacklisting code is in a class, and that class extends another class, and oo.extendClass() uses Object.create() :(

We're working on fixing this by moving the blacklisting up, see bug 50612
Parse wikicode and/or HTML in interface text. This is useful to make longer descriptions, i.e. with some lists, more readable, see URL for a trial.

--------------------------
**Version**: unspecified
**Severity**: enhancement
**URL**: https://de.wikipedia.org/w/index.php?title=Vorlage:Normdaten/Doku&diff=120168256&oldid=120165159
**See Also**:
https://bugzilla.wikimedia.org/show_bug.cgi?id=49772
https://bugzilla.wikimedia.org/show_bug.cgi?id=48451
>>! In T52656#1937666, @Krenair wrote:
> Well we definitely can't allow all HTML, and we probably don't want to put everything through the full MW parser...

Even if we don't want to put everything through the full MW parser having the possibility to use internal links inside the description to link for example with help pages or external pages where the information to add in the parameter is provided.
Providing a link to the template documentation page would be useful for some complex templates like https://en.wikipedia.org/wiki/Template:Coord which is almost impossible to describe using TemplateData. This is bug T51772.
For elaborate documentation and examples, one should use the Template documentation page instead. Remember this all has to fit within the VE interface when inserting a Template. This isn't the place for elaborate instructions.

Contextual information per-parameter tends to be more appropiate. The interface currently provides a link back to the Template documentation page only if the template has no TemplateData yet:
{F3284165}

Perhaps we should provide this link always? Instead of only when data is absent.
Well we definitely can't allow all HTML, and we probably don't want to put everything through the full MW parser...
*** Bug 51311 has been marked as a duplicate of this bug. ***
Please don't mark older bugs as duplicates of newer ones.
(In reply to comment #1)
> Is this the same as Bug 51311?

I think so.

*** This bug has been marked as a duplicate of bug 51311 ***
Is this the same as Bug 51311?
What it says on the tin; if you do nothing but rearrange text, the VE does not recognise it as an alteration and refuses to let you save.

--------------------------
**Version**: unspecified
**Severity**: minor
**See Also**:
https://bugzilla.wikimedia.org/show_bug.cgi?id=49981
https://bugzilla.wikimedia.org/show_bug.cgi?id=50721
The drag-and-drop operation previously had the appearance of being successful, in that the text would change to the dropped position.  After the text was moved, the save button wasnt enabled.

Now the text can only be picked up and dragged around, but the text move operation is cancelled when the text is dropped.

The bug has been fixed, and I am closing as such.  Probably as part of another piece of related work.

For bonus points, VE shouldnt allow the text to be picked up and dragged.  I've opened that as an enhancement bug 54757.
fwiw I'm using Firefox and... it seems to work? The first post is not very descriptive so I don't know what to test. Happy to help.
*** Bug 50977 has been marked as a duplicate of this bug. ***
*** Bug 50721 has been marked as a duplicate of this bug. ***
Bug 49981 is about actually supporting this; until we do, we should disable it appearing to try to work in Firefox, only to not do so (because it's disabled).
**JohnCD67** wrote:

This only happens with drag-and-drop. VE will let you save a text rearrangement done with Ctrl-X, Ctrl-V, or Right-click/Cut, Right-click/Paste.
Some pages use anchors in the headings - useful for redirected articles.  Can VE display these and make them editable?

Original request:

I noticed that when editing (e.g.) [[ https://en.wikipedia.org/wiki/TRS-80#Compatible_successors | TRS-80 ]] that anchor templates, such as the ones I'd included within the section titles (e.g. [13])- for links that don't break when section titles change- don't show up in the visual editor... but they're still easily (inadvertantly) deletable, simply by backspacing over the hidden markup.

You couldn't blame a newbie- or even nontechnical editor- for deleting something that wasn't even shown to them(!), but this is the sort of thing that could be a major pain in the neck.

While I'm in favour of the visual editor in principle (the ability to contribute content shouldn't be reliant upon geekish markup skills), this *was* an issue that concerned me when I heard about the idea- namely that the large amounts of complicated templates and markup (which IMHO will never be entirely representable in the visual editor) would be inadvertantly messed up, either by users or by oversights within the design of a "helpful" visual editor itself.

Ubcule (talk) 22:28, 2 July 2013 (UTC)

--------------------------
**Version**: unspecified
**Severity**: enhancement
**Author:** `ryuch`

**Description:**
Korean input is not complete. 

I tried to input "한글 시험 합니다.". 
But it eats up some letters and produce "글 험 다.".

I tested with Chrome and Safari on Mac OSX. And it is all the same with Chrome on Windows XP.

**See Also**: {T52105} {T72353}
Seem to be resolved (idk which patch solved it).

It's good to see that the #1 reason I hate/blame VE is finally resolved.
Hi, typing seems to work for me in on en.wikipedia.org and on VE-standalone master, using:

- Windows 8, MS or Nalgaeset IME, Firefox 40.0.3 or Chrome 45.0.2454.99 m
- Ubuntu 15.04, Anthy IME, Firefox 40.0.3 or Chromium 44.0.2403.89 Ubuntu 15.04 (64-bit)

In particular, I'm not seeing the "first word disappears" behaviour. Can we close this bug, or is anyone still seeing corruption?
|browser|version|input|output|diff|
|----|----|----|----|----|
|IE|11.0.9600.17959|인터넷 익스플로러 테스트|인터넷 익스플로러 테스트|14721416|
|Firefox|40.0.3|파이어폭스 테스트|파이어폭스 테스트|14721436|
|Chrome|44.0.2403.157|구글 크롬 테스트|구글 크롬 테스트|14721446|

OS: Win7, 32bit. IME: MS default one.

For diff, use [[https://ko.wikipedia.org/wiki/Special:Diff|Special:Diff]].
Same here.
```
구글 크롬 윈도 7 39.0.2171.71 m
```
resulted
```
크롬 윈도 7 39.0.2171.71 m
```
It omits first word (구글).
Tested on Win7 32bit Chrome version 39.0.2171.71 m.
Same here.
```
구글 크롬 윈도 7 39.0.2171.71 m
```
resulted
```
크롬 윈도 7 39.0.2171.71 m
```
It omits first sentense.
Tested on Win7 32bit Chrome version 39.0.2171.71 m.
Helo. It seems that finally most of Korean problems are solved.
But one more problem is seen in VE.

In the Windows 7 Chrome 64bit, when Hanguls first inputed and then spaced, the first word disappears.
And this seems not results from IME.

I input it Korean nalgaeset IME:
Input : 날개셋 입력기로도 비슷한 결과가 나오는걸 보니 IME 문제는 애시당초 아니었겠습네다
Output : 입력기로도 비슷한 결과가 나오는걸 보니 IME 문제는 애시당초 아니었겠습네다

Anyway, thank you for your continuous effort.
Helo. It seems that finally most of Korean problems are solved.
But one more problem is seen in VE.

In the Windows 7 Chrome 64bit, when Hanguls first inputed and then spaced, the first word disappears.
And this seems not results from IME.

I input it Korean senaru IME:
Input : 세나루 입력기로도 비슷한 결과가 나오는걸 보니 IME 문제는 애시당초 아니었겠습네다
Output : 입력기로도 비슷한 결과가 나오는걸 보니 IME 문제는 애시당초 아니었겠습네다

Anyway, thank you for your continuous effort.
>>! In T52631#836024, @Revi wrote:
> Hmm, while reviewing [[ https://ko.wikipedia.org/w/index.php?title=특수:최근바뀜&tagfilter=visualeditor | kowiki VE tag ]] , I find most edits have no problem.

Yes, it's unclear right now which IMEs people are using and what their different impacts in VisualEditor are. It's possible that by now Korean works pretty well for the majority of users. We should follow-up with detailed automatic tests of each specific IME's functionalities so we can assess whether or not it works.
Hmm, while reviewing [[ https://ko.wikipedia.org/w/index.php?title=특수:최근바뀜&tagfilter=visualeditor | kowiki VE tag ]] , I find most edits have no problem.
I tried VE in [[en:User:Hym411/VETest]] with VE betafeatures enabled;

Input: "구글 크롬 안드로이드용 최신 버전"

Output: See the page above. - "국글 클롬 안들롱읻등용 쵯신 벚전"

I used latest release of Google Chrome for Android.

Also, comment 25 's 'backspace does not work' still happens to me.
Thanks very much for the video -- that's a great help!

I agree about the events. Actually I think it's every browser/OS/IME combination, so it's really troublesome.

As far as I can tell, there are actually two issues at the moment:

(1) Entering Korean text into an empty paragraph, and
(2) Entering Korean text into a non-empty paragraph.

Your video shows that case (1) is still broken. In order to test (2), would it be possible to try typing "hello", and then start typing Korean immediately after the "o" (i.e. without starting a new line/paragraph)?

I have done these sorts of tests, but I can't reproduce the behaviour you show in the video, presumably because of some slight difference between our test platforms.

Thanks again!
**heesub** wrote:

(In reply to comment #34)
> Would it be possible to test against current master? We believe that we have
> fixed this (or, at least, change the behaviour) since you tested it with
> cba2935 (thank you!).

I've tested the latest version and uploaded a video clip which shows what is happening on VisualEditor with Korean characters. You can find the video on this link: http://youtu.be/-Q8n4vNONm0

I am not a JavaScript or web programming expert, it seems that every browser out there has different behaviors on firing and processing compositionStart/End and keyDown events. Take a look at this document: http://joone4u.blogspot.kr/2010/07/composition-events-are-handled_27.html

After digging this issue, I found some combinations which avoid this issue:
 - Safari, Google Chrome (maybe every other browsers, but not tested) on Mac OS X. and change preference settings of Korean IME: set 'Input by' to 'Word' not 'Syllable' which is default.
 - Firefox on Ubuntu

Hope this helps!
Would it be possible to test against current master? We believe that we have fixed this (or, at least, change the behaviour) since you tested it with cba2935 (thank you!).
**heesub** wrote:

(In reply to comment #32)
> I am suffering from this issue, tested on the latest version from mediawiki's
> core.git: 217fd43. The odd thing is that it seems to work properly on Firefox
> which comes with Ubuntu 13.04 LTS distribution(, but not perfectly).

I'd tested on VisualEditor.git: cba2935 and also with patchset v16 by David Chan. Not fixed.
**heesub** wrote:

I am suffering from this issue, tested on the latest version from mediawiki's core.git: 217fd43. The odd thing is that it seems to work properly on Firefox which comes with Ubuntu 13.04 LTS distribution(, but not perfectly).

I've tried:
* IE on Windows 7 : not working
* Google Chrome on Windows 7 : not working
* Google Chrome on Ubuntu 13.04 : not working
* Safari on Mac OSX 10.8.5: not working
* Google Chrome on Mac OSX 10.8.5: not working
* Firefox on Ubuntu 13.04 : WORKING

I hope this information help you guys so that it gets fixed.
(In reply to comment #30)
> (In reply to comment #29)
> > Marking this as "FIXED" on the expectation that it's fixed - please re-open
> > if
> > you find that it is still occurring.
> 
> I am sorry. It is not fixed.  I tested on mediawiki.org.

:-(

> I open it again.

OK, we'll look at it urgently. Sorry for this.
**ryuch** wrote:

(In reply to comment #29)
> Marking this as "FIXED" on the expectation that it's fixed - please re-open
> if
> you find that it is still occurring.

I am sorry. It is not fixed.  I tested on mediawiki.org.

I open it again.
Marking this as "FIXED" on the expectation that it's fixed - please re-open if you find that it is still occurring.
There's code to address this bug in the following patch, which is due to go live by mediawiki.org on 13 September 2013:

https://gerrit.wikimedia.org/r/#/c/82858/

Please let us know whether it fixes the bug!
**ryuch** wrote:

(In reply to comment #26)
> (In reply to comment #25)
> > https://gerrit.wikimedia.org/r/#/c/79451 did not fix the problem
> 
> Just to avoid misunderstandings: How did you test this? Do you run a private
> wiki with recent VisualEditor from git master?

Not on a private one, I ran on  MediaWiki.Org, specifically on  [[mw:VisualEditor:Test]].



> 
> > I found another thing, when the cursor is after Korean letters backspace does
> > not work.
> 
> Please file separate bug reports for separate issues. Thanks! :)

I think the space problem is caused by this bug. I suppose we need to fix error  of synchronization between DM and CE.

Thank you, too.
(In reply to comment #25)
> https://gerrit.wikimedia.org/r/#/c/79451 did not fix the problem

Just to avoid misunderstandings: How did you test this? Do you run a private wiki with recent VisualEditor from git master?

> I found another thing, when the cursor is after Korean letters backspace does
> not work.

Please file separate bug reports for separate issues. Thanks! :)
**ryuch** wrote:

(In reply to comment #16)
> I believe the following patch resolves the problem on those platforms where
> there still was one: https://gerrit.wikimedia.org/r/#/c/79451 . At least, the
> patch seems to fix the Korean ibus method on Ubuntu+Chromium. However it's
> hard
> to be sure because of the problems reproducing the bug.

David,

https://gerrit.wikimedia.org/r/#/c/79451 did not fix the problem even Chrome on Ubuntu, if the code is applied to MediaWiki.org as James said.

I found another thing, when the cursor is after Korean letters backspace does not work.
(In reply to comment #22)
> We can check on en.wikipedia or ko.wikipedia, only,
> if the problem fixed.
> 
> So can you apply it on there?

The code will be applied as part of the normal MediaWiki release cycle, which you can see here: [[mw:MediaWiki_1.22/Roadmap#Schedule_for_the_deployments]].

This code is tagged against the release that happened this morning ("wmf14") - this means that the code is available now on MediaWiki.org, and will be available on all Wikipedias (including the English and Korean Wikipedias) next Thursday, 29 August, at approximately 18:00 UTC.

If you want to test and confirm the code, you can edit pages on MediaWiki.org like [[mw:VisualEditor:Test]]. Also, all code is immediately available on the "Beta labs" testing site, which can also be edited (note that it uses a different account system to production "real" Wikipedias): http://en.wikipedia.beta.wmflabs.org/wiki/VisualEditor 

Hope this helps!
Yes. All code in master is eventually deployed during our scheduled deployments. If you want to test the code ahead of the deployment you will have to check it out locally.
We can check on en.wikipedia or ko.wikipedia, only,
if the problem fixed.

So can you apply it on there?
No, it hasn't been deployed to en.wiki yet.
Sorry, but If you applied it on en.wikipedia. it yet not fixed.
Given that this is now merged, I'm going to mark this as fixed. However, this is provisional - please re-open if you think that this has not worked!
Change 80080 merged by jenkins-bot:
Don't emit Surface changes back to the Surface

https://gerrit.wikimedia.org/r/80080
Change 80080 had a related patch set uploaded by Jforrester:
WIP:Don't emit Surface changes back to the Surface

https://gerrit.wikimedia.org/r/80080
I believe the following patch resolves the problem on those platforms where there still was one: https://gerrit.wikimedia.org/r/#/c/79451 . At least, the patch seems to fix the Korean ibus method on Ubuntu+Chromium. However it's hard to be sure because of the problems reproducing the bug.
**ryuch** wrote:

==Test Cases==

글험 합니다. 다닏ㄴ합하험허시ㅅ (2013.8.14, Chrome of Windows XP)

글 험 다. (2013.8.14, Chrome of Mac OS X)

한글 시험 합니다. (2013.8.14, Chrome of Ubuntu, iBus 1.4.1)
**ryuch** wrote:

awesome. anyway.
Please make it opt-in on KOWP.

I will catch you guys at the lounge.
@Ryu not deliberately! Come to the VE lounge tomorrow (hackathon room) and speak to me and David.
It also works on Chrome for WinXP/Win7/Android(though it is not supported).
**ryuch** wrote:

You fixed this? It works.

http://en.wikipedia.org/w/index.php?title=User%3ARyuch&diff=567832037&oldid=567831839

I tested with Chrome on Ubuntu at this moment.
Now the problem seems something changed, but It is yet hard.

I input '한글 결과는 언제 나오나요'

but in the en wikipedia's visual editor @ chrome ,
it have 'ㄱㅡㄹ ㅏㄴㄴ 제 오요나나제언ㅇㅏ결겨ㄱㅡ'.

See http://en.wikipedia.org/w/index.php?title=User:Galadrien/sandbox&diff=564998163&oldid=549762292 .
**ryuch** wrote:


I think VE team is working on this issue. Did you change the code related this?
I think so.
DangSunM's report is not what I got when I made the first report.

Now I tested on Chome of iPad. It is different also.
I input '한글 시험 합니다.', same as previous.
And now I have '한글 싷험 합닏다.', like the think 
http://en.wikipedia.org/w/index.php?title=User:Ryuch&curid=284811&diff=564158229&oldid=554104287
.

It duplicates the begining consonant of a syllable to the place of ending consonant of a syllable just before it in a word when the ending consonant is null.
I also tried to write some Korean words using visual editor
" 시 각 편 집 기 테 스 트 근데 잘 안되"
but it types 
" 시 각 편 집 기 테 스 트 근데 잘 안되 되도안아잘자ㅈ데근ㄱ트스ㅋ크스ㅅ테ㅌㅍ페기집지편펴가" see http://ko.wikipedia.org/w/index.php?title=%EC%82%AC%EC%9A%A9%EC%9E%90%3A%EB%B6%84%EB%8B%B9%EC%84%A0M&diff=11132326&oldid=11087937 for details
Yes, lack of reliable IME support would be a show-stopper.
**ryuch** wrote:

This was feed backed to 
http://www.mediawiki.org/w/index.php?title=Thread:VisualEditor/Feedback/i_can%27t_type_a_east_asian_character

If you cannot resolve the problem in time, we'd better postpone the deployment on Korean Wikipedia or other Korean projects.
(In reply to comment #4)
> The latin text in iBus Korean is:
> 
> gks rmf [SPACE] tl gja [SPACE] gkq sl ek
> 
> Typing just "gksr" the following events are fired:
> 
> compositionstart
> g,k,s
> compositionend
> compositionstart
> r
> compositionend


I'm seeing slightly different behaviour on Chromium 25.0.1364.160-0ubuntu0.12.04.1 using ibus 1.4.1-3ubuntu1 and ibus-hangul 1.3.1-3build1.

If I start with an almost blank document (just the letter "A" with the cursor immediately after), then I can type "gksrmf tlgja gkqslek" and get exactly the expected characters ""한글 시험 합니다". The event sequence is as it should be (with the second compositionend only happening when I hit space).

However, if I then type the full stop, it goes *after* the cursor.
Trying to type into an empty/slug paragraph causes all sorts of whacky behaviour and should probably be filed as a separate bug

The latin text in iBus Korean is:

gks rmf [SPACE] tl gja [SPACE] gkq sl ek

Typing just "gksr" the following events are fired:

compositionstart
g,k,s
compositionend
compositionstart
r
compositionend

with the final compositionend causing the second Hangul character to end prematurely.

Need to investigate if this a browser bug related to IME's which allow continuous typing across graphemes.
This looks quite a lot like an IME issue (at least with iBus Korean).
David and I may take a look at this over a cocktail.
It also comes to Chrome on Win7.
From En:Wikipedia

"Interesting one that i just wandered across while looking at an old Articles for creation backlog drive, that causes a very interesting error popup to appear (Tested in Firefox 22)

Navigate to http://en.wikipedia.org/w/index.php?title=Baylor_University_Institute_for_Oral_History&diff=555106174&oldid=prev
Try to edit the "Mission" section in the VE.
Result: An error popup stating Error loading data from server: parsoidserver: Error contacting the Parsoid server. Would you like to retry?
This seems to be caused by the "oldid=prev" part. Normally this loads the revision prior to the Diff part of the URL, but it seems the VE cannot handle that correctly. Excirial (Contact me,Contribs) 21:25, 2 July 2013 (UTC)"


I tried this and had the same experience on Chrome.

--------------------------
**Version**: unspecified
**Severity**: normal
From David Gerard on the en.wp feedback page: if you go to add a reference and then choose not to continue and exit out of the template and save the page instead of going back, VisualEditor creates an empty closed reference tab </re>.  See here:
https://en.wikipedia.org/w/index.php?title=User:David_Gerard&diff=562600190&oldid=545746964

--------------------------
**Version**: unspecified
**Severity**: minor
**See Also**:
https://bugzilla.wikimedia.org/show_bug.cgi?id=52182
This was fixed in (I think) August; sorry for not noting it until now.
This is because we currently have the logic for a creating refernece (and potentially re-using an existing reference) and actually interacting with the content of a reference in a separate dialog. As soon as you go into the editor it inserts an empty reference and lets you edit that.

This sounds like another reason to keep those two things in the same dialog (instead of making it look like one, actually have it be one). A dialog is perfectly capable of having multiple "pages" or "states". This would save a small amount of duplication and gain a fix for this bug and the bug of the animation between the two dialogs.
(In reply to comment #1)
> Note that this doesn't happen until you hit "Create reference" inside the
> first dialogue box, so you have arguably told it to create a reference ...
> but this will confuse people, because modal dialogue boxes in applications
> usually cancel out your actions if you just keep hitting the X.

Agreed. We'll get this fixed.

> Arguably, it shouldn't create a reference if it's got nothing to put into
> the reference.

Are you telling users they're not allowed to do what they want?! ;-) I think that the number of users irritated by just silently munching references created as blank ("so I can come back to it later!") would be non-zero.
Note that this doesn't happen until you hit "Create reference" inside the first dialogue box, so you have arguably told it to create a reference ... but this will confuse people, because modal dialogue boxes in applications usually cancel out your actions if you just keep hitting the X. Arguably, it shouldn't create a reference if it's got nothing to put into the reference.
Compare the charts table in 

* http://en.wikipedia.org/wiki/2012_%28It_Ain%27t_the_End%29?oldid=561481881
* http://parsoid.wmflabs.org/en/2012_%28It_Ain%27t_the_End%29?oldid=561481881
* http://en.wikipedia.org/wiki/2012_%28It_Ain%27t_the_End%29?veaction=edit&oldid=561481881

In VE, the table cells seem to be squashed into one. The DOM looks like nested divs there, which would explain the different rendering.

--------------------------
**Version**: unspecified
**Severity**: normal
**See Also**:
https://bugzilla.wikimedia.org/show_bug.cgi?id=50951
Fixed by gerrit 140439.
*** Bug 52485 has been marked as a duplicate of this bug. ***
**Wikifram** wrote:

Note that this bug affects all 5,000 pages that use Template:Episode list on enwiki.
{{yes}}. For comparison, the Parsoid output at http://parsoid.wmflabs.org/en/Comparison_of_open-source_software_hosting_facilities looks fine.
Is this bug responsible for the {{yes}} and {{no}} templated cells not rendering as separate cells at https://en.wikipedia.org/w/index.php?title=Comparison_of_open-source_software_hosting_facilities&veaction=edit&section=1 ?
This is because the HTML looks like <td typeof="mw:Transclusion" about="#mwt139">...</td><td about="#mwt139">...</td> and so the group of table cells is considered a template, and so the CE rendering is wrapped in a <div>. I'd like to be able to render templates (and aliens) without wrapper divs in CE, but I'm not sure how realistic that is.
**Author:** `kwwilliams`

**Description:**
VE can't properly display any table using {{singlechart}} on English Wikipedia, which makes any editing of the fields pretty dicey.

Taking http://en.wikipedia.org/wiki/5_O%27Clock_%28T-Pain_song%29 as an example (it's actually one of thousands), http://en.wikipedia.org/wiki/File:Singlechart-Articleview.PNG shows what the table looks like when being displayed. http://en.wikipedia.org/wiki/File:Visual-editor-singlechart.png shows what it looks like after Visual editor has been engaged. Note that South Korea (GAON) rows and Romanian Top 100 rows are generated by manual table markup and the remainder are template calls.

This probably comes about from two factors:

1) Singlechart generates a "|" or "!" internally to start a table row, based on whether it has been called with the rowheader parameter.
2) Singlechart generates another | between the two data items it outputs to separate the fields in the table row.

--------------------------
**Version**: unspecified
**Severity**: normal
**See Also**:
https://bugzilla.wikimedia.org/show_bug.cgi?id=50366
https://bugzilla.wikimedia.org/show_bug.cgi?id=44498
https://bugzilla.wikimedia.org/show_bug.cgi?id=50951
https://bugzilla.wikimedia.org/show_bug.cgi?id=52296
Fixed by https://gerrit.wikimedia.org/r/#/c/79430/, which is now deployed. Chart tables such as the one on http://en.wikipedia.org/wiki/2012_%28It_Ain%27t_the_End%29?veaction=edit now render and round-trip as expected.

The unrelated table rendering issue in http://en.wikipedia.org/wiki/2012_%28It_Ain%27t_the_End%29?veaction=edit is VisualEditor bug 50607.
This seems to be related to bug 44498.
Not sure if I should open a new or make a comment here... But is this wrong rendering (too much td nodes) the result of this bug?
http://parsoid.wmflabs.org/sr/%D0%93%D0%BB%D0%B0%D0%B2%D0%BD%D0%B0_%D1%81%D1%82%D1%80%D0%B0%D0%BD%D0%B0
(In reply to comment #10)
> Oh wow, on some more investigation it looks like we are actually rendering
> the table just fine:
> 
> http://parsoid.wmflabs.org/en/2012_%28It_Ain%27t_the_End%29
> 
> So the odd rendering seems to be a VE issue.

Should this bug be recategorized then?
[Parsoid component reorg by merging JS/General and General. See bug 50685 for more information. Filter bugmail on this comment. parsoidreorg20130704]
Oh wow, on some more investigation it looks like we are actually rendering the table just fine:

http://parsoid.wmflabs.org/en/2012_%28It_Ain%27t_the_End%29

So the odd rendering seems to be a VE issue.
> You really need to be parsing *after* template expansion and tracking all the
> text that the templates generate.

We are tokenizing templates and content separately so that we can cut template vs. non-template content on a token level. Attribute keys and values can also be templated, but we don't support templates producing several attributes and parts of a token.

This and the need to infer resulting DOM structures affected by template-produced tokens already adds a lot of complexity, but at least the results can somewhat sanely be represented in DOM. Having 1/3 of a DOM element's start tag be generated by page source and 2/3 templated on some arbitrary boundary would be a nightmare to represent in DOM and even worse in a UI.

You are right though that we *could* in theory represent something like |{{singlechart|..}} as a special case of a multi-part templated construct. This would run counter to our desire to move towards self-contained templates though that are easier to edit both in wikitext and the VE. Removing the pipes in the page and returning the full table row from singlechart would be better in that regard.

> Removing the pipe doesn't quite work, though: take a peek at
> http://en.wikipedia.org/wiki/2012_%28It_Ain%27t_the_End%29?veaction=edit vs.
> http://en.wikipedia.org/wiki/2012_%28It_Ain%27t_the_End%29 and notice how the
> manual entries and the templated entries align in the normal view but
> scramble
> in the edit view.

Indeed, it seems that we don't recognize single-line rows that don't start with ||. As a workaround, it should be possible to emit '||' from the template instead. I'll file a bug for our table row tokenization bug.
**kwwilliams** wrote:

As a help: there are only a few dozen templates that do things like this. I would have no problem at all adding something in the TemplateData that gave VE a clue as to what was going on, like

 "table":
  {
    "cells": 2,
    "rowheader": "true",
  }
**kwwilliams** wrote:

Hadn't noticed the leading | character. That is wrong, albeit harmless in most cases (if someone set rowheader=true, it would be a visible error). I removed all of those in a bot run before, and it looks like it's time to do it again.

Removing the pipe doesn't quite work, though: take a peek at http://en.wikipedia.org/wiki/2012_%28It_Ain%27t_the_End%29?veaction=edit vs. http://en.wikipedia.org/wiki/2012_%28It_Ain%27t_the_End%29 and notice how the manual entries and the templated entries align in the normal view but scramble in the edit view.

You really need to be parsing *after* template expansion and tracking all the text that the templates generate. That template should display as the chart and reference in the first column followed by a position in the second column, because that's what the wikitext the template generates says to do. Once the editor tries to edit any of those fields, the editor should be taken to the template editor. Displaying the output as a doublespaced item without any table boundaries that doesn't align with other entries is not the right answer to this problem.
and Parsoid. ;)
An example from  http://en.wikipedia.org/wiki/5_O%27Clock_%28T-Pain_song%29:

|{{singlechart|Australia|29|artist=T-Pain feat. Wiz Khalifa & Lily Allen|song=5 O'Clock}}

The issue here is that there is a pipe in the page source while another pipe is emitted by Singlechart. If the pipe in the page source is removed this will work in both the PHP parser and .
My apologies for assuming that these two issues were related. Re-titling.
**kwwilliams** wrote:

"This can be fixed by avoiding 2"? How exactly is the template supposed to generate a row header and two table cells while "avoiding 2)"?
The problem here is 2), the extra | generated by Singlechart. The PHP parser flattens everything to a string, so it will eventually see '\n||' with one of those pipes generated by 2) and the other from 1). Parsoid on the other hand needs to keep track of where things came from, so sees those pipes as two td tags.

This can be fixed by avoiding 2).
This is the same as bug 50366 - merging with that one.

*** This bug has been marked as a duplicate of bug 50366 ***
As per http://en.wikipedia.org/wiki/Wikipedia:VisualEditor/Feedback#Coords_not_displayed_in_title_when_open_in_VE , the coordinates move at the bottom of the page, where one is not expecting to find them.

--------------------------
**Version**: unspecified
**Severity**: major
Indeed we did, this was done by the invaluable Ed in ee5b69772963c5d3f17b15742023cf33fc5dd48a.
Dunno what happened here, but all three of the subtasks seem to no longer be a problem. Did we kill this?
CSS content munging in general is a real pain, and we should find a way around it.
VisualEditor needs to preserve adjacent (even if identical) and additive elements that it internally treats as annotations. Right now it often removes nested annotations (bug 49755) or merges adjacent annotations (bug 49873, http://en.wikipedia.org/w/index.php?title=Bose%E2%80%93Einstein_condensate&diff=prev&oldid=562481552).

Both will lead to a DOM diff and thus likely to a dirty wikitext diff.

Note that this only applies to existing content- merging identical annotations in new content is fine.

--------------------------
**Version**: unspecified
**Severity**: normal
This has been fixed for some time in the DM. Marking as such.
Also, don't cut annotations. This is what I suspect happened here:
http://en.wikipedia.org/w/index.php?title=List_of_Mystery_Science_Theater_3000_episodes&diff=prev&oldid=562488147
See https://en.wikipedia.org/w/index.php?title=Russkaya_Mysl&curid=38914039&diff=562427330&oldid=555891306

--------------------------
**Version**: unspecified
**Severity**: major
**See Also**:
https://bugzilla.wikimedia.org/show_bug.cgi?id=50720
*** This bug has been marked as a duplicate of bug 50720 ***
Still getting this occurring. Examples


https://en.wikipedia.org/w/index.php?title=Austropotamobius_pallipes&curid=3945333&diff=562783871&oldid=545518009
https://en.wikipedia.org/w/index.php?title=Ron_Davies_(songwriter)&curid=31118393&diff=562723238&oldid=553701771
https://en.wikipedia.org/w/index.php?title=Sibling_relationship&curid=22409572&diff=562636237&oldid=561958868
https://en.wikipedia.org/w/index.php?title=Double_Rainbow_(viral_video)&curid=28129724&diff=562626607&oldid=560477885
https://en.wikipedia.org/w/index.php?title=Roger_Mompesson&curid=39389398&diff=562625481&oldid=560045122
(also changed a category link)
The visualeditor-needcheck tag also suggests that there was an issue in VE round-tripping. Reassigning to VE for investigation.
Roan has not been able to reproduce this with VE, and parsoid.wmflabs.org/_rt/en/Russkaya_Mysl?oldid=555891306 does not show this issue either.

Maybe bug 50428 is related?
English Wikipedia editor notes that sometimes when parent templates are removed, a subtemplate (or two) should remain, such as with Template:Multiple issues (http://en.wikipedia.org/wiki/Template:Multiple_issues). It would be a nice feature to allow the parent cat to be removed without removing all parameter, or permitting them to be "escalated" into templates themselves.

Realizing this is not likely to be a high priority, given more urgent issues, just putting in the request. :)

See
http://en.wikipedia.org/w/index.php?title=Wikipedia:VisualEditor/Feedback&oldid=562454889#Can.27t_unwrap_template_within_template

--------------------------
**Version**: unspecified
**Severity**: enhancement
We need an integration and plugin system for VisualEditor, both for extra tools (e.g. "YouTube video node handler") and tool over-rides (e.g. "MediaWiki-specific H3 handler"), as well as a more generalised system to do init and integration.

Enjoy.

--------------------------
**Version**: unspecified
**Severity**: enhancement
At this point, closing this bug is blocked on some reasonable documentation being available. Third parties that want to try to implement things and report what's missing functionality (or more likely, unclear because there's no documentation) would be very welcome. :-)
Change 75271 merged by jenkins-bot:
Infrastructure for loading plugins in the MW integration

https://gerrit.wikimedia.org/r/75271
Change 75271 had a related patch set uploaded by Catrope:
Infrastructure for loading plugins in the MW integration

https://gerrit.wikimedia.org/r/75271
Screenshot

See screenshot - monobook, windows 7, firefox 22.

--------------------------
**Version**: unspecified
**Severity**: normal

**Attached**: {F11469}
I'm going to close this as a one-off appearance of HiDPI icons for a user - if it's repeated, please re-open.
>>! In T52505#562403, @GWicke wrote:
> We have a relatively complete DOM-based references rendering implementation in Parsoid that could be reused by VisualEditor. This would avoid us implementing two versions of essentially the same code, and with combined effort should result in a better implementation.

--------------------------

**See Also**:
{T52474}
Indeed, basically the logic we currently have (or call from) ve.ce.MWReferenceListNode and ve.ce.MWReferenceNode. Converting data-mw into a the dom as it should be given to the browser (html tag name, class name, children composition and attributes etc.). And for ref nodes the sequence between different ones as well. Though VE may have to run the logic more often (where parsoid presumably only runs it once per document) it'd be nice to share this logic.

The HTML rendered by MediaWiki extension tags and/or parser functions should not be hardcoded in VE. Perhaps in a VE plugin, but since it'd be the same for Parsoid as for VE, it'd be nice if this can be shared so that a MediaWiki extension that wants to have logic for Parsoid/VE only needs 1 type of plugin that both can use.
I would not recommend to hack something around the numbering we give you. We should rather share the ref / references rendering code so that you can simply call that code to fully renumber refs and re-render the references blocks.
Parsoid gives us a DOM with references already numbered, so we probably want to use their numbering and reference list as a base, then update that as required.
Possibly also relevant for bug 50474, in case that turns out to be hard to fix in your current implementation.
Sorry, somehow managed to hit return.

We have a relatively complete DOM-based references rendering implementation in Parsoid that could be reused by VisualEditor. This would avoid us implementing two versions of essentially the same code, and with combined effort should result in a better implementation.
A very simple mockup that I made in GIMP to show how it is supposed to look

VisualEditor: Link inspector is not oriented for RTL.

The arrow icon is supposed to point to the right, and be placed in the right corner, separated by a vertical line.

The title is supposed to be aligned to the right.

The chain icon is supposed to be next to the title on its left side.

The trash bin is supposed to be in the left corner.

See the attached file for a very simple mock-up of how it is supposed to look (it is off by a few pixels here and there - I'm not much of a graphic designer).

This bug is similar to bug 49613.

--------------------------
**Version**: unspecified
**Severity**: normal

//attachment link-inspector-rtl.png ignored as obsolete//
The current layout is good. There's a mistake in my image. Marking as FIXED.
En layout is currently:

< (chain icon) 'Hyperlink'    (trash icon)

He layout is currently:

(trash icon)     '(Hyperlink in Hebrew)' (chain icon) >

This is not quite Amir's design attached:

(trash icon)     (chain icon) '(Hyperlink in Hebrew)' >
Change 72056 abandoned by Mooeypoo:
Layout fix for Link Surface in RTL

Reason:
This was fixed in another (much more massive) gerrit fix that was merged. Works in master.

https://gerrit.wikimedia.org/r/72056
Change 72056 had a related patch set uploaded by Mooeypoo:
Layout fix for Link Surface in RTL

https://gerrit.wikimedia.org/r/72056
This depends on the Frame rtl fix, which will add directionality inside frames, and allow for conditional flips (and/or also allow CSSJanus to eventually work inside the frames)

I took a look at the code, the flip itself is relatively easy, but I am missing the ve-rtl/ve-ltr classes that would be there after the frame fix.
Created attachment 12713
A simple mockup that I made in GIMP to show how it is supposed to look

The V icon in the menu is supposed to be moved to the right side, too.

Updated screenshot.

**Attached**: {F11431}
https://en.wikipedia.org/w/index.php?title=Bah%C3%A1%27u%27ll%C3%A1h&diff=562302216&oldid=561967071 - finding out browser/OS now.

--------------------------
**Version**: unspecified
**Severity**: normal
Do we know how this was caused, how to reproduce the issue, if VE was even responsible for it (rather than Parsoid), or if it's since been fixed?
It's Windows 7, Firefox 21.0; I attempted to make a similar edit to the article using Chrome and received a message that said, "Warning: Your edit may have been corrupted – please review before saving." I've asked at http://en.wikipedia.org/wiki/Wikipedia:VisualEditor/Feedback#Addition_of_.3Cu.3E.3C.2Fu.3E.3Cu.3E.3C.2Fu.3E_and_removal_of_categories. if he sees it, too.
Trying to "Edit" on http://en.wikipedia.org/wiki/List_of_Advanced_Dungeons_%26_Dragons_2nd_edition_monsters after a minute or so results in a popup "Error loading data from server: error. Would you like to retry?". Trying again, repeats the issue

--------------------------
**Version**: unspecified
**Severity**: enhancement
**See Also**:
https://bugzilla.wikimedia.org/show_bug.cgi?id=39057
Change 118398 merged by jenkins-bot:
More gracefully handle situations where Parsoid returns a timeout failure code (HTTP 504)

https://gerrit.wikimedia.org/r/118398
Change 118398 had a related patch set uploaded by Alex Monk:
More gracefully handle situations where Parsoid returns a timeout failure code (HTTP 504)

https://gerrit.wikimedia.org/r/118398
(In reply to James Forrester from comment #4)
> Possibily we could, instead of giving the user the error code, we could have
> a pop-up saying "It looks like editor is currently unavailable; would you
> like to edit in source mode instead?" with an OK that takes you to
> action=edit and a cancel that returns you to action=view? Maybe for
> error-tracking purposes we could add <small>Parsoid returned 504</small> or
> <small>Parsoid not available</small> after the general call-to-action?

Basically done this after checking with Roan about how to reproduce this error, without the small text underneath. Confirm dialogs don't allow you to use HTML markup.
We'll help. :-)
(resetting assignee - I had issues trying to properly reproduce Parsoid timeouts like this on my machine)
I'm pulling this from being a blocker to bug 50848, given the reduced impact now that it works on the second try.
VE currently sets a 100s timeout, but in practice we often don't get there because the nginx proxies that terminate HTTPS and IPv6 traffic have a 60s timeout.
(In reply to comment #5)
> Previewing that page also works in about 30 seconds.

Actually closer to 70 on re-test.
After upping the Varnish backend timeout to 5 minutes http://en.wikipedia.org/wiki/List_of_Advanced_Dungeons_%26_Dragons_2nd_edition_monsters?veaction=edit works now despite timing out in VE once. Hitting 'retry' re-joins the ongoing render, and returns the page pretty quickly. Previewing that page also works in about 30 seconds.

You might want to tweak your timeouts / UI to reflect this change. As long as there is no timout from Varnish the render is still ongoing.

More testing is needed with even larger pages. Bug 51053 will be closed when that is done.
Possibily we could, instead of giving the user the error code, we could have a pop-up saying "It looks like editor is currently unavailable; would you like to edit in source mode instead?" with an OK that takes you to action=edit and a cancel that returns you to action=view? Maybe for error-tracking purposes we could add <small>Parsoid returned 504</small> or <small>Parsoid not available</small> after the general call-to-action?
Looks like the timeout here is on the Varnish/Parsoid side (API request on edit fails with error 504 after 60 secs).
Re: timeouts, need to be either handled more gracefully or we'll need to VE-blacklist articles where it occurs for now.
I think this is probably related - editing on large pages such as California is considerably slower when using VE than it is using the old editor. A contributor complained of slowness with this edit (http://en.wikipedia.org/w/index.php?title=California&diff=562339624&oldid=562339237) and I found the same issue with mine (http://en.wikipedia.org/w/index.php?title=California&diff=562390635&oldid=562351322)
References added by templates are currently not very well integrated into the #visualeditor UI. Their footnotes are visible as #parsoid parsed output on the surface, but:

1. the number in square brackets on the footnote does not necessarily fit with other numbers visible from other footnotes
2. they do not appear in the reference lists in the editor
3. they do not appear in the list of references to re-use

A simple demonstration of the first two issues can be seen here:

| Reading | VisualEditor |
| {F56437741} | {F56437750} |

-----------------------------------

For example, look at [[https://en.wikipedia.org/w/index.php?title=Popocatépetl&oldid=667057679|this old version of w:en:Popocatépetl]]. It has 21 references, 3 of them in the infobox only. When you [[https://en.wikipedia.org/w/index.php?title=Popocat%C3%A9petl&oldid=667057679&veaction=edit|open it in VE]], those first 3 cannot be accessed from the re-use menu. In addition, all 21 appear in the references list, but each reference x in the text corresponds to entry x + 3 in the references list. 

**See Also**:
{T52505}
{T53289}
{T54398}
{T55777}
{T54262}

Possible duplicate but might have additional implications: 
{T87134}
>>! In T52474#1772377, @Halibutt wrote:
> Since T114105 was merged into this ticket

In case anyone following that original ticket (or several like it) is confused about why these get merged here: 

VisualEditor handles regular "Harvard" (parenthetical) citations perfectly; see true Harvard style at https://en.wikipedia.org/w/index.php?oldid=521737742&veaction=edit as an example.   Plain Harvard is just plain text, after all; a proper Harvard citation is just `(Author Date)` with an optional page number.  Any system that lets you type common characters can handle plain Harvard citations.

The problem is when it's not truly Harvard citations, but instead it's a non-Harvard [[https://en.wikipedia.org/wiki/Wikipedia:Citing_sources#Short_citations|short citation]] wrapped up in ref tags using a template such as {{sfn}} – when the system is presented with `{{sfn|Author|Date|123}}` instead of  `<ref name="Author Date">Author Date, page 123.</ref>` (which VisualEditor can handle) or `(Author Date, page 123)` (which VisualEditor can also handle). 

In that case, the main technical issue is exactly the same as `{{infobox|field=data<ref>Source</ref>}}`:  the ref is stuck in a transclusion rather than in the article being edited.  This has multiple effects, including impossible numbering and bad displays (because the transcluded doc gets its own <references /> list; see T114105 for a screenshot).  As I understand it, some of these problems will be solved here, and others may be fixed through other mechanisms, e.g., {T110909}.  But the bugs get merged here, because it's not possible to merge them to multiple related tasks.
Since T114105 was merged into this ticket, is there anything I could do to help solve this issue?
Just a friendly reminder, that while T114105 was merged into this ticket, it has nothing to do with it. Nothing to do with ref numbering or with ref accessibility from the re-use menu. Actually, it's more about how VE displays templates as such, not how it handles references. See the attached screenshot to see what I'm talking about.

But since it was merged here, is there anything I could do to help solve this issue?
Just a friendly reminder, that while T114105 was merged into this ticket, it has nothing to do with it. Nothing to do with ref numbering or with ref accessibility from the re-use menu. Actually, it's more about how VE displays templates as such, not how it handles references. 

But since it was merged here, is there anything I could do to help solve this issue?
This information is already shown in context and the reference list. If we change the numbering that will probably be more confusing.
As a stop-gap measure, is it feasible to have the footnotes that are contained in templates (and therefore not "in" the document) be displayed differently?  You would get the usual [1] for whatever is the first footnote in the article body, but the first one in an infobox would be marked as [X] or [Template 1] or something that doesn't match the typical ones.
In the weekly triage meeting on 2015-05-06, we discussed this task. Though we acknowledge that this is moderately confusing for users, fixing this is a very large piece of work (which reflects why it has not been completed in the past two years either). I've marked this as blocked by a piece of work that we hope to finish out this quarter, which will hopefully help make this slightly less epic to fix.
See [[https://en.wikipedia.org/wiki/Wikipedia:VisualEditor/Feedback#Citation_numbers_messing_up | en-Wiki feedback "Citation numbers messing up"]]. This problem is repeatedly mentioned on en-Wiki, confuses editors and hinders editing of developed articles with complex reference structures. I would like to propose the whole issue with "references in templates" and "references generated by templates" as blocker. I am aware, that 5 other tasks are possible related to this problem (See also), maybe the whole topic area needs another fresh look for a solution. - the problem is known for almost 2 years now, and should get a higher priority and more frequent updates on its status.
It doesn't seem to have been mentioned above that this bug can cause the loss of a citation, which might affect the severity or priority.  If you have a ref inside a group note (e.g. inside a tag) and delete all other copies of the ref, including the base copy, VE is unable to transfer the base text to the copy of the ref in the tag, so the citation is lost.
Notes for testing the future fix: 

- The references placed in the Infobox template should be numbered correctly along with the other page references
- There should be no discrepancy in displaying reference numbering in Read mode or VE mode
- also, check reference for class="toccolours" - the warning msg should be displayed: "This reference is defined in a template or other generated block, and for now can only be edited in source mode."
*** Bug 69373 has been marked as a duplicate of this bug. ***
*** Bug 52742 has been marked as a duplicate of this bug. ***
*** Bug 63210 has been marked as a duplicate of this bug. ***
*** Bug 51058 has been marked as a duplicate of this bug. ***
*** Bug 53777 has been marked as a duplicate of this bug. ***
**kwwilliams** wrote:

(In reply to comment #25)
> (In reply to comment #23)
> > There's no way to code a single template that generates both a reference and
> > table markup without using {{#tag:ref}}. 
> 
> True. This should have given you pause to consider /why/ it wasn't available
> until recently. :-)

Laughing while you dismiss my comments adds a layer of rudeness to the discussion that is completely unnecessary.
*** Bug 53486 has been marked as a duplicate of this bug. ***
(In reply to comment #23)
> There's no way to code a single template that generates both a reference and
> table markup without using {{#tag:ref}}. 

True. This should have given you pause to consider /why/ it wasn't available until recently. :-)

> If you didn't think "any reference created by a template shouldn't work,
> deliberately" would be read as a refusal to fix that particular aspect of
> this bug, I have no idea what you intended it to mean.

Translation: When we made MW's citation system, the intent right from the start was to never, ever let people create nested references, or references that need to be parsed multiple times, because it creates endless issues.

Unfortunately, when later the {{#tag:xxx}} system was created, the person implementing that didn't remember this issue and instead has indeed given rise to all manner of epic problems.

> I also don't see that this bugzilla specifically addresses the ability for
> the names and contents of template generated references to be available to an
> editor that is using the "add reference" dialog.

That would be the "don't show up as references to insert" part of the title. :-)
We might actually be able to use the same CSS technique I developed for auto-numbered external links in bug 53505 for citations. That would at least fix the numbering without extra effort, but won't help with <references> rendering and editing.
**kwwilliams** wrote:

There's no way to code a single template that generates both a reference and table markup without using {{#tag:ref}}. 

If you didn't think "any reference created by a template shouldn't work, deliberately" would be read as a refusal to fix that particular aspect of this bug, I have no idea what you intended it to mean.

I also don't see that this bugzilla specifically addresses the ability for the names and contents of template generated references to be available to an editor that is using the "add reference" dialog.
(In reply to comment #21)
> Describing a widely used template as a "hack" and refusing to fix the bugs
> associated with VE in terms of editing it is not a valid solution.

Who said I was refusing to fix it?

> The template does work and the references work fine using the normal editor.
> There's no way to code the template to not include the #ref.

<ref>{{foo}}</ref> works just fine, because that's how it was designed to be used. If you want an easier way to edit, use VE. ;-)

> It is not within the scope of the VE project to refuse to fix problems
> because they are hard.

This is off-topic, but actually, it is very much part of Wikimedia's job to make decisions about whether it is worth spending large amounts of donor funds on marginal use cases rather than features that can't be done in other ways.

> I strongly, strongly object to the implication in the addition to 52478 that
> implies that this bug in VE will never be fixed.

There is no such implication; there is clearly the inference in your reading of it, however. We will fix this bug - the comment just explains the priority of this bug in relation to others.
**kwwilliams** wrote:

Describing a widely used template as a "hack" and refusing to fix the bugs associated with VE in terms of editing it is not a valid solution. The template does work and the references work fine using the normal editor. There's no way to code the template to not include the #ref.

It is not within the scope of the VE project to refuse to fix problems because they are hard.

I strongly, strongly object to the implication in the addition to 52478 that implies that this bug in VE will never be fixed.
*** Bug 52478 has been marked as a duplicate of this bug. ***
Resolving Bug 28980 could relieve at least part of this problem by lifting the need to use <ref> because of localization issues.
*** Bug 52083 has been marked as a duplicate of this bug. ***
The ref duplication issue (last bullet point) was actually a Parsoid bug which is fixed with the commit above. It only manifested itself in templated references sections which are not rendered by VE. The fix is deployed to production.

The other VE issues remain, but fortunately are less visible to users unless they modify references.
Change 71528 merged by jenkins-bot:
Bug 50474: Remove children of references node

https://gerrit.wikimedia.org/r/71528
Change 71528 had a related patch set uploaded by GWicke:
WIP Bug 50474: Remove children of references node

https://gerrit.wikimedia.org/r/71528
I think so far we have seen several issues in this area:

* References from templated content are not being picked up by VE, which causes

** the numbering to be off

** those references to be missing in references

** edits to refs whose primary (first in DOM order) definition is templated just update the first non-templated ref alias in the page. Those changes are then not rendered in the PHP parser. Correct behavior would be to explain why that reference cannot be edited.

* Some refs are duplicated in the references section
Parsoid provides ref info also inside template-generated content, and our ref / references rendering code make use of that. I have proposed to share that code in bug 50505. 

Using the Parsoid rendering on first load could be a workaround, but hacking dynamic updates into that sounds like more trouble than it's worth.
This also prohibits references utilised in templates from being used elsewhere on the page via the template inspector. Blah :/.
(In reply to comment #9)
> IIRC the VE renders (and numbers) references natively without using our
> rendering at all. Which would make this a VE bug. Trying to confirm.
That's correct. VE does not see the first two references because they are in a template, and so it mistakenly believes the one in "Early years" is the first one.

We could mitigate this by using the numbering Parsoid gives us.
Moved to VE, as the numbering seems to be re-done in VE.
IIRC the VE renders (and numbers) references natively without using our rendering at all. Which would make this a VE bug. Trying to confirm.
It seems that this bug doesn't cause any wikitext corruption, but only affects display in VE.  Still something we should fix on the Parsoid end, but not as troublesome as I initially thought this was.
Looks like the ref-counter has been reset after the 2nd ref-tag was processed and also, 13 references are duplicated (the first 2 are not duplicated).

The bug cannot be duplicated locally.  So, I suspect something is off when refs are being reused from Varnish caches.
Indeed. In my defence it's 10pm on a Sunday :/
Ah, I see the new screenshot. You wanted to write "Early years"?
Yes, there are references with the same name, split into multiple entries but I don't understand how the screenshots you attached should demonstrate that.
How it actually looks

**Attached**: {F11401}
How it actually looks

//attachment Screen Shot 2013-06-30 at 12.24.02 PM.png ignored as obsolete//
How it should look

**Attached**: {F11400}
https://en.wikipedia.org/w/index.php?title=Edamattom&diff=562268939&oldid=562266260 <- this was from an attempt to swap a references section and an external links section. We cannot have this scale corruption on launch. I'd be most grateful if someone could find out what the heck happened, and also confirm with some degree of certainty that it won't happen again.

--------------------------
**Version**: unspecified
**Severity**: major
**See Also**:
https://bugzilla.wikimedia.org/show_bug.cgi?id=51677
I think this has been fixed for a while. Re-open if you can reproduce it.
I can reproduce it.  With a lot of the pawn bugs fixed now, maybe it has disappeared.
Oh, meant to add that the loop may well have been infinite but I tried to force the save (with ultimate success).
Given the severity, I'll try to recreate what I was doing but it was basically an attempt to cut the existing External Links section and paste it after the References. As I had made other changes, I can't rule out the idea that I could have stopped editing at the first sight of white pawns; certainly, I saw a couple just before the main "whumpfh" of the loop kicking in, but the loop might have already started by then.

Browser: Chrome latest (27.0.1453.116) running on Windows 7. Plenty of RAM (before the loop, anyway :P).
When a notice is shown (on beta), it's not possible for the user to mark the text and copy.

--------------------------
**Version**: unspecified
**Severity**: enhancement
This was fixed as part of the toolbar fixes last week.
Text selection of the toolbar and descendants of it was intentionally disabled for design and user experience reasons.

I can understand that it may be useful to re-enable it for the edit notice part of the toolbar though.
When adding/modifying a template, you can append a space to the parameter, and even if you have that parameter already used, you can add one more. As well you can add a (multiple) empty " " parameter.

Example template I made ended up as:

{{test|name = "







|logo = '
"| = |  = |logo = }}

--------------------------
**Version**: unspecified
**Severity**: normal
**See Also**:
https://bugzilla.wikimedia.org/show_bug.cgi?id=61049
This appears to be fixed now. You can't create both "foo" and "foo " any more.
Clarification: the transclusion dialog allows the user to create both "foo" and "foo " as separate parameters, but it shouldn't. It also allows the user to create the empty parameter (" ") multiple times.
This is a bug/design issuse with TemplateData.

To use TemplateData in RTL wikis, the syntax mix English and Arabic/Hebrew (etc).

Editing mixed languages with different direction is hard and should be avoided as much as possible because of BiDi issues. (in some cases, such as Lua modules it isn't possible to completely avoid it).

Example :
<templatedata>
{
        "description": "תבנית כלשהי.",
        "params": {
                "שם": {
                        "label": "שם",
                        "type": "string/wiki-user-name",
                        "required": true,
                        "description": "שם של משתמש",
                        "aliases": ["1"]
                }
        },
        "sets": [
                {
                        "label": "Date",
                        "params": ["שנה", "חודש", "יום"]
                }
        ]
}
</templatedata>
It is very hard to edit such syntax as above. (<templatedata> is OK since it is in different line - but the JSON isn't [if we don't want to define special indentation convention due to direction issues])
The syntax for the JSON keywords (description, params, label etc) should be either translatable or should have some neutral direction alternative to defines it (JSON by itself is directionless - [{}:,] doesn't have direction information).

See also:
* bug 50169 - implementing this feature may reduce the severity of this bug (this solution will force template editors in RTL wiki to use visual editor at least for templatedata definitions).
* bug 50370 - translation of interface items

--------------------------
**Version**: unspecified
**Severity**: normal
**See Also**:
https://bugzilla.wikimedia.org/show_bug.cgi?id=50370
This is now effectively "solved" through general availability of the GUI to edit TemplateData.
Would be nice to deploy it the template data editor to Hebrew Wikipedia  - it is more important then in other wikis because of this bug
(In reply to comment #15)
> How about marking it as a duplicate of bug 51734?

I don't think it's really a duplicate, though; the problem remains (so if you want to edit the source directly you still have to deal with it).

(In reply to comment #16)
> Thanks Moriel for implementing a nice workaround to this bug.
> I think this bug can be disposed after template editor will be deployed to
> all wikis.

That seems like a reasonable resolution. Will do.
Thanks Moriel for implementing a nice workaround to this bug.
I think this bug can be disposed after template editor will be deployed to all wikis.
How about marking it as a duplicate of bug 51734?
So… I'm not sure how to dispose of this bug:

* FIXED – except it's not fixed, it's just "worked around" by bug 51734
* INVALID – except it's still a valid concern
* WORKSFORME – but only because I'm willing to put up with this (and I don't do RTL much)
* WONTFIX – closest to the truth, but feels a little blunt

Perhaps we should wait for the template editor to be deployed for all languages, then close this as WONTFIX?
Change 85400 merged by jenkins-bot:
Implement edit interface for TemplateData documentation

https://gerrit.wikimedia.org/r/85400
Change 85400 had a related patch set uploaded by Mooeypoo:
TemplateData Generator GUI

https://gerrit.wikimedia.org/r/85400
(In reply to comment #10)
> Michal tool seems interesting but it currently lacks the ability to edit an
> existing templatedata. Michal, is that something you're planning to add?

Absolutely! Working on that now. At first you'll have to copy JSON data to the tool, but I'll try to add auto copying from a given template.
Ltrlg's script can edit an existing templatedata. I don't know if it works correctly with rtl languages, but if it doesn't you could always ask Ltrlg to fix it.

Michal tool seems interesting but it currently lacks the ability to edit an existing templatedata. Michal, is that something you're planning to add?
I forgot to attach the link... here it is:

https://github.com/mooeypoo/MediaWiki-TemplateDataGenerator

It's still being tested, and there are a couple of changes we should still implement, but it's getting there. I hope it will be ready for wider test in the next few days.
I'm working on a TemplateData Generator extension that will allow the editing or creation from scratch of templatedata json. It will allow the editing of the json data visually, so you could maintain the parameters or description as you please with a GUI.

I'm also making sure it works with RTL languages and the GUI is completely translation-ready. I hope it will be ready in the next few days (at least a basic working version of it)
Is it possible to edit templatedata or just create new? Is it possible to populate the form with existing tempaltedata?

The main problem isn't creation of tempaltedata (which for many cases can be done by bots), but to maintain it - e.g changing the description, adding/removing parameters etc.
I've addded rtl support to my editor (http://tools.wikimedia.pl/~mlazowik/templatedata/). You can send me translations. More info in the bottom of the page.
A user interface exists also as a script on enwiki (which can be used directly from other wikis)
http://en.wikipedia.org/wiki/User:NicoV/TemplateDataEditor

It was written by Ltrlg (see 2 posts above) on frwiki, I translated it into English.
(In reply to comment #2)
> The ideal thing here would be to build a tree-like visual TemplateData
> editor,
> that would save its data to JSON. Kinda like http://www.jsoneditoronline.org/
> (first Google result for "json editor").

It kinda exists now, http://tools.wikimedia.pl/~mlazowik/templatedata/, but is currently not translateable (only in Polish). The code is on GitHub (https://github.com/mlazowik/templatedata/) and author accepts pull requests :) (CC'ing him).
See bug 51734 (Create a non-VisualEditor plugin tool to add/edit template hinting) for visual interface.
The ideal thing here would be to build a tree-like visual TemplateData editor, that would save its data to JSON. Kinda like http://www.jsoneditoronline.org/ (first Google result for "json editor").

Separating labels and data would easily solve the RTL problem, and would also make TemplateData easier to edit for users in all languages.
Timo, thoughts?
I did not add this to closed bug 50012 because while it may be related it's not exactly the same.

This edit to the text of the article added extraneous pipes throughout (http://en.wikipedia.org/w/index.php?title=List_of_male_kickboxers&diff=562103247&oldid=561869162) and also dropped some formatting on the end (|}|}|}|}|}|})

See http://en.wikipedia.org/wiki/Wikipedia:VisualEditor/Feedback#Unwanted_format_changes_throughout_article

--------------------------
**Version**: unspecified
**Severity**: normal
Change 71744 merged by jenkins-bot:
(Bug 50420) Recognize sol-content in implicit <td> after a <tr>

https://gerrit.wikimedia.org/r/71744
Change 71744 had a related patch set uploaded by Subramanya Sastry:
WIP: (Bug 50420) Recognize sol-content in implicit <td> after a <tr>

https://gerrit.wikimedia.org/r/71744
Ok, renamed the bug to reflect the repurposing.
Change 71314 merged by jenkins-bot:
(Bug 50420) Tweaked selser to reuse td/th/tr wrappers from source

https://gerrit.wikimedia.org/r/71314
I was wrong.  This bug was fixed by tweaking selser as in the patch above since VE does not have table-editing capability yet (only table contents, not table structure).

There is an unrelated bug in the parser where leading list wikitext in a td-cell is parsed as plain text rather than as a list item.  So, the pipe problem is fixed by the above commit, but there will still be a dirty-diff (the first list item will be wrapped in nowiki on serialization).  That will be addressed separately.
Change 71314 had a related patch set uploaded by Subramanya Sastry:
(Bug 50420) Tweak selser to reuse td/th/tr wrappers from source

https://gerrit.wikimedia.org/r/71314
https://en.wikipedia.org/w/index.php?title=List_of_male_kickboxers&diff=562167553&oldid=562162447 shows an instance where converting an implicit <td> into an explicit <td> on serialization is a semantic error.

Reduced test case:

{|
|-
*a
|}

This cannot be fixed by selser since on editing the list item, the <td> will go through regular serialization.

We should be able to safely use the autoInserted* flags from data-parsoid in this instance since VE does not have table-editing capability yet.
The problem is that this page had about 13 tables that were unclosed (missing |} wikitext).  Parsoid does handle a lot of corner cases, but at this time, unclosed tables (especially when there are lots of them) are harder for Parsoid to recover from.  But, we have some ideas for recovering from them in the future.  But, till such time, it is easier to fix the wikitext of the page like I did (https://en.wikipedia.org/w/index.php?title=List_of_male_kickboxers&diff=562162447&oldid=562113696)

However, there is definitely a bug there which is about adding "|" after the first table row for which I'll repurpose this bug for fixing in Parsoid.
I would consider this a blocker on Monday's deployment. Things not having support (browsers or features) I can deal with, but we cannot have this sort of corruption being introduced.
Screenshot, cut-off notes list

In some formatting, the "Notes" section of an article gets cut off in editing mode display.  Additionally, "a," "b," "c," etc. get turned into 1.0, 1.1, 1.2 while in editing mode.

--------------------------
**Version**: unspecified
**Severity**: normal

**Attached**: {F11283}
(In reply to comment #2)
> Could this be the same as bug 52371?

No, this was a graphical glitch that we fixed (but I forgot to mark as such) - closing.
Could this be the same as bug 52371?
I couldn't reproduce on Firefox or Chrome, Linux or Windows.  The article hasnt changed since the bug was raised.
https://en.wikipedia.org/wiki/Arc_diagram?veaction=edit

Did you experience this on any other article?
Creating a template entry, marking it and click on "Link" button results in following error (twice in a row):

TypeError: focusedNode is null
https://bits.wikimedia.org/static-1.22wmf9/extensions/VisualEditor/modules/ve/ui/ve.ui.Context.js
Line 260

VE is in a bad state after this cannot access template edit at all after this.

--------------------------
**Version**: unspecified
**Severity**: normal
Changing the status to Resolved -Worksforme.
If you still experience the error , please reopen the bug.
Not getting this error now in FireFox 20 and Chrome Version 26.0.1410.65 using MAC OS X 10.8.5.

Right now clicking on "Link" button while selecting a template adds the link to the left of the template and can access  template edit after that.
When VE is active on a page it inserts its own "edit" tab (veaction=edit) and renames the legacy edit tab (action=edit) to "Edit source".

Since VE is not active on all pages though the "edit" tab's functionality is inconsistent across pages (sometimes opening VE, sometimes opening the Wikitext editor).

VE should rename the legacy edit tab to "Edit source" on *every* page (even if it is not active and therefore not inserting it's own "edit" link so the button's functionality keeps consistent across pages.


This was also discussed on http://en.wikipedia.org/wiki/Wikipedia:Village_pump_%28technical%29#Change_the_.22Edit.22_tab_to_.22Edit_source.22_in_all_namespaces.
Please note (as discussed in the linked section) that renaming the legacy edit tab globally by simply changing the existing interface message is *not* an option. People not using the visual editor should not see "edit source" by default but should continue to see the same text that was always there.

--------------------------
**Version**: unspecified
**Severity**: major
**See Also**:
https://bugzilla.wikimedia.org/show_bug.cgi?id=50424
Now fixed and deployed.
Change 77165 had a related patch set uploaded by Catrope:
Move edit tab generation into PHP and make it more configurable

https://gerrit.wikimedia.org/r/77165
Changing CSS id tags doesn't seem like all that much of a programming challenge, but it would enable all language Wikipedias to deal with this problem of inconsistent names appearing on "edit" tabs. So the payoff here, per hour of programming time, is really large. This isn't in any way a controversial change (it's invisible, directly, to users); it would be great if someone would deal with it and we could make progress in reducing user confusion.
(In reply to comment #3)
> I'm think the following request by English Wikipedia user Reaper Eternal is
> relevant to this bug (sorry if it isn't).

Yes, that would get fixed by us doing this.
(In reply to comment #3)

Reaper Eternal's proposal is an excellent solution to the issue of what the "Edit source" tab should be named, and partly addresses whether "Edit" should be "Edit source" even when VE is not available (and thus there is one edit tab, not two). His proposal is a good solution because it then allows individual editors to alter these labels (I  would prefer "VE" rather than "Edit", and "Wikitext" rather than "Edit source",for example) via their own CSS, while leaving the defaults as is for newer editors. 

> I'm think the following request by English Wikipedia user Reaper Eternal is
> relevant to this bug (sorry if it isn't).
> 
> "Currently, on articles and userpages, editing using the VisualEditor uses
> the
> #ca-edit CSS id and editing the source uses the #ca-editsource CSS id.
> However,
> in all other namespaces, #ca-edit is the only edit link. For people like me
> who
> like to change the titling or styling of the tabs, this inconsistency is
> annoying. (For me, it makes the "edit" tab on this page display as "VE"
> rather
> than "Source".) Could the CSS id tags be made consistent (use #ca-editsource
> for all non-VE editing)? Thanks."
I'm think the following request by English Wikipedia user Reaper Eternal is relevant to this bug (sorry if it isn't).

"Currently, on articles and userpages, editing using the VisualEditor uses the #ca-edit CSS id and editing the source uses the #ca-editsource CSS id. However, in all other namespaces, #ca-edit is the only edit link. For people like me who like to change the titling or styling of the tabs, this inconsistency is annoying. (For me, it makes the "edit" tab on this page display as "VE" rather than "Source".) Could the CSS id tags be made consistent (use #ca-editsource for all non-VE editing)? Thanks."
I agree that relabelling it immediately for all MediaWiki installations is a poor choice, as (a) some people, (b) some WMF wikis, and (c) almost all MediaWiki wikis not hosted by WMF do not have VisualEditor enabled at this point.

When VisualEditor is on for everyone, labelling the tab "edit source" (even when "edit", i.e. VisualEditor, is not available) seems like the best solution for our cluster. (If we wanted to, we could over-ride the value of the "edit" tab with a message from the Wikimedia-Messages system to do a WMF-specific over-ride of the MediaWiki default.) However, fixing this before (b) is fixed, let alone whilst (a) is fixed, feels like the wrong way to do this.

A shorter-term fix is indeed to re-label "edit" to "edit source" for all pages visited by all users with VisualEditor. Maybe we could do that. Thoughts, Timo?
I initially suggested updating the wording from "Edit" to "Edit source" at that VPT thread, and at https://en.wikipedia.org/wiki/MediaWiki_talk:Edit and at https://en.wikipedia.org/wiki/MediaWiki_talk:Vector-view-edit

There are some good (and some not so good) suggestions and comments in the VPT thread. 

Consistency would be ideal, and Eduard's suggestion above, seems to make the most sense.
Try editing the professional ratings template in https://en.wikipedia.org/wiki/All_6%27s_and_7%27s?veaction=edit

--------------------------
**Version**: unspecified
**Severity**: normal
**See Also**:
https://bugzilla.wikimedia.org/show_bug.cgi?id=50551
https://bugzilla.wikimedia.org/show_bug.cgi?id=50910
https://bugzilla.wikimedia.org/show_bug.cgi?id=51708
This issue also occurs for the following case:

1.Add an image
2.Add a gallery 
3.Change the position of the image to the left 
4.Select the gallery
5.Try to select the image 

Observed Result:
Since the width of the phantom for the gallery is 100% , it is overlapping with the image and it becomes difficult to select the image after that.
*** Bug 51048 has been marked as a duplicate of this bug. ***
*** Bug 50443 has been marked as a duplicate of this bug. ***
*** Bug 50211 has been marked as a duplicate of this bug. ***
Changed title to "Phantoms can be width:100% when the object they're meant to cover has a floated element alongside it"; looks like the phantom is generated to be as wide as its target "should" be, before the floats come into play. This can make it impossible to edit the floated item.
Wikicode for inserting animage in a standard ways into Wikipedia: 

[[File:Name.jpg|thumb|Text]] without any size.

VE adds a fixed size of 225x225px (why these numbers?) to the wikicode which is wrong for most Wikipedias.

The size of a standard thumbnail depends on $wgThumbLimits and $wmgThumbsizeIndex or the size set in the user preference.

--------------------------
**Version**: unspecified
**Severity**: normal
**URL**: https://fr.wikipedia.org/w/index.php?title=Yael_Bartana&diff=94503286&oldid=90892725
**See Also**:
https://bugzilla.wikimedia.org/show_bug.cgi?id=47804
Done in gerrit 114420.
I support this bug. Please dont add a size to the image by default. And show the size as tooltip, if user resizes it.
This bug doesn't depend on bug 38129 (and neither does it block it).
(In reply to comment #2)
> Further the manual of style policy on image size
> http://en.wikipedia.org/wiki/Wikipedia:IMGSIZE#Displayed_image_size
> states that most images on the right hand side of the page should be scaled
> to
> 220 pixels wide. There need to be a way of specifying a precise numerical
> size.

No. This is a setting specified in the configuration file. No need to enter a precise numerical value. Per above policy: "In general, do not define the size of an image".
(In reply to comment #2)
> Further the manual of style policy on image size
> http://en.wikipedia.org/wiki/Wikipedia:IMGSIZE#Displayed_image_size
> states that most images on the right hand side of the page should be scaled
> to 220 pixels wide. There need to be a way of specifying a precise
> numerical size.

That will be done as part of bug 38129.
Further the manual of style policy on image size http://en.wikipedia.org/wiki/Wikipedia:IMGSIZE#Displayed_image_size
states that most images on the right hand side of the page should be scaled to 220 pixels wide. There need to be a way of specifying a precise numerical size.
*** Bug 50766 has been marked as a duplicate of this bug. ***
TemplateData from transcluded items (i.e. doc pages) takes a long time to show up in the API. 

A temporary solution to this is to do a [[ https://www.mediawiki.org/wiki/Manual:Purge#Null_edits | null edit  ]] (opening the page, and saving, without making any changes) which will cause the template data to propagate immediately.
>>! In T52372#544516, @SalixAlba wrote:
> What would be nice is if action=purge would force templatedata updates, like null edits do. This is necessary as many templates are protected so only admins can do null edits. Any editor can do an action=purge (I believe).

Hear, hear!  And yes, I certainly //seem// to be able to purge pages I can't edit.
*** Bug 69647 has been marked as a duplicate of this bug. ***
(In reply to comment #23)
> Thanks to Tim's fix this isn't
> critical any more (users can 'just' null-edit touch the relevant template to
> cause TemplateData content to come through)

Note: This workaround only works for templates that aren't widely used.

Widely-used templates are protected, and users can't null-edit them unless they are an admin (which drastically reduces the population of people who can add and edit TemplateData on the exact templates which would benefit from TemplateData most).
Moving this to be a site issue, and re-grading. Thanks to Tim's fix this isn't critical any more (users can 'just' null-edit touch the relevant template to cause TemplateData content to come through), but it's very irritating and we need to fix it.
What would be nice is if action=purge would force templatedata updates, like null edits do. This is necessary as many templates are protected so only admins can do null edits. Any editor can do an action=purge (I believe).
Tim's change https://gerrit.wikimedia.org/r/#/c/72679/ (deployed) seems to have made it possible to force templatedata updates by just performing a null edit on the affected template, which is now safe to do on highly-used templates. Note that a null edit is an edit made by just pressing "Save page" without making _any_ changes to the template code itself.
You appear to just be seeing the effect of weeks of job queue lag, i.e. a system problem, not a MediaWiki problem.
Observation:

- Edite <templatedata> block on Template:Pagetype/doc.
- View https://en.wikipedia.org/w/api.php?format=jsonfm&action=templatedata&titles=Template:Pagetype/doc
  (with random query params to bust frontend cache)
  It shows the updated data.
- View https://en.wikipedia.org/w/api.php?format=jsonfm&action=templatedata&titles=Template:Pagetype
  (with random query to bust frontend cache)
  It shows the old version still.
- View https://en.wikipedia.org/wiki/Template:Pagetype
  It shows the updated version in the HTML version of the data
  (not sure whether the html update was triggered by a deferred update
  as a result of me editing the sub page or by me viewing the page,
  either way the output is updated).

- View https://en.wikipedia.org/w/api.php?format=jsonfm&action=templatedata&titles=Template:Pagetype/doc
  (with random query to bust frontend cache)
  It shows the updated data.
- View https://en.wikipedia.org/w/api.php?format=jsonfm&action=templatedata&titles=Template:Pagetype
  (with random query to bust cache)
  It shows the old version still.

- Check https://en.wikipedia.org/w/api.php?format=jsonfm&action=query&meta=siteinfo&siprop=statistics and saw there are no pending jobs (not sure if this data is accurate though, it seemed to be accurate as edit count was going up on each refresh).


- Make a null edit to "Template:Pagetype".

- View https://en.wikipedia.org/w/api.php?format=jsonfm&action=templatedata&titles=Template:Pagetype
  (with random query to bust cache)

  It now shows the latest data, update succeeded.


So what is causing this to not be auto updated? I think T7382. But having trouble figuring out how come bug 5382 exists since we do have LinkUpdate and RefreshLinks2 which are triggered on edit from the job queue and update all pages linking to it, and the code in LinkUpdate includes all link tables and page properties.
Observation:

- Edite <templatedata> block on Template:Pagetype/doc.
- View https://en.wikipedia.org/w/api.php?format=jsonfm&action=templatedata&titles=Template:Pagetype/doc
  (with random query params to bust frontend cache)
  It shows the updated data.
- View https://en.wikipedia.org/w/api.php?format=jsonfm&action=templatedata&titles=Template:Pagetype
  (with random query to bust frontend cache)
  It shows the old version still.
- View https://en.wikipedia.org/wiki/Template:Pagetype
  It shows the updated version in the HTML version of the data
  (not sure whether the html update was triggered by a deferred update
  as a result of me editing the sub page or by me viewing the page,
  either way the output is updated).

- View https://en.wikipedia.org/w/api.php?format=jsonfm&action=templatedata&titles=Template:Pagetype/doc
  (with random query to bust frontend cache)
  It shows the updated data.
- View https://en.wikipedia.org/w/api.php?format=jsonfm&action=templatedata&titles=Template:Pagetype
  (with random query to bust cache)
  It shows the old version still.

- Check https://en.wikipedia.org/w/api.php?format=jsonfm&action=query&meta=siteinfo&siprop=statistics and saw there are no pending jobs (not sure if this data is accurate though, it seemed to be accurate as edit count was going up on each refresh).


- Make a null edit to "Template:Pagetype".

- View https://en.wikipedia.org/w/api.php?format=jsonfm&action=templatedata&titles=Template:Pagetype
  (with random query to bust cache)

  It now shows the latest data, update succeeded.


So what is causing this to not be auto updated? I think bug 5382. But having trouble figuring out how come bug 5382 exists since we do have LinkUpdate and RefreshLinks2 which are triggered on edit from the job queue and update all pages linking to it, and the code in LinkUpdate includes all link tables and page properties.
Timo has narrowed down the issue to bug 5382 - we're working now to see whether we can fix that bug and so resolve this, or whether that will put too much weight on the cluster.
Thought I'd drop a note and say that when I tried a null edit on https://en.wikipedia.org/wiki/Template:Mileposts, the overall template description loaded right away on https://en.wikipedia.org/wiki/British_Columbia_Highway_7. However, the parameter description (km=) did not load until I deleted the template from the article and reinserted the template anew.
I added[1] templatedata to en.wiki [[Template:Redirect]] yesterday (through the /doc transclusion) and also noticed that the main template page wasn't updating (I waited for about 10 minutes).

Then I did a null-edit on Template:Redirect and it was instantly there.

Roan mentioned something earlier (IRC or IRL, don't remember) about this perhaps being caused by the JobQueue (which we use to invalidate pages transcluding other pages, in this case the transclusion of /doc into Template:. *NOT* the transclusion of Template into articles, of course, that'd be insane).

CC-ing Roan, Tim and Aaron who may have more ideas about the cause of this.

As for TemplateData itself, it is triggered as a extension parser tag (<templatedata>) and during the parsing it adds page properties which MediaWiki ends up storing in the page_props db table. The API does a read query from that same table. Pretty basic.

So what could cause the read query to the page_props table to be delayed (or perhaps even not happen at all?) from the page properties added by a page that is transcluded (Template:Foo/doc) into a template page (Template:Foo).

JobQueue? Database replication? Something else?

Note that in my testing yesterday on Template:Redirect I ruled out HTTP caching (API cluster Squid) by making unique urls each time.


[1] https://en.wikipedia.org/w/index.php?title=Template%3ARedirect%2Fdoc&diff=562472124&oldid=562471783
Wouldn't we avoid this delay if the template data were in a specific namespace, instead of being saved in one page, which is transcluded in another, which on its turn may be transcluded another, and so on, until the data finally gets to the template? See bug 50512.
The extension page says:

"The TemplateData extension works through having a <templatedata> tag defined in the wikitext of a template page (optionally it can be transcluded into the template page as well). This is designed to be compatible with the common layout many wikis have of transcluding template documentation from a separate page (but is not required)."

And this seems to work partly, e.g. for https://en.wikipedia.org/wiki/Template:Italic_title.  TemplateData is at https://en.wikipedia.org/wiki/Template:Italic_title/doc and it comes up at https://en.wikipedia.org/w/api.php?action=templatedata&titles=Template:Italic%20title&format=jsonfm , but it doesn't seem to actually work in VE (e.g. no description).

Then, https://en.wikipedia.org/wiki/Template:Dead_link appears set up similar, with TemplateData at https://en.wikipedia.org/wiki/Template:Dead_link/doc .  But it does not come up at https://en.wikipedia.org/w/api.php?action=templatedata&titles=Template:Dead%20link&format=jsonfm .  It does come up at https://en.wikipedia.org/w/api.php?action=templatedata&titles=Template:Dead%20link/doc&format=jsonfm (explicitly asking for the /doc page).
Indeed, I cannot see templatedata hinting on en.wp for _any_ templates supposedly annotated per https://en.wikipedia.org/w/api.php?action=query&list=pageswithprop&pwppropname=templatedata&pwpprop=ids|title|value&format=jsonfm and https://en.wikipedia.org/wiki/Wikipedia:VisualEditor/TemplateData . Escalating priority.
https://en.wikipedia.org/wiki/Template:Mileposts was updated 48 hours ago and still hasn't shown. That seems like a time period even the squids should blink at.
Though it is possible that VisualEditor and/or TemplateData do something wrong, in general there's nothing relevant in either VisualEditor or TemplateData that can delay the updating of the data.

The template data is changes by users by editing the wikitext of a Template page (or a page transcluded into a Template page). When they click "Save page", the MediaWiki parser detects the <templatedata> tag, tells the TemplateData extension to make sense of it, which then adds (or replaces) the parsed data in the database.

There is no deferred update here, it is replaced directly.

The API request to fetch templatedata grabs it directly from the database. This isn't specifically cached in anyway.

The only caching layer is in your browser cache and the general cache in the Wikimedia cluster for HTTP requests to content domain names (e.g. "en.wikipedia.org") which is Squid.
The behavior seems inconsistent. Today, TemplateData was available in transclusions immediately after adding it to the template's documentation subpage. (tested with https://fr.wikipedia.org/wiki/Mod%C3%A8le:Unit%C3%A9 )
Argh, that's not good - https://en.wikipedia.org/w/api.php?action=templatedata&titles=Template:Talkback is not updated even though it appears in transclusion, even after purge. Timo, thoughts?
https://en.wikipedia.org/wiki/User:Okeyes_%28WMF%29/sandbox?veaction=edit <- check out the talkpage template.
(In reply to comment #6)
> Nope; remember that time I added it to the bugzilla tracked template, and
> nothing happened?

No.

> Well, it started working finally some time today.

That's not good. Did you purge the template, or did it get purged somehow (e.g. it was edited)?

> I'm going to try implementing it in a couple of other minor places and look
> at what happens.

OK.
Nope; remember that time I added it to the bugzilla tracked template, and nothing happened? Well, it started working finally some time today. I'm going to try implementing it in a couple of other minor places and look at what happens.
(In reply to comment #4)
> I'd go with A and C, Chris. If I add TemplateData to a template, go to an
> implementation of it that already exists and click the jigsaw piece, how long
> do I need between those actions to see the TemplateData?

A: This should be instantaneous - if not, action=purge on the template should do it; if not, this is an issue we need to follow-up in general with how MW works.
B: This is not yet done (bug 49778 which is being worked on right now).
C: This should be near-instantaneous (but we're about to change how this works to make it faster).

For A & C in particular as you've asked, seconds or even less. Was this during a time of serious server strain, maybe? Otherwise it sounds worrying.
I'd go with A and C, Chris. If I add TemplateData to a template, go to an implementation of it that already exists and click the jigsaw piece, how long do I need between those actions to see the TemplateData?
(In reply to comment #2)
> As does the fr implementation. I guess the question here is "how long does it
> take for TemplateData implementations to show up?"

Do you mean,

* "how long does it take newly-added TemplateData hinting to become available in the API for use in VisualEditor?",
* "how long does it take the VisualEditor transclusions dialog to show with the TemplateData hinting when adding a template in?", or
* "how long does it take the VisualEditor transclusions dialog to show with the TemplateData hinting on load?"

… or something else?
As does the fr implementation. I guess the question here is "how long does it take for TemplateData implementations to show up?"
Belay that, {{tracked}} works.
This was seen in revisions prior to https://en.wikipedia.org/w/index.php?title=Wikipedia:VisualEditor/Feedback&diff=561926823&oldid=561926781 and fixed in that revision.

For a reduced testcase see <https://test.wikipedia.org/wiki/Section_edit_links_bug2>. The cause seems to be the unclosed `{{`. Of course, this is broken wikitext, but the parser seems to be able to handle it fine (other than leaving out section edit links).

Sorry I can't be more specific.

--------------------------
**Version**: 1.22.0
**Severity**: normal
**See Also**:
https://bugzilla.wikimedia.org/show_bug.cgi?id=73182
Screenshot

See screenshot; Windows 7, Firefox 21.0, on https://en.wikipedia.org/wiki/Rage_Against_the_Machine?veaction=edit

--------------------------
**Version**: unspecified
**Severity**: major
**See Also**:
https://bugzilla.wikimedia.org/show_bug.cgi?id=50589

**Attached**: {F11166}
This bug was raised five months earlier.

*** This bug has been marked as a duplicate of bug 44498 ***
Similar hack, but now on the table itself, instead of a table cell. See the Infobox of WikiProject Aircraft:

https://en.wikipedia.org/wiki/BAC_One-Eleven
FYI, we are considering a post-processing work-around in Parsoid that lets this class of templates render as expected, but might not let users edit those templated cells.

Our longer-term goal is to move towards more self-contained templates. This won't happen over night, and we'll need the help of the editor community and bot authors.
Bug 50589 is a different issue, so I reopened it and added detail there.
**kwwilliams** wrote:

50589 has been marked as a duplicate of this bug. I'm certain it's related, but I'm not certain it's a duplicate. *If* it is a duplicate, marking it as "wontfix" isn't an acceptable answer. 

singlechart *does* return the leading | or !, depending on whether it has been ask to generate a row or a header row. It generates two row cells, separated by a |.
*** Bug 50589 has been marked as a duplicate of this bug. ***
*** Bug 50567 has been marked as a duplicate of this bug. ***
I don't have precise figures right now, but know enough to be sure that a bot will be needed. This bot pass should also fix some other issues listed in http://www.mediawiki.org/wiki/Parsoid/limitations. Do you know a bot author who might be potentially interested in a task like this? We have it on our TODO list, but did not have the time to tackle it before the release.
(In reply to comment #4)
> This cannot easily be parsed in Parsoid while also retaining round-trip
> information. And even if we could, this would be very hard to represent in
> HTML so that the VisualEditor can present a sensible user interface for it. So
> this will remain a limitation of Parsoid.

I'd like to know how many pages are affected by this bug across Wikimedia wikis before it's marked wontfix. Re-opening this for now.
The issue is normally something of this form:

{|
| {{style-and-cell}}
|}

The transclusion returns some attributes and possibly table content.

This cannot easily be parsed in Parsoid while also retaining round-trip information. And even if we could, this would be very hard to represent in HTML so that the VisualEditor can present a sensible user interface for it. So this will remain a limitation of Parsoid.

This issue can however be avoided by changing the template to return the entire table cell including the leading pipe:

{|
{{style-and-cell}}
|}

with {{style-and-cell}} containing:

| style="the style" | The cell content
Parsoid bug, it doesn't seem to like {{won}} and {{nom}}, see http://parsoid.wmflabs.org/en/Rage_Against_the_Machine
See also https://en.wikipedia.org/wiki/Akon_discography?veaction=edit from bug 50532.
*** Bug 50532 has been marked as a duplicate of this bug. ***
How the hatnote appears in the VE when it is added

This takes some effort to replicate, so bear with me; if you insert a hatnote at the beginning of a line, it renders improperly in the VisualEditor - despite rendering properly in the article text, /and/ in subsequent loads of the VE. Screenshots of each attached.

As User:PamD adeptly summarises, "if VE doesn't display the result of a change, or displays it looking wrong, editors are going to assume that their edit didn't work and struggle to "fix" it"

--------------------------
**Version**: unspecified
**Severity**: normal

**Attached**: {F11145}
Fair play; marking as duplicate.

%%%*** This bug has been marked as a duplicate of bug 49784 ***%%%
So, I've read this a number of times and I'm not quite sure I know what you're getting at.

Steps:

1. Go into a page
2. Click into a blank line; insert template "Hatnote", parameter 1 = "Foo".
3. Template appears on its own line, as expected.
4. Template saves on its own line, as expected.
5. Page rendered with template in the right place, as expected
6. Edit article.
7. Template is still there in VisualEditor, as expected.

Try two:

1. Go into a page
2. Click into the start of a non-blank line; insert template "Hatnote", parameter 1 = "Foo".
3. Template appears at the start of the line, a little oddly as it's a <div>, because of bug 49784.
4. Template saves at the start of the line, as expected.
5. Page rendered with template on its own line, as expected.
6. Edit article.
7. Template is still there in VisualEditor at the start of the line, as before.

I assume you mean that this is an issue because it doesn't show up on its own line? If so, this is just a plain duplicate of bug 49784.
How the hatnote appears in subsequent VE loads.

**Attached**: {F11148}
How the hatnote appears in "read" mode

**Attached**: {F11146}
See Kelvinsong's wonderfully detailed bug report at https://en.wikipedia.org/w/index.php?title=Wikipedia:VisualEditor/Feedback&oldid=561944647#The_Chloroplast_Test.E2.80.94June_26_C

--------------------------
**Version**: unspecified
**Severity**: normal
Perhaps I am dense, but I do not understand what this bug was about even after reading the linked discussion.
Many templates serve merely as wrapper around free-form wikitext content. TemplateData specifies the parameter type "content" for this purpose.

This task tracks the implementation in VisualEditor to provide an edit surface for editing the values of these parameter. Similar to how we already support rich editing of the content inside References.

Use cases:
* Wrap-templates. Such as message boxes, and the parameter-consuming variants of the "something-start"/"something-end" templates.
* Nested infoboxes.
* Simple infobox fields that support text but allow/encourage use of inline templates for formatting. Currently these expose raw wikitext to end-users.

>>! @Ironholds wrote
> A lot of infoboxes et al - the one on https://en.wikipedia.org/wiki/Fulgencio_(Modern_Family) comes to mind - have infoboxes /within/ the infoboxes that need editing. I'm not sure what the answer is here - it feels wrong, somehow, to offer an infinitely deep template inspector inside a template inspector inside...etc, but I can't think of another solution short of manually going around making the template namespace make sense or accepting that users will always have to learn markup, just not immediately.
> Wikitext button should look depressed when used. MW theme needs this to be improved mode generally. Need to avoid mode error

Would a ButtonSelectWidget make sense here?
Comments from discussion about this:

* Wikitext button should look depressed when used. MW theme needs this to be improved mode generally. Need to avoid mode error
* Important to remember that the types aren’t for validation, just hints – don’t frustrate the user if they want to over-ride, make it easy to replace.
* Styling of wikitext mode needs improving.
* Need to separate “allowing to use VE” from “helping with type hinting”
* Flow has this issue too (switching mode) – share feature design?
* Edge case (partial wikitext) for not being able to use VE isn’t very common, we believe?
* One switch for the whole dialog?
** Issues?
** In Advanced mode? (alongside multi-template transclusion editing)
* Possibly get rid of the (i) too, to simplify the clutter around boxes?
>>! In T52355#2079713, @Esanders wrote:
> @Ironholds the page has become a disambig since you filed. Looking at the history were you linking to https://en.wikipedia.org/wiki/Fulgencio_(Modern_Family) originally?

I fixed the link.
I have literally no idea, it was in 2014.
@Ironholds the page has become a disambig since you filed. Looking at the history were you linking to https://en.wikipedia.org/wiki/Fulgencio_(Modern_Family) originally?
Current thinking about switching modes:

| Basic appearance | {F3459623}
| Editing with support | {F3459624}
| Switched to 'wikitext' mode | {F3459622}
Re-wording; this isn't a duplicate of bug 50182, which is about non-dialog editing of templates.
*** This bug has been marked as a duplicate of bug 50182 ***
The current workflow for adding a new template; you add the template, you add parameter 1, you go to add parameter 2...only you can't, because adding parameter 1 jumped you to an entirely new tab that doesn't contain a mechanism for adding parameter 2.

It'd be good to have some mechanism to add additional parameters that is more intuitive - something as simple as not jumping a user to the parameter page, even. I appreciate bug 49778 partially solves for this but it's going to be a looong time before all our templates have templatedata.

--------------------------
**Version**: unspecified
**Severity**: enhancement
**See Also**:
https://bugzilla.wikimedia.org/show_bug.cgi?id=51774
https://bugzilla.wikimedia.org/show_bug.cgi?id=49772
I think these are all now tracked in bug 53604's dependencies, which is a more scalable way to find, triage and fix bugs; consequently, closing this as INVALID (though each of its suggestions are of course real bugs or enhancements).
(In reply to comment #11)
> << For templates, it would be helpful to provide some links to the actual
> template page from the transclusion dialog. At least a direct link, but
> perhaps
> something like v*t*e (view/talk/edit) like included in many navigation
> templates. --[[User:Wouterstomp|WS]] ([[User talk:Wouterstomp|talk]]) 11:12,
> 6
> August 2013 (UTC) >>

Links to template documentation pages from the transclusion editor is bug 49772
<< For templates, it would be helpful to provide some links to the actual template page from the transclusion dialog. At least a direct link, but perhaps something like v*t*e (view/talk/edit) like included in many navigation templates. --[[User:Wouterstomp|WS]] ([[User talk:Wouterstomp|talk]]) 11:12, 6 August 2013 (UTC) >>
<< When the templatedata does not take any parameters, as specified by the corresponding templatedata (e.g. <nowiki>{{fixed}}</nowiki>, don't show the add parameter heading/text field and 'no unused parameters'. --[[User:Wouterstomp|WS]] ([[User talk:Wouterstomp|talk]]) 11:08, 6 August 2013 (UTC) >>
I've added bug 51774 as a see-also. That bug is about making it easier to see long descriptions by use of a tooltip. I don't think it is dependent on or duplicative of this though.

Bug 49772 is also relevant here, that asks for links to extended documentation.
The treatment of "required parameters" is positively unhelpful. I suggest that they should be listed below the input box, like the other parameters, with a note saying "Required". At present it's easy not to notice that they're there, at the top of the left-hand column, while a few of the other parameters and their descriptions are listed conspicuosly below the input box.

Steps to add a non-required parameter:
#See it listed below the box, with its descriptionm and click (or, remember its name and type it)
#type the value into the displayed box
# (non-intuitively) click on the template name top left to add another parameter (please give us an "Add another parameter" box!)

Steps to add a required parameter:
# Notice that it's listed, top left - just the name, no description
# Recognise that it's an important and required parameter, even if the name is a bit cryptic
# Move mouse up there and click on it
#Now see it displayed with its description
# type the value into the displayed box
#...

I don't think the editor benefits from the current situation: I've tried adding a few templates and been flummoxed by it: sometimes the parameter name doesn't convey what it is, while if it was listed below the input box with its description it would be much clearer. Stick a red "Required"  note beside it: editors are used to this on all sorts of other web forms.
**euro** wrote:

(In reply to comment #4)
> I'd also request the elimination and replacement of the word "transclusion";
> it's very opaque to non-wikimedians (and also potentially incorrect).

Agreed...Perhaps it would be helpful in "dumbing down" the term to review the Free Dictionary treatise on "transclusion":

http://encyclopedia.thefreedictionary.com/Transclusion

--It pretty much comes down to the age-old issue of taking whatever is somewhere originally and replicating it somewhere else. The catch: no matter what happens to the original material, it's reflected immediately in the replicated copy. So within the context of "Wikistuff", how about "replicate"?

Webbie
I'd also request the elimination and replacement of the word "transclusion"; it's very opaque to non-wikimedians (and also potentially incorrect).
Another editor doing a lot of work with templates suggests that in commonly used templates with regular parameters, it might be a good idea to have the parameters preloaded. Speaking of the common "cite web" template, she says:

"I think it would be easier for the parameteres to already being added, at least the basic ones, to the template. For example, to the "cite web" template, the parameters that most people use (title, url, author, publisher and date). So, when the editor adds the "cite web" template, would only have to add the content of each parameter and not the parameters themselves. If the editor wants to add an extra parameter, they could choose it from the list and add it. I am sure that this is difficult to be done knowing that there are lots of templates to go through but maybe keep it as a thought if it can be done?"
Another thought; the different tabs for different params is something that takes a while to figure out, and introduces a lot more hoops into the system.
The cursor cannot be placed below the last line. This sounds trivial, but there are a lot of situations - adding stub templates, or defaultsort data, for example - where being able to trivially flip to the end of an article and have space to write is A Good Thing (tm). It'd be good to have a temporary line at the end of an article that isn't saved unless it contains anything.

--------------------------
**Version**: unspecified
**Severity**: enhancement
We don't insert slugs if the user can create a new line by pressing enter. If the document ends in a template or other focusable item, we do.
1. Edit [[testwiki:Displaytitle]] using VE
2. Using the transclusion dialog box, add the following "template":
        DISPLAYTITLE:''displaytitle''
3. Save the page

The page title remains "Displaytitle" in roman type.

Expected to see "displaytitle" in italics. This is what you see when you refresh the page.

--------------------------
**Version**: unspecified
**Severity**: minor
**See Also**:
https://bugzilla.wikimedia.org/show_bug.cgi?id=49667
(In reply to Alex Monk from comment #13)
> So this appears to actually be working now.

Woo-hoo. :-)
So this appears to actually be working now.
Change 141098 merged by jenkins-bot:
Update displaytitle on save (try #3)

https://gerrit.wikimedia.org/r/141098
Change 141098 had a related patch set uploaded by Alex Monk:
Update displaytitle on save (try #3)

https://gerrit.wikimedia.org/r/141098
Change 140591 merged by jenkins-bot:
Update displaytitle on save (try #2)

https://gerrit.wikimedia.org/r/140591
Change 140591 had a related patch set uploaded by Alex Monk:
Update displaytitle on save (try #2)

https://gerrit.wikimedia.org/r/140591
Patch reverted; re-opening.
Change 139205 merged by jenkins-bot:
Update displaytitle on save

https://gerrit.wikimedia.org/r/139205
Change 139205 had a related patch set uploaded by Alex Monk:
Update displaytitle on save

https://gerrit.wikimedia.org/r/139205
Yeah it's actually kind of a pain to do that. Let's update it on save.
So now that the dependency is merged, Parsoid now recognises {{DISPLAYTITLE:stuff}} as a meta property (instead of a template), and VE provides a box on the options page to change the display title. I think what we should do is update the title (almost) as soon as it's changed.
Confirmed that adding italics to an existing page doesnt display italics on save - it does display the italic title after save + refresh.

However it does display italics on save, if the DISPLAYTITLE is set for a new page. 

Tested with {{italics title}} and {{DISPLAYTITLE:''ItalicsTitle''}} on testwiki

https://test.wikipedia.org/wiki/ItalicsTitle
I think this includes my problem with {{tl|italic title}}, which is at two levels:
# When I add it, I expect to see it take effect immediately - it doesn't (so I wonder whether I remembered to add it, whether I formatted it correctly, ... etc)
# Even when I save the page, it doesn't take effect until I refresh the page (same set of worries).
Created attachment 12689
Wrong title displayed in "correct title" template.

I think it's related, so I'm sticking this here.

After http://it.wikipedia.org/w/index.php?title=Utente:Dry_Martini/Cricca&diff=prev&oldid=59761793, the page, containing a "Correct title" template, would display, after being saved, the message usually generated by that template, although it disappears if you refresh. 

I tried it myself and this time I actually changed the title in the template.
The screenshot shows what happened after http://it.wikipedia.org/w/index.php?title=Utente%3ADry_Martini%2FCricca&diff=59761896&oldid=59761793 my edit.
Basically, the page retains its formerly given title, while displaying in the message the one I chose. Again, everything is ok if you refresh.
(For the record, the usual title is "There is no Cabal", while mine reads "There's a Cabal, and it's using VisualEditor".)

**Attached**: {F11086}
Using ctrl-click (but not middle-click) on a "content editable" link, does not currently work with Chromium37, but does work with Firefox39.
Using Middle-mouse-click on links does not work in either browser
Using Right-mouse-click to show the context menu with "Open link in new tab/window" does work in both browsers.

(Prior description had different results for Firefox 22.
Ed notes below, that this is all browser-specific behaviour, and rather than overriding that, we should just solve {T56759} (Done))

See also: {T52741}
The main request here was satisfied in {T56759} and for non-links more generally in the context menu stuff done in March-ish. I agree with Ed that breaking people's browsers' behaviour isn't desireable.
The main request here was satisfied in {T56759} and for non-links more generally in the context menu stuff done in March-ish. I agree with Ed that breaking people's browsers' behaviour it's desireable.
Note/update: Using ctrl-click (but not middle-click) on a "content editable" link, does not currently work with Chromium37, but does work with Firefox39. 
I will update the description to clarify.
Middle click/ctrl click on *content editable* links in browser specific behaviour, and isn't necessarily going to be the same as for read-only links. Rather than override the browser's default behaviour we will provide a consistent way to follow links with bug 54759.

Image nodes are protected from editing with highlights so we're not going to able to provide the normal context menu. I can't see a compelling use case, but such functionality may be available in the image dialog in the future.

Suggest wontfix for this.
*** Bug 64974 has been marked as a duplicate of this bug. ***
The mouse cursor not changing is bug 50741 

CTRL+click / right click and open in a new window/tab does work for internal and external links. It does not work for images.
Some more details: 

* Middle mouse click on internal text links: OK (but mouse cursor wrong)

* Middle mouse click on images: NOT OK
* Middle mouse click on external links: NOT OK
Try and edit this version of my sandbox http://it.wikipedia.org/w/index.php?title=Utente:Elitre_(WMF)/Sandbox&oldid=59706098 which is empty except for a __NOINDEX__ ; VE just keeps loading and won't allow to edit. Happens at least with Vector on Chrome and Monobook on FF.

--------------------------
**Version**: unspecified
**Severity**: normal
Fixed in the above commit, which we will push out today.
Change 73745 merged by jenkins-bot:
Extend empty document check to check for meta-only data

https://gerrit.wikimedia.org/r/73745
Change 73745 had a related patch set uploaded by Esanders:
Extend empty document check to check for meta-only data

https://gerrit.wikimedia.org/r/73745
This happens because the converter generates a document with only an alienMeta (the magic word) and an empty internal list. The logic for generating an empty paragraph to prevent an empty document doesn't kick in if the document is non-empty from the converter's perspective but only contains meta items.
When the transclusion editor is emptied out (e.g. by removing all the items), it should not just be blank. This looks broken and is confusing to the user (should I wait for something to appear? is it stuffed/errored out?)

There needs to be some kind of textual label in the empty transclusion editor, that makes two points:

1. that the user can click [+] to add something to the transclusion
2. that by clicking "apply changes", it will remove the transclusion

--------------------------
**Version**: unspecified
**Severity**: enhancement
Change 198131 merged by jenkins-bot:
Fixed the empty Transclusion Box problem

[[https://gerrit.wikimedia.org/r/198131]]
Change 198131 had a related patch set uploaded (by Jforrester):
Fixed the empty Transclusion Box problem

[[https://gerrit.wikimedia.org/r/198131]]
*** Bug 51812 has been marked as a duplicate of this bug. ***
Created attachment 12684
Screenshot of bug

Just found this lovely screenshot that I meant to upload.

**Attached**: {F11889}
1. Go to some page and edit in VE
2. Click the "Link" toolbar button, type "Category:" and click a category that appears

The leading colon is correctly added, but the category now appears in red in the dropdown as if non-existent (although it shows up under "matching pages", not "new pages").

Probably, the link inspector should be ignoring/stripping the preceding colon when checking whether the page exists.

Same thing for links to File: pages.

--------------------------
**Version**: unspecified
**Severity**: normal
*** Bug 63353 has been marked as a duplicate of this bug. ***
Change 142136 merged by jenkins-bot:
Don't prepend extra colon to category/file links

https://gerrit.wikimedia.org/r/142136
Change 142136 had a related patch set uploaded by Alex Monk:
Don't prepend extra colon to category/file links

https://gerrit.wikimedia.org/r/142136
Two different things look like they're pre-pending the ":". Helpful. :-)
Screenshot

See the screenshot (provided by a contributor). I suspect it's down to the screen resolution. Firefox 21.0, Mac OS X 10.6.8.

--------------------------
**Version**: unspecified
**Severity**: normal

**Attached**: {F11863}
(In reply to This, that and the other from comment #2)
> It looks no more broken to me in VE than it does in view mode.

Yeah; marking as fixed.
It looks no more broken to me in VE than it does in view mode.
I wonder if this is related to bug 50036?
See the report at https://en.wikipedia.org/wiki/Wikipedia:VisualEditor/Feedback#Failed_attempt_to_use_VE_to_remove_a_template_parameter

--------------------------
**Version**: unspecified
**Severity**: enhancement
Comment from bug 51558:

An en.wp [[user:3family6]] comments about [[Template:Album ratings]]:
"This is an instance where the transclusion option on VE, while it does work,
is more inconvenient than just wiki-markup. In wikimarkup, if you want to
insert a new review into the middle of the template, i.e. between reviews 3 and
4 (rev3 and rev4), you just change rev4 to rev5 (and rev5 to 6 and so on), then
insert the new score. With VE, you have to add a new rev parameter to the
bottom, and move the content of ALL of the parameters affected through
copy-paste. This is much more time consuming than editing the wikitext."

For context reviews are listed in alphabetical order, initially the template
could be something like:
rev1 = A Magazine
rev1Score  = 4/5
rev2 = CTV
rev2Score = 1/5
rev3 = FooMusic
rev3Score = 5/5
rev4 = ZedNews
rev4Score = 6/10

The album then gets rereleased and reviewed by BetaMag. This needs to be added
at the second review, in source editing it's just a matter of changing 6
characters (4→5,3→4, etc). In VE you have to create a new rev5 and rev5
parameter, then cut and paste the values from each of rev2 - rev4 and rev2Score
- rev4Score to their new locations then add the new data. 

One better way to handle this would be to allow the renaming of parameters.
Either in the "options" section or by right clicking on the parameter name. 

This is likely to affect other templates too.
*** Bug 51558 has been marked as a duplicate of this bug. ***
**Author:** `rachelqa99`

**Description:**
This it the top level links English, Talk, Preferences, Watchlist etc appearing on top of references window

--------------------------
**Version**: unspecified
**Severity**: minor
This was fixed in the deployment earlier this week.
Confirmed in Chrome/Mac; this looks like a general issue with z-indexes. Thanks for the catch!
Created attachment 12650
Screenshot showing issue (extracted from Word docx file)

**Attached**: {F11829}
**rachelqa99** wrote:

screenshot

//attachment screenshotve.docx ignored as obsolete//
Totally a nice-to-have; it'd be good if the link inspector could inform users that they're linking through to a DAB page.

--------------------------
**Version**: unspecified
**Severity**: enhancement
**See Also**:
https://bugzilla.wikimedia.org/show_bug.cgi?id=50160
https://bugzilla.wikimedia.org/show_bug.cgi?id=59208
https://bugzilla.wikimedia.org/show_bug.cgi?id=49502
Change 110654 merged by jenkins-bot:
Mark disambiguation and redirect pages in the link inspector

https://gerrit.wikimedia.org/r/110654
Change 110654 had a related patch set uploaded by Alex Monk:
Mark disambiguation and redirect pages in the link inspector

https://gerrit.wikimedia.org/r/110654
Hint: Links to disambig pages can now be easily checked with the isDisambiguationPage() function introduced with Gerrit 100413.
Can we also ask that VE warns about "auto-links", which is, links in the article pointing to the article itself? https://bugzilla.wikimedia.org/show_bug.cgi?id=50497 explains why those links can happen, but that is true for templates, I can't recall real reasons for wanting that to happen in the article body as well.
So [[user:Fram]] suggested that a warning would be useful in that case.
**Saehrimnirwikipedia** wrote:

Hi is anyone working on this since it is now deployed on more wikipedias this will become a bigger and bigger problem? Before VE people were checking if the Link was going to the right target more often because it was possible to have typos but with a drop down list they are bound to rely that what they pick will work as intended.
*** Bug 51524 has been marked as a duplicate of this bug. ***
The current code related to this functionality is in VisualEditor/modules/ve-mw/ui/widgets/ve.ui.MWLinkTargetInputWidget.js if anyone wants to take a shot at it.
This has come up in a discussion about surging numbers of dablinks being noticed by the dab project.  If VE is the source for this uptick, we should think about getting this fix in sooner rather than later. 

Discussion on en.:
http://en.wikipedia.org/wiki/Wikipedia:Village_pump_%28miscellaneous%29#Disambiguation_in_crisis
This has been implemented in the old editor (WikiEditor). See https://gerrit.wikimedia.org/r/#/c/70564/ for the implementation details. It should be easy to add this feature to VisualEditor as well.
*** Bug 50986 has been marked as a duplicate of this bug. ***
Sure; I don't think we're saying it shouldn't /let/ the user, merely that it should inform the user.
I agree for disambiguation pages.

But I believe creating a wikilink to a redirect page is OK. For instance linking to "HTC Super3" even though it is actually a redirect to "HTC Super".
The Qunit jobs are currently running on the master, they need to be moved to
gallium slave nodes.

--------------------------
**Version**: wmf-deployment
**Severity**: enhancement
I have updated some files ownerships manually and validated qunit tests jobs are passing for MediaWiki core and VisualEditor.
Change 72083 merged by Hashar:
tie qunit jobs to slaves

https://gerrit.wikimedia.org/r/72083
Change 72086 merged by coren:
contint: file perms for qunit jobs

https://gerrit.wikimedia.org/r/72086
Change 72086 had a related patch set uploaded by Hashar:
contint: migrate qunit jobs to Jenkins slaves

https://gerrit.wikimedia.org/r/72086
Change 72083 had a related patch set uploaded by Hashar:
tie qunit jobs to slaves

https://gerrit.wikimedia.org/r/72083
Screenshot: Narrow window

When space is scarce (for example at high zoom, or when the window is very narrow), the "View history" tab is moved to the drop-down menu (that also includes "Delete", "Move", etc.) so that the action remains accessible.

The "Edit" and "Edit source" tabs don't seem to do the same; they stay where they are, which prevents them from being used in similar situations (see attached screenshots).

It would imho make sense to migrate both tabs to the drop-down menu as well when there isn't enough space to display them at their usual location, so that users can still access the edit modes.

--------------------------
**Version**: unspecified
**Severity**: minor

**Attached**: {F11766}
Change 123503 merged by jenkins-bot:
Give the edit tab <li> closest to the collapsed tabs menu class=collapsible

https://gerrit.wikimedia.org/r/123503
Change 123503 had a related patch set uploaded by Alex Monk:
Give the edit tab <li> closest to the collapsed tabs menu class=collapsible

https://gerrit.wikimedia.org/r/123503
(In reply to comment #0)
> It would imho make sense to migrate both tabs to the drop-down menu as well
> when there isn't enough space to display them at their usual location, so
> that
> users can still access the edit modes.

"Edit" is not normally collapsed, but it would make sense for "Edit source". You'd just add class="collapsible" on the <li> and it will magically work.
Created attachment 12643
Screenshot: High zoom

**Attached**: {F11767}
1. Go to http://en.wikipedia.org/w/index.php?title=Black&veaction=edit
2. Middle-click or ctrl+click on any wikilink

You get a 404 page, e.g. http://en.wikipedia.org/w/Outer_space

VE should use fully qualified hrefs (/wiki/foo), just as MW always does.

--------------------------
**Version**: unspecified
**Severity**: normal
I think this is a duplicate of 48915, which clearly we should fix right now.

*** This bug has been marked as a duplicate of bug 48915 ***
(Sorry for carelessly filing a dupe before (bug 50207) - I have checked this one, but if it is a dupe, you are most welcome to trout me for wasting your time!)

1. Edit [[testwiki:VisualEditor:Links]] in VE
2. Make a selection like

     Golden Gate National Recreation [Area is the] best

   (partly inside the link, partly outside it)
3. Click the "Link" toolbar button and make a link to any page
4. Click in the word "Area" to move the cursor there

Two link icons appear in the floating toolbar.

5. Save page > Review changes

Wikitext output has two links side-by-side, pointing to the same target.

--------------------------
**Version**: unspecified
**Severity**: normal
Merged and we'll push this to production in the next hour or so.
Related URL: https://gerrit.wikimedia.org/r/70644 (Gerrit Change I1cab7f3cc4fc9589eced01ad38c59fe5b9622a57)
(In reply to comment #0)
> (Sorry for carelessly filing a dupe before (bug 50207) - I have checked this
> one, but if it is a dupe, you are most welcome to trout me for wasting your
> time!)

Ha, no worries; dupe's aren't in any way useless (it reminds us that it's a real problem we need to fix really soon!). It's mostly just that it's a waste of your time. :-(

> 
> 1. Edit [[testwiki:VisualEditor:Links]] in VE
> 2. Make a selection like
> 
>      Golden Gate National Recreation [Area is the] best
> 
>    (partly inside the link, partly outside it)
> 3. Click the "Link" toolbar button and make a link to any page
> 4. Click in the word "Area" to move the cursor there
> 
> Two link icons appear in the floating toolbar.
> 
> 5. Save page > Review changes
> 
> Wikitext output has two links side-by-side, pointing to the same target.

Yeah, this is definitely a fail on our part (and a regression!). Thanks for the spot; assigning to Ed.
3 parameters is the limit, 6 is crazy.

ve.ui.PopupWidget.prototype.display = function ( x, y, width, height, transition, embedded ) {

--------------------------
**Version**: unspecified
**Severity**: enhancement
Looking pretty good. It's been separated and the method itself (OO.ui.PopupWidget#display) no longer exists.

https://github.com/wikimedia/oojs-ui/blob/e43584b420/src/widgets/PopupWidget.js
screenshot of nested templates in VisualEditor

Templates are sometimes nested into one another. For example, https://en.wikipedia.org/wiki/Template:Chembox relies on sub-templates like https://en.wikipedia.org/wiki/Template:Chembox_Properties , which itself relies on other templates etc.

VisualEditor currently doesn't seem to handle these sub-templates. It shows a nice interface for the top-level template, then shows wikitext for the others (see screenshot).

--------------------------
**Version**: unspecified
**Severity**: enhancement

**Attached**: {F11704}
Hey Riccardo, will try and find an answer for you.
Hello, Riccardo from WikiToLearn here.

We use a lot of templates in our books, and, especially for maths, we would love to have visual editing of templates. I have seen that in T53374 the type for coherent wikitext was added. We would love to implement a solution similar to what has been done for the "Insert Media" dialog where there is a lighter VisualEditor is present when the user edits the caption. Our desired behiavor is to have the same editor show up when the type associated with the parameter is of type `content`.

However, we would only do this if you think it is a good idea, and ideally will accept the patch, to avoid forking an extension as big as VisualEditor. Is it something that would be interesting?
*** Bug 52786 has been marked as a duplicate of this bug. ***
(In reply to comment #10)
> In reply to Gabriel Wicke, substing {{subst:div col}} would give <div
> class="mw-columns-2"> .. </div>. This would work fine for all subsequent
> edits
> with VE, but not for editors using wikitext.

I don't see a big difference between a div start / end tag and {{div col}} / {{div col end}} template pairs. Both are disconnected and of roughly the same text length.
This has come up a few times at 
http://en.wikipedia.org/wiki/Wikipedia:VisualEditor/Feedback#a_sensible_way_to_edit_.7B.7Bdiv_col.7D.7D_sections
http://en.wikipedia.org/wiki/Wikipedia:VisualEditor/Feedback#Bulleted_lists

In reply to Gabriel Wicke, substing {{subst:div col}} would give <div class="mw-columns-2"> .. </div>. This would work fine for all subsequent edits with VE, but not for editors using wikitext.

Ideally list in {{div col}} blocks would be edited in place. Just as if it was a normal list. 

I think this points to a wider question: that some templates are going to need special ways of editing them. You might be able to add a field to the template data, say, "type":"wikitext-block" indicating its a block which should be edited in place. Some sort of extension mechanism could be used, say with an associated  lua module providing hints to VE on how to edit the data.
*** Bug 51485 has been marked as a duplicate of this bug. ***
We also need to be able to add the template {{tl|multiple issues}} around existing tags: when editing [[Dadloi]] I wanted to add a second maintenance tag and then tidy them up into {{tl|mi}}, but of course had to do the latter in Edit Source after my VE edit.
**kwwilliams** wrote:

I'm seeing a few comments that imply that nested templates are somehow the result of a poorly thought out design: I take issue with that. Take {{BillboardURLbyName}}, for example: it's got a very simple job: give it the name of a musical artist, and it will return the URL to the Billboard page for that artist's charts or biography. Billboard loves to redesign its site periodically and builds the URL based on six digit numbers, so we really don't want URL hardcoding going on. 

It would be a very poor design if we required every template that could accept a URL to understand how to translate an artist name into a URL. It's much better to do it the way we do: pass {{BillboardURLbyName|artist name}} as an argument to templates that require URLs, and let each template do its own job.
Adding keywords to summary to make this searchable.

As noted in bug 50595, this bug prevents copy-pasting formatted text from the main document into a template.
*** Bug 50595 has been marked as a duplicate of this bug. ***
Something like <div class="mw-columns-2"> .. </div> with the proper class definition in common.css would work better for editing in VE, as the wrapper won't be template-generated then.

Generally visual editing works best if a template produces a self-contained part of a page ('properly nested') rather than cut-up start / content / end templates.
This bug affects all attempts to edit items in lists which are set out in columns using {{tl|div col}} or {{tl|colbegin}}, so is going to disconcert a lot of editors. I hope it's near the top of the "to-do list":  see [[Wikipedia:VisualEditor/Feedback#Editing_within_a_multi-column_list_.28ie_between_.7B.7Bcolbegin.7D.7D_and_.7B.7Bcolend.7D.7D.29]]
*** Bug 50355 has been marked as a duplicate of this bug. ***
These are currently supported, just as wikitext. :-)

It depends on some changes in Parsoid (which they've put on ice during deployment), and some tweaks in VisualEditor, but this should be relatively do-able.
See https://en.wikipedia.org/wiki/Template:Userspace draft - when rendered in the VE it displays the mainspace appropriate text regardless of what namespace it is in.

--------------------------
**Version**: unspecified
**Severity**: minor
I think this was resolved in Gerrit change 127388
Is this fixed?

When I look at this page which uses [[template:userspace draft]]:

https://en.wikipedia.org/wiki/User:JohnArmagh/Heads_of_Government_of_the_State_of_Victoria,_Australia?veaction=edit

The appropriate message is shown.

However part of that box should render as
"This draft was last edited 13 months ago"
but in VE is renders as
This draft was last edited 1 second's time"

which means {{REVISIONTIMESTAMP}} isnt expanding correctly as, based on the future tense, it is giving a value that is CURRENTTIME+1..?
*** Bug 50582 has been marked as a duplicate of this bug. ***
This was originally about the Parsoid issue, which is now fixed, but re-purposing to be about the DM re-render to PHP parser issue.
I'm guessing this is actually about newly inserted {{NAMESPACE}} calls:

http://www.mediawiki.org/wiki/User:GWicke/TestNamespace?veaction=edit

Reassigning to VE.
We pass in the title to the PHP preprocessor, so namespace-dependent parserfunctions should work as expected. Are you talking about Parsoid rendering or the VE's preview rendering after inserting a new template?
By the time we get the template, the evaluation of the parser functions - in this case, {{NAMESPACE}} - has already been done (by Parsoid). In general, I believe that most parser functions are just "return true" at this point, and will be coming in future.
In the Reference editor we have two fields:

"Re-use by this name"
"Use this group"

These names are useless for new editors (too cryptic and unclear - what is "re-use"? a verb? referring to what?) and also unhelpful for established users (they need to know that these are totally identical to the name="" and group="" attributes). It is also not clear that they are only occasionally needed.

Something simpler, like "Reference name (optional)" and "Reference group (optional)" could be better. 

Same in the Reference list editor:

"Use this group" -> "Display references belonging to this group (optional)"

--------------------------
**Version**: unspecified
**Severity**: enhancement
(In reply to comment #1)
> There is also a request in that discussion about whether "Transclusion" could
> be renamed to something in plain English, like "Templates".

The problem is that they aren't just templates - there are also magic words and parser functions as well, like Wikidata invocations or other oddities that MediaWiki supports. Lumping them all in as templates makes things much harder to explain in documentation.
There is also a request in that discussion about whether "Transclusion" could be renamed to something in plain English, like "Templates".
Planned features, such as searching for an existing reference by content, will require us to implement some http://en.wikipedia.org/wiki/Unicode_equivalence .

We will probably want to use NFKD ("Characters are decomposed by compatibility, and multiple combining characters are arranged in a specific order.") to catch cases such as 'ﬀ' === 'ff', and we will probably want to strip combining characters (i.e. all accents), so that 'Amelie' === 'Amélie'.

https://github.com/walling/unorm looks like a good library for the job. We may want to fork it into UnicodeJS.

--------------------------
**Version**: unspecified
**Severity**: enhancement
So, if I'm understanding correctly, when the user starts a search we want to generate a normalised copy of the entire document in NFKD. (Otherwise we've got a problem keeping two copies in sync). Is this acceptable efficiency-wise?

Could we force the characters in the document model to be in NFC? Could Parsoid provide the article text in NFC? (This is partially off-topic, but we probably want to consider different normalisation issues together).
Agreed. You're likely to do that naturally when displaying search results but it would be a consideration if you try to highlight the matching substring in the result (a non-trivial problem when normalisation is involved)
It's worth noting that in most software, many common grapheme clusters are displayed more correctly when encoded as a single unicode character than when encoded with combining characters. For example, 'sgrîn' ("sgr\u00EEn") displays correctly in my version of Firefox on Linux, but the equivalent decomposed string 'sgrîn' ("sgri\u0302n") shows up with the dot still on the i and the accent in the wrong place (either uncentered over the i, or over the n, depending on the font).

Therefore, while we may want to search and process text using decomposed forms, we should probably use the composed forms for display.
I don't see why not. We may want to add things like 'ß' => 'ss' in German, or final vs. non-final sigma in Greek (https://en.wikipedia.org/wiki/Sigma#Character_Encodings)
We probably shouldn't strip down beyond NFKD. For some languages, 'ä' should be equivalent to 'a'; for others, it shouldn't be equivalent to anything; for still others, it should be equivalent to 'ae'.

Will it be feasible to implement language-specific search on top of this?
See https://en.wikipedia.org/w/index.php?title=User:JohnCD/VEtest&diff=prev&oldid=561397375 - the header is de-headered, and a spurious nowiki tag added.

--------------------------
**Version**: unspecified
**Severity**: normal
It doesn't really matter if the header is the first one, and also happens when the entire section is selected.
*** Bug 54728 has been marked as a duplicate of this bug. ***
Can't reproduce the last heading nowiki-ing, but the first of a document appears to be unable to copy with formatting.
See https://en.wikipedia.org/wiki/Chloroplast?veaction=edit for example.

--------------------------
**Version**: unspecified
**Severity**: normal
Gerrit 70336 is a quick hack to fix this in VisualEditor. Parsoid bug for a proper fix (longer-term) is bug 50142.
https://gerrit.wikimedia.org/r/70336 (Gerrit Change I24491979bc7a27d2380924e48cb677b01e9f8f9b) | change APPROVED and MERGED [by jenkins-bot]
Related URL: https://gerrit.wikimedia.org/r/70336 (Gerrit Change I24491979bc7a27d2380924e48cb677b01e9f8f9b)
It looks like this is [[File:…|right|«alt text»]] is getting wrongly interpreted by Parsoid as a thumb image as opposed to a block image (which doesn't have a caption):

[[File:{{Remove file prefix|{{{1|{{{image<noinclude>|Example.svg</noinclude>}}}}}}}}|right|{{Str number/trim|{{{3|{{{width|250px}}}}}}}}px|{{{2|{{{caption<noinclude>|Caption goes here.</noinclude>}}}}}}]]

->

<figure class="mw-halign-right" typeof="mw:Image" data-parsoid="…">
  <a href="./File:Chloroplast_II.svg" data-parsoid="…"><img resource="./File:Chloroplast_II.svg" src="…" height="344" width="360" data-parsoid="…"></a>
  <figcaption class="mw-figcaption" data-parsoid="{}">Structure of a typical higher-plant chloroplast</figcaption>
</figure>

(The <figcaption> shouldn't be set, and also there should be an alt="" set.)
First image, top right; I suspect stupidity in the {{Plain image}} template.
(In reply to comment #0)
> See https://en.wikipedia.org/wiki/Chloroplast?veaction=edit for example.

Can you say where? There's 27 images on that page and 15 of them are non-captioned images, but I don't see the alt-text coming through for them.
https://en.wikipedia.org/w/index.php?title=AES11&diff=prev&oldid=561340674

--------------------------
**Version**: unspecified
**Severity**: normal
**See Also**:
{T57769}
{T61647}
Split that into {T96395} as it's mobile-specific.
It looks like this is still happening: https://en.wikipedia.org/w/index.php?diff=655361654
Indeed.
If I understand correctly, the fix was deployed as part of version 1.25wmf23, which hasn't arrived to Wikipedias yet. It'll be deployed there tomorrow (April 1).
See [[https://tt.wikipedia.org/w/index.php?title=%D0%9F%D1%81%D0%BA%D0%BE%D0%B2_%D3%A9%D0%BB%D0%BA%D3%99%D1%81%D0%B5&diff=prev&oldid=2056059|here]] though?
The same fix as for T51452 - verified in beta.
Change 162310 merged by jenkins-bot:
For empty / whitespace-only headings, output <p> instead of <h#>

[[https://gerrit.wikimedia.org/r/162310]]
Change 162310 had a related patch set uploaded (by Jforrester):
MWHeading: Don't put self in output if contents are blank or whitespace

[[https://gerrit.wikimedia.org/r/162310]]

#patch-for-review
Change 162310 had a related patch set uploaded by Jforrester:
MWHeading: Don't put self in output if contents are blank or whitespace

https://gerrit.wikimedia.org/r/162310
en.wp user 28bytes comments:
There was an unneeded section, so I selected the section, pressed "delete" and saved. VE did this [1]; I expected it to do this. [2]

1: https://en.wikipedia.org/w/index.php?title=Degeneracy&diff=prev&oldid=569795975
2: https://en.wikipedia.org/w/index.php?title=Degeneracy&diff=569796007&oldid=567105149
This editor http://en.wikipedia.org/w/index.php?title=Pound_%28mass%29&diff=569770089&oldid=569255959 removed the whole section.  It could not possibly have been their intention to leave behind an empty heading line.
<< Often, when an editor tries to remove (or accidentally removes) a section header, the result in VE is something like this: http://en.wikipedia.org/w/index.php?title=%C3%87ank%C4%B1r%C4%B1_Province&diff=567375871&oldid=542107518 . This is seldom (if ever) the intention, can VE be coded to simply remove the section header in these cases? Fram (talk) 09:32, 6 August 2013 (UTC) >>
Since 51829 is now marked as a dupe, 
should we also discuss here an issue that Dan reported as well - VE turning the next paragraph into a heading,
or that "when pressing delete on an empty heading line, if there is a template such as {{main}} on the next line, it is unexpectedly deleted", as user:WS states on enwp?
Speaking as an end-user, I spent quite some time trying to figure out how to delete a heading. It was quite confusing. Bug 51829 (marked as a duplicate) describes my attempts.

VE's behavior in this regard is the opposite of (say) MS Word's.  In Word, if you highlight one character beyond the heading and press Delete, you remove the heading. In VE, you have to highlight an invisible area *preceding* the heading. This is not intuitive.
*** Bug 51829 has been marked as a duplicate of this bug. ***
"Encourage" yes...
(In reply to comment #3)
> I'm not sure we should be deleting empty headings. The user may want to
> delete all the contents of a heading and replace it (or select-all then type,
> which would perform the same operations internally).

Oh, yes, this was meant to be on save, rather than as they edit.

> Perhaps a solution would be for Parsoid to strip empty blocks (provided they
> weren't that way to begin with)?

That could also work, but feels a bit clunky; I think Parsoid should expect users to send it the HTML they actually want saved, and that it's up to clients to encourage users to indeed create such HTML.
Or we have a system for flagging up formatting irregularities (e.g. markers in the margin), which could also flag up other violations of formatting conventions (e.g. double linebreaks).
I'm not sure we should be deleting empty headings. The user may want to delete all the contents of a heading and replace it (or select-all then type, which would perform the same operations internally).

More generally we don't delete paragraphs when they are empty, unless the user presses backspace again, so doing so for just headings would be a confusing user experience.

Perhaps a solution would be for Parsoid to strip empty blocks (provided they weren't that way to begin with)?
%%%*** Bug 51417 has been marked as a duplicate of this bug. ***%%%
*** Bug 50313 has been marked as a duplicate of this bug. ***
Some experienced editors are complaining that writing in VE is slower for them now, because they have to use the toolbar. They are requesting to be able to use wikicode from within the VE.

Instead of fully introducing wikicode into the edit mode as some people have requested, I have a different idea. What if we use [[ and {{ as hotkeys to open the insert link and insert template dialogs ? When detecting this combination, the editor could automatically remove this characters from the editsurface and present the dialog to the user. Then the user can keep typing, greatly speeding up the time to author a sentence.

These are by far the most used insertions I presume. File and external links are much less common, and I don't see how you could easily have a hotkey like supo

I think that would solve much of the concerns that have been mentioned.

--------------------------
**Version**: unspecified
**Severity**: enhancement
'[[' triggers Link insertion; '{{' - inserts Template.

Verified in beta/test2/production
ZOMG!
Change 175910 merged by jenkins-bot:
Provide '[[' and '{{' to trigger the appropriate window open actions

[[https://gerrit.wikimedia.org/r/175910]]
Change 175910 had a related patch set uploaded (by Jforrester):
Provide '[[' and '{{' to trigger the appropriate window open actions

[[https://gerrit.wikimedia.org/r/175910]]

#patch-for-review
This is no longer catastrophically expensive to do. Yay.
I think in general this is a bad idea to do inside VisualEditor, as Brion's comments expand quite nicely. Consequently, I'm marking this as a WONTFIX.

However, yes, of course communities should feel free to write a gadget to do such a thing if you think helpful - but working with us to make VisualEditor better (rather than adding hacks) sounds like a better use of people's time.
Typing in the VE should .... just type. "Markup" that gets input should just be treated as text, just like when we type "<gallery>" into a Bugzilla bug title and expect it to say "<gallery>" on the other side.

Of course a gadget that listens for "[[" and triggers the dialog might be spiffy for power users who just like brackets :), but I wouldn't recommend building it in.
I think this is a wider issue of how the VE treats people trying to put markup in.
It's not required for new users to use the toolbar.  In VE, there is a concept of  hotkeys.  For creating a link use command+k (mac) or control+k (pc)
Compare the number of columns in https://en.wikipedia.org/wiki/Kartik_Poornima in read and VEdit mode.

--------------------------
**Version**: unspecified
**Severity**: minor
This was probably fixed by the suite of changes in CE's munging of CSS two weeks ago.
Me neither.
https://en.wikipedia.org/wiki/Kartik_Poornima?veaction=edit
https://en.wikipedia.org/wiki/Kartik_Poornima?action=edit&preview=yes
Can't reproduce (not anymore at least). Can you?
Screenshot

See screenshot.

--------------------------
**Version**: unspecified
**Severity**: minor
**See Also**:
https://bugzilla.wikimedia.org/show_bug.cgi?id=49818

**Attached**: {F11448}
*** Bug 49768 has been marked as a duplicate of this bug. ***
%%%*** This bug has been marked as a duplicate of bug 49818 ***%%%
See screenshot; problem with the template or with the parsing of it?

--------------------------
**Version**: unspecified
**Severity**: normal
This turned out to be a problem with the template which we fixed by editing said template. See bug 44452 for more details.

*** This bug has been marked as a duplicate of bug 44452 ***
(In reply to comment #3)
> Try https://en.wikipedia.org/wiki/Riddler#Fictional_character_biography

Seems to be a problem with {{unreferenced section}}; {{unreferenced|section}} works just fine. Can't work out why, though.
Try https://en.wikipedia.org/wiki/Riddler#Fictional_character_biography
I can't reproduce this - what page did it appear on (or was it all of them?).

Example URLs that work for me:

https://en.wikipedia.org/wiki/4th_Cinemalaya_Independent_Film_Festival?veaction=edit (page)

https://en.wikipedia.org/wiki/User:Jdforrester_(WMF)/Sandbox?veaction=edit (section)
Screenshot

Moron features forgot to attach the screenshot.

...he has now remembered to attach the screenshot.

Have a screenshot.

**Attached**: {F11438}
...and quite dramatically - take a look at https://en.wikipedia.org/w/index.php?title=Modified_discrete_cosine_transform&diff=561051085&oldid=558725133

--------------------------
**Version**: unspecified
**Severity**: normal
**See Also**:
T50830
(In reply to comment #0)
> ...and quite dramatically - take a look at
> https://en.wikipedia.org/w/index.
> php?title=Modified_discrete_cosine_transform&diff=561051085&oldid=558725133

Eurgh. I hate being proven wrong; each of those changes fixes the (entirely-broken, but masked for users by MediaWiki) wikitext; these are the kinds of errors it's not really possible for us to re-implement.

Specifically, <i>Foo <sup>Bar</i> Baz</sup> is definitely broken HTML (mis-nested annotations), and I don't think it's necessarily a bad thing that we fix these. Obviously it'd be much better if we had a bot do a massive run over the corpus and fix these for users now, rather than have them blame VE, but that's not going to happen. :-(

Punting to Roan for thoughts, but I think this is probably a lost cause.

(In reply to comment #1)
> Brad also has a suggestion (along with a bug report) for a workflow to make
> these easier to identify:

That's going to be done in VisualEditor as part of bug 49761 (well, not that way, because VE can't objectively know what bits of the DOM it "should" have just altered unless we have a local copy of MediaWiki :-)) but yes, coming very soon, hopefully.
Brad also has a suggestion (along with a bug report) for a workflow to make these easier to identify:

"One way to catch this for debugging purposes would be for the VisualEditor to make a note at tuntime of which sections of the article have been edited visually, for the JS code to report this to the server at save time, and then to check on the server side which sections of the article have changed in the wikitext diff. If (a) the section structure of the article remains unchanged from before the edit, and (b) there are wikitext differences in sections that have not been changed by the editor in visual mode, then something's clearly gone wrong, and the edit session should be auto-reported to the programming team. (Please don't try to use this idea as an error concealment technique: these errors shouldn't occur, as every one of them reveals some sort of bug, either in the code or the data model, and hiding them would make the software more, rather than less brittle.)"
The main reason for this still being true was screen-scraping bots (together with $wgHtml5).

For some reason when $wgHtml5 was finally enabled we forgot to also get rid of wgWellFormedXml=true.

We should disable it by default for the same reason we now enable wgHtml5 by default.

This is mainly bugging because of the "&&" sign we have as of recently in the default html output, which, due to wgWellFormedXml, causes an ugly CDATA section.

--------------------------
**Version**: 1.22.0
**Severity**: normal
Change 70036 abandoned by Krinkle:
Set $wgWellFormedXml to false by default

Reason:
Agreed, per bug.

https://gerrit.wikimedia.org/r/70036
I note btw that the tidy config is also set to produce XHTML.
I've decided that I don't think this should be done, now or in the future. I think the general idea behind HTML's original SGML -> XML migration, i.e. to make parsers easier to write at the expense of brevity, continues to be sound and useful. The benefits of a reversion to SGML are small, and the costs can be expected to mirror bug 52253.
(In reply to comment #2)
> You could just use <script>if(jQuery)jQuery.ready()</script>, it would be
> shorter than what you have currently: <script>window.jQuery &&
> jQuery.ready();</script>

<script>if(window.jQuery)jQuery.ready()</script>, rather. The "window." is important here, as we want to keep going even if jQuery is not loaded and thus its variable is not defined.
Related URL: https://gerrit.wikimedia.org/r/70036 (Gerrit Change I4155c74042d22527dc5c9460a4af8b7b1adb36cc)
Self-explanatory, albeit poorly worded; if you type something out in the edit summary box, and then click on a point in that text to move your typing cursor....no luck. This is going to be a total pain for things as simple as tyop corrections.

--------------------------
**Version**: unspecified
**Severity**: normal
Fixed and deployed; sorry for this.
A fix to bug 49927 might also fix this.
From [[Wikipedia:VisualEditor/Feedback#Editing_Defaultsort]]:

> The Page Settings box displays the article title as a default "Defaultsort". But it doesn't seem possible to edit it: typing any letters removes the whole existing text, while trying to delete a few characters has no effect. Where the sort key is not identical to the article title it's usually a variation of it - delete a leading "The ", or move the given name from start to end. It's a waste to have to retype it all: we ought to be able to edit that box.
> 
> This is because the default defaultsort value (article title) is implemented as "placeholder" text. Instead, it should be normal editable text.
> 
> Upon closing the page settings dialog, the logic should be, "if defaultsort != article title, add a {{DEFAULTSORT:}} magic word, else remove existing {{DEFAULTSORT:}} if present".
(In reply to pamdavies7 from comment #3)
> Thanks for the explanation! So it remains a bug - and distinctly irritating,
> for someone who adds a lot of DEFAULTSORTs to articles. 
> 
> That said, I suppose it doesn't actually create any more work for the editor
> than adding the DEFAULTSORT in the old edit system: the value would always
> have had to be typed in from scratch.

But in the old system one could copy and paste the title from some part of the record, edit as needed (move "The" to end, replace an accented letter by plain), highlight, click on "DEFAULTSORT" from the editing menu below the edit box, and that was that. Having to retype is more work; having to retype when you can't see the original to copy from is sometimes impossible.
*** Bug 69568 has been marked as a duplicate of this bug. ***
What if the article "Abc" has a DEFAULTSORT set to "Alphabet", but is then renamed to "Alphabet", making the DEFAULTSORT and article title the same. Then someone opens the category editor, upon save we see that DEFAULTSORT and the article title are the same and remove it. Now you have a dirty diff.

So, we see that separating the default value of the actual value is... well, valuable.

The UX issue is that we force the user to start from scratch when editing the field. The real cause of all this is that we are using the value of text input widget to not only detect a change, but also whether to set or not.

We may consider doing something else, like having a tick to explicitly override the sorting key, and separately have a text input widget which, as requested, is populated with the default or current value.

There are a few things I'm not happy with here, however.

* What happens when DEFAULTSORT is set to empty string?
* It feels like we are adding too much complexity
* If the user unticks override, does the text input widget's value get set to the deafult value, or just get grayed out (either has it's downfalls)
Thanks for the explanation! So it remains a bug - and distinctly irritating, for someone who adds a lot of DEFAULTSORTs to articles. 

That said, I suppose it doesn't actually create any more work for the editor than adding the DEFAULTSORT in the old edit system: the value would always have had to be typed in from scratch.
(In reply to comment #1)
> This seemed yesterday to be fixed (I managed to edit the DEFAULTSORT of [[The
> New Elizabethans]] by removing "The " and retyping it at the end), but today
> - both this morning and just now - the problem is still/again there: to edit
> the DEFAULTSORT of [[Alexander Gilkes]] I had to retype it all.

We've not touched this code in the past two weeks; what you saw was the effect of someone setting the DEFAULTSORT actively to "The New Elizabethans" - see the diff on your edit: https://en.wikipedia.org/w/index.php?title=The_New_Elizabethans&diff=562509771&oldid=562443570
This seemed yesterday to be fixed (I managed to edit the DEFAULTSORT of [[The New Elizabethans]] by removing "The " and retyping it at the end), but today - both this morning and just now - the problem is still/again there: to edit the DEFAULTSORT of [[Alexander Gilkes]] I had to retype it all. ~~~~
More general bug, following on from bug 41150 - this is for text selections, for other generated content blocks, ? others.

--------------------------
**Version**: unspecified
**Severity**: enhancement
**See Also**:
https://bugzilla.wikimedia.org/show_bug.cgi?id=50643
Change 140103 merged by jenkins-bot:
Drag and drop of arbitrary selections

https://gerrit.wikimedia.org/r/140103
Change 140103 had a related patch set uploaded by Esanders:
Drag and drop of arbitrary selections

https://gerrit.wikimedia.org/r/140103
*** Bug 49486 has been marked as a duplicate of this bug. ***
fwiw I believe this bug has been mentioned at https://en.wikipedia.org/wiki/Wikipedia:Village_pump_%28technical%29#VisualEditor_weekly_update_-_2013-09-26_.28MW_1.22wmf19.29 - being the doubt whether reflists can be now dragged or not.
As an update, if you select a reference or non-floated template you can now move these too; however, floated templates and text can't be moved with drag-and-drop yet.
*** Bug 52364 has been marked as a duplicate of this bug. ***
*** Bug 50359 has been marked as a duplicate of this bug. ***
Adding a link to https://bugzilla.wikimedia.org/show_bug.cgi?id=50359 which is related.
*** Bug 50183 has been marked as a duplicate of this bug. ***
--------------------------
**Version**: unspecified
**Severity**: minor
Fixed and being deployed right now.
Related URL: https://gerrit.wikimedia.org/r/70614 (Gerrit Change I8cc12ba7845eebc6199fbcd2d355bf0d5f38264b)
Ignore that, the selection is still working after Roan rolled back newFromDocumentInsertion, but scroll is still a problem.
This is a regression because I fixed dialog close re-focusing.
See https://en.wikipedia.org/wiki/Virivilai for example - bug with the VE or bug with the template?

--------------------------
**Version**: unspecified
**Severity**: normal
We've fixed this, somehow, since it was filed; sorry for not being able to be more precise as to whether the fix was in Parsoid or VisualEditor (it definitely wasn't the template, as that's not been changed in > a month).
The VisualEditor isn't perfectly rendering markup yet (which is understandable), and even when it does it'll look slightly different from read mode in a lot of ways. The problem is that cancelling the VE editing interface, or saving, loads a VE-rendered article view rather than what the article actually looks like.

(sorry if this sounds nonsensical; it's difficult to explain at this end).

--------------------------
**Version**: unspecified
**Severity**: normal
I believe all of the changes for this has been merged and fixed some months ago; please correct if there are still issues.
The example given at the enwiki feedback page was [[scaphoid fracture]]. Observe the spacing of infobox content, then enter and leave VE mode and notice the alteration.
If I try to edit a number in a {{formatnum:…}}, the VisualEditor displays the template’s edition window, saying it is (for example) the 'formatnum:959719' template, without any parameter. So if I want to change the number, I need to remove the 'template' and then to add a new one, for example 'formatnum:958719'.

The editor should allow changing the number without having to remove the 'template'.
>>! In T51954#3388374, @Danmichaelo wrote:
> Was hit by this limitation when I was editing an article now. Couldn't find any way to edit the number except to delete it, so I changed the title to reflect that.

Thanks for the input, but please don't make bugs less general. You can add further examples of how they affect you, but that should be as a comment or in the description, not removing other things that are already covered by this task. For instance, this also applies to the `#dateformat`, `lc`, and `int` transclusion objects.
Was hit by this limitation when I was editing an article now. Couldn't find any way to edit the number except to delete it, so I changed the title to reflect that.
"{{formatnum:…}} is not a template" - true

For this, Parsoid takes wikitext like:

  This was {{formatnum:1234567890}} years ago.

… and gives us HTML of:

<p data-parsoid="…">This was <span about="#mwt1" typeof="mw:Transclusion" data-mw="{'target':{'wt':'formatnum:1234567890','function':'formatnum'}" data-parsoid="…">1,234,567,890</span> years ago.</p>

… so maybe we'd want to special-case on 'function':'formatnum' so that they're easier to edit?
The browser window title is changed to "Parse error at position 0 in input {{"}}{{{1|$1}}}{{"}}" when editing an article with the VisualEditor on dewp. Reproducible in many articles and at least Firefox and Chromium.
(If they're wontfix, then let's decline them.)
This and T95711 are wontfix. These localisation messages should not use parser functions. This was never intentionally supported and whatever localisation needs exist in German that need this should be filed as a separate task against MediaWiki core to find a way to support that.

Complex parser functions will not be supported in this interface message.
(No "Parse error at position 0" since T54479 was fixed.)
This is still a problem, currently only visible when creating a new page because https://de.wikipedia.org/w/index.php?title=MediaWiki:Editing&action=edit no longer has the templates, but https://de.wikipedia.org/w/index.php?title=MediaWiki:Creating&action=edit still does. T95711 is the same bug for MediaWiki's live preview feature.
This is still an issue. I've restored MediaWiki:Editing on testwiki for demonstration purposes.

Krinkle has stated "Don't use wikitext in this message" (MediaWiki:Editing), but he didn't give a reason. Since parser functions, etc. work fine in this message in MediaWiki core, I think we should expect VE to handle them too, or else it should use a different message that specifically does not support fancy stuff.
This seems solved now on dewp. Good to close from my side.
This seems to be caused by the templates in [[de:MediaWiki:Editing]]. 

Can be seen on testwiki as well, where parser functions are the cause ([[testwiki:MediaWiki:Editing]]).
Steps to reproduce:
1. open article in browser window
2. open same article in another browser window, edit, save changes
3. edit with VE in first window

Expected result: VE show some sort of warning, and loads the newest version of the article (or maybe refuses to edit it at all).

Actual result: VE happily edits the old revision, and shows [[MediaWiki:Editingold]].

--------------------------
**Version**: unspecified
**Severity**: minor
This is now deployed and appears to be working as expected in production, according to my testing. Marking as fixed. Please re-open if you find otherwise.
Change 72070 merged by jenkins-bot:
mw.ViewPageTarget: Fix incorrect retention of the wrong oldid

https://gerrit.wikimedia.org/r/72070
Change 72070 had a related patch set uploaded by Krinkle:
mw.ViewPageTarget: Fix incorrect retention of the wrong oldid

https://gerrit.wikimedia.org/r/72070
See, for example, the lead of https://en.wikipedia.org/wiki/Flaming_Pie in the VisualEditor.

--------------------------
**Version**: unspecified
**Severity**: normal
Verified that [[Flaming Pie]], [[Dictionary]], [[Moon]], [[Metallica_(album)]], and [[User:Kww/italictest3]] are rendered correctly in the deployed Parsoid/Visual Editor. Closing as fixed.
Change 79925 merged by jenkins-bot:
Tweak QuoteTransformer to more closely match PHP doQuotes.

https://gerrit.wikimedia.org/r/79925
Change 79925 had a related patch set uploaded by Cscott:
WIP: Tweak QuoteTransformer to more closely match PHP doQuotes.

https://gerrit.wikimedia.org/r/79925
Change 79343 merged by jenkins-bot:
Add parserTests for the interaction of italics and possessives.

https://gerrit.wikimedia.org/r/79343
Change 79343 had a related patch set uploaded by Cscott:
Add parserTests for the interaction of italics and possessives.

https://gerrit.wikimedia.org/r/79343
*** Bug 52254 has been marked as a duplicate of this bug. ***
See also bug 47326.
Just dropping this in for cross-referencing: bug 13227 (this bug made me remember that one).
Taking this one, on subbu's suggestion.
This is still appearing, this time in https://en.wikipedia.org/w/index.php?title=Dictionary&oldid=563086179&veaction=edit - start at " Sebastián Covarrubias"
e.g. I don't want to see this:

.ve-ui-mwReferenceDialog-body {
  padding: 2em;
}

and have to apply that to each dialog that doesn't have panels.

--------------------------
**Version**: unspecified
**Severity**: enhancement
--------------------------
**Version**: unspecified
**Severity**: enhancement
Change 155091 merged by jenkins-bot:
Rename "reference list" to "references list" internally

https://gerrit.wikimedia.org/r/155091
Change 155091 had a related patch set uploaded by Jforrester:
Rename "reference list" to "references list" internally

https://gerrit.wikimedia.org/r/155091
The beta cluster rely on the super project mediawiki/extensions.git to deploy extensions automatically.  Sometime an extension would be misconfigured, a recent example is VisualEditor which got stuck for a few weeks to an old version (bug 49846).

It would be nice to run a SQL query daily that would mail gerritadmin about any misconfiguration.

--------------------------
**Version**: wmf-deployment
**Severity**: enhancement
I have filled that bug to monitor mediawiki/extensions.git being badly configured (for bug 49846).  Instead of using Gerrit maintained mediawiki/extensions.git, I will write a script that list all extensions, register them on beta and then do the submodule update.
(In reply to comment #6)
> So now "all" that is needed is to have this in a cronjob that mails the
> output to...?

I have no clue where it could be send. Nor do I have any idea where such a script should be run.

Possibly, we could run it once a few times per day as a Jenkins job and make that job alert back on IRC and/or to the Gerrit admin mail alias.
(In reply to comment #7)
> Greg: Was that a question to hashar?

Yeah, rhetorical mostly, but he's the one that can answer it ;)
Greg: Was that a question to hashar?
So now "all" that is needed is to have this in a cronjob that mails the output to...?
https://gerrit.wikimedia.org/r/#/c/70836/ adds a script to verify the extensions syncronization.
A slightly better version being run on mediawiki/extensions.git at d0680b9


$ git submodule --quiet foreach 'test "$(git rev-list HEAD..origin/master --count)" = "0" || echo "ERROR! $path is lagging behind."'ERROR! AutoCreateCategoryPages is lagging behind.
ERROR! Bootstrap is lagging behind.
ERROR! Campaigns is lagging behind.
ERROR! CirrusSearch is lagging behind.
ERROR! CommunityTwitter is lagging behind.
ERROR! CoreEvents is lagging behind.
ERROR! EImage is lagging behind.
ERROR! JsonData is lagging behind.
ERROR! Less is lagging behind.
ERROR! OpenStreetMapSlippyMap is lagging behind.
ERROR! PerPageLicense is lagging behind.
ERROR! QuickResponse is lagging behind.
ERROR! TimelineTable is lagging behind.
ERROR! VisualEditor is lagging behind.
ERROR! WikibaseDataModel is lagging behind.
ERROR! WikibaseQueryEngine is lagging behind.
$
So to find out what is not up to date:

Fetch the extensions:

 git clone https://gerrit.wikimedia.org/r/p/mediawiki/extensions.git 
 cd extensions
 git submodule update --init

Then for each submodules look at the number of commits between HEAD (the currently checked out version locally) and origin/master (the version in gerrit):

 git submodule foreach 'test "$(git rev-list HEAD..origin/master --count)" = "0"  && echo "Up to date." || echo "ERROR!"'

Gives out something like:

 ...
 Entering 'AuthorProtect'
 Up to date.
 Entering 'AutoCreateCategoryPages'
 ERROR!

That extension is indeed lagging:

hashar:~/extensions/AutoCreateCategoryPages$ git log --oneline --decorate  --all -n4
14a097d (origin/master, origin/HEAD, master) Localisation updates from http://translatewiki.net.
981a381 (HEAD) Localisation updates from http://translatewiki.net.
e01f64e Add .gitreview and .gitignore
7ae6dd3 (origin/REL1_21) Localisation updates from http://translatewiki.net.
Campaigns not updating, bug 50261
Vector was not updated either, might have caused bug 49911
In edits like https://fr.wikipedia.org/w/index.php?diff=94100781 , the whitespaces between the equal sign of a template parameter and the value of that parameter are removed. This causes confusing diffs since the user didn't make that change.

--------------------------
**Version**: unspecified
**Severity**: normal
This has now been done in Parsoid.
That said, we are considering changing the default for edited templates where we normalize to a single space around the '=' sign.  This will still affect other templates where there was no space around them before, but in general, the change might be a better default.

This will still not fix the problem when HTML isn't preserved (either due to Parsoid or VE bugs) in its original form (as noted by Gabriel).  But, changing the default whitespace around '=' for template transclusions should make this look a little better.
If the user edited the transclusion, then normalization of spaces is to be expected, as remembering every purely syntactical variation would add way too much complexity and slow down processing.

If the user did not touch the transclusion, then you should not see any diff in the template. If you are still seeing a diff, then it is pretty likely that this is a VisualEditor issue. There were some issues in the preservation of HTML for templates when passed through VisualEditor, which can cause the template to appear edited when we get the HTML back.
1. Go to [[Ahab]] and edit in VE
2. Select the succession box at the bottom and edit with transclusion editor
3. Observe that "content" sections are present that look blank, but on closer inspection, contain only a newline

Some templates (like succession boxes) unfortunately need to be on separate lines in the wikitext :( But the current UI for this is non-obvious and could be made better.

--------------------------
**Version**: unspecified
**Severity**: enhancement
The work-around that Parsoid did to hide these means that these don't appear unless it's mis-matched, which is reasonable enough that I'm going to flag as WORKSFORME.
This is the exact wikitext that is interspersed between template calls, so follows our DOM spec (see http://www.mediawiki.org/wiki/Parsoid/MediaWiki_DOM_spec#Template_content). 

The decision whether that should be presented in the UI is one for the VisualEditor team to make. Non-whitespace content like '|-' for a new table row is probably important to show, while pure ws could also be hidden from view.
Yeah, this is a bit of a mess. We could get Parsoid to /always/ do a newline between templates of the same generated block, I suppose? Gabriel, thoughts?
Follow-on from bug 49596.

The insertion of a new image adds link=… whether or not it's been actively set away from the default.

Thus (in the example in bug 49596 comment 0) we get:

[[File:CV.03326.jpg|link=https://commons.wikimedia.org/wiki/File:CV.03326.jpg|right|framed|424x275px]]

… instead of:

[[File:CV.03326.jpg|right|framed|424x275px]]

… which is bad in terms of wikitext-user utility.

--------------------------
**Version**: unspecified
**Severity**: minor
Change 119087 merged by jenkins-bot:
Clarified the default link for image insertion.

https://gerrit.wikimedia.org/r/119087
Change 119087 had a related patch set uploaded by Cscott:
Clarified the default link for image insertion.

https://gerrit.wikimedia.org/r/119087
Clarified the spec: https://www.mediawiki.org/w/index.php?title=Parsoid%2FMediaWiki_DOM_spec&diff=931265&oldid=931084
I believe Parsoid's behavior is correct.
mooeypoo and I tried to reproduce without success.  the code looks correct: the link option is suppressed iff a[href] == img[resource].   Both of these should be local relative URLs, since the only way external images can be referenced is via instacommons (which provides local URLs for the image).
Ok, from looking at the code I can confirm that the link= attribute should be suppressed iff the img[resource] attribute is equal to the a[href].  I'm guessing that autocommons is screwing with this?
Hm, I note that the DOM spec describes "resource attribute on image" this way:

> link to image resource page. TODO: what to use for images from commons?

I'm guessing this is the root of the problem.  What is VE currently setting the resource attribute to, for images from commons?
Hm, maybe this only occurs with images from commons now?  Can you confirm that, James?  It would be helpful to see exactly what VE is giving to Parsoid for new images, and how you are indicating that the link is the default.
Still appears to be happening now that the workaround is removed:

http://en.wikipedia.beta.wmflabs.org/w/index.php?title=User:Whatamidoing_(WMF)/Sandbox&diff=81525&oldid=81245
This bug is fixed; opened bug 61560 for the VE team to revert their workaround hack.
This should be fixed by https://gerrit.wikimedia.org/r/103082 (if it wasn't already fixed).  Should be verified fixed by the VE team once this lands (and their local workaround reverted?).
I cannot reproduce this on latest master.

[subbu@earth lib] cat /tmp/img.html
<span typeof="mw:Image" ><a href="./File:VisualEditor-logo.svg"><img src="http://vewiki/MediaWiki/images/thumb/1/12/VisualEditor-logo.svg/300px-VisualEditor-logo.svg.png" resource="./File:VisualEditor-logo.svg" width="300" height="105"></a></span>
[subbu@earth lib] node parse --html2wt < /tmp/img.html
[[File:VisualEditor-logo.svg|300x300px]]
[Parsoid component reorg by merging JS/General and General. See bug 50685 for more information. Filter bugmail on this comment. parsoidreorg20130704]
This is worked around (albeit with potentially a bit of a hack) in VisualEditor, so not so important now from VisualEditor's POV.
*** Bug 49848 has been marked as a duplicate of this bug. ***
Related URL: https://gerrit.wikimedia.org/r/70551 (Gerrit Change I75dbbfdd248a6f5696252ef3a2d7ca6ede0fa156)
<span typeof="mw:Image" ><a href="./File:VisualEditor-logo.svg" data-parsoid="{'a':{'href':'./File:VisualEditor-logo.svg'}}"><img src="http://vewiki/MediaWiki/images/thumb/1/12/VisualEditor-logo.svg/300px-VisualEditor-logo.svg.png" resource="./File:VisualEditor-logo.svg" width="300" height="105"></a></span>

serialises to:

[[File:VisualEditor-logo.svg|300x105px]]

Whereas

<span typeof="mw:Image" ><a href="./File:VisualEditor-logo.svg"><img src="http://vewiki/MediaWiki/images/thumb/1/12/VisualEditor-logo.svg/300px-VisualEditor-logo.svg.png" resource="./File:VisualEditor-logo.svg" width="300" height="105"></a></span>

(removed data-parsoid from <a> tag)

serialises to:

[[File:VisualEditor-logo.svg|link=File:VisualEditor-logo.svg|300x105px]]
This looks like a Parsoid issue:
Template overall:
* Template panel should have a link to the template's definition page (if it's a real template)
* Template panel should have a link to the relevant MW Manual page (if it's a parser function)

Parameters:
* Label for parameter should use the "label" from TemplateData, not the wt name
* Label panel should use the "description" from TemplateData above the content box
* Label panel should indicate if a parameter is "mandatory" from TemplateData
* Label panel should show the "default" from TemplateData
* Label panel should indicate if a parameter is "deprecated" from TemplateData

Adding parameters:
* Template panel should show available unused parameters and way to add them
* Template panel should highlight available unused parameters that are mandatory
* Template panel should highlight available unused parameters that are in sets
* Insertion of a template with TemplateData should auto-insert the mandatory parameters

--------------------------
**Version**: unspecified
**Severity**: enhancement
**See Also**:
https://bugzilla.wikimedia.org/show_bug.cgi?id=52576
… of the remaining items, I've split them out into:

(In reply to comment #2)
> Template panel:
> * Link to the template page (if it's a transclusion from a MediaWiki page)
> * Link to the MediaWiki.org Manual (if it's a parser function)

Collectively https://bugzilla.wikimedia.org/show_bug.cgi?id=49772

> * Use "Param#required" data to prioritise/encourage use of those parameters

https://bugzilla.wikimedia.org/show_bug.cgi?id=50747

> * Use "Root#sets" data to allow addition and/or completion of parameter
> sets

https://bugzilla.wikimedia.org/show_bug.cgi?id=53609

> * Cursor keys can let you select parameters in the search results off the
> screen and the dialog doesn’t scroll

https://bugzilla.wikimedia.org/show_bug.cgi?id=53610

> * Checkbox (?) to substitute a template on save, rather than leave as
> transclusion 

https://bugzilla.wikimedia.org/show_bug.cgi?id=49904

> Parameter panel:
> * Use "Param#required" from TemplateData

https://bugzilla.wikimedia.org/show_bug.cgi?id=53611

> * Use "Param#default" from TemplateData

https://bugzilla.wikimedia.org/show_bug.cgi?id=52753

> * Use "Param#deprecated" from TemplateData

https://bugzilla.wikimedia.org/show_bug.cgi?id=53612

> * Use "Param#type" from TemplateData

https://bugzilla.wikimedia.org/show_bug.cgi?id=53613

So, closing as INVALID.
Have un-trackered-this;
UX items at this point:

| Template panel:
| * Move “add parameter” button to alongside the search field, not below the results list, so it can be found
| * Link to the template page (if it's a transclusion from a MediaWiki page)
| * Link to the MediaWiki.org Manual (if it's a parser function)
| * Use "Param#required" data to prioritise/encourage use of those parameters
| * Use "Root#sets" data to allow addition and/or completion of parameter sets
| * Auto-add required parameters when creating a new Template transclusion
| * Double-click on a parameter in the selection menu should insert it
| * Up/down keys work in the parameter search field results, but not left/right, even though it’s not just a vertical list
| * Cursor keys can let you select parameters in the search results off the screen and the dialog doesn’t scroll
| * When adding a template, auto-add all mandatory parameters
| * Checkbox (?) to substitute a template on save, rather than leave as transclusion 
| 
| Parameter panel:
| * Use "Param#required" from TemplateData
| * Use "Param#default" from TemplateData
| * Use "Param#deprecated" from TemplateData
| * Use "Param#type" from TemplateData
updated:

Template panel:
* Link to the template page (if it's a transclusion from a MediaWiki page)
* Link to the MediaWiki.org Manual (if it's a parser function)
* Use "Root#description" from TemplateData: Done.

Parameter panel:
* Use "Param#label" from TemplateData: Done.
* Use "Param#description" from TemplateData: Done.
* Use "Param#required" from TemplateData: TODO.
* Use "Param#default" from TemplateData: TODO.
* Use "Param#deprecated" from TemplateData: TODO.
* Use "Param#type" from TemplateData: TODO.

"Add parameter" panel:
* Show available (unused) parameters
* Use "Param#required" data to prioritise/encourage use of those parameters
* Use "Root#sets" data to allow addition and/or completion of parameter sets
* Creating a new Template transclusion should start with all required parameters auto-inserted (instead of requiring the user to add them one-by-one).
In these two edits made with VisualEditor, the infobox was duplicated on save and the duplicate was actually subst'd into the infobox's table:
https://fr.wikipedia.org/w/index.php?diff=94112508
https://fr.wikipedia.org/w/index.php?diff=94163787

The behavior seems to be inconsistent since in the first case, the duplicate was inserted right after the infobox, and in the second case, it was inserted after the first paragraph

--------------------------
**Version**: unspecified
**Severity**: major
We believe that these cases have now been fixed (though we may be wrong). Please re-open if so.
Another infobox duplicated while the editor is touching something else (not the infobox):

https://ca.wikipedia.org/w/index.php?title=Hurac%C3%A0_de_Cuba_de_1910&diff=11973992&oldid=11973843

Duplication of infoboxes is a big deal, very visible and annoying for editors that have to go and change back. Defining importance just in case this report was unnoticed, although of course this is a call for JamesF.  :)
Hidden templates, like Template:Use British English, are displaying as carriage returns. These are pretty easy to mistakenly identify as typos or errors and delete. We need a better way of displaying those within the VE, or (as a long-term goal) a better way of surfacing metadata, a la the "page settings" page.

--------------------------
**Version**: unspecified
**Severity**: enhancement
**See Also**:
https://bugzilla.wikimedia.org/show_bug.cgi?id=49603
https://bugzilla.wikimedia.org/show_bug.cgi?id=53659
There is a curious case of the template: https://test2.wikipedia.org/wiki/Template:No_spam  {{@}}. 
Inserting {{@}}  will display the icon, just as for the hidden template: 'Use British English'. 

Is it intentional?
After a page is Saved, and then switch to Edit mode - the icon for Hidden template is not displayed. Saw it in Chrome.
{F56750}?
Change 193975 merged by jenkins-bot:
Add an icon to hidden templates

[[https://gerrit.wikimedia.org/r/193975]]
We have a general "template" icon, adding @violetto to point to the right asset.
Change 193975 had a related patch set uploaded (by Mooeypoo):
Add an icon to hidden templates

[[https://gerrit.wikimedia.org/r/193975]]
*** Bug 72963 has been marked as a duplicate of this bug. ***
As an additional item (from bug 51978 comment 6):

> Using the {{כ}} template works correctly while editing articles, and the
> original test page https://he.wikipedia.org/wiki/User:Amire80/ve-rlm shows
> everything correctly.
>
> That said, there are issues with handling this template after it's inserted:
> * The bubble that shows its name appears in a wrong location.

This is related to this bug – the context seems to find the nearest thing that actually displays and attaches to that. When we display a place for the context to show, it will presumably show there. :-)
Hi James. Thanks for the explanation. Today I learned the word "slugs". To me they are sufficiently clear that those aren't white space but something different. Some vocal users on nl.wp portray slugs as "ugly white rows" and fear accidental deletion, the examples provided that would be images. I will continue discussion on bug 47790 and bug 55336 about accidental deletion of FocusableNodes. I've seen a live case in which slugs cannot be deleted. However the cases mentioned above can be.
(In reply to Ad Huikeshoven from comment #23)
> Ok to take the conversation there. I've read through bug 47790 and the
> reported issues are more or less the same. Bug 47790 is solved. What is the
> timeline of deployment?

It's already deployed.

It was deployed to MediaWiki.org on 6 March 2014 (see the "Milestone" field), so it would have reached the Dutch Wikipedia a week later, on 13 March 2014.

That's what I meant by "This feels like you don't think the resolution to bug 47790 in March was sufficient". :-)
Ok to take the conversation there. I've read through bug 47790 and the reported issues are more or less the same. Bug 47790 is solved. What is the timeline of deployment?
(In reply to Ad Huikeshoven from comment #21)
> On nl.wp a discussion has started to turn on VE. In the process feedback has
> been collected on VE. Some users commented on "white lines" as a blocking
> issue for turning VE on as default. 
> On top of pages like:
> * https://nl.wikipedia.org/wiki/Bali_%28eiland%29?veaction=edit
> * https://nl.wikipedia.org/wiki/Justine_Henin?veaction=edit
> * https://nl.wikipedia.org/wiki/Rijn?veaction=edit
> * https://nl.wikipedia.org/wiki/Brussels_Hoofdstedelijk_Gewest?veaction=edit
> * https://nl.wikipedia.org/wiki/Antwerpen_%28stad%29?veaction=edit
> as well as on other places on the page "white lines" or carriage returns
> appear in VE edit mode which do not appear in read mode. On mouse over the
> white line turns blue. 
> 
> Some users fear that newcomers others will delete those white lines and
> carriage returns. However, after deletion of those lines images are
> accidently deleted from the page.
> 
> (Deleting white space at the bottom of a page might also delete accidently
> categories and other metadata.)
> 
> How can I help to resolve this 'bug'?

This feels like you don't think the resolution to bug 47790 in March was sufficient; I'm not sure that this has anything to do with this bug, however. Take the conversation there?
On nl.wp a discussion has started to turn on VE. In the process feedback has been collected on VE. Some users commented on "white lines" as a blocking issue for turning VE on as default. 
On top of pages like:
* https://nl.wikipedia.org/wiki/Bali_%28eiland%29?veaction=edit
* https://nl.wikipedia.org/wiki/Justine_Henin?veaction=edit
* https://nl.wikipedia.org/wiki/Rijn?veaction=edit
* https://nl.wikipedia.org/wiki/Brussels_Hoofdstedelijk_Gewest?veaction=edit
* https://nl.wikipedia.org/wiki/Antwerpen_%28stad%29?veaction=edit
as well as on other places on the page "white lines" or carriage returns appear in VE edit mode which do not appear in read mode. On mouse over the white line turns blue. 

Some users fear that newcomers others will delete those white lines and carriage returns. However, after deletion of those lines images are accidently deleted from the page.

(Deleting white space at the bottom of a page might also delete accidently categories and other metadata.)

How can I help to resolve this 'bug'?
*** Bug 52551 has been marked as a duplicate of this bug. ***
*** Bug 60830 has been marked as a duplicate of this bug. ***
> > A work around for this allowing you to add and not delete stuff you've added
> > would be to make their removal undoable. Not ideal but better than nothing.
> 
> Though the problem is that you don't know you've removed them until you
> realise
> on saving the page that something you thought you'd added isn't there! A
> message like "removing invisible template: are you sure?" would be helpful.

Yes. Although reading comment 15 again I meant to say "make their addition undoable." (not removal). Sorry for the confusion.
*** Bug 52658 has been marked as a duplicate of this bug. ***
> 
> A work around for this allowing you to add and not delete stuff you've added
> would be to make their removal undoable. Not ideal but better than nothing.

Though the problem is that you don't know you've removed them until you realise on saving the page that something you thought you'd added isn't there! A message like "removing invisible template: are you sure?" would be helpful.
PamD at en.wp complains that:
"[When] I add invisible matter to an article (eg {{coord missing}}), it's too easy to delete it later in the same edit while "tidying up" blank lines etc."

Suggestions have been made above about how to deal with this in advance of working out how to display hidden templates, e.g. in comment 9. 

Alternatively invisible templates could just be declared not deletable in VE (i.e. just treat them like nowikis). It will occasionally leave unnecessary templates in but that is going to be far rarer than deleting them without meaning or even knowledge as happens now.

A work around for this allowing you to add and not delete stuff you've added would be to make their removal undoable. Not ideal but better than nothing.
Regarding the English language variable templates specifically, it would be great if these were handled by pushing it into a meta tag (bug 52166) and incorporate it into page settings.

Regarding top icons, there is a core enhancement for a pre-defined area for these icons (bug 23796), and a VE enhancement request to do the same (bug 51420).

Regarding others, a puzzle piece sounds like a great UI for it.  Or a custom icon defined in TemplateData?
*** Bug 51322 has been marked as a duplicate of this bug. ***
Whatever solution is here should also apply to templates that normally produce text but have been created empty for whatever reason. For example it is possible to add a {{small}} template with no text to display.
FYI: I count 3 reports in the last 10 posts on WP:VP/T today related to accidental 'hidden' or 'floating' templates deletion.
*** Bug 49633 has been marked as a duplicate of this bug. ***
Why not allowing deletion of a template by keyboard only if the template is selected, not just if the cursor if just before or after the template ?
I don't know if it's difficult to implement, but that would help preventing accidental deletions.
I've seen it a couple of times so far, but not that often. Having said that, we haven't been actively patrolling recentchanges in a while. I'd personally like some kind of resolution pre-IP rollout, because even if it's relatively rare we're throwing sheer numbers at every bug.
Oliver and others watching this bug, what's your sense from reviewing changes how often this (accidental deletion of hidden templates) is currently occurring in practice? Knowing this (even if it's anecdata) would help setting priority for this bug.
How about this: If the cursor is before or straight after a template, pop the 'puzzle' indicator into view.

You could make it float above the current line, with a droplet (as a sort of cursor) downward pointing at the position where there is a template that is invisible or floating. When you click the icon, move the cursor to be on 'template', blue highlighting the template content if it is not hidden (this will help direct the users eye from cursor position to content) and directly open the template editor.
Even with non-hidden, but floating templates it can be confusing. To quote a user:

http://en.wikipedia.org/w/index.php?title=Peach_Springs_Trading_Post&oldid=563257259

I place the cursor to the left of the line that begins "The Peach Springs Trad....", just after the malformed comment, then press backspace, in the hopes of starting to delete said malformed content, the entire infobox disappears.  This is quite startling.

Perhaps a warning is required for the short term ? "Are you sure you want to delete template... ?"
I have no idea if there /is/ a standard. A good illustration is https://en.wikipedia.org/w/index.php?title=Template:Persondata&action=edit
btw What's the standard of "hidden templates". Are templates generating <div style="display:none;">something</div> hidden, or what about <div class="hidden">something</div> when [[MediaWiki:Common.css]] contains .hidden{display:none;} ?
A side-effect of this is that it's impossible to maintain good formatting (keep a blank line between metadata and article text, for example) because the content does not exist from an editor's perspective.
Template:Clear is also a good example of this. Although it doesn't even display as a carriage return. You can insert the template, and then it complete disappears.
Especially important for newly inserted ones, as at the moment we have no idea what they are going to be so we just assume inline.

--------------------------
**Version**: unspecified
**Severity**: enhancement
Change 288813 merged by jenkins-bot:
[BREAKING CHANGE] Evalute block/inline state when inserting a transclusion node

[[https://gerrit.wikimedia.org/r/288813]]
Change 288813 had a related patch set uploaded (by Esanders):
[BREAKING CHANGE] Evalute block/inline state when inserting a transclusion node

[[https://gerrit.wikimedia.org/r/288813]]
*** Bug 72045 has been marked as a duplicate of this bug. ***
Inez talked to me about this long-standing problem today. He worked on a solution that involves waiting for the preview to come back before inserting the template, displaying a spinner in the meantime. His code is at https://github.com/Wikia/app/pull/4932/files . It looks a bit rough and it only deals with insertion, but I think the general approach could work out pretty well. If nothing else, it could be a stop-gap until we have collaborative editing and having a transclusion reevaluate its type asynchronously would not be a big deal.
*** Bug 52032 has been marked as a duplicate of this bug. ***
(In reply to comment #5)
> Parsoid says they now have a public wt2html API that we can use instead of
> action=parse. That would at least allow use to let Parsoid determine whether
> it
> is inline or block (instead of sniffing the html result, though that's fairly
> trivial, just <span> vs. everything else, right? Maybe a few other inline
> elements nodes that we use, or do we wrap them all?)
> 
> However we still need to then find a way to swap the data model node instance
> in that case. (..)

From ve.dm.MWTransclusionBlockNode to ve.dm.MWTransclusionInlineNode or visa versa.
Parsoid says they now have a public wt2html API that we can use instead of action=parse. That would at least allow use to let Parsoid determine whether it is inline or block (instead of sniffing the html result, though that's fairly trivial, just <span> vs. everything else, right? Maybe a few other inline elements nodes that we use, or do we wrap them all?)

However we still need to then find a way to swap the data model node instance in that case. Having 1 datamodel type would be nice indeed. We could make it similar to extension tags in that templates have their own class, but it wouldn't be specific to an element type, we can still swap it dynamically (just like we can change lists from UL to OL).
*** Bug 50610 has been marked as a duplicate of this bug. ***
*** Bug 54893 has been marked as a duplicate of this bug. ***
%%%*** Bug 50363 has been marked as a duplicate of this bug. ***%%%
Possible solution may involve removing distinction between block & inline transclusion types in the DM, replacing with hybrid type, and have CE work out how to render it properly.
Currently in the template dialog when you insert a new template (or other transclusion) it doesn't look up TemplateData for said template (but re-uses if available). It should.

--------------------------
**Version**: unspecified
**Severity**: enhancement
Seems to have been some cache issues, because it seems to be fine now
(In reply to comment #5)
> Testing on beta, which is using 1.22alpha (3c4aac9) the issue seems to

This is mediawiki-core. VisualEditor at beta.wmflabs should be currently at f8d2f14 (latest; including merged commit) after Reedy manually updated it (again).
Testing on beta, which is using 1.22alpha (3c4aac9) the issue seems to persist:

First I make a new template instance and file one parameter:
http://i.imgur.com/69K7IcD.png

Notice the lack of information

Next I apply changes, and open the template dialog again, and following is shown:
http://i.imgur.com/hV8rqag.png
Done in the above commit.
Change 71132 merged by jenkins-bot:
Use template data for new templates and fix alias bug

https://gerrit.wikimedia.org/r/71132
Change 71132 had a related patch set uploaded by Trevor Parscal:
Use template data for new templates

https://gerrit.wikimedia.org/r/71132
Any movement on this? I note the milestone was yesterday's deploy (if it went out but got reverted with the wmf7 problems, ignore me).
Screenshot

See associated screenshot.

--------------------------
**Version**: unspecified
**Severity**: normal

**Attached**: {F11694}
Now fixed, I believe.
In the investigation of most round-tripping bugs we need to figure out if VE modified the DOM in unexpected ways or Parsoid had issues in handling an unmodified DOM. 

We need an easy way to display both the original HTML string retrieved by VE and a serialization of the modified HTML the VE sends out, possibly popped up in two textareas on some keybinding for easy copying.

This would at least allow basic manual debugging.

Optionally, as a time saver, it would be nice if you could also output a DOM diff that makes it easy to spot DOM differences. You could probably base this on the Parsoid DOMDiff module. This DOM diff can also be used in sanity checks to automatically detect VE round-trip issues.

--------------------------
**Version**: unspecified
**Severity**: enhancement
To something which describes their function, not form.

--------------------------
**Version**: unspecified
**Severity**: normal
Change 100313 merged by jenkins-bot:
Rename big/small stack to undoStack & newTransactions

https://gerrit.wikimedia.org/r/100313
Change 100313 had a related patch set uploaded by Esanders:
Rename big/small stack to undoStack & newTransactions

https://gerrit.wikimedia.org/r/100313
You really should be able to. I mean, the cursor pointer triggers and everything. Tsk.

(Actually, it's ignoring all clicks that aren't on the buttons, or so it seems.)

--------------------------
**Version**: unspecified
**Severity**: minor
This was fixed in wmf8.
Screenshot

See associated screenshot, from the page https://en.wikipedia.org/wiki/Henkle_v._Gregory

Reproduced in Chrome, Safari and Firefox.

--------------------------
**Version**: unspecified
**Severity**: normal

**Attached**: {F11483}
Not the same issue; user clearly managed to add a linked space after the italics, which is a UX issue we need to fix generally.
I haven't been able to, but then this kind of thing is pretty difficult to duplicate (unless you want me spending 40 minutes basically doing my damnedest to break linking and looking at what happens each time).
This isn't necessarily the same issue. Is it reproduceable?
It seems not - https://en.wikipedia.org/w/index.php?title=List_of_television_series_canceled_after_one_episode&curid=30873088&diff=562679038&oldid=562678963
We fixed this as part of the DM tweaks, I believe.
Deleting leading newline destroys [[File:....]]

Steps to reproduce:

1. Open a page with [[File:...]] as first line

2. VE adds a leading newline into the edit window

3. Delete this leading newline because for experienced editor it looks superfluous

4. Save

Result: [[File:...]] syntax is destroyed, only the caption is left.

--------------------------
**Version**: unspecified
**Severity**: normal
**URL**: https://test.wikipedia.org/w/index.php?title=User:Raymond/image&diff=174494&oldid=174493
Backdating to when I *think* we fixed this.
I cannot reproduce it now. Looks like it got fixed. Therefore, changing the status to resolved-fixed .
Reopen it if you think it still exists.
Deleting the slug a floated item is locked into is "designed" to delete the item, so this is expected behaviour. See bug 43026 for a wider discussion - we need a better UX concept around here, I feel.

However, leaving the caption there is... not meant to happen. Re-purposing.
In VE, new users may use tutorials/wizards which use [[ https://en.wikinews.org/wiki/Help:Creating_and_using_editintro_and_preload_templates | editintro/preload ]] features, which aren't supported by the visual editor yet.
Change 380530 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Api: include preload content when section=new

[[https://gerrit.wikimedia.org/r/380530]]
Change 380530 had a related patch set uploaded (by DLynch; owner: DLynch):
[mediawiki/extensions/VisualEditor@master] Api: include preload content when section=new

[[https://gerrit.wikimedia.org/r/380530]]
Adding the tag per https://www.mediawiki.org/w/index.php?title=Topic:Tys3st4u4fbxis43 .
Just to confirm, now that patch has made its way to the beta cluster, the inputbox button works and gets us this:

{F9677679}
Change 379246 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Hooks: remove preloadtitle from unsupported list

[[https://gerrit.wikimedia.org/r/379246]]
Change 379246 had a related patch set uploaded (by DLynch; owner: DLynch):
[mediawiki/extensions/VisualEditor@master] Hooks: remove preloadtitle from unsupported list

[[https://gerrit.wikimedia.org/r/379246]]
Ah, that's because I didn't remove `preloadtitle` from the `unsupportedEditParams` list.

Note that if you edit the URL to removes just that parameter, it gets the expected result: https://en.wikipedia.beta.wmflabs.org/w/index.php?title=Template_talk:Submit_an_edit_request&action=edit&preload=Template%3ASubmit_an_edit_request%2Fpreload&editintro=Template%3AEdit_protected%2Feditintro&preloadparams%5B%5D=&preloadparams%5B%5D=Template%3ASubmit_an_edit_request&section=new
Ah, that's because I didn't remove `preloadtitle` from the `unsupportedEditParams` list.

Note that if you edit the URL to removes just that parameted, it gets the expected result: https://en.wikipedia.beta.wmflabs.org/w/index.php?title=Template_talk:Submit_an_edit_request&action=edit&preload=Template%3ASubmit_an_edit_request%2Fpreload&editintro=Template%3AEdit_protected%2Feditintro&preloadparams%5B%5D=&preloadparams%5B%5D=Template%3ASubmit_an_edit_request&section=new
What is the best way to test this?

I tried using [[https://en.wikipedia.beta.wmflabs.org/wiki/Template:Submit_an_edit_request|Template:Submit an edit request]] on the beta cluster, which appears to use preloading, but it kicked me straight in to the 2010 editor even though I've got the 2017 editor beta feature enabled. I don't even know where I'd begin to test it in the visual editor.
Change 378343 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Enable preload in VisualEditor

[[https://gerrit.wikimedia.org/r/378343]]
Change 378726 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] DesktopArticleTarget: Support preloadtitle in source mode

[[https://gerrit.wikimedia.org/r/378726]]
Change 378726 had a related patch set uploaded (by DLynch; owner: DLynch):
[mediawiki/extensions/VisualEditor@master] DesktopArticleTarget: Support preloadtitle in source mode

[[https://gerrit.wikimedia.org/r/378726]]
That patch is very much the "better than nothing" version James suggested. It pulls the article, substitutes in the parameters, and then if it's in visual mode it runs it through Parsoid. It should be functionally-equivalent for the 2017 wikitext editor, though, since that doesn't rely on always containing valid documents.
Change 378343 had a related patch set uploaded (by DLynch; owner: DLynch):
[mediawiki/extensions/VisualEditor@master] Enable preload in VisualEditor

[[https://gerrit.wikimedia.org/r/378343]]
This would be very useful for the [[ https://en.wikiversity.org/wiki/Wikidebate | Wikidebate ]] project at Wikiversity.
Change 329796 merged by jenkins-bot:
Add editintro to notices

[[https://gerrit.wikimedia.org/r/329796]]
Change 329796 had a related patch set uploaded (by Esanders):
Add editintro to notices

[[https://gerrit.wikimedia.org/r/329796]]
VisualEditor having preload support for page creation would be nice. Preload is used in article wizards (e.g. [[ https://en.wikipedia.org/wiki/Wikipedia:Article_wizard/Ready_for_submission | en-wp ]], [[ https://ru.wikipedia.org/wiki/Шаблон:Article_wizard/create | ru-wp ]]).
It looks like there are similar problems on Mobile view, which may be of interest to anyone who is relying on preload:  {T126190}
ProofreadPage needs support of the  EditFormPreloadText hook instead of editinfo/preload parameters. Tracked by task T138588
Thomas's suggestion is that if the article is a 404 (non-extant), we sling the contents of `preload` parameter's indicated article's Parsoid blob as the initial version of the article, and if that's not balanced wikitext (and so not the desired HTML) "oh well", at least it's better than nothing. Thoughts?
A note from @tpt that this is pretty important for successful #proofreadpage integration.
These tasks *really* shouldn't have been merged, despite being about 'the same' area of code (one is about important functionality half done through on-wiki hacky JavaScript, the other is about modifying a fundamental user pattern in core to work with VisualEditor); un-merging.
These tasks *really* shouldn't have been merged, despite being about 'the same' extension (one is about important functionality half done through on-wiki hacky JavaScript, the other is about modifying an extension to work with VisualEditor); un0merging.
We've encountered this issue too on a private MediaWiki. 
Would be really great to have this supported - this would make the VE more versatile in some use cases!

Thanks!
nominating this as Q1 blocker, since this is closely tied to the current BLP practices on english wikipedia, a very visible and sensitive part of our policies.
I've merged the above, and copied the details into the description above.
Editintro and preload are parameters supported by the core, but it is "hidden feature", which is exposed natively by InputBox extension (on non native - using external link)
Editintro/preloud are parts of inputbox extension? Or how it is related?
Indeed.
I think editintro/preload would be very useful not just for new users, but for many kinds of repetitive administration tasks/queries for which preloads are now used. Having TemplateData integrated (I guess), users could be presented the fields they have to fill in the visual way, avoiding errors and fully controlling the input.
To reproduce:

1. Open a page with several sections.
2. Scroll to the second section and press the "edit" link near the heading. The Visual Editor opens. Make a change in the text and save the edit.
3. Press the same "edit" link again.

Observed: The source editor opens.

Expected: The visual editor opens.

--------------------------
**Version**: unspecified
**Severity**: minor
*** Bug 50181 has been marked as a duplicate of this bug. ***
Merged. Will go out on Thursday or beforehand if we push.
Related URL: https://gerrit.wikimedia.org/r/70324 (Gerrit Change Idf938c0dc8535c30ce63a05d56abeee210a67380)
As indicated on
[[mw:Thread:VisualEditor/Feedback/source code?]]
the page
https://www.mediawiki.org/wiki/VisualEditor/Feedback
which was protected recently has no "View source" link to see the content of the header. There should be one, pointing to
https://www.mediawiki.org/wiki/VisualEditor/Feedback?action=edit

--------------------------
**Version**: unspecified
**Severity**: normal
Change 68860 merged by jenkins-bot:
Show an edit link for discussion page headers even if the user can't edit it

https://gerrit.wikimedia.org/r/68860
Related URL: https://gerrit.wikimedia.org/r/68860 (Gerrit Change I99c17acea0be7b0ef650959e5e280ca5e9154b2a)
In VE, click the "Reference" toolbar icon. According to the toolbar icons in the "Content" section, it is possible to insert lists, headings and images within the text of a reference.

This is a nonsensical capability. The only required formatting here is bold, italic and wikilink, if that.

--------------------------
**Version**: unspecified
**Severity**: enhancement
**See Also**:
https://bugzilla.wikimedia.org/show_bug.cgi?id=52646
(In reply to comment #3)
> (In reply to comment #2)
> > Maybe we can discourage users from doing these things in some way, but we
> > can't
> > just not support this, as users have to be able to edit these back into a
> > more
> > rational use.
> 
> On enwiki there is never any good reason to have headings or images in
> references. In the 0.000001% of cases where it is actually wanted, it can
> just be done using the wikitext source editor, I think.

The objective of VE is for even power users to never need to enter the wikitext editor. Fixing broken usage would be an example of a use case that we'd want to support.

> However, I can understand that other wikis might want this functionality in
> VE for some reason, so I suppose enwiki could hide the relevant functionality
> via CSS or something like that if you think it would be better.

I was thinking of having such tools hidden under an "advanced tools" collapsed block in the toolbar, but we should properly look at this rather than just commit to the way to do it in a Bugzilla thread. :-) Ideally we'd rather not have individual wikis trying to come up with local-only "solutions" to this.
(In reply to comment #2)
> Maybe we can discourage users from doing these things in some way, but we
> can't
> just not support this, as users have to be able to edit these back into a
> more
> rational use.

On enwiki there is never any good reason to have headings or images in references. In the 0.000001% of cases where it is actually wanted, it can just be done using the wikitext source editor, I think.

However, I can understand that other wikis might want this functionality in VE for some reason, so I suppose enwiki could hide the relevant functionality via CSS or something like that if you think it would be better.
(In reply to comment #1)
> (In reply to comment #0)
> > lists, headings and images
> 
> Sorry, the list functionality has been correctly removed from this view. It
> is only headings and images that need to be hidden.


Regrettably, wikitext does actually pretty much everything inside references except other references (though some, ahem, "enterprising" users have found a way around that intentional limit). Examples:

  https://www.mediawiki.org/wiki/VisualEditor:TestReferenceContents

Maybe we can discourage users from doing these things in some way, but we can't just not support this, as users have to be able to edit these back into a more rational use.

(The reason that these were removed are that you're not allowed lists in image captions; we're clearly going to have to split what things the sub-editors can allow by type. Created that as bug 49657.)
(In reply to comment #0)
> lists, headings and images

Sorry, the list functionality has been correctly removed from this view. It is only headings and images that need to be hidden.
This is to run from 19 June (end on with the Notifications split test, so we don't much their data up).

--------------------------
**Version**: unspecified
**Severity**: enhancement
**URL**: http://thread.gmane.org/gmane.science.linguistics.wikipedia.technical/70737
**See Also**:
https://bugzilla.wikimedia.org/show_bug.cgi?id=49727
https://en.wikipedia.org/w/index.php?title=Humanoid&diff=prev&oldid=561404936
https://en.wikipedia.org/w/index.php?title=2013_CONCACAF_Gold_Cup&diff=561404682&oldid=561374126
https://en.wikipedia.org/w/index.php?title=Minnesota&curid=19590&diff=561394244&oldid=561292962

Dirty diff, HTML comments being stripped, etc.

Will the VisualEditor team be cleaning up these edits?
This is now deployed and will run for a week or so to help advise on whether the main switch should be thrown for all users. Data to be published as we get it.
From <https://en.wikipedia.org/w/index.php?title=Wikipedia:Administrators%27_noticeboard&oldid=560544063#VisualEditor_-_A.2FB_test_launch_on_18_June>:

---
Hey all. We're going to postpone the A/B test for several days; I'll post more details as I get them, but I understand it's largely down to known bugs with the existing software - bugs that you reported, and bugs that were crucial in making a go/no go decision. Thank you to everyone for all your hard work poking at the VE, and for all your reports thus far; it's much appreciated :). Okeyes (WMF) (talk) 19:25, 18 June 2013 (UTC)
---

Thanks to Legoktm for pointing this out to me, otherwise I likely never would've seen it.
I fully agree with MZMcBride :
* I think it's ethically questionable to run experiments on users in this manner
* There are still severe bugs in VisualEditor at this time, so it shouldn't be deployed more widely

And I've more concerns about this kind of experiments :
* There are still a lot of minor/major bugs in VisualEditor at this time, I don't expect new users to have to handle them when discovering Wikipedia edition.
* There are still major limitations on what can be done with VisualEditor (templates, references, ...). What will be the experience for new users if they can only edit some parts of articles ?

I believe this kind of experiment should only be done when VisualEditor is fully functional (when users can do almost every modification they want) and without major bugs left.
(In reply to comment #0)
> This is to run from 19 June (end on with the Notifications split test, so we
> don't much their data up).

June 19 is a few days away. Given some of the recent feedback at [[Wikipedia:VisualEditor/Feedback]] regarding severe bugs in VisualEditor, it doesn't seem like VisualEditor is ready to be deployed more widely.
It seems like auto-opting in a user also requires an auto-opt out mechanism. Otherwise, this is a dramatic departure from user expectations. As I understand it, anonymous users currently get the wikitext editor. Nearly every MediaWiki installation, including the one the user was just using use the standard wikitext editor, so suddenly changing that needs to be done cautiously.

Is there currently an auto-opt mechanism? If not, I consider that a blocker to this bug being resolved.

While I think it's ethically questionable to run experiments on users in this manner, one safeguard is ensuring that it's as easy as possible for users to _escape_ such experiments. Within the VisualEditor interface (and possibly elsewhere in the user interface), there should be one-click "I didn't ask for this" option to disable VisualEditor. In addition to an option on the editor itself, other areas of the site (such as the post-login screen) could be modified. "Welcome to Wikipedia! You've been selected to test our beta software. [opt out]" or similar.
(In reply to comment #2)
> Has en.wikipedia been notified?

This would be good.

From what I can tell, this test only applies to new users, though it's difficult to figure that out based on the current Bugzilla subject text or the related commit. It currently reads as though this will be an A/B on all users, not just new users.
Related URL: https://gerrit.wikimedia.org/r/68846 (Gerrit Change I94d74fd8abeba465f1f9463890541e8c8f786a43)
Has en.wikipedia been notified?
Related URL: https://gerrit.wikimedia.org/r/68845 (Gerrit Change I5c603ece309d61641d32ccc9eff5ea2890d5b816)
The VisualEditor edit tag (Tag: VisualEditor) should show on diffs, too.  This will probably require a core change.  However, I'm filing it here, both so you're aware of it, and because it might need to be configurable (it might be we don't want all tags, such as AbuseFilter, etc. to show on diffs).

--------------------------
**Version**: unspecified
**Severity**: minor
Change 73004 merged by jenkins-bot:
Remove "Tag: " prefix, now that they're in MW core

https://gerrit.wikimedia.org/r/73004
The core change is done in MW master, and will be part of wmf10; as such, marking this as fixed.
Change 72317 merged by jenkins-bot:
Show change tags on diffs

https://gerrit.wikimedia.org/r/72317
(In reply to comment #5)
> Because revision tagging is really incomplete, as I recall, lacking
> the ability to do all the things you might want to do with revision
> tags (like manually adding one, removing an incorrect one, renaming
> one, etc.).

File a bug :) Change I8ace1d47 (now abandoned) attempted to add an API
module for this, it could be used as a starting point.


(In reply to comment #5)
> Matthew also brings up another major point in comment 4.
> Historically revision tags have been added with AbuseFilter filters
> (Andrew G. wrote both the AbuseFilter extension and the core
> revision tagging feature, as I remember it). Consequently, making
> "possible libel" or other similar tags more visible in the user
> interface may not be a great idea until revision tagging is further
> developed.

They are not really *that* visible, they're displayed just like edit
summaries, but without the italics. (Of course wiki admins can make
them show up all uppercase, bold and on neon-yellow background.)
(In reply to comment #3)
> Personally I see no reason to show any tag in history view, but keep it
> hidden on diff view. What would be the use case?

Because revision tagging is really incomplete, as I recall, lacking the ability to do all the things you might want to do with revision tags (like manually adding one, removing an incorrect one, renaming one, etc.).

Matthew also brings up another major point in comment 4. Historically revision tags have been added with AbuseFilter filters (Andrew G. wrote both the AbuseFilter extension and the core revision tagging feature, as I remember it). Consequently, making "possible libel" or other similar tags more visible in the user interface may not be a great idea until revision tagging is further developed.
(In reply to comment #3)
> Personally I see no reason to show any tag in history view, but keep it
> hidden on diff view. What would be the use case?

It might be annoying to have AbuseFilter tags exposed on the diff UI, since they are known to sometimes be inaccurate (like any automatic classification).  When you're looking at the diff, you see the full change, so automatic classifications are less necessary.

However, I think it's reasonable to just show all the tags for now, and revisit if it turns out to be an issue in practice.
(In reply to comment #0)
> because it might need to be configurable (it might be
> we don't want all tags, such as AbuseFilter, etc. to show on diffs).

Personally I see no reason to show any tag in history view, but keep it hidden on diff view. What would be the use case?
Change 72317 had a related patch set uploaded by Matmarex:
Show change tags on diffs

https://gerrit.wikimedia.org/r/72317
Core change request created as bug 49656. Until that's done this is a "later", sadly.
ULS IME not working with Visual Editor fields

--------------------------
**Version**: master
**Severity**: major
**See Also**:
https://bugzilla.wikimedia.org/show_bug.cgi?id=50722
https://bugzilla.wikimedia.org/show_bug.cgi?id=53700
https://bugzilla.wikimedia.org/show_bug.cgi?id=53701
https://wikimedia.mingle.thoughtworks.com/projects/language_engineering/cards/3493
As of https://gerrit.wikimedia.org/r/#/c/264577/ in #jquery.ime this should now be resolved and working for all users, and will be part of the wmf.12 release starting tomorrow.
*** Bug 58662 has been marked as a duplicate of this bug. ***
Please use bugzilla as the single place o make issues known that are relevant for developers. References to lists of issues on wiki pages will not do.
(In reply to comment #13)
@ Santhosh Thottingal  Please have a look at [https://en.wikipedia.org/wiki/Wikipedia:VisualEditor/Feedback#VE_.2B_ULS_unicode_Devnagari_Script_input_issues].I have added a table of known issues today.

Rgds
With https://gerrit.wikimedia.org/r/#/c/79755/ jquery.ime start working in visual editor. The UI is not integrated well with the VE UI. And there are VE specific bugs related to cursor handling and text selection, that are applicable to all IMEs or non latin text.
Hi, 

Thanks for your reply,I know in any case you will be doing your best to make both extensions compatible.What will be likely situation during the time gap,so please let we know if you can think of any easy time gap solution can be made available.Other wise even while ULS is with us, we will be back to square one. 




Warm Regards
It's probably important to manage expectations here.

Tl;dr: it's not realistic to assess that ULS/jQuery.IME input methods will work in VE before the end of July 2013. At this time, no reliable estimate can be made when this is to be expected. Working towards getting this issue resolved has a high priority in the VE and LE teams.

Input methods for many scripts, either natively supported by an operating system, by an application, or by JavaScript, are currently incompatible or at least lead to unexpcted behavior when using VisualEditor.

Possible ways that will allow this to be resolved are currently being explored. I expect that by the end of next week, The VisualEditor and Language Engineering team will have an understanding that will allow them to estimate how much time is needed to make native input possible in most, if not all scripts, when using VE. Once that is done, further exploration is needed to assess the effort needed to make input methods work correctly, including the input methods of ULS/jQuery.IME.

See bug 33077 for more details. In the near future, I expect we will be able to identify issues that need to be resolved before we can work on this issue specifically in the field "depends on".
Hi,

Waiting for this to be available for test,if possible  couple of days before VE to be launched on vernacular wikis which are dependent on ULS. Time table for hi and few other wikis is expected to be 22nd July 2013.


Thanks and Warm Regards
*** Bug 51354 has been marked as a duplicate of this bug. ***
**ansumang** wrote:

Santhosh, I think by changing the summary, we could avoid the duplicates?

(In reply to comment #7)
%%%> *** Bug 50345 has been marked as a duplicate of this bug. ***%%%
*** Bug 50345 has been marked as a duplicate of this bug. ***
Making this a bug instead of a feature, as we would expect the key mappings to work on any input field that is more or less supported for well supported and stable MediaWiki extensions, including VisualEditor.

Set to highest priority. Tracked on Wikimedia Language Engineering team as https://mingle.corp.wikimedia.org/projects/internationalization/cards/3493

If anyone is working on this and expects to be done before 2013-07-07, please let us know and we'll wait. Otherwise, I expect we will have development capacity to take this up and get it delivered by 2013-07-09.
*** Bug 50293 has been marked as a duplicate of this bug. ***
*** Bug 49704 has been marked as a duplicate of this bug. ***
CCing Moriel who's working for GSoC2013 on VisualEditor issues around i18n and in particular RTL; she may have some thoughts. :-)
*** Bug 49643 has been marked as a duplicate of this bug. ***
This is part of a GSOC2013 project and tracked here https://github.com/wikimedia/jquery.ime/issues/136
Need to review and get working so we can ask Parsoid to re-enable these (stop them being wrapped as <mw:Placeholder>s) - bug 47403 comment 3.

--------------------------
**Version**: unspecified
**Severity**: minor
I'm thinking something like:

start loading VE
done loading VE UI
start rendering VE content
done rendering VE content
done loading VE

These would make it easier for other scripts to hook into what is going on. We could use it for instance to add the BLP/disambig editnotice to the actual edit notices on the english wikipedia. https://en.wikipedia.org/wiki/Wikipedia:Editnotice#Edit_intros

--------------------------
**Version**: unspecified
**Severity**: enhancement
We should probably have a proper discussion about events and integration with external tools, rather than doing spike solutions; punting to Trevor to discuss (post-July).
1. Copy some plain text
2. Make a selection in the document up to the end of it (e.g. select all)
3. Paste
4. Exception time!

Problem is in ve.dm.Surface line 376:

rightAnnotations = dataModelData.getAnnotationsFromOffset( right );

with right = -1 (out of bounds)

--------------------------
**Version**: unspecified
**Severity**: normal
Change 131717 had a related patch set uploaded (by Liangent):
LanguageConverter fix of empty and numeric strings

[[https://gerrit.wikimedia.org/r/131717]]
Merged and will go out with wmf8 from Thursday 20 June.
Related URL: https://gerrit.wikimedia.org/r/68629 (Gerrit Change I7497b5195961e46718c7382409a66b7eec1162a9)
It should allow the editor to see the page content while specifying a reference.

--------------------------
**Version**: unspecified
**Severity**: enhancement
**See Also**:
https://bugzilla.wikimedia.org/show_bug.cgi?id=49969
https://bugzilla.wikimedia.org/show_bug.cgi?id=51755
We changed the sizes of dialogs a few months ago.
(In reply to comment #2)
> I think the user needs to be able to see the page text, but the current modal
> window takes too much space in the screen. If it wasn't modal, the user could
> at least drag it to the side to see the text.

Hmm... It seems a dialog can be modal while still being draggable:
http://jqueryui.com/dialog/#modal-confirmation
(In reply to comment #3)
> Compare this with WikiEditor's dialog (which can be moved on the screen, and
> do not forget what the user typed)

and is smaller...
Notice that if I type some text in the window and then close it for a moment, to take a look in the text, it forgets what I typed once I open the window again.

Compare this with WikiEditor's dialog (which can be moved on the screen, and do not forget what the user typed)
I think the user needs to be able to see the page text, but the current modal window takes too much space in the screen. If it wasn't modal, the user could at least drag it to the side to see the text.
(In reply to comment #0)
> It should allow the editor to see the page content while specifying a
> reference.

I'm a bit confused by your title - are you saying that you expect modal items to take up less screen estate? All modal items in VE (dialogs) are the same, standard size.
Right now the z-index for .ve-ui-surface-overlay is set to 1000, which is way higher than pretty much anything else in MediaWiki. This makes it float above lots of things it shouldn't float above, like the header drop-down menu in the visual editor, the Echo notifications dropdown, etc. The z-index for the Echo notifications dropdown is 100 (so that it is higher than the close buttons in SiteNotices which are 99).

--------------------------
**Version**: unspecified
**Severity**: enhancement
(In reply to Alex Monk from comment #6)
> Wasn't this fixed by Gerrit change #70572?

Yes.
Wasn't this fixed by Gerrit change 70572?
Marking as tech-debt and pulling from beta per discussion.
The z-index isn't too high, the reason the overlays are on top of the save dialog is because they are in a further relative subtree of the DOM. Whether it is z-index -999, 0 or 100000 won't matter.

The actual issue described here is bug 49275.

The overlay using z-index is a separate issue that is otherwise harmless. I'd recommend we:
* Mark as invalid (z-index isn't a problem).
* or; Turn this into a technical debt "clean up" reminder to get rid of the z-index (they're no longer needed afaik, because we moved overlays to be a proper relative subtree overlay instead of siblings with higher z-index).
* or; Mark as duplicate of bug 49275.
(In reply to comment #0)
> Right now the z-index for .ve-ui-surface-overlay is set to 1000, which is way
> higher than pretty much anything else in MediaWiki. This makes it float above
> lots of things it shouldn't float above, like the header drop-down menu in
> the
> visual editor, the Echo notifications dropdown, etc. The z-index for the Echo
> notifications dropdown is 100 (so that it is higher than the close buttons in
> SiteNotices which are 99).

Yes, this was deliberate; you may recall the arms race with Echo where you kept breaking VE with your z-index changes for three weeks, hence this setting whilst we waited for Echo to stop changing. :-)

(In reply to comment #2)
> Created attachment 12545 [details]
> Blue overlay
> 
> Is this screenshot related to this bug or another effect/issue?

That's specifically bug 49275, but yes, that is related to this. The "proper" solution to this is putting the entire save dialog in its own iframe (like all the dialogs we've created since the new dialog system was built), but it's too close to deployment to do major changes like that.

**Attached**: {F11114}
Created attachment 12545
Blue overlay

Is this screenshot related to this bug or another effect/issue?

**Attached**: {F11114}
The VisualEditor's save dialog has a z-index of 3, so perhaps you'll want to use something like 2 for ve-ui-surface-overlay rather than 1000.
Screenshot

An example is https://www.mediawiki.org/wiki/Template:Extension_code_in_wiki which can be seen at https://www.mediawiki.org/wiki/Extension:Syntax_Highlighting

If opened in the inspector menu it displays pretty much nothing (screenshot attached) because there aren't any modifiable parameters. It comes off looking like it broke ;p.

It would be good if, instead of displaying the title, the inspector menu could display a slug that reads something like "This template has no editable elements".

--------------------------
**Version**: unspecified
**Severity**: normal

**Attached**: {F11046}
This is already fixed in master, and will go out in wmf8; our apologies for it looking so denuded in that version!
When an editor tried to remove a heading, the following empty h3 tag seems to have been left behind:  <h3 data-parsoid='{"dsr":[4514,4534,3,3]}'></h3>

Serializes to ===<nowiki/>=== and the user complained about it.

From the bug report: /mng/bugs/en.2013-06-10T16:41:02.032Z-Lightning_(software) on parsoid.wmflabs.org

--------------------------
**Version**: unspecified
**Severity**: enhancement
These look like cached code issues. Closing absent further issues.
Found an other one, edit time is about 12 hours after the first example
https://fr.wikipedia.org/w/index.php?title=Nahhalin&diff=prev&oldid=113480458
I checked again on production - including checking on the exactly same section layout on which the bug was reported: 
{F108277}
No other edits with `==<nowiki/>==` for the moment, I will send an other comment if I see one
>>! In T51452#1174343, @NicoV wrote:
> It doesn't seem to be fixed in 1.25wmf23.
> Edit from 17 hours ago on frwiki (Version page reports 1.25wmf23) with the same kind of problems :
> https://fr.wikipedia.org/w/index.php?title=Tour_d%27Alg%C3%A9rie_1952&diff=prev&oldid=113472247

Yesterday's deployment happened late, so maybe this happened just before or just after the deployment and the user's browser was still running the old code? I tried to create an empty heading or a whitespace-only heading in VE on frwiki and I couldn't. Are there any other edits adding `==<nowiki/>==` that are more recent?
It doesn't seem to be fixed in 1.25wmf23.
Edit from 17 hours ago on frwiki (Version page reports 1.25wmf23) with the same kind of problems :
https://fr.wikipedia.org/w/index.php?title=Tour_d%27Alg%C3%A9rie_1952&diff=prev&oldid=113472247
Deleting headings is clean now

Beta {F103264}
vs
current production(wmf22)
{F103266}
Change 162310 merged by jenkins-bot:
For empty / whitespace-only headings, output <p> instead of <h#>

[[https://gerrit.wikimedia.org/r/162310]]
Change 162310 had a related patch set uploaded (by Jforrester):
MWHeading: Don't put self in output if contents are blank or whitespace

[[https://gerrit.wikimedia.org/r/162310]]

#patch-for-review
*** Bug 70368 has been marked as a duplicate of this bug. ***
Change 162310 had a related patch set uploaded by Jforrester:
MWHeading: Don't put self in output if contents are blank or whitespace

https://gerrit.wikimedia.org/r/162310
/mnt/bugs/2013-06-10T13:57:10.670Z-%25E8%25A5%25BF%25E7%2593%259C%25E6%25B3%25A2 (chinese wikipedia) has an empty heading tag left behind as well (probably inserted when the user added a heading and then deleted it).
/mnt/bugs/2013-06-09T22%3A08%3A31.223Z-Sapo-comum (ptwiki) reports an empty heading left behind "== ==" when the user actually meant to delete it (and I presume thought it gone after the non-whitespace text was deleted).
modules/ve/test/index-phantomjs-tmp.html is not deleted if the tests fail.

--------------------------
**Version**: unspecified
**Severity**: trivial
Related URL: https://gerrit.wikimedia.org/r/68631 (Gerrit Change I5079d00a63d43276a12dd78c306bb3819470631d)
I think it is standard in in (all?) Wikipedias to add a newline before adding a new heading.

This is currently not done by the VisualEditor, see URL.

--------------------------
**Version**: unspecified
**Severity**: enhancement
**URL**: https://de.wikipedia.org/w/index.php?title=Benutzer:Raymond/heading&diff=119444892&oldid=119444326
Roan - I guess we could do this at our end, or as a "default whitespace" rule in Parsoid. Which do you think makes most sense?
Steps to reproduce:

1. Go into a heading

2. Change heading level from 2 to 3 (i.e.)

Expected output: Only the number of = should change

Actual output: Number of = is changed correctly but the newline before the heading is moved under the heading now.

--------------------------
**Version**: unspecified
**Severity**: enhancement
**URL**: https://de.wikipedia.org/w/index.php?title=Benutzer:Raymond/heading&diff=119444161&oldid=119444142
Fix deployed.
https://gerrit.wikimedia.org/r/70214 (Gerrit Change Id8e5b87602e3ba0f0e1cf6b5c6e03f4949e7d053) | change APPROVED and MERGED [by jenkins-bot]
Related URL: https://gerrit.wikimedia.org/r/70214 (Gerrit Change Id8e5b87602e3ba0f0e1cf6b5c6e03f4949e7d053)
(In reply to comment #3)
> I believe they have a default whitespace setting that could fix this so this
> could be raised as a Parsoid bug.

Marking as such.
On a separate note, the standard spacing around headings (on en.wiki at least) appears to be:

Foo

==Bar==
Baz

Where Parsoid renders:

Foo
==Bar==
Baz

I believe they have a default whitespace setting that could fix this so this could be raised as a Parsoid bug.
Replacing a heading is the same a removing the old one and inserting a new one (transactionally speaking), so all the (non visible) whitespace information will be lost.

The output on the right is what you'd get if you created the document from scratch and as you are making structural changes, rather than changes within a paragraph, it is arguably by design that we throw away any old quirks in the wikitext for that section.
Indeed; a newline above or below a heading will be trimmed when the heading is changed in some manner. Is this Parsoid's behaviour?

https://www.mediawiki.org/w/index.php?title=VisualEditor:Bug_49428&diff=715815&oldid=715814
Instead of "Foo v" you get "Foo
v" - dialog contents render before they're styled because the CSS is slow in coming in (per Roan).

--------------------------
**Version**: unspecified
**Severity**: normal
The code to which this refers has been since adjusted, and I think this is now long-fixed.
Per Timo:

| Most likely cause of meta dialog's flash of unstyled content:
|
| ve.ui.Dialog.js:
|   "ve.ui.Dialog.static.addLocalStylesheets( [ 've.ui.Dialog.css' ] );"
So there are two somewhat separate (but possibly connected issues) here. One is that, when you load the category dialog on a cold cache (try incognito window) in Chrome, the dialog contents are displayed before they're styled. I can reproduce this on mw.org but not on localhost, presumably because localhost delivers the CSS really fast.

The rendering bug that James is talking about, with the arrow appearing on the next line, only happens in Chrome and only when the flash of unstyled content also happens.

It would be nice if we could block showing the dialog on the CSS loading. The way we load CSS into the dialog iframes should probably be reconsidered anyway.
Some perverse templates such as {{Largethumb}} return a string with several options separated by pipes ("thumb|<number>px"). In the PHP parser those pipes are then picked up by the link regexp, so result in the regular image options.

In our attribute handling we expand attributes separately, so can end up with strings like the above in a single attribute value. In [[:de:Portal:Thüringen]] for example that is the case for the href attribute, which then caused a crash after retrieving image properties.

We will likely need to handle expanded attributes containing a pipe properly by re-parsing their string representation. This will be difficult to map onto our current template-affected attribute handling.

--------------------------
**Version**: unspecified
**Severity**: normal
The current name of this ticket "Images: Handle templated image options containing pipes" suggests that handling templated image options or image options without pipes would work. They don't. Consider renaming to "Images: Handle templated image options".

On nl.wp largethumb=="260px|thumb". Creating a single option template like large=="260px" would change [[file.foo.jpg|{{largethumb}}]] into [[file.foo.jpg|{{large}}|thumb]]. The first isn't editable in VE. The latter isn't editable in VE either, though the template contains only  a single attribute, and does not contain pipes.
As stated in T51400#579910, Parsoid has implemented solution 1 which has been live in production since February 2014. This prevents largethumb images from being edited in VisualEditor and also ensures that those images roundtrip correctly.

If {T88040} is resolved, we could potentially unblock the editing support for these images -- to be investigated.  Other possibilities for dealing with largethumb have been discussed in comments above (T51400#579925, T51400#1071119). In addition, as far as I know, VE does not yet support editing of templated-affected attributes. So, that editing support would have to be added to VE before these images with template-generated attributes can be edited.

So, TL:DR; is that the status quo seems fine for enabling VE, i.e .this task should no longer be a blocker. It prevents editing of these largethumb-marked images in VE, but it shouldn't corrupt those pages either, nor should it block editing of other parts of the page.
Nothing to be here for this quarter .. So, I am removing the VE Q3 blocker part.
The solution to this bug is probably something like "largethumb" in core or T90914.  But we could also create a {{largethumb2|File:Foo.jpg|some|options|caption}} template which expanded to a complete <figure> tag; that would allow pages which use {{largethumb2}} to be edited in VE.  Ideally we'd use something like wikilint to automatically apply the {{largethumb2}} template.
We need to figure out what else to do with it as far as editing goes. As it stands, Parsoid supports rendering and roundtripping for these templates.
All patches merged; resetting bug status
This problem exists because nl.wp wants two thumb sizes. Why not add 'largethumb' as a core part of syntax? i.e. Has that approach been explored and rejected?
Change 110095 merged by jenkins-bot:
Set up data-mw for all templated image attributes.

https://gerrit.wikimedia.org/r/110095
Change 110095 had a related patch set uploaded by Subramanya Sastry:
WIP: Set up data-mw for all templated image attributes.

https://gerrit.wikimedia.org/r/110095
Change 76821 merged by jenkins-bot:
Add new parserTests for image attributes coming from templates.

https://gerrit.wikimedia.org/r/76821
Change 76821 had a related patch set uploaded by Cscott:
Add new parserTests for image attributes coming from templates.

https://gerrit.wikimedia.org/r/76821
There are two independent issues here, it appears.

1. Image attributes that are template-affected are not properly marked up during parse and hence doesn't rt back to its original form.  This is an issue independent of {{largethumb}} usage.  Once we fix this, even if the {{largethumb}} template doesn't parse correctly, it will RT correctly. This may be easier to fix.  Will create a separate bug report for it.

[subbu@earth tests] echo '[[File:Telephone exchange 1.svg|thumb|{{echo|261px}}]]' | node parse --wt2wt
[[File:Telephone exchange 1.svg|thumb|261px]]

2. Proper rendering of the image in VE depends on us correctly handling the largethumb template (and other such templated image options containing pipes).
~ 1 in 225 nlwp articles (0.45%) have this bug.  This bug affects the whole page.
Except for eight cases, the parser fails for nl.wp pages at http://parsoid.wmflabs.org:8001/topfails all contain '{{largethumb}}'.
Ugh, I guess we have to get to this sooner than later then and find a reasonable solution.
There are around 110 uses on enwp
https://en.wikipedia.org/w/index.php?title=Special:WhatLinksHere/Template:Largethumb&limit=110
They are all in the article, and most of them are [[491]]-[[635]] (years).  I'm guessing they can be subst'd without much concern, to converted to normal thumbs.

On nlwp, it is way over 5000 uses
https://nl.wikipedia.org/w/index.php?title=Speciaal:VerwijzingenNaarHier/Sjabloon:Largethumb&limit=5000

They are in the pages; not in a template, and nlwp doesnt appear keen to subst: them.  Has anyone proposed that their default thumbnail be set to this value?

only four uses here:
https://nds-nl.wikipedia.org/wiki/Spesiaal:Verwiezingen_naor_disse_pagina/Mal:Largethumb
https://gerrit.wikimedia.org/r/67853 (Gerrit Change Ic7652979ec3d5fa35995aac9362c812ab4ede173) | change APPROVED and MERGED [by jenkins-bot]
Related URL: https://gerrit.wikimedia.org/r/67853 (Gerrit Change Ic7652979ec3d5fa35995aac9362c812ab4ede173)
https://en.wikipedia.org/w/index.php?title=Mavericks_(location)&diff=559262706&oldid=559261658

There are a few issues here:

* the diff presented to the user prior to save didn't include any of these extraneous changes (or I obviously wouldn't have saved the edit);

* there's <nowiki> markup being inserted throughout the page, breaking a number of links; and

* there's spacing normalization being done to template parameters, resulting in an even dirtier diff.

I'm not sure how these issues should be split out or if there are existing bug reports for all three of these issues.

--------------------------
**Version**: unspecified
**Severity**: normal
**URL**: https://en.wikipedia.org/w/index.php?title=Special:RecentChanges&tagfilter=visualeditor
Marking as such.
The <nowiki> tags in Cite transclusions (and other tpl transclusions, if they showed up) should be fixed.  My suggestion is to close this bug now since the VE heading bug is tracked separately, and as for user entering wikitext, well, that could be a feature request for VE alerting the user when (s)he enters wikitext, or maybe a FAQ entry or something. 

In all cases, this bug wont be much useful beyond this point.
MZMcBride: For future reference, only one single bug per report please. Also see https://www.mediawiki.org/wiki/How_to_report_a_bug . I'd normally close such tickets as INVALID and ask the reporter to file separate tickets.
The <nowiki> tags in Cite transclusions in ref tags is a Parsoid bug.  I have that on my radar -- will look into that next possibly.

As for <nowiki> tags in other places, looking at bug reports on parsoid.wmflabs.org, there are three different reasons

* due to the bug in ref-tags I mentioned above

* user entering wikitext in the visual editor (Ex: ==See also==* [[Tomato (company)]] in https://en.wikipedia.org/w/index.php?title=Underworld_(band)&diff=prev&oldid=559255806 based on looking at the HTML sent to Parsoid).  I've seen wikitext entered via VE in a few bug reports -- all such wikitext will be nowiki escaped by Parsoid

* Empty heading left behind in the visual editor (tracked in Bug 49452)
Expansion wtf (warning: large diff):

https://en.wikipedia.org/w/index.php?title=Breast_cancer&diff=558696523&oldid=558695500
(In reply to comment #3)
> Misspelling trap:
> 
> https://en.wikipedia.org/w/index.
> php?title=Pepsi_Next&curid=35519554&diff=559230837&oldid=559223494
That one isn't a serialization or round-tripping bug. The user edited the text of the link, but didn't edit the target.

Arguably, links where the text equals the target should have the target track the text when the user edits them. Or maybe they shouldn't. James?

(In reply to comment #2)
> <Gallery> funkiness:
> 
> https://en.wikipedia.org/w/index.
> php?title=British_Rail_Class_50&curid=1448622&diff=559199747&oldid=558786539
Probably a Parsoid bug due to Gallery being capitalized. CCing Gabriel.

The nowiki issues also look like Parsoid serialization bugs to me.
<nowiki> funkiness:

https://en.wikipedia.org/w/index.php?title=Louis-J%C3%A9r%C3%B4me_Gohier&curid=2785680&diff=558445883&oldid=542944471
Misspelling trap:

https://en.wikipedia.org/w/index.php?title=Pepsi_Next&curid=35519554&diff=559230837&oldid=559223494
<Gallery> funkiness:

https://en.wikipedia.org/w/index.php?title=British_Rail_Class_50&curid=1448622&diff=559199747&oldid=558786539
This bug is probably a wash in terms of being an actionable report, so I'll just use it to log other diffs I'm coming across via <https://en.wikipedia.org/w/index.php?title=Special:RecentChanges&tagfilter=visualeditor>.


<nowiki> corruption:

https://en.wikipedia.org/w/index.php?title=Black_Country_Communion&curid=25818560&diff=559205644&oldid=547680063


<nowiki/> weirdness:

https://en.wikipedia.org/w/index.php?title=Lightning_(software)&diff=prev&oldid=559252596


Possible unintentional HTML comment removal; <nowiki> corruption:

https://en.wikipedia.org/w/index.php?title=Underworld_(band)&diff=prev&oldid=559255806
There are a couple of ways to configure references to display differently:
http://www.mediawiki.org/wiki/Extension:Cite/Cite.php#Set_references_to_use_.5E_and_letters_like_Wikipedia
we should access these so the rendering in edit mode is consistent with the that in read mode.
>>! In T51346#2174472, @Trizek-WMF wrote:
>>>! In T51346#2173928, @Jdforrester-WMF wrote:
>> This requires changes to Common.css (or some other site-level styling script) to change the rendering. However, I'd invite wikis to seriously consider whether they really want to vary from every other wiki's rendering.
> 
> On the reverse order, what prevents you to use the Common.css as it is? I mean, on a WYSIWYG system, you expect to have the same rendering both on reading and editing, which is what has been defined in the Common.css or in website settings.

Because Cite doesn't yet use these styles in read mode (that's {T104927}, which is in fact blocked by doing this). :-)
>>! In T51346#2173928, @Jdforrester-WMF wrote:
> This requires changes to Common.css (or some other site-level styling script) to change the rendering. However, I'd invite wikis to seriously consider whether they really want to vary from every other wiki's rendering.

On the reverse order, what prevents you to use the Common.css as it is? I mean, on a WYSIWYG system, you expect to have the same rendering both on reading and editing, which is what has been defined in the Common.css or in website settings.

Thank you for the fix, by the way.
The change for frwiki to make it look like their current local customisation is roughly: 
``` lang=css
/* French Wikipedia over-ride of styling for <ref>s */
span.mw-ref a::after {
  content: counter(mw-Ref,decimal);
} 
```
This requires changes to Common.css (or some other site-level styling script) to change the rendering. However, I'd invite wikis to seriously consider whether they really want to vary from every other wiki's rendering.
Got a feedback about it during a workshop: on fr.wp, footnotes are labelled as "a, b, c"... in reading mode and "3.0, 3.1, 3.2"... on edit mode. Plus, notes on the text don't have brackets on reading mode and have them on editing mode.
I74d4878 will let us fix this.
I think that this is the same problem:

Footnotes created with the ref group <ref group=lower-alpha> are displayed in the saved page as [a], [b], etc.  If you open them in VisualEditor, they display (while editing) as [lower-alpha 1], [lower-alpha 2], etc. instead of [a], [b], etc.
*** Bug 51453 has been marked as a duplicate of this bug. ***
The language committee and WMF Board have approved the creation of Wikipedia Tuvan.

Language code: tyv
Site URL: tyv.wikipedia.org
Project name: Википедия
Project namespace: Википедия
Project talk namespace: Википедия дугайында сүмелел
Project logo: http://commons.wikimedia.org/wiki/File:Wikipedia-logo-v2-tyv.png
Timezone: Asia/Krasnoyarsk
Language name: Тыва дыл
Enable uploads: yes


Thank you.

--------------------------
**Version**: wmf-deployment
**Severity**: enhancement
**URL**: //meta.wikimedia.org/wiki/Requests_for_new_languages/Wikipedia_Tuvan
(In reply to comment #28)
> (In reply to comment #27)
> > (In reply to comment #26)
> > > RT ticket created for addition of lucene search indexes
> > > https://rt.wikimedia.org/Ticket/Display.html?id=5588
> > 
> > But where's VisualEditor
> 
> Thank you very much for this reminder! I added it here (I think):
> https://gerrit.wikimedia.org/r/#/c/79321/

The VisualEditor can now be enabled in the preferences.
Change 79321 merged by jenkins-bot:
Add tyv.wikipedia to projects with visualeditor

https://gerrit.wikimedia.org/r/79321
Change 79321 had a related patch set uploaded by Amire80:
Add tyv.wikipedia to projects with visualeditor

https://gerrit.wikimedia.org/r/79321
(In reply to comment #27)
> (In reply to comment #26)
> > RT ticket created for addition of lucene search indexes
> > https://rt.wikimedia.org/Ticket/Display.html?id=5588
> 
> But where's VisualEditor

Thank you very much for this reminder! I added it here (I think):
https://gerrit.wikimedia.org/r/#/c/79321/
(In reply to comment #26)
> RT ticket created for addition of lucene search indexes
> https://rt.wikimedia.org/Ticket/Display.html?id=5588

But where's VisualEditor
RT ticket created for addition of lucene search indexes https://rt.wikimedia.org/Ticket/Display.html?id=5588
Done!
Change 68188 merged by jenkins-bot:
(bug 49328) Create Wikipedia in Tyvan language

https://gerrit.wikimedia.org/r/68188
*** Bug 52691 has been marked as a duplicate of this bug. ***
Change 78332 merged by jenkins-bot:
Add tyv to langlist

https://gerrit.wikimedia.org/r/78332
Change 78332 had a related patch set uploaded by Reedy:
Add tyv to langlist

https://gerrit.wikimedia.org/r/78332
It should not be chosen arbitrarily. It is chosen according to what was requested on the Meta request, here <https://meta.wikimedia.org/w/index.php?diff=5529039&oldid=5528970>, by Agilight even.
You do have discussions on the Incubator talk pages of some contributors like Tamara Ustinova and Agilight but there is no discussion of everyone anywhere. If you want the sitename to be different, please stop spamming this bug and convince them to change the request on Meta. If you don't manage to do that, shut up and stop delaying this request.
**polar_bear0901** wrote:

(In reply to comment #15)
> (In reply to comment #14)
> > I have been looking at the discussion page for almost a year to see if 
> > anyone in the local community have provided a localization of the name
> > Wikipedia, but till now they're still working in progress. 
> 
> "Work in progress" and "for almost a year" sounds like a contradiction at
> first, so I'd like to take a look myself.
> 
> > few will realize that it's still editable
> 
> People learn when they get things told. Every article on the wiki is
> temporarily too by that definition, as it might be improved later on.

Well, if the project namespace should be arbitrarily chosen since it's temporarily, why don't we choose it to be Видибилиином?
**polar_bear0901** wrote:

(In reply to comment #16)
> Changing status to PATCH_TO_REVIEW because there actually is a patch on Gerrit
Thank you for your progress!

I'd like to mention that concerning the historical discussion, most user who have Tuvan language ability (such as Agilight and Sborsody) have shown a positive altitude about having a native Tuvan name for Tuvan Wikipedia, while those who considered a native name unnecessary or aspiration are mostly Europeans who can not speak Tuvan language (e.g. Kaganer and Tamara Ustinova; what have been labeled a "community requesting" were an request by Kaganer). 

But I'm *not* critcise them, because they're *naturally* speaking in an European POV and that's totally fine. What I'm requesting is that the Tuvan name of Wikipedia should be decided by the native community, rather than by an edit commited by a editor who have few Tuvan knowledge. So there's *no* community-established name at all.

That's also the reason why I say the "Project namespace:" should be temporarily "Wikipedia" rather than request it to be "Видибилиином".
Changing status to PATCH_TO_REVIEW because there actually is a patch on Gerrit waiting to be reviewed & merged: https://gerrit.wikimedia.org/r/68188

Assigning this bug to Sam because he's the one who's been creating new wikis lately.
(In reply to comment #14)
> I have been looking at the discussion page for almost a year to see if 
> anyone in the local community have provided a localization of the name
> Wikipedia, but till now they're still working in progress. 

"Work in progress" and "for almost a year" sounds like a contradiction at first, so I'd like to take a look myself.

> few will realize that it's still editable

People learn when they get things told. Every article on the wiki is temporarily too by that definition, as it might be improved later on.
**polar_bear0901** wrote:

(In reply to comment #13)
> (In reply to comment #6)
> > (In reply to comment #4)
> > Yes. The community is choosing a name for Tuvan Wikipedia
> 
> Can you please provide a direct link to a *recent* discussion about this
> topic,
> on the wiki?
Could you please first tell me why you want a *recent* discussion? I have been looking at the discussion page for almost a year to see if anyone in the local community have provided a localization of the name Wikipedia, but till now they're still working in progress. 
> 
> > So the information should be **temporarily**
> 
> If it makes you happier to call things "temporarily", all things are
> temporarily up to some point. :) (Configuration settings can always be
> changed
> later.)
Well, what you said is *technically* true, but remember once you establish a namespace Википедия few will realize that it's still editable (just as Ali said many Tuvans are not very good at Internet). What's more, once the term Википедия (which violate Tuvan vowel harmony by the last syllable "я") comes into a real Wikipedia, it will be used by some Tuvans, which makes it harder for the locals to choose a localized name.
(In reply to comment #6)
> (In reply to comment #4)
> Yes. The community is choosing a name for Tuvan Wikipedia

Can you please provide a direct link to a *recent* discussion about this topic, on the wiki?

> So the information should be **temporarily**

If it makes you happier to call things "temporarily", all things are temporarily up to some point. :) (Configuration settings can always be changed later.)
**polar_bear0901** wrote:

(In reply to comment #11)
> That's nonsense. There is apparently no "trying to establish a native name",
> because the discussion from Dec. 2012 fell asleep.
> However, the Википедия name is surely 'established' in a certain way because
> the community(!) requested it to be set as their sitename and used it also on
> the Incubator pages. The community can use any name it wants, regardless of
> whether that is "European" or "native" or not.

That's not. Someone (not the community!) edit the info page/summary page of testwiki when the discussion still didn't go to an end, but this has nothing to do with what you claimed "community requested it". 

So temporarily keep the computer internal name "Wikipedia" is good to our community becouse by doing that the local community can establish a Tuvan name of Wikipedia anytime.
That's nonsense. There is apparently no "trying to establish a native name", because the discussion from Dec. 2012 fell asleep.
However, the Википедия name is surely 'established' in a certain way because the community(!) requested it to be set as their sitename and used it also on the Incubator pages. The community can use any name it wants, regardless of whether that is "European" or "native" or not.
**polar_bear0901** wrote:

(In reply to comment #9)
> Well, apparently polar_bear0901 (whom I do not know) opposes the translation
> of
> "Wikipedia" chosen by the test-community.
> 
> In his comment he refers to this discussion about the name from Dec 2012,
> started by an IP (him?):
> <https://incubator.wikimedia.org/wiki/Talk:Wp/tyv/
> %D0%9A%D0%BE%D0%BB_%D0%B0%D1%80%D1%8B%D0%BD#Localization>.
> There was no conclusion.
> 
> See however https://meta.wikimedia.org/w/index.php?diff=5528227&oldid=5527996
> and https://meta.wikimedia.org/w/index.php?diff=5529039&oldid=5528970 for the
> community requesting the project & ns 4 name Википедия, upon which I based
> comment 0.
> Cf. also this recent "editwarring" on the Main Page:
> <https://incubator.wikimedia.org/w/index.php?title=Wp/tyv/
> %D0%9A%D0%BE%D0%BB_%D0%B0%D1%80%D1%8B%D0%BD&action=history>
> 
> Unless the community itself decides to change the 'established' sitename, I'd
> request the wiki configuration to be carried out as described in comment 0.

But where did you show us an "established" sitename? I.e. did the community establish any site name? I didn't see any "community requesting" because the discussion didn't draw a conclution and the local community are still trying to establish a native name, and we should help them choosing a native name rather than apply an European name for them.
Well, apparently polar_bear0901 (whom I do not know) opposes the translation of "Wikipedia" chosen by the test-community.

In his comment he refers to this discussion about the name from Dec 2012, started by an IP (him?): <https://incubator.wikimedia.org/wiki/Talk:Wp/tyv/%D0%9A%D0%BE%D0%BB_%D0%B0%D1%80%D1%8B%D0%BD#Localization>. There was no conclusion.

See however https://meta.wikimedia.org/w/index.php?diff=5528227&oldid=5527996 and https://meta.wikimedia.org/w/index.php?diff=5529039&oldid=5528970 for the community requesting the project & ns 4 name Википедия, upon which I based comment 0.
Cf. also this recent "editwarring" on the Main Page: <https://incubator.wikimedia.org/w/index.php?title=Wp/tyv/%D0%9A%D0%BE%D0%BB_%D0%B0%D1%80%D1%8B%D0%BD&action=history>

Unless the community itself decides to change the 'established' sitename, I'd request the wiki configuration to be carried out as described in comment 0.
@MF-Warburg: Would you please tell us /what the hell/ is going on here? Your request was totally different from comment 6.
**polar_bear0901** wrote:

(In reply to comment #5)
> Waiting for Reedy to do some on-server magic.

TEMPORARILY import an English name is important in that people will realize that the name is temporarily chosen and they still have rights to decide their localized name.
**polar_bear0901** wrote:

(In reply to comment #4)
> Any problems with this request?

Yes. The community is choosing a name for Tuvan Wikipedia (and someone are afraid whether they're granted the right to have a localised name of Wikipedia - see the talk page of the Main Page). 

So the information should be **temporarily**

Project name: Wikipedia
Project namespace: Wikipedia
Project talk namespace: Wikipedia дугайында сүмелел
Project logo: http://commons.wikimedia.org/wiki/File:Wikipedia-logo-v2-en.png

(I don't want to use the English name even temporarily but at least this may not result in many locals feel they're obliged to borrow the Russian name.)
Waiting for Reedy to do some on-server magic.
Any problems with this request?
Related URL: https://gerrit.wikimedia.org/r/68188 (Gerrit Change I7e9a1193500b7e09a29dab1d833c712db9453422)
Related URL: https://gerrit.wikimedia.org/r/68188 (Gerrit Change I7e9a1193500b7e09a29dab1d833c712db9453422)
[I guess that's more of a site request than a language setup bug? Also changing priority.]
**Author:** `the.anonymouse.wikimedia`

**Description:**
I created a wikilink [https://en.wikipedia.org/w/index.php?title=User:The_Anonymouse/sandbox2&diff=558776770&oldid=548109401] as [[United_States]]. I then tried to use VisualEditor to change the underscore to a space ([[United States]]), but it said that my edit was ignored due to no changes. However, if I actually click the link button and click the United States link suggestion, it works as expected. That is how I eventually accomplished the edit with VisualEditor [https://en.wikipedia.org/w/index.php?title=User:The_Anonymouse/sandbox2&diff=558777422&oldid=558776770].

--------------------------
**Version**: unspecified
**Severity**: trivial
**See Also**:
https://bugzilla.wikimedia.org/show_bug.cgi?id=42140
This got fixed a long time ago; sorry for the slow triage on your report.
Is this a Parsoid issue?

<p><a href="./Main_page" rel="mw:WikiLink" data-parsoid="{&quot;a&quot;:{&quot;href&quot;:&quot;./Main_page&quot;},&quot;sa&quot;:{&quot;href&quot;:&quot;Main_page&quot;},&quot;stx&quot;:&quot;simple&quot;,&quot;dsr&quot;:[0,13,2,2]}">Main page</a></p>

serialises to

[[Main_page]]

whereas

<p><a href="./Main_page" rel="mw:WikiLink">Main page</a></p>

serialises to

[[Main page]]

which is what we want
exemple in video

When I add a picture and it gets behind the toolbar,
This prevents the toolbar from be clicked

--------------------------
**Version**: unspecified
**Severity**: normal

**Attached**: {F11568}
The problem seems to be fixed in the current version. Thank you!
(In reply to comment #0)
> Created attachment 12495 [details]
> exemple in video
> 
> When I add a picture and it gets behind the toolbar,
> This prevents the toolbar from be clicked

Thank you for the video; this is hugely helpful and very clear what's going wrong! Assigning.

**Attached**: {F11568}
Per Ed.

--------------------------
**Version**: unspecified
**Severity**: normal
This was fixed by gerrit 68864; there are some edge cases which we may want to address in future ("three Korean Jamo and then a combining accent would split wrong"), but closing this as done.
Related change: https://gerrit.wikimedia.org/r/#/c/68864/
Arrow shown in top-right, under search bar

The Up-Arrow icon, at the top-right of the "Review your changes" dialog (which cancels the review window) needs a tooltip. 

I suggest: "Cancel review, go back to current edit" or similar.

--------------------------
**Version**: unspecified
**Severity**: enhancement

**Attached**: {F11244}
Yes, this was fixed ages ago. Apologies for not noting and closing then – thanks for the reminder!
All left-arrows (except for the link-dialog?) appear to have been replaced with "X", and all "X"s (plus the link-dialog arrow) have tooltips. 

I think this can be closed-as-fixed, but I will leave it up to the product team in case I missed something that they're tracking with this.
**santosh.cool.reddy** wrote:

"Review your changes" - cancel-arrow needs a tooltip; possibly replace with an "X"?

Look at the attached image,looks like this bug has been already solved. Arrow is replaced by an 'X'.

**Attached**: {F11247}
santosh reddy: I have no idea what you meant by "cleared". This bug report is still open and there is no patch mentioned. In case you meant that the bug is fixed for you, please provide a clear link where you see it fixed. Thanks.
**santosh.cool.reddy** wrote:

I see that this bug has been cleared. Please check the bug and close this bug.
Argh, yes, Kaldari got his comment in before mine. :-)
Also needed in "Save your changes" dialog for up and left arrows.
*** Bug 49983 has been marked as a duplicate of this bug. ***
Someone else commented on this today, and suggested that an [X] might be a better icon than a < or ^.

See http://en.wikipedia.org/wiki/Wikipedia:VisualEditor/Feedback#Link_pop-up for further discussion.
Thanks for the catch!
There's an Identical problem with the "Report a problem" dialog, in two places. 

1) The left-arrow at the left-hand-side needs a tooltip. "Cancel report, go back to Review" or similar.

2) The up-arrow at the top-right needs a different tooltip. "Cancel report, go back to current edit" or similar.

(I'm not sure if you'd prefer this in the same bug, or split into 2 bugs, or even 3 bugs. Please let me know.)
Since MediaWiki allows images that are clearly separated out, we should see if we can use `<figure>` and `<figcaption>`.  These tags are intended for "//some flow content, optionally with a caption, that is self-contained and is typically referenced as a single unit from the main flow of the document.//"

This would particularly make sense for thumb and frame where a caption is already shown.  However, figure can also be used without figcaption, which should simplify implementation.

The main concern is backwards-compatibility with browsers that don't know about these tags. They're new to HTML5 (which is now always on in MediaWiki), but

1. Older IE will not be able to style these elements from CSS
2. Older IE will not be able to select these elements from JavaScript.  This can be worked around by calling `createElement(tagName)` once for each of the relevant tag names.

For issue number 2, I think jQuery's internal `createSafeFragment` already takes care of old IE.  So only the styling issue remains.

--------------------------
See also: {T25932}
Change 196533 abandoned by Umherirrender:
Stop specifying element for thumbinner class

Reason:
See T178932

[[https://gerrit.wikimedia.org/r/196533]]
I'm a little confused why this is in code review. The patch is over a year old and I'm unclear what the current state of this task is - have there been new developments? Has there been a request? I see some recent comments on the ticket from @ssastry:
> No, not to be abandoned. We had an RFC hearing around this, and the block figure image usage had approval, but inline image markup was still to be resolved. Brion and Scott were going to do some follow up around that. Separately, we need to figure out transition plans for when we move to <figure> markup since it will break user scripts, gadgets, etc. So, all those are blockers on getting this merged and deployed.

Seems there is a lot more to work out here before we can help review this task?

(Is someone more in the loop able to refresh the description so it does not date back to the Bugzilla days? :))
I'm a little confused why this is in code review. The patch is over a year old and I'm unclear what the current state of this task is - have there been new developments? Has there been a request? I see some recent comments on the ticket from @ssastry:
> No, not to be abandoned. We had an RFC hearing around this, and the block figure image usage had approval, but inline image markup was still to be resolved. Brion and Scott were going to do some follow up around that. Separately, we need to figure out transition plans for when we move to <figure> markup since it will break user scripts, gadgets, etc. So, all those are blockers on getting this merged and deployed.

Seems there is a lot more to work out here before we can help review this task?
@niedzielski: cool.
@dr0ptp4kt, since this requires the Content Service to point at a local Vagrant instance, a local RESTBase and maybe also a local Parsoid install will be necessary. It'll take me a little while to get that configured. Unless this is urgent, let's see if @bearND can run this test.
@mholloway and @niedzielski, are you able to verify no degradation of user experience with the Mobile Content Service in force with this patch, too? CC @bearND in case this task needs to wait until next week.
Thanks, @niedzielski!
@dr0ptp4kt, a quick follow up on gallery. The gallery images have their own request[0]. I also double checked functionally on a couple devices:

## API 10 master and patch {F3046104} {F3046106}

## API 23 master and patch {F3046116} {F3046118}

For _even more_ thoroughness, here's link preview[1] which uses the same request as the gallery on master and its own request on Gingerbread:

## API 10 master and patch {F3046108} {F3046110}

## API 23 master and patch {F3046120} {F3046122}

[0] https://phabricator.wikimedia.org/diffusion/APAW/browse/master/app/src/main/java/org/wikipedia/page/gallery/GalleryCollectionFetchTask.java
[1] These look trash because I don't have all the extensions installed. The trash looks different on different APIs because the requests[2,3] and extract processing has changed since Gingerbread[4].
[2] http://192.168.1.11:8080/w/api.php?action=query&format=json&titles=Thomas_Jefferson&continue=&prop=extracts%7Cpageimages%7Cpageterms&redirects=true&exchars=512&explaintext=true&piprop=thumbnail%7Cname&pithumbsize=320&wbptterms=description
[3] http://192.168.1.11:8080/w/api.php?action=query&format=json&formatversion=2&prop=extracts%7Cpageimages&redirects=true&exsentences=5&explaintext=true&piprop=thumbnail%7Cname&pithumbsize=320&titles=Thomas_Jefferson
[4] https://phabricator.wikimedia.org/rAPAWd945afc63d8025a2ae1198987f0b8cf95dc74efa#a0928e81
## Results
I877baf403088c716ad8e89752008b7a59b7e466c appears to work properly for the Android app, both master and the old deprecated Gingerbread version. I did not test the PhoneGap version. There are slight padding differences on some APIs but I think they're acceptable.

## Setup
I don't play with a local MW instance enough so please excuse the verbose notes for verification.

I checked out master and made a page with some images. I checked out the patch and made another page with the same content. I can see that the master page has divs and the patch page has figures.

I visited the two pages in the Android app (master and our old deprecated Gingerbread version-- not PhoneGap) on a number of devices.

For posterity, some screen caps:

## API 10 master and patch {F3045482} {F3045480}

## API 19 master and patch {F3045484} {F3045486}

## API 23 master and patch {F3045488} {F3045490}

## Fire master and patch {F3045493} {F3045495}
Change 196532 restored by Cscott:
Use figure and figcaption HTML5 elements in Linker::makeThumbLink2

Reason:
I don't think abandoning this is helpful.  I'll put a -2 on it though to prevent premature commit.

[[https://gerrit.wikimedia.org/r/196532]]
Change 196532 abandoned by Prtksxna:
Use figure and figcaption HTML5 elements in Linker::makeThumbLink2

Reason:
Can be unabandoned whenever we're ready.

[[https://gerrit.wikimedia.org/r/196532]]
I believe @TStarling and the parsing team have agreed on a long-term plan to make the PHP parser output and Parsoid output converge.
>>! In T51097#1157239, @matmarex wrote:
>>>! In T51097#1155608, @Mattflaschen wrote:
>> In what cases would someone need to explicitly use figcaption from wikitext (the main point is for people to use File tags, and the parser to generate them)?
> 
> https://en.wikipedia.org/wiki/Template:Multiple_image and other such templates need to replicate the HTML of the image thumbnails.

I'm not opposing `<figure>` in wikitext per se, but templates don't need it. They just have to look similar. There shouldn't be any styles specific to the figure elements in core. The classname on `<div>` will suffice and result in the same visual appearance and behaviour.

Having said that, such templates shouldn't need to replicate the thumb HTML itself. We need to either support it by implementing the necessary bits in core (or an extension), or decide why it is undesired for some technical or UX reason and discourage its use.
>>! In T51097#1157239, @matmarex wrote:
>>>! In T51097#1155608, @Mattflaschen wrote:
>> In what cases would someone need to explicitly use figcaption from wikitext (the main point is for people to use File tags, and the parser to generate them)?
> 
> https://en.wikipedia.org/wiki/Template:Multiple_image and other such templates need to replicate the HTML of the image thumbnails.

I'm not opposing `<figure>` in wikitext per se, but templates don't need it. They just have to look similar. There shouldn't be any styles specific to the figure elements in core. The classname on `<div>` will suffice and result in the same visual appearance and behaviour.

Having said that, such templates shouldn't need to exist. We need to either support it by implementing the necessary bits in core (or an extension), or decide why it is undesired for some technical or UX reason and discourage its use.
>>! In T51097#1155608, @Mattflaschen wrote:
> In what cases would someone need to explicitly use figcaption from wikitext (the main point is for people to use File tags, and the parser to generate them)?

https://en.wikipedia.org/wiki/Template:Multiple_image and other such templates need to replicate the HTML of the image thumbnails.
>>! In T51097#1147961, @TheDJ wrote:
> # Do we want users to use figcaption/figure from wikitext as well ? (I think this can be assessed at a later point in time).

In what cases would someone need to explicitly use figcaption from wikitext (the main point is for people to use File tags, and the parser to generate them)?
# Should be tested with the other skins.
# It seems CSS or scripts for some people would break: https://en.wikipedia.org/w/index.php?title=Special:Search&limit=20&offset=20&profile=all&search=thumbinner Mostly this is style
# MediaWiki:Gadget-ImageAnnotator.js would break and probably a few more
As Brion said, be sure to validate against TimedMediaHandler, Mobile, WikiEditor and other extensions that depend on the current thumbnail layout.

We will probably want to deploy the CSS changes before the element changes for cache reasons ?

Also we have https://en.wikipedia.org/wiki/Category:Graphics_templates where I have two concerns:
# How many of those templates will be affected
# Do we want users to use figcaption/figure from wikitext as well ? (I think this can be assessed at a later point in time).
Should be fine if the HTML5 shiv works properly.  No JS old IE is minimal per https://phabricator.wikimedia.org/T25932#851388 .  IE 8 ([last version](http://caniuse.com/#feat=html5semantic) not to support this out of the box) is EOL in January 2016 (less than 10 months away!)
Change 196533 had a related patch set uploaded (by Prtksxna):
Stop specifying element for thumbinner class

[[https://gerrit.wikimedia.org/r/196533]]
Change 196532 had a related patch set uploaded (by Prtksxna):
Use figure and figcaption HTML5 elements in Linker::makeThumbLink2

[[https://gerrit.wikimedia.org/r/196532]]
Docs on MDN for these elements:

https://developer.mozilla.org/en-US/docs/Web/HTML/Element/figure

https://developer.mozilla.org/en-US/docs/Web/HTML/Element/figcaption

Core and mobile styles would have to be updated, and likely also some JS tools.

Alternatively, <figure> and <figcaption> could be thrown in around the existing <div>s and <span>s without changing the styles, assuming there's no default styles that override stuff.
Currently a reference list (<references /> in wikitext) complete redraws every time an InternalItemNode is touched by a transaction. This is inefficient because:

* Reference lists can be grouped, so a change to one InternalItemNode may not affect that reference list at all.
* Changes to IternalItemNodes shouldn't change the ordering of the list, or any items not touched by the transaction, so we only need to selectively update the items in the list which have changed.
--------------------------
**Version**: unspecified
**Severity**: enhancement
Done on 2013-06-06.
Related URL: https://gerrit.wikimedia.org/r/67151 (Gerrit Change I98eb9f4979ae8d1dc2fdca4d812feaee28672444)
Even though the edit notices appear above text, they don't appear above overlays, e.g. block phantoms.

http://i.imgur.com/RAOdlIZ.png

--------------------------
**Version**: unspecified
**Severity**: minor
**See Also**:
https://bugzilla.wikimedia.org/show_bug.cgi?id=49361
https://bugzilla.wikimedia.org/show_bug.cgi?id=50096
https://bugzilla.wikimedia.org/show_bug.cgi?id=50545
This has now been fixed by Rob; marking as such. I hope we can deploy this to production soon, possibly tomorrow.
See also bug 49275. The layer the phantoms are added too needs to be put below the layer of toolbar, edit notices and save dialog etc.
I edited https://en.wikipedia.org/w/index.php?title=Eagle_Lake_%28Florida%29&oldid=557775556 which contained a piped link:

[[Eagle Lake, Florida|Eagle Lake]]

I used VisualEditor to change the anchor text to Eagle Lake, Florida.  That means piping is no longer necessary.  However, on the review changes screen, it showed:

'''Eagle Lake''' is an elongated lake in shape located in the northern portion of [[Eagle Lake, Florida|Eagle Lake, Florida]].

(irrelevant parts after omitted).

It should just be:

[[Eagle Lake, Florida]]

--------------------------
**Version**: unspecified
**Severity**: normal
Please note that this will be fixed on en-wp only after the latest version of parsoid is deployed.
https://gerrit.wikimedia.org/r/66880 (Gerrit Change I6abef05522192f667d483b4eb4e05de771496c28) | change APPROVED and MERGED [by jenkins-bot]
Related URL: https://gerrit.wikimedia.org/r/66880 (Gerrit Change I6abef05522192f667d483b4eb4e05de771496c28)
Never mind ... bad test case.  This behavior is correct since the second html snippet corresponds to parse output of "[[Foo|Foo]]" as wikitext input.

The problem seems to be that the serializer doesn't exploit the information that the link target has been modified and that there is a diff-marker on the a-tag.
Bug in LinkHandler in the serializer.  Our html2wt tests are lacking.

[subbu@earth lib] cat /tmp/x
<a rel='mw:WikiLink' href='./Foo' data-parsoid='{"a":{"href":"./Foo"},"sa":{"href":"Foo"},"stx":"simple"}'>Foo</a>
<a rel="mw:WikiLink" href="./Foo" data-parsoid='{"a":{"href":"./Foo"},"sa":{"href":"Foo"},"stx":"piped"}'>Foo</a>
[subbu@earth lib] node parse --html2wt < /tmp/x
[[Foo]]
[[Foo|Foo]]
When attempting to move a page where VisualEditor is enabled (take https://www.mediawiki.org/wiki/Special:MovePage/VisualEditor:Sandbox for an example), the tab "Create source" should be an "Edit source" tab instead.

--------------------------
**Version**: unspecified
**Severity**: minor
**See Also**:
https://bugzilla.wikimedia.org/show_bug.cgi?id=66885
(In reply to Alex Monk from comment #17)
> Is there anything left to do here?

This appears fixed for now (albeit as a hack).
Is there anything left to do here?
Change 82744 merged by jenkins-bot:
Reference core bug 53774 in bug 49000 comment

https://gerrit.wikimedia.org/r/82744
Change 82744 had a related patch set uploaded by Jforrester:
Reference core bug 53774 in bug 49000 comment

https://gerrit.wikimedia.org/r/82744
(In reply to comment #12)
> I think I can still see this?
> http://en.wikipedia.org/wiki/Special:WhatLinksHere/Esempio 
> Thanks.

This is caused by (core) bug 53774 which we will need to fix.
I mean, as the page does not exist, shouldn't that read Create source instead, as in http://en.wikipedia.org/wiki/Esempio ?
I think I can still see this? http://en.wikipedia.org/wiki/Special:WhatLinksHere/Esempio 
Thanks.
Now fixed and deployed.
Change 77165 had a related patch set uploaded by Catrope:
Move edit tab generation into PHP and make it more configurable

https://gerrit.wikimedia.org/r/77165
Change 77253 merged by jenkins-bot:
mw.ViewPageTarget.init: Fix pageExists/isViewPage behaviour

https://gerrit.wikimedia.org/r/77253
Change 77253 had a related patch set uploaded by Esanders:
Fix pageExists/isViewPage behaviour

https://gerrit.wikimedia.org/r/77253
Change 77246 merged by jenkins-bot:
Fix edit links on special pages

https://gerrit.wikimedia.org/r/77246
Change 77246 had a related patch set uploaded by Esanders:
Fix edit links on special pages

https://gerrit.wikimedia.org/r/77246
More importantly, it lets you load VE dynamically, which it shouldn't.
Also show on Special:Whatlinkshere (e.g. https://it.wikipedia.org/wiki/Speciale:PuntanoQui/Wikipedia )
Also shown on Special:Undelete, after the page has been restored.

i.e. "User:John Vandenberg/test has been restored" has tabs: Read | Edit | Create source | View history
Confirmed. It says "Read | Edit | Create source | View history".

https://www.mediawiki.org/wiki/Special:MovePage/Sandbox
--> VisualEditor
On http://www.mediawiki.org/wiki/VisualEditor:Test when clicking on the drop down menu for styles, the title of the page is still visible

http://i.imgur.com/O3OvK3w.png

--------------------------
**Version**: unspecified
**Severity**: normal
*** Bug 49430 has been marked as a duplicate of this bug. ***
Thanks for the bug report; this is now fixed in wmf6 which was released yesterday to MediaWiki.org and will be available everywhere by the end of next week.
Screenshot while editing template with wikitext-generated target

--------------------------
**Version**: unspecified
**Severity**: enhancement

**Attached**: {F11029}
A different icon seems somewhat undiscoverable, but not sure what better way to do this. Possibly call them "Auto: <foo>" rather than just "<foo>"? Making the name italics?
Problem 1:

1. Open [[User:Ssastry]]
2. Select Paragraph 3 completely.
3. Ctrl-X
4. Move to beginning of Paragraph 2.  Hit Enter.
5. Ctrl-V on empty line

The paragraph gets pasted on the same line as Paragraph 3.  

Problem 2:

Steps 1-3 and 5. are identical.  Step 4 is different:
4. Move to end of Paragraph 1, hit enter key,

The paragraph gets pasted *before* paragraph 1.  Additionally, on review-and-save, paragraph 1 is lost.  This is not a Parsoid issue -- the edited HTML is missing the paragraph.

This problem seems specific to Firefox.  Cannot reproduce on Chrome.

--------------------------
**Version**: unspecified
**Severity**: normal
This was fixed in the re-write of copy-and-paste; sorry we didn't update this bug until now.
Firefox 21.0
(In reply to comment #0)
> This problem seems specific to Firefox.  Cannot reproduce on Chrome.

Version info always welcome, in general.
tx push
tx push
tx push
tx push

--------------------------
**Version**: unspecified
**Severity**: enhancement
Image patch (https://gerrit.wikimedia.org/r/#/c/57817/) is missing error handling when the mw API is queried to get information about an image.

Two kind of errors that handleResponse in LinkHandler.js has to deal with:

(1) API error: Given that ApiRequest retries, an api error is an indication that the api may be temporarily down or that something else is wrong.  So, rather than continue, it is better to abort processing and return an error code to the clients so they can handle it however they want (ex: ve might tell the user that the page cannot be edited right now because of api/server issues).  This will require calling the error callback found in env.

(2) Image missing: If the api comes back and tells us that the image is missing, we should handle this similar to how the PHP parser does it for missing images.
- Maybe link to a special page/url that will let VE present an upload handler (check with VE folks as to what this url could be.  PHP parser behavior can be found by editing a page on wikipedia sandbox with a non-existent image)
- Dont add a thumb.
- Add a special rdf type on the image/wrapper tag: mw:Image/Missing maybe?

EDIT: These properties should apply to missing templates as well.

--------------------------
**Version**: unspecified
**Severity**: normal
Change 339689 merged by jenkins-bot:
T50900: Set mw:Error and provide error info in data-mw for ext/tpl

[[https://gerrit.wikimedia.org/r/339689]]
Change 339689 had a related patch set uploaded (by Arlolra):
T50900: Set mw:Error and provide error info in data-mw for ext/tpl

[[https://gerrit.wikimedia.org/r/339689]]
According to comments in ext.core.TemplateHandler.js, the data-mw update was supposed to apply to missing templates as well.  Re-opening and retitling to reflect work remaining, since there are already references in the source code to this bug #.
This has been deployed.
Change 170455 merged by jenkins-bot:
T50900: Add mw:Error   error info to data-mw for missing imgs

[[https://gerrit.wikimedia.org/r/170455]]
Change 170455 had a related patch set uploaded (by Subramanya Sastry):
T50900: Add mw:Error   error info to data-mw for missing imgs

[[https://gerrit.wikimedia.org/r/170455]]

#patch-for-review
Change 170455 had a related patch set uploaded by Subramanya Sastry:
WIP: (Bug 48900) Add mw:Error + error info to data-mw for missing imgs

https://gerrit.wikimedia.org/r/170455
We should tackle this one soon since this blocks Flow from removing data-parsoid from their code. They use data-parsoid for missing images to render links. We currently emit a mw:Placeholder meta for it.
*** Bug 51615 has been marked as a duplicate of this bug. ***
Spec in development at http://www.mediawiki.org/wiki/Parsoid/MediaWiki_DOM_spec#Error_handling
We recently discussed this again. A possible solution might be to mark arbitrary elements as error-affected using an additional mw:Error typeof (or CSS class), plus error information in data-mw.error. This error information can be an object like this:

{
  key: "missing-image",
  msg: "This image did not exist"
}
 
The key can be used to retrieve localized messages. The msg just provides a non-localized fall-back. We could leave that out too if we are concerned about space.

For images, we'd use the standard DOM structure as if the image existed, but point out the error with the typeof and data-mw so that the VE can help the user to fix the issue. Similarly, bots can look for errors and potentially fix them automatically.
*** Bug 51535 has been marked as a duplicate of this bug. ***
*** Bug 50290 has been marked as a duplicate of this bug. ***
Another example from bug 51244 - http://parsoid.wmflabs.org/pt/Usu%C3%A1rio:Helder.wiki/Testes?oldid=36380720
*** Bug 51244 has been marked as a duplicate of this bug. ***
*** Bug 51039 has been marked as a duplicate of this bug. ***
[Parsoid component reorg by merging JS/General and General. See bug 50685 for more information. Filter bugmail on this comment. parsoidreorg20130704]
*** Bug 50035 has been marked as a duplicate of this bug. ***
Before merging Mark's image patch I added very basic error handling that at least round-trips the image in case something goes wrong. This uses a simple mw:Placeholder for now, but we should probably create a generic error RDFa type that lets us report localizable errors while still ensuring round-tripping.

To let editors fix such an issue it might be useful to attach the regular DOM structure to the error wrapper. We'd also need to point out which property needs to be fixed, so that a client like the VisualEditor can provide a useful dialog.
screenshot

Example: https://www.mediawiki.org/wiki/Communication

--------------------------
**Version**: unspecified
**Severity**: major
**URL**: http://www.mediawiki.org/w/api.php?action=query&meta=siteinfo&format=jsonfm&siprop=extensiontags
**See Also**:
https://bugzilla.wikimedia.org/show_bug.cgi?id=50284

**Attached**: {F10855}
Parsoid will now wrap these appropriately with the proper typeof `mw:Extension/translate` and whatnot.

Support for the Translate extension in VE is still needed, but a separate task.
Change 261293 merged by jenkins-bot:
T50891: Register <translate> and <tvar> natively

[[https://gerrit.wikimedia.org/r/261293]]
Change 261293 had a related patch set uploaded (by Arlolra):
T50891: Register <translate> and <tvar> natively

[[https://gerrit.wikimedia.org/r/261293]]
>>! In T50891#1840365, @kaldari wrote:
> Any update on this?

A generic extension registration mechanism in Parsoid is one of our (parsing team) goals for this quarter and once that is done, we should be able to work on specific extensions. As noted in T50891#1002436, I think we can implement a parsoid-native version of this which adds annotations to the DOM that marks trees that need to be translated. VE and other tools can then use this to provide translation support by querying the API to manage translations.

I think we can get the extension part done within the next month or so, but the tools to build on top of that is something for VE and language team to work on.
Any update on this?
Since <translate> is a special extension that hooks into the parser pipeline in a way that is not visible to Parsoid, and also since it doesn't render anything new, but marks DOM fragments for translation, the ideal way to deal with this in the short term (till translation goes with a VE based approach) is to implement a native version of translate in Parsoid (just like Cite and planned Gallery extension).

This native translate will be relatively straightforward and will not do anything special beyond recognizing the <translate> and associated tags and marking up DOM fragments with a special typeof that clients like VE or gadgets or anyone could use to enable translation. In addition, it would also have to register a html2wt handler for serializing it back to wikitext.

This should not be a lot of work -- most of it will be in figuring out if there are any tricky things that the translate extension does. Talking to Niklas, we figured this is not high priority, but something worth tackling over the next 6 months.
I had a chat with Subbu about this. In the short tem (this year) we could add configurable support for <translate> tags in parsoid. That support will preserve the tags and comments when pages are edited with VE. In the long term we will implement support for translatable pages without any kind of markup. Marking those pages for translation would only work with VE and it needs special page translation module in VE.
Kabhi2104 asked on #mediawiki-i18n:
> Nemo_bis:  i had one doubt, what does normal parser tags mean ?

Explained briefly from a non-technical perspective, this means that <translate> is a "tag" for the Translate extension, but the parser "doesn't know" it. A symptom is the absence from [[https://www.mediawiki.org/wiki/Special:Version|the list on Special:Version]].

Concretely, the parser deals with tags in ways that interfere with the Translate syntax, with some consequences identified in T50891#524894. But even in the current situation there are some limitations, especially for the newline, which [[https://meta.wikimedia.org/wiki/Help_talk:List#List-agnostic_markup_insertions|is meaningful for the parser and perhaps shouldn't be required]].

More broadly, one could speculate that most wikitext markup is meant to add or modify the HTML of the resulting page, or properties of the page in the database: while translate tags don't do either and are properties of the wikitext itself.
To be clear: there is nothing wrong with that patch itself, it just doesn't work due to limitations in the parser itself. I cannot continue with this patch/bug until I get help from other people to modify parser/parsoid.
(In reply to Nemo from comment #43)
> (In reply to James Forrester from comment #42)
> > No patch any more. :-(
> 
> Hmm I'm not sure that's what "Can be re-activated if there is outlook on
> getting this in a mergable state" means, PATCH_TO_REVIEW seems a sensible
> way to tag such stale patches in need of TLC.

No. There is no patch to review for merge. There is patch to re-*do*.
(In reply to James Forrester from comment #42)
> No patch any more. :-(

Hmm I'm not sure that's what "Can be re-activated if there is outlook on getting this in a mergable state" means, PATCH_TO_REVIEW seems a sensible way to tag such stale patches in need of TLC.
No patch any more. :-(
Change 91583 abandoned by Siebrand:
Add $wgTranslatePageTranslationUseParserHook

Reason:
Abandoned as there is no progress on this patch set. Can be re-activated if there is outlook on getting this in a mergable state.

https://gerrit.wikimedia.org/r/91583
(In reply to comment #39)
> (In reply to comment #36)
> > Issues I have found:
> > 
> > * [MAJOR] Disabling edit section links does not work for headings inside
> > <translate> tags
> 
> You could try marking your output as HTML according to
> https://www.mediawiki.org/wiki/Manual:
> Tag_extensions#How_can_I_avoid_modification_of_my_extension.27s_HTML_output.
> 3F

This causes (lack of) whitespace issues and breaks all lists.

> I'm not sure whether that suppresses section edit links too, but worth a try
> IMO.

It doesn't.

> 
> > * [NORMAL] Edit section links don't work. Not a regression, but would be nice
> > fix. Above issue make this a bigger issue.
> > * [BLOCKER] Table of contents does not include links
> 
> Can you check whether your headings are matched by the formatHeadings regexp?

I'm assuming it processes the html I'm returning, which is:
<h2><span class="mw-headline" id="Culture">Culture</span><mw:editsection page="Pupu" section="1">Culture</mw:editsection></h2>

Not sure whether that matches or not.

> 
> Ideally we'd move both TOC and section edit links to JS / CSS. That is our
> plan
> for Parsoid output, but not going to happen over night.

Any changes for interim solutions?
(In reply to comment #36)
> Issues I have found:
> 
> * [MAJOR] Disabling edit section links does not work for headings inside
> <translate> tags

You could try marking your output as HTML according to https://www.mediawiki.org/wiki/Manual:Tag_extensions#How_can_I_avoid_modification_of_my_extension.27s_HTML_output.3F

I'm not sure whether that suppresses section edit links too, but worth a try IMO.

> * [NORMAL] Edit section links don't work. Not a regression, but would be nice
> fix. Above issue make this a bigger issue.
> * [BLOCKER] Table of contents does not include links

Can you check whether your headings are matched by the formatHeadings regexp?

Ideally we'd move both TOC and section edit links to JS / CSS. That is our plan for Parsoid output, but not going to happen over night.
Editing translatable pages via API seems to work now.
Also, please test the patch if you can to see if you find any other changes in behavior.
Issues I have found:

* [MAJOR] Disabling edit section links does not work for headings inside <translate> tags
* [NORMAL] Edit section links don't work. Not a regression, but would be nice fix. Above issue make this a bigger issue.
* [BLOCKER] Table of contents does not include links
* [MINOR] White space trimming behavior has changed. The original logic cannot be implemented with information provided for the parser hook. You can see the buildup at bottom of http://dev.translatewiki.net/wiki/Extension:Translate compare with http://www.mediawiki.org/wiki/Help:Extension:Translate . This is annoying and would be nice to fix, but the workaround is to edit page source. Documentation about whitespace before has to be update if this way is chosen.

Please help me solve the remaining issues.
Change 91583 had a related patch set uploaded by Nikerabbit:
Add $wgTranslatePageTranslationUseParserHook

https://gerrit.wikimedia.org/r/91583
Trying the parser hook solution now. I have code like:

		$parser->setHook( 'translate', function ( $input, $params, $parser, $frame ) {
			$re = '~<tvar\|([^>]+)>(.*?)</>~u';
			$output = preg_replace( $re, '\2', $input );

			$output = $parser->recursiveTagParse( $output, $frame );
			$output = trim( $output );
			return $output;
		} );

This seems to work okay on simple text, with the exception of section edit links.

I'm still trying with more complex pages with templates as well extensions and our tutorial.
**gmaruzz** wrote:

bump
Niklas: So, here is what I found:

https://meta.wikimedia.org/w/api.php?action=parse&text=<translate>foo</translate> works and does not crash.

https://meta.wikimedia.org/w/api.php?action=parse&text=<translate><!--T:1-->foo</translate> throws the exception.

I am a bit baffled why the comment in the extension content should change what hook is called. I'll let you investigate from here. It might be worth using this opportunity to use a regular extension hook (rather than the ParserBeforeStrip hook), if that might work for you.
Niklas: To me, it looks like an existing bug got exposed. Can you provide more details? Maybe full url of the API call? And/or, if you hop onto #mediawiki-parsoid, we could investigate.
I just found out that if edit is made via API, the ParserBeforeStrip hook I am using does not get called and the exception is shown. Does anybody have an idea why?
To summarize:

* We currently work around the missing tag hook API by calling the full action=parse pipeline for each extension tag. This is quite expensive as you can imagine.
* This lets the translate hack work for now. At least it won't crash.
* The translate extension will crash once we actually call the registered tag hook.

So there is some time to fix this up, but we should not pretend that it is fixed right now.

Can you provide more information on what stops you from using the actual tag hook?
Okay, we tested and all is good for now. You can ignore #c27 :-). 

As I indicated in #c26, this is a problem for when we start updating Parsoid code to call extensions directly rather than go through the full parse pipeline (which was meant to be a temporary hack while we figured out how to call extensions directly).
Actually, now that I wrote that, I might have misspoken about whether it will work now as well. Niklas is right. For <translate> and <tvar> tags found in top-level pages, since we never go through PHP parser at all, this may still not work. 

Parsoid will recognize the hooks because of the registration. In turn, it will call the PHP parser to translate the extension content, which in turn may callback into the translate extension rather than the ParserBeforeStrip callback (which is what <translate> and <tvar> relies on), and that will bomb.

One of us (Gabriel or me) will experiment with the updated code locally and update this bug.
The patch will work with Parsoid right now, because Parsoid always goes through the PHP parser when dealing with extensions and tag hooks. But, there are plans for Parsoid to bypass the PHP parser and call the extensions/hooks directly.

Right now, The translate code preprocesses the page by stripping the <translate> and <tvar> tags before the PHP parser actually parses the page source (by registering for ParserBeforeStrip hook). So, even though the tag hooks are registered (with a callback that bombs if called), the PHP parser never gets to calling them.

If Parsoid is able to mimic the behavior (by calling all hooks, not just extension callback hooks), the existing code will continue to work. However, if Parsoid only supports tag extensions directly, then, the ParserBeforeStrip code won't be invoked by Parsoid at that time and this will be a problem at that point.

So, this is not an issue *right now*, but could be at a later point depending on what functionality Parsoid will implement natively and what it will continue to defer to the PHP parser. 

I think Gabriel was responding to that future concern and also hoping that we can use the opportunity of Parsoid's ongoing development to cleanup some of these interfaces and mechanisms. We could streamline extensions to go through narrow interfaces rather than continuing to use all sort of hooks into various points of the parsing timeline. Anything this is something we could discuss more.

Hope this summarizes where we stand now.
Misunderstanding or miscommunication about the actual requirements is not scope creep. The patch which was made does not add value. I changed the title to reflect the issue with my understanding of it.
This issue appears to suffer from scope creep. The requirements of the current summary have been met. See https://translatewiki.net/wiki/Special:Version?uselang=en: Section "Parser extension tags" now shows "<translate> and <tvar>"
That patch won't work well with Parsoid, see the comment in the patch set.
I don't deserve the credit for Niklas's fix. :-)
Change 83427 merged by jenkins-bot:
Register translate and tvar to the parser

https://gerrit.wikimedia.org/r/83427
(In reply to comment #19)
> I think I already did it yesterday.

There is a comment, but now a followup question requires addresssing
I think I already did it yesterday.
(In reply to comment #17)
> Assigning to James, hoping this may get a parsoid person to review the patch
> that's been available for nearly a month now.

Oh. We've been patiently waiting for you to merge it. :-(

Will ping the team.
Assigning to James, hoping this may get a parsoid person to review the patch that's been available for nearly a month now.
fwiw this bug has been mentioned at https://en.wikipedia.org/wiki/Wikipedia:Village_pump_%28technical%29#VisualEditor_weekly_update_-_2013-09-26_.28MW_1.22wmf19.29

I have also seen this problem here and there while editing at mediawiki.org. Then again these tags are not used in most Wikimedia projects or MediaWikis there so fair enough.
(In reply to comment #14)
> In the long term yes, but wont this render VE useless on translatable pages
> in the short them?

Yes. On MW.org you can use the alien node editor to edit any extension node's contents (but they won't be rich), but on other wikis it will make them un-editable in VE.

However, making a Translation extension editor in VE shouldn't be hard at all - I've created that as bug 53974 along the lines of other bugs.
In the long term yes, but wont this render VE useless on translatable pages in the short them?
Niklas: If VE has to support editing for <translate>, <tvar>, etc. tags, Parsoid has to know about those tags. Parsoid finds out about installed tags by querying mediawiki API. So, either MW API should expose this information for hooks automatically or we need a different API endpoint, or you have to register them.
See the above commit. It is not thoroughly tested. I still don't understand what would the benefit.
Change 83427 had a related patch set uploaded by Nikerabbit:
Register translate and tvar to the parser

https://gerrit.wikimedia.org/r/83427
Ping.
Does someone want to try registering them and see what happens? I probably don't have time before Wikimania.
I don't know. Either the registration would just be symbolic without any side effects, or it could also interfere with the current functionality.
@Niklas are there issues with registering them?
*** Bug 52408 has been marked as a duplicate of this bug. ***
Parsoid needs to know if something is a valid extension tag so that it can process them rather than escape them to literal text.  This will also let VE support them in the future and protect them from being modified right now.

Is there any other way to discover that <translate>, <tvar>, <language> are valid tags on the wiki, i.e. what is the mediawiki api endpoint?  So far we've been using siprop and fetching installed extension tags and use that to detect these.
<translate> and <tvar> are not a normal extension tags. Please explain why I should register them.
(In reply to comment #2)
> Parsoid does fetch a list of registered extensions from the config and uses
> that to wrap the block with mw:Object/Extension/<ext-name-here> type. All
> other unknown tags are pass through as plain text.

Ah, my apologies; I thought you were doing this, but it didn't even occur to me that the Translate extension might fail to do this. Re-filing.
Parsoid does fetch a list of registered extensions from the config and uses that to wrap the block with mw:Object/Extension/<ext-name-here> type. All other unknown tags are pass through as plain text.

The problem is that mediawiki does not report <translate> as an installed extension.  Check http://www.mediawiki.org/w/api.php?action=query&meta=siteinfo&format=jsonfm&siprop=extensiontags

Any idea why mw.org is not reporting <translate> as a registered extension?
Yes, the Translate extension needs to be extended to support VisualEditor editing, but the core issue is that Parsoid doesn't recognise <translate> as an extension block; should it take the local list of registered extensions, and for ones it hasn't been told how to deal with just wrap it as a typeof="mw:Object/Unknown" or something similar?
This may introduce a really large number of scopes and have undesirable performance effects, but we need to come up with a solution nonetheless.

--------------------------
**Version**: unspecified
**Severity**: enhancement
Rephrasing bug.

Problems:


* We're repeatedly referencing $/mw from global scope instead of securing the reference. This is worse for performance and for proper functioning (e.g. jQuery might be redefined at a later time causing version mismatches, this is why ResourceLoader maps $) 

* We're using $ and mw directly instead of mapping jQuery and mediaWiki.

* In standalone, our code executes in the global scope. This is bad.

Solution:

* For standalone, build the dist/ files with a closure mapping, securing and caching '$' from 'jQuery'. And for VE modules other than ve.base, it would also map 've' to 'VisualEditor' (bug 67642)

* In MediaWiki, ResourceLoader already provides a closure which we'd extend to also map 've' to 'VisualEditor'.
I suggest for standalone we introduce an module-intro/outro that is used to wrap around individual modules (not per file).

So e.g. dist/ve.core.js would be:

-- intro
( function ( ve, $ ) {
 -- include ve.js
 -- include ve.A.js
 -- include ve.B.js
 -- include ve.C.js
-- outro
}( VisualEditor, jQuery ) );

And in MediaWiki the same would effectively happen but on-demand by ResourceLoader (since we don't want to use a build system for MW, but instead work on the raw source files directly and have them build dynamically).

See bug 48886 for details, but the end result would be:

-- startup:
register(
 ..,
 [ 'ext.visualEditor', 1234, ...., ['VisualEditor']
);

-- mw.loader:
 script( $, global[propKeys..].. );

-- load.php response when loading visualeditor:
mw.loader.implement( 'ext.visualEditor.core', function ( $, ve ) {
 -- include ve.js
 -- include ve.A.js
 -- include ve.B.js
 -- include ve.C.js
} );
For the record, inside ResourceLoader context $ is a local variable provided by the ResourceLoader built-in closure.

See also bug 48886.
If wikitext contains several empty lines in a row, hovering over those lines in the VisualEditor will present them as uneditable elements. Since the VisualEditor is perfectly able to create and remove empty lines, this seems unnecessary.

--------------------------
**Version**: unspecified
**Severity**: normal
This has been fixed (by removing the mwPlaceholder code in Parsoid, now that VisualEditor can handle these). Sorry for not responding before.
In this edit the user only made the "die -> der" change. In addition the </small> was removed by the VisualEditor.

http://de.wikipedia.org/w/index.php?title=Fu%C3%9Fball-Bremen-Liga_2012%2F13&diff=118880158&oldid=118873211

--------------------------
**Version**: unspecified
**Severity**: normal
**See Also**:
T52052
T52050
OK, then it's a different issue. Created a new one for it: #50050.
This is due to the merging of the 2 <b> tags. Currently it fails compare custom attributes like "style" when attempting to merge equal annotation sequences.
Other example: https://www.mediawiki.org/w/index.php?title=Git%2FConversion%2Fpywikipedia&diff=714194&oldid=713893 (not tag removal but tag property removal). The only real edit is at the bottom.
--------------------------
**Version**: unspecified
**Severity**: enhancement
Steps to Reproduce:

1. Go to https://www.mediawiki.org/wiki/API:Alltransclusions
2. Insert a blank line after the first paragraph.
3. Use the Del key (not backspace) to delete that line.

Rather than deleting the line, the first keypress (sometimes) does nothing. And then the second keypress finally gets rid of the newline, but attempting to save the page shows a diff with the newline still added.

--------------------------
**Version**: unspecified
**Severity**: normal
This was fixed in the re-write of deletion handling in CE; sorry for not marking it as such beforehand.
Created attachment 12390
Bug in Firefox 21

The described problem is slight different for me (Firefox 21)

When inserting a new line and then deleting it, the paragraph is swapped with the next one.

Although both paragraphs are still present on the visual editor, the edit diff shows that the first one has been removed.

**Attached**: {F10655}
Now tracked in #VisualEditor-MediaWiki-Links instead.
*** Bug 57716 has been marked as a duplicate of this bug. ***
Turning this into a tracking bug as it's a lot easier to understand that way.
at en.wp Mauro Bieg comments:
"The add-link dialog should have a clear "OK" and "Cancel" button. Right now, you have no obvious way to get rid of it and it is not clear what happens when you click somewhere else (the dialog goes away, but did it save the changes or not?) Also, what does the strange back button (<) to the left do? and are the Link-symbol and "Hyperlink" two buttons or a description or what (nothing happens when I click on them)? The trash symbol is good and does what you'd expect it to: remove the link."
Adam Cuerden comments again on the suggestion to have separate boxes for link target and link title:
"Yes [that would be better], but do make sure it's on the same page. Don't give one dialogue, then a second. Also, if one of the boxes is left blank, it should be auto-completed from the other box. "

For the second part of the comment they mean that if someone gives a link target (e.g. Fish) and doesn't specify any title, produce a link: [[Fish]]
If someone gives a link title (e.g. Hedgehog) but doesn't specify a target, produce the link: [[Hedgehog]].
English Wikipedia user comments that the current behaviour of the input widget is not intuitive at all:

"I clicked the link tool while not focused on any text, to try and add a new link. I got a largely empty box with no instructions, and the next word in the article highlighted within the box.  I fiddled with it a few times, and still don't know if typing in the box A. changes the text of the link. B. allows me to select more words. C. Changes what is linked to, or D. is followed by another, nearly identical box for a secondary function"

To me this is further evidence that we need two boxes: one to enter the link target and one to enter the link display text. The second box would default to the same as the link for internal links and for external links either (ideally) the page title or (less ideally but probably easier) the filename sans extension. 

This would also fix Bug 50945 and Bug 51438 (if the latter is distinct from the former)
(inspector->input widget; inspector is the context menu with buttons to open a dialog or input widget)
Alternately, once a link is selected we could have the link inspector automatically close (re: OK buttons). I'm more of a fan of OK buttons because I think auto-closes are just inviting someone to mis-click and get infuriated at the software for going away and leaving them with the wrong link.
User can enter html tags or provide tag attributes or attribute values that Parsoid (and downstream clients) treat specially.

Ex: #mwt3 for about-ids, or mw:Object/* for typeofs or <template> tags or any of the special attributes/types found on http://www.mediawiki.org/wiki/Parsoid/MediaWiki_DOM_spec

If Parsoid doesn't detect these and escape/handle them somehow, Parsoid will mislead clients like VisualEditor and/or incorrectly serialize them.

--------------------------
**Version**: unspecified
**Severity**: normal
One more thing that would be good to fix:

Currently, the tokenizer unconditionally escapes typeof and about attributes to data-x-typeof and data-x-about. But, if RDFa attrs from wikitext will also get escaped in this manner. Not sure if RDFa is actually used in wikitext, but that support does exist in MW. So, the escaping could be refined to leave alone any typeof and about attrs that wont confuse Parsoid and clients.

Related FIXME comments from the sanitizer (ext.core.Sanitizer.js) from https://gerrit.wikimedia.org/r/#/c/81569/ that I am pasting here:
```
// SSS FIXME: There is a test in mediawiki.environment.js that doles out
// and tests about ids. There are probably some tests in mediawiki.Util.js
// as well. We should move all these kind of tests somewhere else.
----
// Bypass RDFa/whitelisting checks for Parsoid-inserted attrs
// Safe to do since the tokenizer renames about/typeof attrs.
// unconditionally. FIXME: The escaping solution in tokenizer
// maybe aggressive. There is no need to escape typeof strings
// that or about ids that don't resemble Parsoid types/about ids.
```

Any fix made here should also verify that the sanitization code in sanitizeTagAttrs properly strips dangerous values from unescaped typeofs even when Parsoid updates them with parsoid typeofs.

```
Ex: <tag typeof="dangerous-text">..</tag> gets updated by Parsoid parser to <tag typeof="mw:ParsoidTypeof dangerous-text">..</tag> which should then be handled by the sanitizer to yield <tag typeof="mw:ParsoidTypeof">...</tag>
```
One more thing that would be good to fix:

Currently, the tokenizer unconditionally escapes typeof and about attributes to data-x-typeof and data-x-about. But, if RDFa attrs from wikitext will also get escaped in this manner. Not sure if RDFa is actually used in wikitext, but that support does exist in MW. So, the escaping could be refined to leave alone any typeof and about attrs that wont confuse Parsoid and clients.

Related FIXME comments from the sanitizer (ext.core.Sanitizer.js) from https://gerrit.wikimedia.org/r/#/c/81569/ that I am pasting here:

----
// SSS FIXME: There is a test in mediawiki.environment.js that doles out
// and tests about ids. There are probably some tests in mediawiki.Util.js
// as well. We should move all these kind of tests somewhere else.
----
// Bypass RDFa/whitelisting checks for Parsoid-inserted attrs
// Safe to do since the tokenizer renames about/typeof attrs.
// unconditionally. FIXME: The escaping solution in tokenizer
// maybe aggressive. There is no need to escape typeof strings
// that or about ids that don't resemble Parsoid types/about ids.
----

Any fix made here should also verify that the sanitization code in sanitizeTagAttrs properly strips dangerous values from unescaped typeofs even when Parsoid updates them with parsoid typeofs.

Ex: <tag typeof="dangerous-text">..</tag> gets updated by Parsoid parser to <tag typeof="mw:ParsoidTypeof dangerous-text">..</tag> which should then be handled by the sanitizer to yield <tag typeof="mw:ParsoidTypeof">...</tag>
Patch landed as suggested in comment 5. However, Subbu mentioned that, "we still need to deal with complexity that templates bring."

Ex: <div {{echo|about}}="foo">bar</div>
Change 74586 merged by jenkins-bot:
Protect Parsoid-generated attributes.

https://gerrit.wikimedia.org/r/74586
Or we could write a DOM postprocessor stage that was a bit smarter about which RDFa it unwrapped.  ie, it would unwrap the first example from comment 5, but not the final example there, since it would be able to see that there's parsoid RDFa inside the div which would be broken.  Or other options.
If we do go that route, the fixup for rendering would have to be in client-side JS since we may not use different cached content for editing vs rendering -- or so it seems to me at this time without any sense of how user RDFa markup will need to be supported in MW content.
[Discussed this on IRC with subbu]

To support case 3 from comment 1 and 2, rather than *strip* the attributes, I suggest encapsulating them instead.  For example, if the user authors:

<div about="http://dbpedia.org/resource/Albert_Einstein" typeof="foaf:Person">
  <span property="foaf:name">Albert Einstein</span>
  <span property="foaf:givenName">Albert</span>
</div>

..instead of stripping the RDFa, we're just going to rename the attributes, to:

<div data-user-about="http://dbpedia.org/resource/Albert_Einstein" data-user-typeof="foaf:Person">
  <span data-user-property="foaf:name">Albert Einstein</span>
  <span data-user-property="foaf:givenName">Albert</span>
</div>

That ensures that the user content is safe for Parsoid and VE to manipulate.  In the future we can re-enable the RDFa in the output with a DOM post-processing ("render") pass.  For example, the user content:

<div about="http://dbpedia.org/resource/Albert_Einstein" typeof="foaf:Person">
{{Albert Einstein}}
</div>

might have all sorts of Parsoid RDFa markup inside the {{Albert Einstein}} expansion, which the about="http://dbpedia.org/resource/Albert_Einstein" attribute would screw up the context for.  But for rendering to the web, the Parsoid cruft could be elided and the user's RDFa markup unwrapped.
Change 74586 had a related patch set uploaded by Arlolra:
Protect Parsoid-generated attributes.

https://gerrit.wikimedia.org/r/74586
[Parsoid component reorg by merging JS/General and General. See bug 50685 for more information. Filter bugmail on this comment. parsoidreorg20130704]
1) Is not an issue, as prefix is  not allowed in the PHP sanitizer (and not in our sanitizer either).

2) Is something for later. The risk here is mainly crashes during serialization.

3) Should be supported. We only want to protect our own values where necessary. The typeof attribute for example is multi-valued, so we only need to strip mw:-prefixed user-supplied values. The about attribute on the other hand is single-valued, so we need to override user-supplied values unconditionally where necessary.
There are three interconnected issues:
1)
  <span prefix="mw: http://evil.bad">
is valid wikitext, which would create malformed Parsoid DOM.  We should sanitize the wikitext (but that has to happen *before* we create the DOM, since otherwise we can't tell which prefix attributes are good and which are evil.)

2) VE needs to prevent users from authoring content which sets prefix attributes, etc.  Currently it does so, but it would be nice to make Parsoid more robust against malformed DOM, and/or to add layers of protection so that front ends aren't solely responsible for sanitizing user input.

3) Longer term we should probably think about use cases where the user wants to deliberately author RDFa markup on their content, and ensure that they are able to do so in a safe way.

This bug is primarily about #1 (the short term issue) and I'll tackle it tomorrow.
On my user page https://www.mediawiki.org/wiki/User:S_Page_%28WMF%29 and now on a test page https://www.mediawiki.org/wiki/User:S_Page_%28WMF%29/VE_bugs every time I try to add a new section VE goes haywire

1. Edit (with VE)
2. Click at start of first heading ("welcomecreation...")
3. Press Enter, it prepends new heading (good)
4. Press up arrow to move up to this new blank heading.
5. Start typing the heading, e.g. press 'X'
6. That was wrong, so press Backspace (or left arrow)

Result:
The text of the heading underneath leaps above the new heading, joining text above it.
I can edit other parts of the document, but whenever I return to my new heading to add or backspace, the caret jumps elsewhere.
If I undo enough times, VE undoes to a state where the new header displays below the existing header. The document looks different to what it did before, but [Review and save] is grayed out.

I created a new document https://www.mediawiki.org/wiki/User:S_Page_%28WMF%29/VE_bugs and similar stuff happens in that.

This is in Firefox 21 on Ubuntu, and mediawiki.org's VE as of today.

--------------------------
**Version**: unspecified
**Severity**: minor
This should now be fixed; we will push this to production this afternoon.
Change 70864 merged by jenkins-bot:
Don't advance cursor when adding new line at start of node

https://gerrit.wikimedia.org/r/70864
Change 70918 merged by jenkins-bot:
If cursor is obscured by toolbar, on keypress scroll to cursor.

https://gerrit.wikimedia.org/r/70918
Change 70918 had a related patch set uploaded by Robmoen:
If cursor is obscured by toolbar, on keypress scroll to cursor.

https://gerrit.wikimedia.org/r/70918
Change 70864 had a related patch set uploaded by Robmoen:
Don't advance cursor when adding new line at start of node

https://gerrit.wikimedia.org/r/70864
(In reply to comment #5)
> Sounds good, though I note it's different than e.g. pressing Enter at the
> start of the first of a set of bullet points, which adds another bullet rather
> than a plain paragraph. A foolish consistency is the Hobnobs of little minds :)

Yeah, I've been wondering whether to make these consistent for a little bit.
(In reply to comment #4)
> (In reply to comment #3)
> > * If you press Enter with the caret at start of heading, you get a plain
> > paragraph before (maybe OK but not what I'd expect and not how most WYSIWYG
> > editors work)
> 
> This is intentional - if you have header 1\nheader 2\nheader 3\n and click
> before header 3 and press return, you should be able to type content
> (paragraph) by default.

Sounds good, though I note it's different than e.g. pressing Enter at the start of the first of a set of bullet points, which adds another bullet rather than a plain paragraph. A foolish consistency is the Hobnobs of little minds :)
(In reply to comment #3)
> These days the behavior on mediwiki.org (with Firefox 21.0 Ubuntu 13.04) is
> different and a little better.
> * If you press Enter with the caret at start of heading, you get a plain
> paragraph before (maybe OK but not what I'd expect and not how most WYSIWYG
> editors work)

This is intentional - if you have header 1\nheader 2\nheader 3\n and click before header 3 and press return, you should be able to type content (paragraph) by default. WYSIWYG editors often get this wrong, thinking that context is the most important thing, because they don't know what style "normal" content is. We do, and so we should do this right. (Also, VE isn't intending to be a WYSIWYG editor, just a visual one that is more and WYSIWYM editor at times.)

> * The caret moves between the first and second character of the heading
> (definitely wrong).

Yeah, sorry about that; we should get that fixed soon.
These days the behavior on mediwiki.org (with Firefox 21.0 Ubuntu 13.04) is different and a little better.
* If you press Enter with the caret at start of heading, you get a plain paragraph before (maybe OK but not what I'd expect and not how most WYSIWYG editors work)
* The caret moves between the first and second character of the heading (definitely wrong).
But the document doesn't get out of order, your typing always appears at the caret, and what you see is what is saved. Progress!
**brassratgirl** wrote:

I'm getting a similar bug while trying to edit a userpage subpage, with the addition that it's blanking out the existing text. See https://en.wikipedia.org/wiki/User:Phoebe/chopo

1) edit existing text, all is fine. 
2) move cursor below existing paragraph, attempt to type new heading
3) cursor jumps to above existing paragraph, types up there
4) this results in uneditable blank spaces 
5) and, on save, all text below blank spaces is gone. 

My conclusion is that editing user pages is, for whatever reason, totally haywire. I have screenshots if needed. 

Firefox 20.0 on Ubuntu 12.04
In Chromium (25.0.1364.160 Ubuntu 13.04) not logged in, the same step 3 adds blank line above (not styled as a heading) and moves the caret to the second character in the existing heading.
On wikis where certain "topicons" are moved out of the mw-content-text wrapper into the root of #content the VisualEditor toolbar shows a weird blank space.

The icons in question are invisible due to float overlap, but they do push down the toolbar and occupying space to the right of the "Save and review" button thus pushing it and the rest of ve-ui-toolbar-actions to the left.

To reproduce this situation, run the following one or more times:

    $('#content').prepend(
        '<div class="mw-topicon" style="display: block; width: 20px; height: 20px; background: pink; float: right; margin-left: 3px;">x</div>'
    );

--------------------------
**Version**: unspecified
**Severity**: normal
Related URL: https://gerrit.wikimedia.org/r/64989 (Gerrit Change Ic5f73ac1eb8c41b891dd1c67b71795cb6c456141)
Created attachment 12375
What it looks like with clear:both patch applied

The icons become visible again and the actions toolbar (right hand side of the toolbar) is no longer pushed to the left but flush to the right again.

**Attached**: {F10554}
Created attachment 12374
Current misalignment when there are extra elements in #content

Such as the case currently on https://de.wikipedia.org/wiki/Berlin

**Attached**: {F10553}
Created attachment 12373
What the toolbar usually looks like

Note absence of space between the Vector tabs and the toolbar, and the Save button is flush to the right.

**Attached**: {F10552}
If you have some text with an annotation (e.g. bold, italics or a link) and copy in some text, the annotation is closed off, the text is insert as plain text, and then the annotation is restarted.

I think users will expect "paste as current style" over "paste as plain text".

--------------------------
**Version**: unspecified
**Severity**: enhancement
This seems to work as expected these days. I just tried pasting various annotated things into various other things, and everything behaves fine, with the annotations being merged. 

https://en.wikipedia.org/w/index.php?title=User:Matma_Rex/sandbox&diff=773983701&oldid=773982287
{F7268038}

(Although in the meantime I discovered we're //too// good at this, merging some annotations that don't make sense, see {T162278}.)
I definitely expect that text pasted into the middle of a link will still be part of the link.  `[[Link|Li]]HardToType[[Link|nk]]` is never what I want, and if you end up with that, it's hard to repair (unlike a missing or extra bit of bold text).  Since the {T130735} in Safari, then "just (magically know about and remember to) use plain-paste" isn't a viable solution.
*** Bug 69653 has been marked as a duplicate of this bug. ***
Normal paste (rich paste) should preserve the formatting of the pasted content (even if that means plain). Plain text paste should take the formatting of the target.
erm, yes. Sorry.
(In reply to comment #3)
> An editor at the English Wikipedia comments that the ability to copy and
> paste
> a link is " definitely not an [sic] luxury feature but core functionality."
> 
> I am inclined to agree.

That's presumably meant for bug 33105 which is about copying and pasting rich content, rather than this one?
An editor at the English Wikipedia comments that the ability to copy and paste a link is " definitely not an [sic] luxury feature but core functionality."

I am inclined to agree.
LibreOffice uses additive annotations, so pasting italic text into bold text results in bold+italic text. Google drive uses our current functionality.
*** Bug 48159 has been marked as a duplicate of this bug. ***
Whenever you're scrolled down in a document and close or re-open the Notices flyout, the user is brought back to the top of the page (instead of staying where they are, like any other toolbar button would).

The toolbar floats and follows the user as they view the document, it is expected that interacting with it does not change the scroll offset. Most buttons abide by this except for Notices.

--------------------------
**Version**: unspecified
**Severity**: minor
This is now fixed.
The newsletter update states that Visual Editor is now functioning in the content namespaces at MW, which includes the extension: and manual: namespaces (and it does).  That said, the default text for "MediaWiki:Visualeditor-preference-enable" just states user and main at that wiki. I am presuming that this is a WikimediaMessages update somewhere

As a temporary measure I have created [[mw:MediaWiki:Visualeditor-preference-enable]] that mentions the extra two namespace.

As a note the mention of {{MediaWiki:Visualeditor-extensionnamespacepagelink}} and {{MediaWiki:Visualeditor-manualnamespacepagelink}} failed, so I didn't link, and we will need to look to how these extra namespaces are going to be linked, and documented.

--------------------------
**Version**: unspecified
**Severity**: minor
Change 73565 abandoned by Hashar:
(bug 50929) Remove 'visualeditor-enable' from $wgHiddenPrefs

Reason:
A preference to temporarily disable VisualEditor has been introduced in the VisualEditor extension itself : https://gerrit.wikimedia.org/r/#/c/75541/

This change is thus no more needed.

https://gerrit.wikimedia.org/r/73565
Change 73565 had a related patch set uploaded by Helder.wiki:
(bug 50929) Remove 'visualeditor-enable' from $wgHiddenPrefs

https://gerrit.wikimedia.org/r/73565
Then someone opened Bug 50929 - User preference to disable VisualEditor

The related change is  https://gerrit.wikimedia.org/r/#/c/73565/


That effectively would reopen this bug 48666.
(In reply to comment #8)
> my intention was not to offend or attack, it was to draw attention that, to
> the best of my understanding, hiding the user option did not actually address
> the actual bug.

The 'actual' bug was, effectively, that "the temporary description of a temporary configuration option does not automatically expand based on a different configuration variable's setting".

However, the cause for complaint was "the temporary description of a temporary configuration option on MW.org is wrong and confusing", you are correct.

> i think that bug 51411 you created is perfect, and once it's fixed/addressed,
> everything will be fine.

It's exceedingly unlikely to be addressed, because (a) programmatic writing of human-readable descriptions is very delicate and not something we generally do, and (b) as we have said a great many times, this is about a configuration variable that exists purely for the duration of the alpha, to provide a way to "opt in". Availability of VE is a system-level configuration, not a user-level preference. By the time the software is actually marked for release by anyone outside WMF (when we remove the "here be dragons" labels), the underlying issue will be moot.
my intention was not to offend or attack, it was to draw attention that, to the best of my understanding, hiding the user option did not actually address the actual bug.

i think that bug 51411 you created is perfect, and once it's fixed/addressed, everything will be fine.

regarding the rewording of the synopsis: i am aware that it's common practice. actually, quite a few of the bugs i opened myself received this treatment. 
in all the cases i can recall, the rewording was for the better. 
my complain was not about the fact the synopsis was reworded, per se, but rather about the new description, which i do not think is a good one. 


regarding my presumption: i am not sure if i understand your comment about this bug being specific to "mediawiki.org". 
does this mean it's limited to wikimedia projects? if this is what you mean, i do not think you are correct. 
this issue (the original one, that is) pertains to any wiki that uses the mediawiki software with visualeditor (new synopsis and your fix not withstanding).

peace.
(In reply to comment #2)
> Simplest solution to this problem. :-)

an excellent case where "simplest" is very far from "correct" or "best".

in addition to being a bad solution, this change only affects enwiki, while the (original) bug is generic to all projects that install VE (and even non-projects, i.e., "3rd party" wikis).

as a side, together with this wrong and bad solution, James Forrester also changed the synopsis of the bug: from the original ("underlying text for Visual editor in preferences [editing] tab & variable names?"), to "Make VisualEditor a hidden preference", i.e., instead of outlining the problem, the bug synopsis now spells the "solution". 
this is wrong on several levels: it creates the impression that the bug originator (billinghurst) asked to hide the preference, which he didn't, of course, and it hides the actual problem from someone reading this bug - only by digging in the history i was able to make sense of Comment #1, which looks now completely disjoint from the bug synopsis.

wrong or bad solutions to problems is something that can and does happen in every project. that's just life. 
changing the synopsis the way it was changed is not something that can or should happen.

without digging too deeply, i'm going to revert the synopsis to the original one, and reopen - presuming the problem affects more then just enwiki, and also, with the hope that Bug 50929  (basically a request to undo this change) will be fixed soon.

peace.
Now done.
Change 70652 merged by jenkins-bot:
Make 'visualeditor-enable' pref hidden on wikis where VE is default

https://gerrit.wikimedia.org/r/70652
Related URL: https://gerrit.wikimedia.org/r/70652 (Gerrit Change Ica186b9374ddaa0f2f6b2a84e5dff851011b68a4)
Simplest solution to this problem. :-)
(In reply to comment #0)
> The newsletter update states that Visual Editor is now functioning in the
> content namespaces at MW, which includes the extension: and manual:
> namespaces (and it does).  That said, the default text for
> "MediaWiki:Visualeditor-preference-enable" just states user and main at that
> wiki.

It probably shouldn't default to saying only some namespaces and not changing when the wiki config adds it to other namespaces. Moving this bug to the VisualEditor product.
{{foo}} -> Template:Foo
{{:foo}} -> foo
{{:user:Foo}} -> User:Krinkle
{{Template:foo}} -> Template:Foo
etc.

VisualEditor needs the name of the page that ends up being transcluded by the template invocation.

From conversation with Gabriel I gather that currently the entire tranclusion system (at least in production) is deferred to the PHP parser (including the invocation itself). Which means Parsoid is unable to determine it itself right now.

Gabriel suggested Parsoid will provide the name the best it can for simple cases that don't dynamically construct the page name (e.g. not something like:
 {{ {{getTemplateName|x=foo}} | bar }}
).

--------------------------
**Version**: unspecified
**Severity**: normal
https://gerrit.wikimedia.org/r/65622 (Gerrit Change I3b2fbf3b533b14680d2b881ac9fb43218d4f023a) | change APPROVED and MERGED [by jenkins-bot]
Latest proposal that is now pending review and merge (based on discussions on IRC).

All transclusions now have "mw:Transclusion" typeof.

data-mw.target.href will point to the template source page, if the template target is known statically.  Will not be set set if target is templated.

data-mw.target.function will provide the name of the parser-function/magic-word, if the function target is known statically.  Will not be set otherwise.
Related URL: https://gerrit.wikimedia.org/r/65622 (Gerrit Change I3b2fbf3b533b14680d2b881ac9fb43218d4f023a)
Given that transclusion targets can be dynamic ({{ {{echo|lc}}:FOO}} and such), it wont be possible to always provide a statically determined tpl/pf target.  In the general case, the user shouldn't be editing parameters for these dynamic cases without knowing that the tpl. target is specific to the current editing session and arbitrary editing of the parameters might break the transclusion in other scenarios (day-of-week or month-of-year based selection of tpl targets).

So, if we cannot always provide the template or parser function target, it seems we shouldn't add that to the typeof field and leave the typeof as: "mw:Object/Transclusion/Template" or "mw:Object/Transclusion/ParserFunction" and rely on the data-mw.target json property to communicate info about the target (fully resolved url, if static OR html with transclusion wrappers, if templated).
https://en.wikipedia.org/w/api.php?action=query&meta=siteinfo&format=jsonfm&siprop=functionhooks doesn't expose the flag.

We were thinking of replacing mw:Object/Template with mw:Object/Transclusion to make it clear that the object being annotated is a transclusion.  We want to retain a Transclusion type so all transclusions can be recognized for those cases where you dont need to distinguish between types.  But, I suppose we could make this: "mw:Object/Transclusion/Template" or "mw:Object/Tranclusion/ParserFunction".  Right now, the target is not part of this, since this is a type but we are being inconsistent since extensions provide the target name as part of the typeof.  So, we should probably make all those typeofs consistent in some way.

Since this is not necessary for July, let us take a bit more time to work through these (and any other) details rather than make a quick fix.
(In reply to comment #7)
> We were just looking at the wiki config to see if we can recognize something
> as
> a parser function (instead of a template) and ran into trouble:
> 
> * Looks like parser functions usage comes in 2 flavours: (a) with the
> #-prefix:
> ex: {{#if ..}}, etc. (b) without the #-prefix: ex: {{lc:...}}
> * config.functionhooks provides a list of parser functions, but that list
> doesn't distinguish between (a) and (b) above.  So, the functionhooks list
> has
> an entry for "lc" and an entry of "if" (not #if).
> 
This is controlled by the SFH_NO_HASH flag in CoreParserFunctions.php. Is this flag not exposed in config.functionhooks?

> If
> knowing that something is a parser function is essential for VE, then we
> could
> implement this check and maybe add a flag in data-mw or add some other way of
> marking up a parser function.  data-mw.target.isPF = true possibly?
It's not essential for July, but it's required in order to be able to support Wikidata editing. For that purpose, we'd like for parserfunctions to be marked as something like typeof="mw:Object/ParserFunction/#if" , as opposed as a template with a special data-mw bit (we could deal with the latter too, but the former would be much more convenient).
We were just looking at the wiki config to see if we can recognize something as a parser function (instead of a template) and ran into trouble:

* Looks like parser functions usage comes in 2 flavours: (a) with the #-prefix: ex: {{#if ..}}, etc. (b) without the #-prefix: ex: {{lc:...}}
* config.functionhooks provides a list of parser functions, but that list doesn't distinguish between (a) and (b) above.  So, the functionhooks list has an entry for "lc" and an entry of "if" (not #if).

So, ostensibly we could have tested if (a) the name starts with a # in which case it is a parser function; OR (b) the name (lc/if/padleft) is present in config.functionhooks.

But (b) gets us into trouble because you also have templates like "if".  So, {{if...}} ought to be treated as a template and not a parser function.

We could then use an additional check to see if there is a ":" in the name to distinguish between {{lc:foo}} and {{lc|foo}}.

This could work, but seems a bit hacky and maybe fragile wrt edge cases. If knowing that something is a parser function is essential for VE, then we could implement this check and maybe add a flag in data-mw or add some other way of marking up a parser function.  data-mw.target.isPF = true possibly?
This looks sane to me, and won't change much with the url patch. Transclusions are all treated the same in Parsoid. Would you like us to split on the colon and provide a special-case 0th parameter if something looks like a parser function?
(In reply to comment #4)
> We are exposing an 'url' format for static targets now. In a follow-up patch
> we
> plan to make that editable, and remove the 'wt' value for static targets. For
> templated targets we will initially still return 'wt', but in the longer term
> we will expose either 'url' for static targets or 'html' for templated ones.
So while discussing WikiData integration today, we noticed that parser functions aren't recognized very well. {{#property:capital|of=Germany}} returns {'target':{'wt':'#property:captial'}, 'params':{'of':'Germany'}}

Will this by improved in this URL change you're talking about?
We are exposing an 'url' format for static targets now. In a follow-up patch we plan to make that editable, and remove the 'wt' value for static targets. For templated targets we will initially still return 'wt', but in the longer term we will expose either 'url' for static targets or 'html' for templated ones.
https://gerrit.wikimedia.org/r/64987 (Gerrit Change I3145a4168a2347cecc573dcc07bb4128962a5b11) | change APPROVED and MERGED [by jenkins-bot]
Related URL: https://gerrit.wikimedia.org/r/64987 (Gerrit Change I3145a4168a2347cecc573dcc07bb4128962a5b11)
Related URL: https://gerrit.wikimedia.org/r/64651 (Gerrit Change Ie0114a81eead86d7a3b3e3a7a5b10d25c457b524)
Toolbar in VE floats to position of last BranchNode but should instead just use the bottom of the document or something.

--------------------------
**Version**: unspecified
**Severity**: minor
Fix merged and will go out with next push.
Related URL: https://gerrit.wikimedia.org/r/69478 (Gerrit Change I1c7662f2b6f1ced6f80dec16c6ed69a8cc0c06c8)
(In reply to comment #1)
> So the problem is that it lets it go too far or not far enough? I can imagine
> it somehow, but steps to reproduce the bug would nice.

Doesn't got far enough.

Steps to reproduce: find a document with a very long single BranchNode at the end (or create one). Use VE. Notice that the tool bar slips off the page when you get below the bottom.
So the problem is that it lets it go too far or not far enough? I can imagine it somehow, but steps to reproduce the bug would nice.
Complete with its own sub-store and everything, for consumption by a subsurface.

Right now Trevor is committing crimes against humanity to make this work (converting to DOM then back to linmod again)

--------------------------
**Version**: unspecified
**Severity**: enhancement
Provided by gerrit I38d63e31.
ve.dm.Document#cloneSliceFromRange addresses this
Marking this as merged; follow-up in bug 49257.
*** Bug 49233 has been marked as a duplicate of this bug. ***
Ed's main block of code is merged and will go out with wmf5; keeping this open for follow-up, and removing milestone of tomorrow.
To be precise about what should constitute a character, see Grapheme Cluster Boundary Rules from TR29 (http://unicode.org/reports/tr29/) . We probably want to implement these, except insofar as it differs from the browsers' implementations of what constitutes a character for cursoring purposes.

The important thing right now is to abstract the code away from assuming single-codepoint characters, so the structure is correct. Then we can get the splitting rules right in isolation.
Related URL: https://gerrit.wikimedia.org/r/64965 (Gerrit Change I8d936fb15d82f73cd45fac142c540a7950850d55)
(In reply to comment #3)
> Another major issue is that window.getSelection (which is what we use to get
> cursor position, via Rangy) calculates using number of codepoints, not
> characters, so this would need to be translated.

Which would be done in ve.ce.getOffsetFromTextNode
Another major issue is that window.getSelection (which is what we use to get cursor position, via Rangy) calculates using number of codepoints, not characters, so this would need to be translated.
Ideally merging would be done at the transaction level (e.g. in fixupInsertion), although we would need to extend that method to be allowed to modify the remove part of a transaction, e.g.

Data: ['F','o','o']

Transaction:
  Retain: 3
  Replace:
    Remove: ''
    Insert: '<accent>'

Would become:

Transaction:
  Retain: 2
  Replace:
    Remove: 'o'
    Insert: 'o<accent>'
A related question is when invalid UTF-16 is checked and how errors are handled. 

I don't know enough to suggest where in the system the checks should be. But it obviously relates to the parts of ve.dm.Converter and ve.ce.Surface (for paste) which would call this new splitCharacters function. Note that two chunks of invalid UTF-16 can concatenate into one valid but unexpected chunk.
Toolserver has the local table toolserver.wiki on all databases that provides metadata about the wikis including the server the wiki's database is kept on:

```
| mysql> SELECT * FROM toolserver.wiki LIMIT 5;
| +----------------+------+------------+------------------+------+---------+-----------+--------------+--------------+---------------+--------+-------------+
| | dbname         | lang | family     | domain           | size | is_meta | is_closed | is_multilang | is_sensitive | root_category | server | script_path |
| +----------------+------+------------+------------------+------+---------+-----------+--------------+--------------+---------------+--------+-------------+
| | aawikibooks_p  | aa   | wikibooks  | NULL             |    3 |       0 |         1 |            0 |            0 | NULL          |      3 | /w/         |
| | aawiki_p       | aa   | wikipedia  | NULL             |    6 |       0 |         1 |            0 |            0 | NULL          |      3 | /w/         |
| | aawiktionary_p | aa   | wiktionary | NULL             |    1 |       0 |         1 |            0 |            1 | NULL          |      3 | /w/         |
| | abwiki_p       | ab   | wikipedia  | ab.wikipedia.org |  807 |       0 |         0 |            0 |            0 | NULL          |      3 | /w/         |
| | abwiktionary_p | ab   | wiktionary | NULL             |    0 |       0 |         1 |            0 |            1 | NULL          |      3 | /w/         |
| +----------------+------+------------+------------------+------+---------+-----------+--------------+--------------+---------------+--------+-------------+
| 5 rows in set (0.00 sec)

| mysql>
```

Most of the information can probably be extracted from operations/mediawiki-config, but I don't know which sources there are authoritative.

See also: {T50625}
Added a meta_p.legacy view that has the same column name and order as toolserver.wiki for legacy purposes.

Please note that the semantics of the 'server' columns differs and there may be other subtle differences with the toolserver's table not immediately evident.  Unless the same code base has to run on both labs and the toolserver for the interval while it still has replication, transitioning to use meta_p.wiki is preferable.
It would be possible, but probably unhelpful: from what I understand, the server column is numeric whereas I provide actual host names.  Keeping the column named the same with changed semantics seems to be asking for trouble IMO (i.e.: better a select fails than return a string that is misinterpreted as an integer by code with poor error checking).
Would be a problem to rename slice to server, in order to match the column name of toolserver?

The name column looks good to me from a quick look, btw.
I did not want to rely on the existence of bool, which isn't ANSI; mysql "helpfully" translated my numeric(1) to decimal(1,0).
decimal(1,0) ? This seems strange. Shouldn't those is_* and has_* be BOOL aka. TINYINT(1) ?
I've added a table with automatically maintained meta information
about the replicated databases: meta_p.wiki (which is available on every
shard).

+------------------+--------------+------+-----+---------+-------+
| Field            | Type         | Null | Key | Default | Extra |
+------------------+--------------+------+-----+---------+-------+
| dbname           | varchar(32)  | NO   | PRI | NULL    |       |
| lang             | varchar(12)  | NO   |     | en      |       |
| name             | text         | YES  |     | NULL    |       |
| family           | text         | YES  |     | NULL    |       |
| url              | text         | YES  |     | NULL    |       |
| size             | decimal(1,0) | NO   |     | 1       |       |
| slice            | text         | NO   |     | NULL    |       |
| is_closed        | decimal(1,0) | NO   |     | 0       |       |
| has_echo         | decimal(1,0) | NO   |     | 0       |       |
| has_flaggedrevs  | decimal(1,0) | NO   |     | 0       |       |
| has_visualeditor | decimal(1,0) | NO   |     | 0       |       |
| has_wikidata     | decimal(1,0) | NO   |     | 0       |       |
+------------------+--------------+------+-----+---------+-------+

There is a lingering issue with the 'name' column which seems to
improperly encode the Wiki name when non-ascii characters are involved;
that will get fix once I manage to beat some sense into mysql.

Most columns are self-explanatory, and I can add a few more depending on
demand.  In the meantime, (dbname, slice) provides the much requested
mapping between databases and slices.